[Engine-devel] Autorecovery feature plan for review

[Ayal Baron]

----- Original Message -----
> On 02/14/2012 11:36 PM, Yair Zaslavsky wrote:
> > On 02/14/2012 10:03 PM, Itamar Heim wrote:
> >> On 02/14/2012 09:20 AM, Yair Zaslavsky wrote:
> >>> On 02/14/2012 08:59 AM, Itamar Heim wrote:
> >>>> On 02/14/2012 08:57 AM, Livnat Peer wrote:
> >>>>> On 14/02/12 05:56, Itamar Heim wrote:
> >>>>>> On 02/13/2012 12:32 PM, Laszlo Hornyak wrote:
> >>>>>>> Hi,
> >>>>>>>
> >>>>>>> Please review the plan document for autorecovery.
> >>>>>>> http://www.ovirt.org/wiki/Features/Autorecovery
> >>>>>> why would we disable auto recovery by default? it sounds like
> >>>>>> the
> >>>>>> preferred behavior?
> >>>>>>
> >>>>> I think that by default Laszlo meant in the upgrade process to
> >>>>> maintain
> >>>>> current behavior.
> >>>>>
> >>>>> I agree that for new entities the default should be true.
> >>>> i think the only combination which will allow this is for db to
> >>>> default
> >>>> to false and code to default to true for this property?
> >>> Why can't we during upgrade process set to all existing entities
> >>> in DB
> >>> the value to false, but still have the column defined as "default
> >>> true"?
> >> because upgrade and clean install are running the same scripts?
> > I guess I still fail to understand.
> > Scenarios (as both upgrade and clean install run the same scripts)
> > a. In environment to be upgraded we have X entities that are non
> > recoverable - after upgrade these X entities have the boolean flag
> > set
> > to false. New entities in the system will be created with auto
> > recoverable set to true.
> 
> I still fail to understand why you 'punish' existing objects and not
> giving them the new feature enabled by default.

This is not a feature, it's a bug!
This should not be treated as a feature and this should not be configurable!
Today an object moves to non-operational due to state reported by vdsm.  The object should immediately return to up the moment vdsm reports the object as ok (this means that you don't stop monitoring just because there is an error).
That's it. no db field and no nothing...
This pertains to storage domains, network, host status, whatever.

> Y.
> 
> > b. In environment to be clean installed -we have 0 existing
> > entities -
> > after clean install all new entities in the system will be create
> > with
> > auto recoverable set to true.
> > Will this be considered a bad behavior?
> >
> >
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>