[Engine-devel] Development process wiki page

Moti Asayag masayag at redhat.com
Mon Jan 30 08:30:01 UTC 2012


We should add some guideline for the review process as well to ease the
process for the reviewers.

When pushing a newer version of a patch to gerrit we can distinguish
between a patch which was already reviewed to non-reviewed patch:

1. A reviewed patch: the previous patch-set contains reviewer comments,
therefore the expected change should be described there, as part of the
conversation around a specific piece of code (either as a reply or using
the 'Done' button).

2. A new reviewed patch: A general message should be added on the patch
level describing what have changed since previous patch-set.

Thoughts ?

On 01/30/2012 09:45 AM, Oved Ourfalli wrote:
> Hey all,
> 
> I've wrote a wiki page on the oVirt development process.
> It contains mostly information on the patch review process, patch submission and some git guidelines.
> 
> http://www.ovirt.org/wiki/DevProcess
> 
> I added a link to it from the main wiki page.
> 
> Your comments are welcome.
> 
> Thank you,
> Oved
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel




More information about the Engine-devel mailing list