[Engine-devel] Fwd: Checkstyle- Webadmin & userportal localization

[Eyal Edri]

I believe we can add a checkstyle validation job in jenkins for that using checkstyle plugin[1].

[1] https://wiki.jenkins-ci.org/display/JENKINS/Checkstyle+Plugin


It can run on each commit, and soon on each patch sent to gerrit (once we'll boost our Jenkins framework for oVirt).

Eyal.

----- Original Message -----
> From: "Alona Kaplan" <alkaplan at redhat.com>
> To: derez at redhat.com, gchaplik at redhat.com, achub at redhat.com, vszocs at redhat.com, tjelinek at redhat.com
> Cc: engine-devel at ovirt.org
> Sent: Wednesday, May 2, 2012 11:58:12 AM
> Subject: [Engine-devel] Fwd: Checkstyle- Webadmin & userportal localization
> 
> Hi,
> 
> Yesterday some changes were made in oVirt's checkstyle
> (http://gerrit.ovirt.org/#change,3760)
> 
> 1. Renaming built-tools to build-tools-root and separating it into
> two packages:
>   * checksyles- for checkstyle xml files.
>   * ovirt-checkstyle-extension- for adding new (not built-in)
>   checkstyle checks.
> 
> 2. Adding to the checkstyle.xml a new check- NlsCheck, which fails
> the compilation in case non-externalized strings appear in the code.
> 
> [To understand more about the need of this check, see
> http://gerrit.ovirt.org/#change,3612]
> 
> From now on, all strings in the web-admin/user-portal java code
> should be one of the following:
> - Externalized (in case the string should be localized)
> - Have a "//$NON-NLS-N$" comment next to them (in case the string
> shouldn't be externalized, e.g. HashName of a component)
> 
> If there is a non externalized string in a web-admin/user-portal java
> file and
> there is no "//$NON-NLS-N$" comment next to it, mvn compilation will
> fail.
> 
> Note: NlsCheck is currently configured to run only on
> web-admin/user-portal projects.
> If you want NlsCheck check to run on another project, please add the
> following to the configuration of the checkstyle in the project's
> pom file:
> <propertyExpansion>runNlsCheck=true</propertyExpansion>
> 
> 
> Alona.
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>