[Engine-devel] REST-API: Exposing correlation-ID

[Itamar Heim]

On 05/03/2012 05:34 PM, Yaniv Kaul wrote:
> On 05/03/2012 05:24 PM, Ori Liel wrote:
>> Correlation-ID feature allows 'tagging' a call to a Backend command
>> with a String ID, and this ID will be appended to all log messages
>> that result from this command.
>>
>> http://www.ovirt.org/wiki/Features/TaskManagerDetailed
>>
>> In REST-API, we would like to enable the user to pass a correlation-ID
>> when he activates actions.
>
> Makes a more sense to me that the user will get it in the response,
> rather than setting it by himself.
> What's the added value of the user setting it (as opposed to the engine,
> which is already doing it) ?

engine only does it if not passed by user.
user being able to set it allows user to annotate a group of several 
commands under same group/flow/batch-id

> Y.
>
>>
>> I have two questions:
>>
>> 1) what's the name you'd give this parameter? job-id? batch-id?
>> flow-id? command-id? correlation-id???
>>
>> 2) I've already implemented this as a url parameter. Are there
>> objections?
>> The only viable alternative I see is as an http header, which doesn't
>> feel
>> right. It's not an option to pass it in the XML body, because sometimes
>> there is no body, for example, in DELETE commands.
>>
>> Thanks
>>
>> Ori.
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel