[Engine-devel] DiskImage public mapper

[Michael Kublin]

Yep, it is should be id, I aware about these and Ori already asked me to change it, I will change these very soon

----- Original Message -----
From: "Michael Pasternak" <mpastern at redhat.com>
To: "Yair Zaslavsky" <yzaslavs at redhat.com>
Cc: "Michael Kublin" <mkublin at redhat.com>, "engine-devel" <engine-devel at ovirt.org>
Sent: Sunday, May 20, 2012 5:08:22 PM
Subject: Re: DiskImage public mapper

On 05/20/2012 04:55 PM, Michael Kublin wrote:
> both, id - it is a common id for all images that a disk point of them, and ImageId it is a current image 

if so i have doubts about cloning vm from template impl, as parameters class in BackendVmsResource:182
that receives HashMap<Guid, DiskImage> as collection of disks to clone has "current image" id as key,

Yair shouldn't it be /id/ rather than /ImageId/?

> 
> ----- Original Message -----
> From: "Michael Pasternak" <mpastern at redhat.com>
> To: "Michael Kublin" <mkublin at redhat.com>, "Yair Zaslavsky" <yzaslavs at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>
> Sent: Sunday, May 20, 2012 4:57:13 PM
> Subject: DiskImage public mupper
> 
> what should be exposed to user as disk.id: DiskImage.id or DiskImage.ImageId ?


-- 

Michael Pasternak
RedHat, ENG-Virtualization R&D