[Engine-devel] Using 3.1.0 instead of 3.1.0-0001 for next release?

[Saggi Mizrahi]

Comments inline.

----- Original Message -----
> From: "Juan Hernandez" <juan.hernandez at redhat.com>
> To: "Saggi Mizrahi" <smizrahi at redhat.com>
> Cc: engine-devel at ovirt.org
> Sent: Wednesday, May 30, 2012 3:37:06 PM
> Subject: Re: [Engine-devel] Using 3.1.0 instead of 3.1.0-0001 for next release?
> 
> On 05/30/2012 08:44 PM, Saggi Mizrahi wrote:
> > I gave you a +1 as the patch is solid and I agree with the change.
> > Mu question is why have all the versions in all the files instead
> > of using a variable in the configuration and having *.in files?
> > Will make all future changes much easier.
> 
> Using .in files it not a common practice in the java/maven world, and
> it
> would complicate working with the pom.xml files, as most developers
> and
> tools (eclipse, for example) assume that they can be modified
> directly.
This is why I hate IDEs, they think they can just touch everything.
My understanding of maven is amateurish at best but I think you can put ${env.ENGINE_VERSION} variables in POM files and have the make file declare it. You could also have the ${setting.EngineVersion} and declare in settings.xml.
I personally prefer the environment solution because it allows you to declare the version on the fly to properly mark test RPMs, but maybe Eclipse would prefer the settings.xml solution (which could be a ".in" file ;-) ).
> 
> Having a property in the root POM isn't possible either, at it will
> be a
> chicken-egg problem and the resulting POM files stored in the maven
> repositories will be incorrect.
> 
> Unfortunately the only alternative is modifying each POM file with
> each
> release number change. We don't do releases so frequently, so this is
> not a big issue.
> 
> > ----- Original Message -----
> >> From: "Juan Hernandez"<juan.hernandez at redhat.com>
> >> To: engine-devel at ovirt.org
> >> Sent: Wednesday, May 30, 2012 11:49:26 AM
> >> Subject: [Engine-devel] Using 3.1.0 instead of 3.1.0-0001 for next
> >> release?
> >>
> >> Hello,
> >>
> >> I think we have the opportunity now to clean the version number
> >> and
> >> use
> >> 3.1.0 instead of 3.1.0-0001 for the next release. I submitted the
> >> corresponding change to gerrit for review:
> >>
> >> http://gerrit.ovirt.org/4914
> >>
> >> As far as I can tell there are no issues introduced by this change
> >> and
> >> it allows a cleaner versioning schema for the RPM packages.
> >>
> >> Please let me now if you foresee any issue.
> >>
> >> Regards,
> >> Juan Hernandez
> >> _______________________________________________
> >> Engine-devel mailing list
> >> Engine-devel at ovirt.org
> >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> >>
> 
>