[Engine-devel] [Design for 3.2 RFE] Adding support for external events

[Itamar Heim]

On 11/08/2012 05:17 PM, Eli Mesika wrote:
> Hi
>
> Please review , any comments are welcomed (please note that API section is still in TBD)
>
> RFE :https://bugzilla.redhat.com/show_bug.cgi?id=873223
> Requirements : http://wiki.ovirt.org/wiki/Features/ExternalEvents

> Events are classified as NORMAL , WARNING or ERROR and UI will display different icon according to that.
any reason to not allow external ALERTs?

> Detailed Design :http://wiki.ovirt.org/wiki/Features/Design/DetailedExternalEvents

> Adding is_external boolean field to audit_log with a default value of false

hmmm, i'm not sure it makes sense to inject any event, just flagging it 
as external.
why not just add a new AuditLogType of 'External' (i.e., just another 
event id?
it is easy enough to search for it, etc.

> New command is exposed currently only to SuperUser

I assume you mean there is a new permission, which by default is added 
only to superuser role, and admin can add it to other custom roles?
I also assume this is only relevant to admin users, not to user roles?

other questions:
1. worth detailing all fields of the event which could be passed to this.
2. can an admin add events to entities they don't have permissions on 
(I'm guessing yes, since admins aren't filtered from seeing all 
entities, so implicitly, they have permission to all entities)
otherwise (if intent is to limit permisisons), an event is an action on 
multiple entities, so for any field which is passed for the event 
(vm_id, (vds)host_id, etc.), you'd need to check admin has 
'AddExternalEvent' permission on.

the main reason i think doing permissions may hold merit is it will 
allow to give this permission by default in more roles, rather than only 
for superuser, which may make it more viable for UI plugins that would 
try to leverage this.

3. REST API modeling for adding an event (is that a PUT on the event 
collection, a POST)?
can it be done only on root events collection, or on events of entities 
as well (taking the entity id from url, rather than as a parameter), etc.