[Engine-devel] alias in disk instead of name

[Simon Grinberg]

----- Original Message -----
> From: "Michael Pasternak" <mpastern at redhat.com>
> To: "engine-devel" <engine-devel at ovirt.org>
> Sent: Sunday, October 21, 2012 12:26:46 PM
> Subject: [Engine-devel] alias in disk instead of name
> 
> 
> The problem we caused by using alias in disk instead of name is break
> of search-by-name paradigm
> in engine.search dialect, not sure why we do not want forcing disk
> name to be unique [1],
> but lack of "name" in disk search is does not look good in my view.
> 
> thoughts?
> 
> [1] can be easily achieved via appropriate can-do-action
> verification.

Names by definition are not unique IDs, thus it should not be enforced.
What would be the auto naming conversion to ensure uniqueness with plain text?
Would you change these on import/export?
And so on... 

You should treat the name as a tag/alias that if you bothered to update, probably means something to you, if not then you don't care anyhow and will not search by it anyhow. So it's up to the user what to assign.

   

> 
> background:
> ==========
> 
> On 10/15/2012 02:09 PM, Einav Cohen wrote:
> > we didn't exactly renamed "name" to "alias"; "name" is an automatic
> > identifier of the disk, which is: "Disk n", n=internal drive
> > mapping; "alias" is a *user-defined*
> identifier.
> >
> > IIRC, once we understood that we need a user-defined identifier for
> > the disk business entity, we indeed had in mind re-using "name",
> > however, the "name" field in other
> business entities is unique across the system, and we didn't want the
> disk user-defined identifier to be unique, so we preferred to not
> (re)use the term "name" and came up
> with "alias", to avoid confusion.
> >
> > ----- Original Message -----
> >> From: "Michael Pasternak" <mpastern at redhat.com>
> >> To: "Einav Cohen" <ecohen at redhat.com>
> >> Sent: Monday, October 15, 2012 1:58:26 PM
> >> Subject: alias in disk instead of name
> >>
> >> hi,
> >>
> >> can you remind me why did we renamed name to alias in disk?
> >>
> >> --
> >>
> >> Michael Pasternak
> >> RedHat, ENG-Virtualization R&D
> >>
> 
> --
> 
> Michael Pasternak
> RedHat, ENG-Virtualization R&D
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>