[Engine-devel] AsyncTaskManager and the irsbroker

Yair Zaslavsky yzaslavs at redhat.com
Wed Oct 24 09:32:16 UTC 2012


Hi Laszlo,
Sorry for the very late response,
You are correct.
We have inefficient synchronization issues.
For example - I wonder whether we should have AsyncTaskManager instance per data center

Yair


----- Original Message -----
> From: "Laszlo Hornyak" <lhornyak at redhat.com>
> To: "engine-devel" <engine-devel at ovirt.org>
> Sent: Tuesday, September 11, 2012 7:27:34 PM
> Subject: [Engine-devel] AsyncTaskManager and the irsbroker
> 
> hi,
> 
> I have just noticed that AsyncTaskManager is
> - almost all of the public methods are synchronized
> - and it is singleton
> - calling to VDS operations (line 291)
> 
> Therefore this may be a performance bottleneck. Even when you want to
> create an asynchronous task or query a task's state, you may have to
> wait till a remote vdsm responds. Would it be ok to remove the
> synchronization from e.g. the query-like methods? Or the one
> initiating remote calls?
> 
> Laszlo
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 



More information about the Engine-devel mailing list