[Engine-devel] enable column resizing on all sub-tabs?

[Gilad Chaplik]

imo the preliminary patches (separated or not) should be only adding the missing columns widths.
once done, a single patch should activate column re-sizing in a single shot -i.e removing the method (enableColumn...) and enabling the feature.
btw, what is the time in Boston?

Thanks, 
Gilad.

----- Original Message -----
> From: "Einav Cohen" <ecohen at redhat.com>
> To: "Vojtech Szocs" <vszocs at redhat.com>
> Cc: "Daniel Erez" <derez at redhat.com>, "Alona Kaplan" <alkaplan at redhat.com>, "Tal Nisan" <tnisan at redhat.com>,
> gchaplik at redhat.com, "engine-devel" <engine-devel at ovirt.org>
> Sent: Thursday, April 25, 2013 10:30:48 AM
> Subject: enable column resizing on all sub-tabs?
> 
> Vojtech[/others] - what do you think about Gilad's comment below?
> would it be possible / more correct to activate column resizing within the
> base grid class itself by default (or something similar), rather than enable
> it separately for each grid?
> 
> [@Gilad - keep in mind that IIUC - each column in each grid still needs to
> have
> its width explicitly set]
> 
> ----
> Thanks,
> Einav
> 
> ----- Original Message -----
> > From: gchaplik at redhat.com
> > To: "Daniel Erez" <derez at redhat.com>
> > Cc: "Einav Cohen" <ecohen at redhat.com>, "Vojtech Szocs" <vszocs at redhat.com>,
> > "Alona Kaplan" <alkaplan at redhat.com>,
> > "Tal Nisan" <tnisan at redhat.com>
> > Sent: Thursday, April 25, 2013 3:23:56 AM
> > Subject: Change in ovirt-engine[master]: webadmin: DataCenters main-tab:
> > sub-tabs resizable columns
> > 
> > Gilad Chaplik has posted comments on this change.
> > 
> > Change subject: webadmin: DataCenters main-tab: sub-tabs resizable columns
> > ......................................................................
> > 
> > 
> > Patch Set 4:
> > 
> > why we need to invoke getTable().enableColumnResizing() on each sub-tab?
> > don't we want all grid subtabs to have column resizing?
> > 
> > --
> > To view, visit http://gerrit.ovirt.org/14105
> > To unsubscribe, visit http://gerrit.ovirt.org/settings
> > 
> > Gerrit-MessageType: comment
> > Gerrit-Change-Id: I71465d36e5c18ecb8eb6dbca436feaeea1c902a9
> > Gerrit-PatchSet: 4
> > Gerrit-Project: ovirt-engine
> > Gerrit-Branch: master
> > Gerrit-Owner: Daniel Erez <derez at redhat.com>
> > Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
> > Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
> > Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
> > Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
> > Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
> > Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
> > 
>