[Engine-devel] ok to sort login domains on backend?

[Einav Cohen]

> ----- Original Message -----
> From: "Alon Bar-Lev" <alonbl at redhat.com>
> Sent: Friday, August 30, 2013 9:32:46 AM
> 
> 
> 
> ----- Original Message -----
> > From: "Greg Sheremeta" <gshereme at redhat.com>
> > To: engine-devel at ovirt.org
> > Sent: Friday, August 30, 2013 3:26:48 PM
> > Subject: [Engine-devel] ok to sort login domains on backend?
> > 
> > Hi,
> > 
> > I'm working on https://bugzilla.redhat.com/785555 -- "domain selection list
> > in login screen should be sorted alphabetically"
> > 
> > I was going to put the sort logic in the web apps, but it makes sense to
> > just
> > put it in the backend, specifically in GetDomainListQuery. (There is
> > already
> > a sort there, but it needs to be tweaked to put "internal" always last.)
> > This would affect non-webapp clients (REST API), so I want to make sure
> > there are no objections. Unit tests pass and it seems to work fine (screen
> > attached).
> > 
> > Any objections?
> 
> I think that sorting of visualization is presentation layer role.

true in general, but I think that there is no harm in returning items 
from the backend in some default order, especially if this is a list 
of simple items that have only one possible order that makes sense.

> 
> > 
> > Thanks,
> > Greg
> > 
> > 
> > Greg Sheremeta
> > Red Hat, Inc.
> > Sr. Software Engineer, RHEV
> > Cell: 919-807-1086
> > gshereme at redhat.com
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
> 
>