[Engine-devel] unit tests failing

[Federico Simoncelli]

----- Original Message -----
> From: "Federico Simoncelli" <fsimonce at redhat.com>
> To: "Ewoud Kohl van Wijngaarden" <ewoud+ovirt at kohlvanwijngaarden.nl>
> Cc: "engine-devel" <engine-devel at ovirt.org>
> Sent: Tuesday, January 29, 2013 4:45:43 PM
> Subject: Re: [Engine-devel] unit tests failing
> 
> ----- Original Message -----
> > From: "Ewoud Kohl van Wijngaarden"
> > <ewoud+ovirt at kohlvanwijngaarden.nl>
> > To: "Laszlo Hornyak" <lhornyak at redhat.com>
> > Cc: "Federico Simoncelli" <fsimonce at redhat.com>, "engine-devel"
> > <engine-devel at ovirt.org>
> > Sent: Tuesday, January 29, 2013 4:36:35 PM
> > Subject: Re: [Engine-devel] unit tests failing
> > 
> > May I recommend git bisect? See http://lwn.net/Articles/317154/ or
> > http://clock.co.uk/tech-blogs/git-bisect-simple-examples-and-automation
> > as well.
> > 
> > First you find a known BAD, for example master. Then you find a
> > known
> > GOOD (for example 100 commits ago in master: master~100). Then we
> > can
> > use a script to determine if it's good. I'm assuming mvn test will
> > be
> > sufficient, but maybe you can refine this to only test for a
> > specific
> > unit test.
> > 
> > git bisect start BAD GOOD
> > git bisect run mvn test
> > 
> > Now it will do a binary search in your history trying to find the
> > commit
> > that broke mvn test.
> 
> It's ff64900b7ae1b2d92e40bb290c61354d846d7d30
> I'm working on it as we speak.

This is a quick fix:

http://gerrit.ovirt.org/#/c/11510/

I'm sure there's a lot to improve, please review it so we can push it
as fast as we can. Thanks.
-- 
Federico