From omasad at redhat.com  Sun Jun  2 06:46:34 2013
From: omasad at redhat.com (Ofri Masad)
Date: Sun, 2 Jun 2013 02:46:34 -0400 (EDT)
Subject: [Engine-devel] cannot execute command in the class
	of	InitVdsOnUpCommand
In-Reply-To: <C5A0092C63E939488005F15F736A81120A5CE6FE@SHSMSX103.ccr.corp.intel.com>
References: <C5A0092C63E939488005F15F736A81120A5CE6FE@SHSMSX103.ccr.corp.intel.com>
Message-ID: <1968781161.6100192.1370155594861.JavaMail.root@redhat.com>

Hi Dave,

reason could be found in the VdsUpdateRunTimeInfo.java:refresh().
The call to vdsUpEvent(_vds) is triggered only here and this is calling the executeCommand of InitVdsOnUpCommand.
as you can see, this call is conditioned by the vds going from not "up" status to "up" status and also conditioned to not work in the first transition from "_firstStatus".

So, executeCommand of InitVdsOnUpCommand is only called if in some point of its life the vds status was other than "UP" and then it was set to "UP" again.

Ofri   

----- Original Message -----
> From: "Wei D Chen" <wei.d.chen at intel.com>
> To: "engine-devel" <engine-devel at ovirt.org>
> Cc: "Lijuan Zhang" <lijuan.zhang at intel.com>
> Sent: Thursday, May 30, 2013 6:21:01 PM
> Subject: [Engine-devel] cannot execute command in the class of	InitVdsOnUpCommand
> 
> Hi,
> 
> We suppose when one VDS is added into cluster, executeCommand method in
> InitVdsOnUpCommand.java will be invoked, so, some logic will be checked
> there. But per our experiment, this is depended on what we actually did.
> Here are some cases:
> 1. when reboot VDS, the logic in " executeCommand" will be invoked.
> 2. when re-deploy engine, the logic in " executeCommand" will be invoked.
> 3. when we add a new VDS (vdsm is running) into cluster, the logic in "
> executeCommand" will not be invoked.
> 
> What we expect is the logic will also be invoked in the third case, but why
> it's not invoked? What's behind all of these?
> 
> 
> Best Regards,
> Dave Chen
> 
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From omasad at redhat.com  Sun Jun  2 06:58:05 2013
From: omasad at redhat.com (Ofri Masad)
Date: Sun, 2 Jun 2013 02:58:05 -0400 (EDT)
Subject: [Engine-devel] Network Quality of Service 3.3 - Feature design
In-Reply-To: <1800563849.6100278.1370156093946.JavaMail.root@redhat.com>
Message-ID: <273375846.6100303.1370156285221.JavaMail.root@redhat.com>

Hi all,

A new Feature page for "Network Quality of Service" feature was published.

http://www.ovirt.org/Features/Design/Network_QoS

You are more than welcome to share you thoughts and insights.

Thanks,
Ofri.


From iheim at redhat.com  Sun Jun  2 07:34:47 2013
From: iheim at redhat.com (Itamar Heim)
Date: Sun, 02 Jun 2013 10:34:47 +0300
Subject: [Engine-devel] Network Quality of Service 3.3 - Feature design
In-Reply-To: <273375846.6100303.1370156285221.JavaMail.root@redhat.com>
References: <273375846.6100303.1370156285221.JavaMail.root@redhat.com>
Message-ID: <51AAF597.8090505@redhat.com>

On 06/02/2013 09:58 AM, Ofri Masad wrote:
> Hi all,
>
> A new Feature page for "Network Quality of Service" feature was published.
>
> http://www.ovirt.org/Features/Design/Network_QoS
>
> You are more than welcome to share you thoughts and insights.
>
> Thanks,
> Ofri.
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>


some questions:
1. "In the Add/Edit Network two parts will be added - one for the QoS 
properties of the network, the other for the QoS properties preset for 
VNICs attached to the network."

so the first part of QoS for network is the limit of the logical network 
on the host for all vnic's associated to it, compared to other logical 
networks?

2. "Only a user permitted to edit the network may edit the QoS 
properties in the network dialog or override the QoS properties in the 
VNIC dialog. "

why would a network operator (having permissions on networks) have 
permissions on specific VM's vnic's?
probably a special permission to edit network QoS at vm level is needed?

3. "outbound_burst 	Bigint "
just wondering - what numbers do you expect here that Integer like the 
average and peak is not enough?

4. "Old libvirt versions that have the global driver lock may have 
performance problems. It would be nice to check what version of libvirt 
is this going to run on"

old versions but 1.0.1 is required, does 1.0.1 have this issue?

5. behavior with provider networks (quantum)?

Thanks,
    Itamar


From omasad at redhat.com  Sun Jun  2 08:24:58 2013
From: omasad at redhat.com (Ofri Masad)
Date: Sun, 2 Jun 2013 04:24:58 -0400 (EDT)
Subject: [Engine-devel] Network Quality of Service 3.3 - Feature design
In-Reply-To: <51AAF597.8090505@redhat.com>
References: <273375846.6100303.1370156285221.JavaMail.root@redhat.com>
	<51AAF597.8090505@redhat.com>
Message-ID: <1120708548.6101461.1370161498442.JavaMail.root@redhat.com>

Hi, 
answers inline

Thanks,
Ofri

----- Original Message -----
> From: "Itamar Heim" <iheim at redhat.com>
> To: "Ofri Masad" <omasad at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>
> Sent: Sunday, June 2, 2013 10:34:47 AM
> Subject: Re: [Engine-devel] Network Quality of Service 3.3 - Feature design
> 
> On 06/02/2013 09:58 AM, Ofri Masad wrote:
> > Hi all,
> >
> > A new Feature page for "Network Quality of Service" feature was published.
> >
> > http://www.ovirt.org/Features/Design/Network_QoS
> >
> > You are more than welcome to share you thoughts and insights.
> >
> > Thanks,
> > Ofri.
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> >
> 
> 
> some questions:
> 1. "In the Add/Edit Network two parts will be added - one for the QoS
> properties of the network, the other for the QoS properties preset for
> VNICs attached to the network."
> 
> so the first part of QoS for network is the limit of the logical network
> on the host for all vnic's associated to it, compared to other logical
> networks?

Exactly. first part is the network level limitation.

> 
> 2. "Only a user permitted to edit the network may edit the QoS
> properties in the network dialog or override the QoS properties in the
> VNIC dialog. "
> 
> why would a network operator (having permissions on networks) have
> permissions on specific VM's vnic's?
> probably a special permission to edit network QoS at vm level is needed?

True. we will limit the VNIC QoS editing to a user which holds both UserVmManager and NetworkAdmin permissions.
This also the case for editing port mirroring for vnic.   

> 
> 3. "outbound_burst 	Bigint "
> just wondering - what numbers do you expect here that Integer like the
> average and peak is not enough?
> 

the units for the "burst" parameter are Mb (Mega bits). so, if we would like to allow burst of over 4GB (Giga byte) we will need Bigint.   

> 4. "Old libvirt versions that have the global driver lock may have
> performance problems. It would be nice to check what version of libvirt
> is this going to run on"
> 
> old versions but 1.0.1 is required, does 1.0.1 have this issue?
> 

No. ver 1.0.1 does not have that problem. this sentence was left there by mistake and will be removed.  


> 5. behavior with provider networks (quantum)?

Traffic shaping using the Network QoS feature will be available only for oVirt networks at this stage.

> 
> Thanks,
>     Itamar
> 


From iheim at redhat.com  Sun Jun  2 08:31:14 2013
From: iheim at redhat.com (Itamar Heim)
Date: Sun, 02 Jun 2013 11:31:14 +0300
Subject: [Engine-devel] Network Quality of Service 3.3 - Feature design
In-Reply-To: <1120708548.6101461.1370161498442.JavaMail.root@redhat.com>
References: <273375846.6100303.1370156285221.JavaMail.root@redhat.com>
	<51AAF597.8090505@redhat.com>
	<1120708548.6101461.1370161498442.JavaMail.root@redhat.com>
Message-ID: <51AB02D2.6080200@redhat.com>

On 06/02/2013 11:24 AM, Ofri Masad wrote:
> Hi,
> answers inline
>
> Thanks,
> Ofri
>
> ----- Original Message -----
>> From: "Itamar Heim" <iheim at redhat.com>
>> To: "Ofri Masad" <omasad at redhat.com>
>> Cc: "engine-devel" <engine-devel at ovirt.org>
>> Sent: Sunday, June 2, 2013 10:34:47 AM
>> Subject: Re: [Engine-devel] Network Quality of Service 3.3 - Feature design
>>
>> On 06/02/2013 09:58 AM, Ofri Masad wrote:
>>> Hi all,
>>>
>>> A new Feature page for "Network Quality of Service" feature was published.
>>>
>>> http://www.ovirt.org/Features/Design/Network_QoS
>>>
>>> You are more than welcome to share you thoughts and insights.
>>>
>>> Thanks,
>>> Ofri.
>>> _______________________________________________
>>> Engine-devel mailing list
>>> Engine-devel at ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>
>>
>>
>> some questions:
>> 1. "In the Add/Edit Network two parts will be added - one for the QoS
>> properties of the network, the other for the QoS properties preset for
>> VNICs attached to the network."
>>
>> so the first part of QoS for network is the limit of the logical network
>> on the host for all vnic's associated to it, compared to other logical
>> networks?
>
> Exactly. first part is the network level limitation.

ok. i guess in most cases it wouldn't make sense for network level and 
vnic level to be the same?

...
>
>>
>> 3. "outbound_burst 	Bigint "
>> just wondering - what numbers do you expect here that Integer like the
>> average and peak is not enough?
>>
>
> the units for the "burst" parameter are Mb (Mega bits). so, if we would like to allow burst of over 4GB (Giga byte) we will need Bigint.

integer is up to +2147483647 (Mb)? that's way more than 4GB?

...
>
>
>> 5. behavior with provider networks (quantum)?
>
> Traffic shaping using the Network QoS feature will be available only for oVirt networks at this stage.

1. please comment as much
2. btw, why? if libvirt is the one setting the traffic shaping, how 
would it be different for (some) quantum networks like bridge or ovs?

Thanks,
    Itamar


From ehildesh at redhat.com  Sun Jun  2 08:47:45 2013
From: ehildesh at redhat.com (Eldan Hildesheim)
Date: Sun, 2 Jun 2013 04:47:45 -0400 (EDT)
Subject: [Engine-devel] static header only in VM dialog?
In-Reply-To: <1032392108.32086738.1370021322340.JavaMail.root@redhat.com>
References: <gerrit.1368170341473.Icad8098e286f821da25fac22fd0a840a42f105c9@gerrit.ovirt.org>
	<2014639425.11839457.1369981377910.JavaMail.root@redhat.com>
	<1493549047.16382669.1370000699204.JavaMail.root@redhat.com>
	<73EDF069-94CA-4BEC-8464-F1006BA4954C@redhat.com>
	<909641716.16748965.1370015793965.JavaMail.root@redhat.com>
	<613894007.9673380.1370017734535.JavaMail.root@redhat.com>
	<1035434474.16802346.1370020733824.JavaMail.root@redhat.com>
	<1032392108.32086738.1370021322340.JavaMail.root@redhat.com>
Message-ID: <271345152.2504460.1370162865880.JavaMail.root@redhat.com>

Eldan:

I prepared 2 mockups to explain the differences between the grey docked panel and the grey non-docked panel. (The data inside is not accurate)
I added the colour values for who ever is going to implement the dialogue.

dialogue_not_docked.png:
This mockup is like we have today:
Since it's INSIDE of the general left tab, it has a CONSTANT padding around it. (bg color should be #e5e5e5, the padding is important)

dialogue_docked.png:
Contrary to the previous mockup, here the grey panel is docked - no padding, this is to emphasise that the panel is STATIC.
To emphasise it graphically the bg color is the same as before only this time it has a darker border (#d3d3d3)  
This is also more easy to implement:
The  difference between both of the panel is once the padding border is white and once its dark grey.

Eldan 

----- Original Message -----
From: "Malini Rao" <mrao at redhat.com>
To: "Einav Cohen" <ecohen at redhat.com>
Cc: "Daniel Erez" <derez at redhat.com>, "Tomas Jelinek" <tjelinek at redhat.com>, "Eldan Hildesheim" <info at eldanet.com>, "Eldan Hildesheim" <ehildesh at redhat.com>, "engine-devel" <engine-devel at ovirt.org>, "Itamar Heim" <iheim at redhat.com>
Sent: Friday, May 31, 2013 8:28:42 PM
Subject: Re: [Engine-devel] static header only in VM dialog?





----- Original Message -----
> From: "Einav Cohen" <ecohen at redhat.com>
> To: "Daniel Erez" <derez at redhat.com>, "Tomas Jelinek" <tjelinek at redhat.com>, "Malini Rao" <mrao at redhat.com>, "Eldan
> Hildesheim" <info at eldanet.com>, "Eldan Hildesheim" <ehildesh at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>, "Itamar Heim" <iheim at redhat.com>
> Sent: Friday, May 31, 2013 1:18:53 PM
> Subject: Re: [Engine-devel] static header only in VM dialog?
> 
> > ----- Original Message -----
> > From: "Daniel Erez" <derez at redhat.com>
> > Sent: Friday, May 31, 2013 12:28:54 PM
> > 
> > 
> > ----- Original Message -----
> > > From: "Einav Cohen" <ecohen at redhat.com>
> > > To: "Michal Skrivanek" <michal.skrivanek at redhat.com>, "Tomas Jelinek"
> > > <tjelinek at redhat.com>
> > > Cc: "Eldan Hildesheim" <info at eldanet.com>, "engine-devel"
> > > <engine-devel at ovirt.org>, "Eldan Hildesheim"
> > > <ehildesh at redhat.com>, "Daniel Erez" <derez at redhat.com>, "Malini Rao"
> > > <mrao at redhat.com>, "Itamar Heim"
> > > <iheim at redhat.com>
> > > Sent: Friday, May 31, 2013 6:56:33 PM
> > > Subject: Re: [Engine-devel] static header only in VM dialog?
> > > 
> > > > > ...
> > > > > 
> > > > > [1] my main concern is that this batch of patches (dialog reorg) will
> > > > > make
> > > > > it into ovirt
> > > > > 3.3, but the second batch (which will contain the actual Instance
> > > > > Types
> > > > > fields) won't make
> > > > > it in time [see the ovirt 3.3 schedule in:
> > > > > http://www.ovirt.org/OVirt_3.3_release-management -
> > > > > ovirt 3.3 feature freeze is today (?!)]; so I wouldn't want to see
> > > > > ovirt
> > > > > 3.3 being released
> > > > > with only the first patch batch merged into it. either both batches
> > > > > should
> > > > > be there, or
> > > > > both batches should not be there.
> > > > 
> > > > There was a discussion about postponing it, but not much further it
> > > > seems.
> > > > In any case It may not be necessarily wrong to have dialog reorg in 3.3
> > > > without insttypes as it will at least get people to get used to it and
> > > > we
> > > > can gather feedback. It's not that it removes any functionality, on the
> > > > contrary, e.g. the type ahead feature even solves some of the bugs we
> > > > already have.
> > > 
> > > indeed - it doesn't remove functionality, and I agree that it would be a
> > > good
> > > opportunity to get feedback about some things such as the type-ahead list
> > > box,
> > > however the top static header in particular with only the DC/Cluster +
> > > Quota
> > > in it may seem strange / annoying, as it would just seem like something
> > > that
> > > takes up "real estate" in the dialog in *all* side-tab without a real
> > > good
> > > reason.
> > > 
> > > so there are pros and cons for introducing only the first patch batch to
> > > ovirt-3.3,
> > > I guess; Ideally, I would suggest to maybe re-organize the patches a bit
> > > differently,
> > > so that the top static header in particular wouldn't be part of this
> > > first
> > > patch batch,
> > > i.e., I would suggest introducing the top static header along with adding
> > > the
> > > Instance
> > > Types fields [which, to my understanding, is exactly what Daniel has
> > > originally suggested
> > > on the patch [1] in his gerrit comment(s) from May 28/29 (depends on the
> > > timezone) -
> > > only now I fully understand his concern (I think/hope)...].
> > 
> > Exactly, I prefer that the static header will be introduced along with the
> > new dialog
> > I.e. squashed with the final dialog patch (with instance types fields).
> > I understand that the static header might make sense for the final dialog
> 
> - I am actually waiting for Tomas's response on what exactly is going to be
> included
> within the top static header of the dialog in his current 7-patches batch
> (see my
> previous response in the thread) - there is a chance that it makes some sense
> to
> introduce the top static section at this stage (instead of waiting for the
> "final
> dialog patch" in which the Instance Types and Image fields will be
> introduced), as
> it already affects a "nice" amount of side-tabs.
> 
> - even if the fields that are included in the top static header in the
> current
> patch-batch don't really justify introducing the top static section at this
> stage,
> there are other things that (IMO) should be taken into consideration when
> deciding
> how to proceed [see my (1.a), (1.b), (2) "essay" in one of my previous
> responses
> in the thread]
> 
> > (though I still don't like the idea that it's relevant only for some
> > side-tabs).
> 
> I think that UX wise (and Malini/Eldan can comment on that), if the top
> section affect
> a significant amount of side-tabs, it is better that this section would be
> displayed
> in *all* side tabs, rather than have it visible only in the relevant
> side-tabs, which
> can be a bit irritating to the eye when "jumping" between side-tabs.


MR - Yes, if we have a static top panel, it should be truly static- i.e, it should stay displayed irrespective of whether the currently selected side tab has a dependency or context info on the static panel or not.  


> 
> [of course, I assume that completely different, creative solutions can be
> found, but
> even if so - I suggest to think about them in a later stage, after
> introducing the
> Instance Types feature into the system / getting some more feedback on the
> current
> top static header solution]
> 
> > Added my remarks to the patch: http://gerrit.ovirt.org/#/c/14635/
> > 
> > > 
> > > not sure how easy it is to do though - I know that *a lot* of time and
> > > effort
> > > were
> > > already invested in these patches as they are now, and I wouldn't want
> > > that
> > > the reviewing/
> > > merging process will be held off for much longer.
> > > 
> > > To sum up: these are the options, as I see them:
> > > 
> > > 1) keep the current patch batch as is and:
> > > 
> > >    a. merge it in time for ovirt-3.3, or:
> > > 
> > >    b. merge it post ovirt-3.3.
> > > 
> > > - or -
> > > 
> > > 2) go with what Daniel has suggested in his gerrit comment: reorganize
> > > the
> > > patches so that
> > > the top static header would be introduced only along with the instance
> > > types
> > > fields [that
> > > way, it won't matter what makes it into ovirt-3.3 - the first patch
> > > batch,
> > > or
> > > both (or none)].
> > > 
> > > I am in favor of (1.b) or (2). However, weighing the cons of (1.a)
> > > against
> > > the pros of (1.a) /
> > > cons of (1.b) or against the effort that (2) will require, and taking
> > > into
> > > consideration the
> > > effort that was already invested, I am not strongly against (1.a) as
> > > well.
> > > 
> > > [1] http://gerrit.ovirt.org/#/c/14635/
> > > 
> > > > ...
> > >  
> > > 
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> > 
> > 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dialogue_docked.png
Type: image/png
Size: 63344 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130602/4b0f583d/attachment.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dialogue_not_docked.png
Type: image/png
Size: 41100 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130602/4b0f583d/attachment-0001.png>

From vered at redhat.com  Sun Jun  2 08:57:11 2013
From: vered at redhat.com (Vered Volansky)
Date: Sun, 2 Jun 2013 04:57:11 -0400 (EDT)
Subject: [Engine-devel] Disk BE very small refactoring
In-Reply-To: <1369501327.15118945.1369902580919.JavaMail.root@redhat.com>
References: <1543112346.12706449.1369667938808.JavaMail.root@redhat.com>
	<1454073553.8350387.1369668178246.JavaMail.root@redhat.com>
	<1021461587.13107769.1369729481376.JavaMail.root@redhat.com>
	<51A48BCA.5020509@redhat.com>
	<2012114925.13632941.1369762838851.JavaMail.root@redhat.com>
	<1369501327.15118945.1369902580919.JavaMail.root@redhat.com>
Message-ID: <912493878.17348949.1370163431380.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Omer Frenkel" <ofrenkel at redhat.com>
> To: "Vered Volansky" <vered at redhat.com>
> Cc: "Maor Lipchuk" <mlipchuk at redhat.com>, "Yair Zaslavsky" <yzaslavs at redhat.com>, "Mike Kolesnik"
> <mkolesni at redhat.com>, "Allon Mureinik" <amureini at redhat.com>, "Daniel Erez" <derez at redhat.com>,
> engine-devel at ovirt.org
> Sent: Thursday, May 30, 2013 11:29:40 AM
> Subject: Re: [Engine-devel] Disk BE very small refactoring
> 
> 
> 
> ----- Original Message -----
> > From: "Vered Volansky" <vered at redhat.com>
> > To: "Maor Lipchuk" <mlipchuk at redhat.com>, "Yair Zaslavsky"
> > <yzaslavs at redhat.com>, "Omer Frenkel"
> > <ofrenkel at redhat.com>, "Mike Kolesnik" <mkolesni at redhat.com>, "Allon
> > Mureinik" <amureini at redhat.com>, "Daniel Erez"
> > <derez at redhat.com>
> > Cc: engine-devel at ovirt.org
> > Sent: Tuesday, May 28, 2013 8:40:38 PM
> > Subject: Re: [Engine-devel] Disk BE very small refactoring
> > 
> > I had a problem, didn't see all the replies till now.
> > 
> > I'll add some more info as to why we want to do this like we do.
> > It all started from adding the readOnly property to disks. It should have
> > been handled like plugged is handled, yet plugged is a hack, and if we
> > don't
> > change that now, we'll only keep on adding unreasonable hacks.
> > 
> 
> please explain why you think plugged is a hack? what is wrong with it?
Plugged is a property of a disk-vm.
Were the disk only be able to be plugged to one VM, there would be no problem with that.
But since the disk can be plugged to several VMs, the plugged property should be on the relationship between the two, and not selectively on disk.
Since this is the current case, there's a query that fills in this data in disk under the VM's context, which can be changed when the VM's context is different, which is a hack.

> 
> > So from the start -
> > Disk currently:
> > - Sometimes represents a disk in a vm context and sometimes not.
> > - Holds plugged property, which is only relevant when a disk is in a vm
> > context, which already suggests this is not the natural place for it.
> > - Also holds bootable and interface, which cause limitations of use, but
> > are
> > not so obviously related to the relationship between Disk and Vm as
> > plugged.
> > - Can be shared between several vm's, to some plugged and to some not
> > plugged.
> > - Will soon be optionally RO in one VM and RW in another, which is exactly
> > the same as plugged, and therefore plugged issue should be fixed first.
> > 
> > Every column in that shows a disk in the UI receives a Disk entity, and
> > show
> > its contents, while plugged/unplugged is ignored when not in a VM context.
> > The way things are now, using a VmDevice in the where we need it to show
> > plug
> > status, we'll also have to use it in all other columns, which is irrelevant
> > and just totally not related.
> > So using VmDevice in UI is a no go.
> > 
> > The UI is the main limitation forcing us to use something that extends
> > Disk,
> > and what I described below is the easiest thing to implement in the time
> > restrictions we have without changing the entire system.
> > 
> > I think this answers all the questions not already answered by others.
> > Regarding Maor suggestion - might be a good idea, but not in this scope or
> > time-frame.
> > 
> > If there is any other/unanswered issue or objection to the design change
> > please share.
> > 
> > I appreciate your inputs,
> > Vered
> > 
> 
> sorry i didnt understand why the current disk object isnt good enough,
> you get a disk, some of its properties are valid only in some situations.
> i think its easier to use instead of couple of different objects representing
> the same entity in different situations.
This just doesn't belong there, there's a workaround to make it work when it's indeed needed - by the GetAllDisksByVmIdQuery.
In between the value there means nothing, the fact that we successfully avoid falling into that pitfall doesn't mean it should remain this way.
More importantly, this is not done here, we're adding other properties (currently RO) that face the same handling onless this is resolved now.
This is the best resolution we came up with under the circumstances.

Are you putting you foot down on this?

> 
> > 
> > ----- Original Message -----
> > > From: "Maor Lipchuk" <mlipchuk at redhat.com>
> > > To: "Vered Volansky" <vered at redhat.com>
> > > Cc: engine-devel at ovirt.org
> > > Sent: Tuesday, May 28, 2013 1:49:46 PM
> > > Subject: Re: [Engine-devel] Disk BE very small refactoring
> > > 
> > > I think the main problem is that we abuse the business entity to act as
> > > an O/R mapping class to the DB and also to be used as a business entity
> > > for presentation purposes.
> > > 
> > > I understand how Yair thought isPlugged could be fetched from vmDevice,
> > > this is a confusing design, and it is just one example and more to come.
> > > 
> > > I suggest that if we already thinking of changing the class hierarchy,
> > > we can start by implementing a package for presentation classes for
> > > transient classes such as this instead enforcing complex hierarchy.
> > > 
> > > The query class will fetch all the data from the DB and initialized the
> > > transient class and send it to the client.
> > > I think it could be a good start and will solve many issues we might
> > > encounter in the future.
> > > 
> > > Regards,
> > > Maor
> > > 
> > > On 05/28/2013 11:24 AM, Omer Frenkel wrote:
> > > > 
> > > > 
> > > > ----- Original Message -----
> > > >> From: "Yair Zaslavsky" <yzaslavs at redhat.com>
> > > >> To: "Vered Volansky" <vered at redhat.com>
> > > >> Cc: engine-devel at ovirt.org
> > > >> Sent: Monday, May 27, 2013 6:22:58 PM
> > > >> Subject: Re: [Engine-devel] Disk BE very small refactoring
> > > >>
> > > >> Vered,
> > > >> VmDevice has "isPlugged" field,
> > > >> Why not have somehow in your inheritence (either Disk or a subclass) a
> > > >> field
> > > >> : "VmDevice device"
> > > > 
> > > > disk id is the device id, no need for field to represent the relation.
> > > > the combination of disk-id and a specific entity (vm/template) will get
> > > > you
> > > > the other info
> > > > 
> > > >> and have isPlugged method called "device.isPlugged()" ?
> > > >>
> > > >> Then you can also add the readOnly property which is not represented
> > > >> at
> > > >> VmDevice.
> > > >>
> > > >>
> > > >> Does this sound logical to you?
> > > >>
> > > >> ----- Original Message -----
> > > >>> From: "Vered Volansky" <vered at redhat.com>
> > > >>> To: engine-devel at ovirt.org
> > > >>> Sent: Monday, May 27, 2013 6:18:58 PM
> > > >>> Subject: [Engine-devel] Disk BE very small refactoring
> > > >>>
> > > >>> Hi All,
> > > >>>
> > > >>> Please express your opinion if you have any -
> > > >>>
> > > >>> Currently Disk BE has a plugged property, which should be a property
> > > >>> of
> > > >>> the
> > > >>> relationship between vm(or template) and a disk.
> > > >>> I plan to remove this property from the Disk entity, and add new
> > > >>> entity,
> > > >>> called DeviceDisk.
> > > >>> This should inherit from Disk and contain the vm/template guid and
> > > >>> the
> > > >>> plugged property at first round.
> > > >>> At second round it'll also contain the readOnly property, for RO
> > > >>> disks,
> > > >>> TBD
> > > >>> right after.
> > > >>>
> > > >>> Appreciate any input,
> > > >>> Vered
> > > >>> _______________________________________________
> > > >>> Engine-devel mailing list
> > > >>> Engine-devel at ovirt.org
> > > >>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > >>>
> > > >> _______________________________________________
> > > >> Engine-devel mailing list
> > > >> Engine-devel at ovirt.org
> > > >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > >>
> > > > _______________________________________________
> > > > Engine-devel mailing list
> > > > Engine-devel at ovirt.org
> > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > 
> > > 
> > > 
> > > _______________________________________________
> > > Engine-devel mailing list
> > > Engine-devel at ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > 
> > 
> 


From dfediuck at redhat.com  Sun Jun  2 08:58:39 2013
From: dfediuck at redhat.com (Doron Fediuck)
Date: Sun, 2 Jun 2013 04:58:39 -0400 (EDT)
Subject: [Engine-devel] Network Quality of Service 3.3 - Feature design
In-Reply-To: <51AB02D2.6080200@redhat.com>
References: <273375846.6100303.1370156285221.JavaMail.root@redhat.com>
	<51AAF597.8090505@redhat.com>
	<1120708548.6101461.1370161498442.JavaMail.root@redhat.com>
	<51AB02D2.6080200@redhat.com>
Message-ID: <707553562.17349103.1370163519934.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Itamar Heim" <iheim at redhat.com>
> To: "Ofri Masad" <omasad at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>
> Sent: Sunday, June 2, 2013 11:31:14 AM
> Subject: Re: [Engine-devel] Network Quality of Service 3.3 - Feature design
> 
> On 06/02/2013 11:24 AM, Ofri Masad wrote:
> > Hi,
> > answers inline
> >
> > Thanks,
> > Ofri
> >
> > ----- Original Message -----
> >> From: "Itamar Heim" <iheim at redhat.com>
> >> To: "Ofri Masad" <omasad at redhat.com>
> >> Cc: "engine-devel" <engine-devel at ovirt.org>
> >> Sent: Sunday, June 2, 2013 10:34:47 AM
> >> Subject: Re: [Engine-devel] Network Quality of Service 3.3 - Feature
> >> design
> >>
> >> On 06/02/2013 09:58 AM, Ofri Masad wrote:
> >>> Hi all,
> >>>
> >>> A new Feature page for "Network Quality of Service" feature was
> >>> published.
> >>>
> >>> http://www.ovirt.org/Features/Design/Network_QoS
> >>>
> >>> You are more than welcome to share you thoughts and insights.
> >>>
> >>> Thanks,
> >>> Ofri.
> >>> _______________________________________________
> >>> Engine-devel mailing list
> >>> Engine-devel at ovirt.org
> >>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> >>>
> >>
> >>
> >> some questions:
> >> 1. "In the Add/Edit Network two parts will be added - one for the QoS
> >> properties of the network, the other for the QoS properties preset for
> >> VNICs attached to the network."
> >>
> >> so the first part of QoS for network is the limit of the logical network
> >> on the host for all vnic's associated to it, compared to other logical
> >> networks?
> >
> > Exactly. first part is the network level limitation.
> 
> ok. i guess in most cases it wouldn't make sense for network level and
> vnic level to be the same?
> 
> ...
> >
> >>
> >> 3. "outbound_burst 	Bigint "
> >> just wondering - what numbers do you expect here that Integer like the
> >> average and peak is not enough?
> >>
> >
> > the units for the "burst" parameter are Mb (Mega bits). so, if we would
> > like to allow burst of over 4GB (Giga byte) we will need Bigint.
> 
> integer is up to +2147483647 (Mb)? that's way more than 4GB?
> 
> ...
> >
> >
> >> 5. behavior with provider networks (quantum)?
> >
> > Traffic shaping using the Network QoS feature will be available only for
> > oVirt networks at this stage.
> 
> 1. please comment as much
> 2. btw, why? if libvirt is the one setting the traffic shaping, how
> would it be different for (some) quantum networks like bridge or ovs?

Good question. Quantum has its own API which may conflict the libvirt one.
>From what we saw so far, the Quantum QoS API is still in process, but should
support VM level and not vNIC level. Either way, at this point to prevent
conflicts we support oVirt networks only and once possible we'll try to
expand it to provided networks.

> 
> Thanks,
>     Itamar
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From vered at redhat.com  Sun Jun  2 09:02:55 2013
From: vered at redhat.com (Vered Volansky)
Date: Sun, 2 Jun 2013 05:02:55 -0400 (EDT)
Subject: [Engine-devel] Disk BE very small refactoring
In-Reply-To: <798173905.9398505.1369907846932.JavaMail.root@redhat.com>
References: <1543112346.12706449.1369667938808.JavaMail.root@redhat.com>
	<1454073553.8350387.1369668178246.JavaMail.root@redhat.com>
	<1021461587.13107769.1369729481376.JavaMail.root@redhat.com>
	<51A48BCA.5020509@redhat.com>
	<2012114925.13632941.1369762838851.JavaMail.root@redhat.com>
	<1369501327.15118945.1369902580919.JavaMail.root@redhat.com>
	<798173905.9398505.1369907846932.JavaMail.root@redhat.com>
Message-ID: <709493761.17349467.1370163775374.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Eli Mesika" <emesika at redhat.com>
> To: "Vered Volansky" <vered at redhat.com>
> Cc: engine-devel at ovirt.org
> Sent: Thursday, May 30, 2013 12:57:26 PM
> Subject: Re: [Engine-devel] Disk BE very small refactoring
> 
> 
> 
> ----- Original Message -----
> > From: "Omer Frenkel" <ofrenkel at redhat.com>
> > To: "Vered Volansky" <vered at redhat.com>
> > Cc: engine-devel at ovirt.org
> > Sent: Thursday, May 30, 2013 11:29:40 AM
> > Subject: Re: [Engine-devel] Disk BE very small refactoring
> > 
> > 
> > 
> > ----- Original Message -----
> > > From: "Vered Volansky" <vered at redhat.com>
> > > To: "Maor Lipchuk" <mlipchuk at redhat.com>, "Yair Zaslavsky"
> > > <yzaslavs at redhat.com>, "Omer Frenkel"
> > > <ofrenkel at redhat.com>, "Mike Kolesnik" <mkolesni at redhat.com>, "Allon
> > > Mureinik" <amureini at redhat.com>, "Daniel Erez"
> > > <derez at redhat.com>
> > > Cc: engine-devel at ovirt.org
> > > Sent: Tuesday, May 28, 2013 8:40:38 PM
> > > Subject: Re: [Engine-devel] Disk BE very small refactoring
> > > 
> > > I had a problem, didn't see all the replies till now.
> > > 
> > > I'll add some more info as to why we want to do this like we do.
> > > It all started from adding the readOnly property to disks. It should have
> > > been handled like plugged is handled, yet plugged is a hack, and if we
> > > don't
> > > change that now, we'll only keep on adding unreasonable hacks.
> > > 
> > 
> > please explain why you think plugged is a hack? what is wrong with it?
> 
> You have is_readonly and is_plugged in the device level , this is far from
> being a hack and managed in the correct place since both may apply to
> multiple device types (disk, nics ....)
There's no problem with device level, only I can't use VmDevice (which is where this naturally belongs) in UI since it will cause a major change we don't want right now.
Not only that, VmDevice does hold this info, but not other relevant info used in UI and available in Disk, so using VmDevice on it's own is not only to extensive a change, but also by far will not end there.

> 
> > 
> > > So from the start -
> > > Disk currently:
> > > - Sometimes represents a disk in a vm context and sometimes not.
> > > - Holds plugged property, which is only relevant when a disk is in a vm
> > > context, which already suggests this is not the natural place for it.
> > > - Also holds bootable and interface, which cause limitations of use, but
> > > are
> > > not so obviously related to the relationship between Disk and Vm as
> > > plugged.
> > > - Can be shared between several vm's, to some plugged and to some not
> > > plugged.
> > > - Will soon be optionally RO in one VM and RW in another, which is
> > > exactly
> > > the same as plugged, and therefore plugged issue should be fixed first.
> > > 
> > > Every column in that shows a disk in the UI receives a Disk entity, and
> > > show
> > > its contents, while plugged/unplugged is ignored when not in a VM
> > > context.
> > > The way things are now, using a VmDevice in the where we need it to show
> > > plug
> > > status, we'll also have to use it in all other columns, which is
> > > irrelevant
> > > and just totally not related.
> > > So using VmDevice in UI is a no go.
> > > 
> > > The UI is the main limitation forcing us to use something that extends
> > > Disk,
> > > and what I described below is the easiest thing to implement in the time
> > > restrictions we have without changing the entire system.
> > > 
> > > I think this answers all the questions not already answered by others.
> > > Regarding Maor suggestion - might be a good idea, but not in this scope
> > > or
> > > time-frame.
> > > 
> > > If there is any other/unanswered issue or objection to the design change
> > > please share.
> > > 
> > > I appreciate your inputs,
> > > Vered
> > > 
> > 
> > sorry i didnt understand why the current disk object isnt good enough,
> > you get a disk, some of its properties are valid only in some situations.
> > i think its easier to use instead of couple of different objects
> > representing
> > the same entity in different situations.
> 
> I totally agree with Omer, please specify what is impossible or hard to
> achieve with the current schema
No problem with DB schema, please see my answer in engine-devel, I'm not sure you're directly cc'ed.

> 
> > 
> > > 
> > > ----- Original Message -----
> > > > From: "Maor Lipchuk" <mlipchuk at redhat.com>
> > > > To: "Vered Volansky" <vered at redhat.com>
> > > > Cc: engine-devel at ovirt.org
> > > > Sent: Tuesday, May 28, 2013 1:49:46 PM
> > > > Subject: Re: [Engine-devel] Disk BE very small refactoring
> > > > 
> > > > I think the main problem is that we abuse the business entity to act as
> > > > an O/R mapping class to the DB and also to be used as a business entity
> > > > for presentation purposes.
> > > > 
> > > > I understand how Yair thought isPlugged could be fetched from vmDevice,
> > > > this is a confusing design, and it is just one example and more to
> > > > come.
> > > > 
> > > > I suggest that if we already thinking of changing the class hierarchy,
> > > > we can start by implementing a package for presentation classes for
> > > > transient classes such as this instead enforcing complex hierarchy.
> > > > 
> > > > The query class will fetch all the data from the DB and initialized the
> > > > transient class and send it to the client.
> > > > I think it could be a good start and will solve many issues we might
> > > > encounter in the future.
> > > > 
> > > > Regards,
> > > > Maor
> > > > 
> > > > On 05/28/2013 11:24 AM, Omer Frenkel wrote:
> > > > > 
> > > > > 
> > > > > ----- Original Message -----
> > > > >> From: "Yair Zaslavsky" <yzaslavs at redhat.com>
> > > > >> To: "Vered Volansky" <vered at redhat.com>
> > > > >> Cc: engine-devel at ovirt.org
> > > > >> Sent: Monday, May 27, 2013 6:22:58 PM
> > > > >> Subject: Re: [Engine-devel] Disk BE very small refactoring
> > > > >>
> > > > >> Vered,
> > > > >> VmDevice has "isPlugged" field,
> > > > >> Why not have somehow in your inheritence (either Disk or a subclass)
> > > > >> a
> > > > >> field
> > > > >> : "VmDevice device"
> > > > > 
> > > > > disk id is the device id, no need for field to represent the
> > > > > relation.
> > > > > the combination of disk-id and a specific entity (vm/template) will
> > > > > get
> > > > > you
> > > > > the other info
> > > > > 
> > > > >> and have isPlugged method called "device.isPlugged()" ?
> > > > >>
> > > > >> Then you can also add the readOnly property which is not represented
> > > > >> at
> > > > >> VmDevice.
> > > > >>
> > > > >>
> > > > >> Does this sound logical to you?
> > > > >>
> > > > >> ----- Original Message -----
> > > > >>> From: "Vered Volansky" <vered at redhat.com>
> > > > >>> To: engine-devel at ovirt.org
> > > > >>> Sent: Monday, May 27, 2013 6:18:58 PM
> > > > >>> Subject: [Engine-devel] Disk BE very small refactoring
> > > > >>>
> > > > >>> Hi All,
> > > > >>>
> > > > >>> Please express your opinion if you have any -
> > > > >>>
> > > > >>> Currently Disk BE has a plugged property, which should be a
> > > > >>> property
> > > > >>> of
> > > > >>> the
> > > > >>> relationship between vm(or template) and a disk.
> > > > >>> I plan to remove this property from the Disk entity, and add new
> > > > >>> entity,
> > > > >>> called DeviceDisk.
> > > > >>> This should inherit from Disk and contain the vm/template guid and
> > > > >>> the
> > > > >>> plugged property at first round.
> > > > >>> At second round it'll also contain the readOnly property, for RO
> > > > >>> disks,
> > > > >>> TBD
> > > > >>> right after.
> > > > >>>
> > > > >>> Appreciate any input,
> > > > >>> Vered
> > > > >>> _______________________________________________
> > > > >>> Engine-devel mailing list
> > > > >>> Engine-devel at ovirt.org
> > > > >>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > >>>
> > > > >> _______________________________________________
> > > > >> Engine-devel mailing list
> > > > >> Engine-devel at ovirt.org
> > > > >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > >>
> > > > > _______________________________________________
> > > > > Engine-devel mailing list
> > > > > Engine-devel at ovirt.org
> > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > > 
> > > > 
> > > > 
> > > > _______________________________________________
> > > > Engine-devel mailing list
> > > > Engine-devel at ovirt.org
> > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > 
> > > 
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From omasad at redhat.com  Sun Jun  2 09:04:37 2013
From: omasad at redhat.com (Ofri Masad)
Date: Sun, 2 Jun 2013 05:04:37 -0400 (EDT)
Subject: [Engine-devel] Network Quality of Service 3.3 - Feature design
In-Reply-To: <51AB02D2.6080200@redhat.com>
References: <273375846.6100303.1370156285221.JavaMail.root@redhat.com>
	<51AAF597.8090505@redhat.com>
	<1120708548.6101461.1370161498442.JavaMail.root@redhat.com>
	<51AB02D2.6080200@redhat.com>
Message-ID: <871946415.6102456.1370163877457.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Itamar Heim" <iheim at redhat.com>
> To: "Ofri Masad" <omasad at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>
> Sent: Sunday, June 2, 2013 11:31:14 AM
> Subject: Re: [Engine-devel] Network Quality of Service 3.3 - Feature design
> 
> On 06/02/2013 11:24 AM, Ofri Masad wrote:
> > Hi,
> > answers inline
> >
> > Thanks,
> > Ofri
> >
> > ----- Original Message -----
> >> From: "Itamar Heim" <iheim at redhat.com>
> >> To: "Ofri Masad" <omasad at redhat.com>
> >> Cc: "engine-devel" <engine-devel at ovirt.org>
> >> Sent: Sunday, June 2, 2013 10:34:47 AM
> >> Subject: Re: [Engine-devel] Network Quality of Service 3.3 - Feature
> >> design
> >>
> >> On 06/02/2013 09:58 AM, Ofri Masad wrote:
> >>> Hi all,
> >>>
> >>> A new Feature page for "Network Quality of Service" feature was
> >>> published.
> >>>
> >>> http://www.ovirt.org/Features/Design/Network_QoS
> >>>
> >>> You are more than welcome to share you thoughts and insights.
> >>>
> >>> Thanks,
> >>> Ofri.
> >>> _______________________________________________
> >>> Engine-devel mailing list
> >>> Engine-devel at ovirt.org
> >>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> >>>
> >>
> >>
> >> some questions:
> >> 1. "In the Add/Edit Network two parts will be added - one for the QoS
> >> properties of the network, the other for the QoS properties preset for
> >> VNICs attached to the network."
> >>
> >> so the first part of QoS for network is the limit of the logical network
> >> on the host for all vnic's associated to it, compared to other logical
> >> networks?
> >
> > Exactly. first part is the network level limitation.
> 
> ok. i guess in most cases it wouldn't make sense for network level and
> vnic level to be the same?
>

correct. For example: 
the administrator could limit the network level to 10,000 Mbps average, 20,000 Mbps peak, 100,000 Mb burst
and limit the vnic level to 2000 Mbps average, 5000 Mbps peak and 50,000Mb burst.
So each vnic on this network would be limited to 5000 Mbps in peak but all together those vnics could not exceed 20,000 Mbps. 
 
> ...
> >
> >>
> >> 3. "outbound_burst 	Bigint "
> >> just wondering - what numbers do you expect here that Integer like the
> >> average and peak is not enough?
> >>
> >
> > the units for the "burst" parameter are Mb (Mega bits). so, if we would
> > like to allow burst of over 4GB (Giga byte) we will need Bigint.
> 
> integer is up to +2147483647 (Mb)? that's way more than 4GB?
> 

You are correct.
Fixed in the wiki.

> ...
> >
> >
> >> 5. behavior with provider networks (quantum)?
> >
> > Traffic shaping using the Network QoS feature will be available only for
> > oVirt networks at this stage.
> 
> 1. please comment as much
> 2. btw, why? if libvirt is the one setting the traffic shaping, how
> would it be different for (some) quantum networks like bridge or ovs?

Please see Doron's answer.
I will add a comment to the summery to clarify this. 

> 
> Thanks,
>     Itamar
> 


From amureini at redhat.com  Sun Jun  2 09:19:53 2013
From: amureini at redhat.com (Allon Mureinik)
Date: Sun, 2 Jun 2013 05:19:53 -0400 (EDT)
Subject: [Engine-devel] Disk BE very small refactoring
In-Reply-To: <709493761.17349467.1370163775374.JavaMail.root@redhat.com>
References: <1543112346.12706449.1369667938808.JavaMail.root@redhat.com>
	<1454073553.8350387.1369668178246.JavaMail.root@redhat.com>
	<1021461587.13107769.1369729481376.JavaMail.root@redhat.com>
	<51A48BCA.5020509@redhat.com>
	<2012114925.13632941.1369762838851.JavaMail.root@redhat.com>
	<1369501327.15118945.1369902580919.JavaMail.root@redhat.com>
	<798173905.9398505.1369907846932.JavaMail.root@redhat.com>
	<709493761.17349467.1370163775374.JavaMail.root@redhat.com>
Message-ID: <685825195.2507121.1370164793205.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Vered Volansky" <vered at redhat.com>
> To: "Eli Mesika" <emesika at redhat.com>
> Cc: engine-devel at ovirt.org
> Sent: Sunday, June 2, 2013 12:02:55 PM
> Subject: Re: [Engine-devel] Disk BE very small refactoring
> 
> 
> 
> ----- Original Message -----
> > From: "Eli Mesika" <emesika at redhat.com>
> > To: "Vered Volansky" <vered at redhat.com>
> > Cc: engine-devel at ovirt.org
> > Sent: Thursday, May 30, 2013 12:57:26 PM
> > Subject: Re: [Engine-devel] Disk BE very small refactoring
> > 
> > 
> > 
> > ----- Original Message -----
> > > From: "Omer Frenkel" <ofrenkel at redhat.com>
> > > To: "Vered Volansky" <vered at redhat.com>
> > > Cc: engine-devel at ovirt.org
> > > Sent: Thursday, May 30, 2013 11:29:40 AM
> > > Subject: Re: [Engine-devel] Disk BE very small refactoring
> > > 
> > > 
> > > 
> > > ----- Original Message -----
> > > > From: "Vered Volansky" <vered at redhat.com>
> > > > To: "Maor Lipchuk" <mlipchuk at redhat.com>, "Yair Zaslavsky"
> > > > <yzaslavs at redhat.com>, "Omer Frenkel"
> > > > <ofrenkel at redhat.com>, "Mike Kolesnik" <mkolesni at redhat.com>, "Allon
> > > > Mureinik" <amureini at redhat.com>, "Daniel Erez"
> > > > <derez at redhat.com>
> > > > Cc: engine-devel at ovirt.org
> > > > Sent: Tuesday, May 28, 2013 8:40:38 PM
> > > > Subject: Re: [Engine-devel] Disk BE very small refactoring
> > > > 
> > > > I had a problem, didn't see all the replies till now.
> > > > 
> > > > I'll add some more info as to why we want to do this like we do.
> > > > It all started from adding the readOnly property to disks. It should
> > > > have
> > > > been handled like plugged is handled, yet plugged is a hack, and if we
> > > > don't
> > > > change that now, we'll only keep on adding unreasonable hacks.
> > > > 
> > > 
> > > please explain why you think plugged is a hack? what is wrong with it?
> > 
> > You have is_readonly and is_plugged in the device level , this is far from
> > being a hack and managed in the correct place since both may apply to
> > multiple device types (disk, nics ....)
> There's no problem with device level, only I can't use VmDevice (which is
> where this naturally belongs) in UI since it will cause a major change we
> don't want right now.
> Not only that, VmDevice does hold this info, but not other relevant info used
> in UI and available in Disk, so using VmDevice on it's own is not only to
> extensive a change, but also by far will not end there.
> 
> > 
> > > 
> > > > So from the start -
> > > > Disk currently:
> > > > - Sometimes represents a disk in a vm context and sometimes not.
> > > > - Holds plugged property, which is only relevant when a disk is in a vm
> > > > context, which already suggests this is not the natural place for it.
> > > > - Also holds bootable and interface, which cause limitations of use,
> > > > but
> > > > are
> > > > not so obviously related to the relationship between Disk and Vm as
> > > > plugged.
> > > > - Can be shared between several vm's, to some plugged and to some not
> > > > plugged.
> > > > - Will soon be optionally RO in one VM and RW in another, which is
> > > > exactly
> > > > the same as plugged, and therefore plugged issue should be fixed first.
> > > > 
> > > > Every column in that shows a disk in the UI receives a Disk entity, and
> > > > show
> > > > its contents, while plugged/unplugged is ignored when not in a VM
> > > > context.
> > > > The way things are now, using a VmDevice in the where we need it to
> > > > show
> > > > plug
> > > > status, we'll also have to use it in all other columns, which is
> > > > irrelevant
> > > > and just totally not related.
> > > > So using VmDevice in UI is a no go.
> > > > 
> > > > The UI is the main limitation forcing us to use something that extends
> > > > Disk,
> > > > and what I described below is the easiest thing to implement in the
> > > > time
> > > > restrictions we have without changing the entire system.
> > > > 
> > > > I think this answers all the questions not already answered by others.
> > > > Regarding Maor suggestion - might be a good idea, but not in this scope
> > > > or
> > > > time-frame.
> > > > 
> > > > If there is any other/unanswered issue or objection to the design
> > > > change
> > > > please share.
> > > > 
> > > > I appreciate your inputs,
> > > > Vered
> > > > 
> > > 
> > > sorry i didnt understand why the current disk object isnt good enough,
> > > you get a disk, some of its properties are valid only in some situations.
> > > i think its easier to use instead of couple of different objects
> > > representing
> > > the same entity in different situations.
> > 
> > I totally agree with Omer, please specify what is impossible or hard to
> > achieve with the current schema
> No problem with DB schema, please see my answer in engine-devel, I'm not sure
> you're directly cc'ed.
The way I see it, it's a design issue.
A disk is different from other devices as it can be attached to multiple VMs.
I.e., the same Disk record in the database is associated with either 0 device records (a floating disk), 1 device record (a normal disk) or multiple device records (shared disk).
The java object has a few properties that really belong to the disk (e.g., alias, size, wipeAfterDelete), some that belong to the device (plugged, readOnly in the near future) and  some the belong to ALL the VMs it's attached to (e.g., vmNames).

This way, the object is unusable - depending on which query you use to load it, you'll have a different set of properties set to null, which is unacceptable in modular code.
The suggestion here is simple - instead of needing to comment or somehow no what properties a function is allowed to use, make it explicit my moving these properties to a sensible object.

> 
> > 
> > > 
> > > > 
> > > > ----- Original Message -----
> > > > > From: "Maor Lipchuk" <mlipchuk at redhat.com>
> > > > > To: "Vered Volansky" <vered at redhat.com>
> > > > > Cc: engine-devel at ovirt.org
> > > > > Sent: Tuesday, May 28, 2013 1:49:46 PM
> > > > > Subject: Re: [Engine-devel] Disk BE very small refactoring
> > > > > 
> > > > > I think the main problem is that we abuse the business entity to act
> > > > > as
> > > > > an O/R mapping class to the DB and also to be used as a business
> > > > > entity
> > > > > for presentation purposes.
> > > > > 
> > > > > I understand how Yair thought isPlugged could be fetched from
> > > > > vmDevice,
> > > > > this is a confusing design, and it is just one example and more to
> > > > > come.
> > > > > 
> > > > > I suggest that if we already thinking of changing the class
> > > > > hierarchy,
> > > > > we can start by implementing a package for presentation classes for
> > > > > transient classes such as this instead enforcing complex hierarchy.
> > > > > 
> > > > > The query class will fetch all the data from the DB and initialized
> > > > > the
> > > > > transient class and send it to the client.
> > > > > I think it could be a good start and will solve many issues we might
> > > > > encounter in the future.
> > > > > 
> > > > > Regards,
> > > > > Maor
> > > > > 
> > > > > On 05/28/2013 11:24 AM, Omer Frenkel wrote:
> > > > > > 
> > > > > > 
> > > > > > ----- Original Message -----
> > > > > >> From: "Yair Zaslavsky" <yzaslavs at redhat.com>
> > > > > >> To: "Vered Volansky" <vered at redhat.com>
> > > > > >> Cc: engine-devel at ovirt.org
> > > > > >> Sent: Monday, May 27, 2013 6:22:58 PM
> > > > > >> Subject: Re: [Engine-devel] Disk BE very small refactoring
> > > > > >>
> > > > > >> Vered,
> > > > > >> VmDevice has "isPlugged" field,
> > > > > >> Why not have somehow in your inheritence (either Disk or a
> > > > > >> subclass)
> > > > > >> a
> > > > > >> field
> > > > > >> : "VmDevice device"
> > > > > > 
> > > > > > disk id is the device id, no need for field to represent the
> > > > > > relation.
> > > > > > the combination of disk-id and a specific entity (vm/template) will
> > > > > > get
> > > > > > you
> > > > > > the other info
> > > > > > 
> > > > > >> and have isPlugged method called "device.isPlugged()" ?
> > > > > >>
> > > > > >> Then you can also add the readOnly property which is not
> > > > > >> represented
> > > > > >> at
> > > > > >> VmDevice.
> > > > > >>
> > > > > >>
> > > > > >> Does this sound logical to you?
> > > > > >>
> > > > > >> ----- Original Message -----
> > > > > >>> From: "Vered Volansky" <vered at redhat.com>
> > > > > >>> To: engine-devel at ovirt.org
> > > > > >>> Sent: Monday, May 27, 2013 6:18:58 PM
> > > > > >>> Subject: [Engine-devel] Disk BE very small refactoring
> > > > > >>>
> > > > > >>> Hi All,
> > > > > >>>
> > > > > >>> Please express your opinion if you have any -
> > > > > >>>
> > > > > >>> Currently Disk BE has a plugged property, which should be a
> > > > > >>> property
> > > > > >>> of
> > > > > >>> the
> > > > > >>> relationship between vm(or template) and a disk.
> > > > > >>> I plan to remove this property from the Disk entity, and add new
> > > > > >>> entity,
> > > > > >>> called DeviceDisk.
> > > > > >>> This should inherit from Disk and contain the vm/template guid
> > > > > >>> and
> > > > > >>> the
> > > > > >>> plugged property at first round.
> > > > > >>> At second round it'll also contain the readOnly property, for RO
> > > > > >>> disks,
> > > > > >>> TBD
> > > > > >>> right after.
> > > > > >>>
> > > > > >>> Appreciate any input,
> > > > > >>> Vered
> > > > > >>> _______________________________________________
> > > > > >>> Engine-devel mailing list
> > > > > >>> Engine-devel at ovirt.org
> > > > > >>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > > >>>
> > > > > >> _______________________________________________
> > > > > >> Engine-devel mailing list
> > > > > >> Engine-devel at ovirt.org
> > > > > >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > > >>
> > > > > > _______________________________________________
> > > > > > Engine-devel mailing list
> > > > > > Engine-devel at ovirt.org
> > > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > > > 
> > > > > 
> > > > > 
> > > > > _______________________________________________
> > > > > Engine-devel mailing list
> > > > > Engine-devel at ovirt.org
> > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > > 
> > > > 
> > > _______________________________________________
> > > Engine-devel mailing list
> > > Engine-devel at ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > 
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From mkolesni at redhat.com  Sun Jun  2 10:20:00 2013
From: mkolesni at redhat.com (Mike Kolesnik)
Date: Sun, 2 Jun 2013 06:20:00 -0400 (EDT)
Subject: [Engine-devel] Network Quality of Service 3.3 - Feature design
In-Reply-To: <871946415.6102456.1370163877457.JavaMail.root@redhat.com>
References: <273375846.6100303.1370156285221.JavaMail.root@redhat.com>
	<51AAF597.8090505@redhat.com>
	<1120708548.6101461.1370161498442.JavaMail.root@redhat.com>
	<51AB02D2.6080200@redhat.com>
	<871946415.6102456.1370163877457.JavaMail.root@redhat.com>
Message-ID: <2061032976.10090064.1370168400763.JavaMail.root@redhat.com>

----- Original Message -----
> 
> 
> ----- Original Message -----
> > From: "Itamar Heim" <iheim at redhat.com>
> > To: "Ofri Masad" <omasad at redhat.com>
> > Cc: "engine-devel" <engine-devel at ovirt.org>
> > Sent: Sunday, June 2, 2013 11:31:14 AM
> > Subject: Re: [Engine-devel] Network Quality of Service 3.3 - Feature design
> > 
> > On 06/02/2013 11:24 AM, Ofri Masad wrote:
> > > Hi,
> > > answers inline
> > >
> > > Thanks,
> > > Ofri
> > >
> > > ----- Original Message -----
> > >> From: "Itamar Heim" <iheim at redhat.com>
> > >> To: "Ofri Masad" <omasad at redhat.com>
> > >> Cc: "engine-devel" <engine-devel at ovirt.org>
> > >> Sent: Sunday, June 2, 2013 10:34:47 AM
> > >> Subject: Re: [Engine-devel] Network Quality of Service 3.3 - Feature
> > >> design
> > >>
> > >> On 06/02/2013 09:58 AM, Ofri Masad wrote:
> > >>> Hi all,
> > >>>
> > >>> A new Feature page for "Network Quality of Service" feature was
> > >>> published.
> > >>>
> > >>> http://www.ovirt.org/Features/Design/Network_QoS
> > >>>
> > >>> You are more than welcome to share you thoughts and insights.
> > >>>
> > >>> Thanks,
> > >>> Ofri.
> > >>> _______________________________________________
> > >>> Engine-devel mailing list
> > >>> Engine-devel at ovirt.org
> > >>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> > >>>
> > >>
> > >>
> > >> some questions:
> > >> 1. "In the Add/Edit Network two parts will be added - one for the QoS
> > >> properties of the network, the other for the QoS properties preset for
> > >> VNICs attached to the network."
> > >>
> > >> so the first part of QoS for network is the limit of the logical network
> > >> on the host for all vnic's associated to it, compared to other logical
> > >> networks?
> > >
> > > Exactly. first part is the network level limitation.
> > 
> > ok. i guess in most cases it wouldn't make sense for network level and
> > vnic level to be the same?
> >
> 
> correct. For example:
> the administrator could limit the network level to 10,000 Mbps average,
> 20,000 Mbps peak, 100,000 Mb burst
> and limit the vnic level to 2000 Mbps average, 5000 Mbps peak and 50,000Mb
> burst.
> So each vnic on this network would be limited to 5000 Mbps in peak but all
> together those vnics could not exceed 20,000 Mbps.

IIUC this is not planned to be supported, so why add this setting at network
level if it doesn't mean anything?

>  
> > ...
> > >
> > >>
> > >> 3. "outbound_burst 	Bigint "
> > >> just wondering - what numbers do you expect here that Integer like the
> > >> average and peak is not enough?
> > >>
> > >
> > > the units for the "burst" parameter are Mb (Mega bits). so, if we would
> > > like to allow burst of over 4GB (Giga byte) we will need Bigint.
> > 
> > integer is up to +2147483647 (Mb)? that's way more than 4GB?
> > 
> 
> You are correct.
> Fixed in the wiki.
> 
> > ...
> > >
> > >
> > >> 5. behavior with provider networks (quantum)?
> > >
> > > Traffic shaping using the Network QoS feature will be available only for
> > > oVirt networks at this stage.
> > 
> > 1. please comment as much
> > 2. btw, why? if libvirt is the one setting the traffic shaping, how
> > would it be different for (some) quantum networks like bridge or ovs?
> 
> Please see Doron's answer.
> I will add a comment to the summery to clarify this.

Technically it is possible to let libvirt shape the traffic as it does for internal
networks.
It is correct that we should factor in Quantum QoS consideration, but since it's not
available yet do we really want to hold back this feature for Quantum provisioned networks?

I am not sure we should plan this far ahead given the partial data that we have, and would
rather see Quantum (and any other provider) networks supported.

On a different subject, some notes..

In Design you wrote for example "Leaving the QoS properties empty will result in using the
default setting defined"
You mean to check the box and not fill anything in the field?

The descriptions of "leaving empty" sound more like implementation details than design, and
they don't coincide with the UI mockups..

In Backend > Classes:
   engine.core.dao.network.VmNetworkDao - add support to the NetworkQoS field
What is VmNetworkDao?

   engine.core.dao.network.VmNetworkQoSDao - new Dao
Why not NetworkQoSDao?


From rgolan at redhat.com  Sun Jun  2 13:21:56 2013
From: rgolan at redhat.com (Roy Golan)
Date: Sun, 02 Jun 2013 16:21:56 +0300
Subject: [Engine-devel] OS info wiki
Message-ID: <51AB46F4.2090801@redhat.com>

Hi,

A new feature page for OS info is out: http://www.ovirt.org/OS_info

Please review.

Roy


From iheim at redhat.com  Sun Jun  2 19:15:27 2013
From: iheim at redhat.com (Itamar Heim)
Date: Sun, 02 Jun 2013 22:15:27 +0300
Subject: [Engine-devel] OS info wiki
In-Reply-To: <51AB46F4.2090801@redhat.com>
References: <51AB46F4.2090801@redhat.com>
Message-ID: <51AB99CF.1090902@redhat.com>

On 06/02/2013 04:21 PM, Roy Golan wrote:
> Hi,
>
> A new feature page for OS info is out: http://www.ovirt.org/OS_info
>
> Please review.
>
> Roy
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel

two questions:
1. windows os product key - this is known to be a "must be reconfigured 
by customer" to use, so vdc_options may be fine for it, and if not, a 
prepared template under /etc for overriding this field per relevant OS 
should come out of the box.

2. I18N - is this supported today? how does it work with the search by 
OS type? while at it - how does the search by os type works with this 
new mechanism?

Thanks,
    Itamar


From rgolan at redhat.com  Mon Jun  3 06:50:48 2013
From: rgolan at redhat.com (Roy Golan)
Date: Mon, 03 Jun 2013 09:50:48 +0300
Subject: [Engine-devel] OS info wiki
In-Reply-To: <51AB99CF.1090902@redhat.com>
References: <51AB46F4.2090801@redhat.com> <51AB99CF.1090902@redhat.com>
Message-ID: <51AC3CC8.6090901@redhat.com>

On Sun 02 Jun 2013 10:15:27 PM IDT, Itamar Heim wrote:
> On 06/02/2013 04:21 PM, Roy Golan wrote:
>> Hi,
>>
>> A new feature page for OS info is out: http://www.ovirt.org/OS_info
>>
>> Please review.
>>
>> Roy
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>
> two questions:
> 1. windows os product key - this is known to be a "must be
> reconfigured by customer" to use, so vdc_options may be fine for it,
> and if not, a prepared template under /etc for overriding this field
> per relevant OS should come out of the box.
>
by design a customer can drop  an 10-product-keys.properties under 
/etc/ovirt-engine/conf/osinfo.conf.d/ and have there
override the keys:
os.windows7.productKey=xxx
os.windows8.productKey=yyy
...
> 2. I18N - is this supported today? how does it work with the search by
> OS type? while at it - how does the search by os type works with this
> new mechanism?
>
I'm not sure this is supported today. Anyhow the search is by the 
VmOsType member name so
its actually the unique OS name and not the resource one
  VMs: os = rhel6x84

Witn the new mechanism, on load the UI queries the backend for a map of 
the osId->osUniqueNames and this
is passed to the UI searchbackend instance to populate a class which 
does the auto completion.

To make the search I18N I need to build a reverse lookup table for I18N 
labels -> uniqueOsName.

Another option is to still search by unique name and to draw the 
tooltip of the completion with both the uniqeName and the I18N name:




> Thanks,
>    Itamar




From rgolan at redhat.com  Mon Jun  3 06:57:43 2013
From: rgolan at redhat.com (Roy Golan)
Date: Mon, 03 Jun 2013 09:57:43 +0300
Subject: [Engine-devel] OS info wiki
In-Reply-To: <51AC3CC8.6090901@redhat.com>
References: <51AB46F4.2090801@redhat.com> <51AB99CF.1090902@redhat.com>
	<51AC3CC8.6090901@redhat.com>
Message-ID: <51AC3E67.8080603@redhat.com>

On 06/03/2013 09:50 AM, Roy Golan wrote:
> On Sun 02 Jun 2013 10:15:27 PM IDT, Itamar Heim wrote:
>> On 06/02/2013 04:21 PM, Roy Golan wrote:
>>> Hi,
>>>
>>> A new feature page for OS info is out: http://www.ovirt.org/OS_info
>>>
>>> Please review.
>>>
>>> Roy
>>> _______________________________________________
>>> Engine-devel mailing list
>>> Engine-devel at ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>
>> two questions:
>> 1. windows os product key - this is known to be a "must be
>> reconfigured by customer" to use, so vdc_options may be fine for it,
>> and if not, a prepared template under /etc for overriding this field
>> per relevant OS should come out of the box.
>>
> by design a customer can drop  an 10-product-keys.properties under 
> /etc/ovirt-engine/conf/osinfo.conf.d/ and have there
> override the keys:
> os.windows7.productKey=xxx
> os.windows8.productKey=yyy
> ...
>> 2. I18N - is this supported today? how does it work with the search by
>> OS type? while at it - how does the search by os type works with this
>> new mechanism?
>>
> I'm not sure this is supported today. Anyhow the search is by the 
> VmOsType member name so
> its actually the unique OS name and not the resource one
>  VMs: os = rhel6x84
>
> Witn the new mechanism, on load the UI queries the backend for a map 
> of the osId->osUniqueNames and this
> is passed to the UI searchbackend instance to populate a class which 
> does the auto completion.
>
> To make the search I18N I need to build a reverse lookup table for 
> I18N labels -> uniqueOsName.
>
> Another option is to still search by unique name and to draw the 
> tooltip of the completion with both the uniqeName and the I18N name:
>
>
>

>
>> Thanks,
>>    Itamar
>
>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130603/2a26cd05/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fedggeae.png
Type: image/png
Size: 10593 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130603/2a26cd05/attachment.png>

From iheim at redhat.com  Mon Jun  3 07:10:56 2013
From: iheim at redhat.com (Itamar Heim)
Date: Mon, 03 Jun 2013 10:10:56 +0300
Subject: [Engine-devel] OS info wiki
In-Reply-To: <51AC3CC8.6090901@redhat.com>
References: <51AB46F4.2090801@redhat.com> <51AB99CF.1090902@redhat.com>
	<51AC3CC8.6090901@redhat.com>
Message-ID: <51AC4180.7040904@redhat.com>

On 06/03/2013 09:50 AM, Roy Golan wrote:
> On Sun 02 Jun 2013 10:15:27 PM IDT, Itamar Heim wrote:
>> On 06/02/2013 04:21 PM, Roy Golan wrote:
>>> Hi,
>>>
>>> A new feature page for OS info is out: http://www.ovirt.org/OS_info
>>>
>>> Please review.
>>>
>>> Roy
>>> _______________________________________________
>>> Engine-devel mailing list
>>> Engine-devel at ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>
>> two questions:
>> 1. windows os product key - this is known to be a "must be
>> reconfigured by customer" to use, so vdc_options may be fine for it,
>> and if not, a prepared template under /etc for overriding this field
>> per relevant OS should come out of the box.
>>
> by design a customer can drop  an 10-product-keys.properties under
> /etc/ovirt-engine/conf/osinfo.conf.d/ and have there
> override the keys:
> os.windows7.productKey=xxx
> os.windows8.productKey=yyy

unlike the rest of the config file, here there are no defaults, so i'm 
suggesting you should place a .sample file for this in the appropriate 
/etc folder to help users

> ...
>> 2. I18N - is this supported today? how does it work with the search by
>> OS type? while at it - how does the search by os type works with this
>> new mechanism?
>>
> I'm not sure this is supported today. Anyhow the search is by the
> VmOsType member name so
> its actually the unique OS name and not the resource one
>   VMs: os = rhel6x84
>
> Witn the new mechanism, on load the UI queries the backend for a map of
> the osId->osUniqueNames and this
> is passed to the UI searchbackend instance to populate a class which
> does the auto completion.
>
> To make the search I18N I need to build a reverse lookup table for I18N
> labels -> uniqueOsName.
>
> Another option is to still search by unique name and to draw the tooltip
> of the completion with both the uniqeName and the I18N name:

search is not i18n today for everything else as well, so i would wait 
for a more global effort on this.



From tjelinek at redhat.com  Mon Jun  3 07:24:48 2013
From: tjelinek at redhat.com (Tomas Jelinek)
Date: Mon, 3 Jun 2013 03:24:48 -0400 (EDT)
Subject: [Engine-devel] static header only in VM dialog?
In-Reply-To: <1754688018.16770394.1370017699165.JavaMail.root@redhat.com>
References: <gerrit.1368170341473.Icad8098e286f821da25fac22fd0a840a42f105c9@gerrit.ovirt.org>
	<841607815.31395487.1369929419144.JavaMail.root@redhat.com>
	<2014639425.11839457.1369981377910.JavaMail.root@redhat.com>
	<1493549047.16382669.1370000699204.JavaMail.root@redhat.com>
	<73EDF069-94CA-4BEC-8464-F1006BA4954C@redhat.com>
	<909641716.16748965.1370015793965.JavaMail.root@redhat.com>
	<51A8C9BD.5040706@redhat.com>
	<1754688018.16770394.1370017699165.JavaMail.root@redhat.com>
Message-ID: <2128095245.12545499.1370244288395.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Einav Cohen" <ecohen at redhat.com>
> To: "Itamar Heim" <iheim at redhat.com>, "Tomas Jelinek" <tjelinek at redhat.com>
> Cc: "Michal Skrivanek" <michal.skrivanek at redhat.com>, "Eldan Hildesheim" <info at eldanet.com>, "engine-devel"
> <engine-devel at ovirt.org>, "Eldan Hildesheim" <ehildesh at redhat.com>, "Daniel Erez" <derez at redhat.com>, "Malini Rao"
> <mrao at redhat.com>
> Sent: Friday, May 31, 2013 6:28:19 PM
> Subject: Re: [Engine-devel] static header only in VM dialog?
> 
> > ----- Original Message -----
> > From: "Itamar Heim" <iheim at redhat.com>
> > Sent: Friday, May 31, 2013 12:03:09 PM
> > 
> > On 05/31/2013 06:56 PM, Einav Cohen wrote:
> > >>> ...
> > >>>
> > >>> [1] my main concern is that this batch of patches (dialog reorg) will
> > >>> make
> > >>> it into ovirt
> > >>> 3.3, but the second batch (which will contain the actual Instance Types
> > >>> fields) won't make
> > >>> it in time [see the ovirt 3.3 schedule in:
> > >>> http://www.ovirt.org/OVirt_3.3_release-management -
> > >>> ovirt 3.3 feature freeze is today (?!)]; so I wouldn't want to see
> > >>> ovirt
> > >>> 3.3 being released
> > >>> with only the first patch batch merged into it. either both batches
> > >>> should
> > >>> be there, or
> > >>> both batches should not be there.
> > >>
> > >> There was a discussion about postponing it, but not much further it
> > >> seems.
> > >> In any case It may not be necessarily wrong to have dialog reorg in 3.3
> > >> without insttypes as it will at least get people to get used to it and
> > >> we
> > >> can gather feedback. It's not that it removes any functionality, on the
> > >> contrary, e.g. the type ahead feature even solves some of the bugs we
> > >> already have.
> > >
> > > indeed - it doesn't remove functionality, and I agree that it would be a
> > > good
> > > opportunity to get feedback about some things such as the type-ahead list
> > > box,
> > > however the top static header in particular with only the DC/Cluster +
> > > Quota
> > > in it may seem strange / annoying, as it would just seem like something
> > > that
> > > takes up "real estate" in the dialog in *all* side-tab without a real
> > > good
> > > reason.
> > 
> > but the optimize for desktop/server already start to affect other panes?
> 
> quoting Tomas:
> 
> """
> the first patch we are talking about (http://gerrit.ovirt.org/#/c/14635)
> adds only Data Center, Cluster and Quota to the header.
> There is a second patch (http://gerrit.ovirt.org/#/c/15011/) which moves the
> OS type and
> template to the header.
> """
> 
> so IIUC, the first patch batch [2] will include moving the following fields
> into the
> static header:
> 
> - DataCenter/Cluster
> - Quota
> - OS type
> - Template
> 
> @Tomas - I suggest that you will clarify:
> 
> A) which fields exactly are going to be included in the top static header of
> the New VM
> dialog *in your current patch batch* [2], and:
- Data Center
- Cluster
- Quota
- Template (because according to the mockup the Image field will contain both Template and Image, so until we have images, just templates are there)
- Vm Type (e.g. if server or desktop)
- OS type
(well, basically according to mockup, just without the instance type)

> 
> B) which side-tabs in the New VM dialog will be affected by the fields in
> (A).
More or less all with some exceptions - especially thanx to the template field. And this will not change at all after introducing instance types/templates because
template = instance type + image. So the question is not really if we want to wait until the instance types and images will affect enough side tabs (because that
will not change at all) but if we want to have a top header panel or not. I personally start to think that it is more or less a question of taste. 
One may argue that it makes the dialogs more understandable (by having context all the time) and other that it makes them more un-understandable by flood of information in context you don't need.
I guess either way has some advantages and disadvantages and there is no strict good/wrong solution. 

> 
> [there is a chance that the fields in (A) already affect a lot of the
> side-tabs, which means
> that it would actually make sense to introduce the top static section in the
> current patch
> batch, even without the Instance Types / Images fields included in it, which
> is what (I think)
> Itamar is implying]
> 
> 
> [2] the current patch batch, to my understanding, is:
> 
> http://gerrit.ovirt.org/#/c/14635/
> http://gerrit.ovirt.org/#/c/14810/
> http://gerrit.ovirt.org/#/c/14936/
> http://gerrit.ovirt.org/#/c/15011/
> http://gerrit.ovirt.org/#/c/15048/
> http://gerrit.ovirt.org/#/c/15102/
> http://gerrit.ovirt.org/#/c/15199/
> 
> 
> > 
> > >
> > > so there are pros and cons for introducing only the first patch batch to
> > > ovirt-3.3,
> > > I guess; Ideally, I would suggest to maybe re-organize the patches a bit
> > > differently,
> > > so that the top static header in particular wouldn't be part of this
> > > first
> > > patch batch,
> > > i.e., I would suggest introducing the top static header along with adding
> > > the Instance
> > > Types fields [which, to my understanding, is exactly what Daniel has
> > > originally suggested
> > > on the patch [1] in his gerrit comment(s) from May 28/29 (depends on the
> > > timezone) -
> > > only now I fully understand his concern (I think/hope)...].
> > >
> > > not sure how easy it is to do though - I know that *a lot* of time and
> > > effort were
> > > already invested in these patches as they are now, and I wouldn't want
> > > that
> > > the reviewing/
> > > merging process will be held off for much longer.
> > >
> > > To sum up: these are the options, as I see them:
> > >
> > > 1) keep the current patch batch as is and:
> > >
> > >     a. merge it in time for ovirt-3.3, or:
> > >
> > >     b. merge it post ovirt-3.3.
> > >
> > > - or -
> > >
> > > 2) go with what Daniel has suggested in his gerrit comment: reorganize
> > > the
> > > patches so that
> > > the top static header would be introduced only along with the instance
> > > types fields [that
> > > way, it won't matter what makes it into ovirt-3.3 - the first patch
> > > batch,
> > > or both (or none)].
> > >
> > > I am in favor of (1.b) or (2). However, weighing the cons of (1.a)
> > > against
> > > the pros of (1.a) /
> > > cons of (1.b) or against the effort that (2) will require, and taking
> > > into
> > > consideration the
> > > effort that was already invested, I am not strongly against (1.a) as
> > > well.
> > >
> > > [1] http://gerrit.ovirt.org/#/c/14635/
> > >
> > >> ...
> > >
> > >
> > 
> > 
> 


From ecohen at redhat.com  Mon Jun  3 12:26:45 2013
From: ecohen at redhat.com (Einav Cohen)
Date: Mon, 3 Jun 2013 08:26:45 -0400 (EDT)
Subject: [Engine-devel] static header only in VM dialog?
In-Reply-To: <2128095245.12545499.1370244288395.JavaMail.root@redhat.com>
References: <gerrit.1368170341473.Icad8098e286f821da25fac22fd0a840a42f105c9@gerrit.ovirt.org>
	<2014639425.11839457.1369981377910.JavaMail.root@redhat.com>
	<1493549047.16382669.1370000699204.JavaMail.root@redhat.com>
	<73EDF069-94CA-4BEC-8464-F1006BA4954C@redhat.com>
	<909641716.16748965.1370015793965.JavaMail.root@redhat.com>
	<51A8C9BD.5040706@redhat.com>
	<1754688018.16770394.1370017699165.JavaMail.root@redhat.com>
	<2128095245.12545499.1370244288395.JavaMail.root@redhat.com>
Message-ID: <1088136010.17701900.1370262405492.JavaMail.root@redhat.com>

> > ...
> > 
> > @Tomas - I suggest that you will clarify:
> > 
> > A) which fields exactly are going to be included in the top static header
> > of
> > the New VM
> > dialog *in your current patch batch* [2], and:
> 
> - Data Center
> - Cluster
> - Quota
> - Template (because according to the mockup the Image field will contain both
> Template and Image, so until we have images, just templates are there)
> - Vm Type (e.g. if server or desktop)
> - OS type
> (well, basically according to mockup, just without the instance type)
> 
> > 
> > B) which side-tabs in the New VM dialog will be affected by the fields in
> > (A).
> 
> More or less all with some exceptions - especially thanx to the template
> field. And this will not change at all after introducing instance
> types/templates because template = instance type + image. 

So it seems that it would make sense to introduce the top static header even 
before introducing the Instance Types + Image fields, as it already contains 
fields (namely 'Template') that affect most of the side-tabs.
Thanks, Tomas, for the clarification.

> So the question is not really if we want to
> wait until the instance types and images will affect enough side tabs
> (because that
> will not change at all) but if we want to have a top header panel or not. I
> personally start to think that it is more or less a question of taste.
> One may argue that it makes the dialogs more understandable (by having
> context all the time) and other that it makes them more un-understandable by
> flood of information in context you don't need.
> I guess either way has some advantages and disadvantages and there is no
> strict good/wrong solution.

+1

> ...


From mrao at redhat.com  Mon Jun  3 13:58:30 2013
From: mrao at redhat.com (Malini Rao)
Date: Mon, 3 Jun 2013 09:58:30 -0400 (EDT)
Subject: [Engine-devel] static header only in VM dialog?
In-Reply-To: <1088136010.17701900.1370262405492.JavaMail.root@redhat.com>
References: <gerrit.1368170341473.Icad8098e286f821da25fac22fd0a840a42f105c9@gerrit.ovirt.org>
	<1493549047.16382669.1370000699204.JavaMail.root@redhat.com>
	<73EDF069-94CA-4BEC-8464-F1006BA4954C@redhat.com>
	<909641716.16748965.1370015793965.JavaMail.root@redhat.com>
	<51A8C9BD.5040706@redhat.com>
	<1754688018.16770394.1370017699165.JavaMail.root@redhat.com>
	<2128095245.12545499.1370244288395.JavaMail.root@redhat.com>
	<1088136010.17701900.1370262405492.JavaMail.root@redhat.com>
Message-ID: <933117150.38946446.1370267910493.JavaMail.root@redhat.com>





----- Original Message -----
> From: "Einav Cohen" <ecohen at redhat.com>
> To: "Tomas Jelinek" <tjelinek at redhat.com>, "Daniel Erez" <derez at redhat.com>
> Cc: "Itamar Heim" <iheim at redhat.com>, "Michal Skrivanek" <michal.skrivanek at redhat.com>, "Eldan Hildesheim"
> <info at eldanet.com>, "engine-devel" <engine-devel at ovirt.org>, "Eldan Hildesheim" <ehildesh at redhat.com>, "Malini Rao"
> <mrao at redhat.com>
> Sent: Monday, June 3, 2013 8:26:45 AM
> Subject: Re: [Engine-devel] static header only in VM dialog?
> 
> > > ...
> > > 
> > > @Tomas - I suggest that you will clarify:
> > > 
> > > A) which fields exactly are going to be included in the top static header
> > > of
> > > the New VM
> > > dialog *in your current patch batch* [2], and:
> > 
> > - Data Center
> > - Cluster
> > - Quota
> > - Template (because according to the mockup the Image field will contain
> > both
> > Template and Image, so until we have images, just templates are there)
> > - Vm Type (e.g. if server or desktop)
> > - OS type
> > (well, basically according to mockup, just without the instance type)
> > 
> > > 
> > > B) which side-tabs in the New VM dialog will be affected by the fields in
> > > (A).
> > 
> > More or less all with some exceptions - especially thanx to the template
> > field. And this will not change at all after introducing instance
> > types/templates because template = instance type + image.
> 
> So it seems that it would make sense to introduce the top static header even
> before introducing the Instance Types + Image fields, as it already contains
> fields (namely 'Template') that affect most of the side-tabs.
> Thanks, Tomas, for the clarification.
> 
> > So the question is not really if we want to
> > wait until the instance types and images will affect enough side tabs
> > (because that
> > will not change at all) but if we want to have a top header panel or not. I
> > personally start to think that it is more or less a question of taste.
> > One may argue that it makes the dialogs more understandable (by having
> > context all the time) and other that it makes them more un-understandable
> > by
> > flood of information in context you don't need.
> > I guess either way has some advantages and disadvantages and there is no
> > strict good/wrong solution.
> 
> +1

One way to limit this flooding of information in unnecessary contexts is to not apply a blind rule that the static panel will appear for all dialogs with sub tabs. As outlined in a previous email, the static panel should be used only if there is a  dependency and it is impossible to show the interdependent fields on the same page. The other important thing we should do is very carefully consider what fields populate the static panel. The idea is that this panel is minimal and should definitely not becoming like a page in itself.

-Malini


> 
> > ...
> 


From kmayilsa at redhat.com  Mon Jun  3 14:45:39 2013
From: kmayilsa at redhat.com (Kanagaraj)
Date: Mon, 03 Jun 2013 20:15:39 +0530
Subject: [Engine-devel] Failed to configure management network on the host
Message-ID: <51ACAC13.9040000@redhat.com>

Hi,

  After adding a host to a 3.2 cluster, bootstrap went through fine and 
in the end it failed with the following error.

"Host s2 installation failed. Failed to configure manamgent network on 
the host."

Attached engine.log and vdsm.log

Vdsm rpms:
vdsm-4.10.2-22.2.el6rhs.x86_64
vdsm-python-4.10.2-22.2.el6rhs.x86_64
vdsm-cli-4.10.2-22.2.el6rhs.noarch
vdsm-gluster-4.10.2-22.2.el6rhs.noarch
vdsm-xmlrpc-4.10.2-22.2.el6rhs.noarch

Engine rpms: recent code from master

Can someone please help in resolving this issue,

Thanks,
Kanagaraj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: engine.log
Type: text/x-log
Size: 257227 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130603/0ff008fe/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vdsm.log
Type: text/x-log
Size: 34085 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130603/0ff008fe/attachment-0001.bin>

From deadhorseconsulting at gmail.com  Mon Jun  3 18:50:44 2013
From: deadhorseconsulting at gmail.com (Dead Horse)
Date: Mon, 3 Jun 2013 13:50:44 -0500
Subject: [Engine-devel] Odd Host Activation with mgmt-if
In-Reply-To: <259919713.2325611.1368964886494.JavaMail.root@redhat.com>
References: <CAEWPe=oX94UBGnph+5hePnJSyQBneU3-u7QCRwthzmJsZTBm3Q@mail.gmail.com>
	<CAEWPe=qtPwFC2_SEiFV+TdZjbptSy4pig2SOJE7iWAaBHR6YAw@mail.gmail.com>
	<700182034.3868949.1368945573602.JavaMail.root@redhat.com>
	<1793944165.3869028.1368945795602.JavaMail.root@redhat.com>
	<58289927.2323676.1368958529064.JavaMail.root@redhat.com>
	<703471633.2325369.1368964003055.JavaMail.root@redhat.com>
	<259919713.2325611.1368964886494.JavaMail.root@redhat.com>
Message-ID: <CAEWPe=qQt88K=cbHfhOw1ZPnCBHG2gCBADcrL+kSSQkjOzncNA@mail.gmail.com>

I actually have security disabled on the setup.
Settings wise
EnableSpiceRootCertificateValidation=false
SSLEnabled=false
UseSecureConnectionWithServers=false

I have been adding the hosts by the IP address of their mgmt-if
(ovirtmgmt). I do this since this is an isolated private subnet
specifically for management traffic only. No DNS or name resolution exists
there side for using hard entries /etc/hosts on each node and the engine
host.

I have attached the getcaps output.

- DHC


On Sun, May 19, 2013 at 7:01 AM, Alon Bar-Lev <alonbl at redhat.com> wrote:

>
>
> ----- Original Message -----
> > From: "Yaniv Bronheim" <ybronhei at redhat.com>
> > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > Cc: "Oded Ramraz" <oramraz at redhat.com>, "Moti Asayag" <
> masayag at redhat.com>, engine-devel at ovirt.org
> > Sent: Sunday, May 19, 2013 2:46:43 PM
> > Subject: Re: [Engine-devel] Odd Host Activation with mgmt-if
> >
> > Its true only if you add the host by using an hostname and not by
> explicit
> > IP, with IP you can pass 0 to vdsClient and it works
>
> I don't think so... even if you enrolled using ip address, it will fail as
> 0 tries to access using localhost as far as I remember.
>
> >
> > ----- Original Message -----
> > > From: "Alon Bar-Lev" <alonbl at redhat.com>
> > > To: "Oded Ramraz" <oramraz at redhat.com>, "Moti Asayag" <
> masayag at redhat.com>
> > > Cc: engine-devel at ovirt.org, "Yaniv Bronheim" <ybronhei at redhat.com>
> > > Sent: Sunday, May 19, 2013 1:15:29 PM
> > > Subject: Re: [Engine-devel] Odd Host Activation with mgmt-if
> > >
> > >
> > > Most probably, when SSL is enabled and configured properly this will
> not
> > > work...
> > >
> > > One need:
> > >
> > > vdsClient -s <hostname_as_specified_in_certificate> ....
> > >
> > > ----- Original Message -----
> > > > From: "Oded Ramraz" <oramraz at redhat.com>
> > > > To: "Moti Asayag" <masayag at redhat.com>
> > > > Cc: engine-devel at ovirt.org
> > > > Sent: Sunday, May 19, 2013 9:43:15 AM
> > > > Subject: Re: [Engine-devel] Odd Host Activation with mgmt-if
> > > >
> > > > small correction ( typo ) : 'vdsClient -s 0 getVdsCapabilities'
> > > >
> > > > Oded.
> > > >
> > > > ----- Original Message -----
> > > > From: "Moti Asayag" <masayag at redhat.com>
> > > > To: "Dead Horse" <deadhorseconsulting at gmail.com>
> > > > Cc: engine-devel at ovirt.org
> > > > Sent: Sunday, May 19, 2013 9:39:33 AM
> > > > Subject: Re: [Engine-devel] Odd Host Activation with mgmt-if
> > > >
> > > > Could you provide the output of the 'vdsClient -s 0
> getVdsCapavilities'
> > > > for
> > > > the specific host?
> > > >
> > > > ----- Original Message -----
> > > > > From: "Dead Horse" <deadhorseconsulting at gmail.com>
> > > > > To: engine-devel at ovirt.org
> > > > > Sent: Friday, May 17, 2013 12:21:47 AM
> > > > > Subject: Re: [Engine-devel] Odd Host Activation with mgmt-if
> > > > >
> > > > > Still puzzling on this all I get for an error when I see it is:
> > > > > WARN [org.ovirt.engine.core.bll.
> > > > > network.host.SetupNetworksCommand] (pool-5-thread-42) [21543ac]
> > > > > CanDoAction
> > > > > of action SetupNetworks failed.
> > > > >
> Reasons:VAR__ACTION__SETUP,VAR__TYPE__NETWORKS,NETWORKS_ALREADY_ATTACHED_TO_IFACES,$NETWORKS_ALREADY_ATTACHED_TO_IFACES_LIST
> > > > > ovirtmgmt
> > > > >
> > > > > Nothing is logged VDSM wise other then the above standard host
> > > > > activation
> > > > > probe.
> > > > >
> > > > > - DHC
> > > > >
> > > > >
> > > > >
> > > > > On Mon, May 13, 2013 at 1:19 PM, Dead Horse <
> > > > > deadhorseconsulting at gmail.com
> > > > > >
> > > > > wrote:
> > > > >
> > > > >
> > > > >
> > > > > Seeing this as of late when activating hosts. The odd this is that
> it
> > > > > reports
> > > > > a failure to activate the host (EL6.4) but still does it anyways.
> > > > >
> > > > > Engine side:
> > > > >
> > > > > 2013-05-13 12:53:38,547 INFO
> > > > > [org.ovirt.engine.core.bll.HandleVdsVersionCommand]
> (pool-5-thread-42)
> > > > > [21543ac] Running command: HandleVdsVersionCommand internal: true.
> > > > > Entities
> > > > > affected : ID: 15f11023-9746-49de-b33f-e3cc7dca6f65 Type: VDS
> > > > > 2013-05-13 12:53:38,549 INFO
> > > > > [org.ovirt.engine.core.vdsbroker.ActivateVdsVDSCommand]
> > > > > (pool-5-thread-42)
> > > > > [21543ac] FINISH, ActivateVdsVDSCommand, return: Host[durotar],
> log id:
> > > > > 3796a7bd
> > > > > 2013-05-13 12:53:38,625 WARN
> > > > > [org.ovirt.engine.core.bll.network.host.SetupNetworksCommand]
> > > > > (pool-5-thread-42) [21543ac] CanDoAction of action SetupNetworks
> > > > > failed.
> > > > >
> Reasons:VAR__ACTION__SETUP,VAR__TYPE__NETWORKS,NETWORKS_ALREADY_ATTACHED_TO_IFACES,$NETWORKS_ALREADY_ATTACHED_TO_IFACES_LIST
> > > > > ovirtmgmt
> > > > > 2013-05-13 12:53:39,368 INFO
> > > > > [org.ovirt.engine.core.bll.ActivateVdsCommand]
> > > > > (pool-5-thread-42) [21543ac] Activate finished. Lock released.
> > > > > Monitoring
> > > > > can run now for host durotar from data-center Azeroth
> > > > >
> > > > > VDSM Side:
> > > > >
> > > > > Thread-13::DEBUG::2013-05-13
> > > > > 12:53:37,841::BindingXMLRPC::933::vds::(wrapper)
> > > > > return getCapabilities with {'status': {'message': 'Done', 'code':
> 0},
> > > > > 'info': {'HBAInventory': {'iSCSI': [{'InitiatorName':
> > > > > 'iqn.2012-09.net.azeroth:durotar'}], 'FC': []}, 'packages2':
> {'kernel':
> > > > > {'release': '358.6.1.el6.x86_64', 'buildtime': 1366751713.0,
> 'version':
> > > > > '2.6.32'}, 'glusterfs-rdma': {'release': '0.3.alpha3.el6',
> 'buildtime':
> > > > > 1367604893L, 'version': '3.4.0'}, 'glusterfs-fuse': {'release':
> > > > > '0.3.alpha3.el6', 'buildtime': 1367604893L, 'version': '3.4.0'},
> > > > > 'spice-server': {'release': '12.el6', 'buildtime': 1361573005L,
> > > > > 'version':
> > > > > '0.12.0'}, 'vdsm': {'release': '17.el6', 'buildtime': 1368196305L,
> > > > > 'version': '4.10.3'}, 'qemu-kvm': {'release': '2.355.el6_4.2',
> > > > > 'buildtime':
> > > > > 1362691270L, 'version': '0.12.1.2'}, 'qemu-img': {'release':
> > > > > '2.355.el6_4.2', 'buildtime': 1362691270L, 'version': '0.12.1.2'},
> > > > > 'libvirt': {'release': '18.el6_4.4', 'buildtime': 1366301801L,
> > > > > 'version':
> > > > > '0.10.2'}, 'glusterfs': {'release': '0.3.alpha3.el6', 'buildtime':
> > > > > 1367604893L, 'version': '3.4.0'}, 'mom': {'release': '1.el6',
> > > > > 'buildtime':
> > > > > 1349470062L, 'version': '0.3.0'}, 'glusterfs-server': {'release':
> > > > > '0.3.alpha3.el6', 'buildtime': 1367604893L, 'version': '3.4.0'}},
> > > > > 'cpuModel': 'Intel(R) Xeon(R) CPU X5570 @ 2.93GHz', 'hooks':
> > > > > {'before_vm_start': {'50_sriov': {'md5':
> > > > > '3ebc60cd2e4eb089820102285fad7c45'}, '50_pincpu': {'md5':
> > > > > '0b5fb99ff0e7acb9ad534b87c02c59e3'}, '50_qos': {'md5':
> > > > > '18b596a6b4e4bad80357f240ba122a5e'}, '50_vmfex': {'md5':
> > > > > '9f5abb892ddb6b3daa779985d38d9f55'}, '50_scratchpad': {'md5':
> > > > > '7db25a4b8cb04f6e7132cb7c2300c111'}, '50_numa': {'md5':
> > > > > '5008c2826714ac5b63748780aabd2f25'}, '50_floppy': {'md5':
> > > > > '202fe18705a7d4c50c40c126e8f8dbe8'}, '50_qemucmdline': {'md5':
> > > > > 'a884929ad6f5eb039887157288867409'}, '50_macspoof': {'md5':
> > > > > '25deea559772719
> > > > >
> > > > > - DHC
> > > > >
> > > > >
> > > > > _______________________________________________
> > > > > Engine-devel mailing list
> > > > > Engine-devel at ovirt.org
> > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > >
> > > > _______________________________________________
> > > > Engine-devel mailing list
> > > > Engine-devel at ovirt.org
> > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > _______________________________________________
> > > > Engine-devel mailing list
> > > > Engine-devel at ovirt.org
> > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > >
> > >
> >
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130603/3d757c09/attachment.html>
-------------- next part --------------
[root at kezan ~]# vdsClient localhost  getVdsCapabilities
	HBAInventory = {'FC': [], 'iSCSI': [{'InitiatorName': 'iqn.2012-09.net.azeroth:kezan'}]}
	ISCSIInitiatorName = 'iqn.2012-09.net.azeroth:kezan'
	bondings = {'bond0': {'addr': '',
	                      'cfg': {'BONDING_OPTS': 'mode=4 miimon=250 xmit_hash_policy=layer2+3',
	                              'BOOTPROTO': 'none',
	                              'BRIDGE': 'maelstrom',
	                              'DEVICE': 'bond0',
	                              'IPV6INIT': 'no',
	                              'ONBOOT': 'yes'},
	                      'hwaddr': '00:21:28:83:ce:48',
	                      'ipv6addrs': ['fe80::221:28ff:fe83:ce48/64'],
	                      'mtu': '1500',
	                      'netmask': '',
	                      'slaves': ['eth0', 'eth1']},
	            'bond1': {'addr': '3.70.204.31',
	                      'cfg': {'BONDING_OPTS': 'mode=4 miimon=250 xmit_hash_policy=layer2+3',
	                              'BOOTPROTO': 'none',
	                              'DEVICE': 'bond1',
	                              'IPADDR': '3.70.204.31',
	                              'IPV6INIT': 'no',
	                              'ONBOOT': 'yes',
	                              'PREFIX': '22'},
	                      'hwaddr': '00:21:28:83:ce:4a',
	                      'ipv6addrs': ['fe80::221:28ff:fe83:ce4a/64'],
	                      'mtu': '1500',
	                      'netmask': '255.255.252.0',
	                      'slaves': ['eth2', 'eth3']},
	            'bond2': {'addr': '',
	                      'cfg': {'BONDING_OPTS': 'mode=4 miimon=250 xmit_hash_policy=layer2+3',
	                              'BOOTPROTO': 'none',
	                              'BRIDGE': 'ovirtmgmt',
	                              'DEVICE': 'bond2',
	                              'IPV6INIT': 'no',
	                              'ONBOOT': 'yes'},
	                      'hwaddr': '00:15:17:00:10:0a',
	                      'ipv6addrs': ['fe80::215:17ff:fe00:100a/64'],
	                      'mtu': '1500',
	                      'netmask': '',
	                      'slaves': ['eth4', 'eth5']},
	            'bond3': {'addr': '',
	                      'cfg': {},
	                      'hwaddr': '00:00:00:00:00:00',
	                      'ipv6addrs': [],
	                      'mtu': '1500',
	                      'netmask': '',
	                      'slaves': []},
	            'bond4': {'addr': '',
	                      'cfg': {},
	                      'hwaddr': '00:00:00:00:00:00',
	                      'ipv6addrs': [],
	                      'mtu': '1500',
	                      'netmask': '',
	                      'slaves': []}}
	bridges = {'maelstrom': {'addr': '',
	                         'cfg': {'BOOTPROTO': 'none',
	                                 'DELAY': '0',
	                                 'DEVICE': 'maelstrom',
	                                 'IPV6INIT': 'no',
	                                 'ONBOOT': 'yes',
	                                 'STP': 'off',
	                                 'TYPE': 'Bridge'},
	                         'gateway': '0.0.0.0',
	                         'ipv6addrs': ['fe80::221:28ff:fe83:ce48/64'],
	                         'ipv6gateway': '::',
	                         'mtu': '1500',
	                         'netmask': '',
	                         'ports': ['bond0'],
	                         'stp': 'off'},
	           'ovirtmgmt': {'addr': '3.57.111.31',
	                         'cfg': {'BOOTPROTO': 'none',
	                                 'DELAY': '0',
	                                 'DEVICE': 'ovirtmgmt',
	                                 'IPADDR': '3.57.111.31',
	                                 'IPV6INIT': 'no',
	                                 'ONBOOT': 'yes',
	                                 'PREFIX': '22',
	                                 'STP': 'off',
	                                 'TYPE': 'Bridge'},
	                         'gateway': '0.0.0.0',
	                         'ipv6addrs': ['fe80::215:17ff:fe00:100a/64',
	                                       'fec0::a:215:17ff:fe00:100a/64',
	                                       '2002:339:6d53:a:215:17ff:fe00:100a/64',
	                                       '2002:32d:1611:a:215:17ff:fe00:100a/64'],
	                         'ipv6gateway': '::',
	                         'mtu': '1500',
	                         'netmask': '255.255.252.0',
	                         'ports': ['bond2'],
	                         'stp': 'off'}}
	clusterLevels = ['3.0', '3.1', '3.2', '3.3']
	cpuCores = '8'
	cpuFlags = 'fpu,vme,de,pse,tsc,msr,pae,mce,cx8,apic,sep,mtrr,pge,mca,cmov,pat,pse36,clflush,dts,acpi,mmx,fxsr,sse,sse2,ss,ht,tm,pbe,syscall,nx,rdtscp,lm,constant_tsc,arch_perfmon,pebs,bts,rep_good,nopl,xtopology,nonstop_tsc,aperfmperf,pni,dtes64,monitor,ds_cpl,vmx,est,tm2,ssse3,cx16,xtpr,pdcm,dca,sse4_1,sse4_2,popcnt,lahf_lm,ida,dts,tpr_shadow,vnmi,flexpriority,ept,vpid,model_Nehalem,model_Conroe,model_coreduo,model_core2duo,model_Penryn,model_n270'
	cpuModel = 'Intel(R) Xeon(R) CPU           E5540  @ 2.53GHz'
	cpuSockets = '2'
	cpuSpeed = '2534.000'
	cpuThreads = '16'
	emulatedMachines = ['rhel6.4.0',
	                    'pc',
	                    'rhel6.3.0',
	                    'rhel6.2.0',
	                    'rhel6.1.0',
	                    'rhel6.0.0',
	                    'rhel5.5.0',
	                    'rhel5.4.4',
	                    'rhel5.4.0']
	guestOverhead = '65'
	hooks = {'after_vm_destroy': {'50_directlun': {'md5': '6d05c19e68a141eeb7ee5981d68c0cfa'},
	                              '50_hostusb': {'md5': '0a37bf0a26546e3ab5e424b13653ce2b'},
	                              '50_hugepages': {'md5': '4a980b78f8ee908bf2c61ea9bf156f4a'},
	                              '50_scratchpad': {'md5': '316d21a669f97e83b485b45ab0b23eee'},
	                              '50_sriov': {'md5': '5890b2899d450495a62f3611fad3c526'}},
	         'after_vm_start': {'50_promisc': {'md5': '5ea469fa06dd7cd1e52508672a7519db'}},
	         'before_vm_destroy': {'50_promisc': {'md5': 'dae0434ea8ca2492422a6fde5cc47a1e'}},
	         'before_vm_migrate_destination': {'50_directlun': {'md5': '8a29ce41de079630cb58d48e280d55c2'},
	                                           '50_hugepages': {'md5': '6ddc484746297308b9f9acc5fcabaf10'},
	                                           '50_vmfex': {'md5': 'eac2633f47fb309b4a5b7fe76531baec'}},
	         'before_vm_migrate_source': {'50_floppy': {'md5': 'c68fb91d44105c8b6f2d80566314027a'},
	                                      '50_hostusb': {'md5': 'e50a0975acd8bafd0052b65a787c2fdd'},
	                                      '50_scratchpad': {'md5': 'be90995f959c60c5110c6a0bef67c7b8'},
	                                      '50_sriov': {'md5': '47a59103b7c8b1439ae17dcd5ed197cd'}},
	         'before_vm_start': {'50_directlun': {'md5': '5380575c0e80dc9907ab874393ad30a0'},
	                             '50_fileinject': {'md5': '290dafd45601e010e0f496fa5b889a76'},
	                             '50_floppy': {'md5': '202fe18705a7d4c50c40c126e8f8dbe8'},
	                             '50_hostusb': {'md5': '21c58568f3eae4f0d091005e0eff891a'},
	                             '50_hugepages': {'md5': '6713d703f9d316f1664145b700cd7904'},
	                             '50_isolatedprivatevlan': {'md5': '0a25d7cd0b807ea5e0dfc3318ee98c91'},
	                             '50_macspoof': {'md5': '25deea559772719b90117f2e1009d823'},
	                             '50_numa': {'md5': '5008c2826714ac5b63748780aabd2f25'},
	                             '50_pincpu': {'md5': '0b5fb99ff0e7acb9ad534b87c02c59e3'},
	                             '50_qemucmdline': {'md5': 'a884929ad6f5eb039887157288867409'},
	                             '50_qos': {'md5': '18b596a6b4e4bad80357f240ba122a5e'},
	                             '50_scratchpad': {'md5': '7db25a4b8cb04f6e7132cb7c2300c111'},
	                             '50_smbios': {'md5': '1a6bd8eddc3a86943e558bc4d3e73bd6'},
	                             '50_sriov': {'md5': '3ebc60cd2e4eb089820102285fad7c45'},
	                             '50_usbtablet': {'md5': '392a12fb67be02d43d83855e585b6f9d'},
	                             '50_vmdisk': {'md5': 'b06259a563c750cf46c1d2a7c4ef739b'},
	                             '50_vmfex': {'md5': '9f5abb892ddb6b3daa779985d38d9f55'},
	                             '60_checkimages': {'md5': 'abd32c723a90ab2816e2163f5e02faf7'}}}
	kvmEnabled = 'true'
	lastClient = '3.57.111.30'
	lastClientIface = 'bond1'
	management_ip = ''
	memSize = '36271'
	netConfigDirty = 'False'
	networks = {'maelstrom': {'addr': '',
	                          'bridged': True,
	                          'cfg': {'BOOTPROTO': 'none',
	                                  'DELAY': '0',
	                                  'DEVICE': 'maelstrom',
	                                  'IPV6INIT': 'no',
	                                  'ONBOOT': 'yes',
	                                  'STP': 'off',
	                                  'TYPE': 'Bridge'},
	                          'gateway': '0.0.0.0',
	                          'iface': 'maelstrom',
	                          'ipv6addrs': ['fe80::221:28ff:fe83:ce48/64'],
	                          'ipv6gateway': '::',
	                          'mtu': '1500',
	                          'netmask': '',
	                          'ports': ['bond0'],
	                          'stp': 'off'},
	            'ovirtmgmt': {'addr': '3.57.111.31',
	                          'bridged': True,
	                          'cfg': {'BOOTPROTO': 'none',
	                                  'DELAY': '0',
	                                  'DEVICE': 'ovirtmgmt',
	                                  'IPADDR': '3.57.111.31',
	                                  'IPV6INIT': 'no',
	                                  'ONBOOT': 'yes',
	                                  'PREFIX': '22',
	                                  'STP': 'off',
	                                  'TYPE': 'Bridge'},
	                          'gateway': '0.0.0.0',
	                          'iface': 'ovirtmgmt',
	                          'ipv6addrs': ['fe80::215:17ff:fe00:100a/64',
	                                        'fec0::a:215:17ff:fe00:100a/64',
	                                        '2002:339:6d53:a:215:17ff:fe00:100a/64',
	                                        '2002:32d:1611:a:215:17ff:fe00:100a/64'],
	                          'ipv6gateway': '::',
	                          'mtu': '1500',
	                          'netmask': '255.255.252.0',
	                          'ports': ['bond2'],
	                          'stp': 'off'},
	            'twistingnether': {'addr': '3.70.204.31',
	                               'bridged': False,
	                               'gateway': '3.70.204.254',
	                               'iface': 'bond1',
	                               'interface': 'bond1',
	                               'ipv6addrs': ['fe80::221:28ff:fe83:ce4a/64'],
	                               'ipv6gateway': '::',
	                               'mtu': '1500',
	                               'netmask': '255.255.252.0'}}
	nics = {'eth0': {'addr': '',
	                 'cfg': {'BOOTPROTO': 'none',
	                         'DEVICE': 'eth0',
	                         'HWADDR': '00:21:28:83:CE:48',
	                         'IPV6INIT': 'no',
	                         'MASTER': 'bond0',
	                         'ONBOOT': 'yes',
	                         'SLAVE': 'yes'},
	                 'hwaddr': '00:21:28:83:ce:48',
	                 'ipv6addrs': [],
	                 'mtu': '1500',
	                 'netmask': '',
	                 'permhwaddr': '00:21:28:83:CE:48',
	                 'speed': 1000},
	        'eth1': {'addr': '',
	                 'cfg': {'BOOTPROTO': 'none',
	                         'DEVICE': 'eth1',
	                         'HWADDR': '00:21:28:83:CE:49',
	                         'IPV6INIT': 'no',
	                         'MASTER': 'bond0',
	                         'ONBOOT': 'yes',
	                         'SLAVE': 'yes'},
	                 'hwaddr': '00:21:28:83:ce:48',
	                 'ipv6addrs': [],
	                 'mtu': '1500',
	                 'netmask': '',
	                 'permhwaddr': '00:21:28:83:CE:49',
	                 'speed': 1000},
	        'eth2': {'addr': '',
	                 'cfg': {'BOOTPROTO': 'none',
	                         'DEVICE': 'eth2',
	                         'HWADDR': '00:21:28:83:CE:4A',
	                         'IPV6INIT': 'no',
	                         'MASTER': 'bond1',
	                         'ONBOOT': 'yes',
	                         'SLAVE': 'yes'},
	                 'hwaddr': '00:21:28:83:ce:4a',
	                 'ipv6addrs': [],
	                 'mtu': '1500',
	                 'netmask': '',
	                 'permhwaddr': '00:21:28:83:CE:4A',
	                 'speed': 1000},
	        'eth3': {'addr': '',
	                 'cfg': {'BOOTPROTO': 'none',
	                         'DEVICE': 'eth3',
	                         'HWADDR': '00:21:28:83:CE:4B',
	                         'IPV6INIT': 'no',
	                         'MASTER': 'bond1',
	                         'ONBOOT': 'yes',
	                         'SLAVE': 'yes'},
	                 'hwaddr': '00:21:28:83:ce:4a',
	                 'ipv6addrs': [],
	                 'mtu': '1500',
	                 'netmask': '',
	                 'permhwaddr': '00:21:28:83:CE:4B',
	                 'speed': 1000},
	        'eth4': {'addr': '',
	                 'cfg': {'BOOTPROTO': 'none',
	                         'DEVICE': 'eth4',
	                         'HWADDR': '00:15:17:00:10:0A',
	                         'IPV6INIT': 'no',
	                         'MASTER': 'bond2',
	                         'ONBOOT': 'yes',
	                         'SLAVE': 'yes'},
	                 'hwaddr': '00:15:17:00:10:0a',
	                 'ipv6addrs': [],
	                 'mtu': '1500',
	                 'netmask': '',
	                 'permhwaddr': '00:15:17:00:10:0A',
	                 'speed': 1000},
	        'eth5': {'addr': '',
	                 'cfg': {'BOOTPROTO': 'none',
	                         'DEVICE': 'eth5',
	                         'HWADDR': '00:15:17:00:10:0B',
	                         'IPV6INIT': 'no',
	                         'MASTER': 'bond2',
	                         'ONBOOT': 'yes',
	                         'SLAVE': 'yes'},
	                 'hwaddr': '00:15:17:00:10:0a',
	                 'ipv6addrs': [],
	                 'mtu': '1500',
	                 'netmask': '',
	                 'permhwaddr': '00:15:17:00:10:0B',
	                 'speed': 1000},
	        'ib0': {'addr': '192.168.1.1',
	                'cfg': {'BOOTPROTO': 'none',
	                        'CONNECTED_MODE': 'yes',
	                        'DEVICE': 'ib0',
	                        'IPADDR': '192.168.1.1',
	                        'IPV6INIT': 'no',
	                        'MTU': '65520',
	                        'ONBOOT': 'yes',
	                        'PREFIX': '16',
	                        'TYPE': 'Infiniband'},
	                'hwaddr': '80:00:04:04:fe:80:00:00:00:00:00:00:00:12:79:ff:ff:b5:b0:f1',
	                'ipv6addrs': ['fe80::212:79ff:ffb5:b0f1/64'],
	                'mtu': '65520',
	                'netmask': '255.255.0.0',
	                'speed': 0},
	        'ib1': {'addr': '',
	                'cfg': {'BOOTPROTO': 'none',
	                        'CONNECTED_MODE': 'yes',
	                        'DEVICE': 'ib1',
	                        'IPV6INIT': 'no',
	                        'MTU': '65520',
	                        'ONBOOT': 'no',
	                        'TYPE': 'Infiniband'},
	                'hwaddr': '80:00:04:05:fe:80:00:00:00:00:00:00:00:12:79:ff:ff:b5:b0:f2',
	                'ipv6addrs': [],
	                'mtu': '2044',
	                'netmask': '',
	                'speed': 0}}
	operatingSystem = {'name': 'RHEL', 'release': '4.0.4', 'version': '6Server'}
	packages2 = {'glusterfs': {'buildtime': 1367604893,
	                           'release': '0.3.alpha3.el6',
	                           'version': '3.4.0'},
	             'glusterfs-fuse': {'buildtime': 1367604893,
	                                'release': '0.3.alpha3.el6',
	                                'version': '3.4.0'},
	             'glusterfs-rdma': {'buildtime': 1367604893,
	                                'release': '0.3.alpha3.el6',
	                                'version': '3.4.0'},
	             'glusterfs-server': {'buildtime': 1367604893,
	                                  'release': '0.3.alpha3.el6',
	                                  'version': '3.4.0'},
	             'kernel': {'buildtime': 1368636412.0,
	                        'release': '400.24.1.el6uek.x86_64',
	                        'version': '2.6.39'},
	             'libvirt': {'buildtime': 1368717654,
	                         'release': '18.0.1.el6_4.5',
	                         'version': '0.10.2'},
	             'mom': {'buildtime': 1349470062, 'release': '1.el6', 'version': '0.3.0'},
	             'qemu-img': {'buildtime': 1369259821,
	                          'release': '2.355.el6_4.3',
	                          'version': '0.12.1.2'},
	             'qemu-kvm': {'buildtime': 1369259821,
	                          'release': '2.355.el6_4.3',
	                          'version': '0.12.1.2'},
	             'spice-server': {'buildtime': 1369667146,
	                              'release': '12.el6_4.1',
	                              'version': '0.12.0'},
	             'vdsm': {'buildtime': 1368816180, 'release': '18.el6', 'version': '4.10.3'}}
	reservedMem = '321'
	software_revision = '18'
	software_version = '4.10'
	supportedENGINEs = ['3.0', '3.1']
	supportedProtocols = ['2.2', '2.3']
	uuid = 'FF200008-FFFF-FFFF-FFFF-00212883CE4C'
	version_name = 'Snow Man'
	vlans = {}
	vmTypes = ['kvm']

From deadhorseconsulting at gmail.com  Mon Jun  3 18:53:40 2013
From: deadhorseconsulting at gmail.com (Dead Horse)
Date: Mon, 3 Jun 2013 13:53:40 -0500
Subject: [Engine-devel] Failed to configure management network on the
	host
In-Reply-To: <51ACAC13.9040000@redhat.com>
References: <51ACAC13.9040000@redhat.com>
Message-ID: <CAEWPe=r172RzXMtPx0=3M7bpFLts9T9c3NtRDQOnYn9QJ0_hdQ@mail.gmail.com>

Seeing this as well but during host activation with latest master
vdsm/engine.
--> http://lists.ovirt.org/pipermail/engine-devel/2013-June/004752.html



On Mon, Jun 3, 2013 at 9:45 AM, Kanagaraj <kmayilsa at redhat.com> wrote:

> Hi,
>
>  After adding a host to a 3.2 cluster, bootstrap went through fine and in
> the end it failed with the following error.
>
> "Host s2 installation failed. Failed to configure manamgent network on the
> host."
>
> Attached engine.log and vdsm.log
>
> Vdsm rpms:
> vdsm-4.10.2-22.2.el6rhs.x86_64
> vdsm-python-4.10.2-22.2.**el6rhs.x86_64
> vdsm-cli-4.10.2-22.2.el6rhs.**noarch
> vdsm-gluster-4.10.2-22.2.**el6rhs.noarch
> vdsm-xmlrpc-4.10.2-22.2.**el6rhs.noarch
>
> Engine rpms: recent code from master
>
> Can someone please help in resolving this issue,
>
> Thanks,
> Kanagaraj
>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130603/2c4d270c/attachment.html>

From alonbl at redhat.com  Mon Jun  3 19:08:43 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Mon, 3 Jun 2013 15:08:43 -0400 (EDT)
Subject: [Engine-devel] Odd Host Activation with mgmt-if
In-Reply-To: <CAEWPe=qQt88K=cbHfhOw1ZPnCBHG2gCBADcrL+kSSQkjOzncNA@mail.gmail.com>
References: <CAEWPe=oX94UBGnph+5hePnJSyQBneU3-u7QCRwthzmJsZTBm3Q@mail.gmail.com>
	<CAEWPe=qtPwFC2_SEiFV+TdZjbptSy4pig2SOJE7iWAaBHR6YAw@mail.gmail.com>
	<700182034.3868949.1368945573602.JavaMail.root@redhat.com>
	<1793944165.3869028.1368945795602.JavaMail.root@redhat.com>
	<58289927.2323676.1368958529064.JavaMail.root@redhat.com>
	<703471633.2325369.1368964003055.JavaMail.root@redhat.com>
	<259919713.2325611.1368964886494.JavaMail.root@redhat.com>
	<CAEWPe=qQt88K=cbHfhOw1ZPnCBHG2gCBADcrL+kSSQkjOzncNA@mail.gmail.com>
Message-ID: <731610385.6411464.1370286523984.JavaMail.root@redhat.com>

Hi,

Long time since last discussed this... there were some relevant changes in engine master since, I assume you are using master, right?
If you do, please try latest and send the engine log as well.
Thanks!

----- Original Message -----
> From: "Dead Horse" <deadhorseconsulting at gmail.com>
> To: "Alon Bar-Lev" <alonbl at redhat.com>
> Cc: "Yaniv Bronheim" <ybronhei at redhat.com>, engine-devel at ovirt.org
> Sent: Monday, June 3, 2013 9:50:44 PM
> Subject: Re: [Engine-devel] Odd Host Activation with mgmt-if
> 
> I actually have security disabled on the setup.
> Settings wise
> EnableSpiceRootCertificateValidation=false
> SSLEnabled=false
> UseSecureConnectionWithServers=false
> 
> I have been adding the hosts by the IP address of their mgmt-if
> (ovirtmgmt). I do this since this is an isolated private subnet
> specifically for management traffic only. No DNS or name resolution exists
> there side for using hard entries /etc/hosts on each node and the engine
> host.
> 
> I have attached the getcaps output.
> 
> - DHC
> 
> 
> On Sun, May 19, 2013 at 7:01 AM, Alon Bar-Lev <alonbl at redhat.com> wrote:
> 
> >
> >
> > ----- Original Message -----
> > > From: "Yaniv Bronheim" <ybronhei at redhat.com>
> > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > Cc: "Oded Ramraz" <oramraz at redhat.com>, "Moti Asayag" <
> > masayag at redhat.com>, engine-devel at ovirt.org
> > > Sent: Sunday, May 19, 2013 2:46:43 PM
> > > Subject: Re: [Engine-devel] Odd Host Activation with mgmt-if
> > >
> > > Its true only if you add the host by using an hostname and not by
> > explicit
> > > IP, with IP you can pass 0 to vdsClient and it works
> >
> > I don't think so... even if you enrolled using ip address, it will fail as
> > 0 tries to access using localhost as far as I remember.
> >
> > >
> > > ----- Original Message -----
> > > > From: "Alon Bar-Lev" <alonbl at redhat.com>
> > > > To: "Oded Ramraz" <oramraz at redhat.com>, "Moti Asayag" <
> > masayag at redhat.com>
> > > > Cc: engine-devel at ovirt.org, "Yaniv Bronheim" <ybronhei at redhat.com>
> > > > Sent: Sunday, May 19, 2013 1:15:29 PM
> > > > Subject: Re: [Engine-devel] Odd Host Activation with mgmt-if
> > > >
> > > >
> > > > Most probably, when SSL is enabled and configured properly this will
> > not
> > > > work...
> > > >
> > > > One need:
> > > >
> > > > vdsClient -s <hostname_as_specified_in_certificate> ....
> > > >
> > > > ----- Original Message -----
> > > > > From: "Oded Ramraz" <oramraz at redhat.com>
> > > > > To: "Moti Asayag" <masayag at redhat.com>
> > > > > Cc: engine-devel at ovirt.org
> > > > > Sent: Sunday, May 19, 2013 9:43:15 AM
> > > > > Subject: Re: [Engine-devel] Odd Host Activation with mgmt-if
> > > > >
> > > > > small correction ( typo ) : 'vdsClient -s 0 getVdsCapabilities'
> > > > >
> > > > > Oded.
> > > > >
> > > > > ----- Original Message -----
> > > > > From: "Moti Asayag" <masayag at redhat.com>
> > > > > To: "Dead Horse" <deadhorseconsulting at gmail.com>
> > > > > Cc: engine-devel at ovirt.org
> > > > > Sent: Sunday, May 19, 2013 9:39:33 AM
> > > > > Subject: Re: [Engine-devel] Odd Host Activation with mgmt-if
> > > > >
> > > > > Could you provide the output of the 'vdsClient -s 0
> > getVdsCapavilities'
> > > > > for
> > > > > the specific host?
> > > > >
> > > > > ----- Original Message -----
> > > > > > From: "Dead Horse" <deadhorseconsulting at gmail.com>
> > > > > > To: engine-devel at ovirt.org
> > > > > > Sent: Friday, May 17, 2013 12:21:47 AM
> > > > > > Subject: Re: [Engine-devel] Odd Host Activation with mgmt-if
> > > > > >
> > > > > > Still puzzling on this all I get for an error when I see it is:
> > > > > > WARN [org.ovirt.engine.core.bll.
> > > > > > network.host.SetupNetworksCommand] (pool-5-thread-42) [21543ac]
> > > > > > CanDoAction
> > > > > > of action SetupNetworks failed.
> > > > > >
> > Reasons:VAR__ACTION__SETUP,VAR__TYPE__NETWORKS,NETWORKS_ALREADY_ATTACHED_TO_IFACES,$NETWORKS_ALREADY_ATTACHED_TO_IFACES_LIST
> > > > > > ovirtmgmt
> > > > > >
> > > > > > Nothing is logged VDSM wise other then the above standard host
> > > > > > activation
> > > > > > probe.
> > > > > >
> > > > > > - DHC
> > > > > >
> > > > > >
> > > > > >
> > > > > > On Mon, May 13, 2013 at 1:19 PM, Dead Horse <
> > > > > > deadhorseconsulting at gmail.com
> > > > > > >
> > > > > > wrote:
> > > > > >
> > > > > >
> > > > > >
> > > > > > Seeing this as of late when activating hosts. The odd this is that
> > it
> > > > > > reports
> > > > > > a failure to activate the host (EL6.4) but still does it anyways.
> > > > > >
> > > > > > Engine side:
> > > > > >
> > > > > > 2013-05-13 12:53:38,547 INFO
> > > > > > [org.ovirt.engine.core.bll.HandleVdsVersionCommand]
> > (pool-5-thread-42)
> > > > > > [21543ac] Running command: HandleVdsVersionCommand internal: true.
> > > > > > Entities
> > > > > > affected : ID: 15f11023-9746-49de-b33f-e3cc7dca6f65 Type: VDS
> > > > > > 2013-05-13 12:53:38,549 INFO
> > > > > > [org.ovirt.engine.core.vdsbroker.ActivateVdsVDSCommand]
> > > > > > (pool-5-thread-42)
> > > > > > [21543ac] FINISH, ActivateVdsVDSCommand, return: Host[durotar],
> > log id:
> > > > > > 3796a7bd
> > > > > > 2013-05-13 12:53:38,625 WARN
> > > > > > [org.ovirt.engine.core.bll.network.host.SetupNetworksCommand]
> > > > > > (pool-5-thread-42) [21543ac] CanDoAction of action SetupNetworks
> > > > > > failed.
> > > > > >
> > Reasons:VAR__ACTION__SETUP,VAR__TYPE__NETWORKS,NETWORKS_ALREADY_ATTACHED_TO_IFACES,$NETWORKS_ALREADY_ATTACHED_TO_IFACES_LIST
> > > > > > ovirtmgmt
> > > > > > 2013-05-13 12:53:39,368 INFO
> > > > > > [org.ovirt.engine.core.bll.ActivateVdsCommand]
> > > > > > (pool-5-thread-42) [21543ac] Activate finished. Lock released.
> > > > > > Monitoring
> > > > > > can run now for host durotar from data-center Azeroth
> > > > > >
> > > > > > VDSM Side:
> > > > > >
> > > > > > Thread-13::DEBUG::2013-05-13
> > > > > > 12:53:37,841::BindingXMLRPC::933::vds::(wrapper)
> > > > > > return getCapabilities with {'status': {'message': 'Done', 'code':
> > 0},
> > > > > > 'info': {'HBAInventory': {'iSCSI': [{'InitiatorName':
> > > > > > 'iqn.2012-09.net.azeroth:durotar'}], 'FC': []}, 'packages2':
> > {'kernel':
> > > > > > {'release': '358.6.1.el6.x86_64', 'buildtime': 1366751713.0,
> > 'version':
> > > > > > '2.6.32'}, 'glusterfs-rdma': {'release': '0.3.alpha3.el6',
> > 'buildtime':
> > > > > > 1367604893L, 'version': '3.4.0'}, 'glusterfs-fuse': {'release':
> > > > > > '0.3.alpha3.el6', 'buildtime': 1367604893L, 'version': '3.4.0'},
> > > > > > 'spice-server': {'release': '12.el6', 'buildtime': 1361573005L,
> > > > > > 'version':
> > > > > > '0.12.0'}, 'vdsm': {'release': '17.el6', 'buildtime': 1368196305L,
> > > > > > 'version': '4.10.3'}, 'qemu-kvm': {'release': '2.355.el6_4.2',
> > > > > > 'buildtime':
> > > > > > 1362691270L, 'version': '0.12.1.2'}, 'qemu-img': {'release':
> > > > > > '2.355.el6_4.2', 'buildtime': 1362691270L, 'version': '0.12.1.2'},
> > > > > > 'libvirt': {'release': '18.el6_4.4', 'buildtime': 1366301801L,
> > > > > > 'version':
> > > > > > '0.10.2'}, 'glusterfs': {'release': '0.3.alpha3.el6', 'buildtime':
> > > > > > 1367604893L, 'version': '3.4.0'}, 'mom': {'release': '1.el6',
> > > > > > 'buildtime':
> > > > > > 1349470062L, 'version': '0.3.0'}, 'glusterfs-server': {'release':
> > > > > > '0.3.alpha3.el6', 'buildtime': 1367604893L, 'version': '3.4.0'}},
> > > > > > 'cpuModel': 'Intel(R) Xeon(R) CPU X5570 @ 2.93GHz', 'hooks':
> > > > > > {'before_vm_start': {'50_sriov': {'md5':
> > > > > > '3ebc60cd2e4eb089820102285fad7c45'}, '50_pincpu': {'md5':
> > > > > > '0b5fb99ff0e7acb9ad534b87c02c59e3'}, '50_qos': {'md5':
> > > > > > '18b596a6b4e4bad80357f240ba122a5e'}, '50_vmfex': {'md5':
> > > > > > '9f5abb892ddb6b3daa779985d38d9f55'}, '50_scratchpad': {'md5':
> > > > > > '7db25a4b8cb04f6e7132cb7c2300c111'}, '50_numa': {'md5':
> > > > > > '5008c2826714ac5b63748780aabd2f25'}, '50_floppy': {'md5':
> > > > > > '202fe18705a7d4c50c40c126e8f8dbe8'}, '50_qemucmdline': {'md5':
> > > > > > 'a884929ad6f5eb039887157288867409'}, '50_macspoof': {'md5':
> > > > > > '25deea559772719
> > > > > >
> > > > > > - DHC
> > > > > >
> > > > > >
> > > > > > _______________________________________________
> > > > > > Engine-devel mailing list
> > > > > > Engine-devel at ovirt.org
> > > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > > >
> > > > > _______________________________________________
> > > > > Engine-devel mailing list
> > > > > Engine-devel at ovirt.org
> > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > > _______________________________________________
> > > > > Engine-devel mailing list
> > > > > Engine-devel at ovirt.org
> > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > >
> > > >
> > >
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> >
> 


From deadhorseconsulting at gmail.com  Mon Jun  3 19:37:27 2013
From: deadhorseconsulting at gmail.com (Dead Horse)
Date: Mon, 3 Jun 2013 14:37:27 -0500
Subject: [Engine-devel] Odd Host Activation with mgmt-if
In-Reply-To: <731610385.6411464.1370286523984.JavaMail.root@redhat.com>
References: <CAEWPe=oX94UBGnph+5hePnJSyQBneU3-u7QCRwthzmJsZTBm3Q@mail.gmail.com>
	<CAEWPe=qtPwFC2_SEiFV+TdZjbptSy4pig2SOJE7iWAaBHR6YAw@mail.gmail.com>
	<700182034.3868949.1368945573602.JavaMail.root@redhat.com>
	<1793944165.3869028.1368945795602.JavaMail.root@redhat.com>
	<58289927.2323676.1368958529064.JavaMail.root@redhat.com>
	<703471633.2325369.1368964003055.JavaMail.root@redhat.com>
	<259919713.2325611.1368964886494.JavaMail.root@redhat.com>
	<CAEWPe=qQt88K=cbHfhOw1ZPnCBHG2gCBADcrL+kSSQkjOzncNA@mail.gmail.com>
	<731610385.6411464.1370286523984.JavaMail.root@redhat.com>
Message-ID: <CAEWPe=oDdpXCjGCxJy-c0nfbAMpG2HrkPMPofoe7o3cw3HOVYw@mail.gmail.com>

Above posted was from -->
Engine built from commit: dbc3d31110ce372a1fa7e06f64c4a5c64544c679
This was from a host running VDSM built from commit:
67b59dbf5dd3885db273a34eb89fcb645cdfa5c5

So engine build is about 2 weeks old. Was their a fix merged that fixed
this (nothing obvious that I could see).

engine.log attached

- DHC


On Mon, Jun 3, 2013 at 2:08 PM, Alon Bar-Lev <alonbl at redhat.com> wrote:

> Hi,
>
> Long time since last discussed this... there were some relevant changes in
> engine master since, I assume you are using master, right?
> If you do, please try latest and send the engine log as well.
> Thanks!
>
> ----- Original Message -----
> > From: "Dead Horse" <deadhorseconsulting at gmail.com>
> > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > Cc: "Yaniv Bronheim" <ybronhei at redhat.com>, engine-devel at ovirt.org
> > Sent: Monday, June 3, 2013 9:50:44 PM
> > Subject: Re: [Engine-devel] Odd Host Activation with mgmt-if
> >
> > I actually have security disabled on the setup.
> > Settings wise
> > EnableSpiceRootCertificateValidation=false
> > SSLEnabled=false
> > UseSecureConnectionWithServers=false
> >
> > I have been adding the hosts by the IP address of their mgmt-if
> > (ovirtmgmt). I do this since this is an isolated private subnet
> > specifically for management traffic only. No DNS or name resolution
> exists
> > there side for using hard entries /etc/hosts on each node and the engine
> > host.
> >
> > I have attached the getcaps output.
> >
> > - DHC
> >
> >
> > On Sun, May 19, 2013 at 7:01 AM, Alon Bar-Lev <alonbl at redhat.com> wrote:
> >
> > >
> > >
> > > ----- Original Message -----
> > > > From: "Yaniv Bronheim" <ybronhei at redhat.com>
> > > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > > Cc: "Oded Ramraz" <oramraz at redhat.com>, "Moti Asayag" <
> > > masayag at redhat.com>, engine-devel at ovirt.org
> > > > Sent: Sunday, May 19, 2013 2:46:43 PM
> > > > Subject: Re: [Engine-devel] Odd Host Activation with mgmt-if
> > > >
> > > > Its true only if you add the host by using an hostname and not by
> > > explicit
> > > > IP, with IP you can pass 0 to vdsClient and it works
> > >
> > > I don't think so... even if you enrolled using ip address, it will
> fail as
> > > 0 tries to access using localhost as far as I remember.
> > >
> > > >
> > > > ----- Original Message -----
> > > > > From: "Alon Bar-Lev" <alonbl at redhat.com>
> > > > > To: "Oded Ramraz" <oramraz at redhat.com>, "Moti Asayag" <
> > > masayag at redhat.com>
> > > > > Cc: engine-devel at ovirt.org, "Yaniv Bronheim" <ybronhei at redhat.com>
> > > > > Sent: Sunday, May 19, 2013 1:15:29 PM
> > > > > Subject: Re: [Engine-devel] Odd Host Activation with mgmt-if
> > > > >
> > > > >
> > > > > Most probably, when SSL is enabled and configured properly this
> will
> > > not
> > > > > work...
> > > > >
> > > > > One need:
> > > > >
> > > > > vdsClient -s <hostname_as_specified_in_certificate> ....
> > > > >
> > > > > ----- Original Message -----
> > > > > > From: "Oded Ramraz" <oramraz at redhat.com>
> > > > > > To: "Moti Asayag" <masayag at redhat.com>
> > > > > > Cc: engine-devel at ovirt.org
> > > > > > Sent: Sunday, May 19, 2013 9:43:15 AM
> > > > > > Subject: Re: [Engine-devel] Odd Host Activation with mgmt-if
> > > > > >
> > > > > > small correction ( typo ) : 'vdsClient -s 0 getVdsCapabilities'
> > > > > >
> > > > > > Oded.
> > > > > >
> > > > > > ----- Original Message -----
> > > > > > From: "Moti Asayag" <masayag at redhat.com>
> > > > > > To: "Dead Horse" <deadhorseconsulting at gmail.com>
> > > > > > Cc: engine-devel at ovirt.org
> > > > > > Sent: Sunday, May 19, 2013 9:39:33 AM
> > > > > > Subject: Re: [Engine-devel] Odd Host Activation with mgmt-if
> > > > > >
> > > > > > Could you provide the output of the 'vdsClient -s 0
> > > getVdsCapavilities'
> > > > > > for
> > > > > > the specific host?
> > > > > >
> > > > > > ----- Original Message -----
> > > > > > > From: "Dead Horse" <deadhorseconsulting at gmail.com>
> > > > > > > To: engine-devel at ovirt.org
> > > > > > > Sent: Friday, May 17, 2013 12:21:47 AM
> > > > > > > Subject: Re: [Engine-devel] Odd Host Activation with mgmt-if
> > > > > > >
> > > > > > > Still puzzling on this all I get for an error when I see it is:
> > > > > > > WARN [org.ovirt.engine.core.bll.
> > > > > > > network.host.SetupNetworksCommand] (pool-5-thread-42) [21543ac]
> > > > > > > CanDoAction
> > > > > > > of action SetupNetworks failed.
> > > > > > >
> > >
> Reasons:VAR__ACTION__SETUP,VAR__TYPE__NETWORKS,NETWORKS_ALREADY_ATTACHED_TO_IFACES,$NETWORKS_ALREADY_ATTACHED_TO_IFACES_LIST
> > > > > > > ovirtmgmt
> > > > > > >
> > > > > > > Nothing is logged VDSM wise other then the above standard host
> > > > > > > activation
> > > > > > > probe.
> > > > > > >
> > > > > > > - DHC
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On Mon, May 13, 2013 at 1:19 PM, Dead Horse <
> > > > > > > deadhorseconsulting at gmail.com
> > > > > > > >
> > > > > > > wrote:
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > Seeing this as of late when activating hosts. The odd this is
> that
> > > it
> > > > > > > reports
> > > > > > > a failure to activate the host (EL6.4) but still does it
> anyways.
> > > > > > >
> > > > > > > Engine side:
> > > > > > >
> > > > > > > 2013-05-13 12:53:38,547 INFO
> > > > > > > [org.ovirt.engine.core.bll.HandleVdsVersionCommand]
> > > (pool-5-thread-42)
> > > > > > > [21543ac] Running command: HandleVdsVersionCommand internal:
> true.
> > > > > > > Entities
> > > > > > > affected : ID: 15f11023-9746-49de-b33f-e3cc7dca6f65 Type: VDS
> > > > > > > 2013-05-13 12:53:38,549 INFO
> > > > > > > [org.ovirt.engine.core.vdsbroker.ActivateVdsVDSCommand]
> > > > > > > (pool-5-thread-42)
> > > > > > > [21543ac] FINISH, ActivateVdsVDSCommand, return: Host[durotar],
> > > log id:
> > > > > > > 3796a7bd
> > > > > > > 2013-05-13 12:53:38,625 WARN
> > > > > > > [org.ovirt.engine.core.bll.network.host.SetupNetworksCommand]
> > > > > > > (pool-5-thread-42) [21543ac] CanDoAction of action
> SetupNetworks
> > > > > > > failed.
> > > > > > >
> > >
> Reasons:VAR__ACTION__SETUP,VAR__TYPE__NETWORKS,NETWORKS_ALREADY_ATTACHED_TO_IFACES,$NETWORKS_ALREADY_ATTACHED_TO_IFACES_LIST
> > > > > > > ovirtmgmt
> > > > > > > 2013-05-13 12:53:39,368 INFO
> > > > > > > [org.ovirt.engine.core.bll.ActivateVdsCommand]
> > > > > > > (pool-5-thread-42) [21543ac] Activate finished. Lock released.
> > > > > > > Monitoring
> > > > > > > can run now for host durotar from data-center Azeroth
> > > > > > >
> > > > > > > VDSM Side:
> > > > > > >
> > > > > > > Thread-13::DEBUG::2013-05-13
> > > > > > > 12:53:37,841::BindingXMLRPC::933::vds::(wrapper)
> > > > > > > return getCapabilities with {'status': {'message': 'Done',
> 'code':
> > > 0},
> > > > > > > 'info': {'HBAInventory': {'iSCSI': [{'InitiatorName':
> > > > > > > 'iqn.2012-09.net.azeroth:durotar'}], 'FC': []}, 'packages2':
> > > {'kernel':
> > > > > > > {'release': '358.6.1.el6.x86_64', 'buildtime': 1366751713.0,
> > > 'version':
> > > > > > > '2.6.32'}, 'glusterfs-rdma': {'release': '0.3.alpha3.el6',
> > > 'buildtime':
> > > > > > > 1367604893L, 'version': '3.4.0'}, 'glusterfs-fuse': {'release':
> > > > > > > '0.3.alpha3.el6', 'buildtime': 1367604893L, 'version':
> '3.4.0'},
> > > > > > > 'spice-server': {'release': '12.el6', 'buildtime': 1361573005L,
> > > > > > > 'version':
> > > > > > > '0.12.0'}, 'vdsm': {'release': '17.el6', 'buildtime':
> 1368196305L,
> > > > > > > 'version': '4.10.3'}, 'qemu-kvm': {'release': '2.355.el6_4.2',
> > > > > > > 'buildtime':
> > > > > > > 1362691270L, 'version': '0.12.1.2'}, 'qemu-img': {'release':
> > > > > > > '2.355.el6_4.2', 'buildtime': 1362691270L, 'version':
> '0.12.1.2'},
> > > > > > > 'libvirt': {'release': '18.el6_4.4', 'buildtime': 1366301801L,
> > > > > > > 'version':
> > > > > > > '0.10.2'}, 'glusterfs': {'release': '0.3.alpha3.el6',
> 'buildtime':
> > > > > > > 1367604893L, 'version': '3.4.0'}, 'mom': {'release': '1.el6',
> > > > > > > 'buildtime':
> > > > > > > 1349470062L, 'version': '0.3.0'}, 'glusterfs-server':
> {'release':
> > > > > > > '0.3.alpha3.el6', 'buildtime': 1367604893L, 'version':
> '3.4.0'}},
> > > > > > > 'cpuModel': 'Intel(R) Xeon(R) CPU X5570 @ 2.93GHz', 'hooks':
> > > > > > > {'before_vm_start': {'50_sriov': {'md5':
> > > > > > > '3ebc60cd2e4eb089820102285fad7c45'}, '50_pincpu': {'md5':
> > > > > > > '0b5fb99ff0e7acb9ad534b87c02c59e3'}, '50_qos': {'md5':
> > > > > > > '18b596a6b4e4bad80357f240ba122a5e'}, '50_vmfex': {'md5':
> > > > > > > '9f5abb892ddb6b3daa779985d38d9f55'}, '50_scratchpad': {'md5':
> > > > > > > '7db25a4b8cb04f6e7132cb7c2300c111'}, '50_numa': {'md5':
> > > > > > > '5008c2826714ac5b63748780aabd2f25'}, '50_floppy': {'md5':
> > > > > > > '202fe18705a7d4c50c40c126e8f8dbe8'}, '50_qemucmdline': {'md5':
> > > > > > > 'a884929ad6f5eb039887157288867409'}, '50_macspoof': {'md5':
> > > > > > > '25deea559772719
> > > > > > >
> > > > > > > - DHC
> > > > > > >
> > > > > > >
> > > > > > > _______________________________________________
> > > > > > > Engine-devel mailing list
> > > > > > > Engine-devel at ovirt.org
> > > > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > > > >
> > > > > > _______________________________________________
> > > > > > Engine-devel mailing list
> > > > > > Engine-devel at ovirt.org
> > > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > > > _______________________________________________
> > > > > > Engine-devel mailing list
> > > > > > Engine-devel at ovirt.org
> > > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > > >
> > > > >
> > > >
> > > _______________________________________________
> > > Engine-devel mailing list
> > > Engine-devel at ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > >
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130603/72cd5412/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: engine.log
Type: application/octet-stream
Size: 69442 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130603/72cd5412/attachment.obj>

From alonbl at redhat.com  Mon Jun  3 19:40:20 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Mon, 3 Jun 2013 15:40:20 -0400 (EDT)
Subject: [Engine-devel] Odd Host Activation with mgmt-if
In-Reply-To: <CAEWPe=oDdpXCjGCxJy-c0nfbAMpG2HrkPMPofoe7o3cw3HOVYw@mail.gmail.com>
References: <CAEWPe=oX94UBGnph+5hePnJSyQBneU3-u7QCRwthzmJsZTBm3Q@mail.gmail.com>
	<1793944165.3869028.1368945795602.JavaMail.root@redhat.com>
	<58289927.2323676.1368958529064.JavaMail.root@redhat.com>
	<703471633.2325369.1368964003055.JavaMail.root@redhat.com>
	<259919713.2325611.1368964886494.JavaMail.root@redhat.com>
	<CAEWPe=qQt88K=cbHfhOw1ZPnCBHG2gCBADcrL+kSSQkjOzncNA@mail.gmail.com>
	<731610385.6411464.1370286523984.JavaMail.root@redhat.com>
	<CAEWPe=oDdpXCjGCxJy-c0nfbAMpG2HrkPMPofoe7o3cw3HOVYw@mail.gmail.com>
Message-ID: <102295444.6421774.1370288420276.JavaMail.root@redhat.com>


Well, it seems like the famous infinispan issue.

Yair,
What is the status of that?

2013-06-03 14:35:39,768 ERROR [org.ovirt.engine.core.utils.ejb.EJBUtilsStrategy] (DefaultQuartzScheduler_Worker-7) [e7b3aee] Failed to lookup resource type: CACHE_CONTAINER. JNDI name: java:jboss/infinispan/ovirt-engine: javax.naming.NameNotFoundException: Error looking up infinispan/ovirt-engine, service service jboss.naming.context.java.jboss.infinispan.ovirt-engine is not started
	at org.jboss.as.naming.ServiceBasedNamingStore.lookup(ServiceBasedNamingStore.java:126)


----- Original Message -----
> From: "Dead Horse" <deadhorseconsulting at gmail.com>
> To: "Alon Bar-Lev" <alonbl at redhat.com>
> Cc: "Yaniv Bronheim" <ybronhei at redhat.com>, "engine-devel" <engine-devel at ovirt.org>
> Sent: Monday, June 3, 2013 10:37:27 PM
> Subject: Re: [Engine-devel] Odd Host Activation with mgmt-if
> 
> Above posted was from -->
> Engine built from commit: dbc3d31110ce372a1fa7e06f64c4a5c64544c679
> This was from a host running VDSM built from commit:
> 67b59dbf5dd3885db273a34eb89fcb645cdfa5c5
> 
> So engine build is about 2 weeks old. Was their a fix merged that fixed
> this (nothing obvious that I could see).
> 
> engine.log attached
> 
> - DHC
> 
> 
> On Mon, Jun 3, 2013 at 2:08 PM, Alon Bar-Lev <alonbl at redhat.com> wrote:
> 
> > Hi,
> >
> > Long time since last discussed this... there were some relevant changes in
> > engine master since, I assume you are using master, right?
> > If you do, please try latest and send the engine log as well.
> > Thanks!
> >
> > ----- Original Message -----
> > > From: "Dead Horse" <deadhorseconsulting at gmail.com>
> > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > Cc: "Yaniv Bronheim" <ybronhei at redhat.com>, engine-devel at ovirt.org
> > > Sent: Monday, June 3, 2013 9:50:44 PM
> > > Subject: Re: [Engine-devel] Odd Host Activation with mgmt-if
> > >
> > > I actually have security disabled on the setup.
> > > Settings wise
> > > EnableSpiceRootCertificateValidation=false
> > > SSLEnabled=false
> > > UseSecureConnectionWithServers=false
> > >
> > > I have been adding the hosts by the IP address of their mgmt-if
> > > (ovirtmgmt). I do this since this is an isolated private subnet
> > > specifically for management traffic only. No DNS or name resolution
> > exists
> > > there side for using hard entries /etc/hosts on each node and the engine
> > > host.
> > >
> > > I have attached the getcaps output.
> > >
> > > - DHC
> > >
> > >
> > > On Sun, May 19, 2013 at 7:01 AM, Alon Bar-Lev <alonbl at redhat.com> wrote:
> > >
> > > >
> > > >
> > > > ----- Original Message -----
> > > > > From: "Yaniv Bronheim" <ybronhei at redhat.com>
> > > > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > > > Cc: "Oded Ramraz" <oramraz at redhat.com>, "Moti Asayag" <
> > > > masayag at redhat.com>, engine-devel at ovirt.org
> > > > > Sent: Sunday, May 19, 2013 2:46:43 PM
> > > > > Subject: Re: [Engine-devel] Odd Host Activation with mgmt-if
> > > > >
> > > > > Its true only if you add the host by using an hostname and not by
> > > > explicit
> > > > > IP, with IP you can pass 0 to vdsClient and it works
> > > >
> > > > I don't think so... even if you enrolled using ip address, it will
> > fail as
> > > > 0 tries to access using localhost as far as I remember.
> > > >
> > > > >
> > > > > ----- Original Message -----
> > > > > > From: "Alon Bar-Lev" <alonbl at redhat.com>
> > > > > > To: "Oded Ramraz" <oramraz at redhat.com>, "Moti Asayag" <
> > > > masayag at redhat.com>
> > > > > > Cc: engine-devel at ovirt.org, "Yaniv Bronheim" <ybronhei at redhat.com>
> > > > > > Sent: Sunday, May 19, 2013 1:15:29 PM
> > > > > > Subject: Re: [Engine-devel] Odd Host Activation with mgmt-if
> > > > > >
> > > > > >
> > > > > > Most probably, when SSL is enabled and configured properly this
> > will
> > > > not
> > > > > > work...
> > > > > >
> > > > > > One need:
> > > > > >
> > > > > > vdsClient -s <hostname_as_specified_in_certificate> ....
> > > > > >
> > > > > > ----- Original Message -----
> > > > > > > From: "Oded Ramraz" <oramraz at redhat.com>
> > > > > > > To: "Moti Asayag" <masayag at redhat.com>
> > > > > > > Cc: engine-devel at ovirt.org
> > > > > > > Sent: Sunday, May 19, 2013 9:43:15 AM
> > > > > > > Subject: Re: [Engine-devel] Odd Host Activation with mgmt-if
> > > > > > >
> > > > > > > small correction ( typo ) : 'vdsClient -s 0 getVdsCapabilities'
> > > > > > >
> > > > > > > Oded.
> > > > > > >
> > > > > > > ----- Original Message -----
> > > > > > > From: "Moti Asayag" <masayag at redhat.com>
> > > > > > > To: "Dead Horse" <deadhorseconsulting at gmail.com>
> > > > > > > Cc: engine-devel at ovirt.org
> > > > > > > Sent: Sunday, May 19, 2013 9:39:33 AM
> > > > > > > Subject: Re: [Engine-devel] Odd Host Activation with mgmt-if
> > > > > > >
> > > > > > > Could you provide the output of the 'vdsClient -s 0
> > > > getVdsCapavilities'
> > > > > > > for
> > > > > > > the specific host?
> > > > > > >
> > > > > > > ----- Original Message -----
> > > > > > > > From: "Dead Horse" <deadhorseconsulting at gmail.com>
> > > > > > > > To: engine-devel at ovirt.org
> > > > > > > > Sent: Friday, May 17, 2013 12:21:47 AM
> > > > > > > > Subject: Re: [Engine-devel] Odd Host Activation with mgmt-if
> > > > > > > >
> > > > > > > > Still puzzling on this all I get for an error when I see it is:
> > > > > > > > WARN [org.ovirt.engine.core.bll.
> > > > > > > > network.host.SetupNetworksCommand] (pool-5-thread-42) [21543ac]
> > > > > > > > CanDoAction
> > > > > > > > of action SetupNetworks failed.
> > > > > > > >
> > > >
> > Reasons:VAR__ACTION__SETUP,VAR__TYPE__NETWORKS,NETWORKS_ALREADY_ATTACHED_TO_IFACES,$NETWORKS_ALREADY_ATTACHED_TO_IFACES_LIST
> > > > > > > > ovirtmgmt
> > > > > > > >
> > > > > > > > Nothing is logged VDSM wise other then the above standard host
> > > > > > > > activation
> > > > > > > > probe.
> > > > > > > >
> > > > > > > > - DHC
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > On Mon, May 13, 2013 at 1:19 PM, Dead Horse <
> > > > > > > > deadhorseconsulting at gmail.com
> > > > > > > > >
> > > > > > > > wrote:
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > Seeing this as of late when activating hosts. The odd this is
> > that
> > > > it
> > > > > > > > reports
> > > > > > > > a failure to activate the host (EL6.4) but still does it
> > anyways.
> > > > > > > >
> > > > > > > > Engine side:
> > > > > > > >
> > > > > > > > 2013-05-13 12:53:38,547 INFO
> > > > > > > > [org.ovirt.engine.core.bll.HandleVdsVersionCommand]
> > > > (pool-5-thread-42)
> > > > > > > > [21543ac] Running command: HandleVdsVersionCommand internal:
> > true.
> > > > > > > > Entities
> > > > > > > > affected : ID: 15f11023-9746-49de-b33f-e3cc7dca6f65 Type: VDS
> > > > > > > > 2013-05-13 12:53:38,549 INFO
> > > > > > > > [org.ovirt.engine.core.vdsbroker.ActivateVdsVDSCommand]
> > > > > > > > (pool-5-thread-42)
> > > > > > > > [21543ac] FINISH, ActivateVdsVDSCommand, return: Host[durotar],
> > > > log id:
> > > > > > > > 3796a7bd
> > > > > > > > 2013-05-13 12:53:38,625 WARN
> > > > > > > > [org.ovirt.engine.core.bll.network.host.SetupNetworksCommand]
> > > > > > > > (pool-5-thread-42) [21543ac] CanDoAction of action
> > SetupNetworks
> > > > > > > > failed.
> > > > > > > >
> > > >
> > Reasons:VAR__ACTION__SETUP,VAR__TYPE__NETWORKS,NETWORKS_ALREADY_ATTACHED_TO_IFACES,$NETWORKS_ALREADY_ATTACHED_TO_IFACES_LIST
> > > > > > > > ovirtmgmt
> > > > > > > > 2013-05-13 12:53:39,368 INFO
> > > > > > > > [org.ovirt.engine.core.bll.ActivateVdsCommand]
> > > > > > > > (pool-5-thread-42) [21543ac] Activate finished. Lock released.
> > > > > > > > Monitoring
> > > > > > > > can run now for host durotar from data-center Azeroth
> > > > > > > >
> > > > > > > > VDSM Side:
> > > > > > > >
> > > > > > > > Thread-13::DEBUG::2013-05-13
> > > > > > > > 12:53:37,841::BindingXMLRPC::933::vds::(wrapper)
> > > > > > > > return getCapabilities with {'status': {'message': 'Done',
> > 'code':
> > > > 0},
> > > > > > > > 'info': {'HBAInventory': {'iSCSI': [{'InitiatorName':
> > > > > > > > 'iqn.2012-09.net.azeroth:durotar'}], 'FC': []}, 'packages2':
> > > > {'kernel':
> > > > > > > > {'release': '358.6.1.el6.x86_64', 'buildtime': 1366751713.0,
> > > > 'version':
> > > > > > > > '2.6.32'}, 'glusterfs-rdma': {'release': '0.3.alpha3.el6',
> > > > 'buildtime':
> > > > > > > > 1367604893L, 'version': '3.4.0'}, 'glusterfs-fuse': {'release':
> > > > > > > > '0.3.alpha3.el6', 'buildtime': 1367604893L, 'version':
> > '3.4.0'},
> > > > > > > > 'spice-server': {'release': '12.el6', 'buildtime': 1361573005L,
> > > > > > > > 'version':
> > > > > > > > '0.12.0'}, 'vdsm': {'release': '17.el6', 'buildtime':
> > 1368196305L,
> > > > > > > > 'version': '4.10.3'}, 'qemu-kvm': {'release': '2.355.el6_4.2',
> > > > > > > > 'buildtime':
> > > > > > > > 1362691270L, 'version': '0.12.1.2'}, 'qemu-img': {'release':
> > > > > > > > '2.355.el6_4.2', 'buildtime': 1362691270L, 'version':
> > '0.12.1.2'},
> > > > > > > > 'libvirt': {'release': '18.el6_4.4', 'buildtime': 1366301801L,
> > > > > > > > 'version':
> > > > > > > > '0.10.2'}, 'glusterfs': {'release': '0.3.alpha3.el6',
> > 'buildtime':
> > > > > > > > 1367604893L, 'version': '3.4.0'}, 'mom': {'release': '1.el6',
> > > > > > > > 'buildtime':
> > > > > > > > 1349470062L, 'version': '0.3.0'}, 'glusterfs-server':
> > {'release':
> > > > > > > > '0.3.alpha3.el6', 'buildtime': 1367604893L, 'version':
> > '3.4.0'}},
> > > > > > > > 'cpuModel': 'Intel(R) Xeon(R) CPU X5570 @ 2.93GHz', 'hooks':
> > > > > > > > {'before_vm_start': {'50_sriov': {'md5':
> > > > > > > > '3ebc60cd2e4eb089820102285fad7c45'}, '50_pincpu': {'md5':
> > > > > > > > '0b5fb99ff0e7acb9ad534b87c02c59e3'}, '50_qos': {'md5':
> > > > > > > > '18b596a6b4e4bad80357f240ba122a5e'}, '50_vmfex': {'md5':
> > > > > > > > '9f5abb892ddb6b3daa779985d38d9f55'}, '50_scratchpad': {'md5':
> > > > > > > > '7db25a4b8cb04f6e7132cb7c2300c111'}, '50_numa': {'md5':
> > > > > > > > '5008c2826714ac5b63748780aabd2f25'}, '50_floppy': {'md5':
> > > > > > > > '202fe18705a7d4c50c40c126e8f8dbe8'}, '50_qemucmdline': {'md5':
> > > > > > > > 'a884929ad6f5eb039887157288867409'}, '50_macspoof': {'md5':
> > > > > > > > '25deea559772719
> > > > > > > >
> > > > > > > > - DHC
> > > > > > > >
> > > > > > > >
> > > > > > > > _______________________________________________
> > > > > > > > Engine-devel mailing list
> > > > > > > > Engine-devel at ovirt.org
> > > > > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > > > > >
> > > > > > > _______________________________________________
> > > > > > > Engine-devel mailing list
> > > > > > > Engine-devel at ovirt.org
> > > > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > > > > _______________________________________________
> > > > > > > Engine-devel mailing list
> > > > > > > Engine-devel at ovirt.org
> > > > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > > > >
> > > > > >
> > > > >
> > > > _______________________________________________
> > > > Engine-devel mailing list
> > > > Engine-devel at ovirt.org
> > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > >
> > >
> >
> 


From kmayilsa at redhat.com  Tue Jun  4 05:51:20 2013
From: kmayilsa at redhat.com (Kanagaraj)
Date: Tue, 04 Jun 2013 11:21:20 +0530
Subject: [Engine-devel] Failed to configure management network on the
 host
In-Reply-To: <CAEWPe=r172RzXMtPx0=3M7bpFLts9T9c3NtRDQOnYn9QJ0_hdQ@mail.gmail.com>
References: <51ACAC13.9040000@redhat.com>
	<CAEWPe=r172RzXMtPx0=3M7bpFLts9T9c3NtRDQOnYn9QJ0_hdQ@mail.gmail.com>
Message-ID: <51AD8058.8050901@redhat.com>

Host installation went through successfully after reverting the change 
eca95e192ebf3e1fe0e9440bb8fac694214ca8fd (Change Iaf82e104: engine: 
Allow engine to configure management network ).

Thanks,
Kanagaraj

On 06/04/2013 12:23 AM, Dead Horse wrote:
> Seeing this as well but during host activation with latest master 
> vdsm/engine.
> --> http://lists.ovirt.org/pipermail/engine-devel/2013-June/004752.html
>
>
>
> On Mon, Jun 3, 2013 at 9:45 AM, Kanagaraj <kmayilsa at redhat.com 
> <mailto:kmayilsa at redhat.com>> wrote:
>
>     Hi,
>
>      After adding a host to a 3.2 cluster, bootstrap went through fine
>     and in the end it failed with the following error.
>
>     "Host s2 installation failed. Failed to configure manamgent
>     network on the host."
>
>     Attached engine.log and vdsm.log
>
>     Vdsm rpms:
>     vdsm-4.10.2-22.2.el6rhs.x86_64
>     vdsm-python-4.10.2-22.2.el6rhs.x86_64
>     vdsm-cli-4.10.2-22.2.el6rhs.noarch
>     vdsm-gluster-4.10.2-22.2.el6rhs.noarch
>     vdsm-xmlrpc-4.10.2-22.2.el6rhs.noarch
>
>     Engine rpms: recent code from master
>
>     Can someone please help in resolving this issue,
>
>     Thanks,
>     Kanagaraj
>
>     _______________________________________________
>     Engine-devel mailing list
>     Engine-devel at ovirt.org <mailto:Engine-devel at ovirt.org>
>     http://lists.ovirt.org/mailman/listinfo/engine-devel
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130604/e187a241/attachment.html>

From kmayilsa at redhat.com  Tue Jun  4 06:18:53 2013
From: kmayilsa at redhat.com (Kanagaraj)
Date: Tue, 04 Jun 2013 11:48:53 +0530
Subject: [Engine-devel] Gluster Swift Management - Feature
Message-ID: <51AD86CD.1020202@redhat.com>

Hi All,

Gluster Swift Management feature - 
http://www.ovirt.org/Features/Gluster_Swift_Management

Please share your thoughts.

Thanks,
Kanagaraj


From masayag at redhat.com  Tue Jun  4 06:23:21 2013
From: masayag at redhat.com (Moti Asayag)
Date: Tue, 04 Jun 2013 09:23:21 +0300
Subject: [Engine-devel] Failed to configure management network on the
 host
In-Reply-To: <51AD8058.8050901@redhat.com>
References: <51ACAC13.9040000@redhat.com>
	<CAEWPe=r172RzXMtPx0=3M7bpFLts9T9c3NtRDQOnYn9QJ0_hdQ@mail.gmail.com>
	<51AD8058.8050901@redhat.com>
Message-ID: <51AD87D9.6020608@redhat.com>

Hi,

Same host activation flow should work on the master as well as the
management network will not be created as part of the host activation.
So reverted changes were already merged by commit
bdd8966d97e1e02e775ee6f755d0a3637a668911

For more details about host installation see:
http://www.ovirt.org/Features/Normalized_ovirtmgmt_Initialization

Thanks,
Moti

See
On 06/04/2013 08:51 AM, Kanagaraj wrote:
> Host installation went through successfully after reverting the change
> eca95e192ebf3e1fe0e9440bb8fac694214ca8fd (Change Iaf82e104: engine:
> Allow engine to configure management network ).
> 
> Thanks,
> Kanagaraj
> 
> On 06/04/2013 12:23 AM, Dead Horse wrote:
>> Seeing this as well but during host activation with latest master
>> vdsm/engine.
>> --> http://lists.ovirt.org/pipermail/engine-devel/2013-June/004752.html
>>
>>
>>
>> On Mon, Jun 3, 2013 at 9:45 AM, Kanagaraj <kmayilsa at redhat.com
>> <mailto:kmayilsa at redhat.com>> wrote:
>>
>>     Hi,
>>
>>      After adding a host to a 3.2 cluster, bootstrap went through fine
>>     and in the end it failed with the following error.
>>
>>     "Host s2 installation failed. Failed to configure manamgent
>>     network on the host."
>>
>>     Attached engine.log and vdsm.log
>>
>>     Vdsm rpms:
>>     vdsm-4.10.2-22.2.el6rhs.x86_64
>>     vdsm-python-4.10.2-22.2.el6rhs.x86_64
>>     vdsm-cli-4.10.2-22.2.el6rhs.noarch
>>     vdsm-gluster-4.10.2-22.2.el6rhs.noarch
>>     vdsm-xmlrpc-4.10.2-22.2.el6rhs.noarch
>>
>>     Engine rpms: recent code from master
>>
>>     Can someone please help in resolving this issue,
>>
>>     Thanks,
>>     Kanagaraj
>>
>>     _______________________________________________
>>     Engine-devel mailing list
>>     Engine-devel at ovirt.org <mailto:Engine-devel at ovirt.org>
>>     http://lists.ovirt.org/mailman/listinfo/engine-devel
>>
>>
> 



From sabose at redhat.com  Tue Jun  4 06:52:34 2013
From: sabose at redhat.com (Sahina Bose)
Date: Tue, 04 Jun 2013 12:22:34 +0530
Subject: [Engine-devel] Failed to configure management network on the
 host
In-Reply-To: <51AD87D9.6020608@redhat.com>
References: <51ACAC13.9040000@redhat.com>
	<CAEWPe=r172RzXMtPx0=3M7bpFLts9T9c3NtRDQOnYn9QJ0_hdQ@mail.gmail.com>
	<51AD8058.8050901@redhat.com> <51AD87D9.6020608@redhat.com>
Message-ID: <51AD8EB2.3060402@redhat.com>

Hi Moti,

Not sure I understand your comment about host activation flow.
commit bdd8966d97e1e02e775ee6f755d0a3637a668911  (engine: Remove mgmt 
network setup from host activation) is present in our code base, but we 
were not using the host activation flow.

Here's what we tried to do.
Add a host (with vdsm 4.10.2 installed) to engine (built from Jun 2 
upstream codebase).

The installation failed with "Failed to configure manamgent network on 
the host"

and the logs had this

2013-06-03 19:49:03,390 INFO 
[org.ovirt.engine.core.bll.network.NetworkConfigurator] 
(pool-4-thread-50) [7bf46c88] Engine managed to communicate with VDSM 
agent on host s1
2013-06-03 19:49:03,412 ERROR 
[org.ovirt.engine.core.vdsbroker.vdsbroker.CollectVdsNetworkDataVDSCommand] 
(pool-4-thread-50) [7bf46c88] Command CollectVdsNetworkDataVDS execution 
failed. Exception: VDSNetworkException: java.net.ConnectException: 
Connection refused

As Kanagaraj mentioned, reverting the Change Iaf82e104: engine:
Allow engine to configure management network , fixed this issue.

 From the flowchart on 
http://www.ovirt.org/Features/Normalized_ovirtmgmt_Initialization, it 
seems to fail on the "Configure Management Network (by setup networks)" 
action.

Any help on solving this would be appreciated.

thanks
sahina



On 06/04/2013 11:53 AM, Moti Asayag wrote:
> Hi,
>
> Same host activation flow should work on the master as well as the
> management network will not be created as part of the host activation.
> So reverted changes were already merged by commit
> bdd8966d97e1e02e775ee6f755d0a3637a668911
>
> For more details about host installation see:
> http://www.ovirt.org/Features/Normalized_ovirtmgmt_Initialization
>
> Thanks,
> Moti
>
> See
> On 06/04/2013 08:51 AM, Kanagaraj wrote:
>> Host installation went through successfully after reverting the change
>> eca95e192ebf3e1fe0e9440bb8fac694214ca8fd (Change Iaf82e104: engine:
>> Allow engine to configure management network ).
>>
>> Thanks,
>> Kanagaraj
>>
>> On 06/04/2013 12:23 AM, Dead Horse wrote:
>>> Seeing this as well but during host activation with latest master
>>> vdsm/engine.
>>> --> http://lists.ovirt.org/pipermail/engine-devel/2013-June/004752.html
>>>
>>>
>>>
>>> On Mon, Jun 3, 2013 at 9:45 AM, Kanagaraj <kmayilsa at redhat.com
>>> <mailto:kmayilsa at redhat.com>> wrote:
>>>
>>>      Hi,
>>>
>>>       After adding a host to a 3.2 cluster, bootstrap went through fine
>>>      and in the end it failed with the following error.
>>>
>>>      "Host s2 installation failed. Failed to configure manamgent
>>>      network on the host."
>>>
>>>      Attached engine.log and vdsm.log
>>>
>>>      Vdsm rpms:
>>>      vdsm-4.10.2-22.2.el6rhs.x86_64
>>>      vdsm-python-4.10.2-22.2.el6rhs.x86_64
>>>      vdsm-cli-4.10.2-22.2.el6rhs.noarch
>>>      vdsm-gluster-4.10.2-22.2.el6rhs.noarch
>>>      vdsm-xmlrpc-4.10.2-22.2.el6rhs.noarch
>>>
>>>      Engine rpms: recent code from master
>>>
>>>      Can someone please help in resolving this issue,
>>>
>>>      Thanks,
>>>      Kanagaraj
>>>
>>>      _______________________________________________
>>>      Engine-devel mailing list
>>>      Engine-devel at ovirt.org <mailto:Engine-devel at ovirt.org>
>>>      http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>
>>>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel



From wlbleaboy at 126.com  Tue Jun  4 07:52:30 2013
From: wlbleaboy at 126.com (wlbleaboy@126)
Date: Tue, 4 Jun 2013 15:52:30 +0800
Subject: [Engine-devel] =?utf-8?b?562U5aSNOiAgb3ZpcnQtZW5naW5lLXNkayB3aXRo?=
	=?utf-8?q?_C?=
In-Reply-To: <CAGEoUW8a4XP=VA_NHXd1wD6sqA5dBdPPauMPrQE0RiKQ4Za8Aw@mail.gmail.com>
References: <000101ce4fc3$0f359570$2da0c050$@com>
	<CAGEoUW8a4XP=VA_NHXd1wD6sqA5dBdPPauMPrQE0RiKQ4Za8Aw@mail.gmail.com>
Message-ID: <000901ce60f8$77d692f0$6783b8d0$@com>

Hi, Jarod. W:

    Yes, I just want to use c to invoke ovirt engine RestAPI,

Just get vm?s id, host, port, secur-port, and ticket,

    How can I use libcurl to connect https, could give me

a simple demo to connect https://{ovirt-engine}/api <https://%7bovirt-engine%7d/api>  with 

--cafile, the ca.crt I get from http://{ovirt-engine}/ca.crt <http://%7bovirt-engine%7d/ca.crt> 

 

 

???: Jarod. w [mailto:work.iec23801 at gmail.com] 
????: 2013?5?14? 10:27
???: leaboy at 126
??: engine-devel at ovirt.org
??: Re: [Engine-devel] ovirt-engine-sdk with C

 

2013/5/13 leaboy at 126 <wlbleaboy at 126.com>

Hi?All

         I felt oivrt-engine-sdk coded with Python is slowly to connect

ovirt-engine and console vm when a user have many vms, So, I just

want to rewrite the sdk with C(ANSI C Language). Just rewrite a sdk

with C to connect overt-engine and console vm, would anyone give 

me some suggestion.

Do you want to use c to invoke ovirt engine RestAPI, right?

If yes, you can use libcurl to do the thing, and it'll make you happy.

 

 

         Now, the problem is how can I connect to ovit-engine with C, and

how can I get some information of vms, and how ovirrt-engine can 

respond my action(start,stop, .eg)

Agree with Michael Pasternak.

You should parse your code into the mail list, or someone can't help

you.

 

 

                                                                                    Leaboy at beijing

                                                                 Thinks


_______________________________________________
Engine-devel mailing list
Engine-devel at ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel




-- 
---
Best Regards
Jarod.W

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130604/a7cc011b/attachment.html>

From masayag at redhat.com  Tue Jun  4 08:15:06 2013
From: masayag at redhat.com (Moti Asayag)
Date: Tue, 04 Jun 2013 11:15:06 +0300
Subject: [Engine-devel] Failed to configure management network on the
 host
In-Reply-To: <51AD8EB2.3060402@redhat.com>
References: <51ACAC13.9040000@redhat.com>
	<CAEWPe=r172RzXMtPx0=3M7bpFLts9T9c3NtRDQOnYn9QJ0_hdQ@mail.gmail.com>
	<51AD8058.8050901@redhat.com> <51AD87D9.6020608@redhat.com>
	<51AD8EB2.3060402@redhat.com>
Message-ID: <51ADA20A.9080108@redhat.com>

On 06/04/2013 09:52 AM, Sahina Bose wrote:
> Hi Moti,
> 
> Not sure I understand your comment about host activation flow.
> commit bdd8966d97e1e02e775ee6f755d0a3637a668911  (engine: Remove mgmt
> network setup from host activation) is present in our code base, but we
> were not using the host activation flow.

Hi,

My fault, i had a different old thread in my mind.

The relevant part from the engine.log indicates that the host deployment
ended successfully, host was able to ping VDSM, but the first attempt to
run getVdsCaps on vdsm failed.

Could you add the relevant vdsm.log which contains the flow-ID 740c5292
which matches the same correlation-id from the engine.log ?


2013-06-03 20:06:49,638 INFO
[org.ovirt.engine.core.bll.InstallerMessages] (VdsDeploy) Installation
10.70.43.140: Stage: Termination
2013-06-03 20:06:49,881 ERROR
[org.ovirt.engine.core.vdsbroker.vdsbroker.PollVDSCommand]
(pool-4-thread-48) [740c5292] java.util.concurrent.ExecutionException:
java.lang.reflect.InvocationTargetException
2013-06-03 20:06:49,882 ERROR
[org.ovirt.engine.core.vdsbroker.vdsbroker.PollVDSCommand]
(pool-4-thread-48) [740c5292] Command PollVDS execution failed.
Exception: RuntimeException: java.util.concurrent.ExecutionException:
java.lang.reflect.InvocationTargetException
2013-06-03 20:06:50,382 INFO
[org.ovirt.engine.core.bll.network.NetworkConfigurator]
(pool-4-thread-48) [740c5292] Engine managed to communicate with VDSM
agent on host s2
2013-06-03 20:06:50,393 ERROR
[org.ovirt.engine.core.vdsbroker.vdsbroker.CollectVdsNetworkDataVDSCommand]
(pool-4-thread-48) [740c5292] Command CollectVdsNetworkDataVDS execution
failed. Exception: VDSNetworkException: java.net.ConnectException:
Connection refused

Thanks,
Moti

> 
> Here's what we tried to do.
> Add a host (with vdsm 4.10.2 installed) to engine (built from Jun 2
> upstream codebase).
> 
> The installation failed with "Failed to configure manamgent network on
> the host"
> 
> and the logs had this
> 
> 2013-06-03 19:49:03,390 INFO
> [org.ovirt.engine.core.bll.network.NetworkConfigurator]
> (pool-4-thread-50) [7bf46c88] Engine managed to communicate with VDSM
> agent on host s1
> 2013-06-03 19:49:03,412 ERROR
> [org.ovirt.engine.core.vdsbroker.vdsbroker.CollectVdsNetworkDataVDSCommand]
> (pool-4-thread-50) [7bf46c88] Command CollectVdsNetworkDataVDS execution
> failed. Exception: VDSNetworkException: java.net.ConnectException:
> Connection refused
> 
> As Kanagaraj mentioned, reverting the Change Iaf82e104: engine:
> Allow engine to configure management network , fixed this issue.
> 
> From the flowchart on
> http://www.ovirt.org/Features/Normalized_ovirtmgmt_Initialization, it
> seems to fail on the "Configure Management Network (by setup networks)"
> action.
> 
> Any help on solving this would be appreciated.
> 
> thanks
> sahina
> 
> 
> 
> On 06/04/2013 11:53 AM, Moti Asayag wrote:
>> Hi,
>>
>> Same host activation flow should work on the master as well as the
>> management network will not be created as part of the host activation.
>> So reverted changes were already merged by commit
>> bdd8966d97e1e02e775ee6f755d0a3637a668911
>>
>> For more details about host installation see:
>> http://www.ovirt.org/Features/Normalized_ovirtmgmt_Initialization
>>
>> Thanks,
>> Moti
>>
>> See
>> On 06/04/2013 08:51 AM, Kanagaraj wrote:
>>> Host installation went through successfully after reverting the change
>>> eca95e192ebf3e1fe0e9440bb8fac694214ca8fd (Change Iaf82e104: engine:
>>> Allow engine to configure management network ).
>>>
>>> Thanks,
>>> Kanagaraj
>>>
>>> On 06/04/2013 12:23 AM, Dead Horse wrote:
>>>> Seeing this as well but during host activation with latest master
>>>> vdsm/engine.
>>>> --> http://lists.ovirt.org/pipermail/engine-devel/2013-June/004752.html
>>>>
>>>>
>>>>
>>>> On Mon, Jun 3, 2013 at 9:45 AM, Kanagaraj <kmayilsa at redhat.com
>>>> <mailto:kmayilsa at redhat.com>> wrote:
>>>>
>>>>      Hi,
>>>>
>>>>       After adding a host to a 3.2 cluster, bootstrap went through fine
>>>>      and in the end it failed with the following error.
>>>>
>>>>      "Host s2 installation failed. Failed to configure manamgent
>>>>      network on the host."
>>>>
>>>>      Attached engine.log and vdsm.log
>>>>
>>>>      Vdsm rpms:
>>>>      vdsm-4.10.2-22.2.el6rhs.x86_64
>>>>      vdsm-python-4.10.2-22.2.el6rhs.x86_64
>>>>      vdsm-cli-4.10.2-22.2.el6rhs.noarch
>>>>      vdsm-gluster-4.10.2-22.2.el6rhs.noarch
>>>>      vdsm-xmlrpc-4.10.2-22.2.el6rhs.noarch
>>>>
>>>>      Engine rpms: recent code from master
>>>>
>>>>      Can someone please help in resolving this issue,
>>>>
>>>>      Thanks,
>>>>      Kanagaraj
>>>>
>>>>      _______________________________________________
>>>>      Engine-devel mailing list
>>>>      Engine-devel at ovirt.org <mailto:Engine-devel at ovirt.org>
>>>>      http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>>
>>>>
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 



From djasa at redhat.com  Tue Jun  4 08:21:30 2013
From: djasa at redhat.com (David =?UTF-8?Q?Ja=C5=A1a?=)
Date: Tue, 04 Jun 2013 10:21:30 +0200
Subject: [Engine-devel] ovirt-engine-sdk with C
In-Reply-To: <000101ce4fc3$0f359570$2da0c050$@com>
References: <000101ce4fc3$0f359570$2da0c050$@com>
Message-ID: <1370334090.29419.24.camel@cihla.usersys.redhat.com>

Hi,

I'm not sure if it is applicable to your case, but there is incomplete
C/GObject implementation of oVirt SDK available here:
http://cgit.freedesktop.org/~teuf/govirt/
As far as I know, it's currently focused just on getting connection
details for VMs but I guess that more complete support for whole oVirt
API is just a matter of development...

David


leaboy at 126 p??e v Po 13. 05. 2013 v 18:17 +0800:
> Hi?All
> 
>          I felt oivrt-engine-sdk coded with Python is slowly to connect
> 
> ovirt-engine and console vm when a user have many vms, So, I just
> 
> want to rewrite the sdk with C(ANSI C Language). Just rewrite a sdk
> 
> with C to connect overt-engine and console vm, would anyone give 
> 
> me some suggestion.
> 
>  
> 
>          Now, the problem is how can I connect to ovit-engine with C, and
> 
> how can I get some information of vms, and how ovirrt-engine can 
> 
> respond my action(start,stop, .eg)
> 
>  
> 
> 
> Leaboy at beijing
> 
>                                                                  Thinks
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel

-- 

David Ja?a, RHCE

SPICE QE based in Brno
GPG Key:     22C33E24 
Fingerprint: 513A 060B D1B4 2A72 7F0D 0278 B125 CD00 22C3 3E24


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5727 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130604/d17c149a/attachment.bin>

From lpeer at redhat.com  Tue Jun  4 09:02:35 2013
From: lpeer at redhat.com (Livnat Peer)
Date: Tue, 04 Jun 2013 12:02:35 +0300
Subject: [Engine-devel] Network Quality of Service 3.3 - Feature design
In-Reply-To: <273375846.6100303.1370156285221.JavaMail.root@redhat.com>
References: <273375846.6100303.1370156285221.JavaMail.root@redhat.com>
Message-ID: <51ADAD2B.4070305@redhat.com>

On 06/02/2013 09:58 AM, Ofri Masad wrote:
> Hi all,
> 
> A new Feature page for "Network Quality of Service" feature was published.
> 
> http://www.ovirt.org/Features/Design/Network_QoS
> 
> You are more than welcome to share you thoughts and insights.
> 


Hi Ofri,

Here is another suggestion for you to consider, this suggestion is
realted only to QoS on the VNIC level -

Introducing a new entity - VNIC Profile.
The VNIC profile would include all the properties of a VNIC:
 - network,
 - Qos,
 - Port mirroring,
 - custom properties

>From now on a user would choose a VNIC profile when he defines a VNIC
(instead of choosing a network and defining properties directly on the VNIC)

A network could have multiple profiles defined on it.

A User would need permissions to use a profile instead of the current
state that we require permission to use a network.

The benefits of this approach :

1. Limiting the user to a specific QoS on a network is easy you give the
user permission to use a specific profile.

2. A user can add a new VNIC but he would be limited to QoS defined on
the profile he is able to use (which eliminates the problem that a user
can add a VNIC to it's VM but won't get any bandwidth limitations).

3. An administrator does not add VNIC QoS properties on the network
entity (to serve as defaults) which are not relevant for non-VM network.

4. The network admin who creates the VNIC profile is also the one who
can configure the QoS to that Network.

5. The separation between user portal and admin portal is very clear, in
user portal we expose only the profile name and in the admin portal a
user can view the profile details.

6. We would leave custom properties also on the VNIC level not only the
profile level so a user can send VM specific data.

7.I can also describe upgrade path but maybe we should discuss the
general concept before diving into the details.


Livnat



> Thanks,
> Ofri.
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 



From sabose at redhat.com  Tue Jun  4 09:03:54 2013
From: sabose at redhat.com (Sahina Bose)
Date: Tue, 04 Jun 2013 14:33:54 +0530
Subject: [Engine-devel] Failed to configure management network on the
 host
In-Reply-To: <51ADA20A.9080108@redhat.com>
References: <51ACAC13.9040000@redhat.com>
	<CAEWPe=r172RzXMtPx0=3M7bpFLts9T9c3NtRDQOnYn9QJ0_hdQ@mail.gmail.com>
	<51AD8058.8050901@redhat.com> <51AD87D9.6020608@redhat.com>
	<51AD8EB2.3060402@redhat.com> <51ADA20A.9080108@redhat.com>
Message-ID: <51ADAD7A.50704@redhat.com>

Hi Moti,

Had to reproduce this again to get the logs. Attached both engine and 
vdsm logs.

engine:
[org.ovirt.engine.core.vdsbroker.vdsbroker.CollectVdsNetworkDataVDSCommand] 
(pool-4-thread-4) [59b99e5d] Command CollectVdsNetworkDataVDS execution 
failed. Exception: VDSNetworkException: java.net.ConnectException: 
Connection refused

vdsm (based on flow id 59b99e5d) - no entries found.

However there's a line (without any flowId) -
Thread-13::DEBUG::2013-06-04 
14:21:05,227::BindingXMLRPC::913::vds::(wrapper) client 
[10.70.42.245]::call getCapabilities with () {}

thanks
sahina


On 06/04/2013 01:45 PM, Moti Asayag wrote:
> On 06/04/2013 09:52 AM, Sahina Bose wrote:
>> Hi Moti,
>>
>> Not sure I understand your comment about host activation flow.
>> commit bdd8966d97e1e02e775ee6f755d0a3637a668911  (engine: Remove mgmt
>> network setup from host activation) is present in our code base, but we
>> were not using the host activation flow.
> Hi,
>
> My fault, i had a different old thread in my mind.
>
> The relevant part from the engine.log indicates that the host deployment
> ended successfully, host was able to ping VDSM, but the first attempt to
> run getVdsCaps on vdsm failed.
>
> Could you add the relevant vdsm.log which contains the flow-ID 740c5292
> which matches the same correlation-id from the engine.log ?
>
>
> 2013-06-03 20:06:49,638 INFO
> [org.ovirt.engine.core.bll.InstallerMessages] (VdsDeploy) Installation
> 10.70.43.140: Stage: Termination
> 2013-06-03 20:06:49,881 ERROR
> [org.ovirt.engine.core.vdsbroker.vdsbroker.PollVDSCommand]
> (pool-4-thread-48) [740c5292] java.util.concurrent.ExecutionException:
> java.lang.reflect.InvocationTargetException
> 2013-06-03 20:06:49,882 ERROR
> [org.ovirt.engine.core.vdsbroker.vdsbroker.PollVDSCommand]
> (pool-4-thread-48) [740c5292] Command PollVDS execution failed.
> Exception: RuntimeException: java.util.concurrent.ExecutionException:
> java.lang.reflect.InvocationTargetException
> 2013-06-03 20:06:50,382 INFO
> [org.ovirt.engine.core.bll.network.NetworkConfigurator]
> (pool-4-thread-48) [740c5292] Engine managed to communicate with VDSM
> agent on host s2
> 2013-06-03 20:06:50,393 ERROR
> [org.ovirt.engine.core.vdsbroker.vdsbroker.CollectVdsNetworkDataVDSCommand]
> (pool-4-thread-48) [740c5292] Command CollectVdsNetworkDataVDS execution
> failed. Exception: VDSNetworkException: java.net.ConnectException:
> Connection refused
>
> Thanks,
> Moti
>
>> Here's what we tried to do.
>> Add a host (with vdsm 4.10.2 installed) to engine (built from Jun 2
>> upstream codebase).
>>
>> The installation failed with "Failed to configure manamgent network on
>> the host"
>>
>> and the logs had this
>>
>> 2013-06-03 19:49:03,390 INFO
>> [org.ovirt.engine.core.bll.network.NetworkConfigurator]
>> (pool-4-thread-50) [7bf46c88] Engine managed to communicate with VDSM
>> agent on host s1
>> 2013-06-03 19:49:03,412 ERROR
>> [org.ovirt.engine.core.vdsbroker.vdsbroker.CollectVdsNetworkDataVDSCommand]
>> (pool-4-thread-50) [7bf46c88] Command CollectVdsNetworkDataVDS execution
>> failed. Exception: VDSNetworkException: java.net.ConnectException:
>> Connection refused
>>
>> As Kanagaraj mentioned, reverting the Change Iaf82e104: engine:
>> Allow engine to configure management network , fixed this issue.
>>
>>  From the flowchart on
>> http://www.ovirt.org/Features/Normalized_ovirtmgmt_Initialization, it
>> seems to fail on the "Configure Management Network (by setup networks)"
>> action.
>>
>> Any help on solving this would be appreciated.
>>
>> thanks
>> sahina
>>
>>
>>
>> On 06/04/2013 11:53 AM, Moti Asayag wrote:
>>> Hi,
>>>
>>> Same host activation flow should work on the master as well as the
>>> management network will not be created as part of the host activation.
>>> So reverted changes were already merged by commit
>>> bdd8966d97e1e02e775ee6f755d0a3637a668911
>>>
>>> For more details about host installation see:
>>> http://www.ovirt.org/Features/Normalized_ovirtmgmt_Initialization
>>>
>>> Thanks,
>>> Moti
>>>
>>> See
>>> On 06/04/2013 08:51 AM, Kanagaraj wrote:
>>>> Host installation went through successfully after reverting the change
>>>> eca95e192ebf3e1fe0e9440bb8fac694214ca8fd (Change Iaf82e104: engine:
>>>> Allow engine to configure management network ).
>>>>
>>>> Thanks,
>>>> Kanagaraj
>>>>
>>>> On 06/04/2013 12:23 AM, Dead Horse wrote:
>>>>> Seeing this as well but during host activation with latest master
>>>>> vdsm/engine.
>>>>> --> http://lists.ovirt.org/pipermail/engine-devel/2013-June/004752.html
>>>>>
>>>>>
>>>>>
>>>>> On Mon, Jun 3, 2013 at 9:45 AM, Kanagaraj <kmayilsa at redhat.com
>>>>> <mailto:kmayilsa at redhat.com>> wrote:
>>>>>
>>>>>       Hi,
>>>>>
>>>>>        After adding a host to a 3.2 cluster, bootstrap went through fine
>>>>>       and in the end it failed with the following error.
>>>>>
>>>>>       "Host s2 installation failed. Failed to configure manamgent
>>>>>       network on the host."
>>>>>
>>>>>       Attached engine.log and vdsm.log
>>>>>
>>>>>       Vdsm rpms:
>>>>>       vdsm-4.10.2-22.2.el6rhs.x86_64
>>>>>       vdsm-python-4.10.2-22.2.el6rhs.x86_64
>>>>>       vdsm-cli-4.10.2-22.2.el6rhs.noarch
>>>>>       vdsm-gluster-4.10.2-22.2.el6rhs.noarch
>>>>>       vdsm-xmlrpc-4.10.2-22.2.el6rhs.noarch
>>>>>
>>>>>       Engine rpms: recent code from master
>>>>>
>>>>>       Can someone please help in resolving this issue,
>>>>>
>>>>>       Thanks,
>>>>>       Kanagaraj
>>>>>
>>>>>       _______________________________________________
>>>>>       Engine-devel mailing list
>>>>>       Engine-devel at ovirt.org <mailto:Engine-devel at ovirt.org>
>>>>>       http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>>>
>>>>>
>>> _______________________________________________
>>> Engine-devel mailing list
>>> Engine-devel at ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/engine-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: engine.log
Type: text/x-log
Size: 53624 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130604/c2233249/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vdsm.log
Type: text/x-log
Size: 28178 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130604/c2233249/attachment-0001.bin>

From wlbleaboy at 126.com  Tue Jun  4 09:14:36 2013
From: wlbleaboy at 126.com (wlbleaboy@126)
Date: Tue, 4 Jun 2013 17:14:36 +0800
Subject: [Engine-devel] =?utf-8?b?562U5aSNOiAgb3ZpcnQtZW5naW5lLXNkayB3aXRo?=
	=?utf-8?q?_C?=
In-Reply-To: <1370334090.29419.24.camel@cihla.usersys.redhat.com>
References: <000101ce4fc3$0f359570$2da0c050$@com>
	<1370334090.29419.24.camel@cihla.usersys.redhat.com>
Message-ID: <001a01ce6103$f0367520$d0a35f60$@com>

Hi Jarod.w :
	Thanks very much, I'll try the codes.
	
	And another thing about ovirt documents, I got a PDF doc from
http://www.ovirt.org/File:OVirt-API-CLI-SDK-20111102.pdf , I want to
know is there any other documents about ovirt-engine VMSM ovirt-node
in website like  http://www.ovirt.org/File*** , sometimes , there con't
fint a link from ovirt.org webpage.

-----????-----
???: David Ja?a [mailto:djasa at redhat.com] 
????: 2013?6?4? 16:22
???: leaboy at 126
??: engine-devel at ovirt.org
??: Re: [Engine-devel] ovirt-engine-sdk with C

Hi,

I'm not sure if it is applicable to your case, but there is incomplete
C/GObject implementation of oVirt SDK available here:
http://cgit.freedesktop.org/~teuf/govirt/
As far as I know, it's currently focused just on getting connection
details for VMs but I guess that more complete support for whole oVirt
API is just a matter of development...

David


leaboy at 126 p??e v Po 13. 05. 2013 v 18:17 +0800:
> Hi?All
> 
>          I felt oivrt-engine-sdk coded with Python is slowly to connect
> 
> ovirt-engine and console vm when a user have many vms, So, I just
> 
> want to rewrite the sdk with C(ANSI C Language). Just rewrite a sdk
> 
> with C to connect overt-engine and console vm, would anyone give 
> 
> me some suggestion.
> 
>  
> 
>          Now, the problem is how can I connect to ovit-engine with C, and
> 
> how can I get some information of vms, and how ovirrt-engine can 
> 
> respond my action(start,stop, .eg)
> 
>  
> 
> 
> Leaboy at beijing
> 
>                                                                  Thinks
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel

-- 

David Ja?a, RHCE

SPICE QE based in Brno
GPG Key:     22C33E24 
Fingerprint: 513A 060B D1B4 2A72 7F0D 0278 B125 CD00 22C3 3E24






From work.iec23801 at gmail.com  Tue Jun  4 10:14:05 2013
From: work.iec23801 at gmail.com (Jarod. w)
Date: Tue, 4 Jun 2013 18:14:05 +0800
Subject: [Engine-devel]
	=?utf-8?b?562U5aSNOiAgb3ZpcnQtZW5naW5lLXNkayB3aXRo?= =?utf-8?q?_C?=
In-Reply-To: <000901ce60f8$77d692f0$6783b8d0$@com>
References: <000101ce4fc3$0f359570$2da0c050$@com>
	<CAGEoUW8a4XP=VA_NHXd1wD6sqA5dBdPPauMPrQE0RiKQ4Za8Aw@mail.gmail.com>
	<000901ce60f8$77d692f0$6783b8d0$@com>
Message-ID: <CAGEoUW8UfWfj4RO699M-dOFTWv76h21R+pWL7rf8t1WoXeMeXg@mail.gmail.com>

2013/6/4 wlbleaboy at 126 <wlbleaboy at 126.com>

>  Hi, Jarod. W:****
>
>     Yes, I just want to use c to invoke ovirt engine RestAPI,****
>
> Just get vm?s id, host, port, secur-port, and ticket,****
>
>     How can I use libcurl to connect https, could give me****
>
> a simple demo to connect https://{ovirt-engine}/api with ****
>
> --cafile, the ca.crt I get from http://{ovirt-engine}/ca.crt
>
Please download the demo from the above url:
https://github.com/jarod-w/hglibraries/blob/master/demo/restapi.c


> ****
>
> ** **
>
> ** **
>
> *???:* Jarod. w [mailto:work.iec23801 at gmail.com]
> *????:* 2013?5?14? 10:27
> *???:* leaboy at 126
> *??:* engine-devel at ovirt.org
> *??:* Re: [Engine-devel] ovirt-engine-sdk with C****
>
> ** **
>
> 2013/5/13 leaboy at 126 <wlbleaboy at 126.com>****
>
>  Hi?All****
>
>          I felt oivrt-engine-sdk coded with Python is slowly to connect***
> *
>
> ovirt-engine and console vm when a user have many vms, So, I just****
>
> want to rewrite the sdk with C(ANSI C Language). Just rewrite a sdk****
>
> with C to connect overt-engine and console vm, would anyone give ****
>
> me some suggestion.****
>
>  Do you want to use c to invoke ovirt engine RestAPI, right?****
>
> If yes, you can use libcurl to do the thing, and it'll make you happy.****
>
>  ****
>
>   ****
>
>          Now, the problem is how can I connect to ovit-engine with C, and*
> ***
>
> how can I get some information of vms, and how ovirrt-engine can ****
>
> respond my action(start,stop, .eg)****
>
> Agree with Michael Pasternak.****
>
> You should parse your code into the mail list, or someone can't help****
>
> you.****
>
>  ****
>
>   ****
>
>
> Leaboy at beijing****
>
>                                                                  Thinks***
> *
>
>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel****
>
>
>
>
> --
> ---
> Best Regards
> Jarod.W****
>



-- 
---
Best Regards
Jarod.W
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130604/bb25797d/attachment.html>

From wlbleaboy at 126.com  Tue Jun  4 10:23:14 2013
From: wlbleaboy at 126.com (wlbleaboy@126)
Date: Tue, 4 Jun 2013 18:23:14 +0800
Subject: [Engine-devel] about govirt
Message-ID: <002a01ce610d$863d8190$92b884b0$@com>

Hi, cfergeau:

         Recently, I do something about ovirt-engine-sdk, I just want to 

console a vm via sdk, but I found the sdk implemented by python is

so slowly, so I want to build a simple sdk use C to do that,

 

         before I do it, I found the code govirt you worte, I felt luckly,
you 

had do that. So I got the code, but when I build it on ubuntu, it's failed

I used autogen.sh , but got the error message

like:

         configure: error: Package requirements (rest-0.7 >= 0.7.13) were
not met:

 

No package 'rest-0.7' found

 

         Because I didn't familiar with autogen and configure, such gnu
build tools,

 

 

 

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130604/8a9fb46a/attachment.html>

From djasa at redhat.com  Tue Jun  4 10:42:07 2013
From: djasa at redhat.com (David =?UTF-8?Q?Ja=C5=A1a?=)
Date: Tue, 04 Jun 2013 12:42:07 +0200
Subject: [Engine-devel] about govirt
In-Reply-To: <002a01ce610d$863d8190$92b884b0$@com>
References: <002a01ce610d$863d8190$92b884b0$@com>
Message-ID: <1370342527.29419.34.camel@cihla.usersys.redhat.com>

wlbleaboy at 126 p??e v ?t 04. 06. 2013 v 18:23 +0800:
> Hi, cfergeau:
> 
>          Recently, I do something about ovirt-engine-sdk, I just want to 
> 
> console a vm via sdk, but I found the sdk implemented by python is
> 
> so slowly, so I want to build a simple sdk use C to do that,
> 
>  
> 
>          before I do it, I found the code govirt you worte, I felt luckly,
> you 
> 
> had do that. So I got the code, but when I build it on ubuntu, it's failed
> 
> I used autogen.sh , but got the error message
> 
> like:
> 
>          configure: error: Package requirements (rest-0.7 >= 0.7.13) were
> not met:

IMO you should install librest-dev package on the development machine.

David

> 
>  
> 
> No package 'rest-0.7' found
> 
>  
> 
>          Because I didn't familiar with autogen and configure, such gnu
> build tools,
> 
>  
> 
> 
> 
> 
> 
> 
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel

-- 

David Ja?a, RHCE

SPICE QE based in Brno
GPG Key:     22C33E24 
Fingerprint: 513A 060B D1B4 2A72 7F0D 0278 B125 CD00 22C3 3E24


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5727 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130604/b6d05f9b/attachment.bin>

From lzelkha at redhat.com  Tue Jun  4 11:43:55 2013
From: lzelkha at redhat.com (Liran Zelkha)
Date: Tue, 4 Jun 2013 07:43:55 -0400 (EDT)
Subject: [Engine-devel] Performance and scalability
Message-ID: <1247864565.11509776.1370346235729.JavaMail.root@redhat.com>

Hi all,

I've added a new feature page for Performance and Scalability. Please review and add your ideas... 
http://www.ovirt.org/Features/Performance_And_Scalability


From mpastern at redhat.com  Tue Jun  4 13:27:31 2013
From: mpastern at redhat.com (Michael Pasternak)
Date: Tue, 04 Jun 2013 16:27:31 +0300
Subject: [Engine-devel] ovirt-engine-sdk-java 1.0.0.7-1 released
In-Reply-To: <515D6051.3090604@redhat.com>
References: <515D6051.3090604@redhat.com>
Message-ID: <51ADEB43.8090908@redhat.com>


- updated storagedomain add()/update() docs
- updated tag update() docs
- enabled correct generation of Boolean getters/setters
  to enable Bean Introspection apis (bollean getters will
  be prefixed with getX())
- fixed docs for GlusterBricks add|update
- fixed docs for add|update Tag
- added [network.usages.usage] to ClusterNetworks
- in add TemplateNICs, network.id|name is no longer mandatory
- StorageDomainVM can be removed asynchronously now
- removed DataCenterQuota.add|delete (yet not supported)


More details can be found at [1].

[1] http://www.ovirt.org/Java-sdk-changelog


-- 

Michael Pasternak
RedHat, ENG-Virtualization R&D


From lhornyak at redhat.com  Tue Jun  4 14:01:37 2013
From: lhornyak at redhat.com (Laszlo Hornyak)
Date: Tue, 4 Jun 2013 10:01:37 -0400 (EDT)
Subject: [Engine-devel] Performance and scalability
In-Reply-To: <1247864565.11509776.1370346235729.JavaMail.root@redhat.com>
References: <1247864565.11509776.1370346235729.JavaMail.root@redhat.com>
Message-ID: <1183814794.11684244.1370354496985.JavaMail.root@redhat.com>

Hi Liran,

Some comments to start the discussion:
- Caching: exactly how is this resultset caching going to work? Wouldnt it be more simple to just cache the mapped entities? The mapping is not a big overhead, but caching the resultset seems to be difficult.
- Batch updates: sounds cool, transactions are a major overhead on performance, so if you can make the update in a single tx and few interactions that will rock, but what if we keep the dynamic and statistic data in the memory at the first place and synchronize to DB on a background process. So that when you look for dynamic/statistics data, you do not have to hit the DB.

Thx,
Laszlo

----- Original Message -----
> From: "Liran Zelkha" <lzelkha at redhat.com>
> To: "engine-devel" <engine-devel at ovirt.org>
> Sent: Tuesday, June 4, 2013 1:43:55 PM
> Subject: [Engine-devel] Performance and scalability
> 
> Hi all,
> 
> I've added a new feature page for Performance and Scalability. Please review
> and add your ideas...
> http://www.ovirt.org/Features/Performance_And_Scalability
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From masayag at redhat.com  Tue Jun  4 14:19:56 2013
From: masayag at redhat.com (Moti Asayag)
Date: Tue, 04 Jun 2013 17:19:56 +0300
Subject: [Engine-devel] Failed to configure management network on the
 host
In-Reply-To: <51ADAD7A.50704@redhat.com>
References: <51ACAC13.9040000@redhat.com>
	<CAEWPe=r172RzXMtPx0=3M7bpFLts9T9c3NtRDQOnYn9QJ0_hdQ@mail.gmail.com>
	<51AD8058.8050901@redhat.com> <51AD87D9.6020608@redhat.com>
	<51AD8EB2.3060402@redhat.com> <51ADA20A.9080108@redhat.com>
	<51ADAD7A.50704@redhat.com>
Message-ID: <51ADF78C.1010207@redhat.com>

Hi Sahina,

I was able to reproduce it on my setup, it seems that when a host was
already installed and the user re-installed it, it failed to check the
host availability.

I fixed the host polling by the engine by commit
5c03a936df3a09473f1a05b973680c02280d7a5c.

You can either build from master or wait for the nightly build.
Please let me know if there are more issues.

Thanks,
Moti

On 06/04/2013 12:03 PM, Sahina Bose wrote:
> Hi Moti,
> 
> Had to reproduce this again to get the logs. Attached both engine and
> vdsm logs.
> 
> engine:
> [org.ovirt.engine.core.vdsbroker.vdsbroker.CollectVdsNetworkDataVDSCommand]
> (pool-4-thread-4) [59b99e5d] Command CollectVdsNetworkDataVDS execution
> failed. Exception: VDSNetworkException: java.net.ConnectException:
> Connection refused
> 
> vdsm (based on flow id 59b99e5d) - no entries found.
> 
> However there's a line (without any flowId) -
> Thread-13::DEBUG::2013-06-04
> 14:21:05,227::BindingXMLRPC::913::vds::(wrapper) client
> [10.70.42.245]::call getCapabilities with () {}
> 
> thanks
> sahina
> 
> 
> On 06/04/2013 01:45 PM, Moti Asayag wrote:
>> On 06/04/2013 09:52 AM, Sahina Bose wrote:
>>> Hi Moti,
>>>
>>> Not sure I understand your comment about host activation flow.
>>> commit bdd8966d97e1e02e775ee6f755d0a3637a668911  (engine: Remove mgmt
>>> network setup from host activation) is present in our code base, but we
>>> were not using the host activation flow.
>> Hi,
>>
>> My fault, i had a different old thread in my mind.
>>
>> The relevant part from the engine.log indicates that the host deployment
>> ended successfully, host was able to ping VDSM, but the first attempt to
>> run getVdsCaps on vdsm failed.
>>
>> Could you add the relevant vdsm.log which contains the flow-ID 740c5292
>> which matches the same correlation-id from the engine.log ?
>>
>>
>> 2013-06-03 20:06:49,638 INFO
>> [org.ovirt.engine.core.bll.InstallerMessages] (VdsDeploy) Installation
>> 10.70.43.140: Stage: Termination
>> 2013-06-03 20:06:49,881 ERROR
>> [org.ovirt.engine.core.vdsbroker.vdsbroker.PollVDSCommand]
>> (pool-4-thread-48) [740c5292] java.util.concurrent.ExecutionException:
>> java.lang.reflect.InvocationTargetException
>> 2013-06-03 20:06:49,882 ERROR
>> [org.ovirt.engine.core.vdsbroker.vdsbroker.PollVDSCommand]
>> (pool-4-thread-48) [740c5292] Command PollVDS execution failed.
>> Exception: RuntimeException: java.util.concurrent.ExecutionException:
>> java.lang.reflect.InvocationTargetException
>> 2013-06-03 20:06:50,382 INFO
>> [org.ovirt.engine.core.bll.network.NetworkConfigurator]
>> (pool-4-thread-48) [740c5292] Engine managed to communicate with VDSM
>> agent on host s2
>> 2013-06-03 20:06:50,393 ERROR
>> [org.ovirt.engine.core.vdsbroker.vdsbroker.CollectVdsNetworkDataVDSCommand]
>>
>> (pool-4-thread-48) [740c5292] Command CollectVdsNetworkDataVDS execution
>> failed. Exception: VDSNetworkException: java.net.ConnectException:
>> Connection refused
>>
>> Thanks,
>> Moti
>>
>>> Here's what we tried to do.
>>> Add a host (with vdsm 4.10.2 installed) to engine (built from Jun 2
>>> upstream codebase).
>>>
>>> The installation failed with "Failed to configure manamgent network on
>>> the host"
>>>
>>> and the logs had this
>>>
>>> 2013-06-03 19:49:03,390 INFO
>>> [org.ovirt.engine.core.bll.network.NetworkConfigurator]
>>> (pool-4-thread-50) [7bf46c88] Engine managed to communicate with VDSM
>>> agent on host s1
>>> 2013-06-03 19:49:03,412 ERROR
>>> [org.ovirt.engine.core.vdsbroker.vdsbroker.CollectVdsNetworkDataVDSCommand]
>>>
>>> (pool-4-thread-50) [7bf46c88] Command CollectVdsNetworkDataVDS execution
>>> failed. Exception: VDSNetworkException: java.net.ConnectException:
>>> Connection refused
>>>
>>> As Kanagaraj mentioned, reverting the Change Iaf82e104: engine:
>>> Allow engine to configure management network , fixed this issue.
>>>
>>>  From the flowchart on
>>> http://www.ovirt.org/Features/Normalized_ovirtmgmt_Initialization, it
>>> seems to fail on the "Configure Management Network (by setup networks)"
>>> action.
>>>
>>> Any help on solving this would be appreciated.
>>>
>>> thanks
>>> sahina
>>>
>>>
>>>
>>> On 06/04/2013 11:53 AM, Moti Asayag wrote:
>>>> Hi,
>>>>
>>>> Same host activation flow should work on the master as well as the
>>>> management network will not be created as part of the host activation.
>>>> So reverted changes were already merged by commit
>>>> bdd8966d97e1e02e775ee6f755d0a3637a668911
>>>>
>>>> For more details about host installation see:
>>>> http://www.ovirt.org/Features/Normalized_ovirtmgmt_Initialization
>>>>
>>>> Thanks,
>>>> Moti
>>>>
>>>> See
>>>> On 06/04/2013 08:51 AM, Kanagaraj wrote:
>>>>> Host installation went through successfully after reverting the change
>>>>> eca95e192ebf3e1fe0e9440bb8fac694214ca8fd (Change Iaf82e104: engine:
>>>>> Allow engine to configure management network ).
>>>>>
>>>>> Thanks,
>>>>> Kanagaraj
>>>>>
>>>>> On 06/04/2013 12:23 AM, Dead Horse wrote:
>>>>>> Seeing this as well but during host activation with latest master
>>>>>> vdsm/engine.
>>>>>> -->
>>>>>> http://lists.ovirt.org/pipermail/engine-devel/2013-June/004752.html
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Mon, Jun 3, 2013 at 9:45 AM, Kanagaraj <kmayilsa at redhat.com
>>>>>> <mailto:kmayilsa at redhat.com>> wrote:
>>>>>>
>>>>>>       Hi,
>>>>>>
>>>>>>        After adding a host to a 3.2 cluster, bootstrap went
>>>>>> through fine
>>>>>>       and in the end it failed with the following error.
>>>>>>
>>>>>>       "Host s2 installation failed. Failed to configure manamgent
>>>>>>       network on the host."
>>>>>>
>>>>>>       Attached engine.log and vdsm.log
>>>>>>
>>>>>>       Vdsm rpms:
>>>>>>       vdsm-4.10.2-22.2.el6rhs.x86_64
>>>>>>       vdsm-python-4.10.2-22.2.el6rhs.x86_64
>>>>>>       vdsm-cli-4.10.2-22.2.el6rhs.noarch
>>>>>>       vdsm-gluster-4.10.2-22.2.el6rhs.noarch
>>>>>>       vdsm-xmlrpc-4.10.2-22.2.el6rhs.noarch
>>>>>>
>>>>>>       Engine rpms: recent code from master
>>>>>>
>>>>>>       Can someone please help in resolving this issue,
>>>>>>
>>>>>>       Thanks,
>>>>>>       Kanagaraj
>>>>>>
>>>>>>       _______________________________________________
>>>>>>       Engine-devel mailing list
>>>>>>       Engine-devel at ovirt.org <mailto:Engine-devel at ovirt.org>
>>>>>>       http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>>>>
>>>>>>
>>>> _______________________________________________
>>>> Engine-devel mailing list
>>>> Engine-devel at ovirt.org
>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 



From lzelkha at redhat.com  Tue Jun  4 14:27:25 2013
From: lzelkha at redhat.com (Liran Zelkha)
Date: Tue, 4 Jun 2013 10:27:25 -0400 (EDT)
Subject: [Engine-devel] Performance and scalability
In-Reply-To: <1183814794.11684244.1370354496985.JavaMail.root@redhat.com>
References: <1247864565.11509776.1370346235729.JavaMail.root@redhat.com>
	<1183814794.11684244.1370354496985.JavaMail.root@redhat.com>
Message-ID: <1010286731.11698764.1370356045751.JavaMail.root@redhat.com>

Hi Laszlo

I 100% agree with both of your remarks. 
Caching is caching the entities, but also attempting to cache the list of entities.
Batch updates is done as an infrastructure (change was reviewed and now in fixes) and after that - we can start using it everywhere.

----- Original Message -----
From: "Laszlo Hornyak" <lhornyak at redhat.com>
To: "Liran Zelkha" <lzelkha at redhat.com>
Cc: "engine-devel" <engine-devel at ovirt.org>
Sent: Tuesday, June 4, 2013 5:01:37 PM
Subject: Re: [Engine-devel] Performance and scalability

Hi Liran,

Some comments to start the discussion:
- Caching: exactly how is this resultset caching going to work? Wouldnt it be more simple to just cache the mapped entities? The mapping is not a big overhead, but caching the resultset seems to be difficult.
- Batch updates: sounds cool, transactions are a major overhead on performance, so if you can make the update in a single tx and few interactions that will rock, but what if we keep the dynamic and statistic data in the memory at the first place and synchronize to DB on a background process. So that when you look for dynamic/statistics data, you do not have to hit the DB.

Thx,
Laszlo

----- Original Message -----
> From: "Liran Zelkha" <lzelkha at redhat.com>
> To: "engine-devel" <engine-devel at ovirt.org>
> Sent: Tuesday, June 4, 2013 1:43:55 PM
> Subject: [Engine-devel] Performance and scalability
> 
> Hi all,
> 
> I've added a new feature page for Performance and Scalability. Please review
> and add your ideas...
> http://www.ovirt.org/Features/Performance_And_Scalability
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From cfergeau at redhat.com  Tue Jun  4 16:02:11 2013
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Tue, 4 Jun 2013 18:02:11 +0200
Subject: [Engine-devel] about govirt
In-Reply-To: <1370342527.29419.34.camel@cihla.usersys.redhat.com>
References: <002a01ce610d$863d8190$92b884b0$@com>
	<1370342527.29419.34.camel@cihla.usersys.redhat.com>
Message-ID: <20130604160211.GI11272@teriyaki.redhat.com>

On Tue, Jun 04, 2013 at 12:42:07PM +0200, David Ja?a wrote:
> wlbleaboy at 126 p??e v ?t 04. 06. 2013 v 18:23 +0800:
> > Hi, cfergeau:
> > 
> >          Recently, I do something about ovirt-engine-sdk, I just want to 
> > 
> > console a vm via sdk, but I found the sdk implemented by python is
> > 
> > so slowly, so I want to build a simple sdk use C to do that,
> > 
> >  
> > 
> >          before I do it, I found the code govirt you worte, I felt luckly,
> > you 
> > 
> > had do that. So I got the code, but when I build it on ubuntu, it's failed
> > 
> > I used autogen.sh , but got the error message
> > 
> > like:
> > 
> >          configure: error: Package requirements (rest-0.7 >= 0.7.13) were
> > not met:
> 
> IMO you should install librest-dev package on the development machine.

Yes, that should do it. Keep in mind that 0.7.13 is a fairly recent
version, so if this still does not work, double-check what was installed.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130604/0f5a75ab/attachment.sig>

From iheim at redhat.com  Tue Jun  4 21:29:16 2013
From: iheim at redhat.com (Itamar Heim)
Date: Wed, 05 Jun 2013 00:29:16 +0300
Subject: [Engine-devel] about govirt
In-Reply-To: <002a01ce610d$863d8190$92b884b0$@com>
References: <002a01ce610d$863d8190$92b884b0$@com>
Message-ID: <51AE5C2C.1070108@redhat.com>

On 06/04/2013 01:23 PM, wlbleaboy at 126 wrote:
> Hi, cfergeau:
>
>           Recently, I do something about ovirt-engine-sdk, I just want to
>
> console a vm via sdk, but I found the sdk implemented by python is
>
> so slowly, so I want to build a simple sdk use C to do that,

Can you please share more info on what do you mean by "slow"?

Thanks,
    Itamar

>
>           before I do it, I found the code govirt you worte, I felt
> luckly, you
>
> had do that. So I got the code, but when I build it on ubuntu, it?s failed
>
> I used autogen.sh , but got the error message
>
> like:
>
>           configure: error: Package requirements (rest-0.7 >= 0.7.13)
> were not met:
>
> No package 'rest-0.7' found
>
>           Because I didn?t familiar with autogen and configure, such gnu
> build tools,
>
>
>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>



From wlbleaboy at 126.com  Wed Jun  5 03:04:28 2013
From: wlbleaboy at 126.com (wlbleaboy@126)
Date: Wed, 5 Jun 2013 11:04:28 +0800
Subject: [Engine-devel] ovirt-engine-sdk with C
In-Reply-To: <CAGEoUW8UfWfj4RO699M-dOFTWv76h21R+pWL7rf8t1WoXeMeXg@mail.gmail.com>
References: <000101ce4fc3$0f359570$2da0c050$@com>	<CAGEoUW8a4XP=VA_NHXd1wD6sqA5dBdPPauMPrQE0RiKQ4Za8Aw@mail.gmail.com>	<000901ce60f8$77d692f0$6783b8d0$@com>
	<CAGEoUW8UfWfj4RO699M-dOFTWv76h21R+pWL7rf8t1WoXeMeXg@mail.gmail.com>
Message-ID: <006901ce6199$657eea70$307cbf50$@com>

Hi, Jarod. W:

         I got your demo, and a build libcurl, but I can?t get any info

from https://{ovirt-engine }/api .

my code like this:

int main(void)

{

    CURL *curl;

    CURLcode res;

    curl = curl_easy_init();

 

    if (curl)

    {

        printf("enter....\n");

        curl_easy_setopt(curl, CURLOPT_URL, "https://192.168.1.201/api");

        curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, callback_func);

        curl_easy_setopt(curl, CURLOPT_USERPWD, "admin at internal:111111");

        curl_easy_setopt(curl, CURLOPT_CAINFO,"/tmp/ca.crt");

        curl_easy_perform(curl);

        printf("exit.....\n");

 

        curl_easy_cleanup(curl);

    }

 

    return 0;

}

 

And when I run it, just outpu :

enter....

exit.....

 

I got the libcurl from http://curl.haxx.se/download.html <http://curl.haxx.se/download.html%20and%20chosed%20curl-7.30.0.tar.gz>  and chosed curl-7.30.0.tar.gz

and I use make and make install without any other options . I just guess maybe it need

other SSL library supported, but I don?t know how and which .

 

???: Jarod. w [mailto:work.iec23801 at gmail.com] 
????: 2013?6?4? 18:14
???: wlbleaboy at 126
??: engine-devel at ovirt.org
??: Re: ??: [Engine-devel] ovirt-engine-sdk with C

 

2013/6/4 wlbleaboy at 126 <wlbleaboy at 126.com>

Hi, Jarod. W:

    Yes, I just want to use c to invoke ovirt engine RestAPI,

Just get vm?s id, host, port, secur-port, and ticket,

    How can I use libcurl to connect https, could give me

a simple demo to connect https://{ovirt-engine}/api <https://%7bovirt-engine%7d/api>  with 

--cafile, the ca.crt I get from http://{ovirt-engine}/ca.crt <http://%7bovirt-engine%7d/ca.crt> 

Please download the demo from the above url:
https://github.com/jarod-w/hglibraries/blob/master/demo/restapi.c
 

 

 

???: Jarod. w [mailto:work.iec23801 at gmail.com] 
????: 2013?5?14? 10:27
???: leaboy at 126
??: engine-devel at ovirt.org
??: Re: [Engine-devel] ovirt-engine-sdk with C

 

2013/5/13 leaboy at 126 <wlbleaboy at 126.com>

Hi?All

         I felt oivrt-engine-sdk coded with Python is slowly to connect

ovirt-engine and console vm when a user have many vms, So, I just

want to rewrite the sdk with C(ANSI C Language). Just rewrite a sdk

with C to connect overt-engine and console vm, would anyone give 

me some suggestion.

Do you want to use c to invoke ovirt engine RestAPI, right?

If yes, you can use libcurl to do the thing, and it'll make you happy.

 

 

         Now, the problem is how can I connect to ovit-engine with C, and

how can I get some information of vms, and how ovirrt-engine can 

respond my action(start,stop, .eg)

Agree with Michael Pasternak.

You should parse your code into the mail list, or someone can't help

you.

 

 

                                                                                    Leaboy at beijing

                                                                 Thinks


_______________________________________________
Engine-devel mailing list
Engine-devel at ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel




-- 
---
Best Regards
Jarod.W




-- 
---
Best Regards
Jarod.W

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130605/4d875ba7/attachment.html>

From work.iec23801 at gmail.com  Wed Jun  5 03:34:34 2013
From: work.iec23801 at gmail.com (Jarod. w)
Date: Wed, 5 Jun 2013 11:34:34 +0800
Subject: [Engine-devel] ovirt-engine-sdk with C
In-Reply-To: <006901ce6199$657eea70$307cbf50$@com>
References: <000101ce4fc3$0f359570$2da0c050$@com>
	<CAGEoUW8a4XP=VA_NHXd1wD6sqA5dBdPPauMPrQE0RiKQ4Za8Aw@mail.gmail.com>
	<000901ce60f8$77d692f0$6783b8d0$@com>
	<CAGEoUW8UfWfj4RO699M-dOFTWv76h21R+pWL7rf8t1WoXeMeXg@mail.gmail.com>
	<006901ce6199$657eea70$307cbf50$@com>
Message-ID: <CAGEoUW9=J+WoB2Ds1y2sNn0JFEsz6JAY417GY+G5jF5t5UY1aQ@mail.gmail.com>

2013/6/5 wlbleaboy at 126 <wlbleaboy at 126.com>

>  Hi, Jarod. W:****
>
>          I got your demo, and a build libcurl, but I can?t get any info***
> *
>
> from https://{ovirt-engine }/api .****
>
> my code like this:
>
Please try to run the below command:
--
curl https://YOURIP/api -u YOURNAME:YOURPASSWD --cacert /root/ca.crt
--
After, please parse the result.

ps, I run the program on centos 6.4, and it works.

thanks.


> ****
>
> int main(void)****
>
> {****
>
>     CURL *curl;****
>
>     CURLcode res;****
>
>     curl = curl_easy_init();****
>
> ** **
>
>     if (curl)****
>
>     {****
>
>         printf("enter....\n");****
>
>         curl_easy_setopt(curl, CURLOPT_URL, "*https://192.168.1.201/api*
> ");****
>
>         curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, callback_func);****
>
>         curl_easy_setopt(curl, CURLOPT_USERPWD, "*admin at internal:111111*
> ");****
>
>         curl_easy_setopt(curl, CURLOPT_CAINFO,"*/tmp/ca.crt*");****
>
>         curl_easy_perform(curl);****
>
>         printf("exit.....\n");****
>
> ** **
>
>         curl_easy_cleanup(curl);****
>
>     }****
>
> ** **
>
>     return 0;****
>
> }****
>
> ** **
>
> And when I run it, just outpu :****
>
> *enter....*
>
> *exit.....*
>
> ** **
>
> I got the libcurl from http://curl.haxx.se/download.html and chosed
> curl-7.30.0.tar.gz<http://curl.haxx.se/download.html%20and%20chosed%20curl-7.30.0.tar.gz>
> ****
>
> and I use make and make install without any other options . I just guess
> maybe it need****
>
> other SSL library supported, but I don?t know how and which .****
>
> ** **
>
> *???:* Jarod. w [mailto:work.iec23801 at gmail.com]
> *????:* 2013?6?4? 18:14
> *???:* wlbleaboy at 126
> *??:* engine-devel at ovirt.org
> *??:* Re: ??: [Engine-devel] ovirt-engine-sdk with C****
>
>  ** **
>
> 2013/6/4 wlbleaboy at 126 <wlbleaboy at 126.com>****
>
>  Hi, Jarod. W:****
>
>     Yes, I just want to use c to invoke ovirt engine RestAPI,****
>
> Just get vm?s id, host, port, secur-port, and ticket,****
>
>     How can I use libcurl to connect https, could give me****
>
> a simple demo to connect https://{ovirt-engine}/api with ****
>
> --cafile, the ca.crt I get from http://{ovirt-engine}/ca.crt****
>
>  Please download the demo from the above url:
> https://github.com/jarod-w/hglibraries/blob/master/demo/restapi.c
>  ****
>
>   ****
>
>  ****
>
> *???:* Jarod. w [mailto:work.iec23801 at gmail.com]
> *????:* 2013?5?14? 10:27
> *???:* leaboy at 126
> *??:* engine-devel at ovirt.org
> *??:* Re: [Engine-devel] ovirt-engine-sdk with C****
>
>  ****
>
> 2013/5/13 leaboy at 126 <wlbleaboy at 126.com>****
>
>  Hi?All****
>
>          I felt oivrt-engine-sdk coded with Python is slowly to connect***
> *
>
> ovirt-engine and console vm when a user have many vms, So, I just****
>
> want to rewrite the sdk with C(ANSI C Language). Just rewrite a sdk****
>
> with C to connect overt-engine and console vm, would anyone give ****
>
> me some suggestion.****
>
>  Do you want to use c to invoke ovirt engine RestAPI, right?****
>
> If yes, you can use libcurl to do the thing, and it'll make you happy.****
>
>  ****
>
>   ****
>
>          Now, the problem is how can I connect to ovit-engine with C, and*
> ***
>
> how can I get some information of vms, and how ovirrt-engine can ****
>
> respond my action(start,stop, .eg)****
>
> Agree with Michael Pasternak.****
>
> You should parse your code into the mail list, or someone can't help****
>
> you.****
>
>  ****
>
>   ****
>
>
> Leaboy at beijing****
>
>                                                                  Thinks***
> *
>
>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel****
>
>
>
>
> --
> ---
> Best Regards
> Jarod.W****
>
>
>
>
> --
> ---
> Best Regards
> Jarod.W****
>



-- 
---
Best Regards
Jarod.W
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130605/300187ac/attachment.html>

From tjelinek at redhat.com  Wed Jun  5 06:34:52 2013
From: tjelinek at redhat.com (Tomas Jelinek)
Date: Wed, 5 Jun 2013 02:34:52 -0400 (EDT)
Subject: [Engine-devel] static header only in VM dialog?
In-Reply-To: <933117150.38946446.1370267910493.JavaMail.root@redhat.com>
References: <gerrit.1368170341473.Icad8098e286f821da25fac22fd0a840a42f105c9@gerrit.ovirt.org>
	<73EDF069-94CA-4BEC-8464-F1006BA4954C@redhat.com>
	<909641716.16748965.1370015793965.JavaMail.root@redhat.com>
	<51A8C9BD.5040706@redhat.com>
	<1754688018.16770394.1370017699165.JavaMail.root@redhat.com>
	<2128095245.12545499.1370244288395.JavaMail.root@redhat.com>
	<1088136010.17701900.1370262405492.JavaMail.root@redhat.com>
	<933117150.38946446.1370267910493.JavaMail.root@redhat.com>
Message-ID: <1185129992.13832458.1370414092724.JavaMail.root@redhat.com>

So, are there any additional concerns/questions which need to be discussed? I understand that we have one more 
month but I would like to avoid the situation from a week ago that the last possible day we realize that we don't
have any more time anymore :)

----- Original Message -----
> From: "Malini Rao" <mrao at redhat.com>
> To: "Einav Cohen" <ecohen at redhat.com>
> Cc: "Tomas Jelinek" <tjelinek at redhat.com>, "Daniel Erez" <derez at redhat.com>, "Itamar Heim" <iheim at redhat.com>,
> "Michal Skrivanek" <michal.skrivanek at redhat.com>, "Eldan Hildesheim" <info at eldanet.com>, "engine-devel"
> <engine-devel at ovirt.org>, "Eldan Hildesheim" <ehildesh at redhat.com>
> Sent: Monday, June 3, 2013 3:58:30 PM
> Subject: Re: [Engine-devel] static header only in VM dialog?
> 
> 
> 
> 
> 
> ----- Original Message -----
> > From: "Einav Cohen" <ecohen at redhat.com>
> > To: "Tomas Jelinek" <tjelinek at redhat.com>, "Daniel Erez" <derez at redhat.com>
> > Cc: "Itamar Heim" <iheim at redhat.com>, "Michal Skrivanek"
> > <michal.skrivanek at redhat.com>, "Eldan Hildesheim"
> > <info at eldanet.com>, "engine-devel" <engine-devel at ovirt.org>, "Eldan
> > Hildesheim" <ehildesh at redhat.com>, "Malini Rao"
> > <mrao at redhat.com>
> > Sent: Monday, June 3, 2013 8:26:45 AM
> > Subject: Re: [Engine-devel] static header only in VM dialog?
> > 
> > > > ...
> > > > 
> > > > @Tomas - I suggest that you will clarify:
> > > > 
> > > > A) which fields exactly are going to be included in the top static
> > > > header
> > > > of
> > > > the New VM
> > > > dialog *in your current patch batch* [2], and:
> > > 
> > > - Data Center
> > > - Cluster
> > > - Quota
> > > - Template (because according to the mockup the Image field will contain
> > > both
> > > Template and Image, so until we have images, just templates are there)
> > > - Vm Type (e.g. if server or desktop)
> > > - OS type
> > > (well, basically according to mockup, just without the instance type)
> > > 
> > > > 
> > > > B) which side-tabs in the New VM dialog will be affected by the fields
> > > > in
> > > > (A).
> > > 
> > > More or less all with some exceptions - especially thanx to the template
> > > field. And this will not change at all after introducing instance
> > > types/templates because template = instance type + image.
> > 
> > So it seems that it would make sense to introduce the top static header
> > even
> > before introducing the Instance Types + Image fields, as it already
> > contains
> > fields (namely 'Template') that affect most of the side-tabs.
> > Thanks, Tomas, for the clarification.
> > 
> > > So the question is not really if we want to
> > > wait until the instance types and images will affect enough side tabs
> > > (because that
> > > will not change at all) but if we want to have a top header panel or not.
> > > I
> > > personally start to think that it is more or less a question of taste.
> > > One may argue that it makes the dialogs more understandable (by having
> > > context all the time) and other that it makes them more un-understandable
> > > by
> > > flood of information in context you don't need.
> > > I guess either way has some advantages and disadvantages and there is no
> > > strict good/wrong solution.
> > 
> > +1
> 
> One way to limit this flooding of information in unnecessary contexts is to
> not apply a blind rule that the static panel will appear for all dialogs
> with sub tabs. 
+1

> As outlined in a previous email, the static panel should be
> used only if there is a  dependency and it is impossible to show the
> interdependent fields on the same page. The other important thing we should
> do is very carefully consider what fields populate the static panel. The
> idea is that this panel is minimal and should definitely not becoming like a
> page in itself.
> 
> -Malini
> 
> 
> > 
> > > ...
> > 
> 


From wlbleaboy at 126.com  Wed Jun  5 06:43:14 2013
From: wlbleaboy at 126.com (wlbleaboy@126)
Date: Wed, 5 Jun 2013 14:43:14 +0800
Subject: [Engine-devel] about govirt
In-Reply-To: <51AE5C2C.1070108@redhat.com>
References: <002a01ce610d$863d8190$92b884b0$@com> <51AE5C2C.1070108@redhat.com>
Message-ID: <007d01ce61b7$f4ffd740$deff85c0$@com>

Hi, Itamar Heim:
	I used ovirit-engine-sdk-python to connect ovirt-engine and get vms
It's about 20 seconds, so I felt it's slow.

	I have build govirt success, but how can I use it, I give
REST_URI="https://192.168.1.201/api",
and proxy = ovirt_proxy_new(REST_URI) always return NULL;

-----Original Message-----
From: Itamar Heim [mailto:iheim at redhat.com] 
Sent: Wednesday, June 05, 2013 5:29 AM
To: wlbleaboy at 126
Cc: cfergeau at redhat.com; engine-devel at ovirt.org; Michael Pasternak
Subject: Re: [Engine-devel] about govirt

On 06/04/2013 01:23 PM, wlbleaboy at 126 wrote:
> Hi, cfergeau:
>
>           Recently, I do something about ovirt-engine-sdk, I just want to
>
> console a vm via sdk, but I found the sdk implemented by python is
>
> so slowly, so I want to build a simple sdk use C to do that,

Can you please share more info on what do you mean by "slow"?

Thanks,
    Itamar

>
>           before I do it, I found the code govirt you worte, I felt
> luckly, you
>
> had do that. So I got the code, but when I build it on ubuntu, it's failed
>
> I used autogen.sh , but got the error message
>
> like:
>
>           configure: error: Package requirements (rest-0.7 >= 0.7.13)
> were not met:
>
> No package 'rest-0.7' found
>
>           Because I didn't familiar with autogen and configure, such gnu
> build tools,
>
>
>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>




From iheim at redhat.com  Wed Jun  5 06:57:59 2013
From: iheim at redhat.com (Itamar Heim)
Date: Wed, 05 Jun 2013 09:57:59 +0300
Subject: [Engine-devel] about govirt
In-Reply-To: <007d01ce61b7$f4ffd740$deff85c0$@com>
References: <002a01ce610d$863d8190$92b884b0$@com> <51AE5C2C.1070108@redhat.com>
	<007d01ce61b7$f4ffd740$deff85c0$@com>
Message-ID: <51AEE177.2090902@redhat.com>

On 06/05/2013 09:43 AM, wlbleaboy at 126 wrote:
> Hi, Itamar Heim:
> 	I used ovirit-engine-sdk-python to connect ovirt-engine and get vms
> It's about 20 seconds, so I felt it's slow.

and just to compare, how much time does a curl/wget takes you?

>
> 	I have build govirt success, but how can I use it, I give
> REST_URI="https://192.168.1.201/api",
> and proxy = ovirt_proxy_new(REST_URI) always return NULL;
>
> -----Original Message-----
> From: Itamar Heim [mailto:iheim at redhat.com]
> Sent: Wednesday, June 05, 2013 5:29 AM
> To: wlbleaboy at 126
> Cc: cfergeau at redhat.com; engine-devel at ovirt.org; Michael Pasternak
> Subject: Re: [Engine-devel] about govirt
>
> On 06/04/2013 01:23 PM, wlbleaboy at 126 wrote:
>> Hi, cfergeau:
>>
>>            Recently, I do something about ovirt-engine-sdk, I just want to
>>
>> console a vm via sdk, but I found the sdk implemented by python is
>>
>> so slowly, so I want to build a simple sdk use C to do that,
>
> Can you please share more info on what do you mean by "slow"?
>
> Thanks,
>      Itamar
>
>>
>>            before I do it, I found the code govirt you worte, I felt
>> luckly, you
>>
>> had do that. So I got the code, but when I build it on ubuntu, it's failed
>>
>> I used autogen.sh , but got the error message
>>
>> like:
>>
>>            configure: error: Package requirements (rest-0.7 >= 0.7.13)
>> were not met:
>>
>> No package 'rest-0.7' found
>>
>>            Because I didn't familiar with autogen and configure, such gnu
>> build tools,
>>
>>
>>
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>
>
>



From wlbleaboy at 126.com  Wed Jun  5 07:06:24 2013
From: wlbleaboy at 126.com (wlbleaboy@126)
Date: Wed, 5 Jun 2013 15:06:24 +0800
Subject: [Engine-devel] about govirt
In-Reply-To: <51AEE177.2090902@redhat.com>
References: <002a01ce610d$863d8190$92b884b0$@com> <51AE5C2C.1070108@redhat.com>
	<007d01ce61b7$f4ffd740$deff85c0$@com> <51AEE177.2090902@redhat.com>
Message-ID: <007e01ce61bb$314ab000$93e01000$@com>

En, yes, and choice a better one.

-----Original Message-----
From: Itamar Heim [mailto:iheim at redhat.com] 
Sent: Wednesday, June 05, 2013 2:58 PM
To: wlbleaboy at 126
Cc: cfergeau at redhat.com; engine-devel at ovirt.org; 'Michael Pasternak'
Subject: Re: [Engine-devel] about govirt

On 06/05/2013 09:43 AM, wlbleaboy at 126 wrote:
> Hi, Itamar Heim:
> 	I used ovirit-engine-sdk-python to connect ovirt-engine and get vms
> It's about 20 seconds, so I felt it's slow.

and just to compare, how much time does a curl/wget takes you?

>
> 	I have build govirt success, but how can I use it, I give
> REST_URI="https://192.168.1.201/api",
> and proxy = ovirt_proxy_new(REST_URI) always return NULL;
>
> -----Original Message-----
> From: Itamar Heim [mailto:iheim at redhat.com]
> Sent: Wednesday, June 05, 2013 5:29 AM
> To: wlbleaboy at 126
> Cc: cfergeau at redhat.com; engine-devel at ovirt.org; Michael Pasternak
> Subject: Re: [Engine-devel] about govirt
>
> On 06/04/2013 01:23 PM, wlbleaboy at 126 wrote:
>> Hi, cfergeau:
>>
>>            Recently, I do something about ovirt-engine-sdk, I just want
to
>>
>> console a vm via sdk, but I found the sdk implemented by python is
>>
>> so slowly, so I want to build a simple sdk use C to do that,
>
> Can you please share more info on what do you mean by "slow"?
>
> Thanks,
>      Itamar
>
>>
>>            before I do it, I found the code govirt you worte, I felt
>> luckly, you
>>
>> had do that. So I got the code, but when I build it on ubuntu, it's
failed
>>
>> I used autogen.sh , but got the error message
>>
>> like:
>>
>>            configure: error: Package requirements (rest-0.7 >= 0.7.13)
>> were not met:
>>
>> No package 'rest-0.7' found
>>
>>            Because I didn't familiar with autogen and configure, such gnu
>> build tools,
>>
>>
>>
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>
>
>




From mpastern at redhat.com  Wed Jun  5 07:14:09 2013
From: mpastern at redhat.com (Michael Pasternak)
Date: Wed, 05 Jun 2013 10:14:09 +0300
Subject: [Engine-devel] about govirt
In-Reply-To: <007d01ce61b7$f4ffd740$deff85c0$@com>
References: <002a01ce610d$863d8190$92b884b0$@com> <51AE5C2C.1070108@redhat.com>
	<007d01ce61b7$f4ffd740$deff85c0$@com>
Message-ID: <51AEE541.9000005@redhat.com>

On 06/05/2013 09:43 AM, wlbleaboy at 126 wrote:
> Hi, Itamar Heim:
> 	I used ovirit-engine-sdk-python to connect ovirt-engine and get vms
> It's about 20 seconds, so I felt it's slow.

20 seconds? How much VMs did you fetched?, How do you measure the time?, can i see your code?

> 
> 	I have build govirt success, but how can I use it, I give
> REST_URI="https://192.168.1.201/api",
> and proxy = ovirt_proxy_new(REST_URI) always return NULL;
> 
> -----Original Message-----
> From: Itamar Heim [mailto:iheim at redhat.com] 
> Sent: Wednesday, June 05, 2013 5:29 AM
> To: wlbleaboy at 126
> Cc: cfergeau at redhat.com; engine-devel at ovirt.org; Michael Pasternak
> Subject: Re: [Engine-devel] about govirt
> 
> On 06/04/2013 01:23 PM, wlbleaboy at 126 wrote:
>> Hi, cfergeau:
>>
>>           Recently, I do something about ovirt-engine-sdk, I just want to
>>
>> console a vm via sdk, but I found the sdk implemented by python is
>>
>> so slowly, so I want to build a simple sdk use C to do that,
> 
> Can you please share more info on what do you mean by "slow"?
> 
> Thanks,
>     Itamar
> 
>>
>>           before I do it, I found the code govirt you worte, I felt
>> luckly, you
>>
>> had do that. So I got the code, but when I build it on ubuntu, it's failed
>>
>> I used autogen.sh , but got the error message
>>
>> like:
>>
>>           configure: error: Package requirements (rest-0.7 >= 0.7.13)
>> were not met:
>>
>> No package 'rest-0.7' found
>>
>>           Because I didn't familiar with autogen and configure, such gnu
>> build tools,
>>
>>
>>
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>
> 
> 


-- 

Michael Pasternak
RedHat, ENG-Virtualization R&D


From sabose at redhat.com  Wed Jun  5 07:21:06 2013
From: sabose at redhat.com (Sahina Bose)
Date: Wed, 05 Jun 2013 12:51:06 +0530
Subject: [Engine-devel] Failed to configure management network on the
 host
In-Reply-To: <51ADF78C.1010207@redhat.com>
References: <51ACAC13.9040000@redhat.com>
	<CAEWPe=r172RzXMtPx0=3M7bpFLts9T9c3NtRDQOnYn9QJ0_hdQ@mail.gmail.com>
	<51AD8058.8050901@redhat.com> <51AD87D9.6020608@redhat.com>
	<51AD8EB2.3060402@redhat.com> <51ADA20A.9080108@redhat.com>
	<51ADAD7A.50704@redhat.com> <51ADF78C.1010207@redhat.com>
Message-ID: <51AEE6E2.2080502@redhat.com>

Thanks! will check it out.
On 06/04/2013 07:49 PM, Moti Asayag wrote:
> Hi Sahina,
>
> I was able to reproduce it on my setup, it seems that when a host was
> already installed and the user re-installed it, it failed to check the
> host availability.
>
> I fixed the host polling by the engine by commit
> 5c03a936df3a09473f1a05b973680c02280d7a5c.
>
> You can either build from master or wait for the nightly build.
> Please let me know if there are more issues.
>
> Thanks,
> Moti
>
> On 06/04/2013 12:03 PM, Sahina Bose wrote:
>> Hi Moti,
>>
>> Had to reproduce this again to get the logs. Attached both engine and
>> vdsm logs.
>>
>> engine:
>> [org.ovirt.engine.core.vdsbroker.vdsbroker.CollectVdsNetworkDataVDSCommand]
>> (pool-4-thread-4) [59b99e5d] Command CollectVdsNetworkDataVDS execution
>> failed. Exception: VDSNetworkException: java.net.ConnectException:
>> Connection refused
>>
>> vdsm (based on flow id 59b99e5d) - no entries found.
>>
>> However there's a line (without any flowId) -
>> Thread-13::DEBUG::2013-06-04
>> 14:21:05,227::BindingXMLRPC::913::vds::(wrapper) client
>> [10.70.42.245]::call getCapabilities with () {}
>>
>> thanks
>> sahina
>>
>>
>> On 06/04/2013 01:45 PM, Moti Asayag wrote:
>>> On 06/04/2013 09:52 AM, Sahina Bose wrote:
>>>> Hi Moti,
>>>>
>>>> Not sure I understand your comment about host activation flow.
>>>> commit bdd8966d97e1e02e775ee6f755d0a3637a668911  (engine: Remove mgmt
>>>> network setup from host activation) is present in our code base, but we
>>>> were not using the host activation flow.
>>> Hi,
>>>
>>> My fault, i had a different old thread in my mind.
>>>
>>> The relevant part from the engine.log indicates that the host deployment
>>> ended successfully, host was able to ping VDSM, but the first attempt to
>>> run getVdsCaps on vdsm failed.
>>>
>>> Could you add the relevant vdsm.log which contains the flow-ID 740c5292
>>> which matches the same correlation-id from the engine.log ?
>>>
>>>
>>> 2013-06-03 20:06:49,638 INFO
>>> [org.ovirt.engine.core.bll.InstallerMessages] (VdsDeploy) Installation
>>> 10.70.43.140: Stage: Termination
>>> 2013-06-03 20:06:49,881 ERROR
>>> [org.ovirt.engine.core.vdsbroker.vdsbroker.PollVDSCommand]
>>> (pool-4-thread-48) [740c5292] java.util.concurrent.ExecutionException:
>>> java.lang.reflect.InvocationTargetException
>>> 2013-06-03 20:06:49,882 ERROR
>>> [org.ovirt.engine.core.vdsbroker.vdsbroker.PollVDSCommand]
>>> (pool-4-thread-48) [740c5292] Command PollVDS execution failed.
>>> Exception: RuntimeException: java.util.concurrent.ExecutionException:
>>> java.lang.reflect.InvocationTargetException
>>> 2013-06-03 20:06:50,382 INFO
>>> [org.ovirt.engine.core.bll.network.NetworkConfigurator]
>>> (pool-4-thread-48) [740c5292] Engine managed to communicate with VDSM
>>> agent on host s2
>>> 2013-06-03 20:06:50,393 ERROR
>>> [org.ovirt.engine.core.vdsbroker.vdsbroker.CollectVdsNetworkDataVDSCommand]
>>>
>>> (pool-4-thread-48) [740c5292] Command CollectVdsNetworkDataVDS execution
>>> failed. Exception: VDSNetworkException: java.net.ConnectException:
>>> Connection refused
>>>
>>> Thanks,
>>> Moti
>>>
>>>> Here's what we tried to do.
>>>> Add a host (with vdsm 4.10.2 installed) to engine (built from Jun 2
>>>> upstream codebase).
>>>>
>>>> The installation failed with "Failed to configure manamgent network on
>>>> the host"
>>>>
>>>> and the logs had this
>>>>
>>>> 2013-06-03 19:49:03,390 INFO
>>>> [org.ovirt.engine.core.bll.network.NetworkConfigurator]
>>>> (pool-4-thread-50) [7bf46c88] Engine managed to communicate with VDSM
>>>> agent on host s1
>>>> 2013-06-03 19:49:03,412 ERROR
>>>> [org.ovirt.engine.core.vdsbroker.vdsbroker.CollectVdsNetworkDataVDSCommand]
>>>>
>>>> (pool-4-thread-50) [7bf46c88] Command CollectVdsNetworkDataVDS execution
>>>> failed. Exception: VDSNetworkException: java.net.ConnectException:
>>>> Connection refused
>>>>
>>>> As Kanagaraj mentioned, reverting the Change Iaf82e104: engine:
>>>> Allow engine to configure management network , fixed this issue.
>>>>
>>>>   From the flowchart on
>>>> http://www.ovirt.org/Features/Normalized_ovirtmgmt_Initialization, it
>>>> seems to fail on the "Configure Management Network (by setup networks)"
>>>> action.
>>>>
>>>> Any help on solving this would be appreciated.
>>>>
>>>> thanks
>>>> sahina
>>>>
>>>>
>>>>
>>>> On 06/04/2013 11:53 AM, Moti Asayag wrote:
>>>>> Hi,
>>>>>
>>>>> Same host activation flow should work on the master as well as the
>>>>> management network will not be created as part of the host activation.
>>>>> So reverted changes were already merged by commit
>>>>> bdd8966d97e1e02e775ee6f755d0a3637a668911
>>>>>
>>>>> For more details about host installation see:
>>>>> http://www.ovirt.org/Features/Normalized_ovirtmgmt_Initialization
>>>>>
>>>>> Thanks,
>>>>> Moti
>>>>>
>>>>> See
>>>>> On 06/04/2013 08:51 AM, Kanagaraj wrote:
>>>>>> Host installation went through successfully after reverting the change
>>>>>> eca95e192ebf3e1fe0e9440bb8fac694214ca8fd (Change Iaf82e104: engine:
>>>>>> Allow engine to configure management network ).
>>>>>>
>>>>>> Thanks,
>>>>>> Kanagaraj
>>>>>>
>>>>>> On 06/04/2013 12:23 AM, Dead Horse wrote:
>>>>>>> Seeing this as well but during host activation with latest master
>>>>>>> vdsm/engine.
>>>>>>> -->
>>>>>>> http://lists.ovirt.org/pipermail/engine-devel/2013-June/004752.html
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Mon, Jun 3, 2013 at 9:45 AM, Kanagaraj <kmayilsa at redhat.com
>>>>>>> <mailto:kmayilsa at redhat.com>> wrote:
>>>>>>>
>>>>>>>        Hi,
>>>>>>>
>>>>>>>         After adding a host to a 3.2 cluster, bootstrap went
>>>>>>> through fine
>>>>>>>        and in the end it failed with the following error.
>>>>>>>
>>>>>>>        "Host s2 installation failed. Failed to configure manamgent
>>>>>>>        network on the host."
>>>>>>>
>>>>>>>        Attached engine.log and vdsm.log
>>>>>>>
>>>>>>>        Vdsm rpms:
>>>>>>>        vdsm-4.10.2-22.2.el6rhs.x86_64
>>>>>>>        vdsm-python-4.10.2-22.2.el6rhs.x86_64
>>>>>>>        vdsm-cli-4.10.2-22.2.el6rhs.noarch
>>>>>>>        vdsm-gluster-4.10.2-22.2.el6rhs.noarch
>>>>>>>        vdsm-xmlrpc-4.10.2-22.2.el6rhs.noarch
>>>>>>>
>>>>>>>        Engine rpms: recent code from master
>>>>>>>
>>>>>>>        Can someone please help in resolving this issue,
>>>>>>>
>>>>>>>        Thanks,
>>>>>>>        Kanagaraj
>>>>>>>
>>>>>>>        _______________________________________________
>>>>>>>        Engine-devel mailing list
>>>>>>>        Engine-devel at ovirt.org <mailto:Engine-devel at ovirt.org>
>>>>>>>        http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>>>>>
>>>>>>>
>>>>> _______________________________________________
>>>>> Engine-devel mailing list
>>>>> Engine-devel at ovirt.org
>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel



From dfediuck at redhat.com  Wed Jun  5 07:48:11 2013
From: dfediuck at redhat.com (Doron Fediuck)
Date: Wed, 5 Jun 2013 03:48:11 -0400 (EDT)
Subject: [Engine-devel] Network Quality of Service 3.3 - Feature design
In-Reply-To: <51ADAD2B.4070305@redhat.com>
References: <273375846.6100303.1370156285221.JavaMail.root@redhat.com>
	<51ADAD2B.4070305@redhat.com>
Message-ID: <1011983824.18936772.1370418491831.JavaMail.root@redhat.com>

----- Original Message -----
> From: "Livnat Peer" <lpeer at redhat.com>
> To: "Ofri Masad" <omasad at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>
> Sent: Tuesday, June 4, 2013 12:02:35 PM
> Subject: Re: [Engine-devel] Network Quality of Service 3.3 - Feature design
> 
> On 06/02/2013 09:58 AM, Ofri Masad wrote:
> > Hi all,
> > 
> > A new Feature page for "Network Quality of Service" feature was published.
> > 
> > http://www.ovirt.org/Features/Design/Network_QoS
> > 
> > You are more than welcome to share you thoughts and insights.
> > 
> 
> 
> Hi Ofri,
> 
> Here is another suggestion for you to consider, this suggestion is
> realted only to QoS on the VNIC level -
> 
> Introducing a new entity - VNIC Profile.
> The VNIC profile would include all the properties of a VNIC:
>  - network,
>  - Qos,
>  - Port mirroring,
>  - custom properties
> 
> From now on a user would choose a VNIC profile when he defines a VNIC
> (instead of choosing a network and defining properties directly on the VNIC)
> 
> A network could have multiple profiles defined on it.
> 
> A User would need permissions to use a profile instead of the current
> state that we require permission to use a network.
> 
> The benefits of this approach :
> 
> 1. Limiting the user to a specific QoS on a network is easy you give the
> user permission to use a specific profile.
> 
> 2. A user can add a new VNIC but he would be limited to QoS defined on
> the profile he is able to use (which eliminates the problem that a user
> can add a VNIC to it's VM but won't get any bandwidth limitations).
> 
> 3. An administrator does not add VNIC QoS properties on the network
> entity (to serve as defaults) which are not relevant for non-VM network.
> 
> 4. The network admin who creates the VNIC profile is also the one who
> can configure the QoS to that Network.
> 
> 5. The separation between user portal and admin portal is very clear, in
> user portal we expose only the profile name and in the admin portal a
> user can view the profile details.
> 
> 6. We would leave custom properties also on the VNIC level not only the
> profile level so a user can send VM specific data.
> 
> 7.I can also describe upgrade path but maybe we should discuss the
> general concept before diving into the details.
> 

Hi Livnat,
This design creates a new feature of network profile, which has QoS
included in it, so it's bigger the the original intention. Having that
said, I agree with the concept as we need to take a more holistic
approach which considers other areas of the system, such as SLA policies
and instance types.

So in this view I'll just add that going forward the QoS element of the
profile will be a reference to a policy entity which will include network
QoS as well as other QoS elements.

At this point we're going back to the drawing board to update the design
and will publish an update asap.

Doron

> 
> Livnat
> 
> 
> 
> > Thanks,
> > Ofri.


From wlbleaboy at 126.com  Wed Jun  5 07:51:24 2013
From: wlbleaboy at 126.com (wlbleaboy@126)
Date: Wed, 5 Jun 2013 15:51:24 +0800
Subject: [Engine-devel] about govirt
In-Reply-To: <51AEE541.9000005@redhat.com>
References: <002a01ce610d$863d8190$92b884b0$@com> <51AE5C2C.1070108@redhat.com>
	<007d01ce61b7$f4ffd740$deff85c0$@com> <51AEE541.9000005@redhat.com>
Message-ID: <007f01ce61c1$7af5baf0$70e130d0$@com>

I build a local sdk base on ovirt-engine-sdk-python, I do that like this:

First, I created a python file naked wrap.py, in wrap.py I have 
a class naked CWrap , CWrap have some interface for get vm's information
and connect to ovirt-enginelike:
login(), getVmName(), getVmId(), getVmPort(), getVmTicket() etc.

second, I created a C file named engine-sdk.c, in this file I also implement

some interface like getVmName() etc. but in this file, all the function is 
call python module like 
		PyObject *pyVmId;
        char *vmId;

        pyVmId = PyObject_CallMethod(pInstant, "getVmId", "(i)", vmIndex);

        if(pyVmId == NULL)
        {
            DBG("ERROR:Call py Method getVmDisplayType is failed!\n");
            return NULL;
        }

        vmId = PyString_AsString(pyVmId);

so, the local sdk is used for a client(C/S ) implemented by gtk.

Every time, when I use my client login and get vms's information, it's about
10~20 seconds.

-----Original Message-----
From: Michael Pasternak [mailto:mpastern at redhat.com] 
Sent: Wednesday, June 05, 2013 3:14 PM
To: wlbleaboy at 126
Cc: 'Itamar Heim'; cfergeau at redhat.com; engine-devel at ovirt.org
Subject: Re: [Engine-devel] about govirt

On 06/05/2013 09:43 AM, wlbleaboy at 126 wrote:
> Hi, Itamar Heim:
> 	I used ovirit-engine-sdk-python to connect ovirt-engine and get vms
> It's about 20 seconds, so I felt it's slow.

20 seconds? How much VMs did you fetched?, How do you measure the time?, can
i see your code?

> 
> 	I have build govirt success, but how can I use it, I give
> REST_URI="https://192.168.1.201/api",
> and proxy = ovirt_proxy_new(REST_URI) always return NULL;
> 
> -----Original Message-----
> From: Itamar Heim [mailto:iheim at redhat.com] 
> Sent: Wednesday, June 05, 2013 5:29 AM
> To: wlbleaboy at 126
> Cc: cfergeau at redhat.com; engine-devel at ovirt.org; Michael Pasternak
> Subject: Re: [Engine-devel] about govirt
> 
> On 06/04/2013 01:23 PM, wlbleaboy at 126 wrote:
>> Hi, cfergeau:
>>
>>           Recently, I do something about ovirt-engine-sdk, I just want to
>>
>> console a vm via sdk, but I found the sdk implemented by python is
>>
>> so slowly, so I want to build a simple sdk use C to do that,
> 
> Can you please share more info on what do you mean by "slow"?
> 
> Thanks,
>     Itamar
> 
>>
>>           before I do it, I found the code govirt you worte, I felt
>> luckly, you
>>
>> had do that. So I got the code, but when I build it on ubuntu, it's
failed
>>
>> I used autogen.sh , but got the error message
>>
>> like:
>>
>>           configure: error: Package requirements (rest-0.7 >= 0.7.13)
>> were not met:
>>
>> No package 'rest-0.7' found
>>
>>           Because I didn't familiar with autogen and configure, such gnu
>> build tools,
>>
>>
>>
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>
> 
> 


-- 

Michael Pasternak
RedHat, ENG-Virtualization R&D




From bigclouds at 163.com  Wed Jun  5 09:34:30 2013
From: bigclouds at 163.com (bigclouds)
Date: Wed, 5 Jun 2013 17:34:30 +0800 (CST)
Subject: [Engine-devel] if there is a updated debug environment how to?
Message-ID: <1f1cccaa.c254.13f13b00539.Coremail.bigclouds@163.com>

hi, engine guys:
i want to make a engine debug environment for a looong time, due to all kinds of reasons i have not made it.
now i still have the need for a debug environment. (it seems like that i am keeped away from you all)
if  there is a updated doc  for building engine debug environment?
 
thanks so much.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130605/5b9f681c/attachment.html>

From mpastern at redhat.com  Wed Jun  5 11:49:58 2013
From: mpastern at redhat.com (Michael Pasternak)
Date: Wed, 05 Jun 2013 14:49:58 +0300
Subject: [Engine-devel] about govirt
In-Reply-To: <007f01ce61c1$7af5baf0$70e130d0$@com>
References: <002a01ce610d$863d8190$92b884b0$@com> <51AE5C2C.1070108@redhat.com>
	<007d01ce61b7$f4ffd740$deff85c0$@com> <51AEE541.9000005@redhat.com>
	<007f01ce61c1$7af5baf0$70e130d0$@com>
Message-ID: <51AF25E6.2010809@redhat.com>

On 06/05/2013 10:51 AM, wlbleaboy at 126 wrote:
> I build a local sdk base on ovirt-engine-sdk-python, I do that like this:
> 
> First, I created a python file naked wrap.py, in wrap.py I have 
> a class naked CWrap , CWrap have some interface for get vm's information
> and connect to ovirt-enginelike:
> login(), getVmName(), getVmId(), getVmPort(), getVmTicket() etc.
> 
> second, I created a C file named engine-sdk.c, in this file I also implement
> 
> some interface like getVmName() etc. but in this file, all the function is 
> call python module like 
> 		PyObject *pyVmId;
>         char *vmId;
> 
>         pyVmId = PyObject_CallMethod(pInstant, "getVmId", "(i)", vmIndex);
> 
>         if(pyVmId == NULL)
>         {
>             DBG("ERROR:Call py Method getVmDisplayType is failed!\n");
>             return NULL;
>         }
> 
>         vmId = PyString_AsString(pyVmId);
> 
> so, the local sdk is used for a client(C/S ) implemented by gtk.
> 
> Every time, when I use my client login and get vms's information, it's about
> 10~20 seconds.

i'm confused, are you mixing python with c? so what is CWrap/wrap.py from python?
can you post theirs code?

> 
> -----Original Message-----
> From: Michael Pasternak [mailto:mpastern at redhat.com] 
> Sent: Wednesday, June 05, 2013 3:14 PM
> To: wlbleaboy at 126
> Cc: 'Itamar Heim'; cfergeau at redhat.com; engine-devel at ovirt.org
> Subject: Re: [Engine-devel] about govirt
> 
> On 06/05/2013 09:43 AM, wlbleaboy at 126 wrote:
>> Hi, Itamar Heim:
>> 	I used ovirit-engine-sdk-python to connect ovirt-engine and get vms
>> It's about 20 seconds, so I felt it's slow.
> 
> 20 seconds? How much VMs did you fetched?, How do you measure the time?, can
> i see your code?
> 
>>
>> 	I have build govirt success, but how can I use it, I give
>> REST_URI="https://192.168.1.201/api",
>> and proxy = ovirt_proxy_new(REST_URI) always return NULL;
>>
>> -----Original Message-----
>> From: Itamar Heim [mailto:iheim at redhat.com] 
>> Sent: Wednesday, June 05, 2013 5:29 AM
>> To: wlbleaboy at 126
>> Cc: cfergeau at redhat.com; engine-devel at ovirt.org; Michael Pasternak
>> Subject: Re: [Engine-devel] about govirt
>>
>> On 06/04/2013 01:23 PM, wlbleaboy at 126 wrote:
>>> Hi, cfergeau:
>>>
>>>           Recently, I do something about ovirt-engine-sdk, I just want to
>>>
>>> console a vm via sdk, but I found the sdk implemented by python is
>>>
>>> so slowly, so I want to build a simple sdk use C to do that,
>>
>> Can you please share more info on what do you mean by "slow"?
>>
>> Thanks,
>>     Itamar
>>
>>>
>>>           before I do it, I found the code govirt you worte, I felt
>>> luckly, you
>>>
>>> had do that. So I got the code, but when I build it on ubuntu, it's
> failed
>>>
>>> I used autogen.sh , but got the error message
>>>
>>> like:
>>>
>>>           configure: error: Package requirements (rest-0.7 >= 0.7.13)
>>> were not met:
>>>
>>> No package 'rest-0.7' found
>>>
>>>           Because I didn't familiar with autogen and configure, such gnu
>>> build tools,
>>>
>>>
>>>
>>> _______________________________________________
>>> Engine-devel mailing list
>>> Engine-devel at ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>
>>
>>
> 
> 


-- 

Michael Pasternak
RedHat, ENG-Virtualization R&D


From emesika at redhat.com  Wed Jun  5 20:55:36 2013
From: emesika at redhat.com (Eli Mesika)
Date: Wed, 5 Jun 2013 16:55:36 -0400 (EDT)
Subject: [Engine-devel] Performance and scalability
In-Reply-To: <1010286731.11698764.1370356045751.JavaMail.root@redhat.com>
References: <1247864565.11509776.1370346235729.JavaMail.root@redhat.com>
	<1183814794.11684244.1370354496985.JavaMail.root@redhat.com>
	<1010286731.11698764.1370356045751.JavaMail.root@redhat.com>
Message-ID: <2115175878.12471461.1370465736600.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Liran Zelkha" <lzelkha at redhat.com>
> To: "Laszlo Hornyak" <lhornyak at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>
> Sent: Tuesday, June 4, 2013 5:27:25 PM
> Subject: Re: [Engine-devel] Performance and scalability
> 
> Hi Laszlo
> 
> I 100% agree with both of your remarks.
> Caching is caching the entities, but also attempting to cache the list of
> entities.
> Batch updates is done as an infrastructure (change was reviewed and now in
> fixes) and after that - we can start using it everywhere.
> 
> ----- Original Message -----
> From: "Laszlo Hornyak" <lhornyak at redhat.com>
> To: "Liran Zelkha" <lzelkha at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>
> Sent: Tuesday, June 4, 2013 5:01:37 PM
> Subject: Re: [Engine-devel] Performance and scalability
> 
> Hi Liran,
> 
> Some comments to start the discussion:
> - Caching: exactly how is this resultset caching going to work? Wouldnt it be
> more simple to just cache the mapped entities? The mapping is not a big
> overhead, but caching the resultset seems to be difficult.
> - Batch updates: sounds cool, transactions are a major overhead on
> performance, so if you can make the update in a single tx and few
> interactions that will rock, but what if we keep the dynamic and statistic
> data in the memory at the first place and synchronize to DB on a background
> process. So that when you look for dynamic/statistics data, you do not have
> to hit the DB.
> 
> Thx,
> Laszlo
> 
> ----- Original Message -----
> > From: "Liran Zelkha" <lzelkha at redhat.com>
> > To: "engine-devel" <engine-devel at ovirt.org>
> > Sent: Tuesday, June 4, 2013 1:43:55 PM
> > Subject: [Engine-devel] Performance and scalability
> > 
> > Hi all,
> > 
> > I've added a new feature page for Performance and Scalability. Please
> > review
> > and add your ideas...
> > http://www.ovirt.org/Features/Performance_And_Scalability

Hi Liran

two comments 

1) fn_splitter has few variations (for uuid etc , so all should be handled)
2) Requirements / recommendations on the search engine queries

Thanks
Eli 


> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From emesika at redhat.com  Wed Jun  5 21:17:07 2013
From: emesika at redhat.com (Eli Mesika)
Date: Wed, 5 Jun 2013 17:17:07 -0400 (EDT)
Subject: [Engine-devel] if there is a updated debug environment how to?
In-Reply-To: <1f1cccaa.c254.13f13b00539.Coremail.bigclouds@163.com>
References: <1f1cccaa.c254.13f13b00539.Coremail.bigclouds@163.com>
Message-ID: <873179003.12476209.1370467027165.JavaMail.root@redhat.com>



----- Original Message -----
> From: "bigclouds" <bigclouds at 163.com>
> To: "engine-devel" <engine-devel at ovirt.org>
> Sent: Wednesday, June 5, 2013 12:34:30 PM
> Subject: [Engine-devel] if there is a updated debug environment how to?
> 
> hi, engine guys:
> i want to make a engine debug environment for a looong time, due to all kinds
> of reasons i have not made it.
> now i still have the need for a debug environment. (it seems like that i am
> keeped away from you all)
> if there is a updated doc for building engine debug environment?
> thanks so much.
> 

Please follow Allon's B L doc on how to create a development environment 

http://www.ovirt.org/OVirt_Engine_Development_Environment


> 
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From rgolan at redhat.com  Thu Jun  6 05:17:54 2013
From: rgolan at redhat.com (Roy Golan)
Date: Thu, 06 Jun 2013 08:17:54 +0300
Subject: [Engine-devel] cluster emulation mode feature
Message-ID: <51B01B82.6070900@redhat.com>

Hi,

A new wiki has been published on Cluster Emulation mode 
http://www.ovirt.org/Cluster_emulation_modes

Please review.

Thanks,
Roy


From ofrenkel at redhat.com  Thu Jun  6 07:20:30 2013
From: ofrenkel at redhat.com (Omer Frenkel)
Date: Thu, 6 Jun 2013 03:20:30 -0400 (EDT)
Subject: [Engine-devel] cluster emulation mode feature
In-Reply-To: <51B01B82.6070900@redhat.com>
References: <51B01B82.6070900@redhat.com>
Message-ID: <1540604675.19703375.1370503230945.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Roy Golan" <rgolan at redhat.com>
> To: engine-devel at ovirt.org
> Sent: Thursday, June 6, 2013 8:17:54 AM
> Subject: [Engine-devel] cluster emulation mode feature
> 
> Hi,
> 
> A new wiki has been published on Cluster Emulation mode
> http://www.ovirt.org/Cluster_emulation_modes
> 
> Please review.
> 
> Thanks,
> Roy
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 

maybe better to name host field as supported_emulated_machines - since it holds the list of supported as reported from vdsm.

the following is a copy from the wiki
"
consider this pseudo-code:

operational = false 
if cluster.emulationMode == NULL
 for configVal in Config.ClusterEmulationMode(3.3)
    if configVal in host.emulationModes 
        cluster.emulationMode = configVal
        operational = true
 else if clusterEmulationMode in host.emulationMode
       operational = true
if (!operational)
    set host non operationl, reason = UNSUPPORTED_EMULATION_MODE
"

first, i guess where you write '3.3' its actually should be 'cluster.compatibility'
another thing, the configuration will probably have more than 1 option for emulated machine,
for example 3.3 rhel could have {(for EL-)RHEL6.4.0,RHEL6.3.0,..,(for other-)pc-1.3,pc-1.2..}
we need to make sure the list is used ordered so that the greatest value will be first,
since if host supports many, the latest will be used.
in cpu-flags there is a specific number to do this order, maybe same approach can be taken here,
as i'm not sure the RHEL/pc values are consistent (on my f18 i also have 'pc-i440fx-1.4')


From rgolan at redhat.com  Thu Jun  6 09:33:26 2013
From: rgolan at redhat.com (Roy Golan)
Date: Thu, 06 Jun 2013 12:33:26 +0300
Subject: [Engine-devel] cluster emulation mode feature
In-Reply-To: <1540604675.19703375.1370503230945.JavaMail.root@redhat.com>
References: <51B01B82.6070900@redhat.com>
	<1540604675.19703375.1370503230945.JavaMail.root@redhat.com>
Message-ID: <51B05766.6010105@redhat.com>

On Thu 06 Jun 2013 10:20:30 AM IDT, Omer Frenkel wrote:
>
>
> ----- Original Message -----
>> From: "Roy Golan" <rgolan at redhat.com>
>> To: engine-devel at ovirt.org
>> Sent: Thursday, June 6, 2013 8:17:54 AM
>> Subject: [Engine-devel] cluster emulation mode feature
>>
>> Hi,
>>
>> A new wiki has been published on Cluster Emulation mode
>> http://www.ovirt.org/Cluster_emulation_modes
>>
>> Please review.
>>
>> Thanks,
>> Roy
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>
>
> maybe better to name host field as supported_emulated_machines - since it holds the list of supported as reported from vdsm.
>
will change if this seems clearer
> the following is a copy from the wiki
> "
> consider this pseudo-code:
>
> operational = false
> if cluster.emulationMode == NULL
>   for configVal in Config.ClusterEmulationMode(3.3)
>      if configVal in host.emulationModes
>          cluster.emulationMode = configVal
>          operational = true
>   else if clusterEmulationMode in host.emulationMode
>         operational = true
> if (!operational)
>      set host non operationl, reason = UNSUPPORTED_EMULATION_MODE
> "
>
> first, i guess where you write '3.3' its actually should be 'cluster.compatibility'
yes its just a visual notion of the version
> another thing, the configuration will probably have more than 1 option for emulated machine,
> for example 3.3 rhel could have {(for EL-)RHEL6.4.0,RHEL6.3.0,..,(for other-)pc-1.3,pc-1.2..}
> we need to make sure the list is used ordered so that the greatest value will be first,
> since if host supports many, the latest will be used.
> in cpu-flags there is a specific number to do this order, maybe same approach can be taken here,
> as i'm not sure the RHEL/pc values are consistent (on my f18 i also have 'pc-i440fx-1.4')
isn't the order of the list enough?




From ofrenkel at redhat.com  Thu Jun  6 12:09:59 2013
From: ofrenkel at redhat.com (Omer Frenkel)
Date: Thu, 6 Jun 2013 08:09:59 -0400 (EDT)
Subject: [Engine-devel] cluster emulation mode feature
In-Reply-To: <51B05766.6010105@redhat.com>
References: <51B01B82.6070900@redhat.com>
	<1540604675.19703375.1370503230945.JavaMail.root@redhat.com>
	<51B05766.6010105@redhat.com>
Message-ID: <2128925884.19839284.1370520599796.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Roy Golan" <rgolan at redhat.com>
> To: "Omer Frenkel" <ofrenkel at redhat.com>
> Cc: engine-devel at ovirt.org
> Sent: Thursday, June 6, 2013 12:33:26 PM
> Subject: Re: [Engine-devel] cluster emulation mode feature
> 
> On Thu 06 Jun 2013 10:20:30 AM IDT, Omer Frenkel wrote:
> >
> >
> > ----- Original Message -----
> >> From: "Roy Golan" <rgolan at redhat.com>
> >> To: engine-devel at ovirt.org
> >> Sent: Thursday, June 6, 2013 8:17:54 AM
> >> Subject: [Engine-devel] cluster emulation mode feature
> >>
> >> Hi,
> >>
> >> A new wiki has been published on Cluster Emulation mode
> >> http://www.ovirt.org/Cluster_emulation_modes
> >>
> >> Please review.
> >>
> >> Thanks,
> >> Roy
> >> _______________________________________________
> >> Engine-devel mailing list
> >> Engine-devel at ovirt.org
> >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> >>
> >
> > maybe better to name host field as supported_emulated_machines - since it
> > holds the list of supported as reported from vdsm.
> >
> will change if this seems clearer

seems clearer to me.

> > the following is a copy from the wiki
> > "
> > consider this pseudo-code:
> >
> > operational = false
> > if cluster.emulationMode == NULL
> >   for configVal in Config.ClusterEmulationMode(3.3)
> >      if configVal in host.emulationModes
> >          cluster.emulationMode = configVal
> >          operational = true
> >   else if clusterEmulationMode in host.emulationMode
> >         operational = true
> > if (!operational)
> >      set host non operationl, reason = UNSUPPORTED_EMULATION_MODE
> > "
> >
> > first, i guess where you write '3.3' its actually should be
> > 'cluster.compatibility'
> yes its just a visual notion of the version
> > another thing, the configuration will probably have more than 1 option for
> > emulated machine,
> > for example 3.3 rhel could have {(for EL-)RHEL6.4.0,RHEL6.3.0,..,(for
> > other-)pc-1.3,pc-1.2..}
> > we need to make sure the list is used ordered so that the greatest value
> > will be first,
> > since if host supports many, the latest will be used.
> > in cpu-flags there is a specific number to do this order, maybe same
> > approach can be taken here,
> > as i'm not sure the RHEL/pc values are consistent (on my f18 i also have
> > 'pc-i440fx-1.4')
> isn't the order of the list enough?
> 

basically yes, it means we assume users who will change it will be aware the order matters.
im ok with that because i assume not many changes will be done here (as this just the defaults)


From rgolan at redhat.com  Thu Jun  6 12:14:09 2013
From: rgolan at redhat.com (Roy Golan)
Date: Thu, 06 Jun 2013 15:14:09 +0300
Subject: [Engine-devel] cluster emulation mode feature
In-Reply-To: <2128925884.19839284.1370520599796.JavaMail.root@redhat.com>
References: <51B01B82.6070900@redhat.com>
	<1540604675.19703375.1370503230945.JavaMail.root@redhat.com>
	<51B05766.6010105@redhat.com>
	<2128925884.19839284.1370520599796.JavaMail.root@redhat.com>
Message-ID: <51B07D11.8090806@redhat.com>

On Thu 06 Jun 2013 03:09:59 PM IDT, Omer Frenkel wrote:
>
>
> ----- Original Message -----
>> From: "Roy Golan" <rgolan at redhat.com>
>> To: "Omer Frenkel" <ofrenkel at redhat.com>
>> Cc: engine-devel at ovirt.org
>> Sent: Thursday, June 6, 2013 12:33:26 PM
>> Subject: Re: [Engine-devel] cluster emulation mode feature
>>
>> On Thu 06 Jun 2013 10:20:30 AM IDT, Omer Frenkel wrote:
>>>
>>>
>>> ----- Original Message -----
>>>> From: "Roy Golan" <rgolan at redhat.com>
>>>> To: engine-devel at ovirt.org
>>>> Sent: Thursday, June 6, 2013 8:17:54 AM
>>>> Subject: [Engine-devel] cluster emulation mode feature
>>>>
>>>> Hi,
>>>>
>>>> A new wiki has been published on Cluster Emulation mode
>>>> http://www.ovirt.org/Cluster_emulation_modes
>>>>
>>>> Please review.
>>>>
>>>> Thanks,
>>>> Roy
>>>> _______________________________________________
>>>> Engine-devel mailing list
>>>> Engine-devel at ovirt.org
>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>>
>>>
>>> maybe better to name host field as supported_emulated_machines - since it
>>> holds the list of supported as reported from vdsm.
>>>
>> will change if this seems clearer
>
> seems clearer to me.
>

wiki updated

>>> the following is a copy from the wiki
>>> "
>>> consider this pseudo-code:
>>>
>>> operational = false
>>> if cluster.emulationMode == NULL
>>>    for configVal in Config.ClusterEmulationMode(3.3)
>>>       if configVal in host.emulationModes
>>>           cluster.emulationMode = configVal
>>>           operational = true
>>>    else if clusterEmulationMode in host.emulationMode
>>>          operational = true
>>> if (!operational)
>>>       set host non operationl, reason = UNSUPPORTED_EMULATION_MODE
>>> "
>>>
>>> first, i guess where you write '3.3' its actually should be
>>> 'cluster.compatibility'
>> yes its just a visual notion of the version
>>> another thing, the configuration will probably have more than 1 option for
>>> emulated machine,
>>> for example 3.3 rhel could have {(for EL-)RHEL6.4.0,RHEL6.3.0,..,(for
>>> other-)pc-1.3,pc-1.2..}
>>> we need to make sure the list is used ordered so that the greatest value
>>> will be first,
>>> since if host supports many, the latest will be used.
>>> in cpu-flags there is a specific number to do this order, maybe same
>>> approach can be taken here,
>>> as i'm not sure the RHEL/pc values are consistent (on my f18 i also have
>>> 'pc-i440fx-1.4')
>> isn't the order of the list enough?
>>
>
> basically yes, it means we assume users who will change it will be aware the order matters.
> im ok with that because i assume not many changes will be done here (as this just the defaults)

great I like it simple here.


From bigclouds at 163.com  Fri Jun  7 00:49:15 2013
From: bigclouds at 163.com (bigclouds)
Date: Fri, 7 Jun 2013 08:49:15 +0800 (CST)
Subject: [Engine-devel] if there is a updated debug environment how to?
In-Reply-To: <873179003.12476209.1370467027165.JavaMail.root@redhat.com>
References: <1f1cccaa.c254.13f13b00539.Coremail.bigclouds@163.com>
	<873179003.12476209.1370467027165.JavaMail.root@redhat.com>
Message-ID: <6d2213fa.13e5.13f1c1bdb62.Coremail.bigclouds@163.com>

hi:
there is error when engine-setup-2. finally only 8702 and 8703 port is in listen state.
i can not visit 8080 via browser.
engine-setup-2?
[ INFO  ] Creating CA
[ INFO  ] Creating database schema
[ ERROR ] Failed to execute stage 'Misc configuration': Command '/home/best/ovirt-engine/share/ovirt-engine/dbscripts/create_schema.sh' failed to execute
[ INFO  ] Stage: Clean up
          Log file is located at /tmp/ovirt-engine-setup-20130606172206.log






At 2013-06-06 05:17:07,"Eli Mesika" <emesika at redhat.com> wrote:
>
>
>----- Original Message -----
>> From: "bigclouds" <bigclouds at 163.com>
>> To: "engine-devel" <engine-devel at ovirt.org>
>> Sent: Wednesday, June 5, 2013 12:34:30 PM
>> Subject: [Engine-devel] if there is a updated debug environment how to?
>> 
>> hi, engine guys:
>> i want to make a engine debug environment for a looong time, due to all kinds
>> of reasons i have not made it.
>> now i still have the need for a debug environment. (it seems like that i am
>> keeped away from you all)
>> if there is a updated doc for building engine debug environment?
>> thanks so much.
>> 
>
>Please follow Allon's B L doc on how to create a development environment 
>
>http://www.ovirt.org/OVirt_Engine_Development_Environment
>
>
>> 
>> 
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130607/19e71bf6/attachment.html>

From alonbl at redhat.com  Fri Jun  7 06:55:41 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Fri, 7 Jun 2013 02:55:41 -0400 (EDT)
Subject: [Engine-devel] if there is a updated debug environment how to?
In-Reply-To: <6d2213fa.13e5.13f1c1bdb62.Coremail.bigclouds@163.com>
References: <1f1cccaa.c254.13f13b00539.Coremail.bigclouds@163.com>
	<873179003.12476209.1370467027165.JavaMail.root@redhat.com>
	<6d2213fa.13e5.13f1c1bdb62.Coremail.bigclouds@163.com>
Message-ID: <1765947130.7563104.1370588141651.JavaMail.root@redhat.com>



----- Original Message -----
> From: "bigclouds" <bigclouds at 163.com>
> To: "Eli Mesika" <emesika at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>
> Sent: Friday, June 7, 2013 3:49:15 AM
> Subject: Re: [Engine-devel] if there is a updated debug environment how to?
> 
> hi:
> there is error when engine-setup-2. finally only 8702 and 8703 port is in
> listen state.
> i can not visit 8080 via browser.

Well, if setup fails... probably application won't work.

> engine-setup-2 ?
> [ INFO  ] Creating CA
> [ INFO  ] Creating database schema
> [ ERROR ] Failed to execute stage 'Misc configuration': Command
> '/home/best/ovirt-engine/share/ovirt-engine/dbscripts/create_schema.sh'
> failed to execute
> [ INFO  ] Stage: Clean up
> Log file is located at /tmp/ovirt-engine-setup-20130606172206.log

What database have you  used?
If you don't have anything important there, can you please try to initialize it so you start fresh?

# systemctl stop postgresql.service
# rm -fr /var/lib/pgsql
# postgresql-setup initdb
# vi /var/lib/pgsql/data/pg_hba.conf
modify 127.0.0.1/32 and ::1/128 lines to password at last field
# su - postgres -c psql -d template1
template1=# create user engine password 'engine';
template1=# create database engine owner engine;
# \q

> 
> 
> 
> 
> At?2013-06-06?05:17:07,"Eli?Mesika"?<emesika at redhat.com>?wrote:
> >
> >
> >-----?Original?Message?-----
> >>?From:?"bigclouds"?<bigclouds at 163.com>
> >>?To:?"engine-devel"?<engine-devel at ovirt.org>
> >>?Sent:?Wednesday,?June?5,?2013?12:34:30?PM
> >>?Subject:?[Engine-devel]?if?there?is?a?updated?debug?environment?how?to?
> >>?
> >>?hi,?engine?guys:
> >>?i?want?to?make?a?engine?debug?environment?for?a?looong?time,?due?to?all
> >>??kinds
> >>?of?reasons?i?have?not?made?it.
> >>?now?i?still?have?the?need?for?a?debug?environment.?(it?seems?like?that?i
> >>??am
> >>?keeped?away?from?you?all)
> >>?if?there?is?a?updated?doc?for?building?engine?debug?environment?
> >>?thanks?so?much.
> >>?
> >
> >Please?follow?Allon's?B?L?doc?on?how?to?create?a?development?environment
> >
> >http://www.ovirt.org/OVirt_Engine_Development_Environment
> >
> >
> >>?
> >>?
> >>?_______________________________________________
> >>?Engine-devel?mailing?list
> >>?Engine-devel at ovirt.org
> >>?http://lists.ovirt.org/mailman/listinfo/engine-devel
> >> 
> 
> 
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From alonbl at redhat.com  Fri Jun  7 07:03:39 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Fri, 7 Jun 2013 03:03:39 -0400 (EDT)
Subject: [Engine-devel] if there is a updated debug environment how to?
In-Reply-To: <1765947130.7563104.1370588141651.JavaMail.root@redhat.com>
References: <1f1cccaa.c254.13f13b00539.Coremail.bigclouds@163.com>
	<873179003.12476209.1370467027165.JavaMail.root@redhat.com>
	<6d2213fa.13e5.13f1c1bdb62.Coremail.bigclouds@163.com>
	<1765947130.7563104.1370588141651.JavaMail.root@redhat.com>
Message-ID: <1159734065.7563886.1370588619060.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Alon Bar-Lev" <alonbl at redhat.com>
> To: "bigclouds" <bigclouds at 163.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>
> Sent: Friday, June 7, 2013 9:55:41 AM
> Subject: Re: [Engine-devel] if there is a updated debug environment how to?
> 
> 
> 
> ----- Original Message -----
> > From: "bigclouds" <bigclouds at 163.com>
> > To: "Eli Mesika" <emesika at redhat.com>
> > Cc: "engine-devel" <engine-devel at ovirt.org>
> > Sent: Friday, June 7, 2013 3:49:15 AM
> > Subject: Re: [Engine-devel] if there is a updated debug environment how to?
> > 
> > hi:
> > there is error when engine-setup-2. finally only 8702 and 8703 port is in
> > listen state.
> > i can not visit 8080 via browser.
> 
> Well, if setup fails... probably application won't work.
> 
> > engine-setup-2 ?
> > [ INFO  ] Creating CA
> > [ INFO  ] Creating database schema
> > [ ERROR ] Failed to execute stage 'Misc configuration': Command
> > '/home/best/ovirt-engine/share/ovirt-engine/dbscripts/create_schema.sh'
> > failed to execute
> > [ INFO  ] Stage: Clean up
> > Log file is located at /tmp/ovirt-engine-setup-20130606172206.log
> 
> What database have you  used?
> If you don't have anything important there, can you please try to initialize
> it so you start fresh?
> 
> # systemctl stop postgresql.service
> # rm -fr /var/lib/pgsql
> # postgresql-setup initdb
> # vi /var/lib/pgsql/data/pg_hba.conf
> modify 127.0.0.1/32 and ::1/128 lines to password at last field
# systemctl start postgresql.service
> # su - postgres -c psql -d template1
> template1=# create user engine password 'engine';
> template1=# create database engine owner engine;
> # \q
> 
> > 
> > 
> > 
> > 
> > At?2013-06-06?05:17:07,"Eli?Mesika"?<emesika at redhat.com>?wrote:
> > >
> > >
> > >-----?Original?Message?-----
> > >>?From:?"bigclouds"?<bigclouds at 163.com>
> > >>?To:?"engine-devel"?<engine-devel at ovirt.org>
> > >>?Sent:?Wednesday,?June?5,?2013?12:34:30?PM
> > >>?Subject:?[Engine-devel]?if?there?is?a?updated?debug?environment?how?to?
> > >>?
> > >>?hi,?engine?guys:
> > >>?i?want?to?make?a?engine?debug?environment?for?a?looong?time,?due?to?all
> > >>??kinds
> > >>?of?reasons?i?have?not?made?it.
> > >>?now?i?still?have?the?need?for?a?debug?environment.?(it?seems?like?that?i
> > >>??am
> > >>?keeped?away?from?you?all)
> > >>?if?there?is?a?updated?doc?for?building?engine?debug?environment?
> > >>?thanks?so?much.
> > >>?
> > >
> > >Please?follow?Allon's?B?L?doc?on?how?to?create?a?development?environment
> > >
> > >http://www.ovirt.org/OVirt_Engine_Development_Environment
> > >
> > >
> > >>?
> > >>?
> > >>?_______________________________________________
> > >>?Engine-devel?mailing?list
> > >>?Engine-devel at ovirt.org
> > >>?http://lists.ovirt.org/mailman/listinfo/engine-devel
> > >> 
> > 
> > 
> > 
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From bigclouds at 163.com  Fri Jun  7 07:29:25 2013
From: bigclouds at 163.com (bigclouds)
Date: Fri, 7 Jun 2013 15:29:25 +0800 (CST)
Subject: [Engine-devel] if there is a updated debug environment how to?
In-Reply-To: <1765947130.7563104.1370588141651.JavaMail.root@redhat.com>
References: <1f1cccaa.c254.13f13b00539.Coremail.bigclouds@163.com>
	<873179003.12476209.1370467027165.JavaMail.root@redhat.com>
	<6d2213fa.13e5.13f1c1bdb62.Coremail.bigclouds@163.com>
	<1765947130.7563104.1370588141651.JavaMail.root@redhat.com>
Message-ID: <44c3bbed.8c8a.13f1d8a3830.Coremail.bigclouds@163.com>

so many thinks,i  finally make it.
 
if i can debug gwt  in this environment?  and how?
 
 
if this link is still in use, http://www.ovirt.org/DebugFrontend
 
thanks.





At 2013-06-07 14:55:41,"Alon Bar-Lev" <alonbl at redhat.com> wrote:
>
>
>----- Original Message -----
>> From: "bigclouds" <bigclouds at 163.com>
>> To: "Eli Mesika" <emesika at redhat.com>
>> Cc: "engine-devel" <engine-devel at ovirt.org>
>> Sent: Friday, June 7, 2013 3:49:15 AM
>> Subject: Re: [Engine-devel] if there is a updated debug environment how to?
>> 
>> hi:
>> there is error when engine-setup-2. finally only 8702 and 8703 port is in
>> listen state.
>> i can not visit 8080 via browser.
>
>Well, if setup fails... probably application won't work.
>
>> engine-setup-2 ?
>> [ INFO  ] Creating CA
>> [ INFO  ] Creating database schema
>> [ ERROR ] Failed to execute stage 'Misc configuration': Command
>> '/home/best/ovirt-engine/share/ovirt-engine/dbscripts/create_schema.sh'
>> failed to execute
>> [ INFO  ] Stage: Clean up
>> Log file is located at /tmp/ovirt-engine-setup-20130606172206.log
>
>What database have you  used?
>If you don't have anything important there, can you please try to initialize it so you start fresh?
>
># systemctl stop postgresql.service
># rm -fr /var/lib/pgsql
># postgresql-setup initdb
># vi /var/lib/pgsql/data/pg_hba.conf
>modify 127.0.0.1/32 and ::1/128 lines to password at last field
># su - postgres -c psql -d template1
>template1=# create user engine password 'engine';
>template1=# create database engine owner engine;
># \q
>
>> 
>> 
>> 
>> 
>> At 2013-06-06 05:17:07,"Eli Mesika" <emesika at redhat.com> wrote:
>> >
>> >
>> >----- Original Message -----
>> >> From: "bigclouds" <bigclouds at 163.com>
>> >> To: "engine-devel" <engine-devel at ovirt.org>
>> >> Sent: Wednesday, June 5, 2013 12:34:30 PM
>> >> Subject: [Engine-devel] if there is a updated debug environment how to?
>> >> 
>> >> hi, engine guys:
>> >> i want to make a engine debug environment for a looong time, due to all
>> >>  kinds
>> >> of reasons i have not made it.
>> >> now i still have the need for a debug environment. (it seems like that i
>> >>  am
>> >> keeped away from you all)
>> >> if there is a updated doc for building engine debug environment?
>> >> thanks so much.
>> >> 
>> >
>> >Please follow Allon's B L doc on how to create a development environment
>> >
>> >http://www.ovirt.org/OVirt_Engine_Development_Environment
>> >
>> >
>> >> 
>> >> 
>> >> _______________________________________________
>> >> Engine-devel mailing list
>> >> Engine-devel at ovirt.org
>> >> http://lists.ovirt.org/mailman/listinfo/engine-devel
>> >> 
>> 
>> 
>> 
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130607/fbc3003b/attachment.html>

From alonbl at redhat.com  Fri Jun  7 07:46:12 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Fri, 7 Jun 2013 03:46:12 -0400 (EDT)
Subject: [Engine-devel] if there is a updated debug environment how to?
In-Reply-To: <44c3bbed.8c8a.13f1d8a3830.Coremail.bigclouds@163.com>
References: <1f1cccaa.c254.13f13b00539.Coremail.bigclouds@163.com>
	<873179003.12476209.1370467027165.JavaMail.root@redhat.com>
	<6d2213fa.13e5.13f1c1bdb62.Coremail.bigclouds@163.com>
	<1765947130.7563104.1370588141651.JavaMail.root@redhat.com>
	<44c3bbed.8c8a.13f1d8a3830.Coremail.bigclouds@163.com>
Message-ID: <1746462340.7577952.1370591172283.JavaMail.root@redhat.com>



----- Original Message -----
> From: "bigclouds" <bigclouds at 163.com>
> To: "Alon Bar-Lev" <alonbl at redhat.com>
> Cc: "Eli Mesika" <emesika at redhat.com>, "engine-devel" <engine-devel at ovirt.org>
> Sent: Friday, June 7, 2013 10:29:25 AM
> Subject: Re:Re: [Engine-devel] if there is a updated debug environment how to?
> 
> so many thinks,i  finally make it.
>  
> if i can debug gwt  in this environment?  and how?
>  
>  
> if this link is still in use, http://www.ovirt.org/DebugFrontend
>  
> thanks.
> 

This is interesting, I would like to work with someone that knows GWT to make this happen.

If I read this correctly, all you need to do is:

$ make install-dev PREFIX="${HOME}/ovirt-engine" EXTRA_BUILD_FLAGS_DEV="-Pgwtdev"

And connect eclipse using the standard jboss debug port.

But I know nothing of GWT, I will appreciate help in that...

How do we connect to a running instance of jboss and debug gwt, what setting should we have?

Thanks!

> 
> 
> 
> 
> At 2013-06-07 14:55:41,"Alon Bar-Lev" <alonbl at redhat.com> wrote:
> >
> >
> >----- Original Message -----
> >> From: "bigclouds" <bigclouds at 163.com>
> >> To: "Eli Mesika" <emesika at redhat.com>
> >> Cc: "engine-devel" <engine-devel at ovirt.org>
> >> Sent: Friday, June 7, 2013 3:49:15 AM
> >> Subject: Re: [Engine-devel] if there is a updated debug environment how
> >> to?
> >> 
> >> hi:
> >> there is error when engine-setup-2. finally only 8702 and 8703 port is in
> >> listen state.
> >> i can not visit 8080 via browser.
> >
> >Well, if setup fails... probably application won't work.
> >
> >> engine-setup-2 ?
> >> [ INFO  ] Creating CA
> >> [ INFO  ] Creating database schema
> >> [ ERROR ] Failed to execute stage 'Misc configuration': Command
> >> '/home/best/ovirt-engine/share/ovirt-engine/dbscripts/create_schema.sh'
> >> failed to execute
> >> [ INFO  ] Stage: Clean up
> >> Log file is located at /tmp/ovirt-engine-setup-20130606172206.log
> >
> >What database have you  used?
> >If you don't have anything important there, can you please try to initialize
> >it so you start fresh?
> >
> ># systemctl stop postgresql.service
> ># rm -fr /var/lib/pgsql
> ># postgresql-setup initdb
> ># vi /var/lib/pgsql/data/pg_hba.conf
> >modify 127.0.0.1/32 and ::1/128 lines to password at last field
> ># su - postgres -c psql -d template1
> >template1=# create user engine password 'engine';
> >template1=# create database engine owner engine;
> ># \q
> >
> >> 
> >> 
> >> 
> >> 
> >> At 2013-06-06 05:17:07,"Eli Mesika" <emesika at redhat.com> wrote:
> >> >
> >> >
> >> >----- Original Message -----
> >> >> From: "bigclouds" <bigclouds at 163.com>
> >> >> To: "engine-devel" <engine-devel at ovirt.org>
> >> >> Sent: Wednesday, June 5, 2013 12:34:30 PM
> >> >> Subject: [Engine-devel] if there is a updated debug environment how to?
> >> >> 
> >> >> hi, engine guys:
> >> >> i want to make a engine debug environment for a looong time, due to all
> >> >>  kinds
> >> >> of reasons i have not made it.
> >> >> now i still have the need for a debug environment. (it seems like that
> >> >> i
> >> >>  am
> >> >> keeped away from you all)
> >> >> if there is a updated doc for building engine debug environment?
> >> >> thanks so much.
> >> >> 
> >> >
> >> >Please follow Allon's B L doc on how to create a development environment
> >> >
> >> >http://www.ovirt.org/OVirt_Engine_Development_Environment
> >> >
> >> >
> >> >> 
> >> >> 
> >> >> _______________________________________________
> >> >> Engine-devel mailing list
> >> >> Engine-devel at ovirt.org
> >> >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> >> >> 
> >> 
> >> 
> >> 
> >> _______________________________________________
> >> Engine-devel mailing list
> >> Engine-devel at ovirt.org
> >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> >> 
> 


From sabose at redhat.com  Fri Jun  7 08:47:34 2013
From: sabose at redhat.com (Sahina Bose)
Date: Fri, 07 Jun 2013 14:17:34 +0530
Subject: [Engine-devel] Failing Junit tests in ovirt-engine
Message-ID: <51B19E26.3060105@redhat.com>

Hi,
I have send a patch to fix failures in junit tests [1] during 
ovirt-engine build.
Could someone please review and merge?

http://gerrit.ovirt.org/15434

thanks
sahina

[1]
Results :

Failed tests:
validateParameters(org.ovirt.engine.core.bll.SetupNetworksParametersTest)
  at org.junit.Assert.assertFalse(Assert.java:79)
         at 
org.ovirt.engine.core.bll.SetupNetworksParametersTest.validateParameters(SetupNetworksParametersTest.java:37)
         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

Tests in error:
gatewayChanged(org.ovirt.engine.core.bll.network.host.SetupNetworksHelperTest)
gatewayChanged(org.ovirt.engine.core.bll.network.host.SetupNetworksHelperTest) 
Time elapsed: 0.001 sec  <<< ERROR!
java.lang.NullPointerException
         at 
org.ovirt.engine.core.common.FeatureSupported.supportedInConfig(FeatureSupported.java:14)
         at 
org.ovirt.engine.core.common.FeatureSupported.multipleGatewaysSupported(FeatureSupported.java:114)



From lhornyak at redhat.com  Fri Jun  7 09:03:43 2013
From: lhornyak at redhat.com (Laszlo Hornyak)
Date: Fri, 7 Jun 2013 05:03:43 -0400 (EDT)
Subject: [Engine-devel] Failing Junit tests in ovirt-engine
In-Reply-To: <51B19E26.3060105@redhat.com>
References: <51B19E26.3060105@redhat.com>
Message-ID: <1602487755.13200735.1370595823794.JavaMail.root@redhat.com>

Hi Sahina,

Thank you for the fix, I merged it because the build was failing.
Alissa: could you please check if the changes are OK?

Thank you,
Laszlo

----- Original Message -----
> From: "Sahina Bose" <sabose at redhat.com>
> To: "engine-devel" <engine-devel at ovirt.org>
> Sent: Friday, June 7, 2013 10:47:34 AM
> Subject: [Engine-devel] Failing Junit tests in ovirt-engine
> 
> Hi,
> I have send a patch to fix failures in junit tests [1] during
> ovirt-engine build.
> Could someone please review and merge?
> 
> http://gerrit.ovirt.org/15434
> 
> thanks
> sahina
> 
> [1]
> Results :
> 
> Failed tests:
> validateParameters(org.ovirt.engine.core.bll.SetupNetworksParametersTest)
>   at org.junit.Assert.assertFalse(Assert.java:79)
>          at
> org.ovirt.engine.core.bll.SetupNetworksParametersTest.validateParameters(SetupNetworksParametersTest.java:37)
>          at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 
> Tests in error:
> gatewayChanged(org.ovirt.engine.core.bll.network.host.SetupNetworksHelperTest)
> gatewayChanged(org.ovirt.engine.core.bll.network.host.SetupNetworksHelperTest)
> Time elapsed: 0.001 sec  <<< ERROR!
> java.lang.NullPointerException
>          at
> org.ovirt.engine.core.common.FeatureSupported.supportedInConfig(FeatureSupported.java:14)
>          at
> org.ovirt.engine.core.common.FeatureSupported.multipleGatewaysSupported(FeatureSupported.java:114)
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From wlbleaboy at 126.com  Fri Jun  7 09:47:48 2013
From: wlbleaboy at 126.com (wlbleaboy@126)
Date: Fri, 7 Jun 2013 17:47:48 +0800
Subject: [Engine-devel] ovirt-engine-sdk with C
In-Reply-To: <CAGEoUW9=J+WoB2Ds1y2sNn0JFEsz6JAY417GY+G5jF5t5UY1aQ@mail.gmail.com>
References: <000101ce4fc3$0f359570$2da0c050$@com>	<CAGEoUW8a4XP=VA_NHXd1wD6sqA5dBdPPauMPrQE0RiKQ4Za8Aw@mail.gmail.com>	<000901ce60f8$77d692f0$6783b8d0$@com>	<CAGEoUW8UfWfj4RO699M-dOFTWv76h21R+pWL7rf8t1WoXeMeXg@mail.gmail.com>	<006901ce6199$657eea70$307cbf50$@com>
	<CAGEoUW9=J+WoB2Ds1y2sNn0JFEsz6JAY417GY+G5jF5t5UY1aQ@mail.gmail.com>
Message-ID: <009001ce6364$1244eef0$36ceccd0$@com>

Hi, Jarod.W:

         Thanks for your demo, but I think you miss two fucntinos like this:

 

curl_easy_setopt(curl, CURLOPT_SSL_VERIFYPEER, 0L);

         curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, 0L);

 

the following new demo code on my ubuntu is work well:

#include <stdio.h>

#include <curl/curl.h>

 

int main(void)

{

    CURL *curl;

    CURLcode res;

 

    curl_global_init(CURL_GLOBAL_DEFAULT);

 

    curl = curl_easy_init();

    if(curl)

    {

        curl_easy_setopt(curl, CURLOPT_URL, "https://192.168.1.201/api/");

        curl_easy_setopt(curl, CURLOPT_USERPWD, "admin at internal:111111");

        curl_easy_setopt(curl, CURLOPT_CAINFO,"/tmp/ca.crt");

 

        curl_easy_setopt(curl, CURLOPT_SSL_VERIFYPEER, 0L);

        curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, 0L);

 

        res = curl_easy_perform(curl);

 

        if(res != CURLE_OK)

            fprintf(stderr, "curl_easy_perform() failed: %s\n",

                    curl_easy_strerror(res));

 

        curl_easy_cleanup(curl);

    }

 

    curl_global_cleanup();

 

    return 0;

}

 

when I add this two functions , it works well for admin at internal

but can?t work for user portal, I check the information sent by 

admin at internal and user portal, the only difference is Filter,

admin at internal is Filter:False, the user portal is Filter:True.

 

How can I use curl_easy_setopt to set Filter .

 

                            Thanks

                                               Leaboy

 

From: Jarod. w [mailto:work.iec23801 at gmail.com] 
Sent: Wednesday, June 05, 2013 11:35 AM
To: wlbleaboy at 126
Cc: engine-devel at ovirt.org
Subject: Re: Re: [Engine-devel] ovirt-engine-sdk with C

 

2013/6/5 wlbleaboy at 126 <wlbleaboy at 126.com>

Hi, Jarod. W:

         I got your demo, and a build libcurl, but I can?t get any info

from https://{ovirt-engine }/api .

my code like this:

Please try to run the below command:
--
curl https://YOURIP/api -u YOURNAME:YOURPASSWD --cacert /root/ca.crt
--

After, please parse the result.

ps, I run the program on centos 6.4, and it works.

thanks.
 

int main(void)

{

    CURL *curl;

    CURLcode res;

    curl = curl_easy_init();

 

    if (curl)

    {

        printf("enter....\n");

        curl_easy_setopt(curl, CURLOPT_URL, "https://192.168.1.201/api");

        curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, callback_func);

        curl_easy_setopt(curl, CURLOPT_USERPWD, "admin at internal:111111");

        curl_easy_setopt(curl, CURLOPT_CAINFO,"/tmp/ca.crt");

        curl_easy_perform(curl);

        printf("exit.....\n");

 

        curl_easy_cleanup(curl);

    }

 

    return 0;

}

 

And when I run it, just outpu :

enter....

exit.....

 

I got the libcurl from http://curl.haxx.se/download.html and chosed curl-7.30.0.tar.gz <http://curl.haxx.se/download.html%20and%20chosed%20curl-7.30.0.tar.gz> 

and I use make and make install without any other options . I just guess maybe it need

other SSL library supported, but I don?t know how and which .

 

???: Jarod. w [mailto:work.iec23801 at gmail.com] 

????: 2013?6?4? 18:14
???: wlbleaboy at 126
??: engine-devel at ovirt.org
??: Re: ??: [Engine-devel] ovirt-engine-sdk with C

 

2013/6/4 wlbleaboy at 126 <wlbleaboy at 126.com>

Hi, Jarod. W:

    Yes, I just want to use c to invoke ovirt engine RestAPI,

Just get vm?s id, host, port, secur-port, and ticket,

    How can I use libcurl to connect https, could give me

a simple demo to connect https://{ovirt-engine}/api <https://%7bovirt-engine%7d/api>  with 

--cafile, the ca.crt I get from http://{ovirt-engine}/ca.crt <http://%7bovirt-engine%7d/ca.crt> 

Please download the demo from the above url:
https://github.com/jarod-w/hglibraries/blob/master/demo/restapi.c
 

 

 

???: Jarod. w [mailto:work.iec23801 at gmail.com] 
????: 2013?5?14? 10:27
???: leaboy at 126
??: engine-devel at ovirt.org
??: Re: [Engine-devel] ovirt-engine-sdk with C

 

2013/5/13 leaboy at 126 <wlbleaboy at 126.com>

Hi?All

         I felt oivrt-engine-sdk coded with Python is slowly to connect

ovirt-engine and console vm when a user have many vms, So, I just

want to rewrite the sdk with C(ANSI C Language). Just rewrite a sdk

with C to connect overt-engine and console vm, would anyone give 

me some suggestion.

Do you want to use c to invoke ovirt engine RestAPI, right?

If yes, you can use libcurl to do the thing, and it'll make you happy.

 

 

         Now, the problem is how can I connect to ovit-engine with C, and

how can I get some information of vms, and how ovirrt-engine can 

respond my action(start,stop, .eg)

Agree with Michael Pasternak.

You should parse your code into the mail list, or someone can't help

you.

 

 

                                                                                    Leaboy at beijing

                                                                 Thinks


_______________________________________________
Engine-devel mailing list
Engine-devel at ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel




-- 
---
Best Regards
Jarod.W




-- 
---
Best Regards
Jarod.W




-- 
---
Best Regards
Jarod.W

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130607/4f4bbf25/attachment.html>

From awels at redhat.com  Fri Jun  7 12:09:19 2013
From: awels at redhat.com (Alexander Wels)
Date: Fri, 07 Jun 2013 08:09:19 -0400
Subject: [Engine-devel] if there is a updated debug environment how to?
In-Reply-To: <1746462340.7577952.1370591172283.JavaMail.root@redhat.com>
References: <1f1cccaa.c254.13f13b00539.Coremail.bigclouds@163.com>
	<44c3bbed.8c8a.13f1d8a3830.Coremail.bigclouds@163.com>
	<1746462340.7577952.1370591172283.JavaMail.root@redhat.com>
Message-ID: <2156639.5opditLpGM@awels>

On Friday, June 07, 2013 03:46:12 AM Alon Bar-Lev wrote:
> ----- Original Message -----
> 
> > From: "bigclouds" <bigclouds at 163.com>
> > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > Cc: "Eli Mesika" <emesika at redhat.com>, "engine-devel"
> > <engine-devel at ovirt.org> Sent: Friday, June 7, 2013 10:29:25 AM
> > Subject: Re:Re: [Engine-devel] if there is a updated debug environment how
> > to?
> > 
> > so many thinks,i  finally make it.
> > 
> > if i can debug gwt  in this environment?  and how?
> > 
> > 
> > if this link is still in use, http://www.ovirt.org/DebugFrontend
> > 
> > thanks.
> 
> This is interesting, I would like to work with someone that knows GWT to
> make this happen.
> 
> If I read this correctly, all you need to do is:
> 
> $ make install-dev PREFIX="${HOME}/ovirt-engine"
> EXTRA_BUILD_FLAGS_DEV="-Pgwtdev"
> 
> And connect eclipse using the standard jboss debug port.
> 
> But I know nothing of GWT, I will appreciate help in that...
> 
> How do we connect to a running instance of jboss and debug gwt, what setting
> should we have?
> 

Once you have the engine up and running as explained about, you can use 
http://www.ovirt.org/DebugFrontend to run GWT debugging. You can safely skip step 0 
in that document (I think that needs to be updated). And start at step 1. The 
document explains quite well what to do, but the short version is:

1. cd into the source code directory of either webadmin or user portal. Usually: ovirt-
engine/frontend/webadmin/modules/(webadmin or userportal-gwtp)
2. mvn gwt:debug -Pgwtdev,gwt-admin,gwt-user -Dgwt.noserver=true from the 
command line. Once it is done compiling it will tell you it is listening on port 8000.
3.In eclipse (or your favorite java IDE) make a remote java application connection to 
port 8000
4. Once connected this will open up a GWT debug window.
5. In your browser as ?gwt.codesvr=127.0.0.1:9997 to the url you are working with and 
refresh the page.
6. It will either ask you to install the plugin in your browser or load the page depending 
on if you have the plugin already.

Alexander

> Thanks!
> 
> > At 2013-06-07 14:55:41,"Alon Bar-Lev" <alonbl at redhat.com> wrote:
> > >----- Original Message -----
> > >
> > >> From: "bigclouds" <bigclouds at 163.com>
> > >> To: "Eli Mesika" <emesika at redhat.com>
> > >> Cc: "engine-devel" <engine-devel at ovirt.org>
> > >> Sent: Friday, June 7, 2013 3:49:15 AM
> > >> Subject: Re: [Engine-devel] if there is a updated debug environment how
> > >> to?
> > >> 
> > >> hi:
> > >> there is error when engine-setup-2. finally only 8702 and 8703 port is
> > >> in
> > >> listen state.
> > >> i can not visit 8080 via browser.
> > >
> > >Well, if setup fails... probably application won't work.
> > >
> > >> engine-setup-2 ?
> > >> [ INFO  ] Creating CA
> > >> [ INFO  ] Creating database schema
> > >> [ ERROR ] Failed to execute stage 'Misc configuration': Command
> > >> '/home/best/ovirt-engine/share/ovirt-engine/dbscripts/create_schema.sh'
> > >> failed to execute
> > >> [ INFO  ] Stage: Clean up
> > >> Log file is located at /tmp/ovirt-engine-setup-20130606172206.log
> > >
> > >What database have you  used?
> > >If you don't have anything important there, can you please try to
> > >initialize it so you start fresh?
> > >
> > ># systemctl stop postgresql.service
> > ># rm -fr /var/lib/pgsql
> > ># postgresql-setup initdb
> > ># vi /var/lib/pgsql/data/pg_hba.conf
> > >modify 127.0.0.1/32 and ::1/128 lines to password at last field
> > ># su - postgres -c psql -d template1
> > >template1=# create user engine password 'engine';
> > >template1=# create database engine owner engine;
> > ># \q
> > >
> > >> At 2013-06-06 05:17:07,"Eli Mesika" <emesika at redhat.com> wrote:
> > >> >----- Original Message -----
> > >> >
> > >> >> From: "bigclouds" <bigclouds at 163.com>
> > >> >> To: "engine-devel" <engine-devel at ovirt.org>
> > >> >> Sent: Wednesday, June 5, 2013 12:34:30 PM
> > >> >> Subject: [Engine-devel] if there is a updated debug environment how
> > >> >> to?
> > >> >> 
> > >> >> hi, engine guys:
> > >> >> i want to make a engine debug environment for a looong time, due to
> > >> >> all
> > >> >> 
> > >> >>  kinds
> > >> >> 
> > >> >> of reasons i have not made it.
> > >> >> now i still have the need for a debug environment. (it seems like
> > >> >> that
> > >> >> i
> > >> >> 
> > >> >>  am
> > >> >> 
> > >> >> keeped away from you all)
> > >> >> if there is a updated doc for building engine debug environment?
> > >> >> thanks so much.
> > >> >
> > >> >Please follow Allon's B L doc on how to create a development
> > >> >environment
> > >> >
> > >> >http://www.ovirt.org/OVirt_Engine_Development_Environment
> > >> >
> > >> >> _______________________________________________
> > >> >> Engine-devel mailing list
> > >> >> Engine-devel at ovirt.org
> > >> >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> > >> 
> > >> _______________________________________________
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130607/3ae785a6/attachment.html>

From alonbl at redhat.com  Fri Jun  7 12:26:32 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Fri, 7 Jun 2013 08:26:32 -0400 (EDT)
Subject: [Engine-devel] if there is a updated debug environment how to?
In-Reply-To: <2156639.5opditLpGM@awels>
References: <1f1cccaa.c254.13f13b00539.Coremail.bigclouds@163.com>
	<44c3bbed.8c8a.13f1d8a3830.Coremail.bigclouds@163.com>
	<1746462340.7577952.1370591172283.JavaMail.root@redhat.com>
	<2156639.5opditLpGM@awels>
Message-ID: <1045355139.7632228.1370607992245.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Alexander Wels" <awels at redhat.com>
> To: engine-devel at ovirt.org
> Cc: "Alon Bar-Lev" <alonbl at redhat.com>, "bigclouds" <bigclouds at 163.com>
> Sent: Friday, June 7, 2013 3:09:19 PM
> Subject: Re: [Engine-devel] if there is a updated debug environment how to?
> 
> On Friday, June 07, 2013 03:46:12 AM Alon Bar-Lev wrote:
> > ----- Original Message -----
> > 
> > > From: "bigclouds" <bigclouds at 163.com>
> > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > Cc: "Eli Mesika" <emesika at redhat.com>, "engine-devel"
> > > <engine-devel at ovirt.org> Sent: Friday, June 7, 2013 10:29:25 AM
> > > Subject: Re:Re: [Engine-devel] if there is a updated debug environment
> > > how
> > > to?
> > > 
> > > so many thinks,i  finally make it.
> > > 
> > > if i can debug gwt  in this environment?  and how?
> > > 
> > > 
> > > if this link is still in use, http://www.ovirt.org/DebugFrontend
> > > 
> > > thanks.
> > 
> > This is interesting, I would like to work with someone that knows GWT to
> > make this happen.
> > 
> > If I read this correctly, all you need to do is:
> > 
> > $ make install-dev PREFIX="${HOME}/ovirt-engine"
> > EXTRA_BUILD_FLAGS_DEV="-Pgwtdev"
> > 
> > And connect eclipse using the standard jboss debug port.
> > 
> > But I know nothing of GWT, I will appreciate help in that...
> > 
> > How do we connect to a running instance of jboss and debug gwt, what
> > setting
> > should we have?
> > 

Hi Alex,
 
> Once you have the engine up and running as explained about, you can use
> http://www.ovirt.org/DebugFrontend to run GWT debugging. You can safely skip
> step 0
> in that document (I think that needs to be updated). And start at step 1. The
> document explains quite well what to do, but the short version is:
> 
> 1. cd into the source code directory of either webadmin or user portal.
> Usually: ovirt-
> engine/frontend/webadmin/modules/(webadmin or userportal-gwtp)
> 2. mvn gwt:debug -Pgwtdev,gwt-admin,gwt-user -Dgwt.noserver=true from the
> command line. Once it is done compiling it will tell you it is listening on
> port 8000.

This will not run as jboss, right?
Or you mean it will run on the jboss of the legacy (not the new environment).
I would like a solution in which we can use the already running jboss instance that use for production in order to debug gwt.
Is that possible?
I guess some properties need to be passed, or new modules.

Thanks!

> 3.In eclipse (or your favorite java IDE) make a remote java application
> connection to
> port 8000
> 4. Once connected this will open up a GWT debug window.
> 5. In your browser as ?gwt.codesvr=127.0.0.1:9997 to the url you are working
> with and
> refresh the page.
> 6. It will either ask you to install the plugin in your browser or load the
> page depending
> on if you have the plugin already.
> 
> Alexander
> 
> > Thanks!
> > 
> > > At 2013-06-07 14:55:41,"Alon Bar-Lev" <alonbl at redhat.com> wrote:
> > > >----- Original Message -----
> > > >
> > > >> From: "bigclouds" <bigclouds at 163.com>
> > > >> To: "Eli Mesika" <emesika at redhat.com>
> > > >> Cc: "engine-devel" <engine-devel at ovirt.org>
> > > >> Sent: Friday, June 7, 2013 3:49:15 AM
> > > >> Subject: Re: [Engine-devel] if there is a updated debug environment
> > > >> how
> > > >> to?
> > > >> 
> > > >> hi:
> > > >> there is error when engine-setup-2. finally only 8702 and 8703 port is
> > > >> in
> > > >> listen state.
> > > >> i can not visit 8080 via browser.
> > > >
> > > >Well, if setup fails... probably application won't work.
> > > >
> > > >> engine-setup-2 ?
> > > >> [ INFO  ] Creating CA
> > > >> [ INFO  ] Creating database schema
> > > >> [ ERROR ] Failed to execute stage 'Misc configuration': Command
> > > >> '/home/best/ovirt-engine/share/ovirt-engine/dbscripts/create_schema.sh'
> > > >> failed to execute
> > > >> [ INFO  ] Stage: Clean up
> > > >> Log file is located at /tmp/ovirt-engine-setup-20130606172206.log
> > > >
> > > >What database have you  used?
> > > >If you don't have anything important there, can you please try to
> > > >initialize it so you start fresh?
> > > >
> > > ># systemctl stop postgresql.service
> > > ># rm -fr /var/lib/pgsql
> > > ># postgresql-setup initdb
> > > ># vi /var/lib/pgsql/data/pg_hba.conf
> > > >modify 127.0.0.1/32 and ::1/128 lines to password at last field
> > > ># su - postgres -c psql -d template1
> > > >template1=# create user engine password 'engine';
> > > >template1=# create database engine owner engine;
> > > ># \q
> > > >
> > > >> At 2013-06-06 05:17:07,"Eli Mesika" <emesika at redhat.com> wrote:
> > > >> >----- Original Message -----
> > > >> >
> > > >> >> From: "bigclouds" <bigclouds at 163.com>
> > > >> >> To: "engine-devel" <engine-devel at ovirt.org>
> > > >> >> Sent: Wednesday, June 5, 2013 12:34:30 PM
> > > >> >> Subject: [Engine-devel] if there is a updated debug environment how
> > > >> >> to?
> > > >> >> 
> > > >> >> hi, engine guys:
> > > >> >> i want to make a engine debug environment for a looong time, due to
> > > >> >> all
> > > >> >> 
> > > >> >>  kinds
> > > >> >> 
> > > >> >> of reasons i have not made it.
> > > >> >> now i still have the need for a debug environment. (it seems like
> > > >> >> that
> > > >> >> i
> > > >> >> 
> > > >> >>  am
> > > >> >> 
> > > >> >> keeped away from you all)
> > > >> >> if there is a updated doc for building engine debug environment?
> > > >> >> thanks so much.
> > > >> >
> > > >> >Please follow Allon's B L doc on how to create a development
> > > >> >environment
> > > >> >
> > > >> >http://www.ovirt.org/OVirt_Engine_Development_Environment
> > > >> >
> > > >> >> _______________________________________________
> > > >> >> Engine-devel mailing list
> > > >> >> Engine-devel at ovirt.org
> > > >> >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > >> 
> > > >> _______________________________________________


From awels at redhat.com  Fri Jun  7 13:14:59 2013
From: awels at redhat.com (Alexander Wels)
Date: Fri, 07 Jun 2013 09:14:59 -0400
Subject: [Engine-devel] if there is a updated debug environment how to?
In-Reply-To: <1045355139.7632228.1370607992245.JavaMail.root@redhat.com>
References: <1f1cccaa.c254.13f13b00539.Coremail.bigclouds@163.com>
	<2156639.5opditLpGM@awels>
	<1045355139.7632228.1370607992245.JavaMail.root@redhat.com>
Message-ID: <1468524.dLY0xj14LH@awels>

On Friday, June 07, 2013 08:26:32 AM Alon Bar-Lev wrote:
> ----- Original Message -----
> 
> > From: "Alexander Wels" <awels at redhat.com>
> > To: engine-devel at ovirt.org
> > Cc: "Alon Bar-Lev" <alonbl at redhat.com>, "bigclouds" <bigclouds at 163.com>
> > Sent: Friday, June 7, 2013 3:09:19 PM
> > Subject: Re: [Engine-devel] if there is a updated debug environment how
> > to?
> > 
> > On Friday, June 07, 2013 03:46:12 AM Alon Bar-Lev wrote:
> > > ----- Original Message -----
> > > 
> > > > From: "bigclouds" <bigclouds at 163.com>
> > > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > > Cc: "Eli Mesika" <emesika at redhat.com>, "engine-devel"
> > > > <engine-devel at ovirt.org> Sent: Friday, June 7, 2013 10:29:25 AM
> > > > Subject: Re:Re: [Engine-devel] if there is a updated debug environment
> > > > how
> > > > to?
> > > > 
> > > > so many thinks,i  finally make it.
> > > > 
> > > > if i can debug gwt  in this environment?  and how?
> > > > 
> > > > 
> > > > if this link is still in use, http://www.ovirt.org/DebugFrontend
> > > > 
> > > > thanks.
> > > 
> > > This is interesting, I would like to work with someone that knows GWT to
> > > make this happen.
> > > 
> > > If I read this correctly, all you need to do is:
> > > 
> > > $ make install-dev PREFIX="${HOME}/ovirt-engine"
> > > EXTRA_BUILD_FLAGS_DEV="-Pgwtdev"
> > > 
> > > And connect eclipse using the standard jboss debug port.
> > > 
> > > But I know nothing of GWT, I will appreciate help in that...
> > > 
> > > How do we connect to a running instance of jboss and debug gwt, what
> > > setting
> > > should we have?
> 
> Hi Alex,
> 
> > Once you have the engine up and running as explained about, you can use
> > http://www.ovirt.org/DebugFrontend to run GWT debugging. You can safely
> > skip step 0
> > in that document (I think that needs to be updated). And start at step 1.
> > The document explains quite well what to do, but the short version is:
> > 
> > 1. cd into the source code directory of either webadmin or user portal.
> > Usually: ovirt-
> > engine/frontend/webadmin/modules/(webadmin or userportal-gwtp)
> > 2. mvn gwt:debug -Pgwtdev,gwt-admin,gwt-user -Dgwt.noserver=true from the
> > command line. Once it is done compiling it will tell you it is listening
> > on
> > port 8000.
> 
> This will not run as jboss, right?

No it is a normal java application (The GWT debugger).

> Or you mean it will run on the jboss of the legacy (not the new
> environment). I would like a solution in which we can use the already
> running jboss instance that use for production in order to debug gwt. Is
> that possible?
> I guess some properties need to be passed, or new modules.
> 
> Thanks!

The GWT debugger is completely agnostic with regards to what serves the host 
page. The GWT debugger is connected to the browser, not the server. The host 
page can be served from a local JBOSS, a remote Apache, a file, whatever. The 
GWT debugger doesn't care as it is talking to the browser.

IMO the only thing we could do to improve this is update the make file to 
provide a target to start the debugger, which basically just calls maven with 
the appropriate parameters.


> 
> > 3.In eclipse (or your favorite java IDE) make a remote java application
> > connection to
> > port 8000
> > 4. Once connected this will open up a GWT debug window.
> > 5. In your browser as ?gwt.codesvr=127.0.0.1:9997 to the url you are
> > working with and
> > refresh the page.
> > 6. It will either ask you to install the plugin in your browser or load
> > the
> > page depending
> > on if you have the plugin already.
> > 
> > Alexander
> > 
> > > Thanks!
> > > 
> > > > At 2013-06-07 14:55:41,"Alon Bar-Lev" <alonbl at redhat.com> wrote:
> > > > >----- Original Message -----
> > > > >
> > > > >> From: "bigclouds" <bigclouds at 163.com>
> > > > >> To: "Eli Mesika" <emesika at redhat.com>
> > > > >> Cc: "engine-devel" <engine-devel at ovirt.org>
> > > > >> Sent: Friday, June 7, 2013 3:49:15 AM
> > > > >> Subject: Re: [Engine-devel] if there is a updated debug environment
> > > > >> how
> > > > >> to?
> > > > >> 
> > > > >> hi:
> > > > >> there is error when engine-setup-2. finally only 8702 and 8703 port
> > > > >> is
> > > > >> in
> > > > >> listen state.
> > > > >> i can not visit 8080 via browser.
> > > > >
> > > > >Well, if setup fails... probably application won't work.
> > > > >
> > > > >> engine-setup-2 ?
> > > > >> [ INFO  ] Creating CA
> > > > >> [ INFO  ] Creating database schema
> > > > >> [ ERROR ] Failed to execute stage 'Misc configuration': Command
> > > > >> '/home/best/ovirt-engine/share/ovirt-engine/dbscripts/create_schema
> > > > >> .sh'
> > > > >> failed to execute
> > > > >> [ INFO  ] Stage: Clean up
> > > > >> Log file is located at /tmp/ovirt-engine-setup-20130606172206.log
> > > > >
> > > > >What database have you  used?
> > > > >If you don't have anything important there, can you please try to
> > > > >initialize it so you start fresh?
> > > > >
> > > > ># systemctl stop postgresql.service
> > > > ># rm -fr /var/lib/pgsql
> > > > ># postgresql-setup initdb
> > > > ># vi /var/lib/pgsql/data/pg_hba.conf
> > > > >modify 127.0.0.1/32 and ::1/128 lines to password at last field
> > > > ># su - postgres -c psql -d template1
> > > > >template1=# create user engine password 'engine';
> > > > >template1=# create database engine owner engine;
> > > > ># \q
> > > > >
> > > > >> At 2013-06-06 05:17:07,"Eli Mesika" <emesika at redhat.com> wrote:
> > > > >> >----- Original Message -----
> > > > >> >
> > > > >> >> From: "bigclouds" <bigclouds at 163.com>
> > > > >> >> To: "engine-devel" <engine-devel at ovirt.org>
> > > > >> >> Sent: Wednesday, June 5, 2013 12:34:30 PM
> > > > >> >> Subject: [Engine-devel] if there is a updated debug environment
> > > > >> >> how
> > > > >> >> to?
> > > > >> >> 
> > > > >> >> hi, engine guys:
> > > > >> >> i want to make a engine debug environment for a looong time, due
> > > > >> >> to
> > > > >> >> all
> > > > >> >> 
> > > > >> >>  kinds
> > > > >> >> 
> > > > >> >> of reasons i have not made it.
> > > > >> >> now i still have the need for a debug environment. (it seems
> > > > >> >> like
> > > > >> >> that
> > > > >> >> i
> > > > >> >> 
> > > > >> >>  am
> > > > >> >> 
> > > > >> >> keeped away from you all)
> > > > >> >> if there is a updated doc for building engine debug environment?
> > > > >> >> thanks so much.
> > > > >> >
> > > > >> >Please follow Allon's B L doc on how to create a development
> > > > >> >environment
> > > > >> >
> > > > >> >http://www.ovirt.org/OVirt_Engine_Development_Environment
> > > > >> >
> > > > >> >> _______________________________________________
> > > > >> >> Engine-devel mailing list
> > > > >> >> Engine-devel at ovirt.org
> > > > >> >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > >> 
> > > > >> _______________________________________________


From alonbl at redhat.com  Fri Jun  7 16:22:10 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Fri, 7 Jun 2013 12:22:10 -0400 (EDT)
Subject: [Engine-devel] if there is a updated debug environment how to?
In-Reply-To: <1468524.dLY0xj14LH@awels>
References: <1f1cccaa.c254.13f13b00539.Coremail.bigclouds@163.com>
	<2156639.5opditLpGM@awels>
	<1045355139.7632228.1370607992245.JavaMail.root@redhat.com>
	<1468524.dLY0xj14LH@awels>
Message-ID: <1702507006.7776617.1370622130138.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Alexander Wels" <awels at redhat.com>
> To: "Alon Bar-Lev" <alonbl at redhat.com>
> Cc: engine-devel at ovirt.org, "bigclouds" <bigclouds at 163.com>
> Sent: Friday, June 7, 2013 4:14:59 PM
> Subject: Re: [Engine-devel] if there is a updated debug environment how to?
> 
> On Friday, June 07, 2013 08:26:32 AM Alon Bar-Lev wrote:
> > ----- Original Message -----
> > 
> > > From: "Alexander Wels" <awels at redhat.com>
> > > To: engine-devel at ovirt.org
> > > Cc: "Alon Bar-Lev" <alonbl at redhat.com>, "bigclouds" <bigclouds at 163.com>
> > > Sent: Friday, June 7, 2013 3:09:19 PM
> > > Subject: Re: [Engine-devel] if there is a updated debug environment how
> > > to?
> > > 
> > > On Friday, June 07, 2013 03:46:12 AM Alon Bar-Lev wrote:
> > > > ----- Original Message -----
> > > > 
> > > > > From: "bigclouds" <bigclouds at 163.com>
> > > > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > > > Cc: "Eli Mesika" <emesika at redhat.com>, "engine-devel"
> > > > > <engine-devel at ovirt.org> Sent: Friday, June 7, 2013 10:29:25 AM
> > > > > Subject: Re:Re: [Engine-devel] if there is a updated debug
> > > > > environment
> > > > > how
> > > > > to?
> > > > > 
> > > > > so many thinks,i  finally make it.
> > > > > 
> > > > > if i can debug gwt  in this environment?  and how?
> > > > > 
> > > > > 
> > > > > if this link is still in use, http://www.ovirt.org/DebugFrontend
> > > > > 
> > > > > thanks.
> > > > 
> > > > This is interesting, I would like to work with someone that knows GWT
> > > > to
> > > > make this happen.
> > > > 
> > > > If I read this correctly, all you need to do is:
> > > > 
> > > > $ make install-dev PREFIX="${HOME}/ovirt-engine"
> > > > EXTRA_BUILD_FLAGS_DEV="-Pgwtdev"
> > > > 
> > > > And connect eclipse using the standard jboss debug port.
> > > > 
> > > > But I know nothing of GWT, I will appreciate help in that...
> > > > 
> > > > How do we connect to a running instance of jboss and debug gwt, what
> > > > setting
> > > > should we have?
> > 
> > Hi Alex,
> > 
> > > Once you have the engine up and running as explained about, you can use
> > > http://www.ovirt.org/DebugFrontend to run GWT debugging. You can safely
> > > skip step 0
> > > in that document (I think that needs to be updated). And start at step 1.
> > > The document explains quite well what to do, but the short version is:
> > > 
> > > 1. cd into the source code directory of either webadmin or user portal.
> > > Usually: ovirt-
> > > engine/frontend/webadmin/modules/(webadmin or userportal-gwtp)
> > > 2. mvn gwt:debug -Pgwtdev,gwt-admin,gwt-user -Dgwt.noserver=true from the
> > > command line. Once it is done compiling it will tell you it is listening
> > > on
> > > port 8000.
> > 
> > This will not run as jboss, right?
> 
> No it is a normal java application (The GWT debugger).
> 
> > Or you mean it will run on the jboss of the legacy (not the new
> > environment). I would like a solution in which we can use the already
> > running jboss instance that use for production in order to debug gwt. Is
> > that possible?
> > I guess some properties need to be passed, or new modules.
> > 
> > Thanks!
> 
> The GWT debugger is completely agnostic with regards to what serves the host
> page. The GWT debugger is connected to the browser, not the server. The host
> page can be served from a local JBOSS, a remote Apache, a file, whatever. The
> GWT debugger doesn't care as it is talking to the browser.

Can you please explain this text from the wiki:

gwt.noserver tells Development Mode that the application is already deployed on JBoss AS (don't use embedded Jetty instance to serve application content) 

Or this:

Q: Client-side logs are not persisted on Engine, e.g. $JBOSS_HOME/standalone/log/engine/engine-ui.log.
A: Currently, client-side logs are enabled only when debugging the application via Development Mode.

What listens on port 8700?

Thanks!

> 
> IMO the only thing we could do to improve this is update the make file to
> provide a target to start the debugger, which basically just calls maven with
> the appropriate parameters.
> 
> 
> > 
> > > 3.In eclipse (or your favorite java IDE) make a remote java application
> > > connection to
> > > port 8000
> > > 4. Once connected this will open up a GWT debug window.
> > > 5. In your browser as ?gwt.codesvr=127.0.0.1:9997 to the url you are
> > > working with and
> > > refresh the page.
> > > 6. It will either ask you to install the plugin in your browser or load
> > > the
> > > page depending
> > > on if you have the plugin already.
> > > 
> > > Alexander
> > > 
> > > > Thanks!
> > > > 
> > > > > At 2013-06-07 14:55:41,"Alon Bar-Lev" <alonbl at redhat.com> wrote:
> > > > > >----- Original Message -----
> > > > > >
> > > > > >> From: "bigclouds" <bigclouds at 163.com>
> > > > > >> To: "Eli Mesika" <emesika at redhat.com>
> > > > > >> Cc: "engine-devel" <engine-devel at ovirt.org>
> > > > > >> Sent: Friday, June 7, 2013 3:49:15 AM
> > > > > >> Subject: Re: [Engine-devel] if there is a updated debug
> > > > > >> environment
> > > > > >> how
> > > > > >> to?
> > > > > >> 
> > > > > >> hi:
> > > > > >> there is error when engine-setup-2. finally only 8702 and 8703
> > > > > >> port
> > > > > >> is
> > > > > >> in
> > > > > >> listen state.
> > > > > >> i can not visit 8080 via browser.
> > > > > >
> > > > > >Well, if setup fails... probably application won't work.
> > > > > >
> > > > > >> engine-setup-2 ?
> > > > > >> [ INFO  ] Creating CA
> > > > > >> [ INFO  ] Creating database schema
> > > > > >> [ ERROR ] Failed to execute stage 'Misc configuration': Command
> > > > > >> '/home/best/ovirt-engine/share/ovirt-engine/dbscripts/create_schema
> > > > > >> .sh'
> > > > > >> failed to execute
> > > > > >> [ INFO  ] Stage: Clean up
> > > > > >> Log file is located at /tmp/ovirt-engine-setup-20130606172206.log
> > > > > >
> > > > > >What database have you  used?
> > > > > >If you don't have anything important there, can you please try to
> > > > > >initialize it so you start fresh?
> > > > > >
> > > > > ># systemctl stop postgresql.service
> > > > > ># rm -fr /var/lib/pgsql
> > > > > ># postgresql-setup initdb
> > > > > ># vi /var/lib/pgsql/data/pg_hba.conf
> > > > > >modify 127.0.0.1/32 and ::1/128 lines to password at last field
> > > > > ># su - postgres -c psql -d template1
> > > > > >template1=# create user engine password 'engine';
> > > > > >template1=# create database engine owner engine;
> > > > > ># \q
> > > > > >
> > > > > >> At 2013-06-06 05:17:07,"Eli Mesika" <emesika at redhat.com> wrote:
> > > > > >> >----- Original Message -----
> > > > > >> >
> > > > > >> >> From: "bigclouds" <bigclouds at 163.com>
> > > > > >> >> To: "engine-devel" <engine-devel at ovirt.org>
> > > > > >> >> Sent: Wednesday, June 5, 2013 12:34:30 PM
> > > > > >> >> Subject: [Engine-devel] if there is a updated debug environment
> > > > > >> >> how
> > > > > >> >> to?
> > > > > >> >> 
> > > > > >> >> hi, engine guys:
> > > > > >> >> i want to make a engine debug environment for a looong time,
> > > > > >> >> due
> > > > > >> >> to
> > > > > >> >> all
> > > > > >> >> 
> > > > > >> >>  kinds
> > > > > >> >> 
> > > > > >> >> of reasons i have not made it.
> > > > > >> >> now i still have the need for a debug environment. (it seems
> > > > > >> >> like
> > > > > >> >> that
> > > > > >> >> i
> > > > > >> >> 
> > > > > >> >>  am
> > > > > >> >> 
> > > > > >> >> keeped away from you all)
> > > > > >> >> if there is a updated doc for building engine debug
> > > > > >> >> environment?
> > > > > >> >> thanks so much.
> > > > > >> >
> > > > > >> >Please follow Allon's B L doc on how to create a development
> > > > > >> >environment
> > > > > >> >
> > > > > >> >http://www.ovirt.org/OVirt_Engine_Development_Environment
> > > > > >> >
> > > > > >> >> _______________________________________________
> > > > > >> >> Engine-devel mailing list
> > > > > >> >> Engine-devel at ovirt.org
> > > > > >> >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > > >> 
> > > > > >> _______________________________________________
> 


From mbetak at redhat.com  Fri Jun  7 16:32:31 2013
From: mbetak at redhat.com (Martin Betak)
Date: Fri, 7 Jun 2013 12:32:31 -0400 (EDT)
Subject: [Engine-devel] Guest Reboot
In-Reply-To: <1880445246.16323694.1370621990151.JavaMail.root@redhat.com>
Message-ID: <1845391574.16328760.1370622751837.JavaMail.root@redhat.com>

Hi, engine-devel

Customers request the ability to reboot a VM with a single click so I started designing the overall architecture and planing out the required changes to the respective components. 
You can find the wiki page for the initial draft at [1] and I would like to ask you for your input on my general design and potential issues that could arise in some corner cases.
Please feel free to respond to this thread or add to the Issues section of [1].

Thanks in advance for your opinions :-)

Martin

[1] http://www.ovirt.org/Features/Guest_Reboot


From awels at redhat.com  Fri Jun  7 17:35:27 2013
From: awels at redhat.com (Alexander Wels)
Date: Fri, 07 Jun 2013 13:35:27 -0400
Subject: [Engine-devel] if there is a updated debug environment how to?
In-Reply-To: <1702507006.7776617.1370622130138.JavaMail.root@redhat.com>
References: <1f1cccaa.c254.13f13b00539.Coremail.bigclouds@163.com>
	<1468524.dLY0xj14LH@awels>
	<1702507006.7776617.1370622130138.JavaMail.root@redhat.com>
Message-ID: <4614483.AH5sPLafxW@awels>

On Friday, June 07, 2013 12:22:10 PM Alon Bar-Lev wrote:
> ----- Original Message -----
> 
> > From: "Alexander Wels" <awels at redhat.com>
> > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > Cc: engine-devel at ovirt.org, "bigclouds" <bigclouds at 163.com>
> > Sent: Friday, June 7, 2013 4:14:59 PM
> > Subject: Re: [Engine-devel] if there is a updated debug environment how
> > to?
> > 
> > On Friday, June 07, 2013 08:26:32 AM Alon Bar-Lev wrote:
> > > ----- Original Message -----
> > > 
> > > > From: "Alexander Wels" <awels at redhat.com>
> > > > To: engine-devel at ovirt.org
> > > > Cc: "Alon Bar-Lev" <alonbl at redhat.com>, "bigclouds"
> > > > <bigclouds at 163.com>
> > > > Sent: Friday, June 7, 2013 3:09:19 PM
> > > > Subject: Re: [Engine-devel] if there is a updated debug environment
> > > > how
> > > > to?
> > > > 
> > > > On Friday, June 07, 2013 03:46:12 AM Alon Bar-Lev wrote:
> > > > > ----- Original Message -----
> > > > > 
> > > > > > From: "bigclouds" <bigclouds at 163.com>
> > > > > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > > > > Cc: "Eli Mesika" <emesika at redhat.com>, "engine-devel"
> > > > > > <engine-devel at ovirt.org> Sent: Friday, June 7, 2013 10:29:25 AM
> > > > > > Subject: Re:Re: [Engine-devel] if there is a updated debug
> > > > > > environment
> > > > > > how
> > > > > > to?
> > > > > > 
> > > > > > so many thinks,i  finally make it.
> > > > > > 
> > > > > > if i can debug gwt  in this environment?  and how?
> > > > > > 
> > > > > > 
> > > > > > if this link is still in use, http://www.ovirt.org/DebugFrontend
> > > > > > 
> > > > > > thanks.
> > > > > 
> > > > > This is interesting, I would like to work with someone that knows
> > > > > GWT
> > > > > to
> > > > > make this happen.
> > > > > 
> > > > > If I read this correctly, all you need to do is:
> > > > > 
> > > > > $ make install-dev PREFIX="${HOME}/ovirt-engine"
> > > > > EXTRA_BUILD_FLAGS_DEV="-Pgwtdev"
> > > > > 
> > > > > And connect eclipse using the standard jboss debug port.
> > > > > 
> > > > > But I know nothing of GWT, I will appreciate help in that...
> > > > > 
> > > > > How do we connect to a running instance of jboss and debug gwt, what
> > > > > setting
> > > > > should we have?
> > > 
> > > Hi Alex,
> > > 
> > > > Once you have the engine up and running as explained about, you can
> > > > use
> > > > http://www.ovirt.org/DebugFrontend to run GWT debugging. You can
> > > > safely
> > > > skip step 0
> > > > in that document (I think that needs to be updated). And start at step
> > > > 1.
> > > > The document explains quite well what to do, but the short version is:
> > > > 
> > > > 1. cd into the source code directory of either webadmin or user
> > > > portal.
> > > > Usually: ovirt-
> > > > engine/frontend/webadmin/modules/(webadmin or userportal-gwtp)
> > > > 2. mvn gwt:debug -Pgwtdev,gwt-admin,gwt-user -Dgwt.noserver=true from
> > > > the
> > > > command line. Once it is done compiling it will tell you it is
> > > > listening
> > > > on
> > > > port 8000.
> > > 
> > > This will not run as jboss, right?
> > 
> > No it is a normal java application (The GWT debugger).
> > 
> > > Or you mean it will run on the jboss of the legacy (not the new
> > > environment). I would like a solution in which we can use the already
> > > running jboss instance that use for production in order to debug gwt. Is
> > > that possible?
> > > I guess some properties need to be passed, or new modules.
> > > 
> > > Thanks!
> > 
> > The GWT debugger is completely agnostic with regards to what serves the
> > host page. The GWT debugger is connected to the browser, not the server.
> > The host page can be served from a local JBOSS, a remote Apache, a file,
> > whatever. The GWT debugger doesn't care as it is talking to the browser.
> 
> Can you please explain this text from the wiki:
> 
> gwt.noserver tells Development Mode that the application is already deployed
> on JBoss AS (don't use embedded Jetty instance to serve application
> content)
> 

There are different ways of using the GWT debug mode. One of the ways is to 
have the GWT debugger spin up an instance of jetty and have your web 
application deployed in it. Then have it launch a browser with the appropriate 
url in it. Adding the --gwt.noserver on the command line tells GWT you don't 
want to spin up the jetty server, that the application you are working with is 
somewhere else and you will manually go to it.

> Or this:
> 
> Q: Client-side logs are not persisted on Engine, e.g.
> $JBOSS_HOME/standalone/log/engine/engine-ui.log. A: Currently, client-side
> logs are enabled only when debugging the application via Development Mode.
> 

When the application is running normally it is all just javascript running in 
the browser. There are 'log' statements in the code but no loggers to write 
the data to. When you are connected to the browser with the GWT debugger the 
GWT debugger provides a logger to write to.

> What listens on port 8700?

In the old environment JBOSS. in the new environment nothing as JBOSS is 
listening on 8080 and 8443

> 
> Thanks!
> 
> > IMO the only thing we could do to improve this is update the make file to
> > provide a target to start the debugger, which basically just calls maven
> > with the appropriate parameters.
> > 
> > > > 3.In eclipse (or your favorite java IDE) make a remote java
> > > > application
> > > > connection to
> > > > port 8000
> > > > 4. Once connected this will open up a GWT debug window.
> > > > 5. In your browser as ?gwt.codesvr=127.0.0.1:9997 to the url you are
> > > > working with and
> > > > refresh the page.
> > > > 6. It will either ask you to install the plugin in your browser or
> > > > load
> > > > the
> > > > page depending
> > > > on if you have the plugin already.
> > > > 
> > > > Alexander
> > > > 
> > > > > Thanks!
> > > > > 
> > > > > > At 2013-06-07 14:55:41,"Alon Bar-Lev" <alonbl at redhat.com> wrote:
> > > > > > >----- Original Message -----
> > > > > > >
> > > > > > >> From: "bigclouds" <bigclouds at 163.com>
> > > > > > >> To: "Eli Mesika" <emesika at redhat.com>
> > > > > > >> Cc: "engine-devel" <engine-devel at ovirt.org>
> > > > > > >> Sent: Friday, June 7, 2013 3:49:15 AM
> > > > > > >> Subject: Re: [Engine-devel] if there is a updated debug
> > > > > > >> environment
> > > > > > >> how
> > > > > > >> to?
> > > > > > >> 
> > > > > > >> hi:
> > > > > > >> there is error when engine-setup-2. finally only 8702 and 8703
> > > > > > >> port
> > > > > > >> is
> > > > > > >> in
> > > > > > >> listen state.
> > > > > > >> i can not visit 8080 via browser.
> > > > > > >
> > > > > > >Well, if setup fails... probably application won't work.
> > > > > > >
> > > > > > >> engine-setup-2 ?
> > > > > > >> [ INFO  ] Creating CA
> > > > > > >> [ INFO  ] Creating database schema
> > > > > > >> [ ERROR ] Failed to execute stage 'Misc configuration': Command
> > > > > > >> '/home/best/ovirt-engine/share/ovirt-engine/dbscripts/create_sc
> > > > > > >> hema
> > > > > > >> .sh'
> > > > > > >> failed to execute
> > > > > > >> [ INFO  ] Stage: Clean up
> > > > > > >> Log file is located at
> > > > > > >> /tmp/ovirt-engine-setup-20130606172206.log
> > > > > > >
> > > > > > >What database have you  used?
> > > > > > >If you don't have anything important there, can you please try to
> > > > > > >initialize it so you start fresh?
> > > > > > >
> > > > > > ># systemctl stop postgresql.service
> > > > > > ># rm -fr /var/lib/pgsql
> > > > > > ># postgresql-setup initdb
> > > > > > ># vi /var/lib/pgsql/data/pg_hba.conf
> > > > > > >modify 127.0.0.1/32 and ::1/128 lines to password at last field
> > > > > > ># su - postgres -c psql -d template1
> > > > > > >template1=# create user engine password 'engine';
> > > > > > >template1=# create database engine owner engine;
> > > > > > ># \q
> > > > > > >
> > > > > > >> At 2013-06-06 05:17:07,"Eli Mesika" <emesika at redhat.com> wrote:
> > > > > > >> >----- Original Message -----
> > > > > > >> >
> > > > > > >> >> From: "bigclouds" <bigclouds at 163.com>
> > > > > > >> >> To: "engine-devel" <engine-devel at ovirt.org>
> > > > > > >> >> Sent: Wednesday, June 5, 2013 12:34:30 PM
> > > > > > >> >> Subject: [Engine-devel] if there is a updated debug
> > > > > > >> >> environment
> > > > > > >> >> how
> > > > > > >> >> to?
> > > > > > >> >> 
> > > > > > >> >> hi, engine guys:
> > > > > > >> >> i want to make a engine debug environment for a looong time,
> > > > > > >> >> due
> > > > > > >> >> to
> > > > > > >> >> all
> > > > > > >> >> 
> > > > > > >> >>  kinds
> > > > > > >> >> 
> > > > > > >> >> of reasons i have not made it.
> > > > > > >> >> now i still have the need for a debug environment. (it seems
> > > > > > >> >> like
> > > > > > >> >> that
> > > > > > >> >> i
> > > > > > >> >> 
> > > > > > >> >>  am
> > > > > > >> >> 
> > > > > > >> >> keeped away from you all)
> > > > > > >> >> if there is a updated doc for building engine debug
> > > > > > >> >> environment?
> > > > > > >> >> thanks so much.
> > > > > > >> >
> > > > > > >> >Please follow Allon's B L doc on how to create a development
> > > > > > >> >environment
> > > > > > >> >
> > > > > > >> >http://www.ovirt.org/OVirt_Engine_Development_Environment
> > > > > > >> >
> > > > > > >> >> _______________________________________________
> > > > > > >> >> Engine-devel mailing list
> > > > > > >> >> Engine-devel at ovirt.org
> > > > > > >> >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > > > >> 
> > > > > > >> _______________________________________________


From alonbl at redhat.com  Fri Jun  7 19:20:11 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Fri, 7 Jun 2013 15:20:11 -0400 (EDT)
Subject: [Engine-devel] if there is a updated debug environment how to?
In-Reply-To: <4614483.AH5sPLafxW@awels>
References: <1f1cccaa.c254.13f13b00539.Coremail.bigclouds@163.com>
	<1468524.dLY0xj14LH@awels>
	<1702507006.7776617.1370622130138.JavaMail.root@redhat.com>
	<4614483.AH5sPLafxW@awels>
Message-ID: <207290581.7830430.1370632811036.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Alexander Wels" <awels at redhat.com>
> To: "Alon Bar-Lev" <alonbl at redhat.com>
> Cc: engine-devel at ovirt.org, "bigclouds" <bigclouds at 163.com>
> Sent: Friday, June 7, 2013 8:35:27 PM
> Subject: Re: [Engine-devel] if there is a updated debug environment how to?
> 
> On Friday, June 07, 2013 12:22:10 PM Alon Bar-Lev wrote:
> > ----- Original Message -----
> > 
> > > From: "Alexander Wels" <awels at redhat.com>
> > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > Cc: engine-devel at ovirt.org, "bigclouds" <bigclouds at 163.com>
> > > Sent: Friday, June 7, 2013 4:14:59 PM
> > > Subject: Re: [Engine-devel] if there is a updated debug environment how
> > > to?
> > > 
> > > On Friday, June 07, 2013 08:26:32 AM Alon Bar-Lev wrote:
> > > > ----- Original Message -----
> > > > 
> > > > > From: "Alexander Wels" <awels at redhat.com>
> > > > > To: engine-devel at ovirt.org
> > > > > Cc: "Alon Bar-Lev" <alonbl at redhat.com>, "bigclouds"
> > > > > <bigclouds at 163.com>
> > > > > Sent: Friday, June 7, 2013 3:09:19 PM
> > > > > Subject: Re: [Engine-devel] if there is a updated debug environment
> > > > > how
> > > > > to?
> > > > > 
> > > > > On Friday, June 07, 2013 03:46:12 AM Alon Bar-Lev wrote:
> > > > > > ----- Original Message -----
> > > > > > 
> > > > > > > From: "bigclouds" <bigclouds at 163.com>
> > > > > > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > > > > > Cc: "Eli Mesika" <emesika at redhat.com>, "engine-devel"
> > > > > > > <engine-devel at ovirt.org> Sent: Friday, June 7, 2013 10:29:25 AM
> > > > > > > Subject: Re:Re: [Engine-devel] if there is a updated debug
> > > > > > > environment
> > > > > > > how
> > > > > > > to?
> > > > > > > 
> > > > > > > so many thinks,i  finally make it.
> > > > > > > 
> > > > > > > if i can debug gwt  in this environment?  and how?
> > > > > > > 
> > > > > > > 
> > > > > > > if this link is still in use, http://www.ovirt.org/DebugFrontend
> > > > > > > 
> > > > > > > thanks.
> > > > > > 
> > > > > > This is interesting, I would like to work with someone that knows
> > > > > > GWT
> > > > > > to
> > > > > > make this happen.
> > > > > > 
> > > > > > If I read this correctly, all you need to do is:
> > > > > > 
> > > > > > $ make install-dev PREFIX="${HOME}/ovirt-engine"
> > > > > > EXTRA_BUILD_FLAGS_DEV="-Pgwtdev"
> > > > > > 
> > > > > > And connect eclipse using the standard jboss debug port.
> > > > > > 
> > > > > > But I know nothing of GWT, I will appreciate help in that...
> > > > > > 
> > > > > > How do we connect to a running instance of jboss and debug gwt,
> > > > > > what
> > > > > > setting
> > > > > > should we have?
> > > > 
> > > > Hi Alex,
> > > > 
> > > > > Once you have the engine up and running as explained about, you can
> > > > > use
> > > > > http://www.ovirt.org/DebugFrontend to run GWT debugging. You can
> > > > > safely
> > > > > skip step 0
> > > > > in that document (I think that needs to be updated). And start at
> > > > > step
> > > > > 1.
> > > > > The document explains quite well what to do, but the short version
> > > > > is:
> > > > > 
> > > > > 1. cd into the source code directory of either webadmin or user
> > > > > portal.
> > > > > Usually: ovirt-
> > > > > engine/frontend/webadmin/modules/(webadmin or userportal-gwtp)
> > > > > 2. mvn gwt:debug -Pgwtdev,gwt-admin,gwt-user -Dgwt.noserver=true from
> > > > > the
> > > > > command line. Once it is done compiling it will tell you it is
> > > > > listening
> > > > > on
> > > > > port 8000.
> > > > 
> > > > This will not run as jboss, right?
> > > 
> > > No it is a normal java application (The GWT debugger).
> > > 
> > > > Or you mean it will run on the jboss of the legacy (not the new
> > > > environment). I would like a solution in which we can use the already
> > > > running jboss instance that use for production in order to debug gwt.
> > > > Is
> > > > that possible?
> > > > I guess some properties need to be passed, or new modules.
> > > > 
> > > > Thanks!
> > > 
> > > The GWT debugger is completely agnostic with regards to what serves the
> > > host page. The GWT debugger is connected to the browser, not the server.
> > > The host page can be served from a local JBOSS, a remote Apache, a file,
> > > whatever. The GWT debugger doesn't care as it is talking to the browser.
> > 
> > Can you please explain this text from the wiki:
> > 
> > gwt.noserver tells Development Mode that the application is already
> > deployed
> > on JBoss AS (don't use embedded Jetty instance to serve application
> > content)
> > 
> 
> There are different ways of using the GWT debug mode. One of the ways is to
> have the GWT debugger spin up an instance of jetty and have your web
> application deployed in it. Then have it launch a browser with the
> appropriate
> url in it. Adding the --gwt.noserver on the command line tells GWT you don't
> want to spin up the jetty server, that the application you are working with
> is
> somewhere else and you will manually go to it.
> 
> > Or this:
> > 
> > Q: Client-side logs are not persisted on Engine, e.g.
> > $JBOSS_HOME/standalone/log/engine/engine-ui.log. A: Currently, client-side
> > logs are enabled only when debugging the application via Development Mode.
> > 
> 
> When the application is running normally it is all just javascript running in
> the browser. There are 'log' statements in the code but no loggers to write
> the data to. When you are connected to the browser with the GWT debugger the
> GWT debugger provides a logger to write to.

So how did it reached to the jboss-as log?
Should I add configuration to jboss logging to have this?

> 
> > What listens on port 8700?
> 
> In the old environment JBOSS. in the new environment nothing as JBOSS is
> listening on 8080 and 8443

OK, thanks.

So if I understand correctly, the following is sequence is required:

Build and deploy code:
$ make install-dev PREFIX="${HOME}/ovirt-engine"
$ "${HOME}/ovirt-engine/share/ovirt-engine/services/ovirt-engine.py" start

Execute the gwt debugger as standalone
$ mvn gwt:debug -Pgwtdev -Dgwt.noserver=true

Connect eclipse gwt debugger to localhost:8000

Navigate to application, add ?gwt.codesvr=127.0.0.1:9997 as suffix, example:
    WebAdmin:   http://127.0.0.1:8080/webadmin/webadmin/WebAdmin.html?gwt.codesvr=127.0.0.1:9997
    UserPortal: http://127.0.0.1:8080/UserPortal/org.ovirt.engine.ui.userportal.UserPortal/UserPortal.html?gwt.codesvr=127.0.0.1:9997 

In other words, it should not be required to re-compile the code to execute the debugger... as environment is fully deployed.

Well, the above sequence is not working, I wounder what I miss in principal... the mvn gwt:debug complains about:
[ERROR] Failed to execute goal org.codehaus.mojo:gwt-maven-plugin:2.3.0:debug (default-cli) on project webadmin: The parameters 'runTarget' for goal org.codehaus.mojo:gwt-maven-plugin:2.3.0:debug are missing or invalid -> [Help 1]

Thanks!

> 
> > 
> > Thanks!
> > 
> > > IMO the only thing we could do to improve this is update the make file to
> > > provide a target to start the debugger, which basically just calls maven
> > > with the appropriate parameters.
> > > 
> > > > > 3.In eclipse (or your favorite java IDE) make a remote java
> > > > > application
> > > > > connection to
> > > > > port 8000
> > > > > 4. Once connected this will open up a GWT debug window.
> > > > > 5. In your browser as ?gwt.codesvr=127.0.0.1:9997 to the url you are
> > > > > working with and
> > > > > refresh the page.
> > > > > 6. It will either ask you to install the plugin in your browser or
> > > > > load
> > > > > the
> > > > > page depending
> > > > > on if you have the plugin already.
> > > > > 
> > > > > Alexander
> > > > > 
> > > > > > Thanks!
> > > > > > 
> > > > > > > At 2013-06-07 14:55:41,"Alon Bar-Lev" <alonbl at redhat.com> wrote:
> > > > > > > >----- Original Message -----
> > > > > > > >
> > > > > > > >> From: "bigclouds" <bigclouds at 163.com>
> > > > > > > >> To: "Eli Mesika" <emesika at redhat.com>
> > > > > > > >> Cc: "engine-devel" <engine-devel at ovirt.org>
> > > > > > > >> Sent: Friday, June 7, 2013 3:49:15 AM
> > > > > > > >> Subject: Re: [Engine-devel] if there is a updated debug
> > > > > > > >> environment
> > > > > > > >> how
> > > > > > > >> to?
> > > > > > > >> 
> > > > > > > >> hi:
> > > > > > > >> there is error when engine-setup-2. finally only 8702 and 8703
> > > > > > > >> port
> > > > > > > >> is
> > > > > > > >> in
> > > > > > > >> listen state.
> > > > > > > >> i can not visit 8080 via browser.
> > > > > > > >
> > > > > > > >Well, if setup fails... probably application won't work.
> > > > > > > >
> > > > > > > >> engine-setup-2 ?
> > > > > > > >> [ INFO  ] Creating CA
> > > > > > > >> [ INFO  ] Creating database schema
> > > > > > > >> [ ERROR ] Failed to execute stage 'Misc configuration':
> > > > > > > >> Command
> > > > > > > >> '/home/best/ovirt-engine/share/ovirt-engine/dbscripts/create_sc
> > > > > > > >> hema
> > > > > > > >> .sh'
> > > > > > > >> failed to execute
> > > > > > > >> [ INFO  ] Stage: Clean up
> > > > > > > >> Log file is located at
> > > > > > > >> /tmp/ovirt-engine-setup-20130606172206.log
> > > > > > > >
> > > > > > > >What database have you  used?
> > > > > > > >If you don't have anything important there, can you please try
> > > > > > > >to
> > > > > > > >initialize it so you start fresh?
> > > > > > > >
> > > > > > > ># systemctl stop postgresql.service
> > > > > > > ># rm -fr /var/lib/pgsql
> > > > > > > ># postgresql-setup initdb
> > > > > > > ># vi /var/lib/pgsql/data/pg_hba.conf
> > > > > > > >modify 127.0.0.1/32 and ::1/128 lines to password at last field
> > > > > > > ># su - postgres -c psql -d template1
> > > > > > > >template1=# create user engine password 'engine';
> > > > > > > >template1=# create database engine owner engine;
> > > > > > > ># \q
> > > > > > > >
> > > > > > > >> At 2013-06-06 05:17:07,"Eli Mesika" <emesika at redhat.com>
> > > > > > > >> wrote:
> > > > > > > >> >----- Original Message -----
> > > > > > > >> >
> > > > > > > >> >> From: "bigclouds" <bigclouds at 163.com>
> > > > > > > >> >> To: "engine-devel" <engine-devel at ovirt.org>
> > > > > > > >> >> Sent: Wednesday, June 5, 2013 12:34:30 PM
> > > > > > > >> >> Subject: [Engine-devel] if there is a updated debug
> > > > > > > >> >> environment
> > > > > > > >> >> how
> > > > > > > >> >> to?
> > > > > > > >> >> 
> > > > > > > >> >> hi, engine guys:
> > > > > > > >> >> i want to make a engine debug environment for a looong
> > > > > > > >> >> time,
> > > > > > > >> >> due
> > > > > > > >> >> to
> > > > > > > >> >> all
> > > > > > > >> >> 
> > > > > > > >> >>  kinds
> > > > > > > >> >> 
> > > > > > > >> >> of reasons i have not made it.
> > > > > > > >> >> now i still have the need for a debug environment. (it
> > > > > > > >> >> seems
> > > > > > > >> >> like
> > > > > > > >> >> that
> > > > > > > >> >> i
> > > > > > > >> >> 
> > > > > > > >> >>  am
> > > > > > > >> >> 
> > > > > > > >> >> keeped away from you all)
> > > > > > > >> >> if there is a updated doc for building engine debug
> > > > > > > >> >> environment?
> > > > > > > >> >> thanks so much.
> > > > > > > >> >
> > > > > > > >> >Please follow Allon's B L doc on how to create a development
> > > > > > > >> >environment
> > > > > > > >> >
> > > > > > > >> >http://www.ovirt.org/OVirt_Engine_Development_Environment
> > > > > > > >> >
> > > > > > > >> >> _______________________________________________
> > > > > > > >> >> Engine-devel mailing list
> > > > > > > >> >> Engine-devel at ovirt.org
> > > > > > > >> >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > > > > >> 
> > > > > > > >> _______________________________________________
> 


From awels at redhat.com  Fri Jun  7 19:27:54 2013
From: awels at redhat.com (Alexander Wels)
Date: Fri, 07 Jun 2013 15:27:54 -0400
Subject: [Engine-devel] if there is a updated debug environment how to?
In-Reply-To: <207290581.7830430.1370632811036.JavaMail.root@redhat.com>
References: <1f1cccaa.c254.13f13b00539.Coremail.bigclouds@163.com>
	<4614483.AH5sPLafxW@awels>
	<207290581.7830430.1370632811036.JavaMail.root@redhat.com>
Message-ID: <19879316.JsIC89Exdp@awels>

On Friday, June 07, 2013 03:20:11 PM Alon Bar-Lev wrote:
> ----- Original Message -----
> 
> > From: "Alexander Wels" <awels at redhat.com>
> > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > Cc: engine-devel at ovirt.org, "bigclouds" <bigclouds at 163.com>
> > Sent: Friday, June 7, 2013 8:35:27 PM
> > Subject: Re: [Engine-devel] if there is a updated debug environment how
> > to?
> > 
> > On Friday, June 07, 2013 12:22:10 PM Alon Bar-Lev wrote:
> > > ----- Original Message -----
> > > 
> > > > From: "Alexander Wels" <awels at redhat.com>
> > > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > > Cc: engine-devel at ovirt.org, "bigclouds" <bigclouds at 163.com>
> > > > Sent: Friday, June 7, 2013 4:14:59 PM
> > > > Subject: Re: [Engine-devel] if there is a updated debug environment
> > > > how
> > > > to?
> > > > 
> > > > On Friday, June 07, 2013 08:26:32 AM Alon Bar-Lev wrote:
> > > > > ----- Original Message -----
> > > > > 
> > > > > > From: "Alexander Wels" <awels at redhat.com>
> > > > > > To: engine-devel at ovirt.org
> > > > > > Cc: "Alon Bar-Lev" <alonbl at redhat.com>, "bigclouds"
> > > > > > <bigclouds at 163.com>
> > > > > > Sent: Friday, June 7, 2013 3:09:19 PM
> > > > > > Subject: Re: [Engine-devel] if there is a updated debug
> > > > > > environment
> > > > > > how
> > > > > > to?
> > > > > > 
> > > > > > On Friday, June 07, 2013 03:46:12 AM Alon Bar-Lev wrote:
> > > > > > > ----- Original Message -----
> > > > > > > 
> > > > > > > > From: "bigclouds" <bigclouds at 163.com>
> > > > > > > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > > > > > > Cc: "Eli Mesika" <emesika at redhat.com>, "engine-devel"
> > > > > > > > <engine-devel at ovirt.org> Sent: Friday, June 7, 2013 10:29:25
> > > > > > > > AM
> > > > > > > > Subject: Re:Re: [Engine-devel] if there is a updated debug
> > > > > > > > environment
> > > > > > > > how
> > > > > > > > to?
> > > > > > > > 
> > > > > > > > so many thinks,i  finally make it.
> > > > > > > > 
> > > > > > > > if i can debug gwt  in this environment?  and how?
> > > > > > > > 
> > > > > > > > 
> > > > > > > > if this link is still in use,
> > > > > > > > http://www.ovirt.org/DebugFrontend
> > > > > > > > 
> > > > > > > > thanks.
> > > > > > > 
> > > > > > > This is interesting, I would like to work with someone that
> > > > > > > knows
> > > > > > > GWT
> > > > > > > to
> > > > > > > make this happen.
> > > > > > > 
> > > > > > > If I read this correctly, all you need to do is:
> > > > > > > 
> > > > > > > $ make install-dev PREFIX="${HOME}/ovirt-engine"
> > > > > > > EXTRA_BUILD_FLAGS_DEV="-Pgwtdev"
> > > > > > > 
> > > > > > > And connect eclipse using the standard jboss debug port.
> > > > > > > 
> > > > > > > But I know nothing of GWT, I will appreciate help in that...
> > > > > > > 
> > > > > > > How do we connect to a running instance of jboss and debug gwt,
> > > > > > > what
> > > > > > > setting
> > > > > > > should we have?
> > > > > 
> > > > > Hi Alex,
> > > > > 
> > > > > > Once you have the engine up and running as explained about, you
> > > > > > can
> > > > > > use
> > > > > > http://www.ovirt.org/DebugFrontend to run GWT debugging. You can
> > > > > > safely
> > > > > > skip step 0
> > > > > > in that document (I think that needs to be updated). And start at
> > > > > > step
> > > > > > 1.
> > > > > > The document explains quite well what to do, but the short version
> > > > > > is:
> > > > > > 
> > > > > > 1. cd into the source code directory of either webadmin or user
> > > > > > portal.
> > > > > > Usually: ovirt-
> > > > > > engine/frontend/webadmin/modules/(webadmin or userportal-gwtp)
> > > > > > 2. mvn gwt:debug -Pgwtdev,gwt-admin,gwt-user -Dgwt.noserver=true
> > > > > > from
> > > > > > the
> > > > > > command line. Once it is done compiling it will tell you it is
> > > > > > listening
> > > > > > on
> > > > > > port 8000.
> > > > > 
> > > > > This will not run as jboss, right?
> > > > 
> > > > No it is a normal java application (The GWT debugger).
> > > > 
> > > > > Or you mean it will run on the jboss of the legacy (not the new
> > > > > environment). I would like a solution in which we can use the
> > > > > already
> > > > > running jboss instance that use for production in order to debug
> > > > > gwt.
> > > > > Is
> > > > > that possible?
> > > > > I guess some properties need to be passed, or new modules.
> > > > > 
> > > > > Thanks!
> > > > 
> > > > The GWT debugger is completely agnostic with regards to what serves
> > > > the
> > > > host page. The GWT debugger is connected to the browser, not the
> > > > server.
> > > > The host page can be served from a local JBOSS, a remote Apache, a
> > > > file,
> > > > whatever. The GWT debugger doesn't care as it is talking to the
> > > > browser.
> > > 
> > > Can you please explain this text from the wiki:
> > > 
> > > gwt.noserver tells Development Mode that the application is already
> > > deployed
> > > on JBoss AS (don't use embedded Jetty instance to serve application
> > > content)
> > 
> > There are different ways of using the GWT debug mode. One of the ways is
> > to
> > have the GWT debugger spin up an instance of jetty and have your web
> > application deployed in it. Then have it launch a browser with the
> > appropriate
> > url in it. Adding the --gwt.noserver on the command line tells GWT you
> > don't want to spin up the jetty server, that the application you are
> > working with is
> > somewhere else and you will manually go to it.
> > 
> > > Or this:
> > > 
> > > Q: Client-side logs are not persisted on Engine, e.g.
> > > $JBOSS_HOME/standalone/log/engine/engine-ui.log. A: Currently,
> > > client-side
> > > logs are enabled only when debugging the application via Development
> > > Mode.
> > 
> > When the application is running normally it is all just javascript running
> > in the browser. There are 'log' statements in the code but no loggers to
> > write the data to. When you are connected to the browser with the GWT
> > debugger the GWT debugger provides a logger to write to.
> 
> So how did it reached to the jboss-as log?
> Should I add configuration to jboss logging to have this?
> 
> > > What listens on port 8700?
> > 
> > In the old environment JBOSS. in the new environment nothing as JBOSS is
> > listening on 8080 and 8443
> 
> OK, thanks.
> 
> So if I understand correctly, the following is sequence is required:
> 
> Build and deploy code:
> $ make install-dev PREFIX="${HOME}/ovirt-engine"
> $ "${HOME}/ovirt-engine/share/ovirt-engine/services/ovirt-engine.py" start
> 

 You missed this part:
1. cd into the source code directory of either webadmin or user portal.
you have to change directory to either frontend/webadmin/modules/webadmin or 
frontend/webadmin/modules/userportal-gwtp

As the maven gwt plugin is only defined in the webadmin and userportal poms and 
not in the root pom.

> Execute the gwt debugger as standalone
> $ mvn gwt:debug -Pgwtdev -Dgwt.noserver=true
> 
> Connect eclipse gwt debugger to localhost:8000
> 
> Navigate to application, add ?gwt.codesvr=127.0.0.1:9997 as suffix, example:
> WebAdmin:  
> http://127.0.0.1:8080/webadmin/webadmin/WebAdmin.html?gwt.codesvr=127.0.0.1
> :9997 UserPortal:
> http://127.0.0.1:8080/UserPortal/org.ovirt.engine.ui.userportal.UserPortal/
> UserPortal.html?gwt.codesvr=127.0.0.1:9997
> 
> In other words, it should not be required to re-compile the code to execute
> the debugger... as environment is fully deployed.
> 

> Well, the above sequence is not working, I wounder what I miss in
> principal... the mvn gwt:debug complains about: [ERROR] Failed to execute
> goal org.codehaus.mojo:gwt-maven-plugin:2.3.0:debug (default-cli) on
> project webadmin: The parameters 'runTarget' for goal
> org.codehaus.mojo:gwt-maven-plugin:2.3.0:debug are missing or invalid ->
> [Help 1]
> 
> Thanks!
> 
> > > Thanks!
> > > 
> > > > IMO the only thing we could do to improve this is update the make file
> > > > to
> > > > provide a target to start the debugger, which basically just calls
> > > > maven
> > > > with the appropriate parameters.
> > > > 
> > > > > > 3.In eclipse (or your favorite java IDE) make a remote java
> > > > > > application
> > > > > > connection to
> > > > > > port 8000
> > > > > > 4. Once connected this will open up a GWT debug window.
> > > > > > 5. In your browser as ?gwt.codesvr=127.0.0.1:9997 to the url you
> > > > > > are
> > > > > > working with and
> > > > > > refresh the page.
> > > > > > 6. It will either ask you to install the plugin in your browser or
> > > > > > load
> > > > > > the
> > > > > > page depending
> > > > > > on if you have the plugin already.
> > > > > > 
> > > > > > Alexander
> > > > > > 
> > > > > > > Thanks!
> > > > > > > 
> > > > > > > > At 2013-06-07 14:55:41,"Alon Bar-Lev" <alonbl at redhat.com> 
wrote:
> > > > > > > > >----- Original Message -----
> > > > > > > > >
> > > > > > > > >> From: "bigclouds" <bigclouds at 163.com>
> > > > > > > > >> To: "Eli Mesika" <emesika at redhat.com>
> > > > > > > > >> Cc: "engine-devel" <engine-devel at ovirt.org>
> > > > > > > > >> Sent: Friday, June 7, 2013 3:49:15 AM
> > > > > > > > >> Subject: Re: [Engine-devel] if there is a updated debug
> > > > > > > > >> environment
> > > > > > > > >> how
> > > > > > > > >> to?
> > > > > > > > >> 
> > > > > > > > >> hi:
> > > > > > > > >> there is error when engine-setup-2. finally only 8702 and
> > > > > > > > >> 8703
> > > > > > > > >> port
> > > > > > > > >> is
> > > > > > > > >> in
> > > > > > > > >> listen state.
> > > > > > > > >> i can not visit 8080 via browser.
> > > > > > > > >
> > > > > > > > >Well, if setup fails... probably application won't work.
> > > > > > > > >
> > > > > > > > >> engine-setup-2 ?
> > > > > > > > >> [ INFO  ] Creating CA
> > > > > > > > >> [ INFO  ] Creating database schema
> > > > > > > > >> [ ERROR ] Failed to execute stage 'Misc configuration':
> > > > > > > > >> Command
> > > > > > > > >> '/home/best/ovirt-engine/share/ovirt-engine/dbscripts/creat
> > > > > > > > >> e_sc
> > > > > > > > >> hema
> > > > > > > > >> .sh'
> > > > > > > > >> failed to execute
> > > > > > > > >> [ INFO  ] Stage: Clean up
> > > > > > > > >> Log file is located at
> > > > > > > > >> /tmp/ovirt-engine-setup-20130606172206.log
> > > > > > > > >
> > > > > > > > >What database have you  used?
> > > > > > > > >If you don't have anything important there, can you please
> > > > > > > > >try
> > > > > > > > >to
> > > > > > > > >initialize it so you start fresh?
> > > > > > > > >
> > > > > > > > ># systemctl stop postgresql.service
> > > > > > > > ># rm -fr /var/lib/pgsql
> > > > > > > > ># postgresql-setup initdb
> > > > > > > > ># vi /var/lib/pgsql/data/pg_hba.conf
> > > > > > > > >modify 127.0.0.1/32 and ::1/128 lines to password at last
> > > > > > > > >field
> > > > > > > > ># su - postgres -c psql -d template1
> > > > > > > > >template1=# create user engine password 'engine';
> > > > > > > > >template1=# create database engine owner engine;
> > > > > > > > ># \q
> > > > > > > > >
> > > > > > > > >> At 2013-06-06 05:17:07,"Eli Mesika" <emesika at redhat.com>
> > > > > > > > >> 
> > > > > > > > >> wrote:
> > > > > > > > >> >----- Original Message -----
> > > > > > > > >> >
> > > > > > > > >> >> From: "bigclouds" <bigclouds at 163.com>
> > > > > > > > >> >> To: "engine-devel" <engine-devel at ovirt.org>
> > > > > > > > >> >> Sent: Wednesday, June 5, 2013 12:34:30 PM
> > > > > > > > >> >> Subject: [Engine-devel] if there is a updated debug
> > > > > > > > >> >> environment
> > > > > > > > >> >> how
> > > > > > > > >> >> to?
> > > > > > > > >> >> 
> > > > > > > > >> >> hi, engine guys:
> > > > > > > > >> >> i want to make a engine debug environment for a looong
> > > > > > > > >> >> time,
> > > > > > > > >> >> due
> > > > > > > > >> >> to
> > > > > > > > >> >> all
> > > > > > > > >> >> 
> > > > > > > > >> >>  kinds
> > > > > > > > >> >> 
> > > > > > > > >> >> of reasons i have not made it.
> > > > > > > > >> >> now i still have the need for a debug environment. (it
> > > > > > > > >> >> seems
> > > > > > > > >> >> like
> > > > > > > > >> >> that
> > > > > > > > >> >> i
> > > > > > > > >> >> 
> > > > > > > > >> >>  am
> > > > > > > > >> >> 
> > > > > > > > >> >> keeped away from you all)
> > > > > > > > >> >> if there is a updated doc for building engine debug
> > > > > > > > >> >> environment?
> > > > > > > > >> >> thanks so much.
> > > > > > > > >> >
> > > > > > > > >> >Please follow Allon's B L doc on how to create a
> > > > > > > > >> >development
> > > > > > > > >> >environment
> > > > > > > > >> >
> > > > > > > > >> >http://www.ovirt.org/OVirt_Engine_Development_Environment
> > > > > > > > >> >
> > > > > > > > >> >> _______________________________________________
> > > > > > > > >> >> Engine-devel mailing list
> > > > > > > > >> >> Engine-devel at ovirt.org
> > > > > > > > >> >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > > > > > >> 
> > > > > > > > >> _______________________________________________


From eedri at redhat.com  Fri Jun  7 19:36:02 2013
From: eedri at redhat.com (Eyal Edri)
Date: Fri, 7 Jun 2013 15:36:02 -0400 (EDT)
Subject: [Engine-devel] [oVirt Jenkins] ovirt_engine_find_bugs - Build #
 4393 - Still Unstable!
In-Reply-To: <1562314012.5620.1370607000581.JavaMail.jenkins@jenkins.ovirt.org>
References: <1852944023.5603.1370598531001.JavaMail.jenkins@jenkins.ovirt.org>
	<1562314012.5620.1370607000581.JavaMail.jenkins@jenkins.ovirt.org>
Message-ID: <329930531.186757.1370633762080.JavaMail.root@redhat.com>

fyi,

your last commits add NORAMAL & HIGH priority FINDBUGS issues.

please resolve asap.

http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4389/changes#detail

Eyal.

----- Original Message -----
> From: "Jenkins ci oVirt Server" <jenkins at ovirt.org>
> To: eedri at redhat.com, yzaslavs at redhat.com, dcaro at redhat.com, "juan hernandez" <juan.hernandez at redhat.com>
> Sent: Friday, June 7, 2013 3:09:59 PM
> Subject: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4393 - Still Unstable!
> 
> Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
> Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4393/
> Build Number: 4393
> Build Status:  Still Unstable
> Triggered By: Started by an SCM change
> 
> -------------------------------------
> Changes Since Last Success:
> -------------------------------------
> Changes for Build #4389
> [Shahar Havivi] findbugs: resultSet is not close after use
> 
> [Shahar Havivi] findbugs: inaccurate floating point comparison
> 
> [Shahar Havivi] findbugs: Unwritten public fields
> 
> [Alona Kaplan] engine: multiple gateways
> 
> 
> Changes for Build #4390
> [Alon Bar-Lev] novnc: no need to raise terminate exception on termination
> 
> 
> Changes for Build #4391
> [Alon Bar-Lev] novnc: cleanup defaults file
> 
> [Alon Bar-Lev] novnc: log file is actually trace file
> 
> [Alon Bar-Lev] novnc: override get_target instead of new_client
> 
> [Alon Bar-Lev] novnc: use service debug instead of configuration
> 
> [Alon Bar-Lev] packaging: service: add debug when module returns
> 
> 
> Changes for Build #4392
> [Sahina Bose] engine: Multiple gateways test failure fixed
> 
> 
> Changes for Build #4393
> [Juan Hernandez] core: Make GUID encoders singletons
> 
> 
> 
> 
> -----------------
> Failed Tests:
> -----------------
> No tests ran.
> 
> 


From alonbl at redhat.com  Fri Jun  7 19:51:17 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Fri, 7 Jun 2013 15:51:17 -0400 (EDT)
Subject: [Engine-devel] if there is a updated debug environment how to?
In-Reply-To: <19879316.JsIC89Exdp@awels>
References: <1f1cccaa.c254.13f13b00539.Coremail.bigclouds@163.com>
	<4614483.AH5sPLafxW@awels>
	<207290581.7830430.1370632811036.JavaMail.root@redhat.com>
	<19879316.JsIC89Exdp@awels>
Message-ID: <1179830307.7838122.1370634677541.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Alexander Wels" <awels at redhat.com>
> To: "Alon Bar-Lev" <alonbl at redhat.com>
> Cc: engine-devel at ovirt.org, "bigclouds" <bigclouds at 163.com>
> Sent: Friday, June 7, 2013 10:27:54 PM
> Subject: Re: [Engine-devel] if there is a updated debug environment how to?
> 
> On Friday, June 07, 2013 03:20:11 PM Alon Bar-Lev wrote:
> > ----- Original Message -----
> > 
> > > From: "Alexander Wels" <awels at redhat.com>
> > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > Cc: engine-devel at ovirt.org, "bigclouds" <bigclouds at 163.com>
> > > Sent: Friday, June 7, 2013 8:35:27 PM
> > > Subject: Re: [Engine-devel] if there is a updated debug environment how
> > > to?
> > > 
> > > On Friday, June 07, 2013 12:22:10 PM Alon Bar-Lev wrote:
> > > > ----- Original Message -----
> > > > 
> > > > > From: "Alexander Wels" <awels at redhat.com>
> > > > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > > > Cc: engine-devel at ovirt.org, "bigclouds" <bigclouds at 163.com>
> > > > > Sent: Friday, June 7, 2013 4:14:59 PM
> > > > > Subject: Re: [Engine-devel] if there is a updated debug environment
> > > > > how
> > > > > to?
> > > > > 
> > > > > On Friday, June 07, 2013 08:26:32 AM Alon Bar-Lev wrote:
> > > > > > ----- Original Message -----
> > > > > > 
> > > > > > > From: "Alexander Wels" <awels at redhat.com>
> > > > > > > To: engine-devel at ovirt.org
> > > > > > > Cc: "Alon Bar-Lev" <alonbl at redhat.com>, "bigclouds"
> > > > > > > <bigclouds at 163.com>
> > > > > > > Sent: Friday, June 7, 2013 3:09:19 PM
> > > > > > > Subject: Re: [Engine-devel] if there is a updated debug
> > > > > > > environment
> > > > > > > how
> > > > > > > to?
> > > > > > > 
> > > > > > > On Friday, June 07, 2013 03:46:12 AM Alon Bar-Lev wrote:
> > > > > > > > ----- Original Message -----
> > > > > > > > 
> > > > > > > > > From: "bigclouds" <bigclouds at 163.com>
> > > > > > > > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > > > > > > > Cc: "Eli Mesika" <emesika at redhat.com>, "engine-devel"
> > > > > > > > > <engine-devel at ovirt.org> Sent: Friday, June 7, 2013 10:29:25
> > > > > > > > > AM
> > > > > > > > > Subject: Re:Re: [Engine-devel] if there is a updated debug
> > > > > > > > > environment
> > > > > > > > > how
> > > > > > > > > to?
> > > > > > > > > 
> > > > > > > > > so many thinks,i  finally make it.
> > > > > > > > > 
> > > > > > > > > if i can debug gwt  in this environment?  and how?
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > if this link is still in use,
> > > > > > > > > http://www.ovirt.org/DebugFrontend
> > > > > > > > > 
> > > > > > > > > thanks.
> > > > > > > > 
> > > > > > > > This is interesting, I would like to work with someone that
> > > > > > > > knows
> > > > > > > > GWT
> > > > > > > > to
> > > > > > > > make this happen.
> > > > > > > > 
> > > > > > > > If I read this correctly, all you need to do is:
> > > > > > > > 
> > > > > > > > $ make install-dev PREFIX="${HOME}/ovirt-engine"
> > > > > > > > EXTRA_BUILD_FLAGS_DEV="-Pgwtdev"
> > > > > > > > 
> > > > > > > > And connect eclipse using the standard jboss debug port.
> > > > > > > > 
> > > > > > > > But I know nothing of GWT, I will appreciate help in that...
> > > > > > > > 
> > > > > > > > How do we connect to a running instance of jboss and debug gwt,
> > > > > > > > what
> > > > > > > > setting
> > > > > > > > should we have?
> > > > > > 
> > > > > > Hi Alex,
> > > > > > 
> > > > > > > Once you have the engine up and running as explained about, you
> > > > > > > can
> > > > > > > use
> > > > > > > http://www.ovirt.org/DebugFrontend to run GWT debugging. You can
> > > > > > > safely
> > > > > > > skip step 0
> > > > > > > in that document (I think that needs to be updated). And start at
> > > > > > > step
> > > > > > > 1.
> > > > > > > The document explains quite well what to do, but the short
> > > > > > > version
> > > > > > > is:
> > > > > > > 
> > > > > > > 1. cd into the source code directory of either webadmin or user
> > > > > > > portal.
> > > > > > > Usually: ovirt-
> > > > > > > engine/frontend/webadmin/modules/(webadmin or userportal-gwtp)
> > > > > > > 2. mvn gwt:debug -Pgwtdev,gwt-admin,gwt-user -Dgwt.noserver=true
> > > > > > > from
> > > > > > > the
> > > > > > > command line. Once it is done compiling it will tell you it is
> > > > > > > listening
> > > > > > > on
> > > > > > > port 8000.
> > > > > > 
> > > > > > This will not run as jboss, right?
> > > > > 
> > > > > No it is a normal java application (The GWT debugger).
> > > > > 
> > > > > > Or you mean it will run on the jboss of the legacy (not the new
> > > > > > environment). I would like a solution in which we can use the
> > > > > > already
> > > > > > running jboss instance that use for production in order to debug
> > > > > > gwt.
> > > > > > Is
> > > > > > that possible?
> > > > > > I guess some properties need to be passed, or new modules.
> > > > > > 
> > > > > > Thanks!
> > > > > 
> > > > > The GWT debugger is completely agnostic with regards to what serves
> > > > > the
> > > > > host page. The GWT debugger is connected to the browser, not the
> > > > > server.
> > > > > The host page can be served from a local JBOSS, a remote Apache, a
> > > > > file,
> > > > > whatever. The GWT debugger doesn't care as it is talking to the
> > > > > browser.
> > > > 
> > > > Can you please explain this text from the wiki:
> > > > 
> > > > gwt.noserver tells Development Mode that the application is already
> > > > deployed
> > > > on JBoss AS (don't use embedded Jetty instance to serve application
> > > > content)
> > > 
> > > There are different ways of using the GWT debug mode. One of the ways is
> > > to
> > > have the GWT debugger spin up an instance of jetty and have your web
> > > application deployed in it. Then have it launch a browser with the
> > > appropriate
> > > url in it. Adding the --gwt.noserver on the command line tells GWT you
> > > don't want to spin up the jetty server, that the application you are
> > > working with is
> > > somewhere else and you will manually go to it.
> > > 
> > > > Or this:
> > > > 
> > > > Q: Client-side logs are not persisted on Engine, e.g.
> > > > $JBOSS_HOME/standalone/log/engine/engine-ui.log. A: Currently,
> > > > client-side
> > > > logs are enabled only when debugging the application via Development
> > > > Mode.
> > > 
> > > When the application is running normally it is all just javascript
> > > running
> > > in the browser. There are 'log' statements in the code but no loggers to
> > > write the data to. When you are connected to the browser with the GWT
> > > debugger the GWT debugger provides a logger to write to.
> > 
> > So how did it reached to the jboss-as log?
> > Should I add configuration to jboss logging to have this?
> > 
> > > > What listens on port 8700?
> > > 
> > > In the old environment JBOSS. in the new environment nothing as JBOSS is
> > > listening on 8080 and 8443
> > 
> > OK, thanks.
> > 
> > So if I understand correctly, the following is sequence is required:
> > 
> > Build and deploy code:
> > $ make install-dev PREFIX="${HOME}/ovirt-engine"
> > $ "${HOME}/ovirt-engine/share/ovirt-engine/services/ovirt-engine.py" start
> > 
> 
>  You missed this part:
> 1. cd into the source code directory of either webadmin or user portal.
> you have to change directory to either frontend/webadmin/modules/webadmin or
> frontend/webadmin/modules/userportal-gwtp
> 
> As the maven gwt plugin is only defined in the webadmin and userportal poms
> and
> not in the root pom.

Is there any reason why not to add <something> to root pom?
Activating the debugger should be generic, right, I mean it should not have any dependency with specific module... the fact that we use maven for that is only as a wrapper, right?

> 
> > Execute the gwt debugger as standalone
> > $ mvn gwt:debug -Pgwtdev -Dgwt.noserver=true
> > 
> > Connect eclipse gwt debugger to localhost:8000
> > 
> > Navigate to application, add ?gwt.codesvr=127.0.0.1:9997 as suffix,
> > example:
> > WebAdmin:
> > http://127.0.0.1:8080/webadmin/webadmin/WebAdmin.html?gwt.codesvr=127.0.0.1
> > :9997 UserPortal:
> > http://127.0.0.1:8080/UserPortal/org.ovirt.engine.ui.userportal.UserPortal/
> > UserPortal.html?gwt.codesvr=127.0.0.1:9997
> > 
> > In other words, it should not be required to re-compile the code to execute
> > the debugger... as environment is fully deployed.
> > 
> 
> > Well, the above sequence is not working, I wounder what I miss in
> > principal... the mvn gwt:debug complains about: [ERROR] Failed to execute
> > goal org.codehaus.mojo:gwt-maven-plugin:2.3.0:debug (default-cli) on
> > project webadmin: The parameters 'runTarget' for goal
> > org.codehaus.mojo:gwt-maven-plugin:2.3.0:debug are missing or invalid ->
> > [Help 1]
> > 
> > Thanks!
> > 
> > > > Thanks!
> > > > 
> > > > > IMO the only thing we could do to improve this is update the make
> > > > > file
> > > > > to
> > > > > provide a target to start the debugger, which basically just calls
> > > > > maven
> > > > > with the appropriate parameters.
> > > > > 
> > > > > > > 3.In eclipse (or your favorite java IDE) make a remote java
> > > > > > > application
> > > > > > > connection to
> > > > > > > port 8000
> > > > > > > 4. Once connected this will open up a GWT debug window.
> > > > > > > 5. In your browser as ?gwt.codesvr=127.0.0.1:9997 to the url you
> > > > > > > are
> > > > > > > working with and
> > > > > > > refresh the page.
> > > > > > > 6. It will either ask you to install the plugin in your browser
> > > > > > > or
> > > > > > > load
> > > > > > > the
> > > > > > > page depending
> > > > > > > on if you have the plugin already.
> > > > > > > 
> > > > > > > Alexander
> > > > > > > 
> > > > > > > > Thanks!
> > > > > > > > 
> > > > > > > > > At 2013-06-07 14:55:41,"Alon Bar-Lev" <alonbl at redhat.com>
> wrote:
> > > > > > > > > >----- Original Message -----
> > > > > > > > > >
> > > > > > > > > >> From: "bigclouds" <bigclouds at 163.com>
> > > > > > > > > >> To: "Eli Mesika" <emesika at redhat.com>
> > > > > > > > > >> Cc: "engine-devel" <engine-devel at ovirt.org>
> > > > > > > > > >> Sent: Friday, June 7, 2013 3:49:15 AM
> > > > > > > > > >> Subject: Re: [Engine-devel] if there is a updated debug
> > > > > > > > > >> environment
> > > > > > > > > >> how
> > > > > > > > > >> to?
> > > > > > > > > >> 
> > > > > > > > > >> hi:
> > > > > > > > > >> there is error when engine-setup-2. finally only 8702 and
> > > > > > > > > >> 8703
> > > > > > > > > >> port
> > > > > > > > > >> is
> > > > > > > > > >> in
> > > > > > > > > >> listen state.
> > > > > > > > > >> i can not visit 8080 via browser.
> > > > > > > > > >
> > > > > > > > > >Well, if setup fails... probably application won't work.
> > > > > > > > > >
> > > > > > > > > >> engine-setup-2 ?
> > > > > > > > > >> [ INFO  ] Creating CA
> > > > > > > > > >> [ INFO  ] Creating database schema
> > > > > > > > > >> [ ERROR ] Failed to execute stage 'Misc configuration':
> > > > > > > > > >> Command
> > > > > > > > > >> '/home/best/ovirt-engine/share/ovirt-engine/dbscripts/creat
> > > > > > > > > >> e_sc
> > > > > > > > > >> hema
> > > > > > > > > >> .sh'
> > > > > > > > > >> failed to execute
> > > > > > > > > >> [ INFO  ] Stage: Clean up
> > > > > > > > > >> Log file is located at
> > > > > > > > > >> /tmp/ovirt-engine-setup-20130606172206.log
> > > > > > > > > >
> > > > > > > > > >What database have you  used?
> > > > > > > > > >If you don't have anything important there, can you please
> > > > > > > > > >try
> > > > > > > > > >to
> > > > > > > > > >initialize it so you start fresh?
> > > > > > > > > >
> > > > > > > > > ># systemctl stop postgresql.service
> > > > > > > > > ># rm -fr /var/lib/pgsql
> > > > > > > > > ># postgresql-setup initdb
> > > > > > > > > ># vi /var/lib/pgsql/data/pg_hba.conf
> > > > > > > > > >modify 127.0.0.1/32 and ::1/128 lines to password at last
> > > > > > > > > >field
> > > > > > > > > ># su - postgres -c psql -d template1
> > > > > > > > > >template1=# create user engine password 'engine';
> > > > > > > > > >template1=# create database engine owner engine;
> > > > > > > > > ># \q
> > > > > > > > > >
> > > > > > > > > >> At 2013-06-06 05:17:07,"Eli Mesika" <emesika at redhat.com>
> > > > > > > > > >> 
> > > > > > > > > >> wrote:
> > > > > > > > > >> >----- Original Message -----
> > > > > > > > > >> >
> > > > > > > > > >> >> From: "bigclouds" <bigclouds at 163.com>
> > > > > > > > > >> >> To: "engine-devel" <engine-devel at ovirt.org>
> > > > > > > > > >> >> Sent: Wednesday, June 5, 2013 12:34:30 PM
> > > > > > > > > >> >> Subject: [Engine-devel] if there is a updated debug
> > > > > > > > > >> >> environment
> > > > > > > > > >> >> how
> > > > > > > > > >> >> to?
> > > > > > > > > >> >> 
> > > > > > > > > >> >> hi, engine guys:
> > > > > > > > > >> >> i want to make a engine debug environment for a looong
> > > > > > > > > >> >> time,
> > > > > > > > > >> >> due
> > > > > > > > > >> >> to
> > > > > > > > > >> >> all
> > > > > > > > > >> >> 
> > > > > > > > > >> >>  kinds
> > > > > > > > > >> >> 
> > > > > > > > > >> >> of reasons i have not made it.
> > > > > > > > > >> >> now i still have the need for a debug environment. (it
> > > > > > > > > >> >> seems
> > > > > > > > > >> >> like
> > > > > > > > > >> >> that
> > > > > > > > > >> >> i
> > > > > > > > > >> >> 
> > > > > > > > > >> >>  am
> > > > > > > > > >> >> 
> > > > > > > > > >> >> keeped away from you all)
> > > > > > > > > >> >> if there is a updated doc for building engine debug
> > > > > > > > > >> >> environment?
> > > > > > > > > >> >> thanks so much.
> > > > > > > > > >> >
> > > > > > > > > >> >Please follow Allon's B L doc on how to create a
> > > > > > > > > >> >development
> > > > > > > > > >> >environment
> > > > > > > > > >> >
> > > > > > > > > >> >http://www.ovirt.org/OVirt_Engine_Development_Environment
> > > > > > > > > >> >
> > > > > > > > > >> >> _______________________________________________
> > > > > > > > > >> >> Engine-devel mailing list
> > > > > > > > > >> >> Engine-devel at ovirt.org
> > > > > > > > > >> >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > > > > > > >> 
> > > > > > > > > >> _______________________________________________
> 


From awels at redhat.com  Fri Jun  7 19:56:40 2013
From: awels at redhat.com (Alexander Wels)
Date: Fri, 07 Jun 2013 15:56:40 -0400
Subject: [Engine-devel] if there is a updated debug environment how to?
In-Reply-To: <1179830307.7838122.1370634677541.JavaMail.root@redhat.com>
References: <1f1cccaa.c254.13f13b00539.Coremail.bigclouds@163.com>
	<19879316.JsIC89Exdp@awels>
	<1179830307.7838122.1370634677541.JavaMail.root@redhat.com>
Message-ID: <1436886.BHuK52khM6@awels>

On Friday, June 07, 2013 03:51:17 PM Alon Bar-Lev wrote:
> ----- Original Message -----
> 
> > From: "Alexander Wels" <awels at redhat.com>
> > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > Cc: engine-devel at ovirt.org, "bigclouds" <bigclouds at 163.com>
> > Sent: Friday, June 7, 2013 10:27:54 PM
> > Subject: Re: [Engine-devel] if there is a updated debug environment how
> > to?
> > 
> > On Friday, June 07, 2013 03:20:11 PM Alon Bar-Lev wrote:
> > > ----- Original Message -----
> > > 
> > > > From: "Alexander Wels" <awels at redhat.com>
> > > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > > Cc: engine-devel at ovirt.org, "bigclouds" <bigclouds at 163.com>
> > > > Sent: Friday, June 7, 2013 8:35:27 PM
> > > > Subject: Re: [Engine-devel] if there is a updated debug environment
> > > > how
> > > > to?
> > > > 
> > > > On Friday, June 07, 2013 12:22:10 PM Alon Bar-Lev wrote:
> > > > > ----- Original Message -----
> > > > > 
> > > > > > From: "Alexander Wels" <awels at redhat.com>
> > > > > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > > > > Cc: engine-devel at ovirt.org, "bigclouds" <bigclouds at 163.com>
> > > > > > Sent: Friday, June 7, 2013 4:14:59 PM
> > > > > > Subject: Re: [Engine-devel] if there is a updated debug
> > > > > > environment
> > > > > > how
> > > > > > to?
> > > > > > 
> > > > > > On Friday, June 07, 2013 08:26:32 AM Alon Bar-Lev wrote:
> > > > > > > ----- Original Message -----
> > > > > > > 
> > > > > > > > From: "Alexander Wels" <awels at redhat.com>
> > > > > > > > To: engine-devel at ovirt.org
> > > > > > > > Cc: "Alon Bar-Lev" <alonbl at redhat.com>, "bigclouds"
> > > > > > > > <bigclouds at 163.com>
> > > > > > > > Sent: Friday, June 7, 2013 3:09:19 PM
> > > > > > > > Subject: Re: [Engine-devel] if there is a updated debug
> > > > > > > > environment
> > > > > > > > how
> > > > > > > > to?
> > > > > > > > 
> > > > > > > > On Friday, June 07, 2013 03:46:12 AM Alon Bar-Lev wrote:
> > > > > > > > > ----- Original Message -----
> > > > > > > > > 
> > > > > > > > > > From: "bigclouds" <bigclouds at 163.com>
> > > > > > > > > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > > > > > > > > Cc: "Eli Mesika" <emesika at redhat.com>, "engine-devel"
> > > > > > > > > > <engine-devel at ovirt.org> Sent: Friday, June 7, 2013
> > > > > > > > > > 10:29:25
> > > > > > > > > > AM
> > > > > > > > > > Subject: Re:Re: [Engine-devel] if there is a updated debug
> > > > > > > > > > environment
> > > > > > > > > > how
> > > > > > > > > > to?
> > > > > > > > > > 
> > > > > > > > > > so many thinks,i  finally make it.
> > > > > > > > > > 
> > > > > > > > > > if i can debug gwt  in this environment?  and how?
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > if this link is still in use,
> > > > > > > > > > http://www.ovirt.org/DebugFrontend
> > > > > > > > > > 
> > > > > > > > > > thanks.
> > > > > > > > > 
> > > > > > > > > This is interesting, I would like to work with someone that
> > > > > > > > > knows
> > > > > > > > > GWT
> > > > > > > > > to
> > > > > > > > > make this happen.
> > > > > > > > > 
> > > > > > > > > If I read this correctly, all you need to do is:
> > > > > > > > > 
> > > > > > > > > $ make install-dev PREFIX="${HOME}/ovirt-engine"
> > > > > > > > > EXTRA_BUILD_FLAGS_DEV="-Pgwtdev"
> > > > > > > > > 
> > > > > > > > > And connect eclipse using the standard jboss debug port.
> > > > > > > > > 
> > > > > > > > > But I know nothing of GWT, I will appreciate help in that...
> > > > > > > > > 
> > > > > > > > > How do we connect to a running instance of jboss and debug
> > > > > > > > > gwt,
> > > > > > > > > what
> > > > > > > > > setting
> > > > > > > > > should we have?
> > > > > > > 
> > > > > > > Hi Alex,
> > > > > > > 
> > > > > > > > Once you have the engine up and running as explained about,
> > > > > > > > you
> > > > > > > > can
> > > > > > > > use
> > > > > > > > http://www.ovirt.org/DebugFrontend to run GWT debugging. You
> > > > > > > > can
> > > > > > > > safely
> > > > > > > > skip step 0
> > > > > > > > in that document (I think that needs to be updated). And start
> > > > > > > > at
> > > > > > > > step
> > > > > > > > 1.
> > > > > > > > The document explains quite well what to do, but the short
> > > > > > > > version
> > > > > > > > is:
> > > > > > > > 
> > > > > > > > 1. cd into the source code directory of either webadmin or
> > > > > > > > user
> > > > > > > > portal.
> > > > > > > > Usually: ovirt-
> > > > > > > > engine/frontend/webadmin/modules/(webadmin or userportal-gwtp)
> > > > > > > > 2. mvn gwt:debug -Pgwtdev,gwt-admin,gwt-user
> > > > > > > > -Dgwt.noserver=true
> > > > > > > > from
> > > > > > > > the
> > > > > > > > command line. Once it is done compiling it will tell you it is
> > > > > > > > listening
> > > > > > > > on
> > > > > > > > port 8000.
> > > > > > > 
> > > > > > > This will not run as jboss, right?
> > > > > > 
> > > > > > No it is a normal java application (The GWT debugger).
> > > > > > 
> > > > > > > Or you mean it will run on the jboss of the legacy (not the new
> > > > > > > environment). I would like a solution in which we can use the
> > > > > > > already
> > > > > > > running jboss instance that use for production in order to debug
> > > > > > > gwt.
> > > > > > > Is
> > > > > > > that possible?
> > > > > > > I guess some properties need to be passed, or new modules.
> > > > > > > 
> > > > > > > Thanks!
> > > > > > 
> > > > > > The GWT debugger is completely agnostic with regards to what
> > > > > > serves
> > > > > > the
> > > > > > host page. The GWT debugger is connected to the browser, not the
> > > > > > server.
> > > > > > The host page can be served from a local JBOSS, a remote Apache, a
> > > > > > file,
> > > > > > whatever. The GWT debugger doesn't care as it is talking to the
> > > > > > browser.
> > > > > 
> > > > > Can you please explain this text from the wiki:
> > > > > 
> > > > > gwt.noserver tells Development Mode that the application is already
> > > > > deployed
> > > > > on JBoss AS (don't use embedded Jetty instance to serve application
> > > > > content)
> > > > 
> > > > There are different ways of using the GWT debug mode. One of the ways
> > > > is
> > > > to
> > > > have the GWT debugger spin up an instance of jetty and have your web
> > > > application deployed in it. Then have it launch a browser with the
> > > > appropriate
> > > > url in it. Adding the --gwt.noserver on the command line tells GWT you
> > > > don't want to spin up the jetty server, that the application you are
> > > > working with is
> > > > somewhere else and you will manually go to it.
> > > > 
> > > > > Or this:
> > > > > 
> > > > > Q: Client-side logs are not persisted on Engine, e.g.
> > > > > $JBOSS_HOME/standalone/log/engine/engine-ui.log. A: Currently,
> > > > > client-side
> > > > > logs are enabled only when debugging the application via Development
> > > > > Mode.
> > > > 
> > > > When the application is running normally it is all just javascript
> > > > running
> > > > in the browser. There are 'log' statements in the code but no loggers
> > > > to
> > > > write the data to. When you are connected to the browser with the GWT
> > > > debugger the GWT debugger provides a logger to write to.
> > > 
> > > So how did it reached to the jboss-as log?
> > > Should I add configuration to jboss logging to have this?
> > > 
> > > > > What listens on port 8700?
> > > > 
> > > > In the old environment JBOSS. in the new environment nothing as JBOSS
> > > > is
> > > > listening on 8080 and 8443
> > > 
> > > OK, thanks.
> > > 
> > > So if I understand correctly, the following is sequence is required:
> > > 
> > > Build and deploy code:
> > > $ make install-dev PREFIX="${HOME}/ovirt-engine"
> > > $ "${HOME}/ovirt-engine/share/ovirt-engine/services/ovirt-engine.py"
> > > start
> >  
> >  You missed this part:
> > 1. cd into the source code directory of either webadmin or user portal.
> > you have to change directory to either frontend/webadmin/modules/webadmin
> > or frontend/webadmin/modules/userportal-gwtp
> > 
> > As the maven gwt plugin is only defined in the webadmin and userportal
> > poms
> > and
> > not in the root pom.
> 

It doesn't make much sense to put the gwt plugin in the root pom, as the root 
pom has nothing to do with GWT. The plugin exists in userportal and webadmin 
as those are GWT modules. The debugger is specifically a GWT debugger, you 
can't debug anything else with it.

> Is there any reason why not to add <something> to root pom?
> Activating the debugger should be generic, right, I mean it should not have
> any dependency with specific module... the fact that we use maven for that
> is only as a wrapper, right?
> > > Execute the gwt debugger as standalone
> > > $ mvn gwt:debug -Pgwtdev -Dgwt.noserver=true
> > > 
> > > Connect eclipse gwt debugger to localhost:8000
> > > 
> > > Navigate to application, add ?gwt.codesvr=127.0.0.1:9997 as suffix,
> > > example:
> > > WebAdmin:
> > > http://127.0.0.1:8080/webadmin/webadmin/WebAdmin.html?gwt.codesvr=127.0.
> > > 0.1
> > > 
> > > :9997 UserPortal:
> > > http://127.0.0.1:8080/UserPortal/org.ovirt.engine.ui.userportal.UserPort
> > > al/
> > > UserPortal.html?gwt.codesvr=127.0.0.1:9997
> > > 
> > > In other words, it should not be required to re-compile the code to
> > > execute
> > > the debugger... as environment is fully deployed.
> > > 
> > > 
> > > Well, the above sequence is not working, I wounder what I miss in
> > > principal... the mvn gwt:debug complains about: [ERROR] Failed to
> > > execute
> > > goal org.codehaus.mojo:gwt-maven-plugin:2.3.0:debug (default-cli) on
> > > project webadmin: The parameters 'runTarget' for goal
> > > org.codehaus.mojo:gwt-maven-plugin:2.3.0:debug are missing or invalid ->
> > > [Help 1]
> > > 
> > > Thanks!
> > > 
> > > > > Thanks!
> > > > > 
> > > > > > IMO the only thing we could do to improve this is update the make
> > > > > > file
> > > > > > to
> > > > > > provide a target to start the debugger, which basically just calls
> > > > > > maven
> > > > > > with the appropriate parameters.
> > > > > > 
> > > > > > > > 3.In eclipse (or your favorite java IDE) make a remote java
> > > > > > > > application
> > > > > > > > connection to
> > > > > > > > port 8000
> > > > > > > > 4. Once connected this will open up a GWT debug window.
> > > > > > > > 5. In your browser as ?gwt.codesvr=127.0.0.1:9997 to the url
> > > > > > > > you
> > > > > > > > are
> > > > > > > > working with and
> > > > > > > > refresh the page.
> > > > > > > > 6. It will either ask you to install the plugin in your
> > > > > > > > browser
> > > > > > > > or
> > > > > > > > load
> > > > > > > > the
> > > > > > > > page depending
> > > > > > > > on if you have the plugin already.
> > > > > > > > 
> > > > > > > > Alexander
> > > > > > > > 
> > > > > > > > > Thanks!
> > > > > > > > > 
> > > > > > > > > > At 2013-06-07 14:55:41,"Alon Bar-Lev" <alonbl at redhat.com>
> > 
> > wrote:
> > > > > > > > > > >----- Original Message -----
> > > > > > > > > > >
> > > > > > > > > > >> From: "bigclouds" <bigclouds at 163.com>
> > > > > > > > > > >> To: "Eli Mesika" <emesika at redhat.com>
> > > > > > > > > > >> Cc: "engine-devel" <engine-devel at ovirt.org>
> > > > > > > > > > >> Sent: Friday, June 7, 2013 3:49:15 AM
> > > > > > > > > > >> Subject: Re: [Engine-devel] if there is a updated debug
> > > > > > > > > > >> environment
> > > > > > > > > > >> how
> > > > > > > > > > >> to?
> > > > > > > > > > >> 
> > > > > > > > > > >> hi:
> > > > > > > > > > >> there is error when engine-setup-2. finally only 8702
> > > > > > > > > > >> and
> > > > > > > > > > >> 8703
> > > > > > > > > > >> port
> > > > > > > > > > >> is
> > > > > > > > > > >> in
> > > > > > > > > > >> listen state.
> > > > > > > > > > >> i can not visit 8080 via browser.
> > > > > > > > > > >
> > > > > > > > > > >Well, if setup fails... probably application won't work.
> > > > > > > > > > >
> > > > > > > > > > >> engine-setup-2 ?
> > > > > > > > > > >> [ INFO  ] Creating CA
> > > > > > > > > > >> [ INFO  ] Creating database schema
> > > > > > > > > > >> [ ERROR ] Failed to execute stage 'Misc configuration':
> > > > > > > > > > >> Command
> > > > > > > > > > >> '/home/best/ovirt-engine/share/ovirt-engine/dbscripts/c
> > > > > > > > > > >> reat
> > > > > > > > > > >> e_sc
> > > > > > > > > > >> hema
> > > > > > > > > > >> .sh'
> > > > > > > > > > >> failed to execute
> > > > > > > > > > >> [ INFO  ] Stage: Clean up
> > > > > > > > > > >> Log file is located at
> > > > > > > > > > >> /tmp/ovirt-engine-setup-20130606172206.log
> > > > > > > > > > >
> > > > > > > > > > >What database have you  used?
> > > > > > > > > > >If you don't have anything important there, can you
> > > > > > > > > > >please
> > > > > > > > > > >try
> > > > > > > > > > >to
> > > > > > > > > > >initialize it so you start fresh?
> > > > > > > > > > >
> > > > > > > > > > ># systemctl stop postgresql.service
> > > > > > > > > > ># rm -fr /var/lib/pgsql
> > > > > > > > > > ># postgresql-setup initdb
> > > > > > > > > > ># vi /var/lib/pgsql/data/pg_hba.conf
> > > > > > > > > > >modify 127.0.0.1/32 and ::1/128 lines to password at last
> > > > > > > > > > >field
> > > > > > > > > > ># su - postgres -c psql -d template1
> > > > > > > > > > >template1=# create user engine password 'engine';
> > > > > > > > > > >template1=# create database engine owner engine;
> > > > > > > > > > ># \q
> > > > > > > > > > >
> > > > > > > > > > >> At 2013-06-06 05:17:07,"Eli Mesika"
> > > > > > > > > > >> <emesika at redhat.com>
> > > > > > > > > > >> 
> > > > > > > > > > >> wrote:
> > > > > > > > > > >> >----- Original Message -----
> > > > > > > > > > >> >
> > > > > > > > > > >> >> From: "bigclouds" <bigclouds at 163.com>
> > > > > > > > > > >> >> To: "engine-devel" <engine-devel at ovirt.org>
> > > > > > > > > > >> >> Sent: Wednesday, June 5, 2013 12:34:30 PM
> > > > > > > > > > >> >> Subject: [Engine-devel] if there is a updated debug
> > > > > > > > > > >> >> environment
> > > > > > > > > > >> >> how
> > > > > > > > > > >> >> to?
> > > > > > > > > > >> >> 
> > > > > > > > > > >> >> hi, engine guys:
> > > > > > > > > > >> >> i want to make a engine debug environment for a
> > > > > > > > > > >> >> looong
> > > > > > > > > > >> >> time,
> > > > > > > > > > >> >> due
> > > > > > > > > > >> >> to
> > > > > > > > > > >> >> all
> > > > > > > > > > >> >> 
> > > > > > > > > > >> >>  kinds
> > > > > > > > > > >> >> 
> > > > > > > > > > >> >> of reasons i have not made it.
> > > > > > > > > > >> >> now i still have the need for a debug environment.
> > > > > > > > > > >> >> (it
> > > > > > > > > > >> >> seems
> > > > > > > > > > >> >> like
> > > > > > > > > > >> >> that
> > > > > > > > > > >> >> i
> > > > > > > > > > >> >> 
> > > > > > > > > > >> >>  am
> > > > > > > > > > >> >> 
> > > > > > > > > > >> >> keeped away from you all)
> > > > > > > > > > >> >> if there is a updated doc for building engine debug
> > > > > > > > > > >> >> environment?
> > > > > > > > > > >> >> thanks so much.
> > > > > > > > > > >> >
> > > > > > > > > > >> >Please follow Allon's B L doc on how to create a
> > > > > > > > > > >> >development
> > > > > > > > > > >> >environment
> > > > > > > > > > >> >
> > > > > > > > > > >> >http://www.ovirt.org/OVirt_Engine_Development_Environm
> > > > > > > > > > >> >ent
> > > > > > > > > > >> >
> > > > > > > > > > >> >> _______________________________________________
> > > > > > > > > > >> >> Engine-devel mailing list
> > > > > > > > > > >> >> Engine-devel at ovirt.org
> > > > > > > > > > >> >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > > > > > > > >> 
> > > > > > > > > > >> _______________________________________________


From alonbl at redhat.com  Fri Jun  7 20:07:40 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Fri, 7 Jun 2013 16:07:40 -0400 (EDT)
Subject: [Engine-devel] if there is a updated debug environment how to?
In-Reply-To: <1436886.BHuK52khM6@awels>
References: <1f1cccaa.c254.13f13b00539.Coremail.bigclouds@163.com>
	<19879316.JsIC89Exdp@awels>
	<1179830307.7838122.1370634677541.JavaMail.root@redhat.com>
	<1436886.BHuK52khM6@awels>
Message-ID: <1306276520.7843210.1370635660793.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Alexander Wels" <awels at redhat.com>
> To: "Alon Bar-Lev" <alonbl at redhat.com>
> Cc: engine-devel at ovirt.org, "bigclouds" <bigclouds at 163.com>
> Sent: Friday, June 7, 2013 10:56:40 PM
> Subject: Re: [Engine-devel] if there is a updated debug environment how to?
> 
> > > > So if I understand correctly, the following is sequence is required:
> > > > 
> > > > Build and deploy code:
> > > > $ make install-dev PREFIX="${HOME}/ovirt-engine"
> > > > $ "${HOME}/ovirt-engine/share/ovirt-engine/services/ovirt-engine.py"
> > > > start
> > >  
> > >  You missed this part:
> > > 1. cd into the source code directory of either webadmin or user portal.
> > > you have to change directory to either frontend/webadmin/modules/webadmin
> > > or frontend/webadmin/modules/userportal-gwtp
> > > 
> > > As the maven gwt plugin is only defined in the webadmin and userportal
> > > poms
> > > and
> > > not in the root pom.
> > 
> 
> It doesn't make much sense to put the gwt plugin in the root pom, as the root
> pom has nothing to do with GWT. The plugin exists in userportal and webadmin
> as those are GWT modules. The debugger is specifically a GWT debugger, you
> can't debug anything else with it.

You perceive this as something of gwt project, while I perceive this part of the environment.

What I expect it to allow as simple development environment as we can.
Just like I enable the debug port of jboss automatically I would like to enable gwt debug.

If I add "-P gwtdev" to default build using install-dev, all gwt applications should be built and installed using the extra debugging information, using:

$ make install-dev PREFIX="${HOME}/ovirt-engine"

I can even add GWT_DEBUGGER=1 to optionally enable/disable this feature.

Now, after starting ovirt-engine service, all I expect is a simple command to start the gwt debugger.

$ make gwt-debugger
or:
./gwt-debugger

The fact that maven is used to start the debugger is not important.

What I do expect is that the debugger not to require a specific relation with specific application (Webadmin, userportal).

I would have understood if I had to execute something like the following to run the debugger:

$ cd frontend
$ mvn gwt:debug -Dgwt.noserver=true

Or better to avoid building anything:

$ cd frontend/debugger
$ mvn gwt:debug -Dgwt.noserver=true

But I do not understand why a cd to specific application is required.

Thanks!
Alon


From wlbleaboy at 126.com  Sat Jun  8 07:34:09 2013
From: wlbleaboy at 126.com (wlbleaboy@126)
Date: Sat, 8 Jun 2013 15:34:09 +0800
Subject: [Engine-devel] about session_timeout in API
Message-ID: <009b01ce641a$910934b0$b31b9e10$@com>

Hi, all:

         What's meaning of session_timeout in ovirt-engine-sdk-python API,

 

 

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130608/5921311a/attachment.html>

From shaharh at redhat.com  Sat Jun  8 13:10:07 2013
From: shaharh at redhat.com (Shahar Havivi)
Date: Sat, 8 Jun 2013 16:10:07 +0300
Subject: [Engine-devel] [oVirt Jenkins] ovirt_engine_find_bugs - Build #
 4393 - Still Unstable!
In-Reply-To: <329930531.186757.1370633762080.JavaMail.root@redhat.com>
References: <1852944023.5603.1370598531001.JavaMail.jenkins@jenkins.ovirt.org>
	<1562314012.5620.1370607000581.JavaMail.jenkins@jenkins.ovirt.org>
	<329930531.186757.1370633762080.JavaMail.root@redhat.com>
Message-ID: <20130608131006.GA30431@redhat.com>

On 07.06.13 15:36, Eyal Edri wrote:
> fyi,
> 
> your last commits add NORAMAL & HIGH priority FINDBUGS issues.
> 
> please resolve asap.
Need to check,
Please note that when fixing a findbugs issue a new issue/s can be found.
> 
> http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4389/changes#detail
> 
> Eyal.
> 
> ----- Original Message -----
> > From: "Jenkins ci oVirt Server" <jenkins at ovirt.org>
> > To: eedri at redhat.com, yzaslavs at redhat.com, dcaro at redhat.com, "juan hernandez" <juan.hernandez at redhat.com>
> > Sent: Friday, June 7, 2013 3:09:59 PM
> > Subject: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4393 - Still Unstable!
> > 
> > Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
> > Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4393/
> > Build Number: 4393
> > Build Status:  Still Unstable
> > Triggered By: Started by an SCM change
> > 
> > -------------------------------------
> > Changes Since Last Success:
> > -------------------------------------
> > Changes for Build #4389
> > [Shahar Havivi] findbugs: resultSet is not close after use
> > 
> > [Shahar Havivi] findbugs: inaccurate floating point comparison
> > 
> > [Shahar Havivi] findbugs: Unwritten public fields
> > 
> > [Alona Kaplan] engine: multiple gateways
> > 
> > 
> > Changes for Build #4390
> > [Alon Bar-Lev] novnc: no need to raise terminate exception on termination
> > 
> > 
> > Changes for Build #4391
> > [Alon Bar-Lev] novnc: cleanup defaults file
> > 
> > [Alon Bar-Lev] novnc: log file is actually trace file
> > 
> > [Alon Bar-Lev] novnc: override get_target instead of new_client
> > 
> > [Alon Bar-Lev] novnc: use service debug instead of configuration
> > 
> > [Alon Bar-Lev] packaging: service: add debug when module returns
> > 
> > 
> > Changes for Build #4392
> > [Sahina Bose] engine: Multiple gateways test failure fixed
> > 
> > 
> > Changes for Build #4393
> > [Juan Hernandez] core: Make GUID encoders singletons
> > 
> > 
> > 
> > 
> > -----------------
> > Failed Tests:
> > -----------------
> > No tests ran.
> > 
> > 


From iheim at redhat.com  Sat Jun  8 19:33:15 2013
From: iheim at redhat.com (Itamar Heim)
Date: Sat, 08 Jun 2013 22:33:15 +0300
Subject: [Engine-devel] cluster emulation mode feature
In-Reply-To: <51B01B82.6070900@redhat.com>
References: <51B01B82.6070900@redhat.com>
Message-ID: <51B386FB.9040502@redhat.com>

On 06/06/2013 08:17 AM, Roy Golan wrote:
> Hi,
>
> A new wiki has been published on Cluster Emulation mode
> http://www.ovirt.org/Cluster_emulation_modes
>
> Please review.
>
> Thanks,
> Roy
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel

strange, I thought the EmulatedMachine config value we currently have 
was also used to validate host support, but seems we were missing that part.

what will happen with the current EmulatedMachine config value?

what happens when cluster emulation mode changes to hosts not matching it?




From eedri at redhat.com  Sat Jun  8 20:46:32 2013
From: eedri at redhat.com (Eyal Edri)
Date: Sat, 8 Jun 2013 16:46:32 -0400 (EDT)
Subject: [Engine-devel] [oVirt Jenkins] ovirt_engine_find_bugs - Build #
 4393 - Still Unstable!
In-Reply-To: <20130608131006.GA30431@redhat.com>
References: <1852944023.5603.1370598531001.JavaMail.jenkins@jenkins.ovirt.org>
	<1562314012.5620.1370607000581.JavaMail.jenkins@jenkins.ovirt.org>
	<329930531.186757.1370633762080.JavaMail.root@redhat.com>
	<20130608131006.GA30431@redhat.com>
Message-ID: <271148215.379805.1370724392610.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Shahar Havivi" <shaharh at redhat.com>
> To: "Eyal Edri" <eedri at redhat.com>
> Cc: "Alona Kaplan" <alkaplan at redhat.com>, "engine-devel" <engine-devel at ovirt.org>, "infra" <infra at ovirt.org>
> Sent: Saturday, June 8, 2013 4:10:07 PM
> Subject: Re: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4393 - Still Unstable!
> 
> On 07.06.13 15:36, Eyal Edri wrote:
> > fyi,
> > 
> > your last commits add NORAMAL & HIGH priority FINDBUGS issues.
> > 
> > please resolve asap.
> Need to check,
> Please note that when fixing a findbugs issue a new issue/s can be found.

1. you can run findbugs maven plugin before you merge your patch (via command line / eclipse plugin).
2. we're working on enabling the findbugs per patch as soon as gerrit is back to normal state.

> > 
> > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4389/changes#detail
> > 
> > Eyal.
> > 
> > ----- Original Message -----
> > > From: "Jenkins ci oVirt Server" <jenkins at ovirt.org>
> > > To: eedri at redhat.com, yzaslavs at redhat.com, dcaro at redhat.com, "juan
> > > hernandez" <juan.hernandez at redhat.com>
> > > Sent: Friday, June 7, 2013 3:09:59 PM
> > > Subject: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4393 - Still
> > > Unstable!
> > > 
> > > Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
> > > Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4393/
> > > Build Number: 4393
> > > Build Status:  Still Unstable
> > > Triggered By: Started by an SCM change
> > > 
> > > -------------------------------------
> > > Changes Since Last Success:
> > > -------------------------------------
> > > Changes for Build #4389
> > > [Shahar Havivi] findbugs: resultSet is not close after use
> > > 
> > > [Shahar Havivi] findbugs: inaccurate floating point comparison
> > > 
> > > [Shahar Havivi] findbugs: Unwritten public fields
> > > 
> > > [Alona Kaplan] engine: multiple gateways
> > > 
> > > 
> > > Changes for Build #4390
> > > [Alon Bar-Lev] novnc: no need to raise terminate exception on termination
> > > 
> > > 
> > > Changes for Build #4391
> > > [Alon Bar-Lev] novnc: cleanup defaults file
> > > 
> > > [Alon Bar-Lev] novnc: log file is actually trace file
> > > 
> > > [Alon Bar-Lev] novnc: override get_target instead of new_client
> > > 
> > > [Alon Bar-Lev] novnc: use service debug instead of configuration
> > > 
> > > [Alon Bar-Lev] packaging: service: add debug when module returns
> > > 
> > > 
> > > Changes for Build #4392
> > > [Sahina Bose] engine: Multiple gateways test failure fixed
> > > 
> > > 
> > > Changes for Build #4393
> > > [Juan Hernandez] core: Make GUID encoders singletons
> > > 
> > > 
> > > 
> > > 
> > > -----------------
> > > Failed Tests:
> > > -----------------
> > > No tests ran.
> > > 
> > > 
> 


From asegurap at redhat.com  Sun Jun  9 01:06:27 2013
From: asegurap at redhat.com (Antoni Segura Puimedon)
Date: Sat, 8 Jun 2013 21:06:27 -0400 (EDT)
Subject: [Engine-devel] gerrit command line client
In-Reply-To: <1588616007.7928916.1370739510381.JavaMail.root@redhat.com>
Message-ID: <422197610.7928962.1370739987926.JavaMail.root@redhat.com>

Hi all,

Having yesterday a slow Saturday and inspired by a link sent by ewoud about
gerrit ssh interface. I coded a very basic command line script to retrieve
information from gerrit. You can find it on:

    https://github.com/celebdor/perryt

As of now it doesn't have a lot of options and the code is quite horrible
still. But it does allow some useful queries like the ones at the end of this
email.

The classes on perryt.py are close to modelling all the information that
gerrit 2.4.2 exposes through this interface, so it should be easy to add more
complicated and useful queries (checking dependencies and such).

You might ask: "Why to do that if gerrit already has quite big querying
possibilities?". The answers are twofold:
1. Because I can and it was raining.
2. Because it is easier for me to use than the ssh gerrit thingy.

I welcome pull requests ;-)

./perryt.py reviewer apuimedo reviewed any verified markw
Results: 31(time: 537?s)
================================================================================

(vdsm)Iece96: ifcfg: preserve 'NM_CONTROLLED=no' on removal - (OUTDATED DEP) - wudxw
        http://gerrit.ovirt.org/15148
        P4 (v: 1, r: 2 - [wudxw(v:1), asegurap(r:1), gvallare(r:1)])


(vdsm)I32e8e: Simplify setNewMtu() - (UP TO DATE) - wudxw
        http://gerrit.ovirt.org/15355
        P6 (v: 1, r: 1 - [wudxw(v:1), asegurap(r:1)])


(vdsm)I9e11f: NetReload: netmodels for delNetwork - (OUTDATED DEP) - wudxw
        http://gerrit.ovirt.org/14873
        P10 (v: -1, r: 1 - [wudxw(v:-1), asegurap(r:1)])


(vdsm)Id254a: Move removing libvirt network to configurator - (UP TO DATE) - wudxw
        http://gerrit.ovirt.org/15417
        P1 (v: 0, r: -1 - [wudxw(v:1), oVirt Jenkins CI Server(v:-1), asegurap(r:-1)])
        P3 (v: 1, r: 1 - [wudxw(v:1), asegurap(r:1)])
        P5 (v: 1, r: 1 - [wudxw(v:1), asegurap(r:1)])


(vdsm)I798cc: Separate libvirt network configuration from ifcfg - (UP TO DATE) - wudxw
        http://gerrit.ovirt.org/15178
        P5 (v: 1, r: 1 - [wudxw(v:1), asegurap(r:1)])
        P7 (v: 1, r: 1 - [wudxw(v:1), asegurap(r:1)])
        P8 (v: 2, r: 1 - [wudxw(v:1), asegurap(r:1), asegurap(v:1)])


(vdsm)I9ab6f: NetReload: netmodels for editBonding/removeBonding - (UP TO DATE) - wudxw
        http://gerrit.ovirt.org/15356
        P4 (v: 1, r: -1 - [wudxw(v:1), asegurap(r:-1)])
        P6 (v: 1, r: 1 - [wudxw(v:1), asegurap(r:1)])
        P7 (v: 2, r: 1 - [wudxw(v:1), asegurap(r:1), asegurap(v:1)])


or another example:

./perryt.py owner alonbl status open
Results: 12(time: 161?s)
================================================================================

(ovirt-engine)I76019: packaging: periodically check if ovirt-engine upgrade available - (UP TO DATE) - alonbl
        http://gerrit.ovirt.org/10976
        P2 (v: 0, r: -1 - [oschreib(r:-1), alourie(r:1), alonbl(r:-1)])


(ovirt-engine)I017a5: packaging: setup: use firewalld implementation of otopi - (UP TO DATE) - alonbl
        http://gerrit.ovirt.org/15114
        P1 (v: 0, r: 0 - [alonbl(r:-1), sbonazzo(r:1)])


(ovirt-engine)I3570a: packaging: log rotate - (UP TO DATE) - alonbl
        http://gerrit.ovirt.org/14961
        P3 (v: 2, r: 4 - [yzaslavs(r:1), amureini(r:1), alonbl(v:1), sbonazzo(r:1), didi(r:1), didi(v:1)])


(ovirt-engine)I7f3ab: pki: set ownership of apache key to root - (UP TO DATE) - alonbl
        http://gerrit.ovirt.org/15266
        P1 (v: 1, r: 0 - [alonbl(v:1)])


(ovirt-engine)I638e9: pki: upgrade: do not overwrite apache certificate and key - (UP TO DATE) - alonbl
        http://gerrit.ovirt.org/15267
        P1 (v: 1, r: 0 - [alonbl(v:1)])


(ovirt-image-uploader)Id8600: core: modify copyright of base po - (UP TO DATE) - alonbl
        http://gerrit.ovirt.org/15294
        P1 (v: 0, r: 1 - [kroberts(r:1)])


(ovirt-iso-uploader)I11ea0: core: modify copyright of base po - (UP TO DATE) - alonbl
        http://gerrit.ovirt.org/15295
        P1 (v: 0, r: 1 - [kroberts(r:1)])


(ovirt-engine)Iec8bb: pki: remove database config upgrade - (UP TO DATE) - alonbl
        http://gerrit.ovirt.org/15184
        P1 (v: 1, r: 1 - [emesika(r:1), alonbl(v:1)])


(ovirt-engine-sdk-java)I2f390: build: support make out of tarball - (UP TO DATE) - alonbl
        http://gerrit.ovirt.org/15332
        P1 (v: 1, r: 0 - [alonbl(v:1)])


(ovirt-engine-sdk-java)I0eb58: build: spec: support rhel and centos - (UP TO DATE) - alonbl
        http://gerrit.ovirt.org/15333
        P1 (v: 1, r: 0 - [alonbl(v:1)])


(ovirt-log-collector)Ieef24: core: modify copyright of base po - (UP TO DATE) - alonbl
        http://gerrit.ovirt.org/15293
        P1 (v: 0, r: 1 - [kroberts(r:1)])


(ovirt-engine)Icf94f: packaging: setup: support older psycopg2 - (UP TO DATE) - alonbl
        http://gerrit.ovirt.org/15358
        P2 (v: 1, r: 1 - [alonbl(v:1), sbonazzo(r:1)])




From rgolan at redhat.com  Sun Jun  9 05:56:45 2013
From: rgolan at redhat.com (Roy Golan)
Date: Sun, 09 Jun 2013 08:56:45 +0300
Subject: [Engine-devel] cluster emulation mode feature
In-Reply-To: <51B386FB.9040502@redhat.com>
References: <51B01B82.6070900@redhat.com> <51B386FB.9040502@redhat.com>
Message-ID: <51B4191D.5080406@redhat.com>

On 06/08/2013 10:33 PM, Itamar Heim wrote:
> On 06/06/2013 08:17 AM, Roy Golan wrote:
>> Hi,
>>
>> A new wiki has been published on Cluster Emulation mode
>> http://www.ovirt.org/Cluster_emulation_modes
>>
>> Please review.
>>
>> Thanks,
>> Roy
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>
> strange, I thought the EmulatedMachine config value we currently have 
> was also used to validate host support, but seems we were missing that 
> part.

I was also puzzled while doing git grep -i emulatedmachine

>
> what will happen with the current EmulatedMachine config value?

The OVF builder will use the cluster config and EmulatedMachine will be 
deleted

>
> what happens when cluster emulation mode changes to hosts not matching 
> it?

Updating cluster's emulation mode is prohibited when active hosts has 
running VMs.
if VMs are not running on them they will transit to non-op on the next 
refresh


>
>



From ofrenkel at redhat.com  Sun Jun  9 06:05:19 2013
From: ofrenkel at redhat.com (Omer Frenkel)
Date: Sun, 9 Jun 2013 02:05:19 -0400 (EDT)
Subject: [Engine-devel] cluster emulation mode feature
In-Reply-To: <51B4191D.5080406@redhat.com>
References: <51B01B82.6070900@redhat.com> <51B386FB.9040502@redhat.com>
	<51B4191D.5080406@redhat.com>
Message-ID: <862900779.21187879.1370757919002.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Roy Golan" <rgolan at redhat.com>
> Cc: engine-devel at ovirt.org
> Sent: Sunday, June 9, 2013 8:56:45 AM
> Subject: Re: [Engine-devel] cluster emulation mode feature
> 
> On 06/08/2013 10:33 PM, Itamar Heim wrote:
> > On 06/06/2013 08:17 AM, Roy Golan wrote:
> >> Hi,
> >>
> >> A new wiki has been published on Cluster Emulation mode
> >> http://www.ovirt.org/Cluster_emulation_modes
> >>
> >> Please review.
> >>
> >> Thanks,
> >> Roy
> >> _______________________________________________
> >> Engine-devel mailing list
> >> Engine-devel at ovirt.org
> >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> >
> > strange, I thought the EmulatedMachine config value we currently have
> > was also used to validate host support, but seems we were missing that
> > part.
> 
> I was also puzzled while doing git grep -i emulatedmachine
> 
> >
> > what will happen with the current EmulatedMachine config value?
> 
> The OVF builder will use the cluster config and EmulatedMachine will be
> deleted
> 
> >
> > what happens when cluster emulation mode changes to hosts not matching
> > it?
> 
> Updating cluster's emulation mode is prohibited when active hosts has
> running VMs.
> if VMs are not running on them they will transit to non-op on the next
> refresh
> 

the emulated machines are reported on getCaps, not getStats, so not sure what refresh you refer to,
anyway i think we should allow if no vms running but all active hosts support new value
and block otherwise (if vms are running or one of the active hosts doesn't support new value)

iirc this is the logic for changing cpu type

> 
> >
> >
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From ofrenkel at redhat.com  Sun Jun  9 06:51:54 2013
From: ofrenkel at redhat.com (Omer Frenkel)
Date: Sun, 9 Jun 2013 02:51:54 -0400 (EDT)
Subject: [Engine-devel] Guest Reboot
In-Reply-To: <1845391574.16328760.1370622751837.JavaMail.root@redhat.com>
References: <1845391574.16328760.1370622751837.JavaMail.root@redhat.com>
Message-ID: <1807322852.21193953.1370760714128.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Martin Betak" <mbetak at redhat.com>
> To: engine-devel at ovirt.org
> Sent: Friday, June 7, 2013 7:32:31 PM
> Subject: [Engine-devel] Guest Reboot
> 
> Hi, engine-devel
> 
> Customers request the ability to reboot a VM with a single click so I started
> designing the overall architecture and planing out the required changes to
> the respective components.
> You can find the wiki page for the initial draft at [1] and I would like to
> ask you for your input on my general design and potential issues that could
> arise in some corner cases.
> Please feel free to respond to this thread or add to the Issues section of
> [1].
> 
> Thanks in advance for your opinions :-)
> 
> Martin
> 
> [1] http://www.ovirt.org/Features/Guest_Reboot
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 

As i understand it, reboot will do shutdown and initiate a run-command in order to send any updated parameters,
if this is correct, why vdsm and GA need to know its a reboot? guest is shutting down, no?

it would be better to add some info on stateless issue: when stateless vm goes down, its state is cleared,
so need to decide if reboot to stateless means also start with new state or no.

similar is vm from pool: when vm from automatic pool goes down, it "returns" to the pool, and not belong to a specific user anymore,
also here the state is cleared, so again need to understand the correct behaviour


From mpastern at redhat.com  Sun Jun  9 07:06:18 2013
From: mpastern at redhat.com (Michael Pasternak)
Date: Sun, 09 Jun 2013 10:06:18 +0300
Subject: [Engine-devel] about session_timeout in API
In-Reply-To: <009b01ce641a$910934b0$b31b9e10$@com>
References: <009b01ce641a$910934b0$b31b9e10$@com>
Message-ID: <51B4296A.3020600@redhat.com>

On 06/08/2013 10:34 AM, wlbleaboy at 126 wrote:
> Hi, all:
> 
>          What?s meaning of session_timeout in ovirt-engine-sdk-python API,

[@param session_timeout: authentication session timeout (if persistent_auth is enabled)]

p.s you can find this in __doc__ under API.__init__

> 
>  
> 
>  
> 
>  
> 
> 
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


-- 

Michael Pasternak
RedHat, ENG-Virtualization R&D


From iheim at redhat.com  Sun Jun  9 07:24:45 2013
From: iheim at redhat.com (Itamar Heim)
Date: Sun, 9 Jun 2013 03:24:45 -0400 (EDT)
Subject: [Engine-devel] cluster emulation mode feature
In-Reply-To: <862900779.21187879.1370757919002.JavaMail.root@redhat.com>
References: <51B01B82.6070900@redhat.com> <51B386FB.9040502@redhat.com>
	<51B4191D.5080406@redhat.com>
	<862900779.21187879.1370757919002.JavaMail.root@redhat.com>
Message-ID: <1023421500.16635643.1370762685573.JavaMail.root@redhat.com>


----- Omer Frenkel <ofrenkel at redhat.com> wrote:
> 
> 
> ----- Original Message -----
> > From: "Roy Golan" <rgolan at redhat.com>
> > Cc: engine-devel at ovirt.org
> > Sent: Sunday, June 9, 2013 8:56:45 AM
> > Subject: Re: [Engine-devel] cluster emulation mode feature
> > 
> > On 06/08/2013 10:33 PM, Itamar Heim wrote:
> > > On 06/06/2013 08:17 AM, Roy Golan wrote:
> > >> Hi,
> > >>
> > >> A new wiki has been published on Cluster Emulation mode
> > >> http://www.ovirt.org/Cluster_emulation_modes
> > >>
> > >> Please review.
> > >>
> > >> Thanks,
> > >> Roy
> > >> _______________________________________________
> > >> Engine-devel mailing list
> > >> Engine-devel at ovirt.org
> > >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> > >
> > > strange, I thought the EmulatedMachine config value we currently have
> > > was also used to validate host support, but seems we were missing that
> > > part.
> > 
> > I was also puzzled while doing git grep -i emulatedmachine
> > 
> > >
> > > what will happen with the current EmulatedMachine config value?
> > 
> > The OVF builder will use the cluster config and EmulatedMachine will be
> > deleted
> > 
> > >
> > > what happens when cluster emulation mode changes to hosts not matching
> > > it?
> > 
> > Updating cluster's emulation mode is prohibited when active hosts has
> > running VMs.
> > if VMs are not running on them they will transit to non-op on the next
> > refresh
> > 
> 
> the emulated machines are reported on getCaps, not getStats, so not sure what refresh you refer to,
> anyway i think we should allow if no vms running but all active hosts support new value
> and block otherwise (if vms are running or one of the active hosts doesn't support new value)
> 
> iirc this is the logic for changing cpu type
> 

We allow changing cup while vms are running at least up
> > 
> > >
> > >
> > 
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel



From wlbleaboy at 126.com  Sun Jun  9 07:30:38 2013
From: wlbleaboy at 126.com (wlbleaboy@126)
Date: Sun, 9 Jun 2013 15:30:38 +0800
Subject: [Engine-devel] about session_timeout in API
In-Reply-To: <51B4296A.3020600@redhat.com>
References: <009b01ce641a$910934b0$b31b9e10$@com> <51B4296A.3020600@redhat.com>
Message-ID: <00a001ce64e3$3f06d810$bd148830$@com>

Yes, I saw that you assigned, because I'm not familiar with python, so ,
I want to know that's It's specific meaning, what's the meaning of that 
argument used for API.__init__()

-----Original Message-----
From: Michael Pasternak [mailto:mpastern at redhat.com] 
Sent: Sunday, June 09, 2013 3:06 PM
To: wlbleaboy at 126
Cc: engine-devel at ovirt.org
Subject: Re: [Engine-devel] about session_timeout in API

On 06/08/2013 10:34 AM, wlbleaboy at 126 wrote:
> Hi, all:
> 
>          What's meaning of session_timeout in ovirt-engine-sdk-python API,

[@param session_timeout: authentication session timeout (if persistent_auth
is enabled)]

p.s you can find this in __doc__ under API.__init__

> 
>  
> 
>  
> 
>  
> 
> 
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


-- 

Michael Pasternak
RedHat, ENG-Virtualization R&D




From mpastern at redhat.com  Sun Jun  9 07:54:43 2013
From: mpastern at redhat.com (Michael Pasternak)
Date: Sun, 09 Jun 2013 10:54:43 +0300
Subject: [Engine-devel] about session_timeout in API
In-Reply-To: <00a001ce64e3$3f06d810$bd148830$@com>
References: <009b01ce641a$910934b0$b31b9e10$@com> <51B4296A.3020600@redhat.com>
	<00a001ce64e3$3f06d810$bd148830$@com>
Message-ID: <51B434C3.8080604@redhat.com>

On 06/09/2013 10:30 AM, wlbleaboy at 126 wrote:
> Yes, I saw that you assigned, because I'm not familiar with python, so ,
> I want to know that's It's specific meaning, what's the meaning of that 
> argument used for API.__init__()

By default sdk uses persistent authentication [1], and to achieve that used
http session, the default for the session idle state is 2 hours (IIRC) after that,
if you'll try to perform any action, it will fail with 401 error,

by changing session_timeout in the SDK, you can define your own session timeout.

[1] you can switch off persistent authentication by making 'persistent_auth=False',
but please note that then authentication will take place per sdk request.

> 
> -----Original Message-----
> From: Michael Pasternak [mailto:mpastern at redhat.com] 
> Sent: Sunday, June 09, 2013 3:06 PM
> To: wlbleaboy at 126
> Cc: engine-devel at ovirt.org
> Subject: Re: [Engine-devel] about session_timeout in API
> 
> On 06/08/2013 10:34 AM, wlbleaboy at 126 wrote:
>> Hi, all:
>>
>>          What's meaning of session_timeout in ovirt-engine-sdk-python API,
> 
> [@param session_timeout: authentication session timeout (if persistent_auth
> is enabled)]
> 
> p.s you can find this in __doc__ under API.__init__
> 
>>
>>  
>>
>>  
>>
>>  
>>
>>
>>
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>
> 
> 


-- 

Michael Pasternak
RedHat, ENG-Virtualization R&D


From shaharh at redhat.com  Sun Jun  9 08:21:07 2013
From: shaharh at redhat.com (Shahar Havivi)
Date: Sun, 9 Jun 2013 11:21:07 +0300
Subject: [Engine-devel] [oVirt Jenkins] ovirt_engine_find_bugs - Build #
 4393 - Still Unstable!
In-Reply-To: <271148215.379805.1370724392610.JavaMail.root@redhat.com>
References: <1852944023.5603.1370598531001.JavaMail.jenkins@jenkins.ovirt.org>
	<1562314012.5620.1370607000581.JavaMail.jenkins@jenkins.ovirt.org>
	<329930531.186757.1370633762080.JavaMail.root@redhat.com>
	<20130608131006.GA30431@redhat.com>
	<271148215.379805.1370724392610.JavaMail.root@redhat.com>
Message-ID: <20130609082105.GC15123@redhat.com>

it was my commit and I sent a fix to:
http://gerrit.ovirt.org/#/c/15474/

On 08.06.13 16:46, Eyal Edri wrote:
> 
> 
> ----- Original Message -----
> > From: "Shahar Havivi" <shaharh at redhat.com>
> > To: "Eyal Edri" <eedri at redhat.com>
> > Cc: "Alona Kaplan" <alkaplan at redhat.com>, "engine-devel" <engine-devel at ovirt.org>, "infra" <infra at ovirt.org>
> > Sent: Saturday, June 8, 2013 4:10:07 PM
> > Subject: Re: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4393 - Still Unstable!
> > 
> > On 07.06.13 15:36, Eyal Edri wrote:
> > > fyi,
> > > 
> > > your last commits add NORAMAL & HIGH priority FINDBUGS issues.
> > > 
> > > please resolve asap.
> > Need to check,
> > Please note that when fixing a findbugs issue a new issue/s can be found.
> 
> 1. you can run findbugs maven plugin before you merge your patch (via command line / eclipse plugin).
> 2. we're working on enabling the findbugs per patch as soon as gerrit is back to normal state.
> 
> > > 
> > > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4389/changes#detail
> > > 
> > > Eyal.
> > > 
> > > ----- Original Message -----
> > > > From: "Jenkins ci oVirt Server" <jenkins at ovirt.org>
> > > > To: eedri at redhat.com, yzaslavs at redhat.com, dcaro at redhat.com, "juan
> > > > hernandez" <juan.hernandez at redhat.com>
> > > > Sent: Friday, June 7, 2013 3:09:59 PM
> > > > Subject: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4393 - Still
> > > > Unstable!
> > > > 
> > > > Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
> > > > Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4393/
> > > > Build Number: 4393
> > > > Build Status:  Still Unstable
> > > > Triggered By: Started by an SCM change
> > > > 
> > > > -------------------------------------
> > > > Changes Since Last Success:
> > > > -------------------------------------
> > > > Changes for Build #4389
> > > > [Shahar Havivi] findbugs: resultSet is not close after use
> > > > 
> > > > [Shahar Havivi] findbugs: inaccurate floating point comparison
> > > > 
> > > > [Shahar Havivi] findbugs: Unwritten public fields
> > > > 
> > > > [Alona Kaplan] engine: multiple gateways
> > > > 
> > > > 
> > > > Changes for Build #4390
> > > > [Alon Bar-Lev] novnc: no need to raise terminate exception on termination
> > > > 
> > > > 
> > > > Changes for Build #4391
> > > > [Alon Bar-Lev] novnc: cleanup defaults file
> > > > 
> > > > [Alon Bar-Lev] novnc: log file is actually trace file
> > > > 
> > > > [Alon Bar-Lev] novnc: override get_target instead of new_client
> > > > 
> > > > [Alon Bar-Lev] novnc: use service debug instead of configuration
> > > > 
> > > > [Alon Bar-Lev] packaging: service: add debug when module returns
> > > > 
> > > > 
> > > > Changes for Build #4392
> > > > [Sahina Bose] engine: Multiple gateways test failure fixed
> > > > 
> > > > 
> > > > Changes for Build #4393
> > > > [Juan Hernandez] core: Make GUID encoders singletons
> > > > 
> > > > 
> > > > 
> > > > 
> > > > -----------------
> > > > Failed Tests:
> > > > -----------------
> > > > No tests ran.
> > > > 
> > > > 
> > 


From eedri at redhat.com  Sun Jun  9 08:32:01 2013
From: eedri at redhat.com (Eyal Edri)
Date: Sun, 9 Jun 2013 04:32:01 -0400 (EDT)
Subject: [Engine-devel] [oVirt Jenkins] ovirt_engine_find_bugs - Build #
 4393 - Still Unstable!
In-Reply-To: <20130609082105.GC15123@redhat.com>
References: <1852944023.5603.1370598531001.JavaMail.jenkins@jenkins.ovirt.org>
	<1562314012.5620.1370607000581.JavaMail.jenkins@jenkins.ovirt.org>
	<329930531.186757.1370633762080.JavaMail.root@redhat.com>
	<20130608131006.GA30431@redhat.com>
	<271148215.379805.1370724392610.JavaMail.root@redhat.com>
	<20130609082105.GC15123@redhat.com>
Message-ID: <1030420491.429393.1370766721448.JavaMail.root@redhat.com>

thanks.

once it's merged and job is back to stable, we'll enable back the per-patch job.

eyal.

----- Original Message -----
> From: "Shahar Havivi" <shaharh at redhat.com>
> To: "Eyal Edri" <eedri at redhat.com>
> Cc: "Alona Kaplan" <alkaplan at redhat.com>, "engine-devel" <engine-devel at ovirt.org>, "infra" <infra at ovirt.org>
> Sent: Sunday, June 9, 2013 11:21:07 AM
> Subject: Re: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4393 - Still Unstable!
> 
> it was my commit and I sent a fix to:
> http://gerrit.ovirt.org/#/c/15474/
> 
> On 08.06.13 16:46, Eyal Edri wrote:
> > 
> > 
> > ----- Original Message -----
> > > From: "Shahar Havivi" <shaharh at redhat.com>
> > > To: "Eyal Edri" <eedri at redhat.com>
> > > Cc: "Alona Kaplan" <alkaplan at redhat.com>, "engine-devel"
> > > <engine-devel at ovirt.org>, "infra" <infra at ovirt.org>
> > > Sent: Saturday, June 8, 2013 4:10:07 PM
> > > Subject: Re: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4393 -
> > > Still Unstable!
> > > 
> > > On 07.06.13 15:36, Eyal Edri wrote:
> > > > fyi,
> > > > 
> > > > your last commits add NORAMAL & HIGH priority FINDBUGS issues.
> > > > 
> > > > please resolve asap.
> > > Need to check,
> > > Please note that when fixing a findbugs issue a new issue/s can be found.
> > 
> > 1. you can run findbugs maven plugin before you merge your patch (via
> > command line / eclipse plugin).
> > 2. we're working on enabling the findbugs per patch as soon as gerrit is
> > back to normal state.
> > 
> > > > 
> > > > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4389/changes#detail
> > > > 
> > > > Eyal.
> > > > 
> > > > ----- Original Message -----
> > > > > From: "Jenkins ci oVirt Server" <jenkins at ovirt.org>
> > > > > To: eedri at redhat.com, yzaslavs at redhat.com, dcaro at redhat.com, "juan
> > > > > hernandez" <juan.hernandez at redhat.com>
> > > > > Sent: Friday, June 7, 2013 3:09:59 PM
> > > > > Subject: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4393 -
> > > > > Still
> > > > > Unstable!
> > > > > 
> > > > > Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
> > > > > Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4393/
> > > > > Build Number: 4393
> > > > > Build Status:  Still Unstable
> > > > > Triggered By: Started by an SCM change
> > > > > 
> > > > > -------------------------------------
> > > > > Changes Since Last Success:
> > > > > -------------------------------------
> > > > > Changes for Build #4389
> > > > > [Shahar Havivi] findbugs: resultSet is not close after use
> > > > > 
> > > > > [Shahar Havivi] findbugs: inaccurate floating point comparison
> > > > > 
> > > > > [Shahar Havivi] findbugs: Unwritten public fields
> > > > > 
> > > > > [Alona Kaplan] engine: multiple gateways
> > > > > 
> > > > > 
> > > > > Changes for Build #4390
> > > > > [Alon Bar-Lev] novnc: no need to raise terminate exception on
> > > > > termination
> > > > > 
> > > > > 
> > > > > Changes for Build #4391
> > > > > [Alon Bar-Lev] novnc: cleanup defaults file
> > > > > 
> > > > > [Alon Bar-Lev] novnc: log file is actually trace file
> > > > > 
> > > > > [Alon Bar-Lev] novnc: override get_target instead of new_client
> > > > > 
> > > > > [Alon Bar-Lev] novnc: use service debug instead of configuration
> > > > > 
> > > > > [Alon Bar-Lev] packaging: service: add debug when module returns
> > > > > 
> > > > > 
> > > > > Changes for Build #4392
> > > > > [Sahina Bose] engine: Multiple gateways test failure fixed
> > > > > 
> > > > > 
> > > > > Changes for Build #4393
> > > > > [Juan Hernandez] core: Make GUID encoders singletons
> > > > > 
> > > > > 
> > > > > 
> > > > > 
> > > > > -----------------
> > > > > Failed Tests:
> > > > > -----------------
> > > > > No tests ran.
> > > > > 
> > > > > 
> > > 
> 


From shaharh at redhat.com  Sun Jun  9 09:00:37 2013
From: shaharh at redhat.com (Shahar Havivi)
Date: Sun, 9 Jun 2013 12:00:37 +0300
Subject: [Engine-devel] [oVirt Jenkins] ovirt_engine_find_bugs - Build #
 4393 - Still Unstable!
In-Reply-To: <1030420491.429393.1370766721448.JavaMail.root@redhat.com>
References: <1852944023.5603.1370598531001.JavaMail.jenkins@jenkins.ovirt.org>
	<1562314012.5620.1370607000581.JavaMail.jenkins@jenkins.ovirt.org>
	<329930531.186757.1370633762080.JavaMail.root@redhat.com>
	<20130608131006.GA30431@redhat.com>
	<271148215.379805.1370724392610.JavaMail.root@redhat.com>
	<20130609082105.GC15123@redhat.com>
	<1030420491.429393.1370766721448.JavaMail.root@redhat.com>
Message-ID: <20130609090036.GE15123@redhat.com>

Merged...

On 09.06.13 04:32, Eyal Edri wrote:
> thanks.
> 
> once it's merged and job is back to stable, we'll enable back the per-patch job.
> 
> eyal.
> 
> ----- Original Message -----
> > From: "Shahar Havivi" <shaharh at redhat.com>
> > To: "Eyal Edri" <eedri at redhat.com>
> > Cc: "Alona Kaplan" <alkaplan at redhat.com>, "engine-devel" <engine-devel at ovirt.org>, "infra" <infra at ovirt.org>
> > Sent: Sunday, June 9, 2013 11:21:07 AM
> > Subject: Re: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4393 - Still Unstable!
> > 
> > it was my commit and I sent a fix to:
> > http://gerrit.ovirt.org/#/c/15474/
> > 
> > On 08.06.13 16:46, Eyal Edri wrote:
> > > 
> > > 
> > > ----- Original Message -----
> > > > From: "Shahar Havivi" <shaharh at redhat.com>
> > > > To: "Eyal Edri" <eedri at redhat.com>
> > > > Cc: "Alona Kaplan" <alkaplan at redhat.com>, "engine-devel"
> > > > <engine-devel at ovirt.org>, "infra" <infra at ovirt.org>
> > > > Sent: Saturday, June 8, 2013 4:10:07 PM
> > > > Subject: Re: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4393 -
> > > > Still Unstable!
> > > > 
> > > > On 07.06.13 15:36, Eyal Edri wrote:
> > > > > fyi,
> > > > > 
> > > > > your last commits add NORAMAL & HIGH priority FINDBUGS issues.
> > > > > 
> > > > > please resolve asap.
> > > > Need to check,
> > > > Please note that when fixing a findbugs issue a new issue/s can be found.
> > > 
> > > 1. you can run findbugs maven plugin before you merge your patch (via
> > > command line / eclipse plugin).
> > > 2. we're working on enabling the findbugs per patch as soon as gerrit is
> > > back to normal state.
> > > 
> > > > > 
> > > > > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4389/changes#detail
> > > > > 
> > > > > Eyal.
> > > > > 
> > > > > ----- Original Message -----
> > > > > > From: "Jenkins ci oVirt Server" <jenkins at ovirt.org>
> > > > > > To: eedri at redhat.com, yzaslavs at redhat.com, dcaro at redhat.com, "juan
> > > > > > hernandez" <juan.hernandez at redhat.com>
> > > > > > Sent: Friday, June 7, 2013 3:09:59 PM
> > > > > > Subject: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4393 -
> > > > > > Still
> > > > > > Unstable!
> > > > > > 
> > > > > > Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
> > > > > > Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4393/
> > > > > > Build Number: 4393
> > > > > > Build Status:  Still Unstable
> > > > > > Triggered By: Started by an SCM change
> > > > > > 
> > > > > > -------------------------------------
> > > > > > Changes Since Last Success:
> > > > > > -------------------------------------
> > > > > > Changes for Build #4389
> > > > > > [Shahar Havivi] findbugs: resultSet is not close after use
> > > > > > 
> > > > > > [Shahar Havivi] findbugs: inaccurate floating point comparison
> > > > > > 
> > > > > > [Shahar Havivi] findbugs: Unwritten public fields
> > > > > > 
> > > > > > [Alona Kaplan] engine: multiple gateways
> > > > > > 
> > > > > > 
> > > > > > Changes for Build #4390
> > > > > > [Alon Bar-Lev] novnc: no need to raise terminate exception on
> > > > > > termination
> > > > > > 
> > > > > > 
> > > > > > Changes for Build #4391
> > > > > > [Alon Bar-Lev] novnc: cleanup defaults file
> > > > > > 
> > > > > > [Alon Bar-Lev] novnc: log file is actually trace file
> > > > > > 
> > > > > > [Alon Bar-Lev] novnc: override get_target instead of new_client
> > > > > > 
> > > > > > [Alon Bar-Lev] novnc: use service debug instead of configuration
> > > > > > 
> > > > > > [Alon Bar-Lev] packaging: service: add debug when module returns
> > > > > > 
> > > > > > 
> > > > > > Changes for Build #4392
> > > > > > [Sahina Bose] engine: Multiple gateways test failure fixed
> > > > > > 
> > > > > > 
> > > > > > Changes for Build #4393
> > > > > > [Juan Hernandez] core: Make GUID encoders singletons
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > -----------------
> > > > > > Failed Tests:
> > > > > > -----------------
> > > > > > No tests ran.
> > > > > > 
> > > > > > 
> > > > 
> > 


From omasad at redhat.com  Sun Jun  9 12:41:17 2013
From: omasad at redhat.com (Ofri Masad)
Date: Sun, 9 Jun 2013 08:41:17 -0400 (EDT)
Subject: [Engine-devel] Network Quality of Service 3.3 - Feature page (NEW)
In-Reply-To: <200277630.7964602.1370781444653.JavaMail.root@redhat.com>
Message-ID: <1916733655.7964713.1370781677373.JavaMail.root@redhat.com>

Hi all,

A new Feature page for "Network Quality of Service" feature was published.
New design include "VNIC Profile" design.

http://www.ovirt.org/Features/Network_QoS

Feature was dramatically changed since last Feature page was published.
You are more than welcome to share you thoughts and insights.

Full detailed implementation page will be available soon.

Thanks,
Ofri.


From abonas at redhat.com  Sun Jun  9 13:32:09 2013
From: abonas at redhat.com (Alissa Bonas)
Date: Sun, 9 Jun 2013 09:32:09 -0400 (EDT)
Subject: [Engine-devel] Guest Reboot
In-Reply-To: <1845391574.16328760.1370622751837.JavaMail.root@redhat.com>
References: <1845391574.16328760.1370622751837.JavaMail.root@redhat.com>
Message-ID: <2042273794.20453738.1370784729353.JavaMail.root@redhat.com>

I think that the icon suggested in the wiki looks more like "refresh" , and it's not clear it indicates a reboot action (which is more heavy than just a refresh).
I suggest as alternative something like the "run VM" icon (the triangle - that already exists in the engine and users know what it means), and with it the arrows from the "refresh" icon.
Please see attached.


----- Original Message -----
> From: "Martin Betak" <mbetak at redhat.com>
> To: engine-devel at ovirt.org
> Sent: Friday, June 7, 2013 7:32:31 PM
> Subject: [Engine-devel] Guest Reboot
> 
> Hi, engine-devel
> 
> Customers request the ability to reboot a VM with a single click so I started
> designing the overall architecture and planing out the required changes to
> the respective components.
> You can find the wiki page for the initial draft at [1] and I would like to
> ask you for your input on my general design and potential issues that could
> arise in some corner cases.
> Please feel free to respond to this thread or add to the Issues section of
> [1].
> 
> Thanks in advance for your opinions :-)
> 
> Martin
> 
> [1] http://www.ovirt.org/Features/Guest_Reboot
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: RebootSuggestion.png
Type: image/png
Size: 15372 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130609/0ae15eb2/attachment.png>

From eedri at redhat.com  Sun Jun  9 15:29:02 2013
From: eedri at redhat.com (Eyal Edri)
Date: Sun, 9 Jun 2013 11:29:02 -0400 (EDT)
Subject: [Engine-devel] [oVirt Jenkins] ovirt_engine_find_bugs - Build #
 4398 - Still Unstable!
In-Reply-To: <1805841124.5954.1370782090977.JavaMail.jenkins@jenkins.ovirt.org>
References: <1063590855.5947.1370779137894.JavaMail.jenkins@jenkins.ovirt.org>
	<1805841124.5954.1370782090977.JavaMail.jenkins@jenkins.ovirt.org>
Message-ID: <140258409.483532.1370791742147.JavaMail.root@redhat.com>

fyi,

findbugs is still failing on NORMAL priority bugs.
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4398/findbugsResult/NORMAL/?

<snip>
Commit 44687e0b885a478e3ddbd39376be5d4e9beb07d1 by Shahar Havivi
findbugs: remove unread fields

Change-Id: Ied4990cd90e58e566679851b3e2c5dcde05629cd
</snip>

please resolve asap, this might hide other new bugs introduced. 

Eyal.
infra team.


----- Original Message -----
> From: "Jenkins ci oVirt Server" <jenkins at ovirt.org>
> To: eedri at redhat.com, yzaslavs at redhat.com, dcaro at redhat.com, shavivi at redhat.com, abonas at redhat.com
> Sent: Sunday, June 9, 2013 3:48:10 PM
> Subject: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4398 - Still Unstable!
> 
> Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
> Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4398/
> Build Number: 4398
> Build Status:  Still Unstable
> Triggered By: Started by an SCM change, Started by an SCM change
> 
> -------------------------------------
> Changes Since Last Success:
> -------------------------------------
> Changes for Build #4389
> [Shahar Havivi] findbugs: resultSet is not close after use
> 
> [Shahar Havivi] findbugs: inaccurate floating point comparison
> 
> [Shahar Havivi] findbugs: Unwritten public fields
> 
> [Alona Kaplan] engine: multiple gateways
> 
> 
> Changes for Build #4390
> [Alon Bar-Lev] novnc: no need to raise terminate exception on termination
> 
> 
> Changes for Build #4391
> [Alon Bar-Lev] novnc: cleanup defaults file
> 
> [Alon Bar-Lev] novnc: log file is actually trace file
> 
> [Alon Bar-Lev] novnc: override get_target instead of new_client
> 
> [Alon Bar-Lev] novnc: use service debug instead of configuration
> 
> [Alon Bar-Lev] packaging: service: add debug when module returns
> 
> 
> Changes for Build #4392
> [Sahina Bose] engine: Multiple gateways test failure fixed
> 
> 
> Changes for Build #4393
> [Juan Hernandez] core: Make GUID encoders singletons
> 
> 
> Changes for Build #4394
> [Shahar Havivi] findbugs: fix for inaccurate floating point comparison
> 
> 
> Changes for Build #4395
> [Ori Liel] restapi: RSDL rename power_management.user_name-->username
> (#969097)
> 
> 
> Changes for Build #4396
> [Ori Liel] restapi: RSDL Missing 'fence_type' param - #969797
> 
> [Ravi Nori] restapi : memory_policy-guaranteed option doesn't exists in 'add
> vm' autocompletion
> 
> 
> Changes for Build #4397
> [Moti Asayag] engine: Use NetworkUtils.getEngineNetwork where possible
> 
> [Moti Asayag] engine: Some network cleanups
> 
> 
> Changes for Build #4398
> [Alissa Bonas] core: rename methods to start with lowercase
> 
> [Shahar Havivi] findbugs: ignore: Log interface should not be the same as the
> implemented class name
> 
> [Shahar Havivi] findbugs: ignore Unwritten public fields
> 
> [Shahar Havivi] findbugs: remove unread fields
> 
> 
> 
> 
> -----------------
> Failed Tests:
> -----------------
> No tests ran.
> 
> 


From shaharh at redhat.com  Sun Jun  9 16:22:57 2013
From: shaharh at redhat.com (Shahar Havivi)
Date: Sun, 9 Jun 2013 19:22:57 +0300
Subject: [Engine-devel] [oVirt Jenkins] ovirt_engine_find_bugs - Build #
 4398 - Still Unstable!
In-Reply-To: <140258409.483532.1370791742147.JavaMail.root@redhat.com>
References: <1063590855.5947.1370779137894.JavaMail.jenkins@jenkins.ovirt.org>
	<1805841124.5954.1370782090977.JavaMail.jenkins@jenkins.ovirt.org>
	<140258409.483532.1370791742147.JavaMail.root@redhat.com>
Message-ID: <20130609162256.GA27221@redhat.com>

patch:
http://gerrit.ovirt.org/#/c/15494/

On 09.06.13 11:29, Eyal Edri wrote:
> fyi,
> 
> findbugs is still failing on NORMAL priority bugs.
> http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4398/findbugsResult/NORMAL/?
> 
> <snip>
> Commit 44687e0b885a478e3ddbd39376be5d4e9beb07d1 by Shahar Havivi
> findbugs: remove unread fields
> 
> Change-Id: Ied4990cd90e58e566679851b3e2c5dcde05629cd
> </snip>
> 
> please resolve asap, this might hide other new bugs introduced. 
> 
> Eyal.
> infra team.
> 
> 
> ----- Original Message -----
> > From: "Jenkins ci oVirt Server" <jenkins at ovirt.org>
> > To: eedri at redhat.com, yzaslavs at redhat.com, dcaro at redhat.com, shavivi at redhat.com, abonas at redhat.com
> > Sent: Sunday, June 9, 2013 3:48:10 PM
> > Subject: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4398 - Still Unstable!
> > 
> > Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
> > Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4398/
> > Build Number: 4398
> > Build Status:  Still Unstable
> > Triggered By: Started by an SCM change, Started by an SCM change
> > 
> > -------------------------------------
> > Changes Since Last Success:
> > -------------------------------------
> > Changes for Build #4389
> > [Shahar Havivi] findbugs: resultSet is not close after use
> > 
> > [Shahar Havivi] findbugs: inaccurate floating point comparison
> > 
> > [Shahar Havivi] findbugs: Unwritten public fields
> > 
> > [Alona Kaplan] engine: multiple gateways
> > 
> > 
> > Changes for Build #4390
> > [Alon Bar-Lev] novnc: no need to raise terminate exception on termination
> > 
> > 
> > Changes for Build #4391
> > [Alon Bar-Lev] novnc: cleanup defaults file
> > 
> > [Alon Bar-Lev] novnc: log file is actually trace file
> > 
> > [Alon Bar-Lev] novnc: override get_target instead of new_client
> > 
> > [Alon Bar-Lev] novnc: use service debug instead of configuration
> > 
> > [Alon Bar-Lev] packaging: service: add debug when module returns
> > 
> > 
> > Changes for Build #4392
> > [Sahina Bose] engine: Multiple gateways test failure fixed
> > 
> > 
> > Changes for Build #4393
> > [Juan Hernandez] core: Make GUID encoders singletons
> > 
> > 
> > Changes for Build #4394
> > [Shahar Havivi] findbugs: fix for inaccurate floating point comparison
> > 
> > 
> > Changes for Build #4395
> > [Ori Liel] restapi: RSDL rename power_management.user_name-->username
> > (#969097)
> > 
> > 
> > Changes for Build #4396
> > [Ori Liel] restapi: RSDL Missing 'fence_type' param - #969797
> > 
> > [Ravi Nori] restapi : memory_policy-guaranteed option doesn't exists in 'add
> > vm' autocompletion
> > 
> > 
> > Changes for Build #4397
> > [Moti Asayag] engine: Use NetworkUtils.getEngineNetwork where possible
> > 
> > [Moti Asayag] engine: Some network cleanups
> > 
> > 
> > Changes for Build #4398
> > [Alissa Bonas] core: rename methods to start with lowercase
> > 
> > [Shahar Havivi] findbugs: ignore: Log interface should not be the same as the
> > implemented class name
> > 
> > [Shahar Havivi] findbugs: ignore Unwritten public fields
> > 
> > [Shahar Havivi] findbugs: remove unread fields
> > 
> > 
> > 
> > 
> > -----------------
> > Failed Tests:
> > -----------------
> > No tests ran.
> > 
> > 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel


From shaharh at redhat.com  Sun Jun  9 19:18:23 2013
From: shaharh at redhat.com (Shahar Havivi)
Date: Sun, 9 Jun 2013 22:18:23 +0300
Subject: [Engine-devel] [oVirt Jenkins] ovirt_engine_find_bugs - Build #
 4398 - Still Unstable!
In-Reply-To: <20130609162256.GA27221@redhat.com>
References: <1063590855.5947.1370779137894.JavaMail.jenkins@jenkins.ovirt.org>
	<1805841124.5954.1370782090977.JavaMail.jenkins@jenkins.ovirt.org>
	<140258409.483532.1370791742147.JavaMail.root@redhat.com>
	<20130609162256.GA27221@redhat.com>
Message-ID: <20130609191822.GB27221@redhat.com>

On 09.06.13 19:22, Shahar Havivi wrote:
> patch:
> http://gerrit.ovirt.org/#/c/15494/
Merged...

> 
> On 09.06.13 11:29, Eyal Edri wrote:
> > fyi,
> > 
> > findbugs is still failing on NORMAL priority bugs.
> > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4398/findbugsResult/NORMAL/?
> > 
> > <snip>
> > Commit 44687e0b885a478e3ddbd39376be5d4e9beb07d1 by Shahar Havivi
> > findbugs: remove unread fields
> > 
> > Change-Id: Ied4990cd90e58e566679851b3e2c5dcde05629cd
> > </snip>
> > 
> > please resolve asap, this might hide other new bugs introduced. 
> > 
> > Eyal.
> > infra team.
> > 
> > 
> > ----- Original Message -----
> > > From: "Jenkins ci oVirt Server" <jenkins at ovirt.org>
> > > To: eedri at redhat.com, yzaslavs at redhat.com, dcaro at redhat.com, shavivi at redhat.com, abonas at redhat.com
> > > Sent: Sunday, June 9, 2013 3:48:10 PM
> > > Subject: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4398 - Still Unstable!
> > > 
> > > Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
> > > Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4398/
> > > Build Number: 4398
> > > Build Status:  Still Unstable
> > > Triggered By: Started by an SCM change, Started by an SCM change
> > > 
> > > -------------------------------------
> > > Changes Since Last Success:
> > > -------------------------------------
> > > Changes for Build #4389
> > > [Shahar Havivi] findbugs: resultSet is not close after use
> > > 
> > > [Shahar Havivi] findbugs: inaccurate floating point comparison
> > > 
> > > [Shahar Havivi] findbugs: Unwritten public fields
> > > 
> > > [Alona Kaplan] engine: multiple gateways
> > > 
> > > 
> > > Changes for Build #4390
> > > [Alon Bar-Lev] novnc: no need to raise terminate exception on termination
> > > 
> > > 
> > > Changes for Build #4391
> > > [Alon Bar-Lev] novnc: cleanup defaults file
> > > 
> > > [Alon Bar-Lev] novnc: log file is actually trace file
> > > 
> > > [Alon Bar-Lev] novnc: override get_target instead of new_client
> > > 
> > > [Alon Bar-Lev] novnc: use service debug instead of configuration
> > > 
> > > [Alon Bar-Lev] packaging: service: add debug when module returns
> > > 
> > > 
> > > Changes for Build #4392
> > > [Sahina Bose] engine: Multiple gateways test failure fixed
> > > 
> > > 
> > > Changes for Build #4393
> > > [Juan Hernandez] core: Make GUID encoders singletons
> > > 
> > > 
> > > Changes for Build #4394
> > > [Shahar Havivi] findbugs: fix for inaccurate floating point comparison
> > > 
> > > 
> > > Changes for Build #4395
> > > [Ori Liel] restapi: RSDL rename power_management.user_name-->username
> > > (#969097)
> > > 
> > > 
> > > Changes for Build #4396
> > > [Ori Liel] restapi: RSDL Missing 'fence_type' param - #969797
> > > 
> > > [Ravi Nori] restapi : memory_policy-guaranteed option doesn't exists in 'add
> > > vm' autocompletion
> > > 
> > > 
> > > Changes for Build #4397
> > > [Moti Asayag] engine: Use NetworkUtils.getEngineNetwork where possible
> > > 
> > > [Moti Asayag] engine: Some network cleanups
> > > 
> > > 
> > > Changes for Build #4398
> > > [Alissa Bonas] core: rename methods to start with lowercase
> > > 
> > > [Shahar Havivi] findbugs: ignore: Log interface should not be the same as the
> > > implemented class name
> > > 
> > > [Shahar Havivi] findbugs: ignore Unwritten public fields
> > > 
> > > [Shahar Havivi] findbugs: remove unread fields
> > > 
> > > 
> > > 
> > > 
> > > -----------------
> > > Failed Tests:
> > > -----------------
> > > No tests ran.
> > > 
> > > 
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel


From mbetak at redhat.com  Mon Jun 10 10:02:10 2013
From: mbetak at redhat.com (Martin Betak)
Date: Mon, 10 Jun 2013 06:02:10 -0400 (EDT)
Subject: [Engine-devel] Guest Reboot
In-Reply-To: <2042273794.20453738.1370784729353.JavaMail.root@redhat.com>
References: <1845391574.16328760.1370622751837.JavaMail.root@redhat.com>
	<2042273794.20453738.1370784729353.JavaMail.root@redhat.com>
Message-ID: <686299676.16874924.1370858530364.JavaMail.root@redhat.com>


----- Original Message -----
> From: "Alissa Bonas" <abonas at redhat.com>
> To: "Martin Betak" <mbetak at redhat.com>
> Cc: engine-devel at ovirt.org
> Sent: Sunday, June 9, 2013 3:32:09 PM
> Subject: Re: [Engine-devel] Guest Reboot
> 
> I think that the icon suggested in the wiki looks more like "refresh" , and
> it's not clear it indicates a reboot action (which is more heavy than just a
> refresh).
> I suggest as alternative something like the "run VM" icon (the triangle -
> that already exists in the engine and users know what it means), and with it
> the arrows from the "refresh" icon.
> Please see attached.
> 

Of course, the suggested icon was only to give the impression of "rotating arrow".
The final design I will leave up to the UX experts :-)


From mbetak at redhat.com  Mon Jun 10 10:29:29 2013
From: mbetak at redhat.com (Martin Betak)
Date: Mon, 10 Jun 2013 06:29:29 -0400 (EDT)
Subject: [Engine-devel] Guest Reboot
In-Reply-To: <1807322852.21193953.1370760714128.JavaMail.root@redhat.com>
References: <1845391574.16328760.1370622751837.JavaMail.root@redhat.com>
	<1807322852.21193953.1370760714128.JavaMail.root@redhat.com>
Message-ID: <1040032913.16882363.1370860169358.JavaMail.root@redhat.com>





----- Original Message -----
> From: "Omer Frenkel" <ofrenkel at redhat.com>
> To: "Martin Betak" <mbetak at redhat.com>
> Cc: engine-devel at ovirt.org
> Sent: Sunday, June 9, 2013 8:51:54 AM
> Subject: Re: [Engine-devel] Guest Reboot
> 
> As i understand it, reboot will do shutdown and initiate a run-command in
> order to send any updated parameters,
> if this is correct, why vdsm and GA need to know its a reboot? guest is
> shutting down, no?

Well in some cases where the VM configuration hasn't changed we can do graceful reboot using 
libvirt acpi reboot capabilities  via guest agent (by just passing different option to the existing shutdown script).
This preserves the qemu process and can be more efficient than the destroy(); start() sequence.
Of course if it were the case that the guest would not respond to graceful method of reboot and the 
power-down policy for this VM "hard", the engine would fall back to the destroy(); start() sequence. 
Otherwise (graceful-only reboot policy) we would leave the guest alone -> status UP.

> 
> it would be better to add some info on stateless issue: when stateless vm
> goes down, its state is cleared,
> so need to decide if reboot to stateless means also start with new state or
> no.

I think this issue is similar to the Run-Once question. 
Do we want to give the user another option to choose from or do we pick one for him?

> 
> similar is vm from pool: when vm from automatic pool goes down, it "returns"
> to the pool, and not belong to a specific user anymore,
> also here the state is cleared, so again need to understand the correct
> behaviour
> 

In the case of vm from pool the state treatment should be the same as in stateless but we also need 
to run the stop(); start() sequence in a transaction to make sure nobody else can "steal" this machine from this user. 
Or possibly since pool-VM configuration cannot change we could perhaps do the reboot only using the new vdsm capabilities. 
Do you think this would be possible or the engine would "notice" that the VM went Down for a brief moment?
Maybe a new VM state "Rebooting" instead of Down would help in this case?


From dfediuck at redhat.com  Mon Jun 10 12:43:14 2013
From: dfediuck at redhat.com (Doron Fediuck)
Date: Mon, 10 Jun 2013 08:43:14 -0400 (EDT)
Subject: [Engine-devel] Guest Reboot
In-Reply-To: <1845391574.16328760.1370622751837.JavaMail.root@redhat.com>
References: <1845391574.16328760.1370622751837.JavaMail.root@redhat.com>
Message-ID: <1043824375.21601013.1370868194232.JavaMail.root@redhat.com>

----- Original Message -----
> From: "Martin Betak" <mbetak at redhat.com>
> To: engine-devel at ovirt.org
> Sent: Friday, June 7, 2013 7:32:31 PM
> Subject: [Engine-devel] Guest Reboot
> 
> Hi, engine-devel
> 
> Customers request the ability to reboot a VM with a single click so I started
> designing the overall architecture and planing out the required changes to
> the respective components.
> You can find the wiki page for the initial draft at [1] and I would like to
> ask you for your input on my general design and potential issues that could
> arise in some corner cases.
> Please feel free to respond to this thread or add to the Issues section of
> [1].
> 
> Thanks in advance for your opinions :-)
> 
> Martin
> 
> [1] http://www.ovirt.org/Features/Guest_Reboot

Hi Martin,
Starting version 3.3 we'll enable a fully operational watchdog device.
This device is capable of auto-restarting a guest in case something
goes wrong in the guest (BSOD / kernel panic). This may handle some
of your use cases but not all of them.

My only request from you is to verify the reboot expected behavior
in VMs who are actively using a watchdog device set to restart the
guest. Otherwise users will see conflicts and/or double reboots.

The VM configuration may or may not include a guest agent and a
watchdog device. A watchdog device may reset (reboot) the guest,
but may also pause it for debugging purposes or simply do nothing.
So a table that lists VM configuration and expected behavior should
probably clarify everything and prevent implementation issues.

Doron


From lpeer at redhat.com  Mon Jun 10 12:44:34 2013
From: lpeer at redhat.com (Livnat Peer)
Date: Mon, 10 Jun 2013 15:44:34 +0300
Subject: [Engine-devel] Performance and scalability
In-Reply-To: <1247864565.11509776.1370346235729.JavaMail.root@redhat.com>
References: <1247864565.11509776.1370346235729.JavaMail.root@redhat.com>
Message-ID: <51B5CA32.6060107@redhat.com>

On 06/04/2013 02:43 PM, Liran Zelkha wrote:
> Hi all,
> 
> I've added a new feature page for Performance and Scalability. Please review and add your ideas... 
> http://www.ovirt.org/Features/Performance_And_Scalability
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
> 

Hi Liran,

Handling performance and scale in oVirt seems very interesting.
I would love to get a better understanding of what the problem is before
viewing the different solutions to solve it.

Can you please describe which scenarios you think we should tune the
performance for and which scale are we looking at?

I think that adding the above to the wiki page would give us a better
ground for discussing the issue.
In addition I suggest polling the users list for issues around
performance and/or scale. Maybe the input would help us focus on tuning
the right flows going forward.

Thanks, Livnat


From gvallare at redhat.com  Mon Jun 10 12:56:21 2013
From: gvallare at redhat.com (Giuseppe Vallarelli)
Date: Mon, 10 Jun 2013 08:56:21 -0400 (EDT)
Subject: [Engine-devel] Add traffic shaping parameters for a network
	interface.
In-Reply-To: <1036978361.21603213.1370868394085.JavaMail.root@redhat.com>
Message-ID: <88074007.21607755.1370868981850.JavaMail.root@redhat.com>

Hi Guys, I've recently submitted a patch to support traffic shaping for a network interface (http://gerrit.ovirt.org/#/c/15445/).
This work is needed in order to support http://www.ovirt.org/Features/Network_QoS .
Given:

'specParams': {'inbound': {'average': '1000', 'peak': '5000', 'burst': '1024'},                                                                                                                 
               'outbound': {'average': '128', 'burst': '256'}}}

Generated xml is the following one:

<bandwidth>
<inbound average="1000" burst="1024" peak="5000"/>
<outbound average="128" burst="256"/>
</bandwidth>

As you can see I tried to keep the data structure as flat as possible having the bandwidth element not carrying any useful information.
Feedback is highly appreciated.

Cheers, Giuseppe.


From liran.zelkha at gmail.com  Mon Jun 10 13:51:41 2013
From: liran.zelkha at gmail.com (Liran Zelkha)
Date: Mon, 10 Jun 2013 16:51:41 +0300
Subject: [Engine-devel] Performance and scalability
In-Reply-To: <51B5CA32.6060107@redhat.com>
References: <1247864565.11509776.1370346235729.JavaMail.root@redhat.com>
	<51B5CA32.6060107@redhat.com>
Message-ID: <CAJ3aYLfHGA-t0qYb_PkEF_9ktdwGs2Y4reJBPaVJEXyK6m683A@mail.gmail.com>

Will do. Thanks.


On Mon, Jun 10, 2013 at 3:44 PM, Livnat Peer <lpeer at redhat.com> wrote:

> On 06/04/2013 02:43 PM, Liran Zelkha wrote:
> > Hi all,
> >
> > I've added a new feature page for Performance and Scalability. Please
> review and add your ideas...
> > http://www.ovirt.org/Features/Performance_And_Scalability
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> >
> >
>
> Hi Liran,
>
> Handling performance and scale in oVirt seems very interesting.
> I would love to get a better understanding of what the problem is before
> viewing the different solutions to solve it.
>
> Can you please describe which scenarios you think we should tune the
> performance for and which scale are we looking at?
>
> I think that adding the above to the wiki page would give us a better
> ground for discussing the issue.
> In addition I suggest polling the users list for issues around
> performance and/or scale. Maybe the input would help us focus on tuning
> the right flows going forward.
>
> Thanks, Livnat
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130610/58998a6f/attachment.html>

From danken at redhat.com  Mon Jun 10 14:22:54 2013
From: danken at redhat.com (Dan Kenigsberg)
Date: Mon, 10 Jun 2013 17:22:54 +0300
Subject: [Engine-devel] Add traffic shaping parameters for a network
 interface.
In-Reply-To: <88074007.21607755.1370868981850.JavaMail.root@redhat.com>
References: <1036978361.21603213.1370868394085.JavaMail.root@redhat.com>
	<88074007.21607755.1370868981850.JavaMail.root@redhat.com>
Message-ID: <20130610142254.GG5384@redhat.com>

On Mon, Jun 10, 2013 at 08:56:21AM -0400, Giuseppe Vallarelli wrote:
> Hi Guys, I've recently submitted a patch to support traffic shaping for a network interface (http://gerrit.ovirt.org/#/c/15445/).
> This work is needed in order to support http://www.ovirt.org/Features/Network_QoS .
> Given:
> 
> 'specParams': {'inbound': {'average': '1000', 'peak': '5000', 'burst': '1024'},
>                'outbound': {'average': '128', 'burst': '256'}}}
> 
> Generated xml is the following one:
> 
> <bandwidth>
> <inbound average="1000" burst="1024" peak="5000"/>
> <outbound average="128" burst="256"/>
> </bandwidth>
> 
> As you can see I tried to keep the data structure as flat as possible having the bandwidth element not carrying any useful information.
> Feedback is highly appreciated.
> 

The issue has not been mentioned on the wiki page, but may need a means
to report the currently-configured QoS of each vNIC from Vdsm to Engine.
For example, when a VM is de-hibernated, we may want to tell whether its
QoS needs to be set according to a recently-tweaked policy.

I suggest that we use the "getVmList" verb of Vdsm, which is intended to
report "static" properties of one Vm (or all of them).

On the other hand, Engine would want to blindly set new values whenever
in doubt. In such a case, I think that reporting of QoS can be avoided.

Dan.


From gvallare at redhat.com  Mon Jun 10 15:04:27 2013
From: gvallare at redhat.com (Giuseppe Vallarelli)
Date: Mon, 10 Jun 2013 11:04:27 -0400 (EDT)
Subject: [Engine-devel] Add traffic shaping parameters for a network
 interface.
In-Reply-To: <20130610142254.GG5384@redhat.com>
References: <1036978361.21603213.1370868394085.JavaMail.root@redhat.com>
	<88074007.21607755.1370868981850.JavaMail.root@redhat.com>
	<20130610142254.GG5384@redhat.com>
Message-ID: <903977162.21814892.1370876667370.JavaMail.root@redhat.com>

----- Original Message -----
| From: "Dan Kenigsberg" <danken at redhat.com>
| To: "Giuseppe Vallarelli" <gvallare at redhat.com>
| Cc: engine-devel at ovirt.org
| Sent: Monday, June 10, 2013 4:22:54 PM
| Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface.
| 
| On Mon, Jun 10, 2013 at 08:56:21AM -0400, Giuseppe Vallarelli wrote:
| > Hi Guys, I've recently submitted a patch to support traffic shaping for a
| > network interface (http://gerrit.ovirt.org/#/c/15445/).
| > This work is needed in order to support
| > http://www.ovirt.org/Features/Network_QoS .
| > Given:
| > 
| > 'specParams': {'inbound': {'average': '1000', 'peak': '5000', 'burst':
| > '1024'},
| >                'outbound': {'average': '128', 'burst': '256'}}}
| > 
| > Generated xml is the following one:
| > 
| > 
| > 
| > 
| > 
| > 
| > As you can see I tried to keep the data structure as flat as possible
| > having the bandwidth element not carrying any useful information.
| > Feedback is highly appreciated.
| > 
| 
| The issue has not been mentioned on the wiki page, but may need a means
| to report the currently-configured QoS of each vNIC from Vdsm to Engine.
| For example, when a VM is de-hibernated, we may want to tell whether its
| QoS needs to be set according to a recently-tweaked policy.
| 
| I suggest that we use the "getVmList" verb of Vdsm, which is intended to
| report "static" properties of one Vm (or all of them).
| 
| On the other hand, Engine would want to blindly set new values whenever
| in doubt. In such a case, I think that reporting of QoS can be avoided.
| 
| Dan.
| 

I'm not sure I've understood completely the issue in discussion, doesn't the engine knows already
which are the QoS profile applied to each vNIC ? The last 'tweaked' profile is the one that should
be applied after de-hibernation. This means that on the engine side we should keep track of profile
change, if a change happens de-hibernating a vm triggers a QoS profile update on the host of the
latest profile. I'm not aware of the implementation details so I might be wrong.

Giuseppe. 


From mrao at redhat.com  Mon Jun 10 15:58:12 2013
From: mrao at redhat.com (Malini Rao)
Date: Mon, 10 Jun 2013 11:58:12 -0400 (EDT)
Subject: [Engine-devel] Guest Reboot
In-Reply-To: <2042273794.20453738.1370784729353.JavaMail.root@redhat.com>
References: <1845391574.16328760.1370622751837.JavaMail.root@redhat.com>
	<2042273794.20453738.1370784729353.JavaMail.root@redhat.com>
Message-ID: <857502605.53404230.1370879892213.JavaMail.root@redhat.com>

I think a Power button icon like this one - http://us.123rf.com/400wm/400/400/vipervxw/vipervxw1210/vipervxw121000044/16013272-cool-power-button-in-white-with-blue-led.jpg might work for reboot.

-Malini

----- Original Message -----
From: "Alissa Bonas" <abonas at redhat.com>
To: "Martin Betak" <mbetak at redhat.com>
Cc: engine-devel at ovirt.org
Sent: Sunday, June 9, 2013 9:32:09 AM
Subject: Re: [Engine-devel] Guest Reboot

I think that the icon suggested in the wiki looks more like "refresh" , and it's not clear it indicates a reboot action (which is more heavy than just a refresh).
I suggest as alternative something like the "run VM" icon (the triangle - that already exists in the engine and users know what it means), and with it the arrows from the "refresh" icon.
Please see attached.


----- Original Message -----
> From: "Martin Betak" <mbetak at redhat.com>
> To: engine-devel at ovirt.org
> Sent: Friday, June 7, 2013 7:32:31 PM
> Subject: [Engine-devel] Guest Reboot
> 
> Hi, engine-devel
> 
> Customers request the ability to reboot a VM with a single click so I started
> designing the overall architecture and planing out the required changes to
> the respective components.
> You can find the wiki page for the initial draft at [1] and I would like to
> ask you for your input on my general design and potential issues that could
> arise in some corner cases.
> Please feel free to respond to this thread or add to the Issues section of
> [1].
> 
> Thanks in advance for your opinions :-)
> 
> Martin
> 
> [1] http://www.ovirt.org/Features/Guest_Reboot
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 

_______________________________________________
Engine-devel mailing list
Engine-devel at ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


From dfediuck at redhat.com  Mon Jun 10 16:46:29 2013
From: dfediuck at redhat.com (Doron Fediuck)
Date: Mon, 10 Jun 2013 12:46:29 -0400 (EDT)
Subject: [Engine-devel] Add traffic shaping parameters for a network
 interface.
In-Reply-To: <903977162.21814892.1370876667370.JavaMail.root@redhat.com>
References: <1036978361.21603213.1370868394085.JavaMail.root@redhat.com>
	<88074007.21607755.1370868981850.JavaMail.root@redhat.com>
	<20130610142254.GG5384@redhat.com>
	<903977162.21814892.1370876667370.JavaMail.root@redhat.com>
Message-ID: <247585318.22092746.1370882789300.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Giuseppe Vallarelli" <gvallare at redhat.com>
> To: "Dan Kenigsberg" <danken at redhat.com>
> Cc: engine-devel at ovirt.org
> Sent: Monday, June 10, 2013 6:04:27 PM
> Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface.
> 
> ----- Original Message -----
> | From: "Dan Kenigsberg" <danken at redhat.com>
> | To: "Giuseppe Vallarelli" <gvallare at redhat.com>
> | Cc: engine-devel at ovirt.org
> | Sent: Monday, June 10, 2013 4:22:54 PM
> | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network
> | interface.
> | 
> | On Mon, Jun 10, 2013 at 08:56:21AM -0400, Giuseppe Vallarelli wrote:
> | > Hi Guys, I've recently submitted a patch to support traffic shaping for a
> | > network interface (http://gerrit.ovirt.org/#/c/15445/).
> | > This work is needed in order to support
> | > http://www.ovirt.org/Features/Network_QoS .
> | > Given:
> | > 
> | > 'specParams': {'inbound': {'average': '1000', 'peak': '5000', 'burst':
> | > '1024'},
> | >                'outbound': {'average': '128', 'burst': '256'}}}
> | > 
> | > Generated xml is the following one:
> | > 
> | > 
> | > 
> | > 
> | > 
> | > 
> | > As you can see I tried to keep the data structure as flat as possible
> | > having the bandwidth element not carrying any useful information.
> | > Feedback is highly appreciated.
> | > 
> | 
> | The issue has not been mentioned on the wiki page, but may need a means
> | to report the currently-configured QoS of each vNIC from Vdsm to Engine.
> | For example, when a VM is de-hibernated, we may want to tell whether its
> | QoS needs to be set according to a recently-tweaked policy.
> | 
> | I suggest that we use the "getVmList" verb of Vdsm, which is intended to
> | report "static" properties of one Vm (or all of them).
> | 
> | On the other hand, Engine would want to blindly set new values whenever
> | in doubt. In such a case, I think that reporting of QoS can be avoided.
> | 
> | Dan.
> | 
> 
> I'm not sure I've understood completely the issue in discussion, doesn't the
> engine knows already
> which are the QoS profile applied to each vNIC ? The last 'tweaked' profile
> is the one that should
> be applied after de-hibernation. This means that on the engine side we should
> keep track of profile
> change, if a change happens de-hibernating a vm triggers a QoS profile update
> on the host of the
> latest profile. I'm not aware of the implementation details so I might be
> wrong.
> 
> Giuseppe.

The idea is to handle scenarios where something went wrong;
For example, VDSM crash while starting a new VM, engine crash, etc.
So the engine should be able to ask for current QoS for reporting,
and (re-)apply it if out of sync.


From gvallare at redhat.com  Mon Jun 10 16:54:35 2013
From: gvallare at redhat.com (Giuseppe Vallarelli)
Date: Mon, 10 Jun 2013 12:54:35 -0400 (EDT)
Subject: [Engine-devel] Add traffic shaping parameters for a network
 interface.
In-Reply-To: <247585318.22092746.1370882789300.JavaMail.root@redhat.com>
References: <1036978361.21603213.1370868394085.JavaMail.root@redhat.com>
	<88074007.21607755.1370868981850.JavaMail.root@redhat.com>
	<20130610142254.GG5384@redhat.com>
	<903977162.21814892.1370876667370.JavaMail.root@redhat.com>
	<247585318.22092746.1370882789300.JavaMail.root@redhat.com>
Message-ID: <309960560.22096233.1370883274998.JavaMail.root@redhat.com>

----- Original Message -----
| From: "Doron Fediuck" <dfediuck at redhat.com>
| To: "Giuseppe Vallarelli" <gvallare at redhat.com>
| Cc: "Dan Kenigsberg" <danken at redhat.com>, engine-devel at ovirt.org
| Sent: Monday, June 10, 2013 6:46:29 PM
| Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface.
| 
| 
| 
| ----- Original Message -----
| > From: "Giuseppe Vallarelli" <gvallare at redhat.com>
| > To: "Dan Kenigsberg" <danken at redhat.com>
| > Cc: engine-devel at ovirt.org
| > Sent: Monday, June 10, 2013 6:04:27 PM
| > Subject: Re: [Engine-devel] Add traffic shaping parameters for a network
| > interface.
| > 
| > ----- Original Message -----
| > | From: "Dan Kenigsberg" <danken at redhat.com>
| > | To: "Giuseppe Vallarelli" <gvallare at redhat.com>
| > | Cc: engine-devel at ovirt.org
| > | Sent: Monday, June 10, 2013 4:22:54 PM
| > | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network
| > | interface.
| > | 
| > | On Mon, Jun 10, 2013 at 08:56:21AM -0400, Giuseppe Vallarelli wrote:
| > | > Hi Guys, I've recently submitted a patch to support traffic shaping for
| > | > a
| > | > network interface (http://gerrit.ovirt.org/#/c/15445/).
| > | > This work is needed in order to support
| > | > http://www.ovirt.org/Features/Network_QoS .
| > | > Given:
| > | > 
| > | > 'specParams': {'inbound': {'average': '1000', 'peak': '5000', 'burst':
| > | > '1024'},
| > | >                'outbound': {'average': '128', 'burst': '256'}}}
| > | > 
| > | > Generated xml is the following one:
| > | > 
| > | > 
| > | > 
| > | > 
| > | > 
| > | > 
| > | > As you can see I tried to keep the data structure as flat as possible
| > | > having the bandwidth element not carrying any useful information.
| > | > Feedback is highly appreciated.
| > | > 
| > | 
| > | The issue has not been mentioned on the wiki page, but may need a means
| > | to report the currently-configured QoS of each vNIC from Vdsm to Engine.
| > | For example, when a VM is de-hibernated, we may want to tell whether its
| > | QoS needs to be set according to a recently-tweaked policy.
| > | 
| > | I suggest that we use the "getVmList" verb of Vdsm, which is intended to
| > | report "static" properties of one Vm (or all of them).
| > | 
| > | On the other hand, Engine would want to blindly set new values whenever
| > | in doubt. In such a case, I think that reporting of QoS can be avoided.
| > | 
| > | Dan.
| > | 
| > 
| > I'm not sure I've understood completely the issue in discussion, doesn't
| > the
| > engine knows already
| > which are the QoS profile applied to each vNIC ? The last 'tweaked' profile
| > is the one that should
| > be applied after de-hibernation. This means that on the engine side we
| > should
| > keep track of profile
| > change, if a change happens de-hibernating a vm triggers a QoS profile
| > update
| > on the host of the
| > latest profile. I'm not aware of the implementation details so I might be
| > wrong.
| > 
| > Giuseppe.
| 
| The idea is to handle scenarios where something went wrong;
| For example, VDSM crash while starting a new VM, engine crash, etc.
| So the engine should be able to ask for current QoS for reporting,
| and (re-)apply it if out of sync.
|

Hi Doron, thanks for the feedback, makes sense to me.
Giuseppe 


From djasa at redhat.com  Mon Jun 10 19:20:33 2013
From: djasa at redhat.com (David =?UTF-8?Q?Ja=C5=A1a?=)
Date: Mon, 10 Jun 2013 21:20:33 +0200
Subject: [Engine-devel] Guest Reboot
In-Reply-To: <1845391574.16328760.1370622751837.JavaMail.root@redhat.com>
References: <1845391574.16328760.1370622751837.JavaMail.root@redhat.com>
Message-ID: <1370892033.12051.220.camel@cihla.usersys.redhat.com>

Hi Martin,

there may be more kinds of reboot in context of RHEV: "warm" reboot that
keeps qemu process intact, or "cold" that would involve qemu process
termination and start of new one - and this could be done with keeping
of current configuration, or with applying settings that "take effect
after reboot" that have changed during VM runtime; and all of these can
be "soft" - when the guest OS reboots itself and "hard" when you perform
the reboot right away.

All of these have their use cases, so it should be documented what will
you implement, and you may expect somebody asking you to implement the
rest. ;)

David


Martin Betak p??e v P? 07. 06. 2013 v 12:32 -0400:
> Hi, engine-devel
> 
> Customers request the ability to reboot a VM with a single click so I started designing the overall architecture and planing out the required changes to the respective components. 
> You can find the wiki page for the initial draft at [1] and I would like to ask you for your input on my general design and potential issues that could arise in some corner cases.
> Please feel free to respond to this thread or add to the Issues section of [1].
> 
> Thanks in advance for your opinions :-)
> 
> Martin
> 
> [1] http://www.ovirt.org/Features/Guest_Reboot
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel

-- 

David Ja?a, RHCE

SPICE QE based in Brno
GPG Key:     22C33E24 
Fingerprint: 513A 060B D1B4 2A72 7F0D 0278 B125 CD00 22C3 3E24


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5727 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130610/49089642/attachment.bin>

From thildred at redhat.com  Tue Jun 11 03:46:10 2013
From: thildred at redhat.com (Tim Hildred)
Date: Mon, 10 Jun 2013 23:46:10 -0400 (EDT)
Subject: [Engine-devel] Few detailed REST API questions
In-Reply-To: <D290AD8432118048947689BA3AE8A9B325C28E8F@SACEXCMBX04-PRD.hq.netapp.com>
References: <D290AD8432118048947689BA3AE8A9B325C28E8F@SACEXCMBX04-PRD.hq.netapp.com>
Message-ID: <1581037877.21810448.1370922370791.JavaMail.root@redhat.com>

Hey Chris,

The engine uses a host to do pretty much everything. You'll find that you can't add a data domain to a data center without an active host, either. 

The answer to your question, I think, is that you should specify the SPM host in your data center.

Tim Hildred, RHCE
Content Author II - Engineering Content Services, Red Hat, Inc.
Brisbane, Australia
Email: thildred at redhat.com
Internal: 8588287
Mobile: +61 4 666 25242
IRC: thildred

----- Original Message -----
> From: "Christopher Morrissey" <Christopher.Morrissey at netapp.com>
> To: engine-devel at ovirt.org
> Sent: Thursday, May 30, 2013 1:38:28 AM
> Subject: [Engine-devel] Few detailed REST API questions
> 
> Hi All,
> 
> I'm working with the REST API and have a question that I haven't been able to
> figure out. When destroying a storage domain, it appears that a host is
> required in the storage domain. Can this be any host that has access to that
> domain?
> 
> The storage domain returned through the REST api does not have the host
> populated so I'm not sure how I would figure out a specific host to put in
> there other than to just make sure it's one that can access the domain.
> 
> -Chris
> 
> Chris Morrissey
> Software Engineer
> NetApp Inc.
> 919.476.4428
> 
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From lpeer at redhat.com  Tue Jun 11 06:17:34 2013
From: lpeer at redhat.com (Livnat Peer)
Date: Tue, 11 Jun 2013 09:17:34 +0300
Subject: [Engine-devel] Add traffic shaping parameters for a network
	interface.
In-Reply-To: <247585318.22092746.1370882789300.JavaMail.root@redhat.com>
References: <1036978361.21603213.1370868394085.JavaMail.root@redhat.com>
	<88074007.21607755.1370868981850.JavaMail.root@redhat.com>
	<20130610142254.GG5384@redhat.com>
	<903977162.21814892.1370876667370.JavaMail.root@redhat.com>
	<247585318.22092746.1370882789300.JavaMail.root@redhat.com>
Message-ID: <51B6C0FE.7080600@redhat.com>

On 06/10/2013 07:46 PM, Doron Fediuck wrote:
> 
> 
> ----- Original Message -----
>> From: "Giuseppe Vallarelli" <gvallare at redhat.com>
>> To: "Dan Kenigsberg" <danken at redhat.com>
>> Cc: engine-devel at ovirt.org
>> Sent: Monday, June 10, 2013 6:04:27 PM
>> Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface.
>>
>> ----- Original Message -----
>> | From: "Dan Kenigsberg" <danken at redhat.com>
>> | To: "Giuseppe Vallarelli" <gvallare at redhat.com>
>> | Cc: engine-devel at ovirt.org
>> | Sent: Monday, June 10, 2013 4:22:54 PM
>> | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network
>> | interface.
>> | 
>> | On Mon, Jun 10, 2013 at 08:56:21AM -0400, Giuseppe Vallarelli wrote:
>> | > Hi Guys, I've recently submitted a patch to support traffic shaping for a
>> | > network interface (http://gerrit.ovirt.org/#/c/15445/).
>> | > This work is needed in order to support
>> | > http://www.ovirt.org/Features/Network_QoS .
>> | > Given:
>> | > 
>> | > 'specParams': {'inbound': {'average': '1000', 'peak': '5000', 'burst':
>> | > '1024'},
>> | >                'outbound': {'average': '128', 'burst': '256'}}}
>> | > 
>> | > Generated xml is the following one:
>> | > 
>> | > 
>> | > 
>> | > 
>> | > 
>> | > 
>> | > As you can see I tried to keep the data structure as flat as possible
>> | > having the bandwidth element not carrying any useful information.
>> | > Feedback is highly appreciated.
>> | > 
>> | 
>> | The issue has not been mentioned on the wiki page, but may need a means
>> | to report the currently-configured QoS of each vNIC from Vdsm to Engine.
>> | For example, when a VM is de-hibernated, we may want to tell whether its
>> | QoS needs to be set according to a recently-tweaked policy.
>> | 
>> | I suggest that we use the "getVmList" verb of Vdsm, which is intended to
>> | report "static" properties of one Vm (or all of them).
>> | 
>> | On the other hand, Engine would want to blindly set new values whenever
>> | in doubt. In such a case, I think that reporting of QoS can be avoided.
>> | 
>> | Dan.
>> | 
>>
>> I'm not sure I've understood completely the issue in discussion, doesn't the
>> engine knows already
>> which are the QoS profile applied to each vNIC ? The last 'tweaked' profile
>> is the one that should
>> be applied after de-hibernation. This means that on the engine side we should
>> keep track of profile
>> change, if a change happens de-hibernating a vm triggers a QoS profile update
>> on the host of the
>> latest profile. I'm not aware of the implementation details so I might be
>> wrong.
>>
>> Giuseppe.
> 
> The idea is to handle scenarios where something went wrong;
> For example, VDSM crash while starting a new VM, engine crash, etc.
> So the engine should be able to ask for current QoS for reporting,
> and (re-)apply it if out of sync.


In addition, if we change the VNIC profile we do not require the VMs
that are using this profile to be down.
Now we can reach a state were the profile is configured for one thing
and the VMs using this profile are running with another value.

At least we would like the user to be aware of that.
I'm not sure if we'd like to sync it automatically. I would start only
with exposing this information to our administrator.

Livnat




> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 



From obasan at redhat.com  Tue Jun 11 08:08:25 2013
From: obasan at redhat.com (Ohad Basan)
Date: Tue, 11 Jun 2013 04:08:25 -0400 (EDT)
Subject: [Engine-devel] Ovirt live build failure
In-Reply-To: <134528956.22715588.1370936037503.JavaMail.root@redhat.com>
Message-ID: <1050372831.22787738.1370938105428.JavaMail.root@redhat.com>

Hello everyone.

The jenkins ovirt live job is failing due to libvirt dependency:

Error creating Live CD : Failed to build transaction : vdsm-4.11.0-28.git634b9f4.fc18.x86_64 requires libvirt >= 1.0.2-1

http://jenkins.ovirt.org/job/ovirt_live_create_iso/151/artifact/ovirt-live-1.0.0-0.1.master.20130611.gitc7da94a.log


Does anyone have an idea how to solve it?
the only thing I thought about is compiling libvirt from source in the job itself.

Thanks

Ohad


From michal.skrivanek at redhat.com  Tue Jun 11 08:19:39 2013
From: michal.skrivanek at redhat.com (Michal Skrivanek)
Date: Tue, 11 Jun 2013 10:19:39 +0200
Subject: [Engine-devel] Guest Reboot
In-Reply-To: <1370892033.12051.220.camel@cihla.usersys.redhat.com>
References: <1845391574.16328760.1370622751837.JavaMail.root@redhat.com>
	<1370892033.12051.220.camel@cihla.usersys.redhat.com>
Message-ID: <E3CBDDED-1A72-4350-A6B6-D0A22CC41F78@redhat.com>


On Jun 10, 2013, at 21:20 , David Ja?a <djasa at redhat.com> wrote:

> Hi Martin,
> 
> there may be more kinds of reboot in context of RHEV: "warm" reboot that
> keeps qemu process intact, or "cold" that would involve qemu process
> termination and start of new one - and this could be done with keeping
> of current configuration, or with applying settings that "take effect
> after reboot" that have changed during VM runtime; and all of these can
> be "soft" - when the guest OS reboots itself and "hard" when you perform
> the reboot right away.
we plan to have 2 of them which seem to make most sense
"warm" without applying config changes and keeping qemu process (i.e. also keeps Run Once,Stateless, pooled VM config/state)
"cold" which kills qemu and is completely driven by Engine, and applies config changes
and a policy option in VM properties to specify whether you should forcibly proceed with reboot/shutdown when graceful methods fail/timeout

is there anything not covered for a typical user? We intentionally don't want to provide all possible options, just those making sense. The feature is about providing a convenient shortcut.

Thanks,
michal

> 
> All of these have their use cases, so it should be documented what will
> you implement, and you may expect somebody asking you to implement the
> rest. ;)
> 
> David
> 
> 
> Martin Betak p??e v P? 07. 06. 2013 v 12:32 -0400:
>> Hi, engine-devel
>> 
>> Customers request the ability to reboot a VM with a single click so I started designing the overall architecture and planing out the required changes to the respective components. 
>> You can find the wiki page for the initial draft at [1] and I would like to ask you for your input on my general design and potential issues that could arise in some corner cases.
>> Please feel free to respond to this thread or add to the Issues section of [1].
>> 
>> Thanks in advance for your opinions :-)
>> 
>> Martin
>> 
>> [1] http://www.ovirt.org/Features/Guest_Reboot
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
> -- 
> 
> David Ja?a, RHCE
> 
> SPICE QE based in Brno
> GPG Key:     22C33E24 
> Fingerprint: 513A 060B D1B4 2A72 7F0D 0278 B125 CD00 22C3 3E24
> 
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel



From djasa at redhat.com  Tue Jun 11 08:58:15 2013
From: djasa at redhat.com (David =?UTF-8?Q?Ja=C5=A1a?=)
Date: Tue, 11 Jun 2013 10:58:15 +0200
Subject: [Engine-devel] Guest Reboot
In-Reply-To: <E3CBDDED-1A72-4350-A6B6-D0A22CC41F78@redhat.com>
References: <1845391574.16328760.1370622751837.JavaMail.root@redhat.com>
	<1370892033.12051.220.camel@cihla.usersys.redhat.com>
	<E3CBDDED-1A72-4350-A6B6-D0A22CC41F78@redhat.com>
Message-ID: <1370941095.12051.227.camel@cihla.usersys.redhat.com>

Hi,

Michal Skrivanek p??e v ?t 11. 06. 2013 v 10:19 +0200:
> On Jun 10, 2013, at 21:20 , David Ja?a <djasa at redhat.com> wrote:
> 
> > Hi Martin,
> > 
> > there may be more kinds of reboot in context of RHEV: "warm" reboot that
> > keeps qemu process intact, or "cold" that would involve qemu process
> > termination and start of new one - and this could be done with keeping
> > of current configuration, or with applying settings that "take effect
> > after reboot" that have changed during VM runtime; and all of these can
> > be "soft" - when the guest OS reboots itself and "hard" when you perform
> > the reboot right away.
> we plan to have 2 of them which seem to make most sense
> "warm" without applying config changes and keeping qemu process (i.e. also keeps Run Once,Stateless, pooled VM config/state)
> "cold" which kills qemu and is completely driven by Engine, and applies config changes
> and a policy option in VM properties to specify whether you should forcibly proceed with reboot/shutdown when graceful methods fail/timeout
> 
> is there anything not covered for a typical user? 

I think you covered it all. Based on the original emails by Martin, I
presumed you only covered "warm" reboot, having "cold" reboot available
as well is cool.

David

> We intentionally don't want to provide all possible options, just those making sense. The feature is about providing a convenient shortcut.
> 
> Thanks,
> michal
> 
> > 
> > All of these have their use cases, so it should be documented what will
> > you implement, and you may expect somebody asking you to implement the
> > rest. ;)
> > 
> > David
> > 
> > 
> > Martin Betak p??e v P? 07. 06. 2013 v 12:32 -0400:
> >> Hi, engine-devel
> >> 
> >> Customers request the ability to reboot a VM with a single click so I started designing the overall architecture and planing out the required changes to the respective components. 
> >> You can find the wiki page for the initial draft at [1] and I would like to ask you for your input on my general design and potential issues that could arise in some corner cases.
> >> Please feel free to respond to this thread or add to the Issues section of [1].
> >> 
> >> Thanks in advance for your opinions :-)
> >> 
> >> Martin
> >> 
> >> [1] http://www.ovirt.org/Features/Guest_Reboot
> >> _______________________________________________
> >> Engine-devel mailing list
> >> Engine-devel at ovirt.org
> >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> > -- 
> > 
> > David Ja?a, RHCE
> > 
> > SPICE QE based in Brno
> > GPG Key:     22C33E24 
> > Fingerprint: 513A 060B D1B4 2A72 7F0D 0278 B125 CD00 22C3 3E24
> > 
> > 
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel

-- 

David Ja?a, RHCE

SPICE QE based in Brno
GPG Key:     22C33E24 
Fingerprint: 513A 060B D1B4 2A72 7F0D 0278 B125 CD00 22C3 3E24


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5727 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130611/d3bf7008/attachment.bin>

From ofrenkel at redhat.com  Tue Jun 11 10:26:47 2013
From: ofrenkel at redhat.com (Omer Frenkel)
Date: Tue, 11 Jun 2013 06:26:47 -0400 (EDT)
Subject: [Engine-devel] Guest Reboot
In-Reply-To: <1040032913.16882363.1370860169358.JavaMail.root@redhat.com>
References: <1845391574.16328760.1370622751837.JavaMail.root@redhat.com>
	<1807322852.21193953.1370760714128.JavaMail.root@redhat.com>
	<1040032913.16882363.1370860169358.JavaMail.root@redhat.com>
Message-ID: <137810895.22872855.1370946407760.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Martin Betak" <mbetak at redhat.com>
> To: "Omer Frenkel" <ofrenkel at redhat.com>
> Cc: engine-devel at ovirt.org
> Sent: Monday, June 10, 2013 1:29:29 PM
> Subject: Re: [Engine-devel] Guest Reboot
> 
> 
> 
> 
> 
> ----- Original Message -----
> > From: "Omer Frenkel" <ofrenkel at redhat.com>
> > To: "Martin Betak" <mbetak at redhat.com>
> > Cc: engine-devel at ovirt.org
> > Sent: Sunday, June 9, 2013 8:51:54 AM
> > Subject: Re: [Engine-devel] Guest Reboot
> > 
> > As i understand it, reboot will do shutdown and initiate a run-command in
> > order to send any updated parameters,
> > if this is correct, why vdsm and GA need to know its a reboot? guest is
> > shutting down, no?
> 
> Well in some cases where the VM configuration hasn't changed we can do
> graceful reboot using
> libvirt acpi reboot capabilities  via guest agent (by just passing different
> option to the existing shutdown script).
> This preserves the qemu process and can be more efficient than the destroy();
> start() sequence.
> Of course if it were the case that the guest would not respond to graceful
> method of reboot and the
> power-down policy for this VM "hard", the engine would fall back to the
> destroy(); start() sequence.
> Otherwise (graceful-only reboot policy) we would leave the guest alone ->
> status UP.
> 

ok maybe worth adding this info to the wiki,
although currently there is no way to know if configuration has changed or not,
but should be something like this soon (RFE for changing running vm configuration)

> > 
> > it would be better to add some info on stateless issue: when stateless vm
> > goes down, its state is cleared,
> > so need to decide if reboot to stateless means also start with new state or
> > no.
> 
> I think this issue is similar to the Run-Once question.
> Do we want to give the user another option to choose from or do we pick one
> for him?
> 
> > 
> > similar is vm from pool: when vm from automatic pool goes down, it
> > "returns"
> > to the pool, and not belong to a specific user anymore,
> > also here the state is cleared, so again need to understand the correct
> > behaviour
> > 
> 
> In the case of vm from pool the state treatment should be the same as in
> stateless but we also need
> to run the stop(); start() sequence in a transaction to make sure nobody else
> can "steal" this machine from this user.
> Or possibly since pool-VM configuration cannot change we could perhaps do the
> reboot only using the new vdsm capabilities.
> Do you think this would be possible or the engine would "notice" that the VM
> went Down for a brief moment?

engine have to identify the vm as down before starting it again..

> Maybe a new VM state "Rebooting" instead of Down would help in this case?
> 

not sure this is the best approach, need to do some thinking about this


From lhornyak at redhat.com  Tue Jun 11 11:23:33 2013
From: lhornyak at redhat.com (Laszlo Hornyak)
Date: Tue, 11 Jun 2013 07:23:33 -0400 (EDT)
Subject: [Engine-devel] xml rpc exceptions
Message-ID: <1467027694.14491388.1370949813977.JavaMail.root@redhat.com>

hi,

When starting my VM's I get a strange XML RPC error.

org.xml.sax.SAXException: Serializable objects aren't supported, if isEnabledForExtensions() == false
org.apache.xmlrpc.common.XmlRpcExtensionException: Serializable objects aren't supported, if isEnabledForExtensions() == false

Looks like it is trying to send a Serializable object as parameter to the VDSM, but it is not able to do so. Is anyone handling this issue?

Thx,
Laszlo


From lhornyak at redhat.com  Tue Jun 11 11:54:52 2013
From: lhornyak at redhat.com (Laszlo Hornyak)
Date: Tue, 11 Jun 2013 07:54:52 -0400 (EDT)
Subject: [Engine-devel] xml rpc exceptions
In-Reply-To: <1467027694.14491388.1370949813977.JavaMail.root@redhat.com>
References: <1467027694.14491388.1370949813977.JavaMail.root@redhat.com>
Message-ID: <422141212.14506622.1370951692359.JavaMail.root@redhat.com>

Got it, after Icada39e3918fb053cb0ad0388178ccf5c6338ca2 watchdog devices are attempted to send to vdsm as enum instead of string. Looks like it only happens to watchdogs, I will send a fix soon.

Laszlo

----- Original Message -----
> From: "Laszlo Hornyak" <lhornyak at redhat.com>
> To: "engine-devel" <engine-devel at ovirt.org>
> Sent: Tuesday, June 11, 2013 1:23:33 PM
> Subject: [Engine-devel] xml rpc exceptions
> 
> hi,
> 
> When starting my VM's I get a strange XML RPC error.
> 
> org.xml.sax.SAXException: Serializable objects aren't supported, if
> isEnabledForExtensions() == false
> org.apache.xmlrpc.common.XmlRpcExtensionException: Serializable objects
> aren't supported, if isEnabledForExtensions() == false
> 
> Looks like it is trying to send a Serializable object as parameter to the
> VDSM, but it is not able to do so. Is anyone handling this issue?
> 
> Thx,
> Laszlo
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From lzelkha at redhat.com  Tue Jun 11 12:26:07 2013
From: lzelkha at redhat.com (Liran Zelkha)
Date: Tue, 11 Jun 2013 08:26:07 -0400 (EDT)
Subject: [Engine-devel] Updates in VdsUpdateRuntimeInfo
In-Reply-To: <564468443.14522796.1370953395956.JavaMail.root@redhat.com>
Message-ID: <430125511.14524007.1370953567595.JavaMail.root@redhat.com>

Hi all,

I'm checking performance for VdsUpdateRunTimeInfo.
Naturally, much of the performance surrounds database activity (getVmsRunningOnVds queries, updateDeviceRuntimeInfo, updateVmDynamic)

Few questions:
1. I have implemented batch updates for procedure UpdateVmDeviceRuntimeInfo for improved performance. 
2. Seems like the only parameters UpdateVmDeviceRuntimeInfo is getting are vm_id,vm_device_id,address and alias. Are those rapidly changing, or will it be beneficial to implement caching on those updates (to ensure not-required updates do not travel to the database).
3. Any additional known performance problems you know of in regards to this class?

Thanks...


From iheim at redhat.com  Tue Jun 11 13:00:21 2013
From: iheim at redhat.com (Itamar Heim)
Date: Tue, 11 Jun 2013 16:00:21 +0300
Subject: [Engine-devel] Updates in VdsUpdateRuntimeInfo
In-Reply-To: <430125511.14524007.1370953567595.JavaMail.root@redhat.com>
References: <430125511.14524007.1370953567595.JavaMail.root@redhat.com>
Message-ID: <51B71F65.10203@redhat.com>

On 06/11/2013 03:26 PM, Liran Zelkha wrote:
> Hi all,
>
> I'm checking performance for VdsUpdateRunTimeInfo.
> Naturally, much of the performance surrounds database activity (getVmsRunningOnVds queries, updateDeviceRuntimeInfo, updateVmDynamic)
>
> Few questions:
> 1. I have implemented batch updates for procedure UpdateVmDeviceRuntimeInfo for improved performance.
> 2. Seems like the only parameters UpdateVmDeviceRuntimeInfo is getting are vm_id,vm_device_id,address and alias. Are those rapidly changing, or will it be beneficial to implement caching on those updates (to ensure not-required updates do not travel to the database).

slowly changing, but how will you cover all flows changing these devices 
to invalidate the cache (iiuc, this table is modified by engine when 
adding devices to a VM as well?)

> 3. Any additional known performance problems you know of in regards to this class?
>
> Thanks...
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>



From Christopher.Morrissey at netapp.com  Tue Jun 11 13:02:06 2013
From: Christopher.Morrissey at netapp.com (Morrissey, Christopher)
Date: Tue, 11 Jun 2013 13:02:06 +0000
Subject: [Engine-devel] Few detailed REST API questions
In-Reply-To: <1581037877.21810448.1370922370791.JavaMail.root@redhat.com>
References: <D290AD8432118048947689BA3AE8A9B325C28E8F@SACEXCMBX04-PRD.hq.netapp.com>
	<1581037877.21810448.1370922370791.JavaMail.root@redhat.com>
Message-ID: <D290AD8432118048947689BA3AE8A9B325C373E7@SACEXCMBX04-PRD.hq.netapp.com>

-Chris


> -----Original Message-----
> From: Tim Hildred [mailto:thildred at redhat.com]
> Sent: Monday, June 10, 2013 11:46 PM
> To: Morrissey, Christopher
> Cc: engine-devel at ovirt.org
> Subject: Re: [Engine-devel] Few detailed REST API questions
> 
> Hey Chris,
> 
> The engine uses a host to do pretty much everything. You'll find that you
> can't add a data domain to a data center without an active host, either.
> 
> The answer to your question, I think, is that you should specify the SPM host
> in your data center.

Thanks for the response. By "SPM host" do you mean the host in the data center that is tagged as the "master"?

> 
> Tim Hildred, RHCE
> Content Author II - Engineering Content Services, Red Hat, Inc.
> Brisbane, Australia
> Email: thildred at redhat.com
> Internal: 8588287
> Mobile: +61 4 666 25242
> IRC: thildred
> 
> ----- Original Message -----
> > From: "Christopher Morrissey" <Christopher.Morrissey at netapp.com>
> > To: engine-devel at ovirt.org
> > Sent: Thursday, May 30, 2013 1:38:28 AM
> > Subject: [Engine-devel] Few detailed REST API questions
> >
> > Hi All,
> >
> > I'm working with the REST API and have a question that I haven't been
> > able to figure out. When destroying a storage domain, it appears that
> > a host is required in the storage domain. Can this be any host that
> > has access to that domain?
> >
> > The storage domain returned through the REST api does not have the
> > host populated so I'm not sure how I would figure out a specific host
> > to put in there other than to just make sure it's one that can access the
> domain.
> >
> > -Chris
> >
> > Chris Morrissey
> > Software Engineer
> > NetApp Inc.
> > 919.476.4428
> >
> >
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> >

From gvallare at redhat.com  Tue Jun 11 13:07:32 2013
From: gvallare at redhat.com (Giuseppe Vallarelli)
Date: Tue, 11 Jun 2013 09:07:32 -0400 (EDT)
Subject: [Engine-devel] Add traffic shaping parameters for a network
 interface.
In-Reply-To: <51B6C0FE.7080600@redhat.com>
References: <1036978361.21603213.1370868394085.JavaMail.root@redhat.com>
	<88074007.21607755.1370868981850.JavaMail.root@redhat.com>
	<20130610142254.GG5384@redhat.com>
	<903977162.21814892.1370876667370.JavaMail.root@redhat.com>
	<247585318.22092746.1370882789300.JavaMail.root@redhat.com>
	<51B6C0FE.7080600@redhat.com>
Message-ID: <1513916135.22954126.1370956052304.JavaMail.root@redhat.com>

Related to QoS parameters reporting to the engine. Looks like they're already
available, I tried to use vdsClient with list verb and I've got the devices
list where a 'specParams' is defined (it's empty because I didn't try it with
my last patch).

devices = [... {'nicModel': 'pv', 'macAddr': '00:1a:4a:22:3f:04', 'network': 'ovirtmgmt', 'alias': 'net0', 'specParams': {},
'deviceId': '76173ffc-603a-496f-8ffc-31dc4d41cef6', 'address': {'slot': '0x03', 'bus': '0x00', 'domain': '0x0000',
'type': 'pci', 'function': '0x0'}, 'device': 'bridge', 'type': 'interface'} ...]

Perhaps I'm missing something, any ideas/hints ?
Thanks Giuseppe


From gvallare at redhat.com  Tue Jun 11 14:34:16 2013
From: gvallare at redhat.com (Giuseppe Vallarelli)
Date: Tue, 11 Jun 2013 10:34:16 -0400 (EDT)
Subject: [Engine-devel] Add traffic shaping parameters for a network
 interface.
In-Reply-To: <1513916135.22954126.1370956052304.JavaMail.root@redhat.com>
References: <1036978361.21603213.1370868394085.JavaMail.root@redhat.com>
	<88074007.21607755.1370868981850.JavaMail.root@redhat.com>
	<20130610142254.GG5384@redhat.com>
	<903977162.21814892.1370876667370.JavaMail.root@redhat.com>
	<247585318.22092746.1370882789300.JavaMail.root@redhat.com>
	<51B6C0FE.7080600@redhat.com>
	<1513916135.22954126.1370956052304.JavaMail.root@redhat.com>
Message-ID: <1409020852.23162480.1370961256731.JavaMail.root@redhat.com>

----- Original Message -----
| From: "Giuseppe Vallarelli" <gvallare at redhat.com>
| To: "Livnat Peer" <lpeer at redhat.com>
| Cc: "Doron Fediuck" <dfediuck at redhat.com>, engine-devel at ovirt.org, "Dan Kenigsberg" <danken at redhat.com>
| Sent: Tuesday, June 11, 2013 3:07:32 PM
| Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface.
| 
| Related to QoS parameters reporting to the engine. Looks like they're already
| available, I tried to use vdsClient with list verb and I've got the devices
| list where a 'specParams' is defined (it's empty because I didn't try it with
| my last patch).
| 
| devices = [... {'nicModel': 'pv', 'macAddr': '00:1a:4a:22:3f:04', 'network':
| 'ovirtmgmt', 'alias': 'net0', 'specParams': {},
| 'deviceId': '76173ffc-603a-496f-8ffc-31dc4d41cef6', 'address': {'slot':
| '0x03', 'bus': '0x00', 'domain': '0x0000',
| 'type': 'pci', 'function': '0x0'}, 'device': 'bridge', 'type': 'interface'}
| ...]
| 
| Perhaps I'm missing something, any ideas/hints ?
| Thanks Giuseppe

A few pastes:
creating the vm: http://paste.fedoraproject.org/17953/37096041/
dumping vm xml: http://paste.fedoraproject.org/17951/37096009/

I've tried this out thanks to Toni, losing sanity with vdsClient..

Giuseppe


From awels at redhat.com  Tue Jun 11 16:39:20 2013
From: awels at redhat.com (Alexander Wels)
Date: Tue, 11 Jun 2013 12:39:20 -0400
Subject: [Engine-devel] Introducing limited branding support.
Message-ID: <7714278.RXuSJp6QZq@awels>

Hi Guys,

We recently merged at a patch (http://gerrit.ovirt.org/#/c/13181/) that allows 
for limited branding support of oVirt user portal and web admin. We also moved 
the styles needed to support this branding out of the application and into its 
own module. The styles can now be found in ovirt-
engine/packaging/branding/ovirt.brand.

In this directory you will find the following files:
- branding.properties. This file controls the branding theme.
- ovirt_messages.properties. A standard java resource bundle properties file 
containing the messages that can be changed.
- A bunch of .css files that contain the classes that can be altered.

I have created a wiki page with some information and pictures of what parts of 
the interface can be changed at this point in time. It is located here: 
http://www.ovirt.org/Feature/Branding

There is also more information in README.branding that got introduced with 
this patch.

Alexander

ps.
If your user interface looks messed up (missing borders and things of that 
nature) the engine cannot find the default branding. This means you are not 
using the make commands recently introduced. We highly recommend you use this 
to have a complete environment. If you are unwilling or unable to use that you 
can make a symlink in /etc/ovirt-engine/branding/00-ovirt.brand to ovirt-
engine/packaging/branding/ovirt.brand



From thildred at redhat.com  Wed Jun 12 00:44:31 2013
From: thildred at redhat.com (Tim Hildred)
Date: Tue, 11 Jun 2013 20:44:31 -0400 (EDT)
Subject: [Engine-devel] Few detailed REST API questions
In-Reply-To: <D290AD8432118048947689BA3AE8A9B325C373E7@SACEXCMBX04-PRD.hq.netapp.com>
References: <D290AD8432118048947689BA3AE8A9B325C28E8F@SACEXCMBX04-PRD.hq.netapp.com>
	<1581037877.21810448.1370922370791.JavaMail.root@redhat.com>
	<D290AD8432118048947689BA3AE8A9B325C373E7@SACEXCMBX04-PRD.hq.netapp.com>
Message-ID: <1685553361.22638414.1370997871714.JavaMail.root@redhat.com>

Hey Christopher,

I hope I understand your problem, and I'm not making things more confusing. I mean that if you log into the administration portal, and select the "Hosts" tab, one of your hosts in the data center should be labelled "SPM". 

I'd say anything labelled "Master", you've found in the storage tab. The resources in the "Storage" tab aren't really hosts, even if they are hosted. Storage domains are meant to be understood as abstractions from the actual storage that back them. 

Tim Hildred, RHCE
Content Author II - Engineering Content Services, Red Hat, Inc.
Brisbane, Australia
Email: thildred at redhat.com
Internal: 8588287
Mobile: +61 4 666 25242
IRC: thildred

----- Original Message -----
> From: "Christopher Morrissey" <Christopher.Morrissey at netapp.com>
> To: "Tim Hildred" <thildred at redhat.com>
> Cc: engine-devel at ovirt.org
> Sent: Tuesday, June 11, 2013 11:02:06 PM
> Subject: RE: [Engine-devel] Few detailed REST API questions
> 
> -Chris
> 
> 
> > -----Original Message-----
> > From: Tim Hildred [mailto:thildred at redhat.com]
> > Sent: Monday, June 10, 2013 11:46 PM
> > To: Morrissey, Christopher
> > Cc: engine-devel at ovirt.org
> > Subject: Re: [Engine-devel] Few detailed REST API questions
> > 
> > Hey Chris,
> > 
> > The engine uses a host to do pretty much everything. You'll find that you
> > can't add a data domain to a data center without an active host, either.
> > 
> > The answer to your question, I think, is that you should specify the SPM
> > host
> > in your data center.
> 
> Thanks for the response. By "SPM host" do you mean the host in the data
> center that is tagged as the "master"?
> 
> > 
> > Tim Hildred, RHCE
> > Content Author II - Engineering Content Services, Red Hat, Inc.
> > Brisbane, Australia
> > Email: thildred at redhat.com
> > Internal: 8588287
> > Mobile: +61 4 666 25242
> > IRC: thildred
> > 
> > ----- Original Message -----
> > > From: "Christopher Morrissey" <Christopher.Morrissey at netapp.com>
> > > To: engine-devel at ovirt.org
> > > Sent: Thursday, May 30, 2013 1:38:28 AM
> > > Subject: [Engine-devel] Few detailed REST API questions
> > >
> > > Hi All,
> > >
> > > I'm working with the REST API and have a question that I haven't been
> > > able to figure out. When destroying a storage domain, it appears that
> > > a host is required in the storage domain. Can this be any host that
> > > has access to that domain?
> > >
> > > The storage domain returned through the REST api does not have the
> > > host populated so I'm not sure how I would figure out a specific host
> > > to put in there other than to just make sure it's one that can access the
> > domain.
> > >
> > > -Chris
> > >
> > > Chris Morrissey
> > > Software Engineer
> > > NetApp Inc.
> > > 919.476.4428
> > >
> > >
> > > _______________________________________________
> > > Engine-devel mailing list
> > > Engine-devel at ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > >
> 


From bazulay at redhat.com  Wed Jun 12 06:41:47 2013
From: bazulay at redhat.com (Barak Azulay)
Date: Wed, 12 Jun 2013 02:41:47 -0400 (EDT)
Subject: [Engine-devel] Updates in VdsUpdateRuntimeInfo
In-Reply-To: <51B71F65.10203@redhat.com>
References: <430125511.14524007.1370953567595.JavaMail.root@redhat.com>
	<51B71F65.10203@redhat.com>
Message-ID: <2023173042.23917497.1371019307372.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Itamar Heim" <iheim at redhat.com>
> To: "Liran Zelkha" <lzelkha at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>
> Sent: Tuesday, June 11, 2013 4:00:21 PM
> Subject: Re: [Engine-devel] Updates in VdsUpdateRuntimeInfo
> 
> On 06/11/2013 03:26 PM, Liran Zelkha wrote:
> > Hi all,
> >
> > I'm checking performance for VdsUpdateRunTimeInfo.
> > Naturally, much of the performance surrounds database activity
> > (getVmsRunningOnVds queries, updateDeviceRuntimeInfo, updateVmDynamic)
> >
> > Few questions:
> > 1. I have implemented batch updates for procedure UpdateVmDeviceRuntimeInfo
> > for improved performance.
> > 2. Seems like the only parameters UpdateVmDeviceRuntimeInfo is getting are
> > vm_id,vm_device_id,address and alias. Are those rapidly changing, or will
> > it be beneficial to implement caching on those updates (to ensure
> > not-required updates do not travel to the database).
> 
> slowly changing, but how will you cover all flows changing these devices
> to invalidate the cache (iiuc, this table is modified by engine when
> adding devices to a VM as well?)


I don't think that in the device run time info we need to invalidate once we add a device.
This is a specific case where we actually get the information from the VDSM (addresses are received from libvirt)
The commands IIRC are first send to VDSM and than update the runtime info only on changed info (we can also hash it),
It may put the placeholder in the DB first but it still relies on the data received from VDSM.




> 
> > 3. Any additional known performance problems you know of in regards to this
> > class?
> >
> > Thanks...
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> >
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
> 
> 


From dfediuck at redhat.com  Wed Jun 12 07:05:35 2013
From: dfediuck at redhat.com (Doron Fediuck)
Date: Wed, 12 Jun 2013 03:05:35 -0400 (EDT)
Subject: [Engine-devel] Add traffic shaping parameters for a network
 interface.
In-Reply-To: <1409020852.23162480.1370961256731.JavaMail.root@redhat.com>
References: <1036978361.21603213.1370868394085.JavaMail.root@redhat.com>
	<88074007.21607755.1370868981850.JavaMail.root@redhat.com>
	<20130610142254.GG5384@redhat.com>
	<903977162.21814892.1370876667370.JavaMail.root@redhat.com>
	<247585318.22092746.1370882789300.JavaMail.root@redhat.com>
	<51B6C0FE.7080600@redhat.com>
	<1513916135.22954126.1370956052304.JavaMail.root@redhat.com>
	<1409020852.23162480.1370961256731.JavaMail.root@redhat.com>
Message-ID: <868904316.23923006.1371020735523.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Giuseppe Vallarelli" <gvallare at redhat.com>
> To: "Livnat Peer" <lpeer at redhat.com>
> Cc: "Doron Fediuck" <dfediuck at redhat.com>, engine-devel at ovirt.org, "Dan Kenigsberg" <danken at redhat.com>
> Sent: Tuesday, June 11, 2013 5:34:16 PM
> Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface.
> 
> ----- Original Message -----
> | From: "Giuseppe Vallarelli" <gvallare at redhat.com>
> | To: "Livnat Peer" <lpeer at redhat.com>
> | Cc: "Doron Fediuck" <dfediuck at redhat.com>, engine-devel at ovirt.org, "Dan
> | Kenigsberg" <danken at redhat.com>
> | Sent: Tuesday, June 11, 2013 3:07:32 PM
> | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network
> | interface.
> | 
> | Related to QoS parameters reporting to the engine. Looks like they're
> | already
> | available, I tried to use vdsClient with list verb and I've got the devices
> | list where a 'specParams' is defined (it's empty because I didn't try it
> | with
> | my last patch).
> | 
> | devices = [... {'nicModel': 'pv', 'macAddr': '00:1a:4a:22:3f:04',
> | 'network':
> | 'ovirtmgmt', 'alias': 'net0', 'specParams': {},
> | 'deviceId': '76173ffc-603a-496f-8ffc-31dc4d41cef6', 'address': {'slot':
> | '0x03', 'bus': '0x00', 'domain': '0x0000',
> | 'type': 'pci', 'function': '0x0'}, 'device': 'bridge', 'type': 'interface'}
> | ...]
> | 
> | Perhaps I'm missing something, any ideas/hints ?
> | Thanks Giuseppe
> 
> A few pastes:
> creating the vm: http://paste.fedoraproject.org/17953/37096041/
> dumping vm xml: http://paste.fedoraproject.org/17951/37096009/
> 
> I've tried this out thanks to Toni, losing sanity with vdsClient..
> 
> Giuseppe
> 

Thanks Giuseppe.
Is this also reported by vdsm in getVmStats?


From iheim at redhat.com  Wed Jun 12 07:09:09 2013
From: iheim at redhat.com (Itamar Heim)
Date: Wed, 12 Jun 2013 10:09:09 +0300
Subject: [Engine-devel] Updates in VdsUpdateRuntimeInfo
In-Reply-To: <2023173042.23917497.1371019307372.JavaMail.root@redhat.com>
References: <430125511.14524007.1370953567595.JavaMail.root@redhat.com>
	<51B71F65.10203@redhat.com>
	<2023173042.23917497.1371019307372.JavaMail.root@redhat.com>
Message-ID: <51B81E95.8030809@redhat.com>

On 06/12/2013 09:41 AM, Barak Azulay wrote:
>
>
> ----- Original Message -----
>> From: "Itamar Heim" <iheim at redhat.com>
>> To: "Liran Zelkha" <lzelkha at redhat.com>
>> Cc: "engine-devel" <engine-devel at ovirt.org>
>> Sent: Tuesday, June 11, 2013 4:00:21 PM
>> Subject: Re: [Engine-devel] Updates in VdsUpdateRuntimeInfo
>>
>> On 06/11/2013 03:26 PM, Liran Zelkha wrote:
>>> Hi all,
>>>
>>> I'm checking performance for VdsUpdateRunTimeInfo.
>>> Naturally, much of the performance surrounds database activity
>>> (getVmsRunningOnVds queries, updateDeviceRuntimeInfo, updateVmDynamic)
>>>
>>> Few questions:
>>> 1. I have implemented batch updates for procedure UpdateVmDeviceRuntimeInfo
>>> for improved performance.
>>> 2. Seems like the only parameters UpdateVmDeviceRuntimeInfo is getting are
>>> vm_id,vm_device_id,address and alias. Are those rapidly changing, or will
>>> it be beneficial to implement caching on those updates (to ensure
>>> not-required updates do not travel to the database).
>>
>> slowly changing, but how will you cover all flows changing these devices
>> to invalidate the cache (iiuc, this table is modified by engine when
>> adding devices to a VM as well?)
>
>
> I don't think that in the device run time info we need to invalidate once we add a device.
> This is a specific case where we actually get the information from the VDSM (addresses are received from libvirt)
> The commands IIRC are first send to VDSM and than update the runtime info only on changed info (we can also hash it),
> It may put the placeholder in the DB first but it still relies on the data received from VDSM.

if this table is only updated from vdsm to save it, i agree.
but isn't the engine also manipulating it?
wasn't there a request to be able to maybe edit the addresses some day?



From danken at redhat.com  Wed Jun 12 07:27:57 2013
From: danken at redhat.com (Dan Kenigsberg)
Date: Wed, 12 Jun 2013 10:27:57 +0300
Subject: [Engine-devel] Add traffic shaping parameters for a network
 interface.
In-Reply-To: <1409020852.23162480.1370961256731.JavaMail.root@redhat.com>
References: <1036978361.21603213.1370868394085.JavaMail.root@redhat.com>
	<88074007.21607755.1370868981850.JavaMail.root@redhat.com>
	<20130610142254.GG5384@redhat.com>
	<903977162.21814892.1370876667370.JavaMail.root@redhat.com>
	<247585318.22092746.1370882789300.JavaMail.root@redhat.com>
	<51B6C0FE.7080600@redhat.com>
	<1513916135.22954126.1370956052304.JavaMail.root@redhat.com>
	<1409020852.23162480.1370961256731.JavaMail.root@redhat.com>
Message-ID: <20130612072757.GI5384@redhat.com>

On Tue, Jun 11, 2013 at 10:34:16AM -0400, Giuseppe Vallarelli wrote:
> ----- Original Message -----
> | From: "Giuseppe Vallarelli" <gvallare at redhat.com>
> | To: "Livnat Peer" <lpeer at redhat.com>
> | Cc: "Doron Fediuck" <dfediuck at redhat.com>, engine-devel at ovirt.org, "Dan Kenigsberg" <danken at redhat.com>
> | Sent: Tuesday, June 11, 2013 3:07:32 PM
> | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface.
> | 
> | Related to QoS parameters reporting to the engine. Looks like they're already
> | available, I tried to use vdsClient with list verb and I've got the devices
> | list where a 'specParams' is defined (it's empty because I didn't try it with
> | my last patch).
> | 
> | devices = [... {'nicModel': 'pv', 'macAddr': '00:1a:4a:22:3f:04', 'network':
> | 'ovirtmgmt', 'alias': 'net0', 'specParams': {},
> | 'deviceId': '76173ffc-603a-496f-8ffc-31dc4d41cef6', 'address': {'slot':
> | '0x03', 'bus': '0x00', 'domain': '0x0000',
> | 'type': 'pci', 'function': '0x0'}, 'device': 'bridge', 'type': 'interface'}
> | ...]
> | 
> | Perhaps I'm missing something, any ideas/hints ?

I believe this is enough.



From gvallare at redhat.com  Wed Jun 12 07:28:19 2013
From: gvallare at redhat.com (Giuseppe Vallarelli)
Date: Wed, 12 Jun 2013 03:28:19 -0400 (EDT)
Subject: [Engine-devel] Add traffic shaping parameters for a network
 interface.
In-Reply-To: <868904316.23923006.1371020735523.JavaMail.root@redhat.com>
References: <1036978361.21603213.1370868394085.JavaMail.root@redhat.com>
	<20130610142254.GG5384@redhat.com>
	<903977162.21814892.1370876667370.JavaMail.root@redhat.com>
	<247585318.22092746.1370882789300.JavaMail.root@redhat.com>
	<51B6C0FE.7080600@redhat.com>
	<1513916135.22954126.1370956052304.JavaMail.root@redhat.com>
	<1409020852.23162480.1370961256731.JavaMail.root@redhat.com>
	<868904316.23923006.1371020735523.JavaMail.root@redhat.com>
Message-ID: <766676147.23932152.1371022099857.JavaMail.root@redhat.com>



----- Original Message -----
| From: "Doron Fediuck" <dfediuck at redhat.com>
| To: "Giuseppe Vallarelli" <gvallare at redhat.com>
| Cc: "Livnat Peer" <lpeer at redhat.com>, engine-devel at ovirt.org, "Dan Kenigsberg" <danken at redhat.com>
| Sent: Wednesday, June 12, 2013 9:05:35 AM
| Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface.
| 
| 
| 
| ----- Original Message -----
| > From: "Giuseppe Vallarelli" <gvallare at redhat.com>
| > To: "Livnat Peer" <lpeer at redhat.com>
| > Cc: "Doron Fediuck" <dfediuck at redhat.com>, engine-devel at ovirt.org, "Dan
| > Kenigsberg" <danken at redhat.com>
| > Sent: Tuesday, June 11, 2013 5:34:16 PM
| > Subject: Re: [Engine-devel] Add traffic shaping parameters for a network
| > interface.
| > 
| > ----- Original Message -----
| > | From: "Giuseppe Vallarelli" <gvallare at redhat.com>
| > | To: "Livnat Peer" <lpeer at redhat.com>
| > | Cc: "Doron Fediuck" <dfediuck at redhat.com>, engine-devel at ovirt.org, "Dan
| > | Kenigsberg" <danken at redhat.com>
| > | Sent: Tuesday, June 11, 2013 3:07:32 PM
| > | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network
| > | interface.
| > | 
| > | Related to QoS parameters reporting to the engine. Looks like they're
| > | already
| > | available, I tried to use vdsClient with list verb and I've got the
| > | devices
| > | list where a 'specParams' is defined (it's empty because I didn't try it
| > | with
| > | my last patch).
| > | 
| > | devices = [... {'nicModel': 'pv', 'macAddr': '00:1a:4a:22:3f:04',
| > | 'network':
| > | 'ovirtmgmt', 'alias': 'net0', 'specParams': {},
| > | 'deviceId': '76173ffc-603a-496f-8ffc-31dc4d41cef6', 'address': {'slot':
| > | '0x03', 'bus': '0x00', 'domain': '0x0000',
| > | 'type': 'pci', 'function': '0x0'}, 'device': 'bridge', 'type':
| > | 'interface'}
| > | ...]
| > | 
| > | Perhaps I'm missing something, any ideas/hints ?
| > | Thanks Giuseppe
| > 
| > A few pastes:
| > creating the vm: http://paste.fedoraproject.org/17953/37096041/
| > dumping vm xml: http://paste.fedoraproject.org/17951/37096009/
| > 
| > I've tried this out thanks to Toni, losing sanity with vdsClient..
| > 
| > Giuseppe
| > 
| 
| Thanks Giuseppe.
| Is this also reported by vdsm in getVmStats?
| 

Unfortunately is not reported using getVmStats, I'm looking into it.
Giuseppe


From bazulay at redhat.com  Wed Jun 12 07:45:25 2013
From: bazulay at redhat.com (Barak Azulay)
Date: Wed, 12 Jun 2013 03:45:25 -0400 (EDT)
Subject: [Engine-devel] Updates in VdsUpdateRuntimeInfo
In-Reply-To: <51B81E95.8030809@redhat.com>
References: <430125511.14524007.1370953567595.JavaMail.root@redhat.com>
	<51B71F65.10203@redhat.com>
	<2023173042.23917497.1371019307372.JavaMail.root@redhat.com>
	<51B81E95.8030809@redhat.com>
Message-ID: <1200722402.23937237.1371023125038.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Itamar Heim" <iheim at redhat.com>
> To: "Barak Azulay" <bazulay at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>
> Sent: Wednesday, June 12, 2013 10:09:09 AM
> Subject: Re: [Engine-devel] Updates in VdsUpdateRuntimeInfo
> 
> On 06/12/2013 09:41 AM, Barak Azulay wrote:
> >
> >
> > ----- Original Message -----
> >> From: "Itamar Heim" <iheim at redhat.com>
> >> To: "Liran Zelkha" <lzelkha at redhat.com>
> >> Cc: "engine-devel" <engine-devel at ovirt.org>
> >> Sent: Tuesday, June 11, 2013 4:00:21 PM
> >> Subject: Re: [Engine-devel] Updates in VdsUpdateRuntimeInfo
> >>
> >> On 06/11/2013 03:26 PM, Liran Zelkha wrote:
> >>> Hi all,
> >>>
> >>> I'm checking performance for VdsUpdateRunTimeInfo.
> >>> Naturally, much of the performance surrounds database activity
> >>> (getVmsRunningOnVds queries, updateDeviceRuntimeInfo, updateVmDynamic)
> >>>
> >>> Few questions:
> >>> 1. I have implemented batch updates for procedure
> >>> UpdateVmDeviceRuntimeInfo
> >>> for improved performance.
> >>> 2. Seems like the only parameters UpdateVmDeviceRuntimeInfo is getting
> >>> are
> >>> vm_id,vm_device_id,address and alias. Are those rapidly changing, or will
> >>> it be beneficial to implement caching on those updates (to ensure
> >>> not-required updates do not travel to the database).
> >>
> >> slowly changing, but how will you cover all flows changing these devices
> >> to invalidate the cache (iiuc, this table is modified by engine when
> >> adding devices to a VM as well?)
> >
> >
> > I don't think that in the device run time info we need to invalidate once
> > we add a device.
> > This is a specific case where we actually get the information from the VDSM
> > (addresses are received from libvirt)
> > The commands IIRC are first send to VDSM and than update the runtime info
> > only on changed info (we can also hash it),
> > It may put the placeholder in the DB first but it still relies on the data
> > received from VDSM.
> 
> if this table is only updated from vdsm to save it, i agree.
> but isn't the engine also manipulating it?
> wasn't there a request to be able to maybe edit the addresses some day?

Even if there was such a request, we still update when we receive the info from libvirt.

Anyway there are obviously a few improvements to be done before caching.
- update only when info received from VDSM change (need to verify it is the practice here)
- do batch update for the new updated data received.
- do the hashing (of vm device runtime info) on VDSM for the data , and update only when hash changes
- caching ...

Barak
 


> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
> 
> 


From lhornyak at redhat.com  Wed Jun 12 08:46:23 2013
From: lhornyak at redhat.com (Laszlo Hornyak)
Date: Wed, 12 Jun 2013 04:46:23 -0400 (EDT)
Subject: [Engine-devel] Introducing limited branding support.
In-Reply-To: <7714278.RXuSJp6QZq@awels>
References: <7714278.RXuSJp6QZq@awels>
Message-ID: <532803316.15004672.1371026783718.JavaMail.root@redhat.com>

Hi,

A related question to the designers:
How do you decide if a new configuration goes to the database config, an existing or a new config file? Is there a concept for this?

Thx,
Laszlo

----- Original Message -----
> From: "Alexander Wels" <awels at redhat.com>
> To: engine-devel at ovirt.org
> Sent: Tuesday, June 11, 2013 6:39:20 PM
> Subject: [Engine-devel] Introducing limited branding support.
> 
> Hi Guys,
> 
> We recently merged at a patch (http://gerrit.ovirt.org/#/c/13181/) that
> allows
> for limited branding support of oVirt user portal and web admin. We also
> moved
> the styles needed to support this branding out of the application and into
> its
> own module. The styles can now be found in ovirt-
> engine/packaging/branding/ovirt.brand.
> 
> In this directory you will find the following files:
> - branding.properties. This file controls the branding theme.
> - ovirt_messages.properties. A standard java resource bundle properties file
> containing the messages that can be changed.
> - A bunch of .css files that contain the classes that can be altered.
> 
> I have created a wiki page with some information and pictures of what parts
> of
> the interface can be changed at this point in time. It is located here:
> http://www.ovirt.org/Feature/Branding
> 
> There is also more information in README.branding that got introduced with
> this patch.
> 
> Alexander
> 
> ps.
> If your user interface looks messed up (missing borders and things of that
> nature) the engine cannot find the default branding. This means you are not
> using the make commands recently introduced. We highly recommend you use this
> to have a complete environment. If you are unwilling or unable to use that
> you
> can make a symlink in /etc/ovirt-engine/branding/00-ovirt.brand to ovirt-
> engine/packaging/branding/ovirt.brand
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From alonbl at redhat.com  Wed Jun 12 08:54:45 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Wed, 12 Jun 2013 04:54:45 -0400 (EDT)
Subject: [Engine-devel] Introducing limited branding support.
In-Reply-To: <532803316.15004672.1371026783718.JavaMail.root@redhat.com>
References: <7714278.RXuSJp6QZq@awels>
	<532803316.15004672.1371026783718.JavaMail.root@redhat.com>
Message-ID: <2104428856.8756806.1371027285125.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Laszlo Hornyak" <lhornyak at redhat.com>
> To: awels at redhat.com
> Cc: engine-devel at ovirt.org
> Sent: Wednesday, June 12, 2013 11:46:23 AM
> Subject: Re: [Engine-devel] Introducing limited branding support.
> 
> Hi,
> 
> A related question to the designers:
> How do you decide if a new configuration goes to the database config, an
> existing or a new config file? Is there a concept for this?

Hello Laszlo,

I do not fully understand the question in this context.

Just to make sure I understand, do you suggest that css, images and messages will be stored in database?

Regards,
Alon Bar-Lev.


From lhornyak at redhat.com  Wed Jun 12 09:32:40 2013
From: lhornyak at redhat.com (Laszlo Hornyak)
Date: Wed, 12 Jun 2013 05:32:40 -0400 (EDT)
Subject: [Engine-devel] Introducing limited branding support.
In-Reply-To: <2104428856.8756806.1371027285125.JavaMail.root@redhat.com>
References: <7714278.RXuSJp6QZq@awels>
	<532803316.15004672.1371026783718.JavaMail.root@redhat.com>
	<2104428856.8756806.1371027285125.JavaMail.root@redhat.com>
Message-ID: <1535156306.15017034.1371029560457.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Alon Bar-Lev" <alonbl at redhat.com>
> To: "Laszlo Hornyak" <lhornyak at redhat.com>
> Cc: awels at redhat.com, engine-devel at ovirt.org
> Sent: Wednesday, June 12, 2013 10:54:45 AM
> Subject: Re: [Engine-devel] Introducing limited branding support.
> 
> 
> 
> ----- Original Message -----
> > From: "Laszlo Hornyak" <lhornyak at redhat.com>
> > To: awels at redhat.com
> > Cc: engine-devel at ovirt.org
> > Sent: Wednesday, June 12, 2013 11:46:23 AM
> > Subject: Re: [Engine-devel] Introducing limited branding support.
> > 
> > Hi,
> > 
> > A related question to the designers:
> > How do you decide if a new configuration goes to the database config, an
> > existing or a new config file? Is there a concept for this?
> 
> Hello Laszlo,
> 
> I do not fully understand the question in this context.
> 
> Just to make sure I understand, do you suggest that css, images and messages
> will be stored in database?

Oh no, I wasn't thinking of blobs local FS is just OK. I mean some configuration parameters are stored in /etc/somewhere, some in /etc/somewhereelse and some in the database, and I'd just like to understand what is the concept.

> 
> Regards,
> Alon Bar-Lev.
> 


From liran.zelkha at gmail.com  Wed Jun 12 09:35:03 2013
From: liran.zelkha at gmail.com (Liran Zelkha)
Date: Wed, 12 Jun 2013 12:35:03 +0300
Subject: [Engine-devel] Updates in VdsUpdateRuntimeInfo
In-Reply-To: <1200722402.23937237.1371023125038.JavaMail.root@redhat.com>
References: <430125511.14524007.1370953567595.JavaMail.root@redhat.com>
	<51B71F65.10203@redhat.com>
	<2023173042.23917497.1371019307372.JavaMail.root@redhat.com>
	<51B81E95.8030809@redhat.com>
	<1200722402.23937237.1371023125038.JavaMail.root@redhat.com>
Message-ID: <2B2AB4E0-20FD-429D-82B1-9A534D7BD93A@gmail.com>

Hi guys,

I'm working hard on this. I'll send summary mail and findings later today. 

On Jun 12, 2013, at 10:45 AM, Barak Azulay wrote:

> 
> 
> ----- Original Message -----
>> From: "Itamar Heim" <iheim at redhat.com>
>> To: "Barak Azulay" <bazulay at redhat.com>
>> Cc: "engine-devel" <engine-devel at ovirt.org>
>> Sent: Wednesday, June 12, 2013 10:09:09 AM
>> Subject: Re: [Engine-devel] Updates in VdsUpdateRuntimeInfo
>> 
>> On 06/12/2013 09:41 AM, Barak Azulay wrote:
>>> 
>>> 
>>> ----- Original Message -----
>>>> From: "Itamar Heim" <iheim at redhat.com>
>>>> To: "Liran Zelkha" <lzelkha at redhat.com>
>>>> Cc: "engine-devel" <engine-devel at ovirt.org>
>>>> Sent: Tuesday, June 11, 2013 4:00:21 PM
>>>> Subject: Re: [Engine-devel] Updates in VdsUpdateRuntimeInfo
>>>> 
>>>> On 06/11/2013 03:26 PM, Liran Zelkha wrote:
>>>>> Hi all,
>>>>> 
>>>>> I'm checking performance for VdsUpdateRunTimeInfo.
>>>>> Naturally, much of the performance surrounds database activity
>>>>> (getVmsRunningOnVds queries, updateDeviceRuntimeInfo, updateVmDynamic)
>>>>> 
>>>>> Few questions:
>>>>> 1. I have implemented batch updates for procedure
>>>>> UpdateVmDeviceRuntimeInfo
>>>>> for improved performance.
>>>>> 2. Seems like the only parameters UpdateVmDeviceRuntimeInfo is getting
>>>>> are
>>>>> vm_id,vm_device_id,address and alias. Are those rapidly changing, or will
>>>>> it be beneficial to implement caching on those updates (to ensure
>>>>> not-required updates do not travel to the database).
>>>> 
>>>> slowly changing, but how will you cover all flows changing these devices
>>>> to invalidate the cache (iiuc, this table is modified by engine when
>>>> adding devices to a VM as well?)
>>> 
>>> 
>>> I don't think that in the device run time info we need to invalidate once
>>> we add a device.
>>> This is a specific case where we actually get the information from the VDSM
>>> (addresses are received from libvirt)
>>> The commands IIRC are first send to VDSM and than update the runtime info
>>> only on changed info (we can also hash it),
>>> It may put the placeholder in the DB first but it still relies on the data
>>> received from VDSM.
>> 
>> if this table is only updated from vdsm to save it, i agree.
>> but isn't the engine also manipulating it?
>> wasn't there a request to be able to maybe edit the addresses some day?
> 
> Even if there was such a request, we still update when we receive the info from libvirt.
> 
> Anyway there are obviously a few improvements to be done before caching.
> - update only when info received from VDSM change (need to verify it is the practice here)
> - do batch update for the new updated data received.
> - do the hashing (of vm device runtime info) on VDSM for the data , and update only when hash changes
> - caching ...
> 
> Barak
> 
> 
> 
>> 
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>> 
>> 
>> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel



From alonbl at redhat.com  Wed Jun 12 10:23:53 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Wed, 12 Jun 2013 06:23:53 -0400 (EDT)
Subject: [Engine-devel] Database configuration vs File based configuration
 (Was: Introducing limited branding support)
In-Reply-To: <1535156306.15017034.1371029560457.JavaMail.root@redhat.com>
References: <7714278.RXuSJp6QZq@awels>
	<532803316.15004672.1371026783718.JavaMail.root@redhat.com>
	<2104428856.8756806.1371027285125.JavaMail.root@redhat.com>
	<1535156306.15017034.1371029560457.JavaMail.root@redhat.com>
Message-ID: <2072416354.8768021.1371032633398.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Laszlo Hornyak" <lhornyak at redhat.com>
> To: "Alon Bar-Lev" <alonbl at redhat.com>
> Cc: awels at redhat.com, engine-devel at ovirt.org
> Sent: Wednesday, June 12, 2013 12:32:40 PM
> Subject: Re: [Engine-devel] Introducing limited branding support.
> 
> 
> 
> ----- Original Message -----
> > From: "Alon Bar-Lev" <alonbl at redhat.com>
> > To: "Laszlo Hornyak" <lhornyak at redhat.com>
> > Cc: awels at redhat.com, engine-devel at ovirt.org
> > Sent: Wednesday, June 12, 2013 10:54:45 AM
> > Subject: Re: [Engine-devel] Introducing limited branding support.
> > 
> > 
> > 
> > ----- Original Message -----
> > > From: "Laszlo Hornyak" <lhornyak at redhat.com>
> > > To: awels at redhat.com
> > > Cc: engine-devel at ovirt.org
> > > Sent: Wednesday, June 12, 2013 11:46:23 AM
> > > Subject: Re: [Engine-devel] Introducing limited branding support.
> > > 
> > > Hi,
> > > 
> > > A related question to the designers:
> > > How do you decide if a new configuration goes to the database config, an
> > > existing or a new config file? Is there a concept for this?
> > 
> > Hello Laszlo,
> > 
> > I do not fully understand the question in this context.
> > 
> > Just to make sure I understand, do you suggest that css, images and
> > messages
> > will be stored in database?
> 
> Oh no, I wasn't thinking of blobs local FS is just OK. I mean some
> configuration parameters are stored in /etc/somewhere, some in
> /etc/somewhereelse and some in the database, and I'd just like to understand
> what is the concept.

There is no single concept... however I can present you one...
I hope it will answer your question.

1. Packaging considerations
Why: During package installation and upgrade the database cannot be accessed.
Example: Plugin installation can drop a file but not modify database.

2. Default values should not be stored at database
Why: Product upgrade may update default, if stored in database the upgrade process must also access the database to update defaults and add new defaults.
Solution: Application should query database, if missing revert to default within file, if missing revert to default within application.
Current state: We do store defaults within database, this should be fixed.

3. Options that are not controlled by application (and owner) but controlled by system and sysadmin should not be stored in database:
Example: File locations, no sense to keep these in database if application does not control the location, especially if may be modified between installations and distributions.
Example: Packaging, product version.
Example: Host name, should actually be acquired from system unless overridden.
Example: Service parameters, in this case sysadmin expects these to be at their standard locations.
Current state: We still store file locations within database, this should be fixed.

4. Database connection information
Why: Egg and chicken.

5. Local protected data
Why: Database is exposed to anyone, even if we encrypt a field we need to access the local key, which resides outside of the database.  A simple solution for local resources is to use the operating system ACL.
Example: The password of the engine keystore which is local resource.

6. Values that are used by other technologies used for maintenance
Why: If product is using multiple technologies to handle a resource (shell scripts, python scripts and java), it is easier to have it in configuration than in database. Especially if these required during setup or maintenance, as database may be unavailable. These are usually local resources already covered by the above items.
Example: The location and password of the engine key which is used by log collector, database upgrade, setup, upgrade.

Regards,
Alon Bar-Lev.


From gvallare at redhat.com  Wed Jun 12 10:47:03 2013
From: gvallare at redhat.com (Giuseppe Vallarelli)
Date: Wed, 12 Jun 2013 06:47:03 -0400 (EDT)
Subject: [Engine-devel] Add traffic shaping parameters for a network
 interface.
In-Reply-To: <766676147.23932152.1371022099857.JavaMail.root@redhat.com>
References: <1036978361.21603213.1370868394085.JavaMail.root@redhat.com>
	<903977162.21814892.1370876667370.JavaMail.root@redhat.com>
	<247585318.22092746.1370882789300.JavaMail.root@redhat.com>
	<51B6C0FE.7080600@redhat.com>
	<1513916135.22954126.1370956052304.JavaMail.root@redhat.com>
	<1409020852.23162480.1370961256731.JavaMail.root@redhat.com>
	<868904316.23923006.1371020735523.JavaMail.root@redhat.com>
	<766676147.23932152.1371022099857.JavaMail.root@redhat.com>
Message-ID: <2049132202.24041525.1371034023419.JavaMail.root@redhat.com>

----- Original Message -----
| From: "Giuseppe Vallarelli" <gvallare at redhat.com>
| To: "Doron Fediuck" <dfediuck at redhat.com>
| Cc: engine-devel at ovirt.org
| Sent: Wednesday, June 12, 2013 9:28:19 AM
| Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface.
| 
| 
| 
| ----- Original Message -----
| | From: "Doron Fediuck" <dfediuck at redhat.com>
| | To: "Giuseppe Vallarelli" <gvallare at redhat.com>
| | Cc: "Livnat Peer" <lpeer at redhat.com>, engine-devel at ovirt.org, "Dan
| | Kenigsberg" <danken at redhat.com>
| | Sent: Wednesday, June 12, 2013 9:05:35 AM
| | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network
| | interface.
| | 
| | 
| | 
| | ----- Original Message -----
| | > From: "Giuseppe Vallarelli" <gvallare at redhat.com>
| | > To: "Livnat Peer" <lpeer at redhat.com>
| | > Cc: "Doron Fediuck" <dfediuck at redhat.com>, engine-devel at ovirt.org, "Dan
| | > Kenigsberg" <danken at redhat.com>
| | > Sent: Tuesday, June 11, 2013 5:34:16 PM
| | > Subject: Re: [Engine-devel] Add traffic shaping parameters for a network
| | > interface.
| | > 
| | > ----- Original Message -----
| | > | From: "Giuseppe Vallarelli" <gvallare at redhat.com>
| | > | To: "Livnat Peer" <lpeer at redhat.com>
| | > | Cc: "Doron Fediuck" <dfediuck at redhat.com>, engine-devel at ovirt.org, "Dan
| | > | Kenigsberg" <danken at redhat.com>
| | > | Sent: Tuesday, June 11, 2013 3:07:32 PM
| | > | Subject: Re: [Engine-devel] Add traffic shaping parameters for a
| | > | network
| | > | interface.
| | > | 
| | > | Related to QoS parameters reporting to the engine. Looks like they're
| | > | already
| | > | available, I tried to use vdsClient with list verb and I've got the
| | > | devices
| | > | list where a 'specParams' is defined (it's empty because I didn't try
| | > | it
| | > | with
| | > | my last patch).
| | > | 
| | > | devices = [... {'nicModel': 'pv', 'macAddr': '00:1a:4a:22:3f:04',
| | > | 'network':
| | > | 'ovirtmgmt', 'alias': 'net0', 'specParams': {},
| | > | 'deviceId': '76173ffc-603a-496f-8ffc-31dc4d41cef6', 'address': {'slot':
| | > | '0x03', 'bus': '0x00', 'domain': '0x0000',
| | > | 'type': 'pci', 'function': '0x0'}, 'device': 'bridge', 'type':
| | > | 'interface'}
| | > | ...]
| | > | 
| | > | Perhaps I'm missing something, any ideas/hints ?
| | > | Thanks Giuseppe
| | > 
| | > A few pastes:
| | > creating the vm: http://paste.fedoraproject.org/17953/37096041/
| | > dumping vm xml: http://paste.fedoraproject.org/17951/37096009/
| | > 
| | > I've tried this out thanks to Toni, losing sanity with vdsClient..
| | > 
| | > Giuseppe
| | > 
| | 
| | Thanks Giuseppe.
| | Is this also reported by vdsm in getVmStats?
| | 
| 
| Unfortunately is not reported using getVmStats, I'm looking into it.
| Giuseppe

New paste: http://paste.fedoraproject.org/18161/71033933/

Giuseppe


From dfediuck at redhat.com  Wed Jun 12 10:54:52 2013
From: dfediuck at redhat.com (Doron Fediuck)
Date: Wed, 12 Jun 2013 06:54:52 -0400 (EDT)
Subject: [Engine-devel] Add traffic shaping parameters for a network
 interface.
In-Reply-To: <2049132202.24041525.1371034023419.JavaMail.root@redhat.com>
References: <1036978361.21603213.1370868394085.JavaMail.root@redhat.com>
	<247585318.22092746.1370882789300.JavaMail.root@redhat.com>
	<51B6C0FE.7080600@redhat.com>
	<1513916135.22954126.1370956052304.JavaMail.root@redhat.com>
	<1409020852.23162480.1370961256731.JavaMail.root@redhat.com>
	<868904316.23923006.1371020735523.JavaMail.root@redhat.com>
	<766676147.23932152.1371022099857.JavaMail.root@redhat.com>
	<2049132202.24041525.1371034023419.JavaMail.root@redhat.com>
Message-ID: <551743987.24045227.1371034492166.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Giuseppe Vallarelli" <gvallare at redhat.com>
> To: "Doron Fediuck" <dfediuck at redhat.com>
> Cc: engine-devel at ovirt.org
> Sent: Wednesday, June 12, 2013 1:47:03 PM
> Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface.
> 
> ----- Original Message -----
> | From: "Giuseppe Vallarelli" <gvallare at redhat.com>
> | To: "Doron Fediuck" <dfediuck at redhat.com>
> | Cc: engine-devel at ovirt.org
> | Sent: Wednesday, June 12, 2013 9:28:19 AM
> | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network
> | interface.
> | 
> | 
> | 
> | ----- Original Message -----
> | | From: "Doron Fediuck" <dfediuck at redhat.com>
> | | To: "Giuseppe Vallarelli" <gvallare at redhat.com>
> | | Cc: "Livnat Peer" <lpeer at redhat.com>, engine-devel at ovirt.org, "Dan
> | | Kenigsberg" <danken at redhat.com>
> | | Sent: Wednesday, June 12, 2013 9:05:35 AM
> | | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network
> | | interface.
> | | 
> | | 
> | | 
> | | ----- Original Message -----
> | | > From: "Giuseppe Vallarelli" <gvallare at redhat.com>
> | | > To: "Livnat Peer" <lpeer at redhat.com>
> | | > Cc: "Doron Fediuck" <dfediuck at redhat.com>, engine-devel at ovirt.org, "Dan
> | | > Kenigsberg" <danken at redhat.com>
> | | > Sent: Tuesday, June 11, 2013 5:34:16 PM
> | | > Subject: Re: [Engine-devel] Add traffic shaping parameters for a
> | | > network
> | | > interface.
> | | > 
> | | > ----- Original Message -----
> | | > | From: "Giuseppe Vallarelli" <gvallare at redhat.com>
> | | > | To: "Livnat Peer" <lpeer at redhat.com>
> | | > | Cc: "Doron Fediuck" <dfediuck at redhat.com>, engine-devel at ovirt.org,
> | | > | "Dan
> | | > | Kenigsberg" <danken at redhat.com>
> | | > | Sent: Tuesday, June 11, 2013 3:07:32 PM
> | | > | Subject: Re: [Engine-devel] Add traffic shaping parameters for a
> | | > | network
> | | > | interface.
> | | > | 
> | | > | Related to QoS parameters reporting to the engine. Looks like they're
> | | > | already
> | | > | available, I tried to use vdsClient with list verb and I've got the
> | | > | devices
> | | > | list where a 'specParams' is defined (it's empty because I didn't try
> | | > | it
> | | > | with
> | | > | my last patch).
> | | > | 
> | | > | devices = [... {'nicModel': 'pv', 'macAddr': '00:1a:4a:22:3f:04',
> | | > | 'network':
> | | > | 'ovirtmgmt', 'alias': 'net0', 'specParams': {},
> | | > | 'deviceId': '76173ffc-603a-496f-8ffc-31dc4d41cef6', 'address':
> | | > | {'slot':
> | | > | '0x03', 'bus': '0x00', 'domain': '0x0000',
> | | > | 'type': 'pci', 'function': '0x0'}, 'device': 'bridge', 'type':
> | | > | 'interface'}
> | | > | ...]
> | | > | 
> | | > | Perhaps I'm missing something, any ideas/hints ?
> | | > | Thanks Giuseppe
> | | > 
> | | > A few pastes:
> | | > creating the vm: http://paste.fedoraproject.org/17953/37096041/
> | | > dumping vm xml: http://paste.fedoraproject.org/17951/37096009/
> | | > 
> | | > I've tried this out thanks to Toni, losing sanity with vdsClient..
> | | > 
> | | > Giuseppe
> | | > 
> | | 
> | | Thanks Giuseppe.
> | | Is this also reported by vdsm in getVmStats?
> | | 
> | 
> | Unfortunately is not reported using getVmStats, I'm looking into it.
> | Giuseppe
> 
> New paste: http://paste.fedoraproject.org/18161/71033933/
> 
> Giuseppe

Brilliant, thanks!


From danken at redhat.com  Wed Jun 12 12:59:43 2013
From: danken at redhat.com (Dan Kenigsberg)
Date: Wed, 12 Jun 2013 15:59:43 +0300
Subject: [Engine-devel] Add traffic shaping parameters for a network
 interface.
In-Reply-To: <551743987.24045227.1371034492166.JavaMail.root@redhat.com>
References: <1036978361.21603213.1370868394085.JavaMail.root@redhat.com>
	<247585318.22092746.1370882789300.JavaMail.root@redhat.com>
	<51B6C0FE.7080600@redhat.com>
	<1513916135.22954126.1370956052304.JavaMail.root@redhat.com>
	<1409020852.23162480.1370961256731.JavaMail.root@redhat.com>
	<868904316.23923006.1371020735523.JavaMail.root@redhat.com>
	<766676147.23932152.1371022099857.JavaMail.root@redhat.com>
	<2049132202.24041525.1371034023419.JavaMail.root@redhat.com>
	<551743987.24045227.1371034492166.JavaMail.root@redhat.com>
Message-ID: <20130612125943.GU5384@redhat.com>

On Wed, Jun 12, 2013 at 06:54:52AM -0400, Doron Fediuck wrote:
> 
> 
> ----- Original Message -----
> > From: "Giuseppe Vallarelli" <gvallare at redhat.com>
> > To: "Doron Fediuck" <dfediuck at redhat.com>
> > Cc: engine-devel at ovirt.org
> > Sent: Wednesday, June 12, 2013 1:47:03 PM
> > Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface.
> > 
> > ----- Original Message -----
> > | From: "Giuseppe Vallarelli" <gvallare at redhat.com>
> > | To: "Doron Fediuck" <dfediuck at redhat.com>
> > | Cc: engine-devel at ovirt.org
> > | Sent: Wednesday, June 12, 2013 9:28:19 AM
> > | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network
> > | interface.
> > | 
> > | 
> > | 
> > | ----- Original Message -----
> > | | From: "Doron Fediuck" <dfediuck at redhat.com>
> > | | To: "Giuseppe Vallarelli" <gvallare at redhat.com>
> > | | Cc: "Livnat Peer" <lpeer at redhat.com>, engine-devel at ovirt.org, "Dan
> > | | Kenigsberg" <danken at redhat.com>
> > | | Sent: Wednesday, June 12, 2013 9:05:35 AM
> > | | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network
> > | | interface.
> > | | 
> > | | 
> > | | 
> > | | ----- Original Message -----
> > | | > From: "Giuseppe Vallarelli" <gvallare at redhat.com>
> > | | > To: "Livnat Peer" <lpeer at redhat.com>
> > | | > Cc: "Doron Fediuck" <dfediuck at redhat.com>, engine-devel at ovirt.org, "Dan
> > | | > Kenigsberg" <danken at redhat.com>
> > | | > Sent: Tuesday, June 11, 2013 5:34:16 PM
> > | | > Subject: Re: [Engine-devel] Add traffic shaping parameters for a
> > | | > network
> > | | > interface.
> > | | > 
> > | | > ----- Original Message -----
> > | | > | From: "Giuseppe Vallarelli" <gvallare at redhat.com>
> > | | > | To: "Livnat Peer" <lpeer at redhat.com>
> > | | > | Cc: "Doron Fediuck" <dfediuck at redhat.com>, engine-devel at ovirt.org,
> > | | > | "Dan
> > | | > | Kenigsberg" <danken at redhat.com>
> > | | > | Sent: Tuesday, June 11, 2013 3:07:32 PM
> > | | > | Subject: Re: [Engine-devel] Add traffic shaping parameters for a
> > | | > | network
> > | | > | interface.
> > | | > | 
> > | | > | Related to QoS parameters reporting to the engine. Looks like they're
> > | | > | already
> > | | > | available, I tried to use vdsClient with list verb and I've got the
> > | | > | devices
> > | | > | list where a 'specParams' is defined (it's empty because I didn't try
> > | | > | it
> > | | > | with
> > | | > | my last patch).
> > | | > | 
> > | | > | devices = [... {'nicModel': 'pv', 'macAddr': '00:1a:4a:22:3f:04',
> > | | > | 'network':
> > | | > | 'ovirtmgmt', 'alias': 'net0', 'specParams': {},
> > | | > | 'deviceId': '76173ffc-603a-496f-8ffc-31dc4d41cef6', 'address':
> > | | > | {'slot':
> > | | > | '0x03', 'bus': '0x00', 'domain': '0x0000',
> > | | > | 'type': 'pci', 'function': '0x0'}, 'device': 'bridge', 'type':
> > | | > | 'interface'}
> > | | > | ...]
> > | | > | 
> > | | > | Perhaps I'm missing something, any ideas/hints ?
> > | | > | Thanks Giuseppe
> > | | > 
> > | | > A few pastes:
> > | | > creating the vm: http://paste.fedoraproject.org/17953/37096041/
> > | | > dumping vm xml: http://paste.fedoraproject.org/17951/37096009/
> > | | > 
> > | | > I've tried this out thanks to Toni, losing sanity with vdsClient..
> > | | > 
> > | | > Giuseppe
> > | | > 
> > | | 
> > | | Thanks Giuseppe.
> > | | Is this also reported by vdsm in getVmStats?
> > | | 
> > | 
> > | Unfortunately is not reported using getVmStats, I'm looking into it.
> > | Giuseppe
> > 
> > New paste: http://paste.fedoraproject.org/18161/71033933/

(using hyperlinks instead of inlining the suggested API is unfriendly to
reviewers and to list archives)

network = {'vnet0': {'macAddr': 'D0:67:E5:F0:75:B4', 'outbound': {'average': '1024'}, 'rxDropped': '0', 'txDropped': '0', 'inbound': {'average': '1024'}, 'rxErrors': '0', 'txRate': '0.0', 'rxRate': '0.0', 'txErrors': '0', 'state': 'unknown', 'speed': '1000', 'name': 'vnet0'}}

> > 
> > Giuseppe
> 
> Brilliant, thanks!

Why does it fit into getVmStats? getVmStats should report
dynamically-changing properties. Bandwidth limitations are more static
control entities, why should we report them every 10 seconds or so?

Dan


From lzelkha at redhat.com  Wed Jun 12 13:03:11 2013
From: lzelkha at redhat.com (Liran Zelkha)
Date: Wed, 12 Jun 2013 09:03:11 -0400 (EDT)
Subject: [Engine-devel] Updates in VdsUpdateRuntimeInfo
In-Reply-To: <2B2AB4E0-20FD-429D-82B1-9A534D7BD93A@gmail.com>
References: <430125511.14524007.1370953567595.JavaMail.root@redhat.com>
	<51B71F65.10203@redhat.com>
	<2023173042.23917497.1371019307372.JavaMail.root@redhat.com>
	<51B81E95.8030809@redhat.com>
	<1200722402.23937237.1371023125038.JavaMail.root@redhat.com>
	<2B2AB4E0-20FD-429D-82B1-9A534D7BD93A@gmail.com>
Message-ID: <953706569.15094263.1371042191235.JavaMail.root@redhat.com>

Hi all,

Current status of VdsUpdateRuntimeInfo (please note - patch is not yet committed).
Initial UpdateRuntimeInfo performance wasted roughly 57% of CPU time on DB activity. Of that, about 25% of CPU time wasted on update behavior. 
After modification (moving updates to batch update) UpdateRuntimeInfo performance wasted roughly 40% of CPU time on DB activity. And only 12% of that was wasted on update behavior.

My next task is to try and optimize the rest of overall database performance.


----- Original Message -----
From: "Liran Zelkha" <liran.zelkha at gmail.com>
To: "Barak Azulay" <bazulay at redhat.com>
Cc: "engine-devel" <engine-devel at ovirt.org>
Sent: Wednesday, June 12, 2013 12:35:03 PM
Subject: Re: [Engine-devel] Updates in VdsUpdateRuntimeInfo

Hi guys,

I'm working hard on this. I'll send summary mail and findings later today. 

On Jun 12, 2013, at 10:45 AM, Barak Azulay wrote:

> 
> 
> ----- Original Message -----
>> From: "Itamar Heim" <iheim at redhat.com>
>> To: "Barak Azulay" <bazulay at redhat.com>
>> Cc: "engine-devel" <engine-devel at ovirt.org>
>> Sent: Wednesday, June 12, 2013 10:09:09 AM
>> Subject: Re: [Engine-devel] Updates in VdsUpdateRuntimeInfo
>> 
>> On 06/12/2013 09:41 AM, Barak Azulay wrote:
>>> 
>>> 
>>> ----- Original Message -----
>>>> From: "Itamar Heim" <iheim at redhat.com>
>>>> To: "Liran Zelkha" <lzelkha at redhat.com>
>>>> Cc: "engine-devel" <engine-devel at ovirt.org>
>>>> Sent: Tuesday, June 11, 2013 4:00:21 PM
>>>> Subject: Re: [Engine-devel] Updates in VdsUpdateRuntimeInfo
>>>> 
>>>> On 06/11/2013 03:26 PM, Liran Zelkha wrote:
>>>>> Hi all,
>>>>> 
>>>>> I'm checking performance for VdsUpdateRunTimeInfo.
>>>>> Naturally, much of the performance surrounds database activity
>>>>> (getVmsRunningOnVds queries, updateDeviceRuntimeInfo, updateVmDynamic)
>>>>> 
>>>>> Few questions:
>>>>> 1. I have implemented batch updates for procedure
>>>>> UpdateVmDeviceRuntimeInfo
>>>>> for improved performance.
>>>>> 2. Seems like the only parameters UpdateVmDeviceRuntimeInfo is getting
>>>>> are
>>>>> vm_id,vm_device_id,address and alias. Are those rapidly changing, or will
>>>>> it be beneficial to implement caching on those updates (to ensure
>>>>> not-required updates do not travel to the database).
>>>> 
>>>> slowly changing, but how will you cover all flows changing these devices
>>>> to invalidate the cache (iiuc, this table is modified by engine when
>>>> adding devices to a VM as well?)
>>> 
>>> 
>>> I don't think that in the device run time info we need to invalidate once
>>> we add a device.
>>> This is a specific case where we actually get the information from the VDSM
>>> (addresses are received from libvirt)
>>> The commands IIRC are first send to VDSM and than update the runtime info
>>> only on changed info (we can also hash it),
>>> It may put the placeholder in the DB first but it still relies on the data
>>> received from VDSM.
>> 
>> if this table is only updated from vdsm to save it, i agree.
>> but isn't the engine also manipulating it?
>> wasn't there a request to be able to maybe edit the addresses some day?
> 
> Even if there was such a request, we still update when we receive the info from libvirt.
> 
> Anyway there are obviously a few improvements to be done before caching.
> - update only when info received from VDSM change (need to verify it is the practice here)
> - do batch update for the new updated data received.
> - do the hashing (of vm device runtime info) on VDSM for the data , and update only when hash changes
> - caching ...
> 
> Barak
> 
> 
> 
>> 
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>> 
>> 
>> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel

_______________________________________________
Engine-devel mailing list
Engine-devel at ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


From iheim at redhat.com  Wed Jun 12 13:05:57 2013
From: iheim at redhat.com (Itamar Heim)
Date: Wed, 12 Jun 2013 16:05:57 +0300
Subject: [Engine-devel] Updates in VdsUpdateRuntimeInfo
In-Reply-To: <953706569.15094263.1371042191235.JavaMail.root@redhat.com>
References: <430125511.14524007.1370953567595.JavaMail.root@redhat.com>
	<51B71F65.10203@redhat.com>
	<2023173042.23917497.1371019307372.JavaMail.root@redhat.com>
	<51B81E95.8030809@redhat.com>
	<1200722402.23937237.1371023125038.JavaMail.root@redhat.com>
	<2B2AB4E0-20FD-429D-82B1-9A534D7BD93A@gmail.com>
	<953706569.15094263.1371042191235.JavaMail.root@redhat.com>
Message-ID: <51B87235.1040806@redhat.com>

On 06/12/2013 04:03 PM, Liran Zelkha wrote:
> Hi all,
>
> Current status of VdsUpdateRuntimeInfo (please note - patch is not yet committed).
> Initial UpdateRuntimeInfo performance wasted roughly 57% of CPU time on DB activity. Of that, about 25% of CPU time wasted on update behavior.
> After modification (moving updates to batch update) UpdateRuntimeInfo performance wasted roughly 40% of CPU time on DB activity. And only 12% of that was wasted on update behavior.

which changes are in place for above?
>
> My next task is to try and optimize the rest of overall database performance.
>
>
> ----- Original Message -----
> From: "Liran Zelkha" <liran.zelkha at gmail.com>
> To: "Barak Azulay" <bazulay at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>
> Sent: Wednesday, June 12, 2013 12:35:03 PM
> Subject: Re: [Engine-devel] Updates in VdsUpdateRuntimeInfo
>
> Hi guys,
>
> I'm working hard on this. I'll send summary mail and findings later today.
>
> On Jun 12, 2013, at 10:45 AM, Barak Azulay wrote:
>
>>
>>
>> ----- Original Message -----
>>> From: "Itamar Heim" <iheim at redhat.com>
>>> To: "Barak Azulay" <bazulay at redhat.com>
>>> Cc: "engine-devel" <engine-devel at ovirt.org>
>>> Sent: Wednesday, June 12, 2013 10:09:09 AM
>>> Subject: Re: [Engine-devel] Updates in VdsUpdateRuntimeInfo
>>>
>>> On 06/12/2013 09:41 AM, Barak Azulay wrote:
>>>>
>>>>
>>>> ----- Original Message -----
>>>>> From: "Itamar Heim" <iheim at redhat.com>
>>>>> To: "Liran Zelkha" <lzelkha at redhat.com>
>>>>> Cc: "engine-devel" <engine-devel at ovirt.org>
>>>>> Sent: Tuesday, June 11, 2013 4:00:21 PM
>>>>> Subject: Re: [Engine-devel] Updates in VdsUpdateRuntimeInfo
>>>>>
>>>>> On 06/11/2013 03:26 PM, Liran Zelkha wrote:
>>>>>> Hi all,
>>>>>>
>>>>>> I'm checking performance for VdsUpdateRunTimeInfo.
>>>>>> Naturally, much of the performance surrounds database activity
>>>>>> (getVmsRunningOnVds queries, updateDeviceRuntimeInfo, updateVmDynamic)
>>>>>>
>>>>>> Few questions:
>>>>>> 1. I have implemented batch updates for procedure
>>>>>> UpdateVmDeviceRuntimeInfo
>>>>>> for improved performance.
>>>>>> 2. Seems like the only parameters UpdateVmDeviceRuntimeInfo is getting
>>>>>> are
>>>>>> vm_id,vm_device_id,address and alias. Are those rapidly changing, or will
>>>>>> it be beneficial to implement caching on those updates (to ensure
>>>>>> not-required updates do not travel to the database).
>>>>>
>>>>> slowly changing, but how will you cover all flows changing these devices
>>>>> to invalidate the cache (iiuc, this table is modified by engine when
>>>>> adding devices to a VM as well?)
>>>>
>>>>
>>>> I don't think that in the device run time info we need to invalidate once
>>>> we add a device.
>>>> This is a specific case where we actually get the information from the VDSM
>>>> (addresses are received from libvirt)
>>>> The commands IIRC are first send to VDSM and than update the runtime info
>>>> only on changed info (we can also hash it),
>>>> It may put the placeholder in the DB first but it still relies on the data
>>>> received from VDSM.
>>>
>>> if this table is only updated from vdsm to save it, i agree.
>>> but isn't the engine also manipulating it?
>>> wasn't there a request to be able to maybe edit the addresses some day?
>>
>> Even if there was such a request, we still update when we receive the info from libvirt.
>>
>> Anyway there are obviously a few improvements to be done before caching.
>> - update only when info received from VDSM change (need to verify it is the practice here)
>> - do batch update for the new updated data received.
>> - do the hashing (of vm device runtime info) on VDSM for the data , and update only when hash changes
>> - caching ...
>>
>> Barak
>>
>>
>>
>>>
>>> _______________________________________________
>>> Engine-devel mailing list
>>> Engine-devel at ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>
>>>
>>>
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>



From emesika at redhat.com  Wed Jun 12 13:07:05 2013
From: emesika at redhat.com (Eli Mesika)
Date: Wed, 12 Jun 2013 09:07:05 -0400 (EDT)
Subject: [Engine-devel] Updates in VdsUpdateRuntimeInfo
In-Reply-To: <1200722402.23937237.1371023125038.JavaMail.root@redhat.com>
References: <430125511.14524007.1370953567595.JavaMail.root@redhat.com>
	<51B71F65.10203@redhat.com>
	<2023173042.23917497.1371019307372.JavaMail.root@redhat.com>
	<51B81E95.8030809@redhat.com>
	<1200722402.23937237.1371023125038.JavaMail.root@redhat.com>
Message-ID: <30766579.15011524.1371042425899.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Barak Azulay" <bazulay at redhat.com>
> To: "Itamar Heim" <iheim at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>
> Sent: Wednesday, June 12, 2013 10:45:25 AM
> Subject: Re: [Engine-devel] Updates in VdsUpdateRuntimeInfo
> 
> 
> 
> ----- Original Message -----
> > From: "Itamar Heim" <iheim at redhat.com>
> > To: "Barak Azulay" <bazulay at redhat.com>
> > Cc: "engine-devel" <engine-devel at ovirt.org>
> > Sent: Wednesday, June 12, 2013 10:09:09 AM
> > Subject: Re: [Engine-devel] Updates in VdsUpdateRuntimeInfo
> > 
> > On 06/12/2013 09:41 AM, Barak Azulay wrote:
> > >
> > >
> > > ----- Original Message -----
> > >> From: "Itamar Heim" <iheim at redhat.com>
> > >> To: "Liran Zelkha" <lzelkha at redhat.com>
> > >> Cc: "engine-devel" <engine-devel at ovirt.org>
> > >> Sent: Tuesday, June 11, 2013 4:00:21 PM
> > >> Subject: Re: [Engine-devel] Updates in VdsUpdateRuntimeInfo
> > >>
> > >> On 06/11/2013 03:26 PM, Liran Zelkha wrote:
> > >>> Hi all,
> > >>>
> > >>> I'm checking performance for VdsUpdateRunTimeInfo.
> > >>> Naturally, much of the performance surrounds database activity
> > >>> (getVmsRunningOnVds queries, updateDeviceRuntimeInfo, updateVmDynamic)
> > >>>
> > >>> Few questions:
> > >>> 1. I have implemented batch updates for procedure
> > >>> UpdateVmDeviceRuntimeInfo
> > >>> for improved performance.
> > >>> 2. Seems like the only parameters UpdateVmDeviceRuntimeInfo is getting
> > >>> are
> > >>> vm_id,vm_device_id,address and alias. Are those rapidly changing, or
> > >>> will
> > >>> it be beneficial to implement caching on those updates (to ensure
> > >>> not-required updates do not travel to the database).
> > >>
> > >> slowly changing, but how will you cover all flows changing these devices
> > >> to invalidate the cache (iiuc, this table is modified by engine when
> > >> adding devices to a VM as well?)
> > >
> > >
> > > I don't think that in the device run time info we need to invalidate once
> > > we add a device.
> > > This is a specific case where we actually get the information from the
> > > VDSM
> > > (addresses are received from libvirt)
> > > The commands IIRC are first send to VDSM and than update the runtime info
> > > only on changed info (we can also hash it),
> > > It may put the placeholder in the DB first but it still relies on the
> > > data
> > > received from VDSM.
> > 
> > if this table is only updated from vdsm to save it, i agree.
> > but isn't the engine also manipulating it?
> > wasn't there a request to be able to maybe edit the addresses some day?
> 
> Even if there was such a request, we still update when we receive the info
> from libvirt.
> 
> Anyway there are obviously a few improvements to be done before caching.
> - update only when info received from VDSM change (need to verify it is the
> practice here)

This should be the behavior right now
There is a hash column in vm_dynamic , this hash is passed by VDSM
We are updating only VMs that change their hash value 

> - do batch update for the new updated data received.
> - do the hashing (of vm device runtime info) on VDSM for the data , and
> update only when hash changes
> - caching ...
> 
> Barak
>  
> 
> 
> > 
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> > 
> > 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From liran.zelkha at gmail.com  Wed Jun 12 13:07:44 2013
From: liran.zelkha at gmail.com (Liran Zelkha)
Date: Wed, 12 Jun 2013 16:07:44 +0300
Subject: [Engine-devel] Updates in VdsUpdateRuntimeInfo
In-Reply-To: <51B87235.1040806@redhat.com>
References: <430125511.14524007.1370953567595.JavaMail.root@redhat.com>
	<51B71F65.10203@redhat.com>
	<2023173042.23917497.1371019307372.JavaMail.root@redhat.com>
	<51B81E95.8030809@redhat.com>
	<1200722402.23937237.1371023125038.JavaMail.root@redhat.com>
	<2B2AB4E0-20FD-429D-82B1-9A534D7BD93A@gmail.com>
	<953706569.15094263.1371042191235.JavaMail.root@redhat.com>
	<51B87235.1040806@redhat.com>
Message-ID: <6356DC3D-6109-497A-8BDE-45450686AD6A@gmail.com>

Batch updates for UpdateVmDeviceRuntimeInfo, UpdateVdsInterfaceStatistics and UpdateVdsDynamic.
All improved execution performance by about 60-80%.

On Jun 12, 2013, at 4:05 PM, Itamar Heim wrote:

> On 06/12/2013 04:03 PM, Liran Zelkha wrote:
>> Hi all,
>> 
>> Current status of VdsUpdateRuntimeInfo (please note - patch is not yet committed).
>> Initial UpdateRuntimeInfo performance wasted roughly 57% of CPU time on DB activity. Of that, about 25% of CPU time wasted on update behavior.
>> After modification (moving updates to batch update) UpdateRuntimeInfo performance wasted roughly 40% of CPU time on DB activity. And only 12% of that was wasted on update behavior.
> 
> which changes are in place for above?
>> 
>> My next task is to try and optimize the rest of overall database performance.
>> 
>> 
>> ----- Original Message -----
>> From: "Liran Zelkha" <liran.zelkha at gmail.com>
>> To: "Barak Azulay" <bazulay at redhat.com>
>> Cc: "engine-devel" <engine-devel at ovirt.org>
>> Sent: Wednesday, June 12, 2013 12:35:03 PM
>> Subject: Re: [Engine-devel] Updates in VdsUpdateRuntimeInfo
>> 
>> Hi guys,
>> 
>> I'm working hard on this. I'll send summary mail and findings later today.
>> 
>> On Jun 12, 2013, at 10:45 AM, Barak Azulay wrote:
>> 
>>> 
>>> 
>>> ----- Original Message -----
>>>> From: "Itamar Heim" <iheim at redhat.com>
>>>> To: "Barak Azulay" <bazulay at redhat.com>
>>>> Cc: "engine-devel" <engine-devel at ovirt.org>
>>>> Sent: Wednesday, June 12, 2013 10:09:09 AM
>>>> Subject: Re: [Engine-devel] Updates in VdsUpdateRuntimeInfo
>>>> 
>>>> On 06/12/2013 09:41 AM, Barak Azulay wrote:
>>>>> 
>>>>> 
>>>>> ----- Original Message -----
>>>>>> From: "Itamar Heim" <iheim at redhat.com>
>>>>>> To: "Liran Zelkha" <lzelkha at redhat.com>
>>>>>> Cc: "engine-devel" <engine-devel at ovirt.org>
>>>>>> Sent: Tuesday, June 11, 2013 4:00:21 PM
>>>>>> Subject: Re: [Engine-devel] Updates in VdsUpdateRuntimeInfo
>>>>>> 
>>>>>> On 06/11/2013 03:26 PM, Liran Zelkha wrote:
>>>>>>> Hi all,
>>>>>>> 
>>>>>>> I'm checking performance for VdsUpdateRunTimeInfo.
>>>>>>> Naturally, much of the performance surrounds database activity
>>>>>>> (getVmsRunningOnVds queries, updateDeviceRuntimeInfo, updateVmDynamic)
>>>>>>> 
>>>>>>> Few questions:
>>>>>>> 1. I have implemented batch updates for procedure
>>>>>>> UpdateVmDeviceRuntimeInfo
>>>>>>> for improved performance.
>>>>>>> 2. Seems like the only parameters UpdateVmDeviceRuntimeInfo is getting
>>>>>>> are
>>>>>>> vm_id,vm_device_id,address and alias. Are those rapidly changing, or will
>>>>>>> it be beneficial to implement caching on those updates (to ensure
>>>>>>> not-required updates do not travel to the database).
>>>>>> 
>>>>>> slowly changing, but how will you cover all flows changing these devices
>>>>>> to invalidate the cache (iiuc, this table is modified by engine when
>>>>>> adding devices to a VM as well?)
>>>>> 
>>>>> 
>>>>> I don't think that in the device run time info we need to invalidate once
>>>>> we add a device.
>>>>> This is a specific case where we actually get the information from the VDSM
>>>>> (addresses are received from libvirt)
>>>>> The commands IIRC are first send to VDSM and than update the runtime info
>>>>> only on changed info (we can also hash it),
>>>>> It may put the placeholder in the DB first but it still relies on the data
>>>>> received from VDSM.
>>>> 
>>>> if this table is only updated from vdsm to save it, i agree.
>>>> but isn't the engine also manipulating it?
>>>> wasn't there a request to be able to maybe edit the addresses some day?
>>> 
>>> Even if there was such a request, we still update when we receive the info from libvirt.
>>> 
>>> Anyway there are obviously a few improvements to be done before caching.
>>> - update only when info received from VDSM change (need to verify it is the practice here)
>>> - do batch update for the new updated data received.
>>> - do the hashing (of vm device runtime info) on VDSM for the data , and update only when hash changes
>>> - caching ...
>>> 
>>> Barak
>>> 
>>> 
>>> 
>>>> 
>>>> _______________________________________________
>>>> Engine-devel mailing list
>>>> Engine-devel at ovirt.org
>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>> 
>>>> 
>>>> 
>>> _______________________________________________
>>> Engine-devel mailing list
>>> Engine-devel at ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>> 
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>> 
> 



From dfediuck at redhat.com  Wed Jun 12 15:17:18 2013
From: dfediuck at redhat.com (Doron Fediuck)
Date: Wed, 12 Jun 2013 11:17:18 -0400 (EDT)
Subject: [Engine-devel] Add traffic shaping parameters for a network
 interface.
In-Reply-To: <20130612125943.GU5384@redhat.com>
References: <1036978361.21603213.1370868394085.JavaMail.root@redhat.com>
	<1513916135.22954126.1370956052304.JavaMail.root@redhat.com>
	<1409020852.23162480.1370961256731.JavaMail.root@redhat.com>
	<868904316.23923006.1371020735523.JavaMail.root@redhat.com>
	<766676147.23932152.1371022099857.JavaMail.root@redhat.com>
	<2049132202.24041525.1371034023419.JavaMail.root@redhat.com>
	<551743987.24045227.1371034492166.JavaMail.root@redhat.com>
	<20130612125943.GU5384@redhat.com>
Message-ID: <2133374717.24351477.1371050238284.JavaMail.root@redhat.com>

----- Original Message -----
> From: "Dan Kenigsberg" <danken at redhat.com>
> To: "Doron Fediuck" <dfediuck at redhat.com>
> Cc: "Giuseppe Vallarelli" <gvallare at redhat.com>, engine-devel at ovirt.org
> Sent: Wednesday, June 12, 2013 3:59:43 PM
> Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface.
> 
> On Wed, Jun 12, 2013 at 06:54:52AM -0400, Doron Fediuck wrote:
> > 
> > 
> > ----- Original Message -----
> > > From: "Giuseppe Vallarelli" <gvallare at redhat.com>
> > > To: "Doron Fediuck" <dfediuck at redhat.com>
> > > Cc: engine-devel at ovirt.org
> > > Sent: Wednesday, June 12, 2013 1:47:03 PM
> > > Subject: Re: [Engine-devel] Add traffic shaping parameters for a network
> > > interface.
> > > 
> > > ----- Original Message -----
> > > | From: "Giuseppe Vallarelli" <gvallare at redhat.com>
> > > | To: "Doron Fediuck" <dfediuck at redhat.com>
> > > | Cc: engine-devel at ovirt.org
> > > | Sent: Wednesday, June 12, 2013 9:28:19 AM
> > > | Subject: Re: [Engine-devel] Add traffic shaping parameters for a
> > > | network
> > > | interface.
> > > | 
> > > | 
> > > | 
> > > | ----- Original Message -----
> > > | | From: "Doron Fediuck" <dfediuck at redhat.com>
> > > | | To: "Giuseppe Vallarelli" <gvallare at redhat.com>
> > > | | Cc: "Livnat Peer" <lpeer at redhat.com>, engine-devel at ovirt.org, "Dan
> > > | | Kenigsberg" <danken at redhat.com>
> > > | | Sent: Wednesday, June 12, 2013 9:05:35 AM
> > > | | Subject: Re: [Engine-devel] Add traffic shaping parameters for a
> > > | | network
> > > | | interface.
> > > | | 
> > > | | 
> > > | | 
> > > | | ----- Original Message -----
> > > | | > From: "Giuseppe Vallarelli" <gvallare at redhat.com>
> > > | | > To: "Livnat Peer" <lpeer at redhat.com>
> > > | | > Cc: "Doron Fediuck" <dfediuck at redhat.com>, engine-devel at ovirt.org,
> > > | | > "Dan
> > > | | > Kenigsberg" <danken at redhat.com>
> > > | | > Sent: Tuesday, June 11, 2013 5:34:16 PM
> > > | | > Subject: Re: [Engine-devel] Add traffic shaping parameters for a
> > > | | > network
> > > | | > interface.
> > > | | > 
> > > | | > ----- Original Message -----
> > > | | > | From: "Giuseppe Vallarelli" <gvallare at redhat.com>
> > > | | > | To: "Livnat Peer" <lpeer at redhat.com>
> > > | | > | Cc: "Doron Fediuck" <dfediuck at redhat.com>,
> > > | | > | engine-devel at ovirt.org,
> > > | | > | "Dan
> > > | | > | Kenigsberg" <danken at redhat.com>
> > > | | > | Sent: Tuesday, June 11, 2013 3:07:32 PM
> > > | | > | Subject: Re: [Engine-devel] Add traffic shaping parameters for a
> > > | | > | network
> > > | | > | interface.
> > > | | > | 
> > > | | > | Related to QoS parameters reporting to the engine. Looks like
> > > | | > | they're
> > > | | > | already
> > > | | > | available, I tried to use vdsClient with list verb and I've got
> > > | | > | the
> > > | | > | devices
> > > | | > | list where a 'specParams' is defined (it's empty because I didn't
> > > | | > | try
> > > | | > | it
> > > | | > | with
> > > | | > | my last patch).
> > > | | > | 
> > > | | > | devices = [... {'nicModel': 'pv', 'macAddr': '00:1a:4a:22:3f:04',
> > > | | > | 'network':
> > > | | > | 'ovirtmgmt', 'alias': 'net0', 'specParams': {},
> > > | | > | 'deviceId': '76173ffc-603a-496f-8ffc-31dc4d41cef6', 'address':
> > > | | > | {'slot':
> > > | | > | '0x03', 'bus': '0x00', 'domain': '0x0000',
> > > | | > | 'type': 'pci', 'function': '0x0'}, 'device': 'bridge', 'type':
> > > | | > | 'interface'}
> > > | | > | ...]
> > > | | > | 
> > > | | > | Perhaps I'm missing something, any ideas/hints ?
> > > | | > | Thanks Giuseppe
> > > | | > 
> > > | | > A few pastes:
> > > | | > creating the vm: http://paste.fedoraproject.org/17953/37096041/
> > > | | > dumping vm xml: http://paste.fedoraproject.org/17951/37096009/
> > > | | > 
> > > | | > I've tried this out thanks to Toni, losing sanity with vdsClient..
> > > | | > 
> > > | | > Giuseppe
> > > | | > 
> > > | | 
> > > | | Thanks Giuseppe.
> > > | | Is this also reported by vdsm in getVmStats?
> > > | | 
> > > | 
> > > | Unfortunately is not reported using getVmStats, I'm looking into it.
> > > | Giuseppe
> > > 
> > > New paste: http://paste.fedoraproject.org/18161/71033933/
> 
> (using hyperlinks instead of inlining the suggested API is unfriendly to
> reviewers and to list archives)
> 
> network = {'vnet0': {'macAddr': 'D0:67:E5:F0:75:B4', 'outbound': {'average':
> '1024'}, 'rxDropped': '0', 'txDropped': '0', 'inbound': {'average': '1024'},
> 'rxErrors': '0', 'txRate': '0.0', 'rxRate': '0.0', 'txErrors': '0', 'state':
> 'unknown', 'speed': '1000', 'name': 'vnet0'}}
> 
> > > 
> > > Giuseppe
> > 
> > Brilliant, thanks!
> 
> Why does it fit into getVmStats? getVmStats should report
> dynamically-changing properties. Bandwidth limitations are more static
> control entities, why should we report them every 10 seconds or so?
> 
> Dan
> 

I have no problems with having it in something which runs less frequently.


From lpeer at redhat.com  Wed Jun 12 17:40:07 2013
From: lpeer at redhat.com (Livnat Peer)
Date: Wed, 12 Jun 2013 13:40:07 -0400 (EDT)
Subject: [Engine-devel] Cancelled: ovirt network
Message-ID: <1941714880.15011794.1371058807004.JavaMail.root@redhat.com>

The following meeting has been cancelled:

Subject: ovirt network  
Organizer: "Livnat Peer" <lpeer at redhat.com> 

Time: 4:00:00 PM - 5:00:00 PM GMT +02:00 Jerusalem
 Recurrence : Every 5 week(s) on Wednesday No end date Effective Aug 15, 2012

Invitees: engine-devel at ovirt.org; vdsm-devel at lists.fedorahosted.org; GARGYA at de.ibm.com; dyasny at redhat.com; simon at redhat.com; mkolesni at redhat.com; atal at redhat.com; ilvovsky at redhat.com; dfediuck at redhat.com; pradipta.banerjee at gmail.com; gkotton at redhat.com ... 


*~*~*~*~*~*~*~*~*~*

Hi All, 
As discussed previously on the list, I am adding a monthly discussion on Networking in oVirt. 
In this meeting we'll discuss general status of networking and features that we're missing. 

Thanks, Livnat 


Bridge ID: 972506565679 
Dial-in information: 
Reservationless-Plus Toll Free Dial-In Number (US & Canada): (800) 451-8679 
Reservationless-Plus International Dial-In Number: (212) 729-5016 
Conference code: 8425973915 

Global Access Numbers Local: 
Australia, Sydney Dial-In #: 0289852326 
Austria, Vienna Dial-In #: 012534978196 
Belgium, Brussels Dial-In #: 027920405 
China Dial-In #: 4006205013 
Denmark, Copenhagen Dial-In #: 32729215 
Finland, Helsinki Dial-In #: 0923194436 
France, Paris Dial-In #: 0170377140 
Germany, Berlin Dial-In #: 030300190579 
Ireland, Dublin Dial-In #: 014367793 
Italy, Milan Dial-In #: 0236269529 
Netherlands, Amsterdam Dial-In #: 0207975872 
Norway, Oslo Dial-In #: 21033188 
Singapore Dial-In #: 64840858 
Spain, Barcelona Dial-In #: 935452328 
Sweden, Stockholm Dial-In #: 0850513770 
Switzerland, Geneva Dial-In #: 0225927881 
United Kingdom Dial-In #: 02078970515 
United Kingdom Dial-In #: 08445790676 
United Kingdom, LocalCall Dial-In #: 08445790678 
United States Dial-In #: 2127295016 


Global Access Numbers Tollfree: 
Argentina Dial-In #: 8004441016 
Australia Dial-In #: 1800337169 
Austria Dial-In #: 0800005898 
Bahamas Dial-In #: 18002054776 
Bahrain Dial-In #: 80004377 
Belgium Dial-In #: 080048325 
Brazil Dial-In #: 08008921002 
Bulgaria Dial-In #: 008001100236 
Chile Dial-In #: 800370228 
Colombia Dial-In #: 018009134033 
Costa Rica Dial-In #: 08000131048 
Cyprus Dial-In #: 80095297 
Czech Republic Dial-In #: 800700318 
Denmark Dial-In #: 80887114 
Dominican Republic Dial-In #: 18887512313 
Estonia Dial-In #: 8000100232 
Finland Dial-In #: 0800117116 
France Dial-In #: 0805632867 
Germany Dial-In #: 8006647541 
Greece Dial-In #: 00800127562 
Hong Kong Dial-In #: 800930349 
Hungary Dial-In #: 0680016796 
Iceland Dial-In #: 8008967 
India Dial-In #: 0008006501533 
Indonesia Dial-In #: 0018030179162 
Ireland Dial-In #: 1800932401 
Israel Dial-In #: 1809462557 
Italy Dial-In #: 800985897 
Jamaica Dial-In #: 18002050328 
Japan Dial-In #: 0120934453 
Korea (South) Dial-In #: 007986517393 
Latvia Dial-In #: 80003339 
Lithuania Dial-In #: 880030479 
Luxembourg Dial-In #: 80026595 
Malaysia Dial-In #: 1800814451 
Mexico Dial-In #: 0018664590915 
New Zealand Dial-In #: 0800888167 
Norway Dial-In #: 80012994 
Panama Dial-In #: 008002269184 
Philippines Dial-In #: 180011100991 
Poland Dial-In #: 008001210187 
Portugal Dial-In #: 800814625 
Russian Federation Dial-In #: 81080028341012 
Saint Kitts and Nevis Dial-In #: 18002059252 
Singapore Dial-In #: 8006162235 
Slovak Republic Dial-In #: 0800001441 
South Africa Dial-In #: 0800981148 
Spain Dial-In #: 800300524 
Sweden Dial-In #: 200896860 
Switzerland Dial-In #: 800650077 
Taiwan Dial-In #: 00801127141 
Thailand Dial-In #: 001800656966 
Trinidad and Tobago Dial-In #: 18002024615 
United Arab Emirates Dial-In #: 8000650591 
United Kingdom Dial-In #: 08006948057 
United States Dial-In #: 8004518679 
Uruguay Dial-In #: 00040190315 
Venezuela Dial-In #: 08001627182 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130612/81e420cf/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: meeting.ics
Type: text/calendar
Size: 10868 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130612/81e420cf/attachment.ics>

From mbetak at redhat.com  Thu Jun 13 08:33:09 2013
From: mbetak at redhat.com (Martin Betak)
Date: Thu, 13 Jun 2013 04:33:09 -0400 (EDT)
Subject: [Engine-devel] Guest Reboot
In-Reply-To: <857502605.53404230.1370879892213.JavaMail.root@redhat.com>
References: <1845391574.16328760.1370622751837.JavaMail.root@redhat.com>
	<2042273794.20453738.1370784729353.JavaMail.root@redhat.com>
	<857502605.53404230.1370879892213.JavaMail.root@redhat.com>
Message-ID: <155496347.18788561.1371112389784.JavaMail.root@redhat.com>

Hi,

from the implementation discussion it seems that the behavior of reboot will be in most cases equivalent to 
pressing the current buttons stop and then start, so maybe the reboot icon should reflect that. 
Maybe a combination of red square/green triangle?

Martin

----- Original Message -----
From: "Malini Rao" <mrao at redhat.com>
To: "Alissa Bonas" <abonas at redhat.com>
Cc: "Martin Betak" <mbetak at redhat.com>, engine-devel at ovirt.org
Sent: Monday, June 10, 2013 5:58:12 PM
Subject: Re: [Engine-devel] Guest Reboot

I think a Power button icon like this one - http://us.123rf.com/400wm/400/400/vipervxw/vipervxw1210/vipervxw121000044/16013272-cool-power-button-in-white-with-blue-led.jpg might work for reboot.

-Malini

----- Original Message -----
From: "Alissa Bonas" <abonas at redhat.com>
To: "Martin Betak" <mbetak at redhat.com>
Cc: engine-devel at ovirt.org
Sent: Sunday, June 9, 2013 9:32:09 AM
Subject: Re: [Engine-devel] Guest Reboot

I think that the icon suggested in the wiki looks more like "refresh" , and it's not clear it indicates a reboot action (which is more heavy than just a refresh).
I suggest as alternative something like the "run VM" icon (the triangle - that already exists in the engine and users know what it means), and with it the arrows from the "refresh" icon.
Please see attached.


----- Original Message -----
> From: "Martin Betak" <mbetak at redhat.com>
> To: engine-devel at ovirt.org
> Sent: Friday, June 7, 2013 7:32:31 PM
> Subject: [Engine-devel] Guest Reboot
> 
> Hi, engine-devel
> 
> Customers request the ability to reboot a VM with a single click so I started
> designing the overall architecture and planing out the required changes to
> the respective components.
> You can find the wiki page for the initial draft at [1] and I would like to
> ask you for your input on my general design and potential issues that could
> arise in some corner cases.
> Please feel free to respond to this thread or add to the Issues section of
> [1].
> 
> Thanks in advance for your opinions :-)
> 
> Martin
> 
> [1] http://www.ovirt.org/Features/Guest_Reboot
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 

_______________________________________________
Engine-devel mailing list
Engine-devel at ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


From sabose at redhat.com  Thu Jun 13 10:59:29 2013
From: sabose at redhat.com (Sahina Bose)
Date: Thu, 13 Jun 2013 16:29:29 +0530
Subject: [Engine-devel] Introducing limited branding support.
In-Reply-To: <7714278.RXuSJp6QZq@awels>
References: <7714278.RXuSJp6QZq@awels>
Message-ID: <51B9A611.9010403@redhat.com>


On 06/11/2013 10:09 PM, Alexander Wels wrote:
> Hi Guys,
>
> We recently merged at a patch (http://gerrit.ovirt.org/#/c/13181/) that allows
> for limited branding support of oVirt user portal and web admin. We also moved
> the styles needed to support this branding out of the application and into its
> own module. The styles can now be found in ovirt-
> engine/packaging/branding/ovirt.brand.
>
> In this directory you will find the following files:
> - branding.properties. This file controls the branding theme.
> - ovirt_messages.properties. A standard java resource bundle properties file
> containing the messages that can be changed.
> - A bunch of .css files that contain the classes that can be altered.
>
> I have created a wiki page with some information and pictures of what parts of
> the interface can be changed at this point in time. It is located here:
> http://www.ovirt.org/Feature/Branding
>
> There is also more information in README.branding that got introduced with
> this patch.
>
> Alexander
>
> ps.
> If your user interface looks messed up (missing borders and things of that
> nature) the engine cannot find the default branding. This means you are not
> using the make commands recently introduced. We highly recommend you use this
> to have a complete environment. If you are unwilling or unable to use that you
> can make a symlink in /etc/ovirt-engine/branding/00-ovirt.brand to ovirt-
> engine/packaging/branding/ovirt.brand
If creating a symlink, make sure it matches the ENGINE_ETC property 
that's loaded.
So, for symlink /etc/ovirt-engine/branding/00-ovirt.brand , the 
ENGINE_ETC should be pointing to /etc/ovirt-engine.

I ran into issues, so thought I would share.

thanks
sahina

>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel



From alonbl at redhat.com  Thu Jun 13 11:54:29 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Thu, 13 Jun 2013 07:54:29 -0400 (EDT)
Subject: [Engine-devel] Introducing limited branding support.
In-Reply-To: <51B9A611.9010403@redhat.com>
References: <7714278.RXuSJp6QZq@awels> <51B9A611.9010403@redhat.com>
Message-ID: <438334242.9095912.1371124469767.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Sahina Bose" <sabose at redhat.com>
> To: awels at redhat.com
> Cc: engine-devel at ovirt.org
> Sent: Thursday, June 13, 2013 1:59:29 PM
> Subject: Re: [Engine-devel] Introducing limited branding support.
> 
> 
> On 06/11/2013 10:09 PM, Alexander Wels wrote:
> > Hi Guys,
> >
> > We recently merged at a patch (http://gerrit.ovirt.org/#/c/13181/) that
> > allows
> > for limited branding support of oVirt user portal and web admin. We also
> > moved
> > the styles needed to support this branding out of the application and into
> > its
> > own module. The styles can now be found in ovirt-
> > engine/packaging/branding/ovirt.brand.
> >
> > In this directory you will find the following files:
> > - branding.properties. This file controls the branding theme.
> > - ovirt_messages.properties. A standard java resource bundle properties
> > file
> > containing the messages that can be changed.
> > - A bunch of .css files that contain the classes that can be altered.
> >
> > I have created a wiki page with some information and pictures of what parts
> > of
> > the interface can be changed at this point in time. It is located here:
> > http://www.ovirt.org/Feature/Branding
> >
> > There is also more information in README.branding that got introduced with
> > this patch.
> >
> > Alexander
> >
> > ps.
> > If your user interface looks messed up (missing borders and things of that
> > nature) the engine cannot find the default branding. This means you are not
> > using the make commands recently introduced. We highly recommend you use
> > this
> > to have a complete environment. If you are unwilling or unable to use that
> > you
> > can make a symlink in /etc/ovirt-engine/branding/00-ovirt.brand to ovirt-
> > engine/packaging/branding/ovirt.brand
> If creating a symlink, make sure it matches the ENGINE_ETC property
> that's loaded.
> So, for symlink /etc/ovirt-engine/branding/00-ovirt.brand , the
> ENGINE_ETC should be pointing to /etc/ovirt-engine.
> 
> I ran into issues, so thought I would share.

Please migrate to the new supported development environment[1], it installs everything as it should, you should not set these variables manually.

Regards,
Alon Bar-Lev.

[1] http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=blob;f=README.developer;hb=HEAD

> 
> thanks
> sahina
> 
> >
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From emesika at redhat.com  Sun Jun 16 09:31:28 2013
From: emesika at redhat.com (Eli Mesika)
Date: Sun, 16 Jun 2013 05:31:28 -0400 (EDT)
Subject: [Engine-devel] Introducing limited branding support.
In-Reply-To: <438334242.9095912.1371124469767.JavaMail.root@redhat.com>
References: <7714278.RXuSJp6QZq@awels> <51B9A611.9010403@redhat.com>
	<438334242.9095912.1371124469767.JavaMail.root@redhat.com>
Message-ID: <14870611.16572984.1371375088374.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Alon Bar-Lev" <alonbl at redhat.com>
> To: "Sahina Bose" <sabose at redhat.com>
> Cc: engine-devel at ovirt.org
> Sent: Thursday, June 13, 2013 2:54:29 PM
> Subject: Re: [Engine-devel] Introducing limited branding support.
> 
> 
> 
> ----- Original Message -----
> > From: "Sahina Bose" <sabose at redhat.com>
> > To: awels at redhat.com
> > Cc: engine-devel at ovirt.org
> > Sent: Thursday, June 13, 2013 1:59:29 PM
> > Subject: Re: [Engine-devel] Introducing limited branding support.
> > 
> > 
> > On 06/11/2013 10:09 PM, Alexander Wels wrote:
> > > Hi Guys,
> > >
> > > We recently merged at a patch (http://gerrit.ovirt.org/#/c/13181/) that
> > > allows
> > > for limited branding support of oVirt user portal and web admin. We also
> > > moved
> > > the styles needed to support this branding out of the application and
> > > into
> > > its
> > > own module. The styles can now be found in ovirt-
> > > engine/packaging/branding/ovirt.brand.
> > >
> > > In this directory you will find the following files:
> > > - branding.properties. This file controls the branding theme.
> > > - ovirt_messages.properties. A standard java resource bundle properties
> > > file
> > > containing the messages that can be changed.
> > > - A bunch of .css files that contain the classes that can be altered.
> > >
> > > I have created a wiki page with some information and pictures of what
> > > parts
> > > of
> > > the interface can be changed at this point in time. It is located here:
> > > http://www.ovirt.org/Feature/Branding
> > >
> > > There is also more information in README.branding that got introduced
> > > with
> > > this patch.
> > >
> > > Alexander
> > >
> > > ps.
> > > If your user interface looks messed up (missing borders and things of
> > > that
> > > nature) the engine cannot find the default branding. This means you are
> > > not
> > > using the make commands recently introduced. We highly recommend you use
> > > this
> > > to have a complete environment. If you are unwilling or unable to use
> > > that
> > > you
> > > can make a symlink in /etc/ovirt-engine/branding/00-ovirt.brand to ovirt-
> > > engine/packaging/branding/ovirt.brand
> > If creating a symlink, make sure it matches the ENGINE_ETC property
> > that's loaded.
> > So, for symlink /etc/ovirt-engine/branding/00-ovirt.brand , the
> > ENGINE_ETC should be pointing to /etc/ovirt-engine.
> > 
> > I ran into issues, so thought I would share.
> 
> Please migrate to the new supported development environment[1], it installs
> everything as it should, you should not set these variables manually.

There is a good wiki from Alon as well that I think is more easy to follow 
http://www.ovirt.org/OVirt_Engine_Development_Environment


> 
> Regards,
> Alon Bar-Lev.
> 
> [1]
> http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=blob;f=README.developer;hb=HEAD
> 
> > 
> > thanks
> > sahina
> > 
> > >
> > > _______________________________________________
> > > Engine-devel mailing list
> > > Engine-devel at ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From danken at redhat.com  Sun Jun 16 13:05:15 2013
From: danken at redhat.com (Dan Kenigsberg)
Date: Sun, 16 Jun 2013 16:05:15 +0300
Subject: [Engine-devel] Cloud-Init integration
In-Reply-To: <5154D3BB.7080004@redhat.com>
References: <5154D3BB.7080004@redhat.com>
Message-ID: <20130616130515.GA8170@redhat.com>

On Thu, Mar 28, 2013 at 07:35:23PM -0400, Greg Padgett wrote:
> Hi Everyone,
> 
> I'd like to propose a feature we've been doing some investigation
> into, which is to integrate cloud-init support into oVirt.
> 
> Cloud-init is used to help provision new Linux systems by setting
> the hostname, ip, ssh keys, timezone, injecting files, and more.
> It's used by OpenStack (amongst others) now, and has a lot of
> features that may be helpful to our users.
> 
> Details are still evolving, but for more info please see the wiki page:
> 
> http://www.ovirt.org/Features/Cloud-Init_Integration
> 
> All feedback is welcome!

All feedback? Even if it's 3 months too late?

If so, then here's a few comments:

1. oVirt-3.2 completely supports IPv6 within guests. It would be nice to
   carry this on to cloud-init, by allowing to set the IPv6 address of
   the guest. (or are we happy with the auto configured ipv6 addresses?)

2. I think that the GUI used for setting IP addresses should be
   immitated here. It allows Static/DHCP/None, and disables the
   irrelvant fields when DHCP/None is selected.

3. Is "Support custom volume label for vm payloads" still on the TODO
   list? Note: F19's dosfstools has renamed mkfs.msdos to mkfs.fat.
   This means that creating a virtual floppy with a payload currently
   does not work there (it's a tiny fix, for sure).

4. I do not see ovirt-guest-agent mentioned in the feaure page. It is
   the obvious channel to report that cloud-init is Done to Engine.

5. When we come to implement auto-generate of system ssh key, we may
   want to install a virtio-rng device in our VMs, to ensure that the
   keys are not too easy to guess. (or create the key in the host and
   inject it to the guest)

Dan.


From mkolesni at redhat.com  Sun Jun 16 14:08:39 2013
From: mkolesni at redhat.com (Mike Kolesnik)
Date: Sun, 16 Jun 2013 10:08:39 -0400 (EDT)
Subject: [Engine-devel] Cloud-Init integration
In-Reply-To: <20130616130515.GA8170@redhat.com>
References: <5154D3BB.7080004@redhat.com> <20130616130515.GA8170@redhat.com>
Message-ID: <1802344283.227638.1371391719479.JavaMail.root@redhat.com>

----- Original Message -----
> On Thu, Mar 28, 2013 at 07:35:23PM -0400, Greg Padgett wrote:
> > Hi Everyone,
> > 
> > I'd like to propose a feature we've been doing some investigation
> > into, which is to integrate cloud-init support into oVirt.
> > 
> > Cloud-init is used to help provision new Linux systems by setting
> > the hostname, ip, ssh keys, timezone, injecting files, and more.
> > It's used by OpenStack (amongst others) now, and has a lot of
> > features that may be helpful to our users.
> > 
> > Details are still evolving, but for more info please see the wiki page:
> > 
> > http://www.ovirt.org/Features/Cloud-Init_Integration
> > 
> > All feedback is welcome!
> 
> All feedback? Even if it's 3 months too late?
> 
> If so, then here's a few comments:
> 
> 1. oVirt-3.2 completely supports IPv6 within guests. It would be nice to
>    carry this on to cloud-init, by allowing to set the IPv6 address of
>    the guest. (or are we happy with the auto configured ipv6 addresses?)
> 
> 2. I think that the GUI used for setting IP addresses should be
>    immitated here. It allows Static/DHCP/None, and disables the
>    irrelvant fields when DHCP/None is selected.

Additionally, you should consider showing the vNIC name and not "eth0" etc.
IIUC udev rules are rather unpredictable in this regard and could give your
vNIC a different name on different VM instances (probably by MAC address and/or
PCI address).
Either way, I think it's less confusing to refer to the vNIC itself.

> 
> 3. Is "Support custom volume label for vm payloads" still on the TODO
>    list? Note: F19's dosfstools has renamed mkfs.msdos to mkfs.fat.
>    This means that creating a virtual floppy with a payload currently
>    does not work there (it's a tiny fix, for sure).
> 
> 4. I do not see ovirt-guest-agent mentioned in the feaure page. It is
>    the obvious channel to report that cloud-init is Done to Engine.
> 
> 5. When we come to implement auto-generate of system ssh key, we may
>    want to install a virtio-rng device in our VMs, to ensure that the
>    keys are not too easy to guess. (or create the key in the host and
>    inject it to the guest)

6. Is this going to be supported on template/instance type level?
Probably static IP is not wise on a template, but the other options seem
like they would be the same for most VMs from the same template/instance.

7. Don't forget backwards compatibility considerations for the engine-VDSM
communication, if you're using APIs that aren't available in older VDSM versions.

> 
> Dan.
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From gpadgett at redhat.com  Sun Jun 16 14:50:38 2013
From: gpadgett at redhat.com (Greg Padgett)
Date: Sun, 16 Jun 2013 17:50:38 +0300
Subject: [Engine-devel] Cloud-Init integration
In-Reply-To: <1802344283.227638.1371391719479.JavaMail.root@redhat.com>
References: <5154D3BB.7080004@redhat.com> <20130616130515.GA8170@redhat.com>
	<1802344283.227638.1371391719479.JavaMail.root@redhat.com>
Message-ID: <51BDD0BE.80405@redhat.com>

On 06/16/2013 05:08 PM, Mike Kolesnik wrote:
> ----- Original Message -----
>> On Thu, Mar 28, 2013 at 07:35:23PM -0400, Greg Padgett wrote:
>>> Hi Everyone,
>>>
>>> I'd like to propose a feature we've been doing some investigation
>>> into, which is to integrate cloud-init support into oVirt.
>>>
>>> Cloud-init is used to help provision new Linux systems by setting
>>> the hostname, ip, ssh keys, timezone, injecting files, and more.
>>> It's used by OpenStack (amongst others) now, and has a lot of
>>> features that may be helpful to our users.
>>>
>>> Details are still evolving, but for more info please see the wiki page:
>>>
>>> http://www.ovirt.org/Features/Cloud-Init_Integration
>>>
>>> All feedback is welcome!
>>
>> All feedback? Even if it's 3 months too late?
 >>

I'll have to be more careful next time to specify a time limit :)  But 
really, thank you both for the comments.  Feel free to add them to a "nice 
to have" list on the wiki page, or I can add it.  Replies inline...

>> If so, then here's a few comments:
>>
>> 1. oVirt-3.2 completely supports IPv6 within guests. It would be nice to
>>     carry this on to cloud-init, by allowing to set the IPv6 address of
>>     the guest. (or are we happy with the auto configured ipv6 addresses?)
>>

It would, but unfortunately cloud-init doesn't yet translate ipv6 fields
from /etc/network/interfaces (its chosen networking input format) to
ifcfg files.  Now that you mention it, it doesn't add IPV6INIT=yes,
either.

These are things we can add--to both oVirt and cloud-init, I guess at a
later time.

>> 2. I think that the GUI used for setting IP addresses should be
>>     immitated here. It allows Static/DHCP/None, and disables the
>>     irrelvant fields when DHCP/None is selected.
>

It's close: there is a checkbox for dhcp, and if selected it will hide the 
non-relevant fields.

> Additionally, you should consider showing the vNIC name and not "eth0" etc.
> IIUC udev rules are rather unpredictable in this regard and could give your
> vNIC a different name on different VM instances (probably by MAC address and/or
> PCI address).
> Either way, I think it's less confusing to refer to the vNIC itself.
>

Similarly to the above, I'm not sure how much cloud-init supports with 
respect to vNICs.  The name is used as the /etc/network/interfaces adapter 
name and the ifcfg-* suffix (per distro), so I guess if you plumbed 
everything around that in the image and could finish the setup with just 
the interfaces/ifcfg config file then it would work as-is.  If that isn't 
adequate (I haven't looked or tested) then we may need to consider 
submitting a patch to add this to cloud-init.

>> 3. Is "Support custom volume label for vm payloads" still on the TODO
>>     list? Note: F19's dosfstools has renamed mkfs.msdos to mkfs.fat.
>>     This means that creating a virtual floppy with a payload currently
>>     does not work there (it's a tiny fix, for sure).
>>

It's implemented.  Of course, it still uses mkfs.msdos.

>> 4. I do not see ovirt-guest-agent mentioned in the feaure page. It is
>>     the obvious channel to report that cloud-init is Done to Engine.
>>

You're right, and this is one part of the feature that hasn't been done. 
It may also require some work on cloud-init, or for us to use a different 
input format (i.e. a mime-formatted sequence instead of vanilla 
config-drive-2).  It would be great to add this, though my time to do that 
now is a bit limited.

>> 5. When we come to implement auto-generate of system ssh key, we may
>>     want to install a virtio-rng device in our VMs, to ensure that the
>>     keys are not too easy to guess. (or create the key in the host and
>>     inject it to the guest)
>

Good idea.  I'm not too familiar with virtio-rng, but if the image can be 
configured to use it then the regeneration should follow suit.  So, not a 
limitation right now but not as easy as it could be.  It's another case of 
needing either a cloud-init patch for support or (I'm thinking more likely 
in this case) some scripting and using a mime-formatted input to cloud-init.

> 6. Is this going to be supported on template/instance type level?
> Probably static IP is not wise on a template, but the other options seem
> like they would be the same for most VMs from the same template/instance.
>

Today it's just on "Run VM Once" but once we can persist the cloud-init 
options I don't see why we wouldn't want to allow persisting at least at 
least some of the fields for templates/instance types.

> 7. Don't forget backwards compatibility considerations for the engine-VDSM
> communication, if you're using APIs that aren't available in older VDSM versions.
>

Thanks, it does rely on some new vdsm API features.

>>
>> Dan.
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>



From danken at redhat.com  Sun Jun 16 16:04:27 2013
From: danken at redhat.com (Dan Kenigsberg)
Date: Sun, 16 Jun 2013 19:04:27 +0300
Subject: [Engine-devel] Cloud-Init integration
In-Reply-To: <51BDD0BE.80405@redhat.com>
References: <5154D3BB.7080004@redhat.com> <20130616130515.GA8170@redhat.com>
	<1802344283.227638.1371391719479.JavaMail.root@redhat.com>
	<51BDD0BE.80405@redhat.com>
Message-ID: <20130616160427.GA11932@redhat.com>

On Sun, Jun 16, 2013 at 05:50:38PM +0300, Greg Padgett wrote:
> On 06/16/2013 05:08 PM, Mike Kolesnik wrote:
> >----- Original Message -----
> >>On Thu, Mar 28, 2013 at 07:35:23PM -0400, Greg Padgett wrote:
> >>>Hi Everyone,
> >>>
> >>>I'd like to propose a feature we've been doing some investigation
> >>>into, which is to integrate cloud-init support into oVirt.
> >>>
> >>>Cloud-init is used to help provision new Linux systems by setting
> >>>the hostname, ip, ssh keys, timezone, injecting files, and more.
> >>>It's used by OpenStack (amongst others) now, and has a lot of
> >>>features that may be helpful to our users.
> >>>
> >>>Details are still evolving, but for more info please see the wiki page:
> >>>
> >>>http://www.ovirt.org/Features/Cloud-Init_Integration
> >>>
> >>>All feedback is welcome!
> >>
> >>All feedback? Even if it's 3 months too late?
> >>
> 
> I'll have to be more careful next time to specify a time limit :)
> But really, thank you both for the comments.  Feel free to add them
> to a "nice to have" list on the wiki page, or I can add it.  Replies
> inline...
> 
> >>If so, then here's a few comments:
> >>
> >>1. oVirt-3.2 completely supports IPv6 within guests. It would be nice to
> >>    carry this on to cloud-init, by allowing to set the IPv6 address of
> >>    the guest. (or are we happy with the auto configured ipv6 addresses?)
> >>
> 
> It would, but unfortunately cloud-init doesn't yet translate ipv6 fields
> from /etc/network/interfaces (its chosen networking input format) to
> ifcfg files.  Now that you mention it, it doesn't add IPV6INIT=yes,
> either.

ifcfg files? What's that? Those easily-edited text files that are being
deprecated by NetworkManager? Does cloud-init play well with the latter?
(we found a couple of pitfalls, the hard way).

> 
> These are things we can add--to both oVirt and cloud-init, I guess at a
> later time.
> 
> >>2. I think that the GUI used for setting IP addresses should be
> >>    immitated here. It allows Static/DHCP/None, and disables the
> >>    irrelvant fields when DHCP/None is selected.
> >
> 
> It's close: there is a checkbox for dhcp, and if selected it will
> hide the non-relevant fields.

I hate surprises, so I'm in favor of having the same thing, as well as
the "keep recent config in memory when bootproto is moved to None"
semantics.

This applies more strongly to the REST api. Host level configuration
http://www.ovirt.org/Features/Design/Network/SetupNetworks#Scheme has
   <host_nic>
     <name>em1</name>
     <ip address="10.35.1.247" netmask="255.255.254.0" gateway="10.35.1.254"/>
     <boot_protocol>dhcp</boot_protocol>
   </host_nic>

And for reporting guest configuration
http://www.ovirt.org/Feature/ReportingVnicImplementation#API_Changes has
  <network_device>
     <name>p1p2</name>
     <description>guest reported data</description>
     <ips>
         <ip version="v4" address="10.35.1.177"/>
         <ip version="v6" address="fe80::21a:4aff:fe16:151"/>
     </ips>
  </network_device>

which we should strive to maintain with this feature. Even if cloud-init is not
currently capable of setting multiple addresses, let the API allow for it.

> 
> >Additionally, you should consider showing the vNIC name and not "eth0" etc.
> >IIUC udev rules are rather unpredictable in this regard and could give your
> >vNIC a different name on different VM instances (probably by MAC address and/or
> >PCI address).
> >Either way, I think it's less confusing to refer to the vNIC itself.
> >
> 
> Similarly to the above, I'm not sure how much cloud-init supports
> with respect to vNICs.  The name is used as the
> /etc/network/interfaces adapter name and the ifcfg-* suffix (per
> distro), so I guess if you plumbed everything around that in the
> image and could finish the setup with just the interfaces/ifcfg
> config file then it would work as-is.  If that isn't adequate (I
> haven't looked or tested) then we may need to consider submitting a
> patch to add this to cloud-init.

Either way, RHEV should not expose in its own interface the "eth0" names
that we cannot enforce within the guest. E.g., my Fedora has funny
interface names such as em1 and wlp3s0, nothing like the good old eth*.

> 
> >>3. Is "Support custom volume label for vm payloads" still on the TODO
> >>    list? Note: F19's dosfstools has renamed mkfs.msdos to mkfs.fat.
> >>    This means that creating a virtual floppy with a payload currently
> >>    does not work there (it's a tiny fix, for sure).
> >>
> 
> It's implemented.  Of course, it still uses mkfs.msdos.

Implemented but not yet posted, I presume? Because upstream vdsm's does
not use mkfs.msdos's -n.

> 
> >>4. I do not see ovirt-guest-agent mentioned in the feaure page. It is
> >>    the obvious channel to report that cloud-init is Done to Engine.
> >>
> 
> You're right, and this is one part of the feature that hasn't been
> done. It may also require some work on cloud-init, or for us to use
> a different input format (i.e. a mime-formatted sequence instead of
> vanilla config-drive-2).  It would be great to add this, though my
> time to do that now is a bit limited.

What is the target oVirt version for this feature, by the way? It is not listed
in http://www.ovirt.org/OVirt_3.3_release-management, so I presume it's for
3.4?

> 
> >>5. When we come to implement auto-generate of system ssh key, we may
> >>    want to install a virtio-rng device in our VMs, to ensure that the
> >>    keys are not too easy to guess. (or create the key in the host and
> >>    inject it to the guest)
> >
> 
> Good idea.  I'm not too familiar with virtio-rng, but if the image
> can be configured to use it then the regeneration should follow
> suit.  So, not a limitation right now but not as easy as it could
> be.  It's another case of needing either a cloud-init patch for
> support or (I'm thinking more likely in this case) some scripting
> and using a mime-formatted input to cloud-init.

I do not think any user-space changes are needed in the guest. The guest
kernel should know how to suck entropy from the virtio-rng device and
expose it for guest applications in /dev/random.

> 
> >6. Is this going to be supported on template/instance type level?
> >Probably static IP is not wise on a template, but the other options seem
> >like they would be the same for most VMs from the same template/instance.
> >
> 
> Today it's just on "Run VM Once" but once we can persist the
> cloud-init options I don't see why we wouldn't want to allow
> persisting at least at least some of the fields for
> templates/instance types.
> 
> >7. Don't forget backwards compatibility considerations for the engine-VDSM
> >communication, if you're using APIs that aren't available in older VDSM versions.
> >
> 
> Thanks, it does rely on some new vdsm API features.

Would you document the suggested API changes in the feature page?

Dan.


From alonbl at redhat.com  Mon Jun 17 08:24:20 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Mon, 17 Jun 2013 04:24:20 -0400 (EDT)
Subject: [Engine-devel] [ATN] moving dbscripts location
In-Reply-To: <2102235080.9807977.1371456516922.JavaMail.root@redhat.com>
Message-ID: <1268757897.9810069.1371457460680.JavaMail.root@redhat.com>


Hello All,

During the work I am doing to clean up the build of upcoming 3.3, I am going to move[1] dbscripts directory from:
    backend/manager/dbscripts
to:
    packaging/dbscripts

The packaging directory is a new directory established for files we copy as-is to installation media, dbscripts was the last remaining directory of that nature. dbscripts does not really belong to the java sources nor to required for java project build (except few validation that were kept).

The packaging directory has the following advantages:

1. Simplify the build system to blindly copy files recursively from packaging to installation media.

2. Do not copy unnecessary files as we copy today, example is pom.xml.

3. Allow easy split plain files within packaging directory to sub packages in future.

4. Easier to understand the target system file layout by browsing the packaging directory, no magic of renaming or on the fly creation.

5. A clear separation between the maven build and the packaging build.

Regards,
Alon Bar-Lev.

[1] http://gerrit.ovirt.org/#/c/15743


From emesika at redhat.com  Mon Jun 17 08:28:11 2013
From: emesika at redhat.com (Eli Mesika)
Date: Mon, 17 Jun 2013 04:28:11 -0400 (EDT)
Subject: [Engine-devel] [ATN] moving dbscripts location
In-Reply-To: <1268757897.9810069.1371457460680.JavaMail.root@redhat.com>
References: <1268757897.9810069.1371457460680.JavaMail.root@redhat.com>
Message-ID: <750853424.16785083.1371457691199.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Alon Bar-Lev" <alonbl at redhat.com>
> To: "engine-devel" <engine-devel at ovirt.org>
> Cc: "Eli Mesika" <emesika at redhat.com>
> Sent: Monday, June 17, 2013 11:24:20 AM
> Subject: [ATN] moving dbscripts location
> 
> 
> Hello All,
> 
> During the work I am doing to clean up the build of upcoming 3.3, I am going
> to move[1] dbscripts directory from:
>     backend/manager/dbscripts
> to:
>     packaging/dbscripts
> 
> The packaging directory is a new directory established for files we copy
> as-is to installation media, dbscripts was the last remaining directory of
> that nature. dbscripts does not really belong to the java sources nor to
> required for java project build (except few validation that were kept).
> 
> The packaging directory has the following advantages:
> 
> 1. Simplify the build system to blindly copy files recursively from packaging
> to installation media.
> 
> 2. Do not copy unnecessary files as we copy today, example is pom.xml.
> 
> 3. Allow easy split plain files within packaging directory to sub packages in
> future.
> 
> 4. Easier to understand the target system file layout by browsing the
> packaging directory, no magic of renaming or on the fly creation.
> 
> 5. A clear separation between the maven build and the packaging build.
> 
> Regards,
> Alon Bar-Lev.
> 
> [1] http://gerrit.ovirt.org/#/c/15743

Hi
I had reviewed that patch and it seems that it can be merged ASAP.

+1 for merging that 

> 


From michal.skrivanek at redhat.com  Mon Jun 17 10:40:44 2013
From: michal.skrivanek at redhat.com (Michal Skrivanek)
Date: Mon, 17 Jun 2013 12:40:44 +0200
Subject: [Engine-devel] Cloud-Init integration
In-Reply-To: <20130616160427.GA11932@redhat.com>
References: <5154D3BB.7080004@redhat.com> <20130616130515.GA8170@redhat.com>
	<1802344283.227638.1371391719479.JavaMail.root@redhat.com>
	<51BDD0BE.80405@redhat.com> <20130616160427.GA11932@redhat.com>
Message-ID: <62B8E563-4B1C-4F1D-88A6-EAB51AEFEC45@redhat.com>


On Jun 16, 2013, at 18:04 , Dan Kenigsberg <danken at redhat.com> wrote:

> On Sun, Jun 16, 2013 at 05:50:38PM +0300, Greg Padgett wrote:
>> On 06/16/2013 05:08 PM, Mike Kolesnik wrote:
>>> ----- Original Message -----
>>>> On Thu, Mar 28, 2013 at 07:35:23PM -0400, Greg Padgett wrote:
>>>>> Hi Everyone,
>>>>> 
>>>>> I'd like to propose a feature we've been doing some investigation
>>>>> into, which is to integrate cloud-init support into oVirt.
>>>>> 
>>>>> Cloud-init is used to help provision new Linux systems by setting
>>>>> the hostname, ip, ssh keys, timezone, injecting files, and more.
>>>>> It's used by OpenStack (amongst others) now, and has a lot of
>>>>> features that may be helpful to our users.
>>>>> 
>>>>> Details are still evolving, but for more info please see the wiki page:
>>>>> 
>>>>> http://www.ovirt.org/Features/Cloud-Init_Integration
>>>>> 
>>>>> All feedback is welcome!
>>>> 
>>>> All feedback? Even if it's 3 months too late?
>>>> 
>> 
>> I'll have to be more careful next time to specify a time limit :)
>> But really, thank you both for the comments.  Feel free to add them
>> to a "nice to have" list on the wiki page, or I can add it.  Replies
>> inline...
>> 
>>>> If so, then here's a few comments:
>>>> 
>>>> 1. oVirt-3.2 completely supports IPv6 within guests. It would be nice to
>>>>   carry this on to cloud-init, by allowing to set the IPv6 address of
>>>>   the guest. (or are we happy with the auto configured ipv6 addresses?)
>>>> 
>> 
>> It would, but unfortunately cloud-init doesn't yet translate ipv6 fields
>> from /etc/network/interfaces (its chosen networking input format) to
>> ifcfg files.  Now that you mention it, it doesn't add IPV6INIT=yes,
>> either.
> 
> ifcfg files? What's that? Those easily-edited text files that are being
> deprecated by NetworkManager? Does cloud-init play well with the latter?
> (we found a couple of pitfalls, the hard way).
> 
>> 
>> These are things we can add--to both oVirt and cloud-init, I guess at a
>> later time.
>> 
>>>> 2. I think that the GUI used for setting IP addresses should be
>>>>   immitated here. It allows Static/DHCP/None, and disables the
>>>>   irrelvant fields when DHCP/None is selected.
>>> 
>> 
>> It's close: there is a checkbox for dhcp, and if selected it will
>> hide the non-relevant fields.
> 
> I hate surprises, so I'm in favor of having the same thing, as well as
> the "keep recent config in memory when bootproto is moved to None"
> semantics.
> 
> This applies more strongly to the REST api. Host level configuration
> http://www.ovirt.org/Features/Design/Network/SetupNetworks#Scheme has
>   <host_nic>
>     <name>em1</name>
>     <ip address="10.35.1.247" netmask="255.255.254.0" gateway="10.35.1.254"/>
>     <boot_protocol>dhcp</boot_protocol>
>   </host_nic>
> 
> And for reporting guest configuration
> http://www.ovirt.org/Feature/ReportingVnicImplementation#API_Changes has
>  <network_device>
>     <name>p1p2</name>
>     <description>guest reported data</description>
>     <ips>
>         <ip version="v4" address="10.35.1.177"/>
>         <ip version="v6" address="fe80::21a:4aff:fe16:151"/>
>     </ips>
>  </network_device>
> 
> which we should strive to maintain with this feature. Even if cloud-init is not
> currently capable of setting multiple addresses, let the API allow for it.
> 
>> 
>>> Additionally, you should consider showing the vNIC name and not "eth0" etc.
>>> IIUC udev rules are rather unpredictable in this regard and could give your
>>> vNIC a different name on different VM instances (probably by MAC address and/or
>>> PCI address).
>>> Either way, I think it's less confusing to refer to the vNIC itself.
>>> 
>> 
>> Similarly to the above, I'm not sure how much cloud-init supports
>> with respect to vNICs.  The name is used as the
>> /etc/network/interfaces adapter name and the ifcfg-* suffix (per
>> distro), so I guess if you plumbed everything around that in the
>> image and could finish the setup with just the interfaces/ifcfg
>> config file then it would work as-is.  If that isn't adequate (I
>> haven't looked or tested) then we may need to consider submitting a
>> patch to add this to cloud-init.
> 
> Either way, RHEV should not expose in its own interface the "eth0" names
> that we cannot enforce within the guest. E.g., my Fedora has funny
> interface names such as em1 and wlp3s0, nothing like the good old eth*.
> 
>> 
>>>> 3. Is "Support custom volume label for vm payloads" still on the TODO
>>>>   list? Note: F19's dosfstools has renamed mkfs.msdos to mkfs.fat.
>>>>   This means that creating a virtual floppy with a payload currently
>>>>   does not work there (it's a tiny fix, for sure).
>>>> 
>> 
>> It's implemented.  Of course, it still uses mkfs.msdos.
> 
> Implemented but not yet posted, I presume? Because upstream vdsm's does
> not use mkfs.msdos's -n.
> 
>> 
>>>> 4. I do not see ovirt-guest-agent mentioned in the feaure page. It is
>>>>   the obvious channel to report that cloud-init is Done to Engine.
>>>> 
>> 
>> You're right, and this is one part of the feature that hasn't been
>> done. It may also require some work on cloud-init, or for us to use
>> a different input format (i.e. a mime-formatted sequence instead of
>> vanilla config-drive-2).  It would be great to add this, though my
>> time to do that now is a bit limited.
> 
> What is the target oVirt version for this feature, by the way? It is not listed
> in http://www.ovirt.org/OVirt_3.3_release-management, so I presume it's for
> 3.4?

no, should be 3.3. I think it's an omission. The goal is not to implement all network options we can ever have but rather an initial integration with cloud-init, whatever it does support now. And then go from there?

> 
>> 
>>>> 5. When we come to implement auto-generate of system ssh key, we may
>>>>   want to install a virtio-rng device in our VMs, to ensure that the
>>>>   keys are not too easy to guess. (or create the key in the host and
>>>>   inject it to the guest)
>>> 
>> 
>> Good idea.  I'm not too familiar with virtio-rng, but if the image
>> can be configured to use it then the regeneration should follow
>> suit.  So, not a limitation right now but not as easy as it could
>> be.  It's another case of needing either a cloud-init patch for
>> support or (I'm thinking more likely in this case) some scripting
>> and using a mime-formatted input to cloud-init.
> 
> I do not think any user-space changes are needed in the guest. The guest
> kernel should know how to suck entropy from the virtio-rng device and
> expose it for guest applications in /dev/random.

I suppose we want to generate it on the host and maintain/manage the ssh keys in the engine. The latter for sure so it doesn't seem much worth implementing virtio-rng in guest, but I may be wrong.

> 
>> 
>>> 6. Is this going to be supported on template/instance type level?
>>> Probably static IP is not wise on a template, but the other options seem
>>> like they would be the same for most VMs from the same template/instance.
>>> 
>> 
>> Today it's just on "Run VM Once" but once we can persist the
>> cloud-init options I don't see why we wouldn't want to allow
>> persisting at least at least some of the fields for
>> templates/instance types.
>> 
>>> 7. Don't forget backwards compatibility considerations for the engine-VDSM
>>> communication, if you're using APIs that aren't available in older VDSM versions.
>>> 
>> 
>> Thanks, it does rely on some new vdsm API features.
> 
> Would you document the suggested API changes in the feature page?
> 
> Dan.
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel



From emesika at redhat.com  Mon Jun 17 12:49:12 2013
From: emesika at redhat.com (Eli Mesika)
Date: Mon, 17 Jun 2013 08:49:12 -0400 (EDT)
Subject: [Engine-devel] SELinux problem
In-Reply-To: <1446044480.16877597.1371472469135.JavaMail.root@redhat.com>
Message-ID: <1906733342.16884011.1371473352138.JavaMail.root@redhat.com>

Hi

I am using SELinux Enforcing mode on Fedora 18 (selinux-policy-3.11.1-97.fc18.noarch)

As part as our Postgres DB restore we have to 

1) Open a postgres backup packed as a TAR file
2) Restore the database from those files after unpacking with tar xvf.

I have found that I get a Permission Denied when trying to restore the database data files.
After investigation , I had found that running : setenforce 0 the restore completes with no errors.
Further investigation shows that when I am extracting the TAR file , I have to set the same SELinux context as in /var/lib/pgsql/data directory , i.e. 
unconfined_u:object_r:postgresql_db_t:s0 

I had tried to do that with chcon :

chcon -u unconfined_u -r object_r -t postgresql_db_t <file>

This was failed (also when running with root privileges) and audit2why --all shows a lot of those errors :

type=AVC msg=audit(1371464569.023:671): avc:  denied  { relabelto } for  pid=18144 comm="chcon" name="toc.dat" dev="tmpfs" ino=117639 scontext=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 tcontext=system_u:system_r:postgresql_t:s0 tclass=file
        Was caused by:
                Missing type enforcement (TE) allow rule.

                You can use audit2allow to generate a loadable module to allow this access.


After goggling around that , I found an article by you:

https://docs.fedoraproject.org/en-US/Fedora/11/html/Security-Enhanced_Linux/sect-Security-Enhanced_Linux-Fixing_Problems-Allowing_Access_audit2allow.html

It says : "Missing Type Enforcement rules are usually caused by bugs in SELinux policy, and should be reported in Red Hat Bugzilla. For Fedora, create bugs against the Fedora product, and select the selinux-policy component. Include the output of the audit2allow -w -a and audit2allow -a commands in such bug reports. "

Should I open a BZ on that ?

The TAR I am using is attached. (I am opening it with tar xvf and trying to change the context to desired context as explained above)

Thanks

Eli


 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 00579652_221211073824_pgdump.tar
Type: application/x-tar
Size: 1734144 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130617/773e471c/attachment.tar>

From sbonazzo at redhat.com  Mon Jun 17 12:53:27 2013
From: sbonazzo at redhat.com (Sandro Bonazzola)
Date: Mon, 17 Jun 2013 14:53:27 +0200
Subject: [Engine-devel] SELinux problem
In-Reply-To: <1906733342.16884011.1371473352138.JavaMail.root@redhat.com>
References: <1906733342.16884011.1371473352138.JavaMail.root@redhat.com>
Message-ID: <51BF06C7.9050002@redhat.com>

Il 17/06/2013 14:49, Eli Mesika ha scritto:
> Hi
>
> I am using SELinux Enforcing mode on Fedora 18 (selinux-policy-3.11.1-97.fc18.noarch)
>
> As part as our Postgres DB restore we have to 
>
> 1) Open a postgres backup packed as a TAR file
> 2) Restore the database from those files after unpacking with tar xvf.


Why using tar xvf instead of pg_restore?

-- 
Sandro Bonazzola
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com



From emesika at redhat.com  Mon Jun 17 12:57:12 2013
From: emesika at redhat.com (Eli Mesika)
Date: Mon, 17 Jun 2013 08:57:12 -0400 (EDT)
Subject: [Engine-devel] SELinux problem
In-Reply-To: <51BF06C7.9050002@redhat.com>
References: <1906733342.16884011.1371473352138.JavaMail.root@redhat.com>
	<51BF06C7.9050002@redhat.com>
Message-ID: <453803842.16886552.1371473832040.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Sandro Bonazzola" <sbonazzo at redhat.com>
> To: "Eli Mesika" <emesika at redhat.com>
> Cc: "Daniel Walsh" <dwalsh at redhat.com>, "engine-devel" <engine-devel at ovirt.org>
> Sent: Monday, June 17, 2013 3:53:27 PM
> Subject: Re: [Engine-devel] SELinux problem
> 
> Il 17/06/2013 14:49, Eli Mesika ha scritto:
> > Hi
> >
> > I am using SELinux Enforcing mode on Fedora 18
> > (selinux-policy-3.11.1-97.fc18.noarch)
> >
> > As part as our Postgres DB restore we have to
> >
> > 1) Open a postgres backup packed as a TAR file
> > 2) Restore the database from those files after unpacking with tar xvf.
> 
> 
> Why using tar xvf instead of pg_restore?

There is another PG BZ that prevents us from using the pg_restore 
We have to open the TAR and hack the content of the restore.sql file 
for more details see
http://www.postgresql.org/message-id/E1TrqX7-0002qd-4e at wrigleys.postgresql.org


> 
> --
> Sandro Bonazzola
> Better technology. Faster innovation. Powered by community collaboration.
> See how it works at redhat.com
> 
> 


From emesika at redhat.com  Mon Jun 17 19:17:35 2013
From: emesika at redhat.com (Eli Mesika)
Date: Mon, 17 Jun 2013 15:17:35 -0400 (EDT)
Subject: [Engine-devel] SELinux problem
In-Reply-To: <51BF307B.40101@redhat.com>
References: <1906733342.16884011.1371473352138.JavaMail.root@redhat.com>
	<51BF307B.40101@redhat.com>
Message-ID: <2046099899.17179122.1371496655593.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Daniel J Walsh" <dwalsh at redhat.com>
> To: "Eli Mesika" <emesika at redhat.com>
> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Barak Azulay" <bazulay at redhat.com>, "engine-devel"
> <engine-devel at ovirt.org>
> Sent: Monday, June 17, 2013 6:51:23 PM
> Subject: Re: SELinux problem
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 06/17/2013 08:49 AM, Eli Mesika wrote:
> > Hi
> > 
> > I am using SELinux Enforcing mode on Fedora 18
> > (selinux-policy-3.11.1-97.fc18.noarch)
> > 
> > As part as our Postgres DB restore we have to
> > 
> > 1) Open a postgres backup packed as a TAR file 2) Restore the database from
> > those files after unpacking with tar xvf.
> > 
> > I have found that I get a Permission Denied when trying to restore the
> > database data files. After investigation , I had found that running :
> > setenforce 0 the restore completes with no errors. Further investigation
> > shows that when I am extracting the TAR file , I have to set the same
> > SELinux context as in /var/lib/pgsql/data directory , i.e.
> > unconfined_u:object_r:postgresql_db_t:s0
> > 
> > I had tried to do that with chcon :
> > 
> > chcon -u unconfined_u -r object_r -t postgresql_db_t <file>
> > 
> > This was failed (also when running with root privileges) and audit2why
> > --all shows a lot of those errors :
> > 
> > type=AVC msg=audit(1371464569.023:671): avc:  denied  { relabelto } for
> > pid=18144 comm="chcon" name="toc.dat" dev="tmpfs" ino=117639
> > scontext=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023
> > tcontext=system_u:system_r:postgresql_t:s0 tclass=file Was caused by:
> > Missing type enforcement (TE) allow rule.
> > 
> > You can use audit2allow to generate a loadable module to allow this
> > access.
> > 
> > 
> > After goggling around that , I found an article by you:
> > 
> > https://docs.fedoraproject.org/en-US/Fedora/11/html/Security-Enhanced_Linux/sect-Security-Enhanced_Linux-Fixing_Problems-Allowing_Access_audit2allow.html
> >
> >  It says : "Missing Type Enforcement rules are usually caused by bugs in
> > SELinux policy, and should be reported in Red Hat Bugzilla. For Fedora,
> > create bugs against the Fedora product, and select the selinux-policy
> > component. Include the output of the audit2allow -w -a and audit2allow -a
> > commands in such bug reports. "
> > 
> > Should I open a BZ on that ?
> > 
> > The TAR I am using is attached. (I am opening it with tar xvf and trying to
> > change the context to desired context as explained above)
> > 
> > Thanks
> > 
> > Eli
> > 
> > 
> > 
> > 
> Just untar the files and run restorecon -R on them
> 
> restorecon -R PATH

Thanks for the quick response
I had tried it and nothing happen , same results 
So I had tried with  -RVVF flags and got  the following 

restorecon:  Warning no default label for /tmp/db/00579652_221211073824_pgdump.tar_dir/3622.dat

( this appears on each file of the extracted files )

So, it seems that the pg_dump did not set the correct SELinux defaults on those file when packaging them , right ?

Any workaround to get out of that...

Thanks again

Eli



> 
> SHould put the default labels on the content.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.13 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
> 
> iEYEARECAAYFAlG/MHsACgkQrlYvE4MpobOjNACff0Ugxb2zWZqx+At3orGPS4s7
> CZ0AoNQSRB2QSCrise2m4gFiEO2sbCh1
> =hdyR
> -----END PGP SIGNATURE-----
> 


From dwalsh at redhat.com  Mon Jun 17 15:51:23 2013
From: dwalsh at redhat.com (Daniel J Walsh)
Date: Mon, 17 Jun 2013 11:51:23 -0400
Subject: [Engine-devel] SELinux problem
In-Reply-To: <1906733342.16884011.1371473352138.JavaMail.root@redhat.com>
References: <1906733342.16884011.1371473352138.JavaMail.root@redhat.com>
Message-ID: <51BF307B.40101@redhat.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/17/2013 08:49 AM, Eli Mesika wrote:
> Hi
> 
> I am using SELinux Enforcing mode on Fedora 18
> (selinux-policy-3.11.1-97.fc18.noarch)
> 
> As part as our Postgres DB restore we have to
> 
> 1) Open a postgres backup packed as a TAR file 2) Restore the database from
> those files after unpacking with tar xvf.
> 
> I have found that I get a Permission Denied when trying to restore the
> database data files. After investigation , I had found that running :
> setenforce 0 the restore completes with no errors. Further investigation
> shows that when I am extracting the TAR file , I have to set the same
> SELinux context as in /var/lib/pgsql/data directory , i.e. 
> unconfined_u:object_r:postgresql_db_t:s0
> 
> I had tried to do that with chcon :
> 
> chcon -u unconfined_u -r object_r -t postgresql_db_t <file>
> 
> This was failed (also when running with root privileges) and audit2why
> --all shows a lot of those errors :
> 
> type=AVC msg=audit(1371464569.023:671): avc:  denied  { relabelto } for
> pid=18144 comm="chcon" name="toc.dat" dev="tmpfs" ino=117639
> scontext=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023
> tcontext=system_u:system_r:postgresql_t:s0 tclass=file Was caused by: 
> Missing type enforcement (TE) allow rule.
> 
> You can use audit2allow to generate a loadable module to allow this
> access.
> 
> 
> After goggling around that , I found an article by you:
> 
> https://docs.fedoraproject.org/en-US/Fedora/11/html/Security-Enhanced_Linux/sect-Security-Enhanced_Linux-Fixing_Problems-Allowing_Access_audit2allow.html
>
>  It says : "Missing Type Enforcement rules are usually caused by bugs in
> SELinux policy, and should be reported in Red Hat Bugzilla. For Fedora,
> create bugs against the Fedora product, and select the selinux-policy
> component. Include the output of the audit2allow -w -a and audit2allow -a
> commands in such bug reports. "
> 
> Should I open a BZ on that ?
> 
> The TAR I am using is attached. (I am opening it with tar xvf and trying to
> change the context to desired context as explained above)
> 
> Thanks
> 
> Eli
> 
> 
> 
> 
Just untar the files and run restorecon -R on them

restorecon -R PATH

SHould put the default labels on the content.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlG/MHsACgkQrlYvE4MpobOjNACff0Ugxb2zWZqx+At3orGPS4s7
CZ0AoNQSRB2QSCrise2m4gFiEO2sbCh1
=hdyR
-----END PGP SIGNATURE-----


From Richard.Hopper at netapp.com  Mon Jun 17 18:16:03 2013
From: Richard.Hopper at netapp.com (Hopper, Richard)
Date: Mon, 17 Jun 2013 18:16:03 +0000
Subject: [Engine-devel] IE9 Issue with UI Plugin
Message-ID: <CDE4CAA2.5617%rickyh@netapp.com>

Hi Vojtech,

I had previously sent you an email about IE9 compatibility where the problem we were having was solved by omitting console logging when a console was unavailable (i.e. IE). However, it is looking like IE9 may have a bigger issue with regards to the plugin framework.

Now that we have gotten dialogs to open via dynamically inserted buttons within RHEV tabs (for example, a NetApp button in the Storage tab), we can go through our whole process with the exception of closing the window. In all other browsers, our dialog will close as expected, but in IE the window remains open. It can be closed by hitting the red "x" in the corner, but it appears the code in the frame itself cannot close the window, with a console message in the dev tools of IE9 showing an error of "'Math' is undefined". I've read up on this, and it seems like this is a very widespread error in Internet Explorer concerning the manner/order in which iframes are dynamically inserted.

I've copied engine-devel in case anyone has similar issues/solutions, but it seems as though we need some sort of clause in the plugin framework for IE when it comes to dynamic insertion of new windows.

- Ricky Hopper
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130617/ed0107cd/attachment.html>

From dwalsh at redhat.com  Mon Jun 17 21:15:09 2013
From: dwalsh at redhat.com (Daniel J Walsh)
Date: Mon, 17 Jun 2013 17:15:09 -0400
Subject: [Engine-devel] SELinux problem
In-Reply-To: <2046099899.17179122.1371496655593.JavaMail.root@redhat.com>
References: <1906733342.16884011.1371473352138.JavaMail.root@redhat.com>
	<51BF307B.40101@redhat.com>
	<2046099899.17179122.1371496655593.JavaMail.root@redhat.com>
Message-ID: <51BF7C5D.3080904@redhat.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/17/2013 03:17 PM, Eli Mesika wrote:
> 
> 
> ----- Original Message -----
>> From: "Daniel J Walsh" <dwalsh at redhat.com> To: "Eli Mesika"
>> <emesika at redhat.com> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Barak
>> Azulay" <bazulay at redhat.com>, "engine-devel" <engine-devel at ovirt.org> 
>> Sent: Monday, June 17, 2013 6:51:23 PM Subject: Re: SELinux problem
>> 
> On 06/17/2013 08:49 AM, Eli Mesika wrote:
>>>> Hi
>>>> 
>>>> I am using SELinux Enforcing mode on Fedora 18 
>>>> (selinux-policy-3.11.1-97.fc18.noarch)
>>>> 
>>>> As part as our Postgres DB restore we have to
>>>> 
>>>> 1) Open a postgres backup packed as a TAR file 2) Restore the
>>>> database from those files after unpacking with tar xvf.
>>>> 
>>>> I have found that I get a Permission Denied when trying to restore
>>>> the database data files. After investigation , I had found that
>>>> running : setenforce 0 the restore completes with no errors. Further
>>>> investigation shows that when I am extracting the TAR file , I have
>>>> to set the same SELinux context as in /var/lib/pgsql/data directory ,
>>>> i.e. unconfined_u:object_r:postgresql_db_t:s0
>>>> 
>>>> I had tried to do that with chcon :
>>>> 
>>>> chcon -u unconfined_u -r object_r -t postgresql_db_t <file>
>>>> 
>>>> This was failed (also when running with root privileges) and
>>>> audit2why --all shows a lot of those errors :
>>>> 
>>>> type=AVC msg=audit(1371464569.023:671): avc:  denied  { relabelto }
>>>> for pid=18144 comm="chcon" name="toc.dat" dev="tmpfs" ino=117639 
>>>> scontext=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 
>>>> tcontext=system_u:system_r:postgresql_t:s0 tclass=file Was caused
>>>> by: Missing type enforcement (TE) allow rule.
>>>> 
>>>> You can use audit2allow to generate a loadable module to allow this 
>>>> access.
>>>> 
>>>> 
>>>> After goggling around that , I found an article by you:
>>>> 
>>>> https://docs.fedoraproject.org/en-US/Fedora/11/html/Security-Enhanced_Linux/sect-Security-Enhanced_Linux-Fixing_Problems-Allowing_Access_audit2allow.html
>>>>
>>>>
>>>> 
It says : "Missing Type Enforcement rules are usually caused by bugs in
>>>> SELinux policy, and should be reported in Red Hat Bugzilla. For
>>>> Fedora, create bugs against the Fedora product, and select the
>>>> selinux-policy component. Include the output of the audit2allow -w -a
>>>> and audit2allow -a commands in such bug reports. "
>>>> 
>>>> Should I open a BZ on that ?
>>>> 
>>>> The TAR I am using is attached. (I am opening it with tar xvf and
>>>> trying to change the context to desired context as explained above)
>>>> 
>>>> Thanks
>>>> 
>>>> Eli
>>>> 
>>>> 
>>>> 
>>>> 
> Just untar the files and run restorecon -R on them
> 
> restorecon -R PATH
> 
>> Thanks for the quick response I had tried it and nothing happen , same
>> results So I had tried with  -RVVF flags and got  the following
> 
>> restorecon:  Warning no default label for
>> /tmp/db/00579652_221211073824_pgdump.tar_dir/3622.dat
> 
>> ( this appears on each file of the extracted files )
> 
>> So, it seems that the pg_dump did not set the correct SELinux defaults on
>> those file when packaging them , right ?
> 
>> Any workaround to get out of that...
> 
>> Thanks again
> 
>> Eli
> 
> 
> 
> 
> SHould put the default labels on the content.
>> 

Why are you storing your postgresql database on a /tmp directory?

If you put it in the normal places, it would have worked.

If you must have it there then you need to label it with

chcon -Rt postgresql_db_t /tmp/db

Will change the label to be useable by postgresql.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlG/fF0ACgkQrlYvE4MpobPoXwCfeKhb+JEJX1l/xL/RbavAOjwf
mwMAoOAhh/m3cifg3ktXF9oAkpHLLlZB
=4S5u
-----END PGP SIGNATURE-----


From emesika at redhat.com  Tue Jun 18 00:21:50 2013
From: emesika at redhat.com (Eli Mesika)
Date: Mon, 17 Jun 2013 20:21:50 -0400 (EDT)
Subject: [Engine-devel] SELinux problem
In-Reply-To: <51BF7C5D.3080904@redhat.com>
References: <1906733342.16884011.1371473352138.JavaMail.root@redhat.com>
	<51BF307B.40101@redhat.com>
	<2046099899.17179122.1371496655593.JavaMail.root@redhat.com>
	<51BF7C5D.3080904@redhat.com>
Message-ID: <1887565342.46316.1371514910286.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Daniel J Walsh" <dwalsh at redhat.com>
> To: "Eli Mesika" <emesika at redhat.com>
> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Barak Azulay" <bazulay at redhat.com>, "engine-devel"
> <engine-devel at ovirt.org>
> Sent: Tuesday, June 18, 2013 12:15:09 AM
> Subject: Re: SELinux problem
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 06/17/2013 03:17 PM, Eli Mesika wrote:
> > 
> > 
> > ----- Original Message -----
> >> From: "Daniel J Walsh" <dwalsh at redhat.com> To: "Eli Mesika"
> >> <emesika at redhat.com> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Barak
> >> Azulay" <bazulay at redhat.com>, "engine-devel" <engine-devel at ovirt.org>
> >> Sent: Monday, June 17, 2013 6:51:23 PM Subject: Re: SELinux problem
> >> 
> > On 06/17/2013 08:49 AM, Eli Mesika wrote:
> >>>> Hi
> >>>> 
> >>>> I am using SELinux Enforcing mode on Fedora 18
> >>>> (selinux-policy-3.11.1-97.fc18.noarch)
> >>>> 
> >>>> As part as our Postgres DB restore we have to
> >>>> 
> >>>> 1) Open a postgres backup packed as a TAR file 2) Restore the
> >>>> database from those files after unpacking with tar xvf.
> >>>> 
> >>>> I have found that I get a Permission Denied when trying to restore
> >>>> the database data files. After investigation , I had found that
> >>>> running : setenforce 0 the restore completes with no errors. Further
> >>>> investigation shows that when I am extracting the TAR file , I have
> >>>> to set the same SELinux context as in /var/lib/pgsql/data directory ,
> >>>> i.e. unconfined_u:object_r:postgresql_db_t:s0
> >>>> 
> >>>> I had tried to do that with chcon :
> >>>> 
> >>>> chcon -u unconfined_u -r object_r -t postgresql_db_t <file>
> >>>> 
> >>>> This was failed (also when running with root privileges) and
> >>>> audit2why --all shows a lot of those errors :
> >>>> 
> >>>> type=AVC msg=audit(1371464569.023:671): avc:  denied  { relabelto }
> >>>> for pid=18144 comm="chcon" name="toc.dat" dev="tmpfs" ino=117639
> >>>> scontext=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023
> >>>> tcontext=system_u:system_r:postgresql_t:s0 tclass=file Was caused
> >>>> by: Missing type enforcement (TE) allow rule.
> >>>> 
> >>>> You can use audit2allow to generate a loadable module to allow this
> >>>> access.
> >>>> 
> >>>> 
> >>>> After goggling around that , I found an article by you:
> >>>> 
> >>>> https://docs.fedoraproject.org/en-US/Fedora/11/html/Security-Enhanced_Linux/sect-Security-Enhanced_Linux-Fixing_Problems-Allowing_Access_audit2allow.html
> >>>>
> >>>>
> >>>> 
> It says : "Missing Type Enforcement rules are usually caused by bugs in
> >>>> SELinux policy, and should be reported in Red Hat Bugzilla. For
> >>>> Fedora, create bugs against the Fedora product, and select the
> >>>> selinux-policy component. Include the output of the audit2allow -w -a
> >>>> and audit2allow -a commands in such bug reports. "
> >>>> 
> >>>> Should I open a BZ on that ?
> >>>> 
> >>>> The TAR I am using is attached. (I am opening it with tar xvf and
> >>>> trying to change the context to desired context as explained above)
> >>>> 
> >>>> Thanks
> >>>> 
> >>>> Eli
> >>>> 
> >>>> 
> >>>> 
> >>>> 
> > Just untar the files and run restorecon -R on them
> > 
> > restorecon -R PATH
> > 
> >> Thanks for the quick response I had tried it and nothing happen , same
> >> results So I had tried with  -RVVF flags and got  the following
> > 
> >> restorecon:  Warning no default label for
> >> /tmp/db/00579652_221211073824_pgdump.tar_dir/3622.dat
> > 
> >> ( this appears on each file of the extracted files )
> > 
> >> So, it seems that the pg_dump did not set the correct SELinux defaults on
> >> those file when packaging them , right ?
> > 
> >> Any workaround to get out of that...
> > 
> >> Thanks again
> > 
> >> Eli
> > 
> > 
> > 
> > 
> > SHould put the default labels on the content.
> >> 
> 
> Why are you storing your postgresql database on a /tmp directory?
> 
> If you put it in the normal places, it would have worked.

The reason is that this is a backup file from which I have to restore the database.

> 
> If you must have it there then you need to label it with
> 
> chcon -Rt postgresql_db_t /tmp/db

That worked !!!, thank you very much for your kind help.


> 
> Will change the label to be useable by postgresql.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.13 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
> 
> iEYEARECAAYFAlG/fF0ACgkQrlYvE4MpobPoXwCfeKhb+JEJX1l/xL/RbavAOjwf
> mwMAoOAhh/m3cifg3ktXF9oAkpHLLlZB
> =4S5u
> -----END PGP SIGNATURE-----
> 


From vszocs at redhat.com  Tue Jun 18 11:01:01 2013
From: vszocs at redhat.com (Vojtech Szocs)
Date: Tue, 18 Jun 2013 07:01:01 -0400 (EDT)
Subject: [Engine-devel] if there is a updated debug environment how to?
In-Reply-To: <1306276520.7843210.1370635660793.JavaMail.root@redhat.com>
References: <1f1cccaa.c254.13f13b00539.Coremail.bigclouds@163.com>
	<19879316.JsIC89Exdp@awels>
	<1179830307.7838122.1370634677541.JavaMail.root@redhat.com>
	<1436886.BHuK52khM6@awels>
	<1306276520.7843210.1370635660793.JavaMail.root@redhat.com>
Message-ID: <2084248787.19430955.1371553261241.JavaMail.root@redhat.com>

Hi Alon,

revisiting this thread, I have some comments regarding GWT debugging via standard development environment, as described in README.developer.

- README.developer says:
  For example, if your machine is low on memory, use: EXTRA_BUILD_FLAGS_DEV="-Dgwt-plugin.localWorkers=2"
  however this should be:
  For example, if your machine is low on memory, use: EXTRA_BUILD_FLAGS_DEV="-Dgwt.compiler.localWorkers=2"

- README.developer says:
  By default, only the gecko1_8 support is built
  I'd rather explain what this means:
  By default, only the gecko1_8 (Mozilla Firefox) support is built

- what's the point of having EXTRA_BUILD_FLAGS_DEV_GWT vs. EXTRA_BUILD_FLAGS_DEV ?
  if EXTRA_BUILD_FLAGS_DEV_GWT is meant to control target browser(s) then it should be renamed appropriately
  if EXTRA_BUILD_FLAGS_DEV_GWT is meant to group all GWT-specific flags, README.developer shouldn't advise to do EXTRA_BUILD_FLAGS_DEV="-Dgwt..."

- Makefile gwt-debug target looks OK to me

> What I do expect is that the debugger not to require a specific relation with
> specific application (Webadmin, userportal).

gwt-maven-plugin must be invoked in context of a specific Maven module representing GWT application you want to debug. In other words, you need to start GWT Development Mode for specific application module. This is why you need to "cd" to specific directory (webadmin/userportal-gwtp) before invoking "mvn ... gwt:debug" command.

You cannot start GWT Development Mode in a generic (application-agnostic) way and *then* connect to it from browser and Java IDE, this is not how GWT Development Mode is meant to be used. JBoss remote socket debugging and GWT application debugging are two different things.

> The fact that maven is used to start the debugger is not important.

gwt-maven-plugin is just a wrapper to invoke GWT Development Mode (Java class). Regardless of how you start GWT Development Mode, you need to specify which application (more precisely, GWT modules) you want to debug right when starting GWT Development Mode. See [1] - "module(s)" are always specific for given application.

[1] https://developers.google.com/web-toolkit/doc/latest/DevGuideCompilingAndDebugging#DevGuideCompilerOptions

> If I add "-P gwtdev" to default build using install-dev, all gwt applications
> should be built and installed using the extra debugging information, using:

Yes, as described in [2], besides using "gwtdev" profile for debugging, it can also be used for GWT compilation (i.e. "make install-dev") - in this case, resulting JavaScript will be un-obfuscated and not-too-optimized in order to easily profile the JavaScript application in the browser. In other words, using "gwtdev" for GWT compilation has nothing to do with debugging, maybe we should create separate profile for this purpose.

[2] http://www.ovirt.org/DebugFrontend#Compiling_Frontend_applications_in_detailed_mode

PS: I'll update http://www.ovirt.org/DebugFrontend with regard to standard development environment, as described in README.developer

Vojtech


----- Original Message -----
> From: "Alon Bar-Lev" <alonbl at redhat.com>
> To: awels at redhat.com
> Cc: engine-devel at ovirt.org
> Sent: Friday, June 7, 2013 10:07:40 PM
> Subject: Re: [Engine-devel] if there is a updated debug environment how to?
> 
> 
> 
> ----- Original Message -----
> > From: "Alexander Wels" <awels at redhat.com>
> > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > Cc: engine-devel at ovirt.org, "bigclouds" <bigclouds at 163.com>
> > Sent: Friday, June 7, 2013 10:56:40 PM
> > Subject: Re: [Engine-devel] if there is a updated debug environment how to?
> > 
> > > > > So if I understand correctly, the following is sequence is required:
> > > > > 
> > > > > Build and deploy code:
> > > > > $ make install-dev PREFIX="${HOME}/ovirt-engine"
> > > > > $ "${HOME}/ovirt-engine/share/ovirt-engine/services/ovirt-engine.py"
> > > > > start
> > > >  
> > > >  You missed this part:
> > > > 1. cd into the source code directory of either webadmin or user portal.
> > > > you have to change directory to either
> > > > frontend/webadmin/modules/webadmin
> > > > or frontend/webadmin/modules/userportal-gwtp
> > > > 
> > > > As the maven gwt plugin is only defined in the webadmin and userportal
> > > > poms
> > > > and
> > > > not in the root pom.
> > > 
> > 
> > It doesn't make much sense to put the gwt plugin in the root pom, as the
> > root
> > pom has nothing to do with GWT. The plugin exists in userportal and
> > webadmin
> > as those are GWT modules. The debugger is specifically a GWT debugger, you
> > can't debug anything else with it.
> 
> You perceive this as something of gwt project, while I perceive this part of
> the environment.
> 
> What I expect it to allow as simple development environment as we can.
> Just like I enable the debug port of jboss automatically I would like to
> enable gwt debug.
> 
> If I add "-P gwtdev" to default build using install-dev, all gwt applications
> should be built and installed using the extra debugging information, using:
> 
> $ make install-dev PREFIX="${HOME}/ovirt-engine"
> 
> I can even add GWT_DEBUGGER=1 to optionally enable/disable this feature.
> 
> Now, after starting ovirt-engine service, all I expect is a simple command to
> start the gwt debugger.
> 
> $ make gwt-debugger
> or:
> ./gwt-debugger
> 
> The fact that maven is used to start the debugger is not important.
> 
> What I do expect is that the debugger not to require a specific relation with
> specific application (Webadmin, userportal).
> 
> I would have understood if I had to execute something like the following to
> run the debugger:
> 
> $ cd frontend
> $ mvn gwt:debug -Dgwt.noserver=true
> 
> Or better to avoid building anything:
> 
> $ cd frontend/debugger
> $ mvn gwt:debug -Dgwt.noserver=true
> 
> But I do not understand why a cd to specific application is required.
> 
> Thanks!
> Alon
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From alonbl at redhat.com  Tue Jun 18 11:32:52 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Tue, 18 Jun 2013 07:32:52 -0400 (EDT)
Subject: [Engine-devel] if there is a updated debug environment how to?
In-Reply-To: <2084248787.19430955.1371553261241.JavaMail.root@redhat.com>
References: <1f1cccaa.c254.13f13b00539.Coremail.bigclouds@163.com>
	<19879316.JsIC89Exdp@awels>
	<1179830307.7838122.1370634677541.JavaMail.root@redhat.com>
	<1436886.BHuK52khM6@awels>
	<1306276520.7843210.1370635660793.JavaMail.root@redhat.com>
	<2084248787.19430955.1371553261241.JavaMail.root@redhat.com>
Message-ID: <39510753.10304096.1371555172036.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Vojtech Szocs" <vszocs at redhat.com>
> To: "Alon Bar-Lev" <alonbl at redhat.com>
> Cc: awels at redhat.com, engine-devel at ovirt.org
> Sent: Tuesday, June 18, 2013 2:01:01 PM
> Subject: Re: [Engine-devel] if there is a updated debug environment how to?
> 
> Hi Alon,
> 
> revisiting this thread, I have some comments regarding GWT debugging via
> standard development environment, as described in README.developer.

Thank you for your comments!
As the file is within git, you can submit a patch... :)
I will create one for the following comments.
 
> - README.developer says:
>   For example, if your machine is low on memory, use:
>   EXTRA_BUILD_FLAGS_DEV="-Dgwt-plugin.localWorkers=2"
>   however this should be:
>   For example, if your machine is low on memory, use:
>   EXTRA_BUILD_FLAGS_DEV="-Dgwt.compiler.localWorkers=2"

Fixed.

> 
> - README.developer says:
>   By default, only the gecko1_8 support is built
>   I'd rather explain what this means:
>   By default, only the gecko1_8 (Mozilla Firefox) support is built

Fixed.
 
> - what's the point of having EXTRA_BUILD_FLAGS_DEV_GWT vs.
> EXTRA_BUILD_FLAGS_DEV ?

I wanted to allow customization of GWT as standalone as it require more flags and defaults.

So I can put the following with a default for gwt while allowing application customization.

For example if I have:
EXTRA_BUILD_FLAGS_DEV_GWT:=-D gwt.userAgent=gecko1_8

and execute:
$ make EXTRA_BUILD_FLAGS_DEV="-DskipTests"

I do not override the GWT settings.

BTW: there is a pending patch to rename this to DEV_XXXX[1] to be more consistent.

[1] http://gerrit.ovirt.org/#/c/15735/


>   if EXTRA_BUILD_FLAGS_DEV_GWT is meant to control target browser(s) then it
>   should be renamed appropriately

Any flags, including debug port and such. But I am opened to suggestions... what do you expect it to be named?

>   if EXTRA_BUILD_FLAGS_DEV_GWT is meant to group all GWT-specific flags,
>   README.developer shouldn't advise to do EXTRA_BUILD_FLAGS_DEV="-Dgwt..."

But then I lose the gwt settings.
 
> - Makefile gwt-debug target looks OK to me
> 
> > What I do expect is that the debugger not to require a specific relation
> > with
> > specific application (Webadmin, userportal).
> 
> gwt-maven-plugin must be invoked in context of a specific Maven module
> representing GWT application you want to debug. In other words, you need to
> start GWT Development Mode for specific application module. This is why you
> need to "cd" to specific directory (webadmin/userportal-gwtp) before
> invoking "mvn ... gwt:debug" command.
> 
> You cannot start GWT Development Mode in a generic (application-agnostic) way
> and *then* connect to it from browser and Java IDE, this is not how GWT
> Development Mode is meant to be used. JBoss remote socket debugging and GWT
> application debugging are two different things.

Well, I do expect this to be a feature of top level pom.xml...

something like:
$ mvn -Pgwt-debug -Ddebug.module=webadmin

so that the profile will do whatever necessary to activate the debugger.

> > The fact that maven is used to start the debugger is not important.
> 
> gwt-maven-plugin is just a wrapper to invoke GWT Development Mode (Java
> class). Regardless of how you start GWT Development Mode, you need to
> specify which application (more precisely, GWT modules) you want to debug
> right when starting GWT Development Mode. See [1] - "module(s)" are always
> specific for given application.

So basically what you saying is that you cannot debug two modules at one time...
It is strange... but as long as you fine with it, we are OK.

> 
> [1]
> https://developers.google.com/web-toolkit/doc/latest/DevGuideCompilingAndDebugging#DevGuideCompilerOptions
> 
> > If I add "-P gwtdev" to default build using install-dev, all gwt
> > applications
> > should be built and installed using the extra debugging information, using:
> 
> Yes, as described in [2], besides using "gwtdev" profile for debugging, it
> can also be used for GWT compilation (i.e. "make install-dev") - in this
> case, resulting JavaScript will be un-obfuscated and not-too-optimized in
> order to easily profile the JavaScript application in the browser. In other
> words, using "gwtdev" for GWT compilation has nothing to do with debugging,
> maybe we should create separate profile for this purpose.

That's good.
 
> [2]
> http://www.ovirt.org/DebugFrontend#Compiling_Frontend_applications_in_detailed_mode
> 
> PS: I'll update http://www.ovirt.org/DebugFrontend with regard to standard
> development environment, as described in README.developer
> 
> Vojtech
> 
> 
> ----- Original Message -----
> > From: "Alon Bar-Lev" <alonbl at redhat.com>
> > To: awels at redhat.com
> > Cc: engine-devel at ovirt.org
> > Sent: Friday, June 7, 2013 10:07:40 PM
> > Subject: Re: [Engine-devel] if there is a updated debug environment how to?
> > 
> > 
> > 
> > ----- Original Message -----
> > > From: "Alexander Wels" <awels at redhat.com>
> > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > Cc: engine-devel at ovirt.org, "bigclouds" <bigclouds at 163.com>
> > > Sent: Friday, June 7, 2013 10:56:40 PM
> > > Subject: Re: [Engine-devel] if there is a updated debug environment how
> > > to?
> > > 
> > > > > > So if I understand correctly, the following is sequence is
> > > > > > required:
> > > > > > 
> > > > > > Build and deploy code:
> > > > > > $ make install-dev PREFIX="${HOME}/ovirt-engine"
> > > > > > $
> > > > > > "${HOME}/ovirt-engine/share/ovirt-engine/services/ovirt-engine.py"
> > > > > > start
> > > > >  
> > > > >  You missed this part:
> > > > > 1. cd into the source code directory of either webadmin or user
> > > > > portal.
> > > > > you have to change directory to either
> > > > > frontend/webadmin/modules/webadmin
> > > > > or frontend/webadmin/modules/userportal-gwtp
> > > > > 
> > > > > As the maven gwt plugin is only defined in the webadmin and
> > > > > userportal
> > > > > poms
> > > > > and
> > > > > not in the root pom.
> > > > 
> > > 
> > > It doesn't make much sense to put the gwt plugin in the root pom, as the
> > > root
> > > pom has nothing to do with GWT. The plugin exists in userportal and
> > > webadmin
> > > as those are GWT modules. The debugger is specifically a GWT debugger,
> > > you
> > > can't debug anything else with it.
> > 
> > You perceive this as something of gwt project, while I perceive this part
> > of
> > the environment.
> > 
> > What I expect it to allow as simple development environment as we can.
> > Just like I enable the debug port of jboss automatically I would like to
> > enable gwt debug.
> > 
> > If I add "-P gwtdev" to default build using install-dev, all gwt
> > applications
> > should be built and installed using the extra debugging information, using:
> > 
> > $ make install-dev PREFIX="${HOME}/ovirt-engine"
> > 
> > I can even add GWT_DEBUGGER=1 to optionally enable/disable this feature.
> > 
> > Now, after starting ovirt-engine service, all I expect is a simple command
> > to
> > start the gwt debugger.
> > 
> > $ make gwt-debugger
> > or:
> > ./gwt-debugger
> > 
> > The fact that maven is used to start the debugger is not important.
> > 
> > What I do expect is that the debugger not to require a specific relation
> > with
> > specific application (Webadmin, userportal).
> > 
> > I would have understood if I had to execute something like the following to
> > run the debugger:
> > 
> > $ cd frontend
> > $ mvn gwt:debug -Dgwt.noserver=true
> > 
> > Or better to avoid building anything:
> > 
> > $ cd frontend/debugger
> > $ mvn gwt:debug -Dgwt.noserver=true
> > 
> > But I do not understand why a cd to specific application is required.
> > 
> > Thanks!
> > Alon
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> 


From vszocs at redhat.com  Tue Jun 18 13:16:25 2013
From: vszocs at redhat.com (Vojtech Szocs)
Date: Tue, 18 Jun 2013 09:16:25 -0400 (EDT)
Subject: [Engine-devel] if there is a updated debug environment how to?
In-Reply-To: <39510753.10304096.1371555172036.JavaMail.root@redhat.com>
References: <1f1cccaa.c254.13f13b00539.Coremail.bigclouds@163.com>
	<19879316.JsIC89Exdp@awels>
	<1179830307.7838122.1370634677541.JavaMail.root@redhat.com>
	<1436886.BHuK52khM6@awels>
	<1306276520.7843210.1370635660793.JavaMail.root@redhat.com>
	<2084248787.19430955.1371553261241.JavaMail.root@redhat.com>
	<39510753.10304096.1371555172036.JavaMail.root@redhat.com>
Message-ID: <715468391.19523659.1371561385079.JavaMail.root@redhat.com>


----- Original Message -----
> From: "Alon Bar-Lev" <alonbl at redhat.com>
> To: "Vojtech Szocs" <vszocs at redhat.com>
> Cc: awels at redhat.com, engine-devel at ovirt.org
> Sent: Tuesday, June 18, 2013 1:32:52 PM
> Subject: Re: [Engine-devel] if there is a updated debug environment how to?
> 
> 
> 
> ----- Original Message -----
> > From: "Vojtech Szocs" <vszocs at redhat.com>
> > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > Cc: awels at redhat.com, engine-devel at ovirt.org
> > Sent: Tuesday, June 18, 2013 2:01:01 PM
> > Subject: Re: [Engine-devel] if there is a updated debug environment how to?
> > 
> > Hi Alon,
> > 
> > revisiting this thread, I have some comments regarding GWT debugging via
> > standard development environment, as described in README.developer.
> 
> Thank you for your comments!
> As the file is within git, you can submit a patch... :)
> I will create one for the following comments.

Thanks! I +2'ed your patch [http://gerrit.ovirt.org/#/c/15827/]

>  
> > - README.developer says:
> >   For example, if your machine is low on memory, use:
> >   EXTRA_BUILD_FLAGS_DEV="-Dgwt-plugin.localWorkers=2"
> >   however this should be:
> >   For example, if your machine is low on memory, use:
> >   EXTRA_BUILD_FLAGS_DEV="-Dgwt.compiler.localWorkers=2"
> 
> Fixed.
> 
> > 
> > - README.developer says:
> >   By default, only the gecko1_8 support is built
> >   I'd rather explain what this means:
> >   By default, only the gecko1_8 (Mozilla Firefox) support is built
> 
> Fixed.
>  
> > - what's the point of having EXTRA_BUILD_FLAGS_DEV_GWT vs.
> > EXTRA_BUILD_FLAGS_DEV ?
> 
> I wanted to allow customization of GWT as standalone as it require more flags
> and defaults.
> 
> So I can put the following with a default for gwt while allowing application
> customization.
> 
> For example if I have:
> EXTRA_BUILD_FLAGS_DEV_GWT:=-D gwt.userAgent=gecko1_8
> 
> and execute:
> $ make EXTRA_BUILD_FLAGS_DEV="-DskipTests"
> 
> I do not override the GWT settings.

I see, so developer should only use EXTRA_BUILD_FLAGS_DEV to provide any additional settings (or override existing settings), i.e. both GWT and non-GWT settings can be customized via EXTRA_BUILD_FLAGS_DEV.

If I understand correctly, EXTRA_BUILD_FLAGS_DEV_GWT is used internally for:
- setting default target browser to Firefox (only)
- enabling draft compile (if DEV_BUILD_GWT_DRAFT == 1)

We can consider renaming EXTRA_BUILD_FLAGS_DEV_GWT -> EXTRA_BUILD_FLAGS_DEV_GWT_DEFAULTS. But in any case, I suggest to apply EXTRA_BUILD_FLAGS_DEV_GWT *before* EXTRA_BUILD_FLAGS_DEV (instead of the opposite like today). This way, EXTRA_BUILD_FLAGS_DEV can be used to override any settings set by EXTRA_BUILD_FLAGS_DEV_GWT.

For example:

    $(MVN) \
        $(EXTRA_BUILD_FLAGS_DEV_GWT) \ --> GWT-specific defaults
        $(EXTRA_BUILD_FLAGS_DEV) \ --> generic overrides (both GWT and non-GWT)
        ...

    install \
        EXTRA_BUILD_FLAGS="$(EXTRA_BUILD_FLAGS_DEV_GWT) $(EXTRA_BUILD_FLAGS_DEV)" \ --> this one is OK

Let me know what you think about this.

> 
> BTW: there is a pending patch to rename this to DEV_XXXX[1] to be more
> consistent.
> 
> [1] http://gerrit.ovirt.org/#/c/15735/

+1'ed this patch.

> 
> 
> >   if EXTRA_BUILD_FLAGS_DEV_GWT is meant to control target browser(s) then
> >   it
> >   should be renamed appropriately
> 
> Any flags, including debug port and such. But I am opened to suggestions...
> what do you expect it to be named?
> 
> >   if EXTRA_BUILD_FLAGS_DEV_GWT is meant to group all GWT-specific flags,
> >   README.developer shouldn't advise to do EXTRA_BUILD_FLAGS_DEV="-Dgwt..."
> 
> But then I lose the gwt settings.

Right, please see my suggestion above.

>  
> > - Makefile gwt-debug target looks OK to me
> > 
> > > What I do expect is that the debugger not to require a specific relation
> > > with
> > > specific application (Webadmin, userportal).
> > 
> > gwt-maven-plugin must be invoked in context of a specific Maven module
> > representing GWT application you want to debug. In other words, you need to
> > start GWT Development Mode for specific application module. This is why you
> > need to "cd" to specific directory (webadmin/userportal-gwtp) before
> > invoking "mvn ... gwt:debug" command.
> > 
> > You cannot start GWT Development Mode in a generic (application-agnostic)
> > way
> > and *then* connect to it from browser and Java IDE, this is not how GWT
> > Development Mode is meant to be used. JBoss remote socket debugging and GWT
> > application debugging are two different things.
> 
> Well, I do expect this to be a feature of top level pom.xml...
> 
> something like:
> $ mvn -Pgwt-debug -Ddebug.module=webadmin
> 
> so that the profile will do whatever necessary to activate the debugger.

This would be problematic because when you invoke Maven on root pom, Maven only sees root pom classpath/artifacts, and we need Maven/GWT-Plugin to see application-specific classpath/artifacts.

I'm not saying this is impossible, I'm just saying it will be much harder to do than just "cd" to webadmin/userportal-gwtp directory and invoking Maven there.. We could introduce new flags like DEBUG_GWT_WEBADMIN [0/1] which would take care of providing correct settings to gwt-maven-plugin, not sure if it's really worth it, because we already have DEBUG_MODULE and Makefile internally cd's to it.

> 
> > > The fact that maven is used to start the debugger is not important.
> > 
> > gwt-maven-plugin is just a wrapper to invoke GWT Development Mode (Java
> > class). Regardless of how you start GWT Development Mode, you need to
> > specify which application (more precisely, GWT modules) you want to debug
> > right when starting GWT Development Mode. See [1] - "module(s)" are always
> > specific for given application.
> 
> So basically what you saying is that you cannot debug two modules at one
> time...
> It is strange... but as long as you fine with it, we are OK.

Yes, basically you need to specify all "modules" that make up for one application at time when you start GWT Development Mode. So GWT Development Mode, once started, is tied to specific application.

> 
> > 
> > [1]
> > https://developers.google.com/web-toolkit/doc/latest/DevGuideCompilingAndDebugging#DevGuideCompilerOptions
> > 
> > > If I add "-P gwtdev" to default build using install-dev, all gwt
> > > applications
> > > should be built and installed using the extra debugging information,
> > > using:
> > 
> > Yes, as described in [2], besides using "gwtdev" profile for debugging, it
> > can also be used for GWT compilation (i.e. "make install-dev") - in this
> > case, resulting JavaScript will be un-obfuscated and not-too-optimized in
> > order to easily profile the JavaScript application in the browser. In other
> > words, using "gwtdev" for GWT compilation has nothing to do with debugging,
> > maybe we should create separate profile for this purpose.
> 
> That's good.

OK, I'll make a patch to introduce "gwtdraft" profile with following effects once activated (via -Pgwtdraft):
- set draftCompile to true -> prevent JavaScript code optimizations
- set style to DETAILED -> produce pretty JavaScript without obfuscation

After this, I suggest to modify Makefile so that DEV_BUILD_GWT_DRAFT=1 activates "gwtdraft" profile, instead of just doing -Dgwt.draftCompile=true

>  
> > [2]
> > http://www.ovirt.org/DebugFrontend#Compiling_Frontend_applications_in_detailed_mode
> > 
> > PS: I'll update http://www.ovirt.org/DebugFrontend with regard to standard
> > development environment, as described in README.developer
> > 
> > Vojtech
> > 
> > 
> > ----- Original Message -----
> > > From: "Alon Bar-Lev" <alonbl at redhat.com>
> > > To: awels at redhat.com
> > > Cc: engine-devel at ovirt.org
> > > Sent: Friday, June 7, 2013 10:07:40 PM
> > > Subject: Re: [Engine-devel] if there is a updated debug environment how
> > > to?
> > > 
> > > 
> > > 
> > > ----- Original Message -----
> > > > From: "Alexander Wels" <awels at redhat.com>
> > > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > > Cc: engine-devel at ovirt.org, "bigclouds" <bigclouds at 163.com>
> > > > Sent: Friday, June 7, 2013 10:56:40 PM
> > > > Subject: Re: [Engine-devel] if there is a updated debug environment how
> > > > to?
> > > > 
> > > > > > > So if I understand correctly, the following is sequence is
> > > > > > > required:
> > > > > > > 
> > > > > > > Build and deploy code:
> > > > > > > $ make install-dev PREFIX="${HOME}/ovirt-engine"
> > > > > > > $
> > > > > > > "${HOME}/ovirt-engine/share/ovirt-engine/services/ovirt-engine.py"
> > > > > > > start
> > > > > >  
> > > > > >  You missed this part:
> > > > > > 1. cd into the source code directory of either webadmin or user
> > > > > > portal.
> > > > > > you have to change directory to either
> > > > > > frontend/webadmin/modules/webadmin
> > > > > > or frontend/webadmin/modules/userportal-gwtp
> > > > > > 
> > > > > > As the maven gwt plugin is only defined in the webadmin and
> > > > > > userportal
> > > > > > poms
> > > > > > and
> > > > > > not in the root pom.
> > > > > 
> > > > 
> > > > It doesn't make much sense to put the gwt plugin in the root pom, as
> > > > the
> > > > root
> > > > pom has nothing to do with GWT. The plugin exists in userportal and
> > > > webadmin
> > > > as those are GWT modules. The debugger is specifically a GWT debugger,
> > > > you
> > > > can't debug anything else with it.
> > > 
> > > You perceive this as something of gwt project, while I perceive this part
> > > of
> > > the environment.
> > > 
> > > What I expect it to allow as simple development environment as we can.
> > > Just like I enable the debug port of jboss automatically I would like to
> > > enable gwt debug.
> > > 
> > > If I add "-P gwtdev" to default build using install-dev, all gwt
> > > applications
> > > should be built and installed using the extra debugging information,
> > > using:
> > > 
> > > $ make install-dev PREFIX="${HOME}/ovirt-engine"
> > > 
> > > I can even add GWT_DEBUGGER=1 to optionally enable/disable this feature.
> > > 
> > > Now, after starting ovirt-engine service, all I expect is a simple
> > > command
> > > to
> > > start the gwt debugger.
> > > 
> > > $ make gwt-debugger
> > > or:
> > > ./gwt-debugger
> > > 
> > > The fact that maven is used to start the debugger is not important.
> > > 
> > > What I do expect is that the debugger not to require a specific relation
> > > with
> > > specific application (Webadmin, userportal).
> > > 
> > > I would have understood if I had to execute something like the following
> > > to
> > > run the debugger:
> > > 
> > > $ cd frontend
> > > $ mvn gwt:debug -Dgwt.noserver=true
> > > 
> > > Or better to avoid building anything:
> > > 
> > > $ cd frontend/debugger
> > > $ mvn gwt:debug -Dgwt.noserver=true
> > > 
> > > But I do not understand why a cd to specific application is required.
> > > 
> > > Thanks!
> > > Alon
> > > _______________________________________________
> > > Engine-devel mailing list
> > > Engine-devel at ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > 
> > 
> 


From alonbl at redhat.com  Tue Jun 18 14:56:49 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Tue, 18 Jun 2013 10:56:49 -0400 (EDT)
Subject: [Engine-devel] if there is a updated debug environment how to?
In-Reply-To: <715468391.19523659.1371561385079.JavaMail.root@redhat.com>
References: <1f1cccaa.c254.13f13b00539.Coremail.bigclouds@163.com>
	<19879316.JsIC89Exdp@awels>
	<1179830307.7838122.1370634677541.JavaMail.root@redhat.com>
	<1436886.BHuK52khM6@awels>
	<1306276520.7843210.1370635660793.JavaMail.root@redhat.com>
	<2084248787.19430955.1371553261241.JavaMail.root@redhat.com>
	<39510753.10304096.1371555172036.JavaMail.root@redhat.com>
	<715468391.19523659.1371561385079.JavaMail.root@redhat.com>
Message-ID: <402874074.10394966.1371567409593.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Vojtech Szocs" <vszocs at redhat.com>
> To: "Alon Bar-Lev" <alonbl at redhat.com>
> Cc: awels at redhat.com, engine-devel at ovirt.org
> Sent: Tuesday, June 18, 2013 4:16:25 PM
> Subject: Re: [Engine-devel] if there is a updated debug environment how to?
> 
> 
> ----- Original Message -----
> > From: "Alon Bar-Lev" <alonbl at redhat.com>
> > To: "Vojtech Szocs" <vszocs at redhat.com>
> > Cc: awels at redhat.com, engine-devel at ovirt.org
> > Sent: Tuesday, June 18, 2013 1:32:52 PM
> > Subject: Re: [Engine-devel] if there is a updated debug environment how to?
> > 
> > 
> > 
> > ----- Original Message -----
> > > From: "Vojtech Szocs" <vszocs at redhat.com>
> > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > Cc: awels at redhat.com, engine-devel at ovirt.org
> > > Sent: Tuesday, June 18, 2013 2:01:01 PM
> > > Subject: Re: [Engine-devel] if there is a updated debug environment how
> > > to?
> > > 
> > > Hi Alon,
> > > 
> > > revisiting this thread, I have some comments regarding GWT debugging via
> > > standard development environment, as described in README.developer.
> > 
> > Thank you for your comments!
> > As the file is within git, you can submit a patch... :)
> > I will create one for the following comments.
> 
> Thanks! I +2'ed your patch [http://gerrit.ovirt.org/#/c/15827/]
> 
> >  
> > > - README.developer says:
> > >   For example, if your machine is low on memory, use:
> > >   EXTRA_BUILD_FLAGS_DEV="-Dgwt-plugin.localWorkers=2"
> > >   however this should be:
> > >   For example, if your machine is low on memory, use:
> > >   EXTRA_BUILD_FLAGS_DEV="-Dgwt.compiler.localWorkers=2"
> > 
> > Fixed.
> > 
> > > 
> > > - README.developer says:
> > >   By default, only the gecko1_8 support is built
> > >   I'd rather explain what this means:
> > >   By default, only the gecko1_8 (Mozilla Firefox) support is built
> > 
> > Fixed.
> >  
> > > - what's the point of having EXTRA_BUILD_FLAGS_DEV_GWT vs.
> > > EXTRA_BUILD_FLAGS_DEV ?
> > 
> > I wanted to allow customization of GWT as standalone as it require more
> > flags
> > and defaults.
> > 
> > So I can put the following with a default for gwt while allowing
> > application
> > customization.
> > 
> > For example if I have:
> > EXTRA_BUILD_FLAGS_DEV_GWT:=-D gwt.userAgent=gecko1_8
> > 
> > and execute:
> > $ make EXTRA_BUILD_FLAGS_DEV="-DskipTests"
> > 
> > I do not override the GWT settings.
> 
> I see, so developer should only use EXTRA_BUILD_FLAGS_DEV to provide any
> additional settings (or override existing settings), i.e. both GWT and
> non-GWT settings can be customized via EXTRA_BUILD_FLAGS_DEV.
> 
> If I understand correctly, EXTRA_BUILD_FLAGS_DEV_GWT is used internally for:
> - setting default target browser to Firefox (only)

Right.

> - enabling draft compile (if DEV_BUILD_GWT_DRAFT == 1)

I am going to change that[1]

[1] http://gerrit.ovirt.org/#/c/15736/

> We can consider renaming EXTRA_BUILD_FLAGS_DEV_GWT ->
> EXTRA_BUILD_FLAGS_DEV_GWT_DEFAULTS.

OK, will do.

>  But in any case, I suggest to apply
> EXTRA_BUILD_FLAGS_DEV_GWT *before* EXTRA_BUILD_FLAGS_DEV (instead of the
> opposite like today). This way, EXTRA_BUILD_FLAGS_DEV can be used to
> override any settings set by EXTRA_BUILD_FLAGS_DEV_GWT.
> 
> For example:
> 
>     $(MVN) \
>         $(EXTRA_BUILD_FLAGS_DEV_GWT) \ --> GWT-specific defaults
>         $(EXTRA_BUILD_FLAGS_DEV) \ --> generic overrides (both GWT and
>         non-GWT)
>         ...
> 
>     install \
>         EXTRA_BUILD_FLAGS="$(EXTRA_BUILD_FLAGS_DEV_GWT)
>         $(EXTRA_BUILD_FLAGS_DEV)" \ --> this one is OK
> 
> Let me know what you think about this.

Good for me.

> 
> > 
> > BTW: there is a pending patch to rename this to DEV_XXXX[1] to be more
> > consistent.
> > 
> > [1] http://gerrit.ovirt.org/#/c/15735/
> 
> +1'ed this patch.
> 
> > 
> > 
> > >   if EXTRA_BUILD_FLAGS_DEV_GWT is meant to control target browser(s) then
> > >   it
> > >   should be renamed appropriately
> > 
> > Any flags, including debug port and such. But I am opened to suggestions...
> > what do you expect it to be named?
> > 
> > >   if EXTRA_BUILD_FLAGS_DEV_GWT is meant to group all GWT-specific flags,
> > >   README.developer shouldn't advise to do
> > >   EXTRA_BUILD_FLAGS_DEV="-Dgwt..."
> > 
> > But then I lose the gwt settings.
> 
> Right, please see my suggestion above.
> 
> >  
> > > - Makefile gwt-debug target looks OK to me
> > > 
> > > > What I do expect is that the debugger not to require a specific
> > > > relation
> > > > with
> > > > specific application (Webadmin, userportal).
> > > 
> > > gwt-maven-plugin must be invoked in context of a specific Maven module
> > > representing GWT application you want to debug. In other words, you need
> > > to
> > > start GWT Development Mode for specific application module. This is why
> > > you
> > > need to "cd" to specific directory (webadmin/userportal-gwtp) before
> > > invoking "mvn ... gwt:debug" command.
> > > 
> > > You cannot start GWT Development Mode in a generic (application-agnostic)
> > > way
> > > and *then* connect to it from browser and Java IDE, this is not how GWT
> > > Development Mode is meant to be used. JBoss remote socket debugging and
> > > GWT
> > > application debugging are two different things.
> > 
> > Well, I do expect this to be a feature of top level pom.xml...
> > 
> > something like:
> > $ mvn -Pgwt-debug -Ddebug.module=webadmin
> > 
> > so that the profile will do whatever necessary to activate the debugger.
> 
> This would be problematic because when you invoke Maven on root pom, Maven
> only sees root pom classpath/artifacts, and we need Maven/GWT-Plugin to see
> application-specific classpath/artifacts.
> 
> I'm not saying this is impossible, I'm just saying it will be much harder to
> do than just "cd" to webadmin/userportal-gwtp directory and invoking Maven
> there.. We could introduce new flags like DEBUG_GWT_WEBADMIN [0/1] which
> would take care of providing correct settings to gwt-maven-plugin, not sure
> if it's really worth it, because we already have DEBUG_MODULE and Makefile
> internally cd's to it.

OK, this issue is not that important now... :)

> 
> > 
> > > > The fact that maven is used to start the debugger is not important.
> > > 
> > > gwt-maven-plugin is just a wrapper to invoke GWT Development Mode (Java
> > > class). Regardless of how you start GWT Development Mode, you need to
> > > specify which application (more precisely, GWT modules) you want to debug
> > > right when starting GWT Development Mode. See [1] - "module(s)" are
> > > always
> > > specific for given application.
> > 
> > So basically what you saying is that you cannot debug two modules at one
> > time...
> > It is strange... but as long as you fine with it, we are OK.
> 
> Yes, basically you need to specify all "modules" that make up for one
> application at time when you start GWT Development Mode. So GWT Development
> Mode, once started, is tied to specific application.
> 
> > 
> > > 
> > > [1]
> > > https://developers.google.com/web-toolkit/doc/latest/DevGuideCompilingAndDebugging#DevGuideCompilerOptions
> > > 
> > > > If I add "-P gwtdev" to default build using install-dev, all gwt
> > > > applications
> > > > should be built and installed using the extra debugging information,
> > > > using:
> > > 
> > > Yes, as described in [2], besides using "gwtdev" profile for debugging,
> > > it
> > > can also be used for GWT compilation (i.e. "make install-dev") - in this
> > > case, resulting JavaScript will be un-obfuscated and not-too-optimized in
> > > order to easily profile the JavaScript application in the browser. In
> > > other
> > > words, using "gwtdev" for GWT compilation has nothing to do with
> > > debugging,
> > > maybe we should create separate profile for this purpose.
> > 
> > That's good.
> 
> OK, I'll make a patch to introduce "gwtdraft" profile with following effects
> once activated (via -Pgwtdraft):
> - set draftCompile to true -> prevent JavaScript code optimizations
> - set style to DETAILED -> produce pretty JavaScript without obfuscation
> 
> After this, I suggest to modify Makefile so that DEV_BUILD_GWT_DRAFT=1
> activates "gwtdraft" profile, instead of just doing -Dgwt.draftCompile=true
> 
> >  
> > > [2]
> > > http://www.ovirt.org/DebugFrontend#Compiling_Frontend_applications_in_detailed_mode
> > > 
> > > PS: I'll update http://www.ovirt.org/DebugFrontend with regard to
> > > standard
> > > development environment, as described in README.developer
> > > 
> > > Vojtech
> > > 
> > > 
> > > ----- Original Message -----
> > > > From: "Alon Bar-Lev" <alonbl at redhat.com>
> > > > To: awels at redhat.com
> > > > Cc: engine-devel at ovirt.org
> > > > Sent: Friday, June 7, 2013 10:07:40 PM
> > > > Subject: Re: [Engine-devel] if there is a updated debug environment how
> > > > to?
> > > > 
> > > > 
> > > > 
> > > > ----- Original Message -----
> > > > > From: "Alexander Wels" <awels at redhat.com>
> > > > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > > > Cc: engine-devel at ovirt.org, "bigclouds" <bigclouds at 163.com>
> > > > > Sent: Friday, June 7, 2013 10:56:40 PM
> > > > > Subject: Re: [Engine-devel] if there is a updated debug environment
> > > > > how
> > > > > to?
> > > > > 
> > > > > > > > So if I understand correctly, the following is sequence is
> > > > > > > > required:
> > > > > > > > 
> > > > > > > > Build and deploy code:
> > > > > > > > $ make install-dev PREFIX="${HOME}/ovirt-engine"
> > > > > > > > $
> > > > > > > > "${HOME}/ovirt-engine/share/ovirt-engine/services/ovirt-engine.py"
> > > > > > > > start
> > > > > > >  
> > > > > > >  You missed this part:
> > > > > > > 1. cd into the source code directory of either webadmin or user
> > > > > > > portal.
> > > > > > > you have to change directory to either
> > > > > > > frontend/webadmin/modules/webadmin
> > > > > > > or frontend/webadmin/modules/userportal-gwtp
> > > > > > > 
> > > > > > > As the maven gwt plugin is only defined in the webadmin and
> > > > > > > userportal
> > > > > > > poms
> > > > > > > and
> > > > > > > not in the root pom.
> > > > > > 
> > > > > 
> > > > > It doesn't make much sense to put the gwt plugin in the root pom, as
> > > > > the
> > > > > root
> > > > > pom has nothing to do with GWT. The plugin exists in userportal and
> > > > > webadmin
> > > > > as those are GWT modules. The debugger is specifically a GWT
> > > > > debugger,
> > > > > you
> > > > > can't debug anything else with it.
> > > > 
> > > > You perceive this as something of gwt project, while I perceive this
> > > > part
> > > > of
> > > > the environment.
> > > > 
> > > > What I expect it to allow as simple development environment as we can.
> > > > Just like I enable the debug port of jboss automatically I would like
> > > > to
> > > > enable gwt debug.
> > > > 
> > > > If I add "-P gwtdev" to default build using install-dev, all gwt
> > > > applications
> > > > should be built and installed using the extra debugging information,
> > > > using:
> > > > 
> > > > $ make install-dev PREFIX="${HOME}/ovirt-engine"
> > > > 
> > > > I can even add GWT_DEBUGGER=1 to optionally enable/disable this
> > > > feature.
> > > > 
> > > > Now, after starting ovirt-engine service, all I expect is a simple
> > > > command
> > > > to
> > > > start the gwt debugger.
> > > > 
> > > > $ make gwt-debugger
> > > > or:
> > > > ./gwt-debugger
> > > > 
> > > > The fact that maven is used to start the debugger is not important.
> > > > 
> > > > What I do expect is that the debugger not to require a specific
> > > > relation
> > > > with
> > > > specific application (Webadmin, userportal).
> > > > 
> > > > I would have understood if I had to execute something like the
> > > > following
> > > > to
> > > > run the debugger:
> > > > 
> > > > $ cd frontend
> > > > $ mvn gwt:debug -Dgwt.noserver=true
> > > > 
> > > > Or better to avoid building anything:
> > > > 
> > > > $ cd frontend/debugger
> > > > $ mvn gwt:debug -Dgwt.noserver=true
> > > > 
> > > > But I do not understand why a cd to specific application is required.
> > > > 
> > > > Thanks!
> > > > Alon
> > > > _______________________________________________
> > > > Engine-devel mailing list
> > > > Engine-devel at ovirt.org
> > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > 
> > > 
> > 
> 


From vszocs at redhat.com  Tue Jun 18 15:46:33 2013
From: vszocs at redhat.com (Vojtech Szocs)
Date: Tue, 18 Jun 2013 11:46:33 -0400 (EDT)
Subject: [Engine-devel] if there is a updated debug environment how to?
In-Reply-To: <402874074.10394966.1371567409593.JavaMail.root@redhat.com>
References: <1f1cccaa.c254.13f13b00539.Coremail.bigclouds@163.com>
	<1179830307.7838122.1370634677541.JavaMail.root@redhat.com>
	<1436886.BHuK52khM6@awels>
	<1306276520.7843210.1370635660793.JavaMail.root@redhat.com>
	<2084248787.19430955.1371553261241.JavaMail.root@redhat.com>
	<39510753.10304096.1371555172036.JavaMail.root@redhat.com>
	<715468391.19523659.1371561385079.JavaMail.root@redhat.com>
	<402874074.10394966.1371567409593.JavaMail.root@redhat.com>
Message-ID: <479074858.19616268.1371570393696.JavaMail.root@redhat.com>


----- Original Message -----
> From: "Alon Bar-Lev" <alonbl at redhat.com>
> To: "Vojtech Szocs" <vszocs at redhat.com>
> Cc: awels at redhat.com, engine-devel at ovirt.org
> Sent: Tuesday, June 18, 2013 4:56:49 PM
> Subject: Re: [Engine-devel] if there is a updated debug environment how to?
> 
> 
> 
> ----- Original Message -----
> > From: "Vojtech Szocs" <vszocs at redhat.com>
> > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > Cc: awels at redhat.com, engine-devel at ovirt.org
> > Sent: Tuesday, June 18, 2013 4:16:25 PM
> > Subject: Re: [Engine-devel] if there is a updated debug environment how to?
> > 
> > 
> > ----- Original Message -----
> > > From: "Alon Bar-Lev" <alonbl at redhat.com>
> > > To: "Vojtech Szocs" <vszocs at redhat.com>
> > > Cc: awels at redhat.com, engine-devel at ovirt.org
> > > Sent: Tuesday, June 18, 2013 1:32:52 PM
> > > Subject: Re: [Engine-devel] if there is a updated debug environment how
> > > to?
> > > 
> > > 
> > > 
> > > ----- Original Message -----
> > > > From: "Vojtech Szocs" <vszocs at redhat.com>
> > > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > > Cc: awels at redhat.com, engine-devel at ovirt.org
> > > > Sent: Tuesday, June 18, 2013 2:01:01 PM
> > > > Subject: Re: [Engine-devel] if there is a updated debug environment how
> > > > to?
> > > > 
> > > > Hi Alon,
> > > > 
> > > > revisiting this thread, I have some comments regarding GWT debugging
> > > > via
> > > > standard development environment, as described in README.developer.
> > > 
> > > Thank you for your comments!
> > > As the file is within git, you can submit a patch... :)
> > > I will create one for the following comments.
> > 
> > Thanks! I +2'ed your patch [http://gerrit.ovirt.org/#/c/15827/]
> > 
> > >  
> > > > - README.developer says:
> > > >   For example, if your machine is low on memory, use:
> > > >   EXTRA_BUILD_FLAGS_DEV="-Dgwt-plugin.localWorkers=2"
> > > >   however this should be:
> > > >   For example, if your machine is low on memory, use:
> > > >   EXTRA_BUILD_FLAGS_DEV="-Dgwt.compiler.localWorkers=2"
> > > 
> > > Fixed.
> > > 
> > > > 
> > > > - README.developer says:
> > > >   By default, only the gecko1_8 support is built
> > > >   I'd rather explain what this means:
> > > >   By default, only the gecko1_8 (Mozilla Firefox) support is built
> > > 
> > > Fixed.
> > >  
> > > > - what's the point of having EXTRA_BUILD_FLAGS_DEV_GWT vs.
> > > > EXTRA_BUILD_FLAGS_DEV ?
> > > 
> > > I wanted to allow customization of GWT as standalone as it require more
> > > flags
> > > and defaults.
> > > 
> > > So I can put the following with a default for gwt while allowing
> > > application
> > > customization.
> > > 
> > > For example if I have:
> > > EXTRA_BUILD_FLAGS_DEV_GWT:=-D gwt.userAgent=gecko1_8
> > > 
> > > and execute:
> > > $ make EXTRA_BUILD_FLAGS_DEV="-DskipTests"
> > > 
> > > I do not override the GWT settings.
> > 
> > I see, so developer should only use EXTRA_BUILD_FLAGS_DEV to provide any
> > additional settings (or override existing settings), i.e. both GWT and
> > non-GWT settings can be customized via EXTRA_BUILD_FLAGS_DEV.
> > 
> > If I understand correctly, EXTRA_BUILD_FLAGS_DEV_GWT is used internally
> > for:
> > - setting default target browser to Firefox (only)
> 
> Right.
> 
> > - enabling draft compile (if DEV_BUILD_GWT_DRAFT == 1)
> 
> I am going to change that[1]
> 
> [1] http://gerrit.ovirt.org/#/c/15736/
> 
> > We can consider renaming EXTRA_BUILD_FLAGS_DEV_GWT ->
> > EXTRA_BUILD_FLAGS_DEV_GWT_DEFAULTS.
> 
> OK, will do.
> 
> >  But in any case, I suggest to apply
> > EXTRA_BUILD_FLAGS_DEV_GWT *before* EXTRA_BUILD_FLAGS_DEV (instead of the
> > opposite like today). This way, EXTRA_BUILD_FLAGS_DEV can be used to
> > override any settings set by EXTRA_BUILD_FLAGS_DEV_GWT.
> > 
> > For example:
> > 
> >     $(MVN) \
> >         $(EXTRA_BUILD_FLAGS_DEV_GWT) \ --> GWT-specific defaults
> >         $(EXTRA_BUILD_FLAGS_DEV) \ --> generic overrides (both GWT and
> >         non-GWT)
> >         ...
> > 
> >     install \
> >         EXTRA_BUILD_FLAGS="$(EXTRA_BUILD_FLAGS_DEV_GWT)
> >         $(EXTRA_BUILD_FLAGS_DEV)" \ --> this one is OK
> > 
> > Let me know what you think about this.
> 
> Good for me.

After http://gerrit.ovirt.org/#/c/15736/ gets merged, I can make a patch that modifies this:

DEV_BUILD_FLAGS:=$(DEV_BUILD_FLAGS) $(DEV_EXTRA_BUILD_FLAGS)
DEV_BUILD_FLAGS:=$(DEV_BUILD_FLAGS) $(DEV_EXTRA_BUILD_FLAGS_GWT)

to this:

DEV_BUILD_FLAGS:=$(DEV_BUILD_FLAGS) $(DEV_EXTRA_BUILD_FLAGS_GWT)
DEV_BUILD_FLAGS:=$(DEV_BUILD_FLAGS) $(DEV_EXTRA_BUILD_FLAGS)

otherwise, it looks good to me.

> 
> > 
> > > 
> > > BTW: there is a pending patch to rename this to DEV_XXXX[1] to be more
> > > consistent.
> > > 
> > > [1] http://gerrit.ovirt.org/#/c/15735/
> > 
> > +1'ed this patch.
> > 
> > > 
> > > 
> > > >   if EXTRA_BUILD_FLAGS_DEV_GWT is meant to control target browser(s)
> > > >   then
> > > >   it
> > > >   should be renamed appropriately
> > > 
> > > Any flags, including debug port and such. But I am opened to
> > > suggestions...
> > > what do you expect it to be named?
> > > 
> > > >   if EXTRA_BUILD_FLAGS_DEV_GWT is meant to group all GWT-specific
> > > >   flags,
> > > >   README.developer shouldn't advise to do
> > > >   EXTRA_BUILD_FLAGS_DEV="-Dgwt..."
> > > 
> > > But then I lose the gwt settings.
> > 
> > Right, please see my suggestion above.
> > 
> > >  
> > > > - Makefile gwt-debug target looks OK to me
> > > > 
> > > > > What I do expect is that the debugger not to require a specific
> > > > > relation
> > > > > with
> > > > > specific application (Webadmin, userportal).
> > > > 
> > > > gwt-maven-plugin must be invoked in context of a specific Maven module
> > > > representing GWT application you want to debug. In other words, you
> > > > need
> > > > to
> > > > start GWT Development Mode for specific application module. This is why
> > > > you
> > > > need to "cd" to specific directory (webadmin/userportal-gwtp) before
> > > > invoking "mvn ... gwt:debug" command.
> > > > 
> > > > You cannot start GWT Development Mode in a generic
> > > > (application-agnostic)
> > > > way
> > > > and *then* connect to it from browser and Java IDE, this is not how GWT
> > > > Development Mode is meant to be used. JBoss remote socket debugging and
> > > > GWT
> > > > application debugging are two different things.
> > > 
> > > Well, I do expect this to be a feature of top level pom.xml...
> > > 
> > > something like:
> > > $ mvn -Pgwt-debug -Ddebug.module=webadmin
> > > 
> > > so that the profile will do whatever necessary to activate the debugger.
> > 
> > This would be problematic because when you invoke Maven on root pom, Maven
> > only sees root pom classpath/artifacts, and we need Maven/GWT-Plugin to see
> > application-specific classpath/artifacts.
> > 
> > I'm not saying this is impossible, I'm just saying it will be much harder
> > to
> > do than just "cd" to webadmin/userportal-gwtp directory and invoking Maven
> > there.. We could introduce new flags like DEBUG_GWT_WEBADMIN [0/1] which
> > would take care of providing correct settings to gwt-maven-plugin, not sure
> > if it's really worth it, because we already have DEBUG_MODULE and Makefile
> > internally cd's to it.
> 
> OK, this issue is not that important now... :)
> 
> > 
> > > 
> > > > > The fact that maven is used to start the debugger is not important.
> > > > 
> > > > gwt-maven-plugin is just a wrapper to invoke GWT Development Mode (Java
> > > > class). Regardless of how you start GWT Development Mode, you need to
> > > > specify which application (more precisely, GWT modules) you want to
> > > > debug
> > > > right when starting GWT Development Mode. See [1] - "module(s)" are
> > > > always
> > > > specific for given application.
> > > 
> > > So basically what you saying is that you cannot debug two modules at one
> > > time...
> > > It is strange... but as long as you fine with it, we are OK.
> > 
> > Yes, basically you need to specify all "modules" that make up for one
> > application at time when you start GWT Development Mode. So GWT Development
> > Mode, once started, is tied to specific application.
> > 
> > > 
> > > > 
> > > > [1]
> > > > https://developers.google.com/web-toolkit/doc/latest/DevGuideCompilingAndDebugging#DevGuideCompilerOptions
> > > > 
> > > > > If I add "-P gwtdev" to default build using install-dev, all gwt
> > > > > applications
> > > > > should be built and installed using the extra debugging information,
> > > > > using:
> > > > 
> > > > Yes, as described in [2], besides using "gwtdev" profile for debugging,
> > > > it
> > > > can also be used for GWT compilation (i.e. "make install-dev") - in
> > > > this
> > > > case, resulting JavaScript will be un-obfuscated and not-too-optimized
> > > > in
> > > > order to easily profile the JavaScript application in the browser. In
> > > > other
> > > > words, using "gwtdev" for GWT compilation has nothing to do with
> > > > debugging,
> > > > maybe we should create separate profile for this purpose.
> > > 
> > > That's good.
> > 
> > OK, I'll make a patch to introduce "gwtdraft" profile with following
> > effects
> > once activated (via -Pgwtdraft):
> > - set draftCompile to true -> prevent JavaScript code optimizations
> > - set style to DETAILED -> produce pretty JavaScript without obfuscation
> > 
> > After this, I suggest to modify Makefile so that DEV_BUILD_GWT_DRAFT=1
> > activates "gwtdraft" profile, instead of just doing -Dgwt.draftCompile=true
> > 
> > >  
> > > > [2]
> > > > http://www.ovirt.org/DebugFrontend#Compiling_Frontend_applications_in_detailed_mode
> > > > 
> > > > PS: I'll update http://www.ovirt.org/DebugFrontend with regard to
> > > > standard
> > > > development environment, as described in README.developer
> > > > 
> > > > Vojtech
> > > > 
> > > > 
> > > > ----- Original Message -----
> > > > > From: "Alon Bar-Lev" <alonbl at redhat.com>
> > > > > To: awels at redhat.com
> > > > > Cc: engine-devel at ovirt.org
> > > > > Sent: Friday, June 7, 2013 10:07:40 PM
> > > > > Subject: Re: [Engine-devel] if there is a updated debug environment
> > > > > how
> > > > > to?
> > > > > 
> > > > > 
> > > > > 
> > > > > ----- Original Message -----
> > > > > > From: "Alexander Wels" <awels at redhat.com>
> > > > > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > > > > Cc: engine-devel at ovirt.org, "bigclouds" <bigclouds at 163.com>
> > > > > > Sent: Friday, June 7, 2013 10:56:40 PM
> > > > > > Subject: Re: [Engine-devel] if there is a updated debug environment
> > > > > > how
> > > > > > to?
> > > > > > 
> > > > > > > > > So if I understand correctly, the following is sequence is
> > > > > > > > > required:
> > > > > > > > > 
> > > > > > > > > Build and deploy code:
> > > > > > > > > $ make install-dev PREFIX="${HOME}/ovirt-engine"
> > > > > > > > > $
> > > > > > > > > "${HOME}/ovirt-engine/share/ovirt-engine/services/ovirt-engine.py"
> > > > > > > > > start
> > > > > > > >  
> > > > > > > >  You missed this part:
> > > > > > > > 1. cd into the source code directory of either webadmin or user
> > > > > > > > portal.
> > > > > > > > you have to change directory to either
> > > > > > > > frontend/webadmin/modules/webadmin
> > > > > > > > or frontend/webadmin/modules/userportal-gwtp
> > > > > > > > 
> > > > > > > > As the maven gwt plugin is only defined in the webadmin and
> > > > > > > > userportal
> > > > > > > > poms
> > > > > > > > and
> > > > > > > > not in the root pom.
> > > > > > > 
> > > > > > 
> > > > > > It doesn't make much sense to put the gwt plugin in the root pom,
> > > > > > as
> > > > > > the
> > > > > > root
> > > > > > pom has nothing to do with GWT. The plugin exists in userportal and
> > > > > > webadmin
> > > > > > as those are GWT modules. The debugger is specifically a GWT
> > > > > > debugger,
> > > > > > you
> > > > > > can't debug anything else with it.
> > > > > 
> > > > > You perceive this as something of gwt project, while I perceive this
> > > > > part
> > > > > of
> > > > > the environment.
> > > > > 
> > > > > What I expect it to allow as simple development environment as we
> > > > > can.
> > > > > Just like I enable the debug port of jboss automatically I would like
> > > > > to
> > > > > enable gwt debug.
> > > > > 
> > > > > If I add "-P gwtdev" to default build using install-dev, all gwt
> > > > > applications
> > > > > should be built and installed using the extra debugging information,
> > > > > using:
> > > > > 
> > > > > $ make install-dev PREFIX="${HOME}/ovirt-engine"
> > > > > 
> > > > > I can even add GWT_DEBUGGER=1 to optionally enable/disable this
> > > > > feature.
> > > > > 
> > > > > Now, after starting ovirt-engine service, all I expect is a simple
> > > > > command
> > > > > to
> > > > > start the gwt debugger.
> > > > > 
> > > > > $ make gwt-debugger
> > > > > or:
> > > > > ./gwt-debugger
> > > > > 
> > > > > The fact that maven is used to start the debugger is not important.
> > > > > 
> > > > > What I do expect is that the debugger not to require a specific
> > > > > relation
> > > > > with
> > > > > specific application (Webadmin, userportal).
> > > > > 
> > > > > I would have understood if I had to execute something like the
> > > > > following
> > > > > to
> > > > > run the debugger:
> > > > > 
> > > > > $ cd frontend
> > > > > $ mvn gwt:debug -Dgwt.noserver=true
> > > > > 
> > > > > Or better to avoid building anything:
> > > > > 
> > > > > $ cd frontend/debugger
> > > > > $ mvn gwt:debug -Dgwt.noserver=true
> > > > > 
> > > > > But I do not understand why a cd to specific application is required.
> > > > > 
> > > > > Thanks!
> > > > > Alon
> > > > > _______________________________________________
> > > > > Engine-devel mailing list
> > > > > Engine-devel at ovirt.org
> > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > > 
> > > > 
> > > 
> > 
> 


From vszocs at redhat.com  Wed Jun 19 09:54:16 2013
From: vszocs at redhat.com (Vojtech Szocs)
Date: Wed, 19 Jun 2013 05:54:16 -0400 (EDT)
Subject: [Engine-devel] IE9 Issue with UI Plugin
In-Reply-To: <CDE4CAA2.5617%rickyh@netapp.com>
References: <CDE4CAA2.5617%rickyh@netapp.com>
Message-ID: <1796208617.20183450.1371635656569.JavaMail.root@redhat.com>

Hi Ricky,

code running in the iframe (custom dialog content) can close the dialog in the following way:

1, send message to your plugin to indicate the dialog needs to be closed:

    parent.postMessage('CloseMyDialog', '*');

2, your plugin intercepts the message via MessageReceived function and closes the dialog:

    MessageReceived: function(data, sourceWindow) {
        switch (data) {
            case 'CloseMyDialog':
                window.alert('About to close dialog');
                api.closeDialog('my-dialog');
                break;
        }
    }

If the above doesn't work for you, it could mean that:
- MessageReceived function isn't invoked - make sure to have [*] before api.register() call
- api.closeDialog() function isn't working - in this case I need to fix it for IE9

[*] accept message events from iframe (custom dialog content) origin

    api.options({
        allowedMessageOrigins: 'http://nicedomain:8080'
        /* OR */
        allowedMessageOrigins: ['http://nicedomain1:123', 'https://nicedomain2:345']
    });

I'm going to investigate this issue on IE9 myself to see if the above code is really working there.

Vojtech


----- Original Message -----
> From: "Richard Hopper" <Richard.Hopper at netapp.com>
> To: "Vojtech Szocs" <vszocs at redhat.com>
> Cc: engine-devel at ovirt.org, "Christopher Morrissey" <Christopher.Morrissey at netapp.com>
> Sent: Monday, June 17, 2013 8:16:03 PM
> Subject: IE9 Issue with UI Plugin
> 
> Hi Vojtech,
> 
> I had previously sent you an email about IE9 compatibility where the problem
> we were having was solved by omitting console logging when a console was
> unavailable (i.e. IE). However, it is looking like IE9 may have a bigger
> issue with regards to the plugin framework.
> 
> Now that we have gotten dialogs to open via dynamically inserted buttons
> within RHEV tabs (for example, a NetApp button in the Storage tab), we can
> go through our whole process with the exception of closing the window. In
> all other browsers, our dialog will close as expected, but in IE the window
> remains open. It can be closed by hitting the red "x" in the corner, but it
> appears the code in the frame itself cannot close the window, with a console
> message in the dev tools of IE9 showing an error of "'Math' is undefined".
> I've read up on this, and it seems like this is a very widespread error in
> Internet Explorer concerning the manner/order in which iframes are
> dynamically inserted.
> 
> I've copied engine-devel in case anyone has similar issues/solutions, but it
> seems as though we need some sort of clause in the plugin framework for IE
> when it comes to dynamic insertion of new windows.
> 
> - Ricky Hopper
> 


From vszocs at redhat.com  Wed Jun 19 13:19:44 2013
From: vszocs at redhat.com (Vojtech Szocs)
Date: Wed, 19 Jun 2013 09:19:44 -0400 (EDT)
Subject: [Engine-devel] IE9 Issue with UI Plugin
In-Reply-To: <1796208617.20183450.1371635656569.JavaMail.root@redhat.com>
References: <CDE4CAA2.5617%rickyh@netapp.com>
	<1796208617.20183450.1371635656569.JavaMail.root@redhat.com>
Message-ID: <505179704.20246859.1371647984316.JavaMail.root@redhat.com>

Hi Ricky,

you were right, in IE9, postMessage listener (WebAdmin) didn't work properly, so I simplified it and verified that it now works in IE9, too: http://gerrit.ovirt.org/#/c/15888/

After applying above mentioned patch, everything should work as expected in IE9. I've also attached "test-plugin" which I used for verification in IE9.

Regards,
Vojtech


----- Original Message -----
> From: "Vojtech Szocs" <vszocs at redhat.com>
> To: "Richard Hopper" <Richard.Hopper at netapp.com>
> Cc: engine-devel at ovirt.org, "Christopher Morrissey" <Christopher.Morrissey at netapp.com>
> Sent: Wednesday, June 19, 2013 11:54:16 AM
> Subject: Re: [Engine-devel] IE9 Issue with UI Plugin
> 
> Hi Ricky,
> 
> code running in the iframe (custom dialog content) can close the dialog in
> the following way:
> 
> 1, send message to your plugin to indicate the dialog needs to be closed:
> 
>     parent.postMessage('CloseMyDialog', '*');
> 
> 2, your plugin intercepts the message via MessageReceived function and closes
> the dialog:
> 
>     MessageReceived: function(data, sourceWindow) {
>         switch (data) {
>             case 'CloseMyDialog':
>                 window.alert('About to close dialog');
>                 api.closeDialog('my-dialog');
>                 break;
>         }
>     }
> 
> If the above doesn't work for you, it could mean that:
> - MessageReceived function isn't invoked - make sure to have [*] before
> api.register() call
> - api.closeDialog() function isn't working - in this case I need to fix it
> for IE9
> 
> [*] accept message events from iframe (custom dialog content) origin
> 
>     api.options({
>         allowedMessageOrigins: 'http://nicedomain:8080'
>         /* OR */
>         allowedMessageOrigins: ['http://nicedomain1:123',
>         'https://nicedomain2:345']
>     });
> 
> I'm going to investigate this issue on IE9 myself to see if the above code is
> really working there.
> 
> Vojtech
> 
> 
> ----- Original Message -----
> > From: "Richard Hopper" <Richard.Hopper at netapp.com>
> > To: "Vojtech Szocs" <vszocs at redhat.com>
> > Cc: engine-devel at ovirt.org, "Christopher Morrissey"
> > <Christopher.Morrissey at netapp.com>
> > Sent: Monday, June 17, 2013 8:16:03 PM
> > Subject: IE9 Issue with UI Plugin
> > 
> > Hi Vojtech,
> > 
> > I had previously sent you an email about IE9 compatibility where the
> > problem
> > we were having was solved by omitting console logging when a console was
> > unavailable (i.e. IE). However, it is looking like IE9 may have a bigger
> > issue with regards to the plugin framework.
> > 
> > Now that we have gotten dialogs to open via dynamically inserted buttons
> > within RHEV tabs (for example, a NetApp button in the Storage tab), we can
> > go through our whole process with the exception of closing the window. In
> > all other browsers, our dialog will close as expected, but in IE the window
> > remains open. It can be closed by hitting the red "x" in the corner, but it
> > appears the code in the frame itself cannot close the window, with a
> > console
> > message in the dev tools of IE9 showing an error of "'Math' is undefined".
> > I've read up on this, and it seems like this is a very widespread error in
> > Internet Explorer concerning the manner/order in which iframes are
> > dynamically inserted.
> > 
> > I've copied engine-devel in case anyone has similar issues/solutions, but
> > it
> > seems as though we need some sort of clause in the plugin framework for IE
> > when it comes to dynamic insertion of new windows.
> > 
> > - Ricky Hopper
> > 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test-plugin.tar.gz
Type: application/x-compressed-tar
Size: 693 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130619/3212eaaf/attachment.bin>

From tjelinek at redhat.com  Wed Jun 19 13:33:24 2013
From: tjelinek at redhat.com (Tomas Jelinek)
Date: Wed, 19 Jun 2013 09:33:24 -0400 (EDT)
Subject: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
In-Reply-To: <1391368129.20236042.1371646730953.JavaMail.root@redhat.com>
Message-ID: <501973842.20255318.1371648804880.JavaMail.root@redhat.com>

Hi all,

for the non plugin invocation of the console (http://www.ovirt.org/Features/Non_plugin_console_invocation) the dynamicMenu property is not usable to enrich the SPICE client menu. 

This feature is about requesting this menu using oVirt's REST API and than calling it back once some item from this menu has been selected.

The oVirt's feature page with specific details: http://www.ovirt.org/Features/Foreign_Menu_Using_REST

Any comments are more than welcomed.

Thanx,
Tomas


From vszocs at redhat.com  Wed Jun 19 14:14:25 2013
From: vszocs at redhat.com (Vojtech Szocs)
Date: Wed, 19 Jun 2013 10:14:25 -0400 (EDT)
Subject: [Engine-devel] Speed up GWT compilation for developer builds
In-Reply-To: <173430066.20265911.1371650199831.JavaMail.root@redhat.com>
Message-ID: <358920467.20275225.1371651265143.JavaMail.root@redhat.com>

Hi guys,

I've just merged patch [http://gerrit.ovirt.org/#/c/15849/] which introduces gwtdraft build profile.

I did some build runs and here are my results for WebAdmin GWT compilation:
- without gwtdraft: ~ 3:00 min
- with gwtdraft: ~ 2:15 min

I'll have to update http://www.ovirt.org/DebugFrontend but in the meantime, make sure to enable gwtdraft in your development environment because it really speeds up GWT compilation!

  $ make install-dev PREFIX="${HOME}/ovirt-engine" DEV_BUILD_GWT_DRAFT=1

Regards,
Vojtech


From Christopher.Morrissey at netapp.com  Wed Jun 19 14:44:08 2013
From: Christopher.Morrissey at netapp.com (Morrissey, Christopher)
Date: Wed, 19 Jun 2013 14:44:08 +0000
Subject: [Engine-devel] IE9 Issue with UI Plugin
In-Reply-To: <1796208617.20183450.1371635656569.JavaMail.root@redhat.com>
References: <CDE4CAA2.5617%rickyh@netapp.com>
	<1796208617.20183450.1371635656569.JavaMail.root@redhat.com>
Message-ID: <D290AD8432118048947689BA3AE8A9B33C88BCB0@SACEXCMBX04-PRD.hq.netapp.com>

Thanks for the patch, Vojtech. I'm testing it out now.

-Chris


> -----Original Message-----
> From: Vojtech Szocs [mailto:vszocs at redhat.com]
> Sent: Wednesday, June 19, 2013 5:54 AM
> To: Hopper, Richard
> Cc: engine-devel at ovirt.org; Morrissey, Christopher
> Subject: Re: IE9 Issue with UI Plugin
> 
> Hi Ricky,
> 
> code running in the iframe (custom dialog content) can close the dialog in the
> following way:
> 
> 1, send message to your plugin to indicate the dialog needs to be closed:
> 
>     parent.postMessage('CloseMyDialog', '*');
> 
> 2, your plugin intercepts the message via MessageReceived function and
> closes the dialog:
> 
>     MessageReceived: function(data, sourceWindow) {
>         switch (data) {
>             case 'CloseMyDialog':
>                 window.alert('About to close dialog');
>                 api.closeDialog('my-dialog');
>                 break;
>         }
>     }
> 
> If the above doesn't work for you, it could mean that:
> - MessageReceived function isn't invoked - make sure to have [*] before
> api.register() call
> - api.closeDialog() function isn't working - in this case I need to fix it for IE9
> 
> [*] accept message events from iframe (custom dialog content) origin
> 
>     api.options({
>         allowedMessageOrigins: 'http://nicedomain:8080'
>         /* OR */
>         allowedMessageOrigins: ['http://nicedomain1:123',
> 'https://nicedomain2:345']
>     });
> 
> I'm going to investigate this issue on IE9 myself to see if the above code is
> really working there.
> 
> Vojtech
> 
> 
> ----- Original Message -----
> > From: "Richard Hopper" <Richard.Hopper at netapp.com>
> > To: "Vojtech Szocs" <vszocs at redhat.com>
> > Cc: engine-devel at ovirt.org, "Christopher Morrissey"
> > <Christopher.Morrissey at netapp.com>
> > Sent: Monday, June 17, 2013 8:16:03 PM
> > Subject: IE9 Issue with UI Plugin
> >
> > Hi Vojtech,
> >
> > I had previously sent you an email about IE9 compatibility where the
> > problem we were having was solved by omitting console logging when a
> > console was unavailable (i.e. IE). However, it is looking like IE9 may
> > have a bigger issue with regards to the plugin framework.
> >
> > Now that we have gotten dialogs to open via dynamically inserted
> > buttons within RHEV tabs (for example, a NetApp button in the Storage
> > tab), we can go through our whole process with the exception of
> > closing the window. In all other browsers, our dialog will close as
> > expected, but in IE the window remains open. It can be closed by
> > hitting the red "x" in the corner, but it appears the code in the
> > frame itself cannot close the window, with a console message in the dev
> tools of IE9 showing an error of "'Math' is undefined".
> > I've read up on this, and it seems like this is a very widespread
> > error in Internet Explorer concerning the manner/order in which
> > iframes are dynamically inserted.
> >
> > I've copied engine-devel in case anyone has similar issues/solutions,
> > but it seems as though we need some sort of clause in the plugin
> > framework for IE when it comes to dynamic insertion of new windows.
> >
> > - Ricky Hopper
> >

From iheim at redhat.com  Wed Jun 19 15:00:47 2013
From: iheim at redhat.com (Itamar Heim)
Date: Wed, 19 Jun 2013 18:00:47 +0300
Subject: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
In-Reply-To: <501973842.20255318.1371648804880.JavaMail.root@redhat.com>
References: <501973842.20255318.1371648804880.JavaMail.root@redhat.com>
Message-ID: <51C1C79F.3050401@redhat.com>

On 06/19/2013 04:33 PM, Tomas Jelinek wrote:
> Hi all,
>
> for the non plugin invocation of the console (http://www.ovirt.org/Features/Non_plugin_console_invocation) the dynamicMenu property is not usable to enrich the SPICE client menu.
>
> This feature is about requesting this menu using oVirt's REST API and than calling it back once some item from this menu has been selected.
>
> The oVirt's feature page with specific details: http://www.ovirt.org/Features/Foreign_Menu_Using_REST
>
> Any comments are more than welcomed.

Why are we putting the logic of the menu into the REST API?
can't the menu be builded by client based on getting the list of ISO's 
and current CD?



From mlureau at redhat.com  Wed Jun 19 14:31:58 2013
From: mlureau at redhat.com (=?utf-8?Q?Marc-Andr=C3=A9?= Lureau)
Date: Wed, 19 Jun 2013 10:31:58 -0400 (EDT)
Subject: [Engine-devel] [Spice-devel]  SPICE Foreign Menu Using REST
In-Reply-To: <501973842.20255318.1371648804880.JavaMail.root@redhat.com>
References: <501973842.20255318.1371648804880.JavaMail.root@redhat.com>
Message-ID: <1653042383.4973170.1371652318796.JavaMail.root@redhat.com>



----- Mensaje original -----
> Hi all,
> 
> for the non plugin invocation of the console
> (http://www.ovirt.org/Features/Non_plugin_console_invocation) the
> dynamicMenu property is not usable to enrich the SPICE client menu.
> 
> This feature is about requesting this menu using oVirt's REST API and than
> calling it back once some item from this menu has been selected.
> 
> The oVirt's feature page with specific details:
> http://www.ovirt.org/Features/Foreign_Menu_Using_REST
> 

How does the client know what vmID it should access? The client shouldn't need to know how to form the base menu URL itself.

Regarding the XML, most of the elements would be nicer as properties imho.

- "id"

What is this used for?

- "text"

Why not just call it "label"? "text" is quite generic name, could be a hint etc.. Btw, is the menu localizable and should the client add the LC_LANG or something in the request?

- "marked"

I suggest to follow Gtk/Qt naming "checked", since we expect a check mark next to the label.

- "item_code"

This is quite badly named. Afaik, none of the Spice client implemented accelerators via the menu (it isn't specified in http://spice-space.org/page/Whiteboard/ControllerProtocol). I think in the past there was no default menu provided by the client but the one created by the portal. So the client was configured with CONTROLLER_HOTKEYS and just displayed whatever the menu text was. There was no additional accelerators created. So, this should be considered as a new feature.

I would also like to see the accelerator format specified somewhere (shift, ctrl, alt, fN, char seperated by + afaik)

It could be useful and easy to add a "sensitive" property too already.

I would also like to see the "Comet" approach being discussed in alternatives, instead of the polling and the second refresh request, which I can imagine racy if two items are clicked quickly. Can we expect refresh reply in order (to allow "pipelining" of requests)?

thanks


From Richard.Hopper at netapp.com  Wed Jun 19 19:39:50 2013
From: Richard.Hopper at netapp.com (Hopper, Richard)
Date: Wed, 19 Jun 2013 19:39:50 +0000
Subject: [Engine-devel] IE9 Issue with UI Plugin
In-Reply-To: <505179704.20246859.1371647984316.JavaMail.root@redhat.com>
Message-ID: <CDE780A4.56D4%rickyh@netapp.com>

Hi Vojtech,

I've tested the new patch and for some reason am still running into
problems, though there are different exceptions now. I'll let you know if
we figure out what specifically is going on. It does work if dev tools are
up, but if there are no developer tools available the window will still
not close.

- Ricky

On 6/19/13 9:19 AM, "Vojtech Szocs" <vszocs at redhat.com> wrote:

>Hi Ricky,
>
>you were right, in IE9, postMessage listener (WebAdmin) didn't work
>properly, so I simplified it and verified that it now works in IE9, too:
>http://gerrit.ovirt.org/#/c/15888/
>
>After applying above mentioned patch, everything should work as expected
>in IE9. I've also attached "test-plugin" which I used for verification in
>IE9.
>
>Regards,
>Vojtech
>
>
>----- Original Message -----
>> From: "Vojtech Szocs" <vszocs at redhat.com>
>> To: "Richard Hopper" <Richard.Hopper at netapp.com>
>> Cc: engine-devel at ovirt.org, "Christopher Morrissey"
>><Christopher.Morrissey at netapp.com>
>> Sent: Wednesday, June 19, 2013 11:54:16 AM
>> Subject: Re: [Engine-devel] IE9 Issue with UI Plugin
>> 
>> Hi Ricky,
>> 
>> code running in the iframe (custom dialog content) can close the dialog
>>in
>> the following way:
>> 
>> 1, send message to your plugin to indicate the dialog needs to be
>>closed:
>> 
>>     parent.postMessage('CloseMyDialog', '*');
>> 
>> 2, your plugin intercepts the message via MessageReceived function and
>>closes
>> the dialog:
>> 
>>     MessageReceived: function(data, sourceWindow) {
>>         switch (data) {
>>             case 'CloseMyDialog':
>>                 window.alert('About to close dialog');
>>                 api.closeDialog('my-dialog');
>>                 break;
>>         }
>>     }
>> 
>> If the above doesn't work for you, it could mean that:
>> - MessageReceived function isn't invoked - make sure to have [*] before
>> api.register() call
>> - api.closeDialog() function isn't working - in this case I need to fix
>>it
>> for IE9
>> 
>> [*] accept message events from iframe (custom dialog content) origin
>> 
>>     api.options({
>>         allowedMessageOrigins: 'http://nicedomain:8080'
>>         /* OR */
>>         allowedMessageOrigins: ['http://nicedomain1:123',
>>         'https://nicedomain2:345']
>>     });
>> 
>> I'm going to investigate this issue on IE9 myself to see if the above
>>code is
>> really working there.
>> 
>> Vojtech
>> 
>> 
>> ----- Original Message -----
>> > From: "Richard Hopper" <Richard.Hopper at netapp.com>
>> > To: "Vojtech Szocs" <vszocs at redhat.com>
>> > Cc: engine-devel at ovirt.org, "Christopher Morrissey"
>> > <Christopher.Morrissey at netapp.com>
>> > Sent: Monday, June 17, 2013 8:16:03 PM
>> > Subject: IE9 Issue with UI Plugin
>> > 
>> > Hi Vojtech,
>> > 
>> > I had previously sent you an email about IE9 compatibility where the
>> > problem
>> > we were having was solved by omitting console logging when a console
>>was
>> > unavailable (i.e. IE). However, it is looking like IE9 may have a
>>bigger
>> > issue with regards to the plugin framework.
>> > 
>> > Now that we have gotten dialogs to open via dynamically inserted
>>buttons
>> > within RHEV tabs (for example, a NetApp button in the Storage tab),
>>we can
>> > go through our whole process with the exception of closing the
>>window. In
>> > all other browsers, our dialog will close as expected, but in IE the
>>window
>> > remains open. It can be closed by hitting the red "x" in the corner,
>>but it
>> > appears the code in the frame itself cannot close the window, with a
>> > console
>> > message in the dev tools of IE9 showing an error of "'Math' is
>>undefined".
>> > I've read up on this, and it seems like this is a very widespread
>>error in
>> > Internet Explorer concerning the manner/order in which iframes are
>> > dynamically inserted.
>> > 
>> > I've copied engine-devel in case anyone has similar issues/solutions,
>>but
>> > it
>> > seems as though we need some sort of clause in the plugin framework
>>for IE
>> > when it comes to dynamic insertion of new windows.
>> > 
>> > - Ricky Hopper
>> > 
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>> 



From cfergeau at redhat.com  Thu Jun 20 11:07:16 2013
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Thu, 20 Jun 2013 13:07:16 +0200
Subject: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
In-Reply-To: <51C1C79F.3050401@redhat.com>
References: <501973842.20255318.1371648804880.JavaMail.root@redhat.com>
	<51C1C79F.3050401@redhat.com>
Message-ID: <20130620110715.GC2834@teriyaki>

Hey Itamar,

On Wed, Jun 19, 2013 at 06:00:47PM +0300, Itamar Heim wrote:
> On 06/19/2013 04:33 PM, Tomas Jelinek wrote:
> >Hi all,
> >
> >for the non plugin invocation of the console (http://www.ovirt.org/Features/Non_plugin_console_invocation) the dynamicMenu property is not usable to enrich the SPICE client menu.
> >
> >This feature is about requesting this menu using oVirt's REST API and than calling it back once some item from this menu has been selected.
> >
> >The oVirt's feature page with specific details: http://www.ovirt.org/Features/Foreign_Menu_Using_REST
> >
> >Any comments are more than welcomed.
> 
> Why are we putting the logic of the menu into the REST API?
> can't the menu be builded by client based on getting the list of
> ISO's and current CD?

The client needs a way to get the list of available ISOs in order to build
the menu, as well as a way to let the engine know when the user clicked on
an ISO in the menu. One way of doing that is to have the menu stuff exposed
in the REST API. Another way would be to expose the list of ISOs in the
REST API (I'd have a slight preference for that I think).
Or do you have anything in mind for the client to get the list of ISOs
available to the engine?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130620/c898a52f/attachment.sig>

From iheim at redhat.com  Thu Jun 20 11:09:21 2013
From: iheim at redhat.com (Itamar Heim)
Date: Thu, 20 Jun 2013 14:09:21 +0300
Subject: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
In-Reply-To: <20130620110715.GC2834@teriyaki>
References: <501973842.20255318.1371648804880.JavaMail.root@redhat.com>
	<51C1C79F.3050401@redhat.com> <20130620110715.GC2834@teriyaki>
Message-ID: <51C2E2E1.8030808@redhat.com>

On 06/20/2013 02:07 PM, Christophe Fergeau wrote:
> Hey Itamar,
>
> On Wed, Jun 19, 2013 at 06:00:47PM +0300, Itamar Heim wrote:
>> On 06/19/2013 04:33 PM, Tomas Jelinek wrote:
>>> Hi all,
>>>
>>> for the non plugin invocation of the console (http://www.ovirt.org/Features/Non_plugin_console_invocation) the dynamicMenu property is not usable to enrich the SPICE client menu.
>>>
>>> This feature is about requesting this menu using oVirt's REST API and than calling it back once some item from this menu has been selected.
>>>
>>> The oVirt's feature page with specific details: http://www.ovirt.org/Features/Foreign_Menu_Using_REST
>>>
>>> Any comments are more than welcomed.
>>
>> Why are we putting the logic of the menu into the REST API?
>> can't the menu be builded by client based on getting the list of
>> ISO's and current CD?
>
> The client needs a way to get the list of available ISOs in order to build
> the menu, as well as a way to let the engine know when the user clicked on
> an ISO in the menu. One way of doing that is to have the menu stuff exposed
> in the REST API. Another way would be to expose the list of ISOs in the
> REST API (I'd have a slight preference for that I think).

that's my preference as well, and the REST API should already do that today:
- get list of ISOs of available in a DC (the one the VM is in)
- ability to change the CD of the VM

> Or do you have anything in mind for the client to get the list of ISOs
> available to the engine?

my preference is to provide the data, not the semantics of the menu.
iiuc, we are on the same page.

>
> Christophe
>



From tjelinek at redhat.com  Thu Jun 20 12:13:06 2013
From: tjelinek at redhat.com (Tomas Jelinek)
Date: Thu, 20 Jun 2013 08:13:06 -0400 (EDT)
Subject: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
In-Reply-To: <51C2E2E1.8030808@redhat.com>
References: <501973842.20255318.1371648804880.JavaMail.root@redhat.com>
	<51C1C79F.3050401@redhat.com> <20130620110715.GC2834@teriyaki>
	<51C2E2E1.8030808@redhat.com>
Message-ID: <936279456.20836092.1371730386788.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Itamar Heim" <iheim at redhat.com>
> To: "Christophe Fergeau" <cfergeau at redhat.com>
> Cc: "Tomas Jelinek" <tjelinek at redhat.com>, "engine-devel" <engine-devel at ovirt.org>,
> spice-devel at lists.freedesktop.org, "Marc-Andr? Lureau" <mlureau at redhat.com>
> Sent: Thursday, June 20, 2013 1:09:21 PM
> Subject: Re: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
> 
> On 06/20/2013 02:07 PM, Christophe Fergeau wrote:
> > Hey Itamar,
> >
> > On Wed, Jun 19, 2013 at 06:00:47PM +0300, Itamar Heim wrote:
> >> On 06/19/2013 04:33 PM, Tomas Jelinek wrote:
> >>> Hi all,
> >>>
> >>> for the non plugin invocation of the console
> >>> (http://www.ovirt.org/Features/Non_plugin_console_invocation) the
> >>> dynamicMenu property is not usable to enrich the SPICE client menu.
> >>>
> >>> This feature is about requesting this menu using oVirt's REST API and
> >>> than calling it back once some item from this menu has been selected.
> >>>
> >>> The oVirt's feature page with specific details:
> >>> http://www.ovirt.org/Features/Foreign_Menu_Using_REST
> >>>
> >>> Any comments are more than welcomed.
> >>
> >> Why are we putting the logic of the menu into the REST API?
> >> can't the menu be builded by client based on getting the list of
> >> ISO's and current CD?
> >
> > The client needs a way to get the list of available ISOs in order to build
> > the menu, as well as a way to let the engine know when the user clicked on
> > an ISO in the menu. One way of doing that is to have the menu stuff exposed
> > in the REST API. Another way would be to expose the list of ISOs in the
> > REST API (I'd have a slight preference for that I think).
> 
> that's my preference as well, and the REST API should already do that today:
> - get list of ISOs of available in a DC (the one the VM is in)
> - ability to change the CD of the VM
Well, and what about the stop/suspend VM for example, what we have in the menu today?
Also this should be something that the client decide to have or not have?

> 
> > Or do you have anything in mind for the client to get the list of ISOs
> > available to the engine?
> 
> my preference is to provide the data, not the semantics of the menu.
We should clarify something here. There are two possibilities who should be responsible for deciding
what should the foreign menu contain and also what to do if it the item is selected:
1: the client - e.g. we will not provide any support for the menu in REST because the client reads what needs
   and knows how to call the oVirt back

2: the server side - e.g. we will provide in REST side the menu structure with the description what to do if something is
   selected

Both have some advantages and disadvantages but we need to clarify which way to go. So, who is the one responsible to decide
what is in the foreign menu (now or in the future) and how to react if something is selected? Client or engine?

> iiuc, we are on the same page.
> 
> >
> > Christophe
> >
> 
> 


From iheim at redhat.com  Thu Jun 20 12:27:56 2013
From: iheim at redhat.com (Itamar Heim)
Date: Thu, 20 Jun 2013 15:27:56 +0300
Subject: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
In-Reply-To: <936279456.20836092.1371730386788.JavaMail.root@redhat.com>
References: <501973842.20255318.1371648804880.JavaMail.root@redhat.com>
	<51C1C79F.3050401@redhat.com> <20130620110715.GC2834@teriyaki>
	<51C2E2E1.8030808@redhat.com>
	<936279456.20836092.1371730386788.JavaMail.root@redhat.com>
Message-ID: <51C2F54C.60409@redhat.com>

On 06/20/2013 03:13 PM, Tomas Jelinek wrote:
>
>
> ----- Original Message -----
>> From: "Itamar Heim" <iheim at redhat.com>
>> To: "Christophe Fergeau" <cfergeau at redhat.com>
>> Cc: "Tomas Jelinek" <tjelinek at redhat.com>, "engine-devel" <engine-devel at ovirt.org>,
>> spice-devel at lists.freedesktop.org, "Marc-Andr? Lureau" <mlureau at redhat.com>
>> Sent: Thursday, June 20, 2013 1:09:21 PM
>> Subject: Re: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
>>
>> On 06/20/2013 02:07 PM, Christophe Fergeau wrote:
>>> Hey Itamar,
>>>
>>> On Wed, Jun 19, 2013 at 06:00:47PM +0300, Itamar Heim wrote:
>>>> On 06/19/2013 04:33 PM, Tomas Jelinek wrote:
>>>>> Hi all,
>>>>>
>>>>> for the non plugin invocation of the console
>>>>> (http://www.ovirt.org/Features/Non_plugin_console_invocation) the
>>>>> dynamicMenu property is not usable to enrich the SPICE client menu.
>>>>>
>>>>> This feature is about requesting this menu using oVirt's REST API and
>>>>> than calling it back once some item from this menu has been selected.
>>>>>
>>>>> The oVirt's feature page with specific details:
>>>>> http://www.ovirt.org/Features/Foreign_Menu_Using_REST
>>>>>
>>>>> Any comments are more than welcomed.
>>>>
>>>> Why are we putting the logic of the menu into the REST API?
>>>> can't the menu be builded by client based on getting the list of
>>>> ISO's and current CD?
>>>
>>> The client needs a way to get the list of available ISOs in order to build
>>> the menu, as well as a way to let the engine know when the user clicked on
>>> an ISO in the menu. One way of doing that is to have the menu stuff exposed
>>> in the REST API. Another way would be to expose the list of ISOs in the
>>> REST API (I'd have a slight preference for that I think).
>>
>> that's my preference as well, and the REST API should already do that today:
>> - get list of ISOs of available in a DC (the one the VM is in)
>> - ability to change the CD of the VM
> Well, and what about the stop/suspend VM for example, what we have in the menu today?

supported as well.

> Also this should be something that the client decide to have or not have?

I think the client should decide on the features relevant to the client.

>
>>
>>> Or do you have anything in mind for the client to get the list of ISOs
>>> available to the engine?
>>
>> my preference is to provide the data, not the semantics of the menu.
> We should clarify something here. There are two possibilities who should be responsible for deciding
> what should the foreign menu contain and also what to do if it the item is selected:
> 1: the client - e.g. we will not provide any support for the menu in REST because the client reads what needs
>     and knows how to call the oVirt back
>
> 2: the server side - e.g. we will provide in REST side the menu structure with the description what to do if something is
>     selected
>
> Both have some advantages and disadvantages but we need to clarify which way to go. So, who is the one responsible to decide
> what is in the foreign menu (now or in the future) and how to react if something is selected? Client or engine?

my preference is the client will decide this, as there are various 
clients to the REST API, and each should decide which features are 
important for them.

>
>> iiuc, we are on the same page.
>>
>>>
>>> Christophe
>>>
>>
>>



From deadhorseconsulting at gmail.com  Sat Jun 22 02:05:21 2013
From: deadhorseconsulting at gmail.com (Dead Horse)
Date: Fri, 21 Jun 2013 21:05:21 -0500
Subject: [Engine-devel] Console broken with current master vmSetTicket error
Message-ID: <CAEWPe=p6a8Vgkf_wBN19rhtGR5yu+=KduV4RYF5RmVdNnuT4QA@mail.gmail.com>

When the console button is clicked in the webadmin or userportal (engine
and vdsm built from the latest master) the follow error message is returned:

"Error while executing action SetVmTicket: Unexpected exception"

This occurs with latest master engine and vdsm built as of today.

engine and vdsm logs of failure attached.

- DHC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130621/06630fe6/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: engine.log
Type: application/octet-stream
Size: 2351 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130621/06630fe6/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vdsm.log
Type: application/octet-stream
Size: 1567 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130621/06630fe6/attachment-0001.obj>

From michal.skrivanek at redhat.com  Sun Jun 23 07:00:40 2013
From: michal.skrivanek at redhat.com (Michal Skrivanek)
Date: Sun, 23 Jun 2013 09:00:40 +0200
Subject: [Engine-devel] Console broken with current master vmSetTicket
	error
In-Reply-To: <CAEWPe=p6a8Vgkf_wBN19rhtGR5yu+=KduV4RYF5RmVdNnuT4QA@mail.gmail.com>
References: <CAEWPe=p6a8Vgkf_wBN19rhtGR5yu+=KduV4RYF5RmVdNnuT4QA@mail.gmail.com>
Message-ID: <49EBCD45-0CB4-4837-8730-FD3375674BFA@redhat.com>

Hi,
libvirt version?
perhaps libvirt log as well

Thanks,
michal
 
On Jun 22, 2013, at 04:05 , Dead Horse <deadhorseconsulting at gmail.com> wrote:

> When the console button is clicked in the webadmin or userportal (engine and vdsm built from the latest master) the follow error message is returned:
> 
> "Error while executing action SetVmTicket: Unexpected exception"
> 
> This occurs with latest master engine and vdsm built as of today.
> 
> engine and vdsm logs of failure attached.
> 
> - DHC
> <engine.log><vdsm.log>_______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel



From alonbl at redhat.com  Sun Jun 23 07:35:17 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Sun, 23 Jun 2013 03:35:17 -0400 (EDT)
Subject: [Engine-devel] Feedback image at ovirt-engine
In-Reply-To: <1451490611.11604758.1371972084041.JavaMail.root@redhat.com>
Message-ID: <1721109520.11605189.1371972917704.JavaMail.root@redhat.com>

Hello,

There was a request to add feedback image to the webadmin portal, this has been implemented[1] using the new branding plugins.

My question is which URL to redirect user when pressing the feedback image, currently I just put http://www.ovirt.org.

Using mailto: to a mailing list is something I do not like as:
1. Most people do not have mailto: handler anymore.
2. User will not know that he is forwarded to a mailing list and will wait for a response.
3. There is no way to enforce format (subject, titles).

But any URL is possible... including empty to disable the feature.

What do you think?
Alon

[1] http://gerrit.ovirt.org/#/c/15984/


From iheim at redhat.com  Sun Jun 23 15:21:43 2013
From: iheim at redhat.com (Itamar Heim)
Date: Sun, 23 Jun 2013 18:21:43 +0300
Subject: [Engine-devel] Feedback image at ovirt-engine
In-Reply-To: <1721109520.11605189.1371972917704.JavaMail.root@redhat.com>
References: <1721109520.11605189.1371972917704.JavaMail.root@redhat.com>
Message-ID: <51C71287.4030705@redhat.com>

On 06/23/2013 10:35 AM, Alon Bar-Lev wrote:
> Hello,
>
> There was a request to add feedback image to the webadmin portal, this has been implemented[1] using the new branding plugins.
>
> My question is which URL to redirect user when pressing the feedback image, currently I just put http://www.ovirt.org.
>
> Using mailto: to a mailing list is something I do not like as:
> 1. Most people do not have mailto: handler anymore.
> 2. User will not know that he is forwarded to a mailing list and will wait for a response.
> 3. There is no way to enforce format (subject, titles).
>
> But any URL is possible... including empty to disable the feature.
>
> What do you think?
> Alon
>
> [1] http://gerrit.ovirt.org/#/c/15984/
> _______________________________________________
> Arch mailing list
> Arch at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/arch
>

I do like mailto, even if the mail handler is disabled, its easy to 
understand what should i do to get more help, send feedback, etc.


From alonbl at redhat.com  Sun Jun 23 15:22:22 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Sun, 23 Jun 2013 11:22:22 -0400 (EDT)
Subject: [Engine-devel] Feedback image at ovirt-engine
In-Reply-To: <51C71287.4030705@redhat.com>
References: <1721109520.11605189.1371972917704.JavaMail.root@redhat.com>
	<51C71287.4030705@redhat.com>
Message-ID: <84207001.11623536.1372000942916.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Itamar Heim" <iheim at redhat.com>
> To: "Alon Bar-Lev" <alonbl at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>, "arch" <arch at ovirt.org>
> Sent: Sunday, June 23, 2013 6:21:43 PM
> Subject: Re: Feedback image at ovirt-engine
> 
> On 06/23/2013 10:35 AM, Alon Bar-Lev wrote:
> > Hello,
> >
> > There was a request to add feedback image to the webadmin portal, this has
> > been implemented[1] using the new branding plugins.
> >
> > My question is which URL to redirect user when pressing the feedback image,
> > currently I just put http://www.ovirt.org.
> >
> > Using mailto: to a mailing list is something I do not like as:
> > 1. Most people do not have mailto: handler anymore.
> > 2. User will not know that he is forwarded to a mailing list and will wait
> > for a response.
> > 3. There is no way to enforce format (subject, titles).
> >
> > But any URL is possible... including empty to disable the feature.
> >
> > What do you think?
> > Alon
> >
> > [1] http://gerrit.ovirt.org/#/c/15984/
> > _______________________________________________
> > Arch mailing list
> > Arch at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/arch
> >
> 
> I do like mailto, even if the mail handler is disabled, its easy to
> understand what should i do to get more help, send feedback, etc.
> 

Please suggest what mailto.


From iheim at redhat.com  Sun Jun 23 15:25:15 2013
From: iheim at redhat.com (Itamar Heim)
Date: Sun, 23 Jun 2013 18:25:15 +0300
Subject: [Engine-devel] Feedback image at ovirt-engine
In-Reply-To: <84207001.11623536.1372000942916.JavaMail.root@redhat.com>
References: <1721109520.11605189.1371972917704.JavaMail.root@redhat.com>
	<51C71287.4030705@redhat.com>
	<84207001.11623536.1372000942916.JavaMail.root@redhat.com>
Message-ID: <51C7135B.1070103@redhat.com>

On 06/23/2013 06:22 PM, Alon Bar-Lev wrote:
>
>
> ----- Original Message -----
>> From: "Itamar Heim" <iheim at redhat.com>
>> To: "Alon Bar-Lev" <alonbl at redhat.com>
>> Cc: "engine-devel" <engine-devel at ovirt.org>, "arch" <arch at ovirt.org>
>> Sent: Sunday, June 23, 2013 6:21:43 PM
>> Subject: Re: Feedback image at ovirt-engine
>>
>> On 06/23/2013 10:35 AM, Alon Bar-Lev wrote:
>>> Hello,
>>>
>>> There was a request to add feedback image to the webadmin portal, this has
>>> been implemented[1] using the new branding plugins.
>>>
>>> My question is which URL to redirect user when pressing the feedback image,
>>> currently I just put http://www.ovirt.org.
>>>
>>> Using mailto: to a mailing list is something I do not like as:
>>> 1. Most people do not have mailto: handler anymore.
>>> 2. User will not know that he is forwarded to a mailing list and will wait
>>> for a response.
>>> 3. There is no way to enforce format (subject, titles).
>>>
>>> But any URL is possible... including empty to disable the feature.
>>>
>>> What do you think?
>>> Alon
>>>
>>> [1] http://gerrit.ovirt.org/#/c/15984/
>>> _______________________________________________
>>> Arch mailing list
>>> Arch at ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/arch
>>>
>>
>> I do like mailto, even if the mail handler is disabled, its easy to
>> understand what should i do to get more help, send feedback, etc.
>>
>
> Please suggest what mailto.
>

mailto: users at ovirt.org
not sure i would even put a default subject


From alonbl at redhat.com  Sun Jun 23 15:37:17 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Sun, 23 Jun 2013 11:37:17 -0400 (EDT)
Subject: [Engine-devel] Feedback image at ovirt-engine
In-Reply-To: <51C7135B.1070103@redhat.com>
References: <1721109520.11605189.1371972917704.JavaMail.root@redhat.com>
	<51C71287.4030705@redhat.com>
	<84207001.11623536.1372000942916.JavaMail.root@redhat.com>
	<51C7135B.1070103@redhat.com>
Message-ID: <1741491928.11624041.1372001837127.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Itamar Heim" <iheim at redhat.com>
> To: "Alon Bar-Lev" <alonbl at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>, "arch" <arch at ovirt.org>
> Sent: Sunday, June 23, 2013 6:25:15 PM
> Subject: Re: Feedback image at ovirt-engine
> 
> On 06/23/2013 06:22 PM, Alon Bar-Lev wrote:
> >
> >
> > ----- Original Message -----
> >> From: "Itamar Heim" <iheim at redhat.com>
> >> To: "Alon Bar-Lev" <alonbl at redhat.com>
> >> Cc: "engine-devel" <engine-devel at ovirt.org>, "arch" <arch at ovirt.org>
> >> Sent: Sunday, June 23, 2013 6:21:43 PM
> >> Subject: Re: Feedback image at ovirt-engine
> >>
> >> On 06/23/2013 10:35 AM, Alon Bar-Lev wrote:
> >>> Hello,
> >>>
> >>> There was a request to add feedback image to the webadmin portal, this
> >>> has
> >>> been implemented[1] using the new branding plugins.
> >>>
> >>> My question is which URL to redirect user when pressing the feedback
> >>> image,
> >>> currently I just put http://www.ovirt.org.
> >>>
> >>> Using mailto: to a mailing list is something I do not like as:
> >>> 1. Most people do not have mailto: handler anymore.
> >>> 2. User will not know that he is forwarded to a mailing list and will
> >>> wait
> >>> for a response.
> >>> 3. There is no way to enforce format (subject, titles).
> >>>
> >>> But any URL is possible... including empty to disable the feature.
> >>>
> >>> What do you think?
> >>> Alon
> >>>
> >>> [1] http://gerrit.ovirt.org/#/c/15984/
> >>> _______________________________________________
> >>> Arch mailing list
> >>> Arch at ovirt.org
> >>> http://lists.ovirt.org/mailman/listinfo/arch
> >>>
> >>
> >> I do like mailto, even if the mail handler is disabled, its easy to
> >> understand what should i do to get more help, send feedback, etc.
> >>
> >
> > Please suggest what mailto.
> >
> 
> mailto: users at ovirt.org
> not sure i would even put a default subject
> 

OK, done.


From eedri at redhat.com  Sun Jun 23 19:25:48 2013
From: eedri at redhat.com (Eyal Edri)
Date: Sun, 23 Jun 2013 15:25:48 -0400 (EDT)
Subject: [Engine-devel] Failures on findbugs - ovirt-engine
In-Reply-To: <531798552.1146706.1372015093821.JavaMail.root@redhat.com>
Message-ID: <1643733749.1147712.1372015548362.JavaMail.root@redhat.com>

fyi,

Findbugs has a new 1 NORMAL priority failure in jenkins.ovirt.org [1]
it seems that the patch that introduced it had a failure from jenkins [2], probably on the same issue.

Any reason why this was ignored/overlooked in the patch before merging it ?
(rebasing the patch retriggered the job that didn't complete on the 2nd run).

Please contact any infra team member if you see a failure that you think is wrong or not relevant,
before merging. 

The reason we have these jobs is exactly to stop such regressions from happening post merge. 
it is important to acknowledge those errors and address them, even if might be false positives some times. 

hopefully we'll soon have more powerful slaves to run those gerrit jobs and they will finish faster. 

[1] http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4492/findbugsResult/NORMAL/?
[2] http://gerrit.ovirt.org/#/c/15783/

thank you

Eyal
ovirt infra team.


From iheim at redhat.com  Sun Jun 23 20:00:38 2013
From: iheim at redhat.com (Itamar Heim)
Date: Sun, 23 Jun 2013 23:00:38 +0300
Subject: [Engine-devel] setup ovirt-engine on graphic or web mode
In-Reply-To: <5e10b363.24fde.13ef4c48df1.Coremail.shweng@163.com>
References: <5e10b363.24fde.13ef4c48df1.Coremail.shweng@163.com>
Message-ID: <51C753E6.4000601@redhat.com>

On 05/30/2013 12:28 PM, Edgar wrote:
> Hi,All
> so far as I know, we use engine-setup command to setup ovirt engine.
> engine-setup coded in python which run in linux shell.it is not convenience
> to some people that not be familiar with Linux OS.
> Currently,Does oVirt project has some tools or method that support to
> setup engine on graphic or web mode?
> If no, Is there any plan or schedule to support this feature?
> Thanks and Best Regards.

do you have an example of what you had in mind?
the installer asks a few questions, and we tried to make it as simple as 
possible.
we could ask the same questions "in GUI" (say, via a web page), but they 
would still probably be the same questions?

Thanks,
    Itamar



From michal.skrivanek at redhat.com  Mon Jun 24 08:02:29 2013
From: michal.skrivanek at redhat.com (Michal Skrivanek)
Date: Mon, 24 Jun 2013 10:02:29 +0200
Subject: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
In-Reply-To: <51C2F54C.60409@redhat.com>
References: <501973842.20255318.1371648804880.JavaMail.root@redhat.com>
	<51C1C79F.3050401@redhat.com> <20130620110715.GC2834@teriyaki>
	<51C2E2E1.8030808@redhat.com>
	<936279456.20836092.1371730386788.JavaMail.root@redhat.com>
	<51C2F54C.60409@redhat.com>
Message-ID: <6609F396-8D78-46FB-9F2D-3700D769B5E9@redhat.com>


On Jun 20, 2013, at 14:27 , Itamar Heim <iheim at redhat.com> wrote:

> On 06/20/2013 03:13 PM, Tomas Jelinek wrote:
>> 
>> 
>> ----- Original Message -----
>>> From: "Itamar Heim" <iheim at redhat.com>
>>> To: "Christophe Fergeau" <cfergeau at redhat.com>
>>> Cc: "Tomas Jelinek" <tjelinek at redhat.com>, "engine-devel" <engine-devel at ovirt.org>,
>>> spice-devel at lists.freedesktop.org, "Marc-Andr? Lureau" <mlureau at redhat.com>
>>> Sent: Thursday, June 20, 2013 1:09:21 PM
>>> Subject: Re: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
>>> 
>>> On 06/20/2013 02:07 PM, Christophe Fergeau wrote:
>>>> Hey Itamar,
>>>> 
>>>> On Wed, Jun 19, 2013 at 06:00:47PM +0300, Itamar Heim wrote:
>>>>> On 06/19/2013 04:33 PM, Tomas Jelinek wrote:
>>>>>> Hi all,
>>>>>> 
>>>>>> for the non plugin invocation of the console
>>>>>> (http://www.ovirt.org/Features/Non_plugin_console_invocation) the
>>>>>> dynamicMenu property is not usable to enrich the SPICE client menu.
>>>>>> 
>>>>>> This feature is about requesting this menu using oVirt's REST API and
>>>>>> than calling it back once some item from this menu has been selected.
>>>>>> 
>>>>>> The oVirt's feature page with specific details:
>>>>>> http://www.ovirt.org/Features/Foreign_Menu_Using_REST
>>>>>> 
>>>>>> Any comments are more than welcomed.
>>>>> 
>>>>> Why are we putting the logic of the menu into the REST API?
>>>>> can't the menu be builded by client based on getting the list of
>>>>> ISO's and current CD?
>>>> 
>>>> The client needs a way to get the list of available ISOs in order to build
>>>> the menu, as well as a way to let the engine know when the user clicked on
>>>> an ISO in the menu. One way of doing that is to have the menu stuff exposed
>>>> in the REST API. Another way would be to expose the list of ISOs in the
>>>> REST API (I'd have a slight preference for that I think).
>>> 
>>> that's my preference as well, and the REST API should already do that today:
>>> - get list of ISOs of available in a DC (the one the VM is in)
>>> - ability to change the CD of the VM
>> Well, and what about the stop/suspend VM for example, what we have in the menu today?
> 
> supported as well.
> 
>> Also this should be something that the client decide to have or not have?
> 
> I think the client should decide on the features relevant to the client.
> 
>> 
>>> 
>>>> Or do you have anything in mind for the client to get the list of ISOs
>>>> available to the engine?
>>> 
>>> my preference is to provide the data, not the semantics of the menu.
>> We should clarify something here. There are two possibilities who should be responsible for deciding
>> what should the foreign menu contain and also what to do if it the item is selected:
>> 1: the client - e.g. we will not provide any support for the menu in REST because the client reads what needs
>>    and knows how to call the oVirt back
>> 
>> 2: the server side - e.g. we will provide in REST side the menu structure with the description what to do if something is
>>    selected
>> 
>> Both have some advantages and disadvantages but we need to clarify which way to go. So, who is the one responsible to decide
>> what is in the foreign menu (now or in the future) and how to react if something is selected? Client or engine?
> 
> my preference is the client will decide this, as there are various clients to the REST API, and each should decide which features are important for them.

I would agree as long as it is not hardcoded and can be change in some config file easily. We shouldn't wait for next RHEL release to do a little modification if possible.
I think "owning" the menu in some form on RHEV-M side has an advantage of delivery synchronization.


> 
>> 
>>> iiuc, we are on the same page.
>>> 
>>>> 
>>>> Christophe
>>>> 
>>> 
>>> 
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel



From lhornyak at redhat.com  Mon Jun 24 08:15:38 2013
From: lhornyak at redhat.com (Laszlo Hornyak)
Date: Mon, 24 Jun 2013 04:15:38 -0400 (EDT)
Subject: [Engine-devel] checkstyle and tools project
In-Reply-To: <1828878671.21466608.1372061492840.JavaMail.root@redhat.com>
Message-ID: <1953752891.21467773.1372061738295.JavaMail.root@redhat.com>

Hi,

Checkstyle is not executed on tools project. I have sent a patch to gerrit to fix this, could you guys review?

http://gerrit.ovirt.org/15719

And there are some more cleanup patches for tools:
http://gerrit.ovirt.org/15720
http://gerrit.ovirt.org/15721
http://gerrit.ovirt.org/15722


Thank you,
Laszlo


From michal.skrivanek at redhat.com  Mon Jun 24 08:23:36 2013
From: michal.skrivanek at redhat.com (Michal Skrivanek)
Date: Mon, 24 Jun 2013 10:23:36 +0200
Subject: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
In-Reply-To: <51C7FE80.6090405@redhat.com>
References: <501973842.20255318.1371648804880.JavaMail.root@redhat.com>
	<51C1C79F.3050401@redhat.com> <20130620110715.GC2834@teriyaki>
	<51C2E2E1.8030808@redhat.com>
	<936279456.20836092.1371730386788.JavaMail.root@redhat.com>
	<51C2F54C.60409@redhat.com>
	<6609F396-8D78-46FB-9F2D-3700D769B5E9@redhat.com>
	<51C7FE80.6090405@redhat.com>
Message-ID: <AF7617C8-BBCD-41F3-AE74-24319A399AB3@redhat.com>


On Jun 24, 2013, at 10:08 , Itamar Heim <iheim at redhat.com> wrote:

> On 06/24/2013 11:02 AM, Michal Skrivanek wrote:
>> 
>> On Jun 20, 2013, at 14:27 , Itamar Heim <iheim at redhat.com> wrote:
>> 
>>> On 06/20/2013 03:13 PM, Tomas Jelinek wrote:
>>>> 
>>>> 
>>>> ----- Original Message -----
>>>>> From: "Itamar Heim" <iheim at redhat.com>
>>>>> To: "Christophe Fergeau" <cfergeau at redhat.com>
>>>>> Cc: "Tomas Jelinek" <tjelinek at redhat.com>, "engine-devel" <engine-devel at ovirt.org>,
>>>>> spice-devel at lists.freedesktop.org, "Marc-Andr? Lureau" <mlureau at redhat.com>
>>>>> Sent: Thursday, June 20, 2013 1:09:21 PM
>>>>> Subject: Re: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
>>>>> 
>>>>> On 06/20/2013 02:07 PM, Christophe Fergeau wrote:
>>>>>> Hey Itamar,
>>>>>> 
>>>>>> On Wed, Jun 19, 2013 at 06:00:47PM +0300, Itamar Heim wrote:
>>>>>>> On 06/19/2013 04:33 PM, Tomas Jelinek wrote:
>>>>>>>> Hi all,
>>>>>>>> 
>>>>>>>> for the non plugin invocation of the console
>>>>>>>> (http://www.ovirt.org/Features/Non_plugin_console_invocation) the
>>>>>>>> dynamicMenu property is not usable to enrich the SPICE client menu.
>>>>>>>> 
>>>>>>>> This feature is about requesting this menu using oVirt's REST API and
>>>>>>>> than calling it back once some item from this menu has been selected.
>>>>>>>> 
>>>>>>>> The oVirt's feature page with specific details:
>>>>>>>> http://www.ovirt.org/Features/Foreign_Menu_Using_REST
>>>>>>>> 
>>>>>>>> Any comments are more than welcomed.
>>>>>>> 
>>>>>>> Why are we putting the logic of the menu into the REST API?
>>>>>>> can't the menu be builded by client based on getting the list of
>>>>>>> ISO's and current CD?
>>>>>> 
>>>>>> The client needs a way to get the list of available ISOs in order to build
>>>>>> the menu, as well as a way to let the engine know when the user clicked on
>>>>>> an ISO in the menu. One way of doing that is to have the menu stuff exposed
>>>>>> in the REST API. Another way would be to expose the list of ISOs in the
>>>>>> REST API (I'd have a slight preference for that I think).
>>>>> 
>>>>> that's my preference as well, and the REST API should already do that today:
>>>>> - get list of ISOs of available in a DC (the one the VM is in)
>>>>> - ability to change the CD of the VM
>>>> Well, and what about the stop/suspend VM for example, what we have in the menu today?
>>> 
>>> supported as well.
>>> 
>>>> Also this should be something that the client decide to have or not have?
>>> 
>>> I think the client should decide on the features relevant to the client.
>>> 
>>>> 
>>>>> 
>>>>>> Or do you have anything in mind for the client to get the list of ISOs
>>>>>> available to the engine?
>>>>> 
>>>>> my preference is to provide the data, not the semantics of the menu.
>>>> We should clarify something here. There are two possibilities who should be responsible for deciding
>>>> what should the foreign menu contain and also what to do if it the item is selected:
>>>> 1: the client - e.g. we will not provide any support for the menu in REST because the client reads what needs
>>>>    and knows how to call the oVirt back
>>>> 
>>>> 2: the server side - e.g. we will provide in REST side the menu structure with the description what to do if something is
>>>>    selected
>>>> 
>>>> Both have some advantages and disadvantages but we need to clarify which way to go. So, who is the one responsible to decide
>>>> what is in the foreign menu (now or in the future) and how to react if something is selected? Client or engine?
>>> 
>>> my preference is the client will decide this, as there are various clients to the REST API, and each should decide which features are important for them.
>> 
>> I would agree as long as it is not hardcoded and can be change in some config file easily. We shouldn't wait for next RHEL release to do a little modification if possible.
>> I think "owning" the menu in some form on RHEV-M side has an advantage of delivery synchronization.
>> 
> 
> this forces you to maintain backward compatibility in the "Menu API", the client to handle ignoring new features/items in the menu they don't support yet, etc.
> while the *data* which is the important part is already in the stable, backward compatible, API.

i don't think it would be needed. We don't really need much features on spice client side except for displaying and invoking a generic REST call. Items support is based on Engine side if the menu is supplied by Engine side.


> 
>> 
>>> 
>>>> 
>>>>> iiuc, we are on the same page.
>>>>> 
>>>>>> 
>>>>>> Christophe
>>>>>> 
>>>>> 
>>>>> 
>>> 
>>> _______________________________________________
>>> Engine-devel mailing list
>>> Engine-devel at ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>> 
> 



From iheim at redhat.com  Mon Jun 24 08:08:32 2013
From: iheim at redhat.com (Itamar Heim)
Date: Mon, 24 Jun 2013 11:08:32 +0300
Subject: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
In-Reply-To: <6609F396-8D78-46FB-9F2D-3700D769B5E9@redhat.com>
References: <501973842.20255318.1371648804880.JavaMail.root@redhat.com>
	<51C1C79F.3050401@redhat.com> <20130620110715.GC2834@teriyaki>
	<51C2E2E1.8030808@redhat.com>
	<936279456.20836092.1371730386788.JavaMail.root@redhat.com>
	<51C2F54C.60409@redhat.com>
	<6609F396-8D78-46FB-9F2D-3700D769B5E9@redhat.com>
Message-ID: <51C7FE80.6090405@redhat.com>

On 06/24/2013 11:02 AM, Michal Skrivanek wrote:
>
> On Jun 20, 2013, at 14:27 , Itamar Heim <iheim at redhat.com> wrote:
>
>> On 06/20/2013 03:13 PM, Tomas Jelinek wrote:
>>>
>>>
>>> ----- Original Message -----
>>>> From: "Itamar Heim" <iheim at redhat.com>
>>>> To: "Christophe Fergeau" <cfergeau at redhat.com>
>>>> Cc: "Tomas Jelinek" <tjelinek at redhat.com>, "engine-devel" <engine-devel at ovirt.org>,
>>>> spice-devel at lists.freedesktop.org, "Marc-Andr? Lureau" <mlureau at redhat.com>
>>>> Sent: Thursday, June 20, 2013 1:09:21 PM
>>>> Subject: Re: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
>>>>
>>>> On 06/20/2013 02:07 PM, Christophe Fergeau wrote:
>>>>> Hey Itamar,
>>>>>
>>>>> On Wed, Jun 19, 2013 at 06:00:47PM +0300, Itamar Heim wrote:
>>>>>> On 06/19/2013 04:33 PM, Tomas Jelinek wrote:
>>>>>>> Hi all,
>>>>>>>
>>>>>>> for the non plugin invocation of the console
>>>>>>> (http://www.ovirt.org/Features/Non_plugin_console_invocation) the
>>>>>>> dynamicMenu property is not usable to enrich the SPICE client menu.
>>>>>>>
>>>>>>> This feature is about requesting this menu using oVirt's REST API and
>>>>>>> than calling it back once some item from this menu has been selected.
>>>>>>>
>>>>>>> The oVirt's feature page with specific details:
>>>>>>> http://www.ovirt.org/Features/Foreign_Menu_Using_REST
>>>>>>>
>>>>>>> Any comments are more than welcomed.
>>>>>>
>>>>>> Why are we putting the logic of the menu into the REST API?
>>>>>> can't the menu be builded by client based on getting the list of
>>>>>> ISO's and current CD?
>>>>>
>>>>> The client needs a way to get the list of available ISOs in order to build
>>>>> the menu, as well as a way to let the engine know when the user clicked on
>>>>> an ISO in the menu. One way of doing that is to have the menu stuff exposed
>>>>> in the REST API. Another way would be to expose the list of ISOs in the
>>>>> REST API (I'd have a slight preference for that I think).
>>>>
>>>> that's my preference as well, and the REST API should already do that today:
>>>> - get list of ISOs of available in a DC (the one the VM is in)
>>>> - ability to change the CD of the VM
>>> Well, and what about the stop/suspend VM for example, what we have in the menu today?
>>
>> supported as well.
>>
>>> Also this should be something that the client decide to have or not have?
>>
>> I think the client should decide on the features relevant to the client.
>>
>>>
>>>>
>>>>> Or do you have anything in mind for the client to get the list of ISOs
>>>>> available to the engine?
>>>>
>>>> my preference is to provide the data, not the semantics of the menu.
>>> We should clarify something here. There are two possibilities who should be responsible for deciding
>>> what should the foreign menu contain and also what to do if it the item is selected:
>>> 1: the client - e.g. we will not provide any support for the menu in REST because the client reads what needs
>>>     and knows how to call the oVirt back
>>>
>>> 2: the server side - e.g. we will provide in REST side the menu structure with the description what to do if something is
>>>     selected
>>>
>>> Both have some advantages and disadvantages but we need to clarify which way to go. So, who is the one responsible to decide
>>> what is in the foreign menu (now or in the future) and how to react if something is selected? Client or engine?
>>
>> my preference is the client will decide this, as there are various clients to the REST API, and each should decide which features are important for them.
>
> I would agree as long as it is not hardcoded and can be change in some config file easily. We shouldn't wait for next RHEL release to do a little modification if possible.
> I think "owning" the menu in some form on RHEV-M side has an advantage of delivery synchronization.
>

this forces you to maintain backward compatibility in the "Menu API", 
the client to handle ignoring new features/items in the menu they don't 
support yet, etc.
while the *data* which is the important part is already in the stable, 
backward compatible, API.

>
>>
>>>
>>>> iiuc, we are on the same page.
>>>>
>>>>>
>>>>> Christophe
>>>>>
>>>>
>>>>
>>
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>



From wlbleaboy at 126.com  Mon Jun 24 09:34:33 2013
From: wlbleaboy at 126.com (wlbleaboy@126)
Date: Mon, 24 Jun 2013 17:34:33 +0800
Subject: [Engine-devel] ovirt-engine-sdk
Message-ID: <056101ce70be$09e78cb0$1db6a610$@com>

Hi, all:

         I found when I connect to ovirt-engine via ovirt-engine-sdk is
slowly

than connect to engine via UserPortal, could anyone explain the reason. 

 

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130624/44077934/attachment.html>

From cfergeau at redhat.com  Mon Jun 24 09:47:36 2013
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Mon, 24 Jun 2013 11:47:36 +0200
Subject: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
In-Reply-To: <6609F396-8D78-46FB-9F2D-3700D769B5E9@redhat.com>
References: <501973842.20255318.1371648804880.JavaMail.root@redhat.com>
	<51C1C79F.3050401@redhat.com> <20130620110715.GC2834@teriyaki>
	<51C2E2E1.8030808@redhat.com>
	<936279456.20836092.1371730386788.JavaMail.root@redhat.com>
	<51C2F54C.60409@redhat.com>
	<6609F396-8D78-46FB-9F2D-3700D769B5E9@redhat.com>
Message-ID: <20130624094735.GC1849@teriyaki.cdg.redhat.com>

On Mon, Jun 24, 2013 at 10:02:29AM +0200, Michal Skrivanek wrote:
> I would agree as long as it is not hardcoded and can be change in some
> config file easily. We shouldn't wait for next RHEL release to do a
> little modification if possible.
> I think "owning" the menu in some form on RHEV-M side has an advantage of
> delivery synchronization.

This probably would also make things harder from a client documentation
point of view. With something too generic, there's also always the risk
that it becomes a way to add workaround for bugs, or that the menu starts
containing things that would be better integrated in other places in the
client, ...

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130624/a03d4a0e/attachment.sig>

From gvallare at redhat.com  Mon Jun 24 12:07:16 2013
From: gvallare at redhat.com (Giuseppe Vallarelli)
Date: Mon, 24 Jun 2013 08:07:16 -0400 (EDT)
Subject: [Engine-devel] VNic QoS measure units and attributes.
In-Reply-To: <238152991.6722629.1372074351415.JavaMail.root@redhat.com>
Message-ID: <907004221.6733783.1372075636000.JavaMail.root@redhat.com>

Hi Ofri, I've been reading your design page for this feature [1] and and I've found out
that there's a possible unit of measure mismatch regarding: Average, Burst and Peak, clearly
makes sense to use Mbps on the gui but I wonder if you're aware that the vdsm api expects
respectivly: kB/sec, kB and kB/sec (for average, burst and peak), so a conversion is needed.
As a side note the only compulsory attribute needed to define QoS for incoming and outgoing
traffic is average, burst and peak are optional (see [2]), this is not clear by looking
at the mockups and description.

Cheers, Giuseppe

[1] http://www.ovirt.org/Features/Network_QoS
[2] http://libvirt.org/formatdomain.html#elementQoS




From mpastern at redhat.com  Mon Jun 24 13:42:12 2013
From: mpastern at redhat.com (Michael Pasternak)
Date: Mon, 24 Jun 2013 16:42:12 +0300
Subject: [Engine-devel] ovirt-engine-sdk
In-Reply-To: <056101ce70be$09e78cb0$1db6a610$@com>
References: <056101ce70be$09e78cb0$1db6a610$@com>
Message-ID: <51C84CB4.5010402@redhat.com>

On 06/24/2013 12:34 PM, wlbleaboy at 126 wrote:
> Hi, all:
> 
>          I found when I connect to ovirt-engine via ovirt-engine-sdk is slowly
> 
> than connect to engine via UserPortal, could anyone explain the reason.

- what do you mean by saying "connect to ovirt-engine via ovirt-engine-sdk"?
- you comparing two different things, sdk != userportal

> 
>  
> 
>  
> 
> 
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


-- 

Michael Pasternak
RedHat, ENG-Virtualization R&D


From eedri at redhat.com  Mon Jun 24 14:28:44 2013
From: eedri at redhat.com (Eyal Edri)
Date: Mon, 24 Jun 2013 10:28:44 -0400 (EDT)
Subject: [Engine-devel] checkstyle and tools project
In-Reply-To: <1953752891.21467773.1372061738295.JavaMail.root@redhat.com>
References: <1953752891.21467773.1372061738295.JavaMail.root@redhat.com>
Message-ID: <403026039.1549075.1372084124864.JavaMail.root@redhat.com>

Can we add a gerrit hook to run checkstyle on the code?
rather than waiting it to be merged and fail on jenkins? 

----- Original Message -----
> From: "Laszlo Hornyak" <lhornyak at redhat.com>
> To: "engine-devel" <engine-devel at ovirt.org>
> Sent: Monday, June 24, 2013 11:15:38 AM
> Subject: [Engine-devel] checkstyle and tools project
> 
> Hi,
> 
> Checkstyle is not executed on tools project. I have sent a patch to gerrit to
> fix this, could you guys review?
> 
> http://gerrit.ovirt.org/15719
> 
> And there are some more cleanup patches for tools:
> http://gerrit.ovirt.org/15720
> http://gerrit.ovirt.org/15721
> http://gerrit.ovirt.org/15722
> 
> 
> Thank you,
> Laszlo
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From lhornyak at redhat.com  Mon Jun 24 14:42:29 2013
From: lhornyak at redhat.com (Laszlo Hornyak)
Date: Mon, 24 Jun 2013 10:42:29 -0400 (EDT)
Subject: [Engine-devel] checkstyle and tools project
In-Reply-To: <403026039.1549075.1372084124864.JavaMail.root@redhat.com>
References: <1953752891.21467773.1372061738295.JavaMail.root@redhat.com>
	<403026039.1549075.1372084124864.JavaMail.root@redhat.com>
Message-ID: <1273530280.21663523.1372084949963.JavaMail.root@redhat.com>

Hi Eyal,

Without the patch checkstyle will fail, there are some violations.
But Yair ACKed the patchset, I will rebase and check it over again and merge, should be ready ~today~.


----- Original Message -----
> From: "Eyal Edri" <eedri at redhat.com>
> To: "Laszlo Hornyak" <lhornyak at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>, "infra" <infra at ovirt.org>
> Sent: Monday, June 24, 2013 4:28:44 PM
> Subject: Re: [Engine-devel] checkstyle and tools project
> 
> Can we add a gerrit hook to run checkstyle on the code?
> rather than waiting it to be merged and fail on jenkins?
> 
> ----- Original Message -----
> > From: "Laszlo Hornyak" <lhornyak at redhat.com>
> > To: "engine-devel" <engine-devel at ovirt.org>
> > Sent: Monday, June 24, 2013 11:15:38 AM
> > Subject: [Engine-devel] checkstyle and tools project
> > 
> > Hi,
> > 
> > Checkstyle is not executed on tools project. I have sent a patch to gerrit
> > to
> > fix this, could you guys review?
> > 
> > http://gerrit.ovirt.org/15719
> > 
> > And there are some more cleanup patches for tools:
> > http://gerrit.ovirt.org/15720
> > http://gerrit.ovirt.org/15721
> > http://gerrit.ovirt.org/15722
> > 
> > 
> > Thank you,
> > Laszlo
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> 


From eedri at redhat.com  Mon Jun 24 15:47:59 2013
From: eedri at redhat.com (Eyal Edri)
Date: Mon, 24 Jun 2013 11:47:59 -0400 (EDT)
Subject: [Engine-devel] unit tests failing
In-Reply-To: <564662380.1586151.1372088665013.JavaMail.root@redhat.com>
Message-ID: <1608656683.1587727.1372088879862.JavaMail.root@redhat.com>

fyi,

there are 11 unit tests failing on engine:
http://jenkins.ovirt.org/view/ovirt_engine/job/ovirt_engine_unit_tests/4398/

starting from these builds:
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/4398/
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/4411/#showFailuresLink


please check/fix.

Eyal.


From lpeer at redhat.com  Mon Jun 24 16:31:43 2013
From: lpeer at redhat.com (Livnat Peer)
Date: Mon, 24 Jun 2013 19:31:43 +0300
Subject: [Engine-devel] VNic QoS measure units and attributes.
In-Reply-To: <907004221.6733783.1372075636000.JavaMail.root@redhat.com>
References: <907004221.6733783.1372075636000.JavaMail.root@redhat.com>
Message-ID: <51C8746F.4030704@redhat.com>

On 06/24/2013 03:07 PM, Giuseppe Vallarelli wrote:
> Hi Ofri, I've been reading your design page for this feature [1] and and I've found out
> that there's a possible unit of measure mismatch regarding: Average, Burst and Peak, clearly
> makes sense to use Mbps on the gui but I wonder if you're aware that the vdsm api expects
> respectivly: kB/sec, kB and kB/sec (for average, burst and peak), so a conversion is needed.
> As a side note the only compulsory attribute needed to define QoS for incoming and outgoing
> traffic is average, burst and peak are optional (see [2]), this is not clear by looking
> at the mockups and description.
> 
> Cheers, Giuseppe
> 

Hi Giuseppe,
Do you know why VDSM API exposes KB/Sec? don't you think that Mbps is
more intuitive?


Livnat

> [1] http://www.ovirt.org/Features/Network_QoS
> [2] http://libvirt.org/formatdomain.html#elementQoS
> 
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
> 



From alonbl at redhat.com  Mon Jun 24 17:54:17 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Mon, 24 Jun 2013 13:54:17 -0400 (EDT)
Subject: [Engine-devel] unit tests failing
In-Reply-To: <1608656683.1587727.1372088879862.JavaMail.root@redhat.com>
References: <1608656683.1587727.1372088879862.JavaMail.root@redhat.com>
Message-ID: <1542726415.11894633.1372096457948.JavaMail.root@redhat.com>


RestAPI Branding initialization should be solved by[1]
Most of [2], but there are some more issues.

[1] http://gerrit.ovirt.org/#/c/16046/
[2] http://jenkins.ovirt.org/view/ovirt_engine/job/ovirt_engine_unit_tests/4398/org.ovirt.engine.api$restapi-jaxrs/testReport/org.ovirt.engine.api.restapi.resource/

----- Original Message -----
> From: "Eyal Edri" <eedri at redhat.com>
> To: "engine-devel" <engine-devel at ovirt.org>, "Alon Bar-Lev" <alonbl at redhat.com>, "Yair Zaslavsky"
> <yzaslavs at redhat.com>, "Liran Zelkha" <lzelkha at redhat.com>
> Sent: Monday, June 24, 2013 6:47:59 PM
> Subject: unit tests failing
> 
> fyi,
> 
> there are 11 unit tests failing on engine:
> http://jenkins.ovirt.org/view/ovirt_engine/job/ovirt_engine_unit_tests/4398/
> 
> starting from these builds:
> http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/4398/
> http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/4411/#showFailuresLink
> 
> 
> please check/fix.
> 
> Eyal.
> 


From gvallare at redhat.com  Mon Jun 24 18:22:59 2013
From: gvallare at redhat.com (Giuseppe Vallarelli)
Date: Mon, 24 Jun 2013 14:22:59 -0400 (EDT)
Subject: [Engine-devel] VNic QoS measure units and attributes.
In-Reply-To: <51C8746F.4030704@redhat.com>
References: <907004221.6733783.1372075636000.JavaMail.root@redhat.com>
	<51C8746F.4030704@redhat.com>
Message-ID: <932719585.7046951.1372098179197.JavaMail.root@redhat.com>

----- Original Message -----
| From: "Livnat Peer" <lpeer at redhat.com>
| To: "Giuseppe Vallarelli" <gvallare at redhat.com>
| Cc: engine-devel at ovirt.org
| Sent: Monday, June 24, 2013 6:31:43 PM
| Subject: Re: [Engine-devel] VNic QoS measure units and attributes.
| 
| On 06/24/2013 03:07 PM, Giuseppe Vallarelli wrote:
| > Hi Ofri, I've been reading your design page for this feature [1] and and
| > I've found out
| > that there's a possible unit of measure mismatch regarding: Average, Burst
| > and Peak, clearly
| > makes sense to use Mbps on the gui but I wonder if you're aware that the
| > vdsm api expects
| > respectivly: kB/sec, kB and kB/sec (for average, burst and peak), so a
| > conversion is needed.
| > As a side note the only compulsory attribute needed to define QoS for
| > incoming and outgoing
| > traffic is average, burst and peak are optional (see [2]), this is not
| > clear by looking
| > at the mockups and description.
| > 
| > Cheers, Giuseppe
| > 
| 
| Hi Giuseppe,
| Do you know why VDSM API exposes KB/Sec? don't you think that Mbps is
| more intuitive?

Hi Livnat, I made this choice because libvirt uses those unit of measure
and I considered vdsm to be almost at the same (low) level. This part of
the API has been already implemented/documented and discussed in a
previous thread [1]. I agree that Mbps is much more intuitive for the
end user. We can decide where we should make the conversion, if at the
engine level or in vdsm. I'm fine with both choices.

Cheers Giuseppe.


[1] Add traffic shaping parameters for a network interface.

| 
| 
| Livnat
| 
| > [1] http://www.ovirt.org/Features/Network_QoS
| > [2] http://libvirt.org/formatdomain.html#elementQoS
| > 
| > 
| > _______________________________________________
| > Engine-devel mailing list
| > Engine-devel at ovirt.org
| > http://lists.ovirt.org/mailman/listinfo/engine-devel
| > 
| > 


From iheim at redhat.com  Mon Jun 24 18:57:02 2013
From: iheim at redhat.com (Itamar Heim)
Date: Mon, 24 Jun 2013 21:57:02 +0300
Subject: [Engine-devel] checkstyle and tools project
In-Reply-To: <403026039.1549075.1372084124864.JavaMail.root@redhat.com>
References: <1953752891.21467773.1372061738295.JavaMail.root@redhat.com>
	<403026039.1549075.1372084124864.JavaMail.root@redhat.com>
Message-ID: <51C8967E.4090500@redhat.com>

On 06/24/2013 05:28 PM, Eyal Edri wrote:
> Can we add a gerrit hook to run checkstyle on the code?

i wouldn't want gerrit to build, but can we add this to jenkins job?

> rather than waiting it to be merged and fail on jenkins?
>
> ----- Original Message -----
>> From: "Laszlo Hornyak" <lhornyak at redhat.com>
>> To: "engine-devel" <engine-devel at ovirt.org>
>> Sent: Monday, June 24, 2013 11:15:38 AM
>> Subject: [Engine-devel] checkstyle and tools project
>>
>> Hi,
>>
>> Checkstyle is not executed on tools project. I have sent a patch to gerrit to
>> fix this, could you guys review?
>>
>> http://gerrit.ovirt.org/15719
>>
>> And there are some more cleanup patches for tools:
>> http://gerrit.ovirt.org/15720
>> http://gerrit.ovirt.org/15721
>> http://gerrit.ovirt.org/15722
>>
>>
>> Thank you,
>> Laszlo
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>



From eedri at redhat.com  Mon Jun 24 19:35:47 2013
From: eedri at redhat.com (Eyal Edri)
Date: Mon, 24 Jun 2013 15:35:47 -0400 (EDT)
Subject: [Engine-devel] checkstyle and tools project
In-Reply-To: <51C8967E.4090500@redhat.com>
References: <1953752891.21467773.1372061738295.JavaMail.root@redhat.com>
	<403026039.1549075.1372084124864.JavaMail.root@redhat.com>
	<51C8967E.4090500@redhat.com>
Message-ID: <1695138819.1709163.1372102547418.JavaMail.root@redhat.com>

i believe it's running by default every time you run mvn compile (or install),
so actually findbugs job will catch checkstyle errors too. (i.e fail to compile)

----- Original Message -----
> From: "Itamar Heim" <iheim at redhat.com>
> To: "Eyal Edri" <eedri at redhat.com>
> Cc: "Laszlo Hornyak" <lhornyak at redhat.com>, "engine-devel" <engine-devel at ovirt.org>, "infra" <infra at ovirt.org>
> Sent: Monday, June 24, 2013 9:57:02 PM
> Subject: Re: [Engine-devel] checkstyle and tools project
> 
> On 06/24/2013 05:28 PM, Eyal Edri wrote:
> > Can we add a gerrit hook to run checkstyle on the code?
> 
> i wouldn't want gerrit to build, but can we add this to jenkins job?
> 
> > rather than waiting it to be merged and fail on jenkins?
> >
> > ----- Original Message -----
> >> From: "Laszlo Hornyak" <lhornyak at redhat.com>
> >> To: "engine-devel" <engine-devel at ovirt.org>
> >> Sent: Monday, June 24, 2013 11:15:38 AM
> >> Subject: [Engine-devel] checkstyle and tools project
> >>
> >> Hi,
> >>
> >> Checkstyle is not executed on tools project. I have sent a patch to gerrit
> >> to
> >> fix this, could you guys review?
> >>
> >> http://gerrit.ovirt.org/15719
> >>
> >> And there are some more cleanup patches for tools:
> >> http://gerrit.ovirt.org/15720
> >> http://gerrit.ovirt.org/15721
> >> http://gerrit.ovirt.org/15722
> >>
> >>
> >> Thank you,
> >> Laszlo
> >> _______________________________________________
> >> Engine-devel mailing list
> >> Engine-devel at ovirt.org
> >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> >>
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> >
> 
> 


From deadhorseconsulting at gmail.com  Mon Jun 24 23:46:13 2013
From: deadhorseconsulting at gmail.com (Dead Horse)
Date: Mon, 24 Jun 2013 18:46:13 -0500
Subject: [Engine-devel] Console broken with current master vmSetTicket
	error
In-Reply-To: <49EBCD45-0CB4-4837-8730-FD3375674BFA@redhat.com>
References: <CAEWPe=p6a8Vgkf_wBN19rhtGR5yu+=KduV4RYF5RmVdNnuT4QA@mail.gmail.com>
	<49EBCD45-0CB4-4837-8730-FD3375674BFA@redhat.com>
Message-ID: <CAEWPe=qfWwwfXS-farZQPgQ3Vgmi3SE8XVUODscedOrGC9rqng@mail.gmail.com>

libvirt-python-0.10.2-18.0.1.el6_4.8.x86_64
libvirt-client-0.10.2-18.0.1.el6_4.8.x86_64
libvirt-java-0.4.9-1.el6.noarch
libvirt-0.10.2-18.0.1.el6_4.8.x86_64
libvirt-java-devel-0.4.9-1.el6.noarch
libvirt-lock-sanlock-0.10.2-18.0.1.el6_4.8.x86_64
libvirt-devel-0.10.2-18.0.1.el6_4.8.x86_64

libvirtd log attached.

- DHC


On Sun, Jun 23, 2013 at 2:00 AM, Michal Skrivanek <
michal.skrivanek at redhat.com> wrote:

> Hi,
> libvirt version?
> perhaps libvirt log as well
>
> Thanks,
> michal
>
> On Jun 22, 2013, at 04:05 , Dead Horse <deadhorseconsulting at gmail.com>
> wrote:
>
> > When the console button is clicked in the webadmin or userportal (engine
> and vdsm built from the latest master) the follow error message is returned:
> >
> > "Error while executing action SetVmTicket: Unexpected exception"
> >
> > This occurs with latest master engine and vdsm built as of today.
> >
> > engine and vdsm logs of failure attached.
> >
> > - DHC
> > <engine.log><vdsm.log>_______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130624/ef10265e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libvirtd.log
Type: application/octet-stream
Size: 120068 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130624/ef10265e/attachment.obj>

From wlbleaboy at 126.com  Tue Jun 25 01:23:07 2013
From: wlbleaboy at 126.com (wlbleaboy@126)
Date: Tue, 25 Jun 2013 09:23:07 +0800
Subject: [Engine-devel] ovirt-engine-sdk
In-Reply-To: <51C84CB4.5010402@redhat.com>
References: <056101ce70be$09e78cb0$1db6a610$@com> <51C84CB4.5010402@redhat.com>
Message-ID: <059001ce7142$8d3c1bb0$a7b45310$@com>

"connect to ovirt-engine via ovirt-engine-sdk" is using sdk like this:

Api = API('https://{ovirt-engine}', 'user at domain', 'password',  None, None,
'ca.crt', filter=True)

this function running more than 10 seconds.

And Userportal is faster than it.

-----Original Message-----
From: Michael Pasternak [mailto:mpastern at redhat.com] 
Sent: Monday, June 24, 2013 9:42 PM
To: wlbleaboy at 126
Cc: engine-devel at ovirt.org
Subject: Re: [Engine-devel] ovirt-engine-sdk

On 06/24/2013 12:34 PM, wlbleaboy at 126 wrote:
> Hi, all:
> 
>          I found when I connect to ovirt-engine via ovirt-engine-sdk is
slowly
> 
> than connect to engine via UserPortal, could anyone explain the reason.

- what do you mean by saying "connect to ovirt-engine via ovirt-engine-sdk"?
- you comparing two different things, sdk != userportal

> 
>  
> 
>  
> 
> 
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


-- 

Michael Pasternak
RedHat, ENG-Virtualization R&D




From omasad at redhat.com  Tue Jun 25 06:19:30 2013
From: omasad at redhat.com (Ofri Masad)
Date: Tue, 25 Jun 2013 02:19:30 -0400 (EDT)
Subject: [Engine-devel] VNic QoS measure units and attributes.
In-Reply-To: <932719585.7046951.1372098179197.JavaMail.root@redhat.com>
References: <907004221.6733783.1372075636000.JavaMail.root@redhat.com>
	<51C8746F.4030704@redhat.com>
	<932719585.7046951.1372098179197.JavaMail.root@redhat.com>
Message-ID: <1824829735.12044887.1372141170852.JavaMail.root@redhat.com>

Hi Giuseppe,

Thanks for the review. I am aware of the need to add conversion of units in the engine.
As for the mandatory fields - we decided to make all 6 fields mandatory to the engine users (we know libvirt does not enforce this).
Leaving some fields empty may cause some ambiguity since libvirt is filling the remaining fields by it self. 
for example: if libvirt implementation will change in future releases, the user may get different peak and burst values without even knowing about it. 

thank again
Ofri 

----- Original Message -----
> From: "Giuseppe Vallarelli" <gvallare at redhat.com>
> To: "Livnat Peer" <lpeer at redhat.com>
> Cc: engine-devel at ovirt.org
> Sent: Monday, June 24, 2013 9:22:59 PM
> Subject: Re: [Engine-devel] VNic QoS measure units and attributes.
> 
> ----- Original Message -----
> | From: "Livnat Peer" <lpeer at redhat.com>
> | To: "Giuseppe Vallarelli" <gvallare at redhat.com>
> | Cc: engine-devel at ovirt.org
> | Sent: Monday, June 24, 2013 6:31:43 PM
> | Subject: Re: [Engine-devel] VNic QoS measure units and attributes.
> | 
> | On 06/24/2013 03:07 PM, Giuseppe Vallarelli wrote:
> | > Hi Ofri, I've been reading your design page for this feature [1] and and
> | > I've found out
> | > that there's a possible unit of measure mismatch regarding: Average,
> | > Burst
> | > and Peak, clearly
> | > makes sense to use Mbps on the gui but I wonder if you're aware that the
> | > vdsm api expects
> | > respectivly: kB/sec, kB and kB/sec (for average, burst and peak), so a
> | > conversion is needed.
> | > As a side note the only compulsory attribute needed to define QoS for
> | > incoming and outgoing
> | > traffic is average, burst and peak are optional (see [2]), this is not
> | > clear by looking
> | > at the mockups and description.
> | > 
> | > Cheers, Giuseppe
> | > 
> | 
> | Hi Giuseppe,
> | Do you know why VDSM API exposes KB/Sec? don't you think that Mbps is
> | more intuitive?
> 
> Hi Livnat, I made this choice because libvirt uses those unit of measure
> and I considered vdsm to be almost at the same (low) level. This part of
> the API has been already implemented/documented and discussed in a
> previous thread [1]. I agree that Mbps is much more intuitive for the
> end user. We can decide where we should make the conversion, if at the
> engine level or in vdsm. I'm fine with both choices.
> 
> Cheers Giuseppe.
> 
> 
> [1] Add traffic shaping parameters for a network interface.
> 
> | 
> | 
> | Livnat
> | 
> | > [1] http://www.ovirt.org/Features/Network_QoS
> | > [2] http://libvirt.org/formatdomain.html#elementQoS
> | > 
> | > 
> | > _______________________________________________
> | > Engine-devel mailing list
> | > Engine-devel at ovirt.org
> | > http://lists.ovirt.org/mailman/listinfo/engine-devel
> | > 
> | > 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From michal.skrivanek at redhat.com  Tue Jun 25 06:33:33 2013
From: michal.skrivanek at redhat.com (Michal Skrivanek)
Date: Tue, 25 Jun 2013 08:33:33 +0200
Subject: [Engine-devel] Fwd: Console broken with current master vmSetTicket
	error
References: <CAEWPe=qfWwwfXS-farZQPgQ3Vgmi3SE8XVUODscedOrGC9rqng@mail.gmail.com>
Message-ID: <C2D805B6-1102-43BF-ABC0-97D87776833C@redhat.com>

Hi,
looks like some libvirt issue, can anyone please take a look?

We create the VM via RHEV-M with:

<graphics autoport="yes" keymap="en-us" passwd="*****" passwdValidTo="1970-01-01T00:00:01" port="-1" tlsPort="-1" type="spice">
			<listen network="vdsm-twistingnether" type="network"/>
</graphics>

and the corresponding QEMU line then contains:

-spice port=5900,addr=3.70.204.31,seamless-migration=on 

but then when we want to update the passwd later using:

<graphics autoport="yes" connected="disconnect" keymap="en-us" passwd="mUgwGKKUhc+Z" passwdValidTo="2013-06-24T23:41:39" port="5900" type="spice">
      <listen address="3.70.204.31" network="vdsm-twistingnether" type="network"/>
</graphics>

it actually fails with:

2013-06-24 23:39:39.929+0000: 3499: error : qemuDomainChangeGraphics:1804 : internal error cannot change listen address setting on spice graphics

We didn't change anything on RHEV-M side and the IP is the same?so is there any change in libvirt in this regard? Details below

Thanks a lot,
michal

Begin forwarded message:

> From: Dead Horse <deadhorseconsulting at gmail.com>
> Subject: Re: [Engine-devel] Console broken with current master vmSetTicket error
> Date: June 25, 2013 01:46:13 GMT+02:00
> To: Michal Skrivanek <michal.skrivanek at redhat.com>
> Cc: engine-devel <engine-devel at ovirt.org>
> 
> libvirt-python-0.10.2-18.0.1.el6_4.8.x86_64
> libvirt-client-0.10.2-18.0.1.el6_4.8.x86_64
> libvirt-java-0.4.9-1.el6.noarch
> libvirt-0.10.2-18.0.1.el6_4.8.x86_64
> libvirt-java-devel-0.4.9-1.el6.noarch
> libvirt-lock-sanlock-0.10.2-18.0.1.el6_4.8.x86_64
> libvirt-devel-0.10.2-18.0.1.el6_4.8.x86_64
> 
> libvirtd log attached.
> 
> - DHC
> 
> 
> On Sun, Jun 23, 2013 at 2:00 AM, Michal Skrivanek <michal.skrivanek at redhat.com> wrote:
> Hi,
> libvirt version?
> perhaps libvirt log as well
> 
> Thanks,
> michal
> 
> On Jun 22, 2013, at 04:05 , Dead Horse <deadhorseconsulting at gmail.com> wrote:
> 
> > When the console button is clicked in the webadmin or userportal (engine and vdsm built from the latest master) the follow error message is returned:
> >
> > "Error while executing action SetVmTicket: Unexpected exception"
> >
> > This occurs with latest master engine and vdsm built as of today.
> >
> > engine and vdsm logs of failure attached.
> >
> > - DHC
> > <engine.log><vdsm.log>_______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130625/1385c069/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libvirtd.log
Type: application/octet-stream
Size: 120069 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130625/1385c069/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130625/1385c069/attachment-0001.html>

From gvallare at redhat.com  Tue Jun 25 08:30:33 2013
From: gvallare at redhat.com (Giuseppe Vallarelli)
Date: Tue, 25 Jun 2013 04:30:33 -0400 (EDT)
Subject: [Engine-devel] VNic QoS measure units and attributes.
In-Reply-To: <1824829735.12044887.1372141170852.JavaMail.root@redhat.com>
References: <907004221.6733783.1372075636000.JavaMail.root@redhat.com>
	<51C8746F.4030704@redhat.com>
	<932719585.7046951.1372098179197.JavaMail.root@redhat.com>
	<1824829735.12044887.1372141170852.JavaMail.root@redhat.com>
Message-ID: <1937342506.7340686.1372149033726.JavaMail.root@redhat.com>

----- Original Message -----
| From: "Ofri Masad" <omasad at redhat.com>
| To: "Giuseppe Vallarelli" <gvallare at redhat.com>
| Cc: "Livnat Peer" <lpeer at redhat.com>, engine-devel at ovirt.org
| Sent: Tuesday, June 25, 2013 8:19:30 AM
| Subject: Re: [Engine-devel] VNic QoS measure units and attributes.
| 
| Hi Giuseppe,
| 
| Thanks for the review. I am aware of the need to add conversion of units in
| the engine.
| As for the mandatory fields - we decided to make all 6 fields mandatory to
| the engine users (we know libvirt does not enforce this).
| Leaving some fields empty may cause some ambiguity since libvirt is filling
| the remaining fields by it self.
| for example: if libvirt implementation will change in future releases, the
| user may get different peak and burst values without even knowing about it.

I see, in this case your choice makes perfect sense, Thanks for sharing.

Giuseppe

| 
| thank again
| Ofri
| 
| ----- Original Message -----
| > From: "Giuseppe Vallarelli" <gvallare at redhat.com>
| > To: "Livnat Peer" <lpeer at redhat.com>
| > Cc: engine-devel at ovirt.org
| > Sent: Monday, June 24, 2013 9:22:59 PM
| > Subject: Re: [Engine-devel] VNic QoS measure units and attributes.
| > 
| > ----- Original Message -----
| > | From: "Livnat Peer" <lpeer at redhat.com>
| > | To: "Giuseppe Vallarelli" <gvallare at redhat.com>
| > | Cc: engine-devel at ovirt.org
| > | Sent: Monday, June 24, 2013 6:31:43 PM
| > | Subject: Re: [Engine-devel] VNic QoS measure units and attributes.
| > | 
| > | On 06/24/2013 03:07 PM, Giuseppe Vallarelli wrote:
| > | > Hi Ofri, I've been reading your design page for this feature [1] and
| > | > and
| > | > I've found out
| > | > that there's a possible unit of measure mismatch regarding: Average,
| > | > Burst
| > | > and Peak, clearly
| > | > makes sense to use Mbps on the gui but I wonder if you're aware that
| > | > the
| > | > vdsm api expects
| > | > respectivly: kB/sec, kB and kB/sec (for average, burst and peak), so a
| > | > conversion is needed.
| > | > As a side note the only compulsory attribute needed to define QoS for
| > | > incoming and outgoing
| > | > traffic is average, burst and peak are optional (see [2]), this is not
| > | > clear by looking
| > | > at the mockups and description.
| > | > 
| > | > Cheers, Giuseppe
| > | > 
| > | 
| > | Hi Giuseppe,
| > | Do you know why VDSM API exposes KB/Sec? don't you think that Mbps is
| > | more intuitive?
| > 
| > Hi Livnat, I made this choice because libvirt uses those unit of measure
| > and I considered vdsm to be almost at the same (low) level. This part of
| > the API has been already implemented/documented and discussed in a
| > previous thread [1]. I agree that Mbps is much more intuitive for the
| > end user. We can decide where we should make the conversion, if at the
| > engine level or in vdsm. I'm fine with both choices.
| > 
| > Cheers Giuseppe.
| > 
| > 
| > [1] Add traffic shaping parameters for a network interface.
| > 
| > | 
| > | 
| > | Livnat
| > | 
| > | > [1] http://www.ovirt.org/Features/Network_QoS
| > | > [2] http://libvirt.org/formatdomain.html#elementQoS
| > | > 
| > | > 
| > | > _______________________________________________
| > | > Engine-devel mailing list
| > | > Engine-devel at ovirt.org
| > | > http://lists.ovirt.org/mailman/listinfo/engine-devel
| > | > 
| > | > 
| > _______________________________________________
| > Engine-devel mailing list
| > Engine-devel at ovirt.org
| > http://lists.ovirt.org/mailman/listinfo/engine-devel
| > 
| 


From mpastern at redhat.com  Tue Jun 25 09:14:14 2013
From: mpastern at redhat.com (Michael Pasternak)
Date: Tue, 25 Jun 2013 12:14:14 +0300
Subject: [Engine-devel] ovirt-engine-sdk
In-Reply-To: <059001ce7142$8d3c1bb0$a7b45310$@com>
References: <056101ce70be$09e78cb0$1db6a610$@com> <51C84CB4.5010402@redhat.com>
	<059001ce7142$8d3c1bb0$a7b45310$@com>
Message-ID: <51C95F66.2050602@redhat.com>

On 06/25/2013 04:23 AM, wlbleaboy at 126 wrote:
> "connect to ovirt-engine via ovirt-engine-sdk" is using sdk like this:
> 
> Api = API('https://{ovirt-engine}', 'user at domain', 'password',  None, None,
> 'ca.crt', filter=True)
> 
> this function running more than 10 seconds.

this is very odd,

1. please run GET query with curl against a /api and see how much time it takes to get a response?
2. what is the machine that you running your sdk code at? the ovirt-engine machine?
3. please check CPU, I/O, memory load on the machine where your sdk code runs
4. please add debug=True to API() initialization and send me the output

> 
> And Userportal is faster than it.

sdk is not the same as UserPortal, it runs on a different platform,
uses different technology to communicate with the server, on initialization it creates a pool
of connections to be used + verifying ca cert + maps python<->xml at runtime, etc.,
but any of these should not be time consuming in a way you describing.

> 
> -----Original Message-----
> From: Michael Pasternak [mailto:mpastern at redhat.com] 
> Sent: Monday, June 24, 2013 9:42 PM
> To: wlbleaboy at 126
> Cc: engine-devel at ovirt.org
> Subject: Re: [Engine-devel] ovirt-engine-sdk
> 
> On 06/24/2013 12:34 PM, wlbleaboy at 126 wrote:
>> Hi, all:
>>
>>          I found when I connect to ovirt-engine via ovirt-engine-sdk is
> slowly
>>
>> than connect to engine via UserPortal, could anyone explain the reason.
> 
> - what do you mean by saying "connect to ovirt-engine via ovirt-engine-sdk"?
> - you comparing two different things, sdk != userportal
> 
>>
>>  
>>
>>  
>>
>>
>>
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>
> 
> 


-- 

Michael Pasternak
RedHat, ENG-Virtualization R&D


From amureini at redhat.com  Tue Jun 25 11:20:16 2013
From: amureini at redhat.com (Allon Mureinik)
Date: Tue, 25 Jun 2013 07:20:16 -0400 (EDT)
Subject: [Engine-devel] checkstyle and tools project
In-Reply-To: <403026039.1549075.1372084124864.JavaMail.root@redhat.com>
References: <1953752891.21467773.1372061738295.JavaMail.root@redhat.com>
	<403026039.1549075.1372084124864.JavaMail.root@redhat.com>
Message-ID: <2021886483.1987240.1372159216871.JavaMail.root@redhat.com>

checkstyle runs as part of a compile phase in mvn.
as long as you build your code before submitting it to gerrit you should be scott-free.

----- Original Message -----
> From: "Eyal Edri" <eedri at redhat.com>
> To: "Laszlo Hornyak" <lhornyak at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>, "infra" <infra at ovirt.org>
> Sent: Monday, June 24, 2013 5:28:44 PM
> Subject: Re: [Engine-devel] checkstyle and tools project
> 
> Can we add a gerrit hook to run checkstyle on the code?
> rather than waiting it to be merged and fail on jenkins?
> 
> ----- Original Message -----
> > From: "Laszlo Hornyak" <lhornyak at redhat.com>
> > To: "engine-devel" <engine-devel at ovirt.org>
> > Sent: Monday, June 24, 2013 11:15:38 AM
> > Subject: [Engine-devel] checkstyle and tools project
> > 
> > Hi,
> > 
> > Checkstyle is not executed on tools project. I have sent a patch to gerrit
> > to
> > fix this, could you guys review?
> > 
> > http://gerrit.ovirt.org/15719
> > 
> > And there are some more cleanup patches for tools:
> > http://gerrit.ovirt.org/15720
> > http://gerrit.ovirt.org/15721
> > http://gerrit.ovirt.org/15722
> > 
> > 
> > Thank you,
> > Laszlo
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From mpastern at redhat.com  Tue Jun 25 14:53:32 2013
From: mpastern at redhat.com (Michael Pasternak)
Date: Tue, 25 Jun 2013 17:53:32 +0300
Subject: [Engine-devel] ovirt-engine-sdk-java 1.0.0.8-1 released
In-Reply-To: <51ADEB43.8090908@redhat.com>
References: <51ADEB43.8090908@redhat.com>
Message-ID: <51C9AEEC.20505@redhat.com>


* Thu  Jun 25 2013 Michael Pasternak <mpastern at redhat.com> - 1.0.0.8-1
- implement support for the /capabilities resource
- implement basic debugging capabilities
- added VMApplications sub-collection
- to datacenter added new field [comment]
- to disk added [sgio] field to enable|disable filtering for the ScsiGenericIo
- to StorageDomain.delete() added storagedomain.host.id|name
- to VmPool added MaxUserVMs property
- to cluster.update() added [cluster.data_center.id]
- to host.fence() added action.fence_type
- to storagedomain.delete() added [storagedomain.format]
- to nic added [nic.custom_properties.custom_property]
- to vm.add(), vm.update() added [vm.memory_policy.guaranteed]



More details can be found at [1].

[1] http://www.ovirt.org/Java-sdk-changelog

-- 

Michael Pasternak
RedHat, ENG-Virtualization R&D




From lhornyak at redhat.com  Tue Jun 25 15:20:13 2013
From: lhornyak at redhat.com (Laszlo Hornyak)
Date: Tue, 25 Jun 2013 11:20:13 -0400 (EDT)
Subject: [Engine-devel] Free Text RFE patchset waiting for review
In-Reply-To: <2133164507.22361333.1372173402983.JavaMail.root@redhat.com>
Message-ID: <1387647373.22363616.1372173613453.JavaMail.root@redhat.com>

Hi,

Noam Slomianko's Free Text RFE patchset is waiting for review from
- restapi
- frontend

links to patches:
- http://gerrit.ovirt.org/15414
- http://gerrit.ovirt.org/15421
- http://gerrit.ovirt.org/15484
- http://gerrit.ovirt.org/15486

Thank you,
Laszlo


From alonbl at redhat.com  Wed Jun 26 12:21:34 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Wed, 26 Jun 2013 08:21:34 -0400 (EDT)
Subject: [Engine-devel] [ATN][Action Required] development environemnt users
 - otopi migration
In-Reply-To: <1838692348.12420226.1372248129020.JavaMail.root@redhat.com>
Message-ID: <1916603896.12424152.1372249294617.JavaMail.root@redhat.com>

Hello,

We have pending patch queue that requires latest otopi-1.1 features. We held that queue so we reduce noise to peers.

We would like now to merge this queue, it is best if you can upgrade to most recent otopi package before we merge to avoid breakage.

Latest otopi packages are available at the standard locations[1][2][3]

The minimum version required is otopi-1.1.0-0.0.master.20130626.

I delay merge to ~24 hours.

Of course if you have any issue, please don't hesitate to contact me.

Thank you for your cooperation,
Alon Bar-Lev

[1] http://resources.ovirt.org/releases/nightly/rpm/Fedora/17
[2] http://resources.ovirt.org/releases/nightly/rpm/Fedora/18
[3] http://resources.ovirt.org/releases/nightly/rpm/EL/6/


From alonbl at redhat.com  Wed Jun 26 12:39:46 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Wed, 26 Jun 2013 08:39:46 -0400 (EDT)
Subject: [Engine-devel] [ATN] moving dbscripts location
In-Reply-To: <1268757897.9810069.1371457460680.JavaMail.root@redhat.com>
References: <1268757897.9810069.1371457460680.JavaMail.root@redhat.com>
Message-ID: <1250892139.12428005.1372250386900.JavaMail.root@redhat.com>


Hello,

This change was committed.

Reminder:

Database scripts were moved from:
    backend/manager/dbscripts
to:
    packaging/dbscripts

Regards,
Alon Bar-Lev.

----- Original Message -----
> From: "Alon Bar-Lev" <alonbl at redhat.com>
> To: "engine-devel" <engine-devel at ovirt.org>
> Sent: Monday, June 17, 2013 11:24:20 AM
> Subject: [Engine-devel] [ATN] moving dbscripts location
> 
> 
> Hello All,
> 
> During the work I am doing to clean up the build of upcoming 3.3, I am going
> to move[1] dbscripts directory from:
>     backend/manager/dbscripts
> to:
>     packaging/dbscripts
> 
> The packaging directory is a new directory established for files we copy
> as-is to installation media, dbscripts was the last remaining directory of
> that nature. dbscripts does not really belong to the java sources nor to
> required for java project build (except few validation that were kept).
> 
> The packaging directory has the following advantages:
> 
> 1. Simplify the build system to blindly copy files recursively from packaging
> to installation media.
> 
> 2. Do not copy unnecessary files as we copy today, example is pom.xml.
> 
> 3. Allow easy split plain files within packaging directory to sub packages in
> future.
> 
> 4. Easier to understand the target system file layout by browsing the
> packaging directory, no magic of renaming or on the fly creation.
> 
> 5. A clear separation between the maven build and the packaging build.
> 
> Regards,
> Alon Bar-Lev.
> 
> [1] http://gerrit.ovirt.org/#/c/15743
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From emesika at redhat.com  Wed Jun 26 12:40:51 2013
From: emesika at redhat.com (Eli Mesika)
Date: Wed, 26 Jun 2013 08:40:51 -0400 (EDT)
Subject: [Engine-devel] [IMPORTANT]Change of dbscripts dir location
In-Reply-To: <1263910124.3521982.1372250318395.JavaMail.root@redhat.com>
Message-ID: <948486248.3522842.1372250451665.JavaMail.root@redhat.com>

Hi

Please note that a patch moving dbscripts directory to <ovirt root>/packaging/dbscripts has been merged upstream.

All of you who have any db changed that involves the old dbscripts dir or one of its descendants should re-base and move there scripts to the new location.

If you have any questions , I will be happy to assist you.

Thanks 

Eli


From michal.skrivanek at redhat.com  Wed Jun 26 13:48:26 2013
From: michal.skrivanek at redhat.com (Michal Skrivanek)
Date: Wed, 26 Jun 2013 15:48:26 +0200
Subject: [Engine-devel] Console broken with current master vmSetTicket
	error
In-Reply-To: <CAEWPe=qfWwwfXS-farZQPgQ3Vgmi3SE8XVUODscedOrGC9rqng@mail.gmail.com>
References: <CAEWPe=p6a8Vgkf_wBN19rhtGR5yu+=KduV4RYF5RmVdNnuT4QA@mail.gmail.com>
	<49EBCD45-0CB4-4837-8730-FD3375674BFA@redhat.com>
	<CAEWPe=qfWwwfXS-farZQPgQ3Vgmi3SE8XVUODscedOrGC9rqng@mail.gmail.com>
Message-ID: <89186FFE-8139-4FE5-9021-6B1122A5595D@redhat.com>

Hi,
are you using "display network"?
if so it's a libvirt issue. Try to downgrade your libvirt or wait for a fix. Don't have a bug # though?.but I see some fix is posted so it should land there soon?

Thanks,
michal

On Jun 25, 2013, at 01:46 , Dead Horse <deadhorseconsulting at gmail.com> wrote:

> libvirt-python-0.10.2-18.0.1.el6_4.8.x86_64
> libvirt-client-0.10.2-18.0.1.el6_4.8.x86_64
> libvirt-java-0.4.9-1.el6.noarch
> libvirt-0.10.2-18.0.1.el6_4.8.x86_64
> libvirt-java-devel-0.4.9-1.el6.noarch
> libvirt-lock-sanlock-0.10.2-18.0.1.el6_4.8.x86_64
> libvirt-devel-0.10.2-18.0.1.el6_4.8.x86_64
> 
> libvirtd log attached.
> 
> - DHC
> 
> 
> On Sun, Jun 23, 2013 at 2:00 AM, Michal Skrivanek <michal.skrivanek at redhat.com> wrote:
> Hi,
> libvirt version?
> perhaps libvirt log as well
> 
> Thanks,
> michal
> 
> On Jun 22, 2013, at 04:05 , Dead Horse <deadhorseconsulting at gmail.com> wrote:
> 
> > When the console button is clicked in the webadmin or userportal (engine and vdsm built from the latest master) the follow error message is returned:
> >
> > "Error while executing action SetVmTicket: Unexpected exception"
> >
> > This occurs with latest master engine and vdsm built as of today.
> >
> > engine and vdsm logs of failure attached.
> >
> > - DHC
> > <engine.log><vdsm.log>_______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
> 
> <libvirtd.log>



From lvernia at redhat.com  Thu Jun 27 07:12:33 2013
From: lvernia at redhat.com (Lior Vernia)
Date: Thu, 27 Jun 2013 10:12:33 +0300
Subject: [Engine-devel] Sorting in tabs
Message-ID: <51CBE5E1.7080900@redhat.com>

Hello everyone (UI peeps in particular),

I've pushed (not yet merged) a patch that would enable us to keep items
in tabs (main/sub) sorted at all times by setting a comparator in
SearchableListModel:

http://gerrit.ovirt.org/#/c/15846/

If a comparator isn't set, then everything should behave as before. If a
comparator is set, then from that moment on the tab items will be kept
in a SortedSet, so that even if an item is added in a way that doesn't
trigger an event (e.g. getItems().add()) the items will be kept sorted
according to the given comparator. If the comparator is set to null,
from that moment on the tab should revert to its old behaviour.

You're most welcome to have a look and let me know if this might break
something (remember though that it's not obligatory to set a comparator,
so only possible breakage should be in generic flows).

Feel free to use it once it's merged; along with SortedListModel, this
should make sorting less painful. Just keep in mind that once you set a
comparator, you can't cast getItems() to a List. This shouldn't be a
problem in general, as mostly it's as useful (and probably more correct)
to cast to a Collection.

Lior.


From lhornyak at redhat.com  Thu Jun 27 08:23:42 2013
From: lhornyak at redhat.com (Laszlo Hornyak)
Date: Thu, 27 Jun 2013 04:23:42 -0400 (EDT)
Subject: [Engine-devel] EngineEncryptionUtilsTest
In-Reply-To: <1949926698.23394913.1372321122992.JavaMail.root@redhat.com>
Message-ID: <1949218342.23396969.1372321422142.JavaMail.root@redhat.com>

Hi,

Just ran into an issue with EngineEncryptionUtilsTest, looks like it is failing if the /etc/ovirt-engine/engine.conf does not have some keys. So of course by now all of us added those keys, but isn't there a logical loop here?
First the code should be tested, packaged and then installed and that's how that file should get there. We should not build the tests on the assumption that a version of oVirt is already installed.

What is your opinion?

Thx,
Laszlo



From jhernand at redhat.com  Thu Jun 27 08:50:51 2013
From: jhernand at redhat.com (Juan Hernandez)
Date: Thu, 27 Jun 2013 10:50:51 +0200
Subject: [Engine-devel] NPE approving node
Message-ID: <51CBFCEB.80609@redhat.com>

Any idea why?

2013-06-27 10:37:40,219 INFO 
[org.ovirt.engine.core.bll.ApproveVdsCommand] (pool-6-thread-5) 
[3dd1f412] Running command: ApproveVdsCommand internal: false. Entities 
affected :  ID: 0be6cd89-c5f5-4a4e-b498-504bb2c23eb2 Type: VDS
2013-06-27 10:37:40,239 INFO 
[org.ovirt.engine.core.bll.InstallVdsCommand] (pool-6-thread-5) 
[3dd1f412] Before Installation host 
0be6cd89-c5f5-4a4e-b498-504bb2c23eb2, h0.example.com
2013-06-27 10:37:40,294 ERROR 
[org.ovirt.engine.core.bll.InstallVdsCommand] (pool-6-thread-5) 
[3dd1f412] Host installation failed for host 
0be6cd89-c5f5-4a4e-b498-504bb2c23eb2, h0.example.com.: 
java.lang.NullPointerException
	at 
org.ovirt.engine.core.utils.ssh.EngineSSHDialog.useDefaultKeyPair(EngineSSHDialog.java:32) 
[utils.jar:]
	at 
org.ovirt.engine.core.bll.VdsDeploy.useDefaultKeyPair(VdsDeploy.java:804) [bll.jar:]
	at 
org.ovirt.engine.core.bll.InstallVdsCommand.executeCommand(InstallVdsCommand.java:170) 
[bll.jar:]
	at 
org.ovirt.engine.core.bll.ApproveVdsCommand.executeCommand(ApproveVdsCommand.java:49) 
[bll.jar:]
	at 
org.ovirt.engine.core.bll.CommandBase.executeWithoutTransaction(CommandBase.java:1065) 
[bll.jar:]
	at 
org.ovirt.engine.core.bll.CommandBase.executeActionInTransactionScope(CommandBase.java:1150) 
[bll.jar:]
	at 
org.ovirt.engine.core.bll.CommandBase.runInTransaction(CommandBase.java:1613) 
[bll.jar:]
	at 
org.ovirt.engine.core.utils.transaction.TransactionSupport.executeInSuppressed(TransactionSupport.java:174) 
[utils.jar:]
	at 
org.ovirt.engine.core.utils.transaction.TransactionSupport.executeInScope(TransactionSupport.java:116) 
[utils.jar:]
	at org.ovirt.engine.core.bll.CommandBase.execute(CommandBase.java:1168) 
[bll.jar:]
	at 
org.ovirt.engine.core.bll.CommandBase.executeAction(CommandBase.java:316) [bll.jar:]
	at 
org.ovirt.engine.core.bll.MultipleActionsRunner.executeValidatedCommand(MultipleActionsRunner.java:174) 
[bll.jar:]
	at 
org.ovirt.engine.core.bll.MultipleActionsRunner.RunCommands(MultipleActionsRunner.java:156) 
[bll.jar:]
	at 
org.ovirt.engine.core.bll.MultipleActionsRunner$1.run(MultipleActionsRunner.java:94) 
[bll.jar:]
	at 
org.ovirt.engine.core.utils.threadpool.ThreadPoolUtil$InternalWrapperRunnable.run(ThreadPoolUtil.java:71) 
[utils.jar:]
	at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) 
[rt.jar:1.7.0_09-icedtea]
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334) 
[rt.jar:1.7.0_09-icedtea]
	at java.util.concurrent.FutureTask.run(FutureTask.java:166) 
[rt.jar:1.7.0_09-icedtea]
	at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) 
[rt.jar:1.7.0_09-icedtea]
	at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) 
[rt.jar:1.7.0_09-icedtea]
	at java.lang.Thread.run(Thread.java:722) [rt.jar:1.7.0_09-icedtea]

-- 
Direcci?n Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 
3?D, 28016 Madrid, Spain
Inscrita en el Reg. Mercantil de Madrid ? C.I.F. B82657941 - Red Hat S.L.


From masayag at redhat.com  Thu Jun 27 09:11:23 2013
From: masayag at redhat.com (Moti Asayag)
Date: Thu, 27 Jun 2013 12:11:23 +0300
Subject: [Engine-devel] [ATN][Action Required] development environemnt
 users - otopi migration
In-Reply-To: <1916603896.12424152.1372249294617.JavaMail.root@redhat.com>
References: <1916603896.12424152.1372249294617.JavaMail.root@redhat.com>
Message-ID: <51CC01BB.8010607@redhat.com>

Hi,

Just tried to run 'bin/engine-setup-2' with the latest version of otopi
(otopi-1.1.0-0.0.master.20130626.git33d9561.fc17.noarch) and failed due to:

[ ERROR ] Failed to execute stage 'Misc configuration': [Errno 13]
Permission denied: '/etc/ovirt-engine-setup.conf.d'

OSError: [Errno **FILTERED**3] Permission denied:
'/etc/ovirt-engine-setup.conf.d'
20**FILTERED**3-06-27 **FILTERED**2:04:36 ERROR otopi.context
context._executeMethod:**FILTERED**4**FILTERED** Failed to execute stage
'Misc configuration': [Errno **FILTERED**3] Permission
 denied: '/etc/ovirt-engine-setup.conf.d'

Log is attached.

Thanks,
Moti

On 06/26/2013 03:21 PM, Alon Bar-Lev wrote:
> Hello,
> 
> We have pending patch queue that requires latest otopi-1.1 features. We held that queue so we reduce noise to peers.
> 
> We would like now to merge this queue, it is best if you can upgrade to most recent otopi package before we merge to avoid breakage.
> 
> Latest otopi packages are available at the standard locations[1][2][3]
> 
> The minimum version required is otopi-1.1.0-0.0.master.20130626.
> 
> I delay merge to ~24 hours.
> 
> Of course if you have any issue, please don't hesitate to contact me.
> 
> Thank you for your cooperation,
> Alon Bar-Lev
> 
> [1] http://resources.ovirt.org/releases/nightly/rpm/Fedora/17
> [2] http://resources.ovirt.org/releases/nightly/rpm/Fedora/18
> [3] http://resources.ovirt.org/releases/nightly/rpm/EL/6/
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ovirt-engine-setup-20130627120045.log
Type: text/x-log
Size: 1316461 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130627/a9dac98a/attachment.bin>

From tjelinek at redhat.com  Thu Jun 27 09:21:11 2013
From: tjelinek at redhat.com (Tomas Jelinek)
Date: Thu, 27 Jun 2013 05:21:11 -0400 (EDT)
Subject: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
In-Reply-To: <20130624094735.GC1849@teriyaki.cdg.redhat.com>
References: <501973842.20255318.1371648804880.JavaMail.root@redhat.com>
	<51C1C79F.3050401@redhat.com> <20130620110715.GC2834@teriyaki>
	<51C2E2E1.8030808@redhat.com>
	<936279456.20836092.1371730386788.JavaMail.root@redhat.com>
	<51C2F54C.60409@redhat.com>
	<6609F396-8D78-46FB-9F2D-3700D769B5E9@redhat.com>
	<20130624094735.GC1849@teriyaki.cdg.redhat.com>
Message-ID: <1210717020.2488959.1372324871664.JavaMail.root@redhat.com>

well, it seems that everyone agree that the decision what to add to the
menu is the client responsibility. It means there is no additional work needed on the
oVirt engine side - going to remove the feature page.

----- Original Message -----
> From: "Christophe Fergeau" <cfergeau at redhat.com>
> To: "Michal Skrivanek" <michal.skrivanek at redhat.com>
> Cc: "Itamar Heim" <iheim at redhat.com>, "Tomas Jelinek" <tjelinek at redhat.com>, spice-devel at lists.freedesktop.org,
> "engine-devel" <engine-devel at ovirt.org>, "Marc-Andr? Lureau" <mlureau at redhat.com>
> Sent: Monday, June 24, 2013 11:47:36 AM
> Subject: Re: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
> 
> On Mon, Jun 24, 2013 at 10:02:29AM +0200, Michal Skrivanek wrote:
> > I would agree as long as it is not hardcoded and can be change in some
> > config file easily. We shouldn't wait for next RHEL release to do a
> > little modification if possible.
> > I think "owning" the menu in some form on RHEV-M side has an advantage of
> > delivery synchronization.
> 
> This probably would also make things harder from a client documentation
> point of view. With something too generic, there's also always the risk
> that it becomes a way to add workaround for bugs, or that the menu starts
> containing things that would be better integrated in other places in the
> client, ...
> 
> Christophe
> 


From alonbl at redhat.com  Thu Jun 27 09:25:05 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Thu, 27 Jun 2013 05:25:05 -0400 (EDT)
Subject: [Engine-devel] [ATN][Action Required] development environemnt
 users - otopi migration
In-Reply-To: <51CC01BB.8010607@redhat.com>
References: <1916603896.12424152.1372249294617.JavaMail.root@redhat.com>
	<51CC01BB.8010607@redhat.com>
Message-ID: <1442391258.12674448.1372325105311.JavaMail.root@redhat.com>


Hi,

Are you sure you installed it with PREFIX?
Can you please send me $HOME/ovirt-engine/share/ovirt-engine/setup/ovirt_engine_setup/config.py

----- Original Message -----
> From: "Moti Asayag" <masayag at redhat.com>
> To: "Alon Bar-Lev" <alonbl at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>
> Sent: Thursday, June 27, 2013 12:11:23 PM
> Subject: Re: [Engine-devel] [ATN][Action Required] development environemnt users - otopi migration
> 
> Hi,
> 
> Just tried to run 'bin/engine-setup-2' with the latest version of otopi
> (otopi-1.1.0-0.0.master.20130626.git33d9561.fc17.noarch) and failed due to:
> 
> [ ERROR ] Failed to execute stage 'Misc configuration': [Errno 13]
> Permission denied: '/etc/ovirt-engine-setup.conf.d'
> 
> OSError: [Errno **FILTERED**3] Permission denied:
> '/etc/ovirt-engine-setup.conf.d'
> 20**FILTERED**3-06-27 **FILTERED**2:04:36 ERROR otopi.context
> context._executeMethod:**FILTERED**4**FILTERED** Failed to execute stage
> 'Misc configuration': [Errno **FILTERED**3] Permission
>  denied: '/etc/ovirt-engine-setup.conf.d'
> 
> Log is attached.
> 
> Thanks,
> Moti
> 
> On 06/26/2013 03:21 PM, Alon Bar-Lev wrote:
> > Hello,
> > 
> > We have pending patch queue that requires latest otopi-1.1 features. We
> > held that queue so we reduce noise to peers.
> > 
> > We would like now to merge this queue, it is best if you can upgrade to
> > most recent otopi package before we merge to avoid breakage.
> > 
> > Latest otopi packages are available at the standard locations[1][2][3]
> > 
> > The minimum version required is otopi-1.1.0-0.0.master.20130626.
> > 
> > I delay merge to ~24 hours.
> > 
> > Of course if you have any issue, please don't hesitate to contact me.
> > 
> > Thank you for your cooperation,
> > Alon Bar-Lev
> > 
> > [1] http://resources.ovirt.org/releases/nightly/rpm/Fedora/17
> > [2] http://resources.ovirt.org/releases/nightly/rpm/Fedora/18
> > [3] http://resources.ovirt.org/releases/nightly/rpm/EL/6/
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> 
> 


From masayag at redhat.com  Thu Jun 27 09:27:49 2013
From: masayag at redhat.com (Moti Asayag)
Date: Thu, 27 Jun 2013 12:27:49 +0300
Subject: [Engine-devel] [ATN][Action Required] development environemnt
 users - otopi migration
In-Reply-To: <1442391258.12674448.1372325105311.JavaMail.root@redhat.com>
References: <1916603896.12424152.1372249294617.JavaMail.root@redhat.com>
	<51CC01BB.8010607@redhat.com>
	<1442391258.12674448.1372325105311.JavaMail.root@redhat.com>
Message-ID: <51CC0595.9060603@redhat.com>

On 06/27/2013 12:25 PM, Alon Bar-Lev wrote:
> 
> Hi,
> 
> Are you sure you installed it with PREFIX?

yes.

> Can you please send me $HOME/ovirt-engine/share/ovirt-engine/setup/ovirt_engine_setup/config.py

Here is its content:

"""Config."""


ENGINE_SYSCONFDIR = '/home/motia/ovirt-engine-quantum/etc/ovirt-engine'
ENGINE_SERVICE_CONFIG =
'/home/motia/ovirt-engine-quantum/etc/ovirt-engine/engine.conf'
ENGINE_NOTIFIER_SERVICE_CONFIG =
'/home/motia/ovirt-engine-quantum/etc/ovirt-engine/notifier/notifier.conf'
ENGINE_PKIDIR = '/home/motia/ovirt-engine-quantum/etc/pki/ovirt-engine'
ENGINE_DATADIR = '/home/motia/ovirt-engine-quantum/share/ovirt-engine'
ENGINE_LOCALSTATEDIR =
'/home/motia/ovirt-engine-quantum/var/lib/ovirt-engine'
ENGINE_TMP = '/home/motia/ovirt-engine-quantum/var/tmp/ovirt-engine'
PACKAGE_VERSION = '3.3.0_master'
DISPLAY_VERSION = '3.3.0_master'
RPM_VERSION = '3.3.0'
RPM_RELEASE = '0.2.master.20130627083750'


# vim: expandtab tabstop=4 shiftwidth=4

> 
> ----- Original Message -----
>> From: "Moti Asayag" <masayag at redhat.com>
>> To: "Alon Bar-Lev" <alonbl at redhat.com>
>> Cc: "engine-devel" <engine-devel at ovirt.org>
>> Sent: Thursday, June 27, 2013 12:11:23 PM
>> Subject: Re: [Engine-devel] [ATN][Action Required] development environemnt users - otopi migration
>>
>> Hi,
>>
>> Just tried to run 'bin/engine-setup-2' with the latest version of otopi
>> (otopi-1.1.0-0.0.master.20130626.git33d9561.fc17.noarch) and failed due to:
>>
>> [ ERROR ] Failed to execute stage 'Misc configuration': [Errno 13]
>> Permission denied: '/etc/ovirt-engine-setup.conf.d'
>>
>> OSError: [Errno **FILTERED**3] Permission denied:
>> '/etc/ovirt-engine-setup.conf.d'
>> 20**FILTERED**3-06-27 **FILTERED**2:04:36 ERROR otopi.context
>> context._executeMethod:**FILTERED**4**FILTERED** Failed to execute stage
>> 'Misc configuration': [Errno **FILTERED**3] Permission
>>  denied: '/etc/ovirt-engine-setup.conf.d'
>>
>> Log is attached.
>>
>> Thanks,
>> Moti
>>
>> On 06/26/2013 03:21 PM, Alon Bar-Lev wrote:
>>> Hello,
>>>
>>> We have pending patch queue that requires latest otopi-1.1 features. We
>>> held that queue so we reduce noise to peers.
>>>
>>> We would like now to merge this queue, it is best if you can upgrade to
>>> most recent otopi package before we merge to avoid breakage.
>>>
>>> Latest otopi packages are available at the standard locations[1][2][3]
>>>
>>> The minimum version required is otopi-1.1.0-0.0.master.20130626.
>>>
>>> I delay merge to ~24 hours.
>>>
>>> Of course if you have any issue, please don't hesitate to contact me.
>>>
>>> Thank you for your cooperation,
>>> Alon Bar-Lev
>>>
>>> [1] http://resources.ovirt.org/releases/nightly/rpm/Fedora/17
>>> [2] http://resources.ovirt.org/releases/nightly/rpm/Fedora/18
>>> [3] http://resources.ovirt.org/releases/nightly/rpm/EL/6/
>>> _______________________________________________
>>> Engine-devel mailing list
>>> Engine-devel at ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>
>>
>>



From cfergeau at redhat.com  Thu Jun 27 09:30:10 2013
From: cfergeau at redhat.com (Christophe Fergeau)
Date: Thu, 27 Jun 2013 11:30:10 +0200
Subject: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
In-Reply-To: <1210717020.2488959.1372324871664.JavaMail.root@redhat.com>
References: <501973842.20255318.1371648804880.JavaMail.root@redhat.com>
	<51C1C79F.3050401@redhat.com> <20130620110715.GC2834@teriyaki>
	<51C2E2E1.8030808@redhat.com>
	<936279456.20836092.1371730386788.JavaMail.root@redhat.com>
	<51C2F54C.60409@redhat.com>
	<6609F396-8D78-46FB-9F2D-3700D769B5E9@redhat.com>
	<20130624094735.GC1849@teriyaki.cdg.redhat.com>
	<1210717020.2488959.1372324871664.JavaMail.root@redhat.com>
Message-ID: <20130627093010.GC13576@teriyaki.redhat.com>

Hey,

On Thu, Jun 27, 2013 at 05:21:11AM -0400, Tomas Jelinek wrote:
> well, it seems that everyone agree that the decision what to add to the
> menu is the client responsibility. It means there is no additional work needed on the
> oVirt engine side - going to remove the feature page.

If we go the REST API way to handle foreign menu, we need additional info
in the .vv files: some way to auth with the REST API, and the guid of the
VM to act on.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130627/ab3cf5cd/attachment.sig>

From alonbl at redhat.com  Thu Jun 27 09:36:38 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Thu, 27 Jun 2013 05:36:38 -0400 (EDT)
Subject: [Engine-devel] [ATN][Action Required] development environemnt
 users - otopi migration
In-Reply-To: <51CC0595.9060603@redhat.com>
References: <1916603896.12424152.1372249294617.JavaMail.root@redhat.com>
	<51CC01BB.8010607@redhat.com>
	<1442391258.12674448.1372325105311.JavaMail.root@redhat.com>
	<51CC0595.9060603@redhat.com>
Message-ID: <549866399.12676350.1372325798710.JavaMail.root@redhat.com>


Hi,

Confirmed[1] bug in engine code, will fix soon.

Workaround:

packaging/setup/ovirt_engine_setup/constants.py

Find: OVIRT_SETUP_POST_INSTALL_CONFIG
Modify: OVIRT_OVIRT_SETUP_CONFIG_FILE->'/tmp/xxx'

[1] http://gerrit.ovirt.org/#/c/15957/

----- Original Message -----
> From: "Moti Asayag" <masayag at redhat.com>
> To: "Alon Bar-Lev" <alonbl at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>
> Sent: Thursday, June 27, 2013 12:27:49 PM
> Subject: Re: [Engine-devel] [ATN][Action Required] development environemnt users - otopi migration
> 
> On 06/27/2013 12:25 PM, Alon Bar-Lev wrote:
> > 
> > Hi,
> > 
> > Are you sure you installed it with PREFIX?
> 
> yes.
> 
> > Can you please send me
> > $HOME/ovirt-engine/share/ovirt-engine/setup/ovirt_engine_setup/config.py
> 
> Here is its content:
> 
> """Config."""
> 
> 
> ENGINE_SYSCONFDIR = '/home/motia/ovirt-engine-quantum/etc/ovirt-engine'
> ENGINE_SERVICE_CONFIG =
> '/home/motia/ovirt-engine-quantum/etc/ovirt-engine/engine.conf'
> ENGINE_NOTIFIER_SERVICE_CONFIG =
> '/home/motia/ovirt-engine-quantum/etc/ovirt-engine/notifier/notifier.conf'
> ENGINE_PKIDIR = '/home/motia/ovirt-engine-quantum/etc/pki/ovirt-engine'
> ENGINE_DATADIR = '/home/motia/ovirt-engine-quantum/share/ovirt-engine'
> ENGINE_LOCALSTATEDIR =
> '/home/motia/ovirt-engine-quantum/var/lib/ovirt-engine'
> ENGINE_TMP = '/home/motia/ovirt-engine-quantum/var/tmp/ovirt-engine'
> PACKAGE_VERSION = '3.3.0_master'
> DISPLAY_VERSION = '3.3.0_master'
> RPM_VERSION = '3.3.0'
> RPM_RELEASE = '0.2.master.20130627083750'
> 
> 
> # vim: expandtab tabstop=4 shiftwidth=4
> 
> > 
> > ----- Original Message -----
> >> From: "Moti Asayag" <masayag at redhat.com>
> >> To: "Alon Bar-Lev" <alonbl at redhat.com>
> >> Cc: "engine-devel" <engine-devel at ovirt.org>
> >> Sent: Thursday, June 27, 2013 12:11:23 PM
> >> Subject: Re: [Engine-devel] [ATN][Action Required] development environemnt
> >> users - otopi migration
> >>
> >> Hi,
> >>
> >> Just tried to run 'bin/engine-setup-2' with the latest version of otopi
> >> (otopi-1.1.0-0.0.master.20130626.git33d9561.fc17.noarch) and failed due
> >> to:
> >>
> >> [ ERROR ] Failed to execute stage 'Misc configuration': [Errno 13]
> >> Permission denied: '/etc/ovirt-engine-setup.conf.d'
> >>
> >> OSError: [Errno **FILTERED**3] Permission denied:
> >> '/etc/ovirt-engine-setup.conf.d'
> >> 20**FILTERED**3-06-27 **FILTERED**2:04:36 ERROR otopi.context
> >> context._executeMethod:**FILTERED**4**FILTERED** Failed to execute stage
> >> 'Misc configuration': [Errno **FILTERED**3] Permission
> >>  denied: '/etc/ovirt-engine-setup.conf.d'
> >>
> >> Log is attached.
> >>
> >> Thanks,
> >> Moti
> >>
> >> On 06/26/2013 03:21 PM, Alon Bar-Lev wrote:
> >>> Hello,
> >>>
> >>> We have pending patch queue that requires latest otopi-1.1 features. We
> >>> held that queue so we reduce noise to peers.
> >>>
> >>> We would like now to merge this queue, it is best if you can upgrade to
> >>> most recent otopi package before we merge to avoid breakage.
> >>>
> >>> Latest otopi packages are available at the standard locations[1][2][3]
> >>>
> >>> The minimum version required is otopi-1.1.0-0.0.master.20130626.
> >>>
> >>> I delay merge to ~24 hours.
> >>>
> >>> Of course if you have any issue, please don't hesitate to contact me.
> >>>
> >>> Thank you for your cooperation,
> >>> Alon Bar-Lev
> >>>
> >>> [1] http://resources.ovirt.org/releases/nightly/rpm/Fedora/17
> >>> [2] http://resources.ovirt.org/releases/nightly/rpm/Fedora/18
> >>> [3] http://resources.ovirt.org/releases/nightly/rpm/EL/6/
> >>> _______________________________________________
> >>> Engine-devel mailing list
> >>> Engine-devel at ovirt.org
> >>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> >>>
> >>
> >>
> 
> 


From alonbl at redhat.com  Thu Jun 27 09:43:01 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Thu, 27 Jun 2013 05:43:01 -0400 (EDT)
Subject: [Engine-devel] EngineEncryptionUtilsTest
In-Reply-To: <1949218342.23396969.1372321422142.JavaMail.root@redhat.com>
References: <1949218342.23396969.1372321422142.JavaMail.root@redhat.com>
Message-ID: <666299748.12678284.1372326181519.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Laszlo Hornyak" <lhornyak at redhat.com>
> To: "engine-devel" <engine-devel at ovirt.org>
> Sent: Thursday, June 27, 2013 11:23:42 AM
> Subject: [Engine-devel] EngineEncryptionUtilsTest
> 
> Hi,
> 
> Just ran into an issue with EngineEncryptionUtilsTest, looks like it is
> failing if the /etc/ovirt-engine/engine.conf does not have some keys. So of
> course by now all of us added those keys, but isn't there a logical loop
> here?
> First the code should be tested, packaged and then installed and that's how
> that file should get there. We should not build the tests on the assumption
> that a version of oVirt is already installed.
> 
> What is your opinion?

It is my bad, I did not notice this exception as I had this file.

The problem is within EngineEncryptionUtils which is tested. It has the following:

    static {
        EngineLocalConfig config = EngineLocalConfig.getInstance();
        keystoreFile = config.getPKIEngineStore().getAbsoluteFile();
        keystorePassword = new KeyStore.PasswordProtection(config.getPKIEngineStorePassword().toCharArray());
        keystoreAlias = config.getPKIEngineStoreAlias();
        truststoreFile = config.getPKITrustStore().getAbsoluteFile();
        truststorePassword = new KeyStore.PasswordProtection(config.getPKITrustStorePassword().toCharArray());
    }

So when EngineEncryptionUtils is executed the EngineLocalConfig is initiated. I will add another static variable to disable this block... I think it will be the simplest, unless you have a better idea.

Thanks,
Alon


From tjelinek at redhat.com  Thu Jun 27 09:50:31 2013
From: tjelinek at redhat.com (Tomas Jelinek)
Date: Thu, 27 Jun 2013 05:50:31 -0400 (EDT)
Subject: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
In-Reply-To: <20130627093010.GC13576@teriyaki.redhat.com>
References: <501973842.20255318.1371648804880.JavaMail.root@redhat.com>
	<51C2E2E1.8030808@redhat.com>
	<936279456.20836092.1371730386788.JavaMail.root@redhat.com>
	<51C2F54C.60409@redhat.com>
	<6609F396-8D78-46FB-9F2D-3700D769B5E9@redhat.com>
	<20130624094735.GC1849@teriyaki.cdg.redhat.com>
	<1210717020.2488959.1372324871664.JavaMail.root@redhat.com>
	<20130627093010.GC13576@teriyaki.redhat.com>
Message-ID: <2114201154.2496221.1372326631963.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Christophe Fergeau" <cfergeau at redhat.com>
> To: "Tomas Jelinek" <tjelinek at redhat.com>
> Cc: "Michal Skrivanek" <michal.skrivanek at redhat.com>, "Itamar Heim" <iheim at redhat.com>,
> spice-devel at lists.freedesktop.org, "engine-devel" <engine-devel at ovirt.org>, "Marc-Andr? Lureau" <mlureau at redhat.com>
> Sent: Thursday, June 27, 2013 11:30:10 AM
> Subject: Re: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
> 
> Hey,
> 
> On Thu, Jun 27, 2013 at 05:21:11AM -0400, Tomas Jelinek wrote:
> > well, it seems that everyone agree that the decision what to add to the
> > menu is the client responsibility. It means there is no additional work
> > needed on the
> > oVirt engine side - going to remove the feature page.
> 
> If we go the REST API way to handle foreign menu, we need additional info
> in the .vv files: some way to auth with the REST API, and the guid of the
> VM to act on.
Yes, we can provide the sessionId to authenticate with the REST and the vm guid is not a problem.

> 
> Christophe
> 


From emesika at redhat.com  Thu Jun 27 10:46:58 2013
From: emesika at redhat.com (Eli Mesika)
Date: Thu, 27 Jun 2013 06:46:58 -0400 (EDT)
Subject: [Engine-devel] Sorting in tabs
In-Reply-To: <51CBE5E1.7080900@redhat.com>
References: <51CBE5E1.7080900@redhat.com>
Message-ID: <1283248469.4062177.1372330018886.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Lior Vernia" <lvernia at redhat.com>
> To: engine-devel at ovirt.org
> Sent: Thursday, June 27, 2013 10:12:33 AM
> Subject: [Engine-devel] Sorting in tabs
> 
> Hello everyone (UI peeps in particular),
> 
> I've pushed (not yet merged) a patch that would enable us to keep items
> in tabs (main/sub) sorted at all times by setting a comparator in
> SearchableListModel:

But tabs includes only 100 records and supports paging , how you deal with that ???


> 
> http://gerrit.ovirt.org/#/c/15846/
> 
> If a comparator isn't set, then everything should behave as before. If a
> comparator is set, then from that moment on the tab items will be kept
> in a SortedSet, so that even if an item is added in a way that doesn't
> trigger an event (e.g. getItems().add()) the items will be kept sorted
> according to the given comparator. If the comparator is set to null,
> from that moment on the tab should revert to its old behaviour.
> 
> You're most welcome to have a look and let me know if this might break
> something (remember though that it's not obligatory to set a comparator,
> so only possible breakage should be in generic flows).
> 
> Feel free to use it once it's merged; along with SortedListModel, this
> should make sorting less painful. Just keep in mind that once you set a
> comparator, you can't cast getItems() to a List. This shouldn't be a
> problem in general, as mostly it's as useful (and probably more correct)
> to cast to a Collection.
> 
> Lior.
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From mperina at redhat.com  Thu Jun 27 10:51:06 2013
From: mperina at redhat.com (Martin Perina)
Date: Thu, 27 Jun 2013 06:51:06 -0400 (EDT)
Subject: [Engine-devel] SSH Soft Fencing
In-Reply-To: <2118091250.568449.1372329505806.JavaMail.root@redhat.com>
Message-ID: <1622219224.572748.1372330266360.JavaMail.root@redhat.com>

Hi,

SSH Soft Fencing is a new feature for 3.3 and it tries to restart VDSM
using SSH connection on non responsive hosts prior to real fencing.
More info can be found at 

http://www.ovirt.org/Automatic_Fencing#Automatic_Fencing_in_oVirt_3.3

In current SSH Soft Fencing implementation the restart VDSM using SSH
command is part of standard fencing implementation in 
VdsNotRespondingTreatmentCommand. But this command is executed only
if a host has a valid PM configuration. If host doesn't have a valid
PM configuration, the execution of the command is disabled and host
state is change to Non Responsive.

So my question are:

1) Should SSH Soft Fencing be executed on hosts without valid PM
   configuration?

2) Should VDSM restart using SSH command be reimplemented
   as standalone command to be usable also in other parts of engine?
   If 1) is true, I think it will have to be done anyway.


Martin Perina


From sbonazzo at redhat.com  Thu Jun 27 12:05:08 2013
From: sbonazzo at redhat.com (Sandro Bonazzola)
Date: Thu, 27 Jun 2013 14:05:08 +0200
Subject: [Engine-devel] [ATN][Action Required] development environemnt
 users - otopi migration
In-Reply-To: <549866399.12676350.1372325798710.JavaMail.root@redhat.com>
References: <1916603896.12424152.1372249294617.JavaMail.root@redhat.com>
	<51CC01BB.8010607@redhat.com>
	<1442391258.12674448.1372325105311.JavaMail.root@redhat.com>
	<51CC0595.9060603@redhat.com>
	<549866399.12676350.1372325798710.JavaMail.root@redhat.com>
Message-ID: <51CC2A74.80903@redhat.com>

Patch pushed for review: http://gerrit.ovirt.org/16182


Il 27/06/2013 11:36, Alon Bar-Lev ha scritto:
> Hi,
>
> Confirmed[1] bug in engine code, will fix soon.
>
> Workaround:
>
> packaging/setup/ovirt_engine_setup/constants.py
>
> Find: OVIRT_SETUP_POST_INSTALL_CONFIG
> Modify: OVIRT_OVIRT_SETUP_CONFIG_FILE->'/tmp/xxx'
>
> [1] http://gerrit.ovirt.org/#/c/15957/
>
> ----- Original Message -----
>> From: "Moti Asayag" <masayag at redhat.com>
>> To: "Alon Bar-Lev" <alonbl at redhat.com>
>> Cc: "engine-devel" <engine-devel at ovirt.org>
>> Sent: Thursday, June 27, 2013 12:27:49 PM
>> Subject: Re: [Engine-devel] [ATN][Action Required] development environemnt users - otopi migration
>>
>> On 06/27/2013 12:25 PM, Alon Bar-Lev wrote:
>>> Hi,
>>>
>>> Are you sure you installed it with PREFIX?
>> yes.
>>
>>> Can you please send me
>>> $HOME/ovirt-engine/share/ovirt-engine/setup/ovirt_engine_setup/config.py
>> Here is its content:
>>
>> """Config."""
>>
>>
>> ENGINE_SYSCONFDIR = '/home/motia/ovirt-engine-quantum/etc/ovirt-engine'
>> ENGINE_SERVICE_CONFIG =
>> '/home/motia/ovirt-engine-quantum/etc/ovirt-engine/engine.conf'
>> ENGINE_NOTIFIER_SERVICE_CONFIG =
>> '/home/motia/ovirt-engine-quantum/etc/ovirt-engine/notifier/notifier.conf'
>> ENGINE_PKIDIR = '/home/motia/ovirt-engine-quantum/etc/pki/ovirt-engine'
>> ENGINE_DATADIR = '/home/motia/ovirt-engine-quantum/share/ovirt-engine'
>> ENGINE_LOCALSTATEDIR =
>> '/home/motia/ovirt-engine-quantum/var/lib/ovirt-engine'
>> ENGINE_TMP = '/home/motia/ovirt-engine-quantum/var/tmp/ovirt-engine'
>> PACKAGE_VERSION = '3.3.0_master'
>> DISPLAY_VERSION = '3.3.0_master'
>> RPM_VERSION = '3.3.0'
>> RPM_RELEASE = '0.2.master.20130627083750'
>>
>>
>> # vim: expandtab tabstop=4 shiftwidth=4
>>
>>> ----- Original Message -----
>>>> From: "Moti Asayag" <masayag at redhat.com>
>>>> To: "Alon Bar-Lev" <alonbl at redhat.com>
>>>> Cc: "engine-devel" <engine-devel at ovirt.org>
>>>> Sent: Thursday, June 27, 2013 12:11:23 PM
>>>> Subject: Re: [Engine-devel] [ATN][Action Required] development environemnt
>>>> users - otopi migration
>>>>
>>>> Hi,
>>>>
>>>> Just tried to run 'bin/engine-setup-2' with the latest version of otopi
>>>> (otopi-1.1.0-0.0.master.20130626.git33d9561.fc17.noarch) and failed due
>>>> to:
>>>>
>>>> [ ERROR ] Failed to execute stage 'Misc configuration': [Errno 13]
>>>> Permission denied: '/etc/ovirt-engine-setup.conf.d'
>>>>
>>>> OSError: [Errno **FILTERED**3] Permission denied:
>>>> '/etc/ovirt-engine-setup.conf.d'
>>>> 20**FILTERED**3-06-27 **FILTERED**2:04:36 ERROR otopi.context
>>>> context._executeMethod:**FILTERED**4**FILTERED** Failed to execute stage
>>>> 'Misc configuration': [Errno **FILTERED**3] Permission
>>>>  denied: '/etc/ovirt-engine-setup.conf.d'
>>>>
>>>> Log is attached.
>>>>
>>>> Thanks,
>>>> Moti
>>>>
>>>> On 06/26/2013 03:21 PM, Alon Bar-Lev wrote:
>>>>> Hello,
>>>>>
>>>>> We have pending patch queue that requires latest otopi-1.1 features. We
>>>>> held that queue so we reduce noise to peers.
>>>>>
>>>>> We would like now to merge this queue, it is best if you can upgrade to
>>>>> most recent otopi package before we merge to avoid breakage.
>>>>>
>>>>> Latest otopi packages are available at the standard locations[1][2][3]
>>>>>
>>>>> The minimum version required is otopi-1.1.0-0.0.master.20130626.
>>>>>
>>>>> I delay merge to ~24 hours.
>>>>>
>>>>> Of course if you have any issue, please don't hesitate to contact me.
>>>>>
>>>>> Thank you for your cooperation,
>>>>> Alon Bar-Lev
>>>>>
>>>>> [1] http://resources.ovirt.org/releases/nightly/rpm/Fedora/17
>>>>> [2] http://resources.ovirt.org/releases/nightly/rpm/Fedora/18
>>>>> [3] http://resources.ovirt.org/releases/nightly/rpm/EL/6/
>>>>> _______________________________________________
>>>>> Engine-devel mailing list
>>>>> Engine-devel at ovirt.org
>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>>>
>>>>
>>


-- 
Sandro Bonazzola
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com



From ecohen at redhat.com  Thu Jun 27 12:37:05 2013
From: ecohen at redhat.com (Einav Cohen)
Date: Thu, 27 Jun 2013 08:37:05 -0400 (EDT)
Subject: [Engine-devel] Sorting in tabs
In-Reply-To: <1283248469.4062177.1372330018886.JavaMail.root@redhat.com>
References: <51CBE5E1.7080900@redhat.com>
	<1283248469.4062177.1372330018886.JavaMail.root@redhat.com>
Message-ID: <351803689.9138087.1372336625516.JavaMail.root@redhat.com>

> ----- Original Message -----
> From: "Eli Mesika" <emesika at redhat.com>
> Sent: Thursday, June 27, 2013 6:46:58 AM
> 
> 
> ----- Original Message -----
> > From: "Lior Vernia" <lvernia at redhat.com>
> > To: engine-devel at ovirt.org
> > Sent: Thursday, June 27, 2013 10:12:33 AM
> > Subject: [Engine-devel] Sorting in tabs
> > 
> > Hello everyone (UI peeps in particular),
> > 
> > I've pushed (not yet merged) a patch that would enable us to keep items
> > in tabs (main/sub) sorted at all times by setting a comparator in
> > SearchableListModel:
> 
> But tabs includes only 100 records and supports paging , how you deal with
> that ???

if this is in the GUI level, then I assume that the comparator is simply comparing the 
items within the current page, and not "globally".
so the sorting doesn't affect the set of items that is displayed in the page (it would 
be the same as before the sorting) - just their order.

e.g. if I have VMs named "e", "a", "c" in page 1 and "f", "b", "d" in page 2, then with 
a comparator that is comparing by name (asc) you will see the following in page 1:
"a"
"c"
"e"
and the following in page 2:
"b"
"d"
"f"

However, I assume that in this case, we would ideally want to see the following in page 1:
"a"
"b"
"c"
and the following in page 2:
"d"
"e"
"f"

also: @Lior - what happens when the search query contains a "sort by" part? 
there is a chance that the behaivor would be unexpected in this case; 

I believe that the correct thing to do is to "attach" the GUI sorting mechanism 
to the one in the search mechanism.

thoughts?

> 
> 
> > 
> > http://gerrit.ovirt.org/#/c/15846/
> > 
> > If a comparator isn't set, then everything should behave as before. If a
> > comparator is set, then from that moment on the tab items will be kept
> > in a SortedSet, so that even if an item is added in a way that doesn't
> > trigger an event (e.g. getItems().add()) the items will be kept sorted
> > according to the given comparator. If the comparator is set to null,
> > from that moment on the tab should revert to its old behaviour.
> > 
> > You're most welcome to have a look and let me know if this might break
> > something (remember though that it's not obligatory to set a comparator,
> > so only possible breakage should be in generic flows).
> > 
> > Feel free to use it once it's merged; along with SortedListModel, this
> > should make sorting less painful. Just keep in mind that once you set a
> > comparator, you can't cast getItems() to a List. This shouldn't be a
> > problem in general, as mostly it's as useful (and probably more correct)
> > to cast to a Collection.
> > 
> > Lior.
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From emesika at redhat.com  Thu Jun 27 12:48:39 2013
From: emesika at redhat.com (Eli Mesika)
Date: Thu, 27 Jun 2013 08:48:39 -0400 (EDT)
Subject: [Engine-devel] SSH Soft Fencing
In-Reply-To: <1622219224.572748.1372330266360.JavaMail.root@redhat.com>
References: <1622219224.572748.1372330266360.JavaMail.root@redhat.com>
Message-ID: <1695008076.4096833.1372337319955.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Martin Perina" <mperina at redhat.com>
> To: engine-devel at ovirt.org
> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Barak Azulay" <bazulay at redhat.com>, "Eli Mesika" <emesika at redhat.com>
> Sent: Thursday, June 27, 2013 1:51:06 PM
> Subject: SSH Soft Fencing
> 
> Hi,
> 
> SSH Soft Fencing is a new feature for 3.3 and it tries to restart VDSM
> using SSH connection on non responsive hosts prior to real fencing.
> More info can be found at
> 
> http://www.ovirt.org/Automatic_Fencing#Automatic_Fencing_in_oVirt_3.3
> 
> In current SSH Soft Fencing implementation the restart VDSM using SSH
> command is part of standard fencing implementation in
> VdsNotRespondingTreatmentCommand. But this command is executed only
> if a host has a valid PM configuration. If host doesn't have a valid
> PM configuration, the execution of the command is disabled and host
> state is change to Non Responsive.
> 
> So my question are:
> 
> 1) Should SSH Soft Fencing be executed on hosts without valid PM
>    configuration?

I think that the answer should be yes. The vdsm restart will solve most of problems , so why not using it whether a PM agent is defined or not.

> 
> 2) Should VDSM restart using SSH command be reimplemented
>    as standalone command to be usable also in other parts of engine?
>    If 1) is true, I think it will have to be done anyway.

+1 

> 
> 
> Martin Perina
> 


From lvernia at redhat.com  Thu Jun 27 12:53:59 2013
From: lvernia at redhat.com (Lior Vernia)
Date: Thu, 27 Jun 2013 15:53:59 +0300
Subject: [Engine-devel] Sorting in tabs
In-Reply-To: <351803689.9138087.1372336625516.JavaMail.root@redhat.com>
References: <51CBE5E1.7080900@redhat.com>
	<1283248469.4062177.1372330018886.JavaMail.root@redhat.com>
	<351803689.9138087.1372336625516.JavaMail.root@redhat.com>
Message-ID: <51CC35E7.6030200@redhat.com>



On 27/06/13 15:37, Einav Cohen wrote:
>> ----- Original Message -----
>> From: "Eli Mesika" <emesika at redhat.com>
>> Sent: Thursday, June 27, 2013 6:46:58 AM
>>
>>
>> ----- Original Message -----
>>> From: "Lior Vernia" <lvernia at redhat.com>
>>> To: engine-devel at ovirt.org
>>> Sent: Thursday, June 27, 2013 10:12:33 AM
>>> Subject: [Engine-devel] Sorting in tabs
>>>
>>> Hello everyone (UI peeps in particular),
>>>
>>> I've pushed (not yet merged) a patch that would enable us to keep items
>>> in tabs (main/sub) sorted at all times by setting a comparator in
>>> SearchableListModel:
>>
>> But tabs includes only 100 records and supports paging , how you deal with
>> that ???
> 
> if this is in the GUI level, then I assume that the comparator is simply comparing the 
> items within the current page, and not "globally".
> so the sorting doesn't affect the set of items that is displayed in the page (it would 
> be the same as before the sorting) - just their order.

Yes, if I understand correctly how the paging works, Einav is correct -
only the items passed to the UI are sorted.

> also: @Lior - what happens when the search query contains a "sort by" part? 
> there is a chance that the behaivor would be unexpected in this case; 

Yes, I thought about this case, and it may result in a confusing user
experience if developers aren't careful. Together with the issue of
paging, this probably makes this sorting mechanism a better candidate
for use within subtabs rather than main tabs.

> 
> I believe that the correct thing to do is to "attach" the GUI sorting mechanism 
> to the one in the search mechanism.
> 
> thoughts?

This can be done, however I'm not sure there's much utility in it. Main
tabs are always sorted according to some default ordering even if one
was not entered in the search panel, and this sorting is also performed
consistently with respect to paging. So maybe the right thing to do
would be to just "block" the GUI sorting mechanism for main tabs (i.e.
override the setter method and make it no-op)?

>>
>>
>>>
>>> http://gerrit.ovirt.org/#/c/15846/
>>>
>>> If a comparator isn't set, then everything should behave as before. If a
>>> comparator is set, then from that moment on the tab items will be kept
>>> in a SortedSet, so that even if an item is added in a way that doesn't
>>> trigger an event (e.g. getItems().add()) the items will be kept sorted
>>> according to the given comparator. If the comparator is set to null,
>>> from that moment on the tab should revert to its old behaviour.
>>>
>>> You're most welcome to have a look and let me know if this might break
>>> something (remember though that it's not obligatory to set a comparator,
>>> so only possible breakage should be in generic flows).
>>>
>>> Feel free to use it once it's merged; along with SortedListModel, this
>>> should make sorting less painful. Just keep in mind that once you set a
>>> comparator, you can't cast getItems() to a List. This shouldn't be a
>>> problem in general, as mostly it's as useful (and probably more correct)
>>> to cast to a Collection.
>>>
>>> Lior.
>>> _______________________________________________
>>> Engine-devel mailing list
>>> Engine-devel at ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>


From ecohen at redhat.com  Thu Jun 27 13:42:18 2013
From: ecohen at redhat.com (Einav Cohen)
Date: Thu, 27 Jun 2013 09:42:18 -0400 (EDT)
Subject: [Engine-devel] Sorting in tabs
In-Reply-To: <51CC35E7.6030200@redhat.com>
References: <51CBE5E1.7080900@redhat.com>
	<1283248469.4062177.1372330018886.JavaMail.root@redhat.com>
	<351803689.9138087.1372336625516.JavaMail.root@redhat.com>
	<51CC35E7.6030200@redhat.com>
Message-ID: <1572668253.9189415.1372340538767.JavaMail.root@redhat.com>

> ----- Original Message -----
> From: "Lior Vernia" <lvernia at redhat.com>
> Sent: Thursday, June 27, 2013 8:53:59 AM
> 
> 
> 
> On 27/06/13 15:37, Einav Cohen wrote:
> >> ----- Original Message -----
> >> From: "Eli Mesika" <emesika at redhat.com>
> >> Sent: Thursday, June 27, 2013 6:46:58 AM
> >>
> >>
> >> ----- Original Message -----
> >>> From: "Lior Vernia" <lvernia at redhat.com>
> >>> To: engine-devel at ovirt.org
> >>> Sent: Thursday, June 27, 2013 10:12:33 AM
> >>> Subject: [Engine-devel] Sorting in tabs
> >>>
> >>> Hello everyone (UI peeps in particular),
> >>>
> >>> I've pushed (not yet merged) a patch that would enable us to keep items
> >>> in tabs (main/sub) sorted at all times by setting a comparator in
> >>> SearchableListModel:
> >>
> >> But tabs includes only 100 records and supports paging , how you deal with
> >> that ???
> > 
> > if this is in the GUI level, then I assume that the comparator is simply
> > comparing the
> > items within the current page, and not "globally".
> > so the sorting doesn't affect the set of items that is displayed in the
> > page (it would
> > be the same as before the sorting) - just their order.
> 
> Yes, if I understand correctly how the paging works, Einav is correct -
> only the items passed to the UI are sorted.
> 
> > also: @Lior - what happens when the search query contains a "sort by" part?
> > there is a chance that the behaivor would be unexpected in this case;
> 
> Yes, I thought about this case, and it may result in a confusing user
> experience if developers aren't careful. Together with the issue of
> paging, this probably makes this sorting mechanism a better candidate
> for use within subtabs rather than main tabs.

note that at some point, I think that we would want to introduce paging also to search-
based sub-tabs - it will be useful especially for sub-tabs that potentially display a 
large number of results (e.g. Disks sub-tab in Storage main tab). 
In addition, at some point, we would want to get rid of the paging UI as it is now 
(i.e. "next"/"prev" buttons at the top panel) and move to paging triggered by scroll 
(i.e. have a very long grid, dynamically loaded as you continue to scroll - similar 
to the behavior of some e-mail web-clients, for example). In this case, sorting on 
the client side will make no sense at all (i.e. from the user perspective, only a 
portion of a very large grid will be sorted, the other portions won't be).

So for now - yes, I think it makes sense to introduce your mechanism to all sub-tabs, 
however in the long-term - we would probably want the search-based sub-tabs (which 
will support paging) to move to search-based sorting, rather than GUI-based-sorting.

BTW (maybe the other GUI maintainers can help me with that one) - what about sub-tabs 
that are not search-based (i.e. display results from a "regular" query or even from a 
field within the selected item in the main grid, e.g. Applications in VM) - are these 
managed via SearchableListModel as well? since the comparator mechanism *is* relevant 
for them.

Also: Worth mentioning "Bug 893999 - webadmin: please allow column sorting", which 
requests to enable sorting when clicking on a grid-column header; when implementing 
column-sorting, probably worth attaching your mechanism to it somehow (i.e. clicking on 
a column header should set the relevant comparator in the relevant SearchableListModel).

> 
> > 
> > I believe that the correct thing to do is to "attach" the GUI sorting
> > mechanism
> > to the one in the search mechanism.
> > 
> > thoughts?
> 
> This can be done, however I'm not sure there's much utility in it. Main
> tabs are always sorted according to some default ordering even if one
> was not entered in the search panel, and this sorting is also performed
> consistently with respect to paging. So maybe the right thing to do
> would be to just "block" the GUI sorting mechanism for main tabs (i.e.
> override the setter method and make it no-op)?

yes, and related to what I mentioned above - at some point in the future, we'd might want 
to block it for search-based sub-tabs as well.

> 
> >>
> >>
> >>>
> >>> http://gerrit.ovirt.org/#/c/15846/
> >>>
> >>> If a comparator isn't set, then everything should behave as before. If a
> >>> comparator is set, then from that moment on the tab items will be kept
> >>> in a SortedSet, so that even if an item is added in a way that doesn't
> >>> trigger an event (e.g. getItems().add()) the items will be kept sorted
> >>> according to the given comparator. If the comparator is set to null,
> >>> from that moment on the tab should revert to its old behaviour.
> >>>
> >>> You're most welcome to have a look and let me know if this might break
> >>> something (remember though that it's not obligatory to set a comparator,
> >>> so only possible breakage should be in generic flows).
> >>>
> >>> Feel free to use it once it's merged; along with SortedListModel, this
> >>> should make sorting less painful. Just keep in mind that once you set a
> >>> comparator, you can't cast getItems() to a List. This shouldn't be a
> >>> problem in general, as mostly it's as useful (and probably more correct)
> >>> to cast to a Collection.
> >>>
> >>> Lior.
> >>> _______________________________________________
> >>> Engine-devel mailing list
> >>> Engine-devel at ovirt.org
> >>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> >>>
> >> _______________________________________________
> >> Engine-devel mailing list
> >> Engine-devel at ovirt.org
> >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> >>
> 


From emesika at redhat.com  Thu Jun 27 14:25:29 2013
From: emesika at redhat.com (Eli Mesika)
Date: Thu, 27 Jun 2013 10:25:29 -0400 (EDT)
Subject: [Engine-devel] Sorting in tabs
In-Reply-To: <1572668253.9189415.1372340538767.JavaMail.root@redhat.com>
References: <51CBE5E1.7080900@redhat.com>
	<1283248469.4062177.1372330018886.JavaMail.root@redhat.com>
	<351803689.9138087.1372336625516.JavaMail.root@redhat.com>
	<51CC35E7.6030200@redhat.com>
	<1572668253.9189415.1372340538767.JavaMail.root@redhat.com>
Message-ID: <1402119106.4158142.1372343129214.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Einav Cohen" <ecohen at redhat.com>
> To: "Lior Vernia" <lvernia at redhat.com>
> Cc: "Eli Mesika" <emesika at redhat.com>, engine-devel at ovirt.org, "Vojtech Szocs" <vszocs at redhat.com>, "Alexander Wels"
> <awels at redhat.com>, "Daniel Erez" <derez at redhat.com>, "Gilad Chaplik" <gchaplik at redhat.com>, "Alona Kaplan"
> <alkaplan at redhat.com>, "Tomas Jelinek" <tjelinek at redhat.com>
> Sent: Thursday, June 27, 2013 4:42:18 PM
> Subject: Re: [Engine-devel] Sorting in tabs
> 
> > ----- Original Message -----
> > From: "Lior Vernia" <lvernia at redhat.com>
> > Sent: Thursday, June 27, 2013 8:53:59 AM
> > 
> > 
> > 
> > On 27/06/13 15:37, Einav Cohen wrote:
> > >> ----- Original Message -----
> > >> From: "Eli Mesika" <emesika at redhat.com>
> > >> Sent: Thursday, June 27, 2013 6:46:58 AM
> > >>
> > >>
> > >> ----- Original Message -----
> > >>> From: "Lior Vernia" <lvernia at redhat.com>
> > >>> To: engine-devel at ovirt.org
> > >>> Sent: Thursday, June 27, 2013 10:12:33 AM
> > >>> Subject: [Engine-devel] Sorting in tabs
> > >>>
> > >>> Hello everyone (UI peeps in particular),
> > >>>
> > >>> I've pushed (not yet merged) a patch that would enable us to keep items
> > >>> in tabs (main/sub) sorted at all times by setting a comparator in
> > >>> SearchableListModel:
> > >>
> > >> But tabs includes only 100 records and supports paging , how you deal
> > >> with
> > >> that ???
> > > 
> > > if this is in the GUI level, then I assume that the comparator is simply
> > > comparing the
> > > items within the current page, and not "globally".
> > > so the sorting doesn't affect the set of items that is displayed in the
> > > page (it would
> > > be the same as before the sorting) - just their order.
> > 
> > Yes, if I understand correctly how the paging works, Einav is correct -
> > only the items passed to the UI are sorted.
> > 
> > > also: @Lior - what happens when the search query contains a "sort by"
> > > part?
> > > there is a chance that the behaivor would be unexpected in this case;
> > 
> > Yes, I thought about this case, and it may result in a confusing user
> > experience if developers aren't careful. Together with the issue of
> > paging, this probably makes this sorting mechanism a better candidate
> > for use within subtabs rather than main tabs.
> 
> note that at some point, I think that we would want to introduce paging also
> to search-
> based sub-tabs - it will be useful especially for sub-tabs that potentially
> display a
> large number of results (e.g. Disks sub-tab in Storage main tab).
> In addition, at some point, we would want to get rid of the paging UI as it
> is now
> (i.e. "next"/"prev" buttons at the top panel) and move to paging triggered by
> scroll
> (i.e. have a very long grid, dynamically loaded as you continue to scroll -
> similar
> to the behavior of some e-mail web-clients, for example). In this case,
> sorting on
> the client side will make no sense at all (i.e. from the user perspective,
> only a
> portion of a very large grid will be sorted, the other portions won't be).
> 
> So for now - yes, I think it makes sense to introduce your mechanism to all
> sub-tabs,
> however in the long-term - we would probably want the search-based sub-tabs
> (which
> will support paging) to move to search-based sorting, rather than
> GUI-based-sorting.
> 
> BTW (maybe the other GUI maintainers can help me with that one) - what about
> sub-tabs
> that are not search-based (i.e. display results from a "regular" query or
> even from a
> field within the selected item in the main grid, e.g. Applications in VM) -
> are these
> managed via SearchableListModel as well? since the comparator mechanism *is*
> relevant
> for them.
> 
> Also: Worth mentioning "Bug 893999 - webadmin: please allow column sorting",
> which
> requests to enable sorting when clicking on a grid-column header; when
> implementing
> column-sorting, probably worth attaching your mechanism to it somehow (i.e.
> clicking on
> a column header should set the relevant comparator in the relevant
> SearchableListModel).

I think that when we will implement column sorting it will fulfill all UI sorting requirements 
> 
> > 
> > > 
> > > I believe that the correct thing to do is to "attach" the GUI sorting
> > > mechanism
> > > to the one in the search mechanism.
> > > 
> > > thoughts?

But this should be visible , i.e. the search syntax should be changed to reflect this kind of sorting.

> > 
> > This can be done, however I'm not sure there's much utility in it. Main
> > tabs are always sorted according to some default ordering even if one
> > was not entered in the search panel, and this sorting is also performed
> > consistently with respect to paging. So maybe the right thing to do
> > would be to just "block" the GUI sorting mechanism for main tabs (i.e.
> > override the setter method and make it no-op)?
> 
> yes, and related to what I mentioned above - at some point in the future,
> we'd might want
> to block it for search-based sub-tabs as well.
> 
> > 
> > >>
> > >>
> > >>>
> > >>> http://gerrit.ovirt.org/#/c/15846/
> > >>>
> > >>> If a comparator isn't set, then everything should behave as before. If
> > >>> a
> > >>> comparator is set, then from that moment on the tab items will be kept
> > >>> in a SortedSet, so that even if an item is added in a way that doesn't
> > >>> trigger an event (e.g. getItems().add()) the items will be kept sorted
> > >>> according to the given comparator. If the comparator is set to null,
> > >>> from that moment on the tab should revert to its old behaviour.
> > >>>
> > >>> You're most welcome to have a look and let me know if this might break
> > >>> something (remember though that it's not obligatory to set a
> > >>> comparator,
> > >>> so only possible breakage should be in generic flows).
> > >>>
> > >>> Feel free to use it once it's merged; along with SortedListModel, this
> > >>> should make sorting less painful. Just keep in mind that once you set a
> > >>> comparator, you can't cast getItems() to a List. This shouldn't be a
> > >>> problem in general, as mostly it's as useful (and probably more
> > >>> correct)
> > >>> to cast to a Collection.
> > >>>
> > >>> Lior.
> > >>> _______________________________________________
> > >>> Engine-devel mailing list
> > >>> Engine-devel at ovirt.org
> > >>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> > >>>
> > >> _______________________________________________
> > >> Engine-devel mailing list
> > >> Engine-devel at ovirt.org
> > >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> > >>
> > 
> 


From lvernia at redhat.com  Thu Jun 27 14:38:04 2013
From: lvernia at redhat.com (Lior Vernia)
Date: Thu, 27 Jun 2013 17:38:04 +0300
Subject: [Engine-devel] Sorting in tabs
In-Reply-To: <1572668253.9189415.1372340538767.JavaMail.root@redhat.com>
References: <51CBE5E1.7080900@redhat.com>
	<1283248469.4062177.1372330018886.JavaMail.root@redhat.com>
	<351803689.9138087.1372336625516.JavaMail.root@redhat.com>
	<51CC35E7.6030200@redhat.com>
	<1572668253.9189415.1372340538767.JavaMail.root@redhat.com>
Message-ID: <51CC4E4C.4030507@redhat.com>



On 27/06/13 16:42, Einav Cohen wrote:
>> ----- Original Message -----
>> From: "Lior Vernia" <lvernia at redhat.com>
>> Sent: Thursday, June 27, 2013 8:53:59 AM
>>
>>
>>
>> On 27/06/13 15:37, Einav Cohen wrote:
>>>> ----- Original Message -----
>>>> From: "Eli Mesika" <emesika at redhat.com>
>>>> Sent: Thursday, June 27, 2013 6:46:58 AM
>>>>
>>>>
>>>> ----- Original Message -----
>>>>> From: "Lior Vernia" <lvernia at redhat.com>
>>>>> To: engine-devel at ovirt.org
>>>>> Sent: Thursday, June 27, 2013 10:12:33 AM
>>>>> Subject: [Engine-devel] Sorting in tabs
>>>>>
>>>>> Hello everyone (UI peeps in particular),
>>>>>
>>>>> I've pushed (not yet merged) a patch that would enable us to keep items
>>>>> in tabs (main/sub) sorted at all times by setting a comparator in
>>>>> SearchableListModel:
>>>>
>>>> But tabs includes only 100 records and supports paging , how you deal with
>>>> that ???
>>>
>>> if this is in the GUI level, then I assume that the comparator is simply
>>> comparing the
>>> items within the current page, and not "globally".
>>> so the sorting doesn't affect the set of items that is displayed in the
>>> page (it would
>>> be the same as before the sorting) - just their order.
>>
>> Yes, if I understand correctly how the paging works, Einav is correct -
>> only the items passed to the UI are sorted.
>>
>>> also: @Lior - what happens when the search query contains a "sort by" part?
>>> there is a chance that the behaivor would be unexpected in this case;
>>
>> Yes, I thought about this case, and it may result in a confusing user
>> experience if developers aren't careful. Together with the issue of
>> paging, this probably makes this sorting mechanism a better candidate
>> for use within subtabs rather than main tabs.
> 
> note that at some point, I think that we would want to introduce paging also to search-
> based sub-tabs - it will be useful especially for sub-tabs that potentially display a 
> large number of results (e.g. Disks sub-tab in Storage main tab). 
> In addition, at some point, we would want to get rid of the paging UI as it is now 
> (i.e. "next"/"prev" buttons at the top panel) and move to paging triggered by scroll 
> (i.e. have a very long grid, dynamically loaded as you continue to scroll - similar 
> to the behavior of some e-mail web-clients, for example). In this case, sorting on 
> the client side will make no sense at all (i.e. from the user perspective, only a 
> portion of a very large grid will be sorted, the other portions won't be).
> 
> So for now - yes, I think it makes sense to introduce your mechanism to all sub-tabs, 
> however in the long-term - we would probably want the search-based sub-tabs (which 
> will support paging) to move to search-based sorting, rather than GUI-based-sorting.

Sounds good to me. Let me just re-iterate that it is not mandatory to
set a comparator, so in technical terms it's not even necessary to
introduce it at once to all sub-tabs, if they're already sorting their
items some other way. It could happen gradually, and only if developers
find it more convenient. In either case, dropping the GUI sorting once
search-based sorting is implemented shouldn't be difficult.

> BTW (maybe the other GUI maintainers can help me with that one) - what about sub-tabs 
> that are not search-based (i.e. display results from a "regular" query or even from a 
> field within the selected item in the main grid, e.g. Applications in VM) - are these 
> managed via SearchableListModel as well? since the comparator mechanism *is* relevant 
> for them.

As far as I've seen, some are managed via SearchableListModel and some
aren't. Those that aren't are those that display non-trivial behaviour
upon receipt of the items to display (setItems() method) - often this
non-trivial behaviour is exactly sorting :) And if it's doing its job,
then there's no necessity to change it either. But anyway, I don't know
all of them, so I'd also love to hear GUI maintainers.

> Also: Worth mentioning "Bug 893999 - webadmin: please allow column sorting", which 
> requests to enable sorting when clicking on a grid-column header; when implementing 
> column-sorting, probably worth attaching your mechanism to it somehow (i.e. clicking on 
> a column header should set the relevant comparator in the relevant SearchableListModel).

I didn't want to say it, because if we upgrade to a newer version of GWT
then we could probably use their table column sorting. But this
mechanism could allow us to achieve this without upgrading, and it was
definitely sitting in the back of my head when I implemented it. All
that's needed is, as you said, to listen to table header clicks in the
view, and then appropriately set the comparator in the model.

>>
>>>
>>> I believe that the correct thing to do is to "attach" the GUI sorting
>>> mechanism
>>> to the one in the search mechanism.
>>>
>>> thoughts?
>>
>> This can be done, however I'm not sure there's much utility in it. Main
>> tabs are always sorted according to some default ordering even if one
>> was not entered in the search panel, and this sorting is also performed
>> consistently with respect to paging. So maybe the right thing to do
>> would be to just "block" the GUI sorting mechanism for main tabs (i.e.
>> override the setter method and make it no-op)?
> 
> yes, and related to what I mentioned above - at some point in the future, we'd might want 
> to block it for search-based sub-tabs as well.
> 
>>
>>>>
>>>>
>>>>>
>>>>> http://gerrit.ovirt.org/#/c/15846/
>>>>>
>>>>> If a comparator isn't set, then everything should behave as before. If a
>>>>> comparator is set, then from that moment on the tab items will be kept
>>>>> in a SortedSet, so that even if an item is added in a way that doesn't
>>>>> trigger an event (e.g. getItems().add()) the items will be kept sorted
>>>>> according to the given comparator. If the comparator is set to null,
>>>>> from that moment on the tab should revert to its old behaviour.
>>>>>
>>>>> You're most welcome to have a look and let me know if this might break
>>>>> something (remember though that it's not obligatory to set a comparator,
>>>>> so only possible breakage should be in generic flows).
>>>>>
>>>>> Feel free to use it once it's merged; along with SortedListModel, this
>>>>> should make sorting less painful. Just keep in mind that once you set a
>>>>> comparator, you can't cast getItems() to a List. This shouldn't be a
>>>>> problem in general, as mostly it's as useful (and probably more correct)
>>>>> to cast to a Collection.
>>>>>
>>>>> Lior.
>>>>> _______________________________________________
>>>>> Engine-devel mailing list
>>>>> Engine-devel at ovirt.org
>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>>>
>>>> _______________________________________________
>>>> Engine-devel mailing list
>>>> Engine-devel at ovirt.org
>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>>
>>


From yzaslavs at redhat.com  Thu Jun 27 14:43:17 2013
From: yzaslavs at redhat.com (Yair Zaslavsky)
Date: Thu, 27 Jun 2013 10:43:17 -0400 (EDT)
Subject: [Engine-devel] SSH Soft Fencing
In-Reply-To: <1695008076.4096833.1372337319955.JavaMail.root@redhat.com>
References: <1622219224.572748.1372330266360.JavaMail.root@redhat.com>
	<1695008076.4096833.1372337319955.JavaMail.root@redhat.com>
Message-ID: <12227690.29409642.1372344197624.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Eli Mesika" <emesika at redhat.com>
> To: "Martin Perina" <mperina at redhat.com>
> Cc: engine-devel at ovirt.org, "Yair Zaslavsky" <yzaslavs at redhat.com>, "Barak Azulay" <bazulay at redhat.com>
> Sent: Thursday, June 27, 2013 3:48:39 PM
> Subject: Re: SSH Soft Fencing
> 
> 
> 
> ----- Original Message -----
> > From: "Martin Perina" <mperina at redhat.com>
> > To: engine-devel at ovirt.org
> > Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Barak Azulay"
> > <bazulay at redhat.com>, "Eli Mesika" <emesika at redhat.com>
> > Sent: Thursday, June 27, 2013 1:51:06 PM
> > Subject: SSH Soft Fencing
> > 
> > Hi,
> > 
> > SSH Soft Fencing is a new feature for 3.3 and it tries to restart VDSM
> > using SSH connection on non responsive hosts prior to real fencing.
> > More info can be found at
> > 
> > http://www.ovirt.org/Automatic_Fencing#Automatic_Fencing_in_oVirt_3.3
> > 
> > In current SSH Soft Fencing implementation the restart VDSM using SSH
> > command is part of standard fencing implementation in
> > VdsNotRespondingTreatmentCommand. But this command is executed only
> > if a host has a valid PM configuration. If host doesn't have a valid
> > PM configuration, the execution of the command is disabled and host
> > state is change to Non Responsive.
> > 
> > So my question are:
> > 
> > 1) Should SSH Soft Fencing be executed on hosts without valid PM
> >    configuration?
> 
> I think that the answer should be yes. The vdsm restart will solve most of
> problems , so why not using it whether a PM agent is defined or not.
I agree.
I would like to say that I also don't like the fact that VdsNotRespondingTreatment extends RestartVdsCommand.
One should ask if "non responding treatment is a restart vds operation" or maybe RestartVdsCommand is just a step in the non responding treatment (inheritance vs containment/delegation).
I think that VdsNotRespodingTreatment should delegate the call to RestartVdsCommand as the 2nd step after issuing the Soft Fencing command.
Thoughts anyone?

> 
> > 
> > 2) Should VDSM restart using SSH command be reimplemented
> >    as standalone command to be usable also in other parts of engine?
> >    If 1) is true, I think it will have to be done anyway.

I agree here. 
> 
> +1
> 
> > 
> > 
> > Martin Perina
> > 
> 


From emesika at redhat.com  Thu Jun 27 14:55:29 2013
From: emesika at redhat.com (Eli Mesika)
Date: Thu, 27 Jun 2013 10:55:29 -0400 (EDT)
Subject: [Engine-devel] SSH Soft Fencing
In-Reply-To: <12227690.29409642.1372344197624.JavaMail.root@redhat.com>
References: <1622219224.572748.1372330266360.JavaMail.root@redhat.com>
	<1695008076.4096833.1372337319955.JavaMail.root@redhat.com>
	<12227690.29409642.1372344197624.JavaMail.root@redhat.com>
Message-ID: <1625820710.4175423.1372344929287.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Yair Zaslavsky" <yzaslavs at redhat.com>
> To: "Eli Mesika" <emesika at redhat.com>
> Cc: "Martin Perina" <mperina at redhat.com>, engine-devel at ovirt.org, "Barak Azulay" <bazulay at redhat.com>
> Sent: Thursday, June 27, 2013 5:43:17 PM
> Subject: Re: SSH Soft Fencing
> 
> 
> 
> ----- Original Message -----
> > From: "Eli Mesika" <emesika at redhat.com>
> > To: "Martin Perina" <mperina at redhat.com>
> > Cc: engine-devel at ovirt.org, "Yair Zaslavsky" <yzaslavs at redhat.com>, "Barak
> > Azulay" <bazulay at redhat.com>
> > Sent: Thursday, June 27, 2013 3:48:39 PM
> > Subject: Re: SSH Soft Fencing
> > 
> > 
> > 
> > ----- Original Message -----
> > > From: "Martin Perina" <mperina at redhat.com>
> > > To: engine-devel at ovirt.org
> > > Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Barak Azulay"
> > > <bazulay at redhat.com>, "Eli Mesika" <emesika at redhat.com>
> > > Sent: Thursday, June 27, 2013 1:51:06 PM
> > > Subject: SSH Soft Fencing
> > > 
> > > Hi,
> > > 
> > > SSH Soft Fencing is a new feature for 3.3 and it tries to restart VDSM
> > > using SSH connection on non responsive hosts prior to real fencing.
> > > More info can be found at
> > > 
> > > http://www.ovirt.org/Automatic_Fencing#Automatic_Fencing_in_oVirt_3.3
> > > 
> > > In current SSH Soft Fencing implementation the restart VDSM using SSH
> > > command is part of standard fencing implementation in
> > > VdsNotRespondingTreatmentCommand. But this command is executed only
> > > if a host has a valid PM configuration. If host doesn't have a valid
> > > PM configuration, the execution of the command is disabled and host
> > > state is change to Non Responsive.
> > > 
> > > So my question are:
> > > 
> > > 1) Should SSH Soft Fencing be executed on hosts without valid PM
> > >    configuration?
> > 
> > I think that the answer should be yes. The vdsm restart will solve most of
> > problems , so why not using it whether a PM agent is defined or not.
> I agree.
> I would like to say that I also don't like the fact that
> VdsNotRespondingTreatment extends RestartVdsCommand.
> One should ask if "non responding treatment is a restart vds operation" or
> maybe RestartVdsCommand is just a step in the non responding treatment
> (inheritance vs containment/delegation).
> I think that VdsNotRespodingTreatment should delegate the call to
> RestartVdsCommand as the 2nd step after issuing the Soft Fencing command.
> Thoughts anyone?

That would be a nice and needed re-factoring 

> 
> > 
> > > 
> > > 2) Should VDSM restart using SSH command be reimplemented
> > >    as standalone command to be usable also in other parts of engine?
> > >    If 1) is true, I think it will have to be done anyway.
> 
> I agree here.
> > 
> > +1
> > 
> > > 
> > > 
> > > Martin Perina
> > > 
> > 
> 


From ecohen at redhat.com  Thu Jun 27 15:15:29 2013
From: ecohen at redhat.com (Einav Cohen)
Date: Thu, 27 Jun 2013 11:15:29 -0400 (EDT)
Subject: [Engine-devel] Sorting in tabs
In-Reply-To: <51CC4E4C.4030507@redhat.com>
References: <51CBE5E1.7080900@redhat.com>
	<1283248469.4062177.1372330018886.JavaMail.root@redhat.com>
	<351803689.9138087.1372336625516.JavaMail.root@redhat.com>
	<51CC35E7.6030200@redhat.com>
	<1572668253.9189415.1372340538767.JavaMail.root@redhat.com>
	<51CC4E4C.4030507@redhat.com>
Message-ID: <1796469050.9281535.1372346129622.JavaMail.root@redhat.com>

> ----- Original Message -----
> From: "Lior Vernia" <lvernia at redhat.com>
> Sent: Thursday, June 27, 2013 10:38:04 AM
> 
> 
> 
> On 27/06/13 16:42, Einav Cohen wrote:
> >> ----- Original Message -----
> >> From: "Lior Vernia" <lvernia at redhat.com>
> >> Sent: Thursday, June 27, 2013 8:53:59 AM
> >>
> >>
> >>
> >> On 27/06/13 15:37, Einav Cohen wrote:
> >>>> ----- Original Message -----
> >>>> From: "Eli Mesika" <emesika at redhat.com>
> >>>> Sent: Thursday, June 27, 2013 6:46:58 AM
> >>>>
> >>>>
> >>>> ----- Original Message -----
> >>>>> From: "Lior Vernia" <lvernia at redhat.com>
> >>>>> To: engine-devel at ovirt.org
> >>>>> Sent: Thursday, June 27, 2013 10:12:33 AM
> >>>>> Subject: [Engine-devel] Sorting in tabs
> >>>>>
> >>>>> Hello everyone (UI peeps in particular),
> >>>>>
> >>>>> I've pushed (not yet merged) a patch that would enable us to keep items
> >>>>> in tabs (main/sub) sorted at all times by setting a comparator in
> >>>>> SearchableListModel:
> >>>>
> >>>> But tabs includes only 100 records and supports paging , how you deal
> >>>> with
> >>>> that ???
> >>>
> >>> if this is in the GUI level, then I assume that the comparator is simply
> >>> comparing the
> >>> items within the current page, and not "globally".
> >>> so the sorting doesn't affect the set of items that is displayed in the
> >>> page (it would
> >>> be the same as before the sorting) - just their order.
> >>
> >> Yes, if I understand correctly how the paging works, Einav is correct -
> >> only the items passed to the UI are sorted.
> >>
> >>> also: @Lior - what happens when the search query contains a "sort by"
> >>> part?
> >>> there is a chance that the behaivor would be unexpected in this case;
> >>
> >> Yes, I thought about this case, and it may result in a confusing user
> >> experience if developers aren't careful. Together with the issue of
> >> paging, this probably makes this sorting mechanism a better candidate
> >> for use within subtabs rather than main tabs.
> > 
> > note that at some point, I think that we would want to introduce paging
> > also to search-
> > based sub-tabs - it will be useful especially for sub-tabs that potentially
> > display a
> > large number of results (e.g. Disks sub-tab in Storage main tab).
> > In addition, at some point, we would want to get rid of the paging UI as it
> > is now
> > (i.e. "next"/"prev" buttons at the top panel) and move to paging triggered
> > by scroll
> > (i.e. have a very long grid, dynamically loaded as you continue to scroll -
> > similar
> > to the behavior of some e-mail web-clients, for example). In this case,
> > sorting on
> > the client side will make no sense at all (i.e. from the user perspective,
> > only a
> > portion of a very large grid will be sorted, the other portions won't be).
> > 
> > So for now - yes, I think it makes sense to introduce your mechanism to all
> > sub-tabs,
> > however in the long-term - we would probably want the search-based sub-tabs
> > (which
> > will support paging) to move to search-based sorting, rather than
> > GUI-based-sorting.
> 
> Sounds good to me. Let me just re-iterate that it is not mandatory to
> set a comparator, so in technical terms it's not even necessary to
> introduce it at once to all sub-tabs, if they're already sorting their
> items some other way. It could happen gradually, and only if developers
> find it more convenient. In either case, dropping the GUI sorting once
> search-based sorting is implemented shouldn't be difficult.
> 
> > BTW (maybe the other GUI maintainers can help me with that one) - what
> > about sub-tabs
> > that are not search-based (i.e. display results from a "regular" query or
> > even from a
> > field within the selected item in the main grid, e.g. Applications in VM) -
> > are these
> > managed via SearchableListModel as well? since the comparator mechanism
> > *is* relevant
> > for them.
> 
> As far as I've seen, some are managed via SearchableListModel and some
> aren't. Those that aren't are those that display non-trivial behaviour
> upon receipt of the items to display (setItems() method) - often this
> non-trivial behaviour is exactly sorting :) And if it's doing its job,
> then there's no necessity to change it either. But anyway, I don't know
> all of them, so I'd also love to hear GUI maintainers.
> 
> > Also: Worth mentioning "Bug 893999 - webadmin: please allow column
> > sorting", which
> > requests to enable sorting when clicking on a grid-column header; when
> > implementing
> > column-sorting, probably worth attaching your mechanism to it somehow (i.e.
> > clicking on
> > a column header should set the relevant comparator in the relevant
> > SearchableListModel).
> 
> I didn't want to say it, because if we upgrade to a newer version of GWT
> then we could probably use their table column sorting. But this
> mechanism could allow us to achieve this without upgrading, and it was
> definitely sitting in the back of my head when I implemented it. All
> that's needed is, as you said, to listen to table header clicks in the
> view, and then appropriately set the comparator in the model.
> 

[Vojtech/GUI-maintainers - your input would be appreciated here]

we are actually planning on upgrading the GWT version *really* soon (to GWT 2.5), 
so my question is: should we wait until the new GWT is introduced, and implement 
client-sorting based on the GWT-grid-widget built-in mechanism (assuming there is 
one)?
also, not sure if it is better to utilize the widget default-built-in sorting mechanism 
(which doesn't manipulate the uicommon model data at all), or if it is better to utilize 
your comparator mechanism, which manipulates the uicommon model data, and the GUI-widget 
just reflects this data at any given time. 
thoughts?

> >>
> >>>
> >>> I believe that the correct thing to do is to "attach" the GUI sorting
> >>> mechanism
> >>> to the one in the search mechanism.
> >>>
> >>> thoughts?
> >>
> >> This can be done, however I'm not sure there's much utility in it. Main
> >> tabs are always sorted according to some default ordering even if one
> >> was not entered in the search panel, and this sorting is also performed
> >> consistently with respect to paging. So maybe the right thing to do
> >> would be to just "block" the GUI sorting mechanism for main tabs (i.e.
> >> override the setter method and make it no-op)?
> > 
> > yes, and related to what I mentioned above - at some point in the future,
> > we'd might want
> > to block it for search-based sub-tabs as well.
> > 
> >>
> >>>>
> >>>>
> >>>>>
> >>>>> http://gerrit.ovirt.org/#/c/15846/
> >>>>>
> >>>>> If a comparator isn't set, then everything should behave as before. If
> >>>>> a
> >>>>> comparator is set, then from that moment on the tab items will be kept
> >>>>> in a SortedSet, so that even if an item is added in a way that doesn't
> >>>>> trigger an event (e.g. getItems().add()) the items will be kept sorted
> >>>>> according to the given comparator. If the comparator is set to null,
> >>>>> from that moment on the tab should revert to its old behaviour.
> >>>>>
> >>>>> You're most welcome to have a look and let me know if this might break
> >>>>> something (remember though that it's not obligatory to set a
> >>>>> comparator,
> >>>>> so only possible breakage should be in generic flows).
> >>>>>
> >>>>> Feel free to use it once it's merged; along with SortedListModel, this
> >>>>> should make sorting less painful. Just keep in mind that once you set a
> >>>>> comparator, you can't cast getItems() to a List. This shouldn't be a
> >>>>> problem in general, as mostly it's as useful (and probably more
> >>>>> correct)
> >>>>> to cast to a Collection.
> >>>>>
> >>>>> Lior.
> >>>>> _______________________________________________
> >>>>> Engine-devel mailing list
> >>>>> Engine-devel at ovirt.org
> >>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> >>>>>
> >>>> _______________________________________________
> >>>> Engine-devel mailing list
> >>>> Engine-devel at ovirt.org
> >>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> >>>>
> >>
> 


From ecohen at redhat.com  Thu Jun 27 16:01:13 2013
From: ecohen at redhat.com (Einav Cohen)
Date: Thu, 27 Jun 2013 12:01:13 -0400 (EDT)
Subject: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
In-Reply-To: <2114201154.2496221.1372326631963.JavaMail.root@redhat.com>
References: <501973842.20255318.1371648804880.JavaMail.root@redhat.com>
	<936279456.20836092.1371730386788.JavaMail.root@redhat.com>
	<51C2F54C.60409@redhat.com>
	<6609F396-8D78-46FB-9F2D-3700D769B5E9@redhat.com>
	<20130624094735.GC1849@teriyaki.cdg.redhat.com>
	<1210717020.2488959.1372324871664.JavaMail.root@redhat.com>
	<20130627093010.GC13576@teriyaki.redhat.com>
	<2114201154.2496221.1372326631963.JavaMail.root@redhat.com>
Message-ID: <2874260.9314218.1372348873189.JavaMail.root@redhat.com>

Hi Tomas,

> Yes, we can provide the sessionId to authenticate with the REST and the vm
> guid is not a problem.

Note that in the web-admin, we already have code that generates REST API session-ID;
this code is being utilized in the ui-plugins infrastructure to allow the different 
ui-plugins to communicate with the rest api.
[one related file is this context is RestApiSessionManager.java in the web-admin, not 
sure if there are others]

maybe the RestApiSessionManager(?) can somehow be utilized for the SPICE purpose as well 
(I guess that it will require a couple of code-changes though, and maybe worth moving it 
to gwt-common, to allow its utilization from the user portal as well?) - @Vojtech would 
probably know best to advise on this.

* Note: Today:
(a) a *single* REST API session-ID is generated and used across all ui-plugins in the system 
(upon user login to the web-admin).

(b) this REST-API session-ID is generated based on the *same credentials* with which the user 
logged into the web-admin.

both (a) and (b) will change once [1] will be addressed. 
Only for the SPICE case in particular - I think that (b) should remain. so maybe worth allowing 
both same-credentials-login and different-credentials-login in the REST-API-Session-ID-generation 
code in the GUI.

----
Thanks,
Einav

[1] Bug 962863 - RFE: Improve REST API integration for UI Plugins
https://bugzilla.redhat.com/show_bug.cgi?id=962863
some of the planned changes (from the BZ description):
"""
...
- each UI plugin will have its own dedicated REST API session, unrelated to GUI (admin) 
user credentials
...
"""

> ----- Original Message -----
> From: "Tomas Jelinek" <tjelinek at redhat.com>
> Sent: Thursday, June 27, 2013 5:50:31 AM
> 
> 
> 
> ----- Original Message -----
> > From: "Christophe Fergeau" <cfergeau at redhat.com>
> > To: "Tomas Jelinek" <tjelinek at redhat.com>
> > Cc: "Michal Skrivanek" <michal.skrivanek at redhat.com>, "Itamar Heim"
> > <iheim at redhat.com>,
> > spice-devel at lists.freedesktop.org, "engine-devel" <engine-devel at ovirt.org>,
> > "Marc-Andr? Lureau" <mlureau at redhat.com>
> > Sent: Thursday, June 27, 2013 11:30:10 AM
> > Subject: Re: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
> > 
> > Hey,
> > 
> > On Thu, Jun 27, 2013 at 05:21:11AM -0400, Tomas Jelinek wrote:
> > > well, it seems that everyone agree that the decision what to add to the
> > > menu is the client responsibility. It means there is no additional work
> > > needed on the
> > > oVirt engine side - going to remove the feature page.
> > 
> > If we go the REST API way to handle foreign menu, we need additional info
> > in the .vv files: some way to auth with the REST API, and the guid of the
> > VM to act on.
> Yes, we can provide the sessionId to authenticate with the REST and the vm
> guid is not a problem.
> 
> > 
> > Christophe
> > 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
> 
>


From lvernia at redhat.com  Thu Jun 27 16:15:14 2013
From: lvernia at redhat.com (Lior Vernia)
Date: Thu, 27 Jun 2013 19:15:14 +0300
Subject: [Engine-devel] Sorting in tabs
In-Reply-To: <1796469050.9281535.1372346129622.JavaMail.root@redhat.com>
References: <51CBE5E1.7080900@redhat.com>
	<1283248469.4062177.1372330018886.JavaMail.root@redhat.com>
	<351803689.9138087.1372336625516.JavaMail.root@redhat.com>
	<51CC35E7.6030200@redhat.com>
	<1572668253.9189415.1372340538767.JavaMail.root@redhat.com>
	<51CC4E4C.4030507@redhat.com>
	<1796469050.9281535.1372346129622.JavaMail.root@redhat.com>
Message-ID: <51CC6512.50509@redhat.com>



On 27/06/13 18:15, Einav Cohen wrote:
>> ----- Original Message -----
>> From: "Lior Vernia" <lvernia at redhat.com>
>> Sent: Thursday, June 27, 2013 10:38:04 AM
>>
>>
>>
>> On 27/06/13 16:42, Einav Cohen wrote:
>>>> ----- Original Message -----
>>>> From: "Lior Vernia" <lvernia at redhat.com>
>>>> Sent: Thursday, June 27, 2013 8:53:59 AM
>>>>
>>>>
>>>>
>>>> On 27/06/13 15:37, Einav Cohen wrote:
>>>>>> ----- Original Message -----
>>>>>> From: "Eli Mesika" <emesika at redhat.com>
>>>>>> Sent: Thursday, June 27, 2013 6:46:58 AM
>>>>>>
>>>>>>
>>>>>> ----- Original Message -----
>>>>>>> From: "Lior Vernia" <lvernia at redhat.com>
>>>>>>> To: engine-devel at ovirt.org
>>>>>>> Sent: Thursday, June 27, 2013 10:12:33 AM
>>>>>>> Subject: [Engine-devel] Sorting in tabs
>>>>>>>
>>>>>>> Hello everyone (UI peeps in particular),
>>>>>>>
>>>>>>> I've pushed (not yet merged) a patch that would enable us to keep items
>>>>>>> in tabs (main/sub) sorted at all times by setting a comparator in
>>>>>>> SearchableListModel:
>>>>>>
>>>>>> But tabs includes only 100 records and supports paging , how you deal
>>>>>> with
>>>>>> that ???
>>>>>
>>>>> if this is in the GUI level, then I assume that the comparator is simply
>>>>> comparing the
>>>>> items within the current page, and not "globally".
>>>>> so the sorting doesn't affect the set of items that is displayed in the
>>>>> page (it would
>>>>> be the same as before the sorting) - just their order.
>>>>
>>>> Yes, if I understand correctly how the paging works, Einav is correct -
>>>> only the items passed to the UI are sorted.
>>>>
>>>>> also: @Lior - what happens when the search query contains a "sort by"
>>>>> part?
>>>>> there is a chance that the behaivor would be unexpected in this case;
>>>>
>>>> Yes, I thought about this case, and it may result in a confusing user
>>>> experience if developers aren't careful. Together with the issue of
>>>> paging, this probably makes this sorting mechanism a better candidate
>>>> for use within subtabs rather than main tabs.
>>>
>>> note that at some point, I think that we would want to introduce paging
>>> also to search-
>>> based sub-tabs - it will be useful especially for sub-tabs that potentially
>>> display a
>>> large number of results (e.g. Disks sub-tab in Storage main tab).
>>> In addition, at some point, we would want to get rid of the paging UI as it
>>> is now
>>> (i.e. "next"/"prev" buttons at the top panel) and move to paging triggered
>>> by scroll
>>> (i.e. have a very long grid, dynamically loaded as you continue to scroll -
>>> similar
>>> to the behavior of some e-mail web-clients, for example). In this case,
>>> sorting on
>>> the client side will make no sense at all (i.e. from the user perspective,
>>> only a
>>> portion of a very large grid will be sorted, the other portions won't be).
>>>
>>> So for now - yes, I think it makes sense to introduce your mechanism to all
>>> sub-tabs,
>>> however in the long-term - we would probably want the search-based sub-tabs
>>> (which
>>> will support paging) to move to search-based sorting, rather than
>>> GUI-based-sorting.
>>
>> Sounds good to me. Let me just re-iterate that it is not mandatory to
>> set a comparator, so in technical terms it's not even necessary to
>> introduce it at once to all sub-tabs, if they're already sorting their
>> items some other way. It could happen gradually, and only if developers
>> find it more convenient. In either case, dropping the GUI sorting once
>> search-based sorting is implemented shouldn't be difficult.
>>
>>> BTW (maybe the other GUI maintainers can help me with that one) - what
>>> about sub-tabs
>>> that are not search-based (i.e. display results from a "regular" query or
>>> even from a
>>> field within the selected item in the main grid, e.g. Applications in VM) -
>>> are these
>>> managed via SearchableListModel as well? since the comparator mechanism
>>> *is* relevant
>>> for them.
>>
>> As far as I've seen, some are managed via SearchableListModel and some
>> aren't. Those that aren't are those that display non-trivial behaviour
>> upon receipt of the items to display (setItems() method) - often this
>> non-trivial behaviour is exactly sorting :) And if it's doing its job,
>> then there's no necessity to change it either. But anyway, I don't know
>> all of them, so I'd also love to hear GUI maintainers.
>>
>>> Also: Worth mentioning "Bug 893999 - webadmin: please allow column
>>> sorting", which
>>> requests to enable sorting when clicking on a grid-column header; when
>>> implementing
>>> column-sorting, probably worth attaching your mechanism to it somehow (i.e.
>>> clicking on
>>> a column header should set the relevant comparator in the relevant
>>> SearchableListModel).
>>
>> I didn't want to say it, because if we upgrade to a newer version of GWT
>> then we could probably use their table column sorting. But this
>> mechanism could allow us to achieve this without upgrading, and it was
>> definitely sitting in the back of my head when I implemented it. All
>> that's needed is, as you said, to listen to table header clicks in the
>> view, and then appropriately set the comparator in the model.
>>
> 
> [Vojtech/GUI-maintainers - your input would be appreciated here]
> 
> we are actually planning on upgrading the GWT version *really* soon (to GWT 2.5), 
> so my question is: should we wait until the new GWT is introduced, and implement 
> client-sorting based on the GWT-grid-widget built-in mechanism (assuming there is 
> one)?
> also, not sure if it is better to utilize the widget default-built-in sorting mechanism 
> (which doesn't manipulate the uicommon model data at all), or if it is better to utilize 
> your comparator mechanism, which manipulates the uicommon model data, and the GUI-widget 
> just reflects this data at any given time. 
> thoughts?

I'll just give my two cents concerning this and then let others have the
stage: I don't think it really matters.

Manipulating the models directly is supposedly more portable in case we
ever move away from GWT, but we'd still have the pain of adding new
listeners to the new framework's table headers which could be just as
bad as using its sorting mechanism.

Graphically, the UI might look tighter if we use GWT's mechanism.
However, we could probably mimic everything using GWT's graphics (once
we upgrade) even if we perform the actual sorting using the tab model
and not their mechanism.

My gut feeling actually says to use GWT's built-in mechanism, mainly
because it will force us to put all sorting logic in the same place and
to always use the same sorting mechanism (whereas currently the sorting
logic is scattered and works differently in different places, even if we
use this tab mechanism other widgets will differ). But it shouldn't stop
us from setting a comparator for a tab where convenient.

>>>>
>>>>>
>>>>> I believe that the correct thing to do is to "attach" the GUI sorting
>>>>> mechanism
>>>>> to the one in the search mechanism.
>>>>>
>>>>> thoughts?
>>>>
>>>> This can be done, however I'm not sure there's much utility in it. Main
>>>> tabs are always sorted according to some default ordering even if one
>>>> was not entered in the search panel, and this sorting is also performed
>>>> consistently with respect to paging. So maybe the right thing to do
>>>> would be to just "block" the GUI sorting mechanism for main tabs (i.e.
>>>> override the setter method and make it no-op)?
>>>
>>> yes, and related to what I mentioned above - at some point in the future,
>>> we'd might want
>>> to block it for search-based sub-tabs as well.
>>>
>>>>
>>>>>>
>>>>>>
>>>>>>>
>>>>>>> http://gerrit.ovirt.org/#/c/15846/
>>>>>>>
>>>>>>> If a comparator isn't set, then everything should behave as before. If
>>>>>>> a
>>>>>>> comparator is set, then from that moment on the tab items will be kept
>>>>>>> in a SortedSet, so that even if an item is added in a way that doesn't
>>>>>>> trigger an event (e.g. getItems().add()) the items will be kept sorted
>>>>>>> according to the given comparator. If the comparator is set to null,
>>>>>>> from that moment on the tab should revert to its old behaviour.
>>>>>>>
>>>>>>> You're most welcome to have a look and let me know if this might break
>>>>>>> something (remember though that it's not obligatory to set a
>>>>>>> comparator,
>>>>>>> so only possible breakage should be in generic flows).
>>>>>>>
>>>>>>> Feel free to use it once it's merged; along with SortedListModel, this
>>>>>>> should make sorting less painful. Just keep in mind that once you set a
>>>>>>> comparator, you can't cast getItems() to a List. This shouldn't be a
>>>>>>> problem in general, as mostly it's as useful (and probably more
>>>>>>> correct)
>>>>>>> to cast to a Collection.
>>>>>>>
>>>>>>> Lior.
>>>>>>> _______________________________________________
>>>>>>> Engine-devel mailing list
>>>>>>> Engine-devel at ovirt.org
>>>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>>>>>
>>>>>> _______________________________________________
>>>>>> Engine-devel mailing list
>>>>>> Engine-devel at ovirt.org
>>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>>>>
>>>>
>>


From ecohen at redhat.com  Thu Jun 27 16:40:56 2013
From: ecohen at redhat.com (Einav Cohen)
Date: Thu, 27 Jun 2013 12:40:56 -0400 (EDT)
Subject: [Engine-devel] Sorting in tabs
In-Reply-To: <51CC6512.50509@redhat.com>
References: <51CBE5E1.7080900@redhat.com>
	<1283248469.4062177.1372330018886.JavaMail.root@redhat.com>
	<351803689.9138087.1372336625516.JavaMail.root@redhat.com>
	<51CC35E7.6030200@redhat.com>
	<1572668253.9189415.1372340538767.JavaMail.root@redhat.com>
	<51CC4E4C.4030507@redhat.com>
	<1796469050.9281535.1372346129622.JavaMail.root@redhat.com>
	<51CC6512.50509@redhat.com>
Message-ID: <422687242.9340619.1372351256617.JavaMail.root@redhat.com>

> ----- Original Message -----
> From: "Lior Vernia" <lvernia at redhat.com>
> Sent: Thursday, June 27, 2013 12:15:14 PM
> 
> 
> 
> On 27/06/13 18:15, Einav Cohen wrote:
> >> ----- Original Message -----
> >> From: "Lior Vernia" <lvernia at redhat.com>
> >> Sent: Thursday, June 27, 2013 10:38:04 AM
> >>
> >>
> >>
> >> On 27/06/13 16:42, Einav Cohen wrote:
> >>>> ----- Original Message -----
> >>>> From: "Lior Vernia" <lvernia at redhat.com>
> >>>> Sent: Thursday, June 27, 2013 8:53:59 AM
> >>>>
> >>>>
> >>>>
> >>>> On 27/06/13 15:37, Einav Cohen wrote:
> >>>>>> ----- Original Message -----
> >>>>>> From: "Eli Mesika" <emesika at redhat.com>
> >>>>>> Sent: Thursday, June 27, 2013 6:46:58 AM
> >>>>>>
> >>>>>>
> >>>>>> ----- Original Message -----
> >>>>>>> From: "Lior Vernia" <lvernia at redhat.com>
> >>>>>>> To: engine-devel at ovirt.org
> >>>>>>> Sent: Thursday, June 27, 2013 10:12:33 AM
> >>>>>>> Subject: [Engine-devel] Sorting in tabs
> >>>>>>>
> >>>>>>> Hello everyone (UI peeps in particular),
> >>>>>>>
> >>>>>>> I've pushed (not yet merged) a patch that would enable us to keep
> >>>>>>> items
> >>>>>>> in tabs (main/sub) sorted at all times by setting a comparator in
> >>>>>>> SearchableListModel:
> >>>>>>
> >>>>>> But tabs includes only 100 records and supports paging , how you deal
> >>>>>> with
> >>>>>> that ???
> >>>>>
> >>>>> if this is in the GUI level, then I assume that the comparator is
> >>>>> simply
> >>>>> comparing the
> >>>>> items within the current page, and not "globally".
> >>>>> so the sorting doesn't affect the set of items that is displayed in the
> >>>>> page (it would
> >>>>> be the same as before the sorting) - just their order.
> >>>>
> >>>> Yes, if I understand correctly how the paging works, Einav is correct -
> >>>> only the items passed to the UI are sorted.
> >>>>
> >>>>> also: @Lior - what happens when the search query contains a "sort by"
> >>>>> part?
> >>>>> there is a chance that the behaivor would be unexpected in this case;
> >>>>
> >>>> Yes, I thought about this case, and it may result in a confusing user
> >>>> experience if developers aren't careful. Together with the issue of
> >>>> paging, this probably makes this sorting mechanism a better candidate
> >>>> for use within subtabs rather than main tabs.
> >>>
> >>> note that at some point, I think that we would want to introduce paging
> >>> also to search-
> >>> based sub-tabs - it will be useful especially for sub-tabs that
> >>> potentially
> >>> display a
> >>> large number of results (e.g. Disks sub-tab in Storage main tab).
> >>> In addition, at some point, we would want to get rid of the paging UI as
> >>> it
> >>> is now
> >>> (i.e. "next"/"prev" buttons at the top panel) and move to paging
> >>> triggered
> >>> by scroll
> >>> (i.e. have a very long grid, dynamically loaded as you continue to scroll
> >>> -
> >>> similar
> >>> to the behavior of some e-mail web-clients, for example). In this case,
> >>> sorting on
> >>> the client side will make no sense at all (i.e. from the user
> >>> perspective,
> >>> only a
> >>> portion of a very large grid will be sorted, the other portions won't
> >>> be).
> >>>
> >>> So for now - yes, I think it makes sense to introduce your mechanism to
> >>> all
> >>> sub-tabs,
> >>> however in the long-term - we would probably want the search-based
> >>> sub-tabs
> >>> (which
> >>> will support paging) to move to search-based sorting, rather than
> >>> GUI-based-sorting.
> >>
> >> Sounds good to me. Let me just re-iterate that it is not mandatory to
> >> set a comparator, so in technical terms it's not even necessary to
> >> introduce it at once to all sub-tabs, if they're already sorting their
> >> items some other way. It could happen gradually, and only if developers
> >> find it more convenient. In either case, dropping the GUI sorting once
> >> search-based sorting is implemented shouldn't be difficult.
> >>
> >>> BTW (maybe the other GUI maintainers can help me with that one) - what
> >>> about sub-tabs
> >>> that are not search-based (i.e. display results from a "regular" query or
> >>> even from a
> >>> field within the selected item in the main grid, e.g. Applications in VM)
> >>> -
> >>> are these
> >>> managed via SearchableListModel as well? since the comparator mechanism
> >>> *is* relevant
> >>> for them.
> >>
> >> As far as I've seen, some are managed via SearchableListModel and some
> >> aren't. Those that aren't are those that display non-trivial behaviour
> >> upon receipt of the items to display (setItems() method) - often this
> >> non-trivial behaviour is exactly sorting :) And if it's doing its job,
> >> then there's no necessity to change it either. But anyway, I don't know
> >> all of them, so I'd also love to hear GUI maintainers.
> >>
> >>> Also: Worth mentioning "Bug 893999 - webadmin: please allow column
> >>> sorting", which
> >>> requests to enable sorting when clicking on a grid-column header; when
> >>> implementing
> >>> column-sorting, probably worth attaching your mechanism to it somehow
> >>> (i.e.
> >>> clicking on
> >>> a column header should set the relevant comparator in the relevant
> >>> SearchableListModel).
> >>
> >> I didn't want to say it, because if we upgrade to a newer version of GWT
> >> then we could probably use their table column sorting. But this
> >> mechanism could allow us to achieve this without upgrading, and it was
> >> definitely sitting in the back of my head when I implemented it. All
> >> that's needed is, as you said, to listen to table header clicks in the
> >> view, and then appropriately set the comparator in the model.
> >>
> > 
> > [Vojtech/GUI-maintainers - your input would be appreciated here]
> > 
> > we are actually planning on upgrading the GWT version *really* soon (to GWT
> > 2.5),
> > so my question is: should we wait until the new GWT is introduced, and
> > implement
> > client-sorting based on the GWT-grid-widget built-in mechanism (assuming
> > there is
> > one)?
> > also, not sure if it is better to utilize the widget default-built-in
> > sorting mechanism
> > (which doesn't manipulate the uicommon model data at all), or if it is
> > better to utilize
> > your comparator mechanism, which manipulates the uicommon model data, and
> > the GUI-widget
> > just reflects this data at any given time.
> > thoughts?
> 
> I'll just give my two cents concerning this and then let others have the
> stage: I don't think it really matters.
> 
> Manipulating the models directly is supposedly more portable in case we
> ever move away from GWT, but we'd still have the pain of adding new
> listeners to the new framework's table headers which could be just as
> bad as using its sorting mechanism.
> 
> Graphically, the UI might look tighter if we use GWT's mechanism.
> However, we could probably mimic everything using GWT's graphics (once
> we upgrade) even if we perform the actual sorting using the tab model
> and not their mechanism.
> 
> My gut feeling actually says to use GWT's built-in mechanism, mainly
> because it will force us to put all sorting logic in the same place and
> to always use the same sorting mechanism (whereas currently the sorting
> logic is scattered and works differently in different places, even if we
> use this tab mechanism other widgets will differ). But it shouldn't stop
> us from setting a comparator for a tab where convenient.

[again, GUI maintainers - your input would be appreciated]

Thanks, Lior. Need to keep in mind several things:

- we are now talking only about client-sorting, which generally we would like 
to apply only to grids that display none-"pagable"-results; for grids that would 
display pagable-results, we would want to use search-based (i.e. server) sorting.
[so the sorting logic across the application would be somewhat-scattered anyway].

- I think that if we are choosing to utilize GWT's built-in mechanism, then using 
a comparator would makes sense in case you want your results to be initially displayed 
in a specific order that would not be obtainable using the column-header sorting.

e.g. (dumb example, for demonstration only) if you would want your VMs to be displayed 
by default sorted alphabetically according to the VM's description (and keep in mind 
that description is NOT one of the columns in the VMs grid), then you would probably 
want to do that via the comparator. 

Or (perhaps a better example), if you would want your Templates to be ordered by default 
in a way that "Blank" would appear first, and the rest would appear sorted alphabetically 
by name, utilizing the comparator can be a good idea. 
[After the initial load of the grid, if the user chooses to sort by name, he can click on 
the "Name" column header, which will sort the Templates alphabetically "regularly" (i.e. 
not taking "Blank" into special consideration)]

But - if, by default, we would want, for example, to sort VMs alphabetically by name, 
I think that we should imitate a mouse-click on the "Name" column-header, rather than 
utilize a comparator for that (the exact same result shouldn't be achieved by two different 
implementations).

> 
> >>>>
> >>>>>
> >>>>> I believe that the correct thing to do is to "attach" the GUI sorting
> >>>>> mechanism
> >>>>> to the one in the search mechanism.
> >>>>>
> >>>>> thoughts?
> >>>>
> >>>> This can be done, however I'm not sure there's much utility in it. Main
> >>>> tabs are always sorted according to some default ordering even if one
> >>>> was not entered in the search panel, and this sorting is also performed
> >>>> consistently with respect to paging. So maybe the right thing to do
> >>>> would be to just "block" the GUI sorting mechanism for main tabs (i.e.
> >>>> override the setter method and make it no-op)?
> >>>
> >>> yes, and related to what I mentioned above - at some point in the future,
> >>> we'd might want
> >>> to block it for search-based sub-tabs as well.
> >>>
> >>>>
> >>>>>>
> >>>>>>
> >>>>>>>
> >>>>>>> http://gerrit.ovirt.org/#/c/15846/
> >>>>>>>
> >>>>>>> If a comparator isn't set, then everything should behave as before.
> >>>>>>> If
> >>>>>>> a
> >>>>>>> comparator is set, then from that moment on the tab items will be
> >>>>>>> kept
> >>>>>>> in a SortedSet, so that even if an item is added in a way that
> >>>>>>> doesn't
> >>>>>>> trigger an event (e.g. getItems().add()) the items will be kept
> >>>>>>> sorted
> >>>>>>> according to the given comparator. If the comparator is set to null,
> >>>>>>> from that moment on the tab should revert to its old behaviour.
> >>>>>>>
> >>>>>>> You're most welcome to have a look and let me know if this might
> >>>>>>> break
> >>>>>>> something (remember though that it's not obligatory to set a
> >>>>>>> comparator,
> >>>>>>> so only possible breakage should be in generic flows).
> >>>>>>>
> >>>>>>> Feel free to use it once it's merged; along with SortedListModel,
> >>>>>>> this
> >>>>>>> should make sorting less painful. Just keep in mind that once you set
> >>>>>>> a
> >>>>>>> comparator, you can't cast getItems() to a List. This shouldn't be a
> >>>>>>> problem in general, as mostly it's as useful (and probably more
> >>>>>>> correct)
> >>>>>>> to cast to a Collection.
> >>>>>>>
> >>>>>>> Lior.
> >>>>>>> _______________________________________________
> >>>>>>> Engine-devel mailing list
> >>>>>>> Engine-devel at ovirt.org
> >>>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> >>>>>>>
> >>>>>> _______________________________________________
> >>>>>> Engine-devel mailing list
> >>>>>> Engine-devel at ovirt.org
> >>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> >>>>>>
> >>>>
> >>
> 


From lpeer at redhat.com  Thu Jun 27 17:07:39 2013
From: lpeer at redhat.com (Livnat Peer)
Date: Thu, 27 Jun 2013 20:07:39 +0300
Subject: [Engine-devel] SSH Soft Fencing
In-Reply-To: <12227690.29409642.1372344197624.JavaMail.root@redhat.com>
References: <1622219224.572748.1372330266360.JavaMail.root@redhat.com>
	<1695008076.4096833.1372337319955.JavaMail.root@redhat.com>
	<12227690.29409642.1372344197624.JavaMail.root@redhat.com>
Message-ID: <51CC715B.6070004@redhat.com>

On 06/27/2013 05:43 PM, Yair Zaslavsky wrote:
> 
> 
> ----- Original Message -----
>> From: "Eli Mesika" <emesika at redhat.com>
>> To: "Martin Perina" <mperina at redhat.com>
>> Cc: engine-devel at ovirt.org, "Yair Zaslavsky" <yzaslavs at redhat.com>, "Barak Azulay" <bazulay at redhat.com>
>> Sent: Thursday, June 27, 2013 3:48:39 PM
>> Subject: Re: SSH Soft Fencing
>>
>>
>>
>> ----- Original Message -----
>>> From: "Martin Perina" <mperina at redhat.com>
>>> To: engine-devel at ovirt.org
>>> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Barak Azulay"
>>> <bazulay at redhat.com>, "Eli Mesika" <emesika at redhat.com>
>>> Sent: Thursday, June 27, 2013 1:51:06 PM
>>> Subject: SSH Soft Fencing
>>>
>>> Hi,
>>>
>>> SSH Soft Fencing is a new feature for 3.3 and it tries to restart VDSM
>>> using SSH connection on non responsive hosts prior to real fencing.
>>> More info can be found at
>>>
>>> http://www.ovirt.org/Automatic_Fencing#Automatic_Fencing_in_oVirt_3.3
>>>
>>> In current SSH Soft Fencing implementation the restart VDSM using SSH
>>> command is part of standard fencing implementation in
>>> VdsNotRespondingTreatmentCommand. But this command is executed only
>>> if a host has a valid PM configuration. If host doesn't have a valid
>>> PM configuration, the execution of the command is disabled and host
>>> state is change to Non Responsive.
>>>
>>> So my question are:
>>>
>>> 1) Should SSH Soft Fencing be executed on hosts without valid PM
>>>    configuration?
>>
>> I think that the answer should be yes. The vdsm restart will solve most of
>> problems , so why not using it whether a PM agent is defined or not.
> I agree.
> I would like to say that I also don't like the fact that VdsNotRespondingTreatment extends RestartVdsCommand.
> One should ask if "non responding treatment is a restart vds operation" or maybe RestartVdsCommand is just a step in the non responding treatment (inheritance vs containment/delegation).
> I think that VdsNotRespodingTreatment should delegate the call to RestartVdsCommand as the 2nd step after issuing the Soft Fencing command.
> Thoughts anyone?
> 

I agree.
The purpose of this feature is to add escalation step when handling non
responsive host.
Power fencing is only a step in the escalation flow. so should be called
from within the main flow controller (the VdsNotRespodingTreatment).

Maybe we'd like this to be fine tuned by a custom policy in future versions.

>>
>>>
>>> 2) Should VDSM restart using SSH command be reimplemented
>>>    as standalone command to be usable also in other parts of engine?
>>>    If 1) is true, I think it will have to be done anyway.
> 
> I agree here. 
>>
>> +1

+1
The VDSM restart is a step in the escalation flow, and it should not be
tightly coupled with the non-responsive treatment implementation.

>>
>>>
>>>
>>> Martin Perina
>>>
>>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
> 



From bazulay at redhat.com  Thu Jun 27 17:31:35 2013
From: bazulay at redhat.com (Barak Azulay)
Date: Thu, 27 Jun 2013 13:31:35 -0400 (EDT)
Subject: [Engine-devel] SSH Soft Fencing
In-Reply-To: <1625820710.4175423.1372344929287.JavaMail.root@redhat.com>
References: <1622219224.572748.1372330266360.JavaMail.root@redhat.com>
	<1695008076.4096833.1372337319955.JavaMail.root@redhat.com>
	<12227690.29409642.1372344197624.JavaMail.root@redhat.com>
	<1625820710.4175423.1372344929287.JavaMail.root@redhat.com>
Message-ID: <687362379.9364944.1372354295556.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Eli Mesika" <emesika at redhat.com>
> To: "Yair Zaslavsky" <yzaslavs at redhat.com>
> Cc: "Martin Perina" <mperina at redhat.com>, engine-devel at ovirt.org, "Barak Azulay" <bazulay at redhat.com>
> Sent: Thursday, June 27, 2013 5:55:29 PM
> Subject: Re: SSH Soft Fencing
> 
> 
> 
> ----- Original Message -----
> > From: "Yair Zaslavsky" <yzaslavs at redhat.com>
> > To: "Eli Mesika" <emesika at redhat.com>
> > Cc: "Martin Perina" <mperina at redhat.com>, engine-devel at ovirt.org, "Barak
> > Azulay" <bazulay at redhat.com>
> > Sent: Thursday, June 27, 2013 5:43:17 PM
> > Subject: Re: SSH Soft Fencing
> > 
> > 
> > 
> > ----- Original Message -----
> > > From: "Eli Mesika" <emesika at redhat.com>
> > > To: "Martin Perina" <mperina at redhat.com>
> > > Cc: engine-devel at ovirt.org, "Yair Zaslavsky" <yzaslavs at redhat.com>,
> > > "Barak
> > > Azulay" <bazulay at redhat.com>
> > > Sent: Thursday, June 27, 2013 3:48:39 PM
> > > Subject: Re: SSH Soft Fencing
> > > 
> > > 
> > > 
> > > ----- Original Message -----
> > > > From: "Martin Perina" <mperina at redhat.com>
> > > > To: engine-devel at ovirt.org
> > > > Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Barak Azulay"
> > > > <bazulay at redhat.com>, "Eli Mesika" <emesika at redhat.com>
> > > > Sent: Thursday, June 27, 2013 1:51:06 PM
> > > > Subject: SSH Soft Fencing
> > > > 
> > > > Hi,
> > > > 
> > > > SSH Soft Fencing is a new feature for 3.3 and it tries to restart VDSM
> > > > using SSH connection on non responsive hosts prior to real fencing.
> > > > More info can be found at
> > > > 
> > > > http://www.ovirt.org/Automatic_Fencing#Automatic_Fencing_in_oVirt_3.3
> > > > 
> > > > In current SSH Soft Fencing implementation the restart VDSM using SSH
> > > > command is part of standard fencing implementation in
> > > > VdsNotRespondingTreatmentCommand. But this command is executed only
> > > > if a host has a valid PM configuration. If host doesn't have a valid
> > > > PM configuration, the execution of the command is disabled and host
> > > > state is change to Non Responsive.
> > > > 
> > > > So my question are:
> > > > 
> > > > 1) Should SSH Soft Fencing be executed on hosts without valid PM
> > > >    configuration?
> > > 
> > > I think that the answer should be yes. The vdsm restart will solve most
> > > of
> > > problems , so why not using it whether a PM agent is defined or not.
> > I agree.
> > I would like to say that I also don't like the fact that
> > VdsNotRespondingTreatment extends RestartVdsCommand.
> > One should ask if "non responding treatment is a restart vds operation" or
> > maybe RestartVdsCommand is just a step in the non responding treatment
> > (inheritance vs containment/delegation).
> > I think that VdsNotRespodingTreatment should delegate the call to
> > RestartVdsCommand as the 2nd step after issuing the Soft Fencing command.
> > Thoughts anyone?
> 
> That would be a nice and needed re-factoring

I would say yes - but would add it only with appropriate configuration (enableAutoSoftVdsmRestartWhenNoPMAvailable .... I hate the name)

 

> 
> > 
> > > 
> > > > 
> > > > 2) Should VDSM restart using SSH command be reimplemented
> > > >    as standalone command to be usable also in other parts of engine?
> > > >    If 1) is true, I think it will have to be done anyway.
> > 
> > I agree here.
> > > 
> > > +1

On one hand it makes sense,  but I have several questions on the above:
- Who do we think may want to use such a command ?
- Should (or even can) we limit the use of such command to noneResponsiveTreatment ?

Having general commands available to all code when there is only one specific case we are using it might be a bit riskey,
Especially when we talk about restarting something.

Thoughts ?



> > > 
> > > > 
> > > > 
> > > > Martin Perina
> > > > 
> > > 
> > 
> 


From fellipeh at gmail.com  Thu Jun 27 21:48:08 2013
From: fellipeh at gmail.com (Fellipe Henrique)
Date: Thu, 27 Jun 2013 18:48:08 -0300
Subject: [Engine-devel] Introduce mail
Message-ID: <CAF1jwZHZKSQawW963NAW1fOA-FxBL8NXfX+Ay=-0OsKFVjOLTw@mail.gmail.com>

hello folks!

I'm here today, to introduce myself. I want to start to contribute to oVirt
project, I'm developing most of time in python, and I'll love to contribute
in python, but can be in C.

I love developing and virtualization, and I think this project have all I
like.

well, like I said, this is a introduce email, and I'll like suggestion how
can I help, and show my code to you guys.

best regards,

T.?.F.?.A.?.     S+F
*Fellipe Henrique P. Soares*

*"Quemadmodum gladius neminem occidit, occidentis telum est."* (Epistulae
morales ad Lucilium<http://en.wikipedia.org/wiki/Epistulae_morales_ad_Lucilium>,
Lucius Annaeus Seneca)

*"Any intelligent fool can make things bigger, more complex, and more
violent. It takes a touch of genius -- and a lot of courage -- to move in
the opposite direction."*
Albert Einstein (March 14th 1879 ? April 18th 1955)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130627/f796e785/attachment.html>

From alonbl at redhat.com  Thu Jun 27 22:16:16 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Thu, 27 Jun 2013 18:16:16 -0400 (EDT)
Subject: [Engine-devel] Introduce mail
In-Reply-To: <CAF1jwZHZKSQawW963NAW1fOA-FxBL8NXfX+Ay=-0OsKFVjOLTw@mail.gmail.com>
References: <CAF1jwZHZKSQawW963NAW1fOA-FxBL8NXfX+Ay=-0OsKFVjOLTw@mail.gmail.com>
Message-ID: <1418860875.12884875.1372371376693.JavaMail.root@redhat.com>


Hello Fillipe,

If you can integrate between several components of ovirt we need help in re-writing the ovirt-node vdsm plugin[1].

This is somewhat complex task, in which we integrate ovirt-node distribution with UI and logic of registration and the ovirt-engine.

The basic sequence is as follows:

1. admin login into ovirt-node TUI.
2. ovirt-node TUI loads a plugin out of the ovirt-node-plugin-vdsm.
3. ovirt-node TUI allows user to interact with the plugin.
4. once the ip address and port of the engine are provided the plugin performs:
a) download CA certificate.
b) download SSH public key.
c) perform registration via HTTP
d) create bridge

What we need is to cleanup the code first which contains a lot of legacy, then to modify the behavior to suite our current needs.

The task is complex because of the integration between different components and the ovirt-node hostile environment.

If you are interested, we can start...

Regards,
Alon

[1] http://gerrit.ovirt.org/gitweb?p=ovirt-node-plugin-vdsm.git

----- Original Message -----
> From: "Fellipe Henrique" <fellipeh at gmail.com>
> To: engine-devel at ovirt.org
> Sent: Friday, June 28, 2013 12:48:08 AM
> Subject: [Engine-devel] Introduce mail
> 
> hello folks!
> 
> I'm here today, to introduce myself. I want to start to contribute to oVirt
> project, I'm developing most of time in python, and I'll love to contribute
> in python, but can be in C.
> 
> I love developing and virtualization, and I think this project have all I
> like.
> 
> well, like I said, this is a introduce email, and I'll like suggestion how
> can I help, and show my code to you guys.
> 
> best regards,
> 
> T.?.F.?.A.?. S+F
> Fellipe Henrique P. Soares
> 
> "Quemadmodum gladius neminem occidit, occidentis telum est." ( Epistulae
> morales ad Lucilium , Lucius Annaeus Seneca)
> 
> "Any intelligent fool can make things bigger, more complex, and more violent.
> It takes a touch of genius -- and a lot of courage -- to move in the
> opposite direction."
> Albert Einstein (March 14th 1879 ? April 18th 1955)
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From tjelinek at redhat.com  Fri Jun 28 05:41:11 2013
From: tjelinek at redhat.com (Tomas Jelinek)
Date: Fri, 28 Jun 2013 01:41:11 -0400 (EDT)
Subject: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
In-Reply-To: <2874260.9314218.1372348873189.JavaMail.root@redhat.com>
References: <501973842.20255318.1371648804880.JavaMail.root@redhat.com>
	<51C2F54C.60409@redhat.com>
	<6609F396-8D78-46FB-9F2D-3700D769B5E9@redhat.com>
	<20130624094735.GC1849@teriyaki.cdg.redhat.com>
	<1210717020.2488959.1372324871664.JavaMail.root@redhat.com>
	<20130627093010.GC13576@teriyaki.redhat.com>
	<2114201154.2496221.1372326631963.JavaMail.root@redhat.com>
	<2874260.9314218.1372348873189.JavaMail.root@redhat.com>
Message-ID: <856039866.2941458.1372398071424.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Einav Cohen" <ecohen at redhat.com>
> To: "Tomas Jelinek" <tjelinek at redhat.com>, "Vojtech Szocs" <vszocs at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>, "Michael Pasternak" <mpastern at redhat.com>
> Sent: Thursday, June 27, 2013 6:01:13 PM
> Subject: Re: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
> 
> Hi Tomas,
> 
> > Yes, we can provide the sessionId to authenticate with the REST and the vm
> > guid is not a problem.
> 
> Note that in the web-admin, we already have code that generates REST API
> session-ID;
> this code is being utilized in the ui-plugins infrastructure to allow the
> different
> ui-plugins to communicate with the rest api.
> [one related file is this context is RestApiSessionManager.java in the
> web-admin, not
> sure if there are others]

Yes, I'm aware of that. This is what I had in mind when was talking about passing the SessionId to SPICE.

> 
> maybe the RestApiSessionManager(?) can somehow be utilized for the SPICE
> purpose as well
> (I guess that it will require a couple of code-changes though, and maybe
> worth moving it
> to gwt-common, to allow its utilization from the user portal as well?) -
> @Vojtech would
> probably know best to advise on this.
> 
> * Note: Today:
> (a) a *single* REST API session-ID is generated and used across all
> ui-plugins in the system
> (upon user login to the web-admin).
> 
> (b) this REST-API session-ID is generated based on the *same credentials*
> with which the user
> logged into the web-admin.
> 
> both (a) and (b) will change once [1] will be addressed.

Thank you for mentioning this! I was not aware of this RFE. IIUC the RFE addresses only
UIPlugins with their metadata so in order to integrate this with the SPICE we nee to either
enrich the RFE or to create a UIPlugin which will start the SPICE. I would vote for the second option.
What others?

> Only for the SPICE case in particular - I think that (b) should remain. so

Why only for SPICE? I can imagine UIPlugins which could make use of this option.

> maybe worth allowing
> both same-credentials-login and different-credentials-login in the
> REST-API-Session-ID-generation
> code in the GUI.

This option might make sense also for other UIPlugins so maybe the SPICE integration will not be anything special, just a UIPlugin.

> 
> ----
> Thanks,
> Einav
> 
> [1] Bug 962863 - RFE: Improve REST API integration for UI Plugins
> https://bugzilla.redhat.com/show_bug.cgi?id=962863
> some of the planned changes (from the BZ description):
> """
> ...
> - each UI plugin will have its own dedicated REST API session, unrelated to
> GUI (admin)
> user credentials
> ...
> """
> 
> > ----- Original Message -----
> > From: "Tomas Jelinek" <tjelinek at redhat.com>
> > Sent: Thursday, June 27, 2013 5:50:31 AM
> > 
> > 
> > 
> > ----- Original Message -----
> > > From: "Christophe Fergeau" <cfergeau at redhat.com>
> > > To: "Tomas Jelinek" <tjelinek at redhat.com>
> > > Cc: "Michal Skrivanek" <michal.skrivanek at redhat.com>, "Itamar Heim"
> > > <iheim at redhat.com>,
> > > spice-devel at lists.freedesktop.org, "engine-devel"
> > > <engine-devel at ovirt.org>,
> > > "Marc-Andr? Lureau" <mlureau at redhat.com>
> > > Sent: Thursday, June 27, 2013 11:30:10 AM
> > > Subject: Re: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
> > > 
> > > Hey,
> > > 
> > > On Thu, Jun 27, 2013 at 05:21:11AM -0400, Tomas Jelinek wrote:
> > > > well, it seems that everyone agree that the decision what to add to the
> > > > menu is the client responsibility. It means there is no additional work
> > > > needed on the
> > > > oVirt engine side - going to remove the feature page.
> > > 
> > > If we go the REST API way to handle foreign menu, we need additional info
> > > in the .vv files: some way to auth with the REST API, and the guid of the
> > > VM to act on.
> > Yes, we can provide the sessionId to authenticate with the REST and the vm
> > guid is not a problem.
> > 
> > > 
> > > Christophe
> > > 
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> > 
> >
> 


From mperina at redhat.com  Fri Jun 28 05:59:53 2013
From: mperina at redhat.com (Martin Perina)
Date: Fri, 28 Jun 2013 01:59:53 -0400 (EDT)
Subject: [Engine-devel] Problem with development environment
In-Reply-To: <1077424427.925227.1372398098218.JavaMail.root@redhat.com>
Message-ID: <925161444.931059.1372399193567.JavaMail.root@redhat.com>

Hi,

I've encountered a problem using development environment. When I run

 make clean install-dev PREFIX="$HOME/ovirt-engine"

there appears this error message:

make[2]: Leaving directory `/home/mperina/projects/ovirt/ovirt-engine'
# we should avoid make these directories dirty
make copy-recursive SOURCEDIR=packaging/dbscripts TARGETDIR="/home/mperina/ovirt-engine/share/ovirt-engine/dbscripts" \
	EXCLUDE_GEN="packaging/bin/engine-prolog.sh packaging/bin/pki-common.sh packaging/conf/engine.conf.defaults packaging/conf/notifier.conf.defaults packaging/conf/ovirt-websocket-proxy.conf.defaults packaging/etc/engine-config/log4j.xml packaging/etc/engine-manage-domains/log4j.xml packaging/etc/engine-manage-domains/engine-manage-domains.conf packaging/etc/notifier/log4j.xml packaging/sys-etc/logrotate.d/ovirt-engine packaging/services/config.py packaging/services/ovirt-engine.systemd packaging/services/ovirt-engine.sysv packaging/services/ovirt-engine-notifier.systemd packaging/services/ovirt-engine-notifier.sysv packaging/services/ovirt-websocket-proxy.systemd packaging/services/ovirt-websocket-proxy.sysv packaging/setup/ovirt_engine_setup/config.py packaging/bin/ovirt-engine-log-setup-event.sh ovirt-engine.spec " \
	EXCLUDE="$(find packaging/dbscripts \( -name '*.scripts.md5' -or -name '*.schema' -or -name '*.log' \))"
make[2]: Entering directory `/home/mperina/projects/ovirt/ovirt-engine'
( cd "packaging/dbscripts" && find . -type d -printf '%P\n' ) | while read d; do \
	install -d -m 755 "/home/mperina/ovirt-engine/share/ovirt-engine/dbscripts/${d}"; \
done
( \
	cd "packaging/dbscripts" && find . -type f -printf '%P\n' | \
	while read f; do \
		exclude=false; \
		set -x; \
		for x in packaging/bin/engine-prolog.sh packaging/bin/pki-common.sh packaging/conf/engine.conf.defaults packaging/conf/notifier.conf.defaults packaging/conf/ovirt-websocket-proxy.conf.defaults packaging/etc/engine-config/log4j.xml packaging/etc/engine-manage-domains/log4j.xml packaging/etc/engine-manage-domains/engine-manage-domains.conf packaging/etc/notifier/log4j.xml packaging/sys-etc/logrotate.d/ovirt-engine packaging/services/config.py packaging/services/ovirt-engine.systemd packaging/services/ovirt-engine.sysv packaging/services/ovirt-engine-notifier.systemd packaging/services/ovirt-engine-notifier.sysv packaging/services/ovirt-websocket-proxy.systemd packaging/services/ovirt-websocket-proxy.sysv packaging/setup/ovirt_engine_setup/config.py packaging/bin/ovirt-engine-log-setup-event.sh ovirt-engine.spec ; do \
			if [ "packaging/dbscripts/${f}" = "${x}.in" ]; then \
				exclude=true; \
				break; \
			fi; \
		done; \
		for x in packaging/dbscripts/upgrade.sh.log
/bin/sh: -c: line 12: syntax error: unexpected end of file
make[2]: *** [copy-recursive] Error 1
make[2]: Leaving directory `/home/mperina/projects/ovirt/ovirt-engine'
make[1]: *** [install-packaging-files] Error 2
make[1]: Leaving directory `/home/mperina/projects/ovirt/ovirt-engine'
make: *** [install-dev] Error 2


I've already upgraded to otopi 1.1 (currently 1.1.0-0.0.master.20130626.git33d9561.fc18).


Martin Perina



From mpastern at redhat.com  Fri Jun 28 06:11:38 2013
From: mpastern at redhat.com (Michael Pasternak)
Date: Fri, 28 Jun 2013 09:11:38 +0300
Subject: [Engine-devel] ovirt-engine-sdk-java 1.0.0.9-1 released
In-Reply-To: <51C9AEEC.20505@redhat.com>
References: <51C9AEEC.20505@redhat.com>
Message-ID: <51CD291A.6060500@redhat.com>


* Fri  Jun 28 2013 Michael Pasternak <mpastern at redhat.com> - 1.0.0.9-1

- configure log4j programmatically


More details can be found at [1].

[1] http://www.ovirt.org/Java-sdk-changelog

-- 

Michael Pasternak
RedHat, ENG-Virtualization R&D




From tjelinek at redhat.com  Fri Jun 28 06:45:17 2013
From: tjelinek at redhat.com (Tomas Jelinek)
Date: Fri, 28 Jun 2013 02:45:17 -0400 (EDT)
Subject: [Engine-devel] Sorting in tabs
In-Reply-To: <422687242.9340619.1372351256617.JavaMail.root@redhat.com>
References: <51CBE5E1.7080900@redhat.com>
	<351803689.9138087.1372336625516.JavaMail.root@redhat.com>
	<51CC35E7.6030200@redhat.com>
	<1572668253.9189415.1372340538767.JavaMail.root@redhat.com>
	<51CC4E4C.4030507@redhat.com>
	<1796469050.9281535.1372346129622.JavaMail.root@redhat.com>
	<51CC6512.50509@redhat.com>
	<422687242.9340619.1372351256617.JavaMail.root@redhat.com>
Message-ID: <371875056.2962175.1372401917952.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Einav Cohen" <ecohen at redhat.com>
> To: "Lior Vernia" <lvernia at redhat.com>
> Cc: "Vojtech Szocs" <vszocs at redhat.com>, "Eli Mesika" <emesika at redhat.com>, engine-devel at ovirt.org, "Alexander Wels"
> <awels at redhat.com>, "Daniel Erez" <derez at redhat.com>, "Gilad Chaplik" <gchaplik at redhat.com>, "Alona Kaplan"
> <alkaplan at redhat.com>, "Tomas Jelinek" <tjelinek at redhat.com>
> Sent: Thursday, June 27, 2013 6:40:56 PM
> Subject: Re: [Engine-devel] Sorting in tabs
> 
> > ----- Original Message -----
> > From: "Lior Vernia" <lvernia at redhat.com>
> > Sent: Thursday, June 27, 2013 12:15:14 PM
> > 
> > 
> > 
> > On 27/06/13 18:15, Einav Cohen wrote:
> > >> ----- Original Message -----
> > >> From: "Lior Vernia" <lvernia at redhat.com>
> > >> Sent: Thursday, June 27, 2013 10:38:04 AM
> > >>
> > >>
> > >>
> > >> On 27/06/13 16:42, Einav Cohen wrote:
> > >>>> ----- Original Message -----
> > >>>> From: "Lior Vernia" <lvernia at redhat.com>
> > >>>> Sent: Thursday, June 27, 2013 8:53:59 AM
> > >>>>
> > >>>>
> > >>>>
> > >>>> On 27/06/13 15:37, Einav Cohen wrote:
> > >>>>>> ----- Original Message -----
> > >>>>>> From: "Eli Mesika" <emesika at redhat.com>
> > >>>>>> Sent: Thursday, June 27, 2013 6:46:58 AM
> > >>>>>>
> > >>>>>>
> > >>>>>> ----- Original Message -----
> > >>>>>>> From: "Lior Vernia" <lvernia at redhat.com>
> > >>>>>>> To: engine-devel at ovirt.org
> > >>>>>>> Sent: Thursday, June 27, 2013 10:12:33 AM
> > >>>>>>> Subject: [Engine-devel] Sorting in tabs
> > >>>>>>>
> > >>>>>>> Hello everyone (UI peeps in particular),
> > >>>>>>>
> > >>>>>>> I've pushed (not yet merged) a patch that would enable us to keep
> > >>>>>>> items
> > >>>>>>> in tabs (main/sub) sorted at all times by setting a comparator in
> > >>>>>>> SearchableListModel:
> > >>>>>>
> > >>>>>> But tabs includes only 100 records and supports paging , how you
> > >>>>>> deal
> > >>>>>> with
> > >>>>>> that ???
> > >>>>>
> > >>>>> if this is in the GUI level, then I assume that the comparator is
> > >>>>> simply
> > >>>>> comparing the
> > >>>>> items within the current page, and not "globally".
> > >>>>> so the sorting doesn't affect the set of items that is displayed in
> > >>>>> the
> > >>>>> page (it would
> > >>>>> be the same as before the sorting) - just their order.
> > >>>>
> > >>>> Yes, if I understand correctly how the paging works, Einav is correct
> > >>>> -
> > >>>> only the items passed to the UI are sorted.
> > >>>>
> > >>>>> also: @Lior - what happens when the search query contains a "sort by"
> > >>>>> part?
> > >>>>> there is a chance that the behaivor would be unexpected in this case;
> > >>>>
> > >>>> Yes, I thought about this case, and it may result in a confusing user
> > >>>> experience if developers aren't careful. Together with the issue of
> > >>>> paging, this probably makes this sorting mechanism a better candidate
> > >>>> for use within subtabs rather than main tabs.
> > >>>
> > >>> note that at some point, I think that we would want to introduce paging
> > >>> also to search-
> > >>> based sub-tabs - it will be useful especially for sub-tabs that
> > >>> potentially
> > >>> display a
> > >>> large number of results (e.g. Disks sub-tab in Storage main tab).
> > >>> In addition, at some point, we would want to get rid of the paging UI
> > >>> as
> > >>> it
> > >>> is now
> > >>> (i.e. "next"/"prev" buttons at the top panel) and move to paging
> > >>> triggered
> > >>> by scroll
> > >>> (i.e. have a very long grid, dynamically loaded as you continue to
> > >>> scroll
> > >>> -
> > >>> similar
> > >>> to the behavior of some e-mail web-clients, for example). In this case,
> > >>> sorting on
> > >>> the client side will make no sense at all (i.e. from the user
> > >>> perspective,
> > >>> only a
> > >>> portion of a very large grid will be sorted, the other portions won't
> > >>> be).
> > >>>
> > >>> So for now - yes, I think it makes sense to introduce your mechanism to
> > >>> all
> > >>> sub-tabs,
> > >>> however in the long-term - we would probably want the search-based
> > >>> sub-tabs
> > >>> (which
> > >>> will support paging) to move to search-based sorting, rather than
> > >>> GUI-based-sorting.
> > >>
> > >> Sounds good to me. Let me just re-iterate that it is not mandatory to
> > >> set a comparator, so in technical terms it's not even necessary to
> > >> introduce it at once to all sub-tabs, if they're already sorting their
> > >> items some other way. It could happen gradually, and only if developers
> > >> find it more convenient. In either case, dropping the GUI sorting once
> > >> search-based sorting is implemented shouldn't be difficult.
> > >>
> > >>> BTW (maybe the other GUI maintainers can help me with that one) - what
> > >>> about sub-tabs
> > >>> that are not search-based (i.e. display results from a "regular" query
> > >>> or
> > >>> even from a
> > >>> field within the selected item in the main grid, e.g. Applications in
> > >>> VM)
> > >>> -
> > >>> are these
> > >>> managed via SearchableListModel as well? since the comparator mechanism
> > >>> *is* relevant
> > >>> for them.
> > >>
> > >> As far as I've seen, some are managed via SearchableListModel and some
> > >> aren't. Those that aren't are those that display non-trivial behaviour
> > >> upon receipt of the items to display (setItems() method) - often this
> > >> non-trivial behaviour is exactly sorting :) And if it's doing its job,
> > >> then there's no necessity to change it either. But anyway, I don't know
> > >> all of them, so I'd also love to hear GUI maintainers.
> > >>
> > >>> Also: Worth mentioning "Bug 893999 - webadmin: please allow column
> > >>> sorting", which
> > >>> requests to enable sorting when clicking on a grid-column header; when
> > >>> implementing
> > >>> column-sorting, probably worth attaching your mechanism to it somehow
> > >>> (i.e.
> > >>> clicking on
> > >>> a column header should set the relevant comparator in the relevant
> > >>> SearchableListModel).
> > >>
> > >> I didn't want to say it, because if we upgrade to a newer version of GWT
> > >> then we could probably use their table column sorting. But this
> > >> mechanism could allow us to achieve this without upgrading, and it was
> > >> definitely sitting in the back of my head when I implemented it. All
> > >> that's needed is, as you said, to listen to table header clicks in the
> > >> view, and then appropriately set the comparator in the model.
> > >>
> > > 
> > > [Vojtech/GUI-maintainers - your input would be appreciated here]
> > > 
> > > we are actually planning on upgrading the GWT version *really* soon (to
> > > GWT
> > > 2.5),
> > > so my question is: should we wait until the new GWT is introduced, and
> > > implement
> > > client-sorting based on the GWT-grid-widget built-in mechanism (assuming
> > > there is
> > > one)?
> > > also, not sure if it is better to utilize the widget default-built-in
> > > sorting mechanism
> > > (which doesn't manipulate the uicommon model data at all), or if it is
> > > better to utilize
> > > your comparator mechanism, which manipulates the uicommon model data, and
> > > the GUI-widget
> > > just reflects this data at any given time.
> > > thoughts?
> > 
> > I'll just give my two cents concerning this and then let others have the
> > stage: I don't think it really matters.
> > 
> > Manipulating the models directly is supposedly more portable in case we
> > ever move away from GWT, but we'd still have the pain of adding new
> > listeners to the new framework's table headers which could be just as
> > bad as using its sorting mechanism.
> > 
> > Graphically, the UI might look tighter if we use GWT's mechanism.
> > However, we could probably mimic everything using GWT's graphics (once
> > we upgrade) even if we perform the actual sorting using the tab model
> > and not their mechanism.
> > 
> > My gut feeling actually says to use GWT's built-in mechanism, mainly
> > because it will force us to put all sorting logic in the same place and
> > to always use the same sorting mechanism (whereas currently the sorting
> > logic is scattered and works differently in different places, even if we
> > use this tab mechanism other widgets will differ). But it shouldn't stop
> > us from setting a comparator for a tab where convenient.
> 
> [again, GUI maintainers - your input would be appreciated]
> 
> Thanks, Lior. Need to keep in mind several things:
> 
> - we are now talking only about client-sorting, which generally we would like
> to apply only to grids that display none-"pagable"-results; for grids that
> would
> display pagable-results, we would want to use search-based (i.e. server)
> sorting.
> [so the sorting logic across the application would be somewhat-scattered
> anyway].
> 
> - I think that if we are choosing to utilize GWT's built-in mechanism, then
> using
> a comparator would makes sense in case you want your results to be initially
> displayed
> in a specific order that would not be obtainable using the column-header
> sorting.
> 
> e.g. (dumb example, for demonstration only) if you would want your VMs to be
> displayed
> by default sorted alphabetically according to the VM's description (and keep
> in mind
> that description is NOT one of the columns in the VMs grid), then you would
> probably
> want to do that via the comparator.
> 
> Or (perhaps a better example), if you would want your Templates to be ordered
> by default
> in a way that "Blank" would appear first, and the rest would appear sorted
> alphabetically
> by name, utilizing the comparator can be a good idea.
> [After the initial load of the grid, if the user chooses to sort by name, he
> can click on
> the "Name" column header, which will sort the Templates alphabetically
> "regularly" (i.e.
> not taking "Blank" into special consideration)]
> 
> But - if, by default, we would want, for example, to sort VMs alphabetically
> by name,
> I think that we should imitate a mouse-click on the "Name" column-header,
> rather than
> utilize a comparator for that (the exact same result shouldn't be achieved by
> two different
> implementations).

Hi Lior,

fist of all, I would be really careful about introducing something to UiCommon which could
potentially cause class cast exceptions - not that your approach would be incorrect but the 
UiCommon has lot's of hidden expectations and it is hard to keep tract who expects the
ListModel.getItems will be a list. I would be double careful about this kind of change right
before the freeze. Maybe create a SortedSearchableListModel as a child of SearchableListModel 
would be a much more safe approach.

About the GWT built-in vs Comparator - 
I would also go with the GWT's built in approach.
If we are using a framework we should make use of it and not
try to decouple too much to make it simpler to migrate to a different one.

So I agree with Lior that we should go with GWT's built in approach.
AFAIK Vojtech is already working on the GWT2.5 integration...

Also I would say that we should have the same user experience regardless the table is paged or not
e.g. the user needs to have the same button to click on and the result must make sense after he clicked
it everywhere. So I would say we will have to integrate this GUI sorting with server side sorting for paged tables.

But maybe this integration (however a ideal target) is a bit out of the scope of your initial intention ;)

If you have a good reason to have something always sorted and it is not a paged table, I'm not against. 
Just please be a bit more careful in changing return types in a non-generic code like UiCommon.

> 
> > 
> > >>>>
> > >>>>>
> > >>>>> I believe that the correct thing to do is to "attach" the GUI sorting
> > >>>>> mechanism
> > >>>>> to the one in the search mechanism.
> > >>>>>
> > >>>>> thoughts?
> > >>>>
> > >>>> This can be done, however I'm not sure there's much utility in it.
> > >>>> Main
> > >>>> tabs are always sorted according to some default ordering even if one
> > >>>> was not entered in the search panel, and this sorting is also
> > >>>> performed
> > >>>> consistently with respect to paging. So maybe the right thing to do
> > >>>> would be to just "block" the GUI sorting mechanism for main tabs (i.e.
> > >>>> override the setter method and make it no-op)?
> > >>>
> > >>> yes, and related to what I mentioned above - at some point in the
> > >>> future,
> > >>> we'd might want
> > >>> to block it for search-based sub-tabs as well.
> > >>>
> > >>>>
> > >>>>>>
> > >>>>>>
> > >>>>>>>
> > >>>>>>> http://gerrit.ovirt.org/#/c/15846/
> > >>>>>>>
> > >>>>>>> If a comparator isn't set, then everything should behave as before.
> > >>>>>>> If
> > >>>>>>> a
> > >>>>>>> comparator is set, then from that moment on the tab items will be
> > >>>>>>> kept
> > >>>>>>> in a SortedSet, so that even if an item is added in a way that
> > >>>>>>> doesn't
> > >>>>>>> trigger an event (e.g. getItems().add()) the items will be kept
> > >>>>>>> sorted
> > >>>>>>> according to the given comparator. If the comparator is set to
> > >>>>>>> null,
> > >>>>>>> from that moment on the tab should revert to its old behaviour.
> > >>>>>>>
> > >>>>>>> You're most welcome to have a look and let me know if this might
> > >>>>>>> break
> > >>>>>>> something (remember though that it's not obligatory to set a
> > >>>>>>> comparator,
> > >>>>>>> so only possible breakage should be in generic flows).
> > >>>>>>>
> > >>>>>>> Feel free to use it once it's merged; along with SortedListModel,
> > >>>>>>> this
> > >>>>>>> should make sorting less painful. Just keep in mind that once you
> > >>>>>>> set
> > >>>>>>> a
> > >>>>>>> comparator, you can't cast getItems() to a List. This shouldn't be
> > >>>>>>> a
> > >>>>>>> problem in general, as mostly it's as useful (and probably more
> > >>>>>>> correct)
> > >>>>>>> to cast to a Collection.
> > >>>>>>>
> > >>>>>>> Lior.
> > >>>>>>> _______________________________________________
> > >>>>>>> Engine-devel mailing list
> > >>>>>>> Engine-devel at ovirt.org
> > >>>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> > >>>>>>>
> > >>>>>> _______________________________________________
> > >>>>>> Engine-devel mailing list
> > >>>>>> Engine-devel at ovirt.org
> > >>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> > >>>>>>
> > >>>>
> > >>
> > 
> 


From tjelinek at redhat.com  Fri Jun 28 07:00:47 2013
From: tjelinek at redhat.com (Tomas Jelinek)
Date: Fri, 28 Jun 2013 03:00:47 -0400 (EDT)
Subject: [Engine-devel] Sorting in tabs
In-Reply-To: <371875056.2962175.1372401917952.JavaMail.root@redhat.com>
References: <51CBE5E1.7080900@redhat.com> <51CC35E7.6030200@redhat.com>
	<1572668253.9189415.1372340538767.JavaMail.root@redhat.com>
	<51CC4E4C.4030507@redhat.com>
	<1796469050.9281535.1372346129622.JavaMail.root@redhat.com>
	<51CC6512.50509@redhat.com>
	<422687242.9340619.1372351256617.JavaMail.root@redhat.com>
	<371875056.2962175.1372401917952.JavaMail.root@redhat.com>
Message-ID: <1674644916.2967768.1372402847694.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Tomas Jelinek" <tjelinek at redhat.com>
> To: "Einav Cohen" <ecohen at redhat.com>
> Cc: "Lior Vernia" <lvernia at redhat.com>, "Vojtech Szocs" <vszocs at redhat.com>, "Eli Mesika" <emesika at redhat.com>,
> engine-devel at ovirt.org, "Alexander Wels" <awels at redhat.com>, "Daniel Erez" <derez at redhat.com>, "Gilad Chaplik"
> <gchaplik at redhat.com>, "Alona Kaplan" <alkaplan at redhat.com>
> Sent: Friday, June 28, 2013 8:45:17 AM
> Subject: Re: [Engine-devel] Sorting in tabs
> 
> 
> 
> ----- Original Message -----
> > From: "Einav Cohen" <ecohen at redhat.com>
> > To: "Lior Vernia" <lvernia at redhat.com>
> > Cc: "Vojtech Szocs" <vszocs at redhat.com>, "Eli Mesika" <emesika at redhat.com>,
> > engine-devel at ovirt.org, "Alexander Wels"
> > <awels at redhat.com>, "Daniel Erez" <derez at redhat.com>, "Gilad Chaplik"
> > <gchaplik at redhat.com>, "Alona Kaplan"
> > <alkaplan at redhat.com>, "Tomas Jelinek" <tjelinek at redhat.com>
> > Sent: Thursday, June 27, 2013 6:40:56 PM
> > Subject: Re: [Engine-devel] Sorting in tabs
> > 
> > > ----- Original Message -----
> > > From: "Lior Vernia" <lvernia at redhat.com>
> > > Sent: Thursday, June 27, 2013 12:15:14 PM
> > > 
> > > 
> > > 
> > > On 27/06/13 18:15, Einav Cohen wrote:
> > > >> ----- Original Message -----
> > > >> From: "Lior Vernia" <lvernia at redhat.com>
> > > >> Sent: Thursday, June 27, 2013 10:38:04 AM
> > > >>
> > > >>
> > > >>
> > > >> On 27/06/13 16:42, Einav Cohen wrote:
> > > >>>> ----- Original Message -----
> > > >>>> From: "Lior Vernia" <lvernia at redhat.com>
> > > >>>> Sent: Thursday, June 27, 2013 8:53:59 AM
> > > >>>>
> > > >>>>
> > > >>>>
> > > >>>> On 27/06/13 15:37, Einav Cohen wrote:
> > > >>>>>> ----- Original Message -----
> > > >>>>>> From: "Eli Mesika" <emesika at redhat.com>
> > > >>>>>> Sent: Thursday, June 27, 2013 6:46:58 AM
> > > >>>>>>
> > > >>>>>>
> > > >>>>>> ----- Original Message -----
> > > >>>>>>> From: "Lior Vernia" <lvernia at redhat.com>
> > > >>>>>>> To: engine-devel at ovirt.org
> > > >>>>>>> Sent: Thursday, June 27, 2013 10:12:33 AM
> > > >>>>>>> Subject: [Engine-devel] Sorting in tabs
> > > >>>>>>>
> > > >>>>>>> Hello everyone (UI peeps in particular),
> > > >>>>>>>
> > > >>>>>>> I've pushed (not yet merged) a patch that would enable us to keep
> > > >>>>>>> items
> > > >>>>>>> in tabs (main/sub) sorted at all times by setting a comparator in
> > > >>>>>>> SearchableListModel:
> > > >>>>>>
> > > >>>>>> But tabs includes only 100 records and supports paging , how you
> > > >>>>>> deal
> > > >>>>>> with
> > > >>>>>> that ???
> > > >>>>>
> > > >>>>> if this is in the GUI level, then I assume that the comparator is
> > > >>>>> simply
> > > >>>>> comparing the
> > > >>>>> items within the current page, and not "globally".
> > > >>>>> so the sorting doesn't affect the set of items that is displayed in
> > > >>>>> the
> > > >>>>> page (it would
> > > >>>>> be the same as before the sorting) - just their order.
> > > >>>>
> > > >>>> Yes, if I understand correctly how the paging works, Einav is
> > > >>>> correct
> > > >>>> -
> > > >>>> only the items passed to the UI are sorted.
> > > >>>>
> > > >>>>> also: @Lior - what happens when the search query contains a "sort
> > > >>>>> by"
> > > >>>>> part?
> > > >>>>> there is a chance that the behaivor would be unexpected in this
> > > >>>>> case;
> > > >>>>
> > > >>>> Yes, I thought about this case, and it may result in a confusing
> > > >>>> user
> > > >>>> experience if developers aren't careful. Together with the issue of
> > > >>>> paging, this probably makes this sorting mechanism a better
> > > >>>> candidate
> > > >>>> for use within subtabs rather than main tabs.
> > > >>>
> > > >>> note that at some point, I think that we would want to introduce
> > > >>> paging
> > > >>> also to search-
> > > >>> based sub-tabs - it will be useful especially for sub-tabs that
> > > >>> potentially
> > > >>> display a
> > > >>> large number of results (e.g. Disks sub-tab in Storage main tab).
> > > >>> In addition, at some point, we would want to get rid of the paging UI
> > > >>> as
> > > >>> it
> > > >>> is now
> > > >>> (i.e. "next"/"prev" buttons at the top panel) and move to paging
> > > >>> triggered
> > > >>> by scroll
> > > >>> (i.e. have a very long grid, dynamically loaded as you continue to
> > > >>> scroll
> > > >>> -
> > > >>> similar
> > > >>> to the behavior of some e-mail web-clients, for example). In this
> > > >>> case,
> > > >>> sorting on
> > > >>> the client side will make no sense at all (i.e. from the user
> > > >>> perspective,
> > > >>> only a
> > > >>> portion of a very large grid will be sorted, the other portions won't
> > > >>> be).
> > > >>>
> > > >>> So for now - yes, I think it makes sense to introduce your mechanism
> > > >>> to
> > > >>> all
> > > >>> sub-tabs,
> > > >>> however in the long-term - we would probably want the search-based
> > > >>> sub-tabs
> > > >>> (which
> > > >>> will support paging) to move to search-based sorting, rather than
> > > >>> GUI-based-sorting.
> > > >>
> > > >> Sounds good to me. Let me just re-iterate that it is not mandatory to
> > > >> set a comparator, so in technical terms it's not even necessary to
> > > >> introduce it at once to all sub-tabs, if they're already sorting their
> > > >> items some other way. It could happen gradually, and only if
> > > >> developers
> > > >> find it more convenient. In either case, dropping the GUI sorting once
> > > >> search-based sorting is implemented shouldn't be difficult.
> > > >>
> > > >>> BTW (maybe the other GUI maintainers can help me with that one) -
> > > >>> what
> > > >>> about sub-tabs
> > > >>> that are not search-based (i.e. display results from a "regular"
> > > >>> query
> > > >>> or
> > > >>> even from a
> > > >>> field within the selected item in the main grid, e.g. Applications in
> > > >>> VM)
> > > >>> -
> > > >>> are these
> > > >>> managed via SearchableListModel as well? since the comparator
> > > >>> mechanism
> > > >>> *is* relevant
> > > >>> for them.
> > > >>
> > > >> As far as I've seen, some are managed via SearchableListModel and some
> > > >> aren't. Those that aren't are those that display non-trivial behaviour
> > > >> upon receipt of the items to display (setItems() method) - often this
> > > >> non-trivial behaviour is exactly sorting :) And if it's doing its job,
> > > >> then there's no necessity to change it either. But anyway, I don't
> > > >> know
> > > >> all of them, so I'd also love to hear GUI maintainers.
> > > >>
> > > >>> Also: Worth mentioning "Bug 893999 - webadmin: please allow column
> > > >>> sorting", which
> > > >>> requests to enable sorting when clicking on a grid-column header;
> > > >>> when
> > > >>> implementing
> > > >>> column-sorting, probably worth attaching your mechanism to it somehow
> > > >>> (i.e.
> > > >>> clicking on
> > > >>> a column header should set the relevant comparator in the relevant
> > > >>> SearchableListModel).
> > > >>
> > > >> I didn't want to say it, because if we upgrade to a newer version of
> > > >> GWT
> > > >> then we could probably use their table column sorting. But this
> > > >> mechanism could allow us to achieve this without upgrading, and it was
> > > >> definitely sitting in the back of my head when I implemented it. All
> > > >> that's needed is, as you said, to listen to table header clicks in the
> > > >> view, and then appropriately set the comparator in the model.
> > > >>
> > > > 
> > > > [Vojtech/GUI-maintainers - your input would be appreciated here]
> > > > 
> > > > we are actually planning on upgrading the GWT version *really* soon (to
> > > > GWT
> > > > 2.5),
> > > > so my question is: should we wait until the new GWT is introduced, and
> > > > implement
> > > > client-sorting based on the GWT-grid-widget built-in mechanism
> > > > (assuming
> > > > there is
> > > > one)?
> > > > also, not sure if it is better to utilize the widget default-built-in
> > > > sorting mechanism
> > > > (which doesn't manipulate the uicommon model data at all), or if it is
> > > > better to utilize
> > > > your comparator mechanism, which manipulates the uicommon model data,
> > > > and
> > > > the GUI-widget
> > > > just reflects this data at any given time.
> > > > thoughts?
> > > 
> > > I'll just give my two cents concerning this and then let others have the
> > > stage: I don't think it really matters.
> > > 
> > > Manipulating the models directly is supposedly more portable in case we
> > > ever move away from GWT, but we'd still have the pain of adding new
> > > listeners to the new framework's table headers which could be just as
> > > bad as using its sorting mechanism.
> > > 
> > > Graphically, the UI might look tighter if we use GWT's mechanism.
> > > However, we could probably mimic everything using GWT's graphics (once
> > > we upgrade) even if we perform the actual sorting using the tab model
> > > and not their mechanism.
> > > 
> > > My gut feeling actually says to use GWT's built-in mechanism, mainly
> > > because it will force us to put all sorting logic in the same place and
> > > to always use the same sorting mechanism (whereas currently the sorting
> > > logic is scattered and works differently in different places, even if we
> > > use this tab mechanism other widgets will differ). But it shouldn't stop
> > > us from setting a comparator for a tab where convenient.
> > 
> > [again, GUI maintainers - your input would be appreciated]
> > 
> > Thanks, Lior. Need to keep in mind several things:
> > 
> > - we are now talking only about client-sorting, which generally we would
> > like
> > to apply only to grids that display none-"pagable"-results; for grids that
> > would
> > display pagable-results, we would want to use search-based (i.e. server)
> > sorting.
> > [so the sorting logic across the application would be somewhat-scattered
> > anyway].
> > 
> > - I think that if we are choosing to utilize GWT's built-in mechanism, then
> > using
> > a comparator would makes sense in case you want your results to be
> > initially
> > displayed
> > in a specific order that would not be obtainable using the column-header
> > sorting.
> > 
> > e.g. (dumb example, for demonstration only) if you would want your VMs to
> > be
> > displayed
> > by default sorted alphabetically according to the VM's description (and
> > keep
> > in mind
> > that description is NOT one of the columns in the VMs grid), then you would
> > probably
> > want to do that via the comparator.
> > 
> > Or (perhaps a better example), if you would want your Templates to be
> > ordered
> > by default
> > in a way that "Blank" would appear first, and the rest would appear sorted
> > alphabetically
> > by name, utilizing the comparator can be a good idea.
> > [After the initial load of the grid, if the user chooses to sort by name,
> > he
> > can click on
> > the "Name" column header, which will sort the Templates alphabetically
> > "regularly" (i.e.
> > not taking "Blank" into special consideration)]
> > 
> > But - if, by default, we would want, for example, to sort VMs
> > alphabetically
> > by name,
> > I think that we should imitate a mouse-click on the "Name" column-header,
> > rather than
> > utilize a comparator for that (the exact same result shouldn't be achieved
> > by
> > two different
> > implementations).
> 
> Hi Lior,
> 
> fist of all, I would be really careful about introducing something to
> UiCommon which could
> potentially cause class cast exceptions - not that your approach would be
> incorrect but the
> UiCommon has lot's of hidden expectations and it is hard to keep tract who
> expects the
> ListModel.getItems will be a list. I would be double careful about this kind
> of change right
> before the freeze. Maybe create a SortedSearchableListModel as a child of
> SearchableListModel
> would be a much more safe approach.
> 
> About the GWT built-in vs Comparator -
> I would also go with the GWT's built in approach.
> If we are using a framework we should make use of it and not
> try to decouple too much to make it simpler to migrate to a different one.
> 
> So I agree with Lior that we should go with GWT's built in approach.
> AFAIK Vojtech is already working on the GWT2.5 integration...
> 
> Also I would say that we should have the same user experience regardless the
> table is paged or not
> e.g. the user needs to have the same button to click on and the result must
> make sense after he clicked
> it everywhere. So I would say we will have to integrate this GUI sorting with
> server side sorting for paged tables.
> 
> But maybe this integration (however a ideal target) is a bit out of the scope
> of your initial intention ;)
> 
> If you have a good reason to have something always sorted and it is not a
> paged table, I'm not against.
> Just please be a bit more careful in changing return types in a non-generic
> code like UiCommon.
Ooops, now I have looked into your code and realized that you return a different type only if the comparator is set
which makes your patch much less risky - but at the same time much less predictable.

But this kind of implementation details should be discussed on gerrit, so if it will be
decided that the patch should go in in some form we can continue the discussion on gerrit.

> 
> > 
> > > 
> > > >>>>
> > > >>>>>
> > > >>>>> I believe that the correct thing to do is to "attach" the GUI
> > > >>>>> sorting
> > > >>>>> mechanism
> > > >>>>> to the one in the search mechanism.
> > > >>>>>
> > > >>>>> thoughts?
> > > >>>>
> > > >>>> This can be done, however I'm not sure there's much utility in it.
> > > >>>> Main
> > > >>>> tabs are always sorted according to some default ordering even if
> > > >>>> one
> > > >>>> was not entered in the search panel, and this sorting is also
> > > >>>> performed
> > > >>>> consistently with respect to paging. So maybe the right thing to do
> > > >>>> would be to just "block" the GUI sorting mechanism for main tabs
> > > >>>> (i.e.
> > > >>>> override the setter method and make it no-op)?
> > > >>>
> > > >>> yes, and related to what I mentioned above - at some point in the
> > > >>> future,
> > > >>> we'd might want
> > > >>> to block it for search-based sub-tabs as well.
> > > >>>
> > > >>>>
> > > >>>>>>
> > > >>>>>>
> > > >>>>>>>
> > > >>>>>>> http://gerrit.ovirt.org/#/c/15846/
> > > >>>>>>>
> > > >>>>>>> If a comparator isn't set, then everything should behave as
> > > >>>>>>> before.
> > > >>>>>>> If
> > > >>>>>>> a
> > > >>>>>>> comparator is set, then from that moment on the tab items will be
> > > >>>>>>> kept
> > > >>>>>>> in a SortedSet, so that even if an item is added in a way that
> > > >>>>>>> doesn't
> > > >>>>>>> trigger an event (e.g. getItems().add()) the items will be kept
> > > >>>>>>> sorted
> > > >>>>>>> according to the given comparator. If the comparator is set to
> > > >>>>>>> null,
> > > >>>>>>> from that moment on the tab should revert to its old behaviour.
> > > >>>>>>>
> > > >>>>>>> You're most welcome to have a look and let me know if this might
> > > >>>>>>> break
> > > >>>>>>> something (remember though that it's not obligatory to set a
> > > >>>>>>> comparator,
> > > >>>>>>> so only possible breakage should be in generic flows).
> > > >>>>>>>
> > > >>>>>>> Feel free to use it once it's merged; along with SortedListModel,
> > > >>>>>>> this
> > > >>>>>>> should make sorting less painful. Just keep in mind that once you
> > > >>>>>>> set
> > > >>>>>>> a
> > > >>>>>>> comparator, you can't cast getItems() to a List. This shouldn't
> > > >>>>>>> be
> > > >>>>>>> a
> > > >>>>>>> problem in general, as mostly it's as useful (and probably more
> > > >>>>>>> correct)
> > > >>>>>>> to cast to a Collection.
> > > >>>>>>>
> > > >>>>>>> Lior.
> > > >>>>>>> _______________________________________________
> > > >>>>>>> Engine-devel mailing list
> > > >>>>>>> Engine-devel at ovirt.org
> > > >>>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > >>>>>>>
> > > >>>>>> _______________________________________________
> > > >>>>>> Engine-devel mailing list
> > > >>>>>> Engine-devel at ovirt.org
> > > >>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > >>>>>>
> > > >>>>
> > > >>
> > > 
> >


From alonbl at redhat.com  Fri Jun 28 07:46:36 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Fri, 28 Jun 2013 03:46:36 -0400 (EDT)
Subject: [Engine-devel] Problem with development environment
In-Reply-To: <925161444.931059.1372399193567.JavaMail.root@redhat.com>
References: <925161444.931059.1372399193567.JavaMail.root@redhat.com>
Message-ID: <1066374957.12950088.1372405596873.JavaMail.root@redhat.com>


Hello Marina,

Thank you for the report.

I can confirm that.

Workaround:

rm -f packaging/dbscripts/upgrade.sh.log

I will fix that soon.

Thanks,
Alon

----- Original Message -----
> From: "Martin Perina" <mperina at redhat.com>
> To: engine-devel at ovirt.org
> Sent: Friday, June 28, 2013 8:59:53 AM
> Subject: [Engine-devel] Problem with development environment
> 
> Hi,
> 
> I've encountered a problem using development environment. When I run
> 
>  make clean install-dev PREFIX="$HOME/ovirt-engine"
> 
> there appears this error message:
> 
> make[2]: Leaving directory `/home/mperina/projects/ovirt/ovirt-engine'
> # we should avoid make these directories dirty
> make copy-recursive SOURCEDIR=packaging/dbscripts
> TARGETDIR="/home/mperina/ovirt-engine/share/ovirt-engine/dbscripts" \
> 	EXCLUDE_GEN="packaging/bin/engine-prolog.sh packaging/bin/pki-common.sh
> 	packaging/conf/engine.conf.defaults packaging/conf/notifier.conf.defaults
> 	packaging/conf/ovirt-websocket-proxy.conf.defaults
> 	packaging/etc/engine-config/log4j.xml
> 	packaging/etc/engine-manage-domains/log4j.xml
> 	packaging/etc/engine-manage-domains/engine-manage-domains.conf
> 	packaging/etc/notifier/log4j.xml packaging/sys-etc/logrotate.d/ovirt-engine
> 	packaging/services/config.py packaging/services/ovirt-engine.systemd
> 	packaging/services/ovirt-engine.sysv
> 	packaging/services/ovirt-engine-notifier.systemd
> 	packaging/services/ovirt-engine-notifier.sysv
> 	packaging/services/ovirt-websocket-proxy.systemd
> 	packaging/services/ovirt-websocket-proxy.sysv
> 	packaging/setup/ovirt_engine_setup/config.py
> 	packaging/bin/ovirt-engine-log-setup-event.sh ovirt-engine.spec " \
> 	EXCLUDE="$(find packaging/dbscripts \( -name '*.scripts.md5' -or -name
> 	'*.schema' -or -name '*.log' \))"
> make[2]: Entering directory `/home/mperina/projects/ovirt/ovirt-engine'
> ( cd "packaging/dbscripts" && find . -type d -printf '%P\n' ) | while read d;
> do \
> 	install -d -m 755
> 	"/home/mperina/ovirt-engine/share/ovirt-engine/dbscripts/${d}"; \
> done
> ( \
> 	cd "packaging/dbscripts" && find . -type f -printf '%P\n' | \
> 	while read f; do \
> 		exclude=false; \
> 		set -x; \
> 		for x in packaging/bin/engine-prolog.sh packaging/bin/pki-common.sh
> 		packaging/conf/engine.conf.defaults packaging/conf/notifier.conf.defaults
> 		packaging/conf/ovirt-websocket-proxy.conf.defaults
> 		packaging/etc/engine-config/log4j.xml
> 		packaging/etc/engine-manage-domains/log4j.xml
> 		packaging/etc/engine-manage-domains/engine-manage-domains.conf
> 		packaging/etc/notifier/log4j.xml
> 		packaging/sys-etc/logrotate.d/ovirt-engine packaging/services/config.py
> 		packaging/services/ovirt-engine.systemd
> 		packaging/services/ovirt-engine.sysv
> 		packaging/services/ovirt-engine-notifier.systemd
> 		packaging/services/ovirt-engine-notifier.sysv
> 		packaging/services/ovirt-websocket-proxy.systemd
> 		packaging/services/ovirt-websocket-proxy.sysv
> 		packaging/setup/ovirt_engine_setup/config.py
> 		packaging/bin/ovirt-engine-log-setup-event.sh ovirt-engine.spec ; do \
> 			if [ "packaging/dbscripts/${f}" = "${x}.in" ]; then \
> 				exclude=true; \
> 				break; \
> 			fi; \
> 		done; \
> 		for x in packaging/dbscripts/upgrade.sh.log
> /bin/sh: -c: line 12: syntax error: unexpected end of file
> make[2]: *** [copy-recursive] Error 1
> make[2]: Leaving directory `/home/mperina/projects/ovirt/ovirt-engine'
> make[1]: *** [install-packaging-files] Error 2
> make[1]: Leaving directory `/home/mperina/projects/ovirt/ovirt-engine'
> make: *** [install-dev] Error 2
> 
> 
> I've already upgraded to otopi 1.1 (currently
> 1.1.0-0.0.master.20130626.git33d9561.fc18).
> 
> 
> Martin Perina
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From mperina at redhat.com  Fri Jun 28 08:31:44 2013
From: mperina at redhat.com (Martin Perina)
Date: Fri, 28 Jun 2013 04:31:44 -0400 (EDT)
Subject: [Engine-devel] Problem with development environment
In-Reply-To: <1066374957.12950088.1372405596873.JavaMail.root@redhat.com>
References: <925161444.931059.1372399193567.JavaMail.root@redhat.com>
	<1066374957.12950088.1372405596873.JavaMail.root@redhat.com>
Message-ID: <290605992.999369.1372408304442.JavaMail.root@redhat.com>

Hi,

workaround helped.

Thanks

Martin


----- Original Message -----
> From: "Alon Bar-Lev" <alonbl at redhat.com>
> To: "Martin Perina" <mperina at redhat.com>
> Cc: engine-devel at ovirt.org
> Sent: Friday, June 28, 2013 9:46:36 AM
> Subject: Re: [Engine-devel] Problem with development environment
> 
> 
> Hello Marina,
> 
> Thank you for the report.
> 
> I can confirm that.
> 
> Workaround:
> 
> rm -f packaging/dbscripts/upgrade.sh.log
> 
> I will fix that soon.
> 
> Thanks,
> Alon
> 
> ----- Original Message -----
> > From: "Martin Perina" <mperina at redhat.com>
> > To: engine-devel at ovirt.org
> > Sent: Friday, June 28, 2013 8:59:53 AM
> > Subject: [Engine-devel] Problem with development environment
> > 
> > Hi,
> > 
> > I've encountered a problem using development environment. When I run
> > 
> >  make clean install-dev PREFIX="$HOME/ovirt-engine"
> > 
> > there appears this error message:
> > 
> > make[2]: Leaving directory `/home/mperina/projects/ovirt/ovirt-engine'
> > # we should avoid make these directories dirty
> > make copy-recursive SOURCEDIR=packaging/dbscripts
> > TARGETDIR="/home/mperina/ovirt-engine/share/ovirt-engine/dbscripts" \
> > 	EXCLUDE_GEN="packaging/bin/engine-prolog.sh packaging/bin/pki-common.sh
> > 	packaging/conf/engine.conf.defaults packaging/conf/notifier.conf.defaults
> > 	packaging/conf/ovirt-websocket-proxy.conf.defaults
> > 	packaging/etc/engine-config/log4j.xml
> > 	packaging/etc/engine-manage-domains/log4j.xml
> > 	packaging/etc/engine-manage-domains/engine-manage-domains.conf
> > 	packaging/etc/notifier/log4j.xml
> > 	packaging/sys-etc/logrotate.d/ovirt-engine
> > 	packaging/services/config.py packaging/services/ovirt-engine.systemd
> > 	packaging/services/ovirt-engine.sysv
> > 	packaging/services/ovirt-engine-notifier.systemd
> > 	packaging/services/ovirt-engine-notifier.sysv
> > 	packaging/services/ovirt-websocket-proxy.systemd
> > 	packaging/services/ovirt-websocket-proxy.sysv
> > 	packaging/setup/ovirt_engine_setup/config.py
> > 	packaging/bin/ovirt-engine-log-setup-event.sh ovirt-engine.spec " \
> > 	EXCLUDE="$(find packaging/dbscripts \( -name '*.scripts.md5' -or -name
> > 	'*.schema' -or -name '*.log' \))"
> > make[2]: Entering directory `/home/mperina/projects/ovirt/ovirt-engine'
> > ( cd "packaging/dbscripts" && find . -type d -printf '%P\n' ) | while read
> > d;
> > do \
> > 	install -d -m 755
> > 	"/home/mperina/ovirt-engine/share/ovirt-engine/dbscripts/${d}"; \
> > done
> > ( \
> > 	cd "packaging/dbscripts" && find . -type f -printf '%P\n' | \
> > 	while read f; do \
> > 		exclude=false; \
> > 		set -x; \
> > 		for x in packaging/bin/engine-prolog.sh packaging/bin/pki-common.sh
> > 		packaging/conf/engine.conf.defaults packaging/conf/notifier.conf.defaults
> > 		packaging/conf/ovirt-websocket-proxy.conf.defaults
> > 		packaging/etc/engine-config/log4j.xml
> > 		packaging/etc/engine-manage-domains/log4j.xml
> > 		packaging/etc/engine-manage-domains/engine-manage-domains.conf
> > 		packaging/etc/notifier/log4j.xml
> > 		packaging/sys-etc/logrotate.d/ovirt-engine packaging/services/config.py
> > 		packaging/services/ovirt-engine.systemd
> > 		packaging/services/ovirt-engine.sysv
> > 		packaging/services/ovirt-engine-notifier.systemd
> > 		packaging/services/ovirt-engine-notifier.sysv
> > 		packaging/services/ovirt-websocket-proxy.systemd
> > 		packaging/services/ovirt-websocket-proxy.sysv
> > 		packaging/setup/ovirt_engine_setup/config.py
> > 		packaging/bin/ovirt-engine-log-setup-event.sh ovirt-engine.spec ; do \
> > 			if [ "packaging/dbscripts/${f}" = "${x}.in" ]; then \
> > 				exclude=true; \
> > 				break; \
> > 			fi; \
> > 		done; \
> > 		for x in packaging/dbscripts/upgrade.sh.log
> > /bin/sh: -c: line 12: syntax error: unexpected end of file
> > make[2]: *** [copy-recursive] Error 1
> > make[2]: Leaving directory `/home/mperina/projects/ovirt/ovirt-engine'
> > make[1]: *** [install-packaging-files] Error 2
> > make[1]: Leaving directory `/home/mperina/projects/ovirt/ovirt-engine'
> > make: *** [install-dev] Error 2
> > 
> > 
> > I've already upgraded to otopi 1.1 (currently
> > 1.1.0-0.0.master.20130626.git33d9561.fc18).
> > 
> > 
> > Martin Perina
> > 
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> 


From vszocs at redhat.com  Fri Jun 28 15:10:34 2013
From: vszocs at redhat.com (Vojtech Szocs)
Date: Fri, 28 Jun 2013 11:10:34 -0400 (EDT)
Subject: [Engine-devel] IE9 Issue with UI Plugin
In-Reply-To: <CDE780A4.56D4%rickyh@netapp.com>
References: <CDE780A4.56D4%rickyh@netapp.com>
Message-ID: <1386820619.3136967.1372432234517.JavaMail.root@redhat.com>

Hi Ricky,

did you manage to solve the issue related with IE dev tools? If there are still issues pointing to UI plugin infrastructure, please let me know.

Regards,
Vojtech


----- Original Message -----
> From: "Richard Hopper" <Richard.Hopper at netapp.com>
> To: "Vojtech Szocs" <vszocs at redhat.com>
> Cc: engine-devel at ovirt.org, "Christopher Morrissey" <Christopher.Morrissey at netapp.com>
> Sent: Wednesday, June 19, 2013 9:39:50 PM
> Subject: Re: [Engine-devel] IE9 Issue with UI Plugin
> 
> Hi Vojtech,
> 
> I've tested the new patch and for some reason am still running into
> problems, though there are different exceptions now. I'll let you know if
> we figure out what specifically is going on. It does work if dev tools are
> up, but if there are no developer tools available the window will still
> not close.
> 
> - Ricky
> 
> On 6/19/13 9:19 AM, "Vojtech Szocs" <vszocs at redhat.com> wrote:
> 
> >Hi Ricky,
> >
> >you were right, in IE9, postMessage listener (WebAdmin) didn't work
> >properly, so I simplified it and verified that it now works in IE9, too:
> >http://gerrit.ovirt.org/#/c/15888/
> >
> >After applying above mentioned patch, everything should work as expected
> >in IE9. I've also attached "test-plugin" which I used for verification in
> >IE9.
> >
> >Regards,
> >Vojtech
> >
> >
> >----- Original Message -----
> >> From: "Vojtech Szocs" <vszocs at redhat.com>
> >> To: "Richard Hopper" <Richard.Hopper at netapp.com>
> >> Cc: engine-devel at ovirt.org, "Christopher Morrissey"
> >><Christopher.Morrissey at netapp.com>
> >> Sent: Wednesday, June 19, 2013 11:54:16 AM
> >> Subject: Re: [Engine-devel] IE9 Issue with UI Plugin
> >> 
> >> Hi Ricky,
> >> 
> >> code running in the iframe (custom dialog content) can close the dialog
> >>in
> >> the following way:
> >> 
> >> 1, send message to your plugin to indicate the dialog needs to be
> >>closed:
> >> 
> >>     parent.postMessage('CloseMyDialog', '*');
> >> 
> >> 2, your plugin intercepts the message via MessageReceived function and
> >>closes
> >> the dialog:
> >> 
> >>     MessageReceived: function(data, sourceWindow) {
> >>         switch (data) {
> >>             case 'CloseMyDialog':
> >>                 window.alert('About to close dialog');
> >>                 api.closeDialog('my-dialog');
> >>                 break;
> >>         }
> >>     }
> >> 
> >> If the above doesn't work for you, it could mean that:
> >> - MessageReceived function isn't invoked - make sure to have [*] before
> >> api.register() call
> >> - api.closeDialog() function isn't working - in this case I need to fix
> >>it
> >> for IE9
> >> 
> >> [*] accept message events from iframe (custom dialog content) origin
> >> 
> >>     api.options({
> >>         allowedMessageOrigins: 'http://nicedomain:8080'
> >>         /* OR */
> >>         allowedMessageOrigins: ['http://nicedomain1:123',
> >>         'https://nicedomain2:345']
> >>     });
> >> 
> >> I'm going to investigate this issue on IE9 myself to see if the above
> >>code is
> >> really working there.
> >> 
> >> Vojtech
> >> 
> >> 
> >> ----- Original Message -----
> >> > From: "Richard Hopper" <Richard.Hopper at netapp.com>
> >> > To: "Vojtech Szocs" <vszocs at redhat.com>
> >> > Cc: engine-devel at ovirt.org, "Christopher Morrissey"
> >> > <Christopher.Morrissey at netapp.com>
> >> > Sent: Monday, June 17, 2013 8:16:03 PM
> >> > Subject: IE9 Issue with UI Plugin
> >> > 
> >> > Hi Vojtech,
> >> > 
> >> > I had previously sent you an email about IE9 compatibility where the
> >> > problem
> >> > we were having was solved by omitting console logging when a console
> >>was
> >> > unavailable (i.e. IE). However, it is looking like IE9 may have a
> >>bigger
> >> > issue with regards to the plugin framework.
> >> > 
> >> > Now that we have gotten dialogs to open via dynamically inserted
> >>buttons
> >> > within RHEV tabs (for example, a NetApp button in the Storage tab),
> >>we can
> >> > go through our whole process with the exception of closing the
> >>window. In
> >> > all other browsers, our dialog will close as expected, but in IE the
> >>window
> >> > remains open. It can be closed by hitting the red "x" in the corner,
> >>but it
> >> > appears the code in the frame itself cannot close the window, with a
> >> > console
> >> > message in the dev tools of IE9 showing an error of "'Math' is
> >>undefined".
> >> > I've read up on this, and it seems like this is a very widespread
> >>error in
> >> > Internet Explorer concerning the manner/order in which iframes are
> >> > dynamically inserted.
> >> > 
> >> > I've copied engine-devel in case anyone has similar issues/solutions,
> >>but
> >> > it
> >> > seems as though we need some sort of clause in the plugin framework
> >>for IE
> >> > when it comes to dynamic insertion of new windows.
> >> > 
> >> > - Ricky Hopper
> >> > 
> >> _______________________________________________
> >> Engine-devel mailing list
> >> Engine-devel at ovirt.org
> >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> >> 
> 
> 


From ecohen at redhat.com  Fri Jun 28 16:01:16 2013
From: ecohen at redhat.com (Einav Cohen)
Date: Fri, 28 Jun 2013 12:01:16 -0400 (EDT)
Subject: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
In-Reply-To: <856039866.2941458.1372398071424.JavaMail.root@redhat.com>
References: <501973842.20255318.1371648804880.JavaMail.root@redhat.com>
	<6609F396-8D78-46FB-9F2D-3700D769B5E9@redhat.com>
	<20130624094735.GC1849@teriyaki.cdg.redhat.com>
	<1210717020.2488959.1372324871664.JavaMail.root@redhat.com>
	<20130627093010.GC13576@teriyaki.redhat.com>
	<2114201154.2496221.1372326631963.JavaMail.root@redhat.com>
	<2874260.9314218.1372348873189.JavaMail.root@redhat.com>
	<856039866.2941458.1372398071424.JavaMail.root@redhat.com>
Message-ID: <1643373626.9902858.1372435276836.JavaMail.root@redhat.com>

Hi Tomas,

> IIUC the RFE addresses only UIPlugins with their metadata so 
> in order to integrate this with the SPICE we nee to either 
> enrich the RFE or to create a UIPlugin which will start the 
> SPICE. I would vote for the second option. What others?

using a ui-plugin that will start SPICE is an interesting approach - it 
haven't crossed my mind. What I had in mind is to somewhat "generalize" the 
RestApiSessionManager to provide REST-API-session-creation services to the 
entire GUI (e.g. SPICE-console-opening-code), and not only to the ui-plugins 
in particular. 
I think that since SPICE is already quite integrated into oVirt (in our business 
logic, dialogs, ...), it would be somewhat weird to use a UI-Plugin in order to 
invoke SPICE, just in order to get the REST-API-session-creation capability.

So I am actually in favor of enriching the RFE (i.e. "generalize" the 
RestApiSessionManager), rather than treating SPICE as a UI-Plugin (in a sense).

> Why only for SPICE? I can imagine UIPlugins which could make use of this
> option.

the main difference between SPICE and the UIPlugins is that we know in advance 
how SPICE is going to use REST API. In addition, SPICE is going to do actions (e.g. 
Stop/Pause/Attach CD) on the VM only when the user chooses to do so (via the 
SPICE menu), so actions will be done on behalf of the logged-in user, so it makes 
sense to provide to SPICE the same credentials as the logged-in user.

a ui-plugin is a third-party component which we don't know in advance how it is 
going to act; moreover, the user that is logging into the web-admin doesn't have 
control on it. Imagine a ui-plugin that shuts-down/deletes all VMs immediately 
upon login to the web-admin - all VMs will be shutdown/deleted upon the first 
login into the web-admin (after the ui-plugin installation on the engine server). 
If the same-credentials-approach will be used, the shutdown/deletion of all VMs 
will be done on behalf of the user that happened to be the first one logging into 
the web-admin (post ui-plugin installation), which, obviously, is not good.

So to sum-up: I think that 

- the RestApiSessionManager should be "generalized" to provide REST-API-session-
creation services to the entire GUI (e.g. SPICE-console-opening-code), and not only 
to the ui-plugins in particular. 

- RestApiSessionManager should support creation of both same-credentials-session as 
well as other-credentials-session; the same-credentials-session should be limited to 
well-known/well-integrated components (e.g. SPICE), whereas the other-credentials-session 
can be used by third-party components as well (e.g. ui-plugins).

[I could be wrong - would love to hear what the others GUI maintainers think]


> ----- Original Message -----
> From: "Tomas Jelinek" <tjelinek at redhat.com>
> Sent: Friday, June 28, 2013 1:41:11 AM
> 
> 
> 
> ----- Original Message -----
> > From: "Einav Cohen" <ecohen at redhat.com>
> > To: "Tomas Jelinek" <tjelinek at redhat.com>, "Vojtech Szocs"
> > <vszocs at redhat.com>
> > Cc: "engine-devel" <engine-devel at ovirt.org>, "Michael Pasternak"
> > <mpastern at redhat.com>
> > Sent: Thursday, June 27, 2013 6:01:13 PM
> > Subject: Re: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
> > 
> > Hi Tomas,
> > 
> > > Yes, we can provide the sessionId to authenticate with the REST and the
> > > vm
> > > guid is not a problem.
> > 
> > Note that in the web-admin, we already have code that generates REST API
> > session-ID;
> > this code is being utilized in the ui-plugins infrastructure to allow the
> > different
> > ui-plugins to communicate with the rest api.
> > [one related file is this context is RestApiSessionManager.java in the
> > web-admin, not
> > sure if there are others]
> 
> Yes, I'm aware of that. This is what I had in mind when was talking about
> passing the SessionId to SPICE.
> 
> > 
> > maybe the RestApiSessionManager(?) can somehow be utilized for the SPICE
> > purpose as well
> > (I guess that it will require a couple of code-changes though, and maybe
> > worth moving it
> > to gwt-common, to allow its utilization from the user portal as well?) -
> > @Vojtech would
> > probably know best to advise on this.
> > 
> > * Note: Today:
> > (a) a *single* REST API session-ID is generated and used across all
> > ui-plugins in the system
> > (upon user login to the web-admin).
> > 
> > (b) this REST-API session-ID is generated based on the *same credentials*
> > with which the user
> > logged into the web-admin.
> > 
> > both (a) and (b) will change once [1] will be addressed.
> 
> Thank you for mentioning this! I was not aware of this RFE. IIUC the RFE
> addresses only
> UIPlugins with their metadata so in order to integrate this with the SPICE we
> nee to either
> enrich the RFE or to create a UIPlugin which will start the SPICE. I would
> vote for the second option.
> What others?
> 
> > Only for the SPICE case in particular - I think that (b) should remain. so
> 
> Why only for SPICE? I can imagine UIPlugins which could make use of this
> option.
> 
> > maybe worth allowing
> > both same-credentials-login and different-credentials-login in the
> > REST-API-Session-ID-generation
> > code in the GUI.
> 
> This option might make sense also for other UIPlugins so maybe the SPICE
> integration will not be anything special, just a UIPlugin.
> 
> > 
> > ----
> > Thanks,
> > Einav
> > 
> > [1] Bug 962863 - RFE: Improve REST API integration for UI Plugins
> > https://bugzilla.redhat.com/show_bug.cgi?id=962863
> > some of the planned changes (from the BZ description):
> > """
> > ...
> > - each UI plugin will have its own dedicated REST API session, unrelated to
> > GUI (admin)
> > user credentials
> > ...
> > """
> > 
> > > ----- Original Message -----
> > > From: "Tomas Jelinek" <tjelinek at redhat.com>
> > > Sent: Thursday, June 27, 2013 5:50:31 AM
> > > 
> > > 
> > > 
> > > ----- Original Message -----
> > > > From: "Christophe Fergeau" <cfergeau at redhat.com>
> > > > To: "Tomas Jelinek" <tjelinek at redhat.com>
> > > > Cc: "Michal Skrivanek" <michal.skrivanek at redhat.com>, "Itamar Heim"
> > > > <iheim at redhat.com>,
> > > > spice-devel at lists.freedesktop.org, "engine-devel"
> > > > <engine-devel at ovirt.org>,
> > > > "Marc-Andr? Lureau" <mlureau at redhat.com>
> > > > Sent: Thursday, June 27, 2013 11:30:10 AM
> > > > Subject: Re: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
> > > > 
> > > > Hey,
> > > > 
> > > > On Thu, Jun 27, 2013 at 05:21:11AM -0400, Tomas Jelinek wrote:
> > > > > well, it seems that everyone agree that the decision what to add to
> > > > > the
> > > > > menu is the client responsibility. It means there is no additional
> > > > > work
> > > > > needed on the
> > > > > oVirt engine side - going to remove the feature page.
> > > > 
> > > > If we go the REST API way to handle foreign menu, we need additional
> > > > info
> > > > in the .vv files: some way to auth with the REST API, and the guid of
> > > > the
> > > > VM to act on.
> > > Yes, we can provide the sessionId to authenticate with the REST and the
> > > vm
> > > guid is not a problem.
> > > 
> > > > 
> > > > Christophe
> > > > 
> > > _______________________________________________
> > > Engine-devel mailing list
> > > Engine-devel at ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > 
> > > 
> > >
> > 
>


From Richard.Hopper at netapp.com  Fri Jun 28 17:24:57 2013
From: Richard.Hopper at netapp.com (Hopper, Richard)
Date: Fri, 28 Jun 2013 17:24:57 +0000
Subject: [Engine-devel] IE9 Issue with UI Plugin
In-Reply-To: <1386820619.3136967.1372432234517.JavaMail.root@redhat.com>
Message-ID: <CDF33F1A.5A0B%rickyh@netapp.com>

Hi Vojtech,

It actually turned out that our particular problem was hidden within our
code, so once we found it, the plugin worked fine with IE9. It was
actually related to the lack of console in the browser as well, I just
didn't realize we called native javascript in multiple places. It seems
that the plugin architecture's compatibility with IE9 is quite solid.

Thank you once again!

- Ricky


On 6/28/13 11:10 AM, "Vojtech Szocs" <vszocs at redhat.com> wrote:

>Hi Ricky,
>
>did you manage to solve the issue related with IE dev tools? If there are
>still issues pointing to UI plugin infrastructure, please let me know.
>
>Regards,
>Vojtech
>
>
>----- Original Message -----
>> From: "Richard Hopper" <Richard.Hopper at netapp.com>
>> To: "Vojtech Szocs" <vszocs at redhat.com>
>> Cc: engine-devel at ovirt.org, "Christopher Morrissey"
>><Christopher.Morrissey at netapp.com>
>> Sent: Wednesday, June 19, 2013 9:39:50 PM
>> Subject: Re: [Engine-devel] IE9 Issue with UI Plugin
>> 
>> Hi Vojtech,
>> 
>> I've tested the new patch and for some reason am still running into
>> problems, though there are different exceptions now. I'll let you know
>>if
>> we figure out what specifically is going on. It does work if dev tools
>>are
>> up, but if there are no developer tools available the window will still
>> not close.
>> 
>> - Ricky
>> 
>> On 6/19/13 9:19 AM, "Vojtech Szocs" <vszocs at redhat.com> wrote:
>> 
>> >Hi Ricky,
>> >
>> >you were right, in IE9, postMessage listener (WebAdmin) didn't work
>> >properly, so I simplified it and verified that it now works in IE9,
>>too:
>> >http://gerrit.ovirt.org/#/c/15888/
>> >
>> >After applying above mentioned patch, everything should work as
>>expected
>> >in IE9. I've also attached "test-plugin" which I used for verification
>>in
>> >IE9.
>> >
>> >Regards,
>> >Vojtech
>> >
>> >
>> >----- Original Message -----
>> >> From: "Vojtech Szocs" <vszocs at redhat.com>
>> >> To: "Richard Hopper" <Richard.Hopper at netapp.com>
>> >> Cc: engine-devel at ovirt.org, "Christopher Morrissey"
>> >><Christopher.Morrissey at netapp.com>
>> >> Sent: Wednesday, June 19, 2013 11:54:16 AM
>> >> Subject: Re: [Engine-devel] IE9 Issue with UI Plugin
>> >> 
>> >> Hi Ricky,
>> >> 
>> >> code running in the iframe (custom dialog content) can close the
>>dialog
>> >>in
>> >> the following way:
>> >> 
>> >> 1, send message to your plugin to indicate the dialog needs to be
>> >>closed:
>> >> 
>> >>     parent.postMessage('CloseMyDialog', '*');
>> >> 
>> >> 2, your plugin intercepts the message via MessageReceived function
>>and
>> >>closes
>> >> the dialog:
>> >> 
>> >>     MessageReceived: function(data, sourceWindow) {
>> >>         switch (data) {
>> >>             case 'CloseMyDialog':
>> >>                 window.alert('About to close dialog');
>> >>                 api.closeDialog('my-dialog');
>> >>                 break;
>> >>         }
>> >>     }
>> >> 
>> >> If the above doesn't work for you, it could mean that:
>> >> - MessageReceived function isn't invoked - make sure to have [*]
>>before
>> >> api.register() call
>> >> - api.closeDialog() function isn't working - in this case I need to
>>fix
>> >>it
>> >> for IE9
>> >> 
>> >> [*] accept message events from iframe (custom dialog content) origin
>> >> 
>> >>     api.options({
>> >>         allowedMessageOrigins: 'http://nicedomain:8080'
>> >>         /* OR */
>> >>         allowedMessageOrigins: ['http://nicedomain1:123',
>> >>         'https://nicedomain2:345']
>> >>     });
>> >> 
>> >> I'm going to investigate this issue on IE9 myself to see if the above
>> >>code is
>> >> really working there.
>> >> 
>> >> Vojtech
>> >> 
>> >> 
>> >> ----- Original Message -----
>> >> > From: "Richard Hopper" <Richard.Hopper at netapp.com>
>> >> > To: "Vojtech Szocs" <vszocs at redhat.com>
>> >> > Cc: engine-devel at ovirt.org, "Christopher Morrissey"
>> >> > <Christopher.Morrissey at netapp.com>
>> >> > Sent: Monday, June 17, 2013 8:16:03 PM
>> >> > Subject: IE9 Issue with UI Plugin
>> >> > 
>> >> > Hi Vojtech,
>> >> > 
>> >> > I had previously sent you an email about IE9 compatibility where
>>the
>> >> > problem
>> >> > we were having was solved by omitting console logging when a
>>console
>> >>was
>> >> > unavailable (i.e. IE). However, it is looking like IE9 may have a
>> >>bigger
>> >> > issue with regards to the plugin framework.
>> >> > 
>> >> > Now that we have gotten dialogs to open via dynamically inserted
>> >>buttons
>> >> > within RHEV tabs (for example, a NetApp button in the Storage tab),
>> >>we can
>> >> > go through our whole process with the exception of closing the
>> >>window. In
>> >> > all other browsers, our dialog will close as expected, but in IE
>>the
>> >>window
>> >> > remains open. It can be closed by hitting the red "x" in the
>>corner,
>> >>but it
>> >> > appears the code in the frame itself cannot close the window, with
>>a
>> >> > console
>> >> > message in the dev tools of IE9 showing an error of "'Math' is
>> >>undefined".
>> >> > I've read up on this, and it seems like this is a very widespread
>> >>error in
>> >> > Internet Explorer concerning the manner/order in which iframes are
>> >> > dynamically inserted.
>> >> > 
>> >> > I've copied engine-devel in case anyone has similar
>>issues/solutions,
>> >>but
>> >> > it
>> >> > seems as though we need some sort of clause in the plugin framework
>> >>for IE
>> >> > when it comes to dynamic insertion of new windows.
>> >> > 
>> >> > - Ricky Hopper
>> >> > 
>> >> _______________________________________________
>> >> Engine-devel mailing list
>> >> Engine-devel at ovirt.org
>> >> http://lists.ovirt.org/mailman/listinfo/engine-devel
>> >> 
>> 
>> 
>_______________________________________________
>Engine-devel mailing list
>Engine-devel at ovirt.org
>http://lists.ovirt.org/mailman/listinfo/engine-devel



From dougsland at redhat.com  Fri Jun 28 18:55:02 2013
From: dougsland at redhat.com (Douglas Schilling Landgraf)
Date: Fri, 28 Jun 2013 14:55:02 -0400
Subject: [Engine-devel] NPE approving node
In-Reply-To: <51CBFCEB.80609@redhat.com>
References: <51CBFCEB.80609@redhat.com>
Message-ID: <51CDDC06.4000000@redhat.com>

On 06/27/2013 04:50 AM, Juan Hernandez wrote:
> Any idea why?

Facing the same issue with updated tree. Cannot approve node.

$ git log -1
commit b5438e34e0b179ef4f8ee20ce6e0d7b25cd2a36a

>
> 2013-06-27 10:37:40,219 INFO
> [org.ovirt.engine.core.bll.ApproveVdsCommand] (pool-6-thread-5)
> [3dd1f412] Running command: ApproveVdsCommand internal: false. Entities
> affected :  ID: 0be6cd89-c5f5-4a4e-b498-504bb2c23eb2 Type: VDS
> 2013-06-27 10:37:40,239 INFO
> [org.ovirt.engine.core.bll.InstallVdsCommand] (pool-6-thread-5)
> [3dd1f412] Before Installation host
> 0be6cd89-c5f5-4a4e-b498-504bb2c23eb2, h0.example.com
> 2013-06-27 10:37:40,294 ERROR
> [org.ovirt.engine.core.bll.InstallVdsCommand] (pool-6-thread-5)
> [3dd1f412] Host installation failed for host
> 0be6cd89-c5f5-4a4e-b498-504bb2c23eb2, h0.example.com.:
> java.lang.NullPointerException
>      at
> org.ovirt.engine.core.utils.ssh.EngineSSHDialog.useDefaultKeyPair(EngineSSHDialog.java:32)
> [utils.jar:]
>      at
> org.ovirt.engine.core.bll.VdsDeploy.useDefaultKeyPair(VdsDeploy.java:804) [bll.jar:]
>
>      at
> org.ovirt.engine.core.bll.InstallVdsCommand.executeCommand(InstallVdsCommand.java:170)
> [bll.jar:]
>      at
> org.ovirt.engine.core.bll.ApproveVdsCommand.executeCommand(ApproveVdsCommand.java:49)
> [bll.jar:]
>      at
> org.ovirt.engine.core.bll.CommandBase.executeWithoutTransaction(CommandBase.java:1065)
> [bll.jar:]
>      at
> org.ovirt.engine.core.bll.CommandBase.executeActionInTransactionScope(CommandBase.java:1150)
> [bll.jar:]
>      at
> org.ovirt.engine.core.bll.CommandBase.runInTransaction(CommandBase.java:1613)
> [bll.jar:]
>      at
> org.ovirt.engine.core.utils.transaction.TransactionSupport.executeInSuppressed(TransactionSupport.java:174)
> [utils.jar:]
>      at
> org.ovirt.engine.core.utils.transaction.TransactionSupport.executeInScope(TransactionSupport.java:116)
> [utils.jar:]
>      at
> org.ovirt.engine.core.bll.CommandBase.execute(CommandBase.java:1168)
> [bll.jar:]
>      at
> org.ovirt.engine.core.bll.CommandBase.executeAction(CommandBase.java:316) [bll.jar:]
>
>      at
> org.ovirt.engine.core.bll.MultipleActionsRunner.executeValidatedCommand(MultipleActionsRunner.java:174)
> [bll.jar:]
>      at
> org.ovirt.engine.core.bll.MultipleActionsRunner.RunCommands(MultipleActionsRunner.java:156)
> [bll.jar:]
>      at
> org.ovirt.engine.core.bll.MultipleActionsRunner$1.run(MultipleActionsRunner.java:94)
> [bll.jar:]
>      at
> org.ovirt.engine.core.utils.threadpool.ThreadPoolUtil$InternalWrapperRunnable.run(ThreadPoolUtil.java:71)
> [utils.jar:]
>      at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> [rt.jar:1.7.0_09-icedtea]
>      at
> java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> [rt.jar:1.7.0_09-icedtea]
>      at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> [rt.jar:1.7.0_09-icedtea]
>      at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> [rt.jar:1.7.0_09-icedtea]
>      at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> [rt.jar:1.7.0_09-icedtea]
>      at java.lang.Thread.run(Thread.java:722) [rt.jar:1.7.0_09-icedtea]
>


-- 
Cheers
Douglas


From alonbl at redhat.com  Fri Jun 28 18:22:58 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Fri, 28 Jun 2013 14:22:58 -0400 (EDT)
Subject: [Engine-devel] NPE approving node
In-Reply-To: <51CDDC06.4000000@redhat.com>
References: <51CBFCEB.80609@redhat.com> <51CDDC06.4000000@redhat.com>
Message-ID: <436174951.13103892.1372443778643.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Douglas Schilling Landgraf" <dougsland at redhat.com>
> To: engine-devel at ovirt.org
> Cc: "Alon Bar-Lev" <alonbl at redhat.com>, "Yaniv Bronheim" <ybronhei at redhat.com>
> Sent: Friday, June 28, 2013 9:55:02 PM
> Subject: Re: [Engine-devel] NPE approving node
> 
> On 06/27/2013 04:50 AM, Juan Hernandez wrote:
> > Any idea why?
> 
> Facing the same issue with updated tree. Cannot approve node.
> 
> $ git log -1
> commit b5438e34e0b179ef4f8ee20ce6e0d7b25cd2a36a

This[1] should have fixed that.

Can you please send the exception?

[1] http://gerrit.ovirt.org/#/c/16184/


From dougsland at redhat.com  Fri Jun 28 19:51:10 2013
From: dougsland at redhat.com (Douglas Schilling Landgraf)
Date: Fri, 28 Jun 2013 15:51:10 -0400
Subject: [Engine-devel] NPE approving node
In-Reply-To: <436174951.13103892.1372443778643.JavaMail.root@redhat.com>
References: <51CBFCEB.80609@redhat.com> <51CDDC06.4000000@redhat.com>
	<436174951.13103892.1372443778643.JavaMail.root@redhat.com>
Message-ID: <51CDE92E.3000006@redhat.com>

On 06/28/2013 02:22 PM, Alon Bar-Lev wrote:
>
>
> ----- Original Message -----
>> From: "Douglas Schilling Landgraf" <dougsland at redhat.com>
>> To: engine-devel at ovirt.org
>> Cc: "Alon Bar-Lev" <alonbl at redhat.com>, "Yaniv Bronheim" <ybronhei at redhat.com>
>> Sent: Friday, June 28, 2013 9:55:02 PM
>> Subject: Re: [Engine-devel] NPE approving node
>>
>> On 06/27/2013 04:50 AM, Juan Hernandez wrote:
>>> Any idea why?
>>
>> Facing the same issue with updated tree. Cannot approve node.
>>
>> $ git log -1
>> commit b5438e34e0b179ef4f8ee20ce6e0d7b25cd2a36a
>
> This[1] should have fixed that.
>
> Can you please send the exception?
>
> [1] http://gerrit.ovirt.org/#/c/16184/
>
I have cleanup/refresh my working tree, looks like it's gone. Thanks!

-- 
Cheers
Douglas


From dougsland at redhat.com  Fri Jun 28 22:40:34 2013
From: dougsland at redhat.com (Douglas Schilling Landgraf)
Date: Fri, 28 Jun 2013 18:40:34 -0400
Subject: [Engine-devel] Jenkins failure - findbugs failed: Timeout: killed
	the sub-process
Message-ID: <51CE10E2.9040904@redhat.com>

Hi,

Anyone else facing the below jenkins failure when sending patches to 
gerrit?

[ERROR] Failed to execute goal 
org.codehaus.mojo:findbugs-maven-plugin:2.5.2:findbugs (default-cli) on 
project jboss-modules-maven-plugin: Execution default-cli of goal 
org.codehaus.mojo:findbugs-maven-plugin:2.5.2:findbugs failed: Timeout: 
killed the sub-process -> [Help 1]

http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/2650/

Thanks!

-- 
Cheers
Douglas


From eedri at redhat.com  Sat Jun 29 15:55:15 2013
From: eedri at redhat.com (Eyal Edri)
Date: Sat, 29 Jun 2013 11:55:15 -0400 (EDT)
Subject: [Engine-devel] Jenkins failure - findbugs failed: Timeout:
 killed	the sub-process
In-Reply-To: <51CE10E2.9040904@redhat.com>
References: <51CE10E2.9040904@redhat.com>
Message-ID: <1621683773.1374972.1372521315816.JavaMail.root@redhat.com>

i tried fixing this with alternating the timeout for mvn commnd:

clean install findbugs:findbugs -P findbugs-general -DskipTests -Dtimeout=1200000

according to http://mojo.codehaus.org/findbugs-maven-plugin/findbugs-mojo.html.

i will try increasing it even more.

----- Original Message -----
> From: "Douglas Schilling Landgraf" <dougsland at redhat.com>
> To: engine-devel at ovirt.org
> Sent: Saturday, June 29, 2013 1:40:34 AM
> Subject: [Engine-devel] Jenkins failure - findbugs failed: Timeout: killed	the sub-process
> 
> Hi,
> 
> Anyone else facing the below jenkins failure when sending patches to
> gerrit?
> 
> [ERROR] Failed to execute goal
> org.codehaus.mojo:findbugs-maven-plugin:2.5.2:findbugs (default-cli) on
> project jboss-modules-maven-plugin: Execution default-cli of goal
> org.codehaus.mojo:findbugs-maven-plugin:2.5.2:findbugs failed: Timeout:
> killed the sub-process -> [Help 1]
> 
> http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/2650/
> 
> Thanks!
> 
> --
> Cheers
> Douglas
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From dougsland at redhat.com  Sun Jun 30 02:41:44 2013
From: dougsland at redhat.com (Douglas Schilling Landgraf)
Date: Sat, 29 Jun 2013 22:41:44 -0400
Subject: [Engine-devel] Introduce mail
In-Reply-To: <CAF1jwZHZKSQawW963NAW1fOA-FxBL8NXfX+Ay=-0OsKFVjOLTw@mail.gmail.com>
References: <CAF1jwZHZKSQawW963NAW1fOA-FxBL8NXfX+Ay=-0OsKFVjOLTw@mail.gmail.com>
Message-ID: <51CF9AE8.6050001@redhat.com>

Oi Fellipe,

On 06/27/2013 05:48 PM, Fellipe Henrique wrote:
> hello folks!
>
> I'm here today, to introduce myself. I want to start to contribute to
> oVirt project, I'm developing most of time in python, and I'll love to
> contribute in python, but can be in C.

Nice, welcome!

>
> I love developing and virtualization, and I think this project have all
> I like.
>
> well, like I said, this is a introduce email, and I'll like suggestion
> how can I help, and show my code to you guys.

Which part of world are you located? :) If you are Brazilian (I am 
guessing based on your last name), are you going to FISL next week?

If yes, we will have a booth there with talks about oVirt, demos and I 
am pretty sure we can talk about development, debugging env (on node 
side), eclipse and so on.

As Alon already shared, there are tasks that you can help.

Fell free to contact me offline list for more details about FISL.

-- 
Cheers
Douglas


From yzaslavs at redhat.com  Sun Jun 30 02:46:20 2013
From: yzaslavs at redhat.com (Yair Zaslavsky)
Date: Sat, 29 Jun 2013 22:46:20 -0400 (EDT)
Subject: [Engine-devel] SSH Soft Fencing
In-Reply-To: <687362379.9364944.1372354295556.JavaMail.root@redhat.com>
References: <1622219224.572748.1372330266360.JavaMail.root@redhat.com>
	<1695008076.4096833.1372337319955.JavaMail.root@redhat.com>
	<12227690.29409642.1372344197624.JavaMail.root@redhat.com>
	<1625820710.4175423.1372344929287.JavaMail.root@redhat.com>
	<687362379.9364944.1372354295556.JavaMail.root@redhat.com>
Message-ID: <1778456392.30662061.1372560380868.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Barak Azulay" <bazulay at redhat.com>
> To: "Martin Perina" <mperina at redhat.com>
> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, engine-devel at ovirt.org, "Eli Mesika" <emesika at redhat.com>
> Sent: Thursday, June 27, 2013 8:31:35 PM
> Subject: Re: SSH Soft Fencing
> 
> 
> 
> ----- Original Message -----
> > From: "Eli Mesika" <emesika at redhat.com>
> > To: "Yair Zaslavsky" <yzaslavs at redhat.com>
> > Cc: "Martin Perina" <mperina at redhat.com>, engine-devel at ovirt.org, "Barak
> > Azulay" <bazulay at redhat.com>
> > Sent: Thursday, June 27, 2013 5:55:29 PM
> > Subject: Re: SSH Soft Fencing
> > 
> > 
> > 
> > ----- Original Message -----
> > > From: "Yair Zaslavsky" <yzaslavs at redhat.com>
> > > To: "Eli Mesika" <emesika at redhat.com>
> > > Cc: "Martin Perina" <mperina at redhat.com>, engine-devel at ovirt.org, "Barak
> > > Azulay" <bazulay at redhat.com>
> > > Sent: Thursday, June 27, 2013 5:43:17 PM
> > > Subject: Re: SSH Soft Fencing
> > > 
> > > 
> > > 
> > > ----- Original Message -----
> > > > From: "Eli Mesika" <emesika at redhat.com>
> > > > To: "Martin Perina" <mperina at redhat.com>
> > > > Cc: engine-devel at ovirt.org, "Yair Zaslavsky" <yzaslavs at redhat.com>,
> > > > "Barak
> > > > Azulay" <bazulay at redhat.com>
> > > > Sent: Thursday, June 27, 2013 3:48:39 PM
> > > > Subject: Re: SSH Soft Fencing
> > > > 
> > > > 
> > > > 
> > > > ----- Original Message -----
> > > > > From: "Martin Perina" <mperina at redhat.com>
> > > > > To: engine-devel at ovirt.org
> > > > > Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Barak Azulay"
> > > > > <bazulay at redhat.com>, "Eli Mesika" <emesika at redhat.com>
> > > > > Sent: Thursday, June 27, 2013 1:51:06 PM
> > > > > Subject: SSH Soft Fencing
> > > > > 
> > > > > Hi,
> > > > > 
> > > > > SSH Soft Fencing is a new feature for 3.3 and it tries to restart
> > > > > VDSM
> > > > > using SSH connection on non responsive hosts prior to real fencing.
> > > > > More info can be found at
> > > > > 
> > > > > http://www.ovirt.org/Automatic_Fencing#Automatic_Fencing_in_oVirt_3.3
> > > > > 
> > > > > In current SSH Soft Fencing implementation the restart VDSM using SSH
> > > > > command is part of standard fencing implementation in
> > > > > VdsNotRespondingTreatmentCommand. But this command is executed only
> > > > > if a host has a valid PM configuration. If host doesn't have a valid
> > > > > PM configuration, the execution of the command is disabled and host
> > > > > state is change to Non Responsive.
> > > > > 
> > > > > So my question are:
> > > > > 
> > > > > 1) Should SSH Soft Fencing be executed on hosts without valid PM
> > > > >    configuration?
> > > > 
> > > > I think that the answer should be yes. The vdsm restart will solve most
> > > > of
> > > > problems , so why not using it whether a PM agent is defined or not.
> > > I agree.
> > > I would like to say that I also don't like the fact that
> > > VdsNotRespondingTreatment extends RestartVdsCommand.
> > > One should ask if "non responding treatment is a restart vds operation"
> > > or
> > > maybe RestartVdsCommand is just a step in the non responding treatment
> > > (inheritance vs containment/delegation).
> > > I think that VdsNotRespodingTreatment should delegate the call to
> > > RestartVdsCommand as the 2nd step after issuing the Soft Fencing command.
> > > Thoughts anyone?
> > 
> > That would be a nice and needed re-factoring
> 
> I would say yes - but would add it only with appropriate configuration
> (enableAutoSoftVdsmRestartWhenNoPMAvailable .... I hate the name)

+1 on configuration.
Configuration must reside at host-related entities (i.e - VdsStatic).

Yair

> 
>  
> 
> > 
> > > 
> > > > 
> > > > > 
> > > > > 2) Should VDSM restart using SSH command be reimplemented
> > > > >    as standalone command to be usable also in other parts of engine?
> > > > >    If 1) is true, I think it will have to be done anyway.
> > > 
> > > I agree here.
> > > > 
> > > > +1
> 
> On one hand it makes sense,  but I have several questions on the above:
> - Who do we think may want to use such a command ?
> - Should (or even can) we limit the use of such command to
> noneResponsiveTreatment ?
> 
> Having general commands available to all code when there is only one specific
> case we are using it might be a bit riskey,
> Especially when we talk about restarting something.
> 
> Thoughts ?
> 
> 
> 
> > > > 
> > > > > 
> > > > > 
> > > > > Martin Perina
> > > > > 
> > > > 
> > > 
> > 
> 


From lpeer at redhat.com  Sun Jun 30 05:06:28 2013
From: lpeer at redhat.com (Livnat Peer)
Date: Sun, 30 Jun 2013 08:06:28 +0300
Subject: [Engine-devel] SSH Soft Fencing
In-Reply-To: <1778456392.30662061.1372560380868.JavaMail.root@redhat.com>
References: <1622219224.572748.1372330266360.JavaMail.root@redhat.com>
	<1695008076.4096833.1372337319955.JavaMail.root@redhat.com>
	<12227690.29409642.1372344197624.JavaMail.root@redhat.com>
	<1625820710.4175423.1372344929287.JavaMail.root@redhat.com>
	<687362379.9364944.1372354295556.JavaMail.root@redhat.com>
	<1778456392.30662061.1372560380868.JavaMail.root@redhat.com>
Message-ID: <51CFBCD4.2020707@redhat.com>

On 06/30/2013 05:46 AM, Yair Zaslavsky wrote:
> 
> 
> ----- Original Message -----
>> From: "Barak Azulay" <bazulay at redhat.com>
>> To: "Martin Perina" <mperina at redhat.com>
>> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, engine-devel at ovirt.org, "Eli Mesika" <emesika at redhat.com>
>> Sent: Thursday, June 27, 2013 8:31:35 PM
>> Subject: Re: SSH Soft Fencing
>>
>>
>>
>> ----- Original Message -----
>>> From: "Eli Mesika" <emesika at redhat.com>
>>> To: "Yair Zaslavsky" <yzaslavs at redhat.com>
>>> Cc: "Martin Perina" <mperina at redhat.com>, engine-devel at ovirt.org, "Barak
>>> Azulay" <bazulay at redhat.com>
>>> Sent: Thursday, June 27, 2013 5:55:29 PM
>>> Subject: Re: SSH Soft Fencing
>>>
>>>
>>>
>>> ----- Original Message -----
>>>> From: "Yair Zaslavsky" <yzaslavs at redhat.com>
>>>> To: "Eli Mesika" <emesika at redhat.com>
>>>> Cc: "Martin Perina" <mperina at redhat.com>, engine-devel at ovirt.org, "Barak
>>>> Azulay" <bazulay at redhat.com>
>>>> Sent: Thursday, June 27, 2013 5:43:17 PM
>>>> Subject: Re: SSH Soft Fencing
>>>>
>>>>
>>>>
>>>> ----- Original Message -----
>>>>> From: "Eli Mesika" <emesika at redhat.com>
>>>>> To: "Martin Perina" <mperina at redhat.com>
>>>>> Cc: engine-devel at ovirt.org, "Yair Zaslavsky" <yzaslavs at redhat.com>,
>>>>> "Barak
>>>>> Azulay" <bazulay at redhat.com>
>>>>> Sent: Thursday, June 27, 2013 3:48:39 PM
>>>>> Subject: Re: SSH Soft Fencing
>>>>>
>>>>>
>>>>>
>>>>> ----- Original Message -----
>>>>>> From: "Martin Perina" <mperina at redhat.com>
>>>>>> To: engine-devel at ovirt.org
>>>>>> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Barak Azulay"
>>>>>> <bazulay at redhat.com>, "Eli Mesika" <emesika at redhat.com>
>>>>>> Sent: Thursday, June 27, 2013 1:51:06 PM
>>>>>> Subject: SSH Soft Fencing
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> SSH Soft Fencing is a new feature for 3.3 and it tries to restart
>>>>>> VDSM
>>>>>> using SSH connection on non responsive hosts prior to real fencing.
>>>>>> More info can be found at
>>>>>>
>>>>>> http://www.ovirt.org/Automatic_Fencing#Automatic_Fencing_in_oVirt_3.3
>>>>>>
>>>>>> In current SSH Soft Fencing implementation the restart VDSM using SSH
>>>>>> command is part of standard fencing implementation in
>>>>>> VdsNotRespondingTreatmentCommand. But this command is executed only
>>>>>> if a host has a valid PM configuration. If host doesn't have a valid
>>>>>> PM configuration, the execution of the command is disabled and host
>>>>>> state is change to Non Responsive.
>>>>>>
>>>>>> So my question are:
>>>>>>
>>>>>> 1) Should SSH Soft Fencing be executed on hosts without valid PM
>>>>>>    configuration?
>>>>>
>>>>> I think that the answer should be yes. The vdsm restart will solve most
>>>>> of
>>>>> problems , so why not using it whether a PM agent is defined or not.
>>>> I agree.
>>>> I would like to say that I also don't like the fact that
>>>> VdsNotRespondingTreatment extends RestartVdsCommand.
>>>> One should ask if "non responding treatment is a restart vds operation"
>>>> or
>>>> maybe RestartVdsCommand is just a step in the non responding treatment
>>>> (inheritance vs containment/delegation).
>>>> I think that VdsNotRespodingTreatment should delegate the call to
>>>> RestartVdsCommand as the 2nd step after issuing the Soft Fencing command.
>>>> Thoughts anyone?
>>>
>>> That would be a nice and needed re-factoring
>>
>> I would say yes - but would add it only with appropriate configuration
>> (enableAutoSoftVdsmRestartWhenNoPMAvailable .... I hate the name)
> 
> +1 on configuration.
> Configuration must reside at host-related entities (i.e - VdsStatic).
> 
> Yair
> 

Why would a user like to avoid fencing VDSM when host becomes
non-responsive?

I think that adding another configuration option is cumbersome with no
real value.

Livnat

>>
>>  
>>
>>>
>>>>
>>>>>
>>>>>>
>>>>>> 2) Should VDSM restart using SSH command be reimplemented
>>>>>>    as standalone command to be usable also in other parts of engine?
>>>>>>    If 1) is true, I think it will have to be done anyway.
>>>>
>>>> I agree here.
>>>>>
>>>>> +1
>>
>> On one hand it makes sense,  but I have several questions on the above:
>> - Who do we think may want to use such a command ?
>> - Should (or even can) we limit the use of such command to
>> noneResponsiveTreatment ?
>>
>> Having general commands available to all code when there is only one specific
>> case we are using it might be a bit riskey,
>> Especially when we talk about restarting something.
>>
>> Thoughts ?
>>
>>
>>
>>>>>
>>>>>>
>>>>>>
>>>>>> Martin Perina
>>>>>>
>>>>>
>>>>
>>>
>>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 



From lpeer at redhat.com  Sun Jun 30 06:16:00 2013
From: lpeer at redhat.com (Livnat Peer)
Date: Sun, 30 Jun 2013 09:16:00 +0300
Subject: [Engine-devel] Introduce mail
In-Reply-To: <CAF1jwZHZKSQawW963NAW1fOA-FxBL8NXfX+Ay=-0OsKFVjOLTw@mail.gmail.com>
References: <CAF1jwZHZKSQawW963NAW1fOA-FxBL8NXfX+Ay=-0OsKFVjOLTw@mail.gmail.com>
Message-ID: <51CFCD20.5020106@redhat.com>

Hi Fellipe,

We'll be happy to use your help, there is always a lot of work to do :)
Is there any specific area in virtualization you would like to focus on?
Network | storage | VMs life-cycle | host life-cycle other?

To start setting your development environment, take a look at -
www.ovirt.org/Vdsm_Developers


Also adding Dan to point any low hanging fruits, or pointers for a
potentially first task :)

Livnat

On 06/28/2013 12:48 AM, Fellipe Henrique wrote:
> hello folks! 
> 
> I'm here today, to introduce myself. I want to start to contribute to
> oVirt project, I'm developing most of time in python, and I'll love to
> contribute in python, but can be in C.
> 
> I love developing and virtualization, and I think this project have all
> I like.
> 
> well, like I said, this is a introduce email, and I'll like suggestion
> how can I help, and show my code to you guys.
> 
> best regards,
> 
> T.?.F.?.A.?.     S+F
> *Fellipe Henrique P. Soares*
> 
> /"Quemadmodum gladius neminem occidit, occidentis telum est."/
> (Epistulae morales ad Lucilium
> <http://en.wikipedia.org/wiki/Epistulae_morales_ad_Lucilium>, Lucius
> Annaeus Seneca)
> 
> /"Any intelligent fool can make things bigger, more complex, and more
> violent. It takes a touch of genius -- and a lot of courage -- to move
> in the opposite direction."/ 
> Albert Einstein (March 14th 1879 ? April 18th 1955)
> 
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 



From emesika at redhat.com  Sun Jun 30 07:02:52 2013
From: emesika at redhat.com (Eli Mesika)
Date: Sun, 30 Jun 2013 03:02:52 -0400 (EDT)
Subject: [Engine-devel] SSH Soft Fencing
In-Reply-To: <51CFBCD4.2020707@redhat.com>
References: <1622219224.572748.1372330266360.JavaMail.root@redhat.com>
	<1695008076.4096833.1372337319955.JavaMail.root@redhat.com>
	<12227690.29409642.1372344197624.JavaMail.root@redhat.com>
	<1625820710.4175423.1372344929287.JavaMail.root@redhat.com>
	<687362379.9364944.1372354295556.JavaMail.root@redhat.com>
	<1778456392.30662061.1372560380868.JavaMail.root@redhat.com>
	<51CFBCD4.2020707@redhat.com>
Message-ID: <1341782742.4935945.1372575772165.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Livnat Peer" <lpeer at redhat.com>
> To: "Yair Zaslavsky" <yzaslavs at redhat.com>
> Cc: engine-devel at ovirt.org
> Sent: Sunday, June 30, 2013 8:06:28 AM
> Subject: Re: [Engine-devel] SSH Soft Fencing
> 
> On 06/30/2013 05:46 AM, Yair Zaslavsky wrote:
> > 
> > 
> > ----- Original Message -----
> >> From: "Barak Azulay" <bazulay at redhat.com>
> >> To: "Martin Perina" <mperina at redhat.com>
> >> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, engine-devel at ovirt.org, "Eli
> >> Mesika" <emesika at redhat.com>
> >> Sent: Thursday, June 27, 2013 8:31:35 PM
> >> Subject: Re: SSH Soft Fencing
> >>
> >>
> >>
> >> ----- Original Message -----
> >>> From: "Eli Mesika" <emesika at redhat.com>
> >>> To: "Yair Zaslavsky" <yzaslavs at redhat.com>
> >>> Cc: "Martin Perina" <mperina at redhat.com>, engine-devel at ovirt.org, "Barak
> >>> Azulay" <bazulay at redhat.com>
> >>> Sent: Thursday, June 27, 2013 5:55:29 PM
> >>> Subject: Re: SSH Soft Fencing
> >>>
> >>>
> >>>
> >>> ----- Original Message -----
> >>>> From: "Yair Zaslavsky" <yzaslavs at redhat.com>
> >>>> To: "Eli Mesika" <emesika at redhat.com>
> >>>> Cc: "Martin Perina" <mperina at redhat.com>, engine-devel at ovirt.org, "Barak
> >>>> Azulay" <bazulay at redhat.com>
> >>>> Sent: Thursday, June 27, 2013 5:43:17 PM
> >>>> Subject: Re: SSH Soft Fencing
> >>>>
> >>>>
> >>>>
> >>>> ----- Original Message -----
> >>>>> From: "Eli Mesika" <emesika at redhat.com>
> >>>>> To: "Martin Perina" <mperina at redhat.com>
> >>>>> Cc: engine-devel at ovirt.org, "Yair Zaslavsky" <yzaslavs at redhat.com>,
> >>>>> "Barak
> >>>>> Azulay" <bazulay at redhat.com>
> >>>>> Sent: Thursday, June 27, 2013 3:48:39 PM
> >>>>> Subject: Re: SSH Soft Fencing
> >>>>>
> >>>>>
> >>>>>
> >>>>> ----- Original Message -----
> >>>>>> From: "Martin Perina" <mperina at redhat.com>
> >>>>>> To: engine-devel at ovirt.org
> >>>>>> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Barak Azulay"
> >>>>>> <bazulay at redhat.com>, "Eli Mesika" <emesika at redhat.com>
> >>>>>> Sent: Thursday, June 27, 2013 1:51:06 PM
> >>>>>> Subject: SSH Soft Fencing
> >>>>>>
> >>>>>> Hi,
> >>>>>>
> >>>>>> SSH Soft Fencing is a new feature for 3.3 and it tries to restart
> >>>>>> VDSM
> >>>>>> using SSH connection on non responsive hosts prior to real fencing.
> >>>>>> More info can be found at
> >>>>>>
> >>>>>> http://www.ovirt.org/Automatic_Fencing#Automatic_Fencing_in_oVirt_3.3
> >>>>>>
> >>>>>> In current SSH Soft Fencing implementation the restart VDSM using SSH
> >>>>>> command is part of standard fencing implementation in
> >>>>>> VdsNotRespondingTreatmentCommand. But this command is executed only
> >>>>>> if a host has a valid PM configuration. If host doesn't have a valid
> >>>>>> PM configuration, the execution of the command is disabled and host
> >>>>>> state is change to Non Responsive.
> >>>>>>
> >>>>>> So my question are:
> >>>>>>
> >>>>>> 1) Should SSH Soft Fencing be executed on hosts without valid PM
> >>>>>>    configuration?
> >>>>>
> >>>>> I think that the answer should be yes. The vdsm restart will solve most
> >>>>> of
> >>>>> problems , so why not using it whether a PM agent is defined or not.
> >>>> I agree.
> >>>> I would like to say that I also don't like the fact that
> >>>> VdsNotRespondingTreatment extends RestartVdsCommand.
> >>>> One should ask if "non responding treatment is a restart vds operation"
> >>>> or
> >>>> maybe RestartVdsCommand is just a step in the non responding treatment
> >>>> (inheritance vs containment/delegation).
> >>>> I think that VdsNotRespodingTreatment should delegate the call to
> >>>> RestartVdsCommand as the 2nd step after issuing the Soft Fencing
> >>>> command.
> >>>> Thoughts anyone?
> >>>
> >>> That would be a nice and needed re-factoring
> >>
> >> I would say yes - but would add it only with appropriate configuration
> >> (enableAutoSoftVdsmRestartWhenNoPMAvailable .... I hate the name)
> > 
> > +1 on configuration.
> > Configuration must reside at host-related entities (i.e - VdsStatic).
> > 
> > Yair
> > 
> 
> Why would a user like to avoid fencing VDSM when host becomes
> non-responsive?
> 
> I think that adding another configuration option is cumbersome with no
> real value.

I totally agree with Livnat here , restarting vdsm may resolve problems and is much less brutal that host restart, should be implemented without any configuration IMHO

> 
> Livnat
> 
> >>
> >>  
> >>
> >>>
> >>>>
> >>>>>
> >>>>>>
> >>>>>> 2) Should VDSM restart using SSH command be reimplemented
> >>>>>>    as standalone command to be usable also in other parts of engine?
> >>>>>>    If 1) is true, I think it will have to be done anyway.
> >>>>
> >>>> I agree here.
> >>>>>
> >>>>> +1
> >>
> >> On one hand it makes sense,  but I have several questions on the above:
> >> - Who do we think may want to use such a command ?
> >> - Should (or even can) we limit the use of such command to
> >> noneResponsiveTreatment ?
> >>
> >> Having general commands available to all code when there is only one
> >> specific
> >> case we are using it might be a bit riskey,
> >> Especially when we talk about restarting something.
> >>
> >> Thoughts ?
> >>
> >>
> >>
> >>>>>
> >>>>>>
> >>>>>>
> >>>>>> Martin Perina
> >>>>>>
> >>>>>
> >>>>
> >>>
> >>
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From mpastern at redhat.com  Sun Jun 30 08:03:06 2013
From: mpastern at redhat.com (Michael Pasternak)
Date: Sun, 30 Jun 2013 11:03:06 +0300
Subject: [Engine-devel] development installation issues
Message-ID: <51CFE63A.2050505@redhat.com>


does anyone faced this with new 'development installation'?

[mpastern at lpt21-f ovirt-engine]$ /home/mpastern/Coding/ovirt/ovirt-engine/bin/engine-setup-2
[ ERROR ] Failed to execute stage 'Booting': 5
[ INFO  ] Stage: Initializing
          Setup was run under unprivileged user this will produce development installation do you wish to proceed? (Yes, No) [No]: Yes
[WARNING] engine-setup-2 is a technical preview, and yet to include all functionality that exists in legacy engine-setup. Specifically, engine-setup-2 does not support
upgrade from previous installations.
[mpastern at lpt21-f ovirt-engine]$

-- 

Michael Pasternak
RedHat, ENG-Virtualization R&D


From amureini at redhat.com  Sun Jun 30 08:11:30 2013
From: amureini at redhat.com (Allon Mureinik)
Date: Sun, 30 Jun 2013 04:11:30 -0400 (EDT)
Subject: [Engine-devel] Guid improvements
In-Reply-To: <982201752.1453243.1372579351455.JavaMail.root@redhat.com>
Message-ID: <207761917.1453625.1372579890708.JavaMail.root@redhat.com>

Hi all,

I just merged a couple of improvements to the [N]Guid class [1] to improve it's performance both CPU-wise and memory-wise, based on a set of benchmarks presented by Liran.

What this patchset achieves:
1. Clean up the code, so it's easier to understand and use
2. Eliminate the inflation in the memory foot print caused by the getValue() method
3. Eliminate all the heavy calls to UUID.fromString when creating a new/empty Guid instance as a default value
4. Note that the cleanups proposed in (1) will have minor performance benefits (e.g., eliminating useless conditional statements), but I doubt this would be anything to write home about.

>From a developer's perspective, here's what changed:
1. No more NGuid, just Guid. Both static methods to create a Guid from String still exist, and are named createGuidFromString and createGuidFromStringDefaultEmpty.
2. [N]Guid.getValue() was removed, it's no longer needed after (1) was implemented
3. The Guid() constructor was made private, as it forced a redundant call to UUID.fromString(String). If you need an empty Guid instance, just use Guid.Empty
4. The Guid.EMPTY_GUID_VALUE string constant was removed, as it was used for redundant calls to UUID.fromString. If you really, REALLY, need it, just call Guid.Empty.getValue() for a UUID or Guid.Empty.toString() for a String.
5. All sorts of ways to transform Strings to Guids were removed. If you have a literal you trust, just use new Guid(String). If you suspect it may be null, use Guid.createGuidFromString[DefaultEmpty]
6. NewGuid is now called newGuid. We're in Java, not C# :-)


Many thanks to everyone who reviewed this patchset.
You guys rock!


Regards,
Allon


[1] http://gerrit.ovirt.org/#/q/project:ovirt-engine+branch:master+topic:guid-cleanup,n,z


From yzaslavs at redhat.com  Sun Jun 30 08:13:56 2013
From: yzaslavs at redhat.com (Yair Zaslavsky)
Date: Sun, 30 Jun 2013 04:13:56 -0400 (EDT)
Subject: [Engine-devel] Guid improvements
In-Reply-To: <207761917.1453625.1372579890708.JavaMail.root@redhat.com>
References: <207761917.1453625.1372579890708.JavaMail.root@redhat.com>
Message-ID: <1510804261.30673992.1372580036122.JavaMail.root@redhat.com>

Well done, should have been done ages ago :)
Now, for the painful rebase of async_task_mgr changes :)


----- Original Message -----
> From: "Allon Mureinik" <amureini at redhat.com>
> To: "engine-devel" <engine-devel at ovirt.org>, "Barak Azulay" <bazulay at redhat.com>
> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Michael Pasternak" <mpastern at redhat.com>, "Tal Nisan"
> <tnisan at redhat.com>, "Ayal Baron" <abaron at redhat.com>
> Sent: Sunday, June 30, 2013 11:11:30 AM
> Subject: Guid improvements
> 
> Hi all,
> 
> I just merged a couple of improvements to the [N]Guid class [1] to improve
> it's performance both CPU-wise and memory-wise, based on a set of benchmarks
> presented by Liran.
> 
> What this patchset achieves:
> 1. Clean up the code, so it's easier to understand and use
> 2. Eliminate the inflation in the memory foot print caused by the getValue()
> method
> 3. Eliminate all the heavy calls to UUID.fromString when creating a new/empty
> Guid instance as a default value
> 4. Note that the cleanups proposed in (1) will have minor performance
> benefits (e.g., eliminating useless conditional statements), but I doubt
> this would be anything to write home about.
> 
> From a developer's perspective, here's what changed:
> 1. No more NGuid, just Guid. Both static methods to create a Guid from String
> still exist, and are named createGuidFromString and
> createGuidFromStringDefaultEmpty.
> 2. [N]Guid.getValue() was removed, it's no longer needed after (1) was
> implemented
> 3. The Guid() constructor was made private, as it forced a redundant call to
> UUID.fromString(String). If you need an empty Guid instance, just use
> Guid.Empty
> 4. The Guid.EMPTY_GUID_VALUE string constant was removed, as it was used for
> redundant calls to UUID.fromString. If you really, REALLY, need it, just
> call Guid.Empty.getValue() for a UUID or Guid.Empty.toString() for a String.
> 5. All sorts of ways to transform Strings to Guids were removed. If you have
> a literal you trust, just use new Guid(String). If you suspect it may be
> null, use Guid.createGuidFromString[DefaultEmpty]
> 6. NewGuid is now called newGuid. We're in Java, not C# :-)
> 
> 
> Many thanks to everyone who reviewed this patchset.
> You guys rock!
> 
> 
> Regards,
> Allon
> 
> 
> [1]
> http://gerrit.ovirt.org/#/q/project:ovirt-engine+branch:master+topic:guid-cleanup,n,z
> 


From danken at redhat.com  Sun Jun 30 08:15:54 2013
From: danken at redhat.com (Dan Kenigsberg)
Date: Sun, 30 Jun 2013 11:15:54 +0300
Subject: [Engine-devel] Introduce mail
In-Reply-To: <51CFCD20.5020106@redhat.com>
References: <CAF1jwZHZKSQawW963NAW1fOA-FxBL8NXfX+Ay=-0OsKFVjOLTw@mail.gmail.com>
	<51CFCD20.5020106@redhat.com>
Message-ID: <20130630081554.GL11361@redhat.com>

On Sun, Jun 30, 2013 at 09:16:00AM +0300, Livnat Peer wrote:
> Hi Fellipe,
> 
> We'll be happy to use your help, there is always a lot of work to do :)
> Is there any specific area in virtualization you would like to focus on?
> Network | storage | VMs life-cycle | host life-cycle other?
> 
> To start setting your development environment, take a look at -
> www.ovirt.org/Vdsm_Developers
> 
> 
> Also adding Dan to point any low hanging fruits, or pointers for a
> potentially first task :)

I see that we currently only have 4 EasyFix bugs
https://bugzilla.redhat.com/buglist.cgi?bug_status=NEW&component=vdsm&f0=OP&f1=OP&f3=CP&f4=CP&j1=OR&keywords=EasyFix%2C%20&keywords_type=allwords&list_id=1490222&o2=notsubstring&query_format=advanced&v2=rhel-6.2.0

I would very much like to get help testing vdsm on Fedora 19 and fixing
issues that might arrise there. E.g. my http://gerrit.ovirt.org/16059

I find running the tests (unit+functional) and extending them, as a good
starting poing.

Dan.


From liran.zelkha at gmail.com  Sun Jun 30 08:37:26 2013
From: liran.zelkha at gmail.com (Liran Zelkha)
Date: Sun, 30 Jun 2013 11:37:26 +0300
Subject: [Engine-devel] Guid improvements
In-Reply-To: <1510804261.30673992.1372580036122.JavaMail.root@redhat.com>
References: <207761917.1453625.1372579890708.JavaMail.root@redhat.com>
	<1510804261.30673992.1372580036122.JavaMail.root@redhat.com>
Message-ID: <64DD4754-E88A-4FF2-94BA-3B1F2B2D2BA5@gmail.com>

Great news.
Allon - please note that GUID is being recreated from String by both DB calls and by data received from VDSM. It is VERY useful to cache Guid String-->Guid, and not just Empty GUID. 

However, as the Guid class runs in GWT as well, you can't use Infinispan and you're limited in the HashMap implementations you can use. Personally, I don't think it's a memory leak, as GUID number in the system are finite and not too large. What do you think? Want to add it to your patch?

On Jun 30, 2013, at 11:13 AM, Yair Zaslavsky wrote:

> Well done, should have been done ages ago :)
> Now, for the painful rebase of async_task_mgr changes :)
> 
> 
> ----- Original Message -----
>> From: "Allon Mureinik" <amureini at redhat.com>
>> To: "engine-devel" <engine-devel at ovirt.org>, "Barak Azulay" <bazulay at redhat.com>
>> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Michael Pasternak" <mpastern at redhat.com>, "Tal Nisan"
>> <tnisan at redhat.com>, "Ayal Baron" <abaron at redhat.com>
>> Sent: Sunday, June 30, 2013 11:11:30 AM
>> Subject: Guid improvements
>> 
>> Hi all,
>> 
>> I just merged a couple of improvements to the [N]Guid class [1] to improve
>> it's performance both CPU-wise and memory-wise, based on a set of benchmarks
>> presented by Liran.
>> 
>> What this patchset achieves:
>> 1. Clean up the code, so it's easier to understand and use
>> 2. Eliminate the inflation in the memory foot print caused by the getValue()
>> method
>> 3. Eliminate all the heavy calls to UUID.fromString when creating a new/empty
>> Guid instance as a default value
>> 4. Note that the cleanups proposed in (1) will have minor performance
>> benefits (e.g., eliminating useless conditional statements), but I doubt
>> this would be anything to write home about.
>> 
>> From a developer's perspective, here's what changed:
>> 1. No more NGuid, just Guid. Both static methods to create a Guid from String
>> still exist, and are named createGuidFromString and
>> createGuidFromStringDefaultEmpty.
>> 2. [N]Guid.getValue() was removed, it's no longer needed after (1) was
>> implemented
>> 3. The Guid() constructor was made private, as it forced a redundant call to
>> UUID.fromString(String). If you need an empty Guid instance, just use
>> Guid.Empty
>> 4. The Guid.EMPTY_GUID_VALUE string constant was removed, as it was used for
>> redundant calls to UUID.fromString. If you really, REALLY, need it, just
>> call Guid.Empty.getValue() for a UUID or Guid.Empty.toString() for a String.
>> 5. All sorts of ways to transform Strings to Guids were removed. If you have
>> a literal you trust, just use new Guid(String). If you suspect it may be
>> null, use Guid.createGuidFromString[DefaultEmpty]
>> 6. NewGuid is now called newGuid. We're in Java, not C# :-)
>> 
>> 
>> Many thanks to everyone who reviewed this patchset.
>> You guys rock!
>> 
>> 
>> Regards,
>> Allon
>> 
>> 
>> [1]
>> http://gerrit.ovirt.org/#/q/project:ovirt-engine+branch:master+topic:guid-cleanup,n,z
>> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel



From masayag at redhat.com  Sun Jun 30 08:43:38 2013
From: masayag at redhat.com (Moti Asayag)
Date: Sun, 30 Jun 2013 11:43:38 +0300
Subject: [Engine-devel] development installation issues
In-Reply-To: <51CFE63A.2050505@redhat.com>
References: <51CFE63A.2050505@redhat.com>
Message-ID: <51CFEFBA.3000909@redhat.com>

On 06/30/2013 11:03 AM, Michael Pasternak wrote:
> 
> does anyone faced this with new 'development installation'?
> 
> [mpastern at lpt21-f ovirt-engine]$ /home/mpastern/Coding/ovirt/ovirt-engine/bin/engine-setup-2
> [ ERROR ] Failed to execute stage 'Booting': 5
> [ INFO  ] Stage: Initializing
>           Setup was run under unprivileged user this will produce development installation do you wish to proceed? (Yes, No) [No]: Yes
> [WARNING] engine-setup-2 is a technical preview, and yet to include all functionality that exists in legacy engine-setup. Specifically, engine-setup-2 does not support
> upgrade from previous installations.
> [mpastern at lpt21-f ovirt-engine]$
> 

I had the same problem which was solved by upgrading to the latest otopi
package.


From mpastern at redhat.com  Sun Jun 30 08:52:41 2013
From: mpastern at redhat.com (Michael Pasternak)
Date: Sun, 30 Jun 2013 11:52:41 +0300
Subject: [Engine-devel] development installation issues
In-Reply-To: <51CFEFBA.3000909@redhat.com>
References: <51CFE63A.2050505@redhat.com> <51CFEFBA.3000909@redhat.com>
Message-ID: <51CFF1D9.6090905@redhat.com>

On 06/30/2013 11:43 AM, Moti Asayag wrote:
> On 06/30/2013 11:03 AM, Michael Pasternak wrote:
>>
>> does anyone faced this with new 'development installation'?
>>
>> [mpastern at lpt21-f ovirt-engine]$ /home/mpastern/Coding/ovirt/ovirt-engine/bin/engine-setup-2
>> [ ERROR ] Failed to execute stage 'Booting': 5
>> [ INFO  ] Stage: Initializing
>>           Setup was run under unprivileged user this will produce development installation do you wish to proceed? (Yes, No) [No]: Yes
>> [WARNING] engine-setup-2 is a technical preview, and yet to include all functionality that exists in legacy engine-setup. Specifically, engine-setup-2 does not support
>> upgrade from previous installations.
>> [mpastern at lpt21-f ovirt-engine]$
>>
> 
> I had the same problem which was solved by upgrading to the latest otopi
> package.
> 

thanks moti,

i'm on latest otopi (1b29c7f06a0b9b6715bd8340396c35ac29bf086c).

-- 

Michael Pasternak
RedHat, ENG-Virtualization R&D


From masayag at redhat.com  Sun Jun 30 09:02:27 2013
From: masayag at redhat.com (Moti Asayag)
Date: Sun, 30 Jun 2013 12:02:27 +0300
Subject: [Engine-devel] development installation issues
In-Reply-To: <51CFF1D9.6090905@redhat.com>
References: <51CFE63A.2050505@redhat.com> <51CFEFBA.3000909@redhat.com>
	<51CFF1D9.6090905@redhat.com>
Message-ID: <51CFF423.1090106@redhat.com>

On 06/30/2013 11:52 AM, Michael Pasternak wrote:
> On 06/30/2013 11:43 AM, Moti Asayag wrote:
>> On 06/30/2013 11:03 AM, Michael Pasternak wrote:
>>>
>>> does anyone faced this with new 'development installation'?
>>>
>>> [mpastern at lpt21-f ovirt-engine]$ /home/mpastern/Coding/ovirt/ovirt-engine/bin/engine-setup-2
>>> [ ERROR ] Failed to execute stage 'Booting': 5
>>> [ INFO  ] Stage: Initializing
>>>           Setup was run under unprivileged user this will produce development installation do you wish to proceed? (Yes, No) [No]: Yes
>>> [WARNING] engine-setup-2 is a technical preview, and yet to include all functionality that exists in legacy engine-setup. Specifically, engine-setup-2 does not support
>>> upgrade from previous installations.
>>> [mpastern at lpt21-f ovirt-engine]$
>>>
>>
>> I had the same problem which was solved by upgrading to the latest otopi
>> package.
>>
> 
> thanks moti,
> 
> i'm on latest otopi (1b29c7f06a0b9b6715bd8340396c35ac29bf086c).
> 

It works fine for me with
otopi-1.1.0-0.0.master.20130626.git33d9561.fc17.noarch, taken from
nightly repo.

See mail from Alon Bar-Lev from last week with subject:
"[Engine-devel] [ATN][Action Required] development environemnt users -
otopi migration"


From mpastern at redhat.com  Sun Jun 30 09:06:32 2013
From: mpastern at redhat.com (Michael Pasternak)
Date: Sun, 30 Jun 2013 12:06:32 +0300
Subject: [Engine-devel] Guid improvements
In-Reply-To: <64DD4754-E88A-4FF2-94BA-3B1F2B2D2BA5@gmail.com>
References: <207761917.1453625.1372579890708.JavaMail.root@redhat.com>
	<1510804261.30673992.1372580036122.JavaMail.root@redhat.com>
	<64DD4754-E88A-4FF2-94BA-3B1F2B2D2BA5@gmail.com>
Message-ID: <51CFF518.3090305@redhat.com>

On 06/30/2013 11:37 AM, Liran Zelkha wrote:
> Great news.
> Allon - please note that GUID is being recreated from String by both DB calls and by data received from VDSM. It is VERY useful to cache Guid String-->Guid, and not just Empty GUID. 
> 
> However, as the Guid class runs in GWT as well, you can't use Infinispan and you're limited in the HashMap implementations you can use. 
> Personally, I don't think it's a memory leak, as GUID number in the system are finite and not too large.

it's large, it's 128-bit random number, it's not about memory leaking, but cpu cost,
as you'll face a lot of rehash'ings in the map,

i'm not even sure that using indexing in the map can help, worth checking.

What do you think? Want to add it to your patch?


> 
> On Jun 30, 2013, at 11:13 AM, Yair Zaslavsky wrote:
> 
>> Well done, should have been done ages ago :)
>> Now, for the painful rebase of async_task_mgr changes :)
>>
>>
>> ----- Original Message -----
>>> From: "Allon Mureinik" <amureini at redhat.com>
>>> To: "engine-devel" <engine-devel at ovirt.org>, "Barak Azulay" <bazulay at redhat.com>
>>> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Michael Pasternak" <mpastern at redhat.com>, "Tal Nisan"
>>> <tnisan at redhat.com>, "Ayal Baron" <abaron at redhat.com>
>>> Sent: Sunday, June 30, 2013 11:11:30 AM
>>> Subject: Guid improvements
>>>
>>> Hi all,
>>>
>>> I just merged a couple of improvements to the [N]Guid class [1] to improve
>>> it's performance both CPU-wise and memory-wise, based on a set of benchmarks
>>> presented by Liran.
>>>
>>> What this patchset achieves:
>>> 1. Clean up the code, so it's easier to understand and use
>>> 2. Eliminate the inflation in the memory foot print caused by the getValue()
>>> method
>>> 3. Eliminate all the heavy calls to UUID.fromString when creating a new/empty
>>> Guid instance as a default value
>>> 4. Note that the cleanups proposed in (1) will have minor performance
>>> benefits (e.g., eliminating useless conditional statements), but I doubt
>>> this would be anything to write home about.
>>>
>>> From a developer's perspective, here's what changed:
>>> 1. No more NGuid, just Guid. Both static methods to create a Guid from String
>>> still exist, and are named createGuidFromString and
>>> createGuidFromStringDefaultEmpty.
>>> 2. [N]Guid.getValue() was removed, it's no longer needed after (1) was
>>> implemented
>>> 3. The Guid() constructor was made private, as it forced a redundant call to
>>> UUID.fromString(String). If you need an empty Guid instance, just use
>>> Guid.Empty
>>> 4. The Guid.EMPTY_GUID_VALUE string constant was removed, as it was used for
>>> redundant calls to UUID.fromString. If you really, REALLY, need it, just
>>> call Guid.Empty.getValue() for a UUID or Guid.Empty.toString() for a String.
>>> 5. All sorts of ways to transform Strings to Guids were removed. If you have
>>> a literal you trust, just use new Guid(String). If you suspect it may be
>>> null, use Guid.createGuidFromString[DefaultEmpty]
>>> 6. NewGuid is now called newGuid. We're in Java, not C# :-)
>>>
>>>
>>> Many thanks to everyone who reviewed this patchset.
>>> You guys rock!
>>>
>>>
>>> Regards,
>>> Allon
>>>
>>>
>>> [1]
>>> http://gerrit.ovirt.org/#/q/project:ovirt-engine+branch:master+topic:guid-cleanup,n,z
>>>
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


-- 

Michael Pasternak
RedHat, ENG-Virtualization R&D


From liran.zelkha at gmail.com  Sun Jun 30 09:20:34 2013
From: liran.zelkha at gmail.com (Liran Zelkha)
Date: Sun, 30 Jun 2013 12:20:34 +0300
Subject: [Engine-devel] Guid improvements
In-Reply-To: <51CFF518.3090305@redhat.com>
References: <207761917.1453625.1372579890708.JavaMail.root@redhat.com>
	<1510804261.30673992.1372580036122.JavaMail.root@redhat.com>
	<64DD4754-E88A-4FF2-94BA-3B1F2B2D2BA5@gmail.com>
	<51CFF518.3090305@redhat.com>
Message-ID: <FD2655AD-49C7-4659-9300-DF83F8091790@gmail.com>

I checked such a solution using JProfiler. Creating the GUID object takes much more CPU cycles that checking the string in the Map.

On Jun 30, 2013, at 12:06 PM, Michael Pasternak wrote:

> On 06/30/2013 11:37 AM, Liran Zelkha wrote:
>> Great news.
>> Allon - please note that GUID is being recreated from String by both DB calls and by data received from VDSM. It is VERY useful to cache Guid String-->Guid, and not just Empty GUID. 
>> 
>> However, as the Guid class runs in GWT as well, you can't use Infinispan and you're limited in the HashMap implementations you can use. 
>> Personally, I don't think it's a memory leak, as GUID number in the system are finite and not too large.
> 
> it's large, it's 128-bit random number, it's not about memory leaking, but cpu cost,
> as you'll face a lot of rehash'ings in the map,
> 
> i'm not even sure that using indexing in the map can help, worth checking.
> 
> What do you think? Want to add it to your patch?
> 
> 
>> 
>> On Jun 30, 2013, at 11:13 AM, Yair Zaslavsky wrote:
>> 
>>> Well done, should have been done ages ago :)
>>> Now, for the painful rebase of async_task_mgr changes :)
>>> 
>>> 
>>> ----- Original Message -----
>>>> From: "Allon Mureinik" <amureini at redhat.com>
>>>> To: "engine-devel" <engine-devel at ovirt.org>, "Barak Azulay" <bazulay at redhat.com>
>>>> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Michael Pasternak" <mpastern at redhat.com>, "Tal Nisan"
>>>> <tnisan at redhat.com>, "Ayal Baron" <abaron at redhat.com>
>>>> Sent: Sunday, June 30, 2013 11:11:30 AM
>>>> Subject: Guid improvements
>>>> 
>>>> Hi all,
>>>> 
>>>> I just merged a couple of improvements to the [N]Guid class [1] to improve
>>>> it's performance both CPU-wise and memory-wise, based on a set of benchmarks
>>>> presented by Liran.
>>>> 
>>>> What this patchset achieves:
>>>> 1. Clean up the code, so it's easier to understand and use
>>>> 2. Eliminate the inflation in the memory foot print caused by the getValue()
>>>> method
>>>> 3. Eliminate all the heavy calls to UUID.fromString when creating a new/empty
>>>> Guid instance as a default value
>>>> 4. Note that the cleanups proposed in (1) will have minor performance
>>>> benefits (e.g., eliminating useless conditional statements), but I doubt
>>>> this would be anything to write home about.
>>>> 
>>>> From a developer's perspective, here's what changed:
>>>> 1. No more NGuid, just Guid. Both static methods to create a Guid from String
>>>> still exist, and are named createGuidFromString and
>>>> createGuidFromStringDefaultEmpty.
>>>> 2. [N]Guid.getValue() was removed, it's no longer needed after (1) was
>>>> implemented
>>>> 3. The Guid() constructor was made private, as it forced a redundant call to
>>>> UUID.fromString(String). If you need an empty Guid instance, just use
>>>> Guid.Empty
>>>> 4. The Guid.EMPTY_GUID_VALUE string constant was removed, as it was used for
>>>> redundant calls to UUID.fromString. If you really, REALLY, need it, just
>>>> call Guid.Empty.getValue() for a UUID or Guid.Empty.toString() for a String.
>>>> 5. All sorts of ways to transform Strings to Guids were removed. If you have
>>>> a literal you trust, just use new Guid(String). If you suspect it may be
>>>> null, use Guid.createGuidFromString[DefaultEmpty]
>>>> 6. NewGuid is now called newGuid. We're in Java, not C# :-)
>>>> 
>>>> 
>>>> Many thanks to everyone who reviewed this patchset.
>>>> You guys rock!
>>>> 
>>>> 
>>>> Regards,
>>>> Allon
>>>> 
>>>> 
>>>> [1]
>>>> http://gerrit.ovirt.org/#/q/project:ovirt-engine+branch:master+topic:guid-cleanup,n,z
>>>> 
>>> _______________________________________________
>>> Engine-devel mailing list
>>> Engine-devel at ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>> 
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>> 
> 
> 
> -- 
> 
> Michael Pasternak
> RedHat, ENG-Virtualization R&D



From mpastern at redhat.com  Sun Jun 30 09:44:26 2013
From: mpastern at redhat.com (Michael Pasternak)
Date: Sun, 30 Jun 2013 12:44:26 +0300
Subject: [Engine-devel] Guid improvements
In-Reply-To: <FD2655AD-49C7-4659-9300-DF83F8091790@gmail.com>
References: <207761917.1453625.1372579890708.JavaMail.root@redhat.com>
	<1510804261.30673992.1372580036122.JavaMail.root@redhat.com>
	<64DD4754-E88A-4FF2-94BA-3B1F2B2D2BA5@gmail.com>
	<51CFF518.3090305@redhat.com>
	<FD2655AD-49C7-4659-9300-DF83F8091790@gmail.com>
Message-ID: <51CFFDFA.9020504@redhat.com>

On 06/30/2013 12:20 PM, Liran Zelkha wrote:
> I checked such a solution using JProfiler. Creating the GUID object takes much more CPU cycles that checking the string in the Map.

of course it is, but what is the size of map that you checked?, check on worst scenario, i.e map
is full of all possible guids,

also problem a bit different,java map has a load factor (which is usually 0.75),
when ratio increases beyond the load factor, occurs proses called re-hash so that the hash
table will double amount of buckets. what can produce a cpu spikes (though it should not happen too often),
to avoid this the initial capacity should be greater than the maximum number of entries / the
load factor, and this is a huge map....

so basically this is a tradeoff between time and space costs against the new guid generation.

> 
> On Jun 30, 2013, at 12:06 PM, Michael Pasternak wrote:
> 
>> On 06/30/2013 11:37 AM, Liran Zelkha wrote:
>>> Great news.
>>> Allon - please note that GUID is being recreated from String by both DB calls and by data received from VDSM. It is VERY useful to cache Guid String-->Guid, and not just Empty GUID. 
>>>
>>> However, as the Guid class runs in GWT as well, you can't use Infinispan and you're limited in the HashMap implementations you can use. 
>>> Personally, I don't think it's a memory leak, as GUID number in the system are finite and not too large.
>>
>> it's large, it's 128-bit random number, it's not about memory leaking, but cpu cost,
>> as you'll face a lot of rehash'ings in the map,
>>
>> i'm not even sure that using indexing in the map can help, worth checking.
>>
>> What do you think? Want to add it to your patch?
>>
>>
>>>
>>> On Jun 30, 2013, at 11:13 AM, Yair Zaslavsky wrote:
>>>
>>>> Well done, should have been done ages ago :)
>>>> Now, for the painful rebase of async_task_mgr changes :)
>>>>
>>>>
>>>> ----- Original Message -----
>>>>> From: "Allon Mureinik" <amureini at redhat.com>
>>>>> To: "engine-devel" <engine-devel at ovirt.org>, "Barak Azulay" <bazulay at redhat.com>
>>>>> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Michael Pasternak" <mpastern at redhat.com>, "Tal Nisan"
>>>>> <tnisan at redhat.com>, "Ayal Baron" <abaron at redhat.com>
>>>>> Sent: Sunday, June 30, 2013 11:11:30 AM
>>>>> Subject: Guid improvements
>>>>>
>>>>> Hi all,
>>>>>
>>>>> I just merged a couple of improvements to the [N]Guid class [1] to improve
>>>>> it's performance both CPU-wise and memory-wise, based on a set of benchmarks
>>>>> presented by Liran.
>>>>>
>>>>> What this patchset achieves:
>>>>> 1. Clean up the code, so it's easier to understand and use
>>>>> 2. Eliminate the inflation in the memory foot print caused by the getValue()
>>>>> method
>>>>> 3. Eliminate all the heavy calls to UUID.fromString when creating a new/empty
>>>>> Guid instance as a default value
>>>>> 4. Note that the cleanups proposed in (1) will have minor performance
>>>>> benefits (e.g., eliminating useless conditional statements), but I doubt
>>>>> this would be anything to write home about.
>>>>>
>>>>> From a developer's perspective, here's what changed:
>>>>> 1. No more NGuid, just Guid. Both static methods to create a Guid from String
>>>>> still exist, and are named createGuidFromString and
>>>>> createGuidFromStringDefaultEmpty.
>>>>> 2. [N]Guid.getValue() was removed, it's no longer needed after (1) was
>>>>> implemented
>>>>> 3. The Guid() constructor was made private, as it forced a redundant call to
>>>>> UUID.fromString(String). If you need an empty Guid instance, just use
>>>>> Guid.Empty
>>>>> 4. The Guid.EMPTY_GUID_VALUE string constant was removed, as it was used for
>>>>> redundant calls to UUID.fromString. If you really, REALLY, need it, just
>>>>> call Guid.Empty.getValue() for a UUID or Guid.Empty.toString() for a String.
>>>>> 5. All sorts of ways to transform Strings to Guids were removed. If you have
>>>>> a literal you trust, just use new Guid(String). If you suspect it may be
>>>>> null, use Guid.createGuidFromString[DefaultEmpty]
>>>>> 6. NewGuid is now called newGuid. We're in Java, not C# :-)
>>>>>
>>>>>
>>>>> Many thanks to everyone who reviewed this patchset.
>>>>> You guys rock!
>>>>>
>>>>>
>>>>> Regards,
>>>>> Allon
>>>>>
>>>>>
>>>>> [1]
>>>>> http://gerrit.ovirt.org/#/q/project:ovirt-engine+branch:master+topic:guid-cleanup,n,z
>>>>>
>>>> _______________________________________________
>>>> Engine-devel mailing list
>>>> Engine-devel at ovirt.org
>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>
>>> _______________________________________________
>>> Engine-devel mailing list
>>> Engine-devel at ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>
>>
>>
>> -- 
>>
>> Michael Pasternak
>> RedHat, ENG-Virtualization R&D
> 


-- 

Michael Pasternak
RedHat, ENG-Virtualization R&D


From liran.zelkha at gmail.com  Sun Jun 30 09:45:41 2013
From: liran.zelkha at gmail.com (Liran Zelkha)
Date: Sun, 30 Jun 2013 12:45:41 +0300
Subject: [Engine-devel] Guid improvements
In-Reply-To: <51CFFDFA.9020504@redhat.com>
References: <207761917.1453625.1372579890708.JavaMail.root@redhat.com>
	<1510804261.30673992.1372580036122.JavaMail.root@redhat.com>
	<64DD4754-E88A-4FF2-94BA-3B1F2B2D2BA5@gmail.com>
	<51CFF518.3090305@redhat.com>
	<FD2655AD-49C7-4659-9300-DF83F8091790@gmail.com>
	<51CFFDFA.9020504@redhat.com>
Message-ID: <CAJ3aYLfn2=_npnzLDTn66PWzfbOWpR43_wTf_Tcu3=S4Gz_cug@mail.gmail.com>

All is true. But average UUID.fromString execution is 1675us, and
HashMap.put is 78us - so the benefit is clear when we're talking on >100K
executions for 10minutes...


On Sun, Jun 30, 2013 at 12:44 PM, Michael Pasternak <mpastern at redhat.com>wrote:

> On 06/30/2013 12:20 PM, Liran Zelkha wrote:
> > I checked such a solution using JProfiler. Creating the GUID object
> takes much more CPU cycles that checking the string in the Map.
>
> of course it is, but what is the size of map that you checked?, check on
> worst scenario, i.e map
> is full of all possible guids,
>
> also problem a bit different,java map has a load factor (which is usually
> 0.75),
> when ratio increases beyond the load factor, occurs proses called re-hash
> so that the hash
> table will double amount of buckets. what can produce a cpu spikes (though
> it should not happen too often),
> to avoid this the initial capacity should be greater than the maximum
> number of entries / the
> load factor, and this is a huge map....
>
> so basically this is a tradeoff between time and space costs against the
> new guid generation.
>
> >
> > On Jun 30, 2013, at 12:06 PM, Michael Pasternak wrote:
> >
> >> On 06/30/2013 11:37 AM, Liran Zelkha wrote:
> >>> Great news.
> >>> Allon - please note that GUID is being recreated from String by both
> DB calls and by data received from VDSM. It is VERY useful to cache Guid
> String-->Guid, and not just Empty GUID.
> >>>
> >>> However, as the Guid class runs in GWT as well, you can't use
> Infinispan and you're limited in the HashMap implementations you can use.
> >>> Personally, I don't think it's a memory leak, as GUID number in the
> system are finite and not too large.
> >>
> >> it's large, it's 128-bit random number, it's not about memory leaking,
> but cpu cost,
> >> as you'll face a lot of rehash'ings in the map,
> >>
> >> i'm not even sure that using indexing in the map can help, worth
> checking.
> >>
> >> What do you think? Want to add it to your patch?
> >>
> >>
> >>>
> >>> On Jun 30, 2013, at 11:13 AM, Yair Zaslavsky wrote:
> >>>
> >>>> Well done, should have been done ages ago :)
> >>>> Now, for the painful rebase of async_task_mgr changes :)
> >>>>
> >>>>
> >>>> ----- Original Message -----
> >>>>> From: "Allon Mureinik" <amureini at redhat.com>
> >>>>> To: "engine-devel" <engine-devel at ovirt.org>, "Barak Azulay" <
> bazulay at redhat.com>
> >>>>> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Michael Pasternak" <
> mpastern at redhat.com>, "Tal Nisan"
> >>>>> <tnisan at redhat.com>, "Ayal Baron" <abaron at redhat.com>
> >>>>> Sent: Sunday, June 30, 2013 11:11:30 AM
> >>>>> Subject: Guid improvements
> >>>>>
> >>>>> Hi all,
> >>>>>
> >>>>> I just merged a couple of improvements to the [N]Guid class [1] to
> improve
> >>>>> it's performance both CPU-wise and memory-wise, based on a set of
> benchmarks
> >>>>> presented by Liran.
> >>>>>
> >>>>> What this patchset achieves:
> >>>>> 1. Clean up the code, so it's easier to understand and use
> >>>>> 2. Eliminate the inflation in the memory foot print caused by the
> getValue()
> >>>>> method
> >>>>> 3. Eliminate all the heavy calls to UUID.fromString when creating a
> new/empty
> >>>>> Guid instance as a default value
> >>>>> 4. Note that the cleanups proposed in (1) will have minor performance
> >>>>> benefits (e.g., eliminating useless conditional statements), but I
> doubt
> >>>>> this would be anything to write home about.
> >>>>>
> >>>>> From a developer's perspective, here's what changed:
> >>>>> 1. No more NGuid, just Guid. Both static methods to create a Guid
> from String
> >>>>> still exist, and are named createGuidFromString and
> >>>>> createGuidFromStringDefaultEmpty.
> >>>>> 2. [N]Guid.getValue() was removed, it's no longer needed after (1)
> was
> >>>>> implemented
> >>>>> 3. The Guid() constructor was made private, as it forced a redundant
> call to
> >>>>> UUID.fromString(String). If you need an empty Guid instance, just use
> >>>>> Guid.Empty
> >>>>> 4. The Guid.EMPTY_GUID_VALUE string constant was removed, as it was
> used for
> >>>>> redundant calls to UUID.fromString. If you really, REALLY, need it,
> just
> >>>>> call Guid.Empty.getValue() for a UUID or Guid.Empty.toString() for a
> String.
> >>>>> 5. All sorts of ways to transform Strings to Guids were removed. If
> you have
> >>>>> a literal you trust, just use new Guid(String). If you suspect it
> may be
> >>>>> null, use Guid.createGuidFromString[DefaultEmpty]
> >>>>> 6. NewGuid is now called newGuid. We're in Java, not C# :-)
> >>>>>
> >>>>>
> >>>>> Many thanks to everyone who reviewed this patchset.
> >>>>> You guys rock!
> >>>>>
> >>>>>
> >>>>> Regards,
> >>>>> Allon
> >>>>>
> >>>>>
> >>>>> [1]
> >>>>>
> http://gerrit.ovirt.org/#/q/project:ovirt-engine+branch:master+topic:guid-cleanup,n,z
> >>>>>
> >>>> _______________________________________________
> >>>> Engine-devel mailing list
> >>>> Engine-devel at ovirt.org
> >>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> >>>
> >>> _______________________________________________
> >>> Engine-devel mailing list
> >>> Engine-devel at ovirt.org
> >>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> >>>
> >>
> >>
> >> --
> >>
> >> Michael Pasternak
> >> RedHat, ENG-Virtualization R&D
> >
>
>
> --
>
> Michael Pasternak
> RedHat, ENG-Virtualization R&D
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130630/e0f5b46d/attachment.html>

From mpastern at redhat.com  Sun Jun 30 10:00:21 2013
From: mpastern at redhat.com (Michael Pasternak)
Date: Sun, 30 Jun 2013 13:00:21 +0300
Subject: [Engine-devel] Guid improvements
In-Reply-To: <CAJ3aYLfn2=_npnzLDTn66PWzfbOWpR43_wTf_Tcu3=S4Gz_cug@mail.gmail.com>
References: <207761917.1453625.1372579890708.JavaMail.root@redhat.com>
	<1510804261.30673992.1372580036122.JavaMail.root@redhat.com>
	<64DD4754-E88A-4FF2-94BA-3B1F2B2D2BA5@gmail.com>
	<51CFF518.3090305@redhat.com>
	<FD2655AD-49C7-4659-9300-DF83F8091790@gmail.com>
	<51CFFDFA.9020504@redhat.com>
	<CAJ3aYLfn2=_npnzLDTn66PWzfbOWpR43_wTf_Tcu3=S4Gz_cug@mail.gmail.com>
Message-ID: <51D001B5.9070601@redhat.com>

On 06/30/2013 12:45 PM, Liran Zelkha wrote:
> All is true. But average UUID.fromString execution is 1675us, and HashMap.put is 78us - so the benefit is clear when we're talking on >100K executions for 10minutes...

even with synchronization? what about ConcurrentHashMap?

> 
> 
> On Sun, Jun 30, 2013 at 12:44 PM, Michael Pasternak <mpastern at redhat.com <mailto:mpastern at redhat.com>> wrote:
> 
>     On 06/30/2013 12:20 PM, Liran Zelkha wrote:
>     > I checked such a solution using JProfiler. Creating the GUID object takes much more CPU cycles that checking the string in the Map.
> 
>     of course it is, but what is the size of map that you checked?, check on worst scenario, i.e map
>     is full of all possible guids,
> 
>     also problem a bit different,java map has a load factor (which is usually 0.75),
>     when ratio increases beyond the load factor, occurs proses called re-hash so that the hash
>     table will double amount of buckets. what can produce a cpu spikes (though it should not happen too often),
>     to avoid this the initial capacity should be greater than the maximum number of entries / the
>     load factor, and this is a huge map....
> 
>     so basically this is a tradeoff between time and space costs against the new guid generation.
> 
>     >
>     > On Jun 30, 2013, at 12:06 PM, Michael Pasternak wrote:
>     >
>     >> On 06/30/2013 11:37 AM, Liran Zelkha wrote:
>     >>> Great news.
>     >>> Allon - please note that GUID is being recreated from String by both DB calls and by data received from VDSM. It is VERY useful to cache Guid String-->Guid, and not
>     just Empty GUID.
>     >>>
>     >>> However, as the Guid class runs in GWT as well, you can't use Infinispan and you're limited in the HashMap implementations you can use.
>     >>> Personally, I don't think it's a memory leak, as GUID number in the system are finite and not too large.
>     >>
>     >> it's large, it's 128-bit random number, it's not about memory leaking, but cpu cost,
>     >> as you'll face a lot of rehash'ings in the map,
>     >>
>     >> i'm not even sure that using indexing in the map can help, worth checking.
>     >>
>     >> What do you think? Want to add it to your patch?
>     >>
>     >>
>     >>>
>     >>> On Jun 30, 2013, at 11:13 AM, Yair Zaslavsky wrote:
>     >>>
>     >>>> Well done, should have been done ages ago :)
>     >>>> Now, for the painful rebase of async_task_mgr changes :)
>     >>>>
>     >>>>
>     >>>> ----- Original Message -----
>     >>>>> From: "Allon Mureinik" <amureini at redhat.com <mailto:amureini at redhat.com>>
>     >>>>> To: "engine-devel" <engine-devel at ovirt.org <mailto:engine-devel at ovirt.org>>, "Barak Azulay" <bazulay at redhat.com <mailto:bazulay at redhat.com>>
>     >>>>> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com <mailto:yzaslavs at redhat.com>>, "Michael Pasternak" <mpastern at redhat.com <mailto:mpastern at redhat.com>>, "Tal Nisan"
>     >>>>> <tnisan at redhat.com <mailto:tnisan at redhat.com>>, "Ayal Baron" <abaron at redhat.com <mailto:abaron at redhat.com>>
>     >>>>> Sent: Sunday, June 30, 2013 11:11:30 AM
>     >>>>> Subject: Guid improvements
>     >>>>>
>     >>>>> Hi all,
>     >>>>>
>     >>>>> I just merged a couple of improvements to the [N]Guid class [1] to improve
>     >>>>> it's performance both CPU-wise and memory-wise, based on a set of benchmarks
>     >>>>> presented by Liran.
>     >>>>>
>     >>>>> What this patchset achieves:
>     >>>>> 1. Clean up the code, so it's easier to understand and use
>     >>>>> 2. Eliminate the inflation in the memory foot print caused by the getValue()
>     >>>>> method
>     >>>>> 3. Eliminate all the heavy calls to UUID.fromString when creating a new/empty
>     >>>>> Guid instance as a default value
>     >>>>> 4. Note that the cleanups proposed in (1) will have minor performance
>     >>>>> benefits (e.g., eliminating useless conditional statements), but I doubt
>     >>>>> this would be anything to write home about.
>     >>>>>
>     >>>>> From a developer's perspective, here's what changed:
>     >>>>> 1. No more NGuid, just Guid. Both static methods to create a Guid from String
>     >>>>> still exist, and are named createGuidFromString and
>     >>>>> createGuidFromStringDefaultEmpty.
>     >>>>> 2. [N]Guid.getValue() was removed, it's no longer needed after (1) was
>     >>>>> implemented
>     >>>>> 3. The Guid() constructor was made private, as it forced a redundant call to
>     >>>>> UUID.fromString(String). If you need an empty Guid instance, just use
>     >>>>> Guid.Empty
>     >>>>> 4. The Guid.EMPTY_GUID_VALUE string constant was removed, as it was used for
>     >>>>> redundant calls to UUID.fromString. If you really, REALLY, need it, just
>     >>>>> call Guid.Empty.getValue() for a UUID or Guid.Empty.toString() for a String.
>     >>>>> 5. All sorts of ways to transform Strings to Guids were removed. If you have
>     >>>>> a literal you trust, just use new Guid(String). If you suspect it may be
>     >>>>> null, use Guid.createGuidFromString[DefaultEmpty]
>     >>>>> 6. NewGuid is now called newGuid. We're in Java, not C# :-)
>     >>>>>
>     >>>>>
>     >>>>> Many thanks to everyone who reviewed this patchset.
>     >>>>> You guys rock!
>     >>>>>
>     >>>>>
>     >>>>> Regards,
>     >>>>> Allon
>     >>>>>
>     >>>>>
>     >>>>> [1]
>     >>>>> http://gerrit.ovirt.org/#/q/project:ovirt-engine+branch:master+topic:guid-cleanup,n,z
>     >>>>>
>     >>>> _______________________________________________
>     >>>> Engine-devel mailing list
>     >>>> Engine-devel at ovirt.org <mailto:Engine-devel at ovirt.org>
>     >>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>     >>>
>     >>> _______________________________________________
>     >>> Engine-devel mailing list
>     >>> Engine-devel at ovirt.org <mailto:Engine-devel at ovirt.org>
>     >>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>     >>>
>     >>
>     >>
>     >> --
>     >>
>     >> Michael Pasternak
>     >> RedHat, ENG-Virtualization R&D
>     >
> 
> 
>     --
> 
>     Michael Pasternak
>     RedHat, ENG-Virtualization R&D
> 
> 


-- 

Michael Pasternak
RedHat, ENG-Virtualization R&D


From liran.zelkha at gmail.com  Sun Jun 30 10:08:20 2013
From: liran.zelkha at gmail.com (Liran Zelkha)
Date: Sun, 30 Jun 2013 13:08:20 +0300
Subject: [Engine-devel] Guid improvements
In-Reply-To: <51D001B5.9070601@redhat.com>
References: <207761917.1453625.1372579890708.JavaMail.root@redhat.com>
	<1510804261.30673992.1372580036122.JavaMail.root@redhat.com>
	<64DD4754-E88A-4FF2-94BA-3B1F2B2D2BA5@gmail.com>
	<51CFF518.3090305@redhat.com>
	<FD2655AD-49C7-4659-9300-DF83F8091790@gmail.com>
	<51CFFDFA.9020504@redhat.com>
	<CAJ3aYLfn2=_npnzLDTn66PWzfbOWpR43_wTf_Tcu3=S4Gz_cug@mail.gmail.com>
	<51D001B5.9070601@redhat.com>
Message-ID: <C473A148-584C-4271-9138-DD3137B96E0A@gmail.com>

Why synchronization? No need for it. Worst case scenario a put (which should be much less common then get) will occur twice on the same key. 

On Jun 30, 2013, at 1:00 PM, Michael Pasternak wrote:

> On 06/30/2013 12:45 PM, Liran Zelkha wrote:
>> All is true. But average UUID.fromString execution is 1675us, and HashMap.put is 78us - so the benefit is clear when we're talking on >100K executions for 10minutes...
> 
> even with synchronization? what about ConcurrentHashMap?
> 
>> 
>> 
>> On Sun, Jun 30, 2013 at 12:44 PM, Michael Pasternak <mpastern at redhat.com <mailto:mpastern at redhat.com>> wrote:
>> 
>>    On 06/30/2013 12:20 PM, Liran Zelkha wrote:
>>> I checked such a solution using JProfiler. Creating the GUID object takes much more CPU cycles that checking the string in the Map.
>> 
>>    of course it is, but what is the size of map that you checked?, check on worst scenario, i.e map
>>    is full of all possible guids,
>> 
>>    also problem a bit different,java map has a load factor (which is usually 0.75),
>>    when ratio increases beyond the load factor, occurs proses called re-hash so that the hash
>>    table will double amount of buckets. what can produce a cpu spikes (though it should not happen too often),
>>    to avoid this the initial capacity should be greater than the maximum number of entries / the
>>    load factor, and this is a huge map....
>> 
>>    so basically this is a tradeoff between time and space costs against the new guid generation.
>> 
>>> 
>>> On Jun 30, 2013, at 12:06 PM, Michael Pasternak wrote:
>>> 
>>>> On 06/30/2013 11:37 AM, Liran Zelkha wrote:
>>>>> Great news.
>>>>> Allon - please note that GUID is being recreated from String by both DB calls and by data received from VDSM. It is VERY useful to cache Guid String-->Guid, and not
>>    just Empty GUID.
>>>>> 
>>>>> However, as the Guid class runs in GWT as well, you can't use Infinispan and you're limited in the HashMap implementations you can use.
>>>>> Personally, I don't think it's a memory leak, as GUID number in the system are finite and not too large.
>>>> 
>>>> it's large, it's 128-bit random number, it's not about memory leaking, but cpu cost,
>>>> as you'll face a lot of rehash'ings in the map,
>>>> 
>>>> i'm not even sure that using indexing in the map can help, worth checking.
>>>> 
>>>> What do you think? Want to add it to your patch?
>>>> 
>>>> 
>>>>> 
>>>>> On Jun 30, 2013, at 11:13 AM, Yair Zaslavsky wrote:
>>>>> 
>>>>>> Well done, should have been done ages ago :)
>>>>>> Now, for the painful rebase of async_task_mgr changes :)
>>>>>> 
>>>>>> 
>>>>>> ----- Original Message -----
>>>>>>> From: "Allon Mureinik" <amureini at redhat.com <mailto:amureini at redhat.com>>
>>>>>>> To: "engine-devel" <engine-devel at ovirt.org <mailto:engine-devel at ovirt.org>>, "Barak Azulay" <bazulay at redhat.com <mailto:bazulay at redhat.com>>
>>>>>>> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com <mailto:yzaslavs at redhat.com>>, "Michael Pasternak" <mpastern at redhat.com <mailto:mpastern at redhat.com>>, "Tal Nisan"
>>>>>>> <tnisan at redhat.com <mailto:tnisan at redhat.com>>, "Ayal Baron" <abaron at redhat.com <mailto:abaron at redhat.com>>
>>>>>>> Sent: Sunday, June 30, 2013 11:11:30 AM
>>>>>>> Subject: Guid improvements
>>>>>>> 
>>>>>>> Hi all,
>>>>>>> 
>>>>>>> I just merged a couple of improvements to the [N]Guid class [1] to improve
>>>>>>> it's performance both CPU-wise and memory-wise, based on a set of benchmarks
>>>>>>> presented by Liran.
>>>>>>> 
>>>>>>> What this patchset achieves:
>>>>>>> 1. Clean up the code, so it's easier to understand and use
>>>>>>> 2. Eliminate the inflation in the memory foot print caused by the getValue()
>>>>>>> method
>>>>>>> 3. Eliminate all the heavy calls to UUID.fromString when creating a new/empty
>>>>>>> Guid instance as a default value
>>>>>>> 4. Note that the cleanups proposed in (1) will have minor performance
>>>>>>> benefits (e.g., eliminating useless conditional statements), but I doubt
>>>>>>> this would be anything to write home about.
>>>>>>> 
>>>>>>> From a developer's perspective, here's what changed:
>>>>>>> 1. No more NGuid, just Guid. Both static methods to create a Guid from String
>>>>>>> still exist, and are named createGuidFromString and
>>>>>>> createGuidFromStringDefaultEmpty.
>>>>>>> 2. [N]Guid.getValue() was removed, it's no longer needed after (1) was
>>>>>>> implemented
>>>>>>> 3. The Guid() constructor was made private, as it forced a redundant call to
>>>>>>> UUID.fromString(String). If you need an empty Guid instance, just use
>>>>>>> Guid.Empty
>>>>>>> 4. The Guid.EMPTY_GUID_VALUE string constant was removed, as it was used for
>>>>>>> redundant calls to UUID.fromString. If you really, REALLY, need it, just
>>>>>>> call Guid.Empty.getValue() for a UUID or Guid.Empty.toString() for a String.
>>>>>>> 5. All sorts of ways to transform Strings to Guids were removed. If you have
>>>>>>> a literal you trust, just use new Guid(String). If you suspect it may be
>>>>>>> null, use Guid.createGuidFromString[DefaultEmpty]
>>>>>>> 6. NewGuid is now called newGuid. We're in Java, not C# :-)
>>>>>>> 
>>>>>>> 
>>>>>>> Many thanks to everyone who reviewed this patchset.
>>>>>>> You guys rock!
>>>>>>> 
>>>>>>> 
>>>>>>> Regards,
>>>>>>> Allon
>>>>>>> 
>>>>>>> 
>>>>>>> [1]
>>>>>>> http://gerrit.ovirt.org/#/q/project:ovirt-engine+branch:master+topic:guid-cleanup,n,z
>>>>>>> 
>>>>>> _______________________________________________
>>>>>> Engine-devel mailing list
>>>>>> Engine-devel at ovirt.org <mailto:Engine-devel at ovirt.org>
>>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>>> 
>>>>> _______________________________________________
>>>>> Engine-devel mailing list
>>>>> Engine-devel at ovirt.org <mailto:Engine-devel at ovirt.org>
>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>>> 
>>>> 
>>>> 
>>>> --
>>>> 
>>>> Michael Pasternak
>>>> RedHat, ENG-Virtualization R&D
>>> 
>> 
>> 
>>    --
>> 
>>    Michael Pasternak
>>    RedHat, ENG-Virtualization R&D
>> 
>> 
> 
> 
> -- 
> 
> Michael Pasternak
> RedHat, ENG-Virtualization R&D



From mpastern at redhat.com  Sun Jun 30 10:15:34 2013
From: mpastern at redhat.com (Michael Pasternak)
Date: Sun, 30 Jun 2013 13:15:34 +0300
Subject: [Engine-devel] Guid improvements
In-Reply-To: <C473A148-584C-4271-9138-DD3137B96E0A@gmail.com>
References: <207761917.1453625.1372579890708.JavaMail.root@redhat.com>
	<1510804261.30673992.1372580036122.JavaMail.root@redhat.com>
	<64DD4754-E88A-4FF2-94BA-3B1F2B2D2BA5@gmail.com>
	<51CFF518.3090305@redhat.com>
	<FD2655AD-49C7-4659-9300-DF83F8091790@gmail.com>
	<51CFFDFA.9020504@redhat.com>
	<CAJ3aYLfn2=_npnzLDTn66PWzfbOWpR43_wTf_Tcu3=S4Gz_cug@mail.gmail.com>
	<51D001B5.9070601@redhat.com>
	<C473A148-584C-4271-9138-DD3137B96E0A@gmail.com>
Message-ID: <51D00546.70307@redhat.com>

On 06/30/2013 01:08 PM, Liran Zelkha wrote:
> Why synchronization? No need for it. Worst case scenario a put (which should be much less common then get) will occur twice on the same key. 

why assuming a best & not worst scenario? don't forget that every new insertion requires collision resolution
which is triggers .equals() on the GUID.

> 
> On Jun 30, 2013, at 1:00 PM, Michael Pasternak wrote:
> 
>> On 06/30/2013 12:45 PM, Liran Zelkha wrote:
>>> All is true. But average UUID.fromString execution is 1675us, and HashMap.put is 78us - so the benefit is clear when we're talking on >100K executions for 10minutes...
>>
>> even with synchronization? what about ConcurrentHashMap?
>>
>>>
>>>
>>> On Sun, Jun 30, 2013 at 12:44 PM, Michael Pasternak <mpastern at redhat.com <mailto:mpastern at redhat.com>> wrote:
>>>
>>>    On 06/30/2013 12:20 PM, Liran Zelkha wrote:
>>>> I checked such a solution using JProfiler. Creating the GUID object takes much more CPU cycles that checking the string in the Map.
>>>
>>>    of course it is, but what is the size of map that you checked?, check on worst scenario, i.e map
>>>    is full of all possible guids,
>>>
>>>    also problem a bit different,java map has a load factor (which is usually 0.75),
>>>    when ratio increases beyond the load factor, occurs proses called re-hash so that the hash
>>>    table will double amount of buckets. what can produce a cpu spikes (though it should not happen too often),
>>>    to avoid this the initial capacity should be greater than the maximum number of entries / the
>>>    load factor, and this is a huge map....
>>>
>>>    so basically this is a tradeoff between time and space costs against the new guid generation.
>>>
>>>>
>>>> On Jun 30, 2013, at 12:06 PM, Michael Pasternak wrote:
>>>>
>>>>> On 06/30/2013 11:37 AM, Liran Zelkha wrote:
>>>>>> Great news.
>>>>>> Allon - please note that GUID is being recreated from String by both DB calls and by data received from VDSM. It is VERY useful to cache Guid String-->Guid, and not
>>>    just Empty GUID.
>>>>>>
>>>>>> However, as the Guid class runs in GWT as well, you can't use Infinispan and you're limited in the HashMap implementations you can use.
>>>>>> Personally, I don't think it's a memory leak, as GUID number in the system are finite and not too large.
>>>>>
>>>>> it's large, it's 128-bit random number, it's not about memory leaking, but cpu cost,
>>>>> as you'll face a lot of rehash'ings in the map,
>>>>>
>>>>> i'm not even sure that using indexing in the map can help, worth checking.
>>>>>
>>>>> What do you think? Want to add it to your patch?
>>>>>
>>>>>
>>>>>>
>>>>>> On Jun 30, 2013, at 11:13 AM, Yair Zaslavsky wrote:
>>>>>>
>>>>>>> Well done, should have been done ages ago :)
>>>>>>> Now, for the painful rebase of async_task_mgr changes :)
>>>>>>>
>>>>>>>
>>>>>>> ----- Original Message -----
>>>>>>>> From: "Allon Mureinik" <amureini at redhat.com <mailto:amureini at redhat.com>>
>>>>>>>> To: "engine-devel" <engine-devel at ovirt.org <mailto:engine-devel at ovirt.org>>, "Barak Azulay" <bazulay at redhat.com <mailto:bazulay at redhat.com>>
>>>>>>>> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com <mailto:yzaslavs at redhat.com>>, "Michael Pasternak" <mpastern at redhat.com <mailto:mpastern at redhat.com>>, "Tal Nisan"
>>>>>>>> <tnisan at redhat.com <mailto:tnisan at redhat.com>>, "Ayal Baron" <abaron at redhat.com <mailto:abaron at redhat.com>>
>>>>>>>> Sent: Sunday, June 30, 2013 11:11:30 AM
>>>>>>>> Subject: Guid improvements
>>>>>>>>
>>>>>>>> Hi all,
>>>>>>>>
>>>>>>>> I just merged a couple of improvements to the [N]Guid class [1] to improve
>>>>>>>> it's performance both CPU-wise and memory-wise, based on a set of benchmarks
>>>>>>>> presented by Liran.
>>>>>>>>
>>>>>>>> What this patchset achieves:
>>>>>>>> 1. Clean up the code, so it's easier to understand and use
>>>>>>>> 2. Eliminate the inflation in the memory foot print caused by the getValue()
>>>>>>>> method
>>>>>>>> 3. Eliminate all the heavy calls to UUID.fromString when creating a new/empty
>>>>>>>> Guid instance as a default value
>>>>>>>> 4. Note that the cleanups proposed in (1) will have minor performance
>>>>>>>> benefits (e.g., eliminating useless conditional statements), but I doubt
>>>>>>>> this would be anything to write home about.
>>>>>>>>
>>>>>>>> From a developer's perspective, here's what changed:
>>>>>>>> 1. No more NGuid, just Guid. Both static methods to create a Guid from String
>>>>>>>> still exist, and are named createGuidFromString and
>>>>>>>> createGuidFromStringDefaultEmpty.
>>>>>>>> 2. [N]Guid.getValue() was removed, it's no longer needed after (1) was
>>>>>>>> implemented
>>>>>>>> 3. The Guid() constructor was made private, as it forced a redundant call to
>>>>>>>> UUID.fromString(String). If you need an empty Guid instance, just use
>>>>>>>> Guid.Empty
>>>>>>>> 4. The Guid.EMPTY_GUID_VALUE string constant was removed, as it was used for
>>>>>>>> redundant calls to UUID.fromString. If you really, REALLY, need it, just
>>>>>>>> call Guid.Empty.getValue() for a UUID or Guid.Empty.toString() for a String.
>>>>>>>> 5. All sorts of ways to transform Strings to Guids were removed. If you have
>>>>>>>> a literal you trust, just use new Guid(String). If you suspect it may be
>>>>>>>> null, use Guid.createGuidFromString[DefaultEmpty]
>>>>>>>> 6. NewGuid is now called newGuid. We're in Java, not C# :-)
>>>>>>>>
>>>>>>>>
>>>>>>>> Many thanks to everyone who reviewed this patchset.
>>>>>>>> You guys rock!
>>>>>>>>
>>>>>>>>
>>>>>>>> Regards,
>>>>>>>> Allon
>>>>>>>>
>>>>>>>>
>>>>>>>> [1]
>>>>>>>> http://gerrit.ovirt.org/#/q/project:ovirt-engine+branch:master+topic:guid-cleanup,n,z
>>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Engine-devel mailing list
>>>>>>> Engine-devel at ovirt.org <mailto:Engine-devel at ovirt.org>
>>>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>>>>
>>>>>> _______________________________________________
>>>>>> Engine-devel mailing list
>>>>>> Engine-devel at ovirt.org <mailto:Engine-devel at ovirt.org>
>>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>>
>>>>> Michael Pasternak
>>>>> RedHat, ENG-Virtualization R&D
>>>>
>>>
>>>
>>>    --
>>>
>>>    Michael Pasternak
>>>    RedHat, ENG-Virtualization R&D
>>>
>>>
>>
>>
>> -- 
>>
>> Michael Pasternak
>> RedHat, ENG-Virtualization R&D
> 


-- 

Michael Pasternak
RedHat, ENG-Virtualization R&D


From mpastern at redhat.com  Sun Jun 30 10:23:51 2013
From: mpastern at redhat.com (Michael Pasternak)
Date: Sun, 30 Jun 2013 13:23:51 +0300
Subject: [Engine-devel] Guid improvements
In-Reply-To: <51D00546.70307@redhat.com>
References: <207761917.1453625.1372579890708.JavaMail.root@redhat.com>
	<1510804261.30673992.1372580036122.JavaMail.root@redhat.com>
	<64DD4754-E88A-4FF2-94BA-3B1F2B2D2BA5@gmail.com>
	<51CFF518.3090305@redhat.com>
	<FD2655AD-49C7-4659-9300-DF83F8091790@gmail.com>
	<51CFFDFA.9020504@redhat.com>
	<CAJ3aYLfn2=_npnzLDTn66PWzfbOWpR43_wTf_Tcu3=S4Gz_cug@mail.gmail.com>
	<51D001B5.9070601@redhat.com>
	<C473A148-584C-4271-9138-DD3137B96E0A@gmail.com>
	<51D00546.70307@redhat.com>
Message-ID: <51D00737.4030902@redhat.com>

On 06/30/2013 01:15 PM, Michael Pasternak wrote:
> On 06/30/2013 01:08 PM, Liran Zelkha wrote:
>> Why synchronization? No need for it. Worst case scenario a put (which should be much less common then get) will occur twice on the same key. 
> 
> why assuming a best & not worst scenario? don't forget that every new insertion requires collision resolution
> which is triggers .equals() on the GUID.

Liran, don't get me wrong, i'm not against the caching in general, obviously reads > writes so
actually i'm all with you, just we're going to significantly enlarge a memory footprint so i just want
to make sure we're on a right track for the worst scenario where engine runs for ages and hashmap reaches
it's load factor.

> 
>>
>> On Jun 30, 2013, at 1:00 PM, Michael Pasternak wrote:
>>
>>> On 06/30/2013 12:45 PM, Liran Zelkha wrote:
>>>> All is true. But average UUID.fromString execution is 1675us, and HashMap.put is 78us - so the benefit is clear when we're talking on >100K executions for 10minutes...
>>>
>>> even with synchronization? what about ConcurrentHashMap?
>>>
>>>>
>>>>
>>>> On Sun, Jun 30, 2013 at 12:44 PM, Michael Pasternak <mpastern at redhat.com <mailto:mpastern at redhat.com>> wrote:
>>>>
>>>>    On 06/30/2013 12:20 PM, Liran Zelkha wrote:
>>>>> I checked such a solution using JProfiler. Creating the GUID object takes much more CPU cycles that checking the string in the Map.
>>>>
>>>>    of course it is, but what is the size of map that you checked?, check on worst scenario, i.e map
>>>>    is full of all possible guids,
>>>>
>>>>    also problem a bit different,java map has a load factor (which is usually 0.75),
>>>>    when ratio increases beyond the load factor, occurs proses called re-hash so that the hash
>>>>    table will double amount of buckets. what can produce a cpu spikes (though it should not happen too often),
>>>>    to avoid this the initial capacity should be greater than the maximum number of entries / the
>>>>    load factor, and this is a huge map....
>>>>
>>>>    so basically this is a tradeoff between time and space costs against the new guid generation.
>>>>
>>>>>
>>>>> On Jun 30, 2013, at 12:06 PM, Michael Pasternak wrote:
>>>>>
>>>>>> On 06/30/2013 11:37 AM, Liran Zelkha wrote:
>>>>>>> Great news.
>>>>>>> Allon - please note that GUID is being recreated from String by both DB calls and by data received from VDSM. It is VERY useful to cache Guid String-->Guid, and not
>>>>    just Empty GUID.
>>>>>>>
>>>>>>> However, as the Guid class runs in GWT as well, you can't use Infinispan and you're limited in the HashMap implementations you can use.
>>>>>>> Personally, I don't think it's a memory leak, as GUID number in the system are finite and not too large.
>>>>>>
>>>>>> it's large, it's 128-bit random number, it's not about memory leaking, but cpu cost,
>>>>>> as you'll face a lot of rehash'ings in the map,
>>>>>>
>>>>>> i'm not even sure that using indexing in the map can help, worth checking.
>>>>>>
>>>>>> What do you think? Want to add it to your patch?
>>>>>>
>>>>>>
>>>>>>>
>>>>>>> On Jun 30, 2013, at 11:13 AM, Yair Zaslavsky wrote:
>>>>>>>
>>>>>>>> Well done, should have been done ages ago :)
>>>>>>>> Now, for the painful rebase of async_task_mgr changes :)
>>>>>>>>
>>>>>>>>
>>>>>>>> ----- Original Message -----
>>>>>>>>> From: "Allon Mureinik" <amureini at redhat.com <mailto:amureini at redhat.com>>
>>>>>>>>> To: "engine-devel" <engine-devel at ovirt.org <mailto:engine-devel at ovirt.org>>, "Barak Azulay" <bazulay at redhat.com <mailto:bazulay at redhat.com>>
>>>>>>>>> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com <mailto:yzaslavs at redhat.com>>, "Michael Pasternak" <mpastern at redhat.com <mailto:mpastern at redhat.com>>, "Tal Nisan"
>>>>>>>>> <tnisan at redhat.com <mailto:tnisan at redhat.com>>, "Ayal Baron" <abaron at redhat.com <mailto:abaron at redhat.com>>
>>>>>>>>> Sent: Sunday, June 30, 2013 11:11:30 AM
>>>>>>>>> Subject: Guid improvements
>>>>>>>>>
>>>>>>>>> Hi all,
>>>>>>>>>
>>>>>>>>> I just merged a couple of improvements to the [N]Guid class [1] to improve
>>>>>>>>> it's performance both CPU-wise and memory-wise, based on a set of benchmarks
>>>>>>>>> presented by Liran.
>>>>>>>>>
>>>>>>>>> What this patchset achieves:
>>>>>>>>> 1. Clean up the code, so it's easier to understand and use
>>>>>>>>> 2. Eliminate the inflation in the memory foot print caused by the getValue()
>>>>>>>>> method
>>>>>>>>> 3. Eliminate all the heavy calls to UUID.fromString when creating a new/empty
>>>>>>>>> Guid instance as a default value
>>>>>>>>> 4. Note that the cleanups proposed in (1) will have minor performance
>>>>>>>>> benefits (e.g., eliminating useless conditional statements), but I doubt
>>>>>>>>> this would be anything to write home about.
>>>>>>>>>
>>>>>>>>> From a developer's perspective, here's what changed:
>>>>>>>>> 1. No more NGuid, just Guid. Both static methods to create a Guid from String
>>>>>>>>> still exist, and are named createGuidFromString and
>>>>>>>>> createGuidFromStringDefaultEmpty.
>>>>>>>>> 2. [N]Guid.getValue() was removed, it's no longer needed after (1) was
>>>>>>>>> implemented
>>>>>>>>> 3. The Guid() constructor was made private, as it forced a redundant call to
>>>>>>>>> UUID.fromString(String). If you need an empty Guid instance, just use
>>>>>>>>> Guid.Empty
>>>>>>>>> 4. The Guid.EMPTY_GUID_VALUE string constant was removed, as it was used for
>>>>>>>>> redundant calls to UUID.fromString. If you really, REALLY, need it, just
>>>>>>>>> call Guid.Empty.getValue() for a UUID or Guid.Empty.toString() for a String.
>>>>>>>>> 5. All sorts of ways to transform Strings to Guids were removed. If you have
>>>>>>>>> a literal you trust, just use new Guid(String). If you suspect it may be
>>>>>>>>> null, use Guid.createGuidFromString[DefaultEmpty]
>>>>>>>>> 6. NewGuid is now called newGuid. We're in Java, not C# :-)
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Many thanks to everyone who reviewed this patchset.
>>>>>>>>> You guys rock!
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Regards,
>>>>>>>>> Allon
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> [1]
>>>>>>>>> http://gerrit.ovirt.org/#/q/project:ovirt-engine+branch:master+topic:guid-cleanup,n,z
>>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> Engine-devel mailing list
>>>>>>>> Engine-devel at ovirt.org <mailto:Engine-devel at ovirt.org>
>>>>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Engine-devel mailing list
>>>>>>> Engine-devel at ovirt.org <mailto:Engine-devel at ovirt.org>
>>>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>>
>>>>>> Michael Pasternak
>>>>>> RedHat, ENG-Virtualization R&D
>>>>>
>>>>
>>>>
>>>>    --
>>>>
>>>>    Michael Pasternak
>>>>    RedHat, ENG-Virtualization R&D
>>>>
>>>>
>>>
>>>
>>> -- 
>>>
>>> Michael Pasternak
>>> RedHat, ENG-Virtualization R&D
>>
> 
> 


-- 

Michael Pasternak
RedHat, ENG-Virtualization R&D


From liran.zelkha at gmail.com  Sun Jun 30 10:23:39 2013
From: liran.zelkha at gmail.com (Liran Zelkha)
Date: Sun, 30 Jun 2013 13:23:39 +0300
Subject: [Engine-devel] Guid improvements
In-Reply-To: <51D00737.4030902@redhat.com>
References: <207761917.1453625.1372579890708.JavaMail.root@redhat.com>
	<1510804261.30673992.1372580036122.JavaMail.root@redhat.com>
	<64DD4754-E88A-4FF2-94BA-3B1F2B2D2BA5@gmail.com>
	<51CFF518.3090305@redhat.com>
	<FD2655AD-49C7-4659-9300-DF83F8091790@gmail.com>
	<51CFFDFA.9020504@redhat.com>
	<CAJ3aYLfn2=_npnzLDTn66PWzfbOWpR43_wTf_Tcu3=S4Gz_cug@mail.gmail.com>
	<51D001B5.9070601@redhat.com>
	<C473A148-584C-4271-9138-DD3137B96E0A@gmail.com>
	<51D00546.70307@redhat.com> <51D00737.4030902@redhat.com>
Message-ID: <0F8B2761-FB16-48BE-941D-F8B8C7FA775D@gmail.com>

Sure. I agree. I'd be happy to show you the results in the profiler, so we can make a correct decision.

On Jun 30, 2013, at 1:23 PM, Michael Pasternak wrote:

> On 06/30/2013 01:15 PM, Michael Pasternak wrote:
>> On 06/30/2013 01:08 PM, Liran Zelkha wrote:
>>> Why synchronization? No need for it. Worst case scenario a put (which should be much less common then get) will occur twice on the same key. 
>> 
>> why assuming a best & not worst scenario? don't forget that every new insertion requires collision resolution
>> which is triggers .equals() on the GUID.
> 
> Liran, don't get me wrong, i'm not against the caching in general, obviously reads > writes so
> actually i'm all with you, just we're going to significantly enlarge a memory footprint so i just want
> to make sure we're on a right track for the worst scenario where engine runs for ages and hashmap reaches
> it's load factor.
> 
>> 
>>> 
>>> On Jun 30, 2013, at 1:00 PM, Michael Pasternak wrote:
>>> 
>>>> On 06/30/2013 12:45 PM, Liran Zelkha wrote:
>>>>> All is true. But average UUID.fromString execution is 1675us, and HashMap.put is 78us - so the benefit is clear when we're talking on >100K executions for 10minutes...
>>>> 
>>>> even with synchronization? what about ConcurrentHashMap?
>>>> 
>>>>> 
>>>>> 
>>>>> On Sun, Jun 30, 2013 at 12:44 PM, Michael Pasternak <mpastern at redhat.com <mailto:mpastern at redhat.com>> wrote:
>>>>> 
>>>>>   On 06/30/2013 12:20 PM, Liran Zelkha wrote:
>>>>>> I checked such a solution using JProfiler. Creating the GUID object takes much more CPU cycles that checking the string in the Map.
>>>>> 
>>>>>   of course it is, but what is the size of map that you checked?, check on worst scenario, i.e map
>>>>>   is full of all possible guids,
>>>>> 
>>>>>   also problem a bit different,java map has a load factor (which is usually 0.75),
>>>>>   when ratio increases beyond the load factor, occurs proses called re-hash so that the hash
>>>>>   table will double amount of buckets. what can produce a cpu spikes (though it should not happen too often),
>>>>>   to avoid this the initial capacity should be greater than the maximum number of entries / the
>>>>>   load factor, and this is a huge map....
>>>>> 
>>>>>   so basically this is a tradeoff between time and space costs against the new guid generation.
>>>>> 
>>>>>> 
>>>>>> On Jun 30, 2013, at 12:06 PM, Michael Pasternak wrote:
>>>>>> 
>>>>>>> On 06/30/2013 11:37 AM, Liran Zelkha wrote:
>>>>>>>> Great news.
>>>>>>>> Allon - please note that GUID is being recreated from String by both DB calls and by data received from VDSM. It is VERY useful to cache Guid String-->Guid, and not
>>>>>   just Empty GUID.
>>>>>>>> 
>>>>>>>> However, as the Guid class runs in GWT as well, you can't use Infinispan and you're limited in the HashMap implementations you can use.
>>>>>>>> Personally, I don't think it's a memory leak, as GUID number in the system are finite and not too large.
>>>>>>> 
>>>>>>> it's large, it's 128-bit random number, it's not about memory leaking, but cpu cost,
>>>>>>> as you'll face a lot of rehash'ings in the map,
>>>>>>> 
>>>>>>> i'm not even sure that using indexing in the map can help, worth checking.
>>>>>>> 
>>>>>>> What do you think? Want to add it to your patch?
>>>>>>> 
>>>>>>> 
>>>>>>>> 
>>>>>>>> On Jun 30, 2013, at 11:13 AM, Yair Zaslavsky wrote:
>>>>>>>> 
>>>>>>>>> Well done, should have been done ages ago :)
>>>>>>>>> Now, for the painful rebase of async_task_mgr changes :)
>>>>>>>>> 
>>>>>>>>> 
>>>>>>>>> ----- Original Message -----
>>>>>>>>>> From: "Allon Mureinik" <amureini at redhat.com <mailto:amureini at redhat.com>>
>>>>>>>>>> To: "engine-devel" <engine-devel at ovirt.org <mailto:engine-devel at ovirt.org>>, "Barak Azulay" <bazulay at redhat.com <mailto:bazulay at redhat.com>>
>>>>>>>>>> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com <mailto:yzaslavs at redhat.com>>, "Michael Pasternak" <mpastern at redhat.com <mailto:mpastern at redhat.com>>, "Tal Nisan"
>>>>>>>>>> <tnisan at redhat.com <mailto:tnisan at redhat.com>>, "Ayal Baron" <abaron at redhat.com <mailto:abaron at redhat.com>>
>>>>>>>>>> Sent: Sunday, June 30, 2013 11:11:30 AM
>>>>>>>>>> Subject: Guid improvements
>>>>>>>>>> 
>>>>>>>>>> Hi all,
>>>>>>>>>> 
>>>>>>>>>> I just merged a couple of improvements to the [N]Guid class [1] to improve
>>>>>>>>>> it's performance both CPU-wise and memory-wise, based on a set of benchmarks
>>>>>>>>>> presented by Liran.
>>>>>>>>>> 
>>>>>>>>>> What this patchset achieves:
>>>>>>>>>> 1. Clean up the code, so it's easier to understand and use
>>>>>>>>>> 2. Eliminate the inflation in the memory foot print caused by the getValue()
>>>>>>>>>> method
>>>>>>>>>> 3. Eliminate all the heavy calls to UUID.fromString when creating a new/empty
>>>>>>>>>> Guid instance as a default value
>>>>>>>>>> 4. Note that the cleanups proposed in (1) will have minor performance
>>>>>>>>>> benefits (e.g., eliminating useless conditional statements), but I doubt
>>>>>>>>>> this would be anything to write home about.
>>>>>>>>>> 
>>>>>>>>>> From a developer's perspective, here's what changed:
>>>>>>>>>> 1. No more NGuid, just Guid. Both static methods to create a Guid from String
>>>>>>>>>> still exist, and are named createGuidFromString and
>>>>>>>>>> createGuidFromStringDefaultEmpty.
>>>>>>>>>> 2. [N]Guid.getValue() was removed, it's no longer needed after (1) was
>>>>>>>>>> implemented
>>>>>>>>>> 3. The Guid() constructor was made private, as it forced a redundant call to
>>>>>>>>>> UUID.fromString(String). If you need an empty Guid instance, just use
>>>>>>>>>> Guid.Empty
>>>>>>>>>> 4. The Guid.EMPTY_GUID_VALUE string constant was removed, as it was used for
>>>>>>>>>> redundant calls to UUID.fromString. If you really, REALLY, need it, just
>>>>>>>>>> call Guid.Empty.getValue() for a UUID or Guid.Empty.toString() for a String.
>>>>>>>>>> 5. All sorts of ways to transform Strings to Guids were removed. If you have
>>>>>>>>>> a literal you trust, just use new Guid(String). If you suspect it may be
>>>>>>>>>> null, use Guid.createGuidFromString[DefaultEmpty]
>>>>>>>>>> 6. NewGuid is now called newGuid. We're in Java, not C# :-)
>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>>> Many thanks to everyone who reviewed this patchset.
>>>>>>>>>> You guys rock!
>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>>> Regards,
>>>>>>>>>> Allon
>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>>> [1]
>>>>>>>>>> http://gerrit.ovirt.org/#/q/project:ovirt-engine+branch:master+topic:guid-cleanup,n,z
>>>>>>>>>> 
>>>>>>>>> _______________________________________________
>>>>>>>>> Engine-devel mailing list
>>>>>>>>> Engine-devel at ovirt.org <mailto:Engine-devel at ovirt.org>
>>>>>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>>>>>> 
>>>>>>>> _______________________________________________
>>>>>>>> Engine-devel mailing list
>>>>>>>> Engine-devel at ovirt.org <mailto:Engine-devel at ovirt.org>
>>>>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>> --
>>>>>>> 
>>>>>>> Michael Pasternak
>>>>>>> RedHat, ENG-Virtualization R&D
>>>>>> 
>>>>> 
>>>>> 
>>>>>   --
>>>>> 
>>>>>   Michael Pasternak
>>>>>   RedHat, ENG-Virtualization R&D
>>>>> 
>>>>> 
>>>> 
>>>> 
>>>> -- 
>>>> 
>>>> Michael Pasternak
>>>> RedHat, ENG-Virtualization R&D
>>> 
>> 
>> 
> 
> 
> -- 
> 
> Michael Pasternak
> RedHat, ENG-Virtualization R&D



From tnisan at redhat.com  Sun Jun 30 10:53:01 2013
From: tnisan at redhat.com (Tal Nisan)
Date: Sun, 30 Jun 2013 13:53:01 +0300
Subject: [Engine-devel] Guid improvements
In-Reply-To: <1510804261.30673992.1372580036122.JavaMail.root@redhat.com>
References: <207761917.1453625.1372579890708.JavaMail.root@redhat.com>
	<1510804261.30673992.1372580036122.JavaMail.root@redhat.com>
Message-ID: <51D00E0D.5090103@redhat.com>

On 06/30/2013 11:13 AM, Yair Zaslavsky wrote:
> Well done, should have been done ages ago :)
> Now, for the painful rebase of async_task_mgr changes :)
And for the total removal of Guid wrapper usage of java.util.UUID 
directly instead ;)

>
> ----- Original Message -----
>> From: "Allon Mureinik" <amureini at redhat.com>
>> To: "engine-devel" <engine-devel at ovirt.org>, "Barak Azulay" <bazulay at redhat.com>
>> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Michael Pasternak" <mpastern at redhat.com>, "Tal Nisan"
>> <tnisan at redhat.com>, "Ayal Baron" <abaron at redhat.com>
>> Sent: Sunday, June 30, 2013 11:11:30 AM
>> Subject: Guid improvements
>>
>> Hi all,
>>
>> I just merged a couple of improvements to the [N]Guid class [1] to improve
>> it's performance both CPU-wise and memory-wise, based on a set of benchmarks
>> presented by Liran.
>>
>> What this patchset achieves:
>> 1. Clean up the code, so it's easier to understand and use
>> 2. Eliminate the inflation in the memory foot print caused by the getValue()
>> method
>> 3. Eliminate all the heavy calls to UUID.fromString when creating a new/empty
>> Guid instance as a default value
>> 4. Note that the cleanups proposed in (1) will have minor performance
>> benefits (e.g., eliminating useless conditional statements), but I doubt
>> this would be anything to write home about.
>>
>>  From a developer's perspective, here's what changed:
>> 1. No more NGuid, just Guid. Both static methods to create a Guid from String
>> still exist, and are named createGuidFromString and
>> createGuidFromStringDefaultEmpty.
>> 2. [N]Guid.getValue() was removed, it's no longer needed after (1) was
>> implemented
>> 3. The Guid() constructor was made private, as it forced a redundant call to
>> UUID.fromString(String). If you need an empty Guid instance, just use
>> Guid.Empty
>> 4. The Guid.EMPTY_GUID_VALUE string constant was removed, as it was used for
>> redundant calls to UUID.fromString. If you really, REALLY, need it, just
>> call Guid.Empty.getValue() for a UUID or Guid.Empty.toString() for a String.
>> 5. All sorts of ways to transform Strings to Guids were removed. If you have
>> a literal you trust, just use new Guid(String). If you suspect it may be
>> null, use Guid.createGuidFromString[DefaultEmpty]
>> 6. NewGuid is now called newGuid. We're in Java, not C# :-)
>>
>>
>> Many thanks to everyone who reviewed this patchset.
>> You guys rock!
>>
>>
>> Regards,
>> Allon
>>
>>
>> [1]
>> http://gerrit.ovirt.org/#/q/project:ovirt-engine+branch:master+topic:guid-cleanup,n,z
>>



From lpeer at redhat.com  Sun Jun 30 12:59:37 2013
From: lpeer at redhat.com (Livnat Peer)
Date: Sun, 30 Jun 2013 15:59:37 +0300
Subject: [Engine-devel] VNIC profiles
Message-ID: <51D02BB9.4090008@redhat.com>

Hi,

We are working on adding VNIC profiles as part of the work to add VNIC QoS.

http://www.ovirt.org/Features/Network_QoS#VNIC_Profiles

We need to define some of the system behavior followed by this change,
here is my take -

Editing a profile -
--------------------
A user should be able to edit the profile properties (including profile
name) while VMs are attached and are using this Profile (reference
should be done by id).

Changing the network though is a bit more tricky as long as we don't
have a way to distinguish between running and current configurations I
think it could be very confusing to the user. Especially since we
support dynamic wiring so the behavior IMO is unpredictable.
I think it should be blocked at this point.


Edit a VNIC / change a VNIC profile -
------------------------------------
Changing the profile a VM is using while the VM is running should behave
like dynamic wiring (changing the VM network while it is running).


Remove a Profile -
-------------------
Is only valid if all VMs that are using this profile are in status down.
It should update all VMs to point to no profile which should behave like
none network today.

I see no reason to support a profile on a none network at this point.

The above is also relevant for upgrade flow (upgrading none network to
point to no profile)


Removing a Network -
----------------------
should remove all profiles on that network


VM snapshot/import/export -
--------------------------
We should handle VMs that are pointing to a network directly for b/w
compatibility.
we need to select first profile that is on that network that the user
has permissions on.


I assume there are more, comments are welcome

Thanks, Livnat



From danken at redhat.com  Sun Jun 30 14:40:49 2013
From: danken at redhat.com (Dan Kenigsberg)
Date: Sun, 30 Jun 2013 17:40:49 +0300
Subject: [Engine-devel] SSH Soft Fencing
In-Reply-To: <1695008076.4096833.1372337319955.JavaMail.root@redhat.com>
References: <1622219224.572748.1372330266360.JavaMail.root@redhat.com>
	<1695008076.4096833.1372337319955.JavaMail.root@redhat.com>
Message-ID: <20130630144048.GP11361@redhat.com>

On Thu, Jun 27, 2013 at 08:48:39AM -0400, Eli Mesika wrote:
> 
> 
> ----- Original Message -----
> > From: "Martin Perina" <mperina at redhat.com>
> > To: engine-devel at ovirt.org
> > Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Barak Azulay" <bazulay at redhat.com>, "Eli Mesika" <emesika at redhat.com>
> > Sent: Thursday, June 27, 2013 1:51:06 PM
> > Subject: SSH Soft Fencing
> > 
> > Hi,
> > 
> > SSH Soft Fencing is a new feature for 3.3 and it tries to restart VDSM
> > using SSH connection on non responsive hosts prior to real fencing.
> > More info can be found at
> > 
> > http://www.ovirt.org/Automatic_Fencing#Automatic_Fencing_in_oVirt_3.3
> > 
> > In current SSH Soft Fencing implementation the restart VDSM using SSH
> > command is part of standard fencing implementation in
> > VdsNotRespondingTreatmentCommand. But this command is executed only
> > if a host has a valid PM configuration. If host doesn't have a valid
> > PM configuration, the execution of the command is disabled and host
> > state is change to Non Responsive.
> > 
> > So my question are:
> > 
> > 1) Should SSH Soft Fencing be executed on hosts without valid PM
> >    configuration?
> 
> I think that the answer should be yes. The vdsm restart will solve most of problems

Would you enumerate the problems that would be solved by a vdsm restart
(on list, but on the feature page, too)?
I am aware of two issues, both are vdsm bugs:
- If libvirtd crashes, vdsm not is not restarted unless there are
  running VMs
- Vdsm had several bugs in its soft prepareForShutdown process, getting
  itself stuck there in case of various background storage processes.

I think that solving these two issues would be safer and cleaner than
introducing `ssh host service vdsmd restart` flow.

The first issue is only a matter of untangling some vdsm internal
ugliness: whenever a libvirtconnection is produced, it should be wrapped
so that it cathces libvirt crashes. Unlike now, where only VM-related
libvirtconnection undergo this treatment.

The second issue can be avoiding by vdsm resorting to kill-9-ing itself.
After all, this is what `service vdsmd restart` ends up doing after a
VERY short timeout (2-3 seconds, iicr).

I suppose that there are other reasoning for a remote restart, but in
general, I think that it's better to have Vdsm "do the right thing" than
expecting Engine to control that remotely.

Regards,
Dan.
> , so why not using it whether a PM agent is defined or not.
> 
> > 
> > 2) Should VDSM restart using SSH command be reimplemented
> >    as standalone command to be usable also in other parts of engine?
> >    If 1) is true, I think it will have to be done anyway.
> 
> +1 
> 
> > 
> > 
> > Martin Perina
> > 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel


From bazulay at redhat.com  Sun Jun 30 16:26:47 2013
From: bazulay at redhat.com (Barak Azulay)
Date: Sun, 30 Jun 2013 12:26:47 -0400 (EDT)
Subject: [Engine-devel] SSH Soft Fencing
In-Reply-To: <20130630144048.GP11361@redhat.com>
References: <1622219224.572748.1372330266360.JavaMail.root@redhat.com>
	<1695008076.4096833.1372337319955.JavaMail.root@redhat.com>
	<20130630144048.GP11361@redhat.com>
Message-ID: <1078906370.10265802.1372609607742.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Dan Kenigsberg" <danken at redhat.com>
> To: "Eli Mesika" <emesika at redhat.com>
> Cc: engine-devel at ovirt.org
> Sent: Sunday, June 30, 2013 5:40:49 PM
> Subject: Re: [Engine-devel] SSH Soft Fencing
> 
> On Thu, Jun 27, 2013 at 08:48:39AM -0400, Eli Mesika wrote:
> > 
> > 
> > ----- Original Message -----
> > > From: "Martin Perina" <mperina at redhat.com>
> > > To: engine-devel at ovirt.org
> > > Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Barak Azulay"
> > > <bazulay at redhat.com>, "Eli Mesika" <emesika at redhat.com>
> > > Sent: Thursday, June 27, 2013 1:51:06 PM
> > > Subject: SSH Soft Fencing
> > > 
> > > Hi,
> > > 
> > > SSH Soft Fencing is a new feature for 3.3 and it tries to restart VDSM
> > > using SSH connection on non responsive hosts prior to real fencing.
> > > More info can be found at
> > > 
> > > http://www.ovirt.org/Automatic_Fencing#Automatic_Fencing_in_oVirt_3.3
> > > 
> > > In current SSH Soft Fencing implementation the restart VDSM using SSH
> > > command is part of standard fencing implementation in
> > > VdsNotRespondingTreatmentCommand. But this command is executed only
> > > if a host has a valid PM configuration. If host doesn't have a valid
> > > PM configuration, the execution of the command is disabled and host
> > > state is change to Non Responsive.
> > > 
> > > So my question are:
> > > 
> > > 1) Should SSH Soft Fencing be executed on hosts without valid PM
> > >    configuration?
> > 
> > I think that the answer should be yes. The vdsm restart will solve most of
> > problems
> 
> Would you enumerate the problems that would be solved by a vdsm restart
> (on list, but on the feature page, too)?
> I am aware of two issues, both are vdsm bugs:
> - If libvirtd crashes, vdsm not is not restarted unless there are
>   running VMs
> - Vdsm had several bugs in its soft prepareForShutdown process, getting
>   itself stuck there in case of various background storage processes.
> 
> I think that solving these two issues would be safer and cleaner than
> introducing `ssh host service vdsmd restart` flow.
> 
> The first issue is only a matter of untangling some vdsm internal
> ugliness: whenever a libvirtconnection is produced, it should be wrapped
> so that it cathces libvirt crashes. Unlike now, where only VM-related
> libvirtconnection undergo this treatment.
> 
> The second issue can be avoiding by vdsm resorting to kill-9-ing itself.
> After all, this is what `service vdsmd restart` ends up doing after a
> VERY short timeout (2-3 seconds, iicr).
> 
> I suppose that there are other reasoning for a remote restart, but in
> general, I think that it's better to have Vdsm "do the right thing" than
> expecting Engine to control that remotely.


theoretically you are absolutely right, but this is much more challenging when the platform you are using keeps changing and might introduce unfamiliar behaviors or bugs.
You have enumerated several issues that we have encountered in the past and were fixed by us or by different components.
- libvirt related
- prepareForShutdown
- ... I even remember some from SuperVDSM

All the above eventually were handled brutally by the engine and caused the host to be entirely fenced and all running VMs were killed (and the service they gave went down).

This is about trying to handle an unexpected situation in a more somewhat delicate manner that in most cases will save killing the VMs, in a scenario where the host is going to be fenced anyway 

Now the question Martin had raised is whether this functionality should be applied also when a host has no physical Power-Management device, 

Hopes this provides the info you refereed to.


Thanks
Barak Azulay 


> 
> Regards,
> Dan.
> > , so why not using it whether a PM agent is defined or not.
> > 
> > > 
> > > 2) Should VDSM restart using SSH command be reimplemented
> > >    as standalone command to be usable also in other parts of engine?
> > >    If 1) is true, I think it will have to be done anyway.
> > 
> > +1
> > 
> > > 
> > > 
> > > Martin Perina
> > > 
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
> 
> 


From bazulay at redhat.com  Sun Jun 30 16:33:41 2013
From: bazulay at redhat.com (Barak Azulay)
Date: Sun, 30 Jun 2013 12:33:41 -0400 (EDT)
Subject: [Engine-devel] SSH Soft Fencing
In-Reply-To: <51CFBCD4.2020707@redhat.com>
References: <1622219224.572748.1372330266360.JavaMail.root@redhat.com>
	<1695008076.4096833.1372337319955.JavaMail.root@redhat.com>
	<12227690.29409642.1372344197624.JavaMail.root@redhat.com>
	<1625820710.4175423.1372344929287.JavaMail.root@redhat.com>
	<687362379.9364944.1372354295556.JavaMail.root@redhat.com>
	<1778456392.30662061.1372560380868.JavaMail.root@redhat.com>
	<51CFBCD4.2020707@redhat.com>
Message-ID: <192366924.10266633.1372610021223.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Livnat Peer" <lpeer at redhat.com>
> To: "Yair Zaslavsky" <yzaslavs at redhat.com>
> Cc: engine-devel at ovirt.org
> Sent: Sunday, June 30, 2013 8:06:28 AM
> Subject: Re: [Engine-devel] SSH Soft Fencing
> 
> On 06/30/2013 05:46 AM, Yair Zaslavsky wrote:
> > 
> > 
> > ----- Original Message -----
> >> From: "Barak Azulay" <bazulay at redhat.com>
> >> To: "Martin Perina" <mperina at redhat.com>
> >> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, engine-devel at ovirt.org, "Eli
> >> Mesika" <emesika at redhat.com>
> >> Sent: Thursday, June 27, 2013 8:31:35 PM
> >> Subject: Re: SSH Soft Fencing
> >>
> >>
> >>
> >> ----- Original Message -----
> >>> From: "Eli Mesika" <emesika at redhat.com>
> >>> To: "Yair Zaslavsky" <yzaslavs at redhat.com>
> >>> Cc: "Martin Perina" <mperina at redhat.com>, engine-devel at ovirt.org, "Barak
> >>> Azulay" <bazulay at redhat.com>
> >>> Sent: Thursday, June 27, 2013 5:55:29 PM
> >>> Subject: Re: SSH Soft Fencing
> >>>
> >>>
> >>>
> >>> ----- Original Message -----
> >>>> From: "Yair Zaslavsky" <yzaslavs at redhat.com>
> >>>> To: "Eli Mesika" <emesika at redhat.com>
> >>>> Cc: "Martin Perina" <mperina at redhat.com>, engine-devel at ovirt.org, "Barak
> >>>> Azulay" <bazulay at redhat.com>
> >>>> Sent: Thursday, June 27, 2013 5:43:17 PM
> >>>> Subject: Re: SSH Soft Fencing
> >>>>
> >>>>
> >>>>
> >>>> ----- Original Message -----
> >>>>> From: "Eli Mesika" <emesika at redhat.com>
> >>>>> To: "Martin Perina" <mperina at redhat.com>
> >>>>> Cc: engine-devel at ovirt.org, "Yair Zaslavsky" <yzaslavs at redhat.com>,
> >>>>> "Barak
> >>>>> Azulay" <bazulay at redhat.com>
> >>>>> Sent: Thursday, June 27, 2013 3:48:39 PM
> >>>>> Subject: Re: SSH Soft Fencing
> >>>>>
> >>>>>
> >>>>>
> >>>>> ----- Original Message -----
> >>>>>> From: "Martin Perina" <mperina at redhat.com>
> >>>>>> To: engine-devel at ovirt.org
> >>>>>> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Barak Azulay"
> >>>>>> <bazulay at redhat.com>, "Eli Mesika" <emesika at redhat.com>
> >>>>>> Sent: Thursday, June 27, 2013 1:51:06 PM
> >>>>>> Subject: SSH Soft Fencing
> >>>>>>
> >>>>>> Hi,
> >>>>>>
> >>>>>> SSH Soft Fencing is a new feature for 3.3 and it tries to restart
> >>>>>> VDSM
> >>>>>> using SSH connection on non responsive hosts prior to real fencing.
> >>>>>> More info can be found at
> >>>>>>
> >>>>>> http://www.ovirt.org/Automatic_Fencing#Automatic_Fencing_in_oVirt_3.3
> >>>>>>
> >>>>>> In current SSH Soft Fencing implementation the restart VDSM using SSH
> >>>>>> command is part of standard fencing implementation in
> >>>>>> VdsNotRespondingTreatmentCommand. But this command is executed only
> >>>>>> if a host has a valid PM configuration. If host doesn't have a valid
> >>>>>> PM configuration, the execution of the command is disabled and host
> >>>>>> state is change to Non Responsive.
> >>>>>>
> >>>>>> So my question are:
> >>>>>>
> >>>>>> 1) Should SSH Soft Fencing be executed on hosts without valid PM
> >>>>>>    configuration?
> >>>>>
> >>>>> I think that the answer should be yes. The vdsm restart will solve most
> >>>>> of
> >>>>> problems , so why not using it whether a PM agent is defined or not.
> >>>> I agree.
> >>>> I would like to say that I also don't like the fact that
> >>>> VdsNotRespondingTreatment extends RestartVdsCommand.
> >>>> One should ask if "non responding treatment is a restart vds operation"
> >>>> or
> >>>> maybe RestartVdsCommand is just a step in the non responding treatment
> >>>> (inheritance vs containment/delegation).
> >>>> I think that VdsNotRespodingTreatment should delegate the call to
> >>>> RestartVdsCommand as the 2nd step after issuing the Soft Fencing
> >>>> command.
> >>>> Thoughts anyone?
> >>>
> >>> That would be a nice and needed re-factoring
> >>
> >> I would say yes - but would add it only with appropriate configuration
> >> (enableAutoSoftVdsmRestartWhenNoPMAvailable .... I hate the name)
> > 
> > +1 on configuration.
> > Configuration must reside at host-related entities (i.e - VdsStatic).
> > 
> > Yair
> > 
> 
> Why would a user like to avoid fencing VDSM when host becomes
> non-responsive?
> 
> I think that adding another configuration option is cumbersome with no
> real value.

The problem i'm trying to solve is not about whether this is the right way to solve a case where vdsm is not responsive,
But it's about changing the expected behavior in certain cases (and not be able to disable such a change).

When a user does not configure a PM he does not expect any fencing to happen, and may be he wants to reach a state where VDSM is stuck .....
(even for development purposes ...) and buy doing the automatic SSH fencing we are actually depriving him from thas option.

So let's enable him to reach that situation if he desires (by configuration), and put the default to automatically do the SSH + restart.   


> 
> Livnat
> 
> >>
> >>  
> >>
> >>>
> >>>>
> >>>>>
> >>>>>>
> >>>>>> 2) Should VDSM restart using SSH command be reimplemented
> >>>>>>    as standalone command to be usable also in other parts of engine?
> >>>>>>    If 1) is true, I think it will have to be done anyway.
> >>>>
> >>>> I agree here.
> >>>>>
> >>>>> +1
> >>
> >> On one hand it makes sense,  but I have several questions on the above:
> >> - Who do we think may want to use such a command ?
> >> - Should (or even can) we limit the use of such command to
> >> noneResponsiveTreatment ?
> >>
> >> Having general commands available to all code when there is only one
> >> specific
> >> case we are using it might be a bit riskey,
> >> Especially when we talk about restarting something.
> >>
> >> Thoughts ?
> >>
> >>
> >>
> >>>>>
> >>>>>>
> >>>>>>
> >>>>>> Martin Perina
> >>>>>>
> >>>>>
> >>>>
> >>>
> >>
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
> 
> 


From bazulay at redhat.com  Sun Jun 30 16:35:22 2013
From: bazulay at redhat.com (Barak Azulay)
Date: Sun, 30 Jun 2013 12:35:22 -0400 (EDT)
Subject: [Engine-devel] SSH Soft Fencing
In-Reply-To: <687362379.9364944.1372354295556.JavaMail.root@redhat.com>
References: <1622219224.572748.1372330266360.JavaMail.root@redhat.com>
	<1695008076.4096833.1372337319955.JavaMail.root@redhat.com>
	<12227690.29409642.1372344197624.JavaMail.root@redhat.com>
	<1625820710.4175423.1372344929287.JavaMail.root@redhat.com>
	<687362379.9364944.1372354295556.JavaMail.root@redhat.com>
Message-ID: <2036896830.10266657.1372610122917.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Barak Azulay" <bazulay at redhat.com>
> To: "Martin Perina" <mperina at redhat.com>
> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, engine-devel at ovirt.org, "Eli Mesika" <emesika at redhat.com>
> Sent: Thursday, June 27, 2013 8:31:35 PM
> Subject: Re: SSH Soft Fencing
> 
> 
> 
> ----- Original Message -----
> > From: "Eli Mesika" <emesika at redhat.com>
> > To: "Yair Zaslavsky" <yzaslavs at redhat.com>
> > Cc: "Martin Perina" <mperina at redhat.com>, engine-devel at ovirt.org, "Barak
> > Azulay" <bazulay at redhat.com>
> > Sent: Thursday, June 27, 2013 5:55:29 PM
> > Subject: Re: SSH Soft Fencing
> > 
> > 
> > 
> > ----- Original Message -----
> > > From: "Yair Zaslavsky" <yzaslavs at redhat.com>
> > > To: "Eli Mesika" <emesika at redhat.com>
> > > Cc: "Martin Perina" <mperina at redhat.com>, engine-devel at ovirt.org, "Barak
> > > Azulay" <bazulay at redhat.com>
> > > Sent: Thursday, June 27, 2013 5:43:17 PM
> > > Subject: Re: SSH Soft Fencing
> > > 
> > > 
> > > 
> > > ----- Original Message -----
> > > > From: "Eli Mesika" <emesika at redhat.com>
> > > > To: "Martin Perina" <mperina at redhat.com>
> > > > Cc: engine-devel at ovirt.org, "Yair Zaslavsky" <yzaslavs at redhat.com>,
> > > > "Barak
> > > > Azulay" <bazulay at redhat.com>
> > > > Sent: Thursday, June 27, 2013 3:48:39 PM
> > > > Subject: Re: SSH Soft Fencing
> > > > 
> > > > 
> > > > 
> > > > ----- Original Message -----
> > > > > From: "Martin Perina" <mperina at redhat.com>
> > > > > To: engine-devel at ovirt.org
> > > > > Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Barak Azulay"
> > > > > <bazulay at redhat.com>, "Eli Mesika" <emesika at redhat.com>
> > > > > Sent: Thursday, June 27, 2013 1:51:06 PM
> > > > > Subject: SSH Soft Fencing
> > > > > 
> > > > > Hi,
> > > > > 
> > > > > SSH Soft Fencing is a new feature for 3.3 and it tries to restart
> > > > > VDSM
> > > > > using SSH connection on non responsive hosts prior to real fencing.
> > > > > More info can be found at
> > > > > 
> > > > > http://www.ovirt.org/Automatic_Fencing#Automatic_Fencing_in_oVirt_3.3
> > > > > 
> > > > > In current SSH Soft Fencing implementation the restart VDSM using SSH
> > > > > command is part of standard fencing implementation in
> > > > > VdsNotRespondingTreatmentCommand. But this command is executed only
> > > > > if a host has a valid PM configuration. If host doesn't have a valid
> > > > > PM configuration, the execution of the command is disabled and host
> > > > > state is change to Non Responsive.
> > > > > 
> > > > > So my question are:
> > > > > 
> > > > > 1) Should SSH Soft Fencing be executed on hosts without valid PM
> > > > >    configuration?
> > > > 
> > > > I think that the answer should be yes. The vdsm restart will solve most
> > > > of
> > > > problems , so why not using it whether a PM agent is defined or not.
> > > I agree.
> > > I would like to say that I also don't like the fact that
> > > VdsNotRespondingTreatment extends RestartVdsCommand.
> > > One should ask if "non responding treatment is a restart vds operation"
> > > or
> > > maybe RestartVdsCommand is just a step in the non responding treatment
> > > (inheritance vs containment/delegation).
> > > I think that VdsNotRespodingTreatment should delegate the call to
> > > RestartVdsCommand as the 2nd step after issuing the Soft Fencing command.
> > > Thoughts anyone?
> > 
> > That would be a nice and needed re-factoring
> 
> I would say yes - but would add it only with appropriate configuration
> (enableAutoSoftVdsmRestartWhenNoPMAvailable .... I hate the name)
> 
>  
> 
> > 
> > > 
> > > > 
> > > > > 
> > > > > 2) Should VDSM restart using SSH command be reimplemented
> > > > >    as standalone command to be usable also in other parts of engine?
> > > > >    If 1) is true, I think it will have to be done anyway.
> > > 
> > > I agree here.
> > > > 
> > > > +1
> 
> On one hand it makes sense,  but I have several questions on the above:
> - Who do we think may want to use such a command ?
> - Should (or even can) we limit the use of such command to
> noneResponsiveTreatment ?
> 
> Having general commands available to all code when there is only one specific
> case we are using it might be a bit riskey,
> Especially when we talk about restarting something.

Martin ? Eli? Yair?

Can you please refer to the issue above ?


> 
> Thoughts ?
> 
> 
> 
> > > > 
> > > > > 
> > > > > 
> > > > > Martin Perina
> > > > > 
> > > > 
> > > 
> > 
> 


From lpeer at redhat.com  Sun Jun 30 17:16:19 2013
From: lpeer at redhat.com (Livnat Peer)
Date: Sun, 30 Jun 2013 20:16:19 +0300
Subject: [Engine-devel] SSH Soft Fencing
In-Reply-To: <192366924.10266633.1372610021223.JavaMail.root@redhat.com>
References: <1622219224.572748.1372330266360.JavaMail.root@redhat.com>
	<1695008076.4096833.1372337319955.JavaMail.root@redhat.com>
	<12227690.29409642.1372344197624.JavaMail.root@redhat.com>
	<1625820710.4175423.1372344929287.JavaMail.root@redhat.com>
	<687362379.9364944.1372354295556.JavaMail.root@redhat.com>
	<1778456392.30662061.1372560380868.JavaMail.root@redhat.com>
	<51CFBCD4.2020707@redhat.com>
	<192366924.10266633.1372610021223.JavaMail.root@redhat.com>
Message-ID: <51D067E3.4010203@redhat.com>

On 06/30/2013 07:33 PM, Barak Azulay wrote:
> 
> 
> ----- Original Message -----
>> From: "Livnat Peer" <lpeer at redhat.com>
>> To: "Yair Zaslavsky" <yzaslavs at redhat.com>
>> Cc: engine-devel at ovirt.org
>> Sent: Sunday, June 30, 2013 8:06:28 AM
>> Subject: Re: [Engine-devel] SSH Soft Fencing
>>
>> On 06/30/2013 05:46 AM, Yair Zaslavsky wrote:
>>>
>>>
>>> ----- Original Message -----
>>>> From: "Barak Azulay" <bazulay at redhat.com>
>>>> To: "Martin Perina" <mperina at redhat.com>
>>>> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, engine-devel at ovirt.org, "Eli
>>>> Mesika" <emesika at redhat.com>
>>>> Sent: Thursday, June 27, 2013 8:31:35 PM
>>>> Subject: Re: SSH Soft Fencing
>>>>
>>>>
>>>>
>>>> ----- Original Message -----
>>>>> From: "Eli Mesika" <emesika at redhat.com>
>>>>> To: "Yair Zaslavsky" <yzaslavs at redhat.com>
>>>>> Cc: "Martin Perina" <mperina at redhat.com>, engine-devel at ovirt.org, "Barak
>>>>> Azulay" <bazulay at redhat.com>
>>>>> Sent: Thursday, June 27, 2013 5:55:29 PM
>>>>> Subject: Re: SSH Soft Fencing
>>>>>
>>>>>
>>>>>
>>>>> ----- Original Message -----
>>>>>> From: "Yair Zaslavsky" <yzaslavs at redhat.com>
>>>>>> To: "Eli Mesika" <emesika at redhat.com>
>>>>>> Cc: "Martin Perina" <mperina at redhat.com>, engine-devel at ovirt.org, "Barak
>>>>>> Azulay" <bazulay at redhat.com>
>>>>>> Sent: Thursday, June 27, 2013 5:43:17 PM
>>>>>> Subject: Re: SSH Soft Fencing
>>>>>>
>>>>>>
>>>>>>
>>>>>> ----- Original Message -----
>>>>>>> From: "Eli Mesika" <emesika at redhat.com>
>>>>>>> To: "Martin Perina" <mperina at redhat.com>
>>>>>>> Cc: engine-devel at ovirt.org, "Yair Zaslavsky" <yzaslavs at redhat.com>,
>>>>>>> "Barak
>>>>>>> Azulay" <bazulay at redhat.com>
>>>>>>> Sent: Thursday, June 27, 2013 3:48:39 PM
>>>>>>> Subject: Re: SSH Soft Fencing
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> ----- Original Message -----
>>>>>>>> From: "Martin Perina" <mperina at redhat.com>
>>>>>>>> To: engine-devel at ovirt.org
>>>>>>>> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Barak Azulay"
>>>>>>>> <bazulay at redhat.com>, "Eli Mesika" <emesika at redhat.com>
>>>>>>>> Sent: Thursday, June 27, 2013 1:51:06 PM
>>>>>>>> Subject: SSH Soft Fencing
>>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> SSH Soft Fencing is a new feature for 3.3 and it tries to restart
>>>>>>>> VDSM
>>>>>>>> using SSH connection on non responsive hosts prior to real fencing.
>>>>>>>> More info can be found at
>>>>>>>>
>>>>>>>> http://www.ovirt.org/Automatic_Fencing#Automatic_Fencing_in_oVirt_3.3
>>>>>>>>
>>>>>>>> In current SSH Soft Fencing implementation the restart VDSM using SSH
>>>>>>>> command is part of standard fencing implementation in
>>>>>>>> VdsNotRespondingTreatmentCommand. But this command is executed only
>>>>>>>> if a host has a valid PM configuration. If host doesn't have a valid
>>>>>>>> PM configuration, the execution of the command is disabled and host
>>>>>>>> state is change to Non Responsive.
>>>>>>>>
>>>>>>>> So my question are:
>>>>>>>>
>>>>>>>> 1) Should SSH Soft Fencing be executed on hosts without valid PM
>>>>>>>>    configuration?
>>>>>>>
>>>>>>> I think that the answer should be yes. The vdsm restart will solve most
>>>>>>> of
>>>>>>> problems , so why not using it whether a PM agent is defined or not.
>>>>>> I agree.
>>>>>> I would like to say that I also don't like the fact that
>>>>>> VdsNotRespondingTreatment extends RestartVdsCommand.
>>>>>> One should ask if "non responding treatment is a restart vds operation"
>>>>>> or
>>>>>> maybe RestartVdsCommand is just a step in the non responding treatment
>>>>>> (inheritance vs containment/delegation).
>>>>>> I think that VdsNotRespodingTreatment should delegate the call to
>>>>>> RestartVdsCommand as the 2nd step after issuing the Soft Fencing
>>>>>> command.
>>>>>> Thoughts anyone?
>>>>>
>>>>> That would be a nice and needed re-factoring
>>>>
>>>> I would say yes - but would add it only with appropriate configuration
>>>> (enableAutoSoftVdsmRestartWhenNoPMAvailable .... I hate the name)
>>>
>>> +1 on configuration.
>>> Configuration must reside at host-related entities (i.e - VdsStatic).
>>>
>>> Yair
>>>
>>
>> Why would a user like to avoid fencing VDSM when host becomes
>> non-responsive?
>>
>> I think that adding another configuration option is cumbersome with no
>> real value.
> 
> The problem i'm trying to solve is not about whether this is the right way to solve a case where vdsm is not responsive,
> But it's about changing the expected behavior in certain cases (and not be able to disable such a change).
> 

When adding enhancements many times you change system behavior.
For adding configuration option to enable the previous mode we need to
see if it make sense and if the system users are going to use it,
otherwise we are adding config option with no use.

Ending up with hundreds of configuration options only makes the
configuration cumbersome instead of useful.

> When a user does not configure a PM he does not expect any fencing to happen, and may be he wants to reach a state where VDSM is stuck .....
> (even for development purposes ...) and buy doing the automatic SSH fencing we are actually depriving him from thas option.
> 

The developers use case, in this case, does not sound like a good reason
for adding this configuration option but that is only my 2 cents.

> So let's enable him to reach that situation if he desires (by configuration), and put the default to automatically do the SSH + restart.   
> 
> 
>>
>> Livnat
>>
>>>>
>>>>  
>>>>
>>>>>
>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>> 2) Should VDSM restart using SSH command be reimplemented
>>>>>>>>    as standalone command to be usable also in other parts of engine?
>>>>>>>>    If 1) is true, I think it will have to be done anyway.
>>>>>>
>>>>>> I agree here.
>>>>>>>
>>>>>>> +1
>>>>
>>>> On one hand it makes sense,  but I have several questions on the above:
>>>> - Who do we think may want to use such a command ?
>>>> - Should (or even can) we limit the use of such command to
>>>> noneResponsiveTreatment ?
>>>>
>>>> Having general commands available to all code when there is only one
>>>> specific
>>>> case we are using it might be a bit riskey,
>>>> Especially when we talk about restarting something.
>>>>
>>>> Thoughts ?
>>>>
>>>>
>>>>
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Martin Perina
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>> _______________________________________________
>>> Engine-devel mailing list
>>> Engine-devel at ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>
>>
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>
>>
>>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
> 



From lpeer at redhat.com  Sun Jun 30 17:19:22 2013
From: lpeer at redhat.com (Livnat Peer)
Date: Sun, 30 Jun 2013 20:19:22 +0300
Subject: [Engine-devel] SSH Soft Fencing
In-Reply-To: <1078906370.10265802.1372609607742.JavaMail.root@redhat.com>
References: <1622219224.572748.1372330266360.JavaMail.root@redhat.com>
	<1695008076.4096833.1372337319955.JavaMail.root@redhat.com>
	<20130630144048.GP11361@redhat.com>
	<1078906370.10265802.1372609607742.JavaMail.root@redhat.com>
Message-ID: <51D0689A.5020702@redhat.com>

On 06/30/2013 07:26 PM, Barak Azulay wrote:
> 
> 
> ----- Original Message -----
>> From: "Dan Kenigsberg" <danken at redhat.com>
>> To: "Eli Mesika" <emesika at redhat.com>
>> Cc: engine-devel at ovirt.org
>> Sent: Sunday, June 30, 2013 5:40:49 PM
>> Subject: Re: [Engine-devel] SSH Soft Fencing
>>
>> On Thu, Jun 27, 2013 at 08:48:39AM -0400, Eli Mesika wrote:
>>>
>>>
>>> ----- Original Message -----
>>>> From: "Martin Perina" <mperina at redhat.com>
>>>> To: engine-devel at ovirt.org
>>>> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Barak Azulay"
>>>> <bazulay at redhat.com>, "Eli Mesika" <emesika at redhat.com>
>>>> Sent: Thursday, June 27, 2013 1:51:06 PM
>>>> Subject: SSH Soft Fencing
>>>>
>>>> Hi,
>>>>
>>>> SSH Soft Fencing is a new feature for 3.3 and it tries to restart VDSM
>>>> using SSH connection on non responsive hosts prior to real fencing.
>>>> More info can be found at
>>>>
>>>> http://www.ovirt.org/Automatic_Fencing#Automatic_Fencing_in_oVirt_3.3
>>>>
>>>> In current SSH Soft Fencing implementation the restart VDSM using SSH
>>>> command is part of standard fencing implementation in
>>>> VdsNotRespondingTreatmentCommand. But this command is executed only
>>>> if a host has a valid PM configuration. If host doesn't have a valid
>>>> PM configuration, the execution of the command is disabled and host
>>>> state is change to Non Responsive.
>>>>
>>>> So my question are:
>>>>
>>>> 1) Should SSH Soft Fencing be executed on hosts without valid PM
>>>>    configuration?
>>>
>>> I think that the answer should be yes. The vdsm restart will solve most of
>>> problems
>>
>> Would you enumerate the problems that would be solved by a vdsm restart
>> (on list, but on the feature page, too)?
>> I am aware of two issues, both are vdsm bugs:
>> - If libvirtd crashes, vdsm not is not restarted unless there are
>>   running VMs
>> - Vdsm had several bugs in its soft prepareForShutdown process, getting
>>   itself stuck there in case of various background storage processes.
>>
>> I think that solving these two issues would be safer and cleaner than
>> introducing `ssh host service vdsmd restart` flow.
>>
>> The first issue is only a matter of untangling some vdsm internal
>> ugliness: whenever a libvirtconnection is produced, it should be wrapped
>> so that it cathces libvirt crashes. Unlike now, where only VM-related
>> libvirtconnection undergo this treatment.
>>
>> The second issue can be avoiding by vdsm resorting to kill-9-ing itself.
>> After all, this is what `service vdsmd restart` ends up doing after a
>> VERY short timeout (2-3 seconds, iicr).
>>
>> I suppose that there are other reasoning for a remote restart, but in
>> general, I think that it's better to have Vdsm "do the right thing" than
>> expecting Engine to control that remotely.
> 
> 
> theoretically you are absolutely right, but this is much more challenging when the platform you are using keeps changing and might introduce unfamiliar behaviors or bugs.
> You have enumerated several issues that we have encountered in the past and were fixed by us or by different components.
> - libvirt related
> - prepareForShutdown
> - ... I even remember some from SuperVDSM
> 
> All the above eventually were handled brutally by the engine and caused the host to be entirely fenced and all running VMs were killed (and the service they gave went down).
> 
> This is about trying to handle an unexpected situation in a more somewhat delicate manner that in most cases will save killing the VMs, in a scenario where the host is going to be fenced anyway 
> 

+1
We can not anticipates our own bugs ;)


> Now the question Martin had raised is whether this functionality should be applied also when a host has no physical Power-Management device, 
> 
> Hopes this provides the info you refereed to.
> 
> 
> Thanks
> Barak Azulay 
> 
> 
>>
>> Regards,
>> Dan.
>>> , so why not using it whether a PM agent is defined or not.
>>>
>>>>
>>>> 2) Should VDSM restart using SSH command be reimplemented
>>>>    as standalone command to be usable also in other parts of engine?
>>>>    If 1) is true, I think it will have to be done anyway.
>>>
>>> +1
>>>
>>>>
>>>>
>>>> Martin Perina
>>>>
>>> _______________________________________________
>>> Engine-devel mailing list
>>> Engine-devel at ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>
>>
>>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 



From alonbl at redhat.com  Sun Jun 30 19:16:26 2013
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Sun, 30 Jun 2013 15:16:26 -0400 (EDT)
Subject: [Engine-devel] development installation issues
In-Reply-To: <51CFE63A.2050505@redhat.com>
References: <51CFE63A.2050505@redhat.com>
Message-ID: <1449386688.13237557.1372619786067.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Michael Pasternak" <mpastern at redhat.com>
> To: "engine-devel" <engine-devel at ovirt.org>
> Sent: Sunday, June 30, 2013 11:03:06 AM
> Subject: [Engine-devel] development installation issues
> 
> 
> does anyone faced this with new 'development installation'?

Hi Michael,

Can I have the output of:

OTOPI_DEBUG=1 /home/mpastern/Coding/ovirt/ovirt-engine/bin/engine-setup-2

Thanks!

> 
> [mpastern at lpt21-f ovirt-engine]$
> /home/mpastern/Coding/ovirt/ovirt-engine/bin/engine-setup-2
> [ ERROR ] Failed to execute stage 'Booting': 5
> [ INFO  ] Stage: Initializing
>           Setup was run under unprivileged user this will produce development
>           installation do you wish to proceed? (Yes, No) [No]: Yes
> [WARNING] engine-setup-2 is a technical preview, and yet to include all
> functionality that exists in legacy engine-setup. Specifically,
> engine-setup-2 does not support
> upgrade from previous installations.
> [mpastern at lpt21-f ovirt-engine]$
> 
> --
> 
> Michael Pasternak
> RedHat, ENG-Virtualization R&D
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From emesika at redhat.com  Sun Jun 30 19:57:19 2013
From: emesika at redhat.com (Eli Mesika)
Date: Sun, 30 Jun 2013 15:57:19 -0400 (EDT)
Subject: [Engine-devel] SSH Soft Fencing
In-Reply-To: <2036896830.10266657.1372610122917.JavaMail.root@redhat.com>
References: <1622219224.572748.1372330266360.JavaMail.root@redhat.com>
	<1695008076.4096833.1372337319955.JavaMail.root@redhat.com>
	<12227690.29409642.1372344197624.JavaMail.root@redhat.com>
	<1625820710.4175423.1372344929287.JavaMail.root@redhat.com>
	<687362379.9364944.1372354295556.JavaMail.root@redhat.com>
	<2036896830.10266657.1372610122917.JavaMail.root@redhat.com>
Message-ID: <816379766.5009915.1372622239553.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Barak Azulay" <bazulay at redhat.com>
> To: "Martin Perina" <mperina at redhat.com>
> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, engine-devel at ovirt.org, "Eli Mesika" <emesika at redhat.com>
> Sent: Sunday, June 30, 2013 7:35:22 PM
> Subject: Re: SSH Soft Fencing
> 
> 
> 
> ----- Original Message -----
> > From: "Barak Azulay" <bazulay at redhat.com>
> > To: "Martin Perina" <mperina at redhat.com>
> > Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, engine-devel at ovirt.org, "Eli
> > Mesika" <emesika at redhat.com>
> > Sent: Thursday, June 27, 2013 8:31:35 PM
> > Subject: Re: SSH Soft Fencing
> > 
> > 
> > 
> > ----- Original Message -----
> > > From: "Eli Mesika" <emesika at redhat.com>
> > > To: "Yair Zaslavsky" <yzaslavs at redhat.com>
> > > Cc: "Martin Perina" <mperina at redhat.com>, engine-devel at ovirt.org, "Barak
> > > Azulay" <bazulay at redhat.com>
> > > Sent: Thursday, June 27, 2013 5:55:29 PM
> > > Subject: Re: SSH Soft Fencing
> > > 
> > > 
> > > 
> > > ----- Original Message -----
> > > > From: "Yair Zaslavsky" <yzaslavs at redhat.com>
> > > > To: "Eli Mesika" <emesika at redhat.com>
> > > > Cc: "Martin Perina" <mperina at redhat.com>, engine-devel at ovirt.org,
> > > > "Barak
> > > > Azulay" <bazulay at redhat.com>
> > > > Sent: Thursday, June 27, 2013 5:43:17 PM
> > > > Subject: Re: SSH Soft Fencing
> > > > 
> > > > 
> > > > 
> > > > ----- Original Message -----
> > > > > From: "Eli Mesika" <emesika at redhat.com>
> > > > > To: "Martin Perina" <mperina at redhat.com>
> > > > > Cc: engine-devel at ovirt.org, "Yair Zaslavsky" <yzaslavs at redhat.com>,
> > > > > "Barak
> > > > > Azulay" <bazulay at redhat.com>
> > > > > Sent: Thursday, June 27, 2013 3:48:39 PM
> > > > > Subject: Re: SSH Soft Fencing
> > > > > 
> > > > > 
> > > > > 
> > > > > ----- Original Message -----
> > > > > > From: "Martin Perina" <mperina at redhat.com>
> > > > > > To: engine-devel at ovirt.org
> > > > > > Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Barak Azulay"
> > > > > > <bazulay at redhat.com>, "Eli Mesika" <emesika at redhat.com>
> > > > > > Sent: Thursday, June 27, 2013 1:51:06 PM
> > > > > > Subject: SSH Soft Fencing
> > > > > > 
> > > > > > Hi,
> > > > > > 
> > > > > > SSH Soft Fencing is a new feature for 3.3 and it tries to restart
> > > > > > VDSM
> > > > > > using SSH connection on non responsive hosts prior to real fencing.
> > > > > > More info can be found at
> > > > > > 
> > > > > > http://www.ovirt.org/Automatic_Fencing#Automatic_Fencing_in_oVirt_3.3
> > > > > > 
> > > > > > In current SSH Soft Fencing implementation the restart VDSM using
> > > > > > SSH
> > > > > > command is part of standard fencing implementation in
> > > > > > VdsNotRespondingTreatmentCommand. But this command is executed only
> > > > > > if a host has a valid PM configuration. If host doesn't have a
> > > > > > valid
> > > > > > PM configuration, the execution of the command is disabled and host
> > > > > > state is change to Non Responsive.
> > > > > > 
> > > > > > So my question are:
> > > > > > 
> > > > > > 1) Should SSH Soft Fencing be executed on hosts without valid PM
> > > > > >    configuration?
> > > > > 
> > > > > I think that the answer should be yes. The vdsm restart will solve
> > > > > most
> > > > > of
> > > > > problems , so why not using it whether a PM agent is defined or not.
> > > > I agree.
> > > > I would like to say that I also don't like the fact that
> > > > VdsNotRespondingTreatment extends RestartVdsCommand.
> > > > One should ask if "non responding treatment is a restart vds operation"
> > > > or
> > > > maybe RestartVdsCommand is just a step in the non responding treatment
> > > > (inheritance vs containment/delegation).
> > > > I think that VdsNotRespodingTreatment should delegate the call to
> > > > RestartVdsCommand as the 2nd step after issuing the Soft Fencing
> > > > command.
> > > > Thoughts anyone?
> > > 
> > > That would be a nice and needed re-factoring
> > 
> > I would say yes - but would add it only with appropriate configuration
> > (enableAutoSoftVdsmRestartWhenNoPMAvailable .... I hate the name)
> > 
> >  
> > 
> > > 
> > > > 
> > > > > 
> > > > > > 
> > > > > > 2) Should VDSM restart using SSH command be reimplemented
> > > > > >    as standalone command to be usable also in other parts of
> > > > > >    engine?
> > > > > >    If 1) is true, I think it will have to be done anyway.
> > > > 
> > > > I agree here.
> > > > > 
> > > > > +1
> > 
> > On one hand it makes sense,  but I have several questions on the above:
> > - Who do we think may want to use such a command ?
> > - Should (or even can) we limit the use of such command to
> > noneResponsiveTreatment ?

Yes, I think we should limit that to noneResponsiveTreatment

> > 
> > Having general commands available to all code when there is only one
> > specific
> > case we are using it might be a bit riskey,
> > Especially when we talk about restarting something.

We can keep this internal and not expose it to the user, just implement explicitly in non responding treatment 

> 
> Martin ? Eli? Yair?
> 
> Can you please refer to the issue above ?
> 
> 
> > 
> > Thoughts ?
> > 
> > 
> > 
> > > > > 
> > > > > > 
> > > > > > 
> > > > > > Martin Perina
> > > > > > 
> > > > > 
> > > > 
> > > 
> > 
> 


From emesika at redhat.com  Sun Jun 30 21:19:02 2013
From: emesika at redhat.com (Eli Mesika)
Date: Sun, 30 Jun 2013 17:19:02 -0400 (EDT)
Subject: [Engine-devel] VNIC profiles
In-Reply-To: <51D02BB9.4090008@redhat.com>
References: <51D02BB9.4090008@redhat.com>
Message-ID: <1774330631.5017188.1372627142805.JavaMail.root@redhat.com>



----- Original Message -----
> From: "Livnat Peer" <lpeer at redhat.com>
> To: "engine-devel" <engine-devel at ovirt.org>, "Ofri Masad" <omasad at redhat.com>
> Sent: Sunday, June 30, 2013 3:59:37 PM
> Subject: [Engine-devel] VNIC profiles
> 
> Hi,
> 
> We are working on adding VNIC profiles as part of the work to add VNIC QoS.
> 
> http://www.ovirt.org/Features/Network_QoS#VNIC_Profiles
> 
> We need to define some of the system behavior followed by this change,
> here is my take -
> 
> Editing a profile -
> --------------------
> A user should be able to edit the profile properties (including profile
> name) while VMs are attached and are using this Profile (reference
> should be done by id).
> 
> Changing the network though is a bit more tricky as long as we don't
> have a way to distinguish between running and current configurations I
> think it could be very confusing to the user. Especially since we
> support dynamic wiring so the behavior IMO is unpredictable.
> I think it should be blocked at this point.
> 
> 
> Edit a VNIC / change a VNIC profile -
> ------------------------------------
> Changing the profile a VM is using while the VM is running should behave
> like dynamic wiring (changing the VM network while it is running).
> 
> 
> Remove a Profile -
> -------------------
> Is only valid if all VMs that are using this profile are in status down.

What about HA VMs , are they forced to be down as well for this operation?

> It should update all VMs to point to no profile which should behave like
> none network today.
> 
> I see no reason to support a profile on a none network at this point.
> 
> The above is also relevant for upgrade flow (upgrading none network to
> point to no profile)
> 
> 
> Removing a Network -
> ----------------------
> should remove all profiles on that network
> 
> 
> VM snapshot/import/export -
> --------------------------
> We should handle VMs that are pointing to a network directly for b/w
> compatibility.
> we need to select first profile that is on that network that the user
> has permissions on.
> 
> 
> I assume there are more, comments are welcome
> 
> Thanks, Livnat
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 


From jenkins at ovirt.org  Sun Jun 30 23:02:11 2013
From: jenkins at ovirt.org (Jenkins ci oVirt Server)
Date: Mon, 1 Jul 2013 00:02:11 +0100 (BST)
Subject: [Engine-devel] [oVirt jenkins] Weekly report on open tasks for
	ovirt-engine
Message-ID: <1100143.9610.1372633331964.JavaMail.jenkins@jenkins.ovirt.org>

An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/engine-devel/attachments/20130701/9d7c6d75/attachment.html>