[Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST

[Tomas Jelinek]

----- Original Message -----
> From: "Einav Cohen" <ecohen at redhat.com>
> To: "Tomas Jelinek" <tjelinek at redhat.com>, "Vojtech Szocs" <vszocs at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>, "Michael Pasternak" <mpastern at redhat.com>
> Sent: Thursday, June 27, 2013 6:01:13 PM
> Subject: Re: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
> 
> Hi Tomas,
> 
> > Yes, we can provide the sessionId to authenticate with the REST and the vm
> > guid is not a problem.
> 
> Note that in the web-admin, we already have code that generates REST API
> session-ID;
> this code is being utilized in the ui-plugins infrastructure to allow the
> different
> ui-plugins to communicate with the rest api.
> [one related file is this context is RestApiSessionManager.java in the
> web-admin, not
> sure if there are others]

Yes, I'm aware of that. This is what I had in mind when was talking about passing the SessionId to SPICE.

> 
> maybe the RestApiSessionManager(?) can somehow be utilized for the SPICE
> purpose as well
> (I guess that it will require a couple of code-changes though, and maybe
> worth moving it
> to gwt-common, to allow its utilization from the user portal as well?) -
> @Vojtech would
> probably know best to advise on this.
> 
> * Note: Today:
> (a) a *single* REST API session-ID is generated and used across all
> ui-plugins in the system
> (upon user login to the web-admin).
> 
> (b) this REST-API session-ID is generated based on the *same credentials*
> with which the user
> logged into the web-admin.
> 
> both (a) and (b) will change once [1] will be addressed.

Thank you for mentioning this! I was not aware of this RFE. IIUC the RFE addresses only
UIPlugins with their metadata so in order to integrate this with the SPICE we nee to either
enrich the RFE or to create a UIPlugin which will start the SPICE. I would vote for the second option.
What others?

> Only for the SPICE case in particular - I think that (b) should remain. so

Why only for SPICE? I can imagine UIPlugins which could make use of this option.

> maybe worth allowing
> both same-credentials-login and different-credentials-login in the
> REST-API-Session-ID-generation
> code in the GUI.

This option might make sense also for other UIPlugins so maybe the SPICE integration will not be anything special, just a UIPlugin.

> 
> ----
> Thanks,
> Einav
> 
> [1] Bug 962863 - RFE: Improve REST API integration for UI Plugins
> https://bugzilla.redhat.com/show_bug.cgi?id=962863
> some of the planned changes (from the BZ description):
> """
> ...
> - each UI plugin will have its own dedicated REST API session, unrelated to
> GUI (admin)
> user credentials
> ...
> """
> 
> > ----- Original Message -----
> > From: "Tomas Jelinek" <tjelinek at redhat.com>
> > Sent: Thursday, June 27, 2013 5:50:31 AM
> > 
> > 
> > 
> > ----- Original Message -----
> > > From: "Christophe Fergeau" <cfergeau at redhat.com>
> > > To: "Tomas Jelinek" <tjelinek at redhat.com>
> > > Cc: "Michal Skrivanek" <michal.skrivanek at redhat.com>, "Itamar Heim"
> > > <iheim at redhat.com>,
> > > spice-devel at lists.freedesktop.org, "engine-devel"
> > > <engine-devel at ovirt.org>,
> > > "Marc-André Lureau" <mlureau at redhat.com>
> > > Sent: Thursday, June 27, 2013 11:30:10 AM
> > > Subject: Re: [Engine-devel] [Spice-devel] SPICE Foreign Menu Using REST
> > > 
> > > Hey,
> > > 
> > > On Thu, Jun 27, 2013 at 05:21:11AM -0400, Tomas Jelinek wrote:
> > > > well, it seems that everyone agree that the decision what to add to the
> > > > menu is the client responsibility. It means there is no additional work
> > > > needed on the
> > > > oVirt engine side - going to remove the feature page.
> > > 
> > > If we go the REST API way to handle foreign menu, we need additional info
> > > in the .vv files: some way to auth with the REST API, and the guid of the
> > > VM to act on.
> > Yes, we can provide the sessionId to authenticate with the REST and the vm
> > guid is not a problem.
> > 
> > > 
> > > Christophe
> > > 
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> > 
> >
>