[Engine-devel] Missing vfsType from VDSM conList.

[Alissa Bonas]

----- Original Message -----
> From: snmishra at linux.vnet.ibm.com
> To: engine-devel at ovirt.org
> Sent: Sunday, March 3, 2013 3:34:11 AM
> Subject: [Engine-devel] Missing vfsType from VDSM conList.
> 
> 
> Trying to create a new storage domain using a glusterfs data center.
> The operation is failing because vfsType is not being passed to VDSM.
> Debugging on engine, I can see that Frontend.runActionImpl() is
> called
> with vfsType correctly set but it doesn't seem to reach VDSM. Any
> clues as to what may be causing this behaviour?
> 
> When I run the test with posixfs, I see -
> Thread-169::INFO::2013-03-01
> 11:11:30,889::logUtils::44::dispatcher::(wrapper) Run and protect:
> connectStorageServer(domType=6,
> spUUID='00000000-0000-0000-0000-000000000000', conList=[{'port': '',
> 'connection': 'vm-vdsm-de-1:dpkvol3', 'iqn': '', 'portal': '',
> 'user':
> '', 'vfs_type': 'posixfs', 'password': '******', 'id':
> '00000000-0000-0000-0000-000000000000'}], options=None)
> 
> but with glusterfs, I get -
> Thread-73::INFO::2013-02-27
> 15:40:57,750::logUtils::44::dispatcher::(wrapper) Run and protect:
> connectStorageServer(domType=7,
> spUUID='00000000-0000-0000-0000-000000000000',
> conList=[{'connection':
> 'vm-vdsm-de-1:dpkvol3', 'iqn': '', 'portal': '', 'user': '',
> 'password': '******', 'id': '00000000-0000-0000-0000-000000000000',
> 'port': ''}], options=None)
> 
> 
> Notice that vfsType is not passed in second case.

Hi Sharad, 

I recommend to check/debug these 2 classes: AddStorageServerConnectionCommand and ConnectStorageServerVDSCommand.  
Is the missing type arriving to "AddStorageServerConnectionCommand"  parameters from UI ? 
I'd also recommend to put a breakpoint in method CreateStructFromConnection in class ConnectStorageServerVDSCommand . 
the vfsType is set there before the command is sent to vdsm in an "if" statement, perhaps the condition there is not evaluated to "true", so it doesn't enter the "if" and the vfsType is not set... 
(look for this line inside the if statement : con.putIfNotEmpty("vfs_type", connection.getVfsType());)

> This test was run using the upstream +
> http://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+topic:glusterfs,n,z
> 
> Thanks
> Sharad Mishra
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>