From ukiran770 at yahoo.in Tue Oct 1 03:15:57 2013 From: ukiran770 at yahoo.in (Udaya Kiran P) Date: Tue, 1 Oct 2013 11:15:57 +0800 (SGT) Subject: [Engine-devel] oVirt3.3 - Glance and Neutron Integration In-Reply-To: <415428792.558668.1380539000330.JavaMail.root@redhat.com> References: <1380516320.6878.YahooMailNeo@web193006.mail.sg3.yahoo.com> <84606350.450401.1380525989686.JavaMail.root@redhat.com> <1380526847.70759.YahooMailNeo@web193005.mail.sg3.yahoo.com> <928873806.476333.1380528610243.JavaMail.root@redhat.com> <1380531650.82884.YahooMailNeo@web193001.mail.sg3.yahoo.com> <1351976724.508728.1380532922861.JavaMail.root@redhat.com> <1380535030.90781.YahooMailNeo@web193005.mail.sg3.yahoo.com> <1380536031.90927.YahooMailNeo@web193006.mail.sg3.yahoo.com> <415428792.558668.1380539000330.JavaMail.root@redhat.com> Message-ID: <1380597357.94777.YahooMailNeo@web193003.mail.sg3.yahoo.com> Hi Mike, Thanks much for all your inputs. Now, that should help me resolve all the confusions. I will get back in case if I have any queries. Thank You, Regards, Udaya Kiran ________________________________ > >Hi Mike, Hi Udaya, > >Please find attached the screenshots for, > > >1. yum provides ovirt-engine > >2. /etc/yum.repos.d/ovirt.repo > > >Please correct me if some settings has to be changed. As you can see the package you have installed is from ovirt-nightly repo. The timestamp indicates it's rather old - 20130624021657 means it's from 02:16:57 24/06/2013 This is a development version which didn't have those features fully availabe yet. Also you can see the package is for f18 - Fedora 18. From the download page (http://www.ovirt.org/Download) you can see that Fedora 19 is required. I'm rather sure that Fedora 18 is not supported for 3.3, so my best suggestion would be to either upgrade the machine or try on a new machine. If you upgrade, I'd advise backing up first as fedora upgrade sometimes results (at least for me) in a non-booting disk. Regards, Mike > >Thank You. > > >Regards, >Udaya Kiran > > > > > >________________________________ > > > >Hi Mike, > > >Sounds good. > > >I am eager to know if the Integration is complete for Glance and Cinder in oVirt3.3? > > >Thank You. > > >Regards, >Udaya Kiran > > > >________________________________ > > >> >>Hi Mike, >Hi Udaya, > > >> >> >> >>Thank You for the quick update on this. >Happy to help, responses inline. > > >> >>Is there any restriction on installing the Neutron server? Should that be installed in the oVirt Engine machine or on the machines which host the openstack services - Compute, Network, Controller? >The neutron server itself can be installed on the same machine as engine, just make sure not to install horizon there so it won't mess up your oVirt web admin (haven't tried, but I guess they might not play well together).. > > >> >>Thank You, >> >> >> >>Regards, >>Udaya Kiran >> >> >> >> >>________________________________ >> >> >>> >>>Hi Mike, >>> >>> >>>Thank You for your inputs and update. >>> >>> >>> >>>I am trying to integrate oVirt3.3 (stable - http://ovirt.org/releases/stable/rpm/Fedora/$releasever/) with OpenStack. >>> >>> >>> >>>I am not able to see the web interface?for adding Neutron as an external provider as?specified in the deep dive presentation. >>> >>> >>> >>>Deep Dive Presentation - http://www.ovirt.org/images/e/e7/Ovirt-neutron-integration-deep-dive-2013.pdf >>> >>> >>>I have attached the screenshots of my oVirt3.3 setup. >>This looks like a very old interface that we had while developing the integration, not the final version (that's what you see in the deep dive). >Well, I just installed ovirt from 3.3 and I see the new interface as you posted in the screenshot from the deep dive. > > > >Can you please make sure this is what is installed? > > > >[root at localhost ~]# yum provides ovirt-engine >Loaded plugins: langpacks, refresh-packagekit, versionlock >ovirt-engine-3.3.0-4.fc19.noarch : Management server for Open Virtualization >Repo??????? : ovirt-stable > > > > >> >> >>> >>>Please correct me if using the wrong repository for oVirt3.3. >>Let me install oVirt 3.3 that was published and get back to you on this. >> >> >>> >>>Also, where the Neutron Server should be configured? Is it at the openstack end or at the oVirt end? >>I'm not sure what you mean by this, can you please elaborate? >> >> >>> >>>Thank You. >>> >>> >>>Regards, >>> >>>Udaya Kiran >>> >>> >>> >>>________________________________ >>> >>>Hi Everyone, >>>Hi Udaya, >>> >>> >>>> >>>>Does oVirt3.3 version support Glance and Neutron Integration.? >>>Yes, the version supports these features. >>> >>> >>>> >>>>Can anybody give me few inputs on the current status of these integrations? >>> >>>> >>>>http://www.ovirt.org/OVirt_3.3_release_announcement >>>> >>>>http://www.ovirt.org/Features/Detailed_OSN_Integration >>>> >>>I can say for Neutron that 1st phase is in - you can create a "Neutron" network in oVirt and attach it and use it in your VMs. >>>The supported plugins are Linux Bridge & OVS. >>> >>>There was an issue raised on the users list that the port is not persisted across VM boots, which we will iron out ASAP. >>> >>> >>>> >>>> >>>> >>>>Thank You. >>>> >>>> >>>>Regards, >>>>Udaya Kiran >>>>_______________________________________________ >>>>Engine-devel mailing list >>>>Engine-devel at ovirt.org >>>>http://lists.ovirt.org/mailman/listinfo/engine-devel >>>> >>> >>> >>> >>> >>> >> >> >> >> >> > > > > > > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From ukiran770 at yahoo.in Tue Oct 1 03:22:36 2013 From: ukiran770 at yahoo.in (Udaya Kiran P) Date: Tue, 1 Oct 2013 11:22:36 +0800 (SGT) Subject: [Engine-devel] oVirt3.3 - Glance and Neutron Integration In-Reply-To: <52496CD2.5080906@redhat.com> References: <1380516320.6878.YahooMailNeo@web193006.mail.sg3.yahoo.com> <84606350.450401.1380525989686.JavaMail.root@redhat.com> <1380526847.70759.YahooMailNeo@web193005.mail.sg3.yahoo.com> <928873806.476333.1380528610243.JavaMail.root@redhat.com> <1380531650.82884.YahooMailNeo@web193001.mail.sg3.yahoo.com> <1351976724.508728.1380532922861.JavaMail.root@redhat.com> <1380535030.90781.YahooMailNeo@web193005.mail.sg3.yahoo.com> <52496CD2.5080906@redhat.com> Message-ID: <1380597756.63797.YahooMailNeo@web193001.mail.sg3.yahoo.com> Hi Itamar, Thank You for the input. Regards, Udaya Kiran ________________________________ On 09/30/2013 12:57 PM, Udaya Kiran P wrote: > Hi Mike, > > Sounds good. > > I am eager to know if the Integration is complete for Glance and Cinder > in oVirt3.3? glance is also in, cinder is not. federico can provide more info if you have issues with glance, but first please install the GA'd version of ovirt > > Thank You. > > Regards, > Udaya Kiran > > ------------------------------------------------------------------------ > > >? ? Hi Mike, > > Hi Udaya, > > > >? ? Thank You for the quick update on this. > > Happy to help, responses inline. > > >? ? Is there any restriction on installing the Neutron server? Should >? ? that be installed in the oVirt Engine machine or on the machines >? ? which host the openstack services - Compute, Network, Controller? > > The neutron server itself can be installed on the same machine as > engine, just make sure not to install horizon there so it won't mess up > your oVirt web admin (haven't tried, but I guess they might not play > well together).. > > >? ? Thank You, > >? ? Regards, >? ? Udaya Kiran > > >? ? ------------------------------------------------------------------------ > > >? ? ? ? Hi Mike, > >? ? ? ? Thank You for your inputs and update. > >? ? ? ? I am trying to integrate oVirt3.3 (stable - >? ? ? ? http://ovirt.org/releases/stable/rpm/Fedora/$releasever/) with >? ? ? ? OpenStack. > >? ? ? ? I am not able to see the web interface for adding Neutron as an >? ? ? ? external provider as specified in the deep dive presentation. > >? ? ? ? Deep Dive Presentation - >? ? ? ? http://www.ovirt.org/images/e/e7/Ovirt-neutron-integration-deep-dive-2013.pdf > >? ? ? ? I have attached the screenshots of my oVirt3.3 setup. > >? ? This looks like a very old interface that we had while developing >? ? the integration, not the final version (that's what you see in the >? ? deep dive). > > Well, I just installed ovirt from 3.3 and I see the new interface as you > posted in the screenshot from the deep dive. > > Can you please make sure this is what is installed? > > [root at localhost ~]# yum provides ovirt-engine > Loaded plugins: langpacks, refresh-packagekit, versionlock > ovirt-engine-3.3.0-4.fc19.noarch : Management server for Open Virtualization > Repo? ? ? ? : ovirt-stable > > > >? ? ? ? Please correct me if using the wrong repository for oVirt3.3. > >? ? Let me install oVirt 3.3 that was published and get back to you on this. > > >? ? ? ? Also, where the Neutron Server should be configured? Is it at >? ? ? ? the openstack end or at the oVirt end? > >? ? I'm not sure what you mean by this, can you please elaborate? > > >? ? ? ? Thank You. > >? ? ? ? Regards, >? ? ? ? Udaya Kiran > >? ? ? ? ------------------------------------------------------------------------ > >? ? ? ? ? ? Hi Everyone, > >? ? ? ? Hi Udaya, > > >? ? ? ? ? ? Does oVirt3.3 version support Glance and Neutron Integration.? > >? ? ? ? Yes, the version supports these features. > > >? ? ? ? ? ? Can anybody give me few inputs on the current status of >? ? ? ? ? ? these integrations? > > >? ? ? ? ? ? http://www.ovirt.org/OVirt_3.3_release_announcement >? ? ? ? ? ? http://www.ovirt.org/Features/Detailed_OSN_Integration > >? ? ? ? I can say for Neutron that 1st phase is in - you can create a >? ? ? ? "Neutron" network in oVirt and attach it and use it in your VMs. >? ? ? ? The supported plugins are Linux Bridge & OVS. >? ? ? ? There was an issue raised on the users list that the port is not >? ? ? ? persisted across VM boots, which we will iron out ASAP. > > > >? ? ? ? ? ? Thank You. > >? ? ? ? ? ? Regards, >? ? ? ? ? ? Udaya Kiran > >? ? ? ? ? ? _______________________________________________ >? ? ? ? ? ? Engine-devel mailing list >? ? ? ? ? ? Engine-devel at ovirt.org >? ? ? ? ? ? http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > > > > > > > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > -------------- next part -------------- An HTML attachment was scrubbed... URL: From ukiran770 at yahoo.in Tue Oct 1 06:29:05 2013 From: ukiran770 at yahoo.in (Udaya Kiran P) Date: Tue, 1 Oct 2013 14:29:05 +0800 (SGT) Subject: [Engine-devel] oVirt3.3 - Glance and Neutron Integration In-Reply-To: <1380597357.94777.YahooMailNeo@web193003.mail.sg3.yahoo.com> References: <1380516320.6878.YahooMailNeo@web193006.mail.sg3.yahoo.com> <84606350.450401.1380525989686.JavaMail.root@redhat.com> <1380526847.70759.YahooMailNeo@web193005.mail.sg3.yahoo.com> <928873806.476333.1380528610243.JavaMail.root@redhat.com> <1380531650.82884.YahooMailNeo@web193001.mail.sg3.yahoo.com> <1351976724.508728.1380532922861.JavaMail.root@redhat.com> <1380535030.90781.YahooMailNeo@web193005.mail.sg3.yahoo.com> <1380536031.90927.YahooMailNeo@web193006.mail.sg3.yahoo.com> <415428792.558668.1380539000330.JavaMail.root@redhat.com> <1380597357.94777.YahooMailNeo@web193003.mail.sg3.yahoo.com> Message-ID: <1380608945.91549.YahooMailNeo@web193002.mail.sg3.yahoo.com> Hi Mike, When I tried with Fedora 19, setup failed with below error. I have attached the screenshot. ?"Failed to execute stage 'Misc configuration': Command '/bin/systemctl' failed to execute" Here is what I did: 1. Installed a fedora 19 on a new machine 2.?yum -y update 3. yum localinstall http://ovirt.org/releases/ovirt-release-fedora.noarch.rpm 4. yum -y install ovirt-engine 5. engine-setup I found a bug reported in bugzilla in the below link, yet I am not sure how to fix this. https://bugzilla.redhat.com/show_bug.cgi?id=990980 Please suggest. Regards, Udaya Kiran ________________________________ Hi Mike, Thanks much for all your inputs. Now, that should help me resolve all the confusions. I will get back in case if I have any queries. Thank You, Regards, Udaya Kiran ________________________________ > >Hi Mike, Hi Udaya, > >Please find attached the screenshots for, > > >1. yum provides ovirt-engine > >2. /etc/yum.repos.d/ovirt.repo > > >Please correct me if some settings has to be changed. As you can see the package you have installed is from ovirt-nightly repo. The timestamp indicates it's rather old - 20130624021657 means it's from 02:16:57 24/06/2013 This is a development version which didn't have those features fully availabe yet. Also you can see the package is for f18 - Fedora 18. From the download page (http://www.ovirt.org/Download) you can see that Fedora 19 is required. I'm rather sure that Fedora 18 is not supported for 3.3, so my best suggestion would be to either upgrade the machine or try on a new machine. If you upgrade, I'd advise backing up first as fedora upgrade sometimes results (at least for me) in a non-booting disk. Regards, Mike > >Thank You. > > >Regards, >Udaya Kiran > > > > > >________________________________ > > > >Hi Mike, > > >Sounds good. > > >I am eager to know if the Integration is complete for Glance and Cinder in oVirt3.3? > > >Thank You. > > >Regards, >Udaya Kiran > > > >________________________________ > > >> >>Hi Mike, >Hi Udaya, > > >> >> >> >>Thank You for the quick update on this. >Happy to help, responses inline. > > >> >>Is there any restriction on installing the Neutron server? Should that be installed in the oVirt Engine machine or on the machines which host the openstack services - Compute, Network, Controller? >The neutron server itself can be installed on the same machine as engine, just make sure not to install horizon there so it won't mess up your oVirt web admin (haven't tried, but I guess they might not play well together).. > > >> >>Thank You, >> >> >> >>Regards, >>Udaya Kiran >> >> >> >> >>________________________________ >> >> >>> >>>Hi Mike, >>> >>> >>>Thank You for your inputs and update. >>> >>> >>> >>>I am trying to integrate oVirt3.3 (stable - http://ovirt.org/releases/stable/rpm/Fedora/$releasever/) with OpenStack. >>> >>> >>> >>>I am not able to see the web interface?for adding Neutron as an external provider as?specified in the deep dive presentation. >>> >>> >>> >>>Deep Dive Presentation - http://www.ovirt.org/images/e/e7/Ovirt-neutron-integration-deep-dive-2013.pdf >>> >>> >>>I have attached the screenshots of my oVirt3.3 setup. >>This looks like a very old interface that we had while developing the integration, not the final version (that's what you see in the deep dive). >Well, I just installed ovirt from 3.3 and I see the new interface as you posted in the screenshot from the deep dive. > > > >Can you please make sure this is what is installed? > > > >[root at localhost ~]# yum provides ovirt-engine >Loaded plugins: langpacks, refresh-packagekit, versionlock >ovirt-engine-3.3.0-4.fc19.noarch : Management server for Open Virtualization >Repo??????? : ovirt-stable > > > > >> >> >>> >>>Please correct me if using the wrong repository for oVirt3.3. >>Let me install oVirt 3.3 that was published and get back to you on this. >> >> >>> >>>Also, where the Neutron Server should be configured? Is it at the openstack end or at the oVirt end? >>I'm not sure what you mean by this, can you please elaborate? >> >> >>> >>>Thank You. >>> >>> >>>Regards, >>> >>>Udaya Kiran >>> >>> >>> >>>________________________________ >>> >>>Hi Everyone, >>>Hi Udaya, >>> >>> >>>> >>>>Does oVirt3.3 version support Glance and Neutron Integration.? >>>Yes, the version supports these features. >>> >>> >>>> >>>>Can anybody give me few inputs on the current status of these integrations? >>> >>>> >>>>http://www.ovirt.org/OVirt_3.3_release_announcement >>>> >>>>http://www.ovirt.org/Features/Detailed_OSN_Integration >>>> >>>I can say for Neutron that 1st phase is in - you can create a "Neutron" network in oVirt and attach it and use it in your VMs. >>>The supported plugins are Linux Bridge & OVS. >>> >>>There was an issue raised on the users list that the port is not persisted across VM boots, which we will iron out ASAP. >>> >>> >>>> >>>> >>>> >>>>Thank You. >>>> >>>> >>>>Regards, >>>>Udaya Kiran >>>>_______________________________________________ >>>>Engine-devel mailing list >>>>Engine-devel at ovirt.org >>>>http://lists.ovirt.org/mailman/listinfo/engine-devel >>>> >>> >>> >>> >>> >>> >> >> >> >> >> > > > > > > > > _______________________________________________ Engine-devel mailing list Engine-devel at ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: Fed_19.png Type: image/png Size: 37657 bytes Desc: not available URL: From mkolesni at redhat.com Tue Oct 1 06:40:29 2013 From: mkolesni at redhat.com (Mike Kolesnik) Date: Tue, 1 Oct 2013 02:40:29 -0400 (EDT) Subject: [Engine-devel] oVirt3.3 - Glance and Neutron Integration In-Reply-To: <1380608945.91549.YahooMailNeo@web193002.mail.sg3.yahoo.com> References: <1380516320.6878.YahooMailNeo@web193006.mail.sg3.yahoo.com> <1380531650.82884.YahooMailNeo@web193001.mail.sg3.yahoo.com> <1351976724.508728.1380532922861.JavaMail.root@redhat.com> <1380535030.90781.YahooMailNeo@web193005.mail.sg3.yahoo.com> <1380536031.90927.YahooMailNeo@web193006.mail.sg3.yahoo.com> <415428792.558668.1380539000330.JavaMail.root@redhat.com> <1380597357.94777.YahooMailNeo@web193003.mail.sg3.yahoo.com> <1380608945.91549.YahooMailNeo@web193002.mail.sg3.yahoo.com> Message-ID: <1427681989.1085191.1380609629682.JavaMail.root@redhat.com> ----- Original Message ----- > Hi Mike, Hi Udaya, > When I tried with Fedora 19, setup failed with below error. I have attached > the screenshot. > "Failed to execute stage 'Misc configuration': Command '/bin/systemctl' > failed to execute" Please attach the relevant info from the log file that the setup generated (the location is listed after "Clean up" stage). > Here is what I did: > 1. Installed a fedora 19 on a new machine > 2. yum -y update > 3. yum localinstall http://ovirt.org/releases/ovirt-release-fedora.noarch.rpm > 4. yum -y install ovirt-engine > 5. engine-setup > I found a bug reported in bugzilla in the below link, yet I am not sure how > to fix this. > https://bugzilla.redhat.com/show_bug.cgi?id=990980 Not sure if this is the problem, since this bug's fix should be in the GA version.. > Please suggest. > Regards, > Udaya Kiran > Hi Mike, > Thanks much for all your inputs. > Now, that should help me resolve all the confusions. > I will get back in case if I have any queries. > Thank You, > Regards, > Udaya Kiran > > Hi Mike, > > Hi Udaya, > > Please find attached the screenshots for, > > > 1. yum provides ovirt-engine > > > 2. /etc/yum.repos.d/ovirt.repo > > > Please correct me if some settings has to be changed. > > As you can see the package you have installed is from ovirt-nightly repo. > The timestamp indicates it's rather old - 20130624021657 means it's from > 02:16:57 24/06/2013 > This is a development version which didn't have those features fully availabe > yet. > Also you can see the package is for f18 - Fedora 18. > From the download page ( http://www.ovirt.org/Download ) you can see that > Fedora 19 is required. > I'm rather sure that Fedora 18 is not supported for 3.3, > so my best suggestion would be to either upgrade the machine or try on a new > machine. > If you upgrade, I'd advise backing up first as fedora upgrade sometimes > results (at least for me) in a non-booting disk. > Regards, > Mike > > Thank You. > > > Regards, > > > Udaya Kiran > > > Hi Mike, > > > Sounds good. > > > I am eager to know if the Integration is complete for Glance and Cinder in > > oVirt3.3? > > > Thank You. > > > Regards, > > > Udaya Kiran > > > > Hi Mike, > > > > > Hi Udaya, > > > > Thank You for the quick update on this. > > > > > Happy to help, responses inline. > > > > Is there any restriction on installing the Neutron server? Should that be > > > installed in the oVirt Engine machine or on the machines which host the > > > openstack services - Compute, Network, Controller? > > > > > The neutron server itself can be installed on the same machine as engine, > > just make sure not to install horizon there so it won't mess up your oVirt > > web admin (haven't tried, but I guess they might not play well together).. > > > > Thank You, > > > > > > Regards, > > > > > > Udaya Kiran > > > > > > > Hi Mike, > > > > > > > > > > Thank You for your inputs and update. > > > > > > > > > > I am trying to integrate oVirt3.3 (stable - > > > > http://ovirt.org/releases/stable/rpm/Fedora/$releasever/ ) with > > > > OpenStack. > > > > > > > > > > I am not able to see the web interface for adding Neutron as an > > > > external > > > > provider as specified in the deep dive presentation. > > > > > > > > > > Deep Dive Presentation - > > > > http://www.ovirt.org/images/e/e7/Ovirt-neutron-integration-deep-dive-2013.pdf > > > > > > > > > > I have attached the screenshots of my oVirt3.3 setup. > > > > > > > > > This looks like a very old interface that we had while developing the > > > integration, not the final version (that's what you see in the deep > > > dive). > > > > > Well, I just installed ovirt from 3.3 and I see the new interface as you > > posted in the screenshot from the deep dive. > > > Can you please make sure this is what is installed? > > > [root at localhost ~]# yum provides ovirt-engine > > > Loaded plugins: langpacks, refresh-packagekit, versionlock > > > ovirt-engine-3.3.0-4.fc19.noarch : Management server for Open > > Virtualization > > > Repo : ovirt-stable > > > > > Please correct me if using the wrong repository for oVirt3.3. > > > > > > > > > Let me install oVirt 3.3 that was published and get back to you on this. > > > > > > > Also, where the Neutron Server should be configured? Is it at the > > > > openstack > > > > end or at the oVirt end? > > > > > > > > > I'm not sure what you mean by this, can you please elaborate? > > > > > > > Thank You. > > > > > > > > > > Regards, > > > > > > > > > > Udaya Kiran > > > > > > > > > > > Hi Everyone, > > > > > > > > > > > > > > Hi Udaya, > > > > > > > > > > > Does oVirt3.3 version support Glance and Neutron Integration.? > > > > > > > > > > > > > > Yes, the version supports these features. > > > > > > > > > > > Can anybody give me few inputs on the current status of these > > > > > integrations? > > > > > > > > > > > > > > > http://www.ovirt.org/OVirt_3.3_release_announcement > > > > > > > > > > > > > > > http://www.ovirt.org/Features/Detailed_OSN_Integration > > > > > > > > > > > > > > I can say for Neutron that 1st phase is in - you can create a "Neutron" > > > > network in oVirt and attach it and use it in your VMs. > > > > > > > > > > The supported plugins are Linux Bridge & OVS. > > > > > > > > > > There was an issue raised on the users list that the port is not > > > > persisted > > > > across VM boots, which we will iron out ASAP. > > > > > > > > > > > Thank You. > > > > > > > > > > > > > > > Regards, > > > > > > > > > > > > > > > Udaya Kiran > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > > > > > > > > > Engine-devel mailing list > > > > > > > > > > > > > > > Engine-devel at ovirt.org > > > > > > > > > > > > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > > > > > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel -------------- next part -------------- An HTML attachment was scrubbed... URL: From ukiran770 at yahoo.in Tue Oct 1 06:57:14 2013 From: ukiran770 at yahoo.in (Udaya Kiran P) Date: Tue, 1 Oct 2013 14:57:14 +0800 (SGT) Subject: [Engine-devel] oVirt3.3 - Glance and Neutron Integration In-Reply-To: <1427681989.1085191.1380609629682.JavaMail.root@redhat.com> References: <1380516320.6878.YahooMailNeo@web193006.mail.sg3.yahoo.com> <1380531650.82884.YahooMailNeo@web193001.mail.sg3.yahoo.com> <1351976724.508728.1380532922861.JavaMail.root@redhat.com> <1380535030.90781.YahooMailNeo@web193005.mail.sg3.yahoo.com> <1380536031.90927.YahooMailNeo@web193006.mail.sg3.yahoo.com> <415428792.558668.1380539000330.JavaMail.root@redhat.com> <1380597357.94777.YahooMailNeo@web193003.mail.sg3.yahoo.com> <1380608945.91549.YahooMailNeo@web193002.mail.sg3.yahoo.com> <1427681989.1085191.1380609629682.JavaMail.root@redhat.com> Message-ID: <1380610634.65641.YahooMailNeo@web193003.mail.sg3.yahoo.com> Hi Mike, I was able to fix the error. Steps: 1. ?The log had the message, DEBUG otopi.plugins.otopi.services.systemd plugin.execute:446 execute-output: ('/bin/systemctl', 'start', 'postgresql.service') stderr: Job for postgresql.service failed. See 'systemctl status postgresql.service' and 'journalctl -xn' for details. 2.?systemctl status postgresql.service Failed. (?PostgreSQL's request for a shared memory segment exceeded your kernel's SHMMAX?) 3.?vi /etc/sysctl.conf kernel.shmmax = 41943040 4.?sysctl -p 5.?engine-setup and this time setup was successful..!! Thanks much. Regards, Udaya Kiran ________________________________ > >Hi Mike, Hi Udaya, > >When I tried with Fedora 19, setup failed with below error. I have attached the screenshot. > > >?"Failed to execute stage 'Misc configuration': Command '/bin/systemctl' failed to execute" Please attach the relevant info from the log file that the setup generated (the location is listed after "Clean up" stage). > > > >Here is what I did: > > >1. Installed a fedora 19 on a new machine >2.?yum -y update >3. yum localinstall http://ovirt.org/releases/ovirt-release-fedora.noarch.rpm >4. yum -y install ovirt-engine >5. engine-setup > > >I found a bug reported in bugzilla in the below link, yet I am not sure how to fix this. > > >https://bugzilla.redhat.com/show_bug.cgi?id=990980 Not sure if this is the problem, since this bug's fix should be in the GA version.. > > > >Please suggest. > > >Regards, >Udaya Kiran > > > > > >________________________________ > >Hi Mike, > > > >Thanks much for all your inputs. >Now, that should help me resolve all the confusions. > > >I will get back in case if I have any queries. > > >Thank You, > > >Regards, > >Udaya Kiran > > > > > >________________________________ > > >> >>Hi Mike, >Hi Udaya, > > >> >>Please find attached the screenshots for, >> >> >>1. yum provides ovirt-engine >> >>2. /etc/yum.repos.d/ovirt.repo >> >> >>Please correct me if some settings has to be changed. >As you can see the package you have installed is from ovirt-nightly repo. > >The timestamp indicates it's rather old - 20130624021657 means it's from 02:16:57 24/06/2013 > >This is a development version which didn't have those features fully availabe yet. > > > >Also you can see the package is for f18 - Fedora 18. >From the download page (http://www.ovirt.org/Download) you can see that Fedora 19 is required. > >I'm rather sure that Fedora 18 is not supported for 3.3, >so my best suggestion would be to either upgrade the machine or try on a new machine. > >If you upgrade, I'd advise backing up first as fedora upgrade sometimes results (at least for me) in a non-booting disk. > > > >Regards, > >Mike > > >> >>Thank You. >> >> >>Regards, >>Udaya Kiran >> >> >> >> >> >>________________________________ >> >> >> >>Hi Mike, >> >> >>Sounds good. >> >> >>I am eager to know if the Integration is complete for Glance and Cinder in oVirt3.3? >> >> >>Thank You. >> >> >>Regards, >>Udaya Kiran >> >> >> >>________________________________ >> >> >>> >>>Hi Mike, >>Hi Udaya, >> >> >>> >>> >>> >>>Thank You for the quick update on this. >>Happy to help, responses inline. >> >> >>> >>>Is there any restriction on installing the Neutron server? Should that be installed in the oVirt Engine machine or on the machines which host the openstack services - Compute, Network, Controller? >>The neutron server itself can be installed on the same machine as engine, just make sure not to install horizon there so it won't mess up your oVirt web admin (haven't tried, but I guess they might not play well together).. >> >> >>> >>>Thank You, >>> >>> >>> >>>Regards, >>>Udaya Kiran >>> >>> >>> >>> >>>________________________________ >>> >>> >>>> >>>>Hi Mike, >>>> >>>> >>>>Thank You for your inputs and update. >>>> >>>> >>>> >>>>I am trying to integrate oVirt3.3 (stable - http://ovirt.org/releases/stable/rpm/Fedora/$releasever/) with OpenStack. >>>> >>>> >>>> >>>>I am not able to see the web interface?for adding Neutron as an external provider as?specified in the deep dive presentation. >>>> >>>> >>>> >>>>Deep Dive Presentation - http://www.ovirt.org/images/e/e7/Ovirt-neutron-integration-deep-dive-2013.pdf >>>> >>>> >>>>I have attached the screenshots of my oVirt3.3 setup. >>>This looks like a very old interface that we had while developing the integration, not the final version (that's what you see in the deep dive). >>Well, I just installed ovirt from 3.3 and I see the new interface as you posted in the screenshot from the deep dive. >> >> >> >>Can you please make sure this is what is installed? >> >> >> >>[root at localhost ~]# yum provides ovirt-engine >>Loaded plugins: langpacks, refresh-packagekit, versionlock >>ovirt-engine-3.3.0-4.fc19.noarch : Management server for Open Virtualization >>Repo??????? : ovirt-stable >> >> >> >> >>> >>> >>>> >>>>Please correct me if using the wrong repository for oVirt3.3. >>>Let me install oVirt 3.3 that was published and get back to you on this. >>> >>> >>>> >>>>Also, where the Neutron Server should be configured? Is it at the openstack end or at the oVirt end? >>>I'm not sure what you mean by this, can you please elaborate? >>> >>> >>>> >>>>Thank You. >>>> >>>> >>>>Regards, >>>> >>>>Udaya Kiran >>>> >>>> >>>> >>>>________________________________ >>>> >>>>Hi Everyone, >>>>Hi Udaya, >>>> >>>> >>>>> >>>>>Does oVirt3.3 version support Glance and Neutron Integration.? >>>>Yes, the version supports these features. >>>> >>>> >>>>> >>>>>Can anybody give me few inputs on the current status of these integrations? >>>> >>>>> >>>>>http://www.ovirt.org/OVirt_3.3_release_announcement >>>>> >>>>>http://www.ovirt.org/Features/Detailed_OSN_Integration >>>>> >>>>I can say for Neutron that 1st phase is in - you can create a "Neutron" network in oVirt and attach it and use it in your VMs. >>>>The supported plugins are Linux Bridge & OVS. >>>> >>>>There was an issue raised on the users list that the port is not persisted across VM boots, which we will iron out ASAP. >>>> >>>> >>>>> >>>>> >>>>> >>>>>Thank You. >>>>> >>>>> >>>>>Regards, >>>>>Udaya Kiran >>>>>_______________________________________________ >>>>>Engine-devel mailing list >>>>>Engine-devel at ovirt.org >>>>>http://lists.ovirt.org/mailman/listinfo/engine-devel >>>>> >>>> >>>> >>>> >>>> >>>> >>> >>> >>> >>> >>> >> >> >> >> >> >> >> >> > > > > > >_______________________________________________ >Engine-devel mailing list >Engine-devel at ovirt.org >http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From mkolesni at redhat.com Tue Oct 1 07:45:07 2013 From: mkolesni at redhat.com (Mike Kolesnik) Date: Tue, 1 Oct 2013 03:45:07 -0400 (EDT) Subject: [Engine-devel] oVirt3.3 - Glance and Neutron Integration In-Reply-To: <1380610634.65641.YahooMailNeo@web193003.mail.sg3.yahoo.com> References: <1380516320.6878.YahooMailNeo@web193006.mail.sg3.yahoo.com> <1380535030.90781.YahooMailNeo@web193005.mail.sg3.yahoo.com> <1380536031.90927.YahooMailNeo@web193006.mail.sg3.yahoo.com> <415428792.558668.1380539000330.JavaMail.root@redhat.com> <1380597357.94777.YahooMailNeo@web193003.mail.sg3.yahoo.com> <1380608945.91549.YahooMailNeo@web193002.mail.sg3.yahoo.com> <1427681989.1085191.1380609629682.JavaMail.root@redhat.com> <1380610634.65641.YahooMailNeo@web193003.mail.sg3.yahoo.com> Message-ID: <283319186.1124456.1380613507971.JavaMail.root@redhat.com> ----- Original Message ----- > Hi Mike, Hi Udaya, > I was able to fix the error. > Steps: > 1. The log had the message, > DEBUG otopi.plugins.otopi.services.systemd plugin.execute:446 execute-output: > ('/bin/systemctl', 'start', 'postgresql.service') stderr: > Job for postgresql.service failed. See 'systemctl status postgresql.service' > and 'journalctl -xn' for details. > 2. systemctl status postgresql.service > Failed. ( PostgreSQL's request for a shared memory segment exceeded your > kernel's SHMMAX ) > 3. vi /etc/sysctl.conf > kernel.shmmax = 41943040 > 4. sysctl -p > 5. engine-setup > and this time setup was successful..!! Happy to hear that! > Thanks much. Glad to help. Regards, Mike > Regards, > Udaya Kiran > > Hi Mike, > > Hi Udaya, > > When I tried with Fedora 19, setup failed with below error. I have attached > > the screenshot. > > > "Failed to execute stage 'Misc configuration': Command '/bin/systemctl' > > failed to execute" > > Please attach the relevant info from the log file that the setup generated > (the location is listed after "Clean up" stage). > > Here is what I did: > > > 1. Installed a fedora 19 on a new machine > > > 2. yum -y update > > > 3. yum localinstall > > http://ovirt.org/releases/ovirt-release-fedora.noarch.rpm > > > 4. yum -y install ovirt-engine > > > 5. engine-setup > > > I found a bug reported in bugzilla in the below link, yet I am not sure how > > to fix this. > > > https://bugzilla.redhat.com/show_bug.cgi?id=990980 > > Not sure if this is the problem, since this bug's fix should be in the GA > version.. > > Please suggest. > > > Regards, > > > Udaya Kiran > > > Hi Mike, > > > Thanks much for all your inputs. > > > Now, that should help me resolve all the confusions. > > > I will get back in case if I have any queries. > > > Thank You, > > > Regards, > > > Udaya Kiran > > > > Hi Mike, > > > > > Hi Udaya, > > > > Please find attached the screenshots for, > > > > > > 1. yum provides ovirt-engine > > > > > > 2. /etc/yum.repos.d/ovirt.repo > > > > > > Please correct me if some settings has to be changed. > > > > > As you can see the package you have installed is from ovirt-nightly repo. > > > The timestamp indicates it's rather old - 20130624021657 means it's from > > 02:16:57 24/06/2013 > > > This is a development version which didn't have those features fully > > availabe > > yet. > > > Also you can see the package is for f18 - Fedora 18. > > > From the download page ( http://www.ovirt.org/Download ) you can see that > > Fedora 19 is required. > > > I'm rather sure that Fedora 18 is not supported for 3.3, > > > so my best suggestion would be to either upgrade the machine or try on a > > new > > machine. > > > If you upgrade, I'd advise backing up first as fedora upgrade sometimes > > results (at least for me) in a non-booting disk. > > > Regards, > > > Mike > > > > Thank You. > > > > > > Regards, > > > > > > Udaya Kiran > > > > > > Hi Mike, > > > > > > Sounds good. > > > > > > I am eager to know if the Integration is complete for Glance and Cinder > > > in > > > oVirt3.3? > > > > > > Thank You. > > > > > > Regards, > > > > > > Udaya Kiran > > > > > > > Hi Mike, > > > > > > > > > Hi Udaya, > > > > > > > Thank You for the quick update on this. > > > > > > > > > Happy to help, responses inline. > > > > > > > Is there any restriction on installing the Neutron server? Should that > > > > be > > > > installed in the oVirt Engine machine or on the machines which host the > > > > openstack services - Compute, Network, Controller? > > > > > > > > > The neutron server itself can be installed on the same machine as engine, > > > just make sure not to install horizon there so it won't mess up your > > > oVirt > > > web admin (haven't tried, but I guess they might not play well > > > together).. > > > > > > > Thank You, > > > > > > > > > > Regards, > > > > > > > > > > Udaya Kiran > > > > > > > > > > > Hi Mike, > > > > > > > > > > > > > > > Thank You for your inputs and update. > > > > > > > > > > > > > > > I am trying to integrate oVirt3.3 (stable - > > > > > http://ovirt.org/releases/stable/rpm/Fedora/$releasever/ ) with > > > > > OpenStack. > > > > > > > > > > > > > > > I am not able to see the web interface for adding Neutron as an > > > > > external > > > > > provider as specified in the deep dive presentation. > > > > > > > > > > > > > > > Deep Dive Presentation - > > > > > http://www.ovirt.org/images/e/e7/Ovirt-neutron-integration-deep-dive-2013.pdf > > > > > > > > > > > > > > > I have attached the screenshots of my oVirt3.3 setup. > > > > > > > > > > > > > > This looks like a very old interface that we had while developing the > > > > integration, not the final version (that's what you see in the deep > > > > dive). > > > > > > > > > Well, I just installed ovirt from 3.3 and I see the new interface as you > > > posted in the screenshot from the deep dive. > > > > > > Can you please make sure this is what is installed? > > > > > > [root at localhost ~]# yum provides ovirt-engine > > > > > > Loaded plugins: langpacks, refresh-packagekit, versionlock > > > > > > ovirt-engine-3.3.0-4.fc19.noarch : Management server for Open > > > Virtualization > > > > > > Repo : ovirt-stable > > > > > > > > Please correct me if using the wrong repository for oVirt3.3. > > > > > > > > > > > > > > Let me install oVirt 3.3 that was published and get back to you on > > > > this. > > > > > > > > > > > Also, where the Neutron Server should be configured? Is it at the > > > > > openstack > > > > > end or at the oVirt end? > > > > > > > > > > > > > > I'm not sure what you mean by this, can you please elaborate? > > > > > > > > > > > Thank You. > > > > > > > > > > > > > > > Regards, > > > > > > > > > > > > > > > Udaya Kiran > > > > > > > > > > > > > > > > Hi Everyone, > > > > > > > > > > > > > > > > > > > > Hi Udaya, > > > > > > > > > > > > > > > > Does oVirt3.3 version support Glance and Neutron Integration.? > > > > > > > > > > > > > > > > > > > > Yes, the version supports these features. > > > > > > > > > > > > > > > > Can anybody give me few inputs on the current status of these > > > > > > integrations? > > > > > > > > > > > > > > > > > > > > > http://www.ovirt.org/OVirt_3.3_release_announcement > > > > > > > > > > > > > > > > > > > > > http://www.ovirt.org/Features/Detailed_OSN_Integration > > > > > > > > > > > > > > > > > > > > I can say for Neutron that 1st phase is in - you can create a > > > > > "Neutron" > > > > > network in oVirt and attach it and use it in your VMs. > > > > > > > > > > > > > > > The supported plugins are Linux Bridge & OVS. > > > > > > > > > > > > > > > There was an issue raised on the users list that the port is not > > > > > persisted > > > > > across VM boots, which we will iron out ASAP. > > > > > > > > > > > > > > > > Thank You. > > > > > > > > > > > > > > > > > > > > > Regards, > > > > > > > > > > > > > > > > > > > > > Udaya Kiran > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > > > > > > > > > > > > > > > Engine-devel mailing list > > > > > > > > > > > > > > > > > > > > > Engine-devel at ovirt.org > > > > > > > > > > > > > > > > > > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > > > > > > > > > > > _______________________________________________ > > > Engine-devel mailing list > > > Engine-devel at ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > -------------- next part -------------- An HTML attachment was scrubbed... URL: From ukiran770 at yahoo.in Tue Oct 1 08:02:56 2013 From: ukiran770 at yahoo.in (Udaya Kiran P) Date: Tue, 1 Oct 2013 16:02:56 +0800 (SGT) Subject: [Engine-devel] oVirt3.3 - Glance and Neutron Integration In-Reply-To: <283319186.1124456.1380613507971.JavaMail.root@redhat.com> References: <1380516320.6878.YahooMailNeo@web193006.mail.sg3.yahoo.com> <1380535030.90781.YahooMailNeo@web193005.mail.sg3.yahoo.com> <1380536031.90927.YahooMailNeo@web193006.mail.sg3.yahoo.com> <415428792.558668.1380539000330.JavaMail.root@redhat.com> <1380597357.94777.YahooMailNeo@web193003.mail.sg3.yahoo.com> <1380608945.91549.YahooMailNeo@web193002.mail.sg3.yahoo.com> <1427681989.1085191.1380609629682.JavaMail.root@redhat.com> <1380610634.65641.YahooMailNeo@web193003.mail.sg3.yahoo.com> <283319186.1124456.1380613507971.JavaMail.root@redhat.com> Message-ID: <1380614576.18091.YahooMailNeo@web193003.mail.sg3.yahoo.com> Hi Mike, Can I add oVirt Node Hypervisor 2.6.1 (f18) to the oVirt3.3 Engine setup on f19..? Do I need to setup a new oVirt Node Hypervisor for oVirt3.3? I got an error -Host xxxx.xxx.xxx installation failed. Unexpected connection termination?- after approving the host in the oVirt Web Administration portal. Please suggest. Thank You. Regards, Udaya Kiran ________________________________ > >Hi Mike, Hi Udaya, > >I was able to fix the error. > > >Steps: > > >1. ?The log had the message, > > >DEBUG otopi.plugins.otopi.services.systemd plugin.execute:446 execute-output: ('/bin/systemctl', 'start', 'postgresql.service') stderr: >Job for postgresql.service failed. See 'systemctl status postgresql.service' and 'journalctl -xn' for details. > > >2.?systemctl status postgresql.service > > >Failed. (?PostgreSQL's request for a shared memory segment exceeded your kernel's SHMMAX?) > > >3.?vi /etc/sysctl.conf > > >kernel.shmmax = 41943040 > > >4.?sysctl -p > > >5.?engine-setup > > >and this time setup was successful..!! Happy to hear that! > >Thanks much. Glad to help. Regards, Mike > >Regards, >Udaya Kiran > > > >________________________________ > > >> >>Hi Mike, >Hi Udaya, > > >> >>When I tried with Fedora 19, setup failed with below error. I have attached the screenshot. >> >> >>?"Failed to execute stage 'Misc configuration': Command '/bin/systemctl' failed to execute" >Please attach the relevant info from the log file that the setup generated (the location is listed after "Clean up" stage). > > >> >> >> >>Here is what I did: >> >> >>1. Installed a fedora 19 on a new machine >>2.?yum -y update >>3. yum localinstall http://ovirt.org/releases/ovirt-release-fedora.noarch.rpm >>4. yum -y install ovirt-engine >>5. engine-setup >> >> >>I found a bug reported in bugzilla in the below link, yet I am not sure how to fix this. >> >> >>https://bugzilla.redhat.com/show_bug.cgi?id=990980 >> >Not sure if this is the problem, since this bug's fix should be in the GA version.. > > >> >> >> >>Please suggest. >> >> >>Regards, >>Udaya Kiran >> >> >> >> >> >>________________________________ >> >>Hi Mike, >> >> >> >>Thanks much for all your inputs. >>Now, that should help me resolve all the confusions. >> >> >>I will get back in case if I have any queries. >> >> >>Thank You, >> >> >>Regards, >> >>Udaya Kiran >> >> >> >> >> >>________________________________ >> >> >>> >>>Hi Mike, >>Hi Udaya, >> >> >>> >>>Please find attached the screenshots for, >>> >>> >>>1. yum provides ovirt-engine >>> >>>2. /etc/yum.repos.d/ovirt.repo >>> >>> >>>Please correct me if some settings has to be changed. >>As you can see the package you have installed is from ovirt-nightly repo. >> >>The timestamp indicates it's rather old - 20130624021657 means it's from 02:16:57 24/06/2013 >> >>This is a development version which didn't have those features fully availabe yet. >> >> >> >>Also you can see the package is for f18 - Fedora 18. >>From the download page (http://www.ovirt.org/Download) you can see that Fedora 19 is required. >> >>I'm rather sure that Fedora 18 is not supported for 3.3, >>so my best suggestion would be to either upgrade the machine or try on a new machine. >> >>If you upgrade, I'd advise backing up first as fedora upgrade sometimes results (at least for me) in a non-booting disk. >> >> >> >>Regards, >> >>Mike >> >> >>> >>>Thank You. >>> >>> >>>Regards, >>>Udaya Kiran >>> >>> >>> >>> >>> >>>________________________________ >>> >>> >>> >>>Hi Mike, >>> >>> >>>Sounds good. >>> >>> >>>I am eager to know if the Integration is complete for Glance and Cinder in oVirt3.3? >>> >>> >>>Thank You. >>> >>> >>>Regards, >>>Udaya Kiran >>> >>> >>> >>>________________________________ >>> >>> >>>> >>>>Hi Mike, >>>Hi Udaya, >>> >>> >>>> >>>> >>>> >>>>Thank You for the quick update on this. >>>Happy to help, responses inline. >>> >>> >>>> >>>>Is there any restriction on installing the Neutron server? Should that be installed in the oVirt Engine machine or on the machines which host the openstack services - Compute, Network, Controller? >>>The neutron server itself can be installed on the same machine as engine, just make sure not to install horizon there so it won't mess up your oVirt web admin (haven't tried, but I guess they might not play well together).. >>> >>> >>>> >>>>Thank You, >>>> >>>> >>>> >>>>Regards, >>>>Udaya Kiran >>>> >>>> >>>> >>>> >>>>________________________________ >>>> >>>> >>>>> >>>>>Hi Mike, >>>>> >>>>> >>>>>Thank You for your inputs and update. >>>>> >>>>> >>>>> >>>>>I am trying to integrate oVirt3.3 (stable - http://ovirt.org/releases/stable/rpm/Fedora/$releasever/) with OpenStack. >>>>> >>>>> >>>>> >>>>>I am not able to see the web interface?for adding Neutron as an external provider as?specified in the deep dive presentation. >>>>> >>>>> >>>>> >>>>>Deep Dive Presentation - http://www.ovirt.org/images/e/e7/Ovirt-neutron-integration-deep-dive-2013.pdf >>>>> >>>>> >>>>>I have attached the screenshots of my oVirt3.3 setup. >>>>This looks like a very old interface that we had while developing the integration, not the final version (that's what you see in the deep dive). >>>Well, I just installed ovirt from 3.3 and I see the new interface as you posted in the screenshot from the deep dive. >>> >>> >>> >>>Can you please make sure this is what is installed? >>> >>> >>> >>>[root at localhost ~]# yum provides ovirt-engine >>>Loaded plugins: langpacks, refresh-packagekit, versionlock >>>ovirt-engine-3.3.0-4.fc19.noarch : Management server for Open Virtualization >>>Repo??????? : ovirt-stable >>> >>> >>> >>> >>>> >>>> >>>>> >>>>>Please correct me if using the wrong repository for oVirt3.3. >>>>Let me install oVirt 3.3 that was published and get back to you on this. >>>> >>>> >>>>> >>>>>Also, where the Neutron Server should be configured? Is it at the openstack end or at the oVirt end? >>>>I'm not sure what you mean by this, can you please elaborate? >>>> >>>> >>>>> >>>>>Thank You. >>>>> >>>>> >>>>>Regards, >>>>> >>>>>Udaya Kiran >>>>> >>>>> >>>>> >>>>>________________________________ >>>>> >>>>>Hi Everyone, >>>>>Hi Udaya, >>>>> >>>>> >>>>>> >>>>>>Does oVirt3.3 version support Glance and Neutron Integration.? >>>>>Yes, the version supports these features. >>>>> >>>>> >>>>>> >>>>>>Can anybody give me few inputs on the current status of these integrations? >>>>> >>>>>> >>>>>>http://www.ovirt.org/OVirt_3.3_release_announcement >>>>>> >>>>>>http://www.ovirt.org/Features/Detailed_OSN_Integration >>>>>> >>>>>I can say for Neutron that 1st phase is in - you can create a "Neutron" network in oVirt and attach it and use it in your VMs. >>>>>The supported plugins are Linux Bridge & OVS. >>>>> >>>>>There was an issue raised on the users list that the port is not persisted across VM boots, which we will iron out ASAP. >>>>> >>>>> >>>>>> >>>>>> >>>>>> >>>>>>Thank You. >>>>>> >>>>>> >>>>>>Regards, >>>>>>Udaya Kiran >>>>>>_______________________________________________ >>>>>>Engine-devel mailing list >>>>>>Engine-devel at ovirt.org >>>>>>http://lists.ovirt.org/mailman/listinfo/engine-devel >>>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>> >>>> >>>> >>>> >>>> >>> >>> >>> >>> >>> >>> >>> >>> >> >> >> >> >> >>_______________________________________________ >>Engine-devel mailing list >>Engine-devel at ovirt.org >>http://lists.ovirt.org/mailman/listinfo/engine-devel >> >> >> >> > > > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From masayag at redhat.com Tue Oct 1 18:48:05 2013 From: masayag at redhat.com (Moti Asayag) Date: Tue, 1 Oct 2013 14:48:05 -0400 (EDT) Subject: [Engine-devel] make install-dev failure on second attempt In-Reply-To: <1620603493.621052.1380652961932.JavaMail.root@redhat.com> Message-ID: <373330529.622572.1380653285902.JavaMail.root@redhat.com> Hi, Running "make install-dev PREFIX=~/ovirt-engine_test BUILD_UT=0 BUILD_GWT=0" fails with several errors: ln -s "/home/motia/ovirt-engine_test/etc/ovirt-engine/usbfilter.txt" "/home/motia/ovirt-engine_test/share/ovirt-engine/files/usbfilter.txt" ln: failed to create symbolic link `/home/motia/ovirt-engine_test/share/ovirt-engine/files/usbfilter.txt': File exists make[1]: *** [install-layout] Error 1 make[1]: Leaving directory `/home/motia/work/ovirt-engine' make: *** [install-dev] Error 2 and if /home/motia/ovirt-engine_test/share/ovirt-engine/files/usbfilter.txt is deleted, there are a couple of files which fail with the same error: /home/motia/ovirt-engine/share/ovirt-engine/files/spice-html5 /home/motia/ovirt-engine/share/ovirt-engine/files/novnc I suspect commit b5522d43e2899f66646bb490d268fa890ce9483f "packaging: introduce generic file serving" introduced this issue. Thanks, Moti From alonbl at redhat.com Tue Oct 1 19:28:23 2013 From: alonbl at redhat.com (Alon Bar-Lev) Date: Tue, 1 Oct 2013 15:28:23 -0400 (EDT) Subject: [Engine-devel] make install-dev failure on second attempt In-Reply-To: <373330529.622572.1380653285902.JavaMail.root@redhat.com> References: <373330529.622572.1380653285902.JavaMail.root@redhat.com> Message-ID: <563620353.761483.1380655703742.JavaMail.root@redhat.com> ----- Original Message ----- > From: "Moti Asayag" > To: "engine-devel" > Cc: "Alon Bar-Lev" > Sent: Tuesday, October 1, 2013 9:48:05 PM > Subject: make install-dev failure on second attempt > > Hi, > > Running "make install-dev PREFIX=~/ovirt-engine_test BUILD_UT=0 BUILD_GWT=0" > fails with several errors: > > ln -s "/home/motia/ovirt-engine_test/etc/ovirt-engine/usbfilter.txt" > "/home/motia/ovirt-engine_test/share/ovirt-engine/files/usbfilter.txt" > ln: failed to create symbolic link > `/home/motia/ovirt-engine_test/share/ovirt-engine/files/usbfilter.txt': File > exists > make[1]: *** [install-layout] Error 1 > make[1]: Leaving directory `/home/motia/work/ovirt-engine' > make: *** [install-dev] Error 2 > > and if /home/motia/ovirt-engine_test/share/ovirt-engine/files/usbfilter.txt > is deleted, > there are a couple of files which fail with the same error: > /home/motia/ovirt-engine/share/ovirt-engine/files/spice-html5 > /home/motia/ovirt-engine/share/ovirt-engine/files/novnc > > I suspect commit b5522d43e2899f66646bb490d268fa890ce9483f "packaging: > introduce generic file serving" > introduced this issue. Thanks! > > Thanks, > Moti > From lpeer at redhat.com Wed Oct 2 10:27:11 2013 From: lpeer at redhat.com (Livnat Peer) Date: Wed, 02 Oct 2013 13:27:11 +0300 Subject: [Engine-devel] Lior Vernia as ovirt-UI maintainer Message-ID: <524BF4FF.4060406@redhat.com> I'd like to propose Lior Vernia as a ovirt-UI maintainer. Lior Vernia has been working on the UI for over a year, with a lot of dedication enthusiasm and motivation. He has more than 140 UI patches merged and hopefully many more in the pipeline :) Thanks, Livnat From gchaplik at redhat.com Wed Oct 2 10:31:41 2013 From: gchaplik at redhat.com (Gilad Chaplik) Date: Wed, 2 Oct 2013 06:31:41 -0400 (EDT) Subject: [Engine-devel] Lior Vernia as ovirt-UI maintainer In-Reply-To: <524BF4FF.4060406@redhat.com> References: <524BF4FF.4060406@redhat.com> Message-ID: <2123300255.202638.1380709901491.JavaMail.root@redhat.com> +1 Thanks, Gilad. ----- Original Message ----- > From: "Livnat Peer" > To: "engine-devel" , "board" > Sent: Wednesday, October 2, 2013 12:27:11 PM > Subject: [Engine-devel] Lior Vernia as ovirt-UI maintainer > > I'd like to propose Lior Vernia as a ovirt-UI maintainer. > > Lior Vernia has been working on the UI for over a year, with a lot of > dedication enthusiasm and motivation. > He has more than 140 UI patches merged and hopefully many more in the > pipeline :) > > > Thanks, Livnat > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > From tjelinek at redhat.com Wed Oct 2 10:57:02 2013 From: tjelinek at redhat.com (Tomas Jelinek) Date: Wed, 2 Oct 2013 06:57:02 -0400 (EDT) Subject: [Engine-devel] Lior Vernia as ovirt-UI maintainer In-Reply-To: <2123300255.202638.1380709901491.JavaMail.root@redhat.com> References: <524BF4FF.4060406@redhat.com> <2123300255.202638.1380709901491.JavaMail.root@redhat.com> Message-ID: <1517421001.230686.1380711422091.JavaMail.root@redhat.com> +1 ----- Original Message ----- > From: "Gilad Chaplik" > To: "Livnat Peer" > Cc: "engine-devel" , "board" > Sent: Wednesday, October 2, 2013 12:31:41 PM > Subject: Re: [Engine-devel] Lior Vernia as ovirt-UI maintainer > > +1 > > Thanks, > Gilad. > > ----- Original Message ----- > > From: "Livnat Peer" > > To: "engine-devel" , "board" > > Sent: Wednesday, October 2, 2013 12:27:11 PM > > Subject: [Engine-devel] Lior Vernia as ovirt-UI maintainer > > > > I'd like to propose Lior Vernia as a ovirt-UI maintainer. > > > > Lior Vernia has been working on the UI for over a year, with a lot of > > dedication enthusiasm and motivation. > > He has more than 140 UI patches merged and hopefully many more in the > > pipeline :) > > > > > > Thanks, Livnat > > _______________________________________________ > > Engine-devel mailing list > > Engine-devel at ovirt.org > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > From tnisan at redhat.com Wed Oct 2 11:08:09 2013 From: tnisan at redhat.com (Tal Nisan) Date: Wed, 02 Oct 2013 14:08:09 +0300 Subject: [Engine-devel] Lior Vernia as ovirt-UI maintainer In-Reply-To: <1517421001.230686.1380711422091.JavaMail.root@redhat.com> References: <524BF4FF.4060406@redhat.com> <2123300255.202638.1380709901491.JavaMail.root@redhat.com> <1517421001.230686.1380711422091.JavaMail.root@redhat.com> Message-ID: <524BFE99.9050309@redhat.com> +1 On 10/02/2013 01:57 PM, Tomas Jelinek wrote: > +1 > > ----- Original Message ----- >> From: "Gilad Chaplik" >> To: "Livnat Peer" >> Cc: "engine-devel" , "board" >> Sent: Wednesday, October 2, 2013 12:31:41 PM >> Subject: Re: [Engine-devel] Lior Vernia as ovirt-UI maintainer >> >> +1 >> >> Thanks, >> Gilad. >> >> ----- Original Message ----- >>> From: "Livnat Peer" >>> To: "engine-devel" , "board" >>> Sent: Wednesday, October 2, 2013 12:27:11 PM >>> Subject: [Engine-devel] Lior Vernia as ovirt-UI maintainer >>> >>> I'd like to propose Lior Vernia as a ovirt-UI maintainer. >>> >>> Lior Vernia has been working on the UI for over a year, with a lot of >>> dedication enthusiasm and motivation. >>> He has more than 140 UI patches merged and hopefully many more in the >>> pipeline :) >>> >>> >>> Thanks, Livnat >>> _______________________________________________ >>> Engine-devel mailing list >>> Engine-devel at ovirt.org >>> http://lists.ovirt.org/mailman/listinfo/engine-devel >>> >> _______________________________________________ >> Engine-devel mailing list >> Engine-devel at ovirt.org >> http://lists.ovirt.org/mailman/listinfo/engine-devel >> > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel From derez at redhat.com Wed Oct 2 14:21:10 2013 From: derez at redhat.com (Daniel Erez) Date: Wed, 2 Oct 2013 10:21:10 -0400 (EDT) Subject: [Engine-devel] Lior Vernia as ovirt-UI maintainer In-Reply-To: <524BFE99.9050309@redhat.com> References: <524BF4FF.4060406@redhat.com> <2123300255.202638.1380709901491.JavaMail.root@redhat.com> <1517421001.230686.1380711422091.JavaMail.root@redhat.com> <524BFE99.9050309@redhat.com> Message-ID: <442329056.314660.1380723670479.JavaMail.root@redhat.com> +1 ----- Original Message ----- > From: "Tal Nisan" > To: "Tomas Jelinek" > Cc: "engine-devel" , "board" > Sent: Wednesday, October 2, 2013 2:08:09 PM > Subject: Re: [Engine-devel] Lior Vernia as ovirt-UI maintainer > > +1 > > On 10/02/2013 01:57 PM, Tomas Jelinek wrote: > > +1 > > > > ----- Original Message ----- > >> From: "Gilad Chaplik" > >> To: "Livnat Peer" > >> Cc: "engine-devel" , "board" > >> Sent: Wednesday, October 2, 2013 12:31:41 PM > >> Subject: Re: [Engine-devel] Lior Vernia as ovirt-UI maintainer > >> > >> +1 > >> > >> Thanks, > >> Gilad. > >> > >> ----- Original Message ----- > >>> From: "Livnat Peer" > >>> To: "engine-devel" , "board" > >>> Sent: Wednesday, October 2, 2013 12:27:11 PM > >>> Subject: [Engine-devel] Lior Vernia as ovirt-UI maintainer > >>> > >>> I'd like to propose Lior Vernia as a ovirt-UI maintainer. > >>> > >>> Lior Vernia has been working on the UI for over a year, with a lot of > >>> dedication enthusiasm and motivation. > >>> He has more than 140 UI patches merged and hopefully many more in the > >>> pipeline :) > >>> > >>> > >>> Thanks, Livnat > >>> _______________________________________________ > >>> Engine-devel mailing list > >>> Engine-devel at ovirt.org > >>> http://lists.ovirt.org/mailman/listinfo/engine-devel > >>> > >> _______________________________________________ > >> Engine-devel mailing list > >> Engine-devel at ovirt.org > >> http://lists.ovirt.org/mailman/listinfo/engine-devel > >> > > _______________________________________________ > > Engine-devel mailing list > > Engine-devel at ovirt.org > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > From masayag at redhat.com Wed Oct 2 14:55:32 2013 From: masayag at redhat.com (Moti Asayag) Date: Wed, 2 Oct 2013 10:55:32 -0400 (EDT) Subject: [Engine-devel] Lior Vernia as ovirt-UI maintainer In-Reply-To: <524BF4FF.4060406@redhat.com> References: <524BF4FF.4060406@redhat.com> Message-ID: <1729112660.574853.1380725732448.JavaMail.root@redhat.com> +1 ----- Original Message ----- > From: "Livnat Peer" > To: "engine-devel" , "board" > Sent: Wednesday, October 2, 2013 12:27:11 PM > Subject: [Engine-devel] Lior Vernia as ovirt-UI maintainer > > I'd like to propose Lior Vernia as a ovirt-UI maintainer. > > Lior Vernia has been working on the UI for over a year, with a lot of > dedication enthusiasm and motivation. > He has more than 140 UI patches merged and hopefully many more in the > pipeline :) > > > Thanks, Livnat > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > From vszocs at redhat.com Wed Oct 2 15:56:21 2013 From: vszocs at redhat.com (Vojtech Szocs) Date: Wed, 2 Oct 2013 11:56:21 -0400 (EDT) Subject: [Engine-devel] Lior Vernia as ovirt-UI maintainer In-Reply-To: <524BF4FF.4060406@redhat.com> References: <524BF4FF.4060406@redhat.com> Message-ID: <1768282379.425711.1380729381275.JavaMail.root@redhat.com> +1 ----- Original Message ----- > From: "Livnat Peer" > To: "engine-devel" , "board" > Sent: Wednesday, October 2, 2013 12:27:11 PM > Subject: [Engine-devel] Lior Vernia as ovirt-UI maintainer > > I'd like to propose Lior Vernia as a ovirt-UI maintainer. > > Lior Vernia has been working on the UI for over a year, with a lot of > dedication enthusiasm and motivation. > He has more than 140 UI patches merged and hopefully many more in the > pipeline :) > > > Thanks, Livnat > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > From kmayilsa at redhat.com Thu Oct 3 04:16:54 2013 From: kmayilsa at redhat.com (Kanagaraj) Date: Thu, 03 Oct 2013 09:46:54 +0530 Subject: [Engine-devel] Lior Vernia as ovirt-UI maintainer In-Reply-To: <524BF4FF.4060406@redhat.com> References: <524BF4FF.4060406@redhat.com> Message-ID: <524CEFB6.5000405@redhat.com> +1 Thanks, Kanagaraj On 10/02/2013 03:57 PM, Livnat Peer wrote: > I'd like to propose Lior Vernia as a ovirt-UI maintainer. > > Lior Vernia has been working on the UI for over a year, with a lot of > dedication enthusiasm and motivation. > He has more than 140 UI patches merged and hopefully many more in the > pipeline :) > > > Thanks, Livnat > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel From iheim at redhat.com Thu Oct 3 10:26:03 2013 From: iheim at redhat.com (Itamar Heim) Date: Thu, 03 Oct 2013 13:26:03 +0300 Subject: [Engine-devel] Lior Vernia as ovirt-UI maintainer In-Reply-To: <524CEFB6.5000405@redhat.com> References: <524BF4FF.4060406@redhat.com> <524CEFB6.5000405@redhat.com> Message-ID: <524D463B.4070806@redhat.com> On 10/03/2013 07:16 AM, Kanagaraj wrote: > +1 > > Thanks, > Kanagaraj > > On 10/02/2013 03:57 PM, Livnat Peer wrote: >> I'd like to propose Lior Vernia as a ovirt-UI maintainer. >> >> Lior Vernia has been working on the UI for over a year, with a lot of >> dedication enthusiasm and motivation. >> He has more than 140 UI patches merged and hopefully many more in the >> pipeline :) >> >> >> Thanks, Livnat >> _______________________________________________ >> Engine-devel mailing list >> Engine-devel at ovirt.org >> http://lists.ovirt.org/mailman/listinfo/engine-devel > > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel seeing enough +1's, added to gerrit group From lvernia at redhat.com Thu Oct 3 11:08:42 2013 From: lvernia at redhat.com (Lior Vernia) Date: Thu, 03 Oct 2013 14:08:42 +0300 Subject: [Engine-devel] Lior Vernia as ovirt-UI maintainer In-Reply-To: <524D463B.4070806@redhat.com> References: <524BF4FF.4060406@redhat.com> <524CEFB6.5000405@redhat.com> <524D463B.4070806@redhat.com> Message-ID: <524D503A.4050007@redhat.com> Thanks to everyone who backed me up, please feel free to put me down as a reviewer for your patches as I have done to you. On 03/10/13 13:26, Itamar Heim wrote: > On 10/03/2013 07:16 AM, Kanagaraj wrote: >> +1 >> >> Thanks, >> Kanagaraj >> >> On 10/02/2013 03:57 PM, Livnat Peer wrote: >>> I'd like to propose Lior Vernia as a ovirt-UI maintainer. >>> >>> Lior Vernia has been working on the UI for over a year, with a lot of >>> dedication enthusiasm and motivation. >>> He has more than 140 UI patches merged and hopefully many more in the >>> pipeline :) >>> >>> >>> Thanks, Livnat >>> _______________________________________________ >>> Engine-devel mailing list >>> Engine-devel at ovirt.org >>> http://lists.ovirt.org/mailman/listinfo/engine-devel >> >> _______________________________________________ >> Engine-devel mailing list >> Engine-devel at ovirt.org >> http://lists.ovirt.org/mailman/listinfo/engine-devel > > seeing enough +1's, added to gerrit group > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel From dougsland at redhat.com Fri Oct 4 03:44:26 2013 From: dougsland at redhat.com (Douglas Schilling Landgraf) Date: Thu, 03 Oct 2013 23:44:26 -0400 Subject: [Engine-devel] UseSecureConnectionWithServers Message-ID: <524E399A.9060000@redhat.com> Hi, This email is just a heads up about UseSecureConnectionWithServers option in database that got renamed [1] to EncryptHostCommunication to be more descriptive. Additionally, the EncryptHostCommunication was added to engine-config tool [2]. Fore more info: [1] http://gerrit.ovirt.org/#/c/19305/ [2] http://gerrit.ovirt.org/#/c/19202/ Thanks! -- Cheers Douglas From vszocs at redhat.com Mon Oct 7 10:17:30 2013 From: vszocs at redhat.com (Vojtech Szocs) Date: Mon, 7 Oct 2013 06:17:30 -0400 (EDT) Subject: [Engine-devel] Introducing generics to UiCommon In-Reply-To: <1251012257.4042811.1380281534199.JavaMail.root@redhat.com> References: <247427421.11376161.1375688489773.JavaMail.root@redhat.com> <1251012257.4042811.1380281534199.JavaMail.root@redhat.com> Message-ID: <54579635.3393851.1381141050318.JavaMail.root@redhat.com> Hi Tomas, I missed the original mail and just reviewed both patches (+1 from my side). I think introducing generics to UiCommon is a step in the right direction; as you wrote, using non-generic types (i.e. List instead of List) leads to hidden expectations and type casts that make code harder to read and maintain (and also impacts GwtCommon/WebAdmin/UserPortal code that needs to adapt to such code). Do we have some general plan to cover UiCommon as a whole? - patch [1] modifies EntityModel/ListModel, what about other base models? (i.e. SearchableListModel) - patch [1] adds String version of EntityModelTextBox, what about other editor widgets? [*] according to your original mail, these are: EntityModelLabel, EntityModelTextAreaLabel, EntityModelPasswordBox, EntityModelTextArea, ListModelSuggestBox - any other change necessary? (aside from modifying specific model classes such as DataCenterModel) [*] IIUC for each editor widget we need: the widget itself, editor, renderer/parser (potential reuse) What about following approach (just a suggestion): [separate patch - rebased on patch 1] - make remaining base models generic too (i.e. SearchableListModel) - add remaining GUI infra to bind to generic models, i.e. editor widgets and related stuff [separate patch per specific main tab model] - make main tab model use generics (including any dialog models referenced from this code) - make related sub tab models use generics (including any dialog models referenced from this code) Having said that, I value your effort to improve existing code. This is not an easy task, it will take more patches but I think it's worth it. Thanks! Vojtech ----- Original Message ----- > From: "Tomas Jelinek" > To: "engine-devel" > Cc: "Vojtech Szocs" , "Daniel Erez" , "Gilad Chaplik" , > "Tal Nisan" , "Alona Kaplan" > Sent: Friday, September 27, 2013 1:32:14 PM > Subject: Re: [Engine-devel] Introducing generics to UiCommon > > Hey all, > > some time ago I have created a patch which introduces generics to UiCommon > [1] and one which uses it > in DataCenterModel [2]. Today I have changed a bit the generic version of the > EntityModelTextBox to > be truly generic (since it can edit also e.g. integers) and than a simple > subclass StringEntityModelTextBox > which provides the String renderer/parser to simplify the usage. All the > other details are available in the previous > mail. > > What do you think about it? > > Tomas > > [1]: http://gerrit.ovirt.org/#/c/17604/ > [2]: http://gerrit.ovirt.org/#/c/17605/ > > ----- Original Message ----- > > From: "Tomas Jelinek" > > To: "engine-devel" > > Sent: Monday, August 5, 2013 9:41:29 AM > > Subject: [Engine-devel] Introducing generics to UiCommon > > > > Hey all, > > > > as we have passed the oVirt feature freeze I would like to celebrate it > > with > > a little bit of cleanup :) > > > > A good candidate for this is to introduce generics into uicommonweb > > project. > > The fact that it is not generic > > brings quite some hidden expectations into our code, makes it unreadable > > and > > error prone. > > > > Also, the gwt-common and both webadmin and userportal are mostly prepared > > to > > be generic but because the uicommonweb is not, we have code like: > > > > new ListModelListBoxEditor(new NullSafeRenderer() { > > @Override > > public String renderNullSafe(Object object) > > return ((Version) object).getValue(); > > } > > }); > > > > which is quite ugly and error prone. > > > > So I have prepared two patches, one [1] which introduces the generic > > infrastructure (and prepares one widget for it, more about this below) and > > one [2] which uses it and refactors the DataCenterModel > > to use it (I have chosen this model because it is big enough to show how to > > do it and what the benefits are but small enough to be quickly > > review-able). > > > > The infrastructure change: > > - changes the ListModel and EntityModel to be genreic > > - adjusts the UiCommonEditorDriverGenerator to work with generics (e.g. to > > make it aware that ListModel is indeed a ListModel, same for > > EntityModel) > > - created a String version of EntityModelTextBox > > > > The reason why the String EntityModelTextBox had to be created is that the > > EntityModelTextBox is an EditorWidget so it can work only with > > EntityModel. I saw 2 ways how to make this work with > > EntityModel: > > 1: Create a String version of this editor inside the .generic sub-package, > > incrementally replace the usage of the non-generic EntityModelTextBox and > > when the non-generic will be completely replaced, delete it and move the > > generic one > > out from the generic sub-package > > > > 2: Change the EditorWidget to EditorWidget and replace > > each usage of the "EntityModelTextBox someWidget" by > > "EntityModelTextBox someWidget" and than incrementally replace the > > to as the > > underlying models will be refactored. After the last one will be > > refactored, change the EditorWidget to EditorWidget > > and replace all "EntityModelTextBox someWidget" by > > "EntityModelTextBox someWidget" > > > > I have chosen the first option because: > > - much less classes touched at once (e.g. much more safe) > > - the EntityModelTextBox invites to use something like > > EntityModelTextBox which is not correct and fails on class cast > > exceptions > > > > But at the same time I see the disadvantages of this approach (mostly that > > we > > have two versions of the same class). Please note that far not all the > > widgets will need two versions, only the ones editing only Strings which > > are declared as EditorWidget which are: > > - EntityModelLabel > > - EntityModelTextAreaLabel (used only in couple of places - can be > > refactored > > together without the need to have two versions) > > - EntityModelTextBox (already in the [1]) > > - EntityModelPasswordBox > > - EntityModelTextArea > > - ListModelSuggestBox (used only in couple of places - can be refactored > > together without the need to have two versions) > > > > The rest of the widgets should be already prepared to be used in generic > > environment. > > > > Please let me know what do you think about it, > > > > have a nice day, > > Tomas > > > > [1]: http://gerrit.ovirt.org/#/c/17604/ > > [2]: http://gerrit.ovirt.org/#/c/17605/ > > > > _______________________________________________ > > Engine-devel mailing list > > Engine-devel at ovirt.org > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > From yzaslavs at redhat.com Mon Oct 7 13:52:04 2013 From: yzaslavs at redhat.com (Yair Zaslavsky) Date: Mon, 7 Oct 2013 09:52:04 -0400 (EDT) Subject: [Engine-devel] How to validate no arg ctor existence in params? In-Reply-To: <1862297458.2197292.1381153919586.JavaMail.root@redhat.com> Message-ID: <111134884.2197372.1381153924993.JavaMail.root@redhat.com> Hi, I saw several patches that fixed serialization (json or gwt) issues that were introduced due to non existence of no-arg CTOR for parameters. Does anyone know a way to validate this using let's say some jenkins plugin? Yair From tnisan at redhat.com Mon Oct 7 13:56:52 2013 From: tnisan at redhat.com (Tal Nisan) Date: Mon, 07 Oct 2013 16:56:52 +0300 Subject: [Engine-devel] How to validate no arg ctor existence in params? In-Reply-To: <111134884.2197372.1381153924993.JavaMail.root@redhat.com> References: <111134884.2197372.1381153924993.JavaMail.root@redhat.com> Message-ID: <5252BDA4.5010500@redhat.com> Perhaps it can be done by writing a custom checkstyle plugin? Allon wrote one for alerting when using a static class members initialization in certain packages, he might know. On 10/07/2013 04:52 PM, Yair Zaslavsky wrote: > Hi, > I saw several patches that fixed serialization (json or gwt) issues that were introduced due to non existence of no-arg CTOR for parameters. > Does anyone know a way to validate this using let's say some jenkins plugin? > > Yair > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel From yzaslavs at redhat.com Mon Oct 7 14:02:39 2013 From: yzaslavs at redhat.com (Yair Zaslavsky) Date: Mon, 7 Oct 2013 10:02:39 -0400 (EDT) Subject: [Engine-devel] How to validate no arg ctor existence in params? In-Reply-To: <5252BDA4.5010500@redhat.com> References: <111134884.2197372.1381153924993.JavaMail.root@redhat.com> <5252BDA4.5010500@redhat.com> Message-ID: <507893595.2203481.1381154559896.JavaMail.root@redhat.com> ----- Original Message ----- > From: "Tal Nisan" > To: "Yair Zaslavsky" > Cc: "engine-devel" > Sent: Monday, October 7, 2013 4:56:52 PM > Subject: Re: [Engine-devel] How to validate no arg ctor existence in params? > > Perhaps it can be done by writing a custom checkstyle plugin? Allon > wrote one for alerting when using a static class members initialization > in certain packages, he might know. +1 Martin Perina also remembered something like that. Anyway, I strongly recommend it should be done. Already corresponding with Allon on it. > > On 10/07/2013 04:52 PM, Yair Zaslavsky wrote: > > Hi, > > I saw several patches that fixed serialization (json or gwt) issues that > > were introduced due to non existence of no-arg CTOR for parameters. > > Does anyone know a way to validate this using let's say some jenkins > > plugin? > > > > Yair > > _______________________________________________ > > Engine-devel mailing list > > Engine-devel at ovirt.org > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > From ecohen at redhat.com Mon Oct 7 14:04:06 2013 From: ecohen at redhat.com (Einav Cohen) Date: Mon, 7 Oct 2013 10:04:06 -0400 (EDT) Subject: [Engine-devel] How to validate no arg ctor existence in params? In-Reply-To: <507893595.2203481.1381154559896.JavaMail.root@redhat.com> References: <111134884.2197372.1381153924993.JavaMail.root@redhat.com> <5252BDA4.5010500@redhat.com> <507893595.2203481.1381154559896.JavaMail.root@redhat.com> Message-ID: <262142554.2844154.1381154646595.JavaMail.root@redhat.com> > ----- Original Message ----- > From: "Yair Zaslavsky" > Sent: Monday, October 7, 2013 10:02:39 AM > > > > ----- Original Message ----- > > From: "Tal Nisan" > > To: "Yair Zaslavsky" > > Cc: "engine-devel" > > Sent: Monday, October 7, 2013 4:56:52 PM > > Subject: Re: [Engine-devel] How to validate no arg ctor existence in > > params? > > > > Perhaps it can be done by writing a custom checkstyle plugin? Allon > > wrote one for alerting when using a static class members initialization > > in certain packages, he might know. > > +1 > Martin Perina also remembered something like that. > Anyway, I strongly recommend it should be done. > Already corresponding with Allon on it. I might be missing something, but isn't that what patch http://gerrit.ovirt.org/#/c/18910/ does? > > > > > On 10/07/2013 04:52 PM, Yair Zaslavsky wrote: > > > Hi, > > > I saw several patches that fixed serialization (json or gwt) issues that > > > were introduced due to non existence of no-arg CTOR for parameters. > > > Does anyone know a way to validate this using let's say some jenkins > > > plugin? > > > > > > Yair > > > _______________________________________________ > > > Engine-devel mailing list > > > Engine-devel at ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > From tnisan at redhat.com Mon Oct 7 14:06:52 2013 From: tnisan at redhat.com (Tal Nisan) Date: Mon, 07 Oct 2013 17:06:52 +0300 Subject: [Engine-devel] How to validate no arg ctor existence in params? In-Reply-To: <262142554.2844154.1381154646595.JavaMail.root@redhat.com> References: <111134884.2197372.1381153924993.JavaMail.root@redhat.com> <5252BDA4.5010500@redhat.com> <507893595.2203481.1381154559896.JavaMail.root@redhat.com> <262142554.2844154.1381154646595.JavaMail.root@redhat.com> Message-ID: <5252BFFC.8000302@redhat.com> On 10/07/2013 05:04 PM, Einav Cohen wrote: >> ----- Original Message ----- >> From: "Yair Zaslavsky" >> Sent: Monday, October 7, 2013 10:02:39 AM >> >> >> >> ----- Original Message ----- >>> From: "Tal Nisan" >>> To: "Yair Zaslavsky" >>> Cc: "engine-devel" >>> Sent: Monday, October 7, 2013 4:56:52 PM >>> Subject: Re: [Engine-devel] How to validate no arg ctor existence in >>> params? >>> >>> Perhaps it can be done by writing a custom checkstyle plugin? Allon >>> wrote one for alerting when using a static class members initialization >>> in certain packages, he might know. >> +1 >> Martin Perina also remembered something like that. >> Anyway, I strongly recommend it should be done. >> Already corresponding with Allon on it. > I might be missing something, but isn't that what patch http://gerrit.ovirt.org/#/c/18910/ does? Seems like it, Yair I saw you also reviewed it, from a brief look at the code it looks like it checks for a default constructor existence as well as some other criterias > >>> On 10/07/2013 04:52 PM, Yair Zaslavsky wrote: >>>> Hi, >>>> I saw several patches that fixed serialization (json or gwt) issues that >>>> were introduced due to non existence of no-arg CTOR for parameters. >>>> Does anyone know a way to validate this using let's say some jenkins >>>> plugin? >>>> >>>> Yair >>>> _______________________________________________ >>>> Engine-devel mailing list >>>> Engine-devel at ovirt.org >>>> http://lists.ovirt.org/mailman/listinfo/engine-devel >>> >> _______________________________________________ >> Engine-devel mailing list >> Engine-devel at ovirt.org >> http://lists.ovirt.org/mailman/listinfo/engine-devel >> >> >> From yzaslavs at redhat.com Mon Oct 7 14:15:23 2013 From: yzaslavs at redhat.com (Yair Zaslavsky) Date: Mon, 7 Oct 2013 10:15:23 -0400 (EDT) Subject: [Engine-devel] How to validate no arg ctor existence in params? In-Reply-To: <5252BFFC.8000302@redhat.com> References: <111134884.2197372.1381153924993.JavaMail.root@redhat.com> <5252BDA4.5010500@redhat.com> <507893595.2203481.1381154559896.JavaMail.root@redhat.com> <262142554.2844154.1381154646595.JavaMail.root@redhat.com> <5252BFFC.8000302@redhat.com> Message-ID: <1207086227.2217502.1381155323447.JavaMail.root@redhat.com> Yes, The patch by Vojtech should do this, can we push this forward? ----- Original Message ----- > From: "Tal Nisan" > To: "Einav Cohen" > Cc: "Yair Zaslavsky" , "engine-devel" > Sent: Monday, October 7, 2013 5:06:52 PM > Subject: Re: [Engine-devel] How to validate no arg ctor existence in params? > > On 10/07/2013 05:04 PM, Einav Cohen wrote: > >> ----- Original Message ----- > >> From: "Yair Zaslavsky" > >> Sent: Monday, October 7, 2013 10:02:39 AM > >> > >> > >> > >> ----- Original Message ----- > >>> From: "Tal Nisan" > >>> To: "Yair Zaslavsky" > >>> Cc: "engine-devel" > >>> Sent: Monday, October 7, 2013 4:56:52 PM > >>> Subject: Re: [Engine-devel] How to validate no arg ctor existence in > >>> params? > >>> > >>> Perhaps it can be done by writing a custom checkstyle plugin? Allon > >>> wrote one for alerting when using a static class members initialization > >>> in certain packages, he might know. > >> +1 > >> Martin Perina also remembered something like that. > >> Anyway, I strongly recommend it should be done. > >> Already corresponding with Allon on it. > > I might be missing something, but isn't that what patch > > http://gerrit.ovirt.org/#/c/18910/ does? > Seems like it, Yair I saw you also reviewed it, from a brief look at the > code it looks like it checks for a default constructor existence as well > as some other criterias > > > >>> On 10/07/2013 04:52 PM, Yair Zaslavsky wrote: > >>>> Hi, > >>>> I saw several patches that fixed serialization (json or gwt) issues that > >>>> were introduced due to non existence of no-arg CTOR for parameters. > >>>> Does anyone know a way to validate this using let's say some jenkins > >>>> plugin? > >>>> > >>>> Yair > >>>> _______________________________________________ > >>>> Engine-devel mailing list > >>>> Engine-devel at ovirt.org > >>>> http://lists.ovirt.org/mailman/listinfo/engine-devel > >>> > >> _______________________________________________ > >> Engine-devel mailing list > >> Engine-devel at ovirt.org > >> http://lists.ovirt.org/mailman/listinfo/engine-devel > >> > >> > >> > > From ecohen at redhat.com Mon Oct 7 21:19:40 2013 From: ecohen at redhat.com (Einav Cohen) Date: Mon, 7 Oct 2013 17:19:40 -0400 (EDT) Subject: [Engine-devel] How to validate no arg ctor existence in params? In-Reply-To: <1207086227.2217502.1381155323447.JavaMail.root@redhat.com> References: <111134884.2197372.1381153924993.JavaMail.root@redhat.com> <5252BDA4.5010500@redhat.com> <507893595.2203481.1381154559896.JavaMail.root@redhat.com> <262142554.2844154.1381154646595.JavaMail.root@redhat.com> <5252BFFC.8000302@redhat.com> <1207086227.2217502.1381155323447.JavaMail.root@redhat.com> Message-ID: <1297219916.3132954.1381180780566.JavaMail.root@redhat.com> > ----- Original Message ----- > From: "Yair Zaslavsky" > Sent: Monday, October 7, 2013 10:15:23 AM > > > Yes, The patch by Vojtech should do this, can we push this forward? once we will receive "+2" on it - we will be happy to. @Allon: as a checkstyle expert: any chance that you can take a look (http://gerrit.ovirt.org/#/c/18910/)? many thanks in advance. > > ----- Original Message ----- > > From: "Tal Nisan" > > To: "Einav Cohen" > > Cc: "Yair Zaslavsky" , "engine-devel" > > > > Sent: Monday, October 7, 2013 5:06:52 PM > > Subject: Re: [Engine-devel] How to validate no arg ctor existence in > > params? > > > > On 10/07/2013 05:04 PM, Einav Cohen wrote: > > >> ----- Original Message ----- > > >> From: "Yair Zaslavsky" > > >> Sent: Monday, October 7, 2013 10:02:39 AM > > >> > > >> > > >> > > >> ----- Original Message ----- > > >>> From: "Tal Nisan" > > >>> To: "Yair Zaslavsky" > > >>> Cc: "engine-devel" > > >>> Sent: Monday, October 7, 2013 4:56:52 PM > > >>> Subject: Re: [Engine-devel] How to validate no arg ctor existence in > > >>> params? > > >>> > > >>> Perhaps it can be done by writing a custom checkstyle plugin? Allon > > >>> wrote one for alerting when using a static class members initialization > > >>> in certain packages, he might know. > > >> +1 > > >> Martin Perina also remembered something like that. > > >> Anyway, I strongly recommend it should be done. > > >> Already corresponding with Allon on it. > > > I might be missing something, but isn't that what patch > > > http://gerrit.ovirt.org/#/c/18910/ does? > > Seems like it, Yair I saw you also reviewed it, from a brief look at the > > code it looks like it checks for a default constructor existence as well > > as some other criterias > > > > > >>> On 10/07/2013 04:52 PM, Yair Zaslavsky wrote: > > >>>> Hi, > > >>>> I saw several patches that fixed serialization (json or gwt) issues > > >>>> that > > >>>> were introduced due to non existence of no-arg CTOR for parameters. > > >>>> Does anyone know a way to validate this using let's say some jenkins > > >>>> plugin? > > >>>> > > >>>> Yair > > >>>> _______________________________________________ > > >>>> Engine-devel mailing list > > >>>> Engine-devel at ovirt.org > > >>>> http://lists.ovirt.org/mailman/listinfo/engine-devel > > >>> > > >> _______________________________________________ > > >> Engine-devel mailing list > > >> Engine-devel at ovirt.org > > >> http://lists.ovirt.org/mailman/listinfo/engine-devel > > >> > > >> > > >> > > > > > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > From vszocs at redhat.com Tue Oct 8 14:23:35 2013 From: vszocs at redhat.com (Vojtech Szocs) Date: Tue, 8 Oct 2013 10:23:35 -0400 (EDT) Subject: [Engine-devel] How to validate no arg ctor existence in params? In-Reply-To: <1297219916.3132954.1381180780566.JavaMail.root@redhat.com> References: <111134884.2197372.1381153924993.JavaMail.root@redhat.com> <5252BDA4.5010500@redhat.com> <507893595.2203481.1381154559896.JavaMail.root@redhat.com> <262142554.2844154.1381154646595.JavaMail.root@redhat.com> <5252BFFC.8000302@redhat.com> <1207086227.2217502.1381155323447.JavaMail.root@redhat.com> <1297219916.3132954.1381180780566.JavaMail.root@redhat.com> Message-ID: <1386744142.4461006.1381242215272.JavaMail.root@redhat.com> Hey guys, just a small note, patch http://gerrit.ovirt.org/#/c/18910/ was written specifically for checking classes shared between client/server when using GWT RPC. Because of that, this check applies only to backend "common" module. If we need "has a default (zero argument) constructor (with any access modifier) or no constructor at all" check, without any additional criteria specific to GWT RPC, applicable to other modules, maybe I can write a separate check for that purpose and reuse that within above mentioned patch. Vojtech ----- Original Message ----- > From: "Einav Cohen" > To: "Yair Zaslavsky" , "Allon Mureinik" > Cc: "engine-devel" > Sent: Monday, October 7, 2013 11:19:40 PM > Subject: Re: [Engine-devel] How to validate no arg ctor existence in params? > > > ----- Original Message ----- > > From: "Yair Zaslavsky" > > Sent: Monday, October 7, 2013 10:15:23 AM > > > > > > Yes, The patch by Vojtech should do this, can we push this forward? > > once we will receive "+2" on it - we will be happy to. > @Allon: as a checkstyle expert: any chance that you can take a look > (http://gerrit.ovirt.org/#/c/18910/)? > many thanks in advance. > > > > > ----- Original Message ----- > > > From: "Tal Nisan" > > > To: "Einav Cohen" > > > Cc: "Yair Zaslavsky" , "engine-devel" > > > > > > Sent: Monday, October 7, 2013 5:06:52 PM > > > Subject: Re: [Engine-devel] How to validate no arg ctor existence in > > > params? > > > > > > On 10/07/2013 05:04 PM, Einav Cohen wrote: > > > >> ----- Original Message ----- > > > >> From: "Yair Zaslavsky" > > > >> Sent: Monday, October 7, 2013 10:02:39 AM > > > >> > > > >> > > > >> > > > >> ----- Original Message ----- > > > >>> From: "Tal Nisan" > > > >>> To: "Yair Zaslavsky" > > > >>> Cc: "engine-devel" > > > >>> Sent: Monday, October 7, 2013 4:56:52 PM > > > >>> Subject: Re: [Engine-devel] How to validate no arg ctor existence in > > > >>> params? > > > >>> > > > >>> Perhaps it can be done by writing a custom checkstyle plugin? Allon > > > >>> wrote one for alerting when using a static class members > > > >>> initialization > > > >>> in certain packages, he might know. > > > >> +1 > > > >> Martin Perina also remembered something like that. > > > >> Anyway, I strongly recommend it should be done. > > > >> Already corresponding with Allon on it. > > > > I might be missing something, but isn't that what patch > > > > http://gerrit.ovirt.org/#/c/18910/ does? > > > Seems like it, Yair I saw you also reviewed it, from a brief look at the > > > code it looks like it checks for a default constructor existence as well > > > as some other criterias > > > > > > > >>> On 10/07/2013 04:52 PM, Yair Zaslavsky wrote: > > > >>>> Hi, > > > >>>> I saw several patches that fixed serialization (json or gwt) issues > > > >>>> that > > > >>>> were introduced due to non existence of no-arg CTOR for parameters. > > > >>>> Does anyone know a way to validate this using let's say some > > > >>>> jenkins > > > >>>> plugin? > > > >>>> > > > >>>> Yair > > > >>>> _______________________________________________ > > > >>>> Engine-devel mailing list > > > >>>> Engine-devel at ovirt.org > > > >>>> http://lists.ovirt.org/mailman/listinfo/engine-devel > > > >>> > > > >> _______________________________________________ > > > >> Engine-devel mailing list > > > >> Engine-devel at ovirt.org > > > >> http://lists.ovirt.org/mailman/listinfo/engine-devel > > > >> > > > >> > > > >> > > > > > > > > _______________________________________________ > > Engine-devel mailing list > > Engine-devel at ovirt.org > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > From leonardo.bianconi at eldorado.org.br Tue Oct 8 18:25:33 2013 From: leonardo.bianconi at eldorado.org.br (Leonardo Bianconi) Date: Tue, 8 Oct 2013 18:25:33 +0000 Subject: [Engine-devel] RES: Cluster default with empty processor name with PPC64 support In-Reply-To: <52481535.1040004@redhat.com> References: <50EB20226B72D6419356FC320AB62B8719173370@SERV070.corp.eldorado.org.br> <5222F5B7.5060603@redhat.com> <50EB20226B72D6419356FC320AB62B87191733F5@SERV070.corp.eldorado.org.br> <522715D2.8080103@redhat.com> <50EB20226B72D6419356FC320AB62B8719173649@SERV070.corp.eldorado.org.br>, <52481535.1040004@redhat.com> Message-ID: <50EB20226B72D6419356FC320AB62B871917E364@SERV070.corp.eldorado.org.br> ________________________________________ De: Itamar Heim [iheim at redhat.com] Enviado: domingo, 29 de setembro de 2013 8:55 Para: Leonardo Bianconi Cc: Roy Golan; engine-devel at ovirt.org Assunto: Re: [Engine-devel] Cluster default with empty processor name with PPC64 support On 09/04/2013 03:50 PM, Leonardo Bianconi wrote: > > >> -----Original Message----- >> From: Roy Golan [mailto:rgolan at redhat.com] >> Sent: quarta-feira, 4 de setembro de 2013 08:13 >> To: Leonardo Bianconi >> Cc: engine-devel at ovirt.org >> Subject: Re: [Engine-devel] Cluster default with empty processor name with PPC64 support >> >> On 09/02/2013 03:35 PM, Leonardo Bianconi wrote: >>> >>>>> From: Roy Golan [mailto:rgolan at redhat.com] >>>>> Sent: domingo, 1 de setembro de 2013 05:07 >>>>> To: Leonardo Bianconi >>>>> Cc: engine-devel at ovirt.org >>>>> Subject: Re: [Engine-devel] Cluster default with empty processor >>>>> name with PPC64 support >>>>> >>>>> On 08/30/2013 10:51 PM, Leonardo Bianconi wrote: >>>>> Hi everyone! >>>>> >>>>> During the development of PPC64 support in the engine, we faced some UX issues regarding the default Cluster (that Cluster with >> empty processor name). >>>>> >>>>> Currently, oVirt engine allows the default Cluster to contain empty processor name, and the administrator can add VMs and/or >> Templates to it. The processor name can be assigned later, editing the cluster or assigning a valid host to it. >>>>> >>>>> During the implementation of PPC64 support on the engine, the field "architecture" was added to Clusters, VMs and Templates >> entities. >>>>> >>>>> So we have the following questions regarding how the UI should behave: >>>>> >>>>> - Shall we keep allowing the administrator to assign VMs and Templates to the Cluster with no processor name or assigned >> architecture ? >>>>> -> If we have an "yes" for the question above: >>>>> -- We will have to assign the architecture to the Cluster based on the OS of the first assigned VM, and the processor name >> could be defined the same way as currently ... editing the Cluster or assigning a compatible Host to it. >>>>> -- The VM creation popup will have to be able to indicate the architecture of each OS ... some OSes have the same >> name, and it may get ambiguous since the Cluster architecture is still undefined at that point (before the first VM get already created). >>>>> >>>>> Thanks! >>>>> Regards. >>>>> Leonardo Bianconi >>>>> >>>> To add VMs you anyway need a running host in the cluster which means the cpu name and the architecture would be the host's. >>>> So we can keep the cluster attributes - "cpu name" and "arch" consistent and allow them to be empty on creation. >>>> >>>> >>> Hi Roy! >>> >>> There is a way to add VMs in a cluster with no hosts running. Steps to reproduce: >>> - Initialize the oVirt engine with a new data base >>> - Create a new Cluster (I will call it of newCluster) in the Data >>> Center Default >>> - Add a host in the newCluster >>> - Add a Storage >>> - Create a VM in the Cluster Default >>> Result: The system allows a VM in a cluster with no Hosts running in it. >>> >>> Is it a bug or a system functionality? If it's a functionality, the issue above can happen. >> Just to clear this one - its a functional thing. its a bit confusing but not too complicated: >> >> Storage and all its related actions/entities are related to the Data Center (aka, code-wise storage pool). Its possible to create a VM >> once the DC is up, without a cluster i.e also provision disks to it and so on. >> >> Cluster is know as the "migration domain" wrt VMs. so CPU arch stuff, network config etc, must be homogeneous in order for VMs to >> migrate between hosts which means we must have a running cluster i.e at least 1 running host in it. >> > Roy, thank you for the explanation! It`s clear now >> >>> >>> Thanks!! >>> Regards. >>> Leonardo Bianconi Hi Itamar, sorry about the late replay. > Leonardo - slightly related - is this ppc big endian, small endian? any > thoughts on current and future plans around endianes? PPC64 is big endian, but they are working to enable little endian. > also, can you help with my, well, ignorance - are ppc7+/ppc8[1] a newer > cpu level, also not backward compatible, etc.? Yes, Power7 and Power8 are different on family of processors. On the oVirt wiki, pinatti, from IBM, wrote that the CPUs wouldn't be compatible with each other, so I asked him about the backward compatibility and he answered they don't know what will be the compatibility level between Power7 and Power8. More information about Power8 can be found here in http://www.pcworld.com/article/2047733/ibms-power8-opens-up-to-component-makers.html > Thanks, > Itamar > [1] https://lists.nongnu.org/archive/html/qemu-ppc/2013-08/msg00154.html > (courtesy of rich jones) From iheim at redhat.com Tue Oct 8 18:34:16 2013 From: iheim at redhat.com (Itamar Heim) Date: Tue, 08 Oct 2013 21:34:16 +0300 Subject: [Engine-devel] RES: Cluster default with empty processor name with PPC64 support In-Reply-To: <50EB20226B72D6419356FC320AB62B871917E364@SERV070.corp.eldorado.org.br> References: <50EB20226B72D6419356FC320AB62B8719173370@SERV070.corp.eldorado.org.br> <5222F5B7.5060603@redhat.com> <50EB20226B72D6419356FC320AB62B87191733F5@SERV070.corp.eldorado.org.br> <522715D2.8080103@redhat.com> <50EB20226B72D6419356FC320AB62B8719173649@SERV070.corp.eldorado.org.br>, <52481535.1040004@redhat.com> <50EB20226B72D6419356FC320AB62B871917E364@SERV070.corp.eldorado.org.br> Message-ID: <52545028.6050101@redhat.com> On 10/08/2013 09:25 PM, Leonardo Bianconi wrote: > > ________________________________________ > De: Itamar Heim [iheim at redhat.com] > Enviado: domingo, 29 de setembro de 2013 8:55 > Para: Leonardo Bianconi > Cc: Roy Golan; engine-devel at ovirt.org > Assunto: Re: [Engine-devel] Cluster default with empty processor name with PPC64 support > On 09/04/2013 03:50 PM, Leonardo Bianconi wrote: >> >> >>> -----Original Message----- >>> From: Roy Golan [mailto:rgolan at redhat.com] >>> Sent: quarta-feira, 4 de setembro de 2013 08:13 >>> To: Leonardo Bianconi >>> Cc: engine-devel at ovirt.org >>> Subject: Re: [Engine-devel] Cluster default with empty processor name with PPC64 support >>> >>> On 09/02/2013 03:35 PM, Leonardo Bianconi wrote: >>>> >>>>>> From: Roy Golan [mailto:rgolan at redhat.com] >>>>>> Sent: domingo, 1 de setembro de 2013 05:07 >>>>>> To: Leonardo Bianconi >>>>>> Cc: engine-devel at ovirt.org >>>>>> Subject: Re: [Engine-devel] Cluster default with empty processor >>>>>> name with PPC64 support >>>>>> >>>>>> On 08/30/2013 10:51 PM, Leonardo Bianconi wrote: >>>>>> Hi everyone! >>>>>> >>>>>> During the development of PPC64 support in the engine, we faced some UX issues regarding the default Cluster (that Cluster with >>> empty processor name). >>>>>> >>>>>> Currently, oVirt engine allows the default Cluster to contain empty processor name, and the administrator can add VMs and/or >>> Templates to it. The processor name can be assigned later, editing the cluster or assigning a valid host to it. >>>>>> >>>>>> During the implementation of PPC64 support on the engine, the field "architecture" was added to Clusters, VMs and Templates >>> entities. >>>>>> >>>>>> So we have the following questions regarding how the UI should behave: >>>>>> >>>>>> - Shall we keep allowing the administrator to assign VMs and Templates to the Cluster with no processor name or assigned >>> architecture ? >>>>>> -> If we have an "yes" for the question above: >>>>>> -- We will have to assign the architecture to the Cluster based on the OS of the first assigned VM, and the processor name >>> could be defined the same way as currently ... editing the Cluster or assigning a compatible Host to it. >>>>>> -- The VM creation popup will have to be able to indicate the architecture of each OS ... some OSes have the same >>> name, and it may get ambiguous since the Cluster architecture is still undefined at that point (before the first VM get already created). >>>>>> >>>>>> Thanks! >>>>>> Regards. >>>>>> Leonardo Bianconi >>>>>> >>>>> To add VMs you anyway need a running host in the cluster which means the cpu name and the architecture would be the host's. >>>>> So we can keep the cluster attributes - "cpu name" and "arch" consistent and allow them to be empty on creation. >>>>> >>>>> >>>> Hi Roy! >>>> >>>> There is a way to add VMs in a cluster with no hosts running. Steps to reproduce: >>>> - Initialize the oVirt engine with a new data base >>>> - Create a new Cluster (I will call it of newCluster) in the Data >>>> Center Default >>>> - Add a host in the newCluster >>>> - Add a Storage >>>> - Create a VM in the Cluster Default >>>> Result: The system allows a VM in a cluster with no Hosts running in it. >>>> >>>> Is it a bug or a system functionality? If it's a functionality, the issue above can happen. >>> Just to clear this one - its a functional thing. its a bit confusing but not too complicated: >>> >>> Storage and all its related actions/entities are related to the Data Center (aka, code-wise storage pool). Its possible to create a VM >>> once the DC is up, without a cluster i.e also provision disks to it and so on. >>> >>> Cluster is know as the "migration domain" wrt VMs. so CPU arch stuff, network config etc, must be homogeneous in order for VMs to >>> migrate between hosts which means we must have a running cluster i.e at least 1 running host in it. >>> >> Roy, thank you for the explanation! It`s clear now >>> >>>> >>>> Thanks!! >>>> Regards. >>>> Leonardo Bianconi > > Hi Itamar, sorry about the late replay. > >> Leonardo - slightly related - is this ppc big endian, small endian? any >> thoughts on current and future plans around endianes? > > PPC64 is big endian, but they are working to enable little endian. > >> also, can you help with my, well, ignorance - are ppc7+/ppc8[1] a newer >> cpu level, also not backward compatible, etc.? > > Yes, Power7 and Power8 are different on family of processors. On the oVirt wiki, pinatti, from IBM, wrote that the CPUs wouldn't be compatible with each other, so I asked him about the backward compatibility and he answered they don't know what will be the compatibility level between Power7 and Power8. > > More information about Power8 can be found here in http://www.pcworld.com/article/2047733/ibms-power8-opens-up-to-component-makers.html > >> Thanks, >> Itamar >> [1] https://lists.nongnu.org/archive/html/qemu-ppc/2013-08/msg00154.html >> (courtesy of rich jones) ok, i guess we'll handle little endian and power8 when they become relevant... From lvernia at redhat.com Wed Oct 9 08:34:29 2013 From: lvernia at redhat.com (Lior Vernia) Date: Wed, 09 Oct 2013 10:34:29 +0200 Subject: [Engine-devel] GUI widget for adding/removing entries Message-ID: <52551515.2090503@redhat.com> Hello, Lately a patch has been merged that introduces a widget for adding/removing entries (e.g. network interfaces when creating/editing a VM): http://gerrit.ovirt.org/#/c/19530/ This kind of widgets is becoming common in oVirt, so the idea is to make adding one easy rather than copying & pasting code. AddRemoveRowWidget takes care of the plus/minus button logic, disabling an entry that hasn't been edited, and the arranging in rows. In order to use it, one is required to override a couple of abstract methods that are dependent upon the specific entry implementation. An example may be found in ProfilesInstanceTypeEditor, which handles adding/removing network interfaces in the new/edit VM dialog. Yours, Lior. From mpastern at redhat.com Wed Oct 9 09:07:07 2013 From: mpastern at redhat.com (Michael Pasternak) Date: Wed, 09 Oct 2013 11:07:07 +0200 Subject: [Engine-devel] ovirt-engine-sdk-java 1.0.0.18-1 released In-Reply-To: <52305446.9010704@redhat.com> References: <52305446.9010704@redhat.com> Message-ID: <52551CBB.4010809@redhat.com> More details can be found at [1]. [1] http://www.ovirt.org/Java-sdk-changelog -- Michael Pasternak RedHat, ENG-Virtualization R&D From mpastern at redhat.com Wed Oct 9 09:17:52 2013 From: mpastern at redhat.com (Michael Pasternak) Date: Wed, 09 Oct 2013 11:17:52 +0200 Subject: [Engine-devel] ovirt-engine-sdk-python 3.3.07-1 released In-Reply-To: <5230563B.4030004@redhat.com> References: <5230563B.4030004@redhat.com> Message-ID: <52551F40.7040908@redhat.com> For more details see [1]. * note for pypi users: 3.3 sdk was renamed to ovirt-engine-sdk-python and hosted at [2], old repository [3] contains 3.2 artifacts only. [1] http://wiki.ovirt.org/Python-sdk-changelog [2] https://pypi.python.org/pypi/ovirt-engine-sdk-python [3] https://pypi.python.org/pypi/ovirt-engine-sdk -- Michael Pasternak RedHat, ENG-Virtualization R&D From mpastern at redhat.com Wed Oct 9 09:21:16 2013 From: mpastern at redhat.com (Michael Pasternak) Date: Wed, 09 Oct 2013 11:21:16 +0200 Subject: [Engine-devel] ovirt-engine-cli 3.3.0.5-1 released In-Reply-To: <51E55453.2020905@redhat.com> References: <51E55453.2020905@redhat.com> Message-ID: <5255200C.8090909@redhat.com> More details can be found at [1]. [1] http://wiki.ovirt.org/Cli-changelog -- Michael Pasternak RedHat, ENG-Virtualization R&D From dneary at redhat.com Wed Oct 9 10:07:45 2013 From: dneary at redhat.com (Dave Neary) Date: Wed, 09 Oct 2013 12:07:45 +0200 Subject: [Engine-devel] [vdsm] stale gerrit patches In-Reply-To: <524019CA.3080608@redhat.com> References: <524019CA.3080608@redhat.com> Message-ID: <52552AF1.3060802@redhat.com> Hi, On 09/23/2013 12:36 PM, Itamar Heim wrote: > we have some very old gerrit patches. > I'm for abandoning patches which were not touched over 60 days (to begin > with, I think the number should actually be lower). > they can always be re-opened by any interested party post their closure. > > i.e., looking at gerrit, the patch list should actually get attention, > and not be a few worth looking at, with a "lot of old patches" I'm coming late to this discussion, but I see that there were some dissenting views from people who want maintainers to be able to store "in-progress" patches in Gerrit. I am all in favour of treating Gerrit like we treat a bug tracker. If something is opened in the bug tracker, it should be a bug, an open bug is something to be fixed or closed, not to be left indefinitely. An open patch needs to be rejected, reviewed, revised or committed. I don't think Gerrit is the place for in-progress patches (use private branches for that). Cheers, Dave. -- Dave Neary - Community Action and Impact Open Source and Standards, Red Hat - http://community.redhat.com Ph: +33 9 50 71 55 62 / Cell: +33 6 77 01 92 13 From dcaroest at redhat.com Wed Oct 9 10:16:09 2013 From: dcaroest at redhat.com (David Caro Estevez) Date: Wed, 9 Oct 2013 06:16:09 -0400 (EDT) Subject: [Engine-devel] [vdsm] stale gerrit patches In-Reply-To: <52552AF1.3060802@redhat.com> References: <524019CA.3080608@redhat.com> <52552AF1.3060802@redhat.com> Message-ID: <531846304.4238740.1381313769463.JavaMail.root@redhat.com> ----- Original Message ----- > From: "Dave Neary" > To: "Itamar Heim" > Cc: "engine-devel" , vdsm-devel at lists.fedorahosted.org > Sent: Wednesday, October 9, 2013 12:07:45 PM > Subject: Re: [vdsm] stale gerrit patches > > Hi, > > On 09/23/2013 12:36 PM, Itamar Heim wrote: > > we have some very old gerrit patches. > > I'm for abandoning patches which were not touched over 60 days (to begin > > with, I think the number should actually be lower). > > they can always be re-opened by any interested party post their closure. > > > > i.e., looking at gerrit, the patch list should actually get attention, > > and not be a few worth looking at, with a "lot of old patches" > > I'm coming late to this discussion, but I see that there were some > dissenting views from people who want maintainers to be able to store > "in-progress" patches in Gerrit. > > I am all in favour of treating Gerrit like we treat a bug tracker. If > something is opened in the bug tracker, it should be a bug, an open bug > is something to be fixed or closed, not to be left indefinitely. An open > patch needs to be rejected, reviewed, revised or committed. I don't > think Gerrit is the place for in-progress patches (use private branches > for that). Just point out that you can also use 'drafts' to store those in progress changes: http://gerrit-documentation.googlecode.com/svn/ReleaseNotes/ReleaseNotes-2.3.html#_drafts > > Cheers, > Dave. > > -- > Dave Neary - Community Action and Impact > Open Source and Standards, Red Hat - http://community.redhat.com > Ph: +33 9 50 71 55 62 / Cell: +33 6 77 01 92 13 > _______________________________________________ > vdsm-devel mailing list > vdsm-devel at lists.fedorahosted.org > https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel > From ewoud+ovirt at kohlvanwijngaarden.nl Wed Oct 9 10:18:24 2013 From: ewoud+ovirt at kohlvanwijngaarden.nl (Ewoud Kohl van Wijngaarden) Date: Wed, 9 Oct 2013 12:18:24 +0200 Subject: [Engine-devel] [vdsm] stale gerrit patches In-Reply-To: <531846304.4238740.1381313769463.JavaMail.root@redhat.com> References: <524019CA.3080608@redhat.com> <52552AF1.3060802@redhat.com> <531846304.4238740.1381313769463.JavaMail.root@redhat.com> Message-ID: <20131009101824.GF28877@bogey.xentower.nl> On Wed, Oct 09, 2013 at 06:16:09AM -0400, David Caro Estevez wrote: > > > ----- Original Message ----- > > From: "Dave Neary" > > To: "Itamar Heim" > > Cc: "engine-devel" , vdsm-devel at lists.fedorahosted.org > > Sent: Wednesday, October 9, 2013 12:07:45 PM > > Subject: Re: [vdsm] stale gerrit patches > > > > Hi, > > > > On 09/23/2013 12:36 PM, Itamar Heim wrote: > > > we have some very old gerrit patches. > > > I'm for abandoning patches which were not touched over 60 days (to begin > > > with, I think the number should actually be lower). > > > they can always be re-opened by any interested party post their closure. > > > > > > i.e., looking at gerrit, the patch list should actually get attention, > > > and not be a few worth looking at, with a "lot of old patches" > > > > I'm coming late to this discussion, but I see that there were some > > dissenting views from people who want maintainers to be able to store > > "in-progress" patches in Gerrit. > > > > I am all in favour of treating Gerrit like we treat a bug tracker. If > > something is opened in the bug tracker, it should be a bug, an open bug > > is something to be fixed or closed, not to be left indefinitely. An open > > patch needs to be rejected, reviewed, revised or committed. I don't > > think Gerrit is the place for in-progress patches (use private branches > > for that). > > Just point out that you can also use 'drafts' to store those in progress changes: http://gerrit-documentation.googlecode.com/svn/ReleaseNotes/ReleaseNotes-2.3.html#_drafts +1 for drafts. git review -D submits your patches as drafts. From ecohen at redhat.com Wed Oct 9 11:24:23 2013 From: ecohen at redhat.com (Einav Cohen) Date: Wed, 9 Oct 2013 07:24:23 -0400 (EDT) Subject: [Engine-devel] GUI widget for adding/removing entries In-Reply-To: <52551515.2090503@redhat.com> References: <52551515.2090503@redhat.com> Message-ID: <1787139028.4279384.1381317863699.JavaMail.root@redhat.com> Hi Lior - can you please provide a screen-shot, so we will know which widget you are referring to? will make it easier for people to decide if and where to use this widget. Many thanks! ---- Regards, Einav ----- Original Message ----- > From: "Lior Vernia" > To: "engine-devel" > Sent: Wednesday, October 9, 2013 4:34:29 AM > Subject: [Engine-devel] GUI widget for adding/removing entries > > Hello, > > Lately a patch has been merged that introduces a widget for > adding/removing entries (e.g. network interfaces when creating/editing a > VM): > > http://gerrit.ovirt.org/#/c/19530/ > > This kind of widgets is becoming common in oVirt, so the idea is to make > adding one easy rather than copying & pasting code. AddRemoveRowWidget > takes care of the plus/minus button logic, disabling an entry that > hasn't been edited, and the arranging in rows. > > In order to use it, one is required to override a couple of abstract > methods that are dependent upon the specific entry implementation. An > example may be found in ProfilesInstanceTypeEditor, which handles > adding/removing network interfaces in the new/edit VM dialog. > > Yours, Lior. > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > From lvernia at redhat.com Wed Oct 9 12:32:09 2013 From: lvernia at redhat.com (Lior Vernia) Date: Wed, 09 Oct 2013 14:32:09 +0200 Subject: [Engine-devel] GUI widget for adding/removing entries In-Reply-To: <1787139028.4279384.1381317863699.JavaMail.root@redhat.com> References: <52551515.2090503@redhat.com> <1787139028.4279384.1381317863699.JavaMail.root@redhat.com> Message-ID: <52554CC9.5020806@redhat.com> Of course, my bad. Attached is a screenshot of the add/edit VM dialog, note the vNIC part on the bottom half of the dialog. On 09/10/13 13:24, Einav Cohen wrote: > Hi Lior - can you please provide a screen-shot, so we will know which widget > you are referring to? > will make it easier for people to decide if and where to use this widget. > > Many thanks! > > ---- > Regards, > Einav > > ----- Original Message ----- >> From: "Lior Vernia" >> To: "engine-devel" >> Sent: Wednesday, October 9, 2013 4:34:29 AM >> Subject: [Engine-devel] GUI widget for adding/removing entries >> >> Hello, >> >> Lately a patch has been merged that introduces a widget for >> adding/removing entries (e.g. network interfaces when creating/editing a >> VM): >> >> http://gerrit.ovirt.org/#/c/19530/ >> >> This kind of widgets is becoming common in oVirt, so the idea is to make >> adding one easy rather than copying & pasting code. AddRemoveRowWidget >> takes care of the plus/minus button logic, disabling an entry that >> hasn't been edited, and the arranging in rows. >> >> In order to use it, one is required to override a couple of abstract >> methods that are dependent upon the specific entry implementation. An >> example may be found in ProfilesInstanceTypeEditor, which handles >> adding/removing network interfaces in the new/edit VM dialog. >> >> Yours, Lior. >> _______________________________________________ >> Engine-devel mailing list >> Engine-devel at ovirt.org >> http://lists.ovirt.org/mailman/listinfo/engine-devel >> -------------- next part -------------- A non-text attachment was scrubbed... Name: AddRemoveRowWidget.png Type: image/png Size: 33402 bytes Desc: not available URL: From mrao at redhat.com Wed Oct 9 15:36:39 2013 From: mrao at redhat.com (Malini Rao) Date: Wed, 9 Oct 2013 11:36:39 -0400 (EDT) Subject: [Engine-devel] GUI widget for adding/removing entries In-Reply-To: <52554CC9.5020806@redhat.com> References: <52551515.2090503@redhat.com> <1787139028.4279384.1381317863699.JavaMail.root@redhat.com> <52554CC9.5020806@redhat.com> Message-ID: <468002772.4473431.1381332999001.JavaMail.root@redhat.com> I think a few interaction details listed along with the widget will be useful for anyone considering the use of this widget. For example, if the user cannot delete the last field remaining, then the minus will be disabled. Also, if the use case needs the user to be able to insert in any place in the list ( assuming that sequence is important), then building on the current model, the plus button will show on all rows etc. Thanks Malini ----- Original Message ----- From: "Lior Vernia" To: "Einav Cohen" Cc: "engine-devel" Sent: Wednesday, October 9, 2013 8:32:09 AM Subject: Re: [Engine-devel] GUI widget for adding/removing entries Of course, my bad. Attached is a screenshot of the add/edit VM dialog, note the vNIC part on the bottom half of the dialog. On 09/10/13 13:24, Einav Cohen wrote: > Hi Lior - can you please provide a screen-shot, so we will know which widget > you are referring to? > will make it easier for people to decide if and where to use this widget. > > Many thanks! > > ---- > Regards, > Einav > > ----- Original Message ----- >> From: "Lior Vernia" >> To: "engine-devel" >> Sent: Wednesday, October 9, 2013 4:34:29 AM >> Subject: [Engine-devel] GUI widget for adding/removing entries >> >> Hello, >> >> Lately a patch has been merged that introduces a widget for >> adding/removing entries (e.g. network interfaces when creating/editing a >> VM): >> >> http://gerrit.ovirt.org/#/c/19530/ >> >> This kind of widgets is becoming common in oVirt, so the idea is to make >> adding one easy rather than copying & pasting code. AddRemoveRowWidget >> takes care of the plus/minus button logic, disabling an entry that >> hasn't been edited, and the arranging in rows. >> >> In order to use it, one is required to override a couple of abstract >> methods that are dependent upon the specific entry implementation. An >> example may be found in ProfilesInstanceTypeEditor, which handles >> adding/removing network interfaces in the new/edit VM dialog. >> >> Yours, Lior. >> _______________________________________________ >> Engine-devel mailing list >> Engine-devel at ovirt.org >> http://lists.ovirt.org/mailman/listinfo/engine-devel >> _______________________________________________ Engine-devel mailing list Engine-devel at ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel From iheim at redhat.com Wed Oct 9 21:34:10 2013 From: iheim at redhat.com (Itamar Heim) Date: Thu, 10 Oct 2013 00:34:10 +0300 Subject: [Engine-devel] GUI widget for adding/removing entries In-Reply-To: <52554CC9.5020806@redhat.com> References: <52551515.2090503@redhat.com> <1787139028.4279384.1381317863699.JavaMail.root@redhat.com> <52554CC9.5020806@redhat.com> Message-ID: <5255CBD2.7090606@redhat.com> On 10/09/2013 03:32 PM, Lior Vernia wrote: > Of course, my bad. Attached is a screenshot of the add/edit VM dialog, > note the vNIC part on the bottom half of the dialog. how is it different from the custom properties one? > > On 09/10/13 13:24, Einav Cohen wrote: >> Hi Lior - can you please provide a screen-shot, so we will know which widget >> you are referring to? >> will make it easier for people to decide if and where to use this widget. >> >> Many thanks! >> >> ---- >> Regards, >> Einav >> >> ----- Original Message ----- >>> From: "Lior Vernia" >>> To: "engine-devel" >>> Sent: Wednesday, October 9, 2013 4:34:29 AM >>> Subject: [Engine-devel] GUI widget for adding/removing entries >>> >>> Hello, >>> >>> Lately a patch has been merged that introduces a widget for >>> adding/removing entries (e.g. network interfaces when creating/editing a >>> VM): >>> >>> http://gerrit.ovirt.org/#/c/19530/ >>> >>> This kind of widgets is becoming common in oVirt, so the idea is to make >>> adding one easy rather than copying & pasting code. AddRemoveRowWidget >>> takes care of the plus/minus button logic, disabling an entry that >>> hasn't been edited, and the arranging in rows. >>> >>> In order to use it, one is required to override a couple of abstract >>> methods that are dependent upon the specific entry implementation. An >>> example may be found in ProfilesInstanceTypeEditor, which handles >>> adding/removing network interfaces in the new/edit VM dialog. >>> >>> Yours, Lior. >>> _______________________________________________ >>> Engine-devel mailing list >>> Engine-devel at ovirt.org >>> http://lists.ovirt.org/mailman/listinfo/engine-devel >>> >>> >>> >>> _______________________________________________ >>> Engine-devel mailing list >>> Engine-devel at ovirt.org >>> http://lists.ovirt.org/mailman/listinfo/engine-devel From lvernia at redhat.com Thu Oct 10 07:50:23 2013 From: lvernia at redhat.com (Lior Vernia) Date: Thu, 10 Oct 2013 09:50:23 +0200 Subject: [Engine-devel] GUI widget for adding/removing entries In-Reply-To: <468002772.4473431.1381332999001.JavaMail.root@redhat.com> References: <52551515.2090503@redhat.com> <1787139028.4279384.1381317863699.JavaMail.root@redhat.com> <52554CC9.5020806@redhat.com> <468002772.4473431.1381332999001.JavaMail.root@redhat.com> Message-ID: <52565C3F.6000704@redhat.com> Hi Malini, What do you mean by "listed along with the details"? Did you have something in mind? Maybe tooltips over disabled buttons to explain why they're disabled? Concerning sequence, you're correct of course. However, as far as I'm aware, so far in none of the use cases of this type of widgets was the order important, so that was my postulate when designing this widget. A similar widget could be implemented in case the ordering were important. Lior. On 09/10/13 17:36, Malini Rao wrote: > I think a few interaction details listed along with the widget will be useful for anyone considering the use of this widget. For example, if the user cannot delete the last field remaining, then the minus will be disabled. Also, if the use case needs the user to be able to insert in any place in the list ( assuming that sequence is important), then building on the current model, the plus button will show on all rows etc. > > Thanks > Malini > > ----- Original Message ----- > From: "Lior Vernia" > To: "Einav Cohen" > Cc: "engine-devel" > Sent: Wednesday, October 9, 2013 8:32:09 AM > Subject: Re: [Engine-devel] GUI widget for adding/removing entries > > Of course, my bad. Attached is a screenshot of the add/edit VM dialog, > note the vNIC part on the bottom half of the dialog. > > On 09/10/13 13:24, Einav Cohen wrote: >> Hi Lior - can you please provide a screen-shot, so we will know which widget >> you are referring to? >> will make it easier for people to decide if and where to use this widget. >> >> Many thanks! >> >> ---- >> Regards, >> Einav >> >> ----- Original Message ----- >>> From: "Lior Vernia" >>> To: "engine-devel" >>> Sent: Wednesday, October 9, 2013 4:34:29 AM >>> Subject: [Engine-devel] GUI widget for adding/removing entries >>> >>> Hello, >>> >>> Lately a patch has been merged that introduces a widget for >>> adding/removing entries (e.g. network interfaces when creating/editing a >>> VM): >>> >>> http://gerrit.ovirt.org/#/c/19530/ >>> >>> This kind of widgets is becoming common in oVirt, so the idea is to make >>> adding one easy rather than copying & pasting code. AddRemoveRowWidget >>> takes care of the plus/minus button logic, disabling an entry that >>> hasn't been edited, and the arranging in rows. >>> >>> In order to use it, one is required to override a couple of abstract >>> methods that are dependent upon the specific entry implementation. An >>> example may be found in ProfilesInstanceTypeEditor, which handles >>> adding/removing network interfaces in the new/edit VM dialog. >>> >>> Yours, Lior. >>> _______________________________________________ >>> Engine-devel mailing list >>> Engine-devel at ovirt.org >>> http://lists.ovirt.org/mailman/listinfo/engine-devel >>> > > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > From lvernia at redhat.com Thu Oct 10 07:59:43 2013 From: lvernia at redhat.com (Lior Vernia) Date: Thu, 10 Oct 2013 09:59:43 +0200 Subject: [Engine-devel] GUI widget for adding/removing entries In-Reply-To: <5255CBD2.7090606@redhat.com> References: <52551515.2090503@redhat.com> <1787139028.4279384.1381317863699.JavaMail.root@redhat.com> <52554CC9.5020806@redhat.com> <5255CBD2.7090606@redhat.com> Message-ID: <52565E6F.2060509@redhat.com> On 09/10/13 23:34, Itamar Heim wrote: > On 10/09/2013 03:32 PM, Lior Vernia wrote: >> Of course, my bad. Attached is a screenshot of the add/edit VM dialog, >> note the vNIC part on the bottom half of the dialog. > > how is it different from the custom properties one? > Design-wise, there are a couple of small differences. There's only one button next to each row, plus if it's the last row or minus otherwise (so items can only be added at the end, as I replied to Malini order hasn't been important so far). A row appears as disabled until it is edited, and a disabled row is ignored when the view is flushed back to the model (e.g. when the user presses OK in the dialog). Code-wise, it's constructed to be reusable, which the custom properties widget wasn't :) >> >> On 09/10/13 13:24, Einav Cohen wrote: >>> Hi Lior - can you please provide a screen-shot, so we will know which >>> widget >>> you are referring to? >>> will make it easier for people to decide if and where to use this >>> widget. >>> >>> Many thanks! >>> >>> ---- >>> Regards, >>> Einav >>> >>> ----- Original Message ----- >>>> From: "Lior Vernia" >>>> To: "engine-devel" >>>> Sent: Wednesday, October 9, 2013 4:34:29 AM >>>> Subject: [Engine-devel] GUI widget for adding/removing entries >>>> >>>> Hello, >>>> >>>> Lately a patch has been merged that introduces a widget for >>>> adding/removing entries (e.g. network interfaces when >>>> creating/editing a >>>> VM): >>>> >>>> http://gerrit.ovirt.org/#/c/19530/ >>>> >>>> This kind of widgets is becoming common in oVirt, so the idea is to >>>> make >>>> adding one easy rather than copying & pasting code. AddRemoveRowWidget >>>> takes care of the plus/minus button logic, disabling an entry that >>>> hasn't been edited, and the arranging in rows. >>>> >>>> In order to use it, one is required to override a couple of abstract >>>> methods that are dependent upon the specific entry implementation. An >>>> example may be found in ProfilesInstanceTypeEditor, which handles >>>> adding/removing network interfaces in the new/edit VM dialog. >>>> >>>> Yours, Lior. >>>> _______________________________________________ >>>> Engine-devel mailing list >>>> Engine-devel at ovirt.org >>>> http://lists.ovirt.org/mailman/listinfo/engine-devel >>>> >>>> >>>> >>>> _______________________________________________ >>>> Engine-devel mailing list >>>> Engine-devel at ovirt.org >>>> http://lists.ovirt.org/mailman/listinfo/engine-devel > From iheim at redhat.com Thu Oct 10 07:02:43 2013 From: iheim at redhat.com (Itamar Heim) Date: Thu, 10 Oct 2013 10:02:43 +0300 Subject: [Engine-devel] GUI widget for adding/removing entries In-Reply-To: <52565E6F.2060509@redhat.com> References: <52551515.2090503@redhat.com> <1787139028.4279384.1381317863699.JavaMail.root@redhat.com> <52554CC9.5020806@redhat.com> <5255CBD2.7090606@redhat.com> <52565E6F.2060509@redhat.com> Message-ID: <52565113.9010103@redhat.com> On 10/10/2013 10:59 AM, Lior Vernia wrote: > > > On 09/10/13 23:34, Itamar Heim wrote: >> On 10/09/2013 03:32 PM, Lior Vernia wrote: >>> Of course, my bad. Attached is a screenshot of the add/edit VM dialog, >>> note the vNIC part on the bottom half of the dialog. >> >> how is it different from the custom properties one? >> > > Design-wise, there are a couple of small differences. There's only one > button next to each row, plus if it's the last row or minus otherwise > (so items can only be added at the end, as I replied to Malini order > hasn't been important so far). A row appears as disabled until it is > edited, and a disabled row is ignored when the view is flushed back to > the model (e.g. when the user presses OK in the dialog). > > Code-wise, it's constructed to be reusable, which the custom properties > widget wasn't :) could we converge on one of them though? > >>> >>> On 09/10/13 13:24, Einav Cohen wrote: >>>> Hi Lior - can you please provide a screen-shot, so we will know which >>>> widget >>>> you are referring to? >>>> will make it easier for people to decide if and where to use this >>>> widget. >>>> >>>> Many thanks! >>>> >>>> ---- >>>> Regards, >>>> Einav >>>> >>>> ----- Original Message ----- >>>>> From: "Lior Vernia" >>>>> To: "engine-devel" >>>>> Sent: Wednesday, October 9, 2013 4:34:29 AM >>>>> Subject: [Engine-devel] GUI widget for adding/removing entries >>>>> >>>>> Hello, >>>>> >>>>> Lately a patch has been merged that introduces a widget for >>>>> adding/removing entries (e.g. network interfaces when >>>>> creating/editing a >>>>> VM): >>>>> >>>>> http://gerrit.ovirt.org/#/c/19530/ >>>>> >>>>> This kind of widgets is becoming common in oVirt, so the idea is to >>>>> make >>>>> adding one easy rather than copying & pasting code. AddRemoveRowWidget >>>>> takes care of the plus/minus button logic, disabling an entry that >>>>> hasn't been edited, and the arranging in rows. >>>>> >>>>> In order to use it, one is required to override a couple of abstract >>>>> methods that are dependent upon the specific entry implementation. An >>>>> example may be found in ProfilesInstanceTypeEditor, which handles >>>>> adding/removing network interfaces in the new/edit VM dialog. >>>>> >>>>> Yours, Lior. >>>>> _______________________________________________ >>>>> Engine-devel mailing list >>>>> Engine-devel at ovirt.org >>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel >>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Engine-devel mailing list >>>>> Engine-devel at ovirt.org >>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel >> From lvernia at redhat.com Thu Oct 10 08:44:47 2013 From: lvernia at redhat.com (Lior Vernia) Date: Thu, 10 Oct 2013 10:44:47 +0200 Subject: [Engine-devel] GUI widget for adding/removing entries In-Reply-To: <52565113.9010103@redhat.com> References: <52551515.2090503@redhat.com> <1787139028.4279384.1381317863699.JavaMail.root@redhat.com> <52554CC9.5020806@redhat.com> <5255CBD2.7090606@redhat.com> <52565E6F.2060509@redhat.com> <52565113.9010103@redhat.com> Message-ID: <525668FF.3020102@redhat.com> To my knowledge, such a widget existed only in two other places: custom properties and vNIC profiles in add/edit network dialog. In both of them the order wasn't important, in which case the new widget is probably preferable. If it is indeed preferable (Einav? Malini?), I could do some refactoring to have both of them use it. On 10/10/13 09:02, Itamar Heim wrote: > On 10/10/2013 10:59 AM, Lior Vernia wrote: >> >> >> On 09/10/13 23:34, Itamar Heim wrote: >>> On 10/09/2013 03:32 PM, Lior Vernia wrote: >>>> Of course, my bad. Attached is a screenshot of the add/edit VM dialog, >>>> note the vNIC part on the bottom half of the dialog. >>> >>> how is it different from the custom properties one? >>> >> >> Design-wise, there are a couple of small differences. There's only one >> button next to each row, plus if it's the last row or minus otherwise >> (so items can only be added at the end, as I replied to Malini order >> hasn't been important so far). A row appears as disabled until it is >> edited, and a disabled row is ignored when the view is flushed back to >> the model (e.g. when the user presses OK in the dialog). >> >> Code-wise, it's constructed to be reusable, which the custom properties >> widget wasn't :) > > could we converge on one of them though? > >> >>>> >>>> On 09/10/13 13:24, Einav Cohen wrote: >>>>> Hi Lior - can you please provide a screen-shot, so we will know which >>>>> widget >>>>> you are referring to? >>>>> will make it easier for people to decide if and where to use this >>>>> widget. >>>>> >>>>> Many thanks! >>>>> >>>>> ---- >>>>> Regards, >>>>> Einav >>>>> >>>>> ----- Original Message ----- >>>>>> From: "Lior Vernia" >>>>>> To: "engine-devel" >>>>>> Sent: Wednesday, October 9, 2013 4:34:29 AM >>>>>> Subject: [Engine-devel] GUI widget for adding/removing entries >>>>>> >>>>>> Hello, >>>>>> >>>>>> Lately a patch has been merged that introduces a widget for >>>>>> adding/removing entries (e.g. network interfaces when >>>>>> creating/editing a >>>>>> VM): >>>>>> >>>>>> http://gerrit.ovirt.org/#/c/19530/ >>>>>> >>>>>> This kind of widgets is becoming common in oVirt, so the idea is to >>>>>> make >>>>>> adding one easy rather than copying & pasting code. >>>>>> AddRemoveRowWidget >>>>>> takes care of the plus/minus button logic, disabling an entry that >>>>>> hasn't been edited, and the arranging in rows. >>>>>> >>>>>> In order to use it, one is required to override a couple of abstract >>>>>> methods that are dependent upon the specific entry implementation. An >>>>>> example may be found in ProfilesInstanceTypeEditor, which handles >>>>>> adding/removing network interfaces in the new/edit VM dialog. >>>>>> >>>>>> Yours, Lior. >>>>>> _______________________________________________ >>>>>> Engine-devel mailing list >>>>>> Engine-devel at ovirt.org >>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel >>>>>> >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Engine-devel mailing list >>>>>> Engine-devel at ovirt.org >>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel >>> > From ecohen at redhat.com Thu Oct 10 14:01:06 2013 From: ecohen at redhat.com (Einav Cohen) Date: Thu, 10 Oct 2013 10:01:06 -0400 (EDT) Subject: [Engine-devel] GUI widget for adding/removing entries In-Reply-To: <525668FF.3020102@redhat.com> References: <52551515.2090503@redhat.com> <1787139028.4279384.1381317863699.JavaMail.root@redhat.com> <52554CC9.5020806@redhat.com> <5255CBD2.7090606@redhat.com> <52565E6F.2060509@redhat.com> <52565113.9010103@redhat.com> <525668FF.3020102@redhat.com> Message-ID: <1080405201.5269235.1381413666292.JavaMail.root@redhat.com> see attached: AFAIK, there are three types of adding-and-removing widget in the application: (1) the one that exists in the customs properties section as well as the cluster policy. in this widget: - the "+" and "-" buttons appear on every row. - row is "identified" by a selected item from a drop down. - input controls in row: drop-down and text box (that appears upon selection of a non-empty value in the drop-down) (2) the one that exists in the vNICs assignment part of the General section in the New VM dialog. in this widget: - the "+" appears only in the last row, "-" appears in all lines but the last row. - row is "identified" by (what seems to be a) read-only label (I assume that this widget is built to be initially loaded to already contain a number of rows, as opposed to (1), which typically starts with no rows / initial "empty" row. - input controls in row: drop-down (3) the one that exists in the vNIC profiles section in the Add/Edit Network dialog in this widget: - the "+" and "-" buttons appear on every row. - row is "identified" by a free-text string. - input controls in row: text-box, check-box and drop-down. so there are differences between the widgets other than the "+" and "-" buttons. however, from ux perspective, it is important to keep the look-and-feel of all of them consistent. technically (code-wise), I am not sure how easy it is to merge the three, due to the differences. we can maybe think of creating a general adding-and-removing-entries widget, which can support "ordered" and "non-ordered" flavors (which will affect the "+"/"-" buttons appearance / exact behavior), and it will contain a collection of "abstract" row-widgets (and we will have several implementations of row-widgets for each needed functionality [(1), (2), (3)] with exact appearance / input controls / behavior/etc.), which may need to support a certain api (e.g. isRowEmpty(), get/set Identifier(), etc.) in order to communicate appropriately with its "parent" adding-and-removing-entries widget. thoughts? ----- Original Message ----- > From: "Lior Vernia" > To: "Itamar Heim" > Cc: "engine-devel" > Sent: Thursday, October 10, 2013 4:44:47 AM > Subject: Re: [Engine-devel] GUI widget for adding/removing entries > > To my knowledge, such a widget existed only in two other places: custom > properties and vNIC profiles in add/edit network dialog. In both of them > the order wasn't important, in which case the new widget is probably > preferable. If it is indeed preferable (Einav? Malini?), I could do some > refactoring to have both of them use it. > > On 10/10/13 09:02, Itamar Heim wrote: > > On 10/10/2013 10:59 AM, Lior Vernia wrote: > >> > >> > >> On 09/10/13 23:34, Itamar Heim wrote: > >>> On 10/09/2013 03:32 PM, Lior Vernia wrote: > >>>> Of course, my bad. Attached is a screenshot of the add/edit VM dialog, > >>>> note the vNIC part on the bottom half of the dialog. > >>> > >>> how is it different from the custom properties one? > >>> > >> > >> Design-wise, there are a couple of small differences. There's only one > >> button next to each row, plus if it's the last row or minus otherwise > >> (so items can only be added at the end, as I replied to Malini order > >> hasn't been important so far). A row appears as disabled until it is > >> edited, and a disabled row is ignored when the view is flushed back to > >> the model (e.g. when the user presses OK in the dialog). > >> > >> Code-wise, it's constructed to be reusable, which the custom properties > >> widget wasn't :) > > > > could we converge on one of them though? > > > >> > >>>> > >>>> On 09/10/13 13:24, Einav Cohen wrote: > >>>>> Hi Lior - can you please provide a screen-shot, so we will know which > >>>>> widget > >>>>> you are referring to? > >>>>> will make it easier for people to decide if and where to use this > >>>>> widget. > >>>>> > >>>>> Many thanks! > >>>>> > >>>>> ---- > >>>>> Regards, > >>>>> Einav > >>>>> > >>>>> ----- Original Message ----- > >>>>>> From: "Lior Vernia" > >>>>>> To: "engine-devel" > >>>>>> Sent: Wednesday, October 9, 2013 4:34:29 AM > >>>>>> Subject: [Engine-devel] GUI widget for adding/removing entries > >>>>>> > >>>>>> Hello, > >>>>>> > >>>>>> Lately a patch has been merged that introduces a widget for > >>>>>> adding/removing entries (e.g. network interfaces when > >>>>>> creating/editing a > >>>>>> VM): > >>>>>> > >>>>>> http://gerrit.ovirt.org/#/c/19530/ > >>>>>> > >>>>>> This kind of widgets is becoming common in oVirt, so the idea is to > >>>>>> make > >>>>>> adding one easy rather than copying & pasting code. > >>>>>> AddRemoveRowWidget > >>>>>> takes care of the plus/minus button logic, disabling an entry that > >>>>>> hasn't been edited, and the arranging in rows. > >>>>>> > >>>>>> In order to use it, one is required to override a couple of abstract > >>>>>> methods that are dependent upon the specific entry implementation. An > >>>>>> example may be found in ProfilesInstanceTypeEditor, which handles > >>>>>> adding/removing network interfaces in the new/edit VM dialog. > >>>>>> > >>>>>> Yours, Lior. > >>>>>> _______________________________________________ > >>>>>> Engine-devel mailing list > >>>>>> Engine-devel at ovirt.org > >>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel > >>>>>> > >>>>>> > >>>>>> > >>>>>> _______________________________________________ > >>>>>> Engine-devel mailing list > >>>>>> Engine-devel at ovirt.org > >>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel > >>> > > > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > -------------- next part -------------- A non-text attachment was scrubbed... Name: adding-removing-entries-widgets.png Type: image/png Size: 115121 bytes Desc: not available URL: From tjelinek at redhat.com Fri Oct 11 08:56:03 2013 From: tjelinek at redhat.com (Tomas Jelinek) Date: Fri, 11 Oct 2013 04:56:03 -0400 (EDT) Subject: [Engine-devel] Introducing generics to UiCommon In-Reply-To: <54579635.3393851.1381141050318.JavaMail.root@redhat.com> References: <247427421.11376161.1375688489773.JavaMail.root@redhat.com> <1251012257.4042811.1380281534199.JavaMail.root@redhat.com> <54579635.3393851.1381141050318.JavaMail.root@redhat.com> Message-ID: <1661392185.576605.1381481763699.JavaMail.root@redhat.com> ----- Original Message ----- > From: "Vojtech Szocs" > To: "Tomas Jelinek" > Cc: "engine-devel" , "Daniel Erez" , "Gilad Chaplik" , > "Tal Nisan" , "Alona Kaplan" > Sent: Monday, October 7, 2013 12:17:30 PM > Subject: Re: [Engine-devel] Introducing generics to UiCommon > > Hi Tomas, > > I missed the original mail and just reviewed both patches (+1 from my side). > > I think introducing generics to UiCommon is a step in the right direction; as > you wrote, using non-generic types (i.e. List instead of List) > leads to hidden expectations and type casts that make code harder to read > and maintain (and also impacts GwtCommon/WebAdmin/UserPortal code that needs > to adapt to such code). > > Do we have some general plan to cover UiCommon as a whole? > - patch [1] modifies EntityModel/ListModel, what about other base models? > (i.e. SearchableListModel) > - patch [1] adds String version of EntityModelTextBox, what about other > editor widgets? [*] > according to your original mail, these are: EntityModelLabel, > EntityModelTextAreaLabel, EntityModelPasswordBox, EntityModelTextArea, > ListModelSuggestBox yes, this should be the widgets which needs to be done > - any other change necessary? (aside from modifying specific model classes > such as DataCenterModel) I would say nothing else. > [*] IIUC for each editor widget we need: the widget itself, editor, > renderer/parser (potential reuse) yep > > What about following approach (just a suggestion): > > [separate patch - rebased on patch 1] > - make remaining base models generic too (i.e. SearchableListModel) > - add remaining GUI infra to bind to generic models, i.e. editor widgets and > related stuff well, my idea was to do the infrastructure as needed while refactoring the specific models. But ok, I can prepare this infrastructure patch first. > > [separate patch per specific main tab model] > - make main tab model use generics (including any dialog models referenced > from this code) > - make related sub tab models use generics (including any dialog models > referenced from this code) yes, sounds reasonable. > > Having said that, I value your effort to improve existing code. This is not > an easy task, it will take more patches but I think it's worth it. > > Thanks! > Vojtech > > > ----- Original Message ----- > > From: "Tomas Jelinek" > > To: "engine-devel" > > Cc: "Vojtech Szocs" , "Daniel Erez" , > > "Gilad Chaplik" , > > "Tal Nisan" , "Alona Kaplan" > > Sent: Friday, September 27, 2013 1:32:14 PM > > Subject: Re: [Engine-devel] Introducing generics to UiCommon > > > > Hey all, > > > > some time ago I have created a patch which introduces generics to UiCommon > > [1] and one which uses it > > in DataCenterModel [2]. Today I have changed a bit the generic version of > > the > > EntityModelTextBox to > > be truly generic (since it can edit also e.g. integers) and than a simple > > subclass StringEntityModelTextBox > > which provides the String renderer/parser to simplify the usage. All the > > other details are available in the previous > > mail. > > > > What do you think about it? > > > > Tomas > > > > [1]: http://gerrit.ovirt.org/#/c/17604/ > > [2]: http://gerrit.ovirt.org/#/c/17605/ > > > > ----- Original Message ----- > > > From: "Tomas Jelinek" > > > To: "engine-devel" > > > Sent: Monday, August 5, 2013 9:41:29 AM > > > Subject: [Engine-devel] Introducing generics to UiCommon > > > > > > Hey all, > > > > > > as we have passed the oVirt feature freeze I would like to celebrate it > > > with > > > a little bit of cleanup :) > > > > > > A good candidate for this is to introduce generics into uicommonweb > > > project. > > > The fact that it is not generic > > > brings quite some hidden expectations into our code, makes it unreadable > > > and > > > error prone. > > > > > > Also, the gwt-common and both webadmin and userportal are mostly prepared > > > to > > > be generic but because the uicommonweb is not, we have code like: > > > > > > new ListModelListBoxEditor(new NullSafeRenderer() { > > > @Override > > > public String renderNullSafe(Object object) > > > return ((Version) object).getValue(); > > > } > > > }); > > > > > > which is quite ugly and error prone. > > > > > > So I have prepared two patches, one [1] which introduces the generic > > > infrastructure (and prepares one widget for it, more about this below) > > > and > > > one [2] which uses it and refactors the DataCenterModel > > > to use it (I have chosen this model because it is big enough to show how > > > to > > > do it and what the benefits are but small enough to be quickly > > > review-able). > > > > > > The infrastructure change: > > > - changes the ListModel and EntityModel to be genreic > > > - adjusts the UiCommonEditorDriverGenerator to work with generics (e.g. > > > to > > > make it aware that ListModel is indeed a ListModel, same for > > > EntityModel) > > > - created a String version of EntityModelTextBox > > > > > > The reason why the String EntityModelTextBox had to be created is that > > > the > > > EntityModelTextBox is an EditorWidget so it can work only > > > with > > > EntityModel. I saw 2 ways how to make this work with > > > EntityModel: > > > 1: Create a String version of this editor inside the .generic > > > sub-package, > > > incrementally replace the usage of the non-generic EntityModelTextBox and > > > when the non-generic will be completely replaced, delete it and move the > > > generic one > > > out from the generic sub-package > > > > > > 2: Change the EditorWidget to EditorWidget and > > > replace > > > each usage of the "EntityModelTextBox someWidget" by > > > "EntityModelTextBox someWidget" and than incrementally replace > > > the > > > to as the > > > underlying models will be refactored. After the last one will be > > > refactored, change the EditorWidget to EditorWidget > > ...> > > > and replace all "EntityModelTextBox someWidget" by > > > "EntityModelTextBox someWidget" > > > > > > I have chosen the first option because: > > > - much less classes touched at once (e.g. much more safe) > > > - the EntityModelTextBox invites to use something like > > > EntityModelTextBox which is not correct and fails on class cast > > > exceptions > > > > > > But at the same time I see the disadvantages of this approach (mostly > > > that > > > we > > > have two versions of the same class). Please note that far not all the > > > widgets will need two versions, only the ones editing only Strings which > > > are declared as EditorWidget which are: > > > - EntityModelLabel > > > - EntityModelTextAreaLabel (used only in couple of places - can be > > > refactored > > > together without the need to have two versions) > > > - EntityModelTextBox (already in the [1]) > > > - EntityModelPasswordBox > > > - EntityModelTextArea > > > - ListModelSuggestBox (used only in couple of places - can be refactored > > > together without the need to have two versions) > > > > > > The rest of the widgets should be already prepared to be used in generic > > > environment. > > > > > > Please let me know what do you think about it, > > > > > > have a nice day, > > > Tomas > > > > > > [1]: http://gerrit.ovirt.org/#/c/17604/ > > > [2]: http://gerrit.ovirt.org/#/c/17605/ > > > > > > _______________________________________________ > > > Engine-devel mailing list > > > Engine-devel at ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > From tjelinek at redhat.com Fri Oct 11 13:08:20 2013 From: tjelinek at redhat.com (Tomas Jelinek) Date: Fri, 11 Oct 2013 09:08:20 -0400 (EDT) Subject: [Engine-devel] Introducing generics to UiCommon In-Reply-To: <1661392185.576605.1381481763699.JavaMail.root@redhat.com> References: <247427421.11376161.1375688489773.JavaMail.root@redhat.com> <1251012257.4042811.1380281534199.JavaMail.root@redhat.com> <54579635.3393851.1381141050318.JavaMail.root@redhat.com> <1661392185.576605.1381481763699.JavaMail.root@redhat.com> Message-ID: <592101639.638835.1381496900925.JavaMail.root@redhat.com> ----- Original Message ----- > From: "Tomas Jelinek" > To: "Vojtech Szocs" > Cc: "engine-devel" > Sent: Friday, October 11, 2013 10:56:03 AM > Subject: Re: [Engine-devel] Introducing generics to UiCommon > > > > ----- Original Message ----- > > From: "Vojtech Szocs" > > To: "Tomas Jelinek" > > Cc: "engine-devel" , "Daniel Erez" > > , "Gilad Chaplik" , > > "Tal Nisan" , "Alona Kaplan" > > Sent: Monday, October 7, 2013 12:17:30 PM > > Subject: Re: [Engine-devel] Introducing generics to UiCommon > > > > Hi Tomas, > > > > I missed the original mail and just reviewed both patches (+1 from my > > side). > > > > I think introducing generics to UiCommon is a step in the right direction; > > as > > you wrote, using non-generic types (i.e. List instead of List) > > leads to hidden expectations and type casts that make code harder to read > > and maintain (and also impacts GwtCommon/WebAdmin/UserPortal code that > > needs > > to adapt to such code). > > > > Do we have some general plan to cover UiCommon as a whole? > > - patch [1] modifies EntityModel/ListModel, what about other base models? > > (i.e. SearchableListModel) > > - patch [1] adds String version of EntityModelTextBox, what about other > > editor widgets? [*] > > according to your original mail, these are: EntityModelLabel, > > EntityModelTextAreaLabel, EntityModelPasswordBox, EntityModelTextArea, > > ListModelSuggestBox > > yes, this should be the widgets which needs to be done Ok, no, I have actually found some more widgets which needs to be made generic: EntityModelCheckBox EntityModelCheckBoxOnlyEditor EntityModelRadioButton EntityModelSliderWithTextBoxEditor EntityModelTextBoxOnlyEditor EntityModelInputWithSlider I will provide them in a future patch. > > > - any other change necessary? (aside from modifying specific model classes > > such as DataCenterModel) > > I would say nothing else. > > > [*] IIUC for each editor widget we need: the widget itself, editor, > > renderer/parser (potential reuse) > > yep > > > > > What about following approach (just a suggestion): > > > > [separate patch - rebased on patch 1] > > - make remaining base models generic too (i.e. SearchableListModel) > > - add remaining GUI infra to bind to generic models, i.e. editor widgets > > and > > related stuff > > well, my idea was to do the infrastructure as needed while refactoring the > specific models. > But ok, I can prepare this infrastructure patch first. so I have prepared the second part of the infrastructure patch: http://gerrit.ovirt.org/#/c/20118/ It contains the widgets enumerated above (e.g. EntityModelLabel, EntityModelTextAreaLabel, EntityModelPasswordBox, EntityModelTextArea, ListModelSuggestBox) and the SearchableListModel. > > > > > [separate patch per specific main tab model] > > - make main tab model use generics (including any dialog models referenced > > from this code) > > - make related sub tab models use generics (including any dialog models > > referenced from this code) > > yes, sounds reasonable. > > > > > Having said that, I value your effort to improve existing code. This is not > > an easy task, it will take more patches but I think it's worth it. > > > > Thanks! > > Vojtech > > > > > > ----- Original Message ----- > > > From: "Tomas Jelinek" > > > To: "engine-devel" > > > Cc: "Vojtech Szocs" , "Daniel Erez" > > > , > > > "Gilad Chaplik" , > > > "Tal Nisan" , "Alona Kaplan" > > > Sent: Friday, September 27, 2013 1:32:14 PM > > > Subject: Re: [Engine-devel] Introducing generics to UiCommon > > > > > > Hey all, > > > > > > some time ago I have created a patch which introduces generics to > > > UiCommon > > > [1] and one which uses it > > > in DataCenterModel [2]. Today I have changed a bit the generic version of > > > the > > > EntityModelTextBox to > > > be truly generic (since it can edit also e.g. integers) and than a simple > > > subclass StringEntityModelTextBox > > > which provides the String renderer/parser to simplify the usage. All the > > > other details are available in the previous > > > mail. > > > > > > What do you think about it? > > > > > > Tomas > > > > > > [1]: http://gerrit.ovirt.org/#/c/17604/ > > > [2]: http://gerrit.ovirt.org/#/c/17605/ > > > > > > ----- Original Message ----- > > > > From: "Tomas Jelinek" > > > > To: "engine-devel" > > > > Sent: Monday, August 5, 2013 9:41:29 AM > > > > Subject: [Engine-devel] Introducing generics to UiCommon > > > > > > > > Hey all, > > > > > > > > as we have passed the oVirt feature freeze I would like to celebrate it > > > > with > > > > a little bit of cleanup :) > > > > > > > > A good candidate for this is to introduce generics into uicommonweb > > > > project. > > > > The fact that it is not generic > > > > brings quite some hidden expectations into our code, makes it > > > > unreadable > > > > and > > > > error prone. > > > > > > > > Also, the gwt-common and both webadmin and userportal are mostly > > > > prepared > > > > to > > > > be generic but because the uicommonweb is not, we have code like: > > > > > > > > new ListModelListBoxEditor(new NullSafeRenderer() { > > > > @Override > > > > public String renderNullSafe(Object object) > > > > return ((Version) object).getValue(); > > > > } > > > > }); > > > > > > > > which is quite ugly and error prone. > > > > > > > > So I have prepared two patches, one [1] which introduces the generic > > > > infrastructure (and prepares one widget for it, more about this below) > > > > and > > > > one [2] which uses it and refactors the DataCenterModel > > > > to use it (I have chosen this model because it is big enough to show > > > > how > > > > to > > > > do it and what the benefits are but small enough to be quickly > > > > review-able). > > > > > > > > The infrastructure change: > > > > - changes the ListModel and EntityModel to be genreic > > > > - adjusts the UiCommonEditorDriverGenerator to work with generics (e.g. > > > > to > > > > make it aware that ListModel is indeed a ListModel, same for > > > > EntityModel) > > > > - created a String version of EntityModelTextBox > > > > > > > > The reason why the String EntityModelTextBox had to be created is that > > > > the > > > > EntityModelTextBox is an EditorWidget so it can work only > > > > with > > > > EntityModel. I saw 2 ways how to make this work with > > > > EntityModel: > > > > 1: Create a String version of this editor inside the .generic > > > > sub-package, > > > > incrementally replace the usage of the non-generic EntityModelTextBox > > > > and > > > > when the non-generic will be completely replaced, delete it and move > > > > the > > > > generic one > > > > out from the generic sub-package > > > > > > > > 2: Change the EditorWidget to EditorWidget and > > > > replace > > > > each usage of the "EntityModelTextBox someWidget" by > > > > "EntityModelTextBox someWidget" and than incrementally replace > > > > the > > > > to as the > > > > underlying models will be refactored. After the last one will be > > > > refactored, change the EditorWidget to EditorWidget > > > ...> > > > > and replace all "EntityModelTextBox someWidget" by > > > > "EntityModelTextBox someWidget" > > > > > > > > I have chosen the first option because: > > > > - much less classes touched at once (e.g. much more safe) > > > > - the EntityModelTextBox invites to use something like > > > > EntityModelTextBox which is not correct and fails on class cast > > > > exceptions > > > > > > > > But at the same time I see the disadvantages of this approach (mostly > > > > that > > > > we > > > > have two versions of the same class). Please note that far not all the > > > > widgets will need two versions, only the ones editing only Strings > > > > which > > > > are declared as EditorWidget which are: > > > > - EntityModelLabel > > > > - EntityModelTextAreaLabel (used only in couple of places - can be > > > > refactored > > > > together without the need to have two versions) > > > > - EntityModelTextBox (already in the [1]) > > > > - EntityModelPasswordBox > > > > - EntityModelTextArea > > > > - ListModelSuggestBox (used only in couple of places - can be > > > > refactored > > > > together without the need to have two versions) > > > > > > > > The rest of the widgets should be already prepared to be used in > > > > generic > > > > environment. > > > > > > > > Please let me know what do you think about it, > > > > > > > > have a nice day, > > > > Tomas > > > > > > > > [1]: http://gerrit.ovirt.org/#/c/17604/ > > > > [2]: http://gerrit.ovirt.org/#/c/17605/ > > > > > > > > _______________________________________________ > > > > Engine-devel mailing list > > > > Engine-devel at ovirt.org > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > > > > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > From eedri at redhat.com Sun Oct 13 09:54:24 2013 From: eedri at redhat.com (Eyal Edri) Date: Sun, 13 Oct 2013 05:54:24 -0400 (EDT) Subject: [Engine-devel] Request for Fedora 20 VM In-Reply-To: <1380545532.2666.13.camel@fdeutsch-laptop.local> References: <5249184D.9090800@redhat.com> <1380545532.2666.13.camel@fdeutsch-laptop.local> Message-ID: <1711678079.5801170.1381658064771.JavaMail.root@redhat.com> ----- Original Message ----- > From: "Fabian Deutsch" > To: "Sandro Bonazzola" > Cc: "engine-devel" , infra at ovirt.org > Sent: Monday, September 30, 2013 3:52:12 PM > Subject: Re: Request for Fedora 20 VM > > Am Montag, den 30.09.2013, 08:21 +0200 schrieb Sandro Bonazzola: > > Hi, > > Fedora 20 Alpha has been released and can be downloaded from > > http://fedoraproject.org/get-prerelease. > > I think it's time to start running our tests and build nightly also on > > Fedora 20 in order to discover > > possible compatibility issues. > > Can infra provide a Fedora 20 VM for jenkins use? > > That would also be helpful for us - ovirt-node - to get started with the > F20 migration. @ewoud - is it possible to use oVirt forman to reinstall one of the f18 slaves as f20? > > Greetings > fabian > > _______________________________________________ > Infra mailing list > Infra at ovirt.org > http://lists.ovirt.org/mailman/listinfo/infra > From lvernia at redhat.com Sun Oct 13 14:03:30 2013 From: lvernia at redhat.com (Lior Vernia) Date: Sun, 13 Oct 2013 16:03:30 +0200 Subject: [Engine-devel] GUI widget for adding/removing entries In-Reply-To: <1080405201.5269235.1381413666292.JavaMail.root@redhat.com> References: <52551515.2090503@redhat.com> <1787139028.4279384.1381317863699.JavaMail.root@redhat.com> <52554CC9.5020806@redhat.com> <5255CBD2.7090606@redhat.com> <52565E6F.2060509@redhat.com> <52565113.9010103@redhat.com> <525668FF.3020102@redhat.com> <1080405201.5269235.1381413666292.JavaMail.root@redhat.com> Message-ID: <525AA832.8010500@redhat.com> On 10/10/13 16:01, Einav Cohen wrote: > see attached: AFAIK, there are three types of adding-and-removing widget in the application: > > (1) the one that exists in the customs properties section as well as the cluster policy. > in this widget: > - the "+" and "-" buttons appear on every row. > - row is "identified" by a selected item from a drop down. > - input controls in row: drop-down and text box (that appears upon selection of a non-empty value in the drop-down) > > (2) the one that exists in the vNICs assignment part of the General section in the New VM dialog. > in this widget: > - the "+" appears only in the last row, "-" appears in all lines but the last row. > - row is "identified" by (what seems to be a) read-only label (I assume that this widget is > built to be initially loaded to already contain a number of rows, as opposed to (1), which > typically starts with no rows / initial "empty" row. > - input controls in row: drop-down > > (3) the one that exists in the vNIC profiles section in the Add/Edit Network dialog > in this widget: > - the "+" and "-" buttons appear on every row. > - row is "identified" by a free-text string. > - input controls in row: text-box, check-box and drop-down. > > so there are differences between the widgets other than the "+" and "-" buttons. > however, from ux perspective, it is important to keep the look-and-feel of all of them consistent. > > technically (code-wise), I am not sure how easy it is to merge the three, due to the differences. > we can maybe think of creating a general adding-and-removing-entries widget, which can support > "ordered" and "non-ordered" flavors (which will affect the "+"/"-" buttons appearance / exact > behavior), and it will contain a collection of "abstract" row-widgets (and we will have several > implementations of row-widgets for each needed functionality [(1), (2), (3)] with exact appearance / > input controls / behavior/etc.), which may need to support a certain api (e.g. isRowEmpty(), get/set > Identifier(), etc.) in order to communicate appropriately with its "parent" adding-and-removing-entries > widget. > > thoughts? > What you described is pretty much how the abstract AddRemoveRowWidget works, so it should be fairly easy to merge the three (it was designed to be so). The widget doesn't care about the exact nature of the content widget to the left of the plus/minus button, that information is given when overriding the aforementioned abstract methods. The only difference is that there's only one flavor at the moment, which is orderless, since none of these current examples is mindful of ordering. > ----- Original Message ----- >> From: "Lior Vernia" >> To: "Itamar Heim" >> Cc: "engine-devel" >> Sent: Thursday, October 10, 2013 4:44:47 AM >> Subject: Re: [Engine-devel] GUI widget for adding/removing entries >> >> To my knowledge, such a widget existed only in two other places: custom >> properties and vNIC profiles in add/edit network dialog. In both of them >> the order wasn't important, in which case the new widget is probably >> preferable. If it is indeed preferable (Einav? Malini?), I could do some >> refactoring to have both of them use it. >> >> On 10/10/13 09:02, Itamar Heim wrote: >>> On 10/10/2013 10:59 AM, Lior Vernia wrote: >>>> >>>> >>>> On 09/10/13 23:34, Itamar Heim wrote: >>>>> On 10/09/2013 03:32 PM, Lior Vernia wrote: >>>>>> Of course, my bad. Attached is a screenshot of the add/edit VM dialog, >>>>>> note the vNIC part on the bottom half of the dialog. >>>>> >>>>> how is it different from the custom properties one? >>>>> >>>> >>>> Design-wise, there are a couple of small differences. There's only one >>>> button next to each row, plus if it's the last row or minus otherwise >>>> (so items can only be added at the end, as I replied to Malini order >>>> hasn't been important so far). A row appears as disabled until it is >>>> edited, and a disabled row is ignored when the view is flushed back to >>>> the model (e.g. when the user presses OK in the dialog). >>>> >>>> Code-wise, it's constructed to be reusable, which the custom properties >>>> widget wasn't :) >>> >>> could we converge on one of them though? >>> >>>> >>>>>> >>>>>> On 09/10/13 13:24, Einav Cohen wrote: >>>>>>> Hi Lior - can you please provide a screen-shot, so we will know which >>>>>>> widget >>>>>>> you are referring to? >>>>>>> will make it easier for people to decide if and where to use this >>>>>>> widget. >>>>>>> >>>>>>> Many thanks! >>>>>>> >>>>>>> ---- >>>>>>> Regards, >>>>>>> Einav >>>>>>> >>>>>>> ----- Original Message ----- >>>>>>>> From: "Lior Vernia" >>>>>>>> To: "engine-devel" >>>>>>>> Sent: Wednesday, October 9, 2013 4:34:29 AM >>>>>>>> Subject: [Engine-devel] GUI widget for adding/removing entries >>>>>>>> >>>>>>>> Hello, >>>>>>>> >>>>>>>> Lately a patch has been merged that introduces a widget for >>>>>>>> adding/removing entries (e.g. network interfaces when >>>>>>>> creating/editing a >>>>>>>> VM): >>>>>>>> >>>>>>>> http://gerrit.ovirt.org/#/c/19530/ >>>>>>>> >>>>>>>> This kind of widgets is becoming common in oVirt, so the idea is to >>>>>>>> make >>>>>>>> adding one easy rather than copying & pasting code. >>>>>>>> AddRemoveRowWidget >>>>>>>> takes care of the plus/minus button logic, disabling an entry that >>>>>>>> hasn't been edited, and the arranging in rows. >>>>>>>> >>>>>>>> In order to use it, one is required to override a couple of abstract >>>>>>>> methods that are dependent upon the specific entry implementation. An >>>>>>>> example may be found in ProfilesInstanceTypeEditor, which handles >>>>>>>> adding/removing network interfaces in the new/edit VM dialog. >>>>>>>> >>>>>>>> Yours, Lior. >>>>>>>> _______________________________________________ >>>>>>>> Engine-devel mailing list >>>>>>>> Engine-devel at ovirt.org >>>>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> _______________________________________________ >>>>>>>> Engine-devel mailing list >>>>>>>> Engine-devel at ovirt.org >>>>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel >>>>> >>> >> _______________________________________________ >> Engine-devel mailing list >> Engine-devel at ovirt.org >> http://lists.ovirt.org/mailman/listinfo/engine-devel >> >> From sbonazzo at redhat.com Wed Oct 16 06:30:50 2013 From: sbonazzo at redhat.com (Sandro Bonazzola) Date: Wed, 16 Oct 2013 08:30:50 +0200 Subject: [Engine-devel] 3.3.1 Release tracker Message-ID: <525E329A.7050103@redhat.com> Hi, as you may know, we're planning to build oVirt 3.3.1 beta really soon and release 3.3.1 by the end of October. Ofer has created a tracker bug (https://bugzilla.redhat.com/show_bug.cgi?id=1019391) for this release. Only 2 bugs considered blocking up to now are both in modified state, so we're in a good shape for 3.3.1 beta build. The following is a list of the bugs with target 3.3.1 or 3.3: "Bug ID","Component","Summary","Status","Target Release","Assignee","Whiteboard" 988354,"ovirt-engine-webadmin","nic->network assignement not working for VM created from template with disk","POST",3.3,"tjelinek at redhat.com","network" 988067,"ovirt-engine-sdk-java","Adding a cluster with incomplete version fails with exception","ASSIGNED",3.3,"oliel at redhat.com","infra" 904149,"ovirt-engine-installer","engine-cleanup doesn't remove iso nfs export","ASSIGNED",3.3,"didi at redhat.com","integration" 1017267,"ovirt-engine-core","Plaintext user passwords in async_tasks database","ASSIGNED","3.3.1","emesika at redhat.com","infra" 987897,"ovirt-engine-webadmin","VM - network interfaces subtab has a delayed refresh and displays wrong info for a while","NEW",3.3,"nobody at fedoraproject.org","network" 988016,"ovirt-engine-webadmin","Specify custom MAC address in new/edit VNIC dialog for templates shouldn't exist","NEW",3.3,"nobody at fedoraproject.org","network" 987935,"ovirt-engine-webadmin","[oVirt] [neutron] Networking plugin type doesn't reappear after test","NEW",3.3,"lpeer at redhat.com","network" 988002,"ovirt-engine-webadmin","[oVirt] [network] Add button shouldn't appear on specific network","NEW",3.3,"lpeer at redhat.com","network" 987933,"ovirt-engine-webadmin","[oVirt] [provider] Type list is not sorted in add dialog","NEW",3.3,"lpeer at redhat.com","network" 987949,"ovirt-engine-webadmin","[oVirt] [provider] It's seemingly possible to add a provider with the same name","NEW",3.3,"lpeer at redhat.com","network" 987916,"ovirt-engine-webadmin","[oVirt] [provider] Dialog doesn't update unless focus lost","NEW",3.3,"lpeer at redhat.com","network" 987999,"ovirt-engine-webadmin","[oVirt] [provider] Add button shouldn't appear on specific provider","NEW",3.3,"lpeer at redhat.com","network" 987982,"ovirt-engine-api","When adding a host through the REST API, the error message says that ""rootPassword"" is required, but the actual field name is ""root_password""","NEW",3.3,"mpastern at redhat.com","infra" 987887,"ovirt-engine-webadmin","Error message when reports portal is not installed","NEW",3.3,"mtayer at redhat.com","infra" 915753,"ovirt-engine-core","Deadlock detected during creation vms in pool","NEW",3.3,"laravot at redhat.com","storage" 987917,"ovirt-engine-webadmin","[oVirt] [glance] API version not specified in provider dialog","NEW",3.3,"fsimonce at redhat.com","storage" 987832,"vdsm","failed to add ovirtmgmt bridge when the host has static ip","NEW",3.3,"lpeer at redhat.com","network" 991267,"ovirt-node","[RFE] Add TUI information to log file.","POST",3.3,"fdeutsch at redhat.com", 1009899,"ovirt-engine-core","exportDbSchema scripts generates output file with wrong name","POST","3.3.1","emesika at redhat.com","infra" 990854,"vdsm","Multiple Gateways: Upgrade VDSM to 3.3 must reconfigure networking on host","NEW",3.3,"amuller at redhat.com","network" Please set the target to 3.3.1 and add the bug to the tracker if you think that 3.3.1 should not be released without it fixed. Please also update the target to 3.3.2 or any next release for bugs that won't be in 3.3.1: it will ease gathering the blocking bugs for next releases. -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com From eedri at redhat.com Wed Oct 16 07:02:18 2013 From: eedri at redhat.com (Eyal Edri) Date: Wed, 16 Oct 2013 03:02:18 -0400 (EDT) Subject: [Engine-devel] [JENKINS] failure in upstream job - conflict in db file name In-Reply-To: <309810262.7620817.1381906788226.JavaMail.root@redhat.com> Message-ID: <1039085388.7622258.1381906938194.JavaMail.root@redhat.com> fyi, following patches broke the db scripts (wrong order of naming): core: Fix PinToHostPolicyUnit when PinToHost is enabled (details) core: Use pin to host only when present in cluster policy (details) engine: adding no-arg constructor to RemoveVdsParameters (details) [core] rename VdsStatic hostname to hostName. (details) webadmin: Hide "public" InfoIcon if checkbox hidden (details) error: Running upgrade sql script upgrade/03_03_0910_remove_migration_filter.sql ... Running upgrade sql script upgrade/03_03_0920_add_fqdn_to_vm_dynamic.sql ... Running upgrade sql script upgrade/03_03_0930_add_dwh_heartbeat.sql ... Running upgrade sql script upgrade/03_03_0940_clear_snapshot_id_of_floating_disks.sql ... Illegal script version number 03030990,version should be in max 10 gap from last installed version: 03030940 Please fix numbering to interval 03030941 to 03030950 and run the upgrade script. Failed to create schema for database ovirt_engine_dao_unit_tests_gerrit_50 Build step 'Execute shell' marked build as failure Performing Post build task... Could not match :INFO : False Logical operation result is FALSE Skipping script : dropdb -U postgres ${JOB_NAME}_${BUILD_NUMBER} || /bin/true END OF POST BUILD TASK : 0 Recording test results Email was triggered for: Failure full log: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests_gerrit/50/console From sbonazzo at redhat.com Wed Oct 16 07:05:26 2013 From: sbonazzo at redhat.com (Sandro Bonazzola) Date: Wed, 16 Oct 2013 09:05:26 +0200 Subject: [Engine-devel] 3.3.1 Release tracker In-Reply-To: <525E329A.7050103@redhat.com> References: <525E329A.7050103@redhat.com> Message-ID: <525E3AB6.7020202@redhat.com> Il 16/10/2013 08:30, Sandro Bonazzola ha scritto: > Hi, > > as you may know, we're planning to build oVirt 3.3.1 beta really soon and release 3.3.1 by the end of October. > Ofer has created a tracker bug (https://bugzilla.redhat.com/show_bug.cgi?id=1019391) for this release. > Only 2 bugs considered blocking up to now are both in modified state, so we're in a good shape for 3.3.1 beta build. > > The following is a list of the bugs with target 3.3.1 or 3.3: Reordered and simplified the list: Whiteboard, Bug ID, Summary infra, 987887, Error message when reports portal is not installed infra, 987982, "When adding a host through the REST API, the error message says that ""rootPassword"" is required, ... infra, 988067, Adding a cluster with incomplete version fails with exception infra, 1009899, exportDbSchema scripts generates output file with wrong name infra, 1017267, Plaintext user passwords in async_tasks database integration, 904149, engine-cleanup doesn't remove iso nfs export network, 987832, failed to add ovirtmgmt bridge when the host has static ip network, 987897, VM - network interfaces subtab has a delayed refresh and displays wrong info for a while network, 987916, [oVirt] [provider] Dialog doesn't update unless focus lost network, 987933, [oVirt] [provider] Type list is not sorted in add dialog network, 987935, [oVirt] [neutron] Networking plugin type doesn't reappear after test network, 987949, [oVirt] [provider] It's seemingly possible to add a provider with the same name network, 987999, [oVirt] [provider] Add button shouldn't appear on specific provider network, 988002, [oVirt] [network] Add button shouldn't appear on specific network network, 988016, Specify custom MAC address in new/edit VNIC dialog for templates shouldn't exist network, 988354, nic->network assignement not working for VM created from template with disk storage, 915753, Deadlock detected during creation vms in pool storage, 987917, [oVirt] [glance] API version not specified in provider dialog , 991267, [RFE] Add TUI information to log file. > Please set the target to 3.3.1 and add the bug to the tracker if you think that 3.3.1 should not be released without it fixed. > > Please also update the target to 3.3.2 or any next release for bugs that won't be in 3.3.1: it will ease gathering the blocking bugs for next releases. > -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com From mpastern at redhat.com Wed Oct 16 08:17:34 2013 From: mpastern at redhat.com (Michael Pasternak) Date: Wed, 16 Oct 2013 10:17:34 +0200 Subject: [Engine-devel] 3.3.1 Release tracker In-Reply-To: <525E329A.7050103@redhat.com> References: <525E329A.7050103@redhat.com> Message-ID: <525E4B9E.9070209@redhat.com> On 10/16/2013 08:30 AM, Sandro Bonazzola wrote: > Hi, > > as you may know, we're planning to build oVirt 3.3.1 beta really soon and release 3.3.1 by the end of October. > Ofer has created a tracker bug (https://bugzilla.redhat.com/show_bug.cgi?id=1019391) for this release. > Only 2 bugs considered blocking up to now are both in modified state, so we're in a good shape for 3.3.1 beta build. > > The following is a list of the bugs with target 3.3.1 or 3.3: > > "Bug ID","Component","Summary","Status","Target Release","Assignee","Whiteboard" > 988354,"ovirt-engine-webadmin","nic->network assignement not working for VM created from template with disk","POST",3.3,"tjelinek at redhat.com","network" > 988067,"ovirt-engine-sdk-java","Adding a cluster with incomplete version fails with exception","ASSIGNED",3.3,"oliel at redhat.com","infra" > 904149,"ovirt-engine-installer","engine-cleanup doesn't remove iso nfs export","ASSIGNED",3.3,"didi at redhat.com","integration" > 1017267,"ovirt-engine-core","Plaintext user passwords in async_tasks database","ASSIGNED","3.3.1","emesika at redhat.com","infra" > 987897,"ovirt-engine-webadmin","VM - network interfaces subtab has a delayed refresh and displays wrong info for a > while","NEW",3.3,"nobody at fedoraproject.org","network" > 988016,"ovirt-engine-webadmin","Specify custom MAC address in new/edit VNIC dialog for templates shouldn't > exist","NEW",3.3,"nobody at fedoraproject.org","network" > 987935,"ovirt-engine-webadmin","[oVirt] [neutron] Networking plugin type doesn't reappear after test","NEW",3.3,"lpeer at redhat.com","network" > 988002,"ovirt-engine-webadmin","[oVirt] [network] Add button shouldn't appear on specific network","NEW",3.3,"lpeer at redhat.com","network" > 987933,"ovirt-engine-webadmin","[oVirt] [provider] Type list is not sorted in add dialog","NEW",3.3,"lpeer at redhat.com","network" > 987949,"ovirt-engine-webadmin","[oVirt] [provider] It's seemingly possible to add a provider with the same name","NEW",3.3,"lpeer at redhat.com","network" > 987916,"ovirt-engine-webadmin","[oVirt] [provider] Dialog doesn't update unless focus lost","NEW",3.3,"lpeer at redhat.com","network" > 987999,"ovirt-engine-webadmin","[oVirt] [provider] Add button shouldn't appear on specific provider","NEW",3.3,"lpeer at redhat.com","network" > 987982,"ovirt-engine-api","When adding a host through the REST API, the error message says that ""rootPassword"" is required, but the actual field > name is ""root_password""","NEW",3.3,"mpastern at redhat.com","infra" > 987887,"ovirt-engine-webadmin","Error message when reports portal is not installed","NEW",3.3,"mtayer at redhat.com","infra" > 915753,"ovirt-engine-core","Deadlock detected during creation vms in pool","NEW",3.3,"laravot at redhat.com","storage" > 987917,"ovirt-engine-webadmin","[oVirt] [glance] API version not specified in provider dialog","NEW",3.3,"fsimonce at redhat.com","storage" > 987832,"vdsm","failed to add ovirtmgmt bridge when the host has static ip","NEW",3.3,"lpeer at redhat.com","network" > 991267,"ovirt-node","[RFE] Add TUI information to log file.","POST",3.3,"fdeutsch at redhat.com", > 1009899,"ovirt-engine-core","exportDbSchema scripts generates output file with wrong name","POST","3.3.1","emesika at redhat.com","infra" > 990854,"vdsm","Multiple Gateways: Upgrade VDSM to 3.3 must reconfigure networking on host","NEW",3.3,"amuller at redhat.com","network" > > Please set the target to 3.3.1 and add the bug to the tracker if you think that 3.3.1 should not be released without it fixed. the Bugzila bot changing it back to 3.3.0, any suggestions? > > Please also update the target to 3.3.2 or any next release for bugs that won't be in 3.3.1: it will ease gathering the blocking bugs for next releases. > -- Michael Pasternak RedHat, ENG-Virtualization R&D From iheim at redhat.com Wed Oct 16 07:42:39 2013 From: iheim at redhat.com (Itamar Heim) Date: Wed, 16 Oct 2013 03:42:39 -0400 Subject: [Engine-devel] 3.3.1 Release tracker In-Reply-To: <525E4B9E.9070209@redhat.com> References: <525E329A.7050103@redhat.com> <525E4B9E.9070209@redhat.com> Message-ID: <525E436F.9030402@redhat.com> On 10/16/2013 04:17 AM, Michael Pasternak wrote: > On 10/16/2013 08:30 AM, Sandro Bonazzola wrote: >> Hi, >> >> as you may know, we're planning to build oVirt 3.3.1 beta really soon and release 3.3.1 by the end of October. >> Ofer has created a tracker bug (https://bugzilla.redhat.com/show_bug.cgi?id=1019391) for this release. >> Only 2 bugs considered blocking up to now are both in modified state, so we're in a good shape for 3.3.1 beta build. >> >> The following is a list of the bugs with target 3.3.1 or 3.3: >> >> "Bug ID","Component","Summary","Status","Target Release","Assignee","Whiteboard" >> 988354,"ovirt-engine-webadmin","nic->network assignement not working for VM created from template with disk","POST",3.3,"tjelinek at redhat.com","network" >> 988067,"ovirt-engine-sdk-java","Adding a cluster with incomplete version fails with exception","ASSIGNED",3.3,"oliel at redhat.com","infra" >> 904149,"ovirt-engine-installer","engine-cleanup doesn't remove iso nfs export","ASSIGNED",3.3,"didi at redhat.com","integration" >> 1017267,"ovirt-engine-core","Plaintext user passwords in async_tasks database","ASSIGNED","3.3.1","emesika at redhat.com","infra" >> 987897,"ovirt-engine-webadmin","VM - network interfaces subtab has a delayed refresh and displays wrong info for a >> while","NEW",3.3,"nobody at fedoraproject.org","network" >> 988016,"ovirt-engine-webadmin","Specify custom MAC address in new/edit VNIC dialog for templates shouldn't >> exist","NEW",3.3,"nobody at fedoraproject.org","network" >> 987935,"ovirt-engine-webadmin","[oVirt] [neutron] Networking plugin type doesn't reappear after test","NEW",3.3,"lpeer at redhat.com","network" >> 988002,"ovirt-engine-webadmin","[oVirt] [network] Add button shouldn't appear on specific network","NEW",3.3,"lpeer at redhat.com","network" >> 987933,"ovirt-engine-webadmin","[oVirt] [provider] Type list is not sorted in add dialog","NEW",3.3,"lpeer at redhat.com","network" >> 987949,"ovirt-engine-webadmin","[oVirt] [provider] It's seemingly possible to add a provider with the same name","NEW",3.3,"lpeer at redhat.com","network" >> 987916,"ovirt-engine-webadmin","[oVirt] [provider] Dialog doesn't update unless focus lost","NEW",3.3,"lpeer at redhat.com","network" >> 987999,"ovirt-engine-webadmin","[oVirt] [provider] Add button shouldn't appear on specific provider","NEW",3.3,"lpeer at redhat.com","network" >> 987982,"ovirt-engine-api","When adding a host through the REST API, the error message says that ""rootPassword"" is required, but the actual field >> name is ""root_password""","NEW",3.3,"mpastern at redhat.com","infra" >> 987887,"ovirt-engine-webadmin","Error message when reports portal is not installed","NEW",3.3,"mtayer at redhat.com","infra" >> 915753,"ovirt-engine-core","Deadlock detected during creation vms in pool","NEW",3.3,"laravot at redhat.com","storage" >> 987917,"ovirt-engine-webadmin","[oVirt] [glance] API version not specified in provider dialog","NEW",3.3,"fsimonce at redhat.com","storage" >> 987832,"vdsm","failed to add ovirtmgmt bridge when the host has static ip","NEW",3.3,"lpeer at redhat.com","network" >> 991267,"ovirt-node","[RFE] Add TUI information to log file.","POST",3.3,"fdeutsch at redhat.com", >> 1009899,"ovirt-engine-core","exportDbSchema scripts generates output file with wrong name","POST","3.3.1","emesika at redhat.com","infra" >> 990854,"vdsm","Multiple Gateways: Upgrade VDSM to 3.3 must reconfigure networking on host","NEW",3.3,"amuller at redhat.com","network" >> >> Please set the target to 3.3.1 and add the bug to the tracker if you think that 3.3.1 should not be released without it fixed. > > the Bugzila bot changing it back to 3.3.0, any suggestions? for an ovirt bug? > >> >> Please also update the target to 3.3.2 or any next release for bugs that won't be in 3.3.1: it will ease gathering the blocking bugs for next releases. >> > > From mpastern at redhat.com Wed Oct 16 09:16:21 2013 From: mpastern at redhat.com (Michael Pasternak) Date: Wed, 16 Oct 2013 11:16:21 +0200 Subject: [Engine-devel] 3.3.1 Release tracker In-Reply-To: <525E436F.9030402@redhat.com> References: <525E329A.7050103@redhat.com> <525E4B9E.9070209@redhat.com> <525E436F.9030402@redhat.com> Message-ID: <525E5965.4080107@redhat.com> On 10/16/2013 09:42 AM, Itamar Heim wrote: > On 10/16/2013 04:17 AM, Michael Pasternak wrote: >> On 10/16/2013 08:30 AM, Sandro Bonazzola wrote: >>> Hi, >>> >>> as you may know, we're planning to build oVirt 3.3.1 beta really soon and release 3.3.1 by the end of October. >>> Ofer has created a tracker bug (https://bugzilla.redhat.com/show_bug.cgi?id=1019391) for this release. >>> Only 2 bugs considered blocking up to now are both in modified state, so we're in a good shape for 3.3.1 beta build. >>> >>> The following is a list of the bugs with target 3.3.1 or 3.3: >>> >>> "Bug ID","Component","Summary","Status","Target Release","Assignee","Whiteboard" >>> 988354,"ovirt-engine-webadmin","nic->network assignement not working for VM created from template with disk","POST",3.3,"tjelinek at redhat.com","network" >>> 988067,"ovirt-engine-sdk-java","Adding a cluster with incomplete version fails with exception","ASSIGNED",3.3,"oliel at redhat.com","infra" >>> 904149,"ovirt-engine-installer","engine-cleanup doesn't remove iso nfs export","ASSIGNED",3.3,"didi at redhat.com","integration" >>> 1017267,"ovirt-engine-core","Plaintext user passwords in async_tasks database","ASSIGNED","3.3.1","emesika at redhat.com","infra" >>> 987897,"ovirt-engine-webadmin","VM - network interfaces subtab has a delayed refresh and displays wrong info for a >>> while","NEW",3.3,"nobody at fedoraproject.org","network" >>> 988016,"ovirt-engine-webadmin","Specify custom MAC address in new/edit VNIC dialog for templates shouldn't >>> exist","NEW",3.3,"nobody at fedoraproject.org","network" >>> 987935,"ovirt-engine-webadmin","[oVirt] [neutron] Networking plugin type doesn't reappear after test","NEW",3.3,"lpeer at redhat.com","network" >>> 988002,"ovirt-engine-webadmin","[oVirt] [network] Add button shouldn't appear on specific network","NEW",3.3,"lpeer at redhat.com","network" >>> 987933,"ovirt-engine-webadmin","[oVirt] [provider] Type list is not sorted in add dialog","NEW",3.3,"lpeer at redhat.com","network" >>> 987949,"ovirt-engine-webadmin","[oVirt] [provider] It's seemingly possible to add a provider with the same name","NEW",3.3,"lpeer at redhat.com","network" >>> 987916,"ovirt-engine-webadmin","[oVirt] [provider] Dialog doesn't update unless focus lost","NEW",3.3,"lpeer at redhat.com","network" >>> 987999,"ovirt-engine-webadmin","[oVirt] [provider] Add button shouldn't appear on specific provider","NEW",3.3,"lpeer at redhat.com","network" >>> 987982,"ovirt-engine-api","When adding a host through the REST API, the error message says that ""rootPassword"" is required, but the actual field >>> name is ""root_password""","NEW",3.3,"mpastern at redhat.com","infra" >>> 987887,"ovirt-engine-webadmin","Error message when reports portal is not installed","NEW",3.3,"mtayer at redhat.com","infra" >>> 915753,"ovirt-engine-core","Deadlock detected during creation vms in pool","NEW",3.3,"laravot at redhat.com","storage" >>> 987917,"ovirt-engine-webadmin","[oVirt] [glance] API version not specified in provider dialog","NEW",3.3,"fsimonce at redhat.com","storage" >>> 987832,"vdsm","failed to add ovirtmgmt bridge when the host has static ip","NEW",3.3,"lpeer at redhat.com","network" >>> 991267,"ovirt-node","[RFE] Add TUI information to log file.","POST",3.3,"fdeutsch at redhat.com", >>> 1009899,"ovirt-engine-core","exportDbSchema scripts generates output file with wrong name","POST","3.3.1","emesika at redhat.com","infra" >>> 990854,"vdsm","Multiple Gateways: Upgrade VDSM to 3.3 must reconfigure networking on host","NEW",3.3,"amuller at redhat.com","network" >>> >>> Please set the target to 3.3.1 and add the bug to the tracker if you think that 3.3.1 should not be released without it fixed. >> >> the Bugzila bot changing it back to 3.3.0, any suggestions? > > for an ovirt bug? no, it was slight confusion, all good now, thanks. > >> >>> >>> Please also update the target to 3.3.2 or any next release for bugs that won't be in 3.3.1: it will ease gathering the blocking bugs for next releases. >>> >> >> > -- Michael Pasternak RedHat, ENG-Virtualization R&D From rgolan at redhat.com Wed Oct 16 12:02:53 2013 From: rgolan at redhat.com (Roy Golan) Date: Wed, 16 Oct 2013 15:02:53 +0300 Subject: [Engine-devel] use jrebel to stop redeploying and save precious time Message-ID: <525E806D.2070308@redhat.com> Hi all oVirt developers now have FOSS license to use jRebel. what is jRebel? from http://zeroturnaround.com/software/jrebel/ "View Changes Instantly, See all changes to Java application instantly in the browser. Save and refresh! Locally or remotely. No Maven build needed!" Yes no need to run make,mvn,setup and so on... step to make it work (5 minutes work) * install jRebel plugin for your IDE - http://manuals.zeroturnaround.com/jrebel/ide/index.html * send me a *private* mail, I'll reply back with the key, then go activate the plugin from your IDE * right click "bll" project and ask the pick jRebel from the menu to create a rebel.xml * place /*20-java.conf*/ under */$PREFIX/ovirt-engine/etc/ovirt-engine/engine.conf.d//* and edit it to point to your jrebel.jar. this is my /*20-java.conf*/: ENGINE_JVM_ARGS="${ENGINE_JVM_ARGS} -javaagent:/home/rgolan/.IntelliJIdea12/config/plugins/jr-ide-idea/lib/jrebel/jrebel.jar" from now on, every change to a class in bll which is compiled (so target/classes dir changes) will be reloaded in the jvm. note: this add few seconds to jboss boot time. but worth it. Thanks, Roy -------------- next part -------------- An HTML attachment was scrubbed... URL: From msivak at redhat.com Wed Oct 16 15:22:02 2013 From: msivak at redhat.com (Martin Sivak) Date: Wed, 16 Oct 2013 11:22:02 -0400 (EDT) Subject: [Engine-devel] Localization of canDoAction error messages In-Reply-To: <337101433.2360458.1381936435550.JavaMail.root@redhat.com> Message-ID: <1889528561.2367875.1381936922194.JavaMail.root@redhat.com> Hi, I am trying to improve the messages the user gets when scheduling fails. But I have found an interesting issue regarding localization. The texts here are simplified, but should demonstrate what I am trying to do. So here is the flow: - RunVmCommand's canDoAction fails because there is no host that fits the constraints - For each host I add a message to getReturnValue().getCanDoActionMessages() in the format of "Host XYZ failed constraint ABCD". - I log the same message to the log I expect the log to contain the strings in english and a localized version to be shown in the error popup that will be displayed by the webadmin. And the question is.. how do I localize this? I looked at AppErrors and AppMessages, but there is not way of using them from the backend side. Any ideas? -- Martin Siv?k msivak at redhat.com Red Hat Czech RHEV-M SLA / Brno, CZ From ecohen at redhat.com Wed Oct 16 15:27:11 2013 From: ecohen at redhat.com (Einav Cohen) Date: Wed, 16 Oct 2013 11:27:11 -0400 (EDT) Subject: [Engine-devel] Localization of canDoAction error messages In-Reply-To: <1889528561.2367875.1381936922194.JavaMail.root@redhat.com> References: <1889528561.2367875.1381936922194.JavaMail.root@redhat.com> Message-ID: <1044678996.3306968.1381937231436.JavaMail.root@redhat.com> Hi Martin, please follow instructions in [1] for adding new messages to the system. [you should not add the English message to the canDoActionMessages collection - you should add a key from the AppErrors resource - look for other examples in the code that add items to a command's canDoActionMessages field] ---- Thanks, Einav [1] http://www.ovirt.org/Engine_Adding_Messages ----- Original Message ----- > From: "Martin Sivak" > To: "engine-devel" > Sent: Wednesday, October 16, 2013 11:22:02 AM > Subject: [Engine-devel] Localization of canDoAction error messages > > Hi, > > I am trying to improve the messages the user gets when scheduling fails. But > I have found an interesting issue regarding localization. The texts here are > simplified, but should demonstrate what I am trying to do. > > So here is the flow: > > - RunVmCommand's canDoAction fails because there is no host that fits the > constraints > - For each host I add a message to getReturnValue().getCanDoActionMessages() > in the format of "Host XYZ failed constraint ABCD". > - I log the same message to the log > > I expect the log to contain the strings in english and a localized version to > be shown in the error popup that will be displayed by the webadmin. > > And the question is.. how do I localize this? I looked at AppErrors and > AppMessages, but there is not way of using them from the backend side. > > Any ideas? > > -- > Martin Siv?k > msivak at redhat.com > Red Hat Czech > RHEV-M SLA / Brno, CZ > > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > From msivak at redhat.com Wed Oct 16 15:46:42 2013 From: msivak at redhat.com (Martin Sivak) Date: Wed, 16 Oct 2013 11:46:42 -0400 (EDT) Subject: [Engine-devel] Localization of canDoAction error messages In-Reply-To: <1044678996.3306968.1381937231436.JavaMail.root@redhat.com> References: <1889528561.2367875.1381936922194.JavaMail.root@redhat.com> <1044678996.3306968.1381937231436.JavaMail.root@redhat.com> Message-ID: <1703006429.2384533.1381938402667.JavaMail.root@redhat.com> Hi Einav, I know about this procedure, but if you check closely what I am doing, I need to print a list of messages at once where each has a different content. Something like this (again the strings are just an illustration): ------------- Error ---------------------- The VM net-A could not be started because there was no fitting host available. Host host-A failed constraint memory Host host-B failed constraint cpu load Host host-C failed constraint memory ------------------------------------------ I am pretty sure the replacing we have in VdcBllMessages does not support this as it cannot assign two or more different values to the same variable. -- Martin Siv?k msivak at redhat.com Red Hat Czech RHEV-M SLA / Brno, CZ ----- Original Message ----- > Hi Martin, please follow instructions in [1] for adding new messages to the > system. > [you should not add the English message to the canDoActionMessages collection > - you > should add a key from the AppErrors resource - look for other examples in the > code > that add items to a command's canDoActionMessages field] > > ---- > Thanks, > Einav > > [1] http://www.ovirt.org/Engine_Adding_Messages > > ----- Original Message ----- > > From: "Martin Sivak" > > To: "engine-devel" > > Sent: Wednesday, October 16, 2013 11:22:02 AM > > Subject: [Engine-devel] Localization of canDoAction error messages > > > > Hi, > > > > I am trying to improve the messages the user gets when scheduling fails. > > But > > I have found an interesting issue regarding localization. The texts here > > are > > simplified, but should demonstrate what I am trying to do. > > > > So here is the flow: > > > > - RunVmCommand's canDoAction fails because there is no host that fits the > > constraints > > - For each host I add a message to > > getReturnValue().getCanDoActionMessages() > > in the format of "Host XYZ failed constraint ABCD". > > - I log the same message to the log > > > > I expect the log to contain the strings in english and a localized version > > to > > be shown in the error popup that will be displayed by the webadmin. > > > > And the question is.. how do I localize this? I looked at AppErrors and > > AppMessages, but there is not way of using them from the backend side. > > > > Any ideas? > > > > -- > > Martin Siv?k > > msivak at redhat.com > > Red Hat Czech > > RHEV-M SLA / Brno, CZ > > > > _______________________________________________ > > Engine-devel mailing list > > Engine-devel at ovirt.org > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > From ecohen at redhat.com Wed Oct 16 16:07:44 2013 From: ecohen at redhat.com (Einav Cohen) Date: Wed, 16 Oct 2013 12:07:44 -0400 (EDT) Subject: [Engine-devel] Localization of canDoAction error messages In-Reply-To: <1703006429.2384533.1381938402667.JavaMail.root@redhat.com> References: <1889528561.2367875.1381936922194.JavaMail.root@redhat.com> <1044678996.3306968.1381937231436.JavaMail.root@redhat.com> <1703006429.2384533.1381938402667.JavaMail.root@redhat.com> Message-ID: <333615532.3335870.1381939664968.JavaMail.root@redhat.com> thanks for clarifying. indeed today, the canDoActionMessages is simply a collection of strings, each of which is either a message, a message with variable placeholder(s) or a variable value; if a few messages contain an identically-named variable placeholder (e.g. '${HostName}'), and you want to replace each one of these placeholders with a different value (e.g. 'host-A', 'host-B', etc.), it is impossible to do AFAIK. a possible improvement to the current mechanism in order to support what you need is to define the canDoActionMessage field to be a collection of string collections (rather than a collection of strings); and each string collection will actually represent a single 'line' in the can-do-action failure message, by containing the 'base' message (e.g. "Host '${HostName}' failed constraint memory") and its matching variable value(s) (e.g. '$HostName host-A'). ---- Regards, Einav ----- Original Message ----- > From: "Martin Sivak" > To: "Einav Cohen" > Cc: "engine-devel" > Sent: Wednesday, October 16, 2013 11:46:42 AM > Subject: Re: [Engine-devel] Localization of canDoAction error messages > > Hi Einav, > > I know about this procedure, but if you check closely what I am doing, I need > to print a list of messages at once where each has a different content. > > Something like this (again the strings are just an illustration): > > ------------- Error ---------------------- > The VM net-A could not be started because > there was no fitting host available. > > Host host-A failed constraint memory > Host host-B failed constraint cpu load > Host host-C failed constraint memory > ------------------------------------------ > > I am pretty sure the replacing we have in VdcBllMessages does not support > this as it cannot assign two or more different values to the same variable. > > -- > Martin Siv?k > msivak at redhat.com > Red Hat Czech > RHEV-M SLA / Brno, CZ > > ----- Original Message ----- > > Hi Martin, please follow instructions in [1] for adding new messages to the > > system. > > [you should not add the English message to the canDoActionMessages > > collection > > - you > > should add a key from the AppErrors resource - look for other examples in > > the > > code > > that add items to a command's canDoActionMessages field] > > > > ---- > > Thanks, > > Einav > > > > [1] http://www.ovirt.org/Engine_Adding_Messages > > > > ----- Original Message ----- > > > From: "Martin Sivak" > > > To: "engine-devel" > > > Sent: Wednesday, October 16, 2013 11:22:02 AM > > > Subject: [Engine-devel] Localization of canDoAction error messages > > > > > > Hi, > > > > > > I am trying to improve the messages the user gets when scheduling fails. > > > But > > > I have found an interesting issue regarding localization. The texts here > > > are > > > simplified, but should demonstrate what I am trying to do. > > > > > > So here is the flow: > > > > > > - RunVmCommand's canDoAction fails because there is no host that fits the > > > constraints > > > - For each host I add a message to > > > getReturnValue().getCanDoActionMessages() > > > in the format of "Host XYZ failed constraint ABCD". > > > - I log the same message to the log > > > > > > I expect the log to contain the strings in english and a localized > > > version > > > to > > > be shown in the error popup that will be displayed by the webadmin. > > > > > > And the question is.. how do I localize this? I looked at AppErrors and > > > AppMessages, but there is not way of using them from the backend side. > > > > > > Any ideas? > > > > > > -- > > > Martin Siv?k > > > msivak at redhat.com > > > Red Hat Czech > > > RHEV-M SLA / Brno, CZ > > > > > > _______________________________________________ > > > Engine-devel mailing list > > > Engine-devel at ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > > > > > > From derez at redhat.com Wed Oct 16 20:30:07 2013 From: derez at redhat.com (Daniel Erez) Date: Wed, 16 Oct 2013 16:30:07 -0400 (EDT) Subject: [Engine-devel] Localization of canDoAction error messages In-Reply-To: <1703006429.2384533.1381938402667.JavaMail.root@redhat.com> References: <1889528561.2367875.1381936922194.JavaMail.root@redhat.com> <1044678996.3306968.1381937231436.JavaMail.root@redhat.com> <1703006429.2384533.1381938402667.JavaMail.root@redhat.com> Message-ID: <200527324.2823504.1381955407152.JavaMail.root@redhat.com> ----- Original Message ----- > From: "Martin Sivak" > To: "Einav Cohen" > Cc: "engine-devel" > Sent: Wednesday, October 16, 2013 6:46:42 PM > Subject: Re: [Engine-devel] Localization of canDoAction error messages > > Hi Einav, > > I know about this procedure, but if you check closely what I am doing, I need > to print a list of messages at once where each has a different content. > > Something like this (again the strings are just an illustration): > > ------------- Error ---------------------- > The VM net-A could not be started because > there was no fitting host available. > > Host host-A failed constraint memory > Host host-B failed constraint cpu load > Host host-C failed constraint memory > ------------------------------------------ > > I am pretty sure the replacing we have in VdcBllMessages does not support > this as it cannot assign two or more different values to the same variable. IIUC the exact request, I think you can use a mechanism I've introduced a while back into the error translator. It requires adding each variable separately (and multiple times when needed) to the CanDoActionMessages list - e.g. [1]. The messages will be then localized and displayed in a bullet list layout. However, there's one imitation, adding a title message is trickier (i.e. every message must preceded by a bullet); as an alternative, you can probably utilize 'CommandBase -> setDescription' which is used on RunMultipleAction failure (e.g. for displaying VM name on top of the relevant errors bullet list). [1] code -> addCanDoActionMessage(VdcBllMessages.VAR__TYPE__HOST); addCanDoActionMessage(String.format("$%1$s %2$s", "hostName", "host-A")); addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CONSTRAINT_MEMORY); addCanDoActionMessage(VdcBllMessages.VAR__TYPE__HOST); addCanDoActionMessage(String.format("$%1$s %2$s", "hostName", "host-B")); addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CONSTRAINT_MEMORY); [VdcBllMessages.ACTION_TYPE_FAILED_CONSTRAINT_MEMORY = "${type} ${hostName} failed constraint memory"] output -> Error while executing action: VM1: * Host host-A failed constraint memory * Host host-B failed constraint memory note: instead of adding VAR__TYPE__HOST multiple times, it should be possible to just add a new variable that won't conflict with ${type} (which is already used by VAR__TYPE__VM in case of RunVmCommand). > > -- > Martin Siv?k > msivak at redhat.com > Red Hat Czech > RHEV-M SLA / Brno, CZ > > ----- Original Message ----- > > Hi Martin, please follow instructions in [1] for adding new messages to the > > system. > > [you should not add the English message to the canDoActionMessages > > collection > > - you > > should add a key from the AppErrors resource - look for other examples in > > the > > code > > that add items to a command's canDoActionMessages field] > > > > ---- > > Thanks, > > Einav > > > > [1] http://www.ovirt.org/Engine_Adding_Messages > > > > ----- Original Message ----- > > > From: "Martin Sivak" > > > To: "engine-devel" > > > Sent: Wednesday, October 16, 2013 11:22:02 AM > > > Subject: [Engine-devel] Localization of canDoAction error messages > > > > > > Hi, > > > > > > I am trying to improve the messages the user gets when scheduling fails. > > > But > > > I have found an interesting issue regarding localization. The texts here > > > are > > > simplified, but should demonstrate what I am trying to do. > > > > > > So here is the flow: > > > > > > - RunVmCommand's canDoAction fails because there is no host that fits the > > > constraints > > > - For each host I add a message to > > > getReturnValue().getCanDoActionMessages() > > > in the format of "Host XYZ failed constraint ABCD". > > > - I log the same message to the log > > > > > > I expect the log to contain the strings in english and a localized > > > version > > > to > > > be shown in the error popup that will be displayed by the webadmin. > > > > > > And the question is.. how do I localize this? I looked at AppErrors and > > > AppMessages, but there is not way of using them from the backend side. > > > > > > Any ideas? > > > > > > -- > > > Martin Siv?k > > > msivak at redhat.com > > > Red Hat Czech > > > RHEV-M SLA / Brno, CZ > > > > > > _______________________________________________ > > > Engine-devel mailing list > > > Engine-devel at ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > > > > > > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > From ecohen at redhat.com Thu Oct 17 13:20:07 2013 From: ecohen at redhat.com (Einav Cohen) Date: Thu, 17 Oct 2013 09:20:07 -0400 (EDT) Subject: [Engine-devel] ui code: possible problem in 'remove' confirmation dialog In-Reply-To: <1197627775.4315826.1382015853833.JavaMail.root@redhat.com> Message-ID: <2017494005.4318252.1382016007331.JavaMail.root@redhat.com> Hi, Looking at the current code: It seems that we cannot set the message within a 'remove' confirmation dialog if its HashName starts with "remove_" - it is being set "statically[1] I don't have a major problem with relying on the HashName for setting a *default* message (in fact, I don't have a problem [1] From RemoveConfirmationPopupView.java, line 86: public void setMessage(String message) { if (getHashName() != null && getHashName().startsWith("remove_")) { //$NON-NLS-1$ super.setMessage(constants.removeConfirmationPopupMessage()); } else { super.setMessage(message); } } ---- Regards, Einav Cohen Baum RHEV-M Engineering - UX Team Manager Red Hat, Inc. 314 Littleton Road Westford, MA 01886 T [internal]: (81) 31046 T [external]: (+1) 978 589 1046 IRC: ecohen @ - RHAT [internal]: #rhev-dev #boston #westford #tlv - OFTC [external]: #ovirt From ecohen at redhat.com Thu Oct 17 13:24:56 2013 From: ecohen at redhat.com (Einav Cohen) Date: Thu, 17 Oct 2013 09:24:56 -0400 (EDT) Subject: [Engine-devel] ui code: possible problem in 'remove' confirmation dialog In-Reply-To: <2017494005.4318252.1382016007331.JavaMail.root@redhat.com> References: <2017494005.4318252.1382016007331.JavaMail.root@redhat.com> Message-ID: <208849508.4323041.1382016296885.JavaMail.root@redhat.com> [apologies - previous e-mail sent prematurely by mistake] Hi, Looking at the current code: It seems that we cannot set the message within a 'remove' confirmation dialog if its HashName starts with "remove_" - it is being set "statically" to the "Are you sure you want to remove the following items?" [constants.removeConfirmationPopupMessage] message [1] I don't have a major problem with relying on the HashName for setting a *default* message [2] - but I think that not allowing to override this message if the developer chooses to do so is an incorrect behavior. I would like to change the behavior so that the user would be able to override the message displayed in that dialog, even if its hash-name is set to 'remove_'. thoughts? objections? ---- Thanks, Einav [1] From RemoveConfirmationPopupView.java, line 86: public void setMessage(String message) { if (getHashName() != null && getHashName().startsWith("remove_")) { //$NON-NLS-1$ super.setMessage(constants.removeConfirmationPopupMessage()); } else { super.setMessage(message); } } [2] in fact, I don't mind that this would be the default message for this dialog, even if its hash-name is not set to something that starts with 'remove_'. ----- Original Message ----- > From: "Einav Cohen" > To: "Daniel Erez" , "Gilad Chaplik" , "Tomas Jelinek" , > "Vojtech Szocs" , "Lior Vernia" > Cc: "engine-devel" > Sent: Thursday, October 17, 2013 9:20:07 AM > Subject: ui code: possible problem in 'remove' confirmation dialog > > Hi, > > Looking at the current code: It seems that we cannot set the message within a > 'remove' confirmation > dialog if its HashName starts with "remove_" - it is being set "statically[1] > I don't have a major problem with relying on the HashName for setting a > *default* message (in fact, > I don't have a problem > > [1] From RemoveConfirmationPopupView.java, line 86: > > public void setMessage(String message) { > if (getHashName() != null && getHashName().startsWith("remove_")) { > //$NON-NLS-1$ > super.setMessage(constants.removeConfirmationPopupMessage()); > } else { > super.setMessage(message); > } > } > > ---- > Regards, > Einav Cohen Baum > RHEV-M Engineering - UX Team Manager > Red Hat, Inc. > 314 Littleton Road > Westford, MA 01886 > T [internal]: (81) 31046 > T [external]: (+1) 978 589 1046 > IRC: ecohen @ > - RHAT [internal]: #rhev-dev #boston #westford #tlv > - OFTC [external]: #ovirt > From fabiand at redhat.com Thu Oct 17 13:34:44 2013 From: fabiand at redhat.com (Fabian Deutsch) Date: Thu, 17 Oct 2013 15:34:44 +0200 Subject: [Engine-devel] Request for Fedora 20 VM In-Reply-To: <1380545532.2666.13.camel@fdeutsch-laptop.local> References: <5249184D.9090800@redhat.com> <1380545532.2666.13.camel@fdeutsch-laptop.local> Message-ID: <1382016884.16177.3.camel@fdeutsch-laptop.local> Am Montag, den 30.09.2013, 14:52 +0200 schrieb Fabian Deutsch: > Am Montag, den 30.09.2013, 08:21 +0200 schrieb Sandro Bonazzola: > > Hi, > > Fedora 20 Alpha has been released and can be downloaded from http://fedoraproject.org/get-prerelease. > > I think it's time to start running our tests and build nightly also on Fedora 20 in order to discover > > possible compatibility issues. > > Can infra provide a Fedora 20 VM for jenkins use? > > That would also be helpful for us - ovirt-node - to get started with the > F20 migration. Hey, are there already plans to roll out some f20 builders? Thanks fabian From ecohen at redhat.com Thu Oct 17 13:37:42 2013 From: ecohen at redhat.com (Einav Cohen) Date: Thu, 17 Oct 2013 09:37:42 -0400 (EDT) Subject: [Engine-devel] Localization of canDoAction error messages In-Reply-To: <200527324.2823504.1381955407152.JavaMail.root@redhat.com> References: <1889528561.2367875.1381936922194.JavaMail.root@redhat.com> <1044678996.3306968.1381937231436.JavaMail.root@redhat.com> <1703006429.2384533.1381938402667.JavaMail.root@redhat.com> <200527324.2823504.1381955407152.JavaMail.root@redhat.com> Message-ID: <972591691.4382255.1382017062538.JavaMail.root@redhat.com> Hi Derez, > addCanDoActionMessage(VdcBllMessages.VAR__TYPE__HOST); > addCanDoActionMessage(String.format("$%1$s %2$s", "hostName", "host-A")); > addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CONSTRAINT_MEMORY); > > addCanDoActionMessage(VdcBllMessages.VAR__TYPE__HOST); > addCanDoActionMessage(String.format("$%1$s %2$s", "hostName", "host-B")); > addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CONSTRAINT_CPU); // I changed that from your original message on purpose. > > [VdcBllMessages.ACTION_TYPE_FAILED_CONSTRAINT_MEMORY = > "${type} ${hostName} failed constraint memory"] Is there a guarantee that each of the ACTION_TYPE_FAILED_CONSTRAINT_MEMORY will be replaced with its "matching" VAR__TYPE__HOST value? isn't there a chance that the above will result in: ... Host host-A failed constraint memory Host host-A failed constraint cpu load // second message was replaced with an already-used variable value. ... or in: ... Host host-B failed constraint memory Host host-A failed constraint cpu load // variable values were not used for their "matching" base-messages. ... ? ----- Original Message ----- > From: "Daniel Erez" > To: "Martin Sivak" > Cc: "engine-devel" > Sent: Wednesday, October 16, 2013 4:30:07 PM > Subject: Re: [Engine-devel] Localization of canDoAction error messages > > > > ----- Original Message ----- > > From: "Martin Sivak" > > To: "Einav Cohen" > > Cc: "engine-devel" > > Sent: Wednesday, October 16, 2013 6:46:42 PM > > Subject: Re: [Engine-devel] Localization of canDoAction error messages > > > > Hi Einav, > > > > I know about this procedure, but if you check closely what I am doing, I > > need > > to print a list of messages at once where each has a different content. > > > > Something like this (again the strings are just an illustration): > > > > ------------- Error ---------------------- > > The VM net-A could not be started because > > there was no fitting host available. > > > > Host host-A failed constraint memory > > Host host-B failed constraint cpu load > > Host host-C failed constraint memory > > ------------------------------------------ > > > > I am pretty sure the replacing we have in VdcBllMessages does not support > > this as it cannot assign two or more different values to the same variable. > > IIUC the exact request, I think you can use a mechanism I've introduced > a while back into the error translator. It requires adding each variable > separately (and multiple times when needed) to the CanDoActionMessages > list - e.g. [1]. > The messages will be then localized and displayed in a bullet list layout. > However, there's one imitation, adding a title message is trickier > (i.e. every message must preceded by a bullet); as an alternative, > you can probably utilize 'CommandBase -> setDescription' which is used > on RunMultipleAction failure (e.g. for displaying VM name on top > of the relevant errors bullet list). > > [1] > code -> > > addCanDoActionMessage(VdcBllMessages.VAR__TYPE__HOST); > addCanDoActionMessage(String.format("$%1$s %2$s", "hostName", "host-A")); > addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CONSTRAINT_MEMORY); > > addCanDoActionMessage(VdcBllMessages.VAR__TYPE__HOST); > addCanDoActionMessage(String.format("$%1$s %2$s", "hostName", "host-B")); > addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CONSTRAINT_MEMORY); > > [VdcBllMessages.ACTION_TYPE_FAILED_CONSTRAINT_MEMORY = > "${type} ${hostName} failed constraint memory"] > > output -> > > Error while executing action: > > VM1: > * Host host-A failed constraint memory > * Host host-B failed constraint memory > > > note: > instead of adding VAR__TYPE__HOST multiple times, it should be possible to > just add a new variable that won't conflict with ${type} (which is already > used > by VAR__TYPE__VM in case of RunVmCommand). > > > > > -- > > Martin Siv?k > > msivak at redhat.com > > Red Hat Czech > > RHEV-M SLA / Brno, CZ > > > > ----- Original Message ----- > > > Hi Martin, please follow instructions in [1] for adding new messages to > > > the > > > system. > > > [you should not add the English message to the canDoActionMessages > > > collection > > > - you > > > should add a key from the AppErrors resource - look for other examples in > > > the > > > code > > > that add items to a command's canDoActionMessages field] > > > > > > ---- > > > Thanks, > > > Einav > > > > > > [1] http://www.ovirt.org/Engine_Adding_Messages > > > > > > ----- Original Message ----- > > > > From: "Martin Sivak" > > > > To: "engine-devel" > > > > Sent: Wednesday, October 16, 2013 11:22:02 AM > > > > Subject: [Engine-devel] Localization of canDoAction error messages > > > > > > > > Hi, > > > > > > > > I am trying to improve the messages the user gets when scheduling > > > > fails. > > > > But > > > > I have found an interesting issue regarding localization. The texts > > > > here > > > > are > > > > simplified, but should demonstrate what I am trying to do. > > > > > > > > So here is the flow: > > > > > > > > - RunVmCommand's canDoAction fails because there is no host that fits > > > > the > > > > constraints > > > > - For each host I add a message to > > > > getReturnValue().getCanDoActionMessages() > > > > in the format of "Host XYZ failed constraint ABCD". > > > > - I log the same message to the log > > > > > > > > I expect the log to contain the strings in english and a localized > > > > version > > > > to > > > > be shown in the error popup that will be displayed by the webadmin. > > > > > > > > And the question is.. how do I localize this? I looked at AppErrors and > > > > AppMessages, but there is not way of using them from the backend side. > > > > > > > > Any ideas? > > > > > > > > -- > > > > Martin Siv?k > > > > msivak at redhat.com > > > > Red Hat Czech > > > > RHEV-M SLA / Brno, CZ > > > > > > > > _______________________________________________ > > > > Engine-devel mailing list > > > > Engine-devel at ovirt.org > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > > > > > > > > > > > _______________________________________________ > > Engine-devel mailing list > > Engine-devel at ovirt.org > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > From gshereme at redhat.com Thu Oct 17 14:37:52 2013 From: gshereme at redhat.com (Greg Sheremeta) Date: Thu, 17 Oct 2013 10:37:52 -0400 (EDT) Subject: [Engine-devel] ui code: possible problem in 'remove' confirmation dialog In-Reply-To: <208849508.4323041.1382016296885.JavaMail.root@redhat.com> References: <2017494005.4318252.1382016007331.JavaMail.root@redhat.com> <208849508.4323041.1382016296885.JavaMail.root@redhat.com> Message-ID: <2095131293.5634790.1382020672899.JavaMail.root@redhat.com> ----- Original Message ----- > From: "Einav Cohen" > To: "Daniel Erez" , "Gilad Chaplik" , "Tomas Jelinek" , > "Vojtech Szocs" , "Lior Vernia" > Cc: "engine-devel" > Sent: Thursday, October 17, 2013 9:24:56 AM > Subject: Re: [Engine-devel] ui code: possible problem in 'remove' confirmation dialog > > [apologies - previous e-mail sent prematurely by mistake] > > Hi, > > Looking at the current code: It seems that we cannot set the message within a > 'remove' confirmation dialog if its HashName starts with "remove_" - it is > being set "statically" to the "Are you sure you want to remove the following > items?" [constants.removeConfirmationPopupMessage] message [1] > > I don't have a major problem with relying on the HashName for setting a > *default* message [2] - but I think that not allowing to override this > message if the developer chooses to do so is an incorrect behavior. > > I would like to change the behavior so that the user would be able to > override the message displayed in that dialog, even if its hash-name is > set to 'remove_'. > > thoughts? objections? I agree with you. It should be overridable, with "Are you sure" as the default. Greg > > ---- > Thanks, > Einav > > > [1] From RemoveConfirmationPopupView.java, line 86: > > public void setMessage(String message) { > if (getHashName() != null && getHashName().startsWith("remove_")) { > //$NON-NLS-1$ > super.setMessage(constants.removeConfirmationPopupMessage()); > } else { > super.setMessage(message); > } > } > > [2] in fact, I don't mind that this would be the default message for > this dialog, even if its hash-name is not set to something that starts > with 'remove_'. > > ----- Original Message ----- > > From: "Einav Cohen" > > To: "Daniel Erez" , "Gilad Chaplik" > > , "Tomas Jelinek" , > > "Vojtech Szocs" , "Lior Vernia" > > Cc: "engine-devel" > > Sent: Thursday, October 17, 2013 9:20:07 AM > > Subject: ui code: possible problem in 'remove' confirmation dialog > > > > Hi, > > > > Looking at the current code: It seems that we cannot set the message within > > a > > 'remove' confirmation > > dialog if its HashName starts with "remove_" - it is being set > > "statically[1] > > I don't have a major problem with relying on the HashName for setting a > > *default* message (in fact, > > I don't have a problem > > > > [1] From RemoveConfirmationPopupView.java, line 86: > > > > public void setMessage(String message) { > > if (getHashName() != null && getHashName().startsWith("remove_")) { > > //$NON-NLS-1$ > > super.setMessage(constants.removeConfirmationPopupMessage()); > > } else { > > super.setMessage(message); > > } > > } > > > > ---- > > Regards, > > Einav Cohen Baum > > RHEV-M Engineering - UX Team Manager > > Red Hat, Inc. > > 314 Littleton Road > > Westford, MA 01886 > > T [internal]: (81) 31046 > > T [external]: (+1) 978 589 1046 > > IRC: ecohen @ > > - RHAT [internal]: #rhev-dev #boston #westford #tlv > > - OFTC [external]: #ovirt > > > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > From msivak at redhat.com Fri Oct 18 09:29:25 2013 From: msivak at redhat.com (Martin Sivak) Date: Fri, 18 Oct 2013 05:29:25 -0400 (EDT) Subject: [Engine-devel] Localization of canDoAction error messages In-Reply-To: <972591691.4382255.1382017062538.JavaMail.root@redhat.com> References: <1889528561.2367875.1381936922194.JavaMail.root@redhat.com> <1044678996.3306968.1381937231436.JavaMail.root@redhat.com> <1703006429.2384533.1381938402667.JavaMail.root@redhat.com> <200527324.2823504.1381955407152.JavaMail.root@redhat.com> <972591691.4382255.1382017062538.JavaMail.root@redhat.com> Message-ID: <404266909.3352854.1382088565373.JavaMail.root@redhat.com> I tested this and it works as expected so far. But I am also interested in the answer :) -- Martin Siv?k msivak at redhat.com Red Hat Czech RHEV-M SLA / Brno, CZ ----- Original Message ----- > Hi Derez, > > > addCanDoActionMessage(VdcBllMessages.VAR__TYPE__HOST); > > addCanDoActionMessage(String.format("$%1$s %2$s", "hostName", > > "host-A")); > > addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CONSTRAINT_MEMORY); > > > > addCanDoActionMessage(VdcBllMessages.VAR__TYPE__HOST); > > addCanDoActionMessage(String.format("$%1$s %2$s", "hostName", > > "host-B")); > > addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CONSTRAINT_CPU); > > // I changed that from your original message on purpose. > > > > [VdcBllMessages.ACTION_TYPE_FAILED_CONSTRAINT_MEMORY = > > "${type} ${hostName} failed constraint memory"] > > Is there a guarantee that each of the ACTION_TYPE_FAILED_CONSTRAINT_MEMORY > will > be replaced with its "matching" VAR__TYPE__HOST value? isn't there a chance > that > the above will result in: > > ... > Host host-A failed constraint memory > Host host-A failed constraint cpu load // second message was replaced with > an already-used variable value. > ... > > > or in: > ... > Host host-B failed constraint memory > Host host-A failed constraint cpu load // variable values were not used for > their "matching" base-messages. > ... > > ? > > > ----- Original Message ----- > > From: "Daniel Erez" > > To: "Martin Sivak" > > Cc: "engine-devel" > > Sent: Wednesday, October 16, 2013 4:30:07 PM > > Subject: Re: [Engine-devel] Localization of canDoAction error messages > > > > > > > > ----- Original Message ----- > > > From: "Martin Sivak" > > > To: "Einav Cohen" > > > Cc: "engine-devel" > > > Sent: Wednesday, October 16, 2013 6:46:42 PM > > > Subject: Re: [Engine-devel] Localization of canDoAction error messages > > > > > > Hi Einav, > > > > > > I know about this procedure, but if you check closely what I am doing, I > > > need > > > to print a list of messages at once where each has a different content. > > > > > > Something like this (again the strings are just an illustration): > > > > > > ------------- Error ---------------------- > > > The VM net-A could not be started because > > > there was no fitting host available. > > > > > > Host host-A failed constraint memory > > > Host host-B failed constraint cpu load > > > Host host-C failed constraint memory > > > ------------------------------------------ > > > > > > I am pretty sure the replacing we have in VdcBllMessages does not support > > > this as it cannot assign two or more different values to the same > > > variable. > > > > IIUC the exact request, I think you can use a mechanism I've introduced > > a while back into the error translator. It requires adding each variable > > separately (and multiple times when needed) to the CanDoActionMessages > > list - e.g. [1]. > > The messages will be then localized and displayed in a bullet list layout. > > However, there's one imitation, adding a title message is trickier > > (i.e. every message must preceded by a bullet); as an alternative, > > you can probably utilize 'CommandBase -> setDescription' which is used > > on RunMultipleAction failure (e.g. for displaying VM name on top > > of the relevant errors bullet list). > > > > [1] > > code -> > > > > addCanDoActionMessage(VdcBllMessages.VAR__TYPE__HOST); > > addCanDoActionMessage(String.format("$%1$s %2$s", "hostName", > > "host-A")); > > addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CONSTRAINT_MEMORY); > > > > addCanDoActionMessage(VdcBllMessages.VAR__TYPE__HOST); > > addCanDoActionMessage(String.format("$%1$s %2$s", "hostName", > > "host-B")); > > addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CONSTRAINT_MEMORY); > > > > [VdcBllMessages.ACTION_TYPE_FAILED_CONSTRAINT_MEMORY = > > "${type} ${hostName} failed constraint memory"] > > > > output -> > > > > Error while executing action: > > > > VM1: > > * Host host-A failed constraint memory > > * Host host-B failed constraint memory > > > > > > note: > > instead of adding VAR__TYPE__HOST multiple times, it should be possible to > > just add a new variable that won't conflict with ${type} (which is already > > used > > by VAR__TYPE__VM in case of RunVmCommand). > > > > > > > > -- > > > Martin Siv?k > > > msivak at redhat.com > > > Red Hat Czech > > > RHEV-M SLA / Brno, CZ > > > > > > ----- Original Message ----- > > > > Hi Martin, please follow instructions in [1] for adding new messages to > > > > the > > > > system. > > > > [you should not add the English message to the canDoActionMessages > > > > collection > > > > - you > > > > should add a key from the AppErrors resource - look for other examples > > > > in > > > > the > > > > code > > > > that add items to a command's canDoActionMessages field] > > > > > > > > ---- > > > > Thanks, > > > > Einav > > > > > > > > [1] http://www.ovirt.org/Engine_Adding_Messages > > > > > > > > ----- Original Message ----- > > > > > From: "Martin Sivak" > > > > > To: "engine-devel" > > > > > Sent: Wednesday, October 16, 2013 11:22:02 AM > > > > > Subject: [Engine-devel] Localization of canDoAction error messages > > > > > > > > > > Hi, > > > > > > > > > > I am trying to improve the messages the user gets when scheduling > > > > > fails. > > > > > But > > > > > I have found an interesting issue regarding localization. The texts > > > > > here > > > > > are > > > > > simplified, but should demonstrate what I am trying to do. > > > > > > > > > > So here is the flow: > > > > > > > > > > - RunVmCommand's canDoAction fails because there is no host that fits > > > > > the > > > > > constraints > > > > > - For each host I add a message to > > > > > getReturnValue().getCanDoActionMessages() > > > > > in the format of "Host XYZ failed constraint ABCD". > > > > > - I log the same message to the log > > > > > > > > > > I expect the log to contain the strings in english and a localized > > > > > version > > > > > to > > > > > be shown in the error popup that will be displayed by the webadmin. > > > > > > > > > > And the question is.. how do I localize this? I looked at AppErrors > > > > > and > > > > > AppMessages, but there is not way of using them from the backend > > > > > side. > > > > > > > > > > Any ideas? > > > > > > > > > > -- > > > > > Martin Siv?k > > > > > msivak at redhat.com > > > > > Red Hat Czech > > > > > RHEV-M SLA / Brno, CZ > > > > > > > > > > _______________________________________________ > > > > > Engine-devel mailing list > > > > > Engine-devel at ovirt.org > > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > Engine-devel mailing list > > > Engine-devel at ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > _______________________________________________ > > Engine-devel mailing list > > Engine-devel at ovirt.org > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > From derez at redhat.com Fri Oct 18 10:05:24 2013 From: derez at redhat.com (Daniel Erez) Date: Fri, 18 Oct 2013 06:05:24 -0400 (EDT) Subject: [Engine-devel] Localization of canDoAction error messages In-Reply-To: <972591691.4382255.1382017062538.JavaMail.root@redhat.com> References: <1889528561.2367875.1381936922194.JavaMail.root@redhat.com> <1044678996.3306968.1381937231436.JavaMail.root@redhat.com> <1703006429.2384533.1381938402667.JavaMail.root@redhat.com> <200527324.2823504.1381955407152.JavaMail.root@redhat.com> <972591691.4382255.1382017062538.JavaMail.root@redhat.com> Message-ID: <698226142.3658401.1382090724008.JavaMail.root@redhat.com> ----- Original Message ----- > From: "Einav Cohen" > To: "Daniel Erez" > Cc: "Martin Sivak" , "engine-devel" > Sent: Thursday, October 17, 2013 4:37:42 PM > Subject: Re: [Engine-devel] Localization of canDoAction error messages > > Hi Derez, > > > addCanDoActionMessage(VdcBllMessages.VAR__TYPE__HOST); > > addCanDoActionMessage(String.format("$%1$s %2$s", "hostName", > > "host-A")); > > addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CONSTRAINT_MEMORY); > > > > addCanDoActionMessage(VdcBllMessages.VAR__TYPE__HOST); > > addCanDoActionMessage(String.format("$%1$s %2$s", "hostName", > > "host-B")); > > addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CONSTRAINT_CPU); > > // I changed that from your original message on purpose. > > > > [VdcBllMessages.ACTION_TYPE_FAILED_CONSTRAINT_MEMORY = > > "${type} ${hostName} failed constraint memory"] > > Is there a guarantee that each of the ACTION_TYPE_FAILED_CONSTRAINT_MEMORY > will > be replaced with its "matching" VAR__TYPE__HOST value? isn't there a chance > that > the above will result in: > > ... > Host host-A failed constraint memory > Host host-A failed constraint cpu load // second message was replaced with > an already-used variable value. > ... > > > or in: > ... > Host host-B failed constraint memory > Host host-A failed constraint cpu load // variable values were not used for > their "matching" base-messages. > ... > > ? It shouldn't happen as long as the messages are sent in the correct order (iirc, the inner implementation is based on a linked list). Worth a bit of trial and error though... :) > > > ----- Original Message ----- > > From: "Daniel Erez" > > To: "Martin Sivak" > > Cc: "engine-devel" > > Sent: Wednesday, October 16, 2013 4:30:07 PM > > Subject: Re: [Engine-devel] Localization of canDoAction error messages > > > > > > > > ----- Original Message ----- > > > From: "Martin Sivak" > > > To: "Einav Cohen" > > > Cc: "engine-devel" > > > Sent: Wednesday, October 16, 2013 6:46:42 PM > > > Subject: Re: [Engine-devel] Localization of canDoAction error messages > > > > > > Hi Einav, > > > > > > I know about this procedure, but if you check closely what I am doing, I > > > need > > > to print a list of messages at once where each has a different content. > > > > > > Something like this (again the strings are just an illustration): > > > > > > ------------- Error ---------------------- > > > The VM net-A could not be started because > > > there was no fitting host available. > > > > > > Host host-A failed constraint memory > > > Host host-B failed constraint cpu load > > > Host host-C failed constraint memory > > > ------------------------------------------ > > > > > > I am pretty sure the replacing we have in VdcBllMessages does not support > > > this as it cannot assign two or more different values to the same > > > variable. > > > > IIUC the exact request, I think you can use a mechanism I've introduced > > a while back into the error translator. It requires adding each variable > > separately (and multiple times when needed) to the CanDoActionMessages > > list - e.g. [1]. > > The messages will be then localized and displayed in a bullet list layout. > > However, there's one imitation, adding a title message is trickier > > (i.e. every message must preceded by a bullet); as an alternative, > > you can probably utilize 'CommandBase -> setDescription' which is used > > on RunMultipleAction failure (e.g. for displaying VM name on top > > of the relevant errors bullet list). > > > > [1] > > code -> > > > > addCanDoActionMessage(VdcBllMessages.VAR__TYPE__HOST); > > addCanDoActionMessage(String.format("$%1$s %2$s", "hostName", > > "host-A")); > > addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CONSTRAINT_MEMORY); > > > > addCanDoActionMessage(VdcBllMessages.VAR__TYPE__HOST); > > addCanDoActionMessage(String.format("$%1$s %2$s", "hostName", > > "host-B")); > > addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CONSTRAINT_MEMORY); > > > > [VdcBllMessages.ACTION_TYPE_FAILED_CONSTRAINT_MEMORY = > > "${type} ${hostName} failed constraint memory"] > > > > output -> > > > > Error while executing action: > > > > VM1: > > * Host host-A failed constraint memory > > * Host host-B failed constraint memory > > > > > > note: > > instead of adding VAR__TYPE__HOST multiple times, it should be possible to > > just add a new variable that won't conflict with ${type} (which is already > > used > > by VAR__TYPE__VM in case of RunVmCommand). > > > > > > > > -- > > > Martin Siv?k > > > msivak at redhat.com > > > Red Hat Czech > > > RHEV-M SLA / Brno, CZ > > > > > > ----- Original Message ----- > > > > Hi Martin, please follow instructions in [1] for adding new messages to > > > > the > > > > system. > > > > [you should not add the English message to the canDoActionMessages > > > > collection > > > > - you > > > > should add a key from the AppErrors resource - look for other examples > > > > in > > > > the > > > > code > > > > that add items to a command's canDoActionMessages field] > > > > > > > > ---- > > > > Thanks, > > > > Einav > > > > > > > > [1] http://www.ovirt.org/Engine_Adding_Messages > > > > > > > > ----- Original Message ----- > > > > > From: "Martin Sivak" > > > > > To: "engine-devel" > > > > > Sent: Wednesday, October 16, 2013 11:22:02 AM > > > > > Subject: [Engine-devel] Localization of canDoAction error messages > > > > > > > > > > Hi, > > > > > > > > > > I am trying to improve the messages the user gets when scheduling > > > > > fails. > > > > > But > > > > > I have found an interesting issue regarding localization. The texts > > > > > here > > > > > are > > > > > simplified, but should demonstrate what I am trying to do. > > > > > > > > > > So here is the flow: > > > > > > > > > > - RunVmCommand's canDoAction fails because there is no host that fits > > > > > the > > > > > constraints > > > > > - For each host I add a message to > > > > > getReturnValue().getCanDoActionMessages() > > > > > in the format of "Host XYZ failed constraint ABCD". > > > > > - I log the same message to the log > > > > > > > > > > I expect the log to contain the strings in english and a localized > > > > > version > > > > > to > > > > > be shown in the error popup that will be displayed by the webadmin. > > > > > > > > > > And the question is.. how do I localize this? I looked at AppErrors > > > > > and > > > > > AppMessages, but there is not way of using them from the backend > > > > > side. > > > > > > > > > > Any ideas? > > > > > > > > > > -- > > > > > Martin Siv?k > > > > > msivak at redhat.com > > > > > Red Hat Czech > > > > > RHEV-M SLA / Brno, CZ > > > > > > > > > > _______________________________________________ > > > > > Engine-devel mailing list > > > > > Engine-devel at ovirt.org > > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > Engine-devel mailing list > > > Engine-devel at ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > _______________________________________________ > > Engine-devel mailing list > > Engine-devel at ovirt.org > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > From derez at redhat.com Fri Oct 18 10:06:02 2013 From: derez at redhat.com (Daniel Erez) Date: Fri, 18 Oct 2013 06:06:02 -0400 (EDT) Subject: [Engine-devel] ui code: possible problem in 'remove' confirmation dialog In-Reply-To: <208849508.4323041.1382016296885.JavaMail.root@redhat.com> References: <2017494005.4318252.1382016007331.JavaMail.root@redhat.com> <208849508.4323041.1382016296885.JavaMail.root@redhat.com> Message-ID: <1068645666.3658547.1382090762309.JavaMail.root@redhat.com> ----- Original Message ----- > From: "Einav Cohen" > To: "Daniel Erez" , "Gilad Chaplik" , "Tomas Jelinek" , > "Vojtech Szocs" , "Lior Vernia" > Cc: "engine-devel" > Sent: Thursday, October 17, 2013 4:24:56 PM > Subject: Re: ui code: possible problem in 'remove' confirmation dialog > > [apologies - previous e-mail sent prematurely by mistake] > > Hi, > > Looking at the current code: It seems that we cannot set the message within a > 'remove' confirmation dialog if its HashName starts with "remove_" - it is > being set "statically" to the "Are you sure you want to remove the following > items?" [constants.removeConfirmationPopupMessage] message [1] > > I don't have a major problem with relying on the HashName for setting a > *default* message [2] - but I think that not allowing to override this > message if the developer chooses to do so is an incorrect behavior. > > I would like to change the behavior so that the user would be able to > override the message displayed in that dialog, even if its hash-name is > set to 'remove_'. > > thoughts? objections? > > ---- > Thanks, > Einav > > > [1] From RemoveConfirmationPopupView.java, line 86: > > public void setMessage(String message) { > if (getHashName() != null && getHashName().startsWith("remove_")) { > //$NON-NLS-1$ > super.setMessage(constants.removeConfirmationPopupMessage()); > } else { > super.setMessage(message); > } > } Not sure why we prevent override in this case, I guess it should probably be as simple as: public void setMessage(String message) { super.setMessage(message != null ? message : constants.removeConfirmationPopupMessage()); } Just need to make sure that no one is currently overriding it by mistake to avoid possible regressions. > > [2] in fact, I don't mind that this would be the default message for > this dialog, even if its hash-name is not set to something that starts > with 'remove_'. > > ----- Original Message ----- > > From: "Einav Cohen" > > To: "Daniel Erez" , "Gilad Chaplik" > > , "Tomas Jelinek" , > > "Vojtech Szocs" , "Lior Vernia" > > Cc: "engine-devel" > > Sent: Thursday, October 17, 2013 9:20:07 AM > > Subject: ui code: possible problem in 'remove' confirmation dialog > > > > Hi, > > > > Looking at the current code: It seems that we cannot set the message within > > a > > 'remove' confirmation > > dialog if its HashName starts with "remove_" - it is being set > > "statically[1] > > I don't have a major problem with relying on the HashName for setting a > > *default* message (in fact, > > I don't have a problem > > > > [1] From RemoveConfirmationPopupView.java, line 86: > > > > public void setMessage(String message) { > > if (getHashName() != null && getHashName().startsWith("remove_")) { > > //$NON-NLS-1$ > > super.setMessage(constants.removeConfirmationPopupMessage()); > > } else { > > super.setMessage(message); > > } > > } > > > > ---- > > Regards, > > Einav Cohen Baum > > RHEV-M Engineering - UX Team Manager > > Red Hat, Inc. > > 314 Littleton Road > > Westford, MA 01886 > > T [internal]: (81) 31046 > > T [external]: (+1) 978 589 1046 > > IRC: ecohen @ > > - RHAT [internal]: #rhev-dev #boston #westford #tlv > > - OFTC [external]: #ovirt > > > From ecohen at redhat.com Fri Oct 18 13:44:25 2013 From: ecohen at redhat.com (Einav Cohen) Date: Fri, 18 Oct 2013 09:44:25 -0400 (EDT) Subject: [Engine-devel] ui code: possible problem in 'remove' confirmation dialog In-Reply-To: <1068645666.3658547.1382090762309.JavaMail.root@redhat.com> References: <2017494005.4318252.1382016007331.JavaMail.root@redhat.com> <208849508.4323041.1382016296885.JavaMail.root@redhat.com> <1068645666.3658547.1382090762309.JavaMail.root@redhat.com> Message-ID: <1688807438.5235349.1382103865107.JavaMail.root@redhat.com> > ----- Original Message ----- > From: "Daniel Erez" > Sent: Friday, October 18, 2013 6:06:02 AM > > > > ----- Original Message ----- > > From: "Einav Cohen" > > To: "Daniel Erez" , "Gilad Chaplik" > > , "Tomas Jelinek" , > > "Vojtech Szocs" , "Lior Vernia" > > Cc: "engine-devel" > > Sent: Thursday, October 17, 2013 4:24:56 PM > > Subject: Re: ui code: possible problem in 'remove' confirmation dialog > > > > [apologies - previous e-mail sent prematurely by mistake] > > > > Hi, > > > > Looking at the current code: It seems that we cannot set the message within > > a > > 'remove' confirmation dialog if its HashName starts with "remove_" - it is > > being set "statically" to the "Are you sure you want to remove the > > following > > items?" [constants.removeConfirmationPopupMessage] message [1] > > > > I don't have a major problem with relying on the HashName for setting a > > *default* message [2] - but I think that not allowing to override this > > message if the developer chooses to do so is an incorrect behavior. > > > > I would like to change the behavior so that the user would be able to > > override the message displayed in that dialog, even if its hash-name is > > set to 'remove_'. > > > > thoughts? objections? > > > > ---- > > Thanks, > > Einav > > > > > > [1] From RemoveConfirmationPopupView.java, line 86: > > > > public void setMessage(String message) { > > if (getHashName() != null && getHashName().startsWith("remove_")) > > { > > //$NON-NLS-1$ > > super.setMessage(constants.removeConfirmationPopupMessage()); > > } else { > > super.setMessage(message); > > } > > } > > Not sure why we prevent override in this case, > I guess it should probably be as simple as: > > public void setMessage(String message) { > super.setMessage(message != null ? message : > constants.removeConfirmationPopupMessage()); > } the above would mean that in order to utilize the default message, we would need to explicitly call to 'setMessage()' with 'null' as a parameter, doesn't it? maybe we should do the following instead: public void setMessage(String message) { super.setMessage(message); } public String getMessage() { return super.getMessage() != null ? super.getMessage() : constants.removeConfirmationPopupMessage(); } [of course, the above means that if someone would explicitly sets the message to 'null', the dialog would end up with the default message; but I think it is acceptable. so: - if you want the default message: don't set message / set it to 'null' - if you want an empty message: set message to an empty string - if you want a message other than default: set it to whatever you want] ? > > Just need to make sure that no one is currently overriding > it by mistake to avoid possible regressions. > > > > > [2] in fact, I don't mind that this would be the default message for > > this dialog, even if its hash-name is not set to something that starts > > with 'remove_'. > > > > ----- Original Message ----- > > > From: "Einav Cohen" > > > To: "Daniel Erez" , "Gilad Chaplik" > > > , "Tomas Jelinek" , > > > "Vojtech Szocs" , "Lior Vernia" > > > Cc: "engine-devel" > > > Sent: Thursday, October 17, 2013 9:20:07 AM > > > Subject: ui code: possible problem in 'remove' confirmation dialog > > > > > > Hi, > > > > > > Looking at the current code: It seems that we cannot set the message > > > within > > > a > > > 'remove' confirmation > > > dialog if its HashName starts with "remove_" - it is being set > > > "statically[1] > > > I don't have a major problem with relying on the HashName for setting a > > > *default* message (in fact, > > > I don't have a problem > > > > > > [1] From RemoveConfirmationPopupView.java, line 86: > > > > > > public void setMessage(String message) { > > > if (getHashName() != null && getHashName().startsWith("remove_")) > > > { > > > //$NON-NLS-1$ > > > super.setMessage(constants.removeConfirmationPopupMessage()); > > > } else { > > > super.setMessage(message); > > > } > > > } > > > > > > ---- > > > Regards, > > > Einav Cohen Baum > > > RHEV-M Engineering - UX Team Manager > > > Red Hat, Inc. > > > 314 Littleton Road > > > Westford, MA 01886 > > > T [internal]: (81) 31046 > > > T [external]: (+1) 978 589 1046 > > > IRC: ecohen @ > > > - RHAT [internal]: #rhev-dev #boston #westford #tlv > > > - OFTC [external]: #ovirt > > > > > > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > From derez at redhat.com Sun Oct 20 05:44:44 2013 From: derez at redhat.com (Daniel Erez) Date: Sun, 20 Oct 2013 01:44:44 -0400 (EDT) Subject: [Engine-devel] ui code: possible problem in 'remove' confirmation dialog In-Reply-To: <1688807438.5235349.1382103865107.JavaMail.root@redhat.com> References: <2017494005.4318252.1382016007331.JavaMail.root@redhat.com> <208849508.4323041.1382016296885.JavaMail.root@redhat.com> <1068645666.3658547.1382090762309.JavaMail.root@redhat.com> <1688807438.5235349.1382103865107.JavaMail.root@redhat.com> Message-ID: <535872808.4063401.1382247884773.JavaMail.root@redhat.com> ----- Original Message ----- > From: "Einav Cohen" > To: "Daniel Erez" , "Greg Sheremeta" > Cc: "engine-devel" > Sent: Friday, October 18, 2013 4:44:25 PM > Subject: Re: [Engine-devel] ui code: possible problem in 'remove' confirmation dialog > > > ----- Original Message ----- > > From: "Daniel Erez" > > Sent: Friday, October 18, 2013 6:06:02 AM > > > > > > > > ----- Original Message ----- > > > From: "Einav Cohen" > > > To: "Daniel Erez" , "Gilad Chaplik" > > > , "Tomas Jelinek" , > > > "Vojtech Szocs" , "Lior Vernia" > > > Cc: "engine-devel" > > > Sent: Thursday, October 17, 2013 4:24:56 PM > > > Subject: Re: ui code: possible problem in 'remove' confirmation dialog > > > > > > [apologies - previous e-mail sent prematurely by mistake] > > > > > > Hi, > > > > > > Looking at the current code: It seems that we cannot set the message > > > within > > > a > > > 'remove' confirmation dialog if its HashName starts with "remove_" - it > > > is > > > being set "statically" to the "Are you sure you want to remove the > > > following > > > items?" [constants.removeConfirmationPopupMessage] message [1] > > > > > > I don't have a major problem with relying on the HashName for setting a > > > *default* message [2] - but I think that not allowing to override this > > > message if the developer chooses to do so is an incorrect behavior. > > > > > > I would like to change the behavior so that the user would be able to > > > override the message displayed in that dialog, even if its hash-name is > > > set to 'remove_'. > > > > > > thoughts? objections? > > > > > > ---- > > > Thanks, > > > Einav > > > > > > > > > [1] From RemoveConfirmationPopupView.java, line 86: > > > > > > public void setMessage(String message) { > > > if (getHashName() != null && > > > getHashName().startsWith("remove_")) > > > { > > > //$NON-NLS-1$ > > > super.setMessage(constants.removeConfirmationPopupMessage()); > > > } else { > > > super.setMessage(message); > > > } > > > } > > > > Not sure why we prevent override in this case, > > I guess it should probably be as simple as: > > > > public void setMessage(String message) { > > super.setMessage(message != null ? message : > > constants.removeConfirmationPopupMessage()); > > } > > the above would mean that in order to utilize the default message, > we would need to explicitly call to 'setMessage()' with 'null' as > a parameter, doesn't it? IINM, setMessage is called explicitly with model's getMessage upon popup revealing. So we don't need to call setMessage with null again. > > maybe we should do the following instead: > > public void setMessage(String message) { > super.setMessage(message); > } > > public String getMessage() { > return super.getMessage() != null ? super.getMessage() : > constants.removeConfirmationPopupMessage(); > } > > [of course, the above means that if someone would explicitly sets > the message to 'null', the dialog would end up with the default > message; but I think it is acceptable. so: > - if you want the default message: don't set message / set it to 'null' Just don't set a message, no need to set it to null. > - if you want an empty message: set message to an empty string > - if you want a message other than default: set it to whatever you want] > > ? +1 > > > > > Just need to make sure that no one is currently overriding > > it by mistake to avoid possible regressions. > > > > > > > > [2] in fact, I don't mind that this would be the default message for > > > this dialog, even if its hash-name is not set to something that starts > > > with 'remove_'. > > > > > > ----- Original Message ----- > > > > From: "Einav Cohen" > > > > To: "Daniel Erez" , "Gilad Chaplik" > > > > , "Tomas Jelinek" , > > > > "Vojtech Szocs" , "Lior Vernia" > > > > Cc: "engine-devel" > > > > Sent: Thursday, October 17, 2013 9:20:07 AM > > > > Subject: ui code: possible problem in 'remove' confirmation dialog > > > > > > > > Hi, > > > > > > > > Looking at the current code: It seems that we cannot set the message > > > > within > > > > a > > > > 'remove' confirmation > > > > dialog if its HashName starts with "remove_" - it is being set > > > > "statically[1] > > > > I don't have a major problem with relying on the HashName for setting a > > > > *default* message (in fact, > > > > I don't have a problem > > > > > > > > [1] From RemoveConfirmationPopupView.java, line 86: > > > > > > > > public void setMessage(String message) { > > > > if (getHashName() != null && > > > > getHashName().startsWith("remove_")) > > > > { > > > > //$NON-NLS-1$ > > > > super.setMessage(constants.removeConfirmationPopupMessage()); > > > > } else { > > > > super.setMessage(message); > > > > } > > > > } > > > > > > > > ---- > > > > Regards, > > > > Einav Cohen Baum > > > > RHEV-M Engineering - UX Team Manager > > > > Red Hat, Inc. > > > > 314 Littleton Road > > > > Westford, MA 01886 > > > > T [internal]: (81) 31046 > > > > T [external]: (+1) 978 589 1046 > > > > IRC: ecohen @ > > > > - RHAT [internal]: #rhev-dev #boston #westford #tlv > > > > - OFTC [external]: #ovirt > > > > > > > > > _______________________________________________ > > Engine-devel mailing list > > Engine-devel at ovirt.org > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > From vszocs at redhat.com Mon Oct 21 09:55:05 2013 From: vszocs at redhat.com (Vojtech Szocs) Date: Mon, 21 Oct 2013 05:55:05 -0400 (EDT) Subject: [Engine-devel] ui code: possible problem in 'remove' confirmation dialog In-Reply-To: <1068645666.3658547.1382090762309.JavaMail.root@redhat.com> References: <2017494005.4318252.1382016007331.JavaMail.root@redhat.com> <208849508.4323041.1382016296885.JavaMail.root@redhat.com> <1068645666.3658547.1382090762309.JavaMail.root@redhat.com> Message-ID: <1674204003.5589198.1382349305006.JavaMail.root@redhat.com> ----- Original Message ----- > From: "Daniel Erez" > To: "Einav Cohen" > Cc: "Gilad Chaplik" , "Tomas Jelinek" , "Vojtech Szocs" > , "Lior Vernia" , "engine-devel" > Sent: Friday, October 18, 2013 12:06:02 PM > Subject: Re: ui code: possible problem in 'remove' confirmation dialog > > > > ----- Original Message ----- > > From: "Einav Cohen" > > To: "Daniel Erez" , "Gilad Chaplik" > > , "Tomas Jelinek" , > > "Vojtech Szocs" , "Lior Vernia" > > Cc: "engine-devel" > > Sent: Thursday, October 17, 2013 4:24:56 PM > > Subject: Re: ui code: possible problem in 'remove' confirmation dialog > > > > [apologies - previous e-mail sent prematurely by mistake] > > > > Hi, > > > > Looking at the current code: It seems that we cannot set the message within > > a > > 'remove' confirmation dialog if its HashName starts with "remove_" - it is > > being set "statically" to the "Are you sure you want to remove the > > following > > items?" [constants.removeConfirmationPopupMessage] message [1] > > > > I don't have a major problem with relying on the HashName for setting a > > *default* message [2] - but I think that not allowing to override this > > message if the developer chooses to do so is an incorrect behavior. > > > > I would like to change the behavior so that the user would be able to > > override the message displayed in that dialog, even if its hash-name is > > set to 'remove_'. > > > > thoughts? objections? > > > > ---- > > Thanks, > > Einav > > > > > > [1] From RemoveConfirmationPopupView.java, line 86: > > > > public void setMessage(String message) { > > if (getHashName() != null && getHashName().startsWith("remove_")) > > { > > //$NON-NLS-1$ > > super.setMessage(constants.removeConfirmationPopupMessage()); > > } else { > > super.setMessage(message); > > } > > } > > Not sure why we prevent override in this case, IIRC the current RemoveConfirmationPopupView.setMessage implementation reflects the assumption that all remove confirm dialogs [hashName=remove_*] have the same message, i.e. "Are you sure you want to remove the following items?". However, looking at VmListModel#remove (VM main tab / Remove button) it first sets [hashName=remove_virtual_machine] and then sets message like "Virtual Machine(s)". In practice, RemoveConfirmationPopupView.setMessage will still make the dialog message generic, i.e. "Are you sure ... following items?". > I guess it should probably be as simple as: > > public void setMessage(String message) { > super.setMessage(message != null ? message : > constants.removeConfirmationPopupMessage()); > } For that, we'd have to analyze and modify existing UiCommon models to call setMessage with appropriate value, i.e. VmListModel#remove currently yields RemoveConfirmationPopupView.setMessage("Virtual Machine(s)") > > Just need to make sure that no one is currently overriding > it by mistake to avoid possible regressions. I think the general pattern used in UiCommon models when dealing with remove confirm dialogs is following: - set wnd hashName to "remove_" i.e. "remove_virtual_machine" - set wnd message to "" i.e. "Virtual Machine(s)" Alternative to Daniel's suggestion, following above mentioned pattern: if (message != null) { // expecting message to be "" // should yield "Are you sure you want to remove ?" super.setMessage(messages.removeConfirmationPopupMessage(message)); } else { super.setMessage(message); } > > > > > [2] in fact, I don't mind that this would be the default message for > > this dialog, even if its hash-name is not set to something that starts > > with 'remove_'. > > > > ----- Original Message ----- > > > From: "Einav Cohen" > > > To: "Daniel Erez" , "Gilad Chaplik" > > > , "Tomas Jelinek" , > > > "Vojtech Szocs" , "Lior Vernia" > > > Cc: "engine-devel" > > > Sent: Thursday, October 17, 2013 9:20:07 AM > > > Subject: ui code: possible problem in 'remove' confirmation dialog > > > > > > Hi, > > > > > > Looking at the current code: It seems that we cannot set the message > > > within > > > a > > > 'remove' confirmation > > > dialog if its HashName starts with "remove_" - it is being set > > > "statically[1] > > > I don't have a major problem with relying on the HashName for setting a > > > *default* message (in fact, > > > I don't have a problem > > > > > > [1] From RemoveConfirmationPopupView.java, line 86: > > > > > > public void setMessage(String message) { > > > if (getHashName() != null && getHashName().startsWith("remove_")) > > > { > > > //$NON-NLS-1$ > > > super.setMessage(constants.removeConfirmationPopupMessage()); > > > } else { > > > super.setMessage(message); > > > } > > > } > > > > > > ---- > > > Regards, > > > Einav Cohen Baum > > > RHEV-M Engineering - UX Team Manager > > > Red Hat, Inc. > > > 314 Littleton Road > > > Westford, MA 01886 > > > T [internal]: (81) 31046 > > > T [external]: (+1) 978 589 1046 > > > IRC: ecohen @ > > > - RHAT [internal]: #rhev-dev #boston #westford #tlv > > > - OFTC [external]: #ovirt > > > > > > From derez at redhat.com Mon Oct 21 12:12:22 2013 From: derez at redhat.com (Daniel Erez) Date: Mon, 21 Oct 2013 08:12:22 -0400 (EDT) Subject: [Engine-devel] ui code: possible problem in 'remove' confirmation dialog In-Reply-To: <1674204003.5589198.1382349305006.JavaMail.root@redhat.com> References: <2017494005.4318252.1382016007331.JavaMail.root@redhat.com> <208849508.4323041.1382016296885.JavaMail.root@redhat.com> <1068645666.3658547.1382090762309.JavaMail.root@redhat.com> <1674204003.5589198.1382349305006.JavaMail.root@redhat.com> Message-ID: <609509319.4366970.1382357542000.JavaMail.root@redhat.com> ----- Original Message ----- > From: "Vojtech Szocs" > To: "Daniel Erez" > Cc: "Einav Cohen" , "Gilad Chaplik" , "Tomas Jelinek" , > "Lior Vernia" , "engine-devel" > Sent: Monday, October 21, 2013 12:55:05 PM > Subject: Re: ui code: possible problem in 'remove' confirmation dialog > > > > ----- Original Message ----- > > From: "Daniel Erez" > > To: "Einav Cohen" > > Cc: "Gilad Chaplik" , "Tomas Jelinek" > > , "Vojtech Szocs" > > , "Lior Vernia" , "engine-devel" > > > > Sent: Friday, October 18, 2013 12:06:02 PM > > Subject: Re: ui code: possible problem in 'remove' confirmation dialog > > > > > > > > ----- Original Message ----- > > > From: "Einav Cohen" > > > To: "Daniel Erez" , "Gilad Chaplik" > > > , "Tomas Jelinek" , > > > "Vojtech Szocs" , "Lior Vernia" > > > Cc: "engine-devel" > > > Sent: Thursday, October 17, 2013 4:24:56 PM > > > Subject: Re: ui code: possible problem in 'remove' confirmation dialog > > > > > > [apologies - previous e-mail sent prematurely by mistake] > > > > > > Hi, > > > > > > Looking at the current code: It seems that we cannot set the message > > > within > > > a > > > 'remove' confirmation dialog if its HashName starts with "remove_" - it > > > is > > > being set "statically" to the "Are you sure you want to remove the > > > following > > > items?" [constants.removeConfirmationPopupMessage] message [1] > > > > > > I don't have a major problem with relying on the HashName for setting a > > > *default* message [2] - but I think that not allowing to override this > > > message if the developer chooses to do so is an incorrect behavior. > > > > > > I would like to change the behavior so that the user would be able to > > > override the message displayed in that dialog, even if its hash-name is > > > set to 'remove_'. > > > > > > thoughts? objections? > > > > > > ---- > > > Thanks, > > > Einav > > > > > > > > > [1] From RemoveConfirmationPopupView.java, line 86: > > > > > > public void setMessage(String message) { > > > if (getHashName() != null && > > > getHashName().startsWith("remove_")) > > > { > > > //$NON-NLS-1$ > > > super.setMessage(constants.removeConfirmationPopupMessage()); > > > } else { > > > super.setMessage(message); > > > } > > > } > > > > Not sure why we prevent override in this case, > > IIRC the current RemoveConfirmationPopupView.setMessage implementation > reflects the assumption that all remove confirm dialogs [hashName=remove_*] > have the same message, i.e. "Are you sure you want to remove the following > items?". > > However, looking at VmListModel#remove (VM main tab / Remove button) it first > sets [hashName=remove_virtual_machine] and then sets message like "Virtual > Machine(s)". In practice, RemoveConfirmationPopupView.setMessage will still > make the dialog message generic, i.e. "Are you sure ... following items?". > > > I guess it should probably be as simple as: > > > > public void setMessage(String message) { > > super.setMessage(message != null ? message : > > constants.removeConfirmationPopupMessage()); > > } > > For that, we'd have to analyze and modify existing UiCommon models to call > setMessage with appropriate value, i.e. VmListModel#remove currently yields > RemoveConfirmationPopupView.setMessage("Virtual Machine(s)") Isn't it a cleanup that should be done either way? (I assume this message isn't currently used on any context...). But indeed, it will require making sure that no one is currently overriding the setMessage() by mistake to avoid such possible regressions. > > > > > Just need to make sure that no one is currently overriding > > it by mistake to avoid possible regressions. > > I think the general pattern used in UiCommon models when dealing with remove > confirm dialogs is following: > - set wnd hashName to "remove_" i.e. "remove_virtual_machine" > - set wnd message to "" i.e. "Virtual Machine(s)" > > Alternative to Daniel's suggestion, following above mentioned pattern: > > if (message != null) { > // expecting message to be "" > // should yield "Are you sure you want to remove ?" > super.setMessage(messages.removeConfirmationPopupMessage(message)); > } else { > super.setMessage(message); > } What about default value (when message is null)? Do you mean we should add another abstract class in the hierarchy that would default it to "Are you sure you want to remove the following items?". [btw, we might have some localization issues with this pattern as we've encountered with 'no items to display'; so just need to check it out]. > > > > > > > > > [2] in fact, I don't mind that this would be the default message for > > > this dialog, even if its hash-name is not set to something that starts > > > with 'remove_'. > > > > > > ----- Original Message ----- > > > > From: "Einav Cohen" > > > > To: "Daniel Erez" , "Gilad Chaplik" > > > > , "Tomas Jelinek" , > > > > "Vojtech Szocs" , "Lior Vernia" > > > > Cc: "engine-devel" > > > > Sent: Thursday, October 17, 2013 9:20:07 AM > > > > Subject: ui code: possible problem in 'remove' confirmation dialog > > > > > > > > Hi, > > > > > > > > Looking at the current code: It seems that we cannot set the message > > > > within > > > > a > > > > 'remove' confirmation > > > > dialog if its HashName starts with "remove_" - it is being set > > > > "statically[1] > > > > I don't have a major problem with relying on the HashName for setting a > > > > *default* message (in fact, > > > > I don't have a problem > > > > > > > > [1] From RemoveConfirmationPopupView.java, line 86: > > > > > > > > public void setMessage(String message) { > > > > if (getHashName() != null && > > > > getHashName().startsWith("remove_")) > > > > { > > > > //$NON-NLS-1$ > > > > super.setMessage(constants.removeConfirmationPopupMessage()); > > > > } else { > > > > super.setMessage(message); > > > > } > > > > } > > > > > > > > ---- > > > > Regards, > > > > Einav Cohen Baum > > > > RHEV-M Engineering - UX Team Manager > > > > Red Hat, Inc. > > > > 314 Littleton Road > > > > Westford, MA 01886 > > > > T [internal]: (81) 31046 > > > > T [external]: (+1) 978 589 1046 > > > > IRC: ecohen @ > > > > - RHAT [internal]: #rhev-dev #boston #westford #tlv > > > > - OFTC [external]: #ovirt > > > > > > > > > > From vszocs at redhat.com Mon Oct 21 12:57:16 2013 From: vszocs at redhat.com (Vojtech Szocs) Date: Mon, 21 Oct 2013 08:57:16 -0400 (EDT) Subject: [Engine-devel] ui code: possible problem in 'remove' confirmation dialog In-Reply-To: <609509319.4366970.1382357542000.JavaMail.root@redhat.com> References: <2017494005.4318252.1382016007331.JavaMail.root@redhat.com> <208849508.4323041.1382016296885.JavaMail.root@redhat.com> <1068645666.3658547.1382090762309.JavaMail.root@redhat.com> <1674204003.5589198.1382349305006.JavaMail.root@redhat.com> <609509319.4366970.1382357542000.JavaMail.root@redhat.com> Message-ID: <854385228.5674605.1382360236956.JavaMail.root@redhat.com> ----- Original Message ----- > From: "Daniel Erez" > To: "Vojtech Szocs" > Cc: "Einav Cohen" , "Gilad Chaplik" , "Tomas Jelinek" , > "Lior Vernia" , "engine-devel" > Sent: Monday, October 21, 2013 2:12:22 PM > Subject: Re: ui code: possible problem in 'remove' confirmation dialog > > > > ----- Original Message ----- > > From: "Vojtech Szocs" > > To: "Daniel Erez" > > Cc: "Einav Cohen" , "Gilad Chaplik" > > , "Tomas Jelinek" , > > "Lior Vernia" , "engine-devel" > > Sent: Monday, October 21, 2013 12:55:05 PM > > Subject: Re: ui code: possible problem in 'remove' confirmation dialog > > > > > > > > ----- Original Message ----- > > > From: "Daniel Erez" > > > To: "Einav Cohen" > > > Cc: "Gilad Chaplik" , "Tomas Jelinek" > > > , "Vojtech Szocs" > > > , "Lior Vernia" , "engine-devel" > > > > > > Sent: Friday, October 18, 2013 12:06:02 PM > > > Subject: Re: ui code: possible problem in 'remove' confirmation dialog > > > > > > > > > > > > ----- Original Message ----- > > > > From: "Einav Cohen" > > > > To: "Daniel Erez" , "Gilad Chaplik" > > > > , "Tomas Jelinek" , > > > > "Vojtech Szocs" , "Lior Vernia" > > > > Cc: "engine-devel" > > > > Sent: Thursday, October 17, 2013 4:24:56 PM > > > > Subject: Re: ui code: possible problem in 'remove' confirmation dialog > > > > > > > > [apologies - previous e-mail sent prematurely by mistake] > > > > > > > > Hi, > > > > > > > > Looking at the current code: It seems that we cannot set the message > > > > within > > > > a > > > > 'remove' confirmation dialog if its HashName starts with "remove_" - it > > > > is > > > > being set "statically" to the "Are you sure you want to remove the > > > > following > > > > items?" [constants.removeConfirmationPopupMessage] message [1] > > > > > > > > I don't have a major problem with relying on the HashName for setting a > > > > *default* message [2] - but I think that not allowing to override this > > > > message if the developer chooses to do so is an incorrect behavior. > > > > > > > > I would like to change the behavior so that the user would be able to > > > > override the message displayed in that dialog, even if its hash-name is > > > > set to 'remove_'. > > > > > > > > thoughts? objections? > > > > > > > > ---- > > > > Thanks, > > > > Einav > > > > > > > > > > > > [1] From RemoveConfirmationPopupView.java, line 86: > > > > > > > > public void setMessage(String message) { > > > > if (getHashName() != null && > > > > getHashName().startsWith("remove_")) > > > > { > > > > //$NON-NLS-1$ > > > > super.setMessage(constants.removeConfirmationPopupMessage()); > > > > } else { > > > > super.setMessage(message); > > > > } > > > > } > > > > > > Not sure why we prevent override in this case, > > > > IIRC the current RemoveConfirmationPopupView.setMessage implementation > > reflects the assumption that all remove confirm dialogs [hashName=remove_*] > > have the same message, i.e. "Are you sure you want to remove the following > > items?". > > > > However, looking at VmListModel#remove (VM main tab / Remove button) it > > first > > sets [hashName=remove_virtual_machine] and then sets message like "Virtual > > Machine(s)". In practice, RemoveConfirmationPopupView.setMessage will still > > make the dialog message generic, i.e. "Are you sure ... following items?". > > > > > I guess it should probably be as simple as: > > > > > > public void setMessage(String message) { > > > super.setMessage(message != null ? message : > > > constants.removeConfirmationPopupMessage()); > > > } > > > > For that, we'd have to analyze and modify existing UiCommon models to call > > setMessage with appropriate value, i.e. VmListModel#remove currently yields > > RemoveConfirmationPopupView.setMessage("Virtual Machine(s)") > > Isn't it a cleanup that should be done either way? > (I assume this message isn't currently used on any context...). Yes, I guess some sort of cleanup will be required anyway. For me, the question is if we want to give models the ability to specify full remove confirm msg (i.e. "Are you sure...") or just the item part of it (i.e. "Virtual Machine(s)"). >From localization perspective, full remove confirm msg seems more flexible but will add more msg keys, however as you wrote we'd need some more changes in UiCommon models anyway. > But indeed, it will require making sure that no one is > currently overriding the setMessage() by mistake to > avoid such possible regressions. > > > > > > > > > Just need to make sure that no one is currently overriding > > > it by mistake to avoid possible regressions. > > > > I think the general pattern used in UiCommon models when dealing with > > remove > > confirm dialogs is following: > > - set wnd hashName to "remove_" i.e. "remove_virtual_machine" > > - set wnd message to "" i.e. "Virtual Machine(s)" > > > > Alternative to Daniel's suggestion, following above mentioned pattern: > > > > if (message != null) { > > // expecting message to be "" > > // should yield "Are you sure you want to remove > item(s)>?" > > super.setMessage(messages.removeConfirmationPopupMessage(message)); > > } else { > > super.setMessage(message); > > } > > What about default value (when message is null)? The setMessage code I've mentioned above was based on assumption that UiCommon models such as VmListModel will always follow convention like removeConfirmDialogModel.setMessage("item(s)") .. but maybe such assumption is too strong. In general, you're right, there should be some default value handling included (I forgot about this, sorry). > Do you mean we should add another abstract class in > the hierarchy that would default it to > "Are you sure you want to remove the following items?". > [btw, we might have some localization issues with this > pattern as we've encountered with 'no items to display'; > so just need to check it out]. OK, in that case we can follow Daniel's suggestion (setMessage code that just delegates to super.setMessage unless message == null for which there'd be some default msg), along with updating relevant UiCommon models (i.e. strings used when calling setMessage). > > > > > > > > > > > > > > [2] in fact, I don't mind that this would be the default message for > > > > this dialog, even if its hash-name is not set to something that starts > > > > with 'remove_'. > > > > > > > > ----- Original Message ----- > > > > > From: "Einav Cohen" > > > > > To: "Daniel Erez" , "Gilad Chaplik" > > > > > , "Tomas Jelinek" , > > > > > "Vojtech Szocs" , "Lior Vernia" > > > > > > > > > > Cc: "engine-devel" > > > > > Sent: Thursday, October 17, 2013 9:20:07 AM > > > > > Subject: ui code: possible problem in 'remove' confirmation dialog > > > > > > > > > > Hi, > > > > > > > > > > Looking at the current code: It seems that we cannot set the message > > > > > within > > > > > a > > > > > 'remove' confirmation > > > > > dialog if its HashName starts with "remove_" - it is being set > > > > > "statically[1] > > > > > I don't have a major problem with relying on the HashName for setting > > > > > a > > > > > *default* message (in fact, > > > > > I don't have a problem > > > > > > > > > > [1] From RemoveConfirmationPopupView.java, line 86: > > > > > > > > > > public void setMessage(String message) { > > > > > if (getHashName() != null && > > > > > getHashName().startsWith("remove_")) > > > > > { > > > > > //$NON-NLS-1$ > > > > > super.setMessage(constants.removeConfirmationPopupMessage()); > > > > > } else { > > > > > super.setMessage(message); > > > > > } > > > > > } > > > > > > > > > > ---- > > > > > Regards, > > > > > Einav Cohen Baum > > > > > RHEV-M Engineering - UX Team Manager > > > > > Red Hat, Inc. > > > > > 314 Littleton Road > > > > > Westford, MA 01886 > > > > > T [internal]: (81) 31046 > > > > > T [external]: (+1) 978 589 1046 > > > > > IRC: ecohen @ > > > > > - RHAT [internal]: #rhev-dev #boston #westford #tlv > > > > > - OFTC [external]: #ovirt > > > > > > > > > > > > > > > From ecohen at redhat.com Mon Oct 21 13:28:56 2013 From: ecohen at redhat.com (Einav Cohen) Date: Mon, 21 Oct 2013 09:28:56 -0400 (EDT) Subject: [Engine-devel] ui code: possible problem in 'remove' confirmation dialog In-Reply-To: <854385228.5674605.1382360236956.JavaMail.root@redhat.com> References: <2017494005.4318252.1382016007331.JavaMail.root@redhat.com> <208849508.4323041.1382016296885.JavaMail.root@redhat.com> <1068645666.3658547.1382090762309.JavaMail.root@redhat.com> <1674204003.5589198.1382349305006.JavaMail.root@redhat.com> <609509319.4366970.1382357542000.JavaMail.root@redhat.com> <854385228.5674605.1382360236956.JavaMail.root@redhat.com> Message-ID: <559748560.6785202.1382362136276.JavaMail.root@redhat.com> > For me, the question is if we want to give models the ability to specify full > remove confirm msg (i.e. "Are you sure...") or just the item part of it > (i.e. "Virtual Machine(s)"). > > >From localization perspective, full remove confirm msg seems more flexible > >but will add more msg keys, however as you wrote we'd need some more > >changes in UiCommon models anyway. we *must* be able to specify full remove confirm msg only - we should not use message "particles", as they cause translation-hell (sigular vs. plural, etc.) - we had multiple problems with that in the past - that's why we changed the message here from "are you sure ... ?" to the more generic "are you sure ... items?" [http://gerrit.ovirt.org/#/c/14621] thanks. > ----- Original Message ----- > From: "Vojtech Szocs" > Sent: Monday, October 21, 2013 8:57:16 AM > > > ----- Original Message ----- > > From: "Daniel Erez" > > To: "Vojtech Szocs" > > Cc: "Einav Cohen" , "Gilad Chaplik" > > , "Tomas Jelinek" , > > "Lior Vernia" , "engine-devel" > > Sent: Monday, October 21, 2013 2:12:22 PM > > Subject: Re: ui code: possible problem in 'remove' confirmation dialog > > > > > > > > ----- Original Message ----- > > > From: "Vojtech Szocs" > > > To: "Daniel Erez" > > > Cc: "Einav Cohen" , "Gilad Chaplik" > > > , "Tomas Jelinek" , > > > "Lior Vernia" , "engine-devel" > > > > > > Sent: Monday, October 21, 2013 12:55:05 PM > > > Subject: Re: ui code: possible problem in 'remove' confirmation dialog > > > > > > > > > > > > ----- Original Message ----- > > > > From: "Daniel Erez" > > > > To: "Einav Cohen" > > > > Cc: "Gilad Chaplik" , "Tomas Jelinek" > > > > , "Vojtech Szocs" > > > > , "Lior Vernia" , "engine-devel" > > > > > > > > Sent: Friday, October 18, 2013 12:06:02 PM > > > > Subject: Re: ui code: possible problem in 'remove' confirmation dialog > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > From: "Einav Cohen" > > > > > To: "Daniel Erez" , "Gilad Chaplik" > > > > > , "Tomas Jelinek" , > > > > > "Vojtech Szocs" , "Lior Vernia" > > > > > > > > > > Cc: "engine-devel" > > > > > Sent: Thursday, October 17, 2013 4:24:56 PM > > > > > Subject: Re: ui code: possible problem in 'remove' confirmation > > > > > dialog > > > > > > > > > > [apologies - previous e-mail sent prematurely by mistake] > > > > > > > > > > Hi, > > > > > > > > > > Looking at the current code: It seems that we cannot set the message > > > > > within > > > > > a > > > > > 'remove' confirmation dialog if its HashName starts with "remove_" - > > > > > it > > > > > is > > > > > being set "statically" to the "Are you sure you want to remove the > > > > > following > > > > > items?" [constants.removeConfirmationPopupMessage] message [1] > > > > > > > > > > I don't have a major problem with relying on the HashName for setting > > > > > a > > > > > *default* message [2] - but I think that not allowing to override > > > > > this > > > > > message if the developer chooses to do so is an incorrect behavior. > > > > > > > > > > I would like to change the behavior so that the user would be able to > > > > > override the message displayed in that dialog, even if its hash-name > > > > > is > > > > > set to 'remove_'. > > > > > > > > > > thoughts? objections? > > > > > > > > > > ---- > > > > > Thanks, > > > > > Einav > > > > > > > > > > > > > > > [1] From RemoveConfirmationPopupView.java, line 86: > > > > > > > > > > public void setMessage(String message) { > > > > > if (getHashName() != null && > > > > > getHashName().startsWith("remove_")) > > > > > { > > > > > //$NON-NLS-1$ > > > > > super.setMessage(constants.removeConfirmationPopupMessage()); > > > > > } else { > > > > > super.setMessage(message); > > > > > } > > > > > } > > > > > > > > Not sure why we prevent override in this case, > > > > > > IIRC the current RemoveConfirmationPopupView.setMessage implementation > > > reflects the assumption that all remove confirm dialogs > > > [hashName=remove_*] > > > have the same message, i.e. "Are you sure you want to remove the > > > following > > > items?". > > > > > > However, looking at VmListModel#remove (VM main tab / Remove button) it > > > first > > > sets [hashName=remove_virtual_machine] and then sets message like > > > "Virtual > > > Machine(s)". In practice, RemoveConfirmationPopupView.setMessage will > > > still > > > make the dialog message generic, i.e. "Are you sure ... following > > > items?". > > > > > > > I guess it should probably be as simple as: > > > > > > > > public void setMessage(String message) { > > > > super.setMessage(message != null ? message : > > > > constants.removeConfirmationPopupMessage()); > > > > } > > > > > > For that, we'd have to analyze and modify existing UiCommon models to > > > call > > > setMessage with appropriate value, i.e. VmListModel#remove currently > > > yields > > > RemoveConfirmationPopupView.setMessage("Virtual Machine(s)") > > > > Isn't it a cleanup that should be done either way? > > (I assume this message isn't currently used on any context...). > > Yes, I guess some sort of cleanup will be required anyway. > > For me, the question is if we want to give models the ability to specify full > remove confirm msg (i.e. "Are you sure...") or just the item part of it > (i.e. "Virtual Machine(s)"). > > >From localization perspective, full remove confirm msg seems more flexible > >but will add more msg keys, however as you wrote we'd need some more > >changes in UiCommon models anyway. > > > But indeed, it will require making sure that no one is > > currently overriding the setMessage() by mistake to > > avoid such possible regressions. > > > > > > > > > > > > > Just need to make sure that no one is currently overriding > > > > it by mistake to avoid possible regressions. > > > > > > I think the general pattern used in UiCommon models when dealing with > > > remove > > > confirm dialogs is following: > > > - set wnd hashName to "remove_" i.e. "remove_virtual_machine" > > > - set wnd message to "" i.e. "Virtual Machine(s)" > > > > > > Alternative to Daniel's suggestion, following above mentioned pattern: > > > > > > if (message != null) { > > > // expecting message to be "" > > > // should yield "Are you sure you want to remove > > item(s)>?" > > > super.setMessage(messages.removeConfirmationPopupMessage(message)); > > > } else { > > > super.setMessage(message); > > > } > > > > What about default value (when message is null)? > > The setMessage code I've mentioned above was based on assumption that > UiCommon models such as VmListModel will always follow convention like > removeConfirmDialogModel.setMessage("item(s)") .. but maybe such assumption > is too strong. > > In general, you're right, there should be some default value handling > included (I forgot about this, sorry). > > > Do you mean we should add another abstract class in > > the hierarchy that would default it to > > "Are you sure you want to remove the following items?". > > [btw, we might have some localization issues with this > > pattern as we've encountered with 'no items to display'; > > so just need to check it out]. > > OK, in that case we can follow Daniel's suggestion (setMessage code that just > delegates to super.setMessage unless message == null for which there'd be > some default msg), along with updating relevant UiCommon models (i.e. > strings used when calling setMessage). > > > > > > > > > > > > > > > > > > > > [2] in fact, I don't mind that this would be the default message for > > > > > this dialog, even if its hash-name is not set to something that > > > > > starts > > > > > with 'remove_'. > > > > > > > > > > ----- Original Message ----- > > > > > > From: "Einav Cohen" > > > > > > To: "Daniel Erez" , "Gilad Chaplik" > > > > > > , "Tomas Jelinek" , > > > > > > "Vojtech Szocs" , "Lior Vernia" > > > > > > > > > > > > Cc: "engine-devel" > > > > > > Sent: Thursday, October 17, 2013 9:20:07 AM > > > > > > Subject: ui code: possible problem in 'remove' confirmation dialog > > > > > > > > > > > > Hi, > > > > > > > > > > > > Looking at the current code: It seems that we cannot set the > > > > > > message > > > > > > within > > > > > > a > > > > > > 'remove' confirmation > > > > > > dialog if its HashName starts with "remove_" - it is being set > > > > > > "statically[1] > > > > > > I don't have a major problem with relying on the HashName for > > > > > > setting > > > > > > a > > > > > > *default* message (in fact, > > > > > > I don't have a problem > > > > > > > > > > > > [1] From RemoveConfirmationPopupView.java, line 86: > > > > > > > > > > > > public void setMessage(String message) { > > > > > > if (getHashName() != null && > > > > > > getHashName().startsWith("remove_")) > > > > > > { > > > > > > //$NON-NLS-1$ > > > > > > super.setMessage(constants.removeConfirmationPopupMessage()); > > > > > > } else { > > > > > > super.setMessage(message); > > > > > > } > > > > > > } > > > > > > > > > > > > ---- > > > > > > Regards, > > > > > > Einav Cohen Baum > > > > > > RHEV-M Engineering - UX Team Manager > > > > > > Red Hat, Inc. > > > > > > 314 Littleton Road > > > > > > Westford, MA 01886 > > > > > > T [internal]: (81) 31046 > > > > > > T [external]: (+1) 978 589 1046 > > > > > > IRC: ecohen @ > > > > > > - RHAT [internal]: #rhev-dev #boston #westford #tlv > > > > > > - OFTC [external]: #ovirt > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > From vszocs at redhat.com Mon Oct 21 13:39:04 2013 From: vszocs at redhat.com (Vojtech Szocs) Date: Mon, 21 Oct 2013 09:39:04 -0400 (EDT) Subject: [Engine-devel] ui code: possible problem in 'remove' confirmation dialog In-Reply-To: <559748560.6785202.1382362136276.JavaMail.root@redhat.com> References: <2017494005.4318252.1382016007331.JavaMail.root@redhat.com> <208849508.4323041.1382016296885.JavaMail.root@redhat.com> <1068645666.3658547.1382090762309.JavaMail.root@redhat.com> <1674204003.5589198.1382349305006.JavaMail.root@redhat.com> <609509319.4366970.1382357542000.JavaMail.root@redhat.com> <854385228.5674605.1382360236956.JavaMail.root@redhat.com> <559748560.6785202.1382362136276.JavaMail.root@redhat.com> Message-ID: <1557875489.5720218.1382362744550.JavaMail.root@redhat.com> ----- Original Message ----- > From: "Einav Cohen" > To: "Vojtech Szocs" > Cc: "Daniel Erez" , "engine-devel" > Sent: Monday, October 21, 2013 3:28:56 PM > Subject: Re: [Engine-devel] ui code: possible problem in 'remove' confirmation dialog > > > For me, the question is if we want to give models the ability to specify > > full > > remove confirm msg (i.e. "Are you sure...") or just the item part of it > > (i.e. "Virtual Machine(s)"). > > > > >From localization perspective, full remove confirm msg seems more flexible > > >but will add more msg keys, however as you wrote we'd need some more > > >changes in UiCommon models anyway. > > we *must* be able to specify full remove confirm msg only - we should not use > message "particles", as they cause translation-hell (sigular vs. plural, > etc.) - > we had multiple problems with that in the past - that's why we changed the > message > here from "are you sure ... ?" to the more generic "are you sure > ... > items?" [http://gerrit.ovirt.org/#/c/14621] Thanks Einav, now it's clear to me. I think we can go with Daniel's suggestion, in general we need to inspect/update all setMessage calls on ConfirmationModel instances. > > thanks. > > > ----- Original Message ----- > > From: "Vojtech Szocs" > > Sent: Monday, October 21, 2013 8:57:16 AM > > > > > > ----- Original Message ----- > > > From: "Daniel Erez" > > > To: "Vojtech Szocs" > > > Cc: "Einav Cohen" , "Gilad Chaplik" > > > , "Tomas Jelinek" , > > > "Lior Vernia" , "engine-devel" > > > > > > Sent: Monday, October 21, 2013 2:12:22 PM > > > Subject: Re: ui code: possible problem in 'remove' confirmation dialog > > > > > > > > > > > > ----- Original Message ----- > > > > From: "Vojtech Szocs" > > > > To: "Daniel Erez" > > > > Cc: "Einav Cohen" , "Gilad Chaplik" > > > > , "Tomas Jelinek" , > > > > "Lior Vernia" , "engine-devel" > > > > > > > > Sent: Monday, October 21, 2013 12:55:05 PM > > > > Subject: Re: ui code: possible problem in 'remove' confirmation dialog > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > From: "Daniel Erez" > > > > > To: "Einav Cohen" > > > > > Cc: "Gilad Chaplik" , "Tomas Jelinek" > > > > > , "Vojtech Szocs" > > > > > , "Lior Vernia" , > > > > > "engine-devel" > > > > > > > > > > Sent: Friday, October 18, 2013 12:06:02 PM > > > > > Subject: Re: ui code: possible problem in 'remove' confirmation > > > > > dialog > > > > > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > > From: "Einav Cohen" > > > > > > To: "Daniel Erez" , "Gilad Chaplik" > > > > > > , "Tomas Jelinek" , > > > > > > "Vojtech Szocs" , "Lior Vernia" > > > > > > > > > > > > Cc: "engine-devel" > > > > > > Sent: Thursday, October 17, 2013 4:24:56 PM > > > > > > Subject: Re: ui code: possible problem in 'remove' confirmation > > > > > > dialog > > > > > > > > > > > > [apologies - previous e-mail sent prematurely by mistake] > > > > > > > > > > > > Hi, > > > > > > > > > > > > Looking at the current code: It seems that we cannot set the > > > > > > message > > > > > > within > > > > > > a > > > > > > 'remove' confirmation dialog if its HashName starts with "remove_" > > > > > > - > > > > > > it > > > > > > is > > > > > > being set "statically" to the "Are you sure you want to remove the > > > > > > following > > > > > > items?" [constants.removeConfirmationPopupMessage] message [1] > > > > > > > > > > > > I don't have a major problem with relying on the HashName for > > > > > > setting > > > > > > a > > > > > > *default* message [2] - but I think that not allowing to override > > > > > > this > > > > > > message if the developer chooses to do so is an incorrect behavior. > > > > > > > > > > > > I would like to change the behavior so that the user would be able > > > > > > to > > > > > > override the message displayed in that dialog, even if its > > > > > > hash-name > > > > > > is > > > > > > set to 'remove_'. > > > > > > > > > > > > thoughts? objections? > > > > > > > > > > > > ---- > > > > > > Thanks, > > > > > > Einav > > > > > > > > > > > > > > > > > > [1] From RemoveConfirmationPopupView.java, line 86: > > > > > > > > > > > > public void setMessage(String message) { > > > > > > if (getHashName() != null && > > > > > > getHashName().startsWith("remove_")) > > > > > > { > > > > > > //$NON-NLS-1$ > > > > > > super.setMessage(constants.removeConfirmationPopupMessage()); > > > > > > } else { > > > > > > super.setMessage(message); > > > > > > } > > > > > > } > > > > > > > > > > Not sure why we prevent override in this case, > > > > > > > > IIRC the current RemoveConfirmationPopupView.setMessage implementation > > > > reflects the assumption that all remove confirm dialogs > > > > [hashName=remove_*] > > > > have the same message, i.e. "Are you sure you want to remove the > > > > following > > > > items?". > > > > > > > > However, looking at VmListModel#remove (VM main tab / Remove button) it > > > > first > > > > sets [hashName=remove_virtual_machine] and then sets message like > > > > "Virtual > > > > Machine(s)". In practice, RemoveConfirmationPopupView.setMessage will > > > > still > > > > make the dialog message generic, i.e. "Are you sure ... following > > > > items?". > > > > > > > > > I guess it should probably be as simple as: > > > > > > > > > > public void setMessage(String message) { > > > > > super.setMessage(message != null ? message : > > > > > constants.removeConfirmationPopupMessage()); > > > > > } > > > > > > > > For that, we'd have to analyze and modify existing UiCommon models to > > > > call > > > > setMessage with appropriate value, i.e. VmListModel#remove currently > > > > yields > > > > RemoveConfirmationPopupView.setMessage("Virtual Machine(s)") > > > > > > Isn't it a cleanup that should be done either way? > > > (I assume this message isn't currently used on any context...). > > > > Yes, I guess some sort of cleanup will be required anyway. > > > > For me, the question is if we want to give models the ability to specify > > full > > remove confirm msg (i.e. "Are you sure...") or just the item part of it > > (i.e. "Virtual Machine(s)"). > > > > >From localization perspective, full remove confirm msg seems more flexible > > >but will add more msg keys, however as you wrote we'd need some more > > >changes in UiCommon models anyway. > > > > > But indeed, it will require making sure that no one is > > > currently overriding the setMessage() by mistake to > > > avoid such possible regressions. > > > > > > > > > > > > > > > > > Just need to make sure that no one is currently overriding > > > > > it by mistake to avoid possible regressions. > > > > > > > > I think the general pattern used in UiCommon models when dealing with > > > > remove > > > > confirm dialogs is following: > > > > - set wnd hashName to "remove_" i.e. "remove_virtual_machine" > > > > - set wnd message to "" i.e. "Virtual Machine(s)" > > > > > > > > Alternative to Daniel's suggestion, following above mentioned pattern: > > > > > > > > if (message != null) { > > > > // expecting message to be "" > > > > // should yield "Are you sure you want to remove > > > item(s)>?" > > > > super.setMessage(messages.removeConfirmationPopupMessage(message)); > > > > } else { > > > > super.setMessage(message); > > > > } > > > > > > What about default value (when message is null)? > > > > The setMessage code I've mentioned above was based on assumption that > > UiCommon models such as VmListModel will always follow convention like > > removeConfirmDialogModel.setMessage("item(s)") .. but maybe such assumption > > is too strong. > > > > In general, you're right, there should be some default value handling > > included (I forgot about this, sorry). > > > > > Do you mean we should add another abstract class in > > > the hierarchy that would default it to > > > "Are you sure you want to remove the following items?". > > > [btw, we might have some localization issues with this > > > pattern as we've encountered with 'no items to display'; > > > so just need to check it out]. > > > > OK, in that case we can follow Daniel's suggestion (setMessage code that > > just > > delegates to super.setMessage unless message == null for which there'd be > > some default msg), along with updating relevant UiCommon models (i.e. > > strings used when calling setMessage). > > > > > > > > > > > > > > > > > > > > > > > > > > [2] in fact, I don't mind that this would be the default message > > > > > > for > > > > > > this dialog, even if its hash-name is not set to something that > > > > > > starts > > > > > > with 'remove_'. > > > > > > > > > > > > ----- Original Message ----- > > > > > > > From: "Einav Cohen" > > > > > > > To: "Daniel Erez" , "Gilad Chaplik" > > > > > > > , "Tomas Jelinek" , > > > > > > > "Vojtech Szocs" , "Lior Vernia" > > > > > > > > > > > > > > Cc: "engine-devel" > > > > > > > Sent: Thursday, October 17, 2013 9:20:07 AM > > > > > > > Subject: ui code: possible problem in 'remove' confirmation > > > > > > > dialog > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > Looking at the current code: It seems that we cannot set the > > > > > > > message > > > > > > > within > > > > > > > a > > > > > > > 'remove' confirmation > > > > > > > dialog if its HashName starts with "remove_" - it is being set > > > > > > > "statically[1] > > > > > > > I don't have a major problem with relying on the HashName for > > > > > > > setting > > > > > > > a > > > > > > > *default* message (in fact, > > > > > > > I don't have a problem > > > > > > > > > > > > > > [1] From RemoveConfirmationPopupView.java, line 86: > > > > > > > > > > > > > > public void setMessage(String message) { > > > > > > > if (getHashName() != null && > > > > > > > getHashName().startsWith("remove_")) > > > > > > > { > > > > > > > //$NON-NLS-1$ > > > > > > > super.setMessage(constants.removeConfirmationPopupMessage()); > > > > > > > } else { > > > > > > > super.setMessage(message); > > > > > > > } > > > > > > > } > > > > > > > > > > > > > > ---- > > > > > > > Regards, > > > > > > > Einav Cohen Baum > > > > > > > RHEV-M Engineering - UX Team Manager > > > > > > > Red Hat, Inc. > > > > > > > 314 Littleton Road > > > > > > > Westford, MA 01886 > > > > > > > T [internal]: (81) 31046 > > > > > > > T [external]: (+1) 978 589 1046 > > > > > > > IRC: ecohen @ > > > > > > > - RHAT [internal]: #rhev-dev #boston #westford #tlv > > > > > > > - OFTC [external]: #ovirt > > > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > Engine-devel mailing list > > Engine-devel at ovirt.org > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > From vszocs at redhat.com Mon Oct 21 13:55:01 2013 From: vszocs at redhat.com (Vojtech Szocs) Date: Mon, 21 Oct 2013 09:55:01 -0400 (EDT) Subject: [Engine-devel] Question about Engine user session timeout In-Reply-To: <1548855591.5720853.1382362794485.JavaMail.root@redhat.com> Message-ID: <798767402.5733756.1382363701499.JavaMail.root@redhat.com> Hi guys, I see two different config values for dealing with Engine user session timeout. First, from packaging/etc/engine-config/engine-config.properties file: - UserSessionTimeOutInterval.description=Session timeout interval in minutes, after which it will be expired and clean. A negative value indicates the session should never timeout. - UserSessionTimeOutInvalidationInterval.description=Session timeout invalidation interval in minutes. Specifies the interval in which the invalidation check should occur. Then, in org.ovirt.engine.core.common.config.ConfigValues enum: - UserSessionTimeOutInterval (default 30) - UserSessionTimeOutInvalidationInterval (default 30) Looking at Backend#Initialize, both of these values are used when scheduling "cleanExpiredUsersSessions" job: - UserSessionTimeOutInterval = initialDelay param, i.e. the initial delay before the first activation [SchedulerUtil#scheduleAFixedDelayJob] - UserSessionTimeOutInvalidationInterval = taskDelay param, i.e. the delay between jobs [SchedulerUtil#scheduleAFixedDelayJob] So if I read this correctly, if UserSessionTimeOutInterval=100 then UserSessionTimeOutInvalidationInterval is relevant only after first 100min of Engine uptime. Why do we have two different config values for Engine user session timeout? i.e. why don't we use same value for both initialDelay & taskDelay param? Thanks, Vojtech From ecohen at redhat.com Mon Oct 21 15:03:08 2013 From: ecohen at redhat.com (Einav Cohen) Date: Mon, 21 Oct 2013 11:03:08 -0400 (EDT) Subject: [Engine-devel] ui code: possible problem in 'remove' confirmation dialog In-Reply-To: <1557875489.5720218.1382362744550.JavaMail.root@redhat.com> References: <2017494005.4318252.1382016007331.JavaMail.root@redhat.com> <208849508.4323041.1382016296885.JavaMail.root@redhat.com> <1068645666.3658547.1382090762309.JavaMail.root@redhat.com> <1674204003.5589198.1382349305006.JavaMail.root@redhat.com> <609509319.4366970.1382357542000.JavaMail.root@redhat.com> <854385228.5674605.1382360236956.JavaMail.root@redhat.com> <559748560.6785202.1382362136276.JavaMail.root@redhat.com> <1557875489.5720218.1382362744550.JavaMail.root@redhat.com> Message-ID: <31710772.6919312.1382367788199.JavaMail.root@redhat.com> [top posting] opened a bugzilla in order to track this issue: Bug 1021584 - message in the 'remove' confirmation dialog cannot be overridden in some cases [https://bugzilla.redhat.com/show_bug.cgi?id=1021584] many thanks, everyone, for your input - I highly appreciate it! ---- Regards, Einav ----- Original Message ----- > From: "Vojtech Szocs" > To: "Einav Cohen" > Cc: "engine-devel" > Sent: Monday, October 21, 2013 9:39:04 AM > Subject: Re: [Engine-devel] ui code: possible problem in 'remove' confirmation dialog > > > ----- Original Message ----- > > From: "Einav Cohen" > > To: "Vojtech Szocs" > > Cc: "Daniel Erez" , "engine-devel" > > > > Sent: Monday, October 21, 2013 3:28:56 PM > > Subject: Re: [Engine-devel] ui code: possible problem in 'remove' > > confirmation dialog > > > > > For me, the question is if we want to give models the ability to specify > > > full > > > remove confirm msg (i.e. "Are you sure...") or just the item part of it > > > (i.e. "Virtual Machine(s)"). > > > > > > >From localization perspective, full remove confirm msg seems more > > > >flexible > > > >but will add more msg keys, however as you wrote we'd need some more > > > >changes in UiCommon models anyway. > > > > we *must* be able to specify full remove confirm msg only - we should not > > use > > message "particles", as they cause translation-hell (sigular vs. plural, > > etc.) - > > we had multiple problems with that in the past - that's why we changed the > > message > > here from "are you sure ... ?" to the more generic "are you > > sure > > ... > > items?" [http://gerrit.ovirt.org/#/c/14621] > > Thanks Einav, now it's clear to me. I think we can go with Daniel's > suggestion, in general we need to inspect/update all setMessage calls on > ConfirmationModel instances. > > > > > thanks. > > > > > ----- Original Message ----- > > > From: "Vojtech Szocs" > > > Sent: Monday, October 21, 2013 8:57:16 AM > > > > > > > > > ----- Original Message ----- > > > > From: "Daniel Erez" > > > > To: "Vojtech Szocs" > > > > Cc: "Einav Cohen" , "Gilad Chaplik" > > > > , "Tomas Jelinek" , > > > > "Lior Vernia" , "engine-devel" > > > > > > > > Sent: Monday, October 21, 2013 2:12:22 PM > > > > Subject: Re: ui code: possible problem in 'remove' confirmation dialog > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > From: "Vojtech Szocs" > > > > > To: "Daniel Erez" > > > > > Cc: "Einav Cohen" , "Gilad Chaplik" > > > > > , "Tomas Jelinek" , > > > > > "Lior Vernia" , "engine-devel" > > > > > > > > > > Sent: Monday, October 21, 2013 12:55:05 PM > > > > > Subject: Re: ui code: possible problem in 'remove' confirmation > > > > > dialog > > > > > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > > From: "Daniel Erez" > > > > > > To: "Einav Cohen" > > > > > > Cc: "Gilad Chaplik" , "Tomas Jelinek" > > > > > > , "Vojtech Szocs" > > > > > > , "Lior Vernia" , > > > > > > "engine-devel" > > > > > > > > > > > > Sent: Friday, October 18, 2013 12:06:02 PM > > > > > > Subject: Re: ui code: possible problem in 'remove' confirmation > > > > > > dialog > > > > > > > > > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > > > From: "Einav Cohen" > > > > > > > To: "Daniel Erez" , "Gilad Chaplik" > > > > > > > , "Tomas Jelinek" , > > > > > > > "Vojtech Szocs" , "Lior Vernia" > > > > > > > > > > > > > > Cc: "engine-devel" > > > > > > > Sent: Thursday, October 17, 2013 4:24:56 PM > > > > > > > Subject: Re: ui code: possible problem in 'remove' confirmation > > > > > > > dialog > > > > > > > > > > > > > > [apologies - previous e-mail sent prematurely by mistake] > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > Looking at the current code: It seems that we cannot set the > > > > > > > message > > > > > > > within > > > > > > > a > > > > > > > 'remove' confirmation dialog if its HashName starts with > > > > > > > "remove_" > > > > > > > - > > > > > > > it > > > > > > > is > > > > > > > being set "statically" to the "Are you sure you want to remove > > > > > > > the > > > > > > > following > > > > > > > items?" [constants.removeConfirmationPopupMessage] message [1] > > > > > > > > > > > > > > I don't have a major problem with relying on the HashName for > > > > > > > setting > > > > > > > a > > > > > > > *default* message [2] - but I think that not allowing to override > > > > > > > this > > > > > > > message if the developer chooses to do so is an incorrect > > > > > > > behavior. > > > > > > > > > > > > > > I would like to change the behavior so that the user would be > > > > > > > able > > > > > > > to > > > > > > > override the message displayed in that dialog, even if its > > > > > > > hash-name > > > > > > > is > > > > > > > set to 'remove_'. > > > > > > > > > > > > > > thoughts? objections? > > > > > > > > > > > > > > ---- > > > > > > > Thanks, > > > > > > > Einav > > > > > > > > > > > > > > > > > > > > > [1] From RemoveConfirmationPopupView.java, line 86: > > > > > > > > > > > > > > public void setMessage(String message) { > > > > > > > if (getHashName() != null && > > > > > > > getHashName().startsWith("remove_")) > > > > > > > { > > > > > > > //$NON-NLS-1$ > > > > > > > super.setMessage(constants.removeConfirmationPopupMessage()); > > > > > > > } else { > > > > > > > super.setMessage(message); > > > > > > > } > > > > > > > } > > > > > > > > > > > > Not sure why we prevent override in this case, > > > > > > > > > > IIRC the current RemoveConfirmationPopupView.setMessage > > > > > implementation > > > > > reflects the assumption that all remove confirm dialogs > > > > > [hashName=remove_*] > > > > > have the same message, i.e. "Are you sure you want to remove the > > > > > following > > > > > items?". > > > > > > > > > > However, looking at VmListModel#remove (VM main tab / Remove button) > > > > > it > > > > > first > > > > > sets [hashName=remove_virtual_machine] and then sets message like > > > > > "Virtual > > > > > Machine(s)". In practice, RemoveConfirmationPopupView.setMessage will > > > > > still > > > > > make the dialog message generic, i.e. "Are you sure ... following > > > > > items?". > > > > > > > > > > > I guess it should probably be as simple as: > > > > > > > > > > > > public void setMessage(String message) { > > > > > > super.setMessage(message != null ? message : > > > > > > constants.removeConfirmationPopupMessage()); > > > > > > } > > > > > > > > > > For that, we'd have to analyze and modify existing UiCommon models to > > > > > call > > > > > setMessage with appropriate value, i.e. VmListModel#remove currently > > > > > yields > > > > > RemoveConfirmationPopupView.setMessage("Virtual Machine(s)") > > > > > > > > Isn't it a cleanup that should be done either way? > > > > (I assume this message isn't currently used on any context...). > > > > > > Yes, I guess some sort of cleanup will be required anyway. > > > > > > For me, the question is if we want to give models the ability to specify > > > full > > > remove confirm msg (i.e. "Are you sure...") or just the item part of it > > > (i.e. "Virtual Machine(s)"). > > > > > > >From localization perspective, full remove confirm msg seems more > > > >flexible > > > >but will add more msg keys, however as you wrote we'd need some more > > > >changes in UiCommon models anyway. > > > > > > > But indeed, it will require making sure that no one is > > > > currently overriding the setMessage() by mistake to > > > > avoid such possible regressions. > > > > > > > > > > > > > > > > > > > > > Just need to make sure that no one is currently overriding > > > > > > it by mistake to avoid possible regressions. > > > > > > > > > > I think the general pattern used in UiCommon models when dealing with > > > > > remove > > > > > confirm dialogs is following: > > > > > - set wnd hashName to "remove_" i.e. "remove_virtual_machine" > > > > > - set wnd message to "" i.e. "Virtual Machine(s)" > > > > > > > > > > Alternative to Daniel's suggestion, following above mentioned > > > > > pattern: > > > > > > > > > > if (message != null) { > > > > > // expecting message to be "" > > > > > // should yield "Are you sure you want to remove > > > > item(s)>?" > > > > > super.setMessage(messages.removeConfirmationPopupMessage(message)); > > > > > } else { > > > > > super.setMessage(message); > > > > > } > > > > > > > > What about default value (when message is null)? > > > > > > The setMessage code I've mentioned above was based on assumption that > > > UiCommon models such as VmListModel will always follow convention like > > > removeConfirmDialogModel.setMessage("item(s)") .. but maybe such > > > assumption > > > is too strong. > > > > > > In general, you're right, there should be some default value handling > > > included (I forgot about this, sorry). > > > > > > > Do you mean we should add another abstract class in > > > > the hierarchy that would default it to > > > > "Are you sure you want to remove the following items?". > > > > [btw, we might have some localization issues with this > > > > pattern as we've encountered with 'no items to display'; > > > > so just need to check it out]. > > > > > > OK, in that case we can follow Daniel's suggestion (setMessage code that > > > just > > > delegates to super.setMessage unless message == null for which there'd be > > > some default msg), along with updating relevant UiCommon models (i.e. > > > strings used when calling setMessage). > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > [2] in fact, I don't mind that this would be the default message > > > > > > > for > > > > > > > this dialog, even if its hash-name is not set to something that > > > > > > > starts > > > > > > > with 'remove_'. > > > > > > > > > > > > > > ----- Original Message ----- > > > > > > > > From: "Einav Cohen" > > > > > > > > To: "Daniel Erez" , "Gilad Chaplik" > > > > > > > > , "Tomas Jelinek" , > > > > > > > > "Vojtech Szocs" , "Lior Vernia" > > > > > > > > > > > > > > > > Cc: "engine-devel" > > > > > > > > Sent: Thursday, October 17, 2013 9:20:07 AM > > > > > > > > Subject: ui code: possible problem in 'remove' confirmation > > > > > > > > dialog > > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > Looking at the current code: It seems that we cannot set the > > > > > > > > message > > > > > > > > within > > > > > > > > a > > > > > > > > 'remove' confirmation > > > > > > > > dialog if its HashName starts with "remove_" - it is being set > > > > > > > > "statically[1] > > > > > > > > I don't have a major problem with relying on the HashName for > > > > > > > > setting > > > > > > > > a > > > > > > > > *default* message (in fact, > > > > > > > > I don't have a problem > > > > > > > > > > > > > > > > [1] From RemoveConfirmationPopupView.java, line 86: > > > > > > > > > > > > > > > > public void setMessage(String message) { > > > > > > > > if (getHashName() != null && > > > > > > > > getHashName().startsWith("remove_")) > > > > > > > > { > > > > > > > > //$NON-NLS-1$ > > > > > > > > super.setMessage(constants.removeConfirmationPopupMessage()); > > > > > > > > } else { > > > > > > > > super.setMessage(message); > > > > > > > > } > > > > > > > > } > > > > > > > > > > > > > > > > ---- > > > > > > > > Regards, > > > > > > > > Einav Cohen Baum > > > > > > > > RHEV-M Engineering - UX Team Manager > > > > > > > > Red Hat, Inc. > > > > > > > > 314 Littleton Road > > > > > > > > Westford, MA 01886 > > > > > > > > T [internal]: (81) 31046 > > > > > > > > T [external]: (+1) 978 589 1046 > > > > > > > > IRC: ecohen @ > > > > > > > > - RHAT [internal]: #rhev-dev #boston #westford #tlv > > > > > > > > - OFTC [external]: #ovirt > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > Engine-devel mailing list > > > Engine-devel at ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > > > > > > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > From iheim at redhat.com Tue Oct 22 06:18:56 2013 From: iheim at redhat.com (Itamar Heim) Date: Tue, 22 Oct 2013 07:18:56 +0100 Subject: [Engine-devel] Question about Engine user session timeout In-Reply-To: <798767402.5733756.1382363701499.JavaMail.root@redhat.com> References: <798767402.5733756.1382363701499.JavaMail.root@redhat.com> Message-ID: <526618D0.9060700@redhat.com> On 10/21/2013 02:55 PM, Vojtech Szocs wrote: > Hi guys, > > I see two different config values for dealing with Engine user session timeout. > > First, from packaging/etc/engine-config/engine-config.properties file: > - UserSessionTimeOutInterval.description=Session timeout interval in minutes, after which it will be expired and clean. A negative value indicates the session should never timeout. > - UserSessionTimeOutInvalidationInterval.description=Session timeout invalidation interval in minutes. Specifies the interval in which the invalidation check should occur. > > Then, in org.ovirt.engine.core.common.config.ConfigValues enum: > - UserSessionTimeOutInterval (default 30) > - UserSessionTimeOutInvalidationInterval (default 30) > > Looking at Backend#Initialize, both of these values are used when scheduling "cleanExpiredUsersSessions" job: > - UserSessionTimeOutInterval = initialDelay param, i.e. the initial delay before the first activation [SchedulerUtil#scheduleAFixedDelayJob] > - UserSessionTimeOutInvalidationInterval = taskDelay param, i.e. the delay between jobs [SchedulerUtil#scheduleAFixedDelayJob] > > So if I read this correctly, if UserSessionTimeOutInterval=100 then UserSessionTimeOutInvalidationInterval is relevant only after first 100min of Engine uptime. > > Why do we have two different config values for Engine user session timeout? i.e. why don't we use same value for both initialDelay & taskDelay param? > you may want to be more strict, and invalidate sessions after 30 minutes and check for that every minute? From oschreib at redhat.com Tue Oct 22 09:01:39 2013 From: oschreib at redhat.com (Ofer Schreiber) Date: Tue, 22 Oct 2013 05:01:39 -0400 (EDT) Subject: [Engine-devel] New branch created - ovirt-engine-3.3.1 In-Reply-To: <2050269085.4962295.1382431435435.JavaMail.root@redhat.com> Message-ID: <863863306.4969174.1382432499919.JavaMail.root@redhat.com> Hey, A new branch has been created: ovirt-engine-3.3.1 (based on based on ovirt-engine-3.3 [8af79fdab50ed9c3fabab92a156845f6f0937fce - core:Upgrade script missing field in vm_template]). If you encounter a severe release blocker, please make sure that: 1. The patch proposed for BOTH ovirt-engine-3.3 and ovirt-engine-3.3.1 2. The patch has both VERIFIED and +2 CR. 3. Relevant bug blocks the ovirt-engine-3.3.1 release tracker (https://bugzilla.redhat.com/show_bug.cgi?id=1019391) Once done, the branch maintainer will merge your patch. Thanks, Ofer Schreiber From vszocs at redhat.com Tue Oct 22 09:12:49 2013 From: vszocs at redhat.com (Vojtech Szocs) Date: Tue, 22 Oct 2013 05:12:49 -0400 (EDT) Subject: [Engine-devel] Question about Engine user session timeout In-Reply-To: <526618D0.9060700@redhat.com> References: <798767402.5733756.1382363701499.JavaMail.root@redhat.com> <526618D0.9060700@redhat.com> Message-ID: <1591715216.6236208.1382433169405.JavaMail.root@redhat.com> ----- Original Message ----- > From: "Itamar Heim" > To: "Vojtech Szocs" > Cc: "engine-devel" > Sent: Tuesday, October 22, 2013 8:18:56 AM > Subject: Re: [Engine-devel] Question about Engine user session timeout > > On 10/21/2013 02:55 PM, Vojtech Szocs wrote: > > Hi guys, > > > > I see two different config values for dealing with Engine user session > > timeout. > > > > First, from packaging/etc/engine-config/engine-config.properties file: > > - UserSessionTimeOutInterval.description=Session timeout interval in > > minutes, after which it will be expired and clean. A negative value > > indicates the session should never timeout. > > - UserSessionTimeOutInvalidationInterval.description=Session timeout > > invalidation interval in minutes. Specifies the interval in which the > > invalidation check should occur. > > > > Then, in org.ovirt.engine.core.common.config.ConfigValues enum: > > - UserSessionTimeOutInterval (default 30) > > - UserSessionTimeOutInvalidationInterval (default 30) > > > > Looking at Backend#Initialize, both of these values are used when > > scheduling "cleanExpiredUsersSessions" job: > > - UserSessionTimeOutInterval = initialDelay param, i.e. the initial delay > > before the first activation [SchedulerUtil#scheduleAFixedDelayJob] > > - UserSessionTimeOutInvalidationInterval = taskDelay param, i.e. the delay > > between jobs [SchedulerUtil#scheduleAFixedDelayJob] > > > > So if I read this correctly, if UserSessionTimeOutInterval=100 then > > UserSessionTimeOutInvalidationInterval is relevant only after first 100min > > of Engine uptime. > > > > Why do we have two different config values for Engine user session timeout? > > i.e. why don't we use same value for both initialDelay & taskDelay param? > > > > you may want to be more strict, and invalidate sessions after 30 minutes > and check for that every minute? Well, my motivation was to understand both config values before I'll attempt to use them in server-side Engine code. I'm working on client-side-only improvement of UI Plugin vs. REST API integration [proper server-side RFE is here https://bugzilla.redhat.com/1019921], dealing with a situation when "REST API timeout > Engine session timeout" and its consequences; I'd like UI to create REST API session with timeout equal to Engine session timeout. However, as we have two distinct values for Engine session timeout, I guess my best shot is to do "min(UserSessionTimeOutInterval,UserSessionTimeOutInvalidationInterval)" and expose both via admin-only GetConfigurationValue query, but I'm not sure this is the best approach.. > > From iheim at redhat.com Tue Oct 22 10:22:14 2013 From: iheim at redhat.com (Itamar Heim) Date: Tue, 22 Oct 2013 11:22:14 +0100 Subject: [Engine-devel] Question about Engine user session timeout In-Reply-To: <1591715216.6236208.1382433169405.JavaMail.root@redhat.com> References: <798767402.5733756.1382363701499.JavaMail.root@redhat.com> <526618D0.9060700@redhat.com> <1591715216.6236208.1382433169405.JavaMail.root@redhat.com> Message-ID: <526651D6.2020900@redhat.com> On 10/22/2013 10:12 AM, Vojtech Szocs wrote: > However, as we have two distinct values for Engine session timeout, I guess my best shot is to do "min(UserSessionTimeOutInterval,UserSessionTimeOutInvalidationInterval)" and expose both via admin-only GetConfigurationValue query, but I'm not sure this is the best approach.. shouldn't that be sum() rather than min? From vszocs at redhat.com Tue Oct 22 11:44:31 2013 From: vszocs at redhat.com (Vojtech Szocs) Date: Tue, 22 Oct 2013 07:44:31 -0400 (EDT) Subject: [Engine-devel] Question about Engine user session timeout In-Reply-To: <526651D6.2020900@redhat.com> References: <798767402.5733756.1382363701499.JavaMail.root@redhat.com> <526618D0.9060700@redhat.com> <1591715216.6236208.1382433169405.JavaMail.root@redhat.com> <526651D6.2020900@redhat.com> Message-ID: <547034966.6308959.1382442271276.JavaMail.root@redhat.com> ----- Original Message ----- > From: "Itamar Heim" > To: "Vojtech Szocs" > Cc: "engine-devel" > Sent: Tuesday, October 22, 2013 12:22:14 PM > Subject: Re: [Engine-devel] Question about Engine user session timeout > > On 10/22/2013 10:12 AM, Vojtech Szocs wrote: > > However, as we have two distinct values for Engine session timeout, I guess > > my best shot is to do > > "min(UserSessionTimeOutInterval,UserSessionTimeOutInvalidationInterval)" > > and expose both via admin-only GetConfigurationValue query, but I'm not > > sure this is the best approach.. > > shouldn't that be sum() rather than min? IIUC, the first config value (UserSessionTimeOutInterval) represents the delay between Engine startup and first "cleanExpiredUsersSessions" job execution. The second config value (UserSessionTimeOutInvalidationInterval) is the delay between subsequent executions of this job. This is why I thought it should be min() out of these two; user could open WebAdmin right after Engine startup or anytime after that. Both config values have validValues=-1,1..100000 so -1 could disable first (UserSessionTimeOutInterval) or subsequent (UserSessionTimeOutInvalidationInterval) job execution. I'm still confused why we have two values, though.. > From iheim at redhat.com Tue Oct 22 20:55:00 2013 From: iheim at redhat.com (Itamar Heim) Date: Tue, 22 Oct 2013 21:55:00 +0100 Subject: [Engine-devel] CfP: Virtualisation and IaaS DevRoom at FOSDEM'14 Message-ID: <5266E624.3050506@redhat.com> https://groups.google.com/forum/#!forum/fosdem14-virt-and-iaas-devroom Call for Participation The scope for this devroom is open source, openly-developed projects in the areas of virtualisation and IaaS type clouds, ranging from low level to data center, up to cloud management platforms and cloud resource orchestration. Sessions should always target a developer audience. Bonus points for collaborative sessions that would be appealing to developers from multiple projects. We are particularly interested in the following themes: - low level virtualisation aspects - new features in classic and container-based virtualisation technologies - new use cases for virtualisation, such as virtualisation in mobile, automotive and embedded in general - other resource virtualisation technologies: networking, storage, ? - deep technical dives into specific IaaS or virtualisation management projects features - relationship between IaaS projects and specific dependencies (not just virtualisation) - integration and development leveraging solutions from multiple projects Important dates Submission deadline: Sunday, December 1st, 2013 Acceptance notifications: Sunday, December 15th, 2013 Final schedule announcement: Friday January 10th, 2014 Devroom @ FOSDEM'14: February 1st & 2nd, 2014 Practical Submissions should be 40 minutes, and consist of a 30 minute presentation with 10 minutes of Q&A or 40 minutes of discussions (e.g., requests for feedback, open discussions, etc.). Interactivity is encouraged, but optional. Talks are in English only. We do not provide travel assistance or reimbursement of travel expenses for accepted speakers. Submissions should be made via the FOSDEM submission page at https://penta.fosdem.org/submission/FOSDEM14 : - If necessary, create a Pentabarf account and activate it - In the ?Person? section, provide First name, Last name (in the ?General? tab), Email (in the ?Contact? tab) and Bio (?Abstract? field in the ?Description? tab) - Submit a proposal by clicking on ?Create event" - Important! Select the "Virtualisation and IaaS" track (on the ?General? tab) - Provide the title of your talk (?Event title? in the ?General? tab) - Provide a 250-word description of the subject of the talk and the intended audience (in the ?Abstract? field of the ?Description? tab) - Provide a rough outline of the talk or goals of the session (a short list of bullet points covering topics that will be discussed) in the ?Full description? field in the ?Description? tab Contact For questions w.r.t. the Virtualisation and IaaS DevRoom at FOSDEM'14, please contact the organizers via fosdem14-virt-and-iaas-devroom at googlegroups.com (or via https://groups.google.com/forum/#!forum/fosdem14-virt-and-iaas-devroom). From emesika at redhat.com Thu Oct 24 15:49:21 2013 From: emesika at redhat.com (Eli Mesika) Date: Thu, 24 Oct 2013 11:49:21 -0400 (EDT) Subject: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch In-Reply-To: <1091762834.13392662.1382629384004.JavaMail.root@redhat.com> Message-ID: <1963655862.13395521.1382629761676.JavaMail.root@redhat.com> Hi Please note that any upgrade script introduced to the master branch should have the 03_04 prefix. If this script is resolving a blocker/exception BZ it should be ported to the ovirt-engine-3.3 branch with a 03_03 prefix !!! We have encountered some patches that broke the upgrade from ovirt-engine-3.3 to master as a result of 1) naming new upgrade scripts in master branch with 03_03 prefix 2) naming new upgrade scripts in ovirt-engine-3.3 stable branch with 03_04 prefix I am available for any question and asking you to add me to any DB related script as a reviewer even if I +2 the master patch and you just back-port it to ovirt-engine-3.3. It may save us a lot of noise. Thanks for your cooperation Eli From bazulay at redhat.com Thu Oct 24 16:13:04 2013 From: bazulay at redhat.com (Barak Azulay) Date: Thu, 24 Oct 2013 12:13:04 -0400 (EDT) Subject: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch In-Reply-To: <1963655862.13395521.1382629761676.JavaMail.root@redhat.com> References: <1963655862.13395521.1382629761676.JavaMail.root@redhat.com> Message-ID: <1674499877.10075467.1382631184300.JavaMail.root@redhat.com> We should add a gerrit hook to enforce the right naming/version of db upgrade scripts. Thanks Barak Azulay ----- Original Message ----- > From: "Eli Mesika" > To: "engine-devel" > Sent: Thursday, October 24, 2013 6:49:21 PM > Subject: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch > > Hi > > Please note that any upgrade script introduced to the master branch should > have the 03_04 prefix. > If this script is resolving a blocker/exception BZ it should be ported to the > ovirt-engine-3.3 branch with a 03_03 prefix !!! > > We have encountered some patches that broke the upgrade from ovirt-engine-3.3 > to master as a result of > > 1) naming new upgrade scripts in master branch with 03_03 prefix > 2) naming new upgrade scripts in ovirt-engine-3.3 stable branch with 03_04 > prefix > > I am available for any question and asking you to add me to any DB related > script as a reviewer even if I +2 the master patch and you just back-port it > to ovirt-engine-3.3. > It may save us a lot of noise. > > Thanks for your cooperation > > Eli > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > From eedri at redhat.com Thu Oct 24 16:20:11 2013 From: eedri at redhat.com (Eyal Edri) Date: Thu, 24 Oct 2013 12:20:11 -0400 (EDT) Subject: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch In-Reply-To: <1674499877.10075467.1382631184300.JavaMail.root@redhat.com> References: <1963655862.13395521.1382629761676.JavaMail.root@redhat.com> <1674499877.10075467.1382631184300.JavaMail.root@redhat.com> Message-ID: <1352440551.13328035.1382631611776.JavaMail.root@redhat.com> there are already in place gerrit jobs for all flows, only this was introduced before they were added: ovirt_engine_3.2_update_db_to_3.3_gerrit ovirt_engine_3.3.0_update_db_to_3.3_gerrit ovirt_engine_3.3.1_update_db_to_3.3_gerrit ovirt_engine_3.3_update_db_to_master_gerrit ovirt_engine_3.3.0_update_db_to_3.3.1_gerrit ovirt_engine_master_update_db_to_master_gerrit ovirt_engine_3.3_update_db_to_3.3_latest_gerrit ----- Original Message ----- > From: "Barak Azulay" > To: "Eli Mesika" > Cc: "engine-devel" , infra at ovirt.org, "Eyal Edri" > Sent: Thursday, October 24, 2013 7:13:04 PM > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch > > We should add a gerrit hook to enforce the right naming/version of db > upgrade scripts. > > > Thanks > Barak Azulay > > ----- Original Message ----- > > From: "Eli Mesika" > > To: "engine-devel" > > Sent: Thursday, October 24, 2013 6:49:21 PM > > Subject: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for > > stable branch > > > > Hi > > > > Please note that any upgrade script introduced to the master branch should > > have the 03_04 prefix. > > If this script is resolving a blocker/exception BZ it should be ported to > > the > > ovirt-engine-3.3 branch with a 03_03 prefix !!! > > > > We have encountered some patches that broke the upgrade from > > ovirt-engine-3.3 > > to master as a result of > > > > 1) naming new upgrade scripts in master branch with 03_03 prefix > > 2) naming new upgrade scripts in ovirt-engine-3.3 stable branch with 03_04 > > prefix > > > > I am available for any question and asking you to add me to any DB related > > script as a reviewer even if I +2 the master patch and you just back-port > > it > > to ovirt-engine-3.3. > > It may save us a lot of noise. > > > > Thanks for your cooperation > > > > Eli > > _______________________________________________ > > Engine-devel mailing list > > Engine-devel at ovirt.org > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > From bazulay at redhat.com Thu Oct 24 17:12:27 2013 From: bazulay at redhat.com (Barak Azulay) Date: Thu, 24 Oct 2013 13:12:27 -0400 (EDT) Subject: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch In-Reply-To: <1352440551.13328035.1382631611776.JavaMail.root@redhat.com> References: <1963655862.13395521.1382629761676.JavaMail.root@redhat.com> <1674499877.10075467.1382631184300.JavaMail.root@redhat.com> <1352440551.13328035.1382631611776.JavaMail.root@redhat.com> Message-ID: <1683839335.10116594.1382634747025.JavaMail.root@redhat.com> Even better, When will these hooks be effective on engine master & ovirt-3.3 ? Barak ----- Original Message ----- > From: "Eyal Edri" > To: "Barak Azulay" > Cc: "engine-devel" , infra at ovirt.org > Sent: Thursday, October 24, 2013 7:20:11 PM > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch > > there are already in place gerrit jobs for all flows, only this was > introduced before they were added: > > ovirt_engine_3.2_update_db_to_3.3_gerrit > ovirt_engine_3.3.0_update_db_to_3.3_gerrit > ovirt_engine_3.3.1_update_db_to_3.3_gerrit > ovirt_engine_3.3_update_db_to_master_gerrit > ovirt_engine_3.3.0_update_db_to_3.3.1_gerrit > ovirt_engine_master_update_db_to_master_gerrit > ovirt_engine_3.3_update_db_to_3.3_latest_gerrit > > ----- Original Message ----- > > From: "Barak Azulay" > > To: "Eli Mesika" > > Cc: "engine-devel" , infra at ovirt.org, "Eyal Edri" > > > > Sent: Thursday, October 24, 2013 7:13:04 PM > > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and > > for stable branch > > > > We should add a gerrit hook to enforce the right naming/version of db > > upgrade scripts. > > > > > > Thanks > > Barak Azulay > > > > ----- Original Message ----- > > > From: "Eli Mesika" > > > To: "engine-devel" > > > Sent: Thursday, October 24, 2013 6:49:21 PM > > > Subject: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for > > > stable branch > > > > > > Hi > > > > > > Please note that any upgrade script introduced to the master branch > > > should > > > have the 03_04 prefix. > > > If this script is resolving a blocker/exception BZ it should be ported to > > > the > > > ovirt-engine-3.3 branch with a 03_03 prefix !!! > > > > > > We have encountered some patches that broke the upgrade from > > > ovirt-engine-3.3 > > > to master as a result of > > > > > > 1) naming new upgrade scripts in master branch with 03_03 prefix > > > 2) naming new upgrade scripts in ovirt-engine-3.3 stable branch with > > > 03_04 > > > prefix > > > > > > I am available for any question and asking you to add me to any DB > > > related > > > script as a reviewer even if I +2 the master patch and you just back-port > > > it > > > to ovirt-engine-3.3. > > > It may save us a lot of noise. > > > > > > Thanks for your cooperation > > > > > > Eli > > > _______________________________________________ > > > Engine-devel mailing list > > > Engine-devel at ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > > > > > > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > From eedri at redhat.com Thu Oct 24 17:42:46 2013 From: eedri at redhat.com (Eyal Edri) Date: Thu, 24 Oct 2013 13:42:46 -0400 (EDT) Subject: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch In-Reply-To: <1683839335.10116594.1382634747025.JavaMail.root@redhat.com> References: <1963655862.13395521.1382629761676.JavaMail.root@redhat.com> <1674499877.10075467.1382631184300.JavaMail.root@redhat.com> <1352440551.13328035.1382631611776.JavaMail.root@redhat.com> <1683839335.10116594.1382634747025.JavaMail.root@redhat.com> Message-ID: <1578330426.13390301.1382636566232.JavaMail.root@redhat.com> already active. ----- Original Message ----- > From: "Barak Azulay" > To: "Eyal Edri" > Cc: "engine-devel" , infra at ovirt.org > Sent: Thursday, October 24, 2013 8:12:27 PM > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch > > Even better, > > When will these hooks be effective on engine master & ovirt-3.3 ? > > Barak > > ----- Original Message ----- > > From: "Eyal Edri" > > To: "Barak Azulay" > > Cc: "engine-devel" , infra at ovirt.org > > Sent: Thursday, October 24, 2013 7:20:11 PM > > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and > > for stable branch > > > > there are already in place gerrit jobs for all flows, only this was > > introduced before they were added: > > > > ovirt_engine_3.2_update_db_to_3.3_gerrit > > ovirt_engine_3.3.0_update_db_to_3.3_gerrit > > ovirt_engine_3.3.1_update_db_to_3.3_gerrit > > ovirt_engine_3.3_update_db_to_master_gerrit > > ovirt_engine_3.3.0_update_db_to_3.3.1_gerrit > > ovirt_engine_master_update_db_to_master_gerrit > > ovirt_engine_3.3_update_db_to_3.3_latest_gerrit > > > > ----- Original Message ----- > > > From: "Barak Azulay" > > > To: "Eli Mesika" > > > Cc: "engine-devel" , infra at ovirt.org, "Eyal Edri" > > > > > > Sent: Thursday, October 24, 2013 7:13:04 PM > > > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and > > > for stable branch > > > > > > We should add a gerrit hook to enforce the right naming/version of db > > > upgrade scripts. > > > > > > > > > Thanks > > > Barak Azulay > > > > > > ----- Original Message ----- > > > > From: "Eli Mesika" > > > > To: "engine-devel" > > > > Sent: Thursday, October 24, 2013 6:49:21 PM > > > > Subject: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and > > > > for > > > > stable branch > > > > > > > > Hi > > > > > > > > Please note that any upgrade script introduced to the master branch > > > > should > > > > have the 03_04 prefix. > > > > If this script is resolving a blocker/exception BZ it should be ported > > > > to > > > > the > > > > ovirt-engine-3.3 branch with a 03_03 prefix !!! > > > > > > > > We have encountered some patches that broke the upgrade from > > > > ovirt-engine-3.3 > > > > to master as a result of > > > > > > > > 1) naming new upgrade scripts in master branch with 03_03 prefix > > > > 2) naming new upgrade scripts in ovirt-engine-3.3 stable branch with > > > > 03_04 > > > > prefix > > > > > > > > I am available for any question and asking you to add me to any DB > > > > related > > > > script as a reviewer even if I +2 the master patch and you just > > > > back-port > > > > it > > > > to ovirt-engine-3.3. > > > > It may save us a lot of noise. > > > > > > > > Thanks for your cooperation > > > > > > > > Eli > > > > _______________________________________________ > > > > Engine-devel mailing list > > > > Engine-devel at ovirt.org > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > > > > > > > > > > > _______________________________________________ > > Engine-devel mailing list > > Engine-devel at ovirt.org > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > From bigclouds at 163.com Fri Oct 25 03:03:56 2013 From: bigclouds at 163.com (bigclouds) Date: Fri, 25 Oct 2013 11:03:56 +0800 (CST) Subject: [Engine-devel] fails when build engine source code Message-ID: <2bd7c1e.4aab.141ed917b93.Coremail.bigclouds@163.com> hi,all look at the error. UI Utils Compatibility part fails. [INFO] UI Utils Compatibility (for UICommon) ............. FAILURE [0.385s] [INFO] Frontend for GWT UI Projects ...................... SKIPPED [INFO] UICommonWeb ....................................... SKIPPED [INFO] oVirt GWT UI common infrastructure ................ SKIPPED [INFO] WebAdmin .......................................... SKIPPED [INFO] UserPortal ........................................ SKIPPED [INFO] oVirt Server EAR .................................. SKIPPED [ERROR] Failed to execute goal org.codehaus.mojo:gwt-maven-plugin:2.5.1:compile (default) on project uicompat: GWT Module org.ovirt.engine.core.SearchBackend not found in project sources or resources. -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.codehaus.mojo:gwt-maven-plugin:2.5.1:compile (default) on project uicompat: GWT Module org.ovirt.engine.core.SearchBackend not found in project sources or resources. at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59) at org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161) at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320) at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156) at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537) at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196) at org.apache.maven.cli.MavenCli.main(MavenCli.java:141) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290) at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409) at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352) Caused by: org.apache.maven.plugin.MojoExecutionException: GWT Module org.ovirt.engine.core.SearchBackend not found in project sources or resources. at org.codehaus.mojo.gwt.shell.CompileMojo.compilationRequired(CompileMojo.java:495) at org.codehaus.mojo.gwt.shell.CompileMojo.compile(CompileMojo.java:356) at org.codehaus.mojo.gwt.shell.CompileMojo.doExecute(CompileMojo.java:280) at org.codehaus.mojo.gwt.shell.AbstractGwtShellMojo.execute(AbstractGwtShellMojo.java:172) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209) ... 19 more Caused by: org.codehaus.mojo.gwt.utils.GwtModuleReaderException: GWT Module org.ovirt.engine.core.SearchBackend not found in project sources or resources. at org.codehaus.mojo.gwt.AbstractGwtModuleMojo.readModule(AbstractGwtModuleMojo.java:205) at org.codehaus.mojo.gwt.GwtModule.getLocalInherits(GwtModule.java:189) at org.codehaus.mojo.gwt.GwtModule.getInherits(GwtModule.java:149) at org.codehaus.mojo.gwt.GwtModule.getEntryPoints(GwtModule.java:114) at org.codehaus.mojo.gwt.shell.CompileMojo.compilationRequired(CompileMojo.java:409) ... 24 more [ERROR] [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn -rf :uicompat -------------- next part -------------- An HTML attachment was scrubbed... URL: From tjelinek at redhat.com Fri Oct 25 07:31:21 2013 From: tjelinek at redhat.com (Tomas Jelinek) Date: Fri, 25 Oct 2013 03:31:21 -0400 (EDT) Subject: [Engine-devel] fails when build engine source code In-Reply-To: <2bd7c1e.4aab.141ed917b93.Coremail.bigclouds@163.com> References: <2bd7c1e.4aab.141ed917b93.Coremail.bigclouds@163.com> Message-ID: <319196301.11306667.1382686281222.JavaMail.root@redhat.com> hey, I have tried to build the current master and it works fine. Which exact git commit are you trying to build? BTW for this kinds of errors I could suspect that there is some mess from older builds which causes the problems. If this happens to you also on the current HEAD please try to: delete ~/.m2/repository/org/ovirt/* delete all the targets: cd ; find . -name target -exec rm -rf {} \; Tomas ----- Original Message ----- > From: "bigclouds" > To: "engine-devel" > Sent: Friday, October 25, 2013 5:03:56 AM > Subject: [Engine-devel] fails when build engine source code > > hi,all > look at the error. UI Utils Compatibility part fails. > [INFO] UI Utils Compatibility (for UICommon) ............. FAILURE [0.385s] > [INFO] Frontend for GWT UI Projects ...................... SKIPPED > [INFO] UICommonWeb ....................................... SKIPPED > [INFO] oVirt GWT UI common infrastructure ................ SKIPPED > [INFO] WebAdmin .......................................... SKIPPED > [INFO] UserPortal ........................................ SKIPPED > [INFO] oVirt Server EAR .................................. SKIPPED > [ERROR] Failed to execute goal > org.codehaus.mojo:gwt-maven-plugin:2.5.1:compile (default) on project > uicompat: GWT Module org.ovirt.engine.core.SearchBackend not found in > project sources or resources. -> [Help 1] > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute > goal org.codehaus.mojo:gwt-maven-plugin:2.5.1:compile (default) on project > uicompat: GWT Module org.ovirt.engine.core.SearchBackend not found in > project sources or resources. > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59) > at org.apache.maven.lifecycle.internal.L > ifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320) > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156) > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537) > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196) > at org.apache.maven.cli.MavenCli.main(MavenCli.java:141) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at sun.reflect.DelegatingMethodAccessorImpl > .invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230) > at > org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409) > at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352) > Caused by: org.apache.maven.plugin.MojoExecutionException: GWT Module > org.ovirt.engine.core.SearchBackend not found in project sources or > resources. > at > org.codehaus.mojo.gwt.shell.CompileMojo.compilationRequired(CompileMojo.java:495) > at org.codehaus.mojo.gwt.shell.CompileMojo.compil e(CompileMojo.java:356) > at org.codehaus.mojo.gwt.shell.CompileMojo.doExecute(CompileMojo.java:280) > at > org.codehaus.mojo.gwt.shell.AbstractGwtShellMojo.execute(AbstractGwtShellMojo.java:172) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209) > ... 19 more > Caused by: org.codehaus.mojo.gwt.utils.GwtModuleReaderException: GWT Module > org.ovirt.engine.core.SearchBackend not found in project sources or > resources. > at > org.codehaus.mojo.gwt.AbstractGwtModuleMojo.readModule(AbstractGwtModuleMojo.java:205) > at org.codehaus.mojo.gwt.GwtModule.getLocalInherits(GwtModule.java:189) > at org.codehaus.mojo.gwt.GwtModule.getInherits(GwtModule.java:149) > at org.codehaus.mojo.gwt.GwtModule.getEntryPoints(GwtModule.java:114) > at > org.codehaus.mojo.gwt.shell.CompileMojo.compilationRequired(CompileMojo.java:409) > ... 24 more > [ERROR] > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > [ERROR] > [ERROR] For more information about the errors and possible solutions, please > read the following articles: > [ERROR] [Help 1] > http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException > [ERROR] > [ERROR] After correcting the problems, you can resume the build with the > command > [ERROR] mvn -rf :uicompat > > > > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > From tjelinek at redhat.com Fri Oct 25 07:57:33 2013 From: tjelinek at redhat.com (Tomas Jelinek) Date: Fri, 25 Oct 2013 03:57:33 -0400 (EDT) Subject: [Engine-devel] missing AIO_CONFIG_NOT_AVAILABLE on 3.3 branch In-Reply-To: <1904806623.11547036.1382687625017.JavaMail.root@redhat.com> Message-ID: <1056375491.11584042.1382687853665.JavaMail.root@redhat.com> Hey, I have noticed an error: ***L:ERROR Internal error: type object 'Stages' has no attribute 'AIO_CONFIG_NOT_AVAILABLE' while running engine-setup --jboss-home=... This does not happen on the master, only on ovirt-engine-3.3 - I guess the problem is that the http://gerrit.ovirt.org/#/c/20262 is not backported. I have not seen any pending patch on the 3.3 branch - any reason for that? Thanx, Tomas From alonbl at redhat.com Fri Oct 25 08:00:23 2013 From: alonbl at redhat.com (Alon Bar-Lev) Date: Fri, 25 Oct 2013 04:00:23 -0400 (EDT) Subject: [Engine-devel] missing AIO_CONFIG_NOT_AVAILABLE on 3.3 branch In-Reply-To: <1056375491.11584042.1382687853665.JavaMail.root@redhat.com> References: <1056375491.11584042.1382687853665.JavaMail.root@redhat.com> Message-ID: <530228720.8528958.1382688023151.JavaMail.root@redhat.com> Correct, broken by the same again... THANKS! ----- Original Message ----- > From: "Tomas Jelinek" > To: "engine-devel" > Cc: "Alex Lourie" , "Alon Bar-Lev" > Sent: Friday, October 25, 2013 10:57:33 AM > Subject: missing AIO_CONFIG_NOT_AVAILABLE on 3.3 branch > > Hey, > > I have noticed an error: > ***L:ERROR Internal error: type object 'Stages' has no attribute > 'AIO_CONFIG_NOT_AVAILABLE' > while running engine-setup --jboss-home=... > > This does not happen on the master, only on ovirt-engine-3.3 - I guess the > problem is that the > http://gerrit.ovirt.org/#/c/20262 > is not backported. I have not seen any pending patch on the 3.3 branch - any > reason for that? > > Thanx, > Tomas > From tjelinek at redhat.com Fri Oct 25 08:55:13 2013 From: tjelinek at redhat.com (Tomas Jelinek) Date: Fri, 25 Oct 2013 04:55:13 -0400 (EDT) Subject: [Engine-devel] missing AIO_CONFIG_NOT_AVAILABLE on 3.3 branch In-Reply-To: <530228720.8528958.1382688023151.JavaMail.root@redhat.com> References: <1056375491.11584042.1382687853665.JavaMail.root@redhat.com> <530228720.8528958.1382688023151.JavaMail.root@redhat.com> Message-ID: <413128820.12196374.1382691313268.JavaMail.root@redhat.com> thank you for the quick response! ----- Original Message ----- > From: "Alon Bar-Lev" > To: "Tomas Jelinek" > Cc: "engine-devel" , "Alex Lourie" , "Sandro Bonazzola" > > Sent: Friday, October 25, 2013 10:00:23 AM > Subject: Re: missing AIO_CONFIG_NOT_AVAILABLE on 3.3 branch > > > Correct, broken by the same again... > > THANKS! > > ----- Original Message ----- > > From: "Tomas Jelinek" > > To: "engine-devel" > > Cc: "Alex Lourie" , "Alon Bar-Lev" > > Sent: Friday, October 25, 2013 10:57:33 AM > > Subject: missing AIO_CONFIG_NOT_AVAILABLE on 3.3 branch > > > > Hey, > > > > I have noticed an error: > > ***L:ERROR Internal error: type object 'Stages' has no attribute > > 'AIO_CONFIG_NOT_AVAILABLE' > > while running engine-setup --jboss-home=... > > > > This does not happen on the master, only on ovirt-engine-3.3 - I guess the > > problem is that the > > http://gerrit.ovirt.org/#/c/20262 > > is not backported. I have not seen any pending patch on the 3.3 branch - > > any > > reason for that? > > > > Thanx, > > Tomas > > > From piotr.kliczewski at gmail.com Fri Oct 25 10:38:50 2013 From: piotr.kliczewski at gmail.com (Piotr Kliczewski) Date: Fri, 25 Oct 2013 12:38:50 +0200 Subject: [Engine-devel] fails when build engine source code In-Reply-To: <319196301.11306667.1382686281222.JavaMail.root@redhat.com> References: <2bd7c1e.4aab.141ed917b93.Coremail.bigclouds@163.com> <319196301.11306667.1382686281222.JavaMail.root@redhat.com> Message-ID: Please try to clean your target directories and rebuild using: make clean install-dev PREFIX="$HOME/ovirt-engine" It is always good to check http://www.ovirt.org/OVirt_Engine_Development_Environment and look at Usage section. There is a bit of information which can help solving similar issues. Piotr On Fri, Oct 25, 2013 at 9:31 AM, Tomas Jelinek wrote: > hey, > > I have tried to build the current master and it works fine. > Which exact git commit are you trying to build? > > BTW for this kinds of errors I could suspect that there is some mess > from older builds which causes the problems. If this happens to you also > on the current HEAD > please try to: > > delete ~/.m2/repository/org/ovirt/* > delete all the targets: cd ; find . -name target -exec > rm -rf {} \; > > Tomas > > ----- Original Message ----- > > From: "bigclouds" > > To: "engine-devel" > > Sent: Friday, October 25, 2013 5:03:56 AM > > Subject: [Engine-devel] fails when build engine source code > > > > hi,all > > look at the error. UI Utils Compatibility part fails. > > [INFO] UI Utils Compatibility (for UICommon) ............. FAILURE > [0.385s] > > [INFO] Frontend for GWT UI Projects ...................... SKIPPED > > [INFO] UICommonWeb ....................................... SKIPPED > > [INFO] oVirt GWT UI common infrastructure ................ SKIPPED > > [INFO] WebAdmin .......................................... SKIPPED > > [INFO] UserPortal ........................................ SKIPPED > > [INFO] oVirt Server EAR .................................. SKIPPED > > [ERROR] Failed to execute goal > > org.codehaus.mojo:gwt-maven-plugin:2.5.1:compile (default) on project > > uicompat: GWT Module org.ovirt.engine.core.SearchBackend not found in > > project sources or resources. -> [Help 1] > > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute > > goal org.codehaus.mojo:gwt-maven-plugin:2.5.1:compile (default) on > project > > uicompat: GWT Module org.ovirt.engine.core.SearchBackend not found in > > project sources or resources. > > at > > > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217) > > at > > > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) > > at > > > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) > > at > > > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84) > > at > > > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59) > > at org.apache.maven.lifecycle.internal.L > > ifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183) > > at > > > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161) > > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320) > > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156) > > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537) > > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196) > > at org.apache.maven.cli.MavenCli.main(MavenCli.java:141) > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > > at > > > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > > at sun.reflect.DelegatingMethodAccessorImpl > > .invoke(DelegatingMethodAccessorImpl.java:43) > > at java.lang.reflect.Method.invoke(Method.java:606) > > at > > > org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290) > > at > > > org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230) > > at > > > org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409) > > at > org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352) > > Caused by: org.apache.maven.plugin.MojoExecutionException: GWT Module > > org.ovirt.engine.core.SearchBackend not found in project sources or > > resources. > > at > > > org.codehaus.mojo.gwt.shell.CompileMojo.compilationRequired(CompileMojo.java:495) > > at org.codehaus.mojo.gwt.shell.CompileMojo.compil e(CompileMojo.java:356) > > at > org.codehaus.mojo.gwt.shell.CompileMojo.doExecute(CompileMojo.java:280) > > at > > > org.codehaus.mojo.gwt.shell.AbstractGwtShellMojo.execute(AbstractGwtShellMojo.java:172) > > at > > > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101) > > at > > > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209) > > ... 19 more > > Caused by: org.codehaus.mojo.gwt.utils.GwtModuleReaderException: GWT > Module > > org.ovirt.engine.core.SearchBackend not found in project sources or > > resources. > > at > > > org.codehaus.mojo.gwt.AbstractGwtModuleMojo.readModule(AbstractGwtModuleMojo.java:205) > > at org.codehaus.mojo.gwt.GwtModule.getLocalInherits(GwtModule.java:189) > > at org.codehaus.mojo.gwt.GwtModule.getInherits(GwtModule.java:149) > > at org.codehaus.mojo.gwt.GwtModule.getEntryPoints(GwtModule.java:114) > > at > > > org.codehaus.mojo.gwt.shell.CompileMojo.compilationRequired(CompileMojo.java:409) > > ... 24 more > > [ERROR] > > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > > [ERROR] > > [ERROR] For more information about the errors and possible solutions, > please > > read the following articles: > > [ERROR] [Help 1] > > http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException > > [ERROR] > > [ERROR] After correcting the problems, you can resume the build with the > > command > > [ERROR] mvn -rf :uicompat > > > > > > > > _______________________________________________ > > Engine-devel mailing list > > Engine-devel at ovirt.org > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > -------------- next part -------------- An HTML attachment was scrubbed... URL: From bigclouds at 163.com Fri Oct 25 10:54:49 2013 From: bigclouds at 163.com (bigclouds) Date: Fri, 25 Oct 2013 18:54:49 +0800 (CST) Subject: [Engine-devel] fails when build engine source code In-Reply-To: <319196301.11306667.1382686281222.JavaMail.root@redhat.com> References: <2bd7c1e.4aab.141ed917b93.Coremail.bigclouds@163.com> <319196301.11306667.1382686281222.JavaMail.root@redhat.com> Message-ID: <34f92f6d.c537.141ef409851.Coremail.bigclouds@163.com> error reamins. the code is latest today, i update when build. i download a tar package ovirt-engine-3.3.0.1.tar.gz from internet. this tar works thanks. git log: commit c821e8ffdd4b06683fc2089bb0d60c0d9619fb0a Author: Alon Bar-Lev Date: Thu Oct 24 22:28:57 2013 +0300 packaging: fix typo in java detection caused only version match Change-Id: Ia0224b3bd1172ef5167c7085d2dd29aba72abaff Signed-off-by: Alon Bar-Lev commit 042c17ddadb05dfa33bf5384163d1090fd3747f0 Author: Tomas Jelinek Date: Wed Oct 16 15:33:21 2013 +0200 At 2013-10-25 15:31:21,"Tomas Jelinek" wrote: >hey, > >I have tried to build the current master and it works fine. >Which exact git commit are you trying to build? > >BTW for this kinds of errors I could suspect that there is some mess >from older builds which causes the problems. If this happens to you also on the current HEAD >please try to: > >delete ~/.m2/repository/org/ovirt/* >delete all the targets: cd ; find . -name target -exec rm -rf {} \; > >Tomas > >----- Original Message ----- >> From: "bigclouds" >> To: "engine-devel" >> Sent: Friday, October 25, 2013 5:03:56 AM >> Subject: [Engine-devel] fails when build engine source code >> >> hi,all >> look at the error. UI Utils Compatibility part fails. >> [INFO] UI Utils Compatibility (for UICommon) ............. FAILURE [0.385s] >> [INFO] Frontend for GWT UI Projects ...................... SKIPPED >> [INFO] UICommonWeb ....................................... SKIPPED >> [INFO] oVirt GWT UI common infrastructure ................ SKIPPED >> [INFO] WebAdmin .......................................... SKIPPED >> [INFO] UserPortal ........................................ SKIPPED >> [INFO] oVirt Server EAR .................................. SKIPPED >> [ERROR] Failed to execute goal >> org.codehaus.mojo:gwt-maven-plugin:2.5.1:compile (default) on project >> uicompat: GWT Module org.ovirt.engine.core.SearchBackend not found in >> project sources or resources. -> [Help 1] >> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute >> goal org.codehaus.mojo:gwt-maven-plugin:2.5.1:compile (default) on project >> uicompat: GWT Module org.ovirt.engine.core.SearchBackend not found in >> project sources or resources. >> at >> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217) >> at >> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) >> at >> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) >> at >> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84) >> at >> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59) >> at org.apache.maven.lifecycle.internal.L >> ifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183) >> at >> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161) >> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320) >> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156) >> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537) >> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196) >> at org.apache.maven.cli.MavenCli.main(MavenCli.java:141) >> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >> at >> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) >> at sun.reflect.DelegatingMethodAccessorImpl >> .invoke(DelegatingMethodAccessorImpl.java:43) >> at java.lang.reflect.Method.invoke(Method.java:606) >> at >> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290) >> at >> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230) >> at >> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409) >> at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352) >> Caused by: org.apache.maven.plugin.MojoExecutionException: GWT Module >> org.ovirt.engine.core.SearchBackend not found in project sources or >> resources. >> at >> org.codehaus.mojo.gwt.shell.CompileMojo.compilationRequired(CompileMojo.java:495) >> at org.codehaus.mojo.gwt.shell.CompileMojo.compil e(CompileMojo.java:356) >> at org.codehaus.mojo.gwt.shell.CompileMojo.doExecute(CompileMojo.java:280) >> at >> org.codehaus.mojo.gwt.shell.AbstractGwtShellMojo.execute(AbstractGwtShellMojo.java:172) >> at >> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101) >> at >> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209) >> ... 19 more >> Caused by: org.codehaus.mojo.gwt.utils.GwtModuleReaderException: GWT Module >> org.ovirt.engine.core.SearchBackend not found in project sources or >> resources. >> at >> org.codehaus.mojo.gwt.AbstractGwtModuleMojo.readModule(AbstractGwtModuleMojo.java:205) >> at org.codehaus.mojo.gwt.GwtModule.getLocalInherits(GwtModule.java:189) >> at org.codehaus.mojo.gwt.GwtModule.getInherits(GwtModule.java:149) >> at org.codehaus.mojo.gwt.GwtModule.getEntryPoints(GwtModule.java:114) >> at >> org.codehaus.mojo.gwt.shell.CompileMojo.compilationRequired(CompileMojo.java:409) >> ... 24 more >> [ERROR] >> [ERROR] Re-run Maven using the -X switch to enable full debug logging. >> [ERROR] >> [ERROR] For more information about the errors and possible solutions, please >> read the following articles: >> [ERROR] [Help 1] >> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException >> [ERROR] >> [ERROR] After correcting the problems, you can resume the build with the >> command >> [ERROR] mvn -rf :uicompat >> >> >> >> _______________________________________________ >> Engine-devel mailing list >> Engine-devel at ovirt.org >> http://lists.ovirt.org/mailman/listinfo/engine-devel >> -------------- next part -------------- An HTML attachment was scrubbed... URL: From alonbl at redhat.com Fri Oct 25 10:57:17 2013 From: alonbl at redhat.com (Alon Bar-Lev) Date: Fri, 25 Oct 2013 06:57:17 -0400 (EDT) Subject: [Engine-devel] fails when build engine source code In-Reply-To: <34f92f6d.c537.141ef409851.Coremail.bigclouds@163.com> References: <2bd7c1e.4aab.141ed917b93.Coremail.bigclouds@163.com> <319196301.11306667.1382686281222.JavaMail.root@redhat.com> <34f92f6d.c537.141ef409851.Coremail.bigclouds@163.com> Message-ID: <1827623476.8554135.1382698637062.JavaMail.root@redhat.com> Can you please start from scratch? git checkout master git clean -dxf make install-dev PREFIX=`pwd`/xxx From mrao at redhat.com Fri Oct 25 20:01:13 2013 From: mrao at redhat.com (Malini Rao) Date: Fri, 25 Oct 2013 16:01:13 -0400 (EDT) Subject: [Engine-devel] GUI widget for adding/removing entries In-Reply-To: <525AA832.8010500@redhat.com> References: <52551515.2090503@redhat.com> <52554CC9.5020806@redhat.com> <5255CBD2.7090606@redhat.com> <52565E6F.2060509@redhat.com> <52565113.9010103@redhat.com> <525668FF.3020102@redhat.com> <1080405201.5269235.1381413666292.JavaMail.root@redhat.com> <525AA832.8010500@redhat.com> Message-ID: <1461932287.10862794.1382731273340.JavaMail.root@redhat.com> ----- Original Message ----- > From: "Lior Vernia" > To: "Einav Cohen" > Cc: "engine-devel" > Sent: Sunday, October 13, 2013 10:03:30 AM > Subject: Re: [Engine-devel] GUI widget for adding/removing entries > > > > On 10/10/13 16:01, Einav Cohen wrote: > > see attached: AFAIK, there are three types of adding-and-removing widget in > > the application: > > > > (1) the one that exists in the customs properties section as well as the > > cluster policy. > > in this widget: > > - the "+" and "-" buttons appear on every row. > > - row is "identified" by a selected item from a drop down. > > - input controls in row: drop-down and text box (that appears upon > > selection of a non-empty value in the drop-down) > > > > (2) the one that exists in the vNICs assignment part of the General section > > in the New VM dialog. > > in this widget: > > - the "+" appears only in the last row, "-" appears in all lines but the > > last row. > > - row is "identified" by (what seems to be a) read-only label (I assume > > that this widget is > > built to be initially loaded to already contain a number of rows, as > > opposed to (1), which > > typically starts with no rows / initial "empty" row. > > - input controls in row: drop-down > > > > (3) the one that exists in the vNIC profiles section in the Add/Edit > > Network dialog > > in this widget: > > - the "+" and "-" buttons appear on every row. > > - row is "identified" by a free-text string. > > - input controls in row: text-box, check-box and drop-down. > > > > so there are differences between the widgets other than the "+" and "-" > > buttons. > > however, from ux perspective, it is important to keep the look-and-feel of > > all of them consistent. > > > > technically (code-wise), I am not sure how easy it is to merge the three, > > due to the differences. > > we can maybe think of creating a general adding-and-removing-entries > > widget, which can support > > "ordered" and "non-ordered" flavors (which will affect the "+"/"-" buttons > > appearance / exact > > behavior), and it will contain a collection of "abstract" row-widgets (and > > we will have several > > implementations of row-widgets for each needed functionality [(1), (2), > > (3)] with exact appearance / > > input controls / behavior/etc.), which may need to support a certain api > > (e.g. isRowEmpty(), get/set > > Identifier(), etc.) in order to communicate appropriately with its "parent" > > adding-and-removing-entries > > widget. > > > > thoughts? > > > > What you described is pretty much how the abstract AddRemoveRowWidget > works, so it should be fairly easy to merge the three (it was designed > to be so). The widget doesn't care about the exact nature of the content > widget to the left of the plus/minus button, that information is given > when overriding the aforementioned abstract methods. The only difference > is that there's only one flavor at the moment, which is orderless, since > none of these current examples is mindful of ordering. If all the attached examples are orderless, why do 3 of them have the + button on every row? I think it will be a good idea to lock down the behavior for ordered and order-less rows as Einav mentioned for consistency. I understand that the row content can be different based on the use case but we need to have some basic commonalities - For e.g, in the VNic Profile example, we should have a label for the first text field as it is not really clear what that starting empty text field is for - I can deduce it is for the Profile name but can't be sure. > > > ----- Original Message ----- > >> From: "Lior Vernia" > >> To: "Itamar Heim" > >> Cc: "engine-devel" > >> Sent: Thursday, October 10, 2013 4:44:47 AM > >> Subject: Re: [Engine-devel] GUI widget for adding/removing entries > >> > >> To my knowledge, such a widget existed only in two other places: custom > >> properties and vNIC profiles in add/edit network dialog. In both of them > >> the order wasn't important, in which case the new widget is probably > >> preferable. If it is indeed preferable (Einav? Malini?), I could do some > >> refactoring to have both of them use it. > >> > >> On 10/10/13 09:02, Itamar Heim wrote: > >>> On 10/10/2013 10:59 AM, Lior Vernia wrote: > >>>> > >>>> > >>>> On 09/10/13 23:34, Itamar Heim wrote: > >>>>> On 10/09/2013 03:32 PM, Lior Vernia wrote: > >>>>>> Of course, my bad. Attached is a screenshot of the add/edit VM dialog, > >>>>>> note the vNIC part on the bottom half of the dialog. > >>>>> > >>>>> how is it different from the custom properties one? > >>>>> > >>>> > >>>> Design-wise, there are a couple of small differences. There's only one > >>>> button next to each row, plus if it's the last row or minus otherwise > >>>> (so items can only be added at the end, as I replied to Malini order > >>>> hasn't been important so far). A row appears as disabled until it is > >>>> edited, and a disabled row is ignored when the view is flushed back to > >>>> the model (e.g. when the user presses OK in the dialog). > >>>> > >>>> Code-wise, it's constructed to be reusable, which the custom properties > >>>> widget wasn't :) > >>> > >>> could we converge on one of them though? > >>> > >>>> > >>>>>> > >>>>>> On 09/10/13 13:24, Einav Cohen wrote: > >>>>>>> Hi Lior - can you please provide a screen-shot, so we will know which > >>>>>>> widget > >>>>>>> you are referring to? > >>>>>>> will make it easier for people to decide if and where to use this > >>>>>>> widget. > >>>>>>> > >>>>>>> Many thanks! > >>>>>>> > >>>>>>> ---- > >>>>>>> Regards, > >>>>>>> Einav > >>>>>>> > >>>>>>> ----- Original Message ----- > >>>>>>>> From: "Lior Vernia" > >>>>>>>> To: "engine-devel" > >>>>>>>> Sent: Wednesday, October 9, 2013 4:34:29 AM > >>>>>>>> Subject: [Engine-devel] GUI widget for adding/removing entries > >>>>>>>> > >>>>>>>> Hello, > >>>>>>>> > >>>>>>>> Lately a patch has been merged that introduces a widget for > >>>>>>>> adding/removing entries (e.g. network interfaces when > >>>>>>>> creating/editing a > >>>>>>>> VM): > >>>>>>>> > >>>>>>>> http://gerrit.ovirt.org/#/c/19530/ > >>>>>>>> > >>>>>>>> This kind of widgets is becoming common in oVirt, so the idea is to > >>>>>>>> make > >>>>>>>> adding one easy rather than copying & pasting code. > >>>>>>>> AddRemoveRowWidget > >>>>>>>> takes care of the plus/minus button logic, disabling an entry that > >>>>>>>> hasn't been edited, and the arranging in rows. > >>>>>>>> > >>>>>>>> In order to use it, one is required to override a couple of abstract > >>>>>>>> methods that are dependent upon the specific entry implementation. > >>>>>>>> An > >>>>>>>> example may be found in ProfilesInstanceTypeEditor, which handles > >>>>>>>> adding/removing network interfaces in the new/edit VM dialog. > >>>>>>>> > >>>>>>>> Yours, Lior. > >>>>>>>> _______________________________________________ > >>>>>>>> Engine-devel mailing list > >>>>>>>> Engine-devel at ovirt.org > >>>>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel > >>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> _______________________________________________ > >>>>>>>> Engine-devel mailing list > >>>>>>>> Engine-devel at ovirt.org > >>>>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel > >>>>> > >>> > >> _______________________________________________ > >> Engine-devel mailing list > >> Engine-devel at ovirt.org > >> http://lists.ovirt.org/mailman/listinfo/engine-devel > >> > >> > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > From ecohen at redhat.com Fri Oct 25 21:34:13 2013 From: ecohen at redhat.com (Einav Cohen) Date: Fri, 25 Oct 2013 17:34:13 -0400 (EDT) Subject: [Engine-devel] GUI widget for adding/removing entries In-Reply-To: <1461932287.10862794.1382731273340.JavaMail.root@redhat.com> References: <52551515.2090503@redhat.com> <5255CBD2.7090606@redhat.com> <52565E6F.2060509@redhat.com> <52565113.9010103@redhat.com> <525668FF.3020102@redhat.com> <1080405201.5269235.1381413666292.JavaMail.root@redhat.com> <525AA832.8010500@redhat.com> <1461932287.10862794.1382731273340.JavaMail.root@redhat.com> Message-ID: <1716369249.11807141.1382736853218.JavaMail.root@redhat.com> > If all the attached examples are orderless, why do 3 of them have the + > button on every row? +1. it seems that all widgets should contain the "+" button only in the last row. > I think it will be a good idea to lock down the behavior for ordered and > order-less rows as Einav mentioned for consistency. assuming everyone are OK with adjusting all existing widgets (which are all orderless, as was mentioned here) so that they will contain the "+" button only in the last row, then we currently don't even need to introduce the "ordered" flavor to AddRemoveRowWidget. > I understand that the row content can be different based on the use > case but we need to have some basic commonalities - For e.g, in the > VNic Profile example, we should have a label for the first text > field as it is not really clear what that starting empty text field > is for - I can deduce it is for the Profile name but can't be sure. +1. We should think of a consistent way of "labeling" the different parts within a row / provide an explanation for a row (for all of the row types that we currently have). Today there is a bit of a mess: In the vNIC assignment, there is a top explanation of "VM has x network interfaces. Assign profiles to them". In vNIC profiles, there isn't a top explanation, but the check-box and drop-down are labeled, however the text-box, as you mentioned, is not. In the Profiles/Custom-Properties, there are no explanations and no labels at all. ----- Original Message ----- > From: "Malini Rao" > To: "Lior Vernia" > Cc: "engine-devel" > Sent: Friday, October 25, 2013 4:01:13 PM > Subject: Re: [Engine-devel] GUI widget for adding/removing entries > > > > > > ----- Original Message ----- > > From: "Lior Vernia" > > To: "Einav Cohen" > > Cc: "engine-devel" > > Sent: Sunday, October 13, 2013 10:03:30 AM > > Subject: Re: [Engine-devel] GUI widget for adding/removing entries > > > > > > > > On 10/10/13 16:01, Einav Cohen wrote: > > > see attached: AFAIK, there are three types of adding-and-removing widget > > > in > > > the application: > > > > > > (1) the one that exists in the customs properties section as well as the > > > cluster policy. > > > in this widget: > > > - the "+" and "-" buttons appear on every row. > > > - row is "identified" by a selected item from a drop down. > > > - input controls in row: drop-down and text box (that appears upon > > > selection of a non-empty value in the drop-down) > > > > > > (2) the one that exists in the vNICs assignment part of the General > > > section > > > in the New VM dialog. > > > in this widget: > > > - the "+" appears only in the last row, "-" appears in all lines but the > > > last row. > > > - row is "identified" by (what seems to be a) read-only label (I assume > > > that this widget is > > > built to be initially loaded to already contain a number of rows, as > > > opposed to (1), which > > > typically starts with no rows / initial "empty" row. > > > - input controls in row: drop-down > > > > > > (3) the one that exists in the vNIC profiles section in the Add/Edit > > > Network dialog > > > in this widget: > > > - the "+" and "-" buttons appear on every row. > > > - row is "identified" by a free-text string. > > > - input controls in row: text-box, check-box and drop-down. > > > > > > so there are differences between the widgets other than the "+" and "-" > > > buttons. > > > however, from ux perspective, it is important to keep the look-and-feel > > > of > > > all of them consistent. > > > > > > technically (code-wise), I am not sure how easy it is to merge the three, > > > due to the differences. > > > we can maybe think of creating a general adding-and-removing-entries > > > widget, which can support > > > "ordered" and "non-ordered" flavors (which will affect the "+"/"-" > > > buttons > > > appearance / exact > > > behavior), and it will contain a collection of "abstract" row-widgets > > > (and > > > we will have several > > > implementations of row-widgets for each needed functionality [(1), (2), > > > (3)] with exact appearance / > > > input controls / behavior/etc.), which may need to support a certain api > > > (e.g. isRowEmpty(), get/set > > > Identifier(), etc.) in order to communicate appropriately with its > > > "parent" > > > adding-and-removing-entries > > > widget. > > > > > > thoughts? > > > > > > > What you described is pretty much how the abstract AddRemoveRowWidget > > works, so it should be fairly easy to merge the three (it was designed > > to be so). The widget doesn't care about the exact nature of the content > > widget to the left of the plus/minus button, that information is given > > when overriding the aforementioned abstract methods. The only difference > > is that there's only one flavor at the moment, which is orderless, since > > none of these current examples is mindful of ordering. > > If all the attached examples are orderless, why do 3 of them have the + > button on every row? > I think it will be a good idea to lock down the behavior for ordered and > order-less rows as Einav mentioned for consistency. I understand that the > row content can be different based on the use case but we need to have some > basic commonalities - For e.g, in the VNic Profile example, we should have a > label for the first text field as it is not really clear what that starting > empty text field is for - I can deduce it is for the Profile name but can't > be sure. > > > > > > > ----- Original Message ----- > > >> From: "Lior Vernia" > > >> To: "Itamar Heim" > > >> Cc: "engine-devel" > > >> Sent: Thursday, October 10, 2013 4:44:47 AM > > >> Subject: Re: [Engine-devel] GUI widget for adding/removing entries > > >> > > >> To my knowledge, such a widget existed only in two other places: custom > > >> properties and vNIC profiles in add/edit network dialog. In both of them > > >> the order wasn't important, in which case the new widget is probably > > >> preferable. If it is indeed preferable (Einav? Malini?), I could do some > > >> refactoring to have both of them use it. > > >> > > >> On 10/10/13 09:02, Itamar Heim wrote: > > >>> On 10/10/2013 10:59 AM, Lior Vernia wrote: > > >>>> > > >>>> > > >>>> On 09/10/13 23:34, Itamar Heim wrote: > > >>>>> On 10/09/2013 03:32 PM, Lior Vernia wrote: > > >>>>>> Of course, my bad. Attached is a screenshot of the add/edit VM > > >>>>>> dialog, > > >>>>>> note the vNIC part on the bottom half of the dialog. > > >>>>> > > >>>>> how is it different from the custom properties one? > > >>>>> > > >>>> > > >>>> Design-wise, there are a couple of small differences. There's only one > > >>>> button next to each row, plus if it's the last row or minus otherwise > > >>>> (so items can only be added at the end, as I replied to Malini order > > >>>> hasn't been important so far). A row appears as disabled until it is > > >>>> edited, and a disabled row is ignored when the view is flushed back to > > >>>> the model (e.g. when the user presses OK in the dialog). > > >>>> > > >>>> Code-wise, it's constructed to be reusable, which the custom > > >>>> properties > > >>>> widget wasn't :) > > >>> > > >>> could we converge on one of them though? > > >>> > > >>>> > > >>>>>> > > >>>>>> On 09/10/13 13:24, Einav Cohen wrote: > > >>>>>>> Hi Lior - can you please provide a screen-shot, so we will know > > >>>>>>> which > > >>>>>>> widget > > >>>>>>> you are referring to? > > >>>>>>> will make it easier for people to decide if and where to use this > > >>>>>>> widget. > > >>>>>>> > > >>>>>>> Many thanks! > > >>>>>>> > > >>>>>>> ---- > > >>>>>>> Regards, > > >>>>>>> Einav > > >>>>>>> > > >>>>>>> ----- Original Message ----- > > >>>>>>>> From: "Lior Vernia" > > >>>>>>>> To: "engine-devel" > > >>>>>>>> Sent: Wednesday, October 9, 2013 4:34:29 AM > > >>>>>>>> Subject: [Engine-devel] GUI widget for adding/removing entries > > >>>>>>>> > > >>>>>>>> Hello, > > >>>>>>>> > > >>>>>>>> Lately a patch has been merged that introduces a widget for > > >>>>>>>> adding/removing entries (e.g. network interfaces when > > >>>>>>>> creating/editing a > > >>>>>>>> VM): > > >>>>>>>> > > >>>>>>>> http://gerrit.ovirt.org/#/c/19530/ > > >>>>>>>> > > >>>>>>>> This kind of widgets is becoming common in oVirt, so the idea is > > >>>>>>>> to > > >>>>>>>> make > > >>>>>>>> adding one easy rather than copying & pasting code. > > >>>>>>>> AddRemoveRowWidget > > >>>>>>>> takes care of the plus/minus button logic, disabling an entry that > > >>>>>>>> hasn't been edited, and the arranging in rows. > > >>>>>>>> > > >>>>>>>> In order to use it, one is required to override a couple of > > >>>>>>>> abstract > > >>>>>>>> methods that are dependent upon the specific entry implementation. > > >>>>>>>> An > > >>>>>>>> example may be found in ProfilesInstanceTypeEditor, which handles > > >>>>>>>> adding/removing network interfaces in the new/edit VM dialog. > > >>>>>>>> > > >>>>>>>> Yours, Lior. > > >>>>>>>> _______________________________________________ > > >>>>>>>> Engine-devel mailing list > > >>>>>>>> Engine-devel at ovirt.org > > >>>>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> _______________________________________________ > > >>>>>>>> Engine-devel mailing list > > >>>>>>>> Engine-devel at ovirt.org > > >>>>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel > > >>>>> > > >>> > > >> _______________________________________________ > > >> Engine-devel mailing list > > >> Engine-devel at ovirt.org > > >> http://lists.ovirt.org/mailman/listinfo/engine-devel > > >> > > >> > > _______________________________________________ > > Engine-devel mailing list > > Engine-devel at ovirt.org > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > From shweng at 163.com Sat Oct 26 13:15:37 2013 From: shweng at 163.com (Edgar) Date: Sat, 26 Oct 2013 21:15:37 +0800 (CST) Subject: [Engine-devel] How to DELETE Disk in Illegal state Message-ID: <120a0966.1b5c7.141f4e7db1d.Coremail.shweng@163.com> Hi all, I have encounter a problem that can not remove disk in Illegal state,almost all method I can do on Web UI. I ask for help is is possible to remove it on backend database,and what the psql command will perform this? another question is if the illegal state disk was removed from backend database by psql command whether disk space will be recycle by system? Here is related error message on engine.log 2013-10-26 18:03:47,826 ERROR [org.ovirt.engine.core.vdsbroker.VDSCommandBase] (pool-3-thread-30) [6e9ad129] Command DeleteImageGroupVDS execution failed. Exception: IrsOperationFailedNoFailoverException: IRSGenericException: IRSErrorException: Image does not exist in domain: 'image=b518e267-fba3-4222-964a-488de5a7360f, domain=63322733-a0cd-4648-9a48-d851c219e61e' 2013-10-26 18:03:47,828 INFO [org.ovirt.engine.core.vdsbroker.irsbroker.DeleteImageGroupVDSCommand] (pool-3-thread-30) [6e9ad129] FINISH, DeleteImageGroupVDSCommand, log id: 5cde6484 2013-10-26 18:03:47,828 ERROR [org.ovirt.engine.core.bll.RemoveImageCommand] (pool-3-thread-30) [6e9ad129] Command org.ovirt.engine.core.bll.RemoveImageCommand throw Vdc Bll exception. With error message VdcBLLException: org.ovirt.engine.core.vdsbroker.irsbroker.IrsOperationFailedNoFailoverException: IRSGenericException: IRSErrorException: Image does not exist in domain: 'image=b518e267-fba3-4222-964a-488de5a7360f, domain=63322733-a0cd-4648-9a48-d851c219e61e' 2013-10-26 18:03:47,834 INFO [org.ovirt.engine.core.bll.RemoveImageCommand] (pool-3-thread-30) [6e9ad129] Command [id=9ffffbc3-4d5d-497d-a6f3-efca7362ef15]: Compensating CHANGED_STATUS_ONLY of org.ovirt.engine.core.common.businessentities.Image; snapshot: EntityStatusSnapshot [id=90eb85d4-8d88-4691-8453-585554dff5ac, status=ILLEGAL]. oVirt engine:3.2.1-1.41.el6.noarch.rpm vdsm:4.10.3-0.36.23.el6.noarch.rpm -------------- next part -------------- An HTML attachment was scrubbed... URL: From bazulay at redhat.com Sun Oct 27 10:49:33 2013 From: bazulay at redhat.com (Barak Azulay) Date: Sun, 27 Oct 2013 06:49:33 -0400 (EDT) Subject: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch In-Reply-To: <1578330426.13390301.1382636566232.JavaMail.root@redhat.com> References: <1963655862.13395521.1382629761676.JavaMail.root@redhat.com> <1674499877.10075467.1382631184300.JavaMail.root@redhat.com> <1352440551.13328035.1382631611776.JavaMail.root@redhat.com> <1683839335.10116594.1382634747025.JavaMail.root@redhat.com> <1578330426.13390301.1382636566232.JavaMail.root@redhat.com> Message-ID: <157758143.12015814.1382870973276.JavaMail.root@redhat.com> ----- Original Message ----- > From: "Eyal Edri" > To: "Barak Azulay" > Cc: "engine-devel" , infra at ovirt.org > Sent: Thursday, October 24, 2013 8:42:46 PM > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch > > already active. I may be missing something, so how wasn't it caught by those hooks ? > > ----- Original Message ----- > > From: "Barak Azulay" > > To: "Eyal Edri" > > Cc: "engine-devel" , infra at ovirt.org > > Sent: Thursday, October 24, 2013 8:12:27 PM > > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and > > for stable branch > > > > Even better, > > > > When will these hooks be effective on engine master & ovirt-3.3 ? > > > > Barak > > > > ----- Original Message ----- > > > From: "Eyal Edri" > > > To: "Barak Azulay" > > > Cc: "engine-devel" , infra at ovirt.org > > > Sent: Thursday, October 24, 2013 7:20:11 PM > > > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and > > > for stable branch > > > > > > there are already in place gerrit jobs for all flows, only this was > > > introduced before they were added: > > > > > > ovirt_engine_3.2_update_db_to_3.3_gerrit > > > ovirt_engine_3.3.0_update_db_to_3.3_gerrit > > > ovirt_engine_3.3.1_update_db_to_3.3_gerrit > > > ovirt_engine_3.3_update_db_to_master_gerrit > > > ovirt_engine_3.3.0_update_db_to_3.3.1_gerrit > > > ovirt_engine_master_update_db_to_master_gerrit > > > ovirt_engine_3.3_update_db_to_3.3_latest_gerrit > > > > > > ----- Original Message ----- > > > > From: "Barak Azulay" > > > > To: "Eli Mesika" > > > > Cc: "engine-devel" , infra at ovirt.org, "Eyal > > > > Edri" > > > > > > > > Sent: Thursday, October 24, 2013 7:13:04 PM > > > > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master > > > > and > > > > for stable branch > > > > > > > > We should add a gerrit hook to enforce the right naming/version of db > > > > upgrade scripts. > > > > > > > > > > > > Thanks > > > > Barak Azulay > > > > > > > > ----- Original Message ----- > > > > > From: "Eli Mesika" > > > > > To: "engine-devel" > > > > > Sent: Thursday, October 24, 2013 6:49:21 PM > > > > > Subject: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and > > > > > for > > > > > stable branch > > > > > > > > > > Hi > > > > > > > > > > Please note that any upgrade script introduced to the master branch > > > > > should > > > > > have the 03_04 prefix. > > > > > If this script is resolving a blocker/exception BZ it should be > > > > > ported > > > > > to > > > > > the > > > > > ovirt-engine-3.3 branch with a 03_03 prefix !!! > > > > > > > > > > We have encountered some patches that broke the upgrade from > > > > > ovirt-engine-3.3 > > > > > to master as a result of > > > > > > > > > > 1) naming new upgrade scripts in master branch with 03_03 prefix > > > > > 2) naming new upgrade scripts in ovirt-engine-3.3 stable branch with > > > > > 03_04 > > > > > prefix > > > > > > > > > > I am available for any question and asking you to add me to any DB > > > > > related > > > > > script as a reviewer even if I +2 the master patch and you just > > > > > back-port > > > > > it > > > > > to ovirt-engine-3.3. > > > > > It may save us a lot of noise. > > > > > > > > > > Thanks for your cooperation > > > > > > > > > > Eli > > > > > _______________________________________________ > > > > > Engine-devel mailing list > > > > > Engine-devel at ovirt.org > > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > Engine-devel mailing list > > > Engine-devel at ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > > > > > > From eedri at redhat.com Sun Oct 27 10:57:23 2013 From: eedri at redhat.com (Eyal Edri) Date: Sun, 27 Oct 2013 06:57:23 -0400 (EDT) Subject: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch In-Reply-To: <157758143.12015814.1382870973276.JavaMail.root@redhat.com> References: <1963655862.13395521.1382629761676.JavaMail.root@redhat.com> <1674499877.10075467.1382631184300.JavaMail.root@redhat.com> <1352440551.13328035.1382631611776.JavaMail.root@redhat.com> <1683839335.10116594.1382634747025.JavaMail.root@redhat.com> <1578330426.13390301.1382636566232.JavaMail.root@redhat.com> <157758143.12015814.1382870973276.JavaMail.root@redhat.com> Message-ID: <530488007.14165467.1382871443842.JavaMail.root@redhat.com> ----- Original Message ----- > From: "Barak Azulay" > To: "Eyal Edri" > Cc: "engine-devel" , infra at ovirt.org > Sent: Sunday, October 27, 2013 12:49:33 PM > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch > > > > ----- Original Message ----- > > From: "Eyal Edri" > > To: "Barak Azulay" > > Cc: "engine-devel" , infra at ovirt.org > > Sent: Thursday, October 24, 2013 8:42:46 PM > > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and > > for stable branch > > > > already active. > > I may be missing something, so how wasn't it caught by those hooks ? 1. job was added AFTER failure was introduced (flow from 3.3 -> master). 2. job will now fail on every patch until issue is fixed. > > > > > > ----- Original Message ----- > > > From: "Barak Azulay" > > > To: "Eyal Edri" > > > Cc: "engine-devel" , infra at ovirt.org > > > Sent: Thursday, October 24, 2013 8:12:27 PM > > > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and > > > for stable branch > > > > > > Even better, > > > > > > When will these hooks be effective on engine master & ovirt-3.3 ? > > > > > > Barak > > > > > > ----- Original Message ----- > > > > From: "Eyal Edri" > > > > To: "Barak Azulay" > > > > Cc: "engine-devel" , infra at ovirt.org > > > > Sent: Thursday, October 24, 2013 7:20:11 PM > > > > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master > > > > and > > > > for stable branch > > > > > > > > there are already in place gerrit jobs for all flows, only this was > > > > introduced before they were added: > > > > > > > > ovirt_engine_3.2_update_db_to_3.3_gerrit > > > > ovirt_engine_3.3.0_update_db_to_3.3_gerrit > > > > ovirt_engine_3.3.1_update_db_to_3.3_gerrit > > > > ovirt_engine_3.3_update_db_to_master_gerrit > > > > ovirt_engine_3.3.0_update_db_to_3.3.1_gerrit > > > > ovirt_engine_master_update_db_to_master_gerrit > > > > ovirt_engine_3.3_update_db_to_3.3_latest_gerrit > > > > > > > > ----- Original Message ----- > > > > > From: "Barak Azulay" > > > > > To: "Eli Mesika" > > > > > Cc: "engine-devel" , infra at ovirt.org, "Eyal > > > > > Edri" > > > > > > > > > > Sent: Thursday, October 24, 2013 7:13:04 PM > > > > > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master > > > > > and > > > > > for stable branch > > > > > > > > > > We should add a gerrit hook to enforce the right naming/version of > > > > > db > > > > > upgrade scripts. > > > > > > > > > > > > > > > Thanks > > > > > Barak Azulay > > > > > > > > > > ----- Original Message ----- > > > > > > From: "Eli Mesika" > > > > > > To: "engine-devel" > > > > > > Sent: Thursday, October 24, 2013 6:49:21 PM > > > > > > Subject: [Engine-devel] [IMPORTANT] DB upgrade scripts for master > > > > > > and > > > > > > for > > > > > > stable branch > > > > > > > > > > > > Hi > > > > > > > > > > > > Please note that any upgrade script introduced to the master branch > > > > > > should > > > > > > have the 03_04 prefix. > > > > > > If this script is resolving a blocker/exception BZ it should be > > > > > > ported > > > > > > to > > > > > > the > > > > > > ovirt-engine-3.3 branch with a 03_03 prefix !!! > > > > > > > > > > > > We have encountered some patches that broke the upgrade from > > > > > > ovirt-engine-3.3 > > > > > > to master as a result of > > > > > > > > > > > > 1) naming new upgrade scripts in master branch with 03_03 prefix > > > > > > 2) naming new upgrade scripts in ovirt-engine-3.3 stable branch > > > > > > with > > > > > > 03_04 > > > > > > prefix > > > > > > > > > > > > I am available for any question and asking you to add me to any DB > > > > > > related > > > > > > script as a reviewer even if I +2 the master patch and you just > > > > > > back-port > > > > > > it > > > > > > to ovirt-engine-3.3. > > > > > > It may save us a lot of noise. > > > > > > > > > > > > Thanks for your cooperation > > > > > > > > > > > > Eli > > > > > > _______________________________________________ > > > > > > Engine-devel mailing list > > > > > > Engine-devel at ovirt.org > > > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > Engine-devel mailing list > > > > Engine-devel at ovirt.org > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > > > > > > > > > > > > From bazulay at redhat.com Sun Oct 27 11:18:24 2013 From: bazulay at redhat.com (Barak Azulay) Date: Sun, 27 Oct 2013 07:18:24 -0400 (EDT) Subject: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch In-Reply-To: <530488007.14165467.1382871443842.JavaMail.root@redhat.com> References: <1963655862.13395521.1382629761676.JavaMail.root@redhat.com> <1674499877.10075467.1382631184300.JavaMail.root@redhat.com> <1352440551.13328035.1382631611776.JavaMail.root@redhat.com> <1683839335.10116594.1382634747025.JavaMail.root@redhat.com> <1578330426.13390301.1382636566232.JavaMail.root@redhat.com> <157758143.12015814.1382870973276.JavaMail.root@redhat.com> <530488007.14165467.1382871443842.JavaMail.root@redhat.com> Message-ID: <376256596.12019104.1382872704514.JavaMail.root@redhat.com> ----- Original Message ----- > From: "Eyal Edri" > To: "Barak Azulay" > Cc: "engine-devel" , infra at ovirt.org > Sent: Sunday, October 27, 2013 12:57:23 PM > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch > > > > ----- Original Message ----- > > From: "Barak Azulay" > > To: "Eyal Edri" > > Cc: "engine-devel" , infra at ovirt.org > > Sent: Sunday, October 27, 2013 12:49:33 PM > > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and > > for stable branch > > > > > > > > ----- Original Message ----- > > > From: "Eyal Edri" > > > To: "Barak Azulay" > > > Cc: "engine-devel" , infra at ovirt.org > > > Sent: Thursday, October 24, 2013 8:42:46 PM > > > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and > > > for stable branch > > > > > > already active. > > > > I may be missing something, so how wasn't it caught by those hooks ? > > 1. job was added AFTER failure was introduced (flow from 3.3 -> master). > 2. job will now fail on every patch until issue is fixed. Great, Thanks > > > > > > > > > > > > > ----- Original Message ----- > > > > From: "Barak Azulay" > > > > To: "Eyal Edri" > > > > Cc: "engine-devel" , infra at ovirt.org > > > > Sent: Thursday, October 24, 2013 8:12:27 PM > > > > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master > > > > and > > > > for stable branch > > > > > > > > Even better, > > > > > > > > When will these hooks be effective on engine master & ovirt-3.3 ? > > > > > > > > Barak > > > > > > > > ----- Original Message ----- > > > > > From: "Eyal Edri" > > > > > To: "Barak Azulay" > > > > > Cc: "engine-devel" , infra at ovirt.org > > > > > Sent: Thursday, October 24, 2013 7:20:11 PM > > > > > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master > > > > > and > > > > > for stable branch > > > > > > > > > > there are already in place gerrit jobs for all flows, only this was > > > > > introduced before they were added: > > > > > > > > > > ovirt_engine_3.2_update_db_to_3.3_gerrit > > > > > ovirt_engine_3.3.0_update_db_to_3.3_gerrit > > > > > ovirt_engine_3.3.1_update_db_to_3.3_gerrit > > > > > ovirt_engine_3.3_update_db_to_master_gerrit > > > > > ovirt_engine_3.3.0_update_db_to_3.3.1_gerrit > > > > > ovirt_engine_master_update_db_to_master_gerrit > > > > > ovirt_engine_3.3_update_db_to_3.3_latest_gerrit > > > > > > > > > > ----- Original Message ----- > > > > > > From: "Barak Azulay" > > > > > > To: "Eli Mesika" > > > > > > Cc: "engine-devel" , infra at ovirt.org, "Eyal > > > > > > Edri" > > > > > > > > > > > > Sent: Thursday, October 24, 2013 7:13:04 PM > > > > > > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for > > > > > > master > > > > > > and > > > > > > for stable branch > > > > > > > > > > > > We should add a gerrit hook to enforce the right naming/version > > > > > > of > > > > > > db > > > > > > upgrade scripts. > > > > > > > > > > > > > > > > > > Thanks > > > > > > Barak Azulay > > > > > > > > > > > > ----- Original Message ----- > > > > > > > From: "Eli Mesika" > > > > > > > To: "engine-devel" > > > > > > > Sent: Thursday, October 24, 2013 6:49:21 PM > > > > > > > Subject: [Engine-devel] [IMPORTANT] DB upgrade scripts for master > > > > > > > and > > > > > > > for > > > > > > > stable branch > > > > > > > > > > > > > > Hi > > > > > > > > > > > > > > Please note that any upgrade script introduced to the master > > > > > > > branch > > > > > > > should > > > > > > > have the 03_04 prefix. > > > > > > > If this script is resolving a blocker/exception BZ it should be > > > > > > > ported > > > > > > > to > > > > > > > the > > > > > > > ovirt-engine-3.3 branch with a 03_03 prefix !!! > > > > > > > > > > > > > > We have encountered some patches that broke the upgrade from > > > > > > > ovirt-engine-3.3 > > > > > > > to master as a result of > > > > > > > > > > > > > > 1) naming new upgrade scripts in master branch with 03_03 prefix > > > > > > > 2) naming new upgrade scripts in ovirt-engine-3.3 stable branch > > > > > > > with > > > > > > > 03_04 > > > > > > > prefix > > > > > > > > > > > > > > I am available for any question and asking you to add me to any > > > > > > > DB > > > > > > > related > > > > > > > script as a reviewer even if I +2 the master patch and you just > > > > > > > back-port > > > > > > > it > > > > > > > to ovirt-engine-3.3. > > > > > > > It may save us a lot of noise. > > > > > > > > > > > > > > Thanks for your cooperation > > > > > > > > > > > > > > Eli > > > > > > > _______________________________________________ > > > > > > > Engine-devel mailing list > > > > > > > Engine-devel at ovirt.org > > > > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > Engine-devel mailing list > > > > > Engine-devel at ovirt.org > > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > > > > > > > > > > > > > > > > > > > From iheim at redhat.com Sun Oct 27 16:43:14 2013 From: iheim at redhat.com (Itamar Heim) Date: Sun, 27 Oct 2013 18:43:14 +0200 Subject: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch In-Reply-To: <530488007.14165467.1382871443842.JavaMail.root@redhat.com> References: <1963655862.13395521.1382629761676.JavaMail.root@redhat.com> <1674499877.10075467.1382631184300.JavaMail.root@redhat.com> <1352440551.13328035.1382631611776.JavaMail.root@redhat.com> <1683839335.10116594.1382634747025.JavaMail.root@redhat.com> <1578330426.13390301.1382636566232.JavaMail.root@redhat.com> <157758143.12015814.1382870973276.JavaMail.root@redhat.com> <530488007.14165467.1382871443842.JavaMail.root@redhat.com> Message-ID: <526D42A2.3000704@redhat.com> On 10/27/2013 12:57 PM, Eyal Edri wrote: > 1. job was added AFTER failure was introduced (flow from 3.3 -> master). > 2. job will now fail on every patch until issue is fixed. already proven itself today... From sbonazzo at redhat.com Mon Oct 28 14:16:13 2013 From: sbonazzo at redhat.com (Sandro Bonazzola) Date: Mon, 28 Oct 2013 15:16:13 +0100 Subject: [Engine-devel] simulating > 100 hypervisors Message-ID: <526E71AD.2040407@redhat.com> Hi, I need to do some testing on log-collector for solving Bug 1014379 - When calling the API the LC does not provide a max value, limiting the returned results to 100 by default. How may I have the engine listing more than 100 hypervisors? (I don't really need them to be up, just need them to be listed) -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com From iheim at redhat.com Mon Oct 28 14:52:01 2013 From: iheim at redhat.com (Itamar Heim) Date: Mon, 28 Oct 2013 16:52:01 +0200 Subject: [Engine-devel] simulating > 100 hypervisors In-Reply-To: <526E71AD.2040407@redhat.com> References: <526E71AD.2040407@redhat.com> Message-ID: <526E7A11.2050908@redhat.com> On 10/28/2013 04:16 PM, Sandro Bonazzola wrote: > Hi, > I need to do some testing on log-collector for solving > Bug 1014379 - When calling the API the LC does not provide a max value, limiting the returned results to 100 by default. > How may I have the engine listing more than 100 hypervisors? (I don't really need them to be up, just need them to be listed) > > just add 101 hosts to the engine? From sbonazzo at redhat.com Mon Oct 28 14:59:40 2013 From: sbonazzo at redhat.com (Sandro Bonazzola) Date: Mon, 28 Oct 2013 15:59:40 +0100 Subject: [Engine-devel] simulating > 100 hypervisors In-Reply-To: <526E7A11.2050908@redhat.com> References: <526E71AD.2040407@redhat.com> <526E7A11.2050908@redhat.com> Message-ID: <526E7BDC.5030801@redhat.com> Il 28/10/2013 15:52, Itamar Heim ha scritto: > On 10/28/2013 04:16 PM, Sandro Bonazzola wrote: >> Hi, >> I need to do some testing on log-collector for solving >> Bug 1014379 - When calling the API the LC does not provide a max value, limiting the returned results to 100 by default. >> How may I have the engine listing more than 100 hypervisors? (I don't really need them to be up, just need them to be listed) >> >> > > just add 101 hosts to the engine? Yes. But can't do that using the UI: it fails with "Error while executing action: Cannot add Host. Connecting to host via SSH has failed, verify that the host is reachable (IP address, routable address etc.) You may refer to the engine.log file for further details." So I need a way for bypassing it. Is it enough to add them somewhere in the DB? -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com From iheim at redhat.com Mon Oct 28 15:02:46 2013 From: iheim at redhat.com (Itamar Heim) Date: Mon, 28 Oct 2013 17:02:46 +0200 Subject: [Engine-devel] simulating > 100 hypervisors In-Reply-To: <526E7BDC.5030801@redhat.com> References: <526E71AD.2040407@redhat.com> <526E7A11.2050908@redhat.com> <526E7BDC.5030801@redhat.com> Message-ID: <526E7C96.70606@redhat.com> On 10/28/2013 04:59 PM, Sandro Bonazzola wrote: > Il 28/10/2013 15:52, Itamar Heim ha scritto: >> On 10/28/2013 04:16 PM, Sandro Bonazzola wrote: >>> Hi, >>> I need to do some testing on log-collector for solving >>> Bug 1014379 - When calling the API the LC does not provide a max value, limiting the returned results to 100 by default. >>> How may I have the engine listing more than 100 hypervisors? (I don't really need them to be up, just need them to be listed) >>> >>> >> >> just add 101 hosts to the engine? > > Yes. But can't do that using the UI: it fails with "Error while executing action: Cannot add Host. Connecting to host via SSH has failed, verify that > the host is reachable (IP address, routable address etc.) You may refer to the engine.log file for further details." > > So I need a way for bypassing it. Is it enough to add them somewhere in the DB? > > try setting the config InstallVds to false. From ofrenkel at redhat.com Mon Oct 28 15:09:18 2013 From: ofrenkel at redhat.com (Omer Frenkel) Date: Mon, 28 Oct 2013 11:09:18 -0400 (EDT) Subject: [Engine-devel] simulating > 100 hypervisors In-Reply-To: <526E71AD.2040407@redhat.com> References: <526E71AD.2040407@redhat.com> Message-ID: <260265961.12622661.1382972958089.JavaMail.root@redhat.com> ----- Original Message ----- > From: "Sandro Bonazzola" > To: "engine-devel" > Sent: Monday, October 28, 2013 4:16:13 PM > Subject: [Engine-devel] simulating > 100 hypervisors > > Hi, > I need to do some testing on log-collector for solving > Bug 1014379 - When calling the API the LC does not provide a max value, > limiting the returned results to 100 by default. > How may I have the engine listing more than 100 hypervisors? (I don't really > need them to be up, just need them to be listed) > check this out: http://www.ovirt.org/VDSM_Fake > > -- > Sandro Bonazzola > Better technology. Faster innovation. Powered by community collaboration. > See how it works at redhat.com > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > From jhernand at redhat.com Mon Oct 28 15:29:11 2013 From: jhernand at redhat.com (Juan Hernandez) Date: Mon, 28 Oct 2013 16:29:11 +0100 Subject: [Engine-devel] simulating > 100 hypervisors In-Reply-To: <526E71AD.2040407@redhat.com> References: <526E71AD.2040407@redhat.com> Message-ID: <526E82C7.2000604@redhat.com> On 10/28/2013 03:16 PM, Sandro Bonazzola wrote: > Hi, > I need to do some testing on log-collector for solving > Bug 1014379 - When calling the API the LC does not provide a max value, limiting the returned results to 100 by default. > How may I have the engine listing more than 100 hypervisors? (I don't really need them to be up, just need them to be listed) > > I have used the attached insert_many_hosts function in the past, you may find it useful. However the InsertVds function that it uses is currently broken, so it wont work without the attached patch (the InsertVds function isn't currently used, should probably be removed). -- Direcci?n Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3?D, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid ? C.I.F. B82657941 - Red Hat S.L. -------------- next part -------------- A non-text attachment was scrubbed... Name: insert_many_hosts.sql Type: text/x-sql Size: 1535 bytes Desc: not available URL: -------------- next part -------------- diff --git a/packaging/dbscripts/vds_sp.sql b/packaging/dbscripts/vds_sp.sql index fbf9aea..c37c5a7 100644 --- a/packaging/dbscripts/vds_sp.sql +++ b/packaging/dbscripts/vds_sp.sql @@ -718,15 +718,15 @@ RETURNS VOID BEGIN BEGIN - INSERT INTO vds_static(vds_id,host_name, free_text_comment, ip, vds_unique_id, port, ds_group_id, vds_name, server_SSL_enabled, + INSERT INTO vds_static(vds_id,host_name, free_text_comment, ip, vds_unique_id, port, vds_group_id, vds_name, server_SSL_enabled, vds_type,vds_strength,pm_type,pm_user,pm_password, pm_port, pm_options, pm_enabled, pm_secondary_ip, pm_secondary_type, pm_secondary_user, pm_secondary_password, pm_secondary_port, pm_secondary_options, pm_secondary_concurrent, pm_proxy_preferences, vds_spm_priority, console_address, ssh_port, ssh_username) VALUES(v_vds_id,v_host_name, v_free_text_comment, v_ip, v_vds_unique_id, v_port, v_vds_group_id, v_vds_name, v_server_SSL_enabled, v_vds_type, v_vds_strength,v_pm_type,v_pm_user,v_pm_password,v_pm_port, v_pm_options, v_pm_enabled, - pm_secondary_ip, pm_secondary_type, pm_secondary_user, - pm_secondary_password, pm_secondary_port, pm_secondary_options, pm_secondary_concurrent,v_pm_proxy_preferences, + v_pm_secondary_ip, v_pm_secondary_type, v_pm_secondary_user, + v_pm_secondary_password, v_pm_secondary_port, v_pm_secondary_options, v_pm_secondary_concurrent,v_pm_proxy_preferences, v_vds_spm_priority, v_console_address, v_ssh_port, v_ssh_username); INSERT INTO vds_dynamic(vds_id, status) VALUES(v_vds_id, 0); From sbonazzo at redhat.com Mon Oct 28 15:38:44 2013 From: sbonazzo at redhat.com (Sandro Bonazzola) Date: Mon, 28 Oct 2013 16:38:44 +0100 Subject: [Engine-devel] simulating > 100 hypervisors In-Reply-To: <526E82C7.2000604@redhat.com> References: <526E71AD.2040407@redhat.com> <526E82C7.2000604@redhat.com> Message-ID: <526E8504.3000001@redhat.com> Il 28/10/2013 16:29, Juan Hernandez ha scritto: > On 10/28/2013 03:16 PM, Sandro Bonazzola wrote: >> Hi, >> I need to do some testing on log-collector for solving >> Bug 1014379 - When calling the API the LC does not provide a max value, limiting the returned results to 100 by default. >> How may I have the engine listing more than 100 hypervisors? (I don't really need them to be up, just need them to be listed) >> >> > > I have used the attached insert_many_hosts function in the past, you may > find it useful. However the InsertVds function that it uses is currently > broken, so it wont work without the attached patch (the InsertVds > function isn't currently used, should probably be removed). > it fails saying ds_group_id column doesn't exist in vds_static. -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com From jhernand at redhat.com Mon Oct 28 15:39:59 2013 From: jhernand at redhat.com (Juan Hernandez) Date: Mon, 28 Oct 2013 16:39:59 +0100 Subject: [Engine-devel] simulating > 100 hypervisors In-Reply-To: <526E8504.3000001@redhat.com> References: <526E71AD.2040407@redhat.com> <526E82C7.2000604@redhat.com> <526E8504.3000001@redhat.com> Message-ID: <526E854F.40301@redhat.com> On 10/28/2013 04:38 PM, Sandro Bonazzola wrote: > Il 28/10/2013 16:29, Juan Hernandez ha scritto: >> On 10/28/2013 03:16 PM, Sandro Bonazzola wrote: >>> Hi, >>> I need to do some testing on log-collector for solving >>> Bug 1014379 - When calling the API the LC does not provide a max value, limiting the returned results to 100 by default. >>> How may I have the engine listing more than 100 hypervisors? (I don't really need them to be up, just need them to be listed) >>> >>> >> >> I have used the attached insert_many_hosts function in the past, you may >> find it useful. However the InsertVds function that it uses is currently >> broken, so it wont work without the attached patch (the InsertVds >> function isn't currently used, should probably be removed). >> > > it fails saying ds_group_id column doesn't exist in vds_static. > > Yes, that is one of the things currently broken in the InsertVds function. The name of the column is "vds_group_id" not "ds_group_id". The patch that I attached fixes that. -- Direcci?n Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3?D, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid ? C.I.F. B82657941 - Red Hat S.L. From kmayilsa at redhat.com Tue Oct 29 11:24:05 2013 From: kmayilsa at redhat.com (Kanagaraj) Date: Tue, 29 Oct 2013 16:54:05 +0530 Subject: [Engine-devel] Usage of 'Comment' field in Cluster Message-ID: <526F9AD5.9030704@redhat.com> Hi All, I see a new field in Cluster called 'Comment'. It is available in 'New/Edit Cluster' dialog as well as in the 'Clusters Tab'. The Comment column in the clusters table shows a 'note' icon when some comment is set for a cluster. I just want to understand the right usage of this field. Can someone please clarify this? Thanks, Kanagaraj From mkolesni at redhat.com Tue Oct 29 11:52:16 2013 From: mkolesni at redhat.com (Mike Kolesnik) Date: Tue, 29 Oct 2013 07:52:16 -0400 (EDT) Subject: [Engine-devel] Usage of 'Comment' field in Cluster In-Reply-To: <526F9AD5.9030704@redhat.com> References: <526F9AD5.9030704@redhat.com> Message-ID: <176152986.17263730.1383047536445.JavaMail.root@redhat.com> ----- Original Message ----- > Hi All, > > I see a new field in Cluster called 'Comment'. It is available in > 'New/Edit Cluster' dialog as well as in the 'Clusters Tab'. The Comment > column in the clusters table shows a 'note' icon when some comment is > set for a cluster. I just want to understand the right usage of this field. > > Can someone please clarify this? +1 Also please explain the difference between "comment" and "description" fields since they both appear there, seemingly with same meaning..? > > Thanks, > Kanagaraj > > From gchaplik at redhat.com Tue Oct 29 12:07:05 2013 From: gchaplik at redhat.com (Gilad Chaplik) Date: Tue, 29 Oct 2013 08:07:05 -0400 (EDT) Subject: [Engine-devel] Usage of 'Comment' field in Cluster In-Reply-To: <176152986.17263730.1383047536445.JavaMail.root@redhat.com> References: <526F9AD5.9030704@redhat.com> <176152986.17263730.1383047536445.JavaMail.root@redhat.com> Message-ID: <1496610672.17273437.1383048425704.JavaMail.root@redhat.com> ----- Original Message ----- > From: "Mike Kolesnik" > To: "engine-devel" > Sent: Tuesday, October 29, 2013 1:52:16 PM > Subject: Re: [Engine-devel] Usage of 'Comment' field in Cluster > > > ----- Original Message ----- > > Hi All, > > > > I see a new field in Cluster called 'Comment'. It is available in > > 'New/Edit Cluster' dialog as well as in the 'Clusters Tab'. The Comment > > column in the clusters table shows a 'note' icon when some comment is > > set for a cluster. I just want to understand the right usage of this field. > > > > Can someone please clarify this? > > +1 > > Also please explain the difference between "comment" and "description" fields > since they both appear there, seemingly with same meaning..? > The comment field is a free text area where you can put a temporary notion for an entity. The description is less likely to change (explains what this entity is for), whereas in comment field you can add something like: "Please don't power off the VM without talking to XYZ" or "The DC is under maintenance till XYZ". Thanks, Gilad. > > > > Thanks, > > Kanagaraj > > > > > _______________________________________________ > Engine-devel mailing list > Engine-devel at ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > From mpastern at redhat.com Wed Oct 30 09:46:57 2013 From: mpastern at redhat.com (Michael Pasternak) Date: Wed, 30 Oct 2013 11:46:57 +0200 Subject: [Engine-devel] ovirt-engine-sdk-python 3.3.0.8-1 released In-Reply-To: <52551F40.7040908@redhat.com> References: <52551F40.7040908@redhat.com> Message-ID: <5270D591.3070604@redhat.com> - to host.install() added ssh related arguments - to template added virtio_scsi.enabled - to vm added virtio_scsi.enabled - added ability to attach a disk snapshot to the virtual machine - to File class added 'content' field - Payload class now reuses Files instead of own PayloadFile collection more details can be found at [1]. [1] http://www.ovirt.org/Python-sdk-changelog -- Michael Pasternak RedHat, ENG-Virtualization R&D From mpastern at redhat.com Wed Oct 30 10:29:01 2013 From: mpastern at redhat.com (Michael Pasternak) Date: Wed, 30 Oct 2013 12:29:01 +0200 Subject: [Engine-devel] ovirt-engine-sdk-java 1.0.0.19-1 released In-Reply-To: <52551CBB.4010809@redhat.com> References: <52551CBB.4010809@redhat.com> Message-ID: <5270DF6D.80800@redhat.com> - to host.install() added ssh related arguments - to template added virtio_scsi.enabled - to vm added virtio_scsi.enabled - added ability to attach a disk snapshot to the virtual machine - to File class added 'content' field - Payload class now reuses Files instead of own PayloadFile collection more details can be found at [1]. [1] http://www.ovirt.org/Java-sdk-changelog -- Michael Pasternak RedHat, ENG-Virtualization R&D From obasan at redhat.com Wed Oct 30 13:50:51 2013 From: obasan at redhat.com (Ohad Basan) Date: Wed, 30 Oct 2013 09:50:51 -0400 (EDT) Subject: [Engine-devel] jenkins maintenance Message-ID: <48357283.15136431.1383141051209.JavaMail.root@redhat.com> Hello Jenkins is going down for maintenance for a few minutes. Thanks, Ohad From sbonazzo at redhat.com Thu Oct 31 07:49:28 2013 From: sbonazzo at redhat.com (Sandro Bonazzola) Date: Thu, 31 Oct 2013 08:49:28 +0100 Subject: [Engine-devel] daily oVirt 3.3.1 blocker status Message-ID: <52720B88.9080001@redhat.com> Hi, The following blockers are still not fixed: VDSM: Bug 1022961 - Running a VM from a gluster domain uses mount instead of gluster URI Bug 1022975 - [vdsm] storage domain upgrade fails with attributeError Federico, Eduardo, can you provide an ETA for those? The following patches are targeted 3.3 and needs to be reviewed: http://gerrit.ovirt.org/#/q/branch:%255Eovirt*-3.3.*,n,z vdsm: support VIR_MIGRATE_ABORT_ON_ERROR Peter V. Saveliev vdsm ovirt-3.3 Oct 27 hsm: fix isoprefix KeyError for inactive domains Federico Simoncelli vdsm ovirt-3.3 Oct 20 +1 Read pool metadata once in StoragePool.getInfo() Federico Simoncelli vdsm ovirt-3.3 Oct 15 Make hsm.getVolumesList() pool independent. Federico Simoncelli vdsm ovirt-3.3 Oct 15 Adding [start|stop]MonitoringDomain(). Federico Simoncelli vdsm ovirt-3.3 Oct 15 stats: return domain lockspace status Federico Simoncelli vdsm ovirt-3.3 Oct 15 Make getRepoStats() a hsm method. Federico Simoncelli vdsm ovirt-3.3 Oct 15 Fix getStorageDomainInfo() logic. Federico Simoncelli vdsm ovirt-3.3 Oct 15 vm: add the transient disk support Federico Simoncelli vdsm ovirt-3.3 Oct 15 please review them and merge ASAP the patches meant to be in 3.3.1. I'm not aware of other blockers. If you're aware of any other blocker, please add it to the tracker bug (Bug 1019391 - Tracker: oVirt 3.3.1 release) -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com From eedri at redhat.com Thu Oct 31 08:10:09 2013 From: eedri at redhat.com (Eyal Edri) Date: Thu, 31 Oct 2013 04:10:09 -0400 (EDT) Subject: [Engine-devel] [ATT] jenkins.ovirt.org is down In-Reply-To: <215988154.16933064.1383206921636.JavaMail.root@redhat.com> Message-ID: <1416238117.16933429.1383207009268.JavaMail.root@redhat.com> fyi, Jenkins server is experiencing problems, and is currently down. infra team is investigating the problems and will update once server is back up. Eyal. oVirt infra. From sbonazzo at redhat.com Thu Oct 31 15:20:43 2013 From: sbonazzo at redhat.com (Sandro Bonazzola) Date: Thu, 31 Oct 2013 16:20:43 +0100 Subject: [Engine-devel] Fwd: [Users] oVirt quality team proposal In-Reply-To: <5272531B.7040703@redhat.com> References: <5272531B.7040703@redhat.com> Message-ID: <5272754B.4090209@redhat.com> Hi, it seems that the proposal has been welcomed in users list, so I'm forwarding this to devel and infra for approval. Maybe we can benefit of ovirt-qa list for 3.3.1 testing before releasing it next week. -------- Messaggio originale -------- Oggetto: [Users] oVirt quality team proposal Data: Thu, 31 Oct 2013 13:54:51 +0100 Mittente: Sandro Bonazzola A: users Hi, I would like to propose to the community to join creating a group for testing oVirt releases and oVirt bug fixes. I suggest to create a ovirt-qe mailing list and set that as default QE assignee for oVirt bugs. The list may be used for coordinating testing efforts, to be notified about new ovirt bugs, to plan test days, propose test cases, discussing about jenkins jobs implementation and so on. Forming just a small group of people testing milestones release will also help in having better release testing. What do you think about this? -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com _______________________________________________ Users mailing list Users at ovirt.org http://lists.ovirt.org/mailman/listinfo/users From dneary at redhat.com Thu Oct 31 15:58:21 2013 From: dneary at redhat.com (Dave Neary) Date: Thu, 31 Oct 2013 16:58:21 +0100 Subject: [Engine-devel] Fwd: [Users] oVirt quality team proposal In-Reply-To: <5272754B.4090209@redhat.com> References: <5272531B.7040703@redhat.com> <5272754B.4090209@redhat.com> Message-ID: <52727E1D.9010602@redhat.com> Hi Sandro, I suggested keeping activity on users during bootstrapping rather than creating a new list - do you think that's a bad idea? Thanks! Dave. On 10/31/2013 04:20 PM, Sandro Bonazzola wrote: > Hi, > it seems that the proposal has been welcomed in users list, > so I'm forwarding this to devel and infra for approval. > Maybe we can benefit of ovirt-qa list for 3.3.1 testing before releasing it next week. > > > -------- Messaggio originale -------- > Oggetto: [Users] oVirt quality team proposal > Data: Thu, 31 Oct 2013 13:54:51 +0100 > Mittente: Sandro Bonazzola > A: users > > Hi, > I would like to propose to the community to join creating a group for testing oVirt > releases and oVirt bug fixes. I suggest to create a ovirt-qe mailing list and set > that as default QE assignee for oVirt bugs. > The list may be used for coordinating testing efforts, to be notified about new ovirt bugs, > to plan test days, propose test cases, discussing about jenkins jobs implementation and so on. > Forming just a small group of people testing milestones release will also help in having better release testing. > What do you think about this? > -- Dave Neary - Community Action and Impact Open Source and Standards, Red Hat - http://community.redhat.com Ph: +33 9 50 71 55 62 / Cell: +33 6 77 01 92 13 From sbonazzo at redhat.com Thu Oct 31 16:13:13 2013 From: sbonazzo at redhat.com (Sandro Bonazzola) Date: Thu, 31 Oct 2013 17:13:13 +0100 Subject: [Engine-devel] Fwd: [Users] oVirt quality team proposal In-Reply-To: <52727E1D.9010602@redhat.com> References: <5272531B.7040703@redhat.com> <5272754B.4090209@redhat.com> <52727E1D.9010602@redhat.com> Message-ID: <52728199.2050703@redhat.com> Il 31/10/2013 16:58, Dave Neary ha scritto: > Hi Sandro, > > I suggested keeping activity on users during bootstrapping rather than > creating a new list - do you think that's a bad idea? No it's fine for me. > > Thanks! > Dave. > > On 10/31/2013 04:20 PM, Sandro Bonazzola wrote: >> Hi, >> it seems that the proposal has been welcomed in users list, >> so I'm forwarding this to devel and infra for approval. >> Maybe we can benefit of ovirt-qa list for 3.3.1 testing before releasing it next week. >> >> >> -------- Messaggio originale -------- >> Oggetto: [Users] oVirt quality team proposal >> Data: Thu, 31 Oct 2013 13:54:51 +0100 >> Mittente: Sandro Bonazzola >> A: users >> >> Hi, >> I would like to propose to the community to join creating a group for testing oVirt >> releases and oVirt bug fixes. I suggest to create a ovirt-qe mailing list and set >> that as default QE assignee for oVirt bugs. >> The list may be used for coordinating testing efforts, to be notified about new ovirt bugs, >> to plan test days, propose test cases, discussing about jenkins jobs implementation and so on. >> Forming just a small group of people testing milestones release will also help in having better release testing. >> What do you think about this? >> > -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com From alonbl at redhat.com Thu Oct 31 22:56:29 2013 From: alonbl at redhat.com (Alon Bar-Lev) Date: Thu, 31 Oct 2013 18:56:29 -0400 (EDT) Subject: [Engine-devel] [ATN] ovirt-engine URIs rework In-Reply-To: <1681337895.11390844.1383259771041.JavaMail.root@redhat.com> Message-ID: <543755994.11391455.1383260189824.JavaMail.root@redhat.com> Hello, Please be aware that the following[1] was merged. Many thanks to Alexander Wels and Vojtech Szocs. --- MISSION Advanced farther into well behaved web application, install as much as we can into /ovirt-engine URI name space, removing / abuse. Synchronize between jboss and apache URI layouts so that development setup will be as similar as possible to production. NEW LAYOUT -+- / (root.war) Redirect: ovirt-engine | +--- api/ (api.war) | +-+- ovirt-engine/ (welcome.war) [NEW] | | | +--- docs/ (docs.war) [NEW] | | | +-+- services(services.war) [NEW] | | | | | +-+- attachment/ | | | | | +-+- files/ | | | | | +--- get-session-user | | | | | +--- health | | | | | +--- host-register | | | | | +--- pki-resource | | | | | +--- reports-redirect | | | +--- userportal/ (userportal.war) | | | +--- webadmin/ (webadmin.war) | +-+- OvirtEngineWeb/ | | | +--- HealthStatus.aspx Forward: ovirt-engine/services/health | | | +--- HealthStatus/* Forward: ovirt-engine/services/health | | | +--- VdsAutoRegistration.aspx Forward: ovirt-engine/services/host-register | | | +--- register Forward: ovirt-engine/services/host-register | +-+- RHEVManagerWeb/ | | | +--- VdsAutoRegistration.aspx Forward: ovirt-engine/services/host-register | +--- ca.crt Forward: ovirt-engine/serivces/pki-resource | +--- engine.ssh.key.txt Forward: ovirt-engine/serivces/pki-resource | +--- rhevm.ssh.key.txt Forward: ovirt-engine/serivces/pki-resource LAYOUT NOTES HealthStatus servlet is used by python using urllib2 which supports redirect, it does not accept extra path, so redirect into servlet at services is safe, but forward was installed for now. Registration uses python httplib which does not support redirect, so these uris are forwarded into servlets at services. /ValidateSession is gone as reports can be modified to support the new servlet name at /services/get-session-user. GWT applications have human usable URIs, no duplication no object names. [1] http://gerrit.ovirt.org/#/c/20473/