[Engine-devel] Copy reviewer scores on trivial rebase/commit msg changes

[Adam Litke]

On 18/01/14 01:48 +0200, Itamar Heim wrote:
>I'd like to enable these - comments welcome:
>
>1. label.Label-Name.copyAllScoresOnTrivialRebase
>
>If true, all scores for the label are copied forward when a new patch 
>set is uploaded that is a trivial rebase. A new patch set is 
>considered as trivial rebase if the commit message is the same as in 
>the previous patch set and if it has the same code delta as the 
>previous patch set. This is the case if the change was rebased onto a 
>different parent. This can be used to enable sticky approvals, 
>reducing turn-around for trivial rebases prior to submitting a change. 
>Defaults to false.
>
>
>2. label.Label-Name.copyAllScoresIfNoCodeChange
>
>If true, all scores for the label are copied forward when a new patch 
>set is uploaded that has the same parent commit as the previous patch 
>set and the same code delta as the previous patch set. This means only 
>the commit message is different. This can be used to enable sticky 
>approvals on labels that only depend on the code, reducing turn-around 
>if only the commit message is changed prior to submitting a change. 
>Defaults to false.

I am a bit late to the party but +1 from me for trying both.  I guess
it will be quite rare that something bad happens here.  So unlikely,
that the time saved on all the previous patches will far offset the
lost time for fixing the corner cases.