[Engine-devel] REST API - where did bookmarks go?

Mon Mar 24 16:32:25 UTC 2014

----- Original Message -----
> From: "Gilad Chaplik" <gchaplik at redhat.com>
> To: "Einav Cohen" <ecohen at redhat.com>
> Cc: "Juan Hernandez" <jhernand at redhat.com>, "engine-devel" <engine-devel at ovirt.org>
> Sent: Monday, March 24, 2014 4:58:01 PM
> Subject: Re: [Engine-devel] REST API - where did bookmarks go?
> 
> So iiuc, we are going to develop a known obsolete feature :-) ?
> Can we break it in 4.0?

We should consider whether bookmarks should be persisted/managed through Engine, or whether they should be handled by clients instead (and Engine wouldn't care about them). Sounds more like design decision to me.

> 
> Thanks,
> Gilad.
> 
> 
> ----- Original Message -----
> > From: "Einav Cohen" <ecohen at redhat.com>
> > To: "Gilad Chaplik" <gchaplik at redhat.com>
> > Cc: "Juan Hernandez" <jhernand at redhat.com>, "engine-devel"
> > <engine-devel at ovirt.org>
> > Sent: Monday, March 24, 2014 5:55:20 PM
> > Subject: Re: [Engine-devel] REST API - where did bookmarks go?
> > 
> > > ----- Original Message -----
> > > From: "Gilad Chaplik" <gchaplik at redhat.com>
> > > Sent: Monday, March 24, 2014 11:46:04 AM
> > > 
> > > Hi Einav,
> > > 
> > > I agree with every word. also thought about it, that's why I wrote a
> > > possible
> > > solution.
> > > Not sure we need to design the RESTful API according to UI's needs (add
> > > features in this case).
> > 
> > the REST API should not be designed according to UI's needs - but the REST
> > API
> > should allow to retrieve all engine-managed business entities. Bookmarks is
> > one
> > of them.
> > There is a chance that creating Bookmarks as an engine-managed
> > business-entity
> > in the first place was a bad design decision, but they are there now, as
> > managed
> > business-entities, and as such - should be exposed via the REST API.
> > 
> > > 
> > > 
> > > 
> > > Thanks,
> > > Gilad.
> > > 
> > > 
> > > ----- Original Message -----
> > > > From: "Einav Cohen" <ecohen at redhat.com>
> > > > To: "Gilad Chaplik" <gchaplik at redhat.com>
> > > > Cc: "Vojtech Szocs" <vszocs at redhat.com>, "Juan Hernandez"
> > > > <jhernand at redhat.com>, "engine-devel"
> > > > <engine-devel at ovirt.org>
> > > > Sent: Monday, March 24, 2014 5:38:33 PM
> > > > Subject: Re: [Engine-devel] REST API - where did bookmarks go?
> > > > 
> > > > Hi Gilad, "client-side Bookmarks" is a great suggestion, however it
> > > > is a (non-related) RFE, which may be implemented instead of, or in
> > > > addition to, the already-existing server-side Bookmarks.
> > > > 
> > > > [keep in mind that server-side bookmarks allow you to add bookmarks
> > > > that may be used by other users; it is also a feature that exists
> > > > for a long time in oVirt, so need to think a little bit before
> > > > removing it]
> > > > 
> > > > As long as we have server-side Bookmarks (i.e. as long as Bookmark
> > > > is an engine-managed business entity), they need to be exposed via
> > > > the REST API.
> > > > 
> > > > ----
> > > > Thanks,
> > > > Einav
> > > > 
> > > > ----- Original Message -----
> > > > > From: "Gilad Chaplik" <gchaplik at redhat.com>
> > > > > To: "Vojtech Szocs" <vszocs at redhat.com>
> > > > > Cc: "Juan Hernandez" <jhernand at redhat.com>, "engine-devel"
> > > > > <engine-devel at ovirt.org>
> > > > > Sent: Monday, March 24, 2014 11:28:02 AM
> > > > > Subject: Re: [Engine-devel] REST API - where did bookmarks go?
> > > > > 
> > > > > Hi Guys,
> > > > > 
> > > > > Why we need bookmarks in API? a single liner that points out to
> > > > > another
> > > > > single liner?
> > > > > I know that we need it for 'UI over REST' migration, but...
> > > > > IMHO bookmarks should be saved in client side, maybe inject the
> > > > > search
> > > > > string
> > > > > in the url, and get 'real' bookmarks/favorites... I don't know :-)
> > > > > 
> > > > > Thanks,
> > > > > Gilad.
> > > > > 
> > > > > ----- Original Message -----
> > > > > > From: "Vojtech Szocs" <vszocs at redhat.com>
> > > > > > To: "Juan Hernandez" <jhernand at redhat.com>
> > > > > > Cc: "engine-devel" <engine-devel at ovirt.org>
> > > > > > Sent: Wednesday, March 12, 2014 1:27:19 PM
> > > > > > Subject: Re: [Engine-devel] REST API - where did bookmarks go?
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > ----- Original Message -----
> > > > > > > From: "Juan Hernandez" <jhernand at redhat.com>
> > > > > > > To: "Vojtech Szocs" <vszocs at redhat.com>, "engine-devel"
> > > > > > > <engine-devel at ovirt.org>
> > > > > > > Cc: "Einav Cohen" <ecohen at redhat.com>
> > > > > > > Sent: Tuesday, March 11, 2014 7:22:35 PM
> > > > > > > Subject: Re: REST API - where did bookmarks go?
> > > > > > > 
> > > > > > > On 03/11/2014 07:15 PM, Vojtech Szocs wrote:
> > > > > > > > Hi guys,
> > > > > > > > 
> > > > > > > > as part of prototyping new JavaScript binding for oVirt REST
> > > > > > > > API,
> > > > > > > > we chose a couple of business entities (resources) to
> > > > > > > > experiment
> > > > > > > > with.
> > > > > > > > 
> > > > > > > > I just realized that requesting /ovirt-engine/api doesn't
> > > > > > > > return
> > > > > > > > any information about bookmarks. Where did bookmarks go? Is it
> > > > > > > > possible to manage bookmarks through REST API?
> > > > > > > > 
> > > > > > > > Note: WebAdmin currently gets bookmarks through GWT RPC by
> > > > > > > > calling
> > > > > > > > GetAllBookmarksQuery. Bookmark seems like proper backend
> > > > > > > > business
> > > > > > > > entity (with DAO and everything) so it should be exposed also
> > > > > > > > via
> > > > > > > > REST API.. or am I missing something?
> > > > > > > > 
> > > > > > > > Thanks,
> > > > > > > > Vojtech
> > > > > > > > 
> > > > > > > 
> > > > > > > The didn't go anywhere, just never existed in the API. Please
> > > > > > > open
> > > > > > > a
> > > > > > > RFE
> > > > > > > to add them.
> > > > > > 
> > > > > > Thanks, Juan. The RFE is here:
> > > > > > 
> > > > > >   https://bugzilla.redhat.com/1075556
> > > > > > 
> > > > > > > 
> > > > > > > --
> > > > > > > Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3,
> > > > > > > planta
> > > > > > > 3ºD, 28016 Madrid, Spain
> > > > > > > Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red
> > > > > > > Hat
> > > > > > > S.L.
> > > > > > > 
> > > > > > _______________________________________________
> > > > > > Engine-devel mailing list
> > > > > > Engine-devel at ovirt.org
> > > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > > >
> > > > > _______________________________________________
> > > > > Engine-devel mailing list
> > > > > Engine-devel at ovirt.org
> > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > >
> > > > 
> > > _______________________________________________
> > > Engine-devel mailing list
> > > Engine-devel at ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > 
> > > 
> > > 
> > 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 