<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 03/07/2013 07:25 PM, Vinzenz
Feenstra wrote:<br>
</div>
<blockquote cite="mid:51387942.606@redhat.com" type="cite">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
Please find the prettier version on the wiki: <a
moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://www.ovirt.org/Proposal_VDSM_-_Engine_Data_Statistics_Retrieval">http://www.ovirt.org/Proposal_VDSM_-_Engine_Data_Statistics_Retrieval</a><br>
<br>
<h1 id="firstHeading" class="firstHeading page-header"><span
dir="auto">Proposal VDSM - Engine Data Statistics Retrieval</span></h1>
<h2><span class="mw-headline"
id="VDSM_.3C.3D.3E_Engine_data_retrieval_optimization">VDSM
<=> Engine data retrieval optimization </span></h2>
<h3> <span class="mw-headline" id="Motivation:"> Motivation: </span></h3>
<p>Currently the RHEVM engine is polling the a lot of data from
VDSM every 15 seconds. This should be optimized and the amount
of data requested should be more specific. </p>
</blockquote>
If the data size really matters, we could also consider to pack the
information into binary. I am not sure if it's suitable in the
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
transmission of XMLRPC.<br>
<blockquote cite="mid:51387942.606@redhat.com" type="cite">
<p>For each VM the data currently contains much more information
than actually needed which blows up the size of the XML content
quite big. We could optimize this by splitting the reply on the
getVmStats based on the request of the engine into sections. For
this reason Omer Frenkel and me have split up the data into
parts based on their usage. </p>
<p>This data can and usually does change during the lifetime of
the VM. </p>
<h4> <span class="mw-headline" id="Rarely_Changed:"> Rarely
Changed: </span></h4>
<p>This data is change not very frequent and it should be enough
to update this only once in a while. Most commonly this data
changes after changes made in the UI or after a migration of the
VM to another Host. </p>
<pre> <b>Status</b> = Running
<b>acpiEnable</b> = true
<b>vmType</b> = kvm
<b>guestName</b> = W864GUESTAGENTT
<b>displayType</b> = qxl
<b>guestOs</b> = Win 8
<b>kvmEnable</b> = true # <i><b>this should be constant and never changed</b></i></pre>
</blockquote>
Then it should be removed from vm stats. In my opinion, any
information belongs to vm's static configuration, it shouldn't be
included in vm stats. For the fields above, except 'Status', engine
can get the information without querying the vdsm host. It could not
be changed by vdsm itself, right?<br>
<blockquote cite="mid:51387942.606@redhat.com" type="cite">
<pre>
<b>pauseCode</b> = NOERR
<b>monitorResponse</b> = 0
<b>session</b> = Locked # unused
<b>netIfaces</b> = [{'name': 'Realtek RTL8139C+ Fast Ethernet NIC', 'inet6': ['fe80::490c:92bb:bbcc:9f87'], 'inet': ['10.34.60.148'], 'hw': '00:1a:4a:22:3c:db'}]
<b>appsList</b> = ['RHEV-Tools 3.2.4', 'RHEV-Agent64 3.2.3', 'RHEV-Serial64 3.2.3', 'RHEV-Network64 3.2.2', 'RHEV-Network64 3.2.3', 'RHEV-Block64 3.2.3', 'RHEV-Balloon64 3.2.3', 'RHEV-Balloon64 3.2.2', 'RHEV-Agent64 3.2.2', 'RHEV-USB 3.2.3', 'RHEV-Block64 3.2.2', 'RHEV-Serial64 3.2.2']
<b>pid</b> = 11314
<b>guestIPs</b> = 10.34.60.148 # duplicated info
<b>displayIp</b> = 0
<b>displayPort</b> = 5902
<b>displaySecurePort</b> = 5903
<b>username</b> = user@W864GUESTAGENTT
<b>clientIp</b> =
<b>lastLogin</b> = 1361976900.67
</pre>
<h4> <span class="mw-headline" id="Often_Changed:"> Often
Changed: </span></h4>
<p>This data is changed quite often however it is not necessary to
update this data every 15 seconds. As this is cumulative data
and reflects the current status, and it does not need to be
snapshotted every 15 seconds to retrieve statistics. The data
can be retrieved in much more generous time slices. (e.g. Every
5 minutes) </p>
<pre> <b>network</b> = {'vnet1': {'macAddr': '00:1a:4a:22:3c:db', 'rxDropped': '0', 'txDropped': '0', 'rxErrors': '0', 'txRate': '0.0', 'rxRate': '0.0', 'txErrors': '0', 'state': 'unknown', 'speed': '100', 'name': 'vnet1'}}</pre>
</blockquote>
macAddr and name don't change either.<br>
<blockquote cite="mid:51387942.606@redhat.com" type="cite">
<pre>
<b>disksUsage</b> = [{'path': 'c:\\', 'total': '64055406592', 'fs': 'NTFS', 'used': '19223846912'}, {'path': 'd:\\', 'total': '3490912256', 'fs': 'UDF', 'used': '3490912256'}]
<b>timeOffset</b> = 14422
<b>elapsedTime</b> = 68591
<b>hash</b> = 2335461227228498964
<b>statsAge</b> = 0.09 # unused
</pre>
<h4> <span class="mw-headline" id="Often_Changed_but_unused">
Often Changed but unused </span></h4>
<p>This data does not seem to be used in the engine at all. It is
<b>not</b> even used in the data warehouse. </p>
<pre> <b>memoryStats</b> = {'swap_out': '0', 'majflt': '0', 'mem_free': '1466884', 'swap_in': '0', 'pageflt': '0', 'mem_total': '2096736', 'mem_unused': '1466884'}
<b>balloonInfo</b> = {'balloon_max': 2097152, 'balloon_cur': 2097152}
</pre>
</blockquote>
It's used by mom to adjust memory overcommitment dynamically.<br>
<blockquote cite="mid:51387942.606@redhat.com" type="cite">
<pre>
<b>disks</b> = {'vda': {'readLatency': '0', 'apparentsize': '64424509440', 'writeLatency': '1754496', 'imageID': '28abb923-7b89-4638-84f8-1700f0b76482', 'flushLatency': '156549', 'readRate': '0.00', 'truesize': '18855059456', 'writeRate': '952.05'}, 'hdc': {'readLatency': '0', 'apparentsize': '0', 'writeLatency': '0', 'flushLatency': '0', 'readRate': '0.00', 'truesize': '0', 'writeRate': '0.00'}}
</pre>
<h4> <span class="mw-headline"
id="Very_frequent_uppdates_needed_by_webadmin_portal:"> Very
frequent uppdates needed by webadmin portal: </span></h4>
<p>This data is mostly needed for the webadmin portal and might be
required to be updated quite often. An exception here is the
statsAge field, which seems to be unused by the Engine. This
data could be requested every 15 seconds to keep things as they
are now. </p>
<pre> <b>cpuSys</b> = 2.32
<b>cpuUser</b> = 1.34
<b>memUsage</b> = 30
</pre>
<h2> <span class="mw-headline"
id="Proposed_Solution_for_VDSM_.26_Engine:"> Proposed Solution
for VDSM & Engine: </span></h2>
<p>We will introduce new optional parameters to getVmStats,
getAllVmStats and list to allow a finer grained specification of
data which should be included. </p>
<p><b>Parameter:</b> <b>statsType</b>=<i><b><string></b></i>
(getVmStats, getAllVmStats only) <b>Allowed values:</b> </p>
<ul>
<li> full (default to keep backwards compatibility) </li>
<li> app-list (Just send the application list) </li>
<li> rare (include everything from rarely changed to very
frequent) </li>
<li> often (include everything from often changed to very
frequent) </li>
<li> frequent (only send the very frequently changed items) </li>
</ul>
<p><br>
<b>Parameter:</b> <b>clientId</b>=<b><string></b> The
client id is specified by the client and should be unique
however constantly used. </p>
<p><b>Parameter:</b> <b>diff</b>=<b><boolean></b> In
combination with the clientId VDSM will send only differences to
the previous request from the named clientId. (if diff=true) </p>
<p><br>
</p>
<h3> <span class="mw-headline" id="Additional_Change:">
Additional Change: </span></h3>
<p>Besides the introduction of the new parameters for list,
getVmStats and getAllVmStats it might make sense to include a
hash for the appList into the rarely changed section of the
response which would allow to identify changes and avoid having
to sent the complete appList every so often and only if the hash
known to the client is outdated. </p>
<p><b>Note:</b> The appList (Application List) reported by the
guest agent could be fully implemented on request only, as long
as the guest agent installed supports this. As there seems to be
a request to have the complete list of installed applications on
all guests this data could be quite extensive and a huge list.
On the other hand this data is only rarely visible and therefore
it should not be requested all the time and only on demand. </p>
<h3> <span class="mw-headline"
id="Improvement_of_the_Guest_Agent:"> Improvement of the Guest
Agent: </span></h3>
<p>As part of the proposed solution it is necessary to improve the
guest agent as well. For the full application list there should
be implemented a caching system which will be fully reactive and
should not poll the application list for example all the time.
The guest can create a prepared data file containing all data in
the JSON format (as used for the communication with VDSM via
VIO) and just have to read that file from disk and directly
sends it to VDSM. However it is quite possible that this list is
to big and it might have to be chunked into pieces. (Multiple
messages, which would have to be supported by VDSM then as well)
The solution for this is to make VDSM request this data and it
will retrieve the data necessary on request only. </p>
<pre class="moz-signature" cols="72">--
Regards,
Vinzenz Feenstra | Senior Software Engineer
RedHat Engineering Virtualization R & D
Phone: +420 532 294 625
IRC: vfeenstr or evilissimo
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
vdsm-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:vdsm-devel@lists.fedorahosted.org">vdsm-devel@lists.fedorahosted.org</a>
<a class="moz-txt-link-freetext" href="https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel">https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel</a>
</pre>
</blockquote>
<br>
</body>
</html>