<html><head><style type='text/css'>p { margin: 0; }</style></head><body><div style='font-family: times new roman,new york,times,serif; font-size: 12pt; color: #000000'>Hi,<br><br>Lately I had to add an error message that "name is already used".<br>I looked in the translations files and saw many messages for specific entity types in the system that looked much the same:<br><span class="str">VDS_TRY_CREATE_WITH_EXISTING_PARAMS=Cannot ${action} ${type}. Host with the same name already exists<br></span><span class="pln">ACTION_TYPE_FAILED_VM_ALREADY_EXIST</span><span class="pun">=</span><span class="typ">Cannot</span><span class="pln"> $</span><span class="pun">{</span><span class="pln">action</span><span class="pun">}</span><span class="pln"> $</span><span class="pun">{</span><span class="pln">type</span><span class="pun">}.</span><span class="pln"> VM </span><span class="kwd">with</span><span class="pln"> the same name already exists</span><span class="pun">.</span><br>etc..<br><br>What I decided to do is not add another "X with the same name already exists" message,<br>but instead add a generic message for this condition.<br><br>You can review the patch here:<br>http://gerrit.ovirt.org/#/c/12361<br><br>I also went the extra mile to change the current messages that look like this to use this message:<br>http://gerrit.ovirt.org/#/c/13063/<br><br>It is not a full coverage, since some commands don't fill the $action $type replacements,<br>and the required change is a bit bigger than this patch scope, but it's a good start.<br><br>FYI, and if you see other generic messages repeating themselves, don't hesitate to squash them.<br><br><div><span name="x"></span>Regards,<br>Mike<span name="x"></span><br></div><br></div></body></html>