From gerrit2 at gerrit.ovirt.org  Wed May 21 10:38:52 2014
From: gerrit2 at gerrit.ovirt.org (oVirt Jenkins CI Server)
Date: Wed, 21 May 2014 06:38:52 -0400
Subject: [Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]:
	webadmin: Fix potential NPE when in CheckboxColumn
In-Reply-To: <gerrit.1400658096736.I26f688984083fbd6964972e79e50960b254c547b@gerrit.ovirt.org>
References: <gerrit.1400658096736.I26f688984083fbd6964972e79e50960b254c547b@gerrit.ovirt.org>
Message-ID: <201405211038.s4LAcrTg003714@gerrit.ovirt.org>

oVirt Jenkins CI Server has posted comments on this change.

Change subject: webadmin: Fix potential NPE when in CheckboxColumn
......................................................................


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/ovirt-engine_3.4_upgrade-from-3.3_merge/250/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_3.4_find-bugs_merged/291/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_3.4_create-rpms_merged/419/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/27957
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26f688984083fbd6964972e79e50960b254c547b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From automation at ovirt.org  Wed May 21 10:39:08 2014
From: automation at ovirt.org (automation at ovirt.org)
Date: Wed, 21 May 2014 06:39:08 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: engine:
	TimeConversions in GlusterVolumeProfileInfoReturnFor...
In-Reply-To: <gerrit.1400604635709.I19065777b2cdd2b592677769ac23512f2c36b3d3@gerrit.ovirt.org>
References: <gerrit.1400604635709.I19065777b2cdd2b592677769ac23512f2c36b3d3@gerrit.ovirt.org>
Message-ID: <201405211039.s4LAd86W003765@gerrit.ovirt.org>

automation at ovirt.org has posted comments on this change.

Change subject: engine: TimeConversions in GlusterVolumeProfileInfoReturnForXmlRpc
......................................................................


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])

-- 
To view, visit http://gerrit.ovirt.org/27945
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I19065777b2cdd2b592677769ac23512f2c36b3d3
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu at redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa at redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From automation at ovirt.org  Wed May 21 10:39:10 2014
From: automation at ovirt.org (automation at ovirt.org)
Date: Wed, 21 May 2014 06:39:10 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: webadmin : Gluster
	Volume Profile
In-Reply-To: <gerrit.1399468658508.Ic305a0fece18f29d24a9d0324391e484681fa033@gerrit.ovirt.org>
References: <gerrit.1399468658508.Ic305a0fece18f29d24a9d0324391e484681fa033@gerrit.ovirt.org>
Message-ID: <201405211039.s4LAdAZe003800@gerrit.ovirt.org>

automation at ovirt.org has posted comments on this change.

Change subject: webadmin : Gluster Volume Profile
......................................................................


Patch Set 14:

* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])

-- 
To view, visit http://gerrit.ovirt.org/27470
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic305a0fece18f29d24a9d0324391e484681fa033
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu at redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa at redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From gerrit2 at gerrit.ovirt.org  Wed May 21 10:40:37 2014
From: gerrit2 at gerrit.ovirt.org (oVirt Jenkins CI Server)
Date: Wed, 21 May 2014 06:40:37 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: First draft for
	engine-setup splitting
In-Reply-To: <gerrit.1399999526720.I4d465766f10a490bd213ca3510d02b3d6fdfa7c6@gerrit.ovirt.org>
References: <gerrit.1399999526720.I4d465766f10a490bd213ca3510d02b3d6fdfa7c6@gerrit.ovirt.org>
Message-ID: <201405211040.s4LAeb7N003890@gerrit.ovirt.org>

oVirt Jenkins CI Server has posted comments on this change.

Change subject: First draft for engine-setup splitting
......................................................................


Patch Set 12: Code-Review+1

Build Successful 

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/1966/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/27647
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d465766f10a490bd213ca3510d02b3d6fdfa7c6
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From anbabu at redhat.com  Wed May 21 10:45:08 2014
From: anbabu at redhat.com (anbabu at redhat.com)
Date: Wed, 21 May 2014 06:45:08 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: webadmin:Set
	highest compactibility version by default in ne...
In-Reply-To: <gerrit.1400581934479.Iaa76e316b536bedf1b24ce21493716a4b08c9878@gerrit.ovirt.org>
References: <gerrit.1400581934479.Iaa76e316b536bedf1b24ce21493716a4b08c9878@gerrit.ovirt.org>
Message-ID: <201405211045.s4LAj9NQ004403@gerrit.ovirt.org>

anmolbabu has posted comments on this change.

Change subject: webadmin:Set highest compactibility version by default in new cluster pop-up
......................................................................


Patch Set 1:

(1 comment)

Minor Comment :)

http://gerrit.ovirt.org/#/c/27926/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-05-20 15:45:02 +0530
Line 4: Commit:     Karnan <kchidamb at redhat.com>
Line 5: CommitDate: 2014-05-20 15:45:02 +0530
Line 6: 
Line 7: webadmin:Set highest compactibility version by default in new cluster pop-up
"compatibility"
Line 8: 
Line 9: while creating new cluster in Gluster only mode,
Line 10: the latest version will be selected as Compactibility Version by default
Line 11: 


-- 
To view, visit http://gerrit.ovirt.org/27926
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa76e316b536bedf1b24ce21493716a4b08c9878
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Karnan t c <kchidamb at redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa at redhat.com>
Gerrit-Reviewer: Karnan t c <kchidamb at redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


From anbabu at redhat.com  Wed May 21 10:45:21 2014
From: anbabu at redhat.com (anbabu at redhat.com)
Date: Wed, 21 May 2014 06:45:21 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: webadmin:Set
	highest compactibility version by default in ne...
In-Reply-To: <gerrit.1400581934479.Iaa76e316b536bedf1b24ce21493716a4b08c9878@gerrit.ovirt.org>
References: <gerrit.1400581934479.Iaa76e316b536bedf1b24ce21493716a4b08c9878@gerrit.ovirt.org>
Message-ID: <201405211045.s4LAjLak004409@gerrit.ovirt.org>

anmolbabu has posted comments on this change.

Change subject: webadmin:Set highest compactibility version by default in new cluster pop-up
......................................................................


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/27926
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa76e316b536bedf1b24ce21493716a4b08c9878
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Karnan t c <kchidamb at redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa at redhat.com>
Gerrit-Reviewer: Karnan t c <kchidamb at redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From automation at ovirt.org  Wed May 21 10:58:06 2014
From: automation at ovirt.org (automation at ovirt.org)
Date: Wed, 21 May 2014 06:58:06 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: webadmin: adding
	labels column to Network->Hosts sub-tab
In-Reply-To: <gerrit.1393322004554.I610703df29dcae7ace390e0ebb109475fb202263@gerrit.ovirt.org>
References: <gerrit.1393322004554.I610703df29dcae7ace390e0ebb109475fb202263@gerrit.ovirt.org>
Message-ID: <201405211058.s4LAw6fA005604@gerrit.ovirt.org>

automation at ovirt.org has posted comments on this change.

Change subject: webadmin: adding labels column to Network->Hosts sub-tab
......................................................................


Patch Set 16:

* #1063797::Update tracker: OK
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])

-- 
To view, visit http://gerrit.ovirt.org/24992
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I610703df29dcae7ace390e0ebb109475fb202263
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From alkaplan at redhat.com  Wed May 21 10:58:09 2014
From: alkaplan at redhat.com (alkaplan at redhat.com)
Date: Wed, 21 May 2014 06:58:09 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: webadmin: adding
	labels column to Network->Hosts sub-tab
In-Reply-To: <gerrit.1393322004554.I610703df29dcae7ace390e0ebb109475fb202263@gerrit.ovirt.org>
References: <gerrit.1393322004554.I610703df29dcae7ace390e0ebb109475fb202263@gerrit.ovirt.org>
Message-ID: <201405211058.s4LAwAag005621@gerrit.ovirt.org>

Alona Kaplan has posted comments on this change.

Change subject: webadmin: adding labels column to Network->Hosts sub-tab
......................................................................


Patch Set 16: Verified+1 Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/24992
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I610703df29dcae7ace390e0ebb109475fb202263
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From alkaplan at redhat.com  Wed May 21 10:58:11 2014
From: alkaplan at redhat.com (alkaplan at redhat.com)
Date: Wed, 21 May 2014 06:58:11 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: webadmin: adding
	labels column to Network->Hosts sub-tab
In-Reply-To: <gerrit.1393322004554.I610703df29dcae7ace390e0ebb109475fb202263@gerrit.ovirt.org>
References: <gerrit.1393322004554.I610703df29dcae7ace390e0ebb109475fb202263@gerrit.ovirt.org>
Message-ID: <201405211058.s4LAwCgT005627@gerrit.ovirt.org>

Alona Kaplan has submitted this change and it was merged.

Change subject: webadmin: adding labels column to Network->Hosts sub-tab
......................................................................


webadmin: adding labels column to Network->Hosts sub-tab

Adding a tag image to the device name column if the network is attacehd
via label.

Change-Id: I610703df29dcae7ace390e0ebb109475fb202263
Bug-Url: https://bugzilla.redhat.com/1063797
Signed-off-by: Alona Kaplan <alkaplan at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/SafeHtmlWithSafeHtmlTooltipColumn.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkHostListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java
5 files changed, 89 insertions(+), 25 deletions(-)

Approvals:
  Alona Kaplan: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/24992
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I610703df29dcae7ace390e0ebb109475fb202263
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


From automation at ovirt.org  Wed May 21 10:58:51 2014
From: automation at ovirt.org (automation at ovirt.org)
Date: Wed, 21 May 2014 06:58:51 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: webadmin: adding
	labels column to Network->Hosts sub-tab
In-Reply-To: <gerrit.1393322004554.I610703df29dcae7ace390e0ebb109475fb202263@gerrit.ovirt.org>
References: <gerrit.1393322004554.I610703df29dcae7ace390e0ebb109475fb202263@gerrit.ovirt.org>
Message-ID: <201405211058.s4LAwplT005825@gerrit.ovirt.org>

automation at ovirt.org has posted comments on this change.

Change subject: webadmin: adding labels column to Network->Hosts sub-tab
......................................................................


Patch Set 16:

* #1063797::Update tracker: OK
* #1063797::Target Release: OK
* #1063797::Set MODIFIED: FAILED,

-- 
To view, visit http://gerrit.ovirt.org/24992
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I610703df29dcae7ace390e0ebb109475fb202263
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From alonbl at redhat.com  Wed May 21 10:59:32 2014
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Wed, 21 May 2014 06:59:32 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: First draft for
	engine-setup splitting
In-Reply-To: <gerrit.1399999526720.I4d465766f10a490bd213ca3510d02b3d6fdfa7c6@gerrit.ovirt.org>
References: <gerrit.1399999526720.I4d465766f10a490bd213ca3510d02b3d6fdfa7c6@gerrit.ovirt.org>
Message-ID: <201405211059.s4LAxWfL005869@gerrit.ovirt.org>

Alon Bar-Lev has posted comments on this change.

Change subject: First draft for engine-setup splitting
......................................................................


Patch Set 13:

(1 comment)

looks good!

I would have split the setup file changes to a patch prior to this, and keep in this patch all the house keeping of the actual split.

http://gerrit.ovirt.org/#/c/27647/13/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/jboss.py
File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/jboss.py:

Line 30
Line 31
Line 32
Line 33
Line 34
in all these, please keep the two spaces so you have clean patch


-- 
To view, visit http://gerrit.ovirt.org/27647
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d465766f10a490bd213ca3510d02b3d6fdfa7c6
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


From gerrit2 at gerrit.ovirt.org  Wed May 21 10:59:35 2014
From: gerrit2 at gerrit.ovirt.org (oVirt Jenkins CI Server)
Date: Wed, 21 May 2014 06:59:35 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: webadmin : Gluster
	Volume Profile
In-Reply-To: <gerrit.1399468658508.Ic305a0fece18f29d24a9d0324391e484681fa033@gerrit.ovirt.org>
References: <gerrit.1399468658508.Ic305a0fece18f29d24a9d0324391e484681fa033@gerrit.ovirt.org>
Message-ID: <201405211059.s4LAxaXZ005877@gerrit.ovirt.org>

oVirt Jenkins CI Server has posted comments on this change.

Change subject: webadmin : Gluster Volume Profile
......................................................................


Patch Set 14: -Code-Review -Verified

Build Successful 

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/8650/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/7965/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/24893/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/27470
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic305a0fece18f29d24a9d0324391e484681fa033
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu at redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa at redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From alonbl at redhat.com  Wed May 21 10:59:42 2014
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Wed, 21 May 2014 06:59:42 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: First draft for
	engine-setup splitting
In-Reply-To: <gerrit.1399999526720.I4d465766f10a490bd213ca3510d02b3d6fdfa7c6@gerrit.ovirt.org>
References: <gerrit.1399999526720.I4d465766f10a490bd213ca3510d02b3d6fdfa7c6@gerrit.ovirt.org>
Message-ID: <201405211059.s4LAxhBT005883@gerrit.ovirt.org>

Alon Bar-Lev has posted comments on this change.

Change subject: First draft for engine-setup splitting
......................................................................


Patch Set 13:

please ping me when all the TODO are resolved.

-- 
To view, visit http://gerrit.ovirt.org/27647
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d465766f10a490bd213ca3510d02b3d6fdfa7c6
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From automation at ovirt.org  Wed May 21 11:03:18 2014
From: automation at ovirt.org (automation at ovirt.org)
Date: Wed, 21 May 2014 07:03:18 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: Changes to
	ExtensionsManager
In-Reply-To: <gerrit.1400325139613.I1c914df29a0dbf52ff6d2f8149687b31b4faffe1@gerrit.ovirt.org>
References: <gerrit.1400325139613.I1c914df29a0dbf52ff6d2f8149687b31b4faffe1@gerrit.ovirt.org>
Message-ID: <201405211103.s4LB3IpH006246@gerrit.ovirt.org>

automation at ovirt.org has posted comments on this change.

Change subject: aaa: Changes to ExtensionsManager
......................................................................


Patch Set 36:

* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])

-- 
To view, visit http://gerrit.ovirt.org/27785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1
Gerrit-PatchSet: 36
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From automation at ovirt.org  Wed May 21 11:04:45 2014
From: automation at ovirt.org (automation at ovirt.org)
Date: Wed, 21 May 2014 07:04:45 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: extmgr: use
	extension class loader when calling extension
In-Reply-To: <gerrit.1400509936513.I38031776f1d740da8f8f07f0d4a52b640534bcff@gerrit.ovirt.org>
References: <gerrit.1400509936513.I38031776f1d740da8f8f07f0d4a52b640534bcff@gerrit.ovirt.org>
Message-ID: <201405211104.s4LB4jE5006373@gerrit.ovirt.org>

automation at ovirt.org has posted comments on this change.

Change subject: extmgr: use extension class loader when calling extension
......................................................................


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])

-- 
To view, visit http://gerrit.ovirt.org/27875
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38031776f1d740da8f8f07f0d4a52b640534bcff
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From alonbl at redhat.com  Wed May 21 11:07:55 2014
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Wed, 21 May 2014 07:07:55 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: Extensions
	tester tool
In-Reply-To: <gerrit.1400422425890.I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886@gerrit.ovirt.org>
References: <gerrit.1400422425890.I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886@gerrit.ovirt.org>
Message-ID: <201405211107.s4LB7t9U006666@gerrit.ovirt.org>

Alon Bar-Lev has posted comments on this change.

Change subject: aaa: Extensions tester tool
......................................................................


Patch Set 11:

when we reach to the state that it is separate tool and does not effect any other module, then we can keep this around while we work and actually use it to see how it goes.

-- 
To view, visit http://gerrit.ovirt.org/27814
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From yzaslavs at redhat.com  Wed May 21 11:12:31 2014
From: yzaslavs at redhat.com (yzaslavs at redhat.com)
Date: Wed, 21 May 2014 07:12:31 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: extapi: switch
	sensitive scalar with flags mask, add non pri...
In-Reply-To: <gerrit.1400659389349.I9f9204d2b44af052196b0be0c4ad4ef3727c0768@gerrit.ovirt.org>
References: <gerrit.1400659389349.I9f9204d2b44af052196b0be0c4ad4ef3727c0768@gerrit.ovirt.org>
Message-ID: <201405211112.s4LBCWZA006921@gerrit.ovirt.org>

Yair Zaslavsky has submitted this change and it was merged.

Change subject: extapi: switch sensitive scalar with flags mask, add non printable
......................................................................


extapi: switch sensitive scalar with flags mask, add non printable

there is a case of loops within the map especially when global context
and the context points to each other.

add a flag to skip dump of keys.

Change-Id: I9f9204d2b44af052196b0be0c4ad4ef3727c0768
Signed-off-by: Alon Bar-Lev <alonbl at redhat.com>
---
M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/Base.java
M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtKey.java
M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtMap.java
M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authn.java
4 files changed, 29 insertions(+), 22 deletions(-)

Approvals:
  Alon Bar-Lev: Verified
  Yair Zaslavsky: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/27961
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9f9204d2b44af052196b0be0c4ad4ef3727c0768
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


From automation at ovirt.org  Wed May 21 11:12:43 2014
From: automation at ovirt.org (automation at ovirt.org)
Date: Wed, 21 May 2014 07:12:43 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: extapi: switch
	sensitive scalar with flags mask, add non pri...
In-Reply-To: <gerrit.1400659389349.I9f9204d2b44af052196b0be0c4ad4ef3727c0768@gerrit.ovirt.org>
References: <gerrit.1400659389349.I9f9204d2b44af052196b0be0c4ad4ef3727c0768@gerrit.ovirt.org>
Message-ID: <201405211112.s4LBChWN006982@gerrit.ovirt.org>

automation at ovirt.org has posted comments on this change.

Change subject: extapi: switch sensitive scalar with flags mask, add non printable
......................................................................


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED: IGNORE, no Bug-Url found.

-- 
To view, visit http://gerrit.ovirt.org/27961
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f9204d2b44af052196b0be0c4ad4ef3727c0768
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From gerrit2 at gerrit.ovirt.org  Wed May 21 11:14:18 2014
From: gerrit2 at gerrit.ovirt.org (oVirt Jenkins CI Server)
Date: Wed, 21 May 2014 07:14:18 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: extmgr: use
	extension class loader when calling extension
In-Reply-To: <gerrit.1400509936513.I38031776f1d740da8f8f07f0d4a52b640534bcff@gerrit.ovirt.org>
References: <gerrit.1400509936513.I38031776f1d740da8f8f07f0d4a52b640534bcff@gerrit.ovirt.org>
Message-ID: <201405211114.s4LBEJ7k007092@gerrit.ovirt.org>

oVirt Jenkins CI Server has posted comments on this change.

Change subject: extmgr: use extension class loader when calling extension
......................................................................


Patch Set 6:

Build Successful 

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/8654/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/7969/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/24897/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/27875
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38031776f1d740da8f8f07f0d4a52b640534bcff
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From gerrit2 at gerrit.ovirt.org  Wed May 21 11:15:10 2014
From: gerrit2 at gerrit.ovirt.org (oVirt Jenkins CI Server)
Date: Wed, 21 May 2014 07:15:10 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: engine:
	TimeConversions in GlusterVolumeProfileInfoReturnFor...
In-Reply-To: <gerrit.1400604635709.I19065777b2cdd2b592677769ac23512f2c36b3d3@gerrit.ovirt.org>
References: <gerrit.1400604635709.I19065777b2cdd2b592677769ac23512f2c36b3d3@gerrit.ovirt.org>
Message-ID: <201405211115.s4LBFATj007146@gerrit.ovirt.org>

oVirt Jenkins CI Server has posted comments on this change.

Change subject: engine: TimeConversions in GlusterVolumeProfileInfoReturnForXmlRpc
......................................................................


Patch Set 6:

Build Failed 

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/8649/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/2505/ : FAILURE

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/7964/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/24892/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/27945
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I19065777b2cdd2b592677769ac23512f2c36b3d3
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu at redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa at redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From yzaslavs at redhat.com  Wed May 21 11:15:19 2014
From: yzaslavs at redhat.com (yzaslavs at redhat.com)
Date: Wed, 21 May 2014 07:15:19 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: Move
	GlobalContext to InvokeKeys
In-Reply-To: <gerrit.1400646981389.If4735d01668ab38d8686964d4a335fcbce7776fe@gerrit.ovirt.org>
References: <gerrit.1400646981389.If4735d01668ab38d8686964d4a335fcbce7776fe@gerrit.ovirt.org>
Message-ID: <201405211115.s4LBFJDG007158@gerrit.ovirt.org>

Yair Zaslavsky has abandoned this change.

Change subject: aaa: Move GlobalContext to InvokeKeys
......................................................................


Abandoned

no need, alon suggested another fix.

-- 
To view, visit http://gerrit.ovirt.org/27953
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: If4735d01668ab38d8686964d4a335fcbce7776fe
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


From automation at ovirt.org  Wed May 21 11:15:21 2014
From: automation at ovirt.org (automation at ovirt.org)
Date: Wed, 21 May 2014 07:15:21 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: Move
	GlobalContext to InvokeKeys
In-Reply-To: <gerrit.1400646981389.If4735d01668ab38d8686964d4a335fcbce7776fe@gerrit.ovirt.org>
References: <gerrit.1400646981389.If4735d01668ab38d8686964d4a335fcbce7776fe@gerrit.ovirt.org>
Message-ID: <201405211115.s4LBFLtt007166@gerrit.ovirt.org>

automation at ovirt.org has posted comments on this change.

Change subject: aaa: Move GlobalContext to InvokeKeys
......................................................................


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit http://gerrit.ovirt.org/27953
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If4735d01668ab38d8686964d4a335fcbce7776fe
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From yzaslavs at redhat.com  Wed May 21 11:16:28 2014
From: yzaslavs at redhat.com (yzaslavs at redhat.com)
Date: Wed, 21 May 2014 07:16:28 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: fixes to
	Authz utils
Message-ID: <gerrit.1400670985334.Iceff3f7355219e1887f4e8736d78af94f6ab310e@gerrit.ovirt.org>

Yair Zaslavsky has uploaded a new change for review.

Change subject: aaa: fixes to Authz utils
......................................................................

aaa: fixes to Authz utils

Change-Id: Iceff3f7355219e1887f4e8736d78af94f6ab310e
Signed-off-by: Yair Zaslavsky <yzaslavs at redhat.com>
---
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SearchQueryParsingUtils.java
2 files changed, 4 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/67/27967/1

diff --git a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java
index 57279f5..da3ed56 100644
--- a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java
+++ b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java
@@ -48,7 +48,7 @@
 
     public static List<DirectoryUser> findPrincipalsByIds(final ExtensionProxy extension, final List<String> ids) {
         List<DirectoryUser> results = new ArrayList<>();
-        for (List<String> batch : SearchQueryParsingUtils.getIdsBatches(extension, ids)) {
+        for (List<String> batch : SearchQueryParsingUtils.getIdsBatches(extension.getContext(), ids)) {
             results.addAll(
                     queryPrincipals(
                             extension,
@@ -76,7 +76,7 @@
 
     public static List<DirectoryGroup> findGroupsByIds(final ExtensionProxy extension, final List<String> ids) {
         List<DirectoryGroup> results = new ArrayList<>();
-        for (List<String> batch : SearchQueryParsingUtils.getIdsBatches(extension, ids)) {
+        for (List<String> batch : SearchQueryParsingUtils.getIdsBatches(extension.getContext(), ids)) {
             results.addAll(
                     queryGroups(
                             extension,
diff --git a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SearchQueryParsingUtils.java b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SearchQueryParsingUtils.java
index a4ac29e..67d9210 100644
--- a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SearchQueryParsingUtils.java
+++ b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SearchQueryParsingUtils.java
@@ -12,7 +12,6 @@
 import org.ovirt.engine.api.extensions.aaa.Authz;
 import org.ovirt.engine.api.extensions.aaa.Authz.QueryFilterOperator;
 import org.ovirt.engine.api.extensions.aaa.Authz.QueryFilterRecord;
-import org.ovirt.engine.core.extensions.mgr.ExtensionProxy;
 
 /**
  * This class is a helper class to transform searchbackend related search queries to Extension API structures. This
@@ -128,9 +127,9 @@
         return queryPrefix;
     }
 
-    public static List<List<String>> getIdsBatches(final ExtensionProxy extension, final List<String> ids) {
+    public static List<List<String>> getIdsBatches(final ExtMap context, final List<String> ids) {
 
-        int chunk = extension.getContext().<Integer> get(Authz.ContextKeys.QUERY_MAX_FILTER_SIZE, 100) - 10;
+        int chunk = context.<Integer> get(Authz.ContextKeys.QUERY_MAX_FILTER_SIZE, 100) - 10;
         List<List<String>> batchOfIdsList = new ArrayList<>();
         for (int counter = 0; counter < ids.size(); counter = counter + chunk) {
             batchOfIdsList.add(ids.subList(counter, counter + chunk > ids.size() ? ids.size() : counter + chunk));


-- 
To view, visit http://gerrit.ovirt.org/27967
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iceff3f7355219e1887f4e8736d78af94f6ab310e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>


From automation at ovirt.org  Wed May 21 11:16:28 2014
From: automation at ovirt.org (automation at ovirt.org)
Date: Wed, 21 May 2014 07:16:28 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: Extensions
	tester tool
In-Reply-To: <gerrit.1400422425890.I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886@gerrit.ovirt.org>
References: <gerrit.1400422425890.I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886@gerrit.ovirt.org>
Message-ID: <201405211116.s4LBGSXl007270@gerrit.ovirt.org>

automation at ovirt.org has posted comments on this change.

Change subject: aaa: Extensions tester tool
......................................................................


Patch Set 12:

* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])

-- 
To view, visit http://gerrit.ovirt.org/27814
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From automation at ovirt.org  Wed May 21 11:16:30 2014
From: automation at ovirt.org (automation at ovirt.org)
Date: Wed, 21 May 2014 07:16:30 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: Remove
	dependency at builtin on Common config
In-Reply-To: <gerrit.1399957249361.I1384a99f73ab605b61bce8dcdfd63e222b0001fa@gerrit.ovirt.org>
References: <gerrit.1399957249361.I1384a99f73ab605b61bce8dcdfd63e222b0001fa@gerrit.ovirt.org>
Message-ID: <201405211116.s4LBGU5w007302@gerrit.ovirt.org>

automation at ovirt.org has posted comments on this change.

Change subject: aaa: Remove dependency at builtin on Common config
......................................................................


Patch Set 15:

* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])

-- 
To view, visit http://gerrit.ovirt.org/27607
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1384a99f73ab605b61bce8dcdfd63e222b0001fa
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From automation at ovirt.org  Wed May 21 11:16:32 2014
From: automation at ovirt.org (automation at ovirt.org)
Date: Wed, 21 May 2014 07:16:32 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: fixes to
	Authz utils
In-Reply-To: <gerrit.1400670985334.Iceff3f7355219e1887f4e8736d78af94f6ab310e@gerrit.ovirt.org>
References: <gerrit.1400670985334.Iceff3f7355219e1887f4e8736d78af94f6ab310e@gerrit.ovirt.org>
Message-ID: <201405211116.s4LBGW63007334@gerrit.ovirt.org>

automation at ovirt.org has posted comments on this change.

Change subject: aaa: fixes to Authz utils
......................................................................


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])

-- 
To view, visit http://gerrit.ovirt.org/27967
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iceff3f7355219e1887f4e8736d78af94f6ab310e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


From automation at ovirt.org  Wed May 21 11:17:55 2014
From: automation at ovirt.org (automation at ovirt.org)
Date: Wed, 21 May 2014 07:17:55 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: Extensions
	tester tool
In-Reply-To: <gerrit.1400422425890.I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886@gerrit.ovirt.org>
References: <gerrit.1400422425890.I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886@gerrit.ovirt.org>
Message-ID: <201405211117.s4LBHtPP007532@gerrit.ovirt.org>

automation at ovirt.org has posted comments on this change.

Change subject: aaa: Extensions tester tool
......................................................................


Patch Set 13:

* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])

-- 
To view, visit http://gerrit.ovirt.org/27814
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From automation at ovirt.org  Wed May 21 11:19:02 2014
From: automation at ovirt.org (automation at ovirt.org)
Date: Wed, 21 May 2014 07:19:02 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: Extensions
	tester tool
In-Reply-To: <gerrit.1400422425890.I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886@gerrit.ovirt.org>
References: <gerrit.1400422425890.I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886@gerrit.ovirt.org>
Message-ID: <201405211119.s4LBJ2e0007661@gerrit.ovirt.org>

automation at ovirt.org has posted comments on this change.

Change subject: aaa: Extensions tester tool
......................................................................


Patch Set 14:

* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])

-- 
To view, visit http://gerrit.ovirt.org/27814
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From alonbl at redhat.com  Wed May 21 11:20:05 2014
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Wed, 21 May 2014 07:20:05 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: Extensions
	tester tool
In-Reply-To: <gerrit.1400422425890.I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886@gerrit.ovirt.org>
References: <gerrit.1400422425890.I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886@gerrit.ovirt.org>
Message-ID: <201405211120.s4LBK7sp007746@gerrit.ovirt.org>

Alon Bar-Lev has posted comments on this change.

Change subject: aaa: Extensions tester tool
......................................................................


Patch Set 13:

(1 comment)

http://gerrit.ovirt.org/#/c/27814/13/backend/manager/extension-tool/pom.xml
File backend/manager/extension-tool/pom.xml:

Line 34:       <groupId>${engine.groupId}</groupId>
Line 35:       <artifactId>uutils</artifactId>
Line 36:       <version>${engine.version}</version>
Line 37:     </dependency>
Line 38:     
-
Line 39:   </dependencies>
Line 40: 
Line 41:   <build>
Line 42:     <plugins>


-- 
To view, visit http://gerrit.ovirt.org/27814
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


From juan.hernandez at redhat.com  Wed May 21 11:20:24 2014
From: juan.hernandez at redhat.com (juan.hernandez at redhat.com)
Date: Wed, 21 May 2014 07:20:24 -0400
Subject: [Engine-patches] Change in ovirt-engine-cli[master]: cli: Update to
	generateDS.py 2.12a
Message-ID: <gerrit.1400671223953.Ia1b1529e9428a0b90f914b582f12153c809bdc5b@gerrit.ovirt.org>

Juan Hernandez has uploaded a new change for review.

Change subject: cli: Update to generateDS.py 2.12a
......................................................................

cli: Update to generateDS.py 2.12a

Starting with version 3.5.0.0 of the Python SDK the version of
generateDS.py used to generate the code will be 2.12.a. One of the
changes in this version of generateDS.py is that it doesn't import the
datetime class like it used to do. In version 2.9a it imported it as
follows:

  from from datetime import datetime, tzinfo, timedelta

In version 2.12a it imports it in a different way:

  import datetime as datetime_

We currently depend on the name used by the generated code, so the CLI
doesn't work with the new version of generateDS.py. To fix that problem
and avoid it in the future this patch changes the CLI so that it doesn't
depend on how generateDS.py imports the class.

In addition this patch also updates the setup.py and the RPM spec to
require version 3.5.0.0 of the Python SDK.

Change-Id: Ia1b1529e9428a0b90f914b582f12153c809bdc5b
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M ovirt-engine-cli.spec.in
M setup.py
M src/ovirtcli/format/text.py
3 files changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine-cli refs/changes/69/27969/1

diff --git a/ovirt-engine-cli.spec.in b/ovirt-engine-cli.spec.in
index eac935a..ef5032e 100644
--- a/ovirt-engine-cli.spec.in
+++ b/ovirt-engine-cli.spec.in
@@ -15,7 +15,7 @@
 BuildArch: noarch
 
 Requires: python
-Requires: ovirt-engine-sdk-python >= 3.3.0.3
+Requires: ovirt-engine-sdk-python >= 3.5.0.0
 Requires: python-setuptools
 Requires: python-ply
 Requires: python-kitchen
diff --git a/setup.py b/setup.py
index 5c0c353..799e48d 100755
--- a/setup.py
+++ b/setup.py
@@ -32,7 +32,7 @@
                  'cli.command', 'cli.platform', 'cli.platform.posix', 'ovirtcli.infrastructure',
                  'ovirtcli.annotations', 'ovirtcli.events', 'ovirtcli.listeners', 'ovirtcli.meta',
                  'ovirtcli.state'],
-    install_requires=[ 'ovirt-engine-sdk-python >= 3.3.0.3', 'ply >= 3.3', 'kitchen >= 1' ],
+    install_requires=[ 'ovirt-engine-sdk-python >= 3.5.0.0', 'ply >= 3.3', 'kitchen >= 1' ],
     entry_points={ 'console_scripts': [ 'ovirt-shell = ovirtcli.main:main' ] },
     **version_info
 )
diff --git a/src/ovirtcli/format/text.py b/src/ovirtcli/format/text.py
index ade7390..28bf34d 100644
--- a/src/ovirtcli/format/text.py
+++ b/src/ovirtcli/format/text.py
@@ -15,6 +15,7 @@
 #
 
 
+import datetime
 import sys
 
 from ovirtcli.format.format import Formatter
@@ -48,7 +49,7 @@
 
     # list of complex types that should be treated as
     # primitives (e.g should be wrapped to string at runtime)
-    complex_type_exceptions = [params.datetime]
+    complex_type_exceptions = [datetime.datetime]
 
 
     def _get_fields(self, typ):


-- 
To view, visit http://gerrit.ovirt.org/27969
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1b1529e9428a0b90f914b582f12153c809bdc5b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>


From automation at ovirt.org  Wed May 21 11:20:31 2014
From: automation at ovirt.org (automation at ovirt.org)
Date: Wed, 21 May 2014 07:20:31 -0400
Subject: [Engine-patches] Change in ovirt-engine-cli[master]: cli: Update to
	generateDS.py 2.12a
In-Reply-To: <gerrit.1400671223953.Ia1b1529e9428a0b90f914b582f12153c809bdc5b@gerrit.ovirt.org>
References: <gerrit.1400671223953.Ia1b1529e9428a0b90f914b582f12153c809bdc5b@gerrit.ovirt.org>
Message-ID: <201405211120.s4LBKVKp007799@gerrit.ovirt.org>

automation at ovirt.org has posted comments on this change.

Change subject: cli: Update to generateDS.py 2.12a
......................................................................


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit http://gerrit.ovirt.org/27969
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b1529e9428a0b90f914b582f12153c809bdc5b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


From ahadas at redhat.com  Wed May 21 11:21:15 2014
From: ahadas at redhat.com (ahadas at redhat.com)
Date: Wed, 21 May 2014 07:21:15 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: core: remove
	duplicated custom properties handling
In-Reply-To: <gerrit.1400513801630.I4c37a001985da09cbb7e3f78db1e419901d532cf@gerrit.ovirt.org>
References: <gerrit.1400513801630.I4c37a001985da09cbb7e3f78db1e419901d532cf@gerrit.ovirt.org>
Message-ID: <201405211121.s4LBLHIr007892@gerrit.ovirt.org>

Arik Hadas has posted comments on this change.

Change subject: core: remove duplicated custom properties handling
......................................................................


Patch Set 3: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/27883
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c37a001985da09cbb7e3f78db1e419901d532cf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From gerrit2 at gerrit.ovirt.org  Wed May 21 11:21:35 2014
From: gerrit2 at gerrit.ovirt.org (oVirt Jenkins CI Server)
Date: Wed, 21 May 2014 07:21:35 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: Changes to
	ExtensionsManager
In-Reply-To: <gerrit.1400325139613.I1c914df29a0dbf52ff6d2f8149687b31b4faffe1@gerrit.ovirt.org>
References: <gerrit.1400325139613.I1c914df29a0dbf52ff6d2f8149687b31b4faffe1@gerrit.ovirt.org>
Message-ID: <201405211121.s4LBLZfK007920@gerrit.ovirt.org>

oVirt Jenkins CI Server has posted comments on this change.

Change subject: aaa: Changes to ExtensionsManager
......................................................................


Patch Set 36:

Build Successful 

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/8653/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/7968/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/24896/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/27785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1
Gerrit-PatchSet: 36
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From automation at ovirt.org  Wed May 21 11:21:43 2014
From: automation at ovirt.org (automation at ovirt.org)
Date: Wed, 21 May 2014 07:21:43 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: core: remove
	duplicated custom properties handling
In-Reply-To: <gerrit.1400513801630.I4c37a001985da09cbb7e3f78db1e419901d532cf@gerrit.ovirt.org>
References: <gerrit.1400513801630.I4c37a001985da09cbb7e3f78db1e419901d532cf@gerrit.ovirt.org>
Message-ID: <201405211121.s4LBLhtK007991@gerrit.ovirt.org>

automation at ovirt.org has posted comments on this change.

Change subject: core: remove duplicated custom properties handling
......................................................................


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])

-- 
To view, visit http://gerrit.ovirt.org/27883
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c37a001985da09cbb7e3f78db1e419901d532cf
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From ahadas at redhat.com  Wed May 21 11:22:03 2014
From: ahadas at redhat.com (ahadas at redhat.com)
Date: Wed, 21 May 2014 07:22:03 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: core: remove
	duplicated custom properties handling
In-Reply-To: <gerrit.1400513801630.I4c37a001985da09cbb7e3f78db1e419901d532cf@gerrit.ovirt.org>
References: <gerrit.1400513801630.I4c37a001985da09cbb7e3f78db1e419901d532cf@gerrit.ovirt.org>
Message-ID: <201405211122.s4LBM5A7008023@gerrit.ovirt.org>

Arik Hadas has submitted this change and it was merged.

Change subject: core: remove duplicated custom properties handling
......................................................................


core: remove duplicated custom properties handling

The logic of extracting the predefined and user properties from VM
custom properties was duplicated in some places. This patch keep only
the one which is located in VmPropertiesUtils and change the other
places to use it.

Change-Id: I4c37a001985da09cbb7e3f78db1e419901d532cf
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
2 files changed, 10 insertions(+), 25 deletions(-)

Approvals:
  Omer Frenkel: Looks good to me, approved
  Arik Hadas: Verified



-- 
To view, visit http://gerrit.ovirt.org/27883
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4c37a001985da09cbb7e3f78db1e419901d532cf
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


From juan.hernandez at redhat.com  Wed May 21 11:22:40 2014
From: juan.hernandez at redhat.com (juan.hernandez at redhat.com)
Date: Wed, 21 May 2014 07:22:40 -0400
Subject: [Engine-patches] Change in ovirt-engine-cli[master]: cli: Update to
	generateDS.py 2.12a
In-Reply-To: <gerrit.1400671223953.Ia1b1529e9428a0b90f914b582f12153c809bdc5b@gerrit.ovirt.org>
References: <gerrit.1400671223953.Ia1b1529e9428a0b90f914b582f12153c809bdc5b@gerrit.ovirt.org>
Message-ID: <201405211122.s4LBMe2M008108@gerrit.ovirt.org>

Juan Hernandez has posted comments on this change.

Change subject: cli: Update to generateDS.py 2.12a
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/27969
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b1529e9428a0b90f914b582f12153c809bdc5b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


From alonbl at redhat.com  Wed May 21 11:22:52 2014
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Wed, 21 May 2014 07:22:52 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: extmgr: use
	extension class loader when calling extension
In-Reply-To: <gerrit.1400509936513.I38031776f1d740da8f8f07f0d4a52b640534bcff@gerrit.ovirt.org>
References: <gerrit.1400509936513.I38031776f1d740da8f8f07f0d4a52b640534bcff@gerrit.ovirt.org>
Message-ID: <201405211122.s4LBMqHr008116@gerrit.ovirt.org>

Alon Bar-Lev has posted comments on this change.

Change subject: extmgr: use extension class loader when calling extension
......................................................................


Patch Set 6: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/27875
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38031776f1d740da8f8f07f0d4a52b640534bcff
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From alonbl at redhat.com  Wed May 21 11:23:03 2014
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Wed, 21 May 2014 07:23:03 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: Changes to
	ExtensionsManager
In-Reply-To: <gerrit.1400325139613.I1c914df29a0dbf52ff6d2f8149687b31b4faffe1@gerrit.ovirt.org>
References: <gerrit.1400325139613.I1c914df29a0dbf52ff6d2f8149687b31b4faffe1@gerrit.ovirt.org>
Message-ID: <201405211123.s4LBN3Eo008129@gerrit.ovirt.org>

Alon Bar-Lev has posted comments on this change.

Change subject: aaa: Changes to ExtensionsManager
......................................................................


Patch Set 36: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/27785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1
Gerrit-PatchSet: 36
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From automation at ovirt.org  Wed May 21 11:23:06 2014
From: automation at ovirt.org (automation at ovirt.org)
Date: Wed, 21 May 2014 07:23:06 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: core: remove
	duplicated custom properties handling
In-Reply-To: <gerrit.1400513801630.I4c37a001985da09cbb7e3f78db1e419901d532cf@gerrit.ovirt.org>
References: <gerrit.1400513801630.I4c37a001985da09cbb7e3f78db1e419901d532cf@gerrit.ovirt.org>
Message-ID: <201405211123.s4LBN6TC008146@gerrit.ovirt.org>

automation at ovirt.org has posted comments on this change.

Change subject: core: remove duplicated custom properties handling
......................................................................


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED: IGNORE, no Bug-Url found.

-- 
To view, visit http://gerrit.ovirt.org/27883
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c37a001985da09cbb7e3f78db1e419901d532cf
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From automation at ovirt.org  Wed May 21 11:24:36 2014
From: automation at ovirt.org (automation at ovirt.org)
Date: Wed, 21 May 2014 07:24:36 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: Extensions
	tester tool
In-Reply-To: <gerrit.1400422425890.I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886@gerrit.ovirt.org>
References: <gerrit.1400422425890.I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886@gerrit.ovirt.org>
Message-ID: <201405211124.s4LBObaa008380@gerrit.ovirt.org>

automation at ovirt.org has posted comments on this change.

Change subject: aaa: Extensions tester tool
......................................................................


Patch Set 15:

* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])

-- 
To view, visit http://gerrit.ovirt.org/27814
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From automation at ovirt.org  Wed May 21 11:26:28 2014
From: automation at ovirt.org (automation at ovirt.org)
Date: Wed, 21 May 2014 07:26:28 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: core: fix typo
In-Reply-To: <gerrit.1400590630047.I92ddda877689209c2f4612de6a66f7177798efb7@gerrit.ovirt.org>
References: <gerrit.1400590630047.I92ddda877689209c2f4612de6a66f7177798efb7@gerrit.ovirt.org>
Message-ID: <201405211126.s4LBQSW8008633@gerrit.ovirt.org>

automation at ovirt.org has posted comments on this change.

Change subject: core: fix typo
......................................................................


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])

-- 
To view, visit http://gerrit.ovirt.org/27936
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92ddda877689209c2f4612de6a66f7177798efb7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From yzaslavs at redhat.com  Wed May 21 11:27:16 2014
From: yzaslavs at redhat.com (yzaslavs at redhat.com)
Date: Wed, 21 May 2014 07:27:16 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: Changes to
	ExtensionsManager
In-Reply-To: <gerrit.1400325139613.I1c914df29a0dbf52ff6d2f8149687b31b4faffe1@gerrit.ovirt.org>
References: <gerrit.1400325139613.I1c914df29a0dbf52ff6d2f8149687b31b4faffe1@gerrit.ovirt.org>
Message-ID: <201405211127.s4LBRIWM008727@gerrit.ovirt.org>

Yair Zaslavsky has posted comments on this change.

Change subject: aaa: Changes to ExtensionsManager
......................................................................


Patch Set 36: Verified+1 Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/27785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1
Gerrit-PatchSet: 36
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From gerrit2 at gerrit.ovirt.org  Wed May 21 11:29:36 2014
From: gerrit2 at gerrit.ovirt.org (oVirt Jenkins CI Server)
Date: Wed, 21 May 2014 07:29:36 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: Extensions
	tester tool
In-Reply-To: <gerrit.1400422425890.I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886@gerrit.ovirt.org>
References: <gerrit.1400422425890.I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886@gerrit.ovirt.org>
Message-ID: <201405211129.s4LBTbC8008917@gerrit.ovirt.org>

oVirt Jenkins CI Server has posted comments on this change.

Change subject: aaa: Extensions tester tool
......................................................................


Patch Set 12: Code-Review-1 Verified-1

Build Failed 

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/8655/ : FAILURE

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/1969/ : The patch does not pass the tests

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/7970/ : There was an infra issue, please contact infra at ovirt.org

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/24898/ : There was an infra issue, please contact infra at ovirt.org

-- 
To view, visit http://gerrit.ovirt.org/27814
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From automation at ovirt.org  Wed May 21 11:32:01 2014
From: automation at ovirt.org (automation at ovirt.org)
Date: Wed, 21 May 2014 07:32:01 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: Changes to
	ExtensionsManager
In-Reply-To: <gerrit.1400325139613.I1c914df29a0dbf52ff6d2f8149687b31b4faffe1@gerrit.ovirt.org>
References: <gerrit.1400325139613.I1c914df29a0dbf52ff6d2f8149687b31b4faffe1@gerrit.ovirt.org>
Message-ID: <201405211132.s4LBW1Ke009194@gerrit.ovirt.org>

automation at ovirt.org has posted comments on this change.

Change subject: aaa: Changes to ExtensionsManager
......................................................................


Patch Set 37:

* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])

-- 
To view, visit http://gerrit.ovirt.org/27785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1
Gerrit-PatchSet: 37
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From alonbl at redhat.com  Wed May 21 11:32:03 2014
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Wed, 21 May 2014 07:32:03 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: Remove
	dependency at builtin on Common config
In-Reply-To: <gerrit.1399957249361.I1384a99f73ab605b61bce8dcdfd63e222b0001fa@gerrit.ovirt.org>
References: <gerrit.1399957249361.I1384a99f73ab605b61bce8dcdfd63e222b0001fa@gerrit.ovirt.org>
Message-ID: <201405211132.s4LBW4TI009201@gerrit.ovirt.org>

Alon Bar-Lev has posted comments on this change.

Change subject: aaa: Remove dependency at builtin on Common config
......................................................................


Patch Set 15:

(1 comment)

http://gerrit.ovirt.org/#/c/27607/15/packaging/services/ovirt-engine/ovirt-engine.conf.in
File packaging/services/ovirt-engine/ovirt-engine.conf.in:

Line 101: #   -Dmy.param=my.value -Dmy.flag -Dyour.param=your.value
Line 102: #
Line 103: ENGINE_PROPERTIES=""
Line 104: ENGINE_PROPERTIES="${ENGINE_PROPERTIES} jsse.enableSNIExtension=false"
Line 105: ENGINE_PROPERTIES="${ENGINE_PROPERTIES} \"java.security.krb5.conf=${ENGINE_ETC}/krb5.conf\""
keep the space line? :)
Line 106: #
Line 107: # Extra Java arguments to be added to command-line.
Line 108: #
Line 109: ENGINE_JVM_ARGS=""


-- 
To view, visit http://gerrit.ovirt.org/27607
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1384a99f73ab605b61bce8dcdfd63e222b0001fa
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


From yzaslavs at redhat.com  Wed May 21 11:32:25 2014
From: yzaslavs at redhat.com (yzaslavs at redhat.com)
Date: Wed, 21 May 2014 07:32:25 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: Changes to
	ExtensionsManager
In-Reply-To: <gerrit.1400325139613.I1c914df29a0dbf52ff6d2f8149687b31b4faffe1@gerrit.ovirt.org>
References: <gerrit.1400325139613.I1c914df29a0dbf52ff6d2f8149687b31b4faffe1@gerrit.ovirt.org>
Message-ID: <201405211132.s4LBWPdb009224@gerrit.ovirt.org>

Yair Zaslavsky has posted comments on this change.

Change subject: aaa: Changes to ExtensionsManager
......................................................................


Patch Set 37: Verified+1 Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/27785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1
Gerrit-PatchSet: 37
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From yzaslavs at redhat.com  Wed May 21 11:32:28 2014
From: yzaslavs at redhat.com (yzaslavs at redhat.com)
Date: Wed, 21 May 2014 07:32:28 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: Changes to
	ExtensionsManager
In-Reply-To: <gerrit.1400325139613.I1c914df29a0dbf52ff6d2f8149687b31b4faffe1@gerrit.ovirt.org>
References: <gerrit.1400325139613.I1c914df29a0dbf52ff6d2f8149687b31b4faffe1@gerrit.ovirt.org>
Message-ID: <201405211132.s4LBWTtE009239@gerrit.ovirt.org>

Yair Zaslavsky has submitted this change and it was merged.

Change subject: aaa: Changes to ExtensionsManager
......................................................................


aaa: Changes to ExtensionsManager

The following changes are introduced:

1. ExtensionsManager is no longer singleton.
2. For engine related modules - EngineExtensionsManager is a singleton wrapper.
that also initilizes ExtensionsManager with the proper application name.
3. Splitting load to loading the extension and activating it.

Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1
topic: AAA
Signed-off-by: Yair Zaslavsky <yzaslavs at redhat.com>
---
M backend/manager/modules/aaa/pom.xml
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java
M backend/manager/modules/aaa/src/main/modules/org/ovirt/engine/core/aaa/main/module.xml
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
M backend/manager/modules/builtin-extensions/exclude-filters.xml
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthn.java
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthz.java
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthn.java
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java
M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/Base.java
M backend/manager/modules/extensions-manager/pom.xml
M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionProxy.java
M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java
M backend/manager/modules/extensions-manager/src/main/modules/org/ovirt/engine/core/extensions-manager/main/module.xml
M backend/manager/modules/logger/pom.xml
M backend/manager/modules/logger/src/main/java/org/ovirt/engine/core/logger/LoggerHandler.java
M backend/manager/modules/logger/src/main/modules/org/ovirt/engine/core/logger/main/module.xml
M backend/manager/modules/pom.xml
M backend/manager/modules/utils/pom.xml
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java
M backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml
21 files changed, 453 insertions(+), 332 deletions(-)

Approvals:
  Yair Zaslavsky: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/27785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1
Gerrit-PatchSet: 37
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


From automation at ovirt.org  Wed May 21 11:32:45 2014
From: automation at ovirt.org (automation at ovirt.org)
Date: Wed, 21 May 2014 07:32:45 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: Changes to
	ExtensionsManager
In-Reply-To: <gerrit.1400325139613.I1c914df29a0dbf52ff6d2f8149687b31b4faffe1@gerrit.ovirt.org>
References: <gerrit.1400325139613.I1c914df29a0dbf52ff6d2f8149687b31b4faffe1@gerrit.ovirt.org>
Message-ID: <201405211132.s4LBWj1A009301@gerrit.ovirt.org>

automation at ovirt.org has posted comments on this change.

Change subject: aaa: Changes to ExtensionsManager
......................................................................


Patch Set 37:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED: IGNORE, no Bug-Url found.

-- 
To view, visit http://gerrit.ovirt.org/27785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1
Gerrit-PatchSet: 37
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From automation at ovirt.org  Wed May 21 11:32:59 2014
From: automation at ovirt.org (automation at ovirt.org)
Date: Wed, 21 May 2014 07:32:59 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: extmgr: use
	extension class loader when calling extension
In-Reply-To: <gerrit.1400509936513.I38031776f1d740da8f8f07f0d4a52b640534bcff@gerrit.ovirt.org>
References: <gerrit.1400509936513.I38031776f1d740da8f8f07f0d4a52b640534bcff@gerrit.ovirt.org>
Message-ID: <201405211132.s4LBWxR4009358@gerrit.ovirt.org>

automation at ovirt.org has posted comments on this change.

Change subject: extmgr: use extension class loader when calling extension
......................................................................


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])

-- 
To view, visit http://gerrit.ovirt.org/27875
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38031776f1d740da8f8f07f0d4a52b640534bcff
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From yzaslavs at redhat.com  Wed May 21 11:33:15 2014
From: yzaslavs at redhat.com (yzaslavs at redhat.com)
Date: Wed, 21 May 2014 07:33:15 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: extmgr: use
	extension class loader when calling extension
In-Reply-To: <gerrit.1400509936513.I38031776f1d740da8f8f07f0d4a52b640534bcff@gerrit.ovirt.org>
References: <gerrit.1400509936513.I38031776f1d740da8f8f07f0d4a52b640534bcff@gerrit.ovirt.org>
Message-ID: <201405211133.s4LBXG5u009396@gerrit.ovirt.org>

Yair Zaslavsky has posted comments on this change.

Change subject: extmgr: use extension class loader when calling extension
......................................................................


Patch Set 7: Verified+1 Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/27875
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38031776f1d740da8f8f07f0d4a52b640534bcff
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From yzaslavs at redhat.com  Wed May 21 11:33:19 2014
From: yzaslavs at redhat.com (yzaslavs at redhat.com)
Date: Wed, 21 May 2014 07:33:19 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: extmgr: use
	extension class loader when calling extension
In-Reply-To: <gerrit.1400509936513.I38031776f1d740da8f8f07f0d4a52b640534bcff@gerrit.ovirt.org>
References: <gerrit.1400509936513.I38031776f1d740da8f8f07f0d4a52b640534bcff@gerrit.ovirt.org>
Message-ID: <201405211133.s4LBXKmn009403@gerrit.ovirt.org>

Yair Zaslavsky has submitted this change and it was merged.

Change subject: extmgr: use extension class loader when calling extension
......................................................................


extmgr: use extension class loader when calling extension

currently the context class loader is set to the jboss module that is at
top level. this does not allow the extension to use extra dependencies
it may have in its module.xml.

to solve this we set the context class loader of the extension module
before calling the extension, in this case the extension finds all its
dependencies.

Change-Id: I38031776f1d740da8f8f07f0d4a52b640534bcff
Signed-off-by: Alon Bar-Lev <alonbl at redhat.com>
---
M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/Base.java
M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionProxy.java
M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java
3 files changed, 63 insertions(+), 49 deletions(-)

Approvals:
  Yair Zaslavsky: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/27875
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I38031776f1d740da8f8f07f0d4a52b640534bcff
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


From alonbl at redhat.com  Wed May 21 11:33:19 2014
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Wed, 21 May 2014 07:33:19 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: fixes to
	Authz utils
In-Reply-To: <gerrit.1400670985334.Iceff3f7355219e1887f4e8736d78af94f6ab310e@gerrit.ovirt.org>
References: <gerrit.1400670985334.Iceff3f7355219e1887f4e8736d78af94f6ab310e@gerrit.ovirt.org>
Message-ID: <201405211133.s4LBXK8P009406@gerrit.ovirt.org>

Alon Bar-Lev has posted comments on this change.

Change subject: aaa: fixes to Authz utils
......................................................................


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/27967
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iceff3f7355219e1887f4e8736d78af94f6ab310e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


From automation at ovirt.org  Wed May 21 11:33:36 2014
From: automation at ovirt.org (automation at ovirt.org)
Date: Wed, 21 May 2014 07:33:36 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: extmgr: use
	extension class loader when calling extension
In-Reply-To: <gerrit.1400509936513.I38031776f1d740da8f8f07f0d4a52b640534bcff@gerrit.ovirt.org>
References: <gerrit.1400509936513.I38031776f1d740da8f8f07f0d4a52b640534bcff@gerrit.ovirt.org>
Message-ID: <201405211133.s4LBXbl8009454@gerrit.ovirt.org>

automation at ovirt.org has posted comments on this change.

Change subject: extmgr: use extension class loader when calling extension
......................................................................


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED: IGNORE, no Bug-Url found.

-- 
To view, visit http://gerrit.ovirt.org/27875
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38031776f1d740da8f8f07f0d4a52b640534bcff
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From alonbl at redhat.com  Wed May 21 11:33:47 2014
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Wed, 21 May 2014 07:33:47 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: fixes to
	Authz utils
In-Reply-To: <gerrit.1400670985334.Iceff3f7355219e1887f4e8736d78af94f6ab310e@gerrit.ovirt.org>
References: <gerrit.1400670985334.Iceff3f7355219e1887f4e8736d78af94f6ab310e@gerrit.ovirt.org>
Message-ID: <201405211133.s4LBXmim009478@gerrit.ovirt.org>

Alon Bar-Lev has posted comments on this change.

Change subject: aaa: fixes to Authz utils
......................................................................


Patch Set 1:

yo can modify order of this and merge

-- 
To view, visit http://gerrit.ovirt.org/27967
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iceff3f7355219e1887f4e8736d78af94f6ab310e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


From mperina at redhat.com  Wed May 21 11:34:34 2014
From: mperina at redhat.com (mperina at redhat.com)
Date: Wed, 21 May 2014 07:34:34 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: fklsnr: Introduce
	standalone fence_kdump listener
In-Reply-To: <gerrit.1398777923179.Ieec3bad47bbba860a52a9ff4e2eb7f61277f4e36@gerrit.ovirt.org>
References: <gerrit.1398777923179.Ieec3bad47bbba860a52a9ff4e2eb7f61277f4e36@gerrit.ovirt.org>
Message-ID: <201405211134.s4LBYZmY009605@gerrit.ovirt.org>

Martin Pe?ina has posted comments on this change.

Change subject: fklsnr: Introduce standalone fence_kdump listener
......................................................................


Patch Set 11:

(14 comments)

http://gerrit.ovirt.org/#/c/27201/11/packaging/services/ovirt-fence-kdump-listener/db.py
File packaging/services/ovirt-fence-kdump-listener/db.py:

Line 180:         try:
Line 181:             with contextlib.closing(
Line 182:                     self._connection.cursor()
Line 183:             ) as cursor:
Line 184:                 cursor.callproc(
> please make sure that at rhel's old driver this is supported.
I verified it on Centos6 with python-psycopg2-2.0.14-2
Line 185:                     name,
Line 186:                     args,
Line 187:                 )
Line 188: 


Line 191:                     while True:
Line 192:                         entry = cursor.fetchone()
Line 193:                         if entry is None:
Line 194:                             break
Line 195:                         ret.append(dict(zip(cols, entry)))
> move the above to function as you reuse it now.
Done
Line 196:         except (psycopg2.Error, psycopg2.Warning) as e:
Line 197:             raise DbException(
Line 198:                 message=(
Line 199:                     "Error calling procedure '%s'" % name


Line 236:     def update_vds_kdump_status(self, vds_id, status, address):
Line 237:         return self._db_mgr.call_procedure(
Line 238:             name='UpsertKdumpStatus',
Line 239:             args=(
Line 240:                 vds_id,                          # v_vds_id
> the stored procedure can find the id its-self, you should provide the addre
It's very hard to parse errors from db exception. That's why I prefer to find vds_id in separate procedure.
Line 241:                 status,                          # v_status
Line 242:                 json.dumps(address),             # v_address
Line 243:             ),
Line 244:         )


http://gerrit.ovirt.org/#/c/27201/11/packaging/services/ovirt-fence-kdump-listener/listener.py
File packaging/services/ovirt-fence-kdump-listener/listener.py:

Line 28: class FenceKdumpListener(base.Base):
Line 29:     # Host kdump flow states
Line 30:     SESSION_STATE_INITIAL = 'started'
Line 31:     SESSION_STATE_DUMPING = 'dumping'
Line 32:     SESSION_STATE_CLOSED = 'finished'
> please be consistent ... CLOSED->FINISHED or finished->closed
Sorry, cut&paste your code (CLOSED), but I already had defined 'finished' as last status in engine.
Line 33: 
Line 34:     # buffer size to receive message
Line 35:     _BUF_SIZE = 0x20
Line 36: 


Line 126:                 _(
Line 127:                     "Discarding invalid message '{msg}' from address "
Line 128:                     "'{address}'."
Line 129:                 ).format(
Line 130:                     msg=binascii.hexlify(message),
> message.encode("hex") ?
Is there any difference I should know? I found this on internet when I searched how to achieve it ...
Line 131:                     address=entry['address'][0],
Line 132:                 )
Line 133:             )
Line 134: 


Line 129:                 ).format(
Line 130:                     msg=binascii.hexlify(message),
Line 131:                     address=entry['address'][0],
Line 132:                 )
Line 133:             )
> you should have caught the exception in this function... not at the run()
I need to stop processing if message is invalid. You didn't like that I called return after I logged an error in previous patch and you wanted me to throw an exception. So now I really don't understand :-(
Line 134: 
Line 135:         # message is valid, update timestamp
Line 136:         entry['updated'] = datetime.datetime.utcnow()
Line 137: 


Line 211:                 if session['status'] == 'finished':
Line 212:                     del self._sessions[session['address']]
Line 213: 
Line 214:     def _load_sessions(self):
Line 215:         self._lastDbSync = datetime.datetime.utcnow()
> this should be done part of house keeping at successful FIRST database conn
Well, it's needed only at startup now (if we drop the vdc_options updates, then on 1st db connection establish).
Anyway, I set updated of each session to this time, to prevent unneeded db updates on next sync ...
Line 216:         for record in self._dao.get_unfinished_sessions():
Line 217:             session = {
Line 218:                 'status': record['status'],
Line 219:                 'address': record['address'],


Line 220:                 'updated': self._lastDbSync,
Line 221:             }
Line 222:             self._sessions[session['address']] = session
Line 223: 
Line 224:     def _db_sync(self):
> this is part of house keeping
Well, I wanted session changes to be written into db asap, so in this case right after message accepted and validated. I didn't want to wait until next house keeping
Line 225:         if self._db_manager.validate_connection():
Line 226:             try:
Line 227:                 self._save_heartbeat()
Line 228:                 self._save_sessions()


Line 242:                 _(
Line 243:                     "Database connection is not available, synchronization "
Line 244:                     "will be postponed."
Line 245:                 )
Line 246:             )
> this message should appear once you lost connection and an info message sho
I wanted sysadmin to notice the problem and fix it asap, but OK, I will log only when db connection down detected for 1st time
Line 247: 
Line 248:     def run(self):
Line 249:         # load session from db
Line 250:         self._load_sessions()


Line 268:                         entry=entry,
Line 269:                         message=data,
Line 270:                     )
Line 271:                 except InvalidMessage as e:
Line 272:                     self.logger.error(e)
> this will create overflow within log if someone just sends invalid messages
I wanted to alert sysadmin that someone is sending non fence_kdump traffic to this port ...
Line 273: 
Line 274:             # try to sync with db
Line 275:             self._db_sync()
Line 276: 


http://gerrit.ovirt.org/#/c/27201/11/packaging/services/ovirt-fence-kdump-listener/ovirt-fence-kdump-listener.conf.in
File packaging/services/ovirt-fence-kdump-listener/ovirt-fence-kdump-listener.conf.in:

Line 1: #
Line 2: # This is a default configuration file for oVirt/RHEV-M fence_kdump listener
Line 3: #
Line 4: TRACE_ENABLE=False
Line 5: TRACE_FILE=
> do you use these?
AFAIK no, but they are part of every service, so I left them there ... I didn't have time to find out what they are for :-(
Line 6: ENGINE_USR="@ENGINE_USR@"
Line 7: 
Line 8: #
Line 9: # WARNING:


Line 2: # This is a default configuration file for oVirt/RHEV-M fence_kdump listener
Line 3: #
Line 4: TRACE_ENABLE=False
Line 5: TRACE_FILE=
Line 6: ENGINE_USR="@ENGINE_USR@"
> you do  not use ENGINE_USR
Sorry, it was left by mistake here, because it's used in ovirt-fence-kdump-listener.py in line 56 ...
Line 7: 
Line 8: #
Line 9: # WARNING:
Line 10: #    If some of the following options are changed, engine needs to be


Line 20: # Defines the IP address(es) to send fence_kdump messages to from hosts
Line 21: DESTINATION_ADDRESS=
Line 22: 
Line 23: # Defines interval in seconds between messages sent by fence_kdump
Line 24: MESSAGE_INTERVAL=5
> I do not understand this one
This is the parameter for fence_kdump_send how often the message should be sent from kdumping host. Default is 10 sec, but it seems to me too long, so I want 5 sec to be default in engine. It will be sent to host along with LISTENER_PORT and DESTINATION_ADDRESS during hostdeploy to configure fence_kdump in host.
Line 25: 
Line 26: # Defines the interval in seconds of listener's heartbeat updates
Line 27: HEARTBEAT_INTERVAL=5
Line 28: 


http://gerrit.ovirt.org/#/c/27201/11/packaging/services/ovirt-fence-kdump-listener/ovirt-fence-kdump-listener.py
File packaging/services/ovirt-fence-kdump-listener/ovirt-fence-kdump-listener.py:

Line 56:                 self._config.get("ENGINE_USR"),
Line 57:                 "services",
Line 58:             ),
Line 59:             directory=True,
Line 60:         )
> so you can drop ENGINE_USR from configuration and drop this one... as you d
Done
Line 61: 
Line 62:         if pidfile is not None:
Line 63:             self.check(
Line 64:                 name=pidfile,


-- 
To view, visit http://gerrit.ovirt.org/27201
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec3bad47bbba860a52a9ff4e2eb7f61277f4e36
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Pe?ina <mperina at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Martin Pe?ina <mperina at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


From gerrit2 at gerrit.ovirt.org  Wed May 21 11:35:33 2014
From: gerrit2 at gerrit.ovirt.org (oVirt Jenkins CI Server)
Date: Wed, 21 May 2014 07:35:33 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: core: fix typo
In-Reply-To: <gerrit.1400590630047.I92ddda877689209c2f4612de6a66f7177798efb7@gerrit.ovirt.org>
References: <gerrit.1400590630047.I92ddda877689209c2f4612de6a66f7177798efb7@gerrit.ovirt.org>
Message-ID: <201405211135.s4LBZXFm009665@gerrit.ovirt.org>

oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: fix typo
......................................................................


Patch Set 3:

Build Successful 

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/8662/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/7977/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/24905/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/27936
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92ddda877689209c2f4612de6a66f7177798efb7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From gerrit2 at gerrit.ovirt.org  Wed May 21 11:36:31 2014
From: gerrit2 at gerrit.ovirt.org (oVirt Jenkins CI Server)
Date: Wed, 21 May 2014 07:36:31 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: core: remove
	duplicated custom properties handling
In-Reply-To: <gerrit.1400513801630.I4c37a001985da09cbb7e3f78db1e419901d532cf@gerrit.ovirt.org>
References: <gerrit.1400513801630.I4c37a001985da09cbb7e3f78db1e419901d532cf@gerrit.ovirt.org>
Message-ID: <201405211136.s4LBaW87009770@gerrit.ovirt.org>

oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: remove duplicated custom properties handling
......................................................................


Patch Set 4:

Build Successful 

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/8660/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/7975/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/24903/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/27883
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c37a001985da09cbb7e3f78db1e419901d532cf
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From gerrit2 at gerrit.ovirt.org  Wed May 21 11:37:06 2014
From: gerrit2 at gerrit.ovirt.org (oVirt Jenkins CI Server)
Date: Wed, 21 May 2014 07:37:06 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: webadmin: adding
	labels column to Network->Hosts sub-tab
In-Reply-To: <gerrit.1393322004554.I610703df29dcae7ace390e0ebb109475fb202263@gerrit.ovirt.org>
References: <gerrit.1393322004554.I610703df29dcae7ace390e0ebb109475fb202263@gerrit.ovirt.org>
Message-ID: <201405211137.s4LBb74W009846@gerrit.ovirt.org>

oVirt Jenkins CI Server has posted comments on this change.

Change subject: webadmin: adding labels column to Network->Hosts sub-tab
......................................................................


Patch Set 16:

Build Successful 

http://jenkins.ovirt.org/job/ovirt-engine_master_dao-unit-tests_merged/7265/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_merged/7944/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_merged/7579/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_animal-sniffer_merged/6840/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_merged/2652/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/24992
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I610703df29dcae7ace390e0ebb109475fb202263
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From jenkins at ovirt.org  Wed May 21 11:37:30 2014
From: jenkins at ovirt.org (Jenkins ci oVirt Server)
Date: Wed, 21 May 2014 12:37:30 +0100 (BST)
Subject: [Engine-patches] [oVirt Jenkins]
 ovirt-engine_master_dao_unit_tests_gerrit - Build # 2506 - Fixed!
In-Reply-To: <1695771409.3820.1400669556722.JavaMail.jenkins@jenkins.ovirt.org>
References: <1695771409.3820.1400669556722.JavaMail.jenkins@jenkins.ovirt.org>
Message-ID: <525362814.3826.1400672251133.JavaMail.jenkins@jenkins.ovirt.org>

Project: http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/ 
Build: http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/2506/
Build Number: 2506
Build Status:  Fixed
Triggered By: Manually triggered by user anonymous for Gerrit: http://gerrit.ovirt.org/18176

-------------------------------------
Changes Since Last Success:
-------------------------------------
Changes for Build #2484
[Daniel Erez] core: avoid broken status on snapshot removal


Changes for Build #2485

Changes for Build #2486

Changes for Build #2487

Changes for Build #2488

Changes for Build #2489
[Shahar Havivi] core: Add Audit log for failed to run prestarted VMs


Changes for Build #2490

Changes for Build #2491
[Martin Mucha] core: MacPoolManager-->ScopedMacPoolManager


Changes for Build #2492
[Anmol Babu] engine: TimeConversions in GlusterVolumeProfileInfoReturnForXmlRpc


Changes for Build #2493
[Anmol Babu] engine: TimeConversions in GlusterVolumeProfileInfoReturnForXmlRpc


Changes for Build #2494

Changes for Build #2495
[Vered Volansky] core: Consolidating DiskValidator's RO validations


Changes for Build #2496
[Anmol Babu] engine: TimeConversions in GlusterVolumeProfileInfoReturnForXmlRpc


Changes for Build #2497

Changes for Build #2498

Changes for Build #2499
[Alona Kaplan] engine: errors in audit log- VDS_SET_NONOPERATIONAL_IFACE_DOWN


Changes for Build #2500

Changes for Build #2501
[Federico Simoncelli] core: add the domain detaching state


Changes for Build #2502

Changes for Build #2503

Changes for Build #2504
[Anmol Babu] engine: TimeConversions in GlusterVolumeProfileInfoReturnForXmlRpc


Changes for Build #2505
[Anmol Babu] engine: TimeConversions in GlusterVolumeProfileInfoReturnForXmlRpc


Changes for Build #2506
[Frantisek Kobzik] backend: Control virtio rng device




-----------------
Failed Tests:
-----------------
All tests passed 


From gerrit2 at gerrit.ovirt.org  Wed May 21 11:37:32 2014
From: gerrit2 at gerrit.ovirt.org (oVirt Jenkins CI Server)
Date: Wed, 21 May 2014 07:37:32 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: backend: Control
	virtio rng device
In-Reply-To: <gerrit.1376573888048.Ifc26a484c84244074426f4b0c790e2cc4ebb8da6@gerrit.ovirt.org>
References: <gerrit.1376573888048.Ifc26a484c84244074426f4b0c790e2cc4ebb8da6@gerrit.ovirt.org>
Message-ID: <201405211137.s4LBbWH5009862@gerrit.ovirt.org>

oVirt Jenkins CI Server has posted comments on this change.

Change subject: backend: Control virtio rng device
......................................................................


Patch Set 22:

Build Unstable 

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/8651/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_3.4_update_db_to_master_gerrit/999/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/1968/ : The patch does not pass the tests

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/2506/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/7966/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/24894/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/18176
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc26a484c84244074426f4b0c790e2cc4ebb8da6
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From alonbl at redhat.com  Wed May 21 11:40:05 2014
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Wed, 21 May 2014 07:40:05 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: fklsnr: Introduce
	standalone fence_kdump listener
In-Reply-To: <gerrit.1398777923179.Ieec3bad47bbba860a52a9ff4e2eb7f61277f4e36@gerrit.ovirt.org>
References: <gerrit.1398777923179.Ieec3bad47bbba860a52a9ff4e2eb7f61277f4e36@gerrit.ovirt.org>
Message-ID: <201405211140.s4LBe696010025@gerrit.ovirt.org>

Alon Bar-Lev has posted comments on this change.

Change subject: fklsnr: Introduce standalone fence_kdump listener
......................................................................


Patch Set 11:

(6 comments)

http://gerrit.ovirt.org/#/c/27201/11/packaging/services/ovirt-fence-kdump-listener/db.py
File packaging/services/ovirt-fence-kdump-listener/db.py:

Line 236:     def update_vds_kdump_status(self, vds_id, status, address):
Line 237:         return self._db_mgr.call_procedure(
Line 238:             name='UpsertKdumpStatus',
Line 239:             args=(
Line 240:                 vds_id,                          # v_vds_id
> It's very hard to parse errors from db exception. That's why I prefer to fi
return # of lines modified or a value, not an error.
Line 241:                 status,                          # v_status
Line 242:                 json.dumps(address),             # v_address
Line 243:             ),
Line 244:         )


http://gerrit.ovirt.org/#/c/27201/11/packaging/services/ovirt-fence-kdump-listener/listener.py
File packaging/services/ovirt-fence-kdump-listener/listener.py:

Line 126:                 _(
Line 127:                     "Discarding invalid message '{msg}' from address "
Line 128:                     "'{address}'."
Line 129:                 ).format(
Line 130:                     msg=binascii.hexlify(message),
> Is there any difference I should know? I found this on internet when I sear
less dependencies makes me happy.
Line 131:                     address=entry['address'][0],
Line 132:                 )
Line 133:             )
Line 134: 


Line 129:                 ).format(
Line 130:                     msg=binascii.hexlify(message),
Line 131:                     address=entry['address'][0],
Line 132:                 )
Line 133:             )
> I need to stop processing if message is invalid. You didn't like that I cal
you should have:

 try:
     function body, throw an excpetion if error
 catch E:
     move entry to CLOSED state

all within the same function
Line 134: 
Line 135:         # message is valid, update timestamp
Line 136:         entry['updated'] = datetime.datetime.utcnow()
Line 137: 


Line 211:                 if session['status'] == 'finished':
Line 212:                     del self._sessions[session['address']]
Line 213: 
Line 214:     def _load_sessions(self):
Line 215:         self._lastDbSync = datetime.datetime.utcnow()
> Well, it's needed only at startup now (if we drop the vdc_options updates, 
we need this at fist database connection establish, so we can start without database
Line 216:         for record in self._dao.get_unfinished_sessions():
Line 217:             session = {
Line 218:                 'status': record['status'],
Line 219:                 'address': record['address'],


Line 220:                 'updated': self._lastDbSync,
Line 221:             }
Line 222:             self._sessions[session['address']] = session
Line 223: 
Line 224:     def _db_sync(self):
> Well, I wanted session changes to be written into db asap, so in this case 
why? what's the rush?

the entire point was to relief load from database, even if we get 100000000 packets per second we persist once in 5 seconds or so.
Line 225:         if self._db_manager.validate_connection():
Line 226:             try:
Line 227:                 self._save_heartbeat()
Line 228:                 self._save_sessions()


Line 268:                         entry=entry,
Line 269:                         message=data,
Line 270:                     )
Line 271:                 except InvalidMessage as e:
Line 272:                     self.logger.error(e)
> I wanted to alert sysadmin that someone is sending non fence_kdump traffic 
yes, but you end up with filling his filesystem, causing server to halt.
Line 273: 
Line 274:             # try to sync with db
Line 275:             self._db_sync()
Line 276: 


-- 
To view, visit http://gerrit.ovirt.org/27201
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec3bad47bbba860a52a9ff4e2eb7f61277f4e36
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Pe?ina <mperina at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Martin Pe?ina <mperina at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


From gerrit2 at gerrit.ovirt.org  Wed May 21 11:42:00 2014
From: gerrit2 at gerrit.ovirt.org (oVirt Jenkins CI Server)
Date: Wed, 21 May 2014 07:42:00 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: fixes to
	Authz utils
In-Reply-To: <gerrit.1400670985334.Iceff3f7355219e1887f4e8736d78af94f6ab310e@gerrit.ovirt.org>
References: <gerrit.1400670985334.Iceff3f7355219e1887f4e8736d78af94f6ab310e@gerrit.ovirt.org>
Message-ID: <201405211142.s4LBg1R1010242@gerrit.ovirt.org>

oVirt Jenkins CI Server has posted comments on this change.

Change subject: aaa: fixes to Authz utils
......................................................................


Patch Set 1: Code-Review-1 Verified-1

Build Unstable 

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/8656/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/7971/ : The patch does not pass the findbugs

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/24899/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/27967
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iceff3f7355219e1887f4e8736d78af94f6ab310e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From gerrit2 at gerrit.ovirt.org  Wed May 21 11:42:16 2014
From: gerrit2 at gerrit.ovirt.org (oVirt Jenkins CI Server)
Date: Wed, 21 May 2014 07:42:16 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: First draft for
	engine-setup splitting
In-Reply-To: <gerrit.1399999526720.I4d465766f10a490bd213ca3510d02b3d6fdfa7c6@gerrit.ovirt.org>
References: <gerrit.1399999526720.I4d465766f10a490bd213ca3510d02b3d6fdfa7c6@gerrit.ovirt.org>
Message-ID: <201405211142.s4LBgHY5010256@gerrit.ovirt.org>

oVirt Jenkins CI Server has posted comments on this change.

Change subject: First draft for engine-setup splitting
......................................................................


Patch Set 13: Code-Review+1

Build Successful 

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/1967/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/27647
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d465766f10a490bd213ca3510d02b3d6fdfa7c6
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From gerrit2 at gerrit.ovirt.org  Wed May 21 11:42:49 2014
From: gerrit2 at gerrit.ovirt.org (oVirt Jenkins CI Server)
Date: Wed, 21 May 2014 07:42:49 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: Extensions
	tester tool
In-Reply-To: <gerrit.1400422425890.I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886@gerrit.ovirt.org>
References: <gerrit.1400422425890.I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886@gerrit.ovirt.org>
Message-ID: <201405211142.s4LBgotX010289@gerrit.ovirt.org>

oVirt Jenkins CI Server has posted comments on this change.

Change subject: aaa: Extensions tester tool
......................................................................


Patch Set 13: Code-Review-1 Verified-1

Build Failed 

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/8658/ : FAILURE

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/1971/ : The patch does not pass the tests

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/7973/ : The patch does not pass the findbugs

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/24901/ : The patch did not pass the checkstyle, please fix

-- 
To view, visit http://gerrit.ovirt.org/27814
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From jmoskovc at redhat.com  Wed May 21 11:45:08 2014
From: jmoskovc at redhat.com (jmoskovc at redhat.com)
Date: Wed, 21 May 2014 07:45:08 -0400
Subject: [Engine-patches] Change in ovirt-hosted-engine-ha[master]: don't
	use direct io on block devices
Message-ID: <gerrit.1400672708292.Ie5264e1757e43f22e860af3869495ebab15e0d85@gerrit.ovirt.org>

Ji?? Moskov??k has uploaded a new change for review.

Change subject: don't use direct io on block devices
......................................................................

don't use direct io on block devices

In python the O_DIRECT flag doesn't work properly,
because it needs the buffer alligned to 512B to read into and
in python it's not possible to control the size so the attempt
to read from file using O_DIRECT fails with an os exception.
It's also doubtful if it ever worked as intended because the
code used direct_io only to read, but not write.

Change-Id: Ie5264e1757e43f22e860af3869495ebab15e0d85
Signed-off-by: Jiri Moskovcak <jmoskovc at redhat.com>
---
M ovirt_hosted_engine_ha/broker/storage_broker.py
M ovirt_hosted_engine_ha/env/constants.py.in
M ovirt_hosted_engine_ha/lib/storage_backends.py
3 files changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-hosted-engine-ha refs/changes/71/27971/1

diff --git a/ovirt_hosted_engine_ha/broker/storage_broker.py b/ovirt_hosted_engine_ha/broker/storage_broker.py
index 5ffe238..5ee8660 100644
--- a/ovirt_hosted_engine_ha/broker/storage_broker.py
+++ b/ovirt_hosted_engine_ha/broker/storage_broker.py
@@ -112,7 +112,7 @@
         # from hiding metadata file updates from other hosts.  For NFS, we
         # don't have to worry about alignment; see man open(2) for details.
         # TODO it would be better if this was configurable
-        direct_flag = (os.O_DIRECT if constants.USE_DIRECT_IO else 0)
+        direct_flag = (os.O_DIRECT if self._backends[client].direct_io else 0)
 
         bs = constants.HOST_SEGMENT_BYTES
         # TODO it would be better if this was configurable
diff --git a/ovirt_hosted_engine_ha/env/constants.py.in b/ovirt_hosted_engine_ha/env/constants.py.in
index 3fefd40..1a3064a 100644
--- a/ovirt_hosted_engine_ha/env/constants.py.in
+++ b/ovirt_hosted_engine_ha/env/constants.py.in
@@ -26,7 +26,6 @@
 HOST_SEGMENT_BYTES = 4096
 METADATA_BLOCK_BYTES = 512
 SERVICE_TYPE = 'hosted-engine'
-USE_DIRECT_IO = True
 HOST_ALIVE_TIMEOUT_SECS = 60
 
 # See http://www.gnu.org/software/automake/manual/html_node/Scripts.html
diff --git a/ovirt_hosted_engine_ha/lib/storage_backends.py b/ovirt_hosted_engine_ha/lib/storage_backends.py
index b6c1305..37db6f7 100644
--- a/ovirt_hosted_engine_ha/lib/storage_backends.py
+++ b/ovirt_hosted_engine_ha/lib/storage_backends.py
@@ -31,6 +31,7 @@
     __metaclass__ = ABCMeta
 
     def __init__(self):
+        self.direct_io = True
         # the atomic block size of the underlying storage
         self._blocksize = constants.METADATA_BLOCK_BYTES
 
@@ -317,6 +318,8 @@
 
     def __init__(self, block_dev_name, dm_prefix):
         super(BlockBackend, self).__init__()
+        # direct io doesn't work for block devices
+        self.direct_io = False
         self._block_dev_name = block_dev_name
         self._dm_prefix = dm_prefix.replace("-", "--")
         self._services = {}


-- 
To view, visit http://gerrit.ovirt.org/27971
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie5264e1757e43f22e860af3869495ebab15e0d85
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Ji?? Moskov??k <jmoskovc at redhat.com>


From automation at ovirt.org  Wed May 21 11:45:09 2014
From: automation at ovirt.org (automation at ovirt.org)
Date: Wed, 21 May 2014 07:45:09 -0400
Subject: [Engine-patches] Change in ovirt-hosted-engine-ha[master]: don't
	use direct io on block devices
In-Reply-To: <gerrit.1400672708292.Ie5264e1757e43f22e860af3869495ebab15e0d85@gerrit.ovirt.org>
References: <gerrit.1400672708292.Ie5264e1757e43f22e860af3869495ebab15e0d85@gerrit.ovirt.org>
Message-ID: <201405211145.s4LBj9RT010430@gerrit.ovirt.org>

automation at ovirt.org has posted comments on this change.

Change subject: don't use direct io on block devices
......................................................................


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit http://gerrit.ovirt.org/27971
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5264e1757e43f22e860af3869495ebab15e0d85
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Ji?? Moskov??k <jmoskovc at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


From gerrit2 at gerrit.ovirt.org  Wed May 21 11:45:39 2014
From: gerrit2 at gerrit.ovirt.org (oVirt Jenkins CI Server)
Date: Wed, 21 May 2014 07:45:39 -0400
Subject: [Engine-patches] Change in ovirt-hosted-engine-ha[master]: don't
	use direct io on block devices
In-Reply-To: <gerrit.1400672708292.Ie5264e1757e43f22e860af3869495ebab15e0d85@gerrit.ovirt.org>
References: <gerrit.1400672708292.Ie5264e1757e43f22e860af3869495ebab15e0d85@gerrit.ovirt.org>
Message-ID: <201405211145.s4LBjd1T010463@gerrit.ovirt.org>

oVirt Jenkins CI Server has posted comments on this change.

Change subject: don't use direct io on block devices
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/ovirt-hosted-engine-ha_gerrit/304/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/27971
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5264e1757e43f22e860af3869495ebab15e0d85
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Ji?? Moskov??k <jmoskovc at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From gerrit2 at gerrit.ovirt.org  Wed May 21 11:46:04 2014
From: gerrit2 at gerrit.ovirt.org (oVirt Jenkins CI Server)
Date: Wed, 21 May 2014 07:46:04 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: extmgr: use
	extension class loader when calling extension
In-Reply-To: <gerrit.1400509936513.I38031776f1d740da8f8f07f0d4a52b640534bcff@gerrit.ovirt.org>
References: <gerrit.1400509936513.I38031776f1d740da8f8f07f0d4a52b640534bcff@gerrit.ovirt.org>
Message-ID: <201405211146.s4LBk4TG010498@gerrit.ovirt.org>

oVirt Jenkins CI Server has posted comments on this change.

Change subject: extmgr: use extension class loader when calling extension
......................................................................


Patch Set 7:

Build Successful 

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/8664/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/7979/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/24907/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/27875
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38031776f1d740da8f8f07f0d4a52b640534bcff
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From gerrit2 at gerrit.ovirt.org  Wed May 21 11:46:17 2014
From: gerrit2 at gerrit.ovirt.org (oVirt Jenkins CI Server)
Date: Wed, 21 May 2014 07:46:17 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: Extensions
	tester tool
In-Reply-To: <gerrit.1400422425890.I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886@gerrit.ovirt.org>
References: <gerrit.1400422425890.I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886@gerrit.ovirt.org>
Message-ID: <201405211146.s4LBkHKY010533@gerrit.ovirt.org>

oVirt Jenkins CI Server has posted comments on this change.

Change subject: aaa: Extensions tester tool
......................................................................


Patch Set 15: Code-Review-1 Verified-1

Build Unstable 

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/8661/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/1973/ : The patch does not pass the tests

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/7976/ : The patch does not pass the findbugs

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/24904/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/27814
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From automation at ovirt.org  Wed May 21 11:48:36 2014
From: automation at ovirt.org (automation at ovirt.org)
Date: Wed, 21 May 2014 07:48:36 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: engine : Introduce
	TimeConverter
In-Reply-To: <gerrit.1399468293188.I045aaa4f93b345e0457e1a0ce2ccf0ceeb9071ad@gerrit.ovirt.org>
References: <gerrit.1399468293188.I045aaa4f93b345e0457e1a0ce2ccf0ceeb9071ad@gerrit.ovirt.org>
Message-ID: <201405211148.s4LBmauK010698@gerrit.ovirt.org>

automation at ovirt.org has posted comments on this change.

Change subject: engine : Introduce TimeConverter
......................................................................


Patch Set 13:

* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])

-- 
To view, visit http://gerrit.ovirt.org/27469
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I045aaa4f93b345e0457e1a0ce2ccf0ceeb9071ad
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu at redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa at redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From mperina at redhat.com  Wed May 21 11:48:49 2014
From: mperina at redhat.com (mperina at redhat.com)
Date: Wed, 21 May 2014 07:48:49 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: fklsnr: Introduce
	standalone fence_kdump listener
In-Reply-To: <gerrit.1398777923179.Ieec3bad47bbba860a52a9ff4e2eb7f61277f4e36@gerrit.ovirt.org>
References: <gerrit.1398777923179.Ieec3bad47bbba860a52a9ff4e2eb7f61277f4e36@gerrit.ovirt.org>
Message-ID: <201405211148.s4LBmoQU010728@gerrit.ovirt.org>

Martin Pe?ina has posted comments on this change.

Change subject: fklsnr: Introduce standalone fence_kdump listener
......................................................................


Patch Set 11:

(2 comments)

http://gerrit.ovirt.org/#/c/27201/11/packaging/services/ovirt-fence-kdump-listener/listener.py
File packaging/services/ovirt-fence-kdump-listener/listener.py:

Line 126:                 _(
Line 127:                     "Discarding invalid message '{msg}' from address "
Line 128:                     "'{address}'."
Line 129:                 ).format(
Line 130:                     msg=binascii.hexlify(message),
> less dependencies makes me happy.
OK :-)
Line 131:                     address=entry['address'][0],
Line 132:                 )
Line 133:             )
Line 134: 


Line 220:                 'updated': self._lastDbSync,
Line 221:             }
Line 222:             self._sessions[session['address']] = session
Line 223: 
Line 224:     def _db_sync(self):
> why? what's the rush?
We will receive valid message each 5 seconds for each kdumping host (if no message is lost), so there won't be that much traffic :-)

If 1st message won't be written in db until KdumpStartedTimeout passed in engine, then host will be fenced. That's what I fear most ...
Line 225:         if self._db_manager.validate_connection():
Line 226:             try:
Line 227:                 self._save_heartbeat()
Line 228:                 self._save_sessions()


-- 
To view, visit http://gerrit.ovirt.org/27201
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec3bad47bbba860a52a9ff4e2eb7f61277f4e36
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Pe?ina <mperina at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Martin Pe?ina <mperina at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


From automation at ovirt.org  Wed May 21 11:49:08 2014
From: automation at ovirt.org (automation at ovirt.org)
Date: Wed, 21 May 2014 07:49:08 -0400
Subject: [Engine-patches] Change in ovirt-hosted-engine-ha[master]: create
	the logical volumes with proper owner and tag
In-Reply-To: <gerrit.1399366244415.I91b9b23d5a38f4468c332de092b4a1147ee1d66e@gerrit.ovirt.org>
References: <gerrit.1399366244415.I91b9b23d5a38f4468c332de092b4a1147ee1d66e@gerrit.ovirt.org>
Message-ID: <201405211149.s4LBn84j010775@gerrit.ovirt.org>

automation at ovirt.org has posted comments on this change.

Change subject: create the logical volumes with proper owner and tag
......................................................................


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit http://gerrit.ovirt.org/27400
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91b9b23d5a38f4468c332de092b4a1147ee1d66e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Ji?? Moskov??k <jmoskovc at redhat.com>
Gerrit-Reviewer: Ji?? Moskov??k <jmoskovc at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From gerrit2 at gerrit.ovirt.org  Wed May 21 11:49:37 2014
From: gerrit2 at gerrit.ovirt.org (oVirt Jenkins CI Server)
Date: Wed, 21 May 2014 07:49:37 -0400
Subject: [Engine-patches] Change in ovirt-hosted-engine-ha[master]: create
	the logical volumes with proper owner and tag
In-Reply-To: <gerrit.1399366244415.I91b9b23d5a38f4468c332de092b4a1147ee1d66e@gerrit.ovirt.org>
References: <gerrit.1399366244415.I91b9b23d5a38f4468c332de092b4a1147ee1d66e@gerrit.ovirt.org>
Message-ID: <201405211149.s4LBnbWm010806@gerrit.ovirt.org>

oVirt Jenkins CI Server has posted comments on this change.

Change subject: create the logical volumes with proper owner and tag
......................................................................


Patch Set 4:

Build Successful 

http://jenkins.ovirt.org/job/ovirt-hosted-engine-ha_gerrit/305/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/27400
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91b9b23d5a38f4468c332de092b4a1147ee1d66e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Ji?? Moskov??k <jmoskovc at redhat.com>
Gerrit-Reviewer: Ji?? Moskov??k <jmoskovc at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From gerrit2 at gerrit.ovirt.org  Wed May 21 11:50:28 2014
From: gerrit2 at gerrit.ovirt.org (oVirt Jenkins CI Server)
Date: Wed, 21 May 2014 07:50:28 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: aaa: Changes to
	ExtensionsManager
In-Reply-To: <gerrit.1400325139613.I1c914df29a0dbf52ff6d2f8149687b31b4faffe1@gerrit.ovirt.org>
References: <gerrit.1400325139613.I1c914df29a0dbf52ff6d2f8149687b31b4faffe1@gerrit.ovirt.org>
Message-ID: <201405211150.s4LBoT1P010848@gerrit.ovirt.org>

oVirt Jenkins CI Server has posted comments on this change.

Change subject: aaa: Changes to ExtensionsManager
......................................................................


Patch Set 37:

Build Successful 

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/8663/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/7978/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/24906/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/27785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1
Gerrit-PatchSet: 37
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From ahadas at redhat.com  Wed May 21 11:50:29 2014
From: ahadas at redhat.com (ahadas at redhat.com)
Date: Wed, 21 May 2014 07:50:29 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: core: Adding
	import of unregistered VM template
In-Reply-To: <gerrit.1399885373314.I4fc184e687cbeebf4aa732c901f98222d5b11097@gerrit.ovirt.org>
References: <gerrit.1399885373314.I4fc184e687cbeebf4aa732c901f98222d5b11097@gerrit.ovirt.org>
Message-ID: <201405211150.s4LBoTk6010852@gerrit.ovirt.org>

Arik Hadas has posted comments on this change.

Change subject: core: Adding import of unregistered VM template
......................................................................


Patch Set 12: Code-Review+1

moved my question to the previous patch, besides it, it looks ok to me

-- 
To view, visit http://gerrit.ovirt.org/27581
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fc184e687cbeebf4aa732c901f98222d5b11097
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From ahadas at redhat.com  Wed May 21 11:50:39 2014
From: ahadas at redhat.com (ahadas at redhat.com)
Date: Wed, 21 May 2014 07:50:39 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: core: Use import
	command to register a VM
In-Reply-To: <gerrit.1398859070760.I5ee64651eb614feb6ac9d7fde88a4ee6348aff06@gerrit.ovirt.org>
References: <gerrit.1398859070760.I5ee64651eb614feb6ac9d7fde88a4ee6348aff06@gerrit.ovirt.org>
Message-ID: <201405211150.s4LBoeLM010866@gerrit.ovirt.org>

Arik Hadas has posted comments on this change.

Change subject: core: Use import command to register a VM
......................................................................


Patch Set 20:

(2 comments)

http://gerrit.ovirt.org/#/c/27247/20/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java:

Line 243:             return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_IMPORT_CLONE_NOT_COLLAPSED);
Line 244:         }
Line 245: 
Line 246:         if (isImagesAlreadyOnTarget() && getParameters().getCopyCollapse()) {
Line 247:             return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_IMPORT_UNREGISTERED_NOT_COLLAPSED);
Note that the combination of #242 and #246 means that we won't be able to import unregistered VM as new entity, and we do allow it for templates - why can't we import an unregistered VM as new entity (with copy-collapse) ?
Line 248:         }
Line 249: 
Line 250:         setSourceDomainId(getParameters().getSourceDomainId());
Line 251:         StorageDomainValidator validator = new StorageDomainValidator(getSourceDomain());


Line 610:         boolean verified = true;
Line 611:         if (!getParameters().isImportAsNewEntity() && !isImagesAlreadyOnTarget()) {
Line 612:             verified = checkIfDisksExist(imageList);
Line 613:         }
Line 614:         return verified;
ok, so if we keep this method, can you please remove the 'verified' variable? it is not really needed, and then people will add more logic into this method and we'll end-up with complicated methods like the old canDoAction methods..
Line 615:     }
Line 616: 
Line 617:     private boolean templateExists() {
Line 618:         if (getVmTemplate() == null && !getParameters().getCopyCollapse()) {


-- 
To view, visit http://gerrit.ovirt.org/27247
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ee64651eb614feb6ac9d7fde88a4ee6348aff06
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


From ahadas at redhat.com  Wed May 21 11:51:17 2014
From: ahadas at redhat.com (ahadas at redhat.com)
Date: Wed, 21 May 2014 07:51:17 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: core: fix typo
In-Reply-To: <gerrit.1400590630047.I92ddda877689209c2f4612de6a66f7177798efb7@gerrit.ovirt.org>
References: <gerrit.1400590630047.I92ddda877689209c2f4612de6a66f7177798efb7@gerrit.ovirt.org>
Message-ID: <201405211151.s4LBpHCt010950@gerrit.ovirt.org>

Arik Hadas has posted comments on this change.

Change subject: core: fix typo
......................................................................


Patch Set 3: Code-Review+2 Verified+1

-- 
To view, visit http://gerrit.ovirt.org/27936
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92ddda877689209c2f4612de6a66f7177798efb7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From ahadas at redhat.com  Wed May 21 11:51:25 2014
From: ahadas at redhat.com (ahadas at redhat.com)
Date: Wed, 21 May 2014 07:51:25 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: core: fix typo
In-Reply-To: <gerrit.1400590630047.I92ddda877689209c2f4612de6a66f7177798efb7@gerrit.ovirt.org>
References: <gerrit.1400590630047.I92ddda877689209c2f4612de6a66f7177798efb7@gerrit.ovirt.org>
Message-ID: <201405211151.s4LBpP1t010959@gerrit.ovirt.org>

Arik Hadas has submitted this change and it was merged.

Change subject: core: fix typo
......................................................................


core: fix typo

s/separete/separate

Change-Id: I92ddda877689209c2f4612de6a66f7177798efb7
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmUpdatesOnNextRunExistsQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmUpdatesOnNextRunExistsQueryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/customprop/VmPropertiesUtils.java
5 files changed, 8 insertions(+), 8 deletions(-)

Approvals:
  Arik Hadas: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/27936
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I92ddda877689209c2f4612de6a66f7177798efb7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


From automation at ovirt.org  Wed May 21 11:51:37 2014
From: automation at ovirt.org (automation at ovirt.org)
Date: Wed, 21 May 2014 07:51:37 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: core: fix typo
In-Reply-To: <gerrit.1400590630047.I92ddda877689209c2f4612de6a66f7177798efb7@gerrit.ovirt.org>
References: <gerrit.1400590630047.I92ddda877689209c2f4612de6a66f7177798efb7@gerrit.ovirt.org>
Message-ID: <201405211151.s4LBpbQw011011@gerrit.ovirt.org>

automation at ovirt.org has posted comments on this change.

Change subject: core: fix typo
......................................................................


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED: IGNORE, no Bug-Url found.

-- 
To view, visit http://gerrit.ovirt.org/27936
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92ddda877689209c2f4612de6a66f7177798efb7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From alonbl at redhat.com  Wed May 21 11:52:37 2014
From: alonbl at redhat.com (Alon Bar-Lev)
Date: Wed, 21 May 2014 07:52:37 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: fklsnr: Introduce
	standalone fence_kdump listener
In-Reply-To: <gerrit.1398777923179.Ieec3bad47bbba860a52a9ff4e2eb7f61277f4e36@gerrit.ovirt.org>
References: <gerrit.1398777923179.Ieec3bad47bbba860a52a9ff4e2eb7f61277f4e36@gerrit.ovirt.org>
Message-ID: <201405211152.s4LBqbJK011175@gerrit.ovirt.org>

Alon Bar-Lev has posted comments on this change.

Change subject: fklsnr: Introduce standalone fence_kdump listener
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.ovirt.org/#/c/27201/11/packaging/services/ovirt-fence-kdump-listener/listener.py
File packaging/services/ovirt-fence-kdump-listener/listener.py:

Line 220:                 'updated': self._lastDbSync,
Line 221:             }
Line 222:             self._sessions[session['address']] = session
Line 223: 
Line 224:     def _db_sync(self):
> We will receive valid message each 5 seconds for each kdumping host (if no 
what about if someone just send messages?

what if we have lots of hosts?

the rate in which we update the database should be detached (buffered) from the network activity.

this especially if we should work when database down, as every time you try to establish connection you are not responsive.

BTW: this reminds me that we should have a delay between database reconnection retries at house keeping... but first you need to track if database is up or down.
Line 225:         if self._db_manager.validate_connection():
Line 226:             try:
Line 227:                 self._save_heartbeat()
Line 228:                 self._save_sessions()


-- 
To view, visit http://gerrit.ovirt.org/27201
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec3bad47bbba860a52a9ff4e2eb7f61277f4e36
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Pe?ina <mperina at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Martin Pe?ina <mperina at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


From gerrit2 at gerrit.ovirt.org  Wed May 21 11:57:49 2014
From: gerrit2 at gerrit.ovirt.org (oVirt Jenkins CI Server)
Date: Wed, 21 May 2014 07:57:49 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: webadmin: adding
	labels column to Network->Hosts sub-tab
In-Reply-To: <gerrit.1393322004554.I610703df29dcae7ace390e0ebb109475fb202263@gerrit.ovirt.org>
References: <gerrit.1393322004554.I610703df29dcae7ace390e0ebb109475fb202263@gerrit.ovirt.org>
Message-ID: <201405211157.s4LBvou5011470@gerrit.ovirt.org>

oVirt Jenkins CI Server has posted comments on this change.

Change subject: webadmin: adding labels column to Network->Hosts sub-tab
......................................................................


Patch Set 16:

Build Successful 

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/8652/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/7967/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/24895/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/24992
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I610703df29dcae7ace390e0ebb109475fb202263
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


From laravot at redhat.com  Wed May 21 12:00:05 2014
From: laravot at redhat.com (laravot at redhat.com)
Date: Wed, 21 May 2014 08:00:05 -0400
Subject: [Engine-patches] Change in ovirt-engine[master]: core: add the
	domain detaching state
In-Reply-To: <gerrit.1390392829674.I5732ef00a67ef1381ee0b6f29d08ab39cf63a1bf@gerrit.ovirt.org>
References: <gerrit.1390392829674.I5732ef00a67ef1381ee0b6f29d08ab39cf63a1bf@gerrit.ovirt.org>
Message-ID: <201405211200.s4LC05qB011609@gerrit.ovirt.org>

Liron Ar has posted comments on this change.

Change subject: core: add the domain detaching state
......................................................................


Patch Set 9:

please add the new status to 
/frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties

-- 
To view, visit http://gerrit.ovirt.org/23556
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5732ef00a67ef1381ee0b6f29d08ab39cf63a1bf
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No