[Engine-patches] Change in ovirt-engine[master]: First draft for engine-setup splitting

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: First draft for engine-setup splitting
......................................................................


Patch Set 13:

(1 comment)

looks good!

I would have split the setup file changes to a patch prior to this, and keep in this patch all the house keeping of the actual split.

http://gerrit.ovirt.org/#/c/27647/13/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/jboss.py
File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/jboss.py:

Line 30
Line 31
Line 32
Line 33
Line 34
in all these, please keep the two spaces so you have clean patch


-- 
To view, visit http://gerrit.ovirt.org/27647
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d465766f10a490bd213ca3510d02b3d6fdfa7c6
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes