[Engine-patches] Change in ovirt-engine[master]: fklsnr: Introduce standalone fence_kdump listener

[mperina at redhat.com]

Martin Peřina has posted comments on this change.

Change subject: fklsnr: Introduce standalone fence_kdump listener
......................................................................


Patch Set 11:

(2 comments)

http://gerrit.ovirt.org/#/c/27201/11/packaging/services/ovirt-fence-kdump-listener/listener.py
File packaging/services/ovirt-fence-kdump-listener/listener.py:

Line 126:                 _(
Line 127:                     "Discarding invalid message '{msg}' from address "
Line 128:                     "'{address}'."
Line 129:                 ).format(
Line 130:                     msg=binascii.hexlify(message),
> less dependencies makes me happy.
OK :-)
Line 131:                     address=entry['address'][0],
Line 132:                 )
Line 133:             )
Line 134: 


Line 220:                 'updated': self._lastDbSync,
Line 221:             }
Line 222:             self._sessions[session['address']] = session
Line 223: 
Line 224:     def _db_sync(self):
> why? what's the rush?
We will receive valid message each 5 seconds for each kdumping host (if no message is lost), so there won't be that much traffic :-)

If 1st message won't be written in db until KdumpStartedTimeout passed in engine, then host will be fenced. That's what I fear most ...
Line 225:         if self._db_manager.validate_connection():
Line 226:             try:
Line 227:                 self._save_heartbeat()
Line 228:                 self._save_sessions()


-- 
To view, visit http://gerrit.ovirt.org/27201
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec3bad47bbba860a52a9ff4e2eb7f61277f4e36
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes