findbugs: 2 bll warnings, not related to patch?

[Allon Mureinik]

----- Original Message -----
> From: "Gilad Chaplik" <gchaplik at redhat.com>
> To: "Jiri Moskovcak" <jmoskovc at redhat.com>
> Cc: "Allon Mureinik" <amureini at redhat.com>, "Shahar Havivi" <shaharh at redhat.com>, "Einav Cohen" <ecohen at redhat.com>,
> infra at ovirt.org, "Doron Fediuck" <dfediuck at redhat.com>
> Sent: Wednesday, January 15, 2014 3:27:32 PM
> Subject: Re: findbugs: 2 bll warnings, not related to patch?
> 
> Thanks Einav for reporting :)
> 
> http://gerrit.ovirt.org/#/c/19285/ should fix it.
> 
> Thanks,
> Gilad.
This indeed fixes the issue:
http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/6264/

Thanks!

> 
> ----- Original Message -----
> > From: "Jiri Moskovcak" <jmoskovc at redhat.com>
> > To: "Allon Mureinik" <amureini at redhat.com>, "Shahar Havivi"
> > <shaharh at redhat.com>
> > Cc: "Einav Cohen" <ecohen at redhat.com>, infra at ovirt.org, "Gilad Chaplik"
> > <gchaplik at redhat.com>, "Doron Fediuck"
> > <dfediuck at redhat.com>
> > Sent: Wednesday, January 15, 2014 3:13:57 PM
> > Subject: Re: findbugs: 2 bll warnings, not related to patch?
> > 
> > On 01/15/2014 02:11 PM, Allon Mureinik wrote:
> > > Shahar/Einav - you are looking at the wrong patch.
> > >
> > > The "offending" patch with broke findbgus was merged yesterday:
> > > http://gerrit.ovirt.org/#/c/23103/
> > >
> > > See also:
> > > http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/6254/
> > >
> > > Jiri/Doron - can you please fix this?
> > >
> > 
> > I'm on it.
> > 
> > --Jirka
> > 
> > >
> > > Thanks,
> > > Allon
> > >
> > > ----- Original Message -----
> > >> From: "Shahar Havivi" <shaharh at redhat.com>
> > >> To: "Einav Cohen" <ecohen at redhat.com>
> > >> Cc: infra at ovirt.org, "Gilad Chaplik" <gchaplik at redhat.com>
> > >> Sent: Wednesday, January 15, 2014 3:02:54 PM
> > >> Subject: Re: findbugs: 2 bll warnings, not related to patch?
> > >>
> > >> On 15.01.14 07:57, Einav Cohen wrote:
> > >>> Hi Gilad[/infra],
> > >>>
> > >>> I would like to merge patch [1], however I am getting 2 findbugs
> > >>> warnings on the BLL [2].
> > >>>
> > >>> The patch is a frontend patch, so it has nothing to do with the
> > >>> BLL.
> > >>>
> > >>> findbugs is shouting on the 'equals' method of the PolicyUnit
> > >>> class [2]. it seems like the relevant code was merged quite
> > >>> a while ago [3] so I don't understand why it started shouting
> > >>> all of a sudden.
> > >>>
> > >>> any idea?
> > >> I get the same findbug errors as well
> > >> by looking at the log its looks like the last change is from August.
> > >> Maybe other change trigger it...
> > >>
> > >>>
> > >>> Many thanks in advance.
> > >>>
> > >>> ----
> > >>> Regards,
> > >>> Einav
> > >>>
> > >>> [1] http://gerrit.ovirt.org/#/c/23027/
> > >>> [2]
> > >>> http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs_gerrit/4708/findbugsResult/source.399/#119
> > >>> [3] http://gerrit.ovirt.org/#/c/16107/
> > >>>
> > >>> ----- Forwarded Message -----
> > >>> From: "oVirt Jenkins CI Server" <gerrit2 at gerrit.ovirt.org>
> > >>> To: "Alexander Wels" <awels at redhat.com>, "Einav Cohen"
> > >>> <ecohen at redhat.com>,
> > >>> "Gilad Chaplik" <gchaplik at redhat.com>
> > >>> Sent: Wednesday, January 15, 2014 7:38:37 AM
> > >>> Subject: Change in ovirt-engine[master]: webadmin: user session is kept
> > >>> alive
> > >>>
> > >>> oVirt Jenkins CI Server has posted comments on this change.
> > >>>
> > >>> Change subject: webadmin: user session is kept alive
> > >>> ......................................................................
> > >>>
> > >>>
> > >>> Patch Set 3: Code-Review-1
> > >>>
> > >>> Build Unstable
> > >>>
> > >>> http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit_old_using_plugin/5775/
> > >>> : SUCCESS
> > >>>
> > >>> http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/5/ :
> > >>> SUCCESS
> > >>>
> > >>> http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/16237/
> > >>> : SUCCESS
> > >>>
> > >>> http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs_gerrit/4708/
> > >>> :
> > >>> UNSTABLE
> > >>>
> > >>> --
> > >>> To view, visit http://gerrit.ovirt.org/23027
> > >>> To unsubscribe, visit http://gerrit.ovirt.org/settings
> > >>>
> > >>> Gerrit-MessageType: comment
> > >>> Gerrit-Change-Id: Ib99861bfdc41b98ceac0df7103acff5b9074f851
> > >>> Gerrit-PatchSet: 3
> > >>> Gerrit-Project: ovirt-engine
> > >>> Gerrit-Branch: master
> > >>> Gerrit-Owner: Gilad Chaplik <gchaplik at redhat.com>
> > >>> Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
> > >>> Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
> > >>> Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
> > >>> Gerrit-Reviewer: oVirt Jenkins CI Server
> > >>> Gerrit-HasComments: No
> > >>> _______________________________________________
> > >>> Infra mailing list
> > >>> Infra at ovirt.org
> > >>> http://lists.ovirt.org/mailman/listinfo/infra
> > >> _______________________________________________
> > >> Infra mailing list
> > >> Infra at ovirt.org
> > >> http://lists.ovirt.org/mailman/listinfo/infra
> > >>
> > 
> > 
>