[JIRA] (OVIRT-1507) Fix issues with slave setup code

[Barak Korren (oVirt JIRA)]

     [ https://ovirt-jira.atlassian.net/browse/OVIRT-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Barak Korren reassigned OVIRT-1507:
-----------------------------------

    Assignee: Barak Korren  (was: infra)

> Fix issues with slave setup code
> --------------------------------
>
>                 Key: OVIRT-1507
>                 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1507
>             Project: oVirt - virtualization made easy
>          Issue Type: Improvement
>          Components: oVirt CI
>            Reporter: Barak Korren
>            Assignee: Barak Korren
>            Priority: Highest
>              Labels: standard-ci
>
> We have several things that happen on each slave before the actual CI code that does the "real" work (usually mock_runner.sh) starts running. Here are these things in the order in which they run:
> # the whitelist filter runs ('{{whitelist-filter.sh}}')
> # a code to prevent running check-patch on merged patches runs
> # a generic slave cleanup script runs '{{cleanup_slave.sh}}'
> # the upstream source collection and re-basing runs '{{upstream-source-collector.py}}'
> Additionally for STD-CI jobs:
> # '{{global_setup.sh}}' runs
> # '{{mock_setup.sh}}' runs
> There are a few issues with the current scheme that need to be fixed:
> # '{{global_setup.sh}}' is meant to be run globally for everything, not just STD-CI jobs. 
> # '{{mock_setup.sh}}' includes several things that are not for setting up mock such as docker and python package installations
> # The cleanup script for mock '{{mock_cleanup.sh}}' cleans up some things that may not have to do just with mock (e.g. container images)
> # '{{upstream-source-collector.py}}' tries to use some python libraries before we ensure they are installed because it runs before the setup scripts (See [here|http://jenkins.ovirt.org/job/cockpit-ovirt_4.1_build-artifacts-fc24-x86_64/84/] for example failure because of this
> What we need to do:
> # Reorder scripts so that  '{{global_setup.sh}}'  is the 1st setup script that runs (more specifically, ensure that  '{{upstream-source-collector.py}}' runs after it).
> # Move general setup stages from  '{{mock_setup.sh}}' to '{{global_setup.sh}}'.
> # Move general cleanup stages to '{{cleanup_slave.sh}}', but ensure they do not fail if some packages are missing because it runs before '{{global_setup.sh}}'.



--
This message was sent by Atlassian JIRA
(v1000.1101.0#100054)