[Kimchi-devel] [project-kimchi] [PATCH] Organize python imports

[Ramon Medeiros]

First of all, congratulations. I think it's a very worth effort to keep 
the code complaint.

I have some questions!

why did you separated this imports? They can't be together?
>   import kimchi.mockmodel
>
>   #utils.silence_server()
> diff --git a/tests/test_vmtemplate.py b/tests/test_vmtemplate.py
> index 81382c7..92c7385 100644
> --- a/tests/test_vmtemplate.py
> +++ b/tests/test_vmtemplate.py
> @@ -23,9 +23,11 @@
>   import unittest
>   import uuid
>
> +
>   from kimchi.vmtemplate import *
>   from kimchi.xmlutils import xpath_get_text
>
> +
>   class VMTemplateTests(unittest.TestCase):
>       def test_minimal_construct(self):
>           fields = (('name', 'test'), ('os_distro', 'unknown'),
> diff --git a/tests/utils.py b/tests/utils.py
> index c114813..a7596e8 100644
> --- a/tests/utils.py
> +++ b/tests/utils.py
> @@ -21,16 +21,19 @@
>   # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
>   #
>
> -import httplib
> +import base64
>   import cherrypy
> -import threading
> -import time
> +import httplib
>   import os
> -import sys
>   import socket
> -from contextlib import closing
> +import sys
> +import threading
> +import time
>   import unittest
> -import base64
> +
> +
> +from contextlib import closing
> +
>
>   import kimchi.server
>   import kimchi.model
The same question here


-- 
Ramon Nunes Medeiros
Software Engineer - Linux Technology Center Brazil
IBM Systems & Technology Group
Phone : +55 19 2132 7878
ramonn at br.ibm.com

-- 
project-kimchi mailing list <project-kimchi at googlegroups.com>
https://groups.google.com/forum/#!forum/project-kimchi
--- 
You received this message because you are subscribed to the Google Groups "project-kimchi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to project-kimchi+unsubscribe at googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.