[Kimchi-devel] [PATCH 2/2] Simplify domain xml in featuretests.py

Daniel H Barboza danielhb at linux.vnet.ibm.com
Mon Dec 30 16:55:17 UTC 2013


Reviewed-by: Daniel Barboza <danielhb at linux.vnet.ibm.com>

On 12/30/2013 10:53 AM, Aline Manera wrote:
> From: Aline Manera <alinefm at br.ibm.com>
>
> The domain xml is used in order to check libvirt ISO streaming support.
> It can only contain the elements needed to test ISO streaming.
>
> Signed-off-by: Aline Manera <alinefm at br.ibm.com>
> ---
>   src/kimchi/featuretests.py |   16 ----------------
>   1 file changed, 16 deletions(-)
>
> diff --git a/src/kimchi/featuretests.py b/src/kimchi/featuretests.py
> index 6843a26..1ca3567 100644
> --- a/src/kimchi/featuretests.py
> +++ b/src/kimchi/featuretests.py
> @@ -32,23 +32,11 @@ from kimchi import config
>   ISO_STREAM_XML = """
>   <domain type='kvm'>
>     <name>ISO_STREAMING</name>
> -  <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
>     <memory unit='KiB'>1048576</memory>
> -  <currentMemory unit='KiB'>1048576</currentMemory>
> -  <vcpu placement='static'>1</vcpu>
>     <os>
>       <type arch='x86_64' machine='pc-1.2'>hvm</type>
>       <boot dev='cdrom'/>
>     </os>
> -  <features>
> -    <acpi/>
> -    <apic/>
> -    <pae/>
> -  </features>
> -  <clock offset='utc'/>
> -  <on_poweroff>destroy</on_poweroff>
> -  <on_reboot>restart</on_reboot>
> -  <on_crash>restart</on_crash>
>     <devices>
>       <disk type='network' device='cdrom'>
>         <driver name='qemu' type='raw'/>
> @@ -60,10 +48,6 @@ ISO_STREAM_XML = """
>         <alias name='ide0-1-0'/>
>         <address type='drive' controller='0' bus='1' target='0' unit='0'/>
>       </disk>
> -    <controller type='usb' index='0'/>
> -    <controller type='pci' index='0' model='pci-root'/>
> -    <controller type='ide' index='0'/>
> -    <memballoon model='virtio'/>
>     </devices>
>   </domain>"""
>




More information about the Kimchi-devel mailing list