[Kimchi-devel] [PATCH 0/3] bug fix: change power off to stop for VM and add a power off confirmation.

shaohef at linux.vnet.ibm.com shaohef at linux.vnet.ibm.com
Thu Apr 10 09:57:02 UTC 2014


From: ShaoHe Feng <shaohef at linux.vnet.ibm.com>

We will add a shutdown graceful API later.

"Stop" is obscure for user.
 
Currently, stopping guests in Kimchi is not graceful in the sense that
the guest becomes 'shut down' immediately. This could be be problematic
because guest file systems could become corrupted. Perhaps a warning
should be added before a guest is immediately stopped or reset.

So "power off" is more exact than "stop" in literal meaning.

The aciton power off a VM forcefully is same that we cut the physical
machine power. This action may produce undesirable results, for example
unflushed disk cache in the guest.

We should also add a confirmation to user.

ShaoHe Feng (3):
  change the stop to power off for VM in backend
  change the stop to power off for VM in UI
  add confirmation for power off  a VM

 docs/API.md                    |  3 ++-
 src/kimchi/control/vms.py      |  2 +-
 src/kimchi/i18n.py             |  2 +-
 src/kimchi/mockmodel.py        |  2 +-
 src/kimchi/model/vms.py        |  4 ++--
 tests/test_model.py            | 12 ++++++------
 tests/test_rest.py             | 12 ++++++------
 ui/js/src/kimchi.api.js        |  6 +++---
 ui/js/src/kimchi.guest_main.js | 23 ++++++++++++++++-------
 ui/pages/guest.html.tmpl       |  4 ++--
 ui/pages/help/guests.dita      |  2 +-
 ui/pages/i18n.html.tmpl        |  4 ++++
 12 files changed, 45 insertions(+), 31 deletions(-)

-- 
1.8.5.3




More information about the Kimchi-devel mailing list