[Kimchi-devel] [PATCH 2/3] repository: Make checkbox clickable

Crístian Viana vianac at linux.vnet.ibm.com
Thu Apr 24 16:50:36 UTC 2014


A good usability feature of an HTML form is to click on an element's
label to activate the element itself. For example, when clicking on a
checkbox's label, the checkbox itself is checked, instead of requiring
the user to click on the small corresponding element.

Assign the checkbox "Repository is a mirror" to its corresponding label.

Signed-off-by: Crístian Viana <vianac at linux.vnet.ibm.com>
---
 ui/pages/repository-add.html.tmpl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ui/pages/repository-add.html.tmpl b/ui/pages/repository-add.html.tmpl
index 839ba1d..28e12b7 100644
--- a/ui/pages/repository-add.html.tmpl
+++ b/ui/pages/repository-add.html.tmpl
@@ -66,8 +66,8 @@
                     </div>
                     <div class="field yum">
                         <p class="yum">
-                            <input type="checkbox" name="isMirror" value="true" />
-                            $_("Repository is a mirror.")
+                            <input type="checkbox" name="isMirror" value="true" id="isMirror" />
+                            <label for="isMirror">$_("Repository is a mirror.")</label>
                         </p>
                     </div>
                 </section>
-- 
1.9.0




More information about the Kimchi-devel mailing list