[Kimchi-devel] [PATCh V12 0/7] bug fix: get user and group when VM is running

shaohef at linux.vnet.ibm.com shaohef at linux.vnet.ibm.com
Tue Apr 29 15:45:30 UTC 2014


From: ShaoHe Feng <shaohef at linux.vnet.ibm.com>

V11 -> V12
remove the prefix of xml directly.
remove some duplicate code
pass the node insteal of xml to get/set metadata node function

V10 -> V11
fix typo

V9 -> V10
metadata xml will be changed to hierarchical structure rather than flat.

V8 -> V9
move meta feature test to src/kimchi/model/config.py
use ElementMaker to construct a metanode.

V7 -> V8
add a feature test to probe libvirt support metadata.
add namespace for manully metadata.

V6 -> V7:
After V6 rebase, still find one error code "KCHVM0029E" does not change. 

V5 -> V6:
rebase

V4 -> V5:
it is wrong to call dom.isPersistent in V4, fix it.

V3 -> V4:
work around if libvirt do not support metadata API well.

V2 -> V3:
move the virDomain.metadata and virDomain.setMetadata to model/utils.py
add testcase

V1 -> V2:
libvirt also support virDomain.metadata and virDomain.setMetadata two api.
use virDomain.metadata to get the user and group.
use virDomain.setMetadata to set the user and group.


ShaoHe Feng (7):
  bug fix: call a method should be followed by "()"
  add method to test libvirt metadata api are available
  Add two function to set and get domain xml metadata
  manually manage the metadata element
  bug fix: get user and group when vm is living.
  update test case to set/get user and group when VM is running
  write the template OS info to vm metadata

 src/kimchi/featuretests.py |  33 +++++++++++-
 src/kimchi/i18n.py         |   1 +
 src/kimchi/model/config.py |   2 +
 src/kimchi/model/utils.py  | 123 +++++++++++++++++++++++++++++++++++++++++++++
 src/kimchi/model/vms.py    | 105 +++++++++++++++++++++++---------------
 tests/test_model.py        |  13 +++++
 6 files changed, 235 insertions(+), 42 deletions(-)

-- 
1.9.0




More information about the Kimchi-devel mailing list