[Kimchi-devel] [PATCH V2 0/4] vmiface update support

[Sheldon]

or I will first support to change persistent configure.

And I will to support a new patch to support to change both live and 
persistent configure later for high lever libvirt version?


On 04/29/2014 11:51 PM, Sheldon wrote:
> It works well on host.
>
> It should be your libvirt does not support to change the guest from 
> one network to another when guest is living.
>
> only high version libvirt supports this feature.
>
> But as we discussed last week. we all think this is a good feature for 
> users.
>
> So do you agree to probe the libvirt support this feature first.
> If libvirt supports it, we allow to change the network live and 
> persistent configure.
> or, we just change the network persistent configure?
>
> On 04/29/2014 04:00 AM, Aline Manera wrote:
>>
>> The tests are failing:
>>
>> ======================================================================
>> ERROR: test_vm_ifaces (test_model.ModelTests)
>> ----------------------------------------------------------------------
>> Traceback (most recent call last):
>> File "/home/alinefm/kimchi/tests/test_model.py", line 190, in 
>> test_vm_ifaces
>> inst.vmiface_update('kimchi-ifaces', mac, iface_args)
>> File "/home/alinefm/kimchi/src/kimchi/model/vmifaces.py", line 148, 
>> in update
>> dom.updateDeviceFlags(xml, flags=conf_flag)
>> File "/home/alinefm/kimchi/src/kimchi/model/libvirtconnection.py", 
>> line 62, in wrapper
>> ret = f(*args, **kwargs)
>> ret = f(*args, **kwargs)
>> File "/home/alinefm/kimchi/src/kimchi/model/libvirtconnection.py", 
>> line 62, in wrapper
>> ret = f(*args, **kwargs)
>> File "/home/alinefm/kimchi/src/kimchi/model/libvirtconnection.py", 
>> line 62, in wrapper
>> ret = f(*args, **kwargs)
>> File "/home/alinefm/kimchi/src/kimchi/model/libvirtconnection.py", 
>> line 62, in wrapper
>> ret = f(*args, **kwargs)
>> File "/home/alinefm/kimchi/src/kimchi/model/libvirtconnection.py", 
>> line 62, in wrapper
>> ret = f(*args, **kwargs)
>> File "/home/alinefm/kimchi/src/kimchi/model/libvirtconnection.py", 
>> line 62, in wrapper
>> ret = f(*args, **kwargs)
>> File "/home/alinefm/kimchi/src/kimchi/model/libvirtconnection.py", 
>> line 62, in wrapper
>> ret = f(*args, **kwargs)
>> File "/home/alinefm/kimchi/src/kimchi/model/libvirtconnection.py", 
>> line 62, in wrapper
>> ret = f(*args, **kwargs)
>> File "/home/alinefm/kimchi/src/kimchi/model/libvirtconnection.py", 
>> line 62, in wrapper
>> ret = f(*args, **kwargs)
>> File "/home/alinefm/kimchi/src/kimchi/model/libvirtconnection.py", 
>> line 62, in wrapper
>> ret = f(*args, **kwargs)
>> File "/home/alinefm/kimchi/src/kimchi/model/libvirtconnection.py", 
>> line 62, in wrapper
>> ret = f(*args, **kwargs)
>> File "/home/alinefm/kimchi/src/kimchi/model/libvirtconnection.py", 
>> line 62, in wrapper
>> ret = f(*args, **kwargs)
>> File "/home/alinefm/kimchi/src/kimchi/model/libvirtconnection.py", 
>> line 62, in wrapper
>> ret = f(*args, **kwargs)
>> File "/home/alinefm/kimchi/src/kimchi/model/libvirtconnection.py", 
>> line 62, in wrapper
>> ret = f(*args, **kwargs)
>> File "/home/alinefm/kimchi/src/kimchi/model/libvirtconnection.py", 
>> line 62, in wrapper
>> ret = f(*args, **kwargs)
>> File "/home/alinefm/kimchi/src/kimchi/model/libvirtconnection.py", 
>> line 62, in wrapper
>> ret = f(*args, **kwargs)
>> File "/home/alinefm/kimchi/src/kimchi/model/libvirtconnection.py", 
>> line 62, in wrapper
>> ret = f(*args, **kwargs)
>> File "/home/alinefm/kimchi/src/kimchi/model/libvirtconnection.py", 
>> line 62, in wrapper
>> ret = f(*args, **kwargs)
>> File "/home/alinefm/kimchi/src/kimchi/model/libvirtconnection.py", 
>> line 62, in wrapper
>> ret = f(*args, **kwargs)
>> File "/home/alinefm/kimchi/src/kimchi/model/libvirtconnection.py", 
>> line 62, in wrapper
>> ret = f(*args, **kwargs)
>> File "/home/alinefm/kimchi/src/kimchi/model/libvirtconnection.py", 
>> line 62, in wrapper
>> ret = f(*args, **kwargs)
>> File "/home/alinefm/kimchi/src/kimchi/model/libvirtconnection.py", 
>> line 62, in wrapper
>> ret = f(*args, **kwargs)
>> File "/home/alinefm/kimchi/src/kimchi/model/libvirtconnection.py", 
>> line 62, in wrapper
>> ret = f(*args, **kwargs)
>> File "/usr/lib/python2.7/dist-packages/libvirt.py", line 1628, in 
>> updateDeviceFlags
>> if ret == -1: raise libvirtError ('virDomainUpdateDeviceFlags() 
>> failed', dom=self)
>> libvirtError: this function is not supported by the connection 
>> driver: cannot modify network device configuration
>>
>> ----------------------------------------------------------------------
>> Ran 158 tests in 201.711s
>>
>> FAILED (errors=1)
>> [28/Apr/2014:16:58:10] ENGINE Waiting for child threads to terminate...
>> make[3]: *** [check-local] Error 1
>> make[3]: Leaving directory `/home/alinefm/kimchi/tests'
>> make[2]: *** [check-am] Error 2
>> make[2]: Leaving directory `/home/alinefm/kimchi/tests'
>> make[1]: *** [check] Error 2
>> make[1]: Leaving directory `/home/alinefm/kimchi/tests'
>> make: *** [check-recursive] Error 1
>>
>>
>> On 04/23/2014 11:41 AM, shaohef at linux.vnet.ibm.com wrote:
>>> From: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
>>>
>>> V1 -> V2
>>> add test case for running VM
>>>
>>> We allow user change the interface from one network to another network
>>> when VM is alive.
>>>
>>> But we only support change the vm configure no matter vm is alive or 
>>> not.
>>>
>>> ShaoHe Feng (4):
>>> vmiface update support: update API.md
>>> vmiface update support: update model.
>>> vmiface update support: update mockmodel
>>> vmiface update support: update test case
>>>
>>> docs/API.md | 8 ++++++++
>>> src/kimchi/API.json | 17 +++++++++++++++++
>>> src/kimchi/control/vm/ifaces.py | 1 +
>>> src/kimchi/i18n.py | 1 +
>>> src/kimchi/mockmodel.py | 12 ++++++++++++
>>> src/kimchi/model/vmifaces.py | 25 +++++++++++++++++++++++++
>>> tests/test_model.py | 20 ++++++++++++++++++++
>>> tests/test_rest.py | 8 ++++++++
>>> 8 files changed, 92 insertions(+)
>>>
>>
>>
>>
>
>


-- 
Thanks and best regards!

Sheldon Feng(冯少合)<shaohef at linux.vnet.ibm.com>
IBM Linux Technology Center