[Kimchi-devel] [PATCHv5 0/7] Support image based template

[Royce Lv]

On 2014年08月01日 04:18, Aline Manera wrote:
> Tests failed.
> I am running on Fedora 20.
>
> ======================================================================
> FAIL: test_create_vm_with_img_based_template (test_rest.HttpsRestTests)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/alinefm/kimchi/tests/test_rest.py", line 889, in 
> test_create_vm_with_img_based_template
> self.assertEquals(1, len(resp))
> AssertionError: 1 != 0
>
> ======================================================================
> FAIL: test_create_vm_with_img_based_template (test_rest.RestTests)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/alinefm/kimchi/tests/test_rest.py", line 889, in 
> test_create_vm_with_img_based_template
> self.assertEquals(1, len(resp))
> AssertionError: 1 != 0
>
> ======================================================================
This is due to my last "filter directory" patch triggered a hidden bug 
in function to_volume_list()
I will fix that one then resubmit.
>
>
> On 07/29/2014 06:01 AM, lvroyce at linux.vnet.ibm.com wrote:
>> From: Royce Lv <lvroyce at linux.vnet.ibm.com>
>>
>> v4>v5,
>> Because '/tmp' used tmpfs, but kimchi used 'cache=none' when create 
>> vm, so when create image
>> on '/tmp' result in create vm fails, fix this error.
>> Also clear some files created in test. (Aline)
>> v3>v4,
>> Aggreated image scanning and name generate logic to vmtemplate.py
>> to avoid duplicate code.
>> Updated testcases accordingly.
>> v2>v3,
>> Clear unused iso link,
>> Adding mockmodel and tests
>>
>> How to test:
>> create a image using:
>> POST /templates {'name':'mytemp', 'disks':[{'base':'a_base_img_path'}]}
>> create a vm using:
>> POST /vms {'template': '/templates/mytemp', 'pool'....}
>>
>> Royce Lv (7):
>> Add image probe function
>> Change doc and api specification
>> Change 'cdrom' to a optional param
>> Fix: Prevent iso links filling in osinfo.py
>> Create volume based on backing store image
>> Update mockmodel of base img vm
>> Add tests for image based template
>>
>> Makefile.am | 1 +
>> contrib/DEBIAN/control.in | 4 +-
>> contrib/kimchi.spec.fedora.in | 2 +
>> contrib/kimchi.spec.suse.in | 2 +
>> docs/API.md | 3 +-
>> docs/README.md | 9 ++-
>> src/kimchi/API.json | 8 ++-
>> src/kimchi/control/storagevolumes.py | 2 +-
>> src/kimchi/control/templates.py | 2 +-
>> src/kimchi/exception.py | 4 ++
>> src/kimchi/i18n.py | 8 ++-
>> src/kimchi/imageinfo.py | 66 ++++++++++++++++++++++
>> src/kimchi/mockmodel.py | 21 +++----
>> src/kimchi/model/templates.py | 12 +---
>> src/kimchi/model/vms.py | 1 +
>> src/kimchi/osinfo.py | 24 +-------
>> src/kimchi/vmtemplate.py | 104 +++++++++++++++++++++++++----------
>> tests/test_mockmodel.py | 12 ++--
>> tests/test_model.py | 31 +++++++++++
>> tests/test_osinfo.py | 8 ---
>> tests/test_rest.py | 44 +++++++++++++--
>> tests/test_vmtemplate.py | 25 ++++++---
>> 22 files changed, 287 insertions(+), 106 deletions(-)
>> create mode 100644 src/kimchi/imageinfo.py
>>
>