[Kimchi-devel] [PATCH v3 0/3] Fix issue #377 (and other repository patches)

Aline Manera alinefm at linux.vnet.ibm.com
Wed Aug 6 20:37:46 UTC 2014


Please, run "make check-local" and fix the problems

src/kimchi/utils.py:284:1: E302 expected 2 blank lines, found 1
src/kimchi/utils.py:285:33: E261 at least two spaces before inline comment
tests/test_model.py:1252:17: E126 continuation line over-indented for 
hanging indent
tests/test_model.py:1255:48: E261 at least two spaces before inline comment
tests/test_model.py:1260:21: E201 whitespace after '{'
tests/test_model.py:1262:33: E201 whitespace after '{'
tests/test_model.py:1262:51: E202 whitespace before '}'
tests/test_model.py:1262:53: E202 whitespace before '}'
tests/test_model.py:1267:21: E201 whitespace after '{'
tests/test_model.py:1268:33: E201 whitespace after '{'
tests/test_model.py:1269:51: E202 whitespace before '}'
tests/test_model.py:1269:53: E202 whitespace before '}'
tests/test_model.py:1332:17: E126 continuation line over-indented for 
hanging indent
tests/test_model.py:1335:48: E261 at least two spaces before inline comment
tests/test_model.py:1340:27: E201 whitespace after '{'
tests/test_model.py:1340:42: E202 whitespace before '}'
tests/test_model.py:1341:80: E501 line too long (92 > 79 characters)
tests/test_model.py:1345:27: E201 whitespace after '{'
tests/test_model.py:1345:39: E201 whitespace after '{'
tests/test_model.py:1345:57: E202 whitespace before '}'
tests/test_model.py:1345:59: E202 whitespace before '}'
tests/test_model.py:1346:80: E501 line too long (92 > 79 characters)
tests/test_rest.py:1808:17: E126 continuation line over-indented for 
hanging indent
tests/test_rest.py:1811:48: E261 at least two spaces before inline comment
tests/test_rest.py:1816:21: E201 whitespace after '{'
tests/test_rest.py:1816:62: E202 whitespace before '}'
tests/test_rest.py:1823:21: E201 whitespace after '{'
tests/test_rest.py:1823:65: E202 whitespace before '}'
tests/test_rest.py:1843:80: E501 line too long (80 > 79 characters)
tests/test_rest.py:1851:80: E501 line too long (80 > 79 characters)
make: *** [check-local] Error 1



On 08/06/2014 04:12 PM, Crístian Viana wrote:
> Changelog from v2:
>
> - Rename one last occurrence of "_validate_repo_url" to the correct name.
>
> Crístian Viana (3):
>    Issue #377: Validate repository URLs
>    typo: Fix "repositorie"
>    repository: Remove error message prefix
>
>   src/kimchi/mockmodel.py                  | 25 ++++++++++++++++---
>   src/kimchi/repositories.py               | 11 +++++++++
>   src/kimchi/utils.py                      | 15 ++++++++++++
>   tests/test_model.py                      | 42 ++++++++++++++++++++++++++++++--
>   tests/test_rest.py                       | 41 +++++++++++++++++++++++++++++--
>   ui/js/src/kimchi.repository_add_main.js  |  3 +--
>   ui/js/src/kimchi.repository_edit_main.js |  3 +--
>   ui/pages/i18n.json.tmpl                  |  1 -
>   8 files changed, 129 insertions(+), 12 deletions(-)
>




More information about the Kimchi-devel mailing list