[Kimchi-devel] [RFC] ISO pool: Support to download ISO from URL

[Aline Manera]

On 08/19/2014 05:20 PM, Crístian Viana wrote:
> On 19-08-2014 16:17, Aline Manera wrote:
>> We can use "url" for download and "file" for upload.
>
> What if  both parameters are provided?

Raise an error.

keys = params.keys()
if "url" in keys and "url" in keys:
     raise InvalidParameter()

if url in keys:
     return self.download

if file in keys:
     return self.upload()


>
>> if "url" in params.keys():
>>     self.download()
>> elif "file" in params.keys():
>>     self.upload()
>
> According to this code, the parameter 'url' overrides 'file'. Should 
> we consider that behavior?