[Kimchi-devel] [PATCH 2/2] Issue #405 - Fix enter hit in storage tab under guest edit window

Rodrigo Trujillo rodrigo.trujillo at linux.vnet.ibm.com
Fri Aug 22 15:47:23 UTC 2014


If user goes to storage tab in edit guest window, whenever he focuses
a input boxes (any device name or path) and press ENTER, the default
behaviour is trigger a "click" event in the first window button. In this
case, the "Attach new storage" window is opened. This patch fixes this
problem, so, when user press ENTER, nothing happens.

Signed-off-by: Rodrigo Trujillo <rodrigo.trujillo at linux.vnet.ibm.com>
---
 ui/pages/guest-edit.html.tmpl | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/ui/pages/guest-edit.html.tmpl b/ui/pages/guest-edit.html.tmpl
index ed7ddeb..8870429 100644
--- a/ui/pages/guest-edit.html.tmpl
+++ b/ui/pages/guest-edit.html.tmpl
@@ -100,7 +100,7 @@
                 <div class="header">
                     <span class="cell">$_("Device")</span>
                     <span class="cell">$_("Path")</span>
-                    <button id="guest-edit-attach-cdrom-button" class="action-area attach"></button>
+                    <button type="button" id="guest-edit-attach-cdrom-button" class="action-area attach"></button>
                 </div>
                 <div class="body"></div>
             </form>
@@ -164,19 +164,19 @@
                 value="{path}" readonly="readonly" />
         </span>
         <span class="action-area">
-            <button class="guest-edit-cdrom-button replace"
+            <button type="button" class="guest-edit-cdrom-button replace"
                 data-vm="{vm}" data-dev="{dev}"
                 title='$_("Replace")'>
             </button>
-            <button class="guest-edit-cdrom-button detach"
+            <button type="button" class="guest-edit-cdrom-button detach"
                 data-vm="{vm}" data-dev="{dev}" data-type="{type}"
                 title='$_("Detach")'>
             </button>
-            <button class="guest-edit-cdrom-button save hidden"
+            <button type="button" class="guest-edit-cdrom-button save hidden"
                 data-vm="{vm}" data-dev="{dev}"
                 title='$_("Save")'>
             </button>
-            <button class="guest-edit-cdrom-button cancel hidden"
+            <button type="button" class="guest-edit-cdrom-button cancel hidden"
                 data-vm="{vm}" data-dev="{dev}"
                 title='$_("Cancel")'>
             </button>
@@ -212,7 +212,7 @@
                 value="{path}" readonly="readonly" />
         </span>
         <span class="action-area">
-            <button class="guest-edit-cdrom-button detach"
+            <button type="button" class="guest-edit-cdrom-button detach"
                 data-vm="{vm}" data-dev="{dev}" data-type="{type}"
                 title="$_("Detach")">
             </button>
-- 
1.9.3




More information about the Kimchi-devel mailing list