[Kimchi-devel] [PATCH V6 0/1] Open 8000 and 8001 port by default for distro packages

[Aline Manera]

After doing some tests in all supported distros I got the following:

*RHEL 6.5*
[root at rhel-vm kimchi]# rpm -ivh 
/root/kimchi/rpm/RPMS/x86_64/kimchi-1.1.0-41.git383a830.el6.x86_64.rpm
Preparing... ########################################### [100%]
    1:kimchi ########################################### [100%]
kimchid start/running, process 11043
iptables: Saving firewall rules to /etc/sysconfig/iptables: [  OK ]

We should not show the firewall message


*Fedora 19*
[root at localhost kimchi]# rpm -ivh 
/root/kimchi/rpm/RPMS/x86_64/kimchi-1.1.0-31.git3e009ce.fc19.x86_64.rpm
Preparing... ################################# [100%]
Updating / installing...
    1:kimchi-1.1.0-31.git3e009ce.fc19 ################################# 
[100%]
Redirecting to /bin/systemctl start kimchid.service
success
success

We should not show the 'sucess' messages above. I think it is related to 
firewall commands.

*Ubuntu 13.10*
alinefm at alinefm-virtual-machine:~/kimchi$ sudo dpkg -i 
kimchi-1.1.0-41.git1adc776.noarch.deb
Selecting previously unselected package kimchi.
(Reading database ... 171601 files and directories currently installed.)
Unpacking kimchi (from kimchi-1.1.0-41.git1adc776.noarch.deb) ...
Setting up kimchi (1.1.0) ...
kimchid start/running, process 3351
FirewallD is not running
dpkg: error processing kimchi (--install):
  subprocess installed post-installation script returned error exit 
status 252
Processing triggers for ureadahead ...
Errors were encountered while processing:
  kimchi

I got the following error because firewalld service wasn't running
So I start the service manually

alinefm at alinefm-virtual-machine:~/kimchi$ sudo service firewalld status
  * firewalld is not running
alinefm at alinefm-virtual-machine:~/kimchi$ sudo service firewalld start
  * Starting dynamic firewall daemon firewalld

Then I tried to install kimchi again and I got a new error and I wasn't 
able to install kimchi.

alinefm at alinefm-virtual-machine:~/kimchi$ sudo dpkg -i 
kimchi-1.1.0-41.git1adc776.noarch.deb
Selecting previously unselected package kimchi.
(Reading database ... 171601 files and directories currently installed.)
Unpacking kimchi (from kimchi-1.1.0-41.git1adc776.noarch.deb) ...
Setting up kimchi (1.1.0) ...
kimchid start/running, process 4592
success
Error: INVALID_SERVICE: kimchid
dpkg: error processing kimchi (--install):
  subprocess installed post-installation script returned error exit 
status 101
Processing triggers for ureadahead ...
Errors were encountered while processing:
  kimchi

So I noticed the /usr/lib/firewalld/services/kimchid.xml file wasn't 
installed

alinefm at alinefm-virtual-machine:~/kimchi$ dpkg --contents 
kimchi-1.1.0-41.git1adc776.noarch.deb | grep kimchid
-rwxr-xr-x root/root      3370 2014-01-03 11:46 ./usr/bin/kimchid
-rw-r--r-- root/root      1056 2014-01-03 11:46 ./etc/init/kimchid.conf

You need to update Makefile.am, "deb" target to install the file in the 
correct location.


On 01/03/2014 01:11 AM, taget at linux.vnet.ibm.com wrote:
> From: Eli Qiao <taget at linux.vnet.ibm.com>
>
>      V6 -V5 changes:
>      1.Keep specific condition for RHEL6 when starting kimchid service
>      2.Remove full path of firewall-cmd in postrm
>
>      V5 - V4 changes:
>      1. Add cover-letter. (Aline)
>      2. Move clean up rules into if condition. (Aline)
>      3. Use with_systemd condition to check if use firewalld rules. (Aline)
>      4. Fix typo (Aline)
>
>      V4 - V3 changes:
>      1 Fix typo in firewalld.xml (Rodrigo)
>
>      V3 - V2 changes:
>
>      1.Rename kimchid.xml to firewalld.xml (Mark)
>      2.Remove firewalld from serivce require (Mark)
>      3.Fix typo
>
>      V2 - V1 changes:
>
>      1.Add firewalld sevice configure file kimchid.xml to help open iptables port (Mark)
>      2.Add Ubuntu iptables rule (Royce)
>
>
> Eli Qiao (1):
>    spec: Open 8000 and 8001 port by default
>
>   contrib/DEBIAN/control.in     |    3 ++-
>   contrib/DEBIAN/postinst       |    2 ++
>   contrib/DEBIAN/postrm         |    2 ++
>   contrib/kimchi.spec.fedora.in |   22 ++++++++++++++++++++++
>   contrib/kimchi.spec.suse.in   |   10 ++++++++--
>   src/Makefile.am               |    1 +
>   src/firewalld.xml             |    7 +++++++
>   7 files changed, 44 insertions(+), 3 deletions(-)
>   create mode 100644 src/firewalld.xml
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20140103/95bd0a7b/attachment.html>