[Kimchi-devel] [PATCH V5 0/5] Add spice backend support for kimchi

Royce Lv lvroyce at linux.vnet.ibm.com
Tue Jan 14 06:20:25 UTC 2014


Aline,
I think this is ready to merge, could you pls take a look?

On 2014年01月10日 20:44, apporc wrote:
> v5-v4:
>      1.  Rebase to upstream
>      2.  Change the code to coordinate with new websockify mechanism
>      3.  Add test code for ipv6 (Thanks Aline)
>
> v4-v3:
>      1.  Remove not used module "copy" in vmtemplate.py(Thanks Aline)
>      2.  Fix alignment problem in model.py(Thanks Aline)
>      3.  Use type property of jsonschema to validate both ipv4 and ipv6(Thanks Aline)
>          REF: http://stackoverflow.com/questions/14550235/json-schema-away-to-specify-an-any-type-schema-with-certain-required-fields
>      4.  Use "$ref" to simply API.json, remove dumplicate content(Thanks Rodrigo)
>
> v3-v2:
>      1.  Rebase  to upstream
>      2.  Improve/simplify some code according to reviewers' advice(Thanks Royce, Markwu and Aline).
>      3.  Reimplement parameters validation using jsonschema.
>      4.  Remove unnecessary test code in model.py.
>      5.  Split patch to several smaller commits according to logic(Thanks Royce).
>
> v2-v1:  Rebased to upstream and resend
>
> v1: Add spice backend support for kimchi
>
> apporc (5):
>    Add spice backend support for kimchi
>    Validate graphics parameters input by users
>    Update mockmodel for spice support
>    Update test case for graphics support
>    Add graphics parameters description in API.md
>
>   docs/API.md                     |   43 ++++++++++++++-
>   src/kimchi/API.json             |   30 +++++++++--
>   src/kimchi/control/templates.py |    6 ++-
>   src/kimchi/control/utils.py     |    4 +-
>   src/kimchi/control/vms.py       |    4 +-
>   src/kimchi/mockmodel.py         |   13 +++--
>   src/kimchi/model.py             |   34 +++++++-----
>   src/kimchi/osinfo.py            |    7 +--
>   src/kimchi/vmtemplate.py        |   31 ++++++++++-
>   tests/test_mockmodel.py         |    2 +
>   tests/test_model.py             |   27 +++++++++-
>   tests/test_rest.py              |  111 +++++++++++++++++++++++++++++++++++++--
>   tests/test_vmtemplate.py        |   40 ++++++++++++--
>   13 files changed, 313 insertions(+), 39 deletions(-)
>




More information about the Kimchi-devel mailing list