[Kimchi-devel] [PATCH 3/3] Plugins: Fix sample plugin

[Aline Manera]

Reviewed-by: Aline Manera <alinefm at linux.vnet.ibm.com>

A comment below

On 01/14/2014 02:17 PM, Rodrigo Trujillo wrote:
> The sample plugin needed some modifications to work properly with
> Kimchi tabs. This patch also disables it.
>
> Signed-off-by: Rodrigo Trujillo <rodrigo.trujillo at linux.vnet.ibm.com>
> ---
>   plugins/sample/sample.conf           | 2 +-
>   plugins/sample/ui/config/tab-ext.xml | 6 +++---
>   plugins/sample/ui/tab.html           | 1 +
>   3 files changed, 5 insertions(+), 4 deletions(-)
>   create mode 100644 plugins/sample/ui/tab.html
>
> diff --git a/plugins/sample/sample.conf b/plugins/sample/sample.conf
> index c4e80f7..2f28f50 100644
> --- a/plugins/sample/sample.conf
> +++ b/plugins/sample/sample.conf
> @@ -1,5 +1,5 @@
>   [kimchi]
> -enable = True
> +enable = False
>   plugin_class = "Drawings"
>   uri = "/plugins/sample"

This is the cherrypy config file for the plugin.
So if in addition to tabs.xml file more files/dir should be exposed, you 
need to add the config here.

> diff --git a/plugins/sample/ui/config/tab-ext.xml b/plugins/sample/ui/config/tab-ext.xml
> index 948fa07..b040058 100644
> --- a/plugins/sample/ui/config/tab-ext.xml
> +++ b/plugins/sample/ui/config/tab-ext.xml
> @@ -1,7 +1,7 @@
>   <?xml version="1.0" encoding="utf-8"?>
> -<!--<tabs-ext>
> +<tabs-ext>
>       <tab>
>           <title>Test</title>
> -        <filePath>plugins/sample/ui/tab.html</filePath>
> +        <path>plugins/sample/ui/tab.html</path>
>       </tab>
> -</tabs-ext>-->
> \ No newline at end of file
> +</tabs-ext>
> diff --git a/plugins/sample/ui/tab.html b/plugins/sample/ui/tab.html
> new file mode 100644
> index 0000000..3cf7988
> --- /dev/null
> +++ b/plugins/sample/ui/tab.html
> @@ -0,0 +1 @@
> +Test tab for sample plugin.