[Kimchi-devel] [PATCH] Abstract vm element updater for common usage

[Crístian Viana]

Am 17-01-2014 12:06, schrieb lvroyce0210 at gmail.com:
> +        raise OperationFailed('Unsupported vm element type: %s' % elemArgs['type'])
This line is longer than 80 characters. Please keep it shorter than that.

> +        """Live update domain with correspondant libvirt API.
> +        This should be paired with cancel() operation to cancel failed update."""
This line is longer than 80 characters. Please keep it shorter than that.

> +        raise OperationFailed('Update param generater is not implemented: %s' % self)
This line is longer than 80 characters. Please keep it shorter than that.
> +        self.dom.attachDeviceFlags(xml=self._update_param['xml'],
> +            flags=libvirt.VIR_DOMAIN_AFFECT_CURRENT|libvirt.VIR_DOMAIN_AFFECT_CONFIG)
This line is longer than 80 characters. Please keep it shorter than that.
Also, the second line should be aligned to the beginning of the 
parameter list on the first line (i.e. "flags=" should be right below 
"xml=").
> +    def delete_from_vm(self):
> +        self.dom.detachDeviceFlags(xml=self._update_param['xml'],
> +            flags=libvirt.VIR_DOMAIN_AFFECT_CURRENT|libvirt.VIR_DOMAIN_AFFECT_CONFIG)
This line is longer than 80 characters. Please keep it shorter than that.
Also, the second line should be aligned to the beginning of the 
parameter list on the first line (i.e. "flags=" should be right below 
"xml=").