[Kimchi-devel] [PATCH 0/4] improve controller

Aline Manera alinefm at linux.vnet.ibm.com
Mon Jan 20 16:46:31 UTC 2014


In addition to comments made on patches, I would like to ask you to 
improve the commit description.
In many of them you are just repeating the commit title.
Use the commit description to describe with details why the patch is 
needed and important and what it does.

On 01/20/2014 04:00 AM, shaohef at linux.vnet.ibm.com wrote:
> From: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
>
> add a method to load root sub collections/resouces automatically
>
> ShaoHe Feng (4):
>    improve controller: add a method to load root sub collections/resouces
>      automatically
>    improve controller: tag the collections/resouces of root with
>      @urlSubNode
>    improve controller: Root loads collections/resouces automatically
>    improve controller: set authentication automatically
>
>   src/kimchi/control/__init__.py     |  8 ++++++++
>   src/kimchi/control/config.py       |  2 ++
>   src/kimchi/control/debugreports.py |  2 ++
>   src/kimchi/control/host.py         |  2 ++
>   src/kimchi/control/interfaces.py   |  2 ++
>   src/kimchi/control/networks.py     |  2 ++
>   src/kimchi/control/plugins.py      |  2 ++
>   src/kimchi/control/storagepools.py |  2 ++
>   src/kimchi/control/tasks.py        |  2 ++
>   src/kimchi/control/templates.py    |  2 ++
>   src/kimchi/control/vms.py          |  2 ++
>   src/kimchi/root.py                 | 26 +++++--------------------
>   src/kimchi/server.py               | 12 +++++-------
>   src/kimchi/utils.py                | 39 ++++++++++++++++++++++++++++++++++++++
>   14 files changed, 77 insertions(+), 28 deletions(-)
>




More information about the Kimchi-devel mailing list