[Kimchi-devel] [PATCH 3/5] Issue #310: Query correct name to validate logical devices

[Aline Manera]

Reviewed-by: Aline Manera <alinefm at linux.vnet.ibm.com>

On 01/20/2014 08:09 PM, Crístian Viana wrote:
> The dialog to create a new logical storage pool must validate the user
> input by checking if they selected at least one of the available
> devices. However, the code is looking for checkboxes with a non-existing
> element name and it is always reporting that the user did not select any of
> them - even when they do. Therefore, it is impossible to create a
> logical storage pool.
>
> Change the HTML element name of the devices' checkboxes on the storage pool
> page to match the validation algorithm. Instead of "source.devices", use
> the name "devices" on those elements.
>
> Signed-off-by: Crístian Viana <vianac at linux.vnet.ibm.com>
> ---
>   ui/pages/storagepool-add.html.tmpl | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/pages/storagepool-add.html.tmpl b/ui/pages/storagepool-add.html.tmpl
> index e8dac43..03c063d 100644
> --- a/ui/pages/storagepool-add.html.tmpl
> +++ b/ui/pages/storagepool-add.html.tmpl
> @@ -143,7 +143,7 @@
>       </script>
>       <script id="partitionTmpl" type="html/text">
>           <div>
> -            <input type="checkbox" value="{path}" name="source.devices">
> +            <input type="checkbox" value="{path}" name="devices">
>               <label>{path}</label>
>           </div>
>       </script>