[Kimchi-devel] [PATCHv8 8/8] storage target: Add model support

Crístian Viana vianac at linux.vnet.ibm.com
Tue Jan 21 12:31:44 UTC 2014


Am 19-01-2014 13:28, schrieb lvroyce0210 at gmail.com:
> +            try:
> +                ret = conn.findStoragePoolSources(target_type, xml, 0)
> +            except libvirt.libvirtError as e:
> +                kimchi_log.warning("Query storage pool source fails because of %s",
> +                    e.get_error_message())
> +                continue
Please align the second line of "kimchi.log.warning" to the beginning of 
the parameter list in order to be consistent with our code guidelines 
(i.e. "e.get_error_message" should start right below "Query ...").




More information about the Kimchi-devel mailing list