[Kimchi-devel] [PATCH 1/4] pep8: Reorder import statements

Crístian Viana vianac at linux.vnet.ibm.com
Wed Jan 22 20:58:45 UTC 2014


Thanks for your review!

Am 20-01-2014 13:29, schrieb Aline Manera:
> PAM is also a third-party module. It comes in PyPAM/python-pam package
> psutil is also a third-party module. It comes in python-psutil package
Ack. Judging by their names, I thought they were part of the standard 
library.

> disks is a kimchi module. So it should be "from kimchi import disks" 
> sscert is a kimchi module. So it should be "from kimchi import sslcert"
Ack. I couldn't tell they were Kimchi modules because they didn't start 
with "kimchi."

I'm preparing a new and rebased patchset.




More information about the Kimchi-devel mailing list