[Kimchi-devel] [PATCH V4] Issue#305: Redesign bridged network UI section

[Zhou Zheng Sheng]

on 2014/06/05 20:59, Aline Manera wrote:
> On 06/05/2014 04:46 AM, Zhou Zheng Sheng wrote:
>> on 2014/06/05 15:41, Sheldon wrote:
>>> On 06/04/2014 08:41 AM, Aline Manera wrote:
>>>> Hi Wen Wang!
>>>> Thanks for the patch! The UI looks better now but I still have some
>>>> suggestions to make:
>>>>
>>>>
>>>>
>>>>
>>>> In the red are you can see those 2 fields are redundant.
>>>> We can only have the input box to collect the VLAN ID from user. If
>>>> the input
>>>> box is empty
>>>> (without any value) means the user does not want to set enable VLAN.
>>>> Otherwise
>>>> we get the value
>>>> and set it as the VLAN ID.
>>>>
>>>> So the fields to create a "Bridged" network are "Destination" (a
>>>> combo box)
>>>> and "VLAN ID" (an input box).
>>> I have checked this with Mark.
>>> He is the original designer of this VLAN ID.
>>>
>>> we think the check box is used to tell the user that he want to
>>> enable vlan.
>>> the vlan is disabled by default.
>>> check box is more explicitly to show enable/disable.
>>>
>>> just one input, usually user do not know input can imply
>>> enable/disable function.
>>>
>> For the check box part, I agree. Don't make the user think. A check box
>> disabled by default is more vivid. A naked VLAN ID input box is strange
>> by the first impression, and if it's with long explanation label, it is
>> tedious.
> 
> Ok. For good of all let's keep the check box. =)
> 
> BUT I still have a suggestion:
> 
> Destination:  |_______________________|
> [ ] Enable VLAN
> 
> And **if and only if** the check box is checked the input box to collect
> the VLAN ID is displayed.
> 
> 
> Destination: |_______________________|
> [x] Enable VLAN
> VLAN ID:      |_______________________|
> 
> Agree?
> 

Yes. I would be very nice!