[Kimchi-devel] [PATCH V5 0/2] Issue#296 UI redesign when generating debug reports

Aline Manera alinefm at linux.vnet.ibm.com
Fri Jun 6 16:58:45 UTC 2014


Almost there... =)

I have 2 comments:

1) Add a margin to grid content
    The name and date are too close to the table columns.

2) When the debug report creation failed, an error is displayed on top 
of page
    But the grid keeps showing "Pending..." and "Generating..."
    You should remove that line after the error.


On 06/05/2014 07:09 AM, Wang Wen wrote:
> Issue#296 debug report: kimchi UI should not waiting while generating reports
>
> V4 -> V5
> Deleted one useless line that change the loading icon's size
>
> V3 -> V4
> Changed generating logo(Hong Liang Wang)
>
> V2 -> V3
> Change the layout of the grid: Removed the frist column that has line number
> Changed the progress bar layout that make the whole table more consistant.
>
> V1 -> V2
> Accroding to Yu Xin, this patch move the progress bar to the top of the
> grid and use ellipsis for hiding the name that is too long for the
> generating progress bar.
>
> 1) Removed the dialogue window when generating a debug report.
> 2) Designed an animation bar indicate user there is a report generating
>     during the generating progress.
> 3) Disable the buttons' functions in debug report area when generating a new
>     report in case there might be any conflict. Meanwhile user can operate
>     on other parts of Kimchi.
> 4) Enable all buttonss' functions in debug report area after generating
>     progress.
>
> Wang Wen (2):
>    Remove the first column of debug report grid
>    Added the generating progress indicator
>
>   ui/css/theme-default/host.css                   |   10 +++++---
>   ui/css/theme-default/report-add.css             |    9 +-------
>   ui/images/theme-default/kimchi-loading.gif      |  Bin 6181 -> 6181 bytes
>   ui/images/theme-default/kimchi-loading15x15.gif |  Bin 0 -> 1653 bytes
>   ui/js/src/kimchi.host.js                        |    6 +----
>   ui/js/src/kimchi.report_add_main.js             |   26 ++++++++++++++++++----
>   ui/pages/i18n.html.tmpl                         |    1 +
>   7 files changed, 30 insertions(+), 22 deletions(-)
>   create mode 100644 ui/images/theme-default/kimchi-loading15x15.gif
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>




More information about the Kimchi-devel mailing list