[Kimchi-devel] [PATCH] bug fix: accept '-' & '_' for network name.

Crístian Viana vianac at linux.vnet.ibm.com
Thu Jun 12 13:09:20 UTC 2014


On 12-06-2014 08:19, shaohef at linux.vnet.ibm.com wrote:
> From: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
>
> Both '-' and '_' are allowed by libvirt,  so we should not put extra
> restrictions.
>
I don't think this patch is valid because libvirt support any name as a 
network name (and VM name, storage pool name...). If we're actually not 
putting extra restrictions, let the user type anything for the network 
name that's also valid in libvirt (i.e. spaces, special characters).

You can even have Chinese/Japanese/Korean characters in network names:

$ sudo virsh net-list
Name State Autostart Persistent
----------------------------------------------------------
default active yes yes
크리스티안 active no no




More information about the Kimchi-devel mailing list