[Kimchi-devel] [PATCH v3 0/4] Fix: Report Overwritten when Provided Name Existing

[Hongliang Wang]

On 06/15/2014 12:08 AM, Aline Manera wrote:
> On 06/14/2014 10:24 AM, Hongliang Wang wrote:
>>
>> On 06/13/2014 08:21 PM, Aline Manera wrote:
>>>
>>> When I entered an existent debug report name, the screen blinks to 
>>> display the error message
>>> Is there a way to fix it?
>> So you mean it's too short to see the whole message before it 
>> disappears? It's really a problem for long messages. Let me send 
>> another patch to make the time length configurable.
>
> No.
> I mean, to the error be displayed the screen blinks.
>
> 1) Select generate a new debug report
> 2) A pop-up will be shown
> 3) Enter an existent name for the debug report
> 4) The screen will blink (like a reload page) then the error message 
> is shown
ACK.
>
>>>
>>> On 06/13/2014 06:16 AM, Hongliang Wang wrote:
>>>> When user provides an existing debug report name, then the server 
>>>> will generate
>>>> a new debug report and overwrite the old one.
>>>>    Fixed it in this patch to detect the existing name and ask the 
>>>> user to choose
>>>> another name.
>>>>
>>>> v2 -> v3:
>>>>    3a) Reduced code redundant
>>>>        (Wen Wang's comment)
>>>>
>>>> v1 -> v2:
>>>>    2a) Recovered Generate Button behavior
>>>>        (Wen Wang's comment)
>>>>    2b) Leveraged get_list() function to check name existence
>>>>        (Aline's comment)
>>>>
>>>> Hongliang Wang (4):
>>>>    Add ResourceAlreadyExists Exception (HTTP 409)
>>>>    Add Name Existence Check for Debug Report when Create
>>>>    Add License Statement in kimchi.report_add_main.js
>>>>    Implement UI Part to Properly Handle Report Name Existence
>>>>
>>>>   src/kimchi/control/base.py          |  4 +-
>>>>   src/kimchi/exception.py             |  4 ++
>>>>   src/kimchi/i18n.py                  |  1 +
>>>>   src/kimchi/model/debugreports.py    |  5 +-
>>>>   ui/js/src/kimchi.report_add_main.js | 97 
>>>> +++++++++++++++++++++++--------------
>>>>   5 files changed, 73 insertions(+), 38 deletions(-)
>>>>
>>>
>>
>