[Kimchi-devel] [PATCH v4 0/4] Fix: Report Overwritten when Provided Name Existing

Hongliang Wang hlwang at linux.vnet.ibm.com
Tue Jun 17 08:37:36 UTC 2014


When user provides an existing debug report name, then the server will generate
a new debug report and overwrite the old one.
  Fixed it in this patch to detect the existing name and ask the user to choose
another name.

v3 -> v4:
  4a) Switched to InvalidParameter instead of new ResourceAlreadyExists
      (Aline's comment)
  4b) Fixed screen blink problem
      (Aline's comment)

v2 -> v3:
  3a) Reduced code redundant
      (Wen Wang's comment)

v1 -> v2:
  2a) Recovered Generate Button behavior
      (Wen Wang's comment)
  2b) Leveraged get_list() function to check name existence
      (Aline's comment)

Hongliang Wang (4):
  Add Name Existence Check for Debug Report when Create
  Add License Statement in kimchi.report_add_main.js
  Add progress Event Handler for Asynchronized Tasks
  Keep User from Generating a Report with an Existing Name

 src/kimchi/i18n.py                  |   1 +
 src/kimchi/model/debugreports.py    |   5 +-
 ui/js/src/kimchi.api.js             |   3 +-
 ui/js/src/kimchi.report_add_main.js | 105 +++++++++++++++++++++++-------------
 4 files changed, 74 insertions(+), 40 deletions(-)

-- 
1.8.1.4




More information about the Kimchi-devel mailing list