[Kimchi-devel] [PATCH V3 0/2] bug fix: redirect to the protected page after login

Thu Jun 26 19:35:05 UTC 2014

The tests are failing:

======================================================================
FAIL: test_accepts (test_rest.HttpsRestTests)
----------------------------------------------------------------------
Traceback (most recent call last):
   File "/home/alinefm/kimchi/tests/test_rest.py", line 134, in test_accepts
     self.assertTrue('<!doctype html>' in resp.read().lower())
AssertionError: False is not true

======================================================================
FAIL: test_accepts (test_rest.RestTests)
----------------------------------------------------------------------
Traceback (most recent call last):
   File "/home/alinefm/kimchi/tests/test_rest.py", line 134, in test_accepts
     self.assertTrue('<!doctype html>' in resp.read().lower())
AssertionError: False is not true

======================================================================
FAIL: test_server_start (test_server.ServerTests)
----------------------------------------------------------------------
Traceback (most recent call last):
   File "/home/alinefm/kimchi/tests/test_server.py", line 41, in 
test_server_start
     self.assertEquals(200, resp.status)
AssertionError: 200 != 303

----------------------------------------------------------------------
Ran 159 tests in 155.488s

FAILED (failures=3, skipped=2)
[26/Jun/2014:16:19:06] ENGINE Waiting for child threads to terminate...
make[3]: *** [check-local] Error 1
make[3]: Leaving directory `/home/alinefm/kimchi/tests'
make[2]: *** [check-am] Error 2
make[2]: Leaving directory `/home/alinefm/kimchi/tests'
make[1]: *** [check] Error 2
make[1]: Leaving directory `/home/alinefm/kimchi/tests'
make: *** [check-recursive] Error 1

On 06/20/2014 07:15 AM, shaohef at linux.vnet.ibm.com wrote:
> From: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
>
> V2 -> V3:
> rebase
>
> V1 -> V2:
> remove kimchisession hook
>
> ShaoHe Feng (2):
>    bug fix: redirect to the protected page after login
>    remove kimchisession hook and add the same logic to root.get
>
>   src/kimchi/auth.py       | 31 ++++++++++++-------------------
>   src/kimchi/config.py.in  |  5 -----
>   src/kimchi/root.py       | 40 +++++++++++++++++++++++++---------------
>   src/kimchi/server.py     |  2 --
>   tests/test_config.py.in  |  8 --------
>   ui/pages/login.html.tmpl |  3 ++-
>   6 files changed, 39 insertions(+), 50 deletions(-)
>