[Kimchi-devel] [PATCH] UI: Clone Guest

[Crístian Viana]

On 20-10-2014 07:56, huoyuxin at linux.vnet.ibm.com wrote:

> +                <div class="guest-clone hide-content">
> +                    <span class="icon"></span><span class="text">$_("Cloning") ...</span>
> +                </div>

Instead of "Cloning ...", it should be "Cloning..." (notice the space 
between the text and the ellipsis).

> +                            <button class="button-big running-hidden" name="vm-clone"><span class="text">$_("Clone")</span></button>

I think it's better to use the class "running-disabled" instead of 
"running-hidden". At least the user knows there's a clone operation but 
it's not available at the moment, when the VM is running.

Also, I cannot see a message when an error is raised inside the task. 
The cloning VM simply disappears (which is correct) and nothing else is 
shown. You can check the field 'message' in the task output, and if it 
has the value 'failed', display the field 'message' as an error.